AbdelChoufani commited on
Commit
4ec61f7
ยท
1 Parent(s): 31d88dd

Fix indentation and exception pairing in create_3d_model

Browse files
Files changed (1) hide show
  1. app.py +11 -6
app.py CHANGED
@@ -183,11 +183,14 @@ def save_3d_model(scene: trimesh.Scene, filename: str) -> bool:
183
  """Export the 3D scene to a GLB file."""
184
  try:
185
  scene.export(filename)
186
- return os.path.exists(filename)
187
- print("๐Ÿ’พ wrote file?", os.path.exists(filename))
188
- print("๐Ÿ’พ filesize:", os.path.getsize(filename) if os.path.exists(filename) else "n/a")
 
 
189
 
190
- except Exception:
 
191
  return False
192
 
193
 
@@ -230,11 +233,13 @@ def generate_3d_model(latitude: float, longitude: float, radius: int) -> Tuple[s
230
 
231
  if len(scene.geometry) == 0:
232
  return None, "โŒ Could not create 3D model from the buildings found.", ""
233
-
234
- # Step 4: Save model
235
  timestamp = int(time.time())
236
  filename = f"osm_3d_model_{timestamp}.glb"
237
 
 
 
 
238
  status_msg += f"\nโœ… 3D model created with {len(scene.geometry)} buildings\n๐Ÿ’พ Saving model..."
239
 
240
  if save_3d_model(scene, filename):
 
183
  """Export the 3D scene to a GLB file."""
184
  try:
185
  scene.export(filename)
186
+ file_exists = os.path.exists(filename)
187
+ print("๐Ÿ’พ wrote file?", file_exists)
188
+ if file_exists:
189
+ print("๐Ÿ’พ filesize:", os.path.getsize(filename))
190
+ return file_exists
191
 
192
+ except Exception as e:
193
+ print(f"โŒ Error saving 3D model: {e}")
194
  return False
195
 
196
 
 
233
 
234
  if len(scene.geometry) == 0:
235
  return None, "โŒ Could not create 3D model from the buildings found.", ""
236
+ # Step 4: Save model
 
237
  timestamp = int(time.time())
238
  filename = f"osm_3d_model_{timestamp}.glb"
239
 
240
+ # Ensure we can write to the current directory
241
+ os.makedirs(os.path.dirname(os.path.abspath(filename)) if os.path.dirname(filename) else ".", exist_ok=True)
242
+
243
  status_msg += f"\nโœ… 3D model created with {len(scene.geometry)} buildings\n๐Ÿ’พ Saving model..."
244
 
245
  if save_3d_model(scene, filename):