Updated settings

src/settings.py

@@ -105,12 +105,8 @@ class Settings:
     
     def _get_default_config_file(self) -> str:
         """Get default configuration file path"""
-        # Use writable config directory
-        running_on_hf = os.environ.get("HF_SPACE") == "1" or os.environ.get("SPACE_ID")
-        if running_on_hf:
-            config_dir = os.environ.get('CONFIG_DIR', '/data/researchmate/config')
-        else:
-            config_dir = os.environ.get('CONFIG_DIR', './tmp/researchmate/config')
+        # Use writable config directory with fallback
+        config_dir = os.environ.get('CONFIG_DIR', './tmp/researchmate/config')
         return str(Path(config_dir) / "settings.json")
     
     def _load_config(self):
@@ -147,12 +143,8 @@ class Settings:
         self.server.workers = int(os.getenv("WORKERS", self.server.workers))
         self.server.log_level = os.getenv("LOG_LEVEL", self.server.log_level)
         
-        # Database configuration - USE ENVIRONMENT VARIABLE
-        running_on_hf = os.environ.get("HF_SPACE") == "1" or os.environ.get("SPACE_ID")
-        if running_on_hf:
-            self.database.chroma_persist_dir = os.getenv("CHROMA_DIR", "/data/researchmate/chroma_persist")
-        else:
-            self.database.chroma_persist_dir = os.getenv("CHROMA_DIR", "./tmp/researchmate/chroma_persist")
+        # Database configuration - USE ENVIRONMENT VARIABLE with fallback
+        self.database.chroma_persist_dir = os.getenv("CHROMA_DIR", "./tmp/researchmate/chroma_persist")
         self.database.collection_name = os.getenv("COLLECTION_NAME", self.database.collection_name)
         self.database.similarity_threshold = float(os.getenv("SIMILARITY_THRESHOLD", self.database.similarity_threshold))
         self.database.max_results = int(os.getenv("MAX_RESULTS", self.database.max_results))
@@ -163,23 +155,14 @@ class Settings:
         self.ai_model.max_tokens = int(os.getenv("MAX_TOKENS", self.ai_model.max_tokens))
         self.ai_model.timeout = int(os.getenv("MODEL_TIMEOUT", self.ai_model.timeout))
         
-        # Upload configuration - USE ENVIRONMENT VARIABLES
+        # Upload configuration - USE ENVIRONMENT VARIABLES with fallback
         self.upload.max_file_size = int(os.getenv("MAX_FILE_SIZE", self.upload.max_file_size))
-        running_on_hf = os.environ.get("HF_SPACE") == "1" or os.environ.get("SPACE_ID")
-        if running_on_hf:
-            self.upload.upload_directory = os.getenv("UPLOADS_DIR", "/data/researchmate/uploads")
-            self.upload.temp_directory = os.getenv("TEMP_DIR", "/data/researchmate/tmp")
-        else:
-            self.upload.upload_directory = os.getenv("UPLOADS_DIR", "./tmp/researchmate/uploads")
-            self.upload.temp_directory = os.getenv("TEMP_DIR", "./tmp/researchmate/tmp")
+        self.upload.upload_directory = os.getenv("UPLOADS_DIR", "./tmp/researchmate/uploads")
+        self.upload.temp_directory = os.getenv("TEMP_DIR", "./tmp/researchmate/tmp")
         
-        # Logging configuration - USE ENVIRONMENT VARIABLE
+        # Logging configuration - USE ENVIRONMENT VARIABLE with fallback
         self.logging.level = os.getenv("LOG_LEVEL", self.logging.level)
-        running_on_hf = os.environ.get("HF_SPACE") == "1" or os.environ.get("SPACE_ID")
-        if running_on_hf:
-            self.logging.file_path = os.getenv("LOG_FILE", os.path.join(os.getenv("LOGS_DIR", "/data/researchmate/logs"), "app.log"))
-        else:
-            self.logging.file_path = os.getenv("LOG_FILE", os.path.join(os.getenv("LOGS_DIR", "./tmp/researchmate/logs"), "app.log"))
+        self.logging.file_path = os.getenv("LOG_FILE", os.path.join(os.getenv("LOGS_DIR", "./tmp/researchmate/logs"), "app.log"))
     
     def _validate_config(self):
         """Validate configuration settings"""
@@ -210,14 +193,6 @@ class Settings:
     
     def _create_directories(self):
         """Create necessary directories"""
-        running_on_hf = os.environ.get("HF_SPACE") == "1" or os.environ.get("SPACE_ID")
-        # If on Hugging Face, ensure /data exists first (should always exist, but be safe)
-        if running_on_hf:
-            try:
-                Path("/data").mkdir(parents=True, exist_ok=True)
-            except Exception:
-                pass  # Ignore if already exists or not allowed
-
         # Use writable paths from environment variables
         directories = [
             self.database.chroma_persist_dir,
@@ -226,20 +201,44 @@ class Settings:
             Path(self.logging.file_path).parent,
             Path(self.config_file).parent
         ]
-
+        
         for directory in directories:
             try:
+                # Try to create the directory
                 Path(directory).mkdir(parents=True, exist_ok=True)
                 print(f"Created/verified directory: {directory}")
             except PermissionError as e:
                 print(f"Permission error creating directory {directory}: {e}")
-                print(f"Current working directory: {os.getcwd()}")
-                print(f"Directory path: {Path(directory).absolute()}")
-                raise
+                # If we can't create in the intended location, try a fallback
+                if directory.startswith('/data/'):
+                    fallback_dir = directory.replace('/data/', './tmp/')
+                    try:
+                        Path(fallback_dir).mkdir(parents=True, exist_ok=True)
+                        print(f"Created fallback directory: {fallback_dir}")
+                        # Update the configuration to use the fallback
+                        self._update_config_path(directory, fallback_dir)
+                    except Exception as fallback_error:
+                        print(f"Failed to create fallback directory {fallback_dir}: {fallback_error}")
+                        raise
+                else:
+                    raise
             except Exception as e:
                 print(f"Error creating directory {directory}: {e}")
                 raise
     
+    def _update_config_path(self, original_path: str, new_path: str):
+        """Update configuration paths when fallback is used"""
+        if self.database.chroma_persist_dir == original_path:
+            self.database.chroma_persist_dir = new_path
+        if self.upload.upload_directory == original_path:
+            self.upload.upload_directory = new_path
+        if self.upload.temp_directory == original_path:
+            self.upload.temp_directory = new_path
+        if str(Path(self.logging.file_path).parent) == original_path:
+            self.logging.file_path = str(Path(new_path) / Path(self.logging.file_path).name)
+        if str(Path(self.config_file).parent) == original_path:
+            self.config_file = str(Path(new_path) / Path(self.config_file).name)
+    
     def save_config(self):
         """Save current configuration to file"""
         config_data = {