Update app.py

app.py

@@ -4,19 +4,18 @@ import tempfile
 import google.generativeai as genai
 import requests
 from flask import Flask, request, render_template, send_from_directory, url_for, flash
-from moviepy.video.io.VideoFileClip import VideoFileClip
-from moviepy.audio.io.AudioFileClip import AudioFileClip
+from moviepy.editor import VideoFileClip, AudioFileClip
 from werkzeug.utils import secure_filename
 
-# --- 1. INITIALIZATION & CONFIGURATION ---
+# --- 1. INITIALIZE FLASK APP AND LOAD SECRETS ---
 
 app = Flask(__name__)
 
-# Load secrets from environment variables
+# Load secrets from environment variables (the secure way)
 GEMINI_API_KEY = os.getenv("GEMINI_API_KEY")
 TTS_API_URL = os.getenv("TTS_API_URL")
 
-# Check if secrets were loaded correctly and provide clear error messages
+# Check if secrets were loaded correctly
 if not GEMINI_API_KEY:
     raise ValueError("SECURITY ERROR: GEMINI_API_KEY secret not found! Please set it as an environment variable.")
 if not TTS_API_URL:
@@ -25,7 +24,7 @@ if not TTS_API_URL:
 # Configure the Gemini API
 genai.configure(api_key=GEMINI_API_KEY)
 
-# Configure directories for temporary file storage
+# Configure directories and app settings
 UPLOAD_FOLDER = 'uploads'
 DOWNLOAD_FOLDER = 'downloads'
 os.makedirs(UPLOAD_FOLDER, exist_ok=True)
@@ -33,7 +32,7 @@ os.makedirs(DOWNLOAD_FOLDER, exist_ok=True)
 app.config['UPLOAD_FOLDER'] = UPLOAD_FOLDER
 app.config['DOWNLOAD_FOLDER'] = DOWNLOAD_FOLDER
 app.config['MAX_CONTENT_LENGTH'] = 100 * 1024 * 1024  # 100 MB upload limit
-app.secret_key = 'supersecretkey' # Required for flash messages
+app.secret_key = os.urandom(24) # Secure key for flash messages
 
 # --- 2. VOICE CHOICES & GEMINI PROMPT ---
 
@@ -51,7 +50,7 @@ You are an AI scriptwriter. Your task is to watch the provided video and transcr
 3.  **Incorporate Performance:** Add English style prompts (e.g., `Say happily:`, `Whisper mysteriously:`) and performance tags (e.g., `[laugh]`, `[sigh]`) directly into the text for an expressive narration.
 
 **EXAMPLE OUTPUT:**
-Say happily: வணக்கம்! [laugh] எப்படி இருக்கீங்க? Whisper mysteriously: அந்த ரகசியம் எனக்கு மட்டும் தான் தெரியும். Shout angrily: உடனே இங்கிருந்து போ!
+Say happily: வணக்கம்! [laugh] எப்படி இருக்கீங்க? Whisper mysteriously: அந்த ரகசியம் எனக்கு மட்டும் தான் தெரியும்.
 """
 
 # --- 3. CORE LOGIC HELPER FUNCTIONS ---
@@ -59,7 +58,7 @@ Say happily: வணக்கம்! [laugh] எப்படி இருக்
 def generate_tamil_script(video_file_path):
     """Generates a single, continuous Tamil script from the video using Gemini."""
     print("Uploading file to Gemini for transcription...")
-    video_file = genai.upload_file(video_file_path)
+    video_file = genai.upload_file(video_file_path, mime_type="video/mp4")
     
     print("Waiting for Gemini file processing...")
     while video_file.state.name == "PROCESSING":
@@ -69,7 +68,7 @@ def generate_tamil_script(video_file_path):
         raise Exception(f"Gemini file processing failed: {video_file.state.name}")
 
     print("Generating narrator script...")
-    model = genai.GenerativeModel(model_name="models/gemini-2.5-flash")
+    model = genai.GenerativeModel(model_name="models/gemini-1.5-pro-latest")
     response = model.generate_content([GEMINI_PROMPT, video_file])
     genai.delete_file(video_file.name)
     
@@ -81,7 +80,7 @@ def generate_single_audio_track(dialogue_text, voice_name, is_cheerful, output_p
     """Generates one audio track for the entire script via TTS API."""
     print(f"Requesting audio from TTS API (Voice: {voice_name}, Cheerful: {is_cheerful})")
     payload = {"text": dialogue_text, "voice_name": voice_name, "cheerful": is_cheerful}
-    response = requests.post(TTS_API_URL, json=payload, timeout=300) # 5-minute timeout
+    response = requests.post(TTS_API_URL, json=payload, timeout=300)
     if response.status_code == 200:
         with open(output_path, "wb") as f:
             f.write(response.content)
@@ -92,34 +91,33 @@ def generate_single_audio_track(dialogue_text, voice_name, is_cheerful, output_p
 def replace_video_audio(video_path, new_audio_path, output_path):
     """
     Replaces the audio of a video with a new audio file.
-    This function is robustly designed to ensure file handles are always closed.
+    This function now uses the modern, correct method for MoviePy.
     """
     print("Replacing video audio using MoviePy...")
     video_clip = None
     audio_clip = None
-    final_clip = None
     try:
         video_clip = VideoFileClip(video_path)
         audio_clip = AudioFileClip(new_audio_path)
         
-        # The standard and correct way to set audio in modern moviepy
-        final_clip = video_clip.set_audio(audio_clip)
+        # --- THE CORRECTED CODE ---
+        # In modern MoviePy, you assign the audio clip directly to the .audio attribute.
+        # The .set_audio() method is deprecated and causes the error.
+        video_clip.audio = audio_clip
         
-        # Write the final video file with a progress bar in the console
-        final_clip.write_videofile(output_path, codec="libx264", audio_codec="aac", logger='bar')
+        # Write the modified video_clip object to a file.
+        video_clip.write_videofile(output_path, codec="libx264", audio_codec="aac", logger='bar')
         print(f"Successfully created final video at {output_path}")
 
     except Exception as e:
         print(f"FATAL ERROR in replace_video_audio: {e}")
-        raise # Re-raise the exception to be caught by the Flask route
+        raise
     finally:
-        # This block ensures that all files are closed, preventing file lock issues.
+        # This block ensures that all file handles are closed, preventing file lock issues.
         if video_clip:
             video_clip.close()
         if audio_clip:
             audio_clip.close()
-        if final_clip:
-            final_clip.close()
 
 # --- 4. FLASK WEB ROUTES ---
 
@@ -131,15 +129,12 @@ def index():
 @app.route('/process', methods=['POST'])
 def process_video():
     """Handles video upload, processing, and renders the result."""
-    if 'video' not in request.files:
+    if 'video' not in request.files or request.files['video'].filename == '':
         flash("No video file selected. Please choose a file to upload.")
         return render_template('index.html')
     
     file = request.files['video']
-    if file.filename == '':
-        flash("No video file selected. Please choose a file to upload.")
-        return render_template('index.html')
-
+    
     try:
         filename = secure_filename(file.filename)
         upload_path = os.path.join(app.config['UPLOAD_FOLDER'], filename)
@@ -149,7 +144,6 @@ def process_video():
         is_cheerful = 'cheerful' in request.form
         voice_name = VOICE_CHOICES[voice_choice]
         
-        # Core Logic Execution
         script = generate_tamil_script(upload_path)
         
         with tempfile.NamedTemporaryFile(suffix=".wav", delete=False) as temp_audio:
@@ -162,8 +156,8 @@ def process_video():
         
         replace_video_audio(upload_path, temp_audio_path, final_video_path)
         
-        # Cleanup temporary audio file
         os.remove(temp_audio_path)
+        os.remove(upload_path) # Clean up original upload
         
         return render_template('index.html', 
                                result_video=url_for('serve_video', filename=final_video_name), 
@@ -171,7 +165,7 @@ def process_video():
 
     except Exception as e:
         print(f"An error occurred during processing: {e}")
-        flash(f"An error occurred: {e}")
+        flash(f"An unexpected error occurred: {e}. Please check the console logs and try again.")
         return render_template('index.html')
 
 @app.route('/downloads/<filename>')