Update app.py

app.py

@@ -1,6 +1,5 @@
 import os
 import re
-import random
 import requests
 import streamlit as st
 from langchain_huggingface import HuggingFaceEndpoint
@@ -21,9 +20,7 @@ if NASA_API_KEY is None:
 # ✅ Set Up Streamlit
 st.set_page_config(page_title="HAL - NASA ChatBot", page_icon="🚀")
 
-user_input = st.chat_input("Type your message here...")  # Make sure this is executed first
-
-# ✅ Ensure Session State Variables
+# ✅ Initialize Session State Variables
 if "chat_history" not in st.session_state:
     st.session_state.chat_history = [{"role": "assistant", "content": "Hello! How can I assist you today?"}]
 if "response_ready" not in st.session_state:
@@ -35,7 +32,7 @@ if "follow_up" not in st.session_state:
 model_id = "mistralai/Mistral-7B-Instruct-v0.3"
 
 # ✅ Initialize Hugging Face Model
-def get_llm_hf_inference(model_id=model_id, max_new_tokens=1024, temperature=0.7):
+def get_llm_hf_inference(model_id=model_id, max_new_tokens=512, temperature=0.7):
     return HuggingFaceEndpoint(
         repo_id=model_id,
         max_new_tokens=max_new_tokens,
@@ -65,28 +62,11 @@ def analyze_sentiment(user_text):
 
 # ✅ Intent Detection
 def predict_action(user_text):
-    if "NASA" in user_text or "space" in user_text:
+    if "NASA" in user_text.lower() or "space" in user_text.lower():
         return "nasa_info"
     return "general_query"
 
 # ✅ Follow-Up Question Generation
-def generate_follow_up(user_text):
-    prompt_text = f"Based on: '{user_text}', generate a concise, friendly follow-up."
-    hf = get_llm_hf_inference(max_new_tokens=80, temperature=0.9)
-    output = hf.invoke(input=prompt_text).strip()
-    return output if output else "Would you like to explore this topic further?"
-
-# ✅ Ensure English Responses
-def ensure_english(text):
-    try:
-        detected_lang = detect(text)
-        if detected_lang != "en":
-            return "⚠️ Sorry, I only respond in English. Can you rephrase your question?"
-    except:
-        return "⚠️ Language detection failed. Please ask your question again."
-    return text
-
-# ✅ Ensure Every Response Has a Follow-Up Question
 def generate_follow_up(user_text):
     """Generates a clean follow-up question to guide the user toward related topics or next steps."""
     prompt_text = (
@@ -98,13 +78,22 @@ def generate_follow_up(user_text):
     
     hf = get_llm_hf_inference(max_new_tokens=40, temperature=0.8)
     output = hf.invoke(input=prompt_text).strip()
-    
+
     # ✅ Remove unnecessary characters (like backticks and misplaced formatting)
     cleaned_output = re.sub(r"```|''|\"", "", output).strip()
 
     # ✅ Fallback in case the response is empty or invalid
     return cleaned_output if cleaned_output else "Would you like to explore another related topic or ask about something else?"
 
+# ✅ Ensure English Responses
+def ensure_english(text):
+    try:
+        detected_lang = detect(text)
+        if detected_lang != "en":
+            return "⚠️ Sorry, I only respond in English. Can you rephrase your question?"
+    except:
+        return "⚠️ Language detection failed. Please ask your question again."
+    return text
 
 # ✅ Main Response Function
 def get_response(system_message, chat_history, user_text, max_new_tokens=512):
@@ -155,70 +144,27 @@ def get_response(system_message, chat_history, user_text, max_new_tokens=512):
 
     return response, follow_up, chat_history, None
 
-# ✅ Ensure response is displayed
-if response:
-    st.markdown(f"<div class='assistant-msg'><strong>HAL:</strong> {response}</div>", unsafe_allow_html=True)
-
-# ✅ Save and display follow-up question separately
-if follow_up:  # 🔍 Here is the `if follow_up:` section
-    st.session_state.chat_history.append({'role': 'assistant', 'content': follow_up})
-    st.markdown(f"<div class='assistant-msg'><strong>HAL:</strong> {follow_up}</div>", unsafe_allow_html=True)
-
-
 # ✅ Streamlit UI
 st.title("🚀 HAL - NASA AI Assistant")
 
-# ✅ Justify all chatbot responses
-st.markdown("""
-    <style>
-    .user-msg {
-        background-color: #696969;
-        color: white;
-        padding: 10px;
-        border-radius: 10px;
-        margin-bottom: 5px;
-        width: fit-content;
-        max-width: 80%;
-        text-align: justify;  /* ✅ Justify text */
-    }
-    .assistant-msg {
-        background-color: #333333;
-        color: white;
-        padding: 10px;
-        border-radius: 10px;
-        margin-bottom: 5px;
-        width: fit-content;
-        max-width: 80%;
-        text-align: justify;  /* ✅ Justify text */
-    }
-    .container {
-        display: flex;
-        flex-direction: column;
-        align-items: flex-start;
-    }
-    @media (max-width: 600px) {
-        .user-msg, .assistant-msg { font-size: 16px; max-width: 100%; }
-    }
-    </style>
-""", unsafe_allow_html=True)
-
-
 # ✅ Reset Chat Button
 if st.sidebar.button("Reset Chat"):
     st.session_state.chat_history = [{"role": "assistant", "content": "Hello! How can I assist you today?"}]
     st.session_state.response_ready = False
     st.session_state.follow_up = ""
 
+# ✅ Chat UI
+user_input = st.chat_input("Type your message here...")
 
 if user_input:
-    # ✅ Ensure get_response() returns a response
+    # ✅ Ensure `get_response()` is executed BEFORE using `response`
     response, follow_up, st.session_state.chat_history, image_url = get_response(
         system_message="You are a helpful AI assistant.",
         user_text=user_input,
         chat_history=st.session_state.chat_history
     )
 
-    # ✅ Set default value if `response` is missing
+    # ✅ Ensure `response` is not None before using it
     if not response:
         response = "I'm sorry, but I couldn't generate a response."
 
@@ -227,14 +173,11 @@ if user_input:
 
     # ✅ Handle follow-up question
     if follow_up:
+        st.session_state.chat_history.append({'role': 'assistant', 'content': follow_up})
         st.markdown(f"<div class='assistant-msg'><strong>HAL:</strong> {follow_up}</div>", unsafe_allow_html=True)
 
     # ✅ Display NASA image if available
     if image_url:
         st.image(image_url, caption="NASA Image of the Day")
 
-
-# ✅ Check before displaying follow-up message
-if st.session_state.response_ready and st.session_state.follow_up:
-    st.markdown(f"<div class='assistant-msg'><strong>HAL:</strong> {st.session_state.follow_up}</div>", unsafe_allow_html=True)
-    st.session_state.response_ready = False
+    st.session_state.response_ready = True