Update services/agentic_handlers.py

services/agentic_handlers.py

@@ -40,70 +40,28 @@ class AgenticHandlers:
         self.agentic_modules_really_loaded = AGENTIC_MODULES_LOADED
         logging.info(f"AgenticHandlers initialized. Modules loaded: {self.agentic_modules_really_loaded}")
 
-    def _safe_checkbox_update(self, choices=None, value=None, interactive=True):
-        """
-        Safely create a CheckboxGroup update with proper format.
-        """
-        try:
-            update_dict = {}
-            
-            if choices is not None:
-                # Ensure choices is a list of tuples (display, value)
-                formatted_choices = []
-                for choice in choices:
-                    if isinstance(choice, tuple) and len(choice) == 2:
-                        # Ensure both elements are strings
-                        display_text = str(choice[0]).strip()
-                        choice_value = str(choice[1]).strip()
-                        formatted_choices.append((display_text, choice_value))
-                    elif isinstance(choice, (str, int)):
-                        # Convert single values to (display, value) tuples
-                        choice_str = str(choice).strip()
-                        formatted_choices.append((choice_str, choice_str))
-                    else:
-                        logging.warning(f"Invalid choice format: {choice}")
-                        continue
-                
-                update_dict['choices'] = formatted_choices
-            
-            if value is not None:
-                # Ensure value is a list of strings that match choice values
-                if isinstance(value, list):
-                    # Ensure all values are strings
-                    formatted_value = [str(v).strip() for v in value if v is not None]
-                    update_dict['value'] = formatted_value
-                else:
-                    update_dict['value'] = []
-            
-            update_dict['interactive'] = interactive
-            
-            return gr.update(**update_dict)
-            
-        except Exception as e:
-            logging.error(f"Error creating checkbox update: {e}")
-            return gr.update(choices=[], value=[], interactive=False)
-
     async def run_agentic_pipeline_autonomously_on_update(self, current_token_state_val):
         """
         This function is intended to be triggered by changes in token_state.
         It yields updates for the agentic report and OKR tabs.
         State values (5th, 6th, 7th) are serialized to JSON strings.
-        Updates for key_results_cbg are now for a CheckboxGroup.
+        Updates for key_results_cbg are now simplified without choices/interactive.
         """
         logging.info(f"Agentic pipeline auto-trigger. Token: {'Set' if current_token_state_val.get('token') else 'Not Set'}")
 
         initial_report_status = "Pipeline AI: In attesa dei dati necessari..."
         initial_okr_details = "Pipeline AI: In attesa dei dati necessari..."
         
-        # Initial state for key_results_cbg (CheckboxGroup)
-        initial_okr_cbg_update = self._safe_checkbox_update(choices=[], value=[], interactive=False)
-        
         initial_orchestration_results = self.orchestration_raw_results_st.value 
         initial_selected_krs = self.selected_key_result_ids_st.value
         initial_krs_for_selection = self.key_results_for_selection_st.value
         
         report_status_md_update = gr.update(value=initial_report_status) if self.report_components.get("agentic_pipeline_status_md") else gr.update()
         report_display_md_update = gr.update() 
+        
+        # Simple update for checkbox component - just reset value
+        okrs_cbg_update = gr.update(value=[]) if self.okrs_components.get("key_results_cbg") else gr.update()
+        
         okrs_detail_md_update = gr.update(value=initial_okr_details) if self.okrs_components.get("okr_detail_display_md") else gr.update()
 
         if not current_token_state_val or not current_token_state_val.get("token"):
@@ -111,11 +69,11 @@ class AgenticHandlers:
             yield (
                 report_status_md_update, 
                 report_display_md_update, 
-                initial_okr_cbg_update,          
+                okrs_cbg_update,          
                 okrs_detail_md_update,    
                 json.dumps(initial_orchestration_results), # Serialize to JSON
-                json.dumps(initial_selected_krs if isinstance(initial_selected_krs, list) else []),          # Serialize to JSON
-                json.dumps(initial_krs_for_selection if isinstance(initial_krs_for_selection, list) else [])      # Serialize to JSON
+                json.dumps(initial_selected_krs),          # Serialize to JSON
+                json.dumps(initial_krs_for_selection)      # Serialize to JSON
             )
             return
 
@@ -125,17 +83,11 @@ class AgenticHandlers:
         if self.okrs_components.get("okr_detail_display_md"): 
              okrs_detail_md_update = gr.update(value="Dettagli OKR (Sempre) in corso di generazione...")
         
-        # Show loading state for CheckboxGroup
-        loading_okr_cbg_update = self._safe_checkbox_update(choices=[], value=[], interactive=False)
-        
         yield (
-            report_status_md_update, 
-            report_display_md_update, 
-            loading_okr_cbg_update, 
-            okrs_detail_md_update,
+            report_status_md_update, report_display_md_update, okrs_cbg_update, okrs_detail_md_update,
             json.dumps(initial_orchestration_results), # Serialize to JSON
-            json.dumps(initial_selected_krs if isinstance(initial_selected_krs, list) else []),          # Serialize to JSON
-            json.dumps(initial_krs_for_selection if isinstance(initial_krs_for_selection, list) else [])      # Serialize to JSON
+            json.dumps(initial_selected_krs),          # Serialize to JSON
+            json.dumps(initial_krs_for_selection)      # Serialize to JSON
         )
 
         if not self.agentic_modules_really_loaded:
@@ -146,20 +98,16 @@ class AgenticHandlers:
             if self.report_components.get("agentic_report_display_md"):
                 report_display_md_update = gr.update(value=error_status) 
             
-            # Update for key_results_cbg (CheckboxGroup) in error case
-            error_okr_cbg_update = self._safe_checkbox_update(choices=[], value=[], interactive=False)
+            # Simple update for checkbox in error case
+            if self.okrs_components.get("key_results_cbg"):
+                okrs_cbg_update = gr.update(value=[])
             
             if self.okrs_components.get("okr_detail_display_md"):
                  okrs_detail_md_update = gr.update(value=error_status) 
 
             yield (
-                report_status_md_update, 
-                report_display_md_update, 
-                error_okr_cbg_update, 
-                okrs_detail_md_update,
-                json.dumps(None), 
-                json.dumps([]), 
-                json.dumps([]) # Serialize to JSON
+                report_status_md_update, report_display_md_update, okrs_cbg_update, okrs_detail_md_update,
+                json.dumps(None), json.dumps([]), json.dumps([]) # Serialize to JSON
             )
             return
 
@@ -182,7 +130,6 @@ class AgenticHandlers:
             orchestration_results_update_val = None
             selected_krs_update_val = [] # This will be the value for the CheckboxGroup, initially empty
             krs_for_selection_update_val = []
-            final_okr_cbg_update = self._safe_checkbox_update(choices=[], value=[], interactive=False)
 
             if orchestration_output:
                 orchestration_results_update_val = orchestration_output 
@@ -195,26 +142,9 @@ class AgenticHandlers:
                 krs_for_ui_selection_list = extract_key_results_for_selection(actionable_okrs)
                 krs_for_selection_update_val = krs_for_ui_selection_list # This is the list of dicts
                 
-                # Prepare choices for key_results_cbg (CheckboxGroup)
-                kr_choices_for_cbg = []
-                if krs_for_ui_selection_list and isinstance(krs_for_ui_selection_list, list):
-                    for kr in krs_for_ui_selection_list:
-                        if isinstance(kr, dict) and 'kr_description' in kr and 'unique_kr_id' in kr:
-                            # Ensure kr_description is a string and clean it
-                            kr_desc = str(kr['kr_description']).strip()
-                            # Truncate very long descriptions to avoid UI issues
-                            if len(kr_desc) > 100:
-                                kr_desc = kr_desc[:97] + "..."
-                            # Ensure unique_kr_id is a string
-                            kr_id = str(kr['unique_kr_id']).strip()
-                            kr_choices_for_cbg.append((kr_desc, kr_id))
-                
-                # Create CheckboxGroup update with proper choices
-                final_okr_cbg_update = self._safe_checkbox_update(
-                    choices=kr_choices_for_cbg, 
-                    value=[], 
-                    interactive=True
-                )
+                # For checkbox, just reset the value - don't update choices programmatically
+                if self.okrs_components.get("key_results_cbg"):
+                    okrs_cbg_update = gr.update(value=[])
                 
                 all_okrs_md_parts = []
                 if actionable_okrs and isinstance(actionable_okrs.get("okrs"), list):
@@ -234,8 +164,9 @@ class AgenticHandlers:
                 if self.report_components.get("agentic_report_display_md"):
                     report_display_md_update = gr.update(value="Nessun report generato dalla pipeline AI (Sempre).")
                 
-                # Update for key_results_cbg (CheckboxGroup) if no output
-                final_okr_cbg_update = self._safe_checkbox_update(choices=[], value=[], interactive=False)
+                # Simple update for checkbox if no output
+                if self.okrs_components.get("key_results_cbg"):
+                    okrs_cbg_update = gr.update(value=[])
                 
                 if self.okrs_components.get("okr_detail_display_md"):
                     okrs_detail_md_update = gr.update(value="Nessun OKR generato o errore nella pipeline AI (Sempre).")
@@ -244,10 +175,7 @@ class AgenticHandlers:
                  report_status_md_update = gr.update(value=final_status_text)
 
             yield (
-                report_status_md_update, 
-                report_display_md_update, 
-                final_okr_cbg_update, 
-                okrs_detail_md_update,
+                report_status_md_update, report_display_md_update, okrs_cbg_update, okrs_detail_md_update,
                 json.dumps(orchestration_results_update_val), # Serialize to JSON
                 json.dumps(selected_krs_update_val),          # Serialize to JSON (value for selected_key_result_ids_st)
                 json.dumps(krs_for_selection_update_val)      # Serialize to JSON (value for key_results_for_selection_st)
@@ -261,20 +189,16 @@ class AgenticHandlers:
             if self.report_components.get("agentic_report_display_md"):
                  report_display_md_update = gr.update(value=f"Errore generazione report AI (Sempre): {str(e)}")
             
-            # Update for key_results_cbg (CheckboxGroup) in case of exception
-            error_okr_cbg_update = self._safe_checkbox_update(choices=[], value=[], interactive=False)
+            # Simple update for checkbox in case of exception
+            if self.okrs_components.get("key_results_cbg"):
+                okrs_cbg_update = gr.update(value=[])
 
             if self.okrs_components.get("okr_detail_display_md"):
                 okrs_detail_md_update = gr.update(value=f"Errore generazione OKR AI (Sempre): {str(e)}")
 
             yield (
-                report_status_md_update, 
-                report_display_md_update, 
-                error_okr_cbg_update, 
-                okrs_detail_md_update,
-                json.dumps(None), 
-                json.dumps([]), 
-                json.dumps([]) # Serialize to JSON
+                report_status_md_update, report_display_md_update, okrs_cbg_update, okrs_detail_md_update,
+                json.dumps(None), json.dumps([]), json.dumps([]) # Serialize to JSON
             )
 
     def update_okr_display_on_kr_selection(self, selected_kr_unique_ids: list, 
@@ -292,9 +216,6 @@ class AgenticHandlers:
         if not isinstance(selected_kr_unique_ids, list):
             selected_kr_unique_ids = []
         
-        # Ensure all selected IDs are strings
-        selected_kr_unique_ids = [str(id).strip() for id in selected_kr_unique_ids if id is not None]
-        
         parsed_orchestration_results = None
         try:
             if raw_orchestration_results_json: # Check if the string is not empty
@@ -332,8 +253,7 @@ class AgenticHandlers:
         if isinstance(parsed_krs_for_selection_list, list): # Ensure it's a list before iterating
             for kr_info in parsed_krs_for_selection_list:
                 if isinstance(kr_info, dict) and 'unique_kr_id' in kr_info and 'okr_index' in kr_info and 'kr_index' in kr_info:
-                    kr_id = str(kr_info['unique_kr_id']).strip()
-                    kr_id_to_indices[kr_id] = (kr_info['okr_index'], kr_info['kr_index'])
+                    kr_id_to_indices[kr_info['unique_kr_id']] = (kr_info['okr_index'], kr_info['kr_index'])
                 else:
                     logging.warning(f"Skipping invalid kr_info item: {kr_info}")
 
@@ -341,9 +261,8 @@ class AgenticHandlers:
         # selected_kr_unique_ids comes directly from CheckboxGroup, should be a list of strings/values
         if isinstance(selected_kr_unique_ids, list): 
             for kr_unique_id in selected_kr_unique_ids:
-                kr_unique_id_str = str(kr_unique_id).strip()
-                if kr_unique_id_str in kr_id_to_indices:
-                    okr_idx, kr_idx_in_okr = kr_id_to_indices[kr_unique_id_str]
+                if kr_unique_id in kr_id_to_indices:
+                    okr_idx, kr_idx_in_okr = kr_id_to_indices[kr_unique_id]
                     selected_krs_by_okr_idx[okr_idx].append(kr_idx_in_okr)
         
         output_md_parts = []