Update services/analytics_tab_module.py

services/analytics_tab_module.py

@@ -370,27 +370,29 @@ class AnalyticsTab:
         logging.info("Refreshing analytics graph UI elements and resetting actions/chat (within module).")
         start_time = time.time()
 
-        # --- FIX STARTS HERE ---
-        # The original code used complex slicing (plot_gen_results[1:-1]) which is brittle.
-        # It assumes the figures are returned as a flat list. If update_analytics_plots_figures
-        # returns a more standard (status, [list_of_figs], summary) tuple, the slicing fails.
-        # This new unpacking is more robust and assumes update_analytics_plots_figures returns
-        # a 3-element tuple/list where the second element is the list of figures.
         plot_gen_results = self.update_analytics_plots_figures(current_token_state_val, date_filter_val, custom_start_val, custom_end_val, PLOT_CONFIGS)
         
-        # This direct unpacking is safer than slicing.
-        # It assumes `update_analytics_plots_figures` returns a 3-element structure like:
-        # (status_string, list_of_figure_objects, summaries_dict)
+        # --- NEW FIX STARTS HERE ---
+        # The error "too many values to unpack (expected 3)" and "received 21 elements" confirms the function
+        # returns a flat tuple/list of (status, fig1, fig2, ..., fig19, summary_dict).
+        # This revised unpacking logic handles that specific structure by slicing.
         try:
-            status_msg, gen_figs, new_summaries_for_chatbot = plot_gen_results
-        except (ValueError, TypeError) as e:
+            # Check if we got the expected number of results (status + 19 plots + summary)
+            expected_count = len(PLOT_CONFIGS) + 2
+            if len(plot_gen_results) == expected_count:
+                status_msg = plot_gen_results[0]
+                # Gather all middle elements (the figures) into a list using slicing
+                gen_figs = list(plot_gen_results[1:-1]) 
+                new_summaries_for_chatbot = plot_gen_results[-1]
+            else:
+                # This will handle cases where the number of returned items is unexpected
+                raise ValueError(f"Expected {expected_count} elements, but got {len(plot_gen_results)}")
+        except (ValueError, TypeError, IndexError) as e:
             logging.error(f"Could not unpack results from update_analytics_plots_figures. Error: {e}")
-            logging.error(f"Expected 3 elements (status, figs_list, summaries), but received {len(plot_gen_results)} elements.")
             # Fallback to error state
             status_msg = f"Errore: L'aggiornamento dei grafici non è riuscito a causa di un formato di dati imprevisto."
             gen_figs = [self.create_placeholder_plot("Error", f"Dati non validi {i}") for i in range(len(PLOT_CONFIGS))]
             new_summaries_for_chatbot = {}
-
         # --- FIX ENDS HERE ---
 
         all_updates = []
@@ -398,12 +400,10 @@ class AnalyticsTab:
         all_updates.append(status_msg) # For self.analytics_status_md
 
         # 2. Plot components
-        # This check is now more likely to succeed with the corrected unpacking.
         if isinstance(gen_figs, list) and len(gen_figs) == len(PLOT_CONFIGS):
             all_updates.extend(gen_figs)
         else:
             logging.error(f"Mismatch in generated figures ({len(gen_figs) if isinstance(gen_figs, list) else 'N/A'}) and plot_configs ({len(PLOT_CONFIGS)})")
-            # If there's still a mismatch, create placeholders to avoid crashing Gradio
             all_updates.extend([self.create_placeholder_plot("Error", f"Figura mancante {i}") for i in range(len(PLOT_CONFIGS))])
 
         # 3. UI Resets for Action Panel (9 components)