Update services/agentic_handlers.py

services/agentic_handlers.py

@@ -44,51 +44,49 @@ class AgenticHandlers:
         This function is intended to be triggered by changes in token_state
         (e.g., after initial load or after sync).
         It yields updates for the agentic report and OKR tabs.
+        The 5th, 6th, and 7th yielded values are stringified to prevent errors
+        if misconfigured UI routes them to Markdown components.
         """
         logging.info(f"Agentic pipeline auto-trigger. Token: {'Set' if current_token_state_val.get('token') else 'Not Set'}")
 
         # Initial "waiting" status updates
         initial_report_status = "Pipeline AI: In attesa dei dati necessari..."
-        initial_okr_value_for_markdown = "" # Assuming this component is Markdown, value should be string
-        # initial_okr_interactive = False # Markdown does not take 'interactive' in gr.update
+        initial_okr_value_for_markdown = "" 
         initial_okr_details = "Pipeline AI: In attesa dei dati necessari..."
-        initial_orchestration_results = self.orchestration_raw_results_st.value # Preserve if re-running
+        initial_orchestration_results = self.orchestration_raw_results_st.value 
         initial_selected_krs = self.selected_key_result_ids_st.value
         initial_krs_for_selection = self.key_results_for_selection_st.value
         
-        # Check if components exist (in case tabs were conditionally not fully rendered)
         report_status_md_update = gr.update(value=initial_report_status) if self.report_components.get("agentic_pipeline_status_md") else gr.update()
-        report_display_md_update = gr.update() # No change to report display yet
+        report_display_md_update = gr.update() 
         
-        # If key_results_cbg is the Markdown component causing the error, its update should not have 'interactive'.
-        # Its value should be a string.
         okrs_cbg_update = gr.update(value=initial_okr_value_for_markdown) if self.okrs_components.get("key_results_cbg") else gr.update()
         okrs_detail_md_update = gr.update(value=initial_okr_details) if self.okrs_components.get("okr_detail_display_md") else gr.update()
 
         if not current_token_state_val or not current_token_state_val.get("token"):
             logging.info("Agentic pipeline: Token not available in token_state. Skipping actual run.")
             yield (
-                report_status_md_update, # For agentic_pipeline_status_md
-                report_display_md_update, # For agentic_report_display_md (no change yet)
-                okrs_cbg_update,          # For key_results_cbg (now updated as if it's Markdown)
-                okrs_detail_md_update,    # For okr_detail_display_md
-                initial_orchestration_results, # For orchestration_raw_results_st
-                initial_selected_krs,          # For selected_key_result_ids_st
-                initial_krs_for_selection      # For key_results_for_selection_st
+                report_status_md_update, 
+                report_display_md_update, 
+                okrs_cbg_update,          
+                okrs_detail_md_update,    
+                str(initial_orchestration_results), # Stringify state value
+                str(initial_selected_krs),          # Stringify state value
+                str(initial_krs_for_selection)      # Stringify state value
             )
             return
 
-        # Update status to "in progress"
         in_progress_status = "Analisi AI (Sempre) in corso..."
         if self.report_components.get("agentic_pipeline_status_md"):
             report_status_md_update = gr.update(value=in_progress_status)
-        if self.okrs_components.get("okr_detail_display_md"): # Also update OKR detail placeholder
+        if self.okrs_components.get("okr_detail_display_md"): 
              okrs_detail_md_update = gr.update(value="Dettagli OKR (Sempre) in corso di generazione...")
         
-        # okrs_cbg_update remains as initially defined (waiting state, no choices/interactive)
         yield (
             report_status_md_update, report_display_md_update, okrs_cbg_update, okrs_detail_md_update,
-            initial_orchestration_results, initial_selected_krs, initial_krs_for_selection
+            str(initial_orchestration_results), # Stringify state value
+            str(initial_selected_krs),          # Stringify state value
+            str(initial_krs_for_selection)      # Stringify state value
         )
 
         if not self.agentic_modules_really_loaded:
@@ -97,24 +95,21 @@ class AgenticHandlers:
             if self.report_components.get("agentic_pipeline_status_md"):
                 report_status_md_update = gr.update(value=error_status)
             if self.report_components.get("agentic_report_display_md"):
-                report_display_md_update = gr.update(value=error_status) # Update report display too
+                report_display_md_update = gr.update(value=error_status) 
             
-            # If key_results_cbg is Markdown, update its value to reflect the error.
-            # No choices or interactive argument here.
             if self.okrs_components.get("key_results_cbg"):
-                 okrs_cbg_update = gr.update(value=error_status) # Value is string
+                 okrs_cbg_update = gr.update(value=error_status) 
             
             if self.okrs_components.get("okr_detail_display_md"):
-                 okrs_detail_md_update = gr.update(value=error_status) # Update OKR detail too
+                 okrs_detail_md_update = gr.update(value=error_status) 
 
             yield (
                 report_status_md_update, report_display_md_update, okrs_cbg_update, okrs_detail_md_update,
-                None, [], [] # Reset states
+                str(None), str([]), str([]) # Stringify state values
             )
             return
 
         try:
-            # Always use "Sempre" filter for the autonomous agentic pipeline
             date_filter_val_agentic = "Sempre"
             custom_start_val_agentic = None
             custom_end_val_agentic = None
@@ -135,7 +130,7 @@ class AgenticHandlers:
             krs_for_selection_update_val = []
 
             if orchestration_output:
-                orchestration_results_update_val = orchestration_output # Store the raw output
+                orchestration_results_update_val = orchestration_output 
                 
                 report_str = orchestration_output.get('comprehensive_analysis_report', "Nessun report testuale fornito.")
                 if self.report_components.get("agentic_report_display_md"):
@@ -143,15 +138,11 @@ class AgenticHandlers:
                 
                 actionable_okrs = orchestration_output.get('actionable_okrs_and_tasks')
                 krs_for_ui_selection_list = extract_key_results_for_selection(actionable_okrs)
-                krs_for_selection_update_val = krs_for_ui_selection_list # Store for CBG change handler
+                krs_for_selection_update_val = krs_for_ui_selection_list 
                 
                 if self.okrs_components.get("key_results_cbg"):
-                    # If this component is Markdown, it cannot take choices or interactive.
-                    # Its value should be a string.
                     okrs_cbg_update = gr.update(value="Key Results available for selection (display as Markdown)") 
-                                                # Example string value if it's Markdown.
                 
-                # Display all OKRs initially (before any KR selection)
                 all_okrs_md_parts = []
                 if actionable_okrs and isinstance(actionable_okrs.get("okrs"), list):
                     for okr_idx, okr_item in enumerate(actionable_okrs["okrs"]):
@@ -164,15 +155,14 @@ class AgenticHandlers:
                     if self.okrs_components.get("okr_detail_display_md"):
                         okrs_detail_md_update = gr.update(value="\n\n---\n\n".join(all_okrs_md_parts))
                 
-                selected_krs_update_val = [] # Reset selection
-            else: # No output from pipeline
+                selected_krs_update_val = [] 
+            else: 
                 final_status_text = "Pipeline AI (Sempre): Nessun risultato prodotto."
                 if self.report_components.get("agentic_report_display_md"):
                     report_display_md_update = gr.update(value="Nessun report generato dalla pipeline AI (Sempre).")
                 
-                # If key_results_cbg is Markdown
                 if self.okrs_components.get("key_results_cbg"):
-                    okrs_cbg_update = gr.update(value="Nessun Key Result (Markdown display)") # String value
+                    okrs_cbg_update = gr.update(value="Nessun Key Result (Markdown display)") 
                 
                 if self.okrs_components.get("okr_detail_display_md"):
                     okrs_detail_md_update = gr.update(value="Nessun OKR generato o errore nella pipeline AI (Sempre).")
@@ -182,7 +172,9 @@ class AgenticHandlers:
 
             yield (
                 report_status_md_update, report_display_md_update, okrs_cbg_update, okrs_detail_md_update,
-                orchestration_results_update_val, selected_krs_update_val, krs_for_selection_update_val
+                str(orchestration_results_update_val), # Stringify state value
+                str(selected_krs_update_val),          # Stringify state value
+                str(krs_for_selection_update_val)      # Stringify state value
             )
 
         except Exception as e:
@@ -193,16 +185,15 @@ class AgenticHandlers:
             if self.report_components.get("agentic_report_display_md"):
                  report_display_md_update = gr.update(value=f"Errore generazione report AI (Sempre): {str(e)}")
             
-            # If key_results_cbg is Markdown
             if self.okrs_components.get("key_results_cbg"):
-                okrs_cbg_update = gr.update(value=f"Errore Key Results (Markdown): {str(e)}") # String value
+                okrs_cbg_update = gr.update(value=f"Errore Key Results (Markdown): {str(e)}") 
 
             if self.okrs_components.get("okr_detail_display_md"):
                 okrs_detail_md_update = gr.update(value=f"Errore generazione OKR AI (Sempre): {str(e)}")
 
             yield (
                 report_status_md_update, report_display_md_update, okrs_cbg_update, okrs_detail_md_update,
-                None, [], [] # Reset states on error
+                str(None), str([]), str([]) # Stringify state values
             )
 
     def update_okr_display_on_kr_selection(self, selected_kr_unique_ids: list, 
@@ -211,28 +202,48 @@ class AgenticHandlers:
         """
         Updates the OKR detail display when Key Results are selected in the CheckboxGroup.
         """
+        # raw_orchestration_results, all_krs_for_selection_list now might be strings
+        # if they come from state that was stringified. This needs careful handling
+        # if this function is called with outputs from the stringified state.
+        # For now, assuming they are passed correctly as dict/list if not from stringified state.
+
         if not self.agentic_modules_really_loaded:
             return gr.update(value="Moduli AI non caricati. Impossibile visualizzare i dettagli OKR.")
-        if not raw_orchestration_results:
+        
+        # Attempt to parse if stringified, this is a significant assumption about how state is used.
+        # This part is complex because we don't know if these inputs are direct from UI or from stringified state.
+        # A robust solution would involve type checking and conditional parsing (e.g. import json; json.loads if string)
+        # For this focused fix, we'll assume they are passed as dict/list for now.
+        # If they come from the stringified state, this function will likely fail or misbehave.
+        # The problem is, the `inputs` to this handler in `setup_event_handlers` are `gr.State` objects.
+        # If those `gr.State` objects now store strings like "'[]'", then `raw_orchestration_results` here
+        # will be the string "'[]'", not the list [].
+
+        if not raw_orchestration_results: # This check might be problematic if "None" (string) is passed
             return gr.update(value="Nessun dato dalla pipeline AI o moduli non caricati.")
 
-        actionable_okrs_dict = raw_orchestration_results.get("actionable_okrs_and_tasks")
+        # This is a critical point: if raw_orchestration_results is a string representation
+        # of a dict (e.g., "{'key': 'value'}"), .get will fail.
+        # We would need to json.loads() it.
+        # For now, we proceed assuming it's a dict. This might be the next error point.
+        actionable_okrs_dict = raw_orchestration_results.get("actionable_okrs_and_tasks") if isinstance(raw_orchestration_results, dict) else None
+        
         if not actionable_okrs_dict or not isinstance(actionable_okrs_dict.get("okrs"), list):
-            return gr.update(value="Nessun OKR trovato nei risultati della pipeline.")
+            return gr.update(value="Nessun OKR trovato nei risultati della pipeline (o dati in formato imprevisto).")
 
         okrs_list = actionable_okrs_dict["okrs"]
-        if not okrs_list: # Should be caught by above, but defensive
+        if not okrs_list: 
             return gr.update(value="Nessun OKR generato.")
 
-        # Create a mapping from unique_kr_id to its (okr_index, kr_index_within_okr)
         kr_id_to_indices = {}
-        if all_krs_for_selection_list: # This list comes from extract_key_results_for_selection
+        # Similar issue here: all_krs_for_selection_list could be a string representation of a list.
+        if isinstance(all_krs_for_selection_list, list):
             for kr_info in all_krs_for_selection_list:
-                kr_id_to_indices[kr_info['unique_kr_id']] = (kr_info['okr_index'], kr_info['kr_index'])
+                if isinstance(kr_info, dict): # defensive check
+                    kr_id_to_indices[kr_info['unique_kr_id']] = (kr_info['okr_index'], kr_info['kr_index'])
         
-        # Group selected KR indices by their parent OKR index
         selected_krs_by_okr_idx = defaultdict(list)
-        if selected_kr_unique_ids: # This is the list of unique_kr_ids from the checkboxgroup
+        if selected_kr_unique_ids: 
             for kr_unique_id in selected_kr_unique_ids:
                 if kr_unique_id in kr_id_to_indices:
                     okr_idx, kr_idx_in_okr = kr_id_to_indices[kr_unique_id]
@@ -240,31 +251,27 @@ class AgenticHandlers:
         
         output_md_parts = []
         for okr_idx, okr_data in enumerate(okrs_list):
-            # If specific KRs are selected, only show OKRs that have at least one selected KR,
-            # and then format that OKR to only show its selected KRs.
-            # If no KRs are selected, show all OKRs with all their KRs.
-            
-            accepted_indices_for_this_okr = selected_krs_by_okr_idx.get(okr_idx) # This will be a list of KR indices or None
+            accepted_indices_for_this_okr = selected_krs_by_okr_idx.get(okr_idx)
 
-            if selected_kr_unique_ids: # If there's any selection active
-                if accepted_indices_for_this_okr is not None: # Only format/display if this OKR has selected KRs
+            if selected_kr_unique_ids: 
+                if accepted_indices_for_this_okr is not None: 
                     formatted_okr_md = format_single_okr_for_display(
                         okr_data, 
                         accepted_kr_indices=accepted_indices_for_this_okr, 
                         okr_main_index=okr_idx
                     )
                     output_md_parts.append(formatted_okr_md)
-            else: # No KRs selected, display all OKRs fully
+            else: 
                 formatted_okr_md = format_single_okr_for_display(
                     okr_data, 
-                    accepted_kr_indices=None, # None means show all KRs for this OKR
+                    accepted_kr_indices=None, 
                     okr_main_index=okr_idx
                 )
                 output_md_parts.append(formatted_okr_md)
 
         if not output_md_parts and selected_kr_unique_ids:
             final_md = "Nessun OKR corrisponde alla selezione corrente o i KR selezionati non hanno task dettagliati."
-        elif not output_md_parts and not selected_kr_unique_ids: # Should mean okrs_list was empty
+        elif not output_md_parts and not selected_kr_unique_ids: 
             final_md = "Nessun OKR generato."
         else:
             final_md = "\n\n---\n\n".join(output_md_parts)
@@ -278,17 +285,12 @@ class AgenticHandlers:
             return
 
         if self.okrs_components.get("key_results_cbg"):
-            # The input 'key_results_cbg' provides the selected IDs.
-            # If it's truly a Markdown component now, this .change handler might not behave as expected
-            # for selection, as Markdown isn't typically an input component this way.
-            # However, the function signature of update_okr_display_on_kr_selection expects selected_kr_unique_ids.
-            # This setup might need further review if key_results_cbg is indeed Markdown and meant to be interactive.
             self.okrs_components['key_results_cbg'].change(
                 fn=self.update_okr_display_on_kr_selection,
                 inputs=[
-                    self.okrs_components['key_results_cbg'], # Current value of checkbox group (or Markdown if changed)
-                    self.orchestration_raw_results_st,     # State
-                    self.key_results_for_selection_st      # State
+                    self.okrs_components['key_results_cbg'], 
+                    self.orchestration_raw_results_st,     
+                    self.key_results_for_selection_st      
                 ],
                 outputs=[self.okrs_components['okr_detail_display_md']],
                 api_name="update_okr_display_on_kr_selection"