Update app.py

app.py

@@ -1,12 +1,18 @@
 """
-app.py — Step 8 (refined)
+app.py — Step 9
 Adds:
-- Auto-build of the index on first question (prevents "Index not found" error)
-- Same Extractive/Generative toggle + temperature/max_tokens controls
+- Feedback logger (Helpful / Not helpful) with optional note → data/feedback.csv
+- Per-session ID so you can trace usage (no cookies needed)
+- Auto-build index on first question (from Step 8 refined)
+
+Everything else (RAG + Extractive/Generative toggle) stays the same.
 """
 
 from pathlib import Path
 from typing import List
+import secrets
+import time
+
 import gradio as gr
 
 from indexer import build_index
@@ -19,6 +25,7 @@ from rag_search import (
 )
 from evo_inference import synthesize_with_evo
 from utils_lang import SUPPORTED, normalize_lang, L
+from feedback import log_feedback  # NEW
 
 _searcher = None
 DATA_SEED_DIR = Path("data/seed")
@@ -87,6 +94,7 @@ def on_ask(
     temp: float,
     max_tokens: int,
     history: list,
+    session_id: str,   # NEW: State input
 ):
     """
     Handle a user question end-to-end:
@@ -95,10 +103,12 @@ def on_ask(
     - Synthesize answer (Extractive or Generative)
     - Show sources + extracted links/forms
     - Append to chat history
+    - Return a structured "last answer" payload for feedback logging
     """
     lang = normalize_lang(lang_code)
     if not question or len(question.strip()) < 3:
-        return history, L(lang, "intro_err"), f"{L(lang, 'sources')}: (none)", "", ""
+        last_payload = {}
+        return history, L(lang, "intro_err"), f"{L(lang, 'sources')}: (none)", "", "", last_payload
 
     try:
         # Ensure searcher; if index missing, build once automatically then retry
@@ -133,20 +143,61 @@ def on_ask(
         links_md = links_markdown(L(lang, "links"), other_links)
         forms_md = links_markdown(L(lang, "forms"), form_links)
 
+        # Build "last answer" payload for feedback
+        last_payload = {
+            "ts_question": int(time.time()),
+            "session": session_id or "",
+            "lang": lang,
+            "mode": mode,
+            "temperature": float(temp),
+            "max_tokens": int(max_tokens),
+            "top_k": int(top_k),
+            "question": question,
+            "answer": answer,
+            "sources": srcs,
+            "links": links_md,
+            "forms": forms_md,
+        }
+
     except Exception as e:
         answer = f"Error: {e}\n\n{L(lang, 'tip_build')}"
         srcs = f"{L(lang, 'sources')}: (none)"
         links_md = f"**{L(lang, 'links')}:** (none)"
         forms_md = f"**{L(lang, 'forms')}:** (none)"
+        last_payload = {}
 
     history = history + [(question, answer)]
-    return history, answer, srcs, links_md, forms_md
+    return history, answer, srcs, links_md, forms_md, last_payload
+
+
+def on_feedback_submit(kind: str, note: str, last_payload: dict) -> str:
+    """
+    Log feedback to CSV. 'kind' is 'helpful' or 'not_helpful'.
+    """
+    if not last_payload:
+        return "Ask a question first, then rate the answer."
+    entry = dict(last_payload)  # copy
+    entry["feedback"] = kind
+    entry["note"] = note or ""
+    return log_feedback(entry)
+
+
+def _new_session_id():
+    """Generate a short session id on app load."""
+    return secrets.token_hex(8)
 
 
 with gr.Blocks(title=L("en", "title")) as demo:
-    gr.Markdown(f"# 🇲🇺 **{L('en','title')}** — Step 8")
+    gr.Markdown(f"# 🇲🇺 **{L('en','title')}** — Step 9")
 
-    # Admin: build index / upload & reindex
+    # --- Hidden state: session id + last answer payload
+    session = gr.State()
+    last_answer = gr.State()
+
+    # Generate a session id when the app loads
+    demo.load(fn=_new_session_id, inputs=None, outputs=session)
+
+    # --- Admin: build index / upload & reindex
     with gr.Row():
         build_btn = gr.Button(L("en", "build_btn"))
         status = gr.Markdown(L("en", "status_idle"))
@@ -162,7 +213,7 @@ with gr.Blocks(title=L("en", "title")) as demo:
         upload_status = gr.Markdown()
         save_btn.click(fn=on_upload_and_reindex, inputs=upload, outputs=upload_status)
 
-    # User controls
+    # --- User controls
     gr.Markdown("### Language / Langue / Langaz")
     lang = gr.Dropdown(choices=list(SUPPORTED.keys()), value="en", label="EN / FR / MFE")
 
@@ -176,6 +227,7 @@ with gr.Blocks(title=L("en", "title")) as demo:
         temp = gr.Slider(0.0, 1.2, value=0.4, step=0.05, label="Temperature (gen)")
         max_tokens = gr.Slider(64, 384, value=192, step=16, label="Max new tokens (gen)")
 
+    # --- Q&A
     gr.Markdown("### Ask a question / Posez une question / Poz enn kestyon")
     with gr.Row():
         q = gr.Textbox(placeholder=L("en", "ask_placeholder"), label=L("en", "ask_label"))
@@ -190,13 +242,33 @@ with gr.Blocks(title=L("en", "title")) as demo:
 
     ask_btn.click(
         fn=on_ask,
-        inputs=[q, k, lang, mode, temp, max_tokens, chat],
-        outputs=[chat, answer_md, sources_md, links_md, forms_md],
+        inputs=[q, k, lang, mode, temp, max_tokens, chat, session],
+        outputs=[chat, answer_md, sources_md, links_md, forms_md, last_answer],
     )
     q.submit(
         fn=on_ask,
-        inputs=[q, k, lang, mode, temp, max_tokens, chat],
-        outputs=[chat, answer_md, sources_md, links_md, forms_md],
+        inputs=[q, k, lang, mode, temp, max_tokens, chat, session],
+        outputs=[chat, answer_md, sources_md, links_md, forms_md, last_answer],
+    )
+
+    # --- Feedback UI
+    gr.Markdown("### Rate this answer")
+    with gr.Row():
+        note = gr.Textbox(placeholder="Optional: tell us what was good or missing", label="Your note", lines=2)
+    with gr.Row():
+        helpful_btn = gr.Button("👍 Helpful")
+        not_helpful_btn = gr.Button("👎 Not helpful")
+        fb_status = gr.Markdown()
+
+    helpful_btn.click(
+        fn=lambda n, last: on_feedback_submit("helpful", n, last),
+        inputs=[note, last_answer],
+        outputs=[fb_status],
+    )
+    not_helpful_btn.click(
+        fn=lambda n, last: on_feedback_submit("not_helpful", n, last),
+        inputs=[note, last_answer],
+        outputs=[fb_status],
     )
 
 demo.launch()