Improve text length validation and make vote buttons flush with audio players

pyproject.toml

@@ -45,6 +45,7 @@ ignore = [
     "PLR0913",
     "PLR2004",
     "RUF006",
+    "SIM117",
     "TD002",
     "TD003",
 ]

src/app.py

@@ -35,6 +35,7 @@ from src.utils import (
     determine_selected_option,
     submit_voting_results,
     validate_character_description_length,
+    validate_text_length,
 )
 
 
@@ -116,9 +117,12 @@ class App:
         Raises:
             gr.Error: If any API or unexpected errors occur during the TTS synthesis process.
         """
-        if not text:
-            logger.warning("Skipping text-to-speech due to empty text.")
-            raise gr.Error("Please generate or enter text to synthesize.")
+        try:
+            validate_character_description_length(character_description)
+            validate_text_length(text)
+        except ValueError as ve:
+            logger.warning(f"Validation error: {ve}")
+            raise gr.Error(str(ve))
 
         # Select 2 TTS providers based on whether the text has been modified.
         text_modified = text != generated_text_state
@@ -267,8 +271,8 @@ class App:
         return (
             gr.update(value=None),
             gr.update(value=None, autoplay=False),
-            gr.update(value=constants.SELECT_OPTION_A, variant="secondary"),
-            gr.update(value=constants.SELECT_OPTION_B, variant="secondary"),
+            gr.update(value=constants.SELECT_OPTION_A, variant="secondary", interactive=False),
+            gr.update(value=constants.SELECT_OPTION_B, variant="secondary", interactive=False),
             default_option_map,  # Reset option_map_state as a default OptionMap
             False,
         )
@@ -314,12 +318,31 @@ class App:
             show_copy_button=True,
         )
         synthesize_speech_button = gr.Button("Synthesize Speech", variant="primary")
+
         with gr.Row(equal_height=True):
-            option_a_audio_player = gr.Audio(label=constants.OPTION_A_LABEL, type="filepath", interactive=False)
-            option_b_audio_player = gr.Audio(label=constants.OPTION_B_LABEL, type="filepath", interactive=False)
-        with gr.Row(equal_height=True):
-            vote_button_a = gr.Button(constants.SELECT_OPTION_A, interactive=False)
-            vote_button_b = gr.Button(constants.SELECT_OPTION_B, interactive=False)
+            with gr.Column():
+                with gr.Group():
+                    option_a_audio_player = gr.Audio(
+                        label=constants.OPTION_A_LABEL,
+                        type="filepath",
+                        interactive=False,
+                    )
+                    vote_button_a = gr.Button(
+                        constants.SELECT_OPTION_A,
+                        interactive=False,
+                    )
+            with gr.Column():
+                with gr.Group():
+                    option_b_audio_player = gr.Audio(
+                        label=constants.OPTION_B_LABEL,
+                        type="filepath",
+                        interactive=False,
+                    )
+                    vote_button_b = gr.Button(
+                        constants.SELECT_OPTION_B,
+                        interactive=False,
+                    )
+
         return (
             text_input,
             synthesize_speech_button,

src/constants.py

@@ -23,7 +23,10 @@ HUME_TO_HUME: ComparisonType = "Hume AI - Hume AI"
 HUME_TO_ELEVENLABS: ComparisonType = "Hume AI - ElevenLabs"
 
 CHARACTER_DESCRIPTION_MIN_LENGTH: int = 20
-CHARACTER_DESCRIPTION_MAX_LENGTH: int = 800
+CHARACTER_DESCRIPTION_MAX_LENGTH: int = 1000
+
+TEXT_MIN_LENGTH: int = 100
+TEXT_MAX_LENGTH: int = 1000
 
 OPTION_A_KEY: OptionKey = "option_a"
 OPTION_B_KEY: OptionKey = "option_b"

src/utils.py

@@ -71,13 +71,6 @@ def validate_character_description_length(character_description: str) -> None:
 
     Raises:
         ValueError: If the character description is empty, too short, or exceeds max length.
-
-    Example:
-        >>> validate_character_description_length("This is a character description.")
-        # Passes validation
-
-        >>> validate_character_description_length("")
-        # Raises ValueError: "Voice Description must be at least 20 characters long."
     """
     stripped_character_description = character_description.strip()
     character_description_length = len(stripped_character_description)
@@ -101,6 +94,38 @@ def validate_character_description_length(character_description: str) -> None:
     logger.debug(f"Character description length validation passed for character_description: {truncated_description}")
 
 
+def validate_text_length(text: str) -> None:
+    """
+    Validates that a text input is within specified minimum and maximum length limits.
+
+    Args:
+        text (str): The input text to validate.
+
+    Raises:
+        ValueError: If the text is empty, too short, or exceeds max length.
+    """
+    stripped_text = text.strip()
+    text_length = len(stripped_text)
+
+    logger.debug(f"Voice description length being validated: {text_length} characters")
+
+    if text_length < constants.TEXT_MIN_LENGTH:
+        raise ValueError(
+            f"Your text is too short. Please enter at least "
+            f"{constants.TEXT_MIN_LENGTH} characters. "
+            f"(Current length: {text_length})"
+        )
+    if text_length > constants.TEXT_MAX_LENGTH:
+        raise ValueError(
+            f"Your text is too long. Please limit it to "
+            f"{constants.TEXT_MAX_LENGTH} characters. "
+            f"(Current length: {text_length})"
+        )
+
+    truncated_text = truncate_text(stripped_text)
+    logger.debug(f"Character description length validation passed for text: {truncated_text}")
+
+
 def _delete_files_older_than(directory: Path, minutes: int = 30) -> None:
     """
     Delete all files in the specified directory that are older than a given number of minutes.