Spaces:
Running
Running
File size: 6,595 Bytes
b110593 |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 |
// _ _
// __ _____ __ ___ ___ __ _| |_ ___
// \ \ /\ / / _ \/ _` \ \ / / |/ _` | __/ _ \
// \ V V / __/ (_| |\ V /| | (_| | || __/
// \_/\_/ \___|\__,_| \_/ |_|\__,_|\__\___|
//
// Copyright © 2016 - 2024 Weaviate B.V. All rights reserved.
//
// CONTACT: [email protected]
//
package classification
import (
"fmt"
"testing"
"github.com/stretchr/testify/assert"
"github.com/weaviate/weaviate/entities/models"
)
func Test_ValidateUserInput(t *testing.T) {
type testcase struct {
name string
input models.Classification
expectedError error
}
// knn or general
tests := []testcase{
{
name: "missing class",
input: models.Classification{
BasedOnProperties: []string{"description"},
ClassifyProperties: []string{"exactCategory"},
},
expectedError: fmt.Errorf("invalid classification: class must be set"),
},
{
name: "missing basedOnProperty (nil)",
input: models.Classification{
Class: "Article",
BasedOnProperties: nil,
ClassifyProperties: []string{"exactCategory"},
},
expectedError: fmt.Errorf("invalid classification: basedOnProperties must have at least one property"),
},
{
name: "missing basedOnProperty (len=0)",
input: models.Classification{
Class: "Article",
BasedOnProperties: []string{},
ClassifyProperties: []string{"exactCategory"},
},
expectedError: fmt.Errorf("invalid classification: basedOnProperties must have at least one property"),
},
{
name: "more than one basedOnProperty",
input: models.Classification{
Class: "Article",
BasedOnProperties: []string{"description", "name"},
ClassifyProperties: []string{"exactCategory"},
},
expectedError: fmt.Errorf("invalid classification: only a single property in basedOnProperties " +
"supported at the moment, got [description name]"),
},
{
name: "basedOnProperty does not exist",
input: models.Classification{
Class: "Article",
BasedOnProperties: []string{"doesNotExist"},
ClassifyProperties: []string{"exactCategory"},
},
expectedError: fmt.Errorf("invalid classification: basedOnProperties: property 'doesNotExist' does not exist"),
},
{
name: "basedOnProperty is not of type text",
input: models.Classification{
Class: "Article",
BasedOnProperties: []string{"words"},
ClassifyProperties: []string{"exactCategory"},
},
expectedError: fmt.Errorf("invalid classification: basedOnProperties: property 'words' must be of type 'text'"),
},
{
name: "missing classifyProperties (nil)",
input: models.Classification{
Class: "Article",
BasedOnProperties: []string{"description"},
ClassifyProperties: nil,
},
expectedError: fmt.Errorf("invalid classification: classifyProperties must have at least one property"),
},
{
name: "missing classifyProperties (len=0)",
input: models.Classification{
Class: "Article",
BasedOnProperties: []string{"description"},
ClassifyProperties: []string{},
},
expectedError: fmt.Errorf("invalid classification: classifyProperties must have at least one property"),
},
{
name: "classifyProperties does not exist",
input: models.Classification{
Class: "Article",
BasedOnProperties: []string{"description"},
ClassifyProperties: []string{"doesNotExist"},
},
expectedError: fmt.Errorf("invalid classification: classifyProperties: property 'doesNotExist' does not exist"),
},
{
name: "classifyProperties is not of reference type",
input: models.Classification{
Class: "Article",
BasedOnProperties: []string{"description"},
ClassifyProperties: []string{"name"},
},
expectedError: fmt.Errorf("invalid classification: classifyProperties: property 'name' must be of reference type (cref)"),
},
{
name: "multiple missing fields (aborts early as we can't validate properties if class is not set)",
input: models.Classification{},
expectedError: fmt.Errorf("invalid classification: class must be set"),
},
// specific for knn
{
name: "targetWhere is set",
input: models.Classification{
Class: "Article",
BasedOnProperties: []string{"description"},
ClassifyProperties: []string{"exactCategory"},
Filters: &models.ClassificationFilters{
TargetWhere: &models.WhereFilter{Operator: "Equal", Path: []string{"foo"}, ValueText: ptString("bar")},
},
Type: "knn",
},
expectedError: fmt.Errorf("invalid classification: type is 'knn', but 'targetWhere' filter is set, for 'knn' you cannot limit target data directly, instead limit training data through setting 'trainingSetWhere'"),
},
// specific for text2vec-contextionary-contextual
{
name: "classifyProperty has more than one target class",
input: models.Classification{
Class: "Article",
BasedOnProperties: []string{"description"},
ClassifyProperties: []string{"anyCategory"},
Type: "text2vec-contextionary-contextual",
},
expectedError: fmt.Errorf("invalid classification: classifyProperties: property 'anyCategory' has more than one target class, classification of type 'text2vec-contextionary-contextual' requires exactly one target class"),
},
{
name: "trainingSetWhere is set",
input: models.Classification{
Class: "Article",
BasedOnProperties: []string{"description"},
ClassifyProperties: []string{"exactCategory"},
Filters: &models.ClassificationFilters{
TrainingSetWhere: &models.WhereFilter{Operator: "Equal", Path: []string{"foo"}, ValueText: ptString("bar")},
},
Type: "text2vec-contextionary-contextual",
},
expectedError: fmt.Errorf("invalid classification: type is 'text2vec-contextionary-contextual', but 'trainingSetWhere' filter is set, for 'text2vec-contextionary-contextual' there is no training data, instead limit possible target data directly through setting 'targetWhere'"),
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
validator := NewValidator(&fakeSchemaGetter{testSchema()}, test.input)
err := validator.Do()
assert.Equal(t, test.expectedError, err)
})
}
}
func ptString(in string) *string {
return &in
}
|