Spaces:
Running
Running
File size: 5,918 Bytes
b110593 |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 |
// _ _
// __ _____ __ ___ ___ __ _| |_ ___
// \ \ /\ / / _ \/ _` \ \ / / |/ _` | __/ _ \
// \ V V / __/ (_| |\ V /| | (_| | || __/
// \_/\_/ \___|\__,_| \_/ |_|\__,_|\__\___|
//
// Copyright © 2016 - 2024 Weaviate B.V. All rights reserved.
//
// CONTACT: [email protected]
//
package objects
import (
"context"
"errors"
"testing"
"time"
"github.com/go-openapi/strfmt"
"github.com/sirupsen/logrus/hooks/test"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
"github.com/stretchr/testify/require"
"github.com/weaviate/weaviate/entities/models"
"github.com/weaviate/weaviate/entities/schema"
"github.com/weaviate/weaviate/entities/search"
"github.com/weaviate/weaviate/usecases/config"
enthnsw "github.com/weaviate/weaviate/entities/vectorindex/hnsw"
)
func Test_UpdateAction(t *testing.T) {
var (
db *fakeVectorRepo
modulesProvider *fakeModulesProvider
manager *Manager
extender *fakeExtender
projectorFake *fakeProjector
)
schema := schema.Schema{
Objects: &models.Schema{
Classes: []*models.Class{
{
Class: "ActionClass",
VectorIndexConfig: enthnsw.NewDefaultUserConfig(),
Properties: []*models.Property{
{
DataType: schema.DataTypeText.PropString(),
Tokenization: models.PropertyTokenizationWhitespace,
Name: "foo",
},
},
},
},
},
}
reset := func() {
db = &fakeVectorRepo{}
schemaManager := &fakeSchemaManager{
GetSchemaResponse: schema,
}
locks := &fakeLocks{}
cfg := &config.WeaviateConfig{}
cfg.Config.QueryDefaults.Limit = 20
cfg.Config.QueryMaximumResults = 200
authorizer := &fakeAuthorizer{}
logger, _ := test.NewNullLogger()
extender = &fakeExtender{}
projectorFake = &fakeProjector{}
metrics := &fakeMetrics{}
modulesProvider = getFakeModulesProviderWithCustomExtenders(extender, projectorFake)
manager = NewManager(locks, schemaManager, cfg,
logger, authorizer, db, modulesProvider, metrics)
}
t.Run("ensure creation timestamp persists", func(t *testing.T) {
reset()
beforeUpdate := time.Now().UnixNano() / int64(time.Millisecond)
id := strfmt.UUID("34e9df15-0c3b-468d-ab99-f929662834c7")
vec := []float32{0, 1, 2}
result := &search.Result{
ID: id,
ClassName: "ActionClass",
Schema: map[string]interface{}{"foo": "bar"},
Created: beforeUpdate,
Updated: beforeUpdate,
}
db.On("ObjectByID", id, mock.Anything, mock.Anything).Return(result, nil).Once()
modulesProvider.On("UpdateVector", mock.Anything, mock.AnythingOfType(FindObjectFn)).
Return(vec, nil)
db.On("PutObject", mock.Anything, mock.Anything).Return(nil).Once()
payload := &models.Object{
Class: "ActionClass",
ID: id,
Properties: map[string]interface{}{"foo": "baz"},
}
res, err := manager.UpdateObject(context.Background(), &models.Principal{}, "", id, payload, nil)
require.Nil(t, err)
expected := &models.Object{
Class: "ActionClass",
ID: id,
Properties: map[string]interface{}{"foo": "baz"},
CreationTimeUnix: beforeUpdate,
}
afterUpdate := time.Now().UnixNano() / int64(time.Millisecond)
assert.Equal(t, expected.Class, res.Class)
assert.Equal(t, expected.ID, res.ID)
assert.Equal(t, expected.Properties, res.Properties)
assert.Equal(t, expected.CreationTimeUnix, res.CreationTimeUnix)
assert.GreaterOrEqual(t, res.LastUpdateTimeUnix, beforeUpdate)
assert.LessOrEqual(t, res.LastUpdateTimeUnix, afterUpdate)
})
}
func Test_UpdateObject(t *testing.T) {
var (
cls = "MyClass"
id = strfmt.UUID("34e9df15-0c3b-468d-ab99-f929662834c7")
beforeUpdate = (time.Now().UnixNano() - 2*int64(time.Millisecond)) / int64(time.Millisecond)
vec = []float32{0, 1, 2}
anyErr = errors.New("any error")
)
schema := schema.Schema{
Objects: &models.Schema{
Classes: []*models.Class{
{
Class: cls,
VectorIndexConfig: enthnsw.NewDefaultUserConfig(),
Properties: []*models.Property{
{
DataType: schema.DataTypeText.PropString(),
Tokenization: models.PropertyTokenizationWhitespace,
Name: "foo",
},
},
},
},
},
}
m := newFakeGetManager(schema)
payload := &models.Object{
Class: cls,
ID: id,
Properties: map[string]interface{}{"foo": "baz"},
}
// the object might not exist
m.repo.On("Object", cls, id, mock.Anything, mock.Anything, "").Return(nil, anyErr).Once()
_, err := m.UpdateObject(context.Background(), &models.Principal{}, cls, id, payload, nil)
if err == nil {
t.Fatalf("must return an error if object() fails")
}
result := &search.Result{
ID: id,
ClassName: cls,
Schema: map[string]interface{}{"foo": "bar"},
Created: beforeUpdate,
Updated: beforeUpdate,
}
m.repo.On("Object", cls, id, mock.Anything, mock.Anything, "").Return(result, nil).Once()
m.modulesProvider.On("UpdateVector", mock.Anything, mock.AnythingOfType(FindObjectFn)).
Return(vec, nil)
m.repo.On("PutObject", mock.Anything, mock.Anything).Return(nil).Once()
expected := &models.Object{
Class: cls,
ID: id,
Properties: map[string]interface{}{"foo": "baz"},
CreationTimeUnix: beforeUpdate,
Vector: vec,
}
res, err := m.UpdateObject(context.Background(), &models.Principal{}, cls, id, payload, nil)
require.Nil(t, err)
if res.LastUpdateTimeUnix <= beforeUpdate {
t.Error("time after update must be greater than time before update ")
}
res.LastUpdateTimeUnix = 0 // to allow for equality
assert.Equal(t, expected, res)
}
|