Spaces:
Running
Running
File size: 13,583 Bytes
b110593 |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 |
// _ _
// __ _____ __ ___ ___ __ _| |_ ___
// \ \ /\ / / _ \/ _` \ \ / / |/ _` | __/ _ \
// \ V V / __/ (_| |\ V /| | (_| | || __/
// \_/\_/ \___|\__,_| \_/ |_|\__,_|\__\___|
//
// Copyright © 2016 - 2024 Weaviate B.V. All rights reserved.
//
// CONTACT: [email protected]
//
package vectorizer
import (
"context"
"testing"
"github.com/sirupsen/logrus"
ltest "github.com/sirupsen/logrus/hooks/test"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/weaviate/weaviate/entities/models"
"github.com/weaviate/weaviate/entities/schema"
)
func TestConfigValidator(t *testing.T) {
t.Run("validate class names", func(t *testing.T) {
type testCase struct {
input string
valid bool
name string
vectorize bool
}
// for all test cases keep in mind that the word "carrot" is not present in
// the fake c11y, but every other word is.
//
// Additionally, the word "the" is a stopword
//
// all inputs represent class names (!)
tests := []testCase{
// valid names
{
name: "Single uppercase word present in the c11y",
input: "Car",
valid: true,
vectorize: true,
},
{
name: "Single lowercase word present in the c11y, stored as uppercase",
input: "car",
valid: true,
vectorize: true,
},
{
name: "combination of valid words starting with uppercase letter",
input: "CarGarage",
valid: true,
vectorize: true,
},
{
name: "combination of valid words starting with lowercase letter, stored as uppercase",
input: "carGarage",
valid: true,
vectorize: true,
},
{
name: "combination of valid words and stopwords, starting with uppercase",
input: "TheCarGarage",
valid: true,
vectorize: true,
},
{
name: "combination of valid words and stopwords starting with lowercase letter, stored as uppercase",
input: "carTheGarage",
valid: true,
vectorize: true,
},
// invalid names
{
name: "Single uppercase word NOT present in the c11y",
input: "Carrot",
valid: false,
vectorize: true,
},
{
name: "Single lowercase word NOT present in the c11y",
input: "carrot",
valid: false,
vectorize: true,
},
{
name: "Single uppercase stopword",
input: "The",
valid: false,
vectorize: true,
},
{
name: "Single lowercase stopword",
input: "the",
valid: false,
vectorize: true,
},
{
name: "combination of valid and invalid words, valid word first lowercased",
input: "potatoCarrot",
valid: false,
vectorize: true,
},
{
name: "combination of valid and invalid words, valid word first uppercased",
input: "PotatoCarrot",
valid: false,
vectorize: true,
},
{
name: "combination of valid and invalid words, invalid word first lowercased",
input: "carrotPotato",
valid: false,
vectorize: true,
},
{
name: "combination of valid and invalid words, invalid word first uppercased",
input: "CarrotPotato",
valid: false,
vectorize: true,
},
{
name: "combination of only stopwords, starting with lowercase",
input: "theThe",
valid: false,
vectorize: true,
},
{
name: "combination of only stopwords, starting with uppercase",
input: "TheThe",
valid: false,
vectorize: true,
},
// vectorize turned off
{
name: "non-vectorized: combination of only stopwords, starting with uppercase",
input: "TheThe",
valid: true,
vectorize: false,
},
{
name: "non-vectorized: excluded word",
input: "carrot",
valid: true,
vectorize: false,
},
}
for _, test := range tests {
t.Run(test.name+" object class", func(t *testing.T) {
class := &models.Class{
Class: test.input,
Properties: []*models.Property{{
Name: "dummyPropSoWeDontRunIntoAllNoindexedError",
DataType: schema.DataTypeText.PropString(),
Tokenization: models.PropertyTokenizationWhitespace,
}},
}
logger, _ := ltest.NewNullLogger()
v := NewConfigValidator(&fakeRemote{}, logger)
err := v.Do(context.Background(), class, nil, &fakeIndexChecker{
vectorizeClassName: test.vectorize,
propertyIndexed: true,
})
assert.Equal(t, test.valid, err == nil)
// only proceed if input was supposed to be valid
if test.valid == false {
return
}
})
}
})
t.Run("validate property names", func(t *testing.T) {
type testCase struct {
input string
valid bool
name string
vectorize bool
}
// for all test cases keep in mind that the word "carrot" is not present in
// the fake c11y, but every other word is
//
// all inputs represent property names (!)
tests := []testCase{
// valid names
{
name: "Single uppercase word present in the c11y, stored as lowercase",
input: "Brand",
valid: true,
vectorize: true,
},
{
name: "Single lowercase word present in the c11y",
input: "brand",
valid: true,
vectorize: true,
},
{
name: "combination of valid words starting with uppercase letter, stored as lowercase",
input: "BrandGarage",
valid: true,
vectorize: true,
},
{
name: "combination of valid words starting with lowercase letter",
input: "brandGarage",
valid: true,
vectorize: true,
},
{
name: "combination of valid words and stop words starting with uppercase letter, stored as lowercase",
input: "TheGarage",
valid: true,
vectorize: true,
},
{
name: "combination of valid words and stop words starting with lowercase letter",
input: "theGarage",
valid: true,
vectorize: true,
},
// invalid names
{
name: "Single uppercase word NOT present in the c11y",
input: "Carrot",
valid: false,
vectorize: true,
},
{
name: "Single lowercase word NOT present in the c11y",
input: "carrot",
valid: false,
vectorize: true,
},
{
name: "Single lowercase stop word",
input: "the",
valid: false,
vectorize: true,
},
{
name: "combination of valid and invalid words, valid word first lowercased",
input: "potatoCarrot",
valid: false,
vectorize: true,
},
{
name: "combination of valid and invalid words, valid word first uppercased",
input: "PotatoCarrot",
valid: false,
vectorize: true,
},
{
name: "combination of valid and invalid words, invalid word first lowercased",
input: "carrotPotato",
valid: false,
vectorize: true,
},
{
name: "combination of valid and invalid words, invalid word first uppercased",
input: "CarrotPotato",
valid: false,
vectorize: true,
},
{
name: "combination of only stop words, first lowercased",
input: "theThe",
valid: false,
vectorize: true,
},
{
name: "combination of only stop words, first uppercased",
input: "TheThe",
valid: false,
vectorize: true,
},
// without vectorizing
{
name: "non-vectorizing: combination of only stop words, first uppercased",
input: "TheThe",
valid: true,
vectorize: false,
},
{
name: "non-vectorizing: combination of only stop words, first uppercased",
input: "carrot",
valid: true,
vectorize: false,
},
}
for _, test := range tests {
t.Run(test.name+" object class", func(t *testing.T) {
class := &models.Class{
Class: "ValidName",
Properties: []*models.Property{{
DataType: schema.DataTypeText.PropString(),
Tokenization: models.PropertyTokenizationWhitespace,
Name: test.input,
}},
}
logger, _ := ltest.NewNullLogger()
v := NewConfigValidator(&fakeRemote{}, logger)
err := v.Do(context.Background(), class, nil, &fakeIndexChecker{
vectorizePropertyName: test.vectorize,
propertyIndexed: true,
})
assert.Equal(t, test.valid, err == nil)
})
}
})
t.Run("all usable props no-indexed", func(t *testing.T) {
t.Run("all schema vectorization turned off", func(t *testing.T) {
class := &models.Class{
Vectorizer: "text2vec-contextionary",
Class: "ValidName",
Properties: []*models.Property{
{
DataType: []string{"text"},
Name: "description",
},
{
DataType: schema.DataTypeText.PropString(),
Tokenization: models.PropertyTokenizationWhitespace,
Name: "name",
},
{
DataType: []string{"int"},
Name: "amount",
},
},
}
logger, _ := ltest.NewNullLogger()
v := NewConfigValidator(&fakeRemote{}, logger)
err := v.Do(context.Background(), class, nil, &fakeIndexChecker{
vectorizePropertyName: false,
vectorizeClassName: false,
propertyIndexed: false,
})
assert.NotNil(t, err)
})
})
t.Run("with only array types", func(t *testing.T) {
class := &models.Class{
Vectorizer: "text2vec-contextionary",
Class: "ValidName",
Properties: []*models.Property{
{
DataType: []string{"text[]"},
Name: "descriptions",
},
{
DataType: schema.DataTypeTextArray.PropString(),
Tokenization: models.PropertyTokenizationWhitespace,
Name: "names",
},
},
}
logger, _ := ltest.NewNullLogger()
v := NewConfigValidator(&fakeRemote{}, logger)
err := v.Do(context.Background(), class, nil, &fakeIndexChecker{
vectorizePropertyName: false,
vectorizeClassName: false,
propertyIndexed: true,
})
assert.Nil(t, err)
})
}
func TestConfigValidator_RiskOfDuplicateVectors(t *testing.T) {
type test struct {
name string
in *models.Class
expectWarning bool
indexChecker *fakeIndexChecker
}
tests := []test{
{
name: "usable properties",
in: &models.Class{
Class: "ValidName",
Properties: []*models.Property{
{
DataType: []string{string(schema.DataTypeText)},
Name: "textProp",
},
},
},
expectWarning: false,
indexChecker: &fakeIndexChecker{
vectorizePropertyName: false,
vectorizeClassName: true,
propertyIndexed: true,
},
},
{
name: "no properties",
in: &models.Class{
Class: "ValidName",
},
expectWarning: true,
indexChecker: &fakeIndexChecker{
vectorizePropertyName: false,
vectorizeClassName: true,
propertyIndexed: false,
},
},
{
name: "usable properties, but they are no-indexed",
in: &models.Class{
Class: "ValidName",
Properties: []*models.Property{
{
DataType: []string{string(schema.DataTypeText)},
Name: "textProp",
},
},
},
expectWarning: true,
indexChecker: &fakeIndexChecker{
vectorizePropertyName: false,
vectorizeClassName: true,
propertyIndexed: false,
},
},
{
name: "only unusable properties",
in: &models.Class{
Class: "ValidName",
Properties: []*models.Property{
{
DataType: []string{string(schema.DataTypeInt)},
Name: "intProp",
},
},
},
expectWarning: true,
indexChecker: &fakeIndexChecker{
vectorizePropertyName: false,
vectorizeClassName: true,
propertyIndexed: false,
},
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
logger, hook := ltest.NewNullLogger()
v := NewConfigValidator(&fakeRemote{}, logger)
err := v.Do(context.Background(), test.in, nil, test.indexChecker)
require.Nil(t, err)
entry := hook.LastEntry()
if test.expectWarning {
require.NotNil(t, entry)
assert.Equal(t, logrus.WarnLevel, entry.Level)
} else {
assert.Nil(t, entry)
}
})
}
}
type fakeIndexChecker struct {
vectorizeClassName bool
vectorizePropertyName bool
propertyIndexed bool
}
func (f *fakeIndexChecker) VectorizeClassName() bool {
return f.vectorizeClassName
}
func (f *fakeIndexChecker) VectorizePropertyName(propName string) bool {
return f.vectorizePropertyName
}
func (f *fakeIndexChecker) PropertyIndexed(propName string) bool {
return f.propertyIndexed
}
// Every word in this fake c11y remote client is present except for the word
// Carrot which is not present
type fakeRemote struct{}
func (f *fakeRemote) IsWordPresent(ctx context.Context, word string) (bool, error) {
if word == "carrot" || word == "the" {
return false, nil
}
return true, nil
}
func (f *fakeRemote) IsStopWord(ctx context.Context, word string) (bool, error) {
return word == "the", nil
}
|