Spaces:
Running
Running
File size: 12,164 Bytes
b110593 |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 |
// _ _
// __ _____ __ ___ ___ __ _| |_ ___
// \ \ /\ / / _ \/ _` \ \ / / |/ _` | __/ _ \
// \ V V / __/ (_| |\ V /| | (_| | || __/
// \_/\_/ \___|\__,_| \_/ |_|\__,_|\__\___|
//
// Copyright © 2016 - 2024 Weaviate B.V. All rights reserved.
//
// CONTACT: [email protected]
//
package schema
import (
"context"
"encoding/json"
"testing"
"github.com/pkg/errors"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/weaviate/weaviate/entities/models"
"github.com/weaviate/weaviate/entities/schema"
"github.com/weaviate/weaviate/usecases/config"
)
// As of now, most class settings are immutable, but we need to allow some
// specific updates, such as the vector index config
func TestClassUpdates(t *testing.T) {
t.Run("a class which doesn't exist", func(t *testing.T) {
err := newSchemaManager().UpdateClass(context.Background(),
nil, "WrongClass", &models.Class{})
require.NotNil(t, err)
assert.Equal(t, ErrNotFound, err)
})
t.Run("various immutable and mutable fields", func(t *testing.T) {
type test struct {
name string
initial *models.Class
update *models.Class
expectedError error
}
tests := []test{
{
name: "attempting a name change",
initial: &models.Class{Class: "InitialName"},
update: &models.Class{Class: "UpdatedName"},
expectedError: errors.Errorf(
"class name is immutable: " +
"attempted change from \"InitialName\" to \"UpdatedName\""),
},
{
name: "attempting to modify the vectorizer",
initial: &models.Class{Class: "InitialName", Vectorizer: "model1"},
update: &models.Class{Class: "InitialName", Vectorizer: "model2"},
expectedError: errors.Errorf(
"vectorizer is immutable: " +
"attempted change from \"model1\" to \"model2\""),
},
{
name: "attempting to modify the vector index type",
initial: &models.Class{Class: "InitialName", VectorIndexType: "hnsw"},
update: &models.Class{Class: "InitialName", VectorIndexType: "lsh"},
expectedError: errors.Errorf(
"vector index type is immutable: " +
"attempted change from \"hnsw\" to \"lsh\""),
},
{
name: "attempting to add a property",
initial: &models.Class{Class: "InitialName"},
update: &models.Class{
Class: "InitialName",
Properties: []*models.Property{
{
Name: "newProp",
},
},
},
expectedError: errors.Errorf(
"properties cannot be updated through updating the class. Use the add " +
"property feature (e.g. \"POST /v1/schema/{className}/properties\") " +
"to add additional properties"),
},
{
name: "leaving properties unchanged",
initial: &models.Class{
Class: "InitialName",
Properties: []*models.Property{
{
Name: "aProp",
DataType: schema.DataTypeText.PropString(),
},
},
},
update: &models.Class{
Class: "InitialName",
Properties: []*models.Property{
{
Name: "aProp",
DataType: schema.DataTypeText.PropString(),
},
},
},
expectedError: nil,
},
{
name: "attempting to rename a property",
initial: &models.Class{
Class: "InitialName",
Properties: []*models.Property{
{
Name: "aProp",
DataType: schema.DataTypeText.PropString(),
},
},
},
update: &models.Class{
Class: "InitialName",
Properties: []*models.Property{
{
Name: "changedProp",
DataType: schema.DataTypeText.PropString(),
},
},
},
expectedError: errors.Errorf(
"properties cannot be updated through updating the class. Use the add " +
"property feature (e.g. \"POST /v1/schema/{className}/properties\") " +
"to add additional properties"),
},
{
name: "attempting to update the inverted index cleanup interval",
initial: &models.Class{
Class: "InitialName",
InvertedIndexConfig: &models.InvertedIndexConfig{
CleanupIntervalSeconds: 17,
},
},
update: &models.Class{
Class: "InitialName",
InvertedIndexConfig: &models.InvertedIndexConfig{
CleanupIntervalSeconds: 18,
Bm25: &models.BM25Config{
K1: config.DefaultBM25k1,
B: config.DefaultBM25b,
},
},
},
},
{
name: "attempting to update the inverted index BM25 config",
initial: &models.Class{
Class: "InitialName",
InvertedIndexConfig: &models.InvertedIndexConfig{
CleanupIntervalSeconds: 18,
Bm25: &models.BM25Config{
K1: 1.012,
B: 0.125,
},
},
},
update: &models.Class{
Class: "InitialName",
InvertedIndexConfig: &models.InvertedIndexConfig{
CleanupIntervalSeconds: 18,
Bm25: &models.BM25Config{
K1: 1.012,
B: 0.125,
},
},
},
},
{
name: "attempting to update the inverted index Stopwords config",
initial: &models.Class{
Class: "InitialName",
InvertedIndexConfig: &models.InvertedIndexConfig{
CleanupIntervalSeconds: 18,
Stopwords: &models.StopwordConfig{
Preset: "en",
},
},
},
update: &models.Class{
Class: "InitialName",
InvertedIndexConfig: &models.InvertedIndexConfig{
CleanupIntervalSeconds: 18,
Stopwords: &models.StopwordConfig{
Preset: "none",
Additions: []string{"banana", "passionfruit", "kiwi"},
Removals: []string{"a", "the"},
},
},
},
},
{
name: "attempting to update module config",
initial: &models.Class{
Class: "InitialName",
ModuleConfig: map[string]interface{}{
"my-module1": map[string]interface{}{
"my-setting": "some-value",
},
},
},
update: &models.Class{
Class: "InitialName",
ModuleConfig: map[string]interface{}{
"my-module1": map[string]interface{}{
"my-setting": "updated-value",
},
},
},
expectedError: errors.Errorf("module config is immutable"),
},
{
name: "updating vector index config",
initial: &models.Class{
Class: "InitialName",
VectorIndexConfig: map[string]interface{}{
"some-setting": "old-value",
},
},
update: &models.Class{
Class: "InitialName",
VectorIndexConfig: map[string]interface{}{
"some-setting": "new-value",
},
},
expectedError: nil,
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
sm := newSchemaManager()
assert.Nil(t, sm.AddClass(context.Background(), nil, test.initial))
err := sm.UpdateClass(context.Background(), nil, test.initial.Class, test.update)
if test.expectedError == nil {
assert.Nil(t, err)
} else {
require.NotNil(t, err, "update must error")
assert.Equal(t, test.expectedError.Error(), err.Error())
}
})
}
})
t.Run("update vector index config", func(t *testing.T) {
t.Run("with a validation error", func(t *testing.T) {
sm := newSchemaManager()
migrator := &configMigrator{
vectorConfigValidationError: errors.Errorf("don't think so!"),
}
sm.migrator = migrator
t.Run("create an initial class", func(t *testing.T) {
err := sm.AddClass(context.Background(), nil, &models.Class{
Class: "ClassWithVectorIndexConfig",
VectorIndexConfig: map[string]interface{}{
"setting-1": "value-1",
},
})
assert.Nil(t, err)
})
t.Run("attempt an update of the vector index config", func(t *testing.T) {
err := sm.UpdateClass(context.Background(), nil,
"ClassWithVectorIndexConfig", &models.Class{
Class: "ClassWithVectorIndexConfig",
VectorIndexConfig: map[string]interface{}{
"setting-1": "updated-value",
},
})
expectedErrMsg := "vector index config: don't think so!"
expectedValidateCalledWith := fakeVectorConfig{
raw: map[string]interface{}{
"distance": "cosine",
"setting-1": "updated-value",
},
}
expectedUpdateCalled := false
require.NotNil(t, err)
assert.Equal(t, expectedErrMsg, err.Error())
assert.Equal(t, expectedValidateCalledWith, migrator.vectorConfigValidateCalledWith)
assert.Equal(t, expectedUpdateCalled, migrator.vectorConfigUpdateCalled)
})
})
t.Run("with a valid update", func(t *testing.T) {
sm := newSchemaManager()
migrator := &configMigrator{}
sm.migrator = migrator
t.Run("create an initial class", func(t *testing.T) {
err := sm.AddClass(context.Background(), nil, &models.Class{
Class: "ClassWithVectorIndexConfig",
VectorIndexConfig: map[string]interface{}{
"setting-1": "value-1",
},
})
assert.Nil(t, err)
})
t.Run("update the vector index config", func(t *testing.T) {
err := sm.UpdateClass(context.Background(), nil,
"ClassWithVectorIndexConfig", &models.Class{
Class: "ClassWithVectorIndexConfig",
VectorIndexConfig: map[string]interface{}{
"setting-1": "updated-value",
},
})
expectedValidateCalledWith := fakeVectorConfig{
raw: map[string]interface{}{
"distance": "cosine",
"setting-1": "updated-value",
},
}
expectedUpdateCalledWith := fakeVectorConfig{
raw: map[string]interface{}{
"distance": "cosine",
"setting-1": "updated-value",
},
}
expectedUpdateCalled := true
require.Nil(t, err)
assert.Equal(t, expectedValidateCalledWith, migrator.vectorConfigValidateCalledWith)
assert.Equal(t, expectedUpdateCalledWith, migrator.vectorConfigUpdateCalledWith)
assert.Equal(t, expectedUpdateCalled, migrator.vectorConfigUpdateCalled)
})
t.Run("the update is reflected", func(t *testing.T) {
class := sm.getClassByName("ClassWithVectorIndexConfig")
require.NotNil(t, class)
expectedVectorIndexConfig := fakeVectorConfig{
raw: map[string]interface{}{
"distance": "cosine",
"setting-1": "updated-value",
},
}
assert.Equal(t, expectedVectorIndexConfig, class.VectorIndexConfig)
})
})
})
t.Run("update sharding config", func(t *testing.T) {
t.Run("with a validation error (immutable field)", func(t *testing.T) {
sm := newSchemaManager()
migrator := &NilMigrator{}
sm.migrator = migrator
t.Run("create an initial class", func(t *testing.T) {
err := sm.AddClass(context.Background(), nil, &models.Class{
Class: "ClassWithShardingConfig",
})
assert.Nil(t, err)
})
t.Run("attempt an update of the vector index config", func(t *testing.T) {
err := sm.UpdateClass(context.Background(), nil,
"ClassWithShardingConfig", &models.Class{
Class: "ClassWithShardingConfig",
ShardingConfig: map[string]interface{}{
"desiredCount": json.Number("7"),
},
})
expectedErrMsg := "re-sharding not supported yet: shard count is immutable: attempted change from \"1\" to \"7\""
require.NotNil(t, err)
assert.Contains(t, err.Error(), expectedErrMsg)
})
})
})
}
type configMigrator struct {
NilMigrator
vectorConfigValidationError error
vectorConfigValidateCalledWith schema.VectorIndexConfig
vectorConfigUpdateCalled bool
vectorConfigUpdateCalledWith schema.VectorIndexConfig
}
func (m *configMigrator) ValidateVectorIndexConfigUpdate(ctx context.Context,
old, updated schema.VectorIndexConfig,
) error {
m.vectorConfigValidateCalledWith = updated
return m.vectorConfigValidationError
}
func (m *configMigrator) UpdateVectorIndexConfig(ctx context.Context,
className string, updated schema.VectorIndexConfig,
) error {
m.vectorConfigUpdateCalledWith = updated
m.vectorConfigUpdateCalled = true
return nil
}
|