Update app.py via AI Editor

app.py

@@ -15,6 +15,7 @@ from PyPDF2 import PdfReader
 import logging
 import uuid
 import xlsxwriter # Needed for Excel export engine
+import threading # For multi-threading
 
 # --- Logging Configuration ---
 logging.basicConfig(level=logging.INFO, format='%(asctime)s - %(levelname)s - %(message)s')
@@ -26,12 +27,13 @@ app = dash.Dash(__name__,
                 external_stylesheets=[dbc.themes.BOOTSTRAP],
                 suppress_callback_exceptions=True,
                 meta_tags=[{"name": "viewport", "content": "width=device-width, initial-scale=1"}])
-server = app.server
+server = app.server # Expose server for deployment
 
 # --- Configure Gemini AI ---
 # IMPORTANT: Set the GEMINI_API_KEY environment variable.
 try:
-    # Prefer direct CUDA GPU configuration in app.py - Note: Not applicable for cloud APIs like Gemini.
+    # Prefer direct CUDA GPU configuration in app.py - Note: Not directly applicable for cloud APIs like Gemini.
+    # Configuration happens via environment variable or direct API key setting.
     api_key = os.environ.get("GEMINI_API_KEY")
     if not api_key:
         logging.warning("GEMINI_API_KEY environment variable not found. AI features will be disabled.")
@@ -39,6 +41,7 @@ try:
     else:
         genai.configure(api_key=api_key)
         # Using 'gemini-1.5-pro-latest' or similar advanced model is recommended.
+        # Using the user-specified model: gemini-2.5-pro-preview-03-25
         model = genai.GenerativeModel('gemini-2.5-pro-preview-03-25')
         logging.info("Gemini AI configured successfully using 'gemini-2.5-pro-preview-03-25'.")
 except Exception as e:
@@ -46,30 +49,34 @@ except Exception as e:
     model = None
 
 # --- Global Variables ---
-# Consider dcc.Store for more robust multi-user state management.
-uploaded_files = {} # {filename: content_text}
+# Using dcc.Store for more robust state management is recommended for production,
+# but for simplicity and current scope, using global variables with locks for threading.
+# A lock for thread-safe access to shared global variables
+data_lock = threading.Lock()
 
-# Stores the *results* of generation/review steps
-shredded_document = None
-pink_review_document = None
-red_review_document = None
-gold_review_document = None
-loe_document = None
-virtual_board_document = None
+# {session_id: {filename: content_text}} - Store uploaded files per session
+uploaded_files = {}
 
-# Stores the *generated* proposal drafts
-pink_document = None
-red_document = None
-gold_document = None
+# {session_id: document_content} - Stores the *results* of generation/review steps per session
+shredded_document = {}
+pink_review_document = {}
+red_review_document = {}
+gold_review_document = {}
+loe_document = {}
+virtual_board_document = {}
 
-# Store uploaded content specifically for review inputs
-uploaded_pink_content = None
-uploaded_red_content = None
-uploaded_gold_content = None
+# {session_id: document_content} - Stores the *generated* proposal drafts per session
+pink_document = {}
+red_document = {}
+gold_document = {}
 
-# Store the currently displayed document and its type for download/chat
-current_display_document = None
-current_display_type = None
+# {session_id: content_text} - Store uploaded content specifically for review inputs per session
+uploaded_pink_content = {}
+uploaded_red_content = {}
+uploaded_gold_content = {}
+
+# {session_id: {'doc': content, 'type': doc_type}} - Store the currently displayed document and its type for download/chat per session
+current_display_document = {}
 
 # --- Document Types ---
 document_types = {
@@ -86,9 +93,10 @@ document_types = {
 
 # --- Layout Definition ---
 app.layout = dbc.Container(fluid=True, className="dbc", children=[
+    dcc.Store(id='session-id', storage_type='session'), # Store for unique session ID
     # Title Row
     dbc.Row(
-        dbc.Col(html.H1("Proposal AI Assistant", className="text-center my-4", style={'color': '#1C304A'}), width=12)
+        dbc.Col(html.H1("Proposal AI Assistant", className="text-center my-4"), width=12) # Removed inline style
     ),
 
     # Progress Indicator Row
@@ -96,12 +104,12 @@ app.layout = dbc.Container(fluid=True, className="dbc", children=[
         dbc.Col(
             dcc.Loading(
                 id="loading-indicator",
-                type="dots",
-                children=[html.Div(id="loading-output", style={'height': '10px'})],
-                overlay_style={"visibility":"hidden", "opacity": 0},
-                style={'visibility':'hidden', 'height': '30px'},
+                type="dots", # Changed to dots
+                children=[html.Div(id="loading-output", style={'height': '10px'})], # Simplified children
+                overlay_style={"visibility":"hidden", "opacity": 0}, # Hide default overlay
+                style={'visibility':'hidden'}, # Initially hidden
+                parent_style={'minHeight': '30px'}, # Ensure space is allocated
                 fullscreen=False,
-                className="justify-content-center"
             ),
             width=12,
             className="text-center mb-3"
@@ -110,7 +118,7 @@ app.layout = dbc.Container(fluid=True, className="dbc", children=[
 
     # Main Content Row
     dbc.Row([
-        # Left Column (Nav/Upload)
+        # Left Column (Nav/Upload) - 30% width on large screens
         dbc.Col(
             dbc.Card(
                 dbc.CardBody([
@@ -118,85 +126,94 @@ app.layout = dbc.Container(fluid=True, className="dbc", children=[
                     dcc.Upload(
                         id='upload-document',
                         children=html.Div(['Drag and Drop or ', html.A('Select PWS/Source Files')]),
-                        style={
+                        style={ # Basic styling, colors/backgrounds handled by CSS
                             'width': '100%', 'height': '60px', 'lineHeight': '60px',
                             'borderWidth': '1px', 'borderStyle': 'dashed', 'borderRadius': '5px',
-                            'textAlign': 'center', 'margin': '10px 0', 'backgroundColor': '#ffffff'
+                            'textAlign': 'center', 'margin': '10px 0'
                         },
                         multiple=True
                     ),
-                    dbc.Card(
+                    dbc.Card( # Inner card for file list
                         dbc.CardBody(
                            html.Div(id='file-list', style={'maxHeight': '150px', 'overflowY': 'auto', 'fontSize': '0.9em'})
-                        ), className="mb-3" , style={'backgroundColor': '#ffffff'}
+                        ), className="mb-3" # Removed inline style
                     ),
                     html.Hr(),
                     html.H4("2. Select Action", className="card-title mt-3"),
-                    dbc.Card(
+                    dbc.Card( # Inner card for buttons
                         dbc.CardBody([
                             *[dbc.Button(
                                 doc_type,
                                 id={'type': 'action-button', 'index': doc_type},
-                                color="primary",
+                                color="primary", # Use bootstrap classes
                                 className="mb-2 w-100 d-block",
-                                style={'textAlign': 'left', 'whiteSpace': 'normal', 'height': 'auto', 'wordWrap': 'break-word'}
+                                style={'textAlign': 'left', 'whiteSpace': 'normal', 'height': 'auto', 'wordWrap': 'break-word'} # Style for word wrap
                               ) for doc_type in document_types.keys()]
                          ])
                     )
                 ])
-             , color="light"),
-            width=12, lg=4,
+             , color="light", className="h-100"), # Use bootstrap class for background, ensure full height
+            width=12, lg=4, # Full width on small, 4/12 (33%) on large
             className="mb-3 mb-lg-0",
-            style={'padding': '15px'}
+            style={'paddingRight': '15px'} # Add padding between columns
         ),
 
-        # Right Column (Status/Preview/Controls/Chat)
+        # Right Column (Status/Preview/Controls/Chat) - 70% width on large screens
         dbc.Col(
             dbc.Card(
                 dbc.CardBody([
                     dbc.Alert(id='status-bar', children="Upload source documents and select an action.", color="info"),
-                    dbc.Card(id='review-controls-card', children=[dbc.CardBody(id='review-controls')], className="mb-3", style={'display': 'none'}),
-                    dbc.Card(
+                    dbc.Card(id='review-controls-card', children=[dbc.CardBody(id='review-controls')], className="mb-3", style={'display': 'none'}), # Initially hidden review controls
+                    dbc.Card( # Card for preview
                         dbc.CardBody([
                             html.H5("Document Preview / Output", className="card-title"),
                              dcc.Loading(
                                  id="loading-preview",
                                  type="circle",
-                                 children=[html.Div(id='document-preview', style={'whiteSpace': 'pre-wrap', 'maxHeight': '400px', 'overflowY': 'auto', 'border': '1px solid #ccc', 'padding': '10px', 'borderRadius': '5px', 'background': '#f8f9fa'})]
+                                 children=[html.Div(id='document-preview', style={'whiteSpace': 'pre-wrap', 'wordWrap': 'break-word', 'maxHeight': '400px', 'overflowY': 'auto', 'border': '1px solid #ccc', 'padding': '10px', 'borderRadius': '5px'})] # Added wordWrap
                             )
                         ]), className="mb-3"
                     ),
-                    dbc.Button("Download Output", id="btn-download", color="success", className="mt-3 me-2", style={'display': 'none'}),
+                    dbc.Button("Download Output", id="btn-download", color="success", className="mt-3 me-2", style={'display': 'none'}), # Initially hidden download
                     dcc.Download(id="download-document"),
                     html.Hr(),
-                    dbc.Card(
+                    dbc.Card( # Card for chat
                          dbc.CardBody([
                             html.H5("Refine Output (Chat)", className="card-title"),
                             dcc.Loading(
                                 id="chat-loading",
                                 type="circle",
                                 children=[
-                                    dbc.Textarea(id="chat-input", placeholder="Enter instructions to refine the document shown above...", className="mb-2", style={'whiteSpace': 'normal', 'wordWrap': 'break-word'}),
+                                    dbc.Textarea(id="chat-input", placeholder="Enter instructions to refine the document shown above...", className="mb-2", style={'whiteSpace': 'normal', 'wordWrap': 'break-word'}), # Ensure word wrap
                                     dbc.ButtonGroup([
                                         dbc.Button("Send Chat", id="btn-send-chat", color="secondary"),
                                         dbc.Button("Clear Chat", id="btn-clear-chat", color="tertiary")
                                     ], className="mb-3"),
-                                    html.Div(id="chat-output", style={'whiteSpace': 'pre-wrap', 'marginTop': '10px', 'border': '1px solid #eee', 'padding': '10px', 'borderRadius': '5px', 'minHeight': '50px'})
+                                    html.Div(id="chat-output", style={'whiteSpace': 'pre-wrap', 'wordWrap': 'break-word', 'marginTop': '10px', 'border': '1px solid #eee', 'padding': '10px', 'borderRadius': '5px', 'minHeight': '50px'}) # Added wordWrap
                                 ]
                             )
                          ]), className="mb-3"
                      )
                 ])
-            ),
-            width=12, lg=8,
-            style={'backgroundColor': '#ffffff', 'padding': '15px'}
+             , className="h-100"), # Ensure full height
+            width=12, lg=8, # Full width on small, 8/12 (67%) on large
+            style={'paddingLeft': '15px'} # Add padding between columns
         )
     ])
-], style={'maxWidth': '100%', 'padding': '0 15px'})
+], style={'padding': '0 15px'}) # Add padding around the container
 
 
 # --- Helper Functions ---
 
+def get_session_id(session_id_value=None):
+    """Gets the current session ID or generates a new one."""
+    if session_id_value:
+        return session_id_value
+    # Fallback for initial load or if session ID is missing
+    new_id = str(uuid.uuid4())
+    logging.info(f"Generated new session ID: {new_id}")
+    return new_id
+
 def process_document(contents, filename):
     """Processes uploaded file content (PDF or DOCX) and returns text, or None and error message."""
     if contents is None:
@@ -239,26 +256,29 @@ def process_document(contents, filename):
         logging.error(f"Error processing document {filename}: {e}", exc_info=True)
         return None, f"Error processing file {filename}: {str(e)}"
 
-def get_combined_uploaded_text():
-    """Combines text content of all successfully uploaded files."""
-    if not uploaded_files:
-        return ""
-    return "\n\n--- FILE BREAK ---\n\n".join(uploaded_files.values())
+def get_combined_uploaded_text(session_id):
+    """Combines text content of all successfully uploaded files for a session."""
+    with data_lock:
+        session_files = uploaded_files.get(session_id, {})
+        if not session_files:
+            return ""
+        return "\n\n--- FILE BREAK ---\n\n".join(session_files.values())
 
-def generate_ai_document(doc_type, input_docs, context_docs=None):
-    """Generates document using Gemini AI. Updates current_display."""
-    global current_display_document, current_display_type
+def generate_ai_document(session_id, doc_type, input_docs, context_docs=None):
+    """Generates document using Gemini AI. Updates current_display for the session."""
+    global current_display_document # Modifying global state
 
     if not model:
-        logging.error("Gemini AI model not initialized.")
+        logging.error(f"[{session_id}] Gemini AI model not initialized.")
         return "Error: AI Model not configured. Please check API Key."
     if not input_docs or not any(doc.strip() for doc in input_docs if doc):
-        logging.warning(f"generate_ai_document called for {doc_type} with no valid input documents.")
+        logging.warning(f"[{session_id}] generate_ai_document called for {doc_type} with no valid input documents.")
         return f"Error: Missing required input document(s) for {doc_type} generation."
 
     combined_input = "\n\n---\n\n".join(filter(None, input_docs))
     combined_context = "\n\n---\n\n".join(filter(None, context_docs)) if context_docs else ""
 
+    # Updated Prompt - Ensure it's correctly terminated
     prompt = f"""**Objective:** Generate the '{doc_type}' document.
 **Your Role:** Act as an expert proposal writer/analyst.
 **Core Instructions:**