Merge pull request #130 from MilesCranmer/no-warning-for-static-python

.github/workflows/CI.yml

@@ -119,8 +119,6 @@ jobs:
             python3 -c 'import pysr; pysr.install()'
       - name: "Install Coverage tool"
         run: python3 -m pip install coverage coveralls
-      - name: "Ensure that static libpython warning appears"
-        run: coverage run --source=pysr --omit='*/feynman_problems.py' -m unittest test.test_static_libpython_warning
       - name: "Run tests"
         run: coverage run --append --source=pysr --omit='*/feynman_problems.py' -m unittest test.test
       - name: Coveralls

.github/workflows/CI_conda_forge.yml

@@ -35,7 +35,5 @@ jobs:
         run: conda activate test && mamba install pysr
       - name: "Set up PySR's Julia dependencies"
         run: conda activate test && python3 -c 'import pysr; pysr.install()'
-      - name: "Ensure that static libpython warning appears"
-        run: conda activate test && python3 -m unittest test.test_static_libpython_warning
       - name: "Run tests"
         run: conda activate test && python3 -m unittest test.test

pysr/__init__.py

@@ -7,7 +7,6 @@ from .sr import (
     best_callable,
     best_row,
     install,
-    silence_julia_warning,
 )
 from .feynman_problems import Problem, FeynmanProblem
 from .export_jax import sympy2jax

pysr/sr.py

@@ -17,8 +17,6 @@ from hashlib import sha256
 
 from .version import __version__, __symbolic_regression_jl_version__
 
-is_julia_warning_silenced = False
-
 
 def install(julia_project=None, quiet=False):  # pragma: no cover
     """Install PyCall.jl and all required dependencies for SymbolicRegression.jl.
@@ -296,11 +294,6 @@ def _get_julia_project(julia_project):
     return julia_project, is_shared
 
 
-def silence_julia_warning():
-    global is_julia_warning_silenced
-    is_julia_warning_silenced = True
-
-
 def is_julia_version_greater_eq(Main, version="1.6"):
     """Check if Julia version is greater than specified version."""
     return Main.eval(f'VERSION >= v"{version}"')
@@ -308,7 +301,6 @@ def is_julia_version_greater_eq(Main, version="1.6"):
 
 def init_julia():
     """Initialize julia binary, turning off compiled modules if needed."""
-    global is_julia_warning_silenced
     from julia.core import JuliaInfo, UnsupportedPythonError
 
     try:
@@ -328,16 +320,7 @@ def init_julia():
 
         Main = _Main
     except UnsupportedPythonError:
-        if not is_julia_warning_silenced:
-            warnings.warn(
-                """
-Your Python version is statically linked to libpython. For example, this could be the python included with conda, or maybe your system's built-in python.
-This will still work, but the precompilation cache for Julia will be turned off, which may result in slower startup times on the initial pysr() call.
-
-To install a Python version that is dynamically linked to libpython, pyenv is recommended (https://github.com/pyenv/pyenv). With pyenv, you can run: `PYTHON_CONFIGURE_OPTS="--enable-shared" pyenv install 3.9.10` to install Python 3.9.10 with dynamic linking.
-
-To silence this warning, you can run pysr.silence_julia_warning() after importing pysr."""
-            )
+        # Static python binary, so we turn off pre-compiled modules.
         from julia.core import Julia
 
         jl = Julia(compiled_modules=False)

test/test_static_libpython_warning.py

@@ -1,20 +0,0 @@
-"""Test that running PySR with static libpython raises a warning.
-
-Note: This test will ONLY pass with statically-linked python binaries, such
-as provided by conda. It will not pass on other versions of python, and that is
-okay."""
-
-import unittest
-import warnings
-import pysr
-
-# Taken from https://stackoverflow.com/a/14463362/2689923
-class TestLibpythonWarning(unittest.TestCase):
-    def test_warning(self):
-        with warnings.catch_warnings(record=True) as warning_catcher:
-            warnings.simplefilter("always")
-            pysr.sr.init_julia()
-
-            self.assertEqual(len(warning_catcher), 1)
-            self.assertTrue(issubclass(warning_catcher[-1].category, UserWarning))
-            self.assertIn("static", str(warning_catcher[-1].message))