Update app.py

app.py

@@ -6,7 +6,7 @@ import glob
 import shutil
 import gradio as gr
 
-os.system("chmod +x ./fdkaac")  # Ensure fdkaac is executable
+os.system("chmod +x fdkaac")  # Ensure fdkaac is executable
 
 accel = 'auto'
 video_base_opts = ['-crf', '63', '-c:v', 'libx264', '-tune', 'zerolatency']
@@ -19,7 +19,6 @@ os.makedirs(CONVERTED_FOLDER, exist_ok=True)
 async def run_subprocess(cmd, use_fdkaac=False):
     env = os.environ.copy()
     if use_fdkaac:
-        # Add your fdkaac lib path here if needed:
         env["LD_LIBRARY_PATH"] = os.path.abspath("./") + ":" + env.get("LD_LIBRARY_PATH", "")
     print(f"[DEBUG] Running command:\n{' '.join(cmd)}\n")
     process = await asyncio.create_subprocess_exec(
@@ -35,34 +34,51 @@ async def run_subprocess(cmd, use_fdkaac=False):
     print(f"[DEBUG] Command succeeded:\n{stdout.decode()}\n")
     return stdout.decode(), stderr.decode()
 
-async def convert_video_task(input_path, downscale, faster, use_mp3):
+async def convert_video_task(input_path, downscale, faster, use_mp3, audio_only):
     if use_mp3:
-        # MP3 audio only, no splitting
-        output_path = os.path.join(CONVERTED_FOLDER, f"{uuid.uuid4()}.mp3")
-        ffmpeg_cmd = [
+        output_audio = os.path.join(CONVERTED_FOLDER, f"{uuid.uuid4()}.mp3")
+        ffmpeg_audio_cmd = [
             'ffmpeg', '-y', '-i', input_path, '-vn',
-            '-c:a', 'libmp3lame', '-b:a', '8k', '-ar', '24000', '-ac', '1', output_path
+            '-c:a', 'libmp3lame', '-b:a', '8k', '-ar', '24000', '-ac', '1',
+            output_audio
         ]
-        await run_subprocess(ffmpeg_cmd)
-        return output_path, None
-
-    # Paths for audio and video
+        if audio_only:
+            # Audio-only MP3
+            await run_subprocess(ffmpeg_audio_cmd)
+            return output_audio, None
+        else:
+            # Video+MP3, no splitting; encode video with MP3 audio embedded
+            output_video = os.path.join(CONVERTED_FOLDER, f"{uuid.uuid4()}.mp4")
+            ffmpeg_video_cmd = [
+                'ffmpeg', '-y', '-hwaccel', accel, '-i', input_path,
+                *video_base_opts
+            ]
+            if faster:
+                ffmpeg_video_cmd.extend(['-preset', 'ultrafast'])
+            ffmpeg_video_cmd += [
+                '-c:a', 'libmp3lame', '-b:a', '8k', '-ar', '24000', '-ac', '1',
+                output_video
+            ]
+            await run_subprocess(ffmpeg_video_cmd)
+            return None, output_video
+
+    # fdkaac path: Split, compress audio, merge
     audio_wav = os.path.join(CONVERTED_FOLDER, f"{uuid.uuid4()}.wav")
     audio_output = os.path.join(CONVERTED_FOLDER, f"{uuid.uuid4()}.m4a")
     video_output = os.path.join(CONVERTED_FOLDER, f"{uuid.uuid4()}.mp4")
 
-    # Extract mono 8kHz WAV audio
+    # Extract mono WAV audio
     await run_subprocess([
         'ffmpeg', '-y', '-i', input_path, '-ac', '1', '-ar', '8000', audio_wav
     ])
 
-    # Compress WAV to AAC with fdkaac
+    # Compress WAV with fdkaac
     await run_subprocess([
         './fdkaac', '-b', '1k', '-C', '-f', '2', '-G', '1', '-w', '8000',
         '-o', audio_output, audio_wav
     ], use_fdkaac=True)
 
-    # Compress video with extreme low quality, no audio
+    # Compress video without audio
     video_cmd = [
         'ffmpeg', '-y', '-hwaccel', accel, '-i', input_path,
         *video_base_opts, '-an', video_output
@@ -71,20 +87,23 @@ async def convert_video_task(input_path, downscale, faster, use_mp3):
         video_cmd.extend(['-preset', 'ultrafast'])
     await run_subprocess(video_cmd)
 
-    # Merge video + audio into final mp4 container
+    if audio_only:
+        return audio_output, None
+
+    # Merge video + audio
     merged_output = os.path.join(CONVERTED_FOLDER, f"{uuid.uuid4()}.mp4")
     await run_subprocess([
         'ffmpeg', '-y', '-i', video_output, '-i', audio_output, '-c', 'copy', merged_output
     ])
 
-    # Cleanup intermediate files
+    # Cleanup intermediates
     for f in [audio_wav, audio_output, video_output]:
         try:
             os.remove(f)
         except FileNotFoundError:
             pass
 
-    return audio_output, merged_output
+    return None, merged_output
 
 async def process_conversion(use_youtube, youtube_url, video_file, downscale, faster, use_mp3, audio_only):
     try:
@@ -93,7 +112,7 @@ async def process_conversion(use_youtube, youtube_url, video_file, downscale, fa
                 return "Error: YouTube URL required.", None
             yt_uuid = str(uuid.uuid4())
             yt_out = os.path.join(UPLOAD_FOLDER, yt_uuid + ".%(ext)s")
-            yt_cmd = ['yt-dlp', '-o', yt_out, '-f', "\"best[protocol*=m3u8][format_id*=tv]/best[format_id*=tv]/b\"", youtube_url]
+            yt_cmd = ['yt-dlp', '-o', yt_out, '-f', 'b', youtube_url]
             await run_subprocess(yt_cmd)
             pattern = os.path.join(UPLOAD_FOLDER, yt_uuid + ".*")
             files = glob.glob(pattern)
@@ -107,28 +126,31 @@ async def process_conversion(use_youtube, youtube_url, video_file, downscale, fa
             input_path = os.path.join(UPLOAD_FOLDER, f"{uuid.uuid4()}{ext}")
             shutil.copy2(video_file.name, input_path)
 
-        audio_out, video_out = await convert_video_task(input_path, downscale, faster, use_mp3)
+        audio_out, video_out = await convert_video_task(
+            input_path, downscale, faster, use_mp3, audio_only
+        )
 
         if audio_only:
             return audio_out, audio_out
-        else:
-            return video_out, video_out
+        return video_out, video_out
     except Exception as e:
         return f"Error: {str(e)}", None
 
 def convert_video(*args):
     return asyncio.run(process_conversion(*args))
 
+# Gradio Interface (unchanged, still pretty)
 with gr.Blocks(theme=gr.themes.Default(primary_hue="rose")) as demo:
     gr.Markdown("""
     # 🎥 **Low Quality Video Inator**
-
-    Upload a video or paste a YouTube URL below then play around with the settings to see which one you like the best.
+    Welcome to your personal bad-video-making machine.
+    
+    Upload a video or paste a YouTube URL below, then tweak the settings to ruin your video (on purpose).
     """)
 
     with gr.Group():
         with gr.Row():
-            use_youtube = gr.Checkbox(label="🔗 Use YouTube URL (Never works)", value=False)
+            use_youtube = gr.Checkbox(label="🔗 Use YouTube URL (experimental)", value=False)
             youtube_url = gr.Textbox(label="YouTube URL", placeholder="Paste YouTube URL here")
         video_file = gr.File(label="📁 Upload Video File")