Update app.py

app.py

@@ -109,6 +109,7 @@ def fetch_huggingface_records(dataset_name: str = "imdb"):
         return []
 
 def fetch_vendor_logs_from_salesforce():
+    """Fetch vendor logs from Salesforce with null handling."""
     try:
         query = """
         SELECT Id, Name, Vendor__c, Work_Completion_Percentage__c, Quality_Percentage__c, 
@@ -122,17 +123,25 @@ def fetch_vendor_logs_from_salesforce():
             if not record['Vendor__c']:
                 logger.warning(f"Skipping Vendor_Log__c record with ID {record['Id']} due to missing Vendor__c")
                 continue
-            # Handle null or missing Delay_Days__c
-            delay_days = record.get('Delay_Days__c')
+            # Handle null values for all fields
+            delay_days = record.get('Delay_Days__c', 0)
             if delay_days is None:
                 logger.warning(f"Delay_Days__c is null for record ID {record['Id']}, defaulting to 0")
                 delay_days = 0
+            work_completion = record.get('Work_Completion_Percentage__c', 0.0)
+            if work_completion is None:
+                logger.warning(f"Work_Completion_Percentage__c is null for record ID {record['Id']}, defaulting to 0.0")
+                work_completion = 0.0
+            quality_percentage = record.get('Quality_Percentage__c', 0.0)
+            if quality_percentage is None:
+                logger.warning(f"Quality_Percentage__c is null for record ID {record['Id']}, defaulting to 0.0")
+                quality_percentage = 0.0
             log = VendorLog(
                 vendorLogId=record.get('Id', 'Unknown'),
                 vendorId=record.get('Name', 'Unknown'),
                 vendorRecordId=record.get('Vendor__c', 'Unknown'),
-                workDetails=str(record.get('Work_Completion_Percentage__c', 0.0)),
-                qualityReport=str(record.get('Quality_Percentage__c', 0.0)),
+                workDetails=str(work_completion),
+                qualityReport=str(quality_percentage),
                 incidentLog=record.get('Incident_Severity__c', 'None'),
                 workCompletionDate=record.get('Work_Completion_Date__c', 'N/A'),
                 actualCompletionDate=record.get('Actual_Completion_Date__c', 'N/A'),
@@ -148,6 +157,7 @@ def fetch_vendor_logs_from_salesforce():
         raise HTTPException(status_code=500, detail=f"Error fetching vendor logs: {str(e)}")
 
 def calculate_scores(log: VendorLog):
+    """Calculate vendor performance scores."""
     try:
         work_completion_percentage = float(log.workDetails or 0.0)
         quality_percentage = float(log.qualityReport or 0.0)
@@ -169,6 +179,7 @@ def calculate_scores(log: VendorLog):
         raise HTTPException(status_code=500, detail=f"Error calculating scores: {str(e)}")
 
 def get_feedback(score: float, metric: str) -> str:
+    """Generate feedback based on score and metric."""
     try:
         if score >= 90:
             return "Excellent: Maintain this standard"
@@ -197,6 +208,7 @@ def get_feedback(score: float, metric: str) -> str:
         return "Feedback unavailable"
 
 def generate_pdf(vendor_id: str, vendor_log_name: str, scores: dict):
+    """Generate a PDF report for vendor performance."""
     try:
         filename = f'report_{vendor_id}_{datetime.now().strftime("%Y%m%d%H%M%S")}.pdf'
         c = canvas.Canvas(filename, pagesize=letter)
@@ -219,6 +231,7 @@ def generate_pdf(vendor_id: str, vendor_log_name: str, scores: dict):
         raise HTTPException(status_code=500, detail=f"Error generating PDF: {str(e)}")
 
 def determine_alert_flag(scores: dict, all_logs: list):
+    """Determine if an alert flag should be set."""
     try:
         if not all_logs:
             return False
@@ -232,6 +245,7 @@ def determine_alert_flag(scores: dict, all_logs: list):
         return False
 
 def store_scores_in_salesforce(log: VendorLog, scores: dict, pdf_content: bytes, alert_flag: bool):
+    """Store scores and PDF in Salesforce."""
     try:
         score_record = sf.Subcontractor_Performance_Score__c.create({
             'Vendor_Log__c': log.vendorLogId,
@@ -268,6 +282,7 @@ def store_scores_in_salesforce(log: VendorLog, scores: dict, pdf_content: bytes,
 
 @app.post('/score')
 async def score_vendor(log: VendorLog, authorization: str = Header(...)):
+    """Score a vendor and generate a PDF report."""
     try:
         logger.info(f"Received Vendor Log: {log}")
         if authorization != f'Bearer {API_KEY}':
@@ -313,6 +328,7 @@ async def score_vendor(log: VendorLog, authorization: str = Header(...)):
 
 @app.get('/', response_class=HTMLResponse)
 async def get_dashboard():
+    """Render the dashboard with vendor logs and scores."""
     try:
         global vendor_logs
         fetched_logs = fetch_vendor_logs_from_salesforce()
@@ -344,190 +360,4 @@ async def get_dashboard():
                 <title>Subcontractor Performance Score App</title>
                 <style>
                     body { font-family: Arial, sans-serif; margin: 20px; }
-                    table { width: 100%; border-collapse: collapse; margin-top: 20px; }
-                    th, td { border: 1px solid #ddd; padding: 8px; text-align: left; }
-                    th { background-color: #f2f2f2; }
-                    h1, h2 { text-align: center; }
-                    .generate-btn { 
-                        display: block; 
-                        margin: 20px auto; 
-                        padding: 10px 20px; 
-                        background-color: #4CAF50; 
-                        color: white; 
-                        border: none; 
-                        border-radius: 5px; 
-                        cursor: pointer; 
-                        font-size: 16px; 
-                    }
-                    .generate-btn:hover { background-color: #45a049; }
-                </style>
-                <script>
-                    async function generateScores() {
-                        try {
-                            const response = await fetch('/generate', { method: 'POST' });
-                            if (response.ok) {
-                                window.location.reload();
-                            } else {
-                                alert('Error generating scores');
-                            }
-                        } catch (error) {
-                            alert('Error: ' + error.message);
-                        }
-                    }
-                </script>
-            </head>
-            <body>
-                <h1>SUBCONTRACTOR PERFORMANCE SCORE APP GENERATOR</h1>
-                <h2>VENDOR LOGS SUBMISSION</h2>
-                <table>
-                    <tr>
-                        <th>Vendor ID</th>
-                        <th>Vendor Log Name</th>
-                        <th>Project</th>
-                        <th>Work Completion Percentage</th>
-                        <th>Quality Percentage</th>
-                        <th>Incident Severity</th>
-                        <th>Work Completion Date</th>
-                        <th>Actual Completion Date</th>
-                        <th>Delay Days</th>
-                    </tr>
-        """
-
-        if not vendor_logs:
-            html_content += """
-                    <tr>
-                        <td colspan="9" style="text-align: center;">No vendor logs available</td>
-                    </tr>
-            """
-        else:
-            for log in vendor_logs:
-                html_content += f"""
-                        <tr>
-                            <td>{log['vendorId']}</td>
-                            <td>{log['vendorLogName']}</td>
-                            <td>{log['project']}</td>
-                            <td>{log['workDetails']}</td>
-                            <td>{log['qualityReport']}</td>
-                            <td>{log['incidentLog']}</td>
-                            <td>{log['workCompletionDate']}</td>
-                            <td>{log['actualCompletionDate']}</td>
-                            <td>{log['delayDays']}</td>
-                        </tr>
-                """
-
-        html_content += """
-                </table>
-                <button class="generate-btn" onclick="generateScores()">Generate</button>
-                <h2>SUBCONTRACTOR PERFORMANCE SCORES</h2>
-                <table>
-                    <tr>
-                        <th>Vendor ID</th>
-                        <th>Vendor Log Name</th>
-                        <th>Project</th>
-                        <th>Quality Score</th>
-                        <th>Timeliness Score</th>
-                        <th>Safety Score</th>
-                        <th>Communication Score</th>
-                        <th>Alert Flag</th>
-                    </tr>
-        """
-
-        if not vendor_logs:
-            html_content += """
-                    <tr>
-                        <td colspan="8" style="text-align: center;">No scores available</td>
-                    </tr>
-            """
-        else:
-            for log in vendor_logs:
-                scores = log['scores']
-                alert_flag = determine_alert_flag(scores, vendor_logs)
-                html_content += f"""
-                        <tr>
-                            <td>{log['vendorId']}</td>
-                            <td>{log['vendorLogName']}</td>
-                            <td>{log['project']}</td>
-                            <td>{scores['qualityScore']}%</td>
-                            <td>{scores['timelinessScore']}%</td>
-                            <td>{scores['safetyScore']}%</td>
-                            <td>{scores['communicationScore']}%</td>
-                            <td>{'Checked' if alert_flag else 'Unchecked'}</td>
-                        </tr>
-                """
-
-        html_content += """
-                </table>
-            </body>
-        </html>
-        """
-        return HTMLResponse(content=html_content)
-    except Exception as e:
-        logger.error(f"Error in / endpoint: {str(e)}")
-        raise HTTPException(status_code=500, detail=f"Error generating dashboard: {str(e)}")
-
-@app.post('/generate')
-async def generate_scores():
-    try:
-        global vendor_logs
-        fetched_logs = fetch_vendor_logs_from_salesforce()
-        vendor_logs = []
-        for log in fetched_logs:
-            scores = calculate_scores(log)
-            pdf_content = generate_pdf(log.vendorId, log.vendorLogName, scores)
-            pdf_base64 = base64.b64encode(pdf_content).decode('utf-8')
-            alert_flag = determine_alert_flag(scores, vendor_logs)
-            store_scores_in_salesforce(log, scores, pdf_content, alert_flag)
-            vendor_logs.append({
-                'vendorLogId': log.vendorLogId,
-                'vendorId': log.vendorId,
-                'vendorLogName': log.vendorLogName,
-                'workDetails': log.workDetails,
-                'qualityReport': log.qualityReport,
-                'incidentLog': log.incidentLog,
-                'workCompletionDate': log.workCompletionDate,
-                'actualCompletionDate': log.actualCompletionDate,
-                'delayDays': log.delayDays,
-                'project': log.project,
-                'scores': scores,
-                'extracted': True
-            })
-        logger.info(f"Generated scores for {len(vendor_logs)} logs")
-        return {"status": "success"}
-    except Exception as e:
-        logger.error(f"Error in /generate endpoint: {str(e)}")
-        raise HTTPException(status_code=500, detail=f"Error generating scores: {str(e)}")
-
-@app.get('/huggingface-records')
-async def get_huggingface_records():
-    """Fetch and return Hugging Face dataset records."""
-    try:
-        records = fetch_huggingface_records()
-        if not records:
-            raise HTTPException(status_code=404, detail="No records fetched from Hugging Face")
-        return {"records": records}
-    except Exception as e:
-        logger.error(f"Error fetching Hugging Face records: {str(e)}")
-        raise HTTPException(status_code=500, detail=f"Failed to fetch Hugging Face records: {str(e)}")
-
-@app.get('/debug')
-async def debug_info():
-    """Return debug information about Salesforce and Hugging Face."""
-    try:
-        log_count = sf.query("SELECT COUNT() FROM Vendor_Log__c")['totalSize']
-        fields = [f['name'] for f in sf.Vendor_Log__c.describe()['fields']]
-        score_fields = [f['name'] for f in sf.Subcontractor_Performance_Score__c.describe()['fields']]
-        hf_records = fetch_huggingface_records()
-        return {
-            "salesforce_connected": True,
-            "vendor_log_count": log_count,
-            "vendor_log_fields": fields,
-            "score_fields": score_fields,
-            "huggingface_records_sample": hf_records
-        }
-    except Exception as e:
-        logger.error(f"Debug error: {str(e)}")
-        return {"salesforce_connected": False, "error": str(e)}
-
-if __name__ == "__main__":
-    import uvicorn
-    uvicorn.run(app, host="0.0.0.0", port=7860)
+                    table { width: 100%; border-collapse: collapse; margin-top: 20px; }