Update flare-ui/src/app/components/test/test.component.ts

flare-ui/src/app/components/test/test.component.ts

@@ -175,7 +175,7 @@ export class TestComponent implements OnInit {
         const response = await this.apiService.getEnvironment().toPromise();
         return {
           name: 'GET /api/environment',
-          status: response?.work_mode ? 'PASS' : 'FAIL',  // Add optional chaining
+          status: response?.work_mode ? 'PASS' : 'FAIL',
           duration_ms: Date.now() - start
         };
       } catch (error) {
@@ -196,7 +196,7 @@ export class TestComponent implements OnInit {
           name: 'GET /api/projects',
           status: Array.isArray(response) ? 'PASS' : 'FAIL',
           duration_ms: Date.now() - start,
-          details: `Retrieved ${response?.length || 0} projects`  // Add optional chaining
+          details: `Retrieved ${response?.length || 0} projects`
         };
       } catch (error) {
         return {
@@ -216,7 +216,7 @@ export class TestComponent implements OnInit {
           name: 'GET /api/apis',
           status: Array.isArray(response) ? 'PASS' : 'FAIL',
           duration_ms: Date.now() - start,
-          details: `Retrieved ${response?.length || 0} APIs`  // Add optional chaining
+          details: `Retrieved ${response?.length || 0} APIs`
         };
       } catch (error) {
         return {
@@ -228,24 +228,26 @@ export class TestComponent implements OnInit {
       }
     });
 
-// Integration Tests
+    // Integration Tests
     this.addTest('integration', 'Create and delete project', async () => {
       const start = Date.now();
-      let createdProject: any = null;
+      let projectId: number | undefined;
 
       try {
         // Create project
-        createdProject = await this.apiService.createProject({
+        const createResponse = await this.apiService.createProject({
           name: `test_project_${Date.now()}`,
           caption: 'Test Project'
-        }).toPromise();
+        }).toPromise() as any;
 
-        if (!createdProject?.id) {
-          throw new Error('Project creation failed - no ID returned');
+        if (!createResponse?.id) {
+          throw new Error('Project creation failed');
         }
 
-        // Delete project - ID is guaranteed to exist here
-        await this.apiService.deleteProject(createdProject.id).toPromise();
+        projectId = createResponse.id;
+
+        // Delete project
+        await this.apiService.deleteProject(projectId).toPromise();
 
         return {
           name: 'Create and delete project',
@@ -255,12 +257,10 @@ export class TestComponent implements OnInit {
         };
       } catch (error: any) {
         // Try to clean up if project was created
-        if (createdProject?.id) {
+        if (projectId !== undefined) {
           try {
-            await this.apiService.deleteProject(createdProject.id).toPromise();
-          } catch (cleanupError) {
-            console.error('Cleanup failed:', cleanupError);
-          }
+            await this.apiService.deleteProject(projectId).toPromise();
+          } catch {}
         }
 
         return {
@@ -272,6 +272,28 @@ export class TestComponent implements OnInit {
       }
     });
 
+    this.addTest('integration', 'API used in intent cannot be deleted', async () => {
+      const start = Date.now();
+      try {
+        // Try to delete an API that's used in intents
+        await this.apiService.deleteAPI('book_flight_api').toPromise();
+        
+        return {
+          name: 'API used in intent cannot be deleted',
+          status: 'FAIL',
+          error: 'Expected error but API was deleted',
+          duration_ms: Date.now() - start
+        };
+      } catch (error: any) {
+        return {
+          name: 'API used in intent cannot be deleted',
+          status: error.status === 400 ? 'PASS' : 'FAIL',
+          duration_ms: Date.now() - start,
+          details: 'Correctly prevented deletion of API in use'
+        };
+      }
+    });
+
     // Validation Tests
     this.addTest('validation', 'Regex validation - valid pattern', async () => {
       const start = Date.now();
@@ -312,72 +334,6 @@ export class TestComponent implements OnInit {
       }
     });
 
-    // Integration Tests
-    this.addTest('integration', 'Create and delete project', async () => {
-      const start = Date.now();
-      let projectId: number | null = null;
-
-      try {
-        // Create project
-        const createResponse = await this.apiService.createProject({
-          name: `test_project_${Date.now()}`,
-          caption: 'Test Project'
-        }).toPromise() as any;
-
-        if (!createResponse.id) {
-          throw new Error('Project creation failed');
-        }
-
-        projectId = createResponse.id;
-
-        // Delete project
-        await this.apiService.deleteProject(projectId).toPromise();
-
-        return {
-          name: 'Create and delete project',
-          status: 'PASS',
-          duration_ms: Date.now() - start,
-          details: 'Project lifecycle test passed'
-        };
-      } catch (error: any) {
-        // Try to clean up if project was created
-        if (projectId) {
-          try {
-            await this.apiService.deleteProject(projectId).toPromise();
-          } catch {}
-        }
-
-        return {
-          name: 'Create and delete project',
-          status: 'FAIL',
-          error: error.message || 'Test failed',
-          duration_ms: Date.now() - start
-        };
-      }
-    });
-
-    this.addTest('integration', 'API used in intent cannot be deleted', async () => {
-      const start = Date.now();
-      try {
-        // Try to delete an API that's used in intents
-        await this.apiService.deleteAPI('book_flight_api').toPromise();
-        
-        return {
-          name: 'API used in intent cannot be deleted',
-          status: 'FAIL',
-          error: 'Expected error but API was deleted',
-          duration_ms: Date.now() - start
-        };
-      } catch (error: any) {
-        return {
-          name: 'API used in intent cannot be deleted',
-          status: error.status === 400 ? 'PASS' : 'FAIL',
-          duration_ms: Date.now() - start,
-          details: 'Correctly prevented deletion of API in use'
-        };
-      }
-    });
-
     // Update test counts
     this.categories.forEach(cat => {
       cat.displayName = `${cat.displayName} (${cat.tests.length} tests)`;
@@ -397,7 +353,8 @@ export class TestComponent implements OnInit {
   }
 
   toggleAll() {
-    this.categories.forEach(c => c.selected = this.allSelected);
+    const newState = !this.allSelected;
+    this.categories.forEach(c => c.selected = newState);
   }
 
   async runAllTests() {