Update flare-ui/src/app/dialogs/version-edit-dialog/version-edit-dialog.component.ts

flare-ui/src/app/dialogs/version-edit-dialog/version-edit-dialog.component.ts

@@ -19,6 +19,12 @@ import { MatListModule } from '@angular/material/list';
 import { ApiService, Project, Version } from '../../services/api.service';
 import ConfirmDialogComponent from '../confirm-dialog/confirm-dialog.component';
 
+// Interfaces for multi-language support
+interface LocalizedExample {
+  locale_code: string;
+  example: string;
+}
+
 @Component({
   selector: 'app-version-edit-dialog',
   standalone: true,
@@ -61,6 +67,9 @@ export default class VersionEditDialogComponent implements OnInit {
   testUserMessage = '';
   testResult: any = null;
   testing = false;
+  
+  // Locale for examples
+  selectedExampleLocale: string = 'tr';
 
   constructor(
     private fb: FormBuilder,
@@ -72,6 +81,7 @@ export default class VersionEditDialogComponent implements OnInit {
   ) {
     this.project = data.project;
     this.versions = [...this.project.versions].sort((a, b) => b.no - a.no);
+    this.selectedExampleLocale = this.project.default_locale || 'tr';
   }
 
   ngOnInit() {
@@ -88,7 +98,6 @@ export default class VersionEditDialogComponent implements OnInit {
     this.versionForm.valueChanges.subscribe(() => {
       this.isDirty = true;
     });
-
   }
 
   initializeForm() {
@@ -133,7 +142,7 @@ export default class VersionEditDialogComponent implements OnInit {
       no: version.no,
       caption: version.caption || '',
       published: version.published || false,
-      general_prompt: (version as any).general_prompt || '', // Backend'den gelen general_prompt
+      general_prompt: (version as any).general_prompt || '',
       last_update_date: version.last_update_date || ''
     });
   
@@ -194,23 +203,15 @@ export default class VersionEditDialogComponent implements OnInit {
     const group = this.fb.group({
       name: [intent.name || '', [Validators.required, Validators.pattern(/^[a-zA-Z0-9-]+$/)]],
       caption: [intent.caption || ''],
-      locale: [intent.locale || 'tr-TR'],
       detection_prompt: [intent.detection_prompt || '', Validators.required],
-      examples: this.fb.array([]),
+      examples: [intent.examples || []], // Store as array, not FormArray
       parameters: this.fb.array([]),
       action: [intent.action || '', Validators.required],
       fallback_timeout_prompt: [intent.fallback_timeout_prompt || ''],
       fallback_error_prompt: [intent.fallback_error_prompt || '']
     });
   
-    // Examples ve parameters'ı ayrı olarak ekle
-    if (intent.examples && Array.isArray(intent.examples)) {
-      const examplesArray = group.get('examples') as FormArray;
-      intent.examples.forEach((example: any) => {
-        examplesArray.push(this.fb.control(example));
-      });
-    }
-  
+    // Parameters'ı ayrı olarak ekle
     if (intent.parameters && Array.isArray(intent.parameters)) {
       const parametersArray = group.get('parameters') as FormArray;
       intent.parameters.forEach((param: any) => {
@@ -221,13 +222,6 @@ export default class VersionEditDialogComponent implements OnInit {
     return group;
   }
 
-  private populateIntentParameters(intentFormGroup: FormGroup, parameters: any[]) {
-    const parametersArray = intentFormGroup.get('parameters') as FormArray;
-    parameters.forEach(param => {
-      parametersArray.push(this.createParameterFormGroup(param));
-    });
-  }  
-
   createParameterFormGroup(param: any = {}): FormGroup {
     return this.fb.group({
       name: [param.name || '', [Validators.required, Validators.pattern(/^[a-zA-Z0-9_]+$/)]],
@@ -250,8 +244,59 @@ export default class VersionEditDialogComponent implements OnInit {
     return this.intents.at(intentIndex).get('parameters') as FormArray;
   }
 
-  getIntentExamples(intentIndex: number): FormArray {
-    return this.intents.at(intentIndex).get('examples') as FormArray;
+  // LocalizedExample support methods
+  getLocalizedExamples(examples: any[], locale: string): LocalizedExample[] {
+    if (!examples || !Array.isArray(examples)) return [];
+    
+    // Check if examples are in new format
+    if (examples.length > 0 && typeof examples[0] === 'object' && 'locale_code' in examples[0]) {
+      return examples.filter(ex => ex.locale_code === locale);
+    }
+    
+    // Old format - convert to new
+    if (typeof examples[0] === 'string') {
+      return examples.map(ex => ({ locale_code: locale, example: ex }));
+    }
+    
+    return [];
+  }
+
+  addLocalizedExample(intentIndex: number, example: string) {
+    if (!example.trim()) return;
+    
+    const intent = this.intents.at(intentIndex);
+    const currentExamples = intent.get('examples')?.value || [];
+    
+    // Check if already exists
+    const exists = currentExamples.some((ex: any) => 
+      ex.locale_code === this.selectedExampleLocale && ex.example === example.trim()
+    );
+    
+    if (!exists) {
+      const newExamples = [...currentExamples, {
+        locale_code: this.selectedExampleLocale,
+        example: example.trim()
+      }];
+      intent.patchValue({ examples: newExamples });
+      this.isDirty = true;
+    }
+  }
+
+  removeLocalizedExample(intentIndex: number, exampleToRemove: LocalizedExample) {
+    const intent = this.intents.at(intentIndex);
+    const currentExamples = intent.get('examples')?.value || [];
+    
+    const newExamples = currentExamples.filter((ex: any) => 
+      !(ex.locale_code === exampleToRemove.locale_code && ex.example === exampleToRemove.example)
+    );
+    
+    intent.patchValue({ examples: newExamples });
+    this.isDirty = true;
+  }
+
+  // Check if version can be edited
+  get canEdit(): boolean {
+    return !this.selectedVersion?.published;
   }
 
   addIntent() {
@@ -300,30 +345,25 @@ export default class VersionEditDialogComponent implements OnInit {
   
     dialogRef.afterClosed().subscribe(result => {
       if (result) {
-        // FormArray'leri yeniden oluştur
+        // Update intent with result
         intent.patchValue({
           name: result.name,
           caption: result.caption,
-          locale: result.locale,
           detection_prompt: result.detection_prompt,
+          examples: result.examples || [],
           action: result.action,
           fallback_timeout_prompt: result.fallback_timeout_prompt,
           fallback_error_prompt: result.fallback_error_prompt
         });
   
-        // Examples'ı güncelle
-        const examplesArray = intent.get('examples') as FormArray;
-        examplesArray.clear();
-        (result.examples || []).forEach((example: string) => {
-          examplesArray.push(this.fb.control(example));
-        });
-  
-        // Parameters'ı güncelle
+        // Update parameters
         const parametersArray = intent.get('parameters') as FormArray;
         parametersArray.clear();
         (result.parameters || []).forEach((param: any) => {
           parametersArray.push(this.createParameterFormGroup(param));
         });
+        
+        this.isDirty = true;
       }
     });
   }
@@ -338,18 +378,6 @@ export default class VersionEditDialogComponent implements OnInit {
     parameters.removeAt(paramIndex);
   }
 
-  addExample(intentIndex: number, example: string) {
-    if (example.trim()) {
-      const examples = this.getIntentExamples(intentIndex);
-      examples.push(this.fb.control(example));
-    }
-  }
-
-  removeExample(intentIndex: number, exampleIndex: number) {
-    const examples = this.getIntentExamples(intentIndex);
-    examples.removeAt(exampleIndex);
-  }
-
   async createVersion() {
     const publishedVersions = this.versions.filter(v => v.published);
     
@@ -359,7 +387,7 @@ export default class VersionEditDialogComponent implements OnInit {
         title: 'Create New Version',
         message: 'Which published version would you like to use as a base for the new version?',
         showDropdown: true,
-        dropdownOptions: publishedVersions.map(v => ({  // ✅ publishedVersions kullan
+        dropdownOptions: publishedVersions.map(v => ({
           value: v.no,
           label: `Version ${v.no} - ${v.caption || 'No description'}`
         })),
@@ -427,8 +455,8 @@ export default class VersionEditDialogComponent implements OnInit {
   }
 
   async saveVersion() {
-    if (!this.selectedVersion) {
-      this.snackBar.open('No version selected', 'Close', { duration: 3000 });
+    if (!this.selectedVersion || !this.canEdit) {
+      this.snackBar.open('Cannot save published version', 'Close', { duration: 3000 });
       return;
     }
     
@@ -463,7 +491,7 @@ export default class VersionEditDialogComponent implements OnInit {
       // updateData'yı backend'in beklediği formatta hazırla
       const updateData = {
         caption: formValue.caption,
-        general_prompt: formValue.general_prompt || '', // Bu alan eksikti
+        general_prompt: formValue.general_prompt || '',
         llm: formValue.llm,
         intents: formValue.intents.map((intent: any) => ({
           name: intent.name,
@@ -513,8 +541,13 @@ export default class VersionEditDialogComponent implements OnInit {
       console.error('Save error:', error);
       
       if (error.status === 409) {
-        // Race condition handling için ayrı metod çağır
+        // Race condition handling
         await this.handleRaceCondition(currentVersion);
+      } else if (error.status === 400 && error.error?.detail?.includes('Published versions')) {
+        this.snackBar.open('Published versions cannot be modified. Create a new version instead.', 'Close', { 
+          duration: 5000,
+          panelClass: 'error-snackbar'
+        });
       } else {
         const errorMessage = error.error?.detail || error.message || 'Failed to save version';
         this.snackBar.open(errorMessage, 'Close', { 
@@ -527,7 +560,7 @@ export default class VersionEditDialogComponent implements OnInit {
     }
   }
   
-  // Race condition handling için ayrı metod
+  // Race condition handling
   private async handleRaceCondition(currentVersion: Version) {
     const formValue = this.versionForm.getRawValue();
     
@@ -682,8 +715,11 @@ export default class VersionEditDialogComponent implements OnInit {
       let confidence = 0;
 
       for (const intent of intents) {
-        for (const example of intent.examples || []) {
-          if (this.testUserMessage.toLowerCase().includes(example.toLowerCase())) {
+        // Check examples in all locales
+        const allExamples = intent.examples || [];
+        for (const example of allExamples) {
+          const exampleText = typeof example === 'string' ? example : example.example;
+          if (this.testUserMessage.toLowerCase().includes(exampleText.toLowerCase())) {
             detectedIntent = intent.name;
             confidence = 0.95;
             break;