Update app.py

app.py

@@ -192,18 +192,17 @@ def check_java():
         try:
             result = subprocess.run([java_path, "-version"], capture_output=True, text=True)
             print(f"Found Java: {java_path}")
-            print(result.stderr.split('\n')[0])  # Java version info is in stderr
+            print(result.stderr.split('\n')[0])
             return java_path
         except:
             pass
     
-    # Check our custom Java installation
     custom_java = JAVA_DIR / "bin" / "java"
     if custom_java.exists():
         try:
             result = subprocess.run([str(custom_java), "-version"], capture_output=True, text=True)
             print(f"Found custom Java: {custom_java}")
-            print(result.stderr.split('\n')[0])  # Java version info is in stderr
+            print(result.stderr.split('\n')[0])
             return str(custom_java)
         except:
             pass
@@ -255,22 +254,18 @@ def install_java():
         print(f"No Java download available for platform: {platform_key}")
         return False
     
-    # Download Java
     java_archive = DATA_DIR / "java.tar.gz"
     if not download_file(java_url, java_archive):
         return False
     
-    # Extract Java
     print("Extracting Java...")
     try:
         import tarfile
         with tarfile.open(java_archive, 'r:gz') as tar:
-            # Extract to temporary directory first
             temp_dir = DATA_DIR / "java_temp"
             temp_dir.mkdir(exist_ok=True)
             tar.extractall(temp_dir)
             
-            # Find the extracted JDK directory (usually has a version number)
             extracted_dirs = [d for d in temp_dir.iterdir() if d.is_dir() and d.name.startswith('jdk')]
             if not extracted_dirs:
                 print("Could not find extracted JDK directory")
@@ -278,18 +273,15 @@ def install_java():
             
             jdk_dir = extracted_dirs[0]
             
-            # Move to final location
             if JAVA_DIR.exists():
                 shutil.rmtree(JAVA_DIR)
             shutil.move(str(jdk_dir), str(JAVA_DIR))
             
-            # Clean up
             shutil.rmtree(temp_dir)
             java_archive.unlink()
             
         print(f"✓ Java installed to: {JAVA_DIR}")
         
-        # Make java executable
         java_bin = JAVA_DIR / "bin" / "java"
         java_bin.chmod(0o755)
         
@@ -300,12 +292,8 @@ def install_java():
         return False
 
 def setup_minecraft_server():
-    """Set up the Minecraft server in persistent storage"""
-    
-    # Ensure the data directory exists
     DATA_DIR.mkdir(parents=True, exist_ok=True)
     
-    # Check and install Java if needed
     java_path = check_java()
     if not java_path:
         print("Java not found. Installing Java...")
@@ -317,7 +305,6 @@ def setup_minecraft_server():
             print("Java installation failed or not working.")
             return False
     
-    # Download the server JAR if it doesn't exist
     if not JAR_PATH.exists():
         print(f"Downloading Minecraft server to {JAR_PATH}")
         if not download_file(PAPER_JAR_URL, JAR_PATH):
@@ -325,7 +312,6 @@ def setup_minecraft_server():
     else:
         print(f"Server JAR already exists at {JAR_PATH}")
     
-    # Create server.properties file if it doesn't exist
     server_properties_path = DATA_DIR / "server.properties"
     if not server_properties_path.exists():
         print("Creating server.properties...")
@@ -333,11 +319,13 @@ def setup_minecraft_server():
 server-port=25565
 gamemode=survival
 difficulty=easy
-spawn-protection=16
-max-players=20
-online-mode=false
+spawn-protection=0
+max-players=64
+online-mode=true
 white-list=false
-motd=Hugging Face Minecraft Server
+motd=Hugging Face Spaces Minecraft Server
+enable-query=true
+query.port=25565
 """
         with open(server_properties_path, 'w') as f:
             f.write(server_properties)
@@ -390,7 +378,6 @@ def start_server():
             bufsize=1
         )
         
-        # Print server output in real-time
         for line in process.stdout:
             print(line.strip())
             
@@ -411,24 +398,20 @@ if __name__ == "__main__":
     print("=== Minecraft Server Setup ===")
     
     try:
-        # Step 1: Setup Minecraft server
         if not setup_minecraft_server():
             print("Setup failed. Cannot start server.")
             sys.exit(1)
         
-        # Step 2: Setup ngrok
         print("\n=== Setting up ngrok ===")
         if not setup_ngrok():
             print("ngrok setup failed. Server will start but won't be accessible externally.")
             tunnel = None
         else:
-            # Step 3: Start ngrok tunnel
             print("\n=== Starting ngrok tunnel ===")
             tunnel, tunnel_url = start_ngrok_tunnel()
             if not tunnel:
                 print("Failed to start ngrok tunnel. Server will start but won't be accessible externally.")
         
-        # Step 4: Start the server
         print("\n=== Starting Minecraft Server ===")
         start_server()