refactored tests

deep_translator/base.py

@@ -1,6 +1,7 @@
 """base translator class"""
 
 from .constants import GOOGLE_LANGUAGES_TO_CODES
+from .exceptions import InvalidSourceOrTargetLanguage
 from abc import ABC, abstractmethod
 
 
@@ -24,6 +25,11 @@ class BaseTranslator(ABC):
         self._base_url = base_url
         self.languages: dict = GOOGLE_LANGUAGES_TO_CODES if not languages else languages
         self.supported_languages: list = list(self.languages.keys())
+        if not source:
+            raise InvalidSourceOrTargetLanguage(source)
+        if not target:
+            raise InvalidSourceOrTargetLanguage(target)
+
         self._source, self._target = self._map_language_to_code(source, target)
         self._url_params = url_params
         self._element_tag = element_tag

deep_translator/exceptions.py

@@ -43,11 +43,10 @@ class InvalidSourceOrTargetLanguage(BaseError):
 
     def __init__(self,
                  val,
-                 message="source and target language can't be the same"):
+                 message="Invalid source or target language!"):
         super(InvalidSourceOrTargetLanguage, self).__init__(val, message)
 
 
-
 class TranslationNotFound(BaseError):
     """
     exception thrown if no translation was found for the text provided by the user

tests/test_google.py

@@ -0,0 +1,68 @@
+#!/usr/bin/env python
+
+"""Tests for `deep_translator` package."""
+
+import pytest
+from deep_translator import exceptions, GoogleTranslator
+from deep_translator.constants import GOOGLE_CODES_TO_LANGUAGES
+
+
+@pytest.fixture
+def google_translator():
+    """Sample pytest fixture.
+    See more at: http://doc.pytest.org/en/latest/fixture.html
+    """
+    return GoogleTranslator(target='en')
+
+
+def test_content(google_translator):
+    """Sample pytest test function with the pytest fixture as an argument."""
+    assert google_translator.translate(text='좋은') == "good"
+
+
+def test_abbreviations_and_languages_mapping():
+    for abb, lang in GOOGLE_CODES_TO_LANGUAGES.items():
+        g1 = GoogleTranslator(abb)
+        g2 = GoogleTranslator(lang)
+        assert g1._source == g2._source
+
+
+def test_inputs():
+    with pytest.raises(exceptions.InvalidSourceOrTargetLanguage):
+        GoogleTranslator(source="", target="")
+
+    with pytest.raises(exceptions.InvalidSourceOrTargetLanguage):
+        GoogleTranslator(source="auto", target="")
+
+    with pytest.raises(exceptions.InvalidSourceOrTargetLanguage):
+        GoogleTranslator(source="", target="en")
+
+
+def test_empty_text(google_translator):
+    empty_txt = ""
+    res = google_translator.translate(text=empty_txt)
+    assert res == empty_txt
+
+
+def test_payload(google_translator):
+
+    with pytest.raises(exceptions.NotValidPayload):
+        google_translator.translate(text='1234')
+        google_translator.translate(text='{}')
+        google_translator.translate(text='%@')
+
+    with pytest.raises(exceptions.NotValidPayload):
+        google_translator.translate(text=123)
+
+    with pytest.raises(exceptions.NotValidPayload):
+        google_translator.translate(text={})
+
+    with pytest.raises(exceptions.NotValidPayload):
+        google_translator.translate(text=[])
+
+    with pytest.raises(exceptions.NotValidLength):
+        google_translator.translate("a"*5001)
+
+
+def test_one_character_words():
+    assert GoogleTranslator(source='es', target='en').translate('o') == 'or'

tests/test_google_trans.py

@@ -1,175 +0,0 @@
-#!/usr/bin/env python
-
-"""Tests for `deep_translator` package."""
-
-import pytest
-from deep_translator import exceptions, GoogleTranslator
-from deep_translator.constants import GOOGLE_CODES_TO_LANGUAGES
-
-
-test_text_standard = 'Hello world.'
-
-TRANSLATED_RESULTS = {
-    "afrikaans": "Hello Wêreld.",
-    "albanian": "Përshendetje Botë.",
-    "amharic": "ሰላም ልዑል.",
-    "arabic": "مرحبا بالعالم.",
-    "armenian": "Բարեւ աշխարհ.",
-    "azerbaijani": "Salam dünya.",
-    "basque": "Kaixo Mundua.",
-    "belarusian": "Прывітанне Сусвет.",
-    "bengali": "ওহে বিশ্ব.",
-    "bosnian": "Zdravo svijete.",
-    "bulgarian": "Здравей свят.",
-    "catalan": "Hola món.",
-    "cebuano": "Kumusta kalibutan.",
-    "chichewa": "Moni Dziko Lapansi.",
-    "chinese (simplified)": "你好，世界。",
-    "chinese (traditional)": "你好，世界。",
-    "corsican": "Bonghjornu mondu.",
-    "croatian": "Pozdrav svijete.",
-    "czech": "Ahoj světe.",
-    "danish": "Hej Verden.",
-    "dutch": "Hallo Wereld.",
-    "esperanto": "Saluton mondo.",
-    "estonian": "Tere, Maailm.",
-    "filipino": "Kamusta mundo",
-    "finnish": "Hei maailma.",
-    "french": "Bonjour le monde.",
-    "frisian": "Hallo wrâld.",
-    "galician": "Ola mundo.",
-    "georgian": "Გამარჯობა მსოფლიო.",
-    "german": "Hallo Welt.",
-    "greek": "Γειά σου Κόσμε.",
-    "gujarati": "હેલો વર્લ્ડ.",
-    "haitian creole": "Bonjou mond.",
-    "hausa": "Sannu Duniya.",
-    "hawaiian": "Aloha honua.",
-    "hebrew": "שלום עולם.",
-    "hindi": "नमस्ते दुनिया।",
-    "hmong": "Nyob zoo ntiaj teb.",
-    "hungarian": "Helló Világ.",
-    "icelandic": "Halló heimur.",
-    "igbo": "Ndewo Ụwa.",
-    "indonesian": "Halo Dunia.",
-    "irish": "Dia duit ar domhan.",
-    "italian": "Ciao mondo.",
-    "japanese": "こんにちは世界。",
-    "javanese": "Halo jagad.",
-    "kannada": "ಹಲೋ ವಿಶ್ವ.",
-    "kazakh": "Сәлем Әлем.",
-    "khmer": "សួស្តី​ពិភពលោក។",
-    "kinyarwanda": "Mwaramutse isi.",
-    "korean": "안녕하세요 세계입니다.",
-    "kurdish": "Hello cîhanê.",
-    "kyrgyz": "Салам дүйнө.",
-    "lao": "ສະ​ບາຍ​ດີ​ຊາວ​ໂລກ.",
-    "latin": "Salve mundi.",
-    "latvian": "Sveika pasaule.",
-    "lithuanian": "Labas pasauli.",
-    "luxembourgish": "Moien Welt.",
-    "macedonian": "Здраво свету.",
-    "malagasy": "Hello World.",
-    "malay": "Hai dunia.",
-    "malayalam": "ഹലോ വേൾഡ്.",
-    "maltese": "Hello dinja.",
-    "maori": "Kia ora te ao.",
-    "marathi": "नमस्कार जग.",
-    "mongolian": "Сайн уу ертөнц.",
-    "myanmar": "မင်္ဂလာပါကမ္ဘာလောက။",
-    "nepali": "नमस्कार संसार।",
-    "norwegian": "Hei Verden.",
-    "odia": "ନମସ୍କାର ବିଶ୍ୱବାସି।",
-    "pashto": "سلام نړی.",
-    "persian": "سلام دنیا.",
-    "polish": "Witaj świecie.",
-    "portuguese": "Olá Mundo.",
-    "punjabi": "ਸਤਿ ਸ੍ਰੀ ਅਕਾਲ ਦੁਨਿਆ.",
-    "romanian": "Salut Lume.",
-    "russian": "Привет, мир.",
-    "samoan": "Talofa lalolagi.",
-    "scots gaelic": "Hàlo a Shaoghail.",
-    "serbian": "Здраво Свете.",
-    "sesotho": "Lefatše Lumela.",
-    "shona": "Mhoro nyika.",
-    "sindhi": "هيلو دنيا.",
-    "sinhala": "හෙලෝ වර්ල්ඩ්.",
-    "slovak": "Ahoj svet.",
-    "slovenian": "Pozdravljen, svet.",
-    "somali": "Salaamu calaykum.",
-    "spanish": "Hola Mundo.",
-    "sundanese": "Halo Dunya.",
-    "swahili": "Salamu, Dunia.",
-    "swedish": "Hej världen.",
-    "tajik": "Салом Ҷаҳон.",
-    "tamil": "வணக்கம் உலகம்.",
-    "tatar": "Сәлам, Дөнья.",
-    "telugu": "హలో వరల్డ్.",
-    "thai": "สวัสดีชาวโลก.",
-    "turkish": "Selam Dünya.",
-    "turkmen": "Salam dünýä.",
-    "ukrainian": "Привіт Світ.",
-    "urdu": "سلام دنیا۔",
-    "uyghur": "ياخشىمۇسىز دۇنيا.",
-    "uzbek": "Salom Dunyo.",
-    "vietnamese": "Chào thế giới.",
-    "welsh": "Helo Byd.",
-    "xhosa": "Molo Lizwe.",
-    "yiddish": "העלא וועלט.",
-    "yoruba": "Mo ki O Ile Aiye.",
-    "zulu": "Sawubona Mhlaba."
-}
-
-
-@pytest.fixture
-def google_translator():
-    """Sample pytest fixture.
-    See more at: http://doc.pytest.org/en/latest/fixture.html
-    """
-    return GoogleTranslator(target='en')
-
-
-def test_content(google_translator):
-    """Sample pytest test function with the pytest fixture as an argument."""
-    # from bs4 import BeautifulSoup
-    # assert 'GitHub' in BeautifulSoup(response.content).title.string
-    assert google_translator.translate(text='좋은') == "good"
-
-
-def test_abbreviations_and_languages_mapping():
-    for abb, lang in GOOGLE_CODES_TO_LANGUAGES.items():
-        if abb != 'en':
-            g1 = GoogleTranslator(abb)
-            g2 = GoogleTranslator(lang)
-            assert g1._source == g2._source
-
-
-def test_inputs():
-    with pytest.raises(exceptions.LanguageNotSupportedException):
-        GoogleTranslator(source="", target="")
-
-    with pytest.raises(exceptions.LanguageNotSupportedException):
-        GoogleTranslator(source="auto", target="nothing")
-
-def test_payload(google_translator):
-
-    with pytest.raises(exceptions.NotValidPayload):
-        google_translator.translate(text="")
-        google_translator.translate(text='1234')
-        google_translator.translate(text='{}')
-        google_translator.translate(text='%@')
-
-    with pytest.raises(exceptions.NotValidPayload):
-        google_translator.translate(text=123)
-
-    with pytest.raises(exceptions.NotValidPayload):
-        google_translator.translate(text={})
-
-    with pytest.raises(exceptions.NotValidPayload):
-        google_translator.translate(text=[])
-
-    with pytest.raises(exceptions.NotValidLength):
-        google_translator.translate("a"*5001)
-
-def test_one_character_words():
-    assert GoogleTranslator(source='es', target='en').translate('o') == 'or'

tests/test_libre.py

@@ -6,27 +6,6 @@ import pytest
 from deep_translator import exceptions, LibreTranslator
 from deep_translator.constants import LIBRE_CODES_TO_LANGUAGES
 
-test_text_standard = 'Hello world.'
-TRANSLATED_RESULTS = {
-    'English': 'Hello world.',
-    'Arabic': 'مرحبا العالم.',
-    'Chinese': '霍洛美世界。',
-    'French': 'Bonjour.',
-    'German': 'Hallo Welt.',
-    'Hindi': 'नमस्ते दुनिया।',
-    'Indonesian': 'Halo dunia.',
-    'Irish': 'Dia duit domhan.',
-    'Italian': 'Ciao mondo.',
-    'Japanese': 'こんにちは。',
-    'Korean': '안녕하세요.',
-    'Polish': 'Hello world (ang.).',
-    'Portuguese': 'Olá, mundo.',
-    'Russian': 'Привет мир.',
-    'Spanish': 'Hola mundo.',
-    'Turkish': 'Merhaba dünya.',
-    'Vietnamese': 'Xin chào.'
-}
-
 
 @pytest.fixture
 def libre():
@@ -35,31 +14,28 @@ def libre():
 
 def test_content(libre):
     """Sample pytest test function with the pytest fixture as an argument."""
-    # from bs4 import BeautifulSoup
-    # assert 'GitHub' in BeautifulSoup(response.content).title.string
     assert libre.translate(text='good') is not None
 
 
 def test_inputs():
-    with pytest.raises(exceptions.LanguageNotSupportedException):
+    with pytest.raises(exceptions.InvalidSourceOrTargetLanguage):
         LibreTranslator(source="", target="")
 
-    with pytest.raises(exceptions.LanguageNotSupportedException):
-        LibreTranslator(source="auto", target="nothing")
+    with pytest.raises(exceptions.InvalidSourceOrTargetLanguage):
+        LibreTranslator(source="auto", target="")
+
+    with pytest.raises(exceptions.InvalidSourceOrTargetLanguage):
+        LibreTranslator(source="", target="en")
 
 
 def test_abbreviations_and_languages_mapping():
     for abb, lang in LIBRE_CODES_TO_LANGUAGES.items():
-        if abb != 'en':
-            l1 = LibreTranslator(abb)
-            l2 = LibreTranslator(lang)
-            assert l1.source == l2.source
+        l1 = LibreTranslator(abb)
+        l2 = LibreTranslator(lang)
+        assert l1._source == l2._source
 
 
 def test_payload(libre):
-    with pytest.raises(exceptions.NotValidPayload):
-        libre.translate("")
-
     with pytest.raises(exceptions.NotValidPayload):
         libre.translate(123)
 

tests/test_linguee.py

@@ -19,11 +19,14 @@ def test_content(linguee):
 
 
 def test_inputs():
-    with pytest.raises(exceptions.LanguageNotSupportedException):
+    with pytest.raises(exceptions.InvalidSourceOrTargetLanguage):
         LingueeTranslator(source="", target="")
 
-    with pytest.raises(exceptions.LanguageNotSupportedException):
-        LingueeTranslator(source="auto", target="nothing")
+    with pytest.raises(exceptions.InvalidSourceOrTargetLanguage):
+        LingueeTranslator(source="auto", target="")
+
+    with pytest.raises(exceptions.InvalidSourceOrTargetLanguage):
+        LingueeTranslator(source="", target="en")
 
     l1 = LingueeTranslator("en", "fr")
     l2 = LingueeTranslator("english", "french")
@@ -33,9 +36,6 @@ def test_inputs():
 
 def test_payload(linguee):
 
-    with pytest.raises(exceptions.NotValidPayload):
-        linguee.translate("")
-
     with pytest.raises(exceptions.NotValidPayload):
         linguee.translate(123)
 
@@ -47,12 +47,3 @@ def test_payload(linguee):
 
     with pytest.raises(exceptions.NotValidLength):
         linguee.translate("a"*51)
-
-
-
-def test_translate_words(linguee):
-    words = ['hello', 'world']
-    translated_words = linguee.translate_words(words)
-
-def test_one_character_words():
-    assert LingueeTranslator(source='es', target='en').translate('y') == 'and'

tests/test_microsoft_trans.py

@@ -58,5 +58,5 @@ def test_incorrect_target_attributes():
 def test_abbreviations():
     m1 = MicrosoftTranslator(api_key=APIkey, source="en", target="fr")
     m2 = MicrosoftTranslator(api_key=APIkey, source="English", target="French")
-    assert ''.join(m1.source) == ''.join(m2.source)
-    assert ''.join(m1.target) == ''.join(m2.target)
+    assert ''.join(m1._source) == ''.join(m2._source)
+    assert ''.join(m1._target) == ''.join(m2._target)

tests/test_mymemory.py

@@ -19,11 +19,15 @@ def test_content(mymemory):
 
 
 def test_inputs():
-    with pytest.raises(exceptions.LanguageNotSupportedException):
+    with pytest.raises(exceptions.InvalidSourceOrTargetLanguage):
         MyMemoryTranslator(source="", target="")
 
-    with pytest.raises(exceptions.LanguageNotSupportedException):
-        MyMemoryTranslator(source="auto", target="nothing")
+    with pytest.raises(exceptions.InvalidSourceOrTargetLanguage):
+        MyMemoryTranslator(source="auto", target="")
+
+    with pytest.raises(exceptions.InvalidSourceOrTargetLanguage):
+        MyMemoryTranslator(source="", target="en")
+
     m1 = MyMemoryTranslator("en", "fr")
     m2 = MyMemoryTranslator("english", "french")
     assert m1._source == m2._source
@@ -48,6 +52,3 @@ def test_payload(mymemory):
         mymemory.translate(text="a"*501)
 
 
-def test_one_character_words(mymemory):
-    assert mymemory.translate('I')
-

tests/test_pons.py

@@ -19,11 +19,15 @@ def test_content(pons):
 
 
 def test_inputs():
-    with pytest.raises(exceptions.LanguageNotSupportedException):
+    with pytest.raises(exceptions.InvalidSourceOrTargetLanguage):
         PonsTranslator(source="", target="")
 
-    with pytest.raises(exceptions.LanguageNotSupportedException):
-        PonsTranslator(source="auto", target="nothing")
+    with pytest.raises(exceptions.InvalidSourceOrTargetLanguage):
+        PonsTranslator(source="auto", target="")
+
+    with pytest.raises(exceptions.InvalidSourceOrTargetLanguage):
+        PonsTranslator(source="", target="en")
+
     l1 = PonsTranslator("en", "fr")
     l2 = PonsTranslator("english", "french")
     assert l1._source == l2._source
@@ -31,10 +35,6 @@ def test_inputs():
 
 
 def test_payload(pons):
-
-    with pytest.raises(exceptions.NotValidPayload):
-        pons.translate("")
-
     with pytest.raises(exceptions.NotValidPayload):
         pons.translate(123)
 
@@ -47,11 +47,3 @@ def test_payload(pons):
     with pytest.raises(exceptions.NotValidLength):
         pons.translate("a" * 51)
 
-
-
-def test_translate_words(pons):
-    words = ['hello', 'world']
-    translated_words = pons.translate_words(words)
-
-def test_one_character_words(pons):
-    assert pons.translate('I')