added unit tests for cli

deep_translator/__main__.py

@@ -4,44 +4,7 @@ from .cli import CLI
 
 
 def main():
-    """
-    function responsible for parsing terminal arguments and provide them for further use in the translation process
-    """
-    parser = argparse.ArgumentParser(add_help=True,
-                                     description="Official CLI for deep-translator",
-                                     usage="dt --help")
-
-    parser.add_argument('--translator',
-                        '-trans',
-                        default='google',
-                        type=str,
-                        help="name of the translator you want to use")
-    parser.add_argument('--source',
-                        '-src',
-                        default='auto',
-                        type=str,
-                        help="source language to translate from")
-    parser.add_argument('--target',
-                        '-tg',
-                        type=str,
-                        help="target language to translate to")
-    parser.add_argument('--text',
-                        '-txt',
-                        type=str,
-                        help="text you want to translate")
-    parser.add_argument('--languages',
-                        '-lang',
-                        action='store_true',
-                        help="all the languages available with the translator"
-                             "Run the command deep_translator -trans <translator service> -lang")
-
-    args = parser.parse_args()
-
-    cli = CLI(args)
-    if args.languages:
-        cli.get_supported_languages()
-    else:
-        cli.translate()
+    CLI().run()
 
 
 if __name__ == "__main__":

deep_translator/cli.py

@@ -1,5 +1,4 @@
 """Console script for deep_translator."""
-import sys
 
 from .google_trans import GoogleTranslator
 from .mymemory import MyMemoryTranslator
@@ -11,6 +10,7 @@ from .qcri import QCRI
 from .papago import PapagoTranslator
 from .microsoft import MicrosoftTranslator
 from .libre import LibreTranslator
+import argparse
 
 
 class CLI(object):
@@ -18,7 +18,7 @@ class CLI(object):
     translators_dict = None
     translator = None
 
-    def __init__(self, args):
+    def __init__(self, custom_args=None):
         self.translators_dict = {
             'google': GoogleTranslator,
             'pons': PonsTranslator,
@@ -31,12 +31,14 @@ class CLI(object):
             'qcri': QCRI,
             'papago': PapagoTranslator
         }
-        self.args = args
+        self.custom_args = custom_args
+        self.args = self.parse_args()
+
         translator_class = self.translators_dict.get(self.args.translator, None)
         if not translator_class:
             raise Exception(f"Translator {self.args.translator} is not supported."
                             f"Supported translators: {list(self.translators_dict.keys())}")
-        self.translator = translator_class(source=args.source, target=args.target)
+        self.translator = translator_class(source=self.args.source, target=self.args.target)
 
     def translate(self):
         """
@@ -58,5 +60,43 @@ class CLI(object):
         print(f'Languages supported by \'{self.args.translator}\' are :\n')
         print(translator_supported_languages)
 
+    def parse_args(self):
+        """
+        function responsible for parsing terminal arguments and provide them for further use in the translation process
+        """
+        parser = argparse.ArgumentParser(add_help=True,
+                                         description="Official CLI for deep-translator",
+                                         usage="dt --help")
 
+        parser.add_argument('--translator',
+                            '-trans',
+                            default='google',
+                            type=str,
+                            help="name of the translator you want to use")
+        parser.add_argument('--source',
+                            '-src',
+                            default='auto',
+                            type=str,
+                            help="source language to translate from")
+        parser.add_argument('--target',
+                            '-tg',
+                            type=str,
+                            help="target language to translate to")
+        parser.add_argument('--text',
+                            '-txt',
+                            type=str,
+                            help="text you want to translate")
+        parser.add_argument('--languages',
+                            '-lang',
+                            action='store_true',
+                            help="all the languages available with the translator"
+                                 "Run the command deep_translator -trans <translator service> -lang")
+        parsed_args = parser.parse_args(self.custom_args) if self.custom_args else parser.parse_args()
+        print(f"parsed args: {parsed_args}")
+        return parsed_args
 
+    def run(self):
+        if self.args.languages:
+            self.get_supported_languages()
+        else:
+            self.translate()

tests/test_cli.py

@@ -2,30 +2,22 @@
 
 """Tests for the CLI interface."""
 
-# from click.testing import CliRunner
-# from deep_translator.main import cli
-#
-#
-# class TestClass:
-#     def test_translate(self):
-#         runner = CliRunner()
-#         result = runner.invoke(cli, ['translate', 'google', '-src=auto', '-tgt=en', '-txt=좋은'])
-#         assert 'good' in result.output
-#         assert result.exit_code == 0
-#
-#     def test_api_key_error(self):
-#         runner = CliRunner()
-#         result = runner.invoke(cli, ['translate', 'microsoft','-src=auto','-tgt=en','-txt=\'Zwei minimale Dellchen auf der Rückseite.\''])
-#         assert "This translator requires an api key provided through --api-key" in result.output
-#         assert result.exit_code == 1
-#
-#     def test_language_languages(self):
-#         runner = CliRunner()
-#         result = runner.invoke(cli, ['languages', 'google'])
-#         assert result.exit_code == 0
-#
-#     def test_invalid_language_languages(self):
-#         runner = CliRunner()
-#         result = runner.invoke(cli, ['languages', 'notValidTranslator'])
-#         assert 'The given translator is not supported.' in str(result.exception)
-#         assert result.exit_code == 1
+from deep_translator.cli import CLI
+import pytest
+import sys
+
+
+@pytest.fixture
+def mock_args():
+    sys.argv[1:] = ['--source', 'en', '--target', 'de', '--text', 'hello']
+    return CLI(sys.argv[1:]).parse_args()
+
+
+def test_source(mock_args):
+    assert mock_args.source == 'en'
+
+
+def test_target(mock_args):
+    assert mock_args.target == 'de'
+
+

tests/test_google_trans.py

@@ -135,6 +135,7 @@ def test_content(google_translator):
     # assert 'GitHub' in BeautifulSoup(response.content).title.string
     assert google_translator.translate(text='좋은') == "good"
 
+
 def test_abbreviations_and_languages_mapping():
     for abb, lang in GOOGLE_CODES_TO_LANGUAGES.items():
         if abb != 'en':
@@ -142,6 +143,7 @@ def test_abbreviations_and_languages_mapping():
             g2 = GoogleTranslator(lang)
             assert g1._source == g2._source
 
+
 def test_inputs():
     with pytest.raises(exceptions.LanguageNotSupportedException):
         GoogleTranslator(source="", target="")