fix: make setup more strict

app/lib/github-app.server.ts

@@ -3,10 +3,14 @@ import { createAppAuth } from "@octokit/auth-app";
 import jwt from "jsonwebtoken";
 
 // GitHub App configuration - these should be environment variables in production
-const GITHUB_APP_ID = process.env.GITHUB_APP_ID || "1356087";
-const GITHUB_APP_PRIVATE_KEY = process.env.GITHUB_APP_PRIVATE_KEY || "your-private-key";
-const GITHUB_APP_CLIENT_ID = process.env.GITHUB_APP_CLIENT_ID || "Iv23liFxEtiiREnjOeB2";
-const GITHUB_APP_CLIENT_SECRET = process.env.GITHUB_APP_CLIENT_SECRET || "your-client-secret";
+const GITHUB_APP_ID = process.env.GITHUB_APP_ID;
+const GITHUB_APP_PRIVATE_KEY = process.env.GITHUB_APP_PRIVATE_KEY;
+const GITHUB_APP_CLIENT_ID = process.env.GITHUB_APP_CLIENT_ID;
+const GITHUB_APP_CLIENT_SECRET = process.env.GITHUB_APP_CLIENT_SECRET;
+
+if (!GITHUB_APP_ID || !GITHUB_APP_PRIVATE_KEY || !GITHUB_APP_CLIENT_ID || !GITHUB_APP_CLIENT_SECRET) {
+  throw new Error('Missing required GitHub App environment variables. Please check your .env file.');
+}
 
 // For now, we'll hardcode a simple in-memory store
 // In production, you'd use a database
@@ -30,7 +34,12 @@ export class GitHubAppAuth {
    * Generate the installation URL for users to authorize the app
    */
   getInstallationUrl(state?: string): string {
-    const baseUrl = `https://github.com/apps/${process.env.GITHUB_APP_NAME || 'hugex-gh'}/installations/new`;
+    const appName = process.env.GITHUB_APP_NAME;
+    if (!appName) {
+      throw new Error('GITHUB_APP_NAME environment variable is required for installation URL');
+    }
+    
+    const baseUrl = `https://github.com/apps/${appName}/installations/new`;
     const params = new URLSearchParams();
     
     if (state) {
@@ -44,9 +53,14 @@ export class GitHubAppAuth {
    * Get OAuth authorization URL for user identity
    */
   getOAuthUrl(state?: string): string {
+    const callbackUrl = process.env.GITHUB_CALLBACK_URL;
+    if (!callbackUrl) {
+      throw new Error('GITHUB_CALLBACK_URL environment variable is required');
+    }
+    
     const params = new URLSearchParams({
       client_id: GITHUB_APP_CLIENT_ID,
-      redirect_uri: process.env.GITHUB_CALLBACK_URL || 'http://localhost:3000/auth/github/callback',
+      redirect_uri: callbackUrl,
       scope: 'user:email',
       state: state || '',
     });

app/lib/session.server.ts

@@ -1,5 +1,20 @@
 import { createCookieSessionStorage } from "@remix-run/node";
 
+export { getSession, commitSession, destroySession };
+
+export interface UserSession {
+  userId: string;
+  login: string;
+  name?: string;
+  email?: string;
+  avatar_url?: string;
+}
+
+const sessionSecret = process.env.SESSION_SECRET;
+if (!sessionSecret) {
+  throw new Error('SESSION_SECRET environment variable is required');
+}
+
 const { getSession, commitSession, destroySession } = createCookieSessionStorage({
   cookie: {
     name: "__session",
@@ -7,21 +22,11 @@ const { getSession, commitSession, destroySession } = createCookieSessionStorage
     maxAge: 60 * 60 * 24 * 30, // 30 days
     path: "/",
     sameSite: "lax",
-    secrets: [process.env.SESSION_SECRET || "your-secret-key"],
+    secrets: [sessionSecret],
     secure: process.env.NODE_ENV === "production",
   },
 });
 
-export { getSession, commitSession, destroySession };
-
-export interface UserSession {
-  userId: string;
-  login: string;
-  name?: string;
-  email?: string;
-  avatar_url?: string;
-}
-
 export async function requireUserSession(request: Request): Promise<UserSession> {
   const session = await getSession(request.headers.get("Cookie"));
   const userSession = session.get("user");

app/routes/status.tsx

@@ -8,12 +8,12 @@ export async function loader({ request }: LoaderFunctionArgs) {
     GITHUB_APP_ID: {
       value: process.env.GITHUB_APP_ID || null,
       required: true,
-      example: "1356087",
+      example: "your-app-id",
     },
     GITHUB_APP_NAME: {
       value: process.env.GITHUB_APP_NAME || null,
       required: true,
-      example: "hugex-gh",
+      example: "your-app-name",
     },
     GITHUB_APP_PRIVATE_KEY: {
       value: process.env.GITHUB_APP_PRIVATE_KEY ? "✓ Set" : null,
@@ -23,7 +23,7 @@ export async function loader({ request }: LoaderFunctionArgs) {
     GITHUB_APP_CLIENT_ID: {
       value: process.env.GITHUB_APP_CLIENT_ID || null,
       required: true,
-      example: "Iv23liFxEtiiREnjOeB2",
+      example: "your-client-id",
     },
     GITHUB_APP_CLIENT_SECRET: {
       value: process.env.GITHUB_APP_CLIENT_SECRET ? "✓ Set" : null,