Update app.py

app.py

@@ -6,16 +6,12 @@ import datetime as dt
 import gradio as gr
 from utils import extract_kyc_fields
 
-# ------------------------------------------------------------------
-# 🔐 CREDENTIALS STRATEGY
-# Prefer environment variables (Hugging Face Space Secrets or local env).
-# Emergency fallback (NOT recommended): replace these locally.
-# ------------------------------------------------------------------
-SF_DEFAULT_USERNAME = os.getenv("[email protected]", "REPLACE_ME_USERNAME")
-SF_DEFAULT_PASSWORD = os.getenv("Lic@2025", "REPLACE_ME_PASSWORD")
-SF_DEFAULT_TOKEN    = os.getenv("AmmfRcd6IiYaRtSGntBnzNMQU", "REPLACE_ME_SECURITY_TOKEN")
-SF_DEFAULT_DOMAIN   = os.getenv("SF_DOMAIN", "login")  # "login" (prod) or "test" (sandbox)
-# ------------------------------------------------------------------
+# ------------------ HARD-CODED SALESFORCE CREDS (as requested) ------------------
+SF_USERNAME = "[email protected]"
+SF_PASSWORD = "Lic@2025"
+SF_SECURITY_TOKEN = "AmmfRcd6IiYaRtSGntBnzNMQU"
+SF_DOMAIN = "login"   # "login" for prod, "test" for sandbox
+# -------------------------------------------------------------------------------
 
 # simple-salesforce + exceptions
 try:
@@ -72,15 +68,10 @@ def _parse_birthdate(dob_text: str):
 
 
 def _fmt_sf_error(err: Exception):
-    """
-    Produce a clear, JSON-safe dict from any simple-salesforce error.
-    """
-    # Default
+    """Produce a clear, JSON-safe dict from any simple-salesforce error."""
     info = {"type": err.__class__.__name__, "message": str(err)}
 
-    # Enrich known exceptions
     if isinstance(err, SalesforceAuthenticationFailed):
-        # Has attributes: code, response.content, status, message, etc.
         content = getattr(err, "content", None) or getattr(err, "response", None)
         info.update({
             "category": "AUTHENTICATION",
@@ -88,7 +79,6 @@ def _fmt_sf_error(err: Exception):
             "content": getattr(content, "content", None) if hasattr(content, "content") else content,
         })
     elif isinstance(err, (SalesforceMalformedRequest, SalesforceGeneralError, SalesforceRefusedRequest)):
-        # These typically have status/resource_name/content/url
         info.update({
             "category": "REQUEST",
             "status": getattr(err, "status", None),
@@ -100,34 +90,25 @@ def _fmt_sf_error(err: Exception):
         info.update({"category": "NOT_FOUND"})
     elif isinstance(err, SalesforceExpiredSession):
         info.update({"category": "AUTH_EXPIRED"})
-
     return info
 
 
-def sf_connect_from_env_or_defaults():
+def sf_connect():
     """
-    Tries env vars first (HF Space Secrets / local env), then hardcoded defaults.
-    Env vars: SF_USERNAME, SF_PASSWORD, SF_SECURITY_TOKEN, SF_DOMAIN
-    Also runs a quick auth test query to surface auth issues early.
+    Connect to Salesforce using the hardcoded credentials.
+    Also runs a quick auth query to surface any auth issues clearly.
     """
     if not SF_AVAILABLE:
         raise RuntimeError("simple-salesforce is not installed. Add `simple-salesforce` to requirements.txt.")
 
-    username = os.getenv("SF_USERNAME", SF_DEFAULT_USERNAME)
-    password = os.getenv("SF_PASSWORD", SF_DEFAULT_PASSWORD)
-    token    = os.getenv("SF_SECURITY_TOKEN", SF_DEFAULT_TOKEN)
-    domain   = os.getenv("SF_DOMAIN", SF_DEFAULT_DOMAIN or "login")
-
-    if any(v.startswith("REPLACE_ME") for v in [username, password, token]):
-        raise ValueError(
-            "Salesforce credentials missing. "
-            "Set env vars (SF_USERNAME, SF_PASSWORD, SF_SECURITY_TOKEN, SF_DOMAIN) "
-            "or replace the REPLACE_ME_* constants in app.py."
-        )
-
     try:
-        sf = Salesforce(username=username, password=password, security_token=token, domain=domain)
-        # 🔎 lightweight auth sanity check
+        sf = Salesforce(
+            username=SF_USERNAME,
+            password=SF_PASSWORD,
+            security_token=SF_SECURITY_TOKEN,
+            domain=SF_DOMAIN,
+        )
+        # quick auth sanity check
         sf.query("SELECT Id FROM User LIMIT 1")
         return sf
     except Exception as e:
@@ -137,7 +118,7 @@ def sf_connect_from_env_or_defaults():
 def sf_push_kyc_record(sf, ocr_results):
     """
     Create one KYC_Record__c combining Aadhaar + PAN.
-    Fields:
+    Salesforce custom object fields:
       Aadhaar_Number__c, Aadhaar_Name__c, Aadhaar_DOB__c (Date)
       PAN_Number__c,    Pan_Name__c,     Pan_DOB__c     (Date)
     """
@@ -145,29 +126,27 @@ def sf_push_kyc_record(sf, ocr_results):
     p = ocr_results.get("pan") or {}
 
     aadhaar_number = a.get("aadhaar_number") if (a.get("card_type") == "AADHAAR") else None
-    aadhaar_name   = a.get("name") if (a.get("card_type") == "AADHAAR") else None
+    aadhaar_name   = a.get("name")           if (a.get("card_type") == "AADHAAR") else None
     aadhaar_dob    = _parse_birthdate(a.get("dob")) if (a.get("card_type") == "AADHAAR") else None
 
     pan_number     = p.get("pan_number") if (p.get("card_type") == "PAN") else None
-    pan_name       = p.get("name") if (p.get("card_type") == "PAN") else None
+    pan_name       = p.get("name")       if (p.get("card_type") == "PAN") else None
     pan_dob        = _parse_birthdate(p.get("dob")) if (p.get("card_type") == "PAN") else None
 
     payload = {
         "Aadhaar_Number__c": aadhaar_number,
         "Aadhaar_Name__c":   aadhaar_name,
-        "Aadhaar_DOB__c":    aadhaar_dob,   # Date field in SF
+        "Aadhaar_DOB__c":    aadhaar_dob,
         "PAN_Number__c":     pan_number,
         "Pan_Name__c":       pan_name,
-        "Pan_DOB__c":        pan_dob,       # Date field in SF
+        "Pan_DOB__c":        pan_dob,
     }
-    # Remove None keys to avoid nulling non-nullable fields
     payload = {k: v for k, v in payload.items() if v is not None}
 
     try:
         result = sf.KYC_Record__c.create(payload)
         return {"success": True, "id": result.get("id"), "payload": payload}
     except Exception as e:
-        # Return rich error info
         return {"success": False, "error": _fmt_sf_error(e), "payload": payload}
 
 
@@ -204,7 +183,7 @@ def process_documents(aadhaar_file, pan_file, push_to_sf):
 
     if push_to_sf:
         try:
-            sf = sf_connect_from_env_or_defaults()
+            sf = sf_connect()
             created = sf_push_kyc_record(sf, results)
             output["salesforce"] = {"pushed": created.get("success", False), **created}
         except Exception as e:
@@ -219,10 +198,6 @@ with gr.Blocks(title="Smart KYC OCR → Salesforce (KYC_Record__c)") as demo:
         """
         # 🧾 Smart KYC OCR → Salesforce
         Upload **Aadhaar** and **PAN** in separate boxes, then (optional) push one **KYC_Record__c**.
-
-        **Creds**: Set env vars (preferred)  
-        `SF_USERNAME`, `SF_PASSWORD`, `SF_SECURITY_TOKEN`, `SF_DOMAIN` (login|test)  
-        or replace the placeholders in `app.py` (not recommended).
         """
     )
 
@@ -252,7 +227,7 @@ with gr.Blocks(title="Smart KYC OCR → Salesforce (KYC_Record__c)") as demo:
     gr.Markdown("---")
     gr.Markdown(
         """
-        🔒 **Note:** If you see an error, the response now includes the Salesforce status, URL, and error body.
+        ⚠️ Credentials are embedded in this file. Keep this code private and rotate the token if shared.
         """
     )