update with async issues

app.py

@@ -44,7 +44,7 @@ class BasicAgent:
             get_current_time_in_timezone
         ]
         
-        self.chat_with_tools = self.chat.with_tools(self.tools)
+        self.chat_with_tools = self.chat.bind_tools(self.tools)
         print(f"Total tools available: {len(self.tools)}")
 
     async def answer(self, question: str) -> str:
@@ -53,33 +53,56 @@ class BasicAgent:
         response = await asyncio.to_thread(self.chat_with_tools.invoke, {"messages": messages})
         return response['messages'][-1].content[14:]
 
-async def run_agent_async(agent, questions_data):
-    # results_log, answers_payload = [], []
-    tasks = []
+    def answer_sync(self, question: str) -> str:
+        """Synchronous version of answer method"""
+        print(f"Agent received question (first 50 chars): {question[:50]}...")
+        messages = [HumanMessage(content=question)]
+        response = self.chat_with_tools.invoke({"messages": messages})
+        return response.content
 
-    print(f"Running agent on {len(questions_data)} questions...")
-    results_log, answers_payload = asyncio.run(run_agent_async(agent, questions_data))
+async def run_agent_async(agent, questions_data):
+    """Run agent asynchronously on all questions"""
+    results_log, answers_payload = [], []
 
-    async def process(task_id, question):
+    async def process_question(task_id, question):
         try:
             answer = await agent.answer(question)
             return task_id, question, answer, None
         except Exception as e:
             return task_id, question, None, str(e)
 
-    results = await asyncio.gather(*(process(tid, q) for tid, q in tasks))
-    for tid, question, answer, error in results:
+    # Create tasks for all questions
+    tasks = []
+    for item in questions_data:
+        task_id = item.get("task_id")
+        question_text = item.get("question")
+        if not task_id or question_text is None:
+            print(f"Skipping item with missing task_id or question: {item}")
+            continue
+        tasks.append(process_question(task_id, question_text))
+
+    print(f"Processing {len(tasks)} questions asynchronously...")
+    
+    # Process all questions concurrently
+    results = await asyncio.gather(*tasks, return_exceptions=True)
+    
+    for result in results:
+        if isinstance(result, Exception):
+            print(f"Unexpected error: {result}")
+            continue
+            
+        task_id, question, answer, error = result
         if error:
-            print(f"Error running agent on task {tid}: {error}")
-            results_log.append({"Task ID": tid, "Question": question, "Submitted Answer": f"AGENT ERROR: {error}"})
+            print(f"Error running agent on task {task_id}: {error}")
+            results_log.append({"Task ID": task_id, "Question": question, "Submitted Answer": f"AGENT ERROR: {error}"})
         else:
-            answers_payload.append({"task_id": tid, "submitted_answer": answer})
-            results_log.append({"Task ID": tid, "Question": question, "Submitted Answer": answer})
+            answers_payload.append({"task_id": task_id, "submitted_answer": answer})
+            results_log.append({"Task ID": task_id, "Question": question, "Submitted Answer": answer})
 
     return results_log, answers_payload
 
 
-def run_and_submit_all( profile: gr.OAuthProfile | None):
+def run_and_submit_all(profile: gr.OAuthProfile | None):
     """
     Fetches all questions, runs the BasicAgent on them, submits all answers,
     and displays the results.
@@ -88,7 +111,7 @@ def run_and_submit_all( profile: gr.OAuthProfile | None):
     space_id = os.getenv("SPACE_ID") # Get the SPACE_ID for sending link to the code
 
     if profile:
-        username= f"{profile.username}"
+        username = f"{profile.username}"
         print(f"User logged in: {username}")
     else:
         print("User not logged in.")
@@ -98,13 +121,14 @@ def run_and_submit_all( profile: gr.OAuthProfile | None):
     questions_url = f"{api_url}/questions"
     submit_url = f"{api_url}/submit"
 
-    # 1. Instantiate Agent ( modify this part to create your agent)
+    # 1. Instantiate Agent (modify this part to create your agent)
     try:
         agent = BasicAgent()
     except Exception as e:
         print(f"Error instantiating agent: {e}")
         return f"Error initializing agent: {e}", None
-    # In the case of an app running as a hugging Face space, this link points toward your codebase ( usefull for others so please keep it public)
+    
+    # In the case of an app running as a Hugging Face space, this link points toward your codebase (useful for others so please keep it public)
     agent_code = f"https://huggingface.co/spaces/{space_id}/tree/main"
     print(agent_code)
 
@@ -115,16 +139,16 @@ def run_and_submit_all( profile: gr.OAuthProfile | None):
         response.raise_for_status()
         questions_data = response.json()
         if not questions_data:
-             print("Fetched questions list is empty.")
-             return "Fetched questions list is empty or invalid format.", None
+            print("Fetched questions list is empty.")
+            return "Fetched questions list is empty or invalid format.", None
         print(f"Fetched {len(questions_data)} questions.")
     except requests.exceptions.RequestException as e:
         print(f"Error fetching questions: {e}")
         return f"Error fetching questions: {e}", None
     except requests.exceptions.JSONDecodeError as e:
-         print(f"Error decoding JSON response from questions endpoint: {e}")
-         print(f"Response text: {response.text[:500]}")
-         return f"Error decoding server response for questions: {e}", None
+        print(f"Error decoding JSON response from questions endpoint: {e}")
+        print(f"Response text: {response.text[:500]}")
+        return f"Error decoding server response for questions: {e}", None
     except Exception as e:
         print(f"An unexpected error occurred fetching questions: {e}")
         return f"An unexpected error occurred fetching questions: {e}", None
@@ -132,20 +156,27 @@ def run_and_submit_all( profile: gr.OAuthProfile | None):
     # 3. Run your Agent
     results_log = []
     answers_payload = []
-    print(f"Running agent on {len(questions_data)} questions...")
-    for item in questions_data:
-        task_id = item.get("task_id")
-        question_text = item.get("question")
-        if not task_id or question_text is None:
-            print(f"Skipping item with missing task_id or question: {item}")
-            continue
-        try:
-            submitted_answer = agent(question_text)
-            answers_payload.append({"task_id": task_id, "submitted_answer": submitted_answer})
-            results_log.append({"Task ID": task_id, "Question": question_text, "Submitted Answer": submitted_answer})
-        except Exception as e:
-             print(f"Error running agent on task {task_id}: {e}")
-             results_log.append({"Task ID": task_id, "Question": question_text, "Submitted Answer": f"AGENT ERROR: {e}"})
+    
+    # Try async approach first, fall back to sync if needed
+    try:
+        print(f"Running agent asynchronously on {len(questions_data)} questions...")
+        results_log, answers_payload = asyncio.run(run_agent_async(agent, questions_data))
+    except Exception as e:
+        print(f"Async processing failed: {e}, falling back to synchronous processing...")
+        # Fallback to synchronous processing
+        for item in questions_data:
+            task_id = item.get("task_id")
+            question_text = item.get("question")
+            if not task_id or question_text is None:
+                print(f"Skipping item with missing task_id or question: {item}")
+                continue
+            try:
+                submitted_answer = agent.answer_sync(question_text)
+                answers_payload.append({"task_id": task_id, "submitted_answer": submitted_answer})
+                results_log.append({"Task ID": task_id, "Question": question_text, "Submitted Answer": submitted_answer})
+            except Exception as e:
+                print(f"Error running agent on task {task_id}: {e}")
+                results_log.append({"Task ID": task_id, "Question": question_text, "Submitted Answer": f"AGENT ERROR: {e}"})
 
     if not answers_payload:
         print("Agent did not produce any answers to submit.")
@@ -253,4 +284,5 @@ if __name__ == "__main__":
     print("-"*(60 + len(" App Starting ")) + "\n")
 
     print("Launching Gradio Interface for Basic Agent Evaluation...")
-    demo.launch(debug=True, share=False)
+    demo.launch(debug=True, share=False)
+