seems to work, nice

src/index.mts

@@ -1,5 +1,7 @@
 import { promises as fs } from 'fs'
+import path from 'node:path'
 
+import tmpDir from 'temp-dir'
 import express from 'express'
 
 import { generateVideo } from './services/generateVideo.mts'
@@ -17,16 +19,18 @@ app.use(express.json())
 app.post('/shot', async (req, res) => {
   const query = req.body as MakeShot
 
+  console.log('received query:', query)
   const token = `${query.token || ''}`
   if (token !== process.env.VS_SECRET_ACCESS_TOKEN) {
+    console.log("couldn't find access token in the query")
     res.write(JSON.stringify({ error: true, message: 'access denied' }))
     res.end()
     return
   }
 
   const shotPrompt = `${query.shotPrompt || ''}`
-  if (shotPrompt.length) {
-    res.write(JSON.stringify({ error: true, message: 'prompt too short' }))
+  if (shotPrompt.length < 5) {
+    res.write(JSON.stringify({ error: true, message: 'prompt too short (must be at least 5 in length)' }))
     res.end()
     return
   }
@@ -37,32 +41,36 @@ app.post('/shot', async (req, res) => {
   // optional audio prompt
   const audioPrompt = `${query.audioPrompt || ''}`
 
-    // optional seed
-    const seedStr = Number(`${query.seed || ''}`)
-    const maybeSeed = Number(seedStr)
-    const seed = isNaN(maybeSeed) || ! isFinite(maybeSeed) ? generateSeed() : maybeSeed
+  // optional seed
+  const seedStr = Number(`${query.seed || ''}`)
+  const maybeSeed = Number(seedStr)
+  const seed = isNaN(maybeSeed) || ! isFinite(maybeSeed) ? generateSeed() : maybeSeed
     
 
   // should we upscale or not?
   const upscale = `${query.upscale || 'false'}` === 'true'
 
   // duration of the prompt, in seconds
-  const durationStr = Number(`${query.duration || ''}`)
+  const defaultDuration = 3
+  const durationStr = Number(`${query.duration || defaultDuration}`)
   const maybeDuration = Number(durationStr)
-  const duration = Math.min(3, Math.max(1, isNaN(maybeDuration) || !isFinite(maybeDuration) ? 3 : maybeDuration))
+  const duration = Math.min(3, Math.max(1, isNaN(maybeDuration) || !isFinite(maybeDuration) ? defaultDuration : maybeDuration))
   
-  const stepsStr = Number(`${query.steps || ''}`)
+  const defaultSteps = 35
+  const stepsStr = Number(`${query.steps || defaultSteps}`)
   const maybeSteps = Number(stepsStr)
-  const nbSteps = Math.min(60, Math.max(1, isNaN(maybeSteps) || !isFinite(maybeSteps) ? 35 : maybeSteps))
+  const nbSteps = Math.min(60, Math.max(1, isNaN(maybeSteps) || !isFinite(maybeSteps) ? defaultSteps : maybeSteps))
   
   // const frames per second
-  const fpsStr = Number(`${query.fps || ''}`)
+  const defaultFps = 24
+  const fpsStr = Number(`${query.fps || defaultFps}`)
   const maybeFps = Number(fpsStr)
-  const fps = Math.min(60, Math.max(8, isNaN(maybeFps) || !isFinite(maybeFps) ? 24 : maybeFps))
+  const fps = Math.min(60, Math.max(8, isNaN(maybeFps) || !isFinite(maybeFps) ? defaultFps : maybeFps))
   
-  const resolutionStr = Number(`${query.resolution || ''}`)
+  const defaultResolution = 576
+  const resolutionStr = Number(`${query.resolution || defaultResolution}`)
   const maybeResolution = Number(resolutionStr)
-  const resolution = Math.min(1080, Math.max(256, isNaN(maybeResolution) || !isFinite(maybeResolution) ? 576 : maybeResolution))
+  const resolution = Math.min(1080, Math.max(256, isNaN(maybeResolution) || !isFinite(maybeResolution) ? defaultResolution : maybeResolution))
   
 
   const shotFileName = `${Date.now()}.mp4`
@@ -101,7 +109,10 @@ app.post('/shot', async (req, res) => {
   }
 
   console.log('returning result to user..')
-  const buffer = await fs.readFile(videoFileName)
+
+  const filePath = path.resolve(tmpDir, videoFileName)
+
+  const buffer = await fs.readFile(filePath)
   res.setHeader('Content-Type', 'media/mp4')
   res.setHeader('Content-Length', buffer.length)
   res.end(buffer)

src/services/downloadVideo.mts

@@ -7,8 +7,13 @@ export const downloadVideo = async (remoteUrl: string, fileName: string): Promis
 
   const filePath = path.resolve(tmpDir, fileName)
 
+  const controller = new AbortController()
+  const timeoutId = setTimeout(() => controller.abort(), 15 * 60 * 60 * 1000) // 15 minutes
+
   // download the video
-  const response = await fetch(remoteUrl)
+  const response = await fetch(remoteUrl, {
+    signal: controller.signal
+  })
 
   // write it to the disk
   const arrayBuffer = await response.arrayBuffer()

src/test.mts

@@ -0,0 +1,23 @@
+import { promises as fs } from "node:fs"
+
+
+console.log('generating shot..')
+const response = await fetch("http://localhost:7860/shot", {
+  method: "POST",
+  headers: {
+    "Accept": "application/json",
+    "Content-Type": "application/json"
+  },
+  body: JSON.stringify({
+    token: process.env.VS_SECRET_ACCESS_TOKEN,
+    shotPrompt: "video of a dancing cat"
+  })
+});
+
+console.log('response:', response)
+const buffer = await (response as any).buffer()
+
+fs.writeFile(`./test-juju.mp4`, buffer)
+
+// if called from an API, we ùight want to use streams instead:
+// https://stackoverflow.com/questions/15713424/how-can-i-download-a-video-mp4-file-using-node-js