fix to nan patches in coloring of reliability diagram

local_app.py

@@ -98,11 +98,13 @@ def reliability_plot(results):
     # DEV: nicer would be to plot like a polygon
     # see: https://github.com/markus93/fit-on-the-test/blob/main/Experiments_Synthetic/binnings.py
 
-    def over_under_confidence(results):
+    def over_under_confidence(bins, patches):
         colors = []
-        for j, bin in enumerate(results["y_bar"]):
-            perfect = results["y_bar"][j]
-            empirical = results["p_bar"][j]
+        for j, bin in enumerate(bins):
+            perfect = bin
+            if j == len(patches):
+              j = len(patches) -1
+            empirical = patches[j].get_height()
 
             bin_color = (
                 "limegreen"
@@ -123,10 +125,10 @@ def reliability_plot(results):
         weights=np.nan_to_num(results["p_bar"][:-1], copy=True, nan=0),
         bins=bins_with_left_edge,
     )
-    colors = over_under_confidence(results)
+    colors = over_under_confidence(bins, patches)
     for b in range(len(B)):
         patches[b].set_facecolor(colors[b])  # color based on over/underconfidence
-
+    
     ax1handles = [
         mpatches.Patch(color="orangered", label="Overconfident"),
         mpatches.Patch(color="limegreen", label="Perfect", linestyle="dotted"),