Fix group parameters.

biome.json

@@ -25,6 +25,7 @@
         "useValidAnchor": "off",
         "useButtonType": "off",
         "noAutofocus": "off",
+        "noLabelWithoutControl": "off",
         "noNoninteractiveTabindex": "off"
       }
     }

lynxkite-app/web/src/workspace/nodes/NodeGroupParameter.tsx

@@ -1,5 +1,4 @@
-import { useEffect, useState } from "react";
-import NodeParameter from "./NodeParameter";
+import NodeParameter, { type UpdateOptions } from "./NodeParameter";
 
 interface SelectorType {
   name: string;
@@ -23,44 +22,27 @@ interface GroupsType {
 
 interface NodeGroupParameterProps {
   meta: { selector: SelectorType; groups: GroupsType };
-  value: any;
   data: any;
-  setParam: (name: string, value: any, options?: { delay: number }) => void;
-  deleteParam: (name: string, options?: { delay: number }) => void;
+  setParam: (name: string, value: any, options: UpdateOptions) => void;
 }
 
-export default function NodeGroupParameter({
-  meta,
-  value,
-  data,
-  setParam,
-  deleteParam,
-}: NodeGroupParameterProps) {
+export default function NodeGroupParameter({ meta, data, setParam }: NodeGroupParameterProps) {
   const selector = meta.selector;
-  const groups = meta.groups;
-  const [selectedValue, setSelectedValue] = useState<string>(value || selector.default);
-
-  const handleSelectorChange = (value: any, opts?: { delay: number }) => {
-    setSelectedValue(value);
-    setParam(selector.name, value, opts);
-  };
-
-  useEffect(() => {
-    // Clean possible previous parameters first
-    Object.values(groups).flatMap((group) => group.map((entry) => deleteParam(entry.name)));
-    for (const param of groups[selectedValue]) {
-      setParam(param.name, param.default);
-    }
-  }, [selectedValue]);
+  const selectorValue = data.params[selector.name] || selector.default;
+  const group = meta.groups[selectorValue] || [];
 
   return (
-    <NodeParameter
-      name={selector.name}
-      key={selector.name}
-      value={selectedValue}
-      data={data}
-      meta={selector}
-      onChange={handleSelectorChange}
-    />
+    <>
+      {group.map((meta: any) => (
+        <NodeParameter
+          name={meta.name}
+          key={meta.name}
+          value={data.params[meta.name] ?? meta.default}
+          data={data}
+          meta={meta}
+          setParam={setParam}
+        />
+      ))}
+    </>
   );
 }

lynxkite-app/web/src/workspace/nodes/NodeParameter.tsx

@@ -1,6 +1,7 @@
 import { useRef } from "react";
 // @ts-ignore
 import ArrowsHorizontal from "~icons/tabler/arrows-horizontal.jsx";
+import NodeGroupParameter from "./NodeGroupParameter";
 
 const BOOLEAN = "<class 'bool'>";
 const MODEL_TRAINING_INPUT_MAPPING =
@@ -189,77 +190,79 @@ interface NodeParameterProps {
   value: any;
   meta: any;
   data: any;
-  onChange: (value: any, options?: { delay: number }) => void;
+  setParam: (name: string, value: any, options: UpdateOptions) => void;
 }
 
-export default function NodeParameter({ name, value, meta, data, onChange }: NodeParameterProps) {
-  return (
-    // biome-ignore lint/a11y/noLabelWithoutControl: Most of the time there is a control.
+export type UpdateOptions = { delay?: number };
+
+export default function NodeParameter({ name, value, meta, data, setParam }: NodeParameterProps) {
+  function onChange(value: any, opts?: UpdateOptions) {
+    setParam(meta.name, value, opts || {});
+  }
+  return meta?.type?.format === "collapsed" ? (
+    <label className="param">
+      <ParamName name={name} />
+      <button className="collapsed-param">⋯</button>
+    </label>
+  ) : meta?.type?.format === "textarea" ? (
+    <label className="param">
+      <ParamName name={name} />
+      <textarea
+        className="textarea textarea-bordered w-full"
+        rows={6}
+        value={value}
+        onChange={(evt) => onChange(evt.currentTarget.value, { delay: 2 })}
+        onBlur={(evt) => onChange(evt.currentTarget.value, { delay: 0 })}
+      />
+    </label>
+  ) : meta?.type === "group" ? (
+    <NodeGroupParameter meta={meta} data={data} setParam={setParam} />
+  ) : meta?.type?.enum ? (
+    <label className="param">
+      <ParamName name={name} />
+      <select
+        className="select select-bordered w-full"
+        value={value || meta.type.enum[0]}
+        onChange={(evt) => onChange(evt.currentTarget.value)}
+      >
+        {meta.type.enum.map((option: string) => (
+          <option key={option} value={option}>
+            {option}
+          </option>
+        ))}
+      </select>
+    </label>
+  ) : meta?.type?.type === BOOLEAN ? (
+    <div className="form-control">
+      <label className="label cursor-pointer">
+        {name.replace(/_/g, " ")}
+        <input
+          className="checkbox"
+          type="checkbox"
+          checked={value}
+          onChange={(evt) => onChange(evt.currentTarget.checked)}
+        />
+      </label>
+    </div>
+  ) : meta?.type?.type === MODEL_TRAINING_INPUT_MAPPING ? (
+    <label className="param">
+      <ParamName name={name} />
+      <ModelMapping value={value} data={data} variant="training input" onChange={onChange} />
+    </label>
+  ) : meta?.type?.type === MODEL_INFERENCE_INPUT_MAPPING ? (
+    <label className="param">
+      <ParamName name={name} />
+      <ModelMapping value={value} data={data} variant="inference input" onChange={onChange} />
+    </label>
+  ) : meta?.type?.type === MODEL_OUTPUT_MAPPING ? (
+    <label className="param">
+      <ParamName name={name} />
+      <ModelMapping value={value} data={data} variant="output" onChange={onChange} />
+    </label>
+  ) : (
     <label className="param">
-      {meta?.type?.format === "collapsed" ? (
-        <>
-          <ParamName name={name} />
-          <button className="collapsed-param">⋯</button>
-        </>
-      ) : meta?.type?.format === "textarea" ? (
-        <>
-          <ParamName name={name} />
-          <textarea
-            className="textarea textarea-bordered w-full"
-            rows={6}
-            value={value}
-            onChange={(evt) => onChange(evt.currentTarget.value, { delay: 2 })}
-            onBlur={(evt) => onChange(evt.currentTarget.value, { delay: 0 })}
-          />
-        </>
-      ) : meta?.type?.enum ? (
-        <>
-          <ParamName name={name} />
-          <select
-            className="select select-bordered w-full"
-            value={value || meta.type.enum[0]}
-            onChange={(evt) => onChange(evt.currentTarget.value)}
-          >
-            {meta.type.enum.map((option: string) => (
-              <option key={option} value={option}>
-                {option}
-              </option>
-            ))}
-          </select>
-        </>
-      ) : meta?.type?.type === BOOLEAN ? (
-        <div className="form-control">
-          <label className="label cursor-pointer">
-            {name.replace(/_/g, " ")}
-            <input
-              className="checkbox"
-              type="checkbox"
-              checked={value}
-              onChange={(evt) => onChange(evt.currentTarget.checked)}
-            />
-          </label>
-        </div>
-      ) : meta?.type?.type === MODEL_TRAINING_INPUT_MAPPING ? (
-        <>
-          <ParamName name={name} />
-          <ModelMapping value={value} data={data} variant="training input" onChange={onChange} />
-        </>
-      ) : meta?.type?.type === MODEL_INFERENCE_INPUT_MAPPING ? (
-        <>
-          <ParamName name={name} />
-          <ModelMapping value={value} data={data} variant="inference input" onChange={onChange} />
-        </>
-      ) : meta?.type?.type === MODEL_OUTPUT_MAPPING ? (
-        <>
-          <ParamName name={name} />
-          <ModelMapping value={value} data={data} variant="output" onChange={onChange} />
-        </>
-      ) : (
-        <>
-          <ParamName name={name} />
-          <Input value={value} onChange={onChange} />
-        </>
-      )}
+      <ParamName name={name} />
+      <Input value={value} onChange={onChange} />
     </label>
   );
 }

lynxkite-app/web/src/workspace/nodes/NodeWithParams.tsx

@@ -3,10 +3,7 @@ import React from "react";
 // @ts-ignore
 import Triangle from "~icons/tabler/triangle-inverted-filled.jsx";
 import LynxKiteNode from "./LynxKiteNode";
-import NodeGroupParameter from "./NodeGroupParameter";
-import NodeParameter from "./NodeParameter";
-
-export type UpdateOptions = { delay?: number };
+import NodeParameter, { type UpdateOptions } from "./NodeParameter";
 
 export function NodeWithParams(props: any) {
   const reactFlow = useReactFlow();
@@ -21,16 +18,6 @@ export function NodeWithParams(props: any) {
     }));
   }
 
-  function deleteParam(name: string, opts: UpdateOptions) {
-    if (props.data.params[name] === undefined) {
-      return;
-    }
-    delete props.data.params[name];
-    reactFlow.updateNodeData(props.id, {
-      params: { ...props.data.params },
-      __execution_delay: opts.delay || 0,
-    });
-  }
   return (
     <>
       {props.collapsed && metaParams.length > 0 && (
@@ -39,31 +26,16 @@ export function NodeWithParams(props: any) {
         </div>
       )}
       {!collapsed &&
-        metaParams.map((meta: any) =>
-          meta.type === "group" ? (
-            <NodeGroupParameter
-              key={meta.name}
-              value={props.data.params[meta.name]}
-              data={props.data}
-              meta={meta}
-              setParam={(name: string, value: any, opts?: UpdateOptions) =>
-                setParam(name, value, opts || {})
-              }
-              deleteParam={(name: string, opts?: UpdateOptions) => deleteParam(name, opts || {})}
-            />
-          ) : (
-            <NodeParameter
-              name={meta.name}
-              key={meta.name}
-              value={props.data.params[meta.name]}
-              data={props.data}
-              meta={meta}
-              onChange={(value: any, opts?: UpdateOptions) =>
-                setParam(meta.name, value, opts || {})
-              }
-            />
-          ),
-        )}
+        metaParams.map((meta: any) => (
+          <NodeParameter
+            name={meta.name}
+            key={meta.name}
+            value={props.data.params[meta.name]}
+            data={props.data}
+            meta={meta}
+            setParam={setParam}
+          />
+        ))}
       {props.children}
     </>
   );

lynxkite-graph-analytics/src/lynxkite_graph_analytics/lynxkite_ops.py

@@ -60,17 +60,17 @@ def import_file(
         Bundle: Bundle with a single table with the contents of the file.
     """
     if file_format == "csv":
-        names = kwargs.pop("columns", "<from file>")
+        names = kwargs.get("columns", "<from file>")
         names = pd.api.extensions.no_default if names == "<from file>" else names.split(",")
-        sep = kwargs.pop("separator", "<auto>")
+        sep = kwargs.get("separator", "<auto>")
         sep = pd.api.extensions.no_default if sep == "<auto>" else sep
-        df = pd.read_csv(file_path, names=names, sep=sep, **kwargs)
+        df = pd.read_csv(file_path, names=names, sep=sep)
     elif file_format == "json":
-        df = pd.read_json(file_path, **kwargs)
+        df = pd.read_json(file_path)
     elif file_format == "parquet":
-        df = pd.read_parquet(file_path, **kwargs)
+        df = pd.read_parquet(file_path)
     elif file_format == "excel":
-        df = pd.read_excel(file_path, **kwargs)
+        df = pd.read_excel(file_path, sheet_name=kwargs.get("sheet_name", "Sheet1"))
     else:
         df = ValueError(f"Unsupported file format: {file_format}")
     return core.Bundle(dfs={table_name: df})