refactor(WorkflowUI): improve zip file handling with cross-platform support

- Replace system temp directory with application's TEMP_DIR for better compatibility
- Add automatic cleanup of old download files to prevent disk space issues
- Improve error handling for file permission operations
- Simplify documentation in code_generator.json by removing redundant instructions

app.py

@@ -1647,7 +1647,6 @@ class WorkflowUI:
         
         try:
             import zipfile
-            import tempfile
             import os
             import shutil
             from datetime import datetime
@@ -1659,14 +1658,27 @@ class WorkflowUI:
                 logger.warning(f"Output directory does not exist: {session_output_dir}")
                 return None
                 
-            # Create a properly named zip file in a temporary location that Gradio can access
+            # Create a properly named zip file in a location that Gradio can access
             timestamp = datetime.now().strftime("%Y%m%d_%H%M%S")
             zip_filename = f"processed_files_{self.session_id}_{timestamp}.zip"
             
-            # Use Python's tempfile to create a file in the system temp directory
-            # This ensures Gradio can access it properly
-            temp_dir = tempfile.gettempdir()
-            zip_path = Path(temp_dir) / zip_filename
+            # Use application's TEMP_DIR instead of system temp for cross-platform compatibility
+            # This ensures Gradio can access it properly across all systems
+            downloads_dir = Path(settings.TEMP_DIR) / "downloads"
+            downloads_dir.mkdir(parents=True, exist_ok=True)
+            
+            # Clean up old download files (older than 1 hour) to prevent disk space issues
+            try:
+                import time
+                current_time = time.time()
+                for old_file in downloads_dir.glob("*.zip"):
+                    if current_time - old_file.stat().st_mtime > 3600:  # 1 hour
+                        old_file.unlink()
+                        logger.debug(f"Cleaned up old download file: {old_file.name}")
+            except Exception as cleanup_error:
+                logger.warning(f"Could not clean up old download files: {cleanup_error}")
+            
+            zip_path = downloads_dir / zip_filename
                 
             with zipfile.ZipFile(zip_path, 'w', zipfile.ZIP_DEFLATED) as zipf:
                 # Add all files from output directory
@@ -1703,16 +1715,19 @@ class WorkflowUI:
             
             # Ensure the file exists and has content
             if zip_path.exists() and zip_path.stat().st_size > 0:
-                # For Gradio file downloads, we need to return the file path in a specific way
-                abs_path = str(zip_path.absolute())
+                # For cross-platform compatibility, use forward slashes and resolve path
+                abs_path = str(zip_path.resolve())
                 logger.info(f"Returning zip file path for download: {abs_path}")
                 logger.info(f"File size: {zip_path.stat().st_size} bytes")
                 
-                # Try to make the file accessible by setting proper permissions
-                os.chmod(abs_path, 0o644)
+                # Set proper permissions for cross-platform access
+                try:
+                    os.chmod(abs_path, 0o644)
+                except (OSError, PermissionError) as e:
+                    logger.warning(f"Could not set file permissions: {e}")
                 
                 # Return the file path for Gradio to handle
-                # Make sure to return the path in a way Gradio can process
+                # Use resolved absolute path for better cross-platform compatibility
                 return abs_path
             else:
                 logger.error("Zip file was created but is empty or doesn't exist")

instructions/agents/code_generator.json

@@ -17,16 +17,6 @@
     "SEVENTH, verify Excel file creation using list_files and file size validation.",
     "EIGHTH, report success only after confirming Excel file exists and is >10KB.",
     "",
-    "CRITICAL: Always start Python scripts with:",
-    "import os",
-    "os.chdir(os.path.dirname(os.path.abspath(__file__)) or '.')",
-    "This ensures the script runs in the correct directory regardless of OS.",
-    "",
-    "=== AVAILABLE TOOLS ===",
-    "- FileTools: read_file, save_file, list_files",
-    "- PythonTools: pip_install_package (ONLY for package installation)",
-    "- ShellTools: run_shell_command (PRIMARY execution tool)",
-    "",
     "=== EXCEL WORKBOOK REQUIREMENTS ===",
     "Create comprehensive worksheets based on JSON categories:",
     "📊 1. Executive Summary (key metrics, charts, highlights)",
@@ -69,104 +59,42 @@
     "• Financial ratios: Column charts",
     "• Cash flow: Waterfall charts (if possible)",
     "",
-    "=== PYTHON SCRIPT TEMPLATE ===",
-    "Your generate_excel_report.py MUST include:",
-    "```python",
-    "import os, json, datetime, logging",
-    "from openpyxl import Workbook",
-    "from openpyxl.styles import Font, PatternFill, Border, Alignment, NamedStyle",
-    "from openpyxl.chart import BarChart, LineChart, PieChart",
-    "",
-    "# CRITICAL: Set working directory first",
+    "CRITICAL: Always start Python scripts with:",
+    "import os",
     "os.chdir(os.path.dirname(os.path.abspath(__file__)) or '.')",
+    "This ensures the script runs in the correct directory regardless of OS.",
     "",
-    "# Setup logging",
-    "logging.basicConfig(level=logging.INFO)",
-    "logger = logging.getLogger(__name__)",
-    "",
-    "def load_financial_data():",
-    "    with open('arranged_financial_data.json', 'r') as f:",
-    "        return json.load(f)",
-    "",
-    "def create_professional_styles(wb):",
-    "    # Define all formatting styles",
-    "    pass",
-    "",
-    "def create_worksheets(wb, data):",
-    "    # Create all required worksheets",
-    "    pass",
-    "",
-    "def add_charts(wb, data):",
-    "    # Add appropriate charts",
-    "    pass",
-    "",
-    "def main():",
-    "    try:",
-    "        logger.info('Starting Excel report generation...')",
-    "        data = load_financial_data()",
-    "        wb = Workbook()",
-    "        create_professional_styles(wb)",
-    "        create_worksheets(wb, data)",
-    "        add_charts(wb, data)",
-    "        ",
-    "        # Save with timestamp",
-    "        timestamp = datetime.datetime.now().strftime('%Y%m%d_%H%M%S')",
-    "        filename = f'Financial_Report_{timestamp}.xlsx'",
-    "        wb.save(filename)",
-    "        logger.info(f'SUCCESS: Report saved as {filename}')",
-    "        return filename",
-    "    except Exception as e:",
-    "        logger.error(f'ERROR: {e}')",
-    "        raise",
-    "",
-    "if __name__ == '__main__':",
-    "    main()",
-    "```",
-    "",
-    "=== CROSS-PLATFORM EXECUTION ===",
-    "Try execution methods in this order:",
-    "1. run_shell_command('python generate_excel_report.py 2>&1')",
-    "2. If fails on Windows: run_shell_command('python.exe generate_excel_report.py 2>&1')",
-    "3. PowerShell alternative: run_shell_command('powershell -Command \"python generate_excel_report.py\" 2>&1')",
-    "",
-    "=== VERIFICATION COMMANDS ===",
-    "Linux/Mac:",
-    "• run_shell_command('ls -la *.xlsx')",
-    "• run_shell_command('file Financial_Report*.xlsx')",
-    "• run_shell_command('du -h *.xlsx')",
+    "Available Tools:",
+    "- FileTools: read_file, save_file, list_files",
+    "- PythonTools: pip_install_package (ONLY for package installation)",
+    "- ShellTools: run_shell_command (PRIMARY execution tool)",
     "",
-    "Windows/PowerShell:",
-    "• run_shell_command('dir *.xlsx')",
-    "• run_shell_command('powershell -Command \"Get-ChildItem *.xlsx\"')",
-    "• run_shell_command('powershell -Command \"(Get-Item *.xlsx).Length\"')",
+    "Cross-Platform Execution:",
+    "- Try: run_shell_command('python script.py 2>&1')",
+    "- If fails on Windows: run_shell_command('python.exe script.py 2>&1')",
+    "- PowerShell alternative: run_shell_command('powershell -Command \"python script.py\" 2>&1')",
     "",
-    "=== DEBUG COMMANDS ===",
-    "If issues occur:",
-    "• Current directory: run_shell_command('pwd') or run_shell_command('cd')",
-    "• Python location: run_shell_command('where python') or run_shell_command('which python')",
-    "• List files: run_shell_command('dir') or run_shell_command('ls')",
+    "Verification Commands (Linux/Mac):",
+    "- run_shell_command('ls -la *.xlsx')",
+    "- run_shell_command('file Financial_Report*.xlsx')",
+    "- run_shell_command('du -h *.xlsx')",
     "",
-    "=== PACKAGE INSTALLATION ===",
-    "• pip_install_package('openpyxl')",
-    "• Or via shell: run_shell_command('pip install openpyxl')",
-    "• Windows: run_shell_command('python -m pip install openpyxl')",
+    "Verification Commands (Windows/PowerShell):",
+    "- run_shell_command('dir *.xlsx')",
+    "- run_shell_command('powershell -Command \"Get-ChildItem *.xlsx\"')",
+    "- run_shell_command('powershell -Command \"(Get-Item *.xlsx).Length\"')",
     "",
-    "=== SUCCESS CRITERIA ===",
-    "✅ Excel file created with timestamp filename",
-    "✅ File size >5KB (indicates substantial content)",
-    "✅ All worksheets present and formatted professionally",
-    "✅ Charts and visualizations included",
-    "✅ No execution errors in logs",
-    "✅ Data accurately transferred from JSON to Excel",
+    "Debug Commands (Cross-Platform):",
+    "- Current directory: run_shell_command('pwd') or run_shell_command('cd')",
+    "- Python location: run_shell_command('where python') or run_shell_command('which python')",
+    "- List files: run_shell_command('dir') or run_shell_command('ls')",
     "",
-    "=== FAILURE IS NOT ACCEPTABLE ===",
-    "You MUST complete ALL steps. Do not stop until:",
-    "1. Excel file exists",
-    "2. File size is verified >5KB",
-    "3. No errors in execution logs",
-    "4. Success message is logged",
+    "Package Installation:",
+    "- pip_install_package('openpyxl')",
+    "- Or via shell: run_shell_command('pip install openpyxl')",
+    "- Windows: run_shell_command('python -m pip install openpyxl')",
     "",
-    "CRITICAL: Report detailed progress after each step. If any step fails, debug and retry until success."
+    "Success Criteria: Excel file exists, size >5KB, no errors in output."
   ],
   "agent_type": "code_generator",
   "description": "Excel report generator with mandatory completion and cross-platform shell execution",