Simplified summary page code

summary_page.py

@@ -1,6 +1,68 @@
 import matplotlib.pyplot as plt
 import pandas as pd
 
+# Layout parameters
+COLUMNS = 3
+
+# Derived constants
+COLUMN_WIDTH = 100 / COLUMNS  # Each column takes 25% of width
+BAR_WIDTH = COLUMN_WIDTH * 0.8  # 80% of column width for bars
+BAR_MARGIN = COLUMN_WIDTH * 0.1  # 10% margin on each side
+
+# Figure dimensions
+FIGURE_WIDTH = 20  # Wider to accommodate columns
+MAX_HEIGHT = 12  # Maximum height in inches
+MIN_HEIGHT_PER_ROW = 2.2
+FIGURE_PADDING = 2
+
+# Bar styling
+BAR_HEIGHT_RATIO = 0.22  # Bar height as ratio of vertical spacing
+VERTICAL_SPACING_RATIO = 0.2  # Base vertical position ratio
+AMD_BAR_OFFSET = 0.25  # AMD bar offset ratio
+NVIDIA_BAR_OFFSET = 0.54  # NVIDIA bar offset ratio
+
+# Colors
+COLORS = {
+    'passed': '#4CAF50',
+    'failed': '#E53E3E', 
+    'skipped': '#FFD54F',
+    'error': '#8B0000',
+    'empty': "#5B5B5B"
+}
+
+# Font styling
+MODEL_NAME_FONT_SIZE = 16
+LABEL_FONT_SIZE = 14
+LABEL_OFFSET = 1  # Distance of label from bar
+
+
+def draw_text_and_bar(
+    label: str,
+    stats: dict[str, int],
+    y_bar: float,
+    column_left_position: float,
+    bar_height: float,
+    ax: plt.Axes,
+) -> None:
+    """Draw a horizontal bar chart for given stats and its label on the left."""
+    # Text
+    label_x = column_left_position - LABEL_OFFSET 
+    ax.text(
+        label_x, y_bar, label, ha='right', va='center', color='#CCCCCC', fontsize=LABEL_FONT_SIZE, 
+        fontfamily='monospace', fontweight='normal'
+    )
+    # Bar
+    total = sum(stats.values())
+    if total > 0:            
+        left = column_left_position
+        for category in ['passed', 'failed', 'skipped', 'error']:
+            if stats[category] > 0:
+                width = stats[category] / total * BAR_WIDTH
+                ax.barh(y_bar, width, left=left, height=bar_height, color=COLORS[category], alpha=0.9)
+                left += width
+    else:
+        ax.barh(y_bar, BAR_WIDTH, left=column_left_position, height=bar_height, color=COLORS['empty'], alpha=0.9)
+
 def create_summary_page(df: pd.DataFrame, available_models: list[str]) -> plt.Figure:
     """Create a summary page with model names and both AMD/NVIDIA test stats bars."""
     if df.empty:
@@ -15,34 +77,18 @@ def create_summary_page(df: pd.DataFrame, available_models: list[str]) -> plt.Fi
     
     # Calculate dimensions for N-column layout
     model_count = len(available_models)
-    columns = 3
-    rows = (model_count + columns - 1) // columns  # Ceiling division
+    rows = (model_count + COLUMNS - 1) // COLUMNS  # Ceiling division
     
-    # Figure dimensions - wider for 4 columns, height based on rows
-    figure_width = 20  # Wider to accommodate 4 columns
-    max_height = 12  # Maximum height in inches
-    height_per_row = min(2.2, max_height / max(rows, 1))
-    figure_height = min(max_height, rows * height_per_row + 2)
+    # Figure dimensions - wider for columns, height based on rows
+    height_per_row = min(MIN_HEIGHT_PER_ROW, MAX_HEIGHT / max(rows, 1))
+    figure_height = min(MAX_HEIGHT, rows * height_per_row + FIGURE_PADDING)
     
-    fig, ax = plt.subplots(figsize=(figure_width, figure_height), facecolor='#000000')
+    fig, ax = plt.subplots(figsize=(FIGURE_WIDTH, figure_height), facecolor='#000000')
     ax.set_facecolor('#000000')
     
-    colors = {
-        'passed': '#4CAF50',
-        'failed': '#E53E3E', 
-        'skipped': '#FFD54F',
-        'error': '#8B0000',
-        'empty': "#5B5B5B"
-    }
-    
     visible_model_count = 0
     max_y = 0
     
-    # Column layout parameters
-    column_width = 100 / columns  # Each column takes 25% of width
-    bar_width = column_width * 0.8  # 80% of column width for bars
-    bar_margin = column_width * 0.1  # 10% margin on each side
-    
     for i, model_name in enumerate(available_models):
         if model_name not in df.index:
             continue
@@ -71,75 +117,34 @@ def create_summary_page(df: pd.DataFrame, available_models: list[str]) -> plt.Fi
             'skipped': 0,
             'error': 0
         }
-        
-        amd_total = sum(amd_stats.values())
-        nvidia_total = sum(nvidia_stats.values())
-        
-        if amd_total == 0 and nvidia_total == 0:
-            continue
             
         # Calculate position in 4-column grid
-        col = visible_model_count % columns
-        row = visible_model_count // columns
+        col = visible_model_count % COLUMNS
+        row = visible_model_count // COLUMNS
         
         # Calculate horizontal position for this column
-        col_left = col * column_width + bar_margin
-        col_center = col * column_width + column_width / 2
+        col_left = col * COLUMN_WIDTH + BAR_MARGIN
+        col_center = col * COLUMN_WIDTH + COLUMN_WIDTH / 2
         
         # Calculate vertical position for this row - start from top
         vertical_spacing = height_per_row
-        y_base = (0.2 + row) * vertical_spacing  # Start closer to top
+        y_base = (VERTICAL_SPACING_RATIO + row) * vertical_spacing
         y_model_name = y_base    # Model name above AMD bar
-        y_amd_bar = y_base + vertical_spacing * 0.25       # AMD bar
-        y_nvidia_bar = y_base + vertical_spacing * 0.54    # NVIDIA bar
+        y_amd_bar = y_base + vertical_spacing * AMD_BAR_OFFSET       # AMD bar
+        y_nvidia_bar = y_base + vertical_spacing * NVIDIA_BAR_OFFSET    # NVIDIA bar
         max_y = max(max_y, y_nvidia_bar + vertical_spacing * 0.3)
         
         # Model name centered above the bars in this column
         ax.text(col_center, y_model_name, model_name.lower(), 
                ha='center', va='center', color='#FFFFFF', 
-               fontsize=16, fontfamily='monospace', fontweight='bold')
+               fontsize=MODEL_NAME_FONT_SIZE, fontfamily='monospace', fontweight='bold')
         
         # AMD label and bar in this column
-        bar_height = min(0.4, vertical_spacing * 0.22)  # Adjust bar height based on spacing
-        label_x = col_left - 1  # Label position to the left of the bar
-        ax.text(label_x, y_amd_bar, "amd", ha='right', va='center', color='#CCCCCC', fontsize=14, fontfamily='monospace', fontweight='normal')
-        
-        if amd_total > 0:           
-            # AMD bar starts at column left position
-            left = col_left
-            for category in ['passed', 'failed', 'skipped', 'error']:
-                if amd_stats[category] > 0:
-                    width = amd_stats[category] / amd_total * bar_width
-                    ax.barh(y_amd_bar, width, left=left, height=bar_height, 
-                           color=colors[category], alpha=0.9)
-                    # if width > 2:  # Smaller threshold for text display
-                    #     ax.text(left + width/2, y_amd_bar, str(amd_stats[category]), 
-                    #            ha='center', va='center', color='black', 
-                    #            fontweight='bold', fontsize=10, fontfamily='monospace')
-                    left += width
-        else:
-            ax.barh(y_amd_bar, bar_width, left=col_left, height=bar_height, color=colors['empty'], alpha=0.9)
-            # ax.text(col_center, y_amd_bar, "No data", ha='center', va='center', color='black', fontweight='bold', fontsize=10, fontfamily='monospace')
-        
-        # NVIDIA label and bar in this column
-        ax.text(label_x, y_nvidia_bar, "nvidia", ha='right', va='center', color='#CCCCCC', fontsize=14, fontfamily='monospace', fontweight='normal')
-
-        if nvidia_total > 0:            
-            # NVIDIA bar starts at column left position
-            left = col_left
-            for category in ['passed', 'failed', 'skipped', 'error']:
-                if nvidia_stats[category] > 0:
-                    width = nvidia_stats[category] / nvidia_total * bar_width
-                    ax.barh(y_nvidia_bar, width, left=left, height=bar_height, 
-                           color=colors[category], alpha=0.9)
-                    # if width > 2:  # Smaller threshold for text display
-                    #     ax.text(left + width/2, y_nvidia_bar, str(nvidia_stats[category]), 
-                    #            ha='center', va='center', color='black', 
-                    #            fontweight='bold', fontsize=10, fontfamily='monospace')
-                    left += width
-        else:
-            ax.barh(y_nvidia_bar, bar_width, left=col_left, height=bar_height, color=colors['empty'], alpha=0.9)
-            # ax.text(col_center, y_nvidia_bar, "No data", ha='center', va='center', color='black', fontweight='bold', fontsize=10, fontfamily='monospace')
+        bar_height = min(0.4, vertical_spacing * BAR_HEIGHT_RATIO)
+        # Draw AMD bar
+        draw_text_and_bar("amd", amd_stats, y_amd_bar, col_left, bar_height, ax)
+        # Draw NVIDIA bar
+        draw_text_and_bar("nvidia", nvidia_stats, y_nvidia_bar, col_left, bar_height, ax)
         
         # Increment counter for next visible model
         visible_model_count += 1
@@ -158,7 +163,5 @@ def create_summary_page(df: pd.DataFrame, available_models: list[str]) -> plt.Fi
     ax.yaxis.set_inverted(True)
     
     # Remove all margins to make figure stick to top
-    plt.tight_layout()
-    plt.subplots_adjust(left=0.02, right=0.98, top=1.0, bottom=0.02)
-    
+    plt.tight_layout()    
     return fig