Fix model page for unfound data

app.py

@@ -35,21 +35,19 @@ def model_has_failures(model_name):
     # Check if model exists in DataFrame
     if model_name_lower not in Ci_results.df.index:
         return False
+    row = Ci_results.df.loc[model_name_lower]
     
-    try:
-        row = Ci_results.df.loc[model_name_lower]
-        
-        # Check for failures in both AMD and NVIDIA
-        amd_multi_failures = row.get('failed_multi_no_amd', 0) or 0
-        amd_single_failures = row.get('failed_single_no_amd', 0) or 0
-        nvidia_multi_failures = row.get('failed_multi_no_nvidia', 0) or 0
-        nvidia_single_failures = row.get('failed_single_no_nvidia', 0) or 0
-        
-        total_failures = amd_multi_failures + amd_single_failures + nvidia_multi_failures + nvidia_single_failures
-        return total_failures > 0
-        
-    except Exception:
-        return False
+    # Check for failures in both AMD and NVIDIA
+    amd_multi_failures = row.get('failed_multi_no_amd', 0)
+    amd_single_failures = row.get('failed_single_no_amd', 0)
+    nvidia_multi_failures = row.get('failed_multi_no_nvidia', 0)
+    nvidia_single_failures = row.get('failed_single_no_nvidia', 0)
+    return any([
+        amd_multi_failures > 0,
+        amd_single_failures > 0,
+        nvidia_multi_failures > 0,
+        nvidia_single_failures > 0,
+    ])
 
 
 # Function to get current description text
@@ -110,6 +108,7 @@ with gr.Blocks(title="Model Test Results Dashboard", css=load_css()) as demo:
                 for model_name in model_choices:
                     # Check if model has failures to determine styling
                     has_failures = model_has_failures(model_name)
+                    # print(f"{model_name = }, {has_failures = }")
                     button_classes = ["model-button"]
                     if has_failures:
                         button_classes.append("model-button-failed")

data.py

@@ -1,13 +1,13 @@
 from huggingface_hub import HfFileSystem
 import pandas as pd
 from utils import logger
-import os
 from datetime import datetime
 import threading
 import traceback
 import json
 
-fs = HfFileSystem(use_listings_cache=False)
+# NOTE: if caching is an issue, try adding `use_listings_cache=False`
+fs = HfFileSystem()
 
 IMPORTANT_MODELS = [
     "auto",
@@ -76,6 +76,10 @@ def get_distant_data() -> pd.DataFrame:
     # Fitler out all but important models
     important_models_lower = [model.lower() for model in IMPORTANT_MODELS]
     filtered_joined = joined[joined.index.str.lower().isin(important_models_lower)]
+    # Warn for ach missing important models
+    for model in IMPORTANT_MODELS:
+        if model not in filtered_joined.index:
+            print(f"[WARNING] Model {model} was missing from index.")            
     return filtered_joined
 
 

model_page.py

@@ -104,8 +104,10 @@ def plot_model_stats(df: pd.DataFrame, model_name: str) -> tuple[plt.Figure, str
         nvidia_filtered = {k: v for k, v in nvidia_stats.items() if v > 0}
 
         # Generate failure info directly from dataframe
-        failures_amd = dict(row.get('failures_amd', {}))
-        failures_nvidia = dict(row.get('failures_nvidia', {}))
+        failures_amd = row.get('failures_amd', None)
+        failures_amd = {} if (failures_amd is None or pd.isna(failures_amd)) else dict(failures_amd)
+        failures_nvidia = row.get('failures_nvidia')
+        failures_nvidia = {} if (failures_nvidia is None or pd.isna(failures_nvidia)) else dict(failures_nvidia)
 
     # failure_xxx = {"single": [test, ...], "multi": [...]}
     # test = {"line": test_name. "trace": error_msg}