issue_id
int64
2.04k
425k
title
stringlengths
9
251
body
stringlengths
4
32.8k
status
stringclasses
6 values
after_fix_sha
stringlengths
7
7
project_name
stringclasses
6 values
repo_url
stringclasses
6 values
repo_name
stringclasses
6 values
language
stringclasses
1 value
issue_url
null
before_fix_sha
null
pull_url
null
commit_datetime
timestamp[us, tz=UTC]
report_datetime
timestamp[us, tz=UTC]
updated_file
stringlengths
23
187
chunk_content
stringlengths
1
22k
5,264
Bug 5264 Class detail filtering options in packages view.
Build 20011018. The new build allows the user to expand classes in the packages view and look at their contents. (methods and fields) It would be nice to be able to filter out this view so it didn't show you the field if you didn't want it to. (e.g. have the same options as you do in the Outline view for a Java file)
resolved fixed
425b5aa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T11:01:14Z
2001-10-25T22:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/MethodsViewerFilter.java
public static final int FILTER_NONPUBLIC= 1; public static final int FILTER_STATIC= 2; public static final int FILTER_FIELDS= 4; private int fFilterProperties; /** * Modifies filter and add a property to filter for */ public final void addFilter(int filter) { fFilterProperties |= filter; } /** * Modifies filter and remove a property to filter for */ public final void removeFilter(int filter) { fFilterProperties &= (-1 ^ filter); } /** * Tests if a property is filtered */ public final boolean hasFilter(int filter) { return (fFilterProperties & filter) != 0; } /* * @see ViewerFilter@isFilterProperty
5,264
Bug 5264 Class detail filtering options in packages view.
Build 20011018. The new build allows the user to expand classes in the packages view and look at their contents. (methods and fields) It would be nice to be able to filter out this view so it didn't show you the field if you didn't want it to. (e.g. have the same options as you do in the Outline view for a Java file)
resolved fixed
425b5aa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T11:01:14Z
2001-10-25T22:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/MethodsViewerFilter.java
*/ public boolean isFilterProperty(Object element, Object property) { return false; } /* * @see ViewerFilter@select */ public boolean select(Viewer viewer, Object parentElement, Object element) { try { if (element instanceof IField && hasFilter(FILTER_FIELDS)) { return false; } if (element instanceof IMember) { IMember member= (IMember)element; int flags= member.getFlags(); if (Flags.isStatic(flags) && (hasFilter(FILTER_STATIC) || "<clinit>".equals(member.getElementName()))) { return false; } if (!Flags.isPublic(flags) && !member.getDeclaringType().isInterface()) { return !hasFilter(FILTER_NONPUBLIC); } return true; } } catch (JavaModelException e) { } return false; } }
4,367
Bug 4367 Argument hover doesn't work for nested method calls
- enter the following code public class A { public int foo(int x, int y) { return 1; } public void bar() { } } - now enter public void bar() { foo<= code assist } - select foo(int x, int y) - observe: argument hover is correct - now type foo again - open code assist - select foo(...) - type 10, 10 and cursor left - argument hover disappears although outer method call isn't finihed yet.
resolved fixed
3a027c9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T11:07:22Z
2001-10-11T11:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/JavaCompletionProposal.java
package org.eclipse.jdt.internal.ui.text.java; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import org.eclipse.jface.util.Assert; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.graphics.Point; import org.eclipse.core.runtime.CoreException; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IImportContainer; import org.eclipse.jdt.core.IImportDeclaration; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.ISourceRange; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.corext.codemanipulation.ImportsStructure; import org.eclipse.jdt.internal.ui.preferences.ImportOrganizePreferencePage; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jface.text.BadLocationException; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.contentassist.ICompletionProposal; import org.eclipse.jface.text.contentassist.ICompletionProposalExtension; import org.eclipse.jface.text.contentassist.IContextInformation; public class JavaCompletionProposal implements ICompletionProposal, ICompletionProposalExtension { private String fDisplayString; private String fReplacementString; private int fReplacementOffset;
4,367
Bug 4367 Argument hover doesn't work for nested method calls
- enter the following code public class A { public int foo(int x, int y) { return 1; } public void bar() { } } - now enter public void bar() { foo<= code assist } - select foo(int x, int y) - observe: argument hover is correct - now type foo again - open code assist - select foo(...) - type 10, 10 and cursor left - argument hover disappears although outer method call isn't finihed yet.
resolved fixed
3a027c9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T11:07:22Z
2001-10-11T11:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/JavaCompletionProposal.java
private int fReplacementLength; private int fCursorPosition; private Image fImage; private IContextInformation fContextInformation; private int fContextInformationPosition; private ProposalInfo fProposalInfo; private IImportDeclaration fImportDeclaration; private char[] fTriggerCharacters; /** * Creates a new completion proposal. All fields are initialized based on the provided information. * * @param replacementString the actual string to be inserted into the document * @param replacementOffset the offset of the text to be replaced * @param replacementLength the length of the text to be replaced * @param image the image to display for this proposal * @param displayString the string to be displayed for the proposal * If set to <code>null</code>, the replacement string will be taken as display string. */ public JavaCompletionProposal(String replacementString, int replacementOffset, int replacementLength, Image image, String displayString) { Assert.isNotNull(replacementString); Assert.isTrue(replacementOffset >= 0); Assert.isTrue(replacementLength >= 0); fReplacementString= replacementString; fReplacementOffset= replacementOffset; fReplacementLength= replacementLength; fImage= image; fDisplayString= displayString != null ? displayString : replacementString; fCursorPosition= replacementString.length();
4,367
Bug 4367 Argument hover doesn't work for nested method calls
- enter the following code public class A { public int foo(int x, int y) { return 1; } public void bar() { } } - now enter public void bar() { foo<= code assist } - select foo(int x, int y) - observe: argument hover is correct - now type foo again - open code assist - select foo(...) - type 10, 10 and cursor left - argument hover disappears although outer method call isn't finihed yet.
resolved fixed
3a027c9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T11:07:22Z
2001-10-11T11:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/JavaCompletionProposal.java
fContextInformation= null; fContextInformationPosition= -1; fImportDeclaration= null; fTriggerCharacters= null; fProposalInfo= null; } /** * Sets the context information. * @param contentInformation The context information associated with this proposal */ public void setContextInformation(IContextInformation contextInformation) { fContextInformation= contextInformation; fContextInformationPosition= (fContextInformation != null ? fCursorPosition : -1); } /** * Sets the import declaration to import when applied. * @param importDeclaration Optional import declaration to be added. Can be <code>null</code>. The underlying compilation unit * is assumed to be compatible with the document passed in <code>apply</code>. */ public void setImportDeclaration(IImportDeclaration importDeclaration) { fImportDeclaration= importDeclaration; } /** * Sets the trigger characters. * @param triggerCharacters The set of characters which can trigger the application of this completion proposal */ public void setTriggerCharacters(char[] triggerCharacters) {
4,367
Bug 4367 Argument hover doesn't work for nested method calls
- enter the following code public class A { public int foo(int x, int y) { return 1; } public void bar() { } } - now enter public void bar() { foo<= code assist } - select foo(int x, int y) - observe: argument hover is correct - now type foo again - open code assist - select foo(...) - type 10, 10 and cursor left - argument hover disappears although outer method call isn't finihed yet.
resolved fixed
3a027c9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T11:07:22Z
2001-10-11T11:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/JavaCompletionProposal.java
fTriggerCharacters= triggerCharacters; } /** * Sets the proposal info. * @param additionalProposalInfo The additional information associated with this proposal or <code>null</code> */ public void setProposalInfo(ProposalInfo proposalInfo) { fProposalInfo= proposalInfo; } /** * Sets the cursor position relative to the insertion offset. By default this is the length of the completion string * (Cursor positioned after the completion) * @param cursorPosition The cursorPosition to set */ public void setCursorPosition(int cursorPosition) { Assert.isTrue(cursorPosition >= 0); fCursorPosition= cursorPosition; } protected void applyImports(IDocument document) { if (fImportDeclaration == null) { return; } ICompilationUnit cu= (ICompilationUnit) JavaModelUtil.findElementOfKind(fImportDeclaration, IJavaElement.COMPILATION_UNIT); if (cu != null) { try { IType[] types= cu.getTypes();
4,367
Bug 4367 Argument hover doesn't work for nested method calls
- enter the following code public class A { public int foo(int x, int y) { return 1; } public void bar() { } } - now enter public void bar() { foo<= code assist } - select foo(int x, int y) - observe: argument hover is correct - now type foo again - open code assist - select foo(...) - type 10, 10 and cursor left - argument hover disappears although outer method call isn't finihed yet.
resolved fixed
3a027c9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T11:07:22Z
2001-10-11T11:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/JavaCompletionProposal.java
if (types.length == 0 || types[0].getSourceRange().getOffset() > fReplacementOffset) { return; } String[] prefOrder= ImportOrganizePreferencePage.getImportOrderPreference(); int threshold= ImportOrganizePreferencePage.getImportNumberThreshold(); ImportsStructure impStructure= new ImportsStructure(cu, prefOrder, threshold, true); impStructure.addImport(fImportDeclaration.getElementName()); impStructure.create(false, null); } catch (CoreException e) { JavaPlugin.log(e); } } } /* * @see ICompletionProposalExtension#apply(IDocument, char) */ public void apply(IDocument document, char trigger) { try { if (trigger == (char) 0) { document.replace(fReplacementOffset, fReplacementLength, fReplacementString); } else { StringBuffer buffer= new StringBuffer(fReplacementString); if ((fReplacementLength < buffer.length() && buffer.charAt(fReplacementLength) != trigger)) { buffer.insert(fCursorPosition, trigger); ++fCursorPosition;
4,367
Bug 4367 Argument hover doesn't work for nested method calls
- enter the following code public class A { public int foo(int x, int y) { return 1; } public void bar() { } } - now enter public void bar() { foo<= code assist } - select foo(int x, int y) - observe: argument hover is correct - now type foo again - open code assist - select foo(...) - type 10, 10 and cursor left - argument hover disappears although outer method call isn't finihed yet.
resolved fixed
3a027c9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T11:07:22Z
2001-10-11T11:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/JavaCompletionProposal.java
} document.replace(fReplacementOffset, fReplacementLength, buffer.toString()); } int oldLen= document.getLength(); applyImports(document); fReplacementOffset += document.getLength() - oldLen; } catch (BadLocationException x) { } } /* * @see ICompletionProposal#apply */ public void apply(IDocument document) { apply(document, (char) 0); } /* * @see ICompletionProposal#getSelection */ public Point getSelection(IDocument document) { return new Point(fReplacementOffset + fCursorPosition, 0); } /* * @see ICompletionProposal#getContextInformation() */
4,367
Bug 4367 Argument hover doesn't work for nested method calls
- enter the following code public class A { public int foo(int x, int y) { return 1; } public void bar() { } } - now enter public void bar() { foo<= code assist } - select foo(int x, int y) - observe: argument hover is correct - now type foo again - open code assist - select foo(...) - type 10, 10 and cursor left - argument hover disappears although outer method call isn't finihed yet.
resolved fixed
3a027c9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T11:07:22Z
2001-10-11T11:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/JavaCompletionProposal.java
public IContextInformation getContextInformation() { return fContextInformation; } /* * @see ICompletionProposal#getImage() */ public Image getImage() { return fImage; } /* * @see ICompletionProposal#getDisplayString() */ public String getDisplayString() { return fDisplayString; } /* * @see ICompletionProposal#getAdditionalProposalInfo() */ public String getAdditionalProposalInfo() { if (fProposalInfo != null) { return fProposalInfo.getInfo(); } return null; } /* * @see ICompletionProposalExtension#getTriggerCharacters() */ public char[] getTriggerCharacters() { return fTriggerCharacters;
4,367
Bug 4367 Argument hover doesn't work for nested method calls
- enter the following code public class A { public int foo(int x, int y) { return 1; } public void bar() { } } - now enter public void bar() { foo<= code assist } - select foo(int x, int y) - observe: argument hover is correct - now type foo again - open code assist - select foo(...) - type 10, 10 and cursor left - argument hover disappears although outer method call isn't finihed yet.
resolved fixed
3a027c9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T11:07:22Z
2001-10-11T11:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/JavaCompletionProposal.java
} /* * @see ICompletionProposalExtension#getContextInformationPosition() */ public int getContextInformationPosition() { return fReplacementOffset + fContextInformationPosition; } /** * Gets the replacement offset. * @return Returns a int */ public int getReplacementOffset() { return fReplacementOffset; } /** * Sets the replacement offset. * @param replacementOffset The replacement offset to set */ public void setReplacementOffset(int replacementOffset) { Assert.isTrue(replacementOffset >= 0); fReplacementOffset= replacementOffset; } /** * Gets the replacement length. * @return Returns a int */ public int getReplacementLength() { return fReplacementLength; }
4,367
Bug 4367 Argument hover doesn't work for nested method calls
- enter the following code public class A { public int foo(int x, int y) { return 1; } public void bar() { } } - now enter public void bar() { foo<= code assist } - select foo(int x, int y) - observe: argument hover is correct - now type foo again - open code assist - select foo(...) - type 10, 10 and cursor left - argument hover disappears although outer method call isn't finihed yet.
resolved fixed
3a027c9
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T11:07:22Z
2001-10-11T11:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/JavaCompletionProposal.java
/** * Sets the replacement length. * @param replacementLength The replacementLength to set */ public void setReplacementLength(int replacementLength) { Assert.isTrue(replacementLength >= 0); fReplacementLength= replacementLength; } /** * Gets the replacement string. * @return Returns a String */ public String getReplacementString() { return fReplacementString; } /** * Sets the replacement string. * @param replacementString The replacement string to set */ public void setReplacementString(String replacementString) { fReplacementString= replacementString; } /** * Sets the image. * @param image The image to set */ public void setImage(Image image) { fImage= image; } }
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/IJavaHelpContextIds.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui; import org.eclipse.jdt.ui.JavaUI; /** * Help context ids for the Java UI. * <p> * This interface contains constants only; it is not intended to be implemented * or extended. * </p> * */ public interface IJavaHelpContextIds { public static final String PREFIX= JavaUI.ID_PLUGIN + '.'; public static final String GETTERSETTER_ACTION= PREFIX + "getter_setter_action_context"; public static final String ADD_METHODBREAKPOINT_ACTION= PREFIX + "add_methodbreakpoint_action_context";
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/IJavaHelpContextIds.java
public static final String ADD_WATCHPOINT_ACTION= PREFIX + "add_watchpoint_action_context"; public static final String ADD_METHODSTUB_ACTION= PREFIX + "add_methodstub_action_context"; public static final String ADD_UNIMPLEMENTED_METHODS_ACTION= PREFIX + "add_unimplemented_methods_action_context"; public static final String ADD_UNIMPLEMENTED_CONSTRUCTORS_ACTION= PREFIX + "add_unimplemented_constructors_action_context"; public static final String SHOW_IN_PACKAGEVIEW_ACTION= PREFIX + "show_in_packageview_action_context"; public static final String SHOW_IN_HIERARCHYVIEW_ACTION= PREFIX + "show_in_hierarchyview_action_context"; public static final String FOCUS_ON_SELECTION_ACTION= PREFIX + "focus_on_selection_action"; public static final String FOCUS_ON_TYPE_ACTION= PREFIX + "focus_on_type_action"; public static final String TYPEHIERARCHY_HISTORY_ACTION= PREFIX + "typehierarchy_history_action"; public static final String FILTER_PUBLIC_ACTION= PREFIX + "filter_public_action"; public static final String FILTER_FIELDS_ACTION= PREFIX + "filter_fields_action"; public static final String FILTER_STATIC_ACTION= PREFIX + "filter_static_action"; public static final String SHOW_INHERITED_ACTION= PREFIX + "show_inherited_action"; public static final String SHOW_SUPERTYPES= PREFIX + "show_supertypes_action"; public static final String SHOW_SUBTYPES= PREFIX + "show_subtypes_action"; public static final String SHOW_HIERARCHY= PREFIX + "show_hierarchy_action"; public static final String ENABLE_METHODFILTER_ACTION= PREFIX + "enable_methodfilter_action"; public static final String ADD_IMPORT_ON_SELECTION_ACTION= PREFIX + "add_imports_on_selection_action_context"; public static final String ORGANIZE_IMPORTS_ACTION= PREFIX + "organize_imports_action_context"; public static final String RUN_TO_LINE_ACTION= PREFIX + "run_to_line_action_context"; public static final String TOGGLE_PRESENTATION_ACTION= PREFIX + "toggle_presentation_action_context"; public static final String TOGGLE_TEXTHOVER_ACTION= PREFIX + "toggle_texthover_action_context"; public static final String MAINTYPE_SELECTION_DIALOG= PREFIX + "maintype_selection_dialog_context"; public static final String OPEN_TYPE_DIALOG= PREFIX + "open_type_dialog_context"; public static final String EDIT_JRE_DIALOG= PREFIX + "edit_jre_dialog_context"; public static final String SOURCE_ATTACHMENT_DIALOG= PREFIX + "source_attachment_dialog_context"; public static final String VARIABLE_SELECTION_DIALOG= PREFIX + "variable_selection_dialog_context"; public static final String VARIABLE_CREATION_DIALOG= PREFIX + "variable_creation_dialog_context"; public static final String JAVA_SEARCH_PAGE= PREFIX + "java_search_page_context";
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/IJavaHelpContextIds.java
public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String BUILD_PATH_PROPERTY_PAGE= PREFIX + "build_path_property_page_context"; public static final String CP_VARIABLES_PREFERENCE_PAGE= PREFIX + "cp_variables_preference_page_context"; public static final String CODEFORMATTER_PREFERENCE_PAGE= PREFIX + "codeformatter_preference_page_context"; public static final String SOURCE_ATTACHMENT_PROPERTY_PAGE= PREFIX + "source_attachment_property_page_context"; public static final String SOURCE_LOOKUP_PROPERTY_PAGE= PREFIX + "source_lookup_property_page_context"; public static final String CODE_MANIPULATION_PREFERENCE_PAGE= PREFIX + "code_manipulation_preference_context"; public static final String ORGANIZE_IMPORTS_PREFERENCE_PAGE= PREFIX + "organizeimports_preference_page_context"; public static final String JAVA_BASE_PREFERENCE_PAGE= PREFIX + "java_base_preference_page_context"; public static final String REFACTORING_PREFERENCE_PAGE= PREFIX + "refactoring_preference_page_context"; public static final String JAVA_EDITOR_PREFERENCE_PAGE= PREFIX + "java_editor_preference_page_context"; public static final String COMPILER_PREFERENCE_PAGE= PREFIX + "compiler_preference_page_context"; public static final String TEMPLATE_PREFERENCE_PAGE= PREFIX + "template_preference_page_context"; public static final String WORK_IN_PROGRESS_PREFERENCE_PAGE= PREFIX + "work_in_progress_preference_page_context"; public static final String NEW_JAVAPROJECT_WIZARD_PAGE= PREFIX + "new_javaproject_wizard_page_context"; public static final String NEW_SNIPPET_WIZARD_PAGE= PREFIX + "new_snippet_wizard_page_context"; public static final String NEW_PACKAGE_WIZARD_PAGE= PREFIX + "new_package_wizard_page_context"; public static final String NEW_CLASS_WIZARD_PAGE= PREFIX + "new_class_wizard_page_context"; public static final String NEW_INTERFACE_WIZARD_PAGE= PREFIX + "new_interface_wizard_page_context"; public static final String NEW_PACKAGEROOT_WIZARD_PAGE= PREFIX + "new_packageroot_wizard_page_context"; public static final String JARPACKAGER_WIZARD_PAGE= PREFIX + "jar_packager_wizard_page_context"; public static final String JARMANIFEST_WIZARD_PAGE= PREFIX + "jar_manifest_wizard_page_context"; public static final String JAROPTIONS_WIZARD_PAGE= PREFIX + "jar_options_wizard_page_context"; public static final String REFACTORING_PREVIEW_WIZARD_PAGE= PREFIX + "refactoring_preview_wizard_page_context";
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/IJavaHelpContextIds.java
public static final String MOVE_CU_WIZARD_PAGE= PREFIX + "move_cu_wizard_page_context"; public static final String MOVE_CU_ERROR_WIZARD_PAGE= PREFIX + "move_cu_error_wizard_page_context"; public static final String RENAME_PARAMS_WIZARD_PAGE= PREFIX + "rename_params_wizard_page"; public static final String RENAME_PARAMS_ERROR_WIZARD_PAGE= PREFIX + "rename_params_error_wizard_page"; public static final String EXTRACT_METHOD_WIZARD_PAGE= PREFIX + "extract_method_wizard_page_context"; public static final String EXTRACT_METHOD_ERROR_WIZARD_PAGE= PREFIX + "extract_method_error_wizard_page_context"; public static final String RENAME_PACKAGE_WIZARD_PAGE= PREFIX + "rename_package_wizard_page_context"; public static final String RENAME_PACKAGE_ERROR_WIZARD_PAGE= PREFIX + "rename_package_error_wizard_page_context"; public static final String RENAME_SRCFLDR_WIZARD_PAGE= PREFIX + "rename_source_folder_wizard_page_context"; public static final String RENAME_SRCFLDR_ERROR_WIZARD_PAGE= PREFIX + "rename_source_folder_error_wizard_page_context"; public static final String RENAME_JPRJ_WIZARD_PAGE= PREFIX + "rename_java_project_wizard_page_context"; public static final String RENAME_JPRJ_ERROR_WIZARD_PAGE= PREFIX + "rename_java_project_error_wizard_page_context"; public static final String RENAME_RESOURCE_WIZARD_PAGE= PREFIX + "rename_resource_wizard_page_context"; public static final String RENAME_RESOURCE_ERROR_WIZARD_PAGE= PREFIX + "rename_resource_error_wizard_page_context"; public static final String RENAME_TEMP_WIZARD_PAGE= PREFIX + "rename_local_variable_wizard_page_context"; public static final String RENAME_TEMP_ERROR_WIZARD_PAGE= PREFIX + "rename_local_variable_error_wizard_page_context"; public static final String RENAME_CU_WIZARD_PAGE= PREFIX + "rename_cu_wizard_page_context"; public static final String RENAME_CU_ERROR_WIZARD_PAGE= PREFIX + "rename_cu_error_wizard_page_context"; public static final String RENAME_METHOD_WIZARD_PAGE= PREFIX + "rename_method_wizard_page_context"; public static final String RENAME_METHOD_ERROR_WIZARD_PAGE= PREFIX + "rename_method_error_wizard_page_context"; public static final String RENAME_TYPE_WIZARD_PAGE= PREFIX + "rename_type_wizard_page_context"; public static final String RENAME_TYPE_ERROR_WIZARD_PAGE= PREFIX + "rename_type_error_wizard_page_context"; public static final String RENAME_FIELD_WIZARD_PAGE= PREFIX + "rename_field_wizard_page_context"; public static final String RENAME_FIELD_ERROR_WIZARD_PAGE= PREFIX + "rename_field_error_wizard_page_context"; public static final String SEF_WIZARD_PAGE= PREFIX + "self_encapsulate_field_wizard_page_context"; public static final String BUILD_PATH_BLOCK= PREFIX + "build_paths_context"; public static final String SOURCE_ATTACHMENT_BLOCK= PREFIX + "source_attachment_context"; }
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor.java
package org.eclipse.jdt.internal.ui.javaeditor; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IResource; import org.eclipse.core.runtime.CoreException; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jface.action.IMenuManager; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IEditorSite; import org.eclipse.ui.IFileEditorInput; import org.eclipse.ui.IMemento; import org.eclipse.ui.PartInitException; import org.eclipse.ui.texteditor.ITextEditorActionConstants; /** * Java specific text editor. */ public class ClassFileEditor extends JavaEditor {
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor.java
/** * Default constructor. */ public ClassFileEditor() { super(); setDocumentProvider(JavaPlugin.getDefault().getClassFileDocumentProvider()); setEditorContextMenuId("#ClassFileEditorContext"); setRulerContextMenuId("#ClassFileRulerContext"); setOutlinerContextMenuId("#ClassFileOutlinerContext"); } /** * @see AbstractTextEditor#createActions() */ protected void createActions() { super.createActions(); setAction(ITextEditorActionConstants.SAVE, null); setAction(ITextEditorActionConstants.REVERT_TO_SAVED, null); setAction("ManageBreakpoints", new BreakpointRulerAction(getVerticalRuler(), this)); /* * 1GF82PL: ITPJUI:ALL - Need to be able to add bookmark to classfile * * // replace default action with class file specific ones * * setAction(ITextEditorActionConstants.BOOKMARK, new AddClassFileMarkerAction("AddBookmark.", this, IMarker.BOOKMARK, true)); * setAction(ITextEditorActionConstants.ADD_TASK, new AddClassFileMarkerAction("AddTask.", this, IMarker.TASK, false));
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor.java
* setAction(ITextEditorActionConstants.RULER_MANAGE_BOOKMARKS, new ClassFileMarkerRulerAction("ManageBookmarks.", getVerticalRuler(), this, IMarker.BOOKMARK, true)); * setAction(ITextEditorActionConstants.RULER_MANAGE_TASKS, new ClassFileMarkerRulerAction("ManageTasks.", getVerticalRuler(), this, IMarker.TASK, true)); */ setAction(ITextEditorActionConstants.BOOKMARK, null); setAction(ITextEditorActionConstants.ADD_TASK, null); setAction(ITextEditorActionConstants.RULER_MANAGE_BOOKMARKS, null); setAction(ITextEditorActionConstants.RULER_MANAGE_TASKS, null); setAction(ITextEditorActionConstants.RULER_DOUBLE_CLICK, getAction("ManageBreakpoints")); } /** * @see JavaEditor#getElementAt(int) */ protected IJavaElement getElementAt(int offset) { if (getEditorInput() instanceof IClassFileEditorInput) { try { IClassFileEditorInput input= (IClassFileEditorInput) getEditorInput(); return input.getClassFile().getElementAt(offset); } catch (JavaModelException x) { } } return null; } /** * @see JavaEditor#getCorrespondingElement(IJavaElement) */ protected IJavaElement getCorrespondingElement(IJavaElement element) { if (getEditorInput() instanceof IClassFileEditorInput) {
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor.java
IClassFileEditorInput input= (IClassFileEditorInput) getEditorInput(); IJavaElement parent= JavaModelUtil.findParentOfKind(element, IJavaElement.CLASS_FILE); if (input.getClassFile() == parent) return element; } return null; } /** * @see EditorPart#init(IEditorSite, IEditorInput) */ public void init(IEditorSite site, IEditorInput input) throws PartInitException { if (input instanceof IFileEditorInput) { IFile file= ((IFileEditorInput) input).getFile(); IClassFileEditorInput classFileInput= new ExternalClassFileEditorInput(file); if (classFileInput.getClassFile() != null) input= classFileInput; } if (!(input instanceof IClassFileEditorInput)) throw new PartInitException(JavaEditorMessages.getString("ClassFileEditor.error.invalid_input_message")); super.init(site, input); } /** * @see IEditorPart#saveState(IMemento) */ public void saveState(IMemento memento) {
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor.java
} /** * @see AbstractTextEditor#rulerContextMenuAboutToShow(IMenuManager) */ protected void rulerContextMenuAboutToShow(IMenuManager menu) { super.rulerContextMenuAboutToShow(menu); if (getEditorInput() instanceof IClassFileEditorInput) { IClassFileEditorInput input= (IClassFileEditorInput) getEditorInput(); IClassFile file= input.getClassFile(); try { if (file.getSource() != null) addAction(menu, "ManageBreakpoints"); } catch (JavaModelException x) { } } } /** * @see JavaEditor#setOutlinePageInput(JavaOutlinePage, IEditorInput) */ protected void setOutlinePageInput(JavaOutlinePage page, IEditorInput input) { if (page != null && input instanceof IClassFileEditorInput) { IClassFileEditorInput cfi= (IClassFileEditorInput) input; page.setInput(cfi.getClassFile()); }
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/ClassFileEditor.java
} /* * 1GEPKT5: ITPJUI:Linux - Source in editor for external classes is editable * Removed methods isSaveOnClosedNeeded and isDirty. * Added method isEditable. */ /** * @see AbstractTextEditor#isEditable() */ public boolean isEditable() { return false; } /** * @see AbstractTextEditor#doSetInput(IEditorInput) */ protected void doSetInput(IEditorInput input) throws CoreException { if (input instanceof ExternalClassFileEditorInput) { ExternalClassFileEditorInput classFileInput= (ExternalClassFileEditorInput) input; IFile file= classFileInput.getFile(); try { file.refreshLocal(IResource.DEPTH_INFINITE, null); } catch (CoreException x) { JavaPlugin.log(x); } } super.doSetInput(input); } }
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
package org.eclipse.jdt.internal.ui.javaeditor; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.lang.reflect.InvocationTargetException; import java.util.Iterator; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IFolder; import org.eclipse.core.resources.IMarker; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.core.resources.ResourcesPlugin; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.Path; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.compare.JavaAddElementFromHistory; import org.eclipse.jdt.internal.ui.compare.JavaReplaceWithEditionAction; import org.eclipse.jdt.internal.ui.dialogs.AbstractElementListSelectionDialog; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor.BracketHighlighter.BracketPositionManager;
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor.BracketHighlighter.HighlightBrackets; import org.eclipse.jdt.internal.ui.reorg.DeleteAction; import org.eclipse.jdt.internal.ui.text.ContentAssistPreference; import org.eclipse.jdt.internal.ui.text.JavaPairMatcher; import org.eclipse.jdt.ui.IContextMenuConstants; import org.eclipse.jdt.ui.IWorkingCopyManager; import org.eclipse.jdt.ui.text.JavaTextTools; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.dialogs.Dialog; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.dialogs.ProgressMonitorDialog; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.jface.preference.PreferenceConverter; import org.eclipse.jface.text.BadLocationException; import org.eclipse.jface.text.BadPositionCategoryException; import org.eclipse.jface.text.DefaultPositionUpdater; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.IPositionUpdater; import org.eclipse.jface.text.IRegion; import org.eclipse.jface.text.ITextInputListener; import org.eclipse.jface.text.ITextListener; import org.eclipse.jface.text.ITextOperationTarget; import org.eclipse.jface.text.ITextSelection; import org.eclipse.jface.text.Position; import org.eclipse.jface.text.TextEvent; import org.eclipse.jface.text.contentassist.ContentAssistant; import org.eclipse.jface.text.contentassist.IContentAssistant; import org.eclipse.jface.text.source.Annotation; import org.eclipse.jface.text.source.IAnnotationModel;
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
import org.eclipse.jface.text.source.ISourceViewer; import org.eclipse.jface.text.source.IVerticalRuler; import org.eclipse.jface.text.source.SourceViewer; import org.eclipse.jface.util.PropertyChangeEvent; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.swt.custom.StyledText; import org.eclipse.swt.events.KeyEvent; import org.eclipse.swt.events.KeyListener; import org.eclipse.swt.events.MouseEvent; import org.eclipse.swt.events.MouseListener; import org.eclipse.swt.events.PaintEvent; import org.eclipse.swt.events.PaintListener; import org.eclipse.swt.graphics.Color; import org.eclipse.swt.graphics.GC; import org.eclipse.swt.graphics.Point; import org.eclipse.swt.graphics.RGB; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Shell; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IViewPart; import org.eclipse.ui.IWorkbenchPage; import org.eclipse.ui.actions.WorkspaceModifyOperation; import org.eclipse.ui.dialogs.SaveAsDialog; import org.eclipse.ui.part.FileEditorInput; import org.eclipse.ui.texteditor.AbstractTextEditor; import org.eclipse.ui.texteditor.IDocumentProvider;
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
import org.eclipse.ui.texteditor.ITextEditorActionConstants; import org.eclipse.ui.texteditor.MarkerAnnotation; import org.eclipse.ui.texteditor.MarkerUtilities; import org.eclipse.ui.texteditor.TextOperationAction; import org.eclipse.ui.views.tasklist.TaskList; /** * Java specific text editor. */ public class CompilationUnitEditor extends JavaEditor { /** * Responsible for highlighting matching pairs of brackets. */ class BracketHighlighter implements KeyListener, MouseListener, ISelectionChangedListener, ITextListener, ITextInputListener { /** * Highlights the brackets. */ class HighlightBrackets implements PaintListener { private JavaPairMatcher fMatcher= new JavaPairMatcher(new char[] { '{', '}', '(', ')', '[', ']' }); private Position fBracketPosition= new Position(0, 0); private int fAnchor; private boolean fIsActive= false; private StyledText fTextWidget; private Color fColor;
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
public HighlightBrackets() { fTextWidget= fSourceViewer.getTextWidget(); } public void setHighlightColor(Color color) { fColor= color; } public void dispose() { if (fMatcher != null) { fMatcher.dispose(); fMatcher= null; } fColor= null; fTextWidget= null; } public void deactivate(boolean redraw) { if (fIsActive) { fIsActive= false; fTextWidget.removePaintListener(this); fManager.unmanage(fBracketPosition); if (redraw) handleDrawRequest(null); } } public void run() {
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
Point selection= fSourceViewer.getSelectedRange(); if (selection.y > 0) { deactivate(true); return; } IRegion pair= fMatcher.match(fSourceViewer.getDocument(), selection.x); if (pair == null) { deactivate(true); return; } if (fIsActive) { if (pair.getOffset() != fBracketPosition.getOffset() || pair.getLength() != fBracketPosition.getLength() || fMatcher.getAnchor() != fAnchor) { handleDrawRequest(null); fBracketPosition.isDeleted= false; fBracketPosition.offset= pair.getOffset(); fBracketPosition.length= pair.getLength(); fAnchor= fMatcher.getAnchor(); handleDrawRequest(null); } } else {
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
fIsActive= true; fBracketPosition.isDeleted= false; fBracketPosition.offset= pair.getOffset(); fBracketPosition.length= pair.getLength(); fAnchor= fMatcher.getAnchor(); fTextWidget.addPaintListener(this); fManager.manage(fBracketPosition); handleDrawRequest(null); } } public void paintControl(PaintEvent event) { if (fTextWidget != null) handleDrawRequest(event.gc); } private void handleDrawRequest(GC gc) { IRegion region= fSourceViewer.getVisibleRegion(); int offset= fBracketPosition.getOffset(); int length= fBracketPosition.getLength(); if (region.getOffset() <= offset && region.getOffset() + region.getLength() >= offset + length) { offset -= region.getOffset(); if (fMatcher.RIGHT == fAnchor) draw(gc, offset, 1); else draw(gc, offset + length -1, 1);
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
} } private void draw(GC gc, int offset, int length) { if (gc != null) { Point left= fTextWidget.getLocationAtOffset(offset); Point right= fTextWidget.getLocationAtOffset(offset + length); gc.setForeground(fColor); gc.drawRectangle(left.x, left.y, right.x - left.x - 1, gc.getFontMetrics().getHeight() - 1); } else { fTextWidget.redrawRange(offset, length, true); } } }; /** * Manages the registration and updating of the bracket position. */ class BracketPositionManager { private IDocument fDocument; private IPositionUpdater fPositionUpdater; private String fCategory; public BracketPositionManager() { fCategory= getClass().getName() + hashCode(); fPositionUpdater= new DefaultPositionUpdater(fCategory); }
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
public void install(IDocument document) { fDocument= document; fDocument.addPositionCategory(fCategory); fDocument.addPositionUpdater(fPositionUpdater); } public void dispose() { uninstall(fDocument); } public void uninstall(IDocument document) { if (document == fDocument && document != null) { try { fDocument.removePositionUpdater(fPositionUpdater); fDocument.removePositionCategory(fCategory); } catch (BadPositionCategoryException x) { } fDocument= null; } } public void manage(Position position) { try { fDocument.addPosition(fCategory, position); } catch (BadPositionCategoryException x) { } catch (BadLocationException x) {
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
} } public void unmanage(Position position) { try { fDocument.removePosition(fCategory, position); } catch (BadPositionCategoryException x) { } } }; private BracketPositionManager fManager= new BracketPositionManager(); private HighlightBrackets fHighlightBrackets; private ISourceViewer fSourceViewer; private boolean fTextChanged= false; public BracketHighlighter(ISourceViewer sourceViewer) { fSourceViewer= sourceViewer; fHighlightBrackets= new HighlightBrackets(); } public void setHighlightColor(Color color) { fHighlightBrackets.setHighlightColor(color); } public void install() { fManager.install(fSourceViewer.getDocument());
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
fSourceViewer.addTextInputListener(this); ISelectionProvider provider= fSourceViewer.getSelectionProvider(); provider.addSelectionChangedListener(this); fSourceViewer.addTextListener(this); StyledText text= fSourceViewer.getTextWidget(); text.addKeyListener(this); text.addMouseListener(this); } public void dispose() { if (fManager != null) { fManager.dispose(); fManager= null; } if (fHighlightBrackets != null) { fHighlightBrackets.dispose(); fHighlightBrackets= null; } if (fSourceViewer != null && fBracketHighlighter != null) { fSourceViewer.removeTextInputListener(this); ISelectionProvider provider= fSourceViewer.getSelectionProvider();
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
provider.removeSelectionChangedListener(this); fSourceViewer.removeTextListener(this); StyledText text= fSourceViewer.getTextWidget(); if (text != null && !text.isDisposed()) { text.removeKeyListener(fBracketHighlighter); text.removeMouseListener(fBracketHighlighter); } fSourceViewer= null; } } /** * @see KeyListener#keyPressed(KeyEvent) */ public void keyPressed(KeyEvent e) { fTextChanged= false; } /** * @see KeyListener#keyReleased(KeyEvent) */ public void keyReleased(KeyEvent e) { if (!fTextChanged) fHighlightBrackets.run(); } /** * @see MouseListener#mouseDoubleClick(MouseEvent) */
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
public void mouseDoubleClick(MouseEvent e) { } /** * @see MouseListener#mouseDown(MouseEvent) */ public void mouseDown(MouseEvent e) { } /** * @see MouseListener#mouseUp(MouseEvent) */ public void mouseUp(MouseEvent e) { fHighlightBrackets.run(); } /** * @see ISelectionChangedListener#selectionChanged(SelectionChangedEvent) */ public void selectionChanged(SelectionChangedEvent event) { fHighlightBrackets.run(); } /** * @see ITextListener#textChanged(TextEvent) */ public void textChanged(TextEvent event) { fTextChanged= true; Control control= fSourceViewer.getTextWidget(); if (control != null) {
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
control.getDisplay().asyncExec(new Runnable() { public void run() { if (fTextChanged && fHighlightBrackets != null) fHighlightBrackets.run(); } }); } } /** * @see ITextInputListener#inputDocumentAboutToBeChanged(IDocument, IDocument) */ public void inputDocumentAboutToBeChanged(IDocument oldInput, IDocument newInput) { if (oldInput != null) { fHighlightBrackets.deactivate(false); fManager.uninstall(oldInput); } } /** * @see ITextInputListener#inputDocumentChanged(IDocument, IDocument) */ public void inputDocumentChanged(IDocument oldInput, IDocument newInput) { if (newInput != null) fManager.install(newInput); } }; class InternalSourceViewer extends SourceViewer {
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
public InternalSourceViewer(Composite parent, IVerticalRuler ruler, int styles) { super(parent, ruler, styles); } public IContentAssistant getContentAssistant() { return fContentAssistant; } }; public final static String MATCHING_BRACKETS= "matchingBrackets"; public final static String MATCHING_BRACKETS_COLOR= "matchingBracketsColor"; protected ISelectionChangedListener fStatusLineClearer; protected ISavePolicy fSavePolicy; private JavaEditorErrorTickUpdater fJavaEditorErrorTickUpdater; private BracketHighlighter fBracketHighlighter;
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
/** * Creates a new compilation unit editor. */ public CompilationUnitEditor() { super(); setDocumentProvider(JavaPlugin.getDefault().getCompilationUnitDocumentProvider()); setEditorContextMenuId("#CompilationUnitEditorContext"); setRulerContextMenuId("#CompilationUnitRulerContext"); setOutlinerContextMenuId("#CompilationUnitOutlinerContext"); fSavePolicy= null; fJavaEditorErrorTickUpdater= new JavaEditorErrorTickUpdater(this); } /** * @see AbstractTextEditor#createActions() */ protected void createActions() { super.createActions(); setAction("ContentAssistProposal", new TextOperationAction(JavaEditorMessages.getResourceBundle(), "ContentAssistProposal.", this, ISourceViewer.CONTENTASSIST_PROPOSALS)); setAction("AddImportOnSelection", new AddImportOnSelectionAction(this)); setAction("OrganizeImports", new OrganizeImportsAction(this)); setAction("Comment", new TextOperationAction(JavaEditorMessages.getResourceBundle(), "Comment.", this, ITextOperationTarget.PREFIX)); setAction("Uncomment", new TextOperationAction(JavaEditorMessages.getResourceBundle(), "Uncomment.", this, ITextOperationTarget.STRIP_PREFIX)); setAction("Format", new TextOperationAction(JavaEditorMessages.getResourceBundle(), "Format.", this, ISourceViewer.FORMAT));
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
setAction("ManageBreakpoints", new BreakpointRulerAction(getVerticalRuler(), this)); setAction(ITextEditorActionConstants.RULER_DOUBLE_CLICK, getAction("ManageBreakpoints")); } /** * @see JavaEditor#getElementAt(int) */ protected IJavaElement getElementAt(int offset) { IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); ICompilationUnit unit= manager.getWorkingCopy(getEditorInput()); if (unit != null) { synchronized (unit) { try { unit.reconcile(); return unit.getElementAt(offset); } catch (JavaModelException x) { } } } return null; } /** * @see JavaEditor#getCorrespondingElement(IJavaElement) */ protected IJavaElement getCorrespondingElement(IJavaElement element) { try {
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
return EditorUtility.getWorkingCopy(element, true); } catch (JavaModelException x) { } return null; } /** * @see AbstractTextEditor#editorContextMenuAboutToShow(IMenuManager) */ public void editorContextMenuAboutToShow(IMenuManager menu) { super.editorContextMenuAboutToShow(menu); addAction(menu, IContextMenuConstants.GROUP_GENERATE, "ContentAssistProposal"); addAction(menu, IContextMenuConstants.GROUP_GENERATE, "AddImportOnSelection"); addAction(menu, IContextMenuConstants.GROUP_GENERATE, "OrganizeImports"); addAction(menu, ITextEditorActionConstants.GROUP_EDIT, "Comment"); addAction(menu, ITextEditorActionConstants.GROUP_EDIT, "Uncomment"); addAction(menu, ITextEditorActionConstants.GROUP_EDIT, "Format"); } /** * @see AbstractTextEditor#rulerContextMenuAboutToShow(IMenuManager) */ protected void rulerContextMenuAboutToShow(IMenuManager menu) { super.rulerContextMenuAboutToShow(menu); addAction(menu, "ManageBreakpoints"); } /**
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
* @see JavaEditor#createOutlinePage() */ protected JavaOutlinePage createOutlinePage() { JavaOutlinePage page= super.createOutlinePage(); page.setAction("OrganizeImports", new OrganizeImportsAction(this)); DeleteAction deleteElement= new DeleteAction(page); page.setAction("DeleteElement", deleteElement); return page; } /** * @see JavaEditor#setOutlinePageInput(JavaOutlinePage, IEditorInput) */ protected void setOutlinePageInput(JavaOutlinePage page, IEditorInput input) { if (page != null) { IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); page.setInput(manager.getWorkingCopy(input)); } } /** * @see AbstractTextEditor#performSaveOperation(WorkspaceModifyOperation, IProgressMonitor) */ protected void performSaveOperation(WorkspaceModifyOperation operation, IProgressMonitor progressMonitor) { IDocumentProvider p= getDocumentProvider(); if (p instanceof CompilationUnitDocumentProvider) {
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
CompilationUnitDocumentProvider cp= (CompilationUnitDocumentProvider) p; cp.setSavePolicy(fSavePolicy); } try { super.performSaveOperation(operation, progressMonitor); } finally { if (p instanceof CompilationUnitDocumentProvider) { CompilationUnitDocumentProvider cp= (CompilationUnitDocumentProvider) p; cp.setSavePolicy(null); } } } /** * @see AbstractTextEditor#doSave(IProgressMonitor) */ public void doSave(IProgressMonitor progressMonitor) { IDocumentProvider p= getDocumentProvider(); if (p == null) return; if (p.isDeleted(getEditorInput())) { if (isSaveAsAllowed()) { /* * 1GEUSSR: ITPUI:ALL - User should never loose changes made in the editors. * Changed Behavior to make sure that if called inside a regular save (because
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
* of deletion of input element) there is a way to report back to the caller. */ performSaveAs(progressMonitor); } else { /* * 1GF5YOX: ITPJUI:ALL - Save of delete file claims it's still there * Missing resources. */ Shell shell= getSite().getShell(); MessageDialog.openError(shell, JavaEditorMessages.getString("CompilationUnitEditor.error.saving.title1"), JavaEditorMessages.getString("CompilationUnitEditor.error.saving.message1")); } } else { getStatusLineManager().setErrorMessage(""); IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); ICompilationUnit unit= manager.getWorkingCopy(getEditorInput()); if (unit != null) { synchronized (unit) { performSaveOperation(createSaveOperation(false), progressMonitor); } } else performSaveOperation(createSaveOperation(false), progressMonitor); } }
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
/** * Jumps to the error next according to the given direction. */ public void gotoError(boolean forward) { ISelectionProvider provider= getSelectionProvider(); if (fStatusLineClearer != null) { provider.removeSelectionChangedListener(fStatusLineClearer); fStatusLineClearer= null; } ITextSelection s= (ITextSelection) provider.getSelection(); IMarker nextError= getNextError(s.getOffset(), forward); if (nextError != null) { gotoMarker(nextError); IWorkbenchPage page= getSite().getPage(); IViewPart view= view= page.findView("org.eclipse.ui.views.TaskList"); if (view instanceof TaskList) { StructuredSelection ss= new StructuredSelection(nextError); ((TaskList) view).setSelection(ss, true); } getStatusLineManager().setErrorMessage(nextError.getAttribute(IMarker.MESSAGE, "")); fStatusLineClearer= new ISelectionChangedListener() { public void selectionChanged(SelectionChangedEvent event) {
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
getSelectionProvider().removeSelectionChangedListener(fStatusLineClearer); fStatusLineClearer= null; getStatusLineManager().setErrorMessage(""); } }; provider.addSelectionChangedListener(fStatusLineClearer); } else { getStatusLineManager().setErrorMessage(""); } } private IMarker getNextError(int offset, boolean forward) { IMarker nextError= null; IDocument document= getDocumentProvider().getDocument(getEditorInput()); int endOfDocument= document.getLength(); int distance= 0; IAnnotationModel model= getDocumentProvider().getAnnotationModel(getEditorInput()); Iterator e= model.getAnnotationIterator(); while (e.hasNext()) { Annotation a= (Annotation) e.next(); if (a instanceof MarkerAnnotation) { MarkerAnnotation ma= (MarkerAnnotation) a; IMarker marker= ma.getMarker(); if (MarkerUtilities.isMarkerType(marker, IMarker.PROBLEM)) {
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
Position p= model.getPosition(a); if (!p.includes(offset)) { int currentDistance= 0; if (forward) { currentDistance= p.getOffset() - offset; if (currentDistance < 0) currentDistance= endOfDocument - offset + p.getOffset(); } else { currentDistance= offset - p.getOffset(); if (currentDistance < 0) currentDistance= offset + endOfDocument - p.getOffset(); } if (nextError == null || currentDistance < distance) { distance= currentDistance; nextError= marker; } } } } } return nextError; } /** * @see AbstractTextEditor#isSaveAsAllowed()
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
*/ public boolean isSaveAsAllowed() { return true; } /* * 1GF7WG9: ITPJUI:ALL - EXCEPTION: "Save As..." always fails */ protected IPackageFragment getPackage(IWorkspaceRoot root, IPath path) { if (path.segmentCount() == 1) { IProject project= root.getProject(path.toString()); if (project != null) { IJavaProject jProject= JavaCore.create(project); if (jProject != null) { try { IJavaElement element= jProject.findElement(new Path("")); if (element instanceof IPackageFragment) { IPackageFragment fragment= (IPackageFragment) element; IJavaElement parent= fragment.getParent(); if (parent instanceof IPackageFragmentRoot) { IPackageFragmentRoot pRoot= (IPackageFragmentRoot) parent; if ( !pRoot.isArchive() && !pRoot.isExternal() && path.equals(pRoot.getPath())) return fragment; } } } catch (JavaModelException x) { }
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
} } return null; } else if (path.segmentCount() > 1) { IFolder folder= root.getFolder(path); IJavaElement element= JavaCore.create(folder); if (element instanceof IPackageFragment) return (IPackageFragment) element; } return null; } /* * 1GEUSSR: ITPUI:ALL - User should never loose changes made in the editors. * Changed behavior to make sure that if called inside a regular save (because * of deletion of input element) there is a way to report back to the caller. */ protected void performSaveAs(IProgressMonitor progressMonitor) { Shell shell= getSite().getShell(); SaveAsDialog dialog= new SaveAsDialog(shell); if (dialog.open() == Dialog.CANCEL) { if (progressMonitor != null) progressMonitor.setCanceled(true); return;
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
} IPath filePath= dialog.getResult(); if (filePath == null) { if (progressMonitor != null) progressMonitor.setCanceled(true); return; } filePath= filePath.removeTrailingSeparator(); final String fileName= filePath.lastSegment(); IPath folderPath= filePath.removeLastSegments(1); if (folderPath == null) { if (progressMonitor != null) progressMonitor.setCanceled(true); return; } IWorkspaceRoot root= ResourcesPlugin.getWorkspace().getRoot(); /* * 1GF7WG9: ITPJUI:ALL - EXCEPTION: "Save As..." always fails */ final IPackageFragment fragment= getPackage(root, folderPath); IFile file= root.getFile(filePath); final FileEditorInput newInput= new FileEditorInput(file); WorkspaceModifyOperation op= new WorkspaceModifyOperation() { public void execute(final IProgressMonitor monitor) throws CoreException {
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
if (fragment != null) { try { IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); ICompilationUnit unit= manager.getWorkingCopy(getEditorInput()); /* * 1GJXY0L: ITPJUI:WINNT - NPE during save As in Java editor * Introduced null check, just go on in the null case */ if (unit != null) { /* * 1GF5YOX: ITPJUI:ALL - Save of delete file claims it's still there * Changed false to true. */ unit.copy(fragment, null, fileName, true, monitor); return; } } catch (JavaModelException x) { } } /* * 1GF5YOX: ITPJUI:ALL - Save of delete file claims it's still there
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
* Changed false to true. */ getDocumentProvider().saveDocument(monitor, newInput, getDocumentProvider().getDocument(getEditorInput()), true); } }; boolean success= false; try { if (fragment == null) getDocumentProvider().aboutToChange(newInput); new ProgressMonitorDialog(shell).run(false, true, op); setInput(newInput); success= true; } catch (InterruptedException x) { } catch (InvocationTargetException x) { /* * 1GF5YOX: ITPJUI:ALL - Save of delete file claims it's still there * Missing resources. */ Throwable t= x.getTargetException(); if (t instanceof CoreException) { CoreException cx= (CoreException) t; ErrorDialog.openError(shell, JavaEditorMessages.getString("CompilationUnitEditor.error.saving.title2"), JavaEditorMessages.getString("CompilationUnitEditor.error.saving.message2"), cx.getStatus()); } else { MessageDialog.openError(shell, JavaEditorMessages.getString("CompilationUnitEditor.error.saving.title3"), JavaEditorMessages.getString("CompilationUnitEditor.error.saving.message3") + t.getMessage()); }
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
} finally { if (fragment == null) getDocumentProvider().changed(newInput); if (progressMonitor != null) progressMonitor.setCanceled(!success); } } /** * @see AbstractTextEditor#doSetInput(IEditorInput) */ protected void doSetInput(IEditorInput input) throws CoreException { super.doSetInput(input); fJavaEditorErrorTickUpdater.setAnnotationModel(getDocumentProvider().getAnnotationModel(input)); } private void startBracketHighlighting() { if (fBracketHighlighter == null) { ISourceViewer sourceViewer= getSourceViewer(); fBracketHighlighter= new BracketHighlighter(sourceViewer); fBracketHighlighter.setHighlightColor(getColor(MATCHING_BRACKETS_COLOR)); fBracketHighlighter.install(); } } private void stopBracketHighlighting() { if (fBracketHighlighter != null) {
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
fBracketHighlighter.dispose(); fBracketHighlighter= null; } } private boolean isBracketHighlightingEnabled() { IPreferenceStore store= getPreferenceStore(); return store.getBoolean(MATCHING_BRACKETS); } private Color getColor(String key) { RGB rgb= PreferenceConverter.getColor(getPreferenceStore(), key); JavaTextTools textTools= JavaPlugin.getDefault().getJavaTextTools(); return textTools.getColorManager().getColor(rgb); } /** * @see AbstractTextEditor#dispose() */ public void dispose() { if (fJavaEditorErrorTickUpdater != null) { fJavaEditorErrorTickUpdater.setAnnotationModel(null); fJavaEditorErrorTickUpdater= null; } stopBracketHighlighting(); super.dispose(); }
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
/** * @see AbstractTextEditor#createPartControl(Composite) */ public void createPartControl(Composite parent) { super.createPartControl(parent); if (isBracketHighlightingEnabled()) startBracketHighlighting(); } /** * @see AbstractTextEditor#handlePreferenceStoreChanged(PropertyChangeEvent) */ protected void handlePreferenceStoreChanged(PropertyChangeEvent event) { try { InternalSourceViewer isv= (InternalSourceViewer) getSourceViewer(); if (isv != null) { String p= event.getProperty(); if (MATCHING_BRACKETS.equals(p)) { if (isBracketHighlightingEnabled()) startBracketHighlighting(); else stopBracketHighlighting(); return; } if (MATCHING_BRACKETS_COLOR.equals(p)) {
3,782
Bug 3782 F1 help does nothing (1GETAYN)
F1 help doesn't seem to work in many of the JDT views or the Java text editor. Press F1 in outline, hierachy view, or a Java editor. Nothing happens. NOTES: EG (6/4/2001 10:35:44 AM) The help contexts for Views is missing in the IJavaHelpContextIds.java file. As a consequence they are also missing in the contexts_JDT.xml. EG (6/4/2001 10:24:22 PM) The display view is missing a help context ID. The search results view doesn't define a help context ID. The type hierarchy view doesn't define a context. EG (6/5/2001 3:43:50 AM) global actions in action sets don't have a help context id, e.g., <action label="%DebugAction.label" pulldown="true" icon="icons/full/ctool16/debug_exc.gif" tooltip="%DebugAction.tooltip" class="org.eclipse.debug.internal.ui.DebugDropDownAction" toolbarPath="debug" id="org.eclipse.debug.internal.ui.DebugDropDownAction" helpContextId="debug_action_context"> <<<<<<<<<<<<<<<<<<<<<<<<<<<< </action> EG (6/5/2001 5:31:13 AM) see also 1GEUF4P: ITPJUI:WIN2000 - No Help on Refactoring wizards GDA (6/5/01 11:09:35 AM) Should add the context ids. This is a 1 line change for each context. Recommend move to candidates MA (6/6/01 6:45:35 PM) Refactorings have help context ids added for views public static final String SEARCH_VIEW= PREFIX + "search_view_context"; public static final String PACKAGE_VIEW= PREFIX + "package_view_context"; public static final String TYPE_HIERARCHY_VIEW= PREFIX + "type_hierarchy_view_context"; public static final String DISPLAY_VIEW= PREFIX + "display_view_context"; global actions are all very obvious what they do. suggest to not add help DM (6/20/01 4:33:45 PM) Verified against 0.125 - context help is there for the stuff described in this PR: - packages view - hierarchy view BUT: - Outline view will only show Workbench's help because we do not register help in the page - Java editor: standard text comes up - Search View: standard text comes up - might work once help files from workbench are ok Not fixed - moving to InBox - Deferred
verified fixed
50e30fa
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T12:23:28Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/CompilationUnitEditor.java
if (fBracketHighlighter != null) fBracketHighlighter.setHighlightColor(getColor(MATCHING_BRACKETS_COLOR)); return; } IContentAssistant c= isv.getContentAssistant(); if (c instanceof ContentAssistant) ContentAssistPreference.changeConfiguration((ContentAssistant) c, getPreferenceStore(), event); } } finally { super.handlePreferenceStoreChanged(event); } } /** * @see AbstractTextEditor#affectsTextPresentation(PropertyChangeEvent) */ protected boolean affectsTextPresentation(PropertyChangeEvent event) { String p= event.getProperty(); boolean affects=MATCHING_BRACKETS_COLOR.equals(p); return affects ? affects : super.affectsTextPresentation(event); } /** * @see AbstractTextEditor#createSourceViewer(Composite, IVerticalRuler, int) */ protected ISourceViewer createSourceViewer(Composite parent, IVerticalRuler ruler, int styles) { return new InternalSourceViewer(parent, ruler, styles); } }
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.wizards; import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import java.util.List; import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.core.runtime.SubProgressMonitor; import org.eclipse.swt.SWT; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.widgets.Composite;
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
import org.eclipse.swt.widgets.Control; import org.eclipse.jface.operation.IRunnableWithProgress; import org.eclipse.jface.viewers.LabelProvider; import org.eclipse.jdt.core.Flags; import org.eclipse.jdt.core.IBuffer; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.ISourceRange; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.ITypeHierarchy; import org.eclipse.jdt.core.JavaConventions; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.Signature; import org.eclipse.jdt.core.search.IJavaSearchScope; import org.eclipse.jdt.core.search.SearchEngine; import org.eclipse.jdt.ui.IJavaElementSearchConstants; import org.eclipse.jdt.ui.JavaElementLabelProvider; import org.eclipse.jdt.internal.compiler.env.IConstants; import org.eclipse.jdt.internal.corext.codemanipulation.CodeGenerationSettings; import org.eclipse.jdt.internal.corext.codemanipulation.IImportsStructure; import org.eclipse.jdt.internal.corext.codemanipulation.ImportsStructure; import org.eclipse.jdt.internal.corext.codemanipulation.StubUtility; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.dialogs.ElementListSelectionDialog; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo;
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
import org.eclipse.jdt.internal.ui.dialogs.TypeSelectionDialog; import org.eclipse.jdt.internal.ui.javaeditor.EditorUtility; import org.eclipse.jdt.internal.ui.preferences.CodeGenerationPreferencePage; import org.eclipse.jdt.internal.ui.preferences.ImportOrganizePreferencePage; import org.eclipse.jdt.internal.ui.preferences.JavaPreferencesSettings; import org.eclipse.jdt.internal.ui.text.template.Template; import org.eclipse.jdt.internal.ui.text.template.Templates; import org.eclipse.jdt.internal.ui.wizards.dialogfields.DialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IDialogFieldListener; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IListAdapter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IStringButtonAdapter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.LayoutUtil; import org.eclipse.jdt.internal.ui.wizards.dialogfields.ListDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.SelectionButtonDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.SelectionButtonDialogFieldGroup; import org.eclipse.jdt.internal.ui.wizards.dialogfields.Separator; import org.eclipse.jdt.internal.ui.wizards.dialogfields.StringButtonDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.StringButtonStatusDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.StringDialogField; import org.eclipse.jdt.internal.ui.wizards.swt.MGridData; /** * <code>TypePage</code> contains controls and validation routines for a 'New Type WizardPage' * Implementors decide which components to add and to enable. Implementors can also * customize the validation code. * <code>TypePage</code> is intended to serve as base class of all wizards that create types. * Applets, Servlets, Classes, Interfaces... * See <code>NewClassCreationWizardPage</code> or <code>NewInterfaceCreationWizardPage</code> for an * example usage of TypePage. */ public abstract class TypePage extends ContainerPage {
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
private final static String PAGE_NAME= "TypePage"; protected final static String PACKAGE= PAGE_NAME + ".package"; protected final static String ENCLOSING= PAGE_NAME + ".enclosing"; protected final static String ENCLOSINGSELECTION= ENCLOSING + ".selection"; protected final static String TYPENAME= PAGE_NAME + ".typename"; protected final static String SUPER= PAGE_NAME + ".superclass"; protected final static String INTERFACES= PAGE_NAME + ".interfaces"; protected final static String MODIFIERS= PAGE_NAME + ".modifiers"; protected final static String METHODS= PAGE_NAME + ".methods"; private class InterfacesListLabelProvider extends LabelProvider {
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
private Image fInterfaceImage; public InterfacesListLabelProvider() { super(); fInterfaceImage= JavaPlugin.getDefault().getImageRegistry().get(JavaPluginImages.IMG_OBJS_INTERFACE); } public Image getImage(Object element) { return fInterfaceImage; } } private StringButtonStatusDialogField fPackageDialogField; private SelectionButtonDialogField fEnclosingTypeSelection; private StringButtonDialogField fEnclosingTypeDialogField; private boolean fCanModifyPackage; private boolean fCanModifyEnclosingType; private IPackageFragment fCurrPackage; private IType fCurrEnclosingType;
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
private StringDialogField fTypeNameDialogField; private StringButtonDialogField fSuperClassDialogField; private ListDialogField fSuperInterfacesDialogField; private IType fSuperClass; private SelectionButtonDialogFieldGroup fAccMdfButtons; private SelectionButtonDialogFieldGroup fOtherMdfButtons; private IType fCreatedType; protected IStatus fEnclosingTypeStatus; protected IStatus fPackageStatus; protected IStatus fTypeNameStatus; protected IStatus fSuperClassStatus; protected IStatus fModifierStatus; protected IStatus fSuperInterfacesStatus; private boolean fIsClass; private int fStaticMdfIndex; private final int PUBLIC_INDEX= 0, DEFAULT_INDEX= 1, PRIVATE_INDEX= 2, PROTECTED_INDEX= 3; private final int ABSTRACT_INDEX= 0, FINAL_INDEX= 1; public TypePage(boolean isClass, String pageName, IWorkspaceRoot root) { super(pageName, root); fCreatedType= null; fIsClass= isClass;
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
TypeFieldsAdapter adapter= new TypeFieldsAdapter(); fPackageDialogField= new StringButtonStatusDialogField(adapter); fPackageDialogField.setDialogFieldListener(adapter); fPackageDialogField.setLabelText(NewWizardMessages.getString("TypePage.package.label")); fPackageDialogField.setButtonLabel(NewWizardMessages.getString("TypePage.package.button")); fPackageDialogField.setStatusWidthHint(NewWizardMessages.getString("TypePage.default")); fEnclosingTypeSelection= new SelectionButtonDialogField(SWT.CHECK); fEnclosingTypeSelection.setDialogFieldListener(adapter); fEnclosingTypeSelection.setLabelText(NewWizardMessages.getString("TypePage.enclosing.selection.label")); fEnclosingTypeDialogField= new StringButtonDialogField(adapter); fEnclosingTypeDialogField.setDialogFieldListener(adapter); fEnclosingTypeDialogField.setButtonLabel(NewWizardMessages.getString("TypePage.enclosing.button")); fTypeNameDialogField= new StringDialogField(); fTypeNameDialogField.setDialogFieldListener(adapter); fTypeNameDialogField.setLabelText(NewWizardMessages.getString("TypePage.typename.label")); fSuperClassDialogField= new StringButtonDialogField(adapter); fSuperClassDialogField.setDialogFieldListener(adapter); fSuperClassDialogField.setLabelText(NewWizardMessages.getString("TypePage.superclass.label")); fSuperClassDialogField.setButtonLabel(NewWizardMessages.getString("TypePage.superclass.button")); String[] addButtons= new String[] { NewWizardMessages.getString("TypePage.interfaces.add"), null, NewWizardMessages.getString("TypePage.interfaces.remove")
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
}; fSuperInterfacesDialogField= new ListDialogField(adapter, addButtons, new InterfacesListLabelProvider()); fSuperInterfacesDialogField.setDialogFieldListener(adapter); String interfaceLabel= fIsClass ? NewWizardMessages.getString("TypePage.interfaces.class.label") : NewWizardMessages.getString("TypePage.interfaces.ifc.label"); fSuperInterfacesDialogField.setLabelText(interfaceLabel); fSuperInterfacesDialogField.setRemoveButtonIndex(2); String[] buttonNames1= new String[] { NewWizardMessages.getString("TypePage.modifiers.public"), NewWizardMessages.getString("TypePage.modifiers.default"), NewWizardMessages.getString("TypePage.modifiers.private"), NewWizardMessages.getString("TypePage.modifiers.protected") }; fAccMdfButtons= new SelectionButtonDialogFieldGroup(SWT.RADIO, buttonNames1, 4); fAccMdfButtons.setDialogFieldListener(adapter); fAccMdfButtons.setLabelText(NewWizardMessages.getString("TypePage.modifiers.acc.label")); fAccMdfButtons.setSelection(0, true); String[] buttonNames2; if (fIsClass) { buttonNames2= new String[] { NewWizardMessages.getString("TypePage.modifiers.abstract"), NewWizardMessages.getString("TypePage.modifiers.final"), NewWizardMessages.getString("TypePage.modifiers.static") }; fStaticMdfIndex= 2; } else { buttonNames2= new String[] { NewWizardMessages.getString("TypePage.modifiers.static") };
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
fStaticMdfIndex= 0; } fOtherMdfButtons= new SelectionButtonDialogFieldGroup(SWT.CHECK, buttonNames2, 4); fOtherMdfButtons.setDialogFieldListener(adapter); fAccMdfButtons.enableSelectionButton(PRIVATE_INDEX, false); fAccMdfButtons.enableSelectionButton(PROTECTED_INDEX, false); fOtherMdfButtons.enableSelectionButton(fStaticMdfIndex, false); fPackageStatus= new StatusInfo(); fEnclosingTypeStatus= new StatusInfo(); fCanModifyPackage= true; fCanModifyEnclosingType= true; updateEnableState(); fTypeNameStatus= new StatusInfo(); fSuperClassStatus= new StatusInfo(); fSuperInterfacesStatus= new StatusInfo(); fModifierStatus= new StatusInfo(); } /** * Initializes all fields provided by the type page with a given * Java element as selection. * @param elem The initial selection of this page or null if no * selection was available */ protected void initTypePage(IJavaElement elem) { String initSuperclass= "java.lang.Object"; ArrayList initSuperinterfaces= new ArrayList(5);
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
IPackageFragment pack= null; IType enclosingType= null; if (elem != null) { pack= (IPackageFragment) JavaModelUtil.findElementOfKind(elem, IJavaElement.PACKAGE_FRAGMENT); IType typeInCU= (IType) JavaModelUtil.findElementOfKind(elem, IJavaElement.TYPE); if (typeInCU != null) { if (typeInCU.getCompilationUnit() != null) { enclosingType= typeInCU; } } else { ICompilationUnit cu= (ICompilationUnit) JavaModelUtil.findElementOfKind(elem, IJavaElement.COMPILATION_UNIT); if (cu != null) { enclosingType= JavaModelUtil.findPrimaryType(cu); } } try { IType type= null; if (elem.getElementType() == IJavaElement.TYPE) { type= (IType)elem; if (type.exists()) { String superName= JavaModelUtil.getFullyQualifiedName(type); if (type.isInterface()) { initSuperinterfaces.add(superName); } else { initSuperclass= superName; } }
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
} } catch (JavaModelException e) { JavaPlugin.log(e.getStatus()); } } setPackageFragment(pack, true); setEnclosingType(enclosingType, true); setEnclosingTypeSelection(false, true); setTypeName("", true); setSuperClass(initSuperclass, true); setSuperInterfaces(initSuperinterfaces, true); } /** * Creates a separator line. * @param composite The parent composite * @param nColumns Number of columns to span */ protected void createSeparator(Composite composite, int nColumns) { (new Separator(SWT.SEPARATOR | SWT.HORIZONTAL)).doFillIntoGrid(composite, nColumns, convertHeightInCharsToPixels(1)); } /** * Creates the controls for the package name field. * @param composite The parent composite * @param nColumns Number of columns to span */
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
protected void createPackageControls(Composite composite, int nColumns) { fPackageDialogField.doFillIntoGrid(composite, 4); LayoutUtil.setWidthHint(fPackageDialogField.getTextControl(null), getMaxFieldWidth()); } /** * Creates the controls for the enclosing type name field. * @param composite The parent composite * @param nColumns Number of columns to span */ protected void createEnclosingTypeControls(Composite composite, int nColumns) { fEnclosingTypeSelection.doFillIntoGrid(composite, 1); Control c= fEnclosingTypeDialogField.getTextControl(composite); MGridData gd= new MGridData(MGridData.FILL_HORIZONTAL); gd.widthHint= getMaxFieldWidth(); gd.horizontalSpan= 2; c.setLayoutData(gd); c= fEnclosingTypeDialogField.getChangeControl(composite); c.setLayoutData(new MGridData(MGridData.HORIZONTAL_ALIGN_FILL)); } /** * Creates the controls for the type name field. * @param composite The parent composite * @param nColumns Number of columns to span */ protected void createTypeNameControls(Composite composite, int nColumns) { fTypeNameDialogField.doFillIntoGrid(composite, nColumns - 1); DialogField.createEmptySpace(composite);
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
LayoutUtil.setWidthHint(fTypeNameDialogField.getTextControl(null), getMaxFieldWidth()); } /** * Creates the controls for the modifiers radio/ceckbox buttons. * @param composite The parent composite * @param nColumns Number of columns to span */ protected void createModifierControls(Composite composite, int nColumns) { LayoutUtil.setHorizontalSpan(fAccMdfButtons.getLabelControl(composite), 1); Control control= fAccMdfButtons.getSelectionButtonsGroup(composite); MGridData gd= new MGridData(MGridData.HORIZONTAL_ALIGN_FILL); gd.horizontalSpan= nColumns - 2; control.setLayoutData(gd); DialogField.createEmptySpace(composite); DialogField.createEmptySpace(composite); control= fOtherMdfButtons.getSelectionButtonsGroup(composite); gd= new MGridData(MGridData.HORIZONTAL_ALIGN_FILL); gd.horizontalSpan= nColumns - 2; control.setLayoutData(gd); DialogField.createEmptySpace(composite); } /** * Creates the controls for the superclass name field. * @param composite The parent composite * @param nColumns Number of columns to span */
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
protected void createSuperClassControls(Composite composite, int nColumns) { fSuperClassDialogField.doFillIntoGrid(composite, nColumns); LayoutUtil.setWidthHint(fSuperClassDialogField.getTextControl(null), getMaxFieldWidth()); } /** * Creates the controls for the superclass name field. * @param composite The parent composite * @param nColumns Number of columns to span */ protected void createSuperInterfacesControls(Composite composite, int nColumns) { fSuperInterfacesDialogField.doFillIntoGrid(composite, nColumns); MGridData gd= (MGridData)fSuperInterfacesDialogField.getListControl(null).getLayoutData(); if (fIsClass) { gd.heightHint= convertHeightInCharsToPixels(3); } else { gd.heightHint= convertHeightInCharsToPixels(6); } gd.grabExcessVerticalSpace= false; gd.widthHint= getMaxFieldWidth(); } /** * Sets the focus on the container if empty, elso on type name. */ protected void setFocus() { fTypeNameDialogField.setFocus(); } private class TypeFieldsAdapter implements IStringButtonAdapter, IDialogFieldListener, IListAdapter {
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
public void changeControlPressed(DialogField field) { typePageChangeControlPressed(field); } public void customButtonPressed(DialogField field, int index) { typePageCustomButtonPressed(field, index); } public void selectionChanged(DialogField field) {} public void dialogFieldChanged(DialogField field) { typePageDialogFieldChanged(field); } } private void typePageChangeControlPressed(DialogField field) { if (field == fPackageDialogField) {
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
IPackageFragment pack= choosePackage(); if (pack != null) { fPackageDialogField.setText(pack.getElementName()); } } else if (field == fEnclosingTypeDialogField) { IType type= chooseEnclosingType(); if (type != null) { fEnclosingTypeDialogField.setText(JavaModelUtil.getFullyQualifiedName(type)); } } else if (field == fSuperClassDialogField) { IType type= chooseSuperType(); if (type != null) { fSuperClassDialogField.setText(JavaModelUtil.getFullyQualifiedName(type)); } } } private void typePageCustomButtonPressed(DialogField field, int index) { if (field == fSuperInterfacesDialogField) { chooseSuperInterfaces(); } } /* * A field on the type has changed. The fields' status and all dependend * status are updated. */ private void typePageDialogFieldChanged(DialogField field) { String fieldName= null; if (field == fPackageDialogField) {
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
fPackageStatus= packageChanged(); updatePackageStatusLabel(); fTypeNameStatus= typeNameChanged(); fSuperClassStatus= superClassChanged(); fieldName= PACKAGE; } else if (field == fEnclosingTypeDialogField) { fEnclosingTypeStatus= enclosingTypeChanged(); fTypeNameStatus= typeNameChanged(); fSuperClassStatus= superClassChanged(); fieldName= ENCLOSING; } else if (field == fEnclosingTypeSelection) { updateEnableState(); boolean isEnclosedType= isEnclosingTypeSelected(); if (!isEnclosedType) { if (fAccMdfButtons.isSelected(PRIVATE_INDEX) || fAccMdfButtons.isSelected(PROTECTED_INDEX)) { fAccMdfButtons.setSelection(PRIVATE_INDEX, false); fAccMdfButtons.setSelection(PROTECTED_INDEX, false); fAccMdfButtons.setSelection(PUBLIC_INDEX, true); } if (fOtherMdfButtons.isSelected(fStaticMdfIndex)) { fOtherMdfButtons.setSelection(fStaticMdfIndex, false); } } fAccMdfButtons.enableSelectionButton(PRIVATE_INDEX, isEnclosedType && fIsClass); fAccMdfButtons.enableSelectionButton(PROTECTED_INDEX, isEnclosedType && fIsClass); fOtherMdfButtons.enableSelectionButton(fStaticMdfIndex, isEnclosedType); fTypeNameStatus= typeNameChanged(); fSuperClassStatus= superClassChanged(); fieldName= ENCLOSINGSELECTION; } else if (field == fTypeNameDialogField) {
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
fTypeNameStatus= typeNameChanged(); fieldName= TYPENAME; } else if (field == fSuperClassDialogField) { fSuperClassStatus= superClassChanged(); fieldName= SUPER; } else if (field == fSuperInterfacesDialogField) { fSuperInterfacesStatus= superInterfacesChanged(); fieldName= INTERFACES; } else if (field == fOtherMdfButtons) { fModifierStatus= modifiersChanged(); fieldName= MODIFIERS; } else { fieldName= METHODS; } handleFieldChanged(fieldName); } /** * Called whenever a content of a field has changed. * Implementors of TypePage can hook in. * @see ContainerPage#handleFieldChanged */ protected void handleFieldChanged(String fieldName) { super.handleFieldChanged(fieldName); if (fieldName == CONTAINER) { fPackageStatus= packageChanged();
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
fEnclosingTypeStatus= enclosingTypeChanged(); fTypeNameStatus= typeNameChanged(); fSuperClassStatus= superClassChanged(); fSuperInterfacesStatus= superInterfacesChanged(); } } /** * Gets the text of package field. */ public String getPackageText() { return fPackageDialogField.getText(); } /** * Gets the text of enclosing type field. */ public String getEnclosingTypeText() { return fEnclosingTypeDialogField.getText(); } /** * Returns the package fragment corresponding to the current input. * @return Returns <code>null</code> if the input could not be resolved. */ public IPackageFragment getPackageFragment() { if (!isEnclosingTypeSelected()) { return fCurrPackage;
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
} else { if (fCurrEnclosingType != null) { return fCurrEnclosingType.getPackageFragment(); } } return null; } /** * Sets the package fragment. * This will update model and the text of the control. * @param canBeModified Selects if the package fragment can be changed by the user */ public void setPackageFragment(IPackageFragment pack, boolean canBeModified) { fCurrPackage= pack; fCanModifyPackage= canBeModified; String str= (pack == null) ? "" : pack.getElementName(); fPackageDialogField.setText(str); updateEnableState(); } /** * Returns the encloding type corresponding to the current input. * @return Returns <code>null</code> if enclosing type is not selected or the input could not * be resolved. */ public IType getEnclosingType() { if (isEnclosingTypeSelected()) { return fCurrEnclosingType; } return null;
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
} /** * Sets the package fragment. * This will update model and the text of the control. * @param canBeModified Selects if the enclosing type can be changed by the user */ public void setEnclosingType(IType type, boolean canBeModified) { fCurrEnclosingType= type; fCanModifyEnclosingType= canBeModified; String str= (type == null) ? "" : JavaModelUtil.getFullyQualifiedName(type); fEnclosingTypeDialogField.setText(str); updateEnableState(); } /** * Returns <code>true</code> if the enclosing type selection check box is enabled. */ public boolean isEnclosingTypeSelected() { return fEnclosingTypeSelection.isSelected(); } /** * Sets the enclosing type selection checkbox. * @param canBeModified Selects if the enclosing type selection can be changed by the user */ public void setEnclosingTypeSelection(boolean isSelected, boolean canBeModified) { fEnclosingTypeSelection.setSelection(isSelected); fEnclosingTypeSelection.setEnabled(canBeModified); updateEnableState(); }
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
/** * Gets the type name. */ public String getTypeName() { return fTypeNameDialogField.getText(); } /** * Sets the type name. * @param canBeModified Selects if the type name can be changed by the user */ public void setTypeName(String name, boolean canBeModified) { fTypeNameDialogField.setText(name); fTypeNameDialogField.setEnabled(canBeModified); } /** * Gets the selected modifiers. * @see Flags */ public int getModifiers() { int mdf= 0; if (fAccMdfButtons.isSelected(PUBLIC_INDEX)) { mdf+= IConstants.AccPublic; } else if (fAccMdfButtons.isSelected(PRIVATE_INDEX)) { mdf+= IConstants.AccPrivate; } else if (fAccMdfButtons.isSelected(PROTECTED_INDEX)) { mdf+= IConstants.AccProtected; } if (fOtherMdfButtons.isSelected(ABSTRACT_INDEX) && (fStaticMdfIndex != 0)) { mdf+= IConstants.AccAbstract;
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
} if (fOtherMdfButtons.isSelected(FINAL_INDEX)) { mdf+= IConstants.AccFinal; } if (fOtherMdfButtons.isSelected(fStaticMdfIndex)) { mdf+= IConstants.AccStatic; } return mdf; } /** * Sets the modifiers. * @param canBeModified Selects if the modifiers can be changed by the user * @see IConstants */ public void setModifiers(int modifiers, boolean canBeModified) { if (Flags.isPublic(modifiers)) { fAccMdfButtons.setSelection(PUBLIC_INDEX, true); } else if (Flags.isPrivate(modifiers)) { fAccMdfButtons.setSelection(PRIVATE_INDEX, true); } else if (Flags.isProtected(modifiers)) { fAccMdfButtons.setSelection(PROTECTED_INDEX, true); } else { fAccMdfButtons.setSelection(DEFAULT_INDEX, true); } if (Flags.isAbstract(modifiers)) { fOtherMdfButtons.setSelection(ABSTRACT_INDEX, true); } if (Flags.isFinal(modifiers)) { fOtherMdfButtons.setSelection(FINAL_INDEX, true); }
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
if (Flags.isStatic(modifiers)) { fOtherMdfButtons.setSelection(fStaticMdfIndex, true); } fAccMdfButtons.setEnabled(canBeModified); fOtherMdfButtons.setEnabled(canBeModified); } /** * Gets the content of the super class text field. */ public String getSuperClass() { return fSuperClassDialogField.getText(); } /** * Sets the super class name. * @param canBeModified Selects if the super class can be changed by the user */ public void setSuperClass(String name, boolean canBeModified) { fSuperClassDialogField.setText(name); fSuperClassDialogField.setEnabled(canBeModified); } /** * Gets the currently chosen super interfaces. * @return returns a list of String */ public List getSuperInterfaces() { return fSuperInterfacesDialogField.getElements(); }
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
/** * Sets the super interfaces. * @param interfacesNames a list of String */ public void setSuperInterfaces(List interfacesNames, boolean canBeModified) { fSuperInterfacesDialogField.setElements(interfacesNames); fSuperInterfacesDialogField.setEnabled(canBeModified); } /** * Called when the package field has changed. * The method validates the package name and returns the status of the validation * This also updates the package fragment model. * Can be extended to add more validation */ protected IStatus packageChanged() { StatusInfo status= new StatusInfo(); fPackageDialogField.enableButton(getPackageFragmentRoot() != null); String packName= getPackageText(); if (packName.length() > 0) { IStatus val= JavaConventions.validatePackageName(packName); if (val.getSeverity() == IStatus.ERROR) { status.setError(NewWizardMessages.getFormattedString("TypePage.error.InvalidPackageName", val.getMessage())); return status; } else if (val.getSeverity() == IStatus.WARNING) { status.setWarning(NewWizardMessages.getFormattedString("TypePage.warning.DiscouragedPackageName", val.getMessage()));
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
} } IPackageFragmentRoot root= getPackageFragmentRoot(); if (root != null) { IPackageFragment pack= root.getPackageFragment(packName); try { IPath rootPath= root.getPath(); IPath outputPath= root.getJavaProject().getOutputLocation(); if (rootPath.isPrefixOf(outputPath) && !rootPath.equals(outputPath)) { IPath packagePath= pack.getUnderlyingResource().getFullPath(); if (outputPath.isPrefixOf(packagePath)) { status.setError(NewWizardMessages.getString("TypePage.error.ClashOutputLocation")); return status; } } } catch (JavaModelException e) { JavaPlugin.log(e.getStatus()); } fCurrPackage= pack; } else { status.setError(""); } return status; } /*
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
* Updates the 'default' label next to the package field. */ private void updatePackageStatusLabel() { String packName= fPackageDialogField.getText(); if (packName.length() == 0) { fPackageDialogField.setStatus(NewWizardMessages.getString("TypePage.default")); } else { fPackageDialogField.setStatus(""); } } /* * Updates the enable state of buttons related to the enclosing type selection checkbox. */ private void updateEnableState() { boolean enclosing= isEnclosingTypeSelected(); fPackageDialogField.setEnabled(fCanModifyPackage && !enclosing); fEnclosingTypeDialogField.setEnabled(fCanModifyEnclosingType && enclosing); } /** * Called when the enclosing type name has changed. * The method validates the enclosing type and returns the status of the validation * This also updates the enclosing type model. * Can be extended to add more validation */ protected IStatus enclosingTypeChanged() { StatusInfo status= new StatusInfo(); fCurrEnclosingType= null;
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
IPackageFragmentRoot root= getPackageFragmentRoot(); fEnclosingTypeDialogField.enableButton(root != null); if (root == null) { status.setError(""); return status; } String enclName= getEnclosingTypeText(); if (enclName.length() == 0) { status.setError(NewWizardMessages.getString("TypePage.error.EnclosingTypeEnterName")); return status; } try { IType type= JavaModelUtil.findType(root.getJavaProject(), enclName); if (type == null) { status.setError(NewWizardMessages.getString("TypePage.error.EnclosingTypeNotExists")); return status; } if (type.getCompilationUnit() == null) { status.setError(NewWizardMessages.getString("TypePage.error.EnclosingNotInCU")); return status; } fCurrEnclosingType= type; return status; } catch (JavaModelException e) { status.setError(NewWizardMessages.getString("TypePage.error.EnclosingTypeNotExists")); JavaPlugin.log(e.getStatus()); return status; }
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
} /** * Called when the type name has changed. * The method validates the type name and returns the status of the validation. * Can be extended to add more validation */ protected IStatus typeNameChanged() { StatusInfo status= new StatusInfo(); String typeName= getTypeName(); if (typeName.length() == 0) { status.setError(NewWizardMessages.getString("TypePage.error.EnterTypeName")); return status; } if (typeName.indexOf('.') != -1) { status.setError(NewWizardMessages.getString("TypePage.error.QualifiedName")); return status; } IStatus val= JavaConventions.validateJavaTypeName(typeName); if (val.getSeverity() == IStatus.ERROR) { status.setError(NewWizardMessages.getFormattedString("TypePage.error.InvalidTypeName", val.getMessage())); return status; } else if (val.getSeverity() == IStatus.WARNING) { status.setWarning(NewWizardMessages.getFormattedString("TypePage.warning.TypeNameDiscouraged", val.getMessage())); } if (!isEnclosingTypeSelected()) { IPackageFragment pack= getPackageFragment();
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
if (pack != null) { ICompilationUnit cu= pack.getCompilationUnit(typeName + ".java"); if (cu.exists()) { status.setError(NewWizardMessages.getString("TypePage.error.TypeNameExists")); return status; } } } else { IType type= getEnclosingType(); if (type != null) { IType member= type.getType(typeName); if (member.exists()) { status.setError(NewWizardMessages.getString("TypePage.error.TypeNameExists")); return status; } } } return status; } /** * Called when the superclass name has changed. * The method validates the superclass name and returns the status of the validation. * Can be extended to add more validation */ protected IStatus superClassChanged() { StatusInfo status= new StatusInfo(); IPackageFragmentRoot root= getPackageFragmentRoot(); fSuperClassDialogField.enableButton(root != null);
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
fSuperClass= null; String sclassName= getSuperClass(); if (sclassName.length() == 0) { return status; } IStatus val= JavaConventions.validateJavaTypeName(sclassName); if (!val.isOK()) { status.setError(NewWizardMessages.getString("TypePage.error.InvalidSuperClassName")); return status; } if (root != null) { try { IType type= resolveSuperTypeName(root.getJavaProject(), sclassName); if (type == null) { status.setWarning(NewWizardMessages.getString("TypePage.warning.SuperClassNotExists")); return status; } else { if (type.isInterface()) { status.setWarning(NewWizardMessages.getFormattedString("TypePage.warning.SuperClassIsNotClass", sclassName)); return status; } int flags= type.getFlags(); if (Flags.isFinal(flags)) { status.setWarning(NewWizardMessages.getFormattedString("TypePage.warning.SuperClassIsFinal", sclassName)); return status; } else if (!JavaModelUtil.isVisible(type, getPackageFragment())) { status.setWarning(NewWizardMessages.getFormattedString("TypePage.warning.SuperClassIsNotVisible", sclassName));
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
return status; } } fSuperClass= type; } catch (JavaModelException e) { status.setError(NewWizardMessages.getString("TypePage.error.InvalidSuperClassName")); JavaPlugin.log(e.getStatus()); } } else { status.setError(""); } return status; } private IType resolveSuperTypeName(IJavaProject jproject, String sclassName) throws JavaModelException { IType type= null; if (isEnclosingTypeSelected()) { IType enclosingType= getEnclosingType(); if (enclosingType != null) { String[][] res= enclosingType.resolveType(sclassName); if (res != null && res.length > 0) { type= JavaModelUtil.findType(jproject, res[0][0], res[0][1]); } } } else { IPackageFragment currPack= getPackageFragment(); if (type == null && currPack != null) { String packName= currPack.getElementName();
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
if (!currPack.isDefaultPackage()) { type= JavaModelUtil.findType(jproject, packName, sclassName); } if (type == null && !"java.lang".equals(packName)) { type= JavaModelUtil.findType(jproject, "java.lang", sclassName); } } if (type == null) { type= JavaModelUtil.findType(jproject, sclassName); } } return type; } /** * Called when the list of super interface has changed. * The method validates the superinterfaces and returns the status of the validation. * Can be extended to add more validation. */ protected IStatus superInterfacesChanged() { StatusInfo status= new StatusInfo(); IPackageFragmentRoot root= getPackageFragmentRoot(); fSuperInterfacesDialogField.enableButton(0, root != null); if (root != null) { List elements= fSuperInterfacesDialogField.getElements();
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
int nElements= elements.size(); for (int i= 0; i < nElements; i++) { String intfname= (String)elements.get(i); try { IType type= JavaModelUtil.findType(root.getJavaProject(), intfname); if (type == null) { status.setWarning(NewWizardMessages.getFormattedString("TypePage.warning.InterfaceNotExists", intfname)); return status; } else { if (type.isClass()) { status.setWarning(NewWizardMessages.getFormattedString("TypePage.warning.InterfaceIsNotInterface", intfname)); return status; } if (!JavaModelUtil.isVisible(type, getPackageFragment())) { status.setWarning(NewWizardMessages.getFormattedString("TypePage.warning.InterfaceIsNotVisible", intfname)); return status; } } } catch (JavaModelException e) { JavaPlugin.log(e.getStatus()); } } } return status; } /** * Called when the modifiers have changed. * The method validates the modifiers and returns the status of the validation. * Can be extended to add more validation.
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
*/ protected IStatus modifiersChanged() { StatusInfo status= new StatusInfo(); int modifiers= getModifiers(); if (Flags.isFinal(modifiers) && Flags.isAbstract(modifiers)) { status.setError(NewWizardMessages.getString("TypePage.error.ModifiersFinalAndAbstract")); } return status; } private IPackageFragment choosePackage() { IPackageFragmentRoot froot= getPackageFragmentRoot(); IJavaElement[] packages= null; try { if (froot != null) { packages= froot.getChildren(); } } catch (JavaModelException e) { } if (packages == null) { packages= new IJavaElement[0]; } ElementListSelectionDialog dialog= new ElementListSelectionDialog(getShell(), new JavaElementLabelProvider(JavaElementLabelProvider.SHOW_DEFAULT)); dialog.setIgnoreCase(false); dialog.setTitle(NewWizardMessages.getString("TypePage.ChoosePackageDialog.title")); dialog.setMessage(NewWizardMessages.getString("TypePage.ChoosePackageDialog.description"));
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
dialog.setEmptyListMessage(NewWizardMessages.getString("TypePage.ChoosePackageDialog.empty")); dialog.setElements(packages); if (fCurrPackage != null) { dialog.setInitialSelections(new Object[] { fCurrPackage }); } if (dialog.open() == dialog.OK) { return (IPackageFragment) dialog.getFirstResult(); } return null; } private IType chooseEnclosingType() { IPackageFragmentRoot root= getPackageFragmentRoot(); if (root == null) { return null; } IJavaElement[] elements= new IJavaElement[] { root.getJavaProject() }; IJavaSearchScope scope= SearchEngine.createJavaSearchScope(elements); TypeSelectionDialog dialog= new TypeSelectionDialog(getShell(), getWizard().getContainer(), scope, IJavaElementSearchConstants.CONSIDER_TYPES); dialog.setTitle(NewWizardMessages.getString("TypePage.ChooseEnclosingTypeDialog.title")); dialog.setMessage(NewWizardMessages.getString("TypePage.ChooseEnclosingTypeDialog.description")); if (fCurrEnclosingType != null) { dialog.setInitialSelections(new Object[] { fCurrEnclosingType }); dialog.setFilter(fCurrEnclosingType.getElementName().substring(0, 1)); } if (dialog.open() == dialog.OK) { return (IType) dialog.getFirstResult(); }
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
return null; } private IType chooseSuperType() { IPackageFragmentRoot root= getPackageFragmentRoot(); if (root == null) { return null; } IJavaElement[] elements= new IJavaElement[] { root.getJavaProject() }; IJavaSearchScope scope= SearchEngine.createJavaSearchScope(elements); TypeSelectionDialog dialog= new TypeSelectionDialog(getShell(), getWizard().getContainer(), scope, IJavaElementSearchConstants.CONSIDER_CLASSES); dialog.setTitle(NewWizardMessages.getString("TypePage.SuperClassDialog.title")); dialog.setMessage(NewWizardMessages.getString("TypePage.SuperClassDialog.message")); if (fSuperClass != null) { dialog.setFilter(fSuperClass.getElementName()); } if (dialog.open() == dialog.OK) { return (IType) dialog.getFirstResult(); } return null; } private void chooseSuperInterfaces() { IPackageFragmentRoot root= getPackageFragmentRoot(); if (root == null) { return; } IJavaProject project= root.getJavaProject(); SuperInterfaceSelectionDialog dialog= new SuperInterfaceSelectionDialog(getShell(), getWizard().getContainer(), fSuperInterfacesDialogField, project); dialog.setTitle(NewWizardMessages.getString("TypePage.InterfacesDialog.title"));
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
dialog.setMessage(NewWizardMessages.getString("TypePage.InterfacesDialog.message")); dialog.open(); return; } /** * Creates a type using the current field values. */ public void createType(IProgressMonitor monitor) throws CoreException, InterruptedException { monitor.beginTask(NewWizardMessages.getString("TypePage.operationdesc"), 10); IPackageFragmentRoot root= getPackageFragmentRoot(); IPackageFragment pack= getPackageFragment(); if (pack == null) { pack= root.getPackageFragment(""); } if (!pack.exists()) { String packName= pack.getElementName(); pack= root.createPackageFragment(packName, true, null); } monitor.worked(1); String clName= fTypeNameDialogField.getText(); boolean isInnerClass= isEnclosingTypeSelected();
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
IType createdType; ImportsStructure imports; int indent= 0; String[] prefOrder= ImportOrganizePreferencePage.getImportOrderPreference(); int threshold= ImportOrganizePreferencePage.getImportNumberThreshold(); String lineDelimiter= null; if (!isInnerClass) { ICompilationUnit parentCU= pack.getCompilationUnit(clName + ".java"); imports= new ImportsStructure(parentCU, prefOrder, threshold, false); lineDelimiter= StubUtility.getLineDelimiterUsed(parentCU); String content= createTypeBody(imports, lineDelimiter); createdType= parentCU.createType(content, null, false, new SubProgressMonitor(monitor, 5)); String fileComment= getFileComment(); if (fileComment != null) { parentCU.getBuffer().replace(0, 0, fileComment + lineDelimiter); } } else { IType enclosingType= getEnclosingType(); IType workingCopy= (IType) EditorUtility.getWorkingCopy(enclosingType); if (workingCopy != null) { enclosingType= workingCopy; } ICompilationUnit parentCU= enclosingType.getCompilationUnit();
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
imports= new ImportsStructure(parentCU, prefOrder, threshold, true); lineDelimiter= StubUtility.getLineDelimiterUsed(enclosingType); String content= createTypeBody(imports, lineDelimiter); IJavaElement[] elems= enclosingType.getChildren(); IJavaElement sibling= elems.length > 0 ? elems[0] : null; createdType= enclosingType.createType(content, sibling, false, new SubProgressMonitor(monitor, 1)); indent= StubUtility.getIndentUsed(enclosingType) + 1; } imports.create(!isInnerClass, new SubProgressMonitor(monitor, 1)); String[] methods= evalMethods(createdType, imports, new SubProgressMonitor(monitor, 1)); if (methods.length > 0) { for (int i= 0; i < methods.length; i++) { createdType.createMethod(methods[i], null, false, null); } imports.create(!isInnerClass, null); } monitor.worked(1); ICompilationUnit cu= createdType.getCompilationUnit(); ISourceRange range; if (isInnerClass) { synchronized(cu) { cu.reconcile();
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
} range= createdType.getSourceRange(); } else { range= cu.getSourceRange(); } IBuffer buf= cu.getBuffer(); String originalContent= buf.getText(range.getOffset(), range.getLength()); String formattedContent= StubUtility.codeFormat(originalContent, indent, lineDelimiter); buf.replace(range.getOffset(), range.getLength(), formattedContent); if (!isInnerClass) { buf.save(new SubProgressMonitor(monitor, 1), false); } else { monitor.worked(1); } fCreatedType= createdType; monitor.done(); } /** * Returns the created type. Only valid after createType has been invoked */ public IType getCreatedType() { return fCreatedType; } private void writeSuperClass(StringBuffer buf, IImportsStructure imports) { String typename= getSuperClass(); if (fIsClass && typename.length() > 0 && !"java.lang.Object".equals(typename)) {
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
buf.append(" extends "); buf.append(Signature.getSimpleName(typename)); if (fSuperClass != null) { imports.addImport(JavaModelUtil.getFullyQualifiedName(fSuperClass)); } else { imports.addImport(typename); } } } private void writeSuperInterfaces(StringBuffer buf, IImportsStructure imports) { List interfaces= getSuperInterfaces(); int last= interfaces.size() - 1; if (last >= 0) { if (fIsClass) { buf.append(" implements "); } else { buf.append(" extends "); } for (int i= 0; i <= last; i++) { String typename= (String) interfaces.get(i); imports.addImport(typename); buf.append(Signature.getSimpleName(typename)); if (i < last) { buf.append(", "); } } } } /*
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
* Called from createType to construct the source for this type */ private String createTypeBody(IImportsStructure imports, String lineDelimiter) { StringBuffer buf= new StringBuffer(); String typeComment= getTypeComment(); if (typeComment != null) { buf.append(typeComment); buf.append(lineDelimiter); } int modifiers= getModifiers(); buf.append(Flags.toString(modifiers)); if (modifiers != 0) { buf.append(' '); } buf.append(fIsClass ? "class " : "interface "); buf.append(getTypeName()); writeSuperClass(buf, imports); writeSuperInterfaces(buf, imports); buf.append(" {"); buf.append(lineDelimiter); buf.append(lineDelimiter); buf.append('}'); buf.append(lineDelimiter); return buf.toString(); } /** * Called from createType to allow adding methods for the newly created type * Returns array of sources of the methods that have to be added * @param parent The type where the methods will be added to
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
*/ protected String[] evalMethods(IType parent, IImportsStructure imports, IProgressMonitor monitor) throws CoreException { return new String[0]; } /** * Called from createType to get a file comment. By default the content of template * 'filecomment' is taken. * Returns source or null, if no file comment should be added */ protected String getFileComment() { if (CodeGenerationPreferencePage.doFileComments()) { return getTemplate("filecomment"); } return null; } /** * Called from createType to get a type comment. * Returns source or null, if no type comment should be added */ protected String getTypeComment() { if (CodeGenerationPreferencePage.doCreateComments()) { return getTemplate("typecomment"); } return null; } protected String getTemplate(String name) { Template[] templates= Templates.getInstance().getTemplates();
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
for (int i= 0; i < templates.length; i++) { if (name.equals(templates[i].getName())) { return templates[i].getPattern(); } } return null; } /** * Creates the bodies of all unimplemented methods or/and all constructors * Can be used by implementors of TypePage to add method stub checkboxes */ protected String[] constructInheritedMethods(IType type, boolean doConstructors, boolean doUnimplementedMethods, IImportsStructure imports, IProgressMonitor monitor) throws CoreException { List newMethods= new ArrayList(); ITypeHierarchy hierarchy= type.newSupertypeHierarchy(monitor); CodeGenerationSettings settings= JavaPreferencesSettings.getCodeGenerationSettings(); if (doConstructors) { IType superclass= hierarchy.getSuperclass(type); if (superclass != null) { String[] constructors= StubUtility.evalConstructors(type, superclass, settings, imports); if (constructors != null) { for (int i= 0; i < constructors.length; i++) { newMethods.add(constructors[i]); } } } } if (doUnimplementedMethods) { String[] unimplemented= StubUtility.evalUnimplementedMethods(type, hierarchy, false, settings, null, imports);
6,891
Bug 6891 Enclosing type checkbox doesn't appear in tab order in new class wizard
Build 20011211 In the new class wizard, the checkbox for enclosing type doesn't appear in the tab order. The JDT code doesn't seem to be doing any magic.
resolved fixed
24434b7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2001-12-17T14:53:03Z
2001-12-13T13:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/TypePage.java
if (unimplemented != null) { for (int i= 0; i < unimplemented.length; i++) { newMethods.add(unimplemented[i]); } } } return (String[]) newMethods.toArray(new String[newMethods.size()]); } /** * @see NewElementWizardPage#getRunnable */ public IRunnableWithProgress getRunnable() { return new IRunnableWithProgress() { public void run(IProgressMonitor monitor) throws InvocationTargetException, InterruptedException { try { if (monitor == null) { monitor= new NullProgressMonitor(); } createType(monitor); } catch (CoreException e) { throw new InvocationTargetException(e); } } }; } }