issue_id
int64
2.04k
425k
title
stringlengths
9
251
body
stringlengths
4
32.8k
status
stringclasses
6 values
after_fix_sha
stringlengths
7
7
project_name
stringclasses
6 values
repo_url
stringclasses
6 values
repo_name
stringclasses
6 values
language
stringclasses
1 value
issue_url
null
before_fix_sha
null
pull_url
null
commit_datetime
timestamp[us, tz=UTC]
report_datetime
timestamp[us, tz=UTC]
updated_file
stringlengths
23
187
chunk_content
stringlengths
1
22k
8,604
Bug 8604 J Search opens type selection dialog if code resolve has > 1 result
null
resolved fixed
7c11c22
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-28T18:26:40Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java
} JavaSearchResultCollector collector= new JavaSearchResultCollector(); JavaSearchOperation op= null; if (data.javaElement != null && getPattern().equals(fInitialData.pattern)) op= new JavaSearchOperation(workspace, data.javaElement, data.limitTo, scope, scopeDescription, collector); else { data.javaElement= null; op= new JavaSearchOperation(workspace, data.pattern, data.isCaseSensitive, data.searchFor, data.limitTo, scope, scopeDescription, collector); } Shell shell= getControl().getShell(); try { getContainer().getRunnableContext().run(true, true, op); } catch (InvocationTargetException ex) { ExceptionHandler.handle(ex, shell, SearchMessages.getString("Search.Error.search.title"), SearchMessages.getString("Search.Error.search.message")); return false; } catch (InterruptedException ex) { return false; } return true; } private int getLimitTo() { for (int i= 0; i < fLimitTo.length; i++) { if (fLimitTo[i].getSelection()) return i; } return -1; } private void setLimitTo(int searchFor) {
8,604
Bug 8604 J Search opens type selection dialog if code resolve has > 1 result
null
resolved fixed
7c11c22
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-28T18:26:40Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java
fLimitTo[DECLARATIONS].setEnabled(true); fLimitTo[IMPLEMENTORS].setEnabled(false); fLimitTo[REFERENCES].setEnabled(true); fLimitTo[ALL_OCCURRENCES].setEnabled(true); fLimitTo[READ_ACCESSES].setEnabled(false); fLimitTo[WRITE_ACCESSES].setEnabled(false); if (!(searchFor == TYPE || searchFor == INTERFACE) && fLimitTo[IMPLEMENTORS].getSelection()) { fLimitTo[IMPLEMENTORS].setSelection(false); fLimitTo[REFERENCES].setSelection(true); } if (!(searchFor == FIELD) && (getLimitTo() == READ_ACCESSES || getLimitTo() == WRITE_ACCESSES)) { fLimitTo[getLimitTo()].setSelection(false); fLimitTo[REFERENCES].setSelection(true); } switch (searchFor) { case TYPE | INTERFACE: fLimitTo[IMPLEMENTORS].setEnabled(true); case FIELD: fLimitTo[READ_ACCESSES].setEnabled(true); fLimitTo[WRITE_ACCESSES].setEnabled(true); break; default : break; } } private String[] getPreviousSearchPatterns() { int patternCount= fgPreviousSearchPatterns.size(); String [] patterns= new String[patternCount];
8,604
Bug 8604 J Search opens type selection dialog if code resolve has > 1 result
null
resolved fixed
7c11c22
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-28T18:26:40Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java
for (int i= 0; i < patternCount; i++) patterns[i]= ((SearchPatternData) fgPreviousSearchPatterns.get(patternCount - 1 - i)).pattern; return patterns; } private int getSearchFor() { for (int i= 0; i < fSearchFor.length; i++) { if (fSearchFor[i].getSelection()) return i; } Assert.isTrue(false, "shouldNeverHappen"); return -1; } private String getPattern() { return fPattern.getText(); } /** * Return search pattern data and update previous searches. * An existing entry will be updated. */ private SearchPatternData getPatternData() { String pattern= getPattern(); SearchPatternData match= null; int i= 0; int size= fgPreviousSearchPatterns.size(); while (match == null && i < size) { match= (SearchPatternData) fgPreviousSearchPatterns.get(i); i++; if (!pattern.equals(match.pattern))
8,604
Bug 8604 J Search opens type selection dialog if code resolve has > 1 result
null
resolved fixed
7c11c22
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-28T18:26:40Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java
match= null; }; if (match == null) { match= new SearchPatternData( getSearchFor(), getLimitTo(), pattern, fCaseSensitive.getSelection(), fJavaElement, getContainer().getSelectedScope(), getContainer().getSelectedWorkingSet()); fgPreviousSearchPatterns.add(match); } else { match.searchFor= getSearchFor(); match.limitTo= getLimitTo(); match.isCaseSensitive= fCaseSensitive.getSelection(); match.javaElement= fJavaElement; match.scope= getContainer().getSelectedScope(); match.workingSet= getContainer().getSelectedWorkingSet(); }; return match; } /* * Implements method from IDialogPage */ public void setVisible(boolean visible) { if (visible && fPattern != null) { if (fFirstTime) { fFirstTime= false;
8,604
Bug 8604 J Search opens type selection dialog if code resolve has > 1 result
null
resolved fixed
7c11c22
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-28T18:26:40Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java
fPattern.setItems(getPreviousSearchPatterns()); initSelections(); } fPattern.setFocus(); getContainer().setPerformActionEnabled(fPattern.getText().length() > 0 && getContainer().hasValidScope()); } super.setVisible(visible); } public boolean isValid() { return true; } /** * Creates the page's content. */ public void createControl(Composite parent) { readConfiguration(); GridData gd; Composite result= new Composite(parent, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 2; layout.makeColumnsEqualWidth= true; layout.horizontalSpacing= 10; result.setLayout(layout); RowLayouter layouter= new RowLayouter(layout.numColumns); gd= new GridData(); gd.horizontalAlignment= gd.FILL;
8,604
Bug 8604 J Search opens type selection dialog if code resolve has > 1 result
null
resolved fixed
7c11c22
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-28T18:26:40Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java
layouter.setDefaultGridData(gd, 0); layouter.setDefaultGridData(gd, 1); layouter.setDefaultSpan(); layouter.perform(createExpression(result)); layouter.perform(createSearchFor(result), createLimitTo(result), -1); SelectionAdapter javaElementInitializer= new SelectionAdapter() { public void widgetSelected(SelectionEvent event) { if (getSearchFor() == fInitialData.searchFor) fJavaElement= fInitialData.javaElement; else fJavaElement= null; setLimitTo(getSearchFor()); updateCaseSensitiveCheckbox(); } }; fSearchFor[TYPE].addSelectionListener(javaElementInitializer); fSearchFor[METHOD].addSelectionListener(javaElementInitializer); fSearchFor[FIELD].addSelectionListener(javaElementInitializer); fSearchFor[CONSTRUCTOR].addSelectionListener(javaElementInitializer); fSearchFor[PACKAGE].addSelectionListener(javaElementInitializer); setControl(result); WorkbenchHelp.setHelp(result, new Object[] { IJavaHelpContextIds.JAVA_SEARCH_PAGE }); } private Control createExpression(Composite parent) { Group result= new Group(parent, SWT.NONE); result.setText(SearchMessages.getString("SearchPage.expression.label")); GridLayout layout= new GridLayout();
8,604
Bug 8604 J Search opens type selection dialog if code resolve has > 1 result
null
resolved fixed
7c11c22
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-28T18:26:40Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java
layout.numColumns= 2; result.setLayout(layout); fPattern= new Combo(result, SWT.SINGLE | SWT.BORDER); fPattern.addSelectionListener(new SelectionAdapter() { public void widgetSelected(SelectionEvent e) { handlePatternSelected(); } }); fPattern.addModifyListener(new ModifyListener() { public void modifyText(ModifyEvent e) { getContainer().setPerformActionEnabled(getPattern().length() > 0 && getContainer().hasValidScope()); updateCaseSensitiveCheckbox(); } }); GridData gd= new GridData(GridData.FILL_HORIZONTAL); gd.widthHint= convertWidthInCharsToPixels(30); gd.horizontalSpan= 2; fPattern.setLayoutData(gd); Label label= new Label(result, SWT.LEFT); label.setText(SearchMessages.getString("SearchPage.expression.pattern")); fCaseSensitive= new Button(result, SWT.CHECK); fCaseSensitive.setText(SearchMessages.getString("SearchPage.expression.caseSensitive")); gd= new GridData(); gd.horizontalAlignment= gd.END; fCaseSensitive.setLayoutData(gd); fCaseSensitive.addSelectionListener(new SelectionAdapter() {
8,604
Bug 8604 J Search opens type selection dialog if code resolve has > 1 result
null
resolved fixed
7c11c22
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-28T18:26:40Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java
public void widgetSelected(SelectionEvent e) { fIsCaseSensitive= fCaseSensitive.getSelection(); writeConfiguration(); } }); return result; } private void updateCaseSensitiveCheckbox() { if (fInitialData != null && getPattern().equals(fInitialData.pattern) && fJavaElement != null) { fCaseSensitive.setEnabled(false); fCaseSensitive.setSelection(true); } else { fCaseSensitive.setEnabled(true); fCaseSensitive.setSelection(fIsCaseSensitive); } } private void handlePatternSelected() { if (fPattern.getSelectionIndex() < 0) return; int index= fgPreviousSearchPatterns.size() - 1 - fPattern.getSelectionIndex(); fInitialData= (SearchPatternData) fgPreviousSearchPatterns.get(index); for (int i= 0; i < fSearchFor.length; i++) fSearchFor[i].setSelection(false); for (int i= 0; i < fLimitTo.length; i++) fLimitTo[i].setSelection(false); fSearchFor[fInitialData.searchFor].setSelection(true); setLimitTo(fInitialData.searchFor); fLimitTo[fInitialData.limitTo].setSelection(true);
8,604
Bug 8604 J Search opens type selection dialog if code resolve has > 1 result
null
resolved fixed
7c11c22
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-28T18:26:40Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java
fPattern.setText(fInitialData.pattern); fIsCaseSensitive= fInitialData.isCaseSensitive; fJavaElement= fInitialData.javaElement; fCaseSensitive.setEnabled(fJavaElement == null); fCaseSensitive.setSelection(fInitialData.isCaseSensitive); if (fInitialData.workingSet != null) getContainer().setSelectedWorkingSet(fInitialData.workingSet); else getContainer().setSelectedScope(fInitialData.scope); } private Control createSearchFor(Composite parent) { Group result= new Group(parent, SWT.NONE); result.setText(SearchMessages.getString("SearchPage.searchFor.label")); GridLayout layout= new GridLayout(); layout.numColumns= 3; result.setLayout(layout); result.setLayoutData(new GridData(GridData.FILL_VERTICAL)); fSearchFor= new Button[fSearchForText.length]; for (int i= 0; i < fSearchForText.length; i++) { Button button= new Button(result, SWT.RADIO); button.setText(fSearchForText[i]); fSearchFor[i]= button; } return result; } private Control createLimitTo(Composite parent) { Group result= new Group(parent, SWT.NONE); result.setText(SearchMessages.getString("SearchPage.limitTo.label"));
8,604
Bug 8604 J Search opens type selection dialog if code resolve has > 1 result
null
resolved fixed
7c11c22
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-28T18:26:40Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java
GridLayout layout= new GridLayout(); layout.numColumns= 2; result.setLayout(layout); fLimitTo= new Button[fLimitToText.length]; for (int i= 0; i < fLimitToText.length; i++) { Button button= new Button(result, SWT.RADIO); button.setText(fLimitToText[i]); fLimitTo[i]= button; } return result; } private void initSelections() { ISelection selection= getSelection(); fInitialData= null; fInitialData= tryTypedTextSelection(selection); if (fInitialData == null) fInitialData= trySelection(selection); if (fInitialData == null) fInitialData= trySimpleTextSelection(selection); if (fInitialData == null) fInitialData= getDefaultInitValues(); fJavaElement= fInitialData.javaElement; fCaseSensitive.setSelection(fInitialData.isCaseSensitive); fCaseSensitive.setEnabled(fInitialData.javaElement == null); fSearchFor[fInitialData.searchFor].setSelection(true); setLimitTo(fInitialData.searchFor); fLimitTo[fInitialData.limitTo].setSelection(true); fPattern.setText(fInitialData.pattern); }
8,604
Bug 8604 J Search opens type selection dialog if code resolve has > 1 result
null
resolved fixed
7c11c22
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-28T18:26:40Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java
private SearchPatternData tryTypedTextSelection(ISelection selection) { if (selection instanceof ITextSelection) { IEditorPart e= getEditorPart(); if (e != null) { ITextSelection ts= (ITextSelection)selection; ICodeAssist assist= getCodeAssist(e); if (assist != null) { IJavaElement[] elements= null; try { elements= assist.codeSelect(ts.getOffset(), ts.getLength()); } catch (JavaModelException ex) { ExceptionHandler.handle(ex, SearchMessages.getString("Search.Error.createJavaElement.title"), SearchMessages.getString("Search.Error.createJavaElement.message")); } if (elements != null && elements.length > 0) { IJavaElement javaElement; if (elements.length == 1) javaElement= elements[0]; else javaElement= chooseFromList(elements); if (javaElement != null) return determineInitValuesFrom(javaElement); } } } } return null; } private ICodeAssist getCodeAssist(IEditorPart editorPart) { IEditorInput input= editorPart.getEditorInput();
8,604
Bug 8604 J Search opens type selection dialog if code resolve has > 1 result
null
resolved fixed
7c11c22
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-28T18:26:40Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java
if (input instanceof IClassFileEditorInput) return ((IClassFileEditorInput)input).getClassFile(); IWorkingCopyManager manager= JavaPlugin.getDefault().getWorkingCopyManager(); return manager.getWorkingCopy(input); } private SearchPatternData trySelection(ISelection selection) { SearchPatternData result= null; if (selection == null) return result; Object o= null; if (selection instanceof IStructuredSelection) o= ((IStructuredSelection)selection).getFirstElement(); if (o instanceof IJavaElement) { result= determineInitValuesFrom((IJavaElement)o); } else if (o instanceof ISearchResultViewEntry) { IJavaElement element= getJavaElement(((ISearchResultViewEntry)o).getSelectedMarker()); result= determineInitValuesFrom(element); } else if (o instanceof IAdaptable) { IJavaElement element= (IJavaElement)((IAdaptable)o).getAdapter(IJavaElement.class); if (element != null) { result= determineInitValuesFrom(element); } else { IWorkbenchAdapter adapter= (IWorkbenchAdapter)((IAdaptable)o).getAdapter(IWorkbenchAdapter.class); result= new SearchPatternData(TYPE, REFERENCES, adapter.getLabel(o), null); } } return result; } private IJavaElement getJavaElement(IMarker marker) { try {
8,604
Bug 8604 J Search opens type selection dialog if code resolve has > 1 result
null
resolved fixed
7c11c22
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-28T18:26:40Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java
return JavaCore.create((String)marker.getAttribute(IJavaSearchUIConstants.ATT_JE_HANDLE_ID)); } catch (CoreException ex) { ExceptionHandler.handle(ex, SearchMessages.getString("Search.Error.createJavaElement.title"), SearchMessages.getString("Search.Error.createJavaElement.message")); return null; } } private SearchPatternData determineInitValuesFrom(IJavaElement element) { if (element == null) return null; int searchFor= UNKNOWN; int limitTo= UNKNOWN; String pattern= null; switch (element.getElementType()) { case IJavaElement.PACKAGE_FRAGMENT: searchFor= PACKAGE; limitTo= REFERENCES; pattern= element.getElementName(); break; case IJavaElement.PACKAGE_FRAGMENT_ROOT: searchFor= PACKAGE; limitTo= REFERENCES; pattern= element.getElementName(); break; case IJavaElement.PACKAGE_DECLARATION: searchFor= PACKAGE; limitTo= REFERENCES; pattern= element.getElementName(); break; case IJavaElement.IMPORT_DECLARATION:
8,604
Bug 8604 J Search opens type selection dialog if code resolve has > 1 result
null
resolved fixed
7c11c22
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-28T18:26:40Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java
pattern= element.getElementName(); IImportDeclaration declaration= (IImportDeclaration)element; if (declaration.isOnDemand()) { searchFor= PACKAGE; int index= pattern.lastIndexOf('.'); pattern= pattern.substring(0, index); } else { searchFor= TYPE; } limitTo= DECLARATIONS; break; case IJavaElement.TYPE: searchFor= TYPE; limitTo= REFERENCES; pattern= JavaModelUtil.getFullyQualifiedName((IType)element); break; case IJavaElement.COMPILATION_UNIT: ICompilationUnit cu= (ICompilationUnit)element; String mainTypeName= element.getElementName().substring(0, element.getElementName().indexOf(".")); IType mainType= cu.getType(mainTypeName); mainTypeName= JavaModelUtil.getTypeQualifiedName(mainType); try { mainType= JavaModelUtil.findTypeInCompilationUnit(cu, mainTypeName); if (mainType == null) { IType[] types= cu.getTypes(); if (types.length > 0) mainType= types[0]; else break;
8,604
Bug 8604 J Search opens type selection dialog if code resolve has > 1 result
null
resolved fixed
7c11c22
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-28T18:26:40Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java
} } catch (JavaModelException ex) { ExceptionHandler.handle(ex, SearchMessages.getString("Search.Error.javaElementAccess.title"), SearchMessages.getString("Search.Error.javaElementAccess.message")); break; } searchFor= TYPE; element= mainType; limitTo= REFERENCES; pattern= JavaModelUtil.getFullyQualifiedName((IType)mainType); break; case IJavaElement.CLASS_FILE: IClassFile cf= (IClassFile)element; try { mainType= cf.getType(); } catch (JavaModelException ex) { ExceptionHandler.handle(ex, SearchMessages.getString("Search.Error.javaElementAccess.title"), SearchMessages.getString("Search.Error.javaElementAccess.message")); break; } if (mainType == null) break; element= mainType; searchFor= TYPE; limitTo= REFERENCES; pattern= JavaModelUtil.getFullyQualifiedName(mainType); break; case IJavaElement.FIELD: searchFor= FIELD; limitTo= REFERENCES; IType type= ((IField)element).getDeclaringType(); StringBuffer buffer= new StringBuffer();
8,604
Bug 8604 J Search opens type selection dialog if code resolve has > 1 result
null
resolved fixed
7c11c22
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-28T18:26:40Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java
buffer.append(JavaModelUtil.getFullyQualifiedName(type)); buffer.append('.'); buffer.append(element.getElementName()); pattern= buffer.toString(); break; case IJavaElement.METHOD: searchFor= METHOD; try { IMethod method= (IMethod)element; if (method.isConstructor()) searchFor= CONSTRUCTOR; } catch (JavaModelException ex) { ExceptionHandler.handle(ex, SearchMessages.getString("Search.Error.javaElementAccess.title"), SearchMessages.getString("Search.Error.javaElementAccess.message")); break; } limitTo= REFERENCES; pattern= PrettySignature.getMethodSignature((IMethod)element); break; } if (searchFor != UNKNOWN && limitTo != UNKNOWN && pattern != null) return new SearchPatternData(searchFor, limitTo, pattern, element); return null; } private SearchPatternData trySimpleTextSelection(ISelection selection) { SearchPatternData result= null; if (selection instanceof ITextSelection) { BufferedReader reader= new BufferedReader(new StringReader(((ITextSelection)selection).getText())); String text;
8,604
Bug 8604 J Search opens type selection dialog if code resolve has > 1 result
null
resolved fixed
7c11c22
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-28T18:26:40Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java
try { text= reader.readLine(); if (text == null) text= ""; } catch (IOException ex) { text= ""; } result= new SearchPatternData(TYPE, REFERENCES, text, null); } return result; } private SearchPatternData getDefaultInitValues() { return new SearchPatternData(TYPE, REFERENCES, "", null); } private IJavaElement chooseFromList(IJavaElement[] openChoices) { int flags= JavaElementLabelProvider.SHOW_DEFAULT | JavaElementLabelProvider.SHOW_QUALIFIED; ILabelProvider labelProvider= new JavaElementLabelProvider(flags); ElementListSelectionDialog dialog= new ElementListSelectionDialog(getShell(), labelProvider); dialog.setTitle(SearchMessages.getString("SearchElementSelectionDialog.title")); dialog.setMessage(SearchMessages.getString("SearchElementSelectionDialog.message")); dialog.setElements(openChoices); if (dialog.open() == dialog.OK) return (IJavaElement)dialog.getFirstResult(); return null; } /* * Implements method from ISearchPage */ public void setContainer(ISearchPageContainer container) {
8,604
Bug 8604 J Search opens type selection dialog if code resolve has > 1 result
null
resolved fixed
7c11c22
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-28T18:26:40Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java
fContainer= container; } /** * Returns the search page's container. */ private ISearchPageContainer getContainer() { return fContainer; } /** * Returns the current active selection. */ private ISelection getSelection() { return fContainer.getSelection(); } /** * Returns the current active editor part. */ private IEditorPart getEditorPart() { IWorkbenchWindow window= JavaPlugin.getActiveWorkbenchWindow(); if (window != null) { IWorkbenchPage page= window.getActivePage(); if (page != null) return page.getActiveEditor(); } return null; }
8,604
Bug 8604 J Search opens type selection dialog if code resolve has > 1 result
null
resolved fixed
7c11c22
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-28T18:26:40Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchPage.java
/** * Returns the page settings for this Java search page. * * @return the page settings to be used */ private IDialogSettings getDialogSettings() { IDialogSettings settings= JavaPlugin.getDefault().getDialogSettings(); fDialogSettings= settings.getSection(PAGE_NAME); if (fDialogSettings == null) fDialogSettings= settings.addNewSection(PAGE_NAME); return fDialogSettings; } /** * Initializes itself from the stored page settings. */ private void readConfiguration() { IDialogSettings s= getDialogSettings(); fIsCaseSensitive= s.getBoolean(STORE_CASE_SENSITIVE); } /** * Stores it current configuration in the dialog store. */ private void writeConfiguration() { IDialogSettings s= getDialogSettings(); s.put(STORE_CASE_SENSITIVE, fIsCaseSensitive); } }
7,444
Bug 7444 surround try/catch: NPE
i had code like: public static int getTabSize() { return Integer.parseInt(getIntValue((String) JavaCore.getOption().get (PREF_TAB_SIZE), 4)); } and tried to surroung the returned expression. could not reproduce on a smaller test case 4 org.eclipse.ui 0 java.lang.NullPointerException java.lang.NullPointerException at org.eclipse.jdt.internal.corext.refactoring.util.NewSelectionAnalyzer.visit (NewSelectionAnalyzer.java:460) at org.eclipse.jdt.internal.corext.refactoring.util.ASTParentTrackingAdapter.visit (ASTParentTrackingAdapter.java:707) at org.eclipse.jdt.internal.compiler.ast.MessageSend.traverse (MessageSend.java:261) at org.eclipse.jdt.internal.compiler.ast.ReturnStatement.traverse (ReturnStatement.java:235) at org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.traverse (MethodDeclaration.java(Compiled Code)) at org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.traverse (TypeDeclaration.java:851) at org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.traverse (CompilationUnitDeclaration.java:228) at org.eclipse.jdt.internal.corext.refactoring.util.AST.accept (AST.java:70) at org.eclipse.jdt.internal.corext.refactoring.surround.SurroundWithTryCatchRefacto ring.checkActivation(SurroundWithTryCatchRefactoring.java:102) at org.eclipse.jdt.internal.ui.refactoring.actions.SurroundWithTryCatchAction.run (SurroundWithTryCatchAction.java:42) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:798) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:821) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:285) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.Main.main(Main.java:362)
verified fixed
8a58ba8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-29T18:55:46Z
2002-01-10T19:13:20Z
org.eclipse.jdt.ui.tests.refactoring/resources/ExtractMethodWorkSpace/ExtractMethodTests/A.java
class A { void f() { int i= 0; int j= 1; switch (j) { case 1 : i= 1; break; default : i= -1; break; } System.out.println(i); } }
7,444
Bug 7444 surround try/catch: NPE
i had code like: public static int getTabSize() { return Integer.parseInt(getIntValue((String) JavaCore.getOption().get (PREF_TAB_SIZE), 4)); } and tried to surroung the returned expression. could not reproduce on a smaller test case 4 org.eclipse.ui 0 java.lang.NullPointerException java.lang.NullPointerException at org.eclipse.jdt.internal.corext.refactoring.util.NewSelectionAnalyzer.visit (NewSelectionAnalyzer.java:460) at org.eclipse.jdt.internal.corext.refactoring.util.ASTParentTrackingAdapter.visit (ASTParentTrackingAdapter.java:707) at org.eclipse.jdt.internal.compiler.ast.MessageSend.traverse (MessageSend.java:261) at org.eclipse.jdt.internal.compiler.ast.ReturnStatement.traverse (ReturnStatement.java:235) at org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.traverse (MethodDeclaration.java(Compiled Code)) at org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.traverse (TypeDeclaration.java:851) at org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.traverse (CompilationUnitDeclaration.java:228) at org.eclipse.jdt.internal.corext.refactoring.util.AST.accept (AST.java:70) at org.eclipse.jdt.internal.corext.refactoring.surround.SurroundWithTryCatchRefacto ring.checkActivation(SurroundWithTryCatchRefactoring.java:102) at org.eclipse.jdt.internal.ui.refactoring.actions.SurroundWithTryCatchAction.run (SurroundWithTryCatchAction.java:42) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:798) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:821) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:285) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.Main.main(Main.java:362)
verified fixed
8a58ba8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-29T18:55:46Z
2002-01-10T19:13:20Z
org.eclipse.jdt.ui.tests.refactoring/resources/ExtractMethodWorkSpace/ExtractMethodTests/D.java
public class D { public char foo() { return 100; } }
7,444
Bug 7444 surround try/catch: NPE
i had code like: public static int getTabSize() { return Integer.parseInt(getIntValue((String) JavaCore.getOption().get (PREF_TAB_SIZE), 4)); } and tried to surroung the returned expression. could not reproduce on a smaller test case 4 org.eclipse.ui 0 java.lang.NullPointerException java.lang.NullPointerException at org.eclipse.jdt.internal.corext.refactoring.util.NewSelectionAnalyzer.visit (NewSelectionAnalyzer.java:460) at org.eclipse.jdt.internal.corext.refactoring.util.ASTParentTrackingAdapter.visit (ASTParentTrackingAdapter.java:707) at org.eclipse.jdt.internal.compiler.ast.MessageSend.traverse (MessageSend.java:261) at org.eclipse.jdt.internal.compiler.ast.ReturnStatement.traverse (ReturnStatement.java:235) at org.eclipse.jdt.internal.compiler.ast.MethodDeclaration.traverse (MethodDeclaration.java(Compiled Code)) at org.eclipse.jdt.internal.compiler.ast.TypeDeclaration.traverse (TypeDeclaration.java:851) at org.eclipse.jdt.internal.compiler.ast.CompilationUnitDeclaration.traverse (CompilationUnitDeclaration.java:228) at org.eclipse.jdt.internal.corext.refactoring.util.AST.accept (AST.java:70) at org.eclipse.jdt.internal.corext.refactoring.surround.SurroundWithTryCatchRefacto ring.checkActivation(SurroundWithTryCatchRefactoring.java:102) at org.eclipse.jdt.internal.ui.refactoring.actions.SurroundWithTryCatchAction.run (SurroundWithTryCatchAction.java:42) at org.eclipse.jface.action.Action.runWithEvent(Action.java:452) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:798) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:821) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:285) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.Main.main(Main.java:362)
verified fixed
8a58ba8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-29T18:55:46Z
2002-01-10T19:13:20Z
org.eclipse.jdt.ui.tests.refactoring/resources/ExtractMethodWorkSpace/ExtractMethodTests/X.java
class X{ void f(){ int i= 0; int j= 1; switch (j){ case 1: i= 1; default: i--; i= -1; break; } } }
8,068
Bug 8068 search: missing working set names on 'seearch for implementors'
select sth in the editor, open the context menu, go to: search note: in all 5 entires there are names of working sets you defined except for: 'implementors'
verified fixed
e2bf5d7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-29T19:48:22Z
2002-01-23T10:00:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/FindImplementorsInWorkingSetAction.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.search; import org.eclipse.ui.dialogs.SelectionDialog; import org.eclipse.search.ui.IWorkingSet; import org.eclipse.search.ui.SearchUI; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.search.IJavaSearchScope; import org.eclipse.jdt.internal.ui.JavaPlugin; public class FindImplementorsInWorkingSetAction extends FindImplementorsAction {
8,068
Bug 8068 search: missing working set names on 'seearch for implementors'
select sth in the editor, open the context menu, go to: search note: in all 5 entires there are names of working sets you defined except for: 'implementors'
verified fixed
e2bf5d7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-29T19:48:22Z
2002-01-23T10:00:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/FindImplementorsInWorkingSetAction.java
public FindImplementorsInWorkingSetAction() { setText(SearchMessages.getString("Search.FindImplementorsInWorkingSetAction.label")); setToolTipText(SearchMessages.getString("Search.FindImplementorsInWorkingSetAction.tooltip")); } protected JavaSearchOperation makeOperation(IJavaElement element) throws JavaModelException { IWorkingSet workingSet= queryWorkingSet(); if (workingSet == null) return null; updateLRUWorkingSet(workingSet); return new JavaSearchOperation(JavaPlugin.getWorkspace(), element, getLimitTo(), getScope(workingSet), getScopeDescription(workingSet), getCollector()); }; private IJavaSearchScope getScope(IWorkingSet workingSet) throws JavaModelException { return JavaSearchScopeFactory.getInstance().createJavaSearchScope(workingSet); } private String getScopeDescription(IWorkingSet workingSet) { return SearchMessages.getFormattedString("WorkingSetScope", new String[] {workingSet.getName()}); } private IWorkingSet queryWorkingSet() throws JavaModelException { SelectionDialog dialog= SearchUI.createWorkingSetDialog(JavaPlugin.getActiveWorkbenchShell()); if (dialog.open() == dialog.OK) return (IWorkingSet)dialog.getResult()[0]; else return null; } }
8,068
Bug 8068 search: missing working set names on 'seearch for implementors'
select sth in the editor, open the context menu, go to: search note: in all 5 entires there are names of working sets you defined except for: 'implementors'
verified fixed
e2bf5d7
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-29T19:48:22Z
2002-01-23T10:00:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/ImplementorsSearchGroup.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.search; /** * Contribute Java search specific menu elements. */ public class ImplementorsSearchGroup extends JavaSearchSubGroup { public static final String GROUP_NAME= SearchMessages.getString("group.implementors"); protected ElementSearchAction[] getActions() { return new ElementSearchAction[] { new FindImplementorsAction(), new FindImplementorsInWorkingSetAction() }; } protected String getName() { return GROUP_NAME; } }
8,730
Bug 8730 wrong method deleted (packages view)
from the newsgroup: public class TestClass { public void foo(String s) { } public void foo(String[] s) { } public void otherfoo(String s) { } } 2. click right on "foo(String s)" in package view, select "delete" ->foo(String s) vanishes in source view, package view is not updated (bug or feature?) 3. click right on "foo(String[] s)" in package view, select "delete" -> otherfoo(String s) vanishes in source view ------------------------------------------------------ 2 is a feature 3 is a bug
verified fixed
939a7d8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T12:13:20Z
2002-01-30T11:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/reorg/SourceReferenceAction.java
package org.eclipse.jdt.internal.ui.reorg; import java.util.List; import org.eclipse.jface.viewers.ISelectionProvider; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.jdt.core.IClassFile; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IImportContainer; import org.eclipse.jdt.core.IImportDeclaration; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IPackageDeclaration; import org.eclipse.jdt.core.ISourceReference; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.refactoring.reorg.SourceReferenceUtil; import org.eclipse.jdt.internal.corext.refactoring.util.WorkingCopyUtil; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.actions.StructuredSelectionProvider; import org.eclipse.jdt.internal.ui.refactoring.actions.RefactoringAction; class SourceReferenceAction extends RefactoringAction {
8,730
Bug 8730 wrong method deleted (packages view)
from the newsgroup: public class TestClass { public void foo(String s) { } public void foo(String[] s) { } public void otherfoo(String s) { } } 2. click right on "foo(String s)" in package view, select "delete" ->foo(String s) vanishes in source view, package view is not updated (bug or feature?) 3. click right on "foo(String[] s)" in package view, select "delete" -> otherfoo(String s) vanishes in source view ------------------------------------------------------ 2 is a feature 3 is a bug
verified fixed
939a7d8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T12:13:20Z
2002-01-30T11:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/reorg/SourceReferenceAction.java
protected SourceReferenceAction(String name, StructuredSelectionProvider provider) { super(name, provider); } protected SourceReferenceAction(String name, ISelectionProvider provider) { super(name, provider); } /* * @see RefactoringAction#canOperateOn(IStructuredSelection) */ public boolean canOperateOn(IStructuredSelection selection) { try{ if (selection.isEmpty()) return false; Object[] elems= selection.toArray();
8,730
Bug 8730 wrong method deleted (packages view)
from the newsgroup: public class TestClass { public void foo(String s) { } public void foo(String[] s) { } public void otherfoo(String s) { } } 2. click right on "foo(String s)" in package view, select "delete" ->foo(String s) vanishes in source view, package view is not updated (bug or feature?) 3. click right on "foo(String[] s)" in package view, select "delete" -> otherfoo(String s) vanishes in source view ------------------------------------------------------ 2 is a feature 3 is a bug
verified fixed
939a7d8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T12:13:20Z
2002-01-30T11:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/reorg/SourceReferenceAction.java
for (int i= 0; i < elems.length; i++) { Object elem= elems[i]; if (! canWorkOn(elem)) return false; } return true; } catch (JavaModelException e){ JavaPlugin.log(e); return false; } } private static boolean canWorkOn(Object elem) throws JavaModelException{ if (elem == null) return false; if (! (elem instanceof ISourceReference)) return false; if (! (elem instanceof IJavaElement)) return false; if (elem instanceof IClassFile) return false; if (elem instanceof ICompilationUnit) return false; if ((elem instanceof IMember) && ((IMember)elem).isBinary()) return false; if (isDeletedFromEditor((ISourceReference)elem))
8,730
Bug 8730 wrong method deleted (packages view)
from the newsgroup: public class TestClass { public void foo(String s) { } public void foo(String[] s) { } public void otherfoo(String s) { } } 2. click right on "foo(String s)" in package view, select "delete" ->foo(String s) vanishes in source view, package view is not updated (bug or feature?) 3. click right on "foo(String[] s)" in package view, select "delete" -> otherfoo(String s) vanishes in source view ------------------------------------------------------ 2 is a feature 3 is a bug
verified fixed
939a7d8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T12:13:20Z
2002-01-30T11:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/reorg/SourceReferenceAction.java
return false; if (elem instanceof IMember) return true; if (elem instanceof IImportContainer) return true; if (elem instanceof IImportDeclaration) return true; if (elem instanceof IPackageDeclaration) return true; return false; } private static boolean isDeletedFromEditor(ISourceReference elem) throws JavaModelException{ ICompilationUnit cu= SourceReferenceUtil.getCompilationUnit(elem); ICompilationUnit wc= WorkingCopyUtil.getWorkingCopyIfExists(cu); if (wc.equals(cu)) return false; IJavaElement element= (IJavaElement)elem; IJavaElement wcElement= JavaModelUtil.findInCompilationUnit(wc, element); return wcElement == null || ! wcElement.exists(); } protected ISourceReference[] getSelectedElements(){ List l= getStructuredSelection().toList(); return (ISourceReference[]) l.toArray(new ISourceReference[l.size()]); } }
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/JavaWorkbenchAdapter.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui; import org.eclipse.jface.resource.ImageDescriptor; import org.eclipse.ui.model.IWorkbenchAdapter; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IParent; import org.eclipse.jdt.core.JavaModelException; /** * An imlementation of the IWorkbenchAdapter for IJavaElements. */ public class JavaWorkbenchAdapter implements IWorkbenchAdapter {
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/JavaWorkbenchAdapter.java
protected static final Object[] NO_CHILDREN= new Object[0]; public Object[] getChildren(Object o) { if (o instanceof IParent) { try { return ((IParent)o).getChildren(); } catch(JavaModelException e) { JavaPlugin.logErrorMessage(getClass().getName() + ": Error getting children for: " + o); } } return NO_CHILDREN; } public ImageDescriptor getImageDescriptor(Object object) { return null; } public String getLabel(Object o) { if (o instanceof IJavaElement) return ((IJavaElement)o).getElementName(); return null; } public Object getParent(Object o) { if (o instanceof IJavaElement) return ((IJavaElement)o).getParent(); return null; } }
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ResultCollector.java
package org.eclipse.jdt.internal.ui.text.java; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.util.ArrayList; import java.util.Arrays; import java.util.Comparator; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.graphics.Point; import org.eclipse.swt.graphics.Rectangle; import org.eclipse.core.resources.IMarker; import org.eclipse.jface.resource.ImageDescriptor; import org.eclipse.jface.resource.ImageRegistry; import org.eclipse.jface.text.contentassist.ICompletionProposal; import org.eclipse.jdt.core.Flags; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.ICompletionRequestor; import org.eclipse.jdt.core.IImportDeclaration; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.viewsupport.ImageDescriptorRegistry; import org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageDescriptor; /** * Bin to collect the proposal of the infrastructure on code assist in a java text. */ public class ResultCollector implements ICompletionRequestor {
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ResultCollector.java
private class ProposalComparator implements Comparator { public int compare(Object o1, Object o2) { ICompletionProposal c1= (ICompletionProposal) o1;
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ResultCollector.java
ICompletionProposal c2= (ICompletionProposal) o2; return c1.getDisplayString().compareToIgnoreCase(c2.getDisplayString()); } }; private final static char[] METHOD_WITH_ARGUMENTS_TRIGGERS= new char[] { '(', '-', ' ' }; private final static char[] METHOD_TRIGGERS= new char[] { ';', ',', '.', '\t', '[', ' ' }; private final static char[] TYPE_TRIGGERS= new char[] { '.', '\t', '[', '(', ' ' }; private final static char[] VAR_TRIGGER= new char[] { '\t', ' ', '=', ';' }; private ArrayList fFields= new ArrayList(), fKeywords= new ArrayList(), fLabels= new ArrayList(), fMethods= new ArrayList(), fModifiers= new ArrayList(), fPackages= new ArrayList(), fTypes= new ArrayList(), fVariables= new ArrayList(); private IMarker fLastProblem; private IJavaProject fJavaProject; private ICompilationUnit fCompilationUnit; private int fCodeAssistOffset; private ImageDescriptorRegistry fRegistry= JavaPlugin.getImageDescriptorRegistry(); private ArrayList[] fResults = new ArrayList[] { fVariables, fFields, fMethods, fTypes, fKeywords, fModifiers, fLabels, fPackages }; private int fUserReplacementLength; /* * Is eating code assist enabled or disabled? PR #3666 * When eating is enabled, JavaCompletionProposal must be revisited: PR #5533 */ private boolean fPreventEating= true;
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ResultCollector.java
/* * @see ICompletionRequestor#acceptClass */ public void acceptClass(char[] packageName, char[] typeName, char[] completionName, int modifiers, int start, int end) { ImageDescriptor descriptor= JavaPluginImages.DESC_OBJS_CLASS; if (Flags.isDeprecated(modifiers)) descriptor= getDeprecatedDescriptor(descriptor); ProposalInfo info= new ProposalInfo(fJavaProject, packageName, typeName); fTypes.add(createTypeCompletion(start, end, new String(completionName), descriptor, new String(typeName), new String(packageName), info)); } /* * @see ICompletionRequestor#acceptError */ public void acceptError(IMarker problemMarker) { fLastProblem= problemMarker; } /* * @see ICompletionRequestor#acceptField */ public void acceptField( char[] declaringTypePackageName, char[] declaringTypeName, char[] name, char[] typePackageName, char[] typeName, char[] completionName, int modifiers, int start, int end) { ImageDescriptor descriptor= getMemberDescriptor(modifiers); if (Flags.isDeprecated(modifiers)) descriptor= getDeprecatedDescriptor(descriptor);
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ResultCollector.java
StringBuffer nameBuffer= new StringBuffer(); nameBuffer.append(name); if (typeName.length > 0) { nameBuffer.append(" "); nameBuffer.append(typeName); } if (declaringTypeName != null && declaringTypeName.length > 0) { nameBuffer.append(" - "); nameBuffer.append(declaringTypeName); } JavaCompletionProposal proposal= createCompletion(start, end, new String(completionName), descriptor, nameBuffer.toString()); proposal.setProposalInfo(new ProposalInfo(fJavaProject, declaringTypePackageName, declaringTypeName, name)); proposal.setTriggerCharacters(VAR_TRIGGER); fFields.add(proposal); } /* * @see ICompletionRequestor#acceptInterface */ public void acceptInterface(char[] packageName, char[] typeName, char[] completionName, int modifiers, int start, int end) { ImageDescriptor descriptor= JavaPluginImages.DESC_OBJS_INTERFACE; if (Flags.isDeprecated(modifiers)) descriptor= getDeprecatedDescriptor(descriptor); ProposalInfo info= new ProposalInfo(fJavaProject, packageName, typeName); fTypes.add(createTypeCompletion(start, end, new String(completionName), descriptor, new String(typeName), new String(packageName), info)); } /*
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ResultCollector.java
* @see ICompletionRequestor#acceptAnonymousType(char[], char[], char[][], char[][], char[][], char[], int, int, int) */ public void acceptAnonymousType(char[] superTypePackageName, char[] superTypeName, char[][] parameterPackageNames, char[][] parameterTypeNames, char[][] parameterNames, char[] completionName, int modifiers, int completionStart, int completionEnd) { JavaCompletionProposal proposal= createAnonymousTypeCompletion(superTypePackageName, superTypeName, parameterTypeNames, parameterNames, completionName, completionStart, completionEnd); proposal.setProposalInfo(new ProposalInfo(fJavaProject, superTypePackageName, superTypeName)); fTypes.add(proposal); } /* * @see ICompletionRequestor#acceptKeyword */ public void acceptKeyword(char[] keyword, int start, int end) { String kw= new String(keyword); fKeywords.add(createCompletion(start, end, kw, null, kw)); } /* * @see ICompletionRequestor#acceptLabel */ public void acceptLabel(char[] labelName, int start, int end) { String ln= new String(labelName); fLabels.add(createCompletion(start, end, ln, null, ln)); } /* * @see ICompletionRequestor#acceptLocalVariable */ public void acceptLocalVariable(char[] name, char[] typePackageName, char[] typeName, int modifiers, int start, int end) { StringBuffer buf= new StringBuffer();
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ResultCollector.java
buf.append(name); if (typeName != null) { buf.append(" "); buf.append(typeName); } JavaCompletionProposal proposal= createCompletion(start, end, new String(name), null, buf.toString()); proposal.setTriggerCharacters(VAR_TRIGGER); fVariables.add(proposal); } private String getParameterSignature(char[][] parameterTypeNames, char[][] parameterNames) { StringBuffer buf = new StringBuffer(); if (parameterTypeNames != null) { for (int i = 0; i < parameterTypeNames.length; i++) { if (i > 0) { buf.append(','); buf.append(' '); } buf.append(parameterTypeNames[i]); if (parameterNames[i] != null) { buf.append(' '); buf.append(parameterNames[i]); } } } return buf.toString(); } /* * @see ICompletionRequestor#acceptMethod(char[], char[], char[], char[][], char[][], char[][], char[], char[], char[], int, int, int)
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ResultCollector.java
*/ public void acceptMethod(char[] declaringTypePackageName, char[] declaringTypeName, char[] name, char[][] parameterPackageNames, char[][] parameterTypeNames, char[][] parameterNames, char[] returnTypePackageName, char[] returnTypeName, char[] completionName, int modifiers, int start, int end) { JavaCompletionProposal proposal= createMethodCompletion(declaringTypeName, name, parameterTypeNames, parameterNames, returnTypeName, completionName, modifiers, start, end); proposal.setProposalInfo(new ProposalInfo(fJavaProject, declaringTypePackageName, declaringTypeName, name, parameterPackageNames, parameterTypeNames, returnTypeName.length == 0)); boolean hasClosingBracket= completionName.length > 0 && completionName[completionName.length - 1] == ')'; ProposalContextInformation contextInformation= null; if (hasClosingBracket && parameterTypeNames.length > 0) { contextInformation= new ProposalContextInformation(); contextInformation.setInformationDisplayString(getParameterSignature(parameterTypeNames, parameterNames)); contextInformation.setContextDisplayString(proposal.getDisplayString()); proposal.setContextInformation(contextInformation); } boolean userMustCompleteParameters= (contextInformation != null && completionName.length > 0); char[] triggers= userMustCompleteParameters ? METHOD_WITH_ARGUMENTS_TRIGGERS : METHOD_TRIGGERS; proposal.setTriggerCharacters(triggers); if (userMustCompleteParameters) { proposal.setCursorPosition(completionName.length - 1); } fMethods.add(proposal); }
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ResultCollector.java
/* * @see ICompletionRequestor#acceptModifier */ public void acceptModifier(char[] modifier, int start, int end) { String mod= new String(modifier); fModifiers.add(createCompletion(start, end, mod, null, mod)); } /* * @see ICompletionRequestor#acceptPackage */ public void acceptPackage(char[] packageName, char[] completionName, int start, int end) { fPackages.add(createCompletion(start, end, new String(completionName), JavaPluginImages.DESC_OBJS_PACKAGE, new String(packageName))); } /* * @see ICompletionRequestor#acceptType */ public void acceptType(char[] packageName, char[] typeName, char[] completionName, int start, int end) { ProposalInfo info= new ProposalInfo(fJavaProject, packageName, typeName); fTypes.add(createTypeCompletion(start, end, new String(completionName), JavaPluginImages.DESC_OBJS_CLASS, new String(typeName), new String(packageName), info)); } /* * @see ICodeCompletionRequestor#acceptMethodDeclaration(char[], char[], char[], char[][], char[][], char[][], char[], char[], char[], int, int, int) */ public void acceptMethodDeclaration(char[] declaringTypePackageName, char[] declaringTypeName, char[] name, char[][] parameterPackageNames, char[][] parameterTypeNames, char[][] parameterNames, char[] returnTypePackageName, char[] returnTypeName, char[] completionName, int modifiers, int start, int end) { JavaCompletionProposal proposal= createMethodCompletion(declaringTypeName, name, parameterTypeNames, parameterNames, returnTypeName, completionName, modifiers, start, end); fMethods.add(proposal);
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ResultCollector.java
} /* * @see ICodeCompletionRequestor#acceptVariableName(char[], char[], char[], char[], int, int) */ public void acceptVariableName(char[] typePackageName, char[] typeName, char[] name, char[] completionName, int start, int end) { StringBuffer buf= new StringBuffer(); buf.append(name); if (typeName != null && typeName.length > 0) { buf.append(" - "); buf.append(typeName); } JavaCompletionProposal proposal= createCompletion(start, end, new String(completionName), null, buf.toString()); proposal.setTriggerCharacters(VAR_TRIGGER); fVariables.add(proposal); } public String getErrorMessage() { if (fLastProblem != null) return fLastProblem.getAttribute(IMarker.MESSAGE, JavaTextMessages.getString("ResultCollector.compile_error.message")); return ""; } public JavaCompletionProposal[] getResults() { ArrayList result= new ArrayList(); ProposalComparator comperator= new ProposalComparator(); for (int i= 0; i < fResults.length; i++) { ArrayList bucket = fResults[i]; int size= bucket.size(); if (size == 1) {
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ResultCollector.java
result.add(bucket.get(0)); } else if (size > 1) { Object[] sortedBucket = new Object[size]; bucket.toArray(sortedBucket); Arrays.sort(sortedBucket, comperator); for (int j= 0; j < sortedBucket.length; j++) result.add(sortedBucket[j]); } } return (JavaCompletionProposal[]) result.toArray(new JavaCompletionProposal[result.size()]); } protected JavaCompletionProposal createMethodCompletion(char[] declaringTypeName, char[] name, char[][] parameterTypeNames, char[][] parameterNames, char[] returnTypeName, char[] completionName, int modifiers, int start, int end) { ImageDescriptor descriptor= getMemberDescriptor(modifiers); if (Flags.isDeprecated(modifiers)) descriptor= getDeprecatedDescriptor(descriptor); StringBuffer nameBuffer= new StringBuffer(); nameBuffer.append(name); nameBuffer.append('('); if (parameterTypeNames.length > 0) { nameBuffer.append(getParameterSignature(parameterTypeNames, parameterNames)); } nameBuffer.append(')'); if (returnTypeName.length > 0) { nameBuffer.append(" "); nameBuffer.append(returnTypeName); } if (declaringTypeName.length > 0) { nameBuffer.append(" - "); nameBuffer.append(declaringTypeName); }
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ResultCollector.java
return createCompletion(start, end, new String(completionName), descriptor, nameBuffer.toString()); } protected JavaCompletionProposal createAnonymousTypeCompletion(char[] declaringTypePackageName, char[] declaringTypeName, char[][] parameterTypeNames, char[][] parameterNames, char[] completionName, int start, int end) { StringBuffer declTypeBuf= new StringBuffer(); if (declaringTypePackageName.length > 0) { declTypeBuf.append(declaringTypePackageName); declTypeBuf.append('.'); } declTypeBuf.append(declaringTypeName); StringBuffer nameBuffer= new StringBuffer(); nameBuffer.append(declaringTypeName); nameBuffer.append('('); if (parameterTypeNames.length > 0) { nameBuffer.append(getParameterSignature(parameterTypeNames, parameterNames)); } nameBuffer.append(')'); nameBuffer.append(" "); nameBuffer.append(JavaTextMessages.getString("ResultCollector.anonymous_type")); int length= end - start; return new AnonymousTypeCompletionProposal(fCompilationUnit, start, length, new String(completionName), nameBuffer.toString(), declTypeBuf.toString()); } protected JavaCompletionProposal createTypeCompletion(int start, int end, String completion, ImageDescriptor descriptor, String typeName, String containerName, ProposalInfo proposalInfo) { IImportDeclaration importDeclaration= null; if (containerName != null && fCompilationUnit != null) { if (completion.equals(JavaModelUtil.concatenateName(containerName, typeName))) { importDeclaration= fCompilationUnit.getImport(completion);
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ResultCollector.java
completion= typeName; } } StringBuffer buf= new StringBuffer(typeName); if (containerName != null) { buf.append(" - "); buf.append(containerName); } String name= buf.toString(); JavaCompletionProposal proposal= createCompletion(start, end, completion, descriptor, name); proposal.setImportDeclaration(importDeclaration); proposal.setProposalInfo(proposalInfo); proposal.setTriggerCharacters(TYPE_TRIGGERS); return proposal; } protected ImageDescriptor getMemberDescriptor(int modifiers) { if (Flags.isPublic(modifiers)) { return JavaPluginImages.DESC_MISC_PUBLIC; } else if (Flags.isProtected(modifiers)) { return JavaPluginImages.DESC_MISC_PROTECTED; } else if (Flags.isPrivate(modifiers)) { return JavaPluginImages.DESC_MISC_PRIVATE; } else { return JavaPluginImages.DESC_MISC_DEFAULT; } } protected ImageDescriptor getDeprecatedDescriptor(ImageDescriptor descriptor) { Point size= new Point(16, 16);
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ResultCollector.java
return new JavaElementImageDescriptor(descriptor, JavaElementImageDescriptor.WARNING, size); } protected JavaCompletionProposal createCompletion(int start, int end, String completion, ImageDescriptor descriptor, String name) { int length; if (fUserReplacementLength == -1) { length= fPreventEating ? fCodeAssistOffset - start : end - start; } else { length= fUserReplacementLength; if (start < fCodeAssistOffset) { length+= fCodeAssistOffset - start; } } Image icon= (descriptor == null) ? null : fRegistry.get(descriptor); return new JavaCompletionProposal(completion, start, length, icon, name); } /** * Specifies the context of the code assist operation. * @param codeAssistOffset The Offset on which the code assist will be called. * Used to modify the offsets of the created proposals. ('Non Eating') * @param jproject The Java project to which the underlying source belongs. * Needed to find types referred. * @param cu The compilation unit that is edited. Used to add import statements. * Can be <code>null</code> if no import statements should be added. */
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/ResultCollector.java
public void reset(int codeAssistOffset, IJavaProject jproject, ICompilationUnit cu) { fJavaProject= jproject; fCompilationUnit= cu; fCodeAssistOffset= codeAssistOffset; fUserReplacementLength= -1; fLastProblem= null; for (int i= 0; i < fResults.length; i++) fResults[i].clear(); } /** * If the replacement length is set, it overrides the length returned from * the content assist infrastructure. * Use this setting if code assist is called with a none empty selection. */ public void setReplacementLength(int length) { fUserReplacementLength= length; } /** * If set, proposals created will not remove characters after the code assist position * @param preventEating The preventEating to set */ public void setPreventEating(boolean preventEating) { fPreventEating= preventEating; } }
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/ErrorTickImageProvider.java
package org.eclipse.jdt.internal.ui.viewsupport; import java.util.Iterator; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IMarker; import org.eclipse.core.resources.IResource; import org.eclipse.core.runtime.CoreException; import org.eclipse.jface.text.Position; import org.eclipse.jface.text.source.Annotation; import org.eclipse.jface.text.source.IAnnotationModel; import org.eclipse.ui.part.FileEditorInput; import org.eclipse.ui.texteditor.MarkerAnnotation; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.ISourceRange; import org.eclipse.jdt.core.ISourceReference; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; public class ErrorTickImageProvider extends JavaElementImageProvider { private static final int ERRORTICK_WARNING= JavaElementImageDescriptor.WARNING; private static final int ERRORTICK_ERROR= JavaElementImageDescriptor.ERROR; /* * @see JavaElementImageProvider#computeExtraAdornmentFlags(Object) */ protected int computeExtraAdornmentFlags(Object obj) {
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/ErrorTickImageProvider.java
try { if (obj instanceof IJavaElement) { IJavaElement element= (IJavaElement) obj; if (!element.exists()) { return 0; } int type= element.getElementType(); switch (type) { case IJavaElement.JAVA_PROJECT: case IJavaElement.PACKAGE_FRAGMENT_ROOT: return getErrorTicksFromMarkers(element.getCorrespondingResource(), IResource.DEPTH_INFINITE, null); case IJavaElement.PACKAGE_FRAGMENT: case IJavaElement.CLASS_FILE: return getErrorTicksFromMarkers(element.getCorrespondingResource(), IResource.DEPTH_ONE, null); case IJavaElement.COMPILATION_UNIT: case IJavaElement.PACKAGE_DECLARATION: case IJavaElement.IMPORT_DECLARATION: case IJavaElement.IMPORT_CONTAINER: case IJavaElement.TYPE: case IJavaElement.INITIALIZER: case IJavaElement.METHOD: case IJavaElement.FIELD: ICompilationUnit cu= (ICompilationUnit) JavaModelUtil.findElementOfKind(element, IJavaElement.COMPILATION_UNIT); if (cu != null && cu.exists()) { ISourceRange range= ((ISourceReference)element).getSourceRange(); if (cu.isWorkingCopy()) { return getErrorTicksFromWorkingCopy((ICompilationUnit) cu.getOriginalElement(), range);
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/ErrorTickImageProvider.java
} return getErrorTicksFromMarkers(cu.getCorrespondingResource(), IResource.DEPTH_ONE, range); } default: } } else if (obj instanceof IResource) { return getErrorTicksFromMarkers((IResource) obj, IResource.DEPTH_INFINITE, null); } } catch (CoreException e) { JavaPlugin.log(e); } return 0; } private int getErrorTicksFromMarkers(IResource res, int depth, ISourceRange range) throws CoreException { if (res == null) { return 0; } int info= 0; IMarker[] markers= res.findMarkers(IMarker.PROBLEM, true, depth); if (markers != null) { for (int i= 0; i < markers.length && (info != ERRORTICK_ERROR); i++) { IMarker curr= markers[i]; if (range == null || isMarkerInRange(curr, range)) { int priority= curr.getAttribute(IMarker.SEVERITY, -1); if (priority == IMarker.SEVERITY_WARNING) { info= ERRORTICK_WARNING; } else if (priority == IMarker.SEVERITY_ERROR) { info= ERRORTICK_ERROR;
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/ErrorTickImageProvider.java
} } } } return info; } private boolean isMarkerInRange(IMarker marker, ISourceRange range) throws CoreException { if (marker.isSubtypeOf(IMarker.TEXT)) { int pos= marker.getAttribute(IMarker.CHAR_START, -1); int offset= range.getOffset(); return (offset <= pos && offset + range.getLength() > pos); } return false; } private int getErrorTicksFromWorkingCopy(ICompilationUnit original, ISourceRange range) throws CoreException { int info= 0; if (!original.exists()) { return 0; } FileEditorInput editorInput= new FileEditorInput((IFile) original.getCorrespondingResource()); IAnnotationModel model= JavaPlugin.getDefault().getCompilationUnitDocumentProvider().getAnnotationModel(editorInput); if (model != null) { Iterator iter= model.getAnnotationIterator(); while ((info != ERRORTICK_ERROR) && iter.hasNext()) { Annotation curr= (Annotation) iter.next(); IMarker marker= isAnnotationInRange(model, curr, range);
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/ErrorTickImageProvider.java
if (marker != null) { int priority= marker.getAttribute(IMarker.SEVERITY, -1); if (priority == IMarker.SEVERITY_WARNING) { info= ERRORTICK_WARNING; } else if (priority == IMarker.SEVERITY_ERROR) { info= ERRORTICK_ERROR; } } } } return info; } private IMarker isAnnotationInRange(IAnnotationModel model, Annotation annot, ISourceRange range) throws CoreException { if (annot instanceof MarkerAnnotation) { IMarker marker= ((MarkerAnnotation)annot).getMarker(); if (marker.exists() && marker.isSubtypeOf(IMarker.PROBLEM)) { Position pos= model.getPosition(annot); if (pos.overlapsWith(range.getOffset(), range.getLength())) { return marker; } } } return null; } }
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/JavaElementImageDescriptor.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.viewsupport; import org.eclipse.swt.graphics.ImageData; import org.eclipse.swt.graphics.Point; import org.eclipse.jface.resource.CompositeImageDescriptor; import org.eclipse.jface.resource.ImageDescriptor; import org.eclipse.jface.util.Assert; import org.eclipse.jdt.internal.ui.JavaPluginImages; /** * A JavaImageDescriptor consists of a main icon and several adornments. The adornments * are computed according to Java element's modifiers (e.g. visibility, static, final, ...). */ public class JavaElementImageDescriptor extends CompositeImageDescriptor { public final static int ABSTRACT= 0x001; public final static int FINAL= 0x002; public final static int SYNCHRONIZED= 0x004; public final static int STATIC= 0x008; public final static int RUNNABLE= 0x010; public final static int WARNING= 0x020;
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/JavaElementImageDescriptor.java
public final static int ERROR= 0x040; public final static int OVERRIDDEN= 0x080; private ImageDescriptor fBaseImage; private int fFlags; private Point fSize; /** * Create a new JavaElementImageDescriptor. * * @param baseImage an image descriptor used as the base image * @param flags flags indicating which adornments are to be rendered * @param size the size of the resulting image */ public JavaElementImageDescriptor(ImageDescriptor baseImage, int flags, Point size) { fBaseImage= baseImage; Assert.isNotNull(fBaseImage); fFlags= flags; Assert.isTrue(fFlags >= 0); fSize= size; Assert.isNotNull(fSize); } /* (non-Javadoc) * Method declared in CompositeImageDescriptor */ protected Point getSize() { return fSize; }
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/JavaElementImageDescriptor.java
/* (non-Javadoc) * Method declared on Object. */ public boolean equals(Object object) { if (!JavaElementImageDescriptor.class.equals(object.getClass())) return false; JavaElementImageDescriptor other= (JavaElementImageDescriptor)object; return (fBaseImage.equals(other.fBaseImage) && fFlags == other.fFlags && fSize.equals(other.fSize)); } /* (non-Javadoc) * Method declared on Object. */ public int hashCode() { return fBaseImage.hashCode() | fFlags | fSize.hashCode(); } /* (non-Javadoc) * Method declared in CompositeImageDescriptor */ protected void drawCompositeImage(int width, int height) { ImageData bg; if ((bg= fBaseImage.getImageData()) == null) bg= DEFAULT_IMAGE_DATA; drawImage(bg, 0, 0); drawTopRight(); drawBottomRight();
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/JavaElementImageDescriptor.java
drawBottomLeft(); } private void drawTopRight() { int x= getSize().x; ImageData data= null; if ((fFlags & ABSTRACT) != 0) { data= JavaPluginImages.DESC_OVR_ABSTRACT.getImageData(); x-= data.width; drawImage(data, x, 0); } if ((fFlags & FINAL) != 0) { data= JavaPluginImages.DESC_OVR_FINAL.getImageData(); x-= data.width; drawImage(data, x, 0); } if ((fFlags & STATIC) != 0) { data= JavaPluginImages.DESC_OVR_STATIC.getImageData(); x-= data.width; drawImage(data, x, 0); } } private void drawBottomRight() { Point size= getSize(); int x= size.x; ImageData data= null; if ((fFlags & SYNCHRONIZED) != 0) { data= JavaPluginImages.DESC_OVR_SYNCH.getImageData(); x-= data.width;
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/JavaElementImageDescriptor.java
drawImage(data, x, size.y - data.height); } if ((fFlags & RUNNABLE) != 0) { data= JavaPluginImages.DESC_OVR_RUN.getImageData(); x-= data.width; drawImage(data, x, size.y - data.height); } if ((fFlags & OVERRIDDEN) != 0) { data= JavaPluginImages.DESC_OVR_OVERRIDDEN.getImageData(); x-= data.width; drawImage(data, x, size.y - data.height); } } private void drawBottomLeft() { Point size= getSize(); int x= 0; ImageData data= null; if ((fFlags & ERROR) != 0) { data= JavaPluginImages.DESC_OVR_ERROR.getImageData(); drawImage(data, x, size.y - data.height); x+= data.width; } if ((fFlags & WARNING) != 0) { data= JavaPluginImages.DESC_OVR_WARNING.getImageData(); drawImage(data, x, size.y - data.height); x+= data.width; } } }
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/JavaElementImageProvider.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.viewsupport; import org.eclipse.core.resources.IProject; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IAdaptable; import org.eclipse.core.runtime.IPath; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.graphics.Point; import org.eclipse.jface.resource.ImageDescriptor; import org.eclipse.jface.util.Assert; import org.eclipse.ui.ISharedImages; import org.eclipse.ui.model.IWorkbenchAdapter; import org.eclipse.jdt.core.Flags; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaProject;
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/JavaElementImageProvider.java
import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.ISourceReference; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaPluginImages; import org.eclipse.jdt.internal.ui.JavaUIMessages; /** * Default strategy of the Java plugin for the construction of Java element icons. */ public class JavaElementImageProvider { /** * Flags for the JavaImageLabelProvider: * Generate images with overlays. */ public final static int OVERLAY_ICONS= 0x1; /** * Generate small sized images. */ public final static int SMALL_ICONS= 0x2; /** * Use the 'light' style for rendering types. */ public final static int LIGHT_TYPE_ICONS= 0x4;
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/JavaElementImageProvider.java
private static final Point SMALL_SIZE= new Point(16, 16); private static final Point BIG_SIZE= new Point(22, 16); private static ImageDescriptor DESC_OBJ_PROJECT_CLOSED; private static ImageDescriptor DESC_OBJ_PROJECT; private static ImageDescriptor DESC_OBJ_FOLDER; { ISharedImages images= JavaPlugin.getDefault().getWorkbench().getSharedImages(); DESC_OBJ_PROJECT_CLOSED= images.getImageDescriptor(ISharedImages.IMG_OBJ_PROJECT_CLOSED); DESC_OBJ_PROJECT= images.getImageDescriptor(ISharedImages.IMG_OBJ_PROJECT); DESC_OBJ_FOLDER= images.getImageDescriptor(ISharedImages.IMG_OBJ_FOLDER); } private ImageDescriptorRegistry fRegistry; public JavaElementImageProvider() { fRegistry= JavaPlugin.getImageDescriptorRegistry(); } /** * Returns the icon for a given element. The icon depends on the element type * and element properties. If configured, overlay icons are constructed for * <code>ISourceReference</code>s. * @param flags Flags as defined by the JavaImageLabelProvider */ public Image getImageLabel(Object element, int flags) { ImageDescriptor descriptor= null; if (element instanceof IJavaElement) { descriptor= getJavaImageDescriptor((IJavaElement) element, flags); } else if (element instanceof IAdaptable) { descriptor= getWorkbenchImageDescriptor((IAdaptable) element, flags);
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/JavaElementImageProvider.java
} if (descriptor != null) { return fRegistry.get(descriptor); } return null; } private boolean showOverlayIcons(int flags) { return (flags & OVERLAY_ICONS) != 0; } private boolean useLightIcons(int flags) { return (flags & LIGHT_TYPE_ICONS) != 0; } private boolean useSmallSize(int flags) { return (flags & SMALL_ICONS) != 0; } /** * Returns an image descriptor for a java element. The descriptor includes overlays, if specified. */ public ImageDescriptor getJavaImageDescriptor(IJavaElement element, int flags) { int adornmentFlags= showOverlayIcons(flags) ? computeAdornmentFlags(element) : 0; Point size= useSmallSize(flags) ? SMALL_SIZE : BIG_SIZE; return new JavaElementImageDescriptor(getBaseImageDescriptor(element, flags), adornmentFlags, size); } /** * Returns an image descriptor for a IAdaptable. The descriptor includes overlays, if specified (only error ticks apply). * Returns <code>null</code> if no image could be found. */
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/JavaElementImageProvider.java
public ImageDescriptor getWorkbenchImageDescriptor(IAdaptable adaptable, int flags) { IWorkbenchAdapter wbAdapter= (IWorkbenchAdapter) adaptable.getAdapter(IWorkbenchAdapter.class); if (wbAdapter == null) { return null; } ImageDescriptor descriptor= wbAdapter.getImageDescriptor(adaptable); if (descriptor == null) { return null; } int adornmentFlags= computeExtraAdornmentFlags(adaptable); Point size= useSmallSize(flags) ? SMALL_SIZE : BIG_SIZE; return new JavaElementImageDescriptor(descriptor, adornmentFlags, size); } /** * Returns an image descriptor for a java element. This is the base image, no overlays. */ public ImageDescriptor getBaseImageDescriptor(IJavaElement element, int renderFlags) { try { switch (element.getElementType()) { case IJavaElement.INITIALIZER: case IJavaElement.METHOD: case IJavaElement.FIELD: { IMember member= (IMember) element; if (member.getDeclaringType().isInterface()) return JavaPluginImages.DESC_MISC_PUBLIC;
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/JavaElementImageProvider.java
int flags= member.getFlags(); if (Flags.isPublic(flags)) return JavaPluginImages.DESC_MISC_PUBLIC; if (Flags.isProtected(flags)) return JavaPluginImages.DESC_MISC_PROTECTED; if (Flags.isPrivate(flags)) return JavaPluginImages.DESC_MISC_PRIVATE; return JavaPluginImages.DESC_MISC_DEFAULT; } case IJavaElement.PACKAGE_DECLARATION: return JavaPluginImages.DESC_OBJS_PACKDECL; case IJavaElement.IMPORT_DECLARATION: return JavaPluginImages.DESC_OBJS_IMPDECL; case IJavaElement.IMPORT_CONTAINER: return JavaPluginImages.DESC_OBJS_IMPCONT; case IJavaElement.TYPE: { IType type= (IType) element; if (useLightIcons(renderFlags)) { if (type.isClass()) return JavaPluginImages.DESC_OBJS_CLASSALT; else return JavaPluginImages.DESC_OBJS_INTERFACEALT; } int flags= type.getFlags();
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/JavaElementImageProvider.java
boolean hasVisibility= Flags.isPublic(flags) || Flags.isPrivate(flags) || Flags.isProtected(flags); if (type.isClass()) return hasVisibility ? JavaPluginImages.DESC_OBJS_CLASS : JavaPluginImages.DESC_OBJS_PCLASS; return hasVisibility ? JavaPluginImages.DESC_OBJS_INTERFACE : JavaPluginImages.DESC_OBJS_PINTERFACE; } case IJavaElement.PACKAGE_FRAGMENT_ROOT: { IPackageFragmentRoot root= (IPackageFragmentRoot) element; if (root.isArchive()) { IPath attach= root.getSourceAttachmentPath(); if (root.isExternal()) { if (attach == null) { return JavaPluginImages.DESC_OBJS_EXTJAR; } else { return JavaPluginImages.DESC_OBJS_EXTJAR_WSRC; } } else { if (attach == null) { return JavaPluginImages.DESC_OBJS_JAR; } else { return JavaPluginImages.DESC_OBJS_JAR_WSRC; } } } else { return JavaPluginImages.DESC_OBJS_PACKFRAG_ROOT; } } case IJavaElement.PACKAGE_FRAGMENT: IPackageFragment fragment= (IPackageFragment)element; try {
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/JavaElementImageProvider.java
if (!fragment.hasChildren() && (fragment.getNonJavaResources().length >0)) return DESC_OBJ_FOLDER; } catch(JavaModelException e) { return DESC_OBJ_FOLDER; } return JavaPluginImages.DESC_OBJS_PACKAGE; case IJavaElement.COMPILATION_UNIT: return JavaPluginImages.DESC_OBJS_CUNIT; case IJavaElement.CLASS_FILE: /* this is too expensive for large packages try { IClassFile cfile= (IClassFile)element; if (cfile.isClass()) return JavaPluginImages.IMG_OBJS_CFILECLASS; return JavaPluginImages.IMG_OBJS_CFILEINT; } catch(JavaModelException e) { // fall through; }*/ return JavaPluginImages.DESC_OBJS_CFILE; case IJavaElement.JAVA_PROJECT: IJavaProject jp= (IJavaProject)element; if (jp.getProject().isOpen()) { IProject project= jp.getProject(); IWorkbenchAdapter adapter= (IWorkbenchAdapter)project.getAdapter(IWorkbenchAdapter.class); if (adapter != null) {
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/JavaElementImageProvider.java
ImageDescriptor result= adapter.getImageDescriptor(project); if (result != null) return result; } return DESC_OBJ_PROJECT; } return DESC_OBJ_PROJECT_CLOSED; case IJavaElement.JAVA_MODEL: return JavaPluginImages.DESC_OBJS_JAVA_MODEL; } Assert.isTrue(false, JavaUIMessages.getString("JavaImageLabelprovider.assert.wrongImage")); return null; } catch (CoreException e) { JavaPlugin.log(e); return JavaPluginImages.DESC_OBJS_GHOST; } } private int computeAdornmentFlags(IJavaElement element) { int flags= computeExtraAdornmentFlags(element); if (element instanceof ISourceReference) { ISourceReference sourceReference= (ISourceReference)element; int modifiers= getModifiers(sourceReference);
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/JavaElementImageProvider.java
if (Flags.isAbstract(modifiers) && confirmAbstract((IMember) sourceReference)) flags |= JavaElementImageDescriptor.ABSTRACT; if (Flags.isFinal(modifiers)) flags |= JavaElementImageDescriptor.FINAL; if (Flags.isSynchronized(modifiers) && confirmSynchronized((IMember) sourceReference)) flags |= JavaElementImageDescriptor.SYNCHRONIZED; if (Flags.isStatic(modifiers)) flags |= JavaElementImageDescriptor.STATIC; if (sourceReference instanceof IType) { try { if (JavaModelUtil.hasMainMethod((IType)sourceReference)) flags |= JavaElementImageDescriptor.RUNNABLE; } catch (JavaModelException e) { } } } return flags; } protected int computeExtraAdornmentFlags(Object element) { return 0; } private boolean confirmAbstract(IMember member) { IType t= member.getDeclaringType(); if (t == null && member instanceof IType)
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/JavaElementImageProvider.java
t= (IType) member; if (t != null) { try { return !t.isInterface(); } catch (JavaModelException x) { } } return true; } private boolean confirmSynchronized(IMember member) { return !(member instanceof IType); } private int getModifiers(ISourceReference sourceReference) { if (sourceReference instanceof IMember) { try { return ((IMember) sourceReference).getFlags(); } catch (JavaModelException x) { } } return 0; } public void dispose() { } }
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/OverrideImageProvider.java
package org.eclipse.jdt.internal.ui.viewsupport; import org.eclipse.jdt.core.Flags; import org.eclipse.jdt.core.IMethod; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.ITypeHierarchy; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.preferences.WorkInProgressPreferencePage; import org.eclipse.jdt.internal.ui.typehierarchy.ITypeHierarchyLifeCycleListener; import org.eclipse.jdt.internal.ui.typehierarchy.TypeHierarchyLifeCycle; public class OverrideImageProvider extends ErrorTickImageProvider {
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/OverrideImageProvider.java
private TypeHierarchyLifeCycle fTypeHierarchy; public OverrideImageProvider() { fTypeHierarchy= new TypeHierarchyLifeCycle(true); } /* * @see JavaElementImageProvider#computeExtraAdornmentFlags(Object) */ protected int computeExtraAdornmentFlags(Object element) { int adornmentFlags= super.computeExtraAdornmentFlags(element); if (!WorkInProgressPreferencePage.showOverrideIndicators()) { return adornmentFlags; } if (element instanceof IMethod) { try { IMethod method= (IMethod) element;
6,299
Bug 6299 JavaWorkbenchAdapter does not provide images
org.eclipse.jdt.internal.ui.JavaWorkbenchAdapter#getImageDescriptor returns null; not very nice when presenting in a viewer. Solution (just suggestion;): org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider#getImageDescriptor ... org.eclipse.jdt.internal.ui.viewsupport.JavaElementImageProvider imageProvider; ... return imageProvider.getImageDescriptor((IJavaElement)element, JavaElementImageProvider.SMALL_ICONS);
resolved fixed
cf601cf
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T15:50:59Z
2001-11-26T10:20:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/viewsupport/OverrideImageProvider.java
int flags= method.getFlags(); IType type= method.getDeclaringType(); if (type.isClass() && !method.isConstructor() && !Flags.isPrivate(flags) && !Flags.isStatic(flags)) { ITypeHierarchy hierarchy= getTypeHierarchy(type); IMethod overridden= JavaModelUtil.findMethodDeclarationInHierarchy(hierarchy, type, method.getElementName(), method.getParameterTypes(), false); if (overridden != null) { adornmentFlags |= JavaElementImageDescriptor.OVERRIDDEN; } } } catch (JavaModelException e) { JavaPlugin.log(e); } } return adornmentFlags; } private ITypeHierarchy getTypeHierarchy(IType type) throws JavaModelException { fTypeHierarchy.ensureRefreshedTypeHierarchy(type); return fTypeHierarchy.getHierarchy(); } /* * @see JavaElementImageProvider#dispose() */ public void dispose() { fTypeHierarchy.freeHierarchy(); super.dispose(); } }
8,611
Bug 8611 NPE in text search with Compare to a Version editor open
Build: 20020125 Description: Doing a text search on "Selected Resource" causes a NullPointerException if the active editor is a comparison editor. Steps: 1. Right click on a java file in the Packages view and choose Compare With > Version... from the context menu. 2. Once the comparison editor opens, click on a version to make the comparison. 3. Choose Edit > Search... 4. In the dialog that opens, Text search should be the default tab. If not, choose it. 5. Enter some text in the search field and choose "Selected Resources" in the Scope frame. 6. Click on the Search button. 7. Here you get an error. Stack trace from the log: Log: Mon Jan 28 13:32:00 EST 2002 4 org.eclipse.core.runtime 0 Unhandled exception caught in event loop. java.lang.NullPointerException at org.eclipse.search.internal.ui.text.TextSearchPage.getSelectedResourcesScope (TextSearchPage.java:469) at org.eclipse.search.internal.ui.text.TextSearchPage.performAction (TextSearchPage.java:118) at org.eclipse.search.internal.ui.SearchDialog.performAction (SearchDialog.java:215) at org.eclipse.search.internal.ui.util.ExtendedDialogWindow.buttonPressed (ExtendedDialogWindow.java:162) at org.eclipse.jface.dialogs.Dialog$1.widgetSelected(Dialog.java:344) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.search.internal.ui.OpenSearchDialogAction.run (OpenSearchDialogAction.java:45) at org.eclipse.search.internal.ui.OpenSearchDialogAction.run (OpenSearchDialogAction.java:32) at org.eclipse.ui.internal.PluginAction.runWithEvent (PluginAction.java:204) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.Main.main(Main.java:362) 4. Run a text search
resolved fixed
70463b8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T16:23:29Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchScopeFactory.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.search; import java.util.HashSet; import java.util.Iterator; import java.util.Set; import org.eclipse.core.resources.IFolder; import org.eclipse.core.resources.IResource; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IAdaptable; import org.eclipse.jface.viewers.ISelection; import org.eclipse.jface.viewers.IStructuredSelection; import org.eclipse.search.ui.IWorkingSet; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.search.IJavaSearchScope; import org.eclipse.jdt.core.search.SearchEngine; public class JavaSearchScopeFactory {
8,611
Bug 8611 NPE in text search with Compare to a Version editor open
Build: 20020125 Description: Doing a text search on "Selected Resource" causes a NullPointerException if the active editor is a comparison editor. Steps: 1. Right click on a java file in the Packages view and choose Compare With > Version... from the context menu. 2. Once the comparison editor opens, click on a version to make the comparison. 3. Choose Edit > Search... 4. In the dialog that opens, Text search should be the default tab. If not, choose it. 5. Enter some text in the search field and choose "Selected Resources" in the Scope frame. 6. Click on the Search button. 7. Here you get an error. Stack trace from the log: Log: Mon Jan 28 13:32:00 EST 2002 4 org.eclipse.core.runtime 0 Unhandled exception caught in event loop. java.lang.NullPointerException at org.eclipse.search.internal.ui.text.TextSearchPage.getSelectedResourcesScope (TextSearchPage.java:469) at org.eclipse.search.internal.ui.text.TextSearchPage.performAction (TextSearchPage.java:118) at org.eclipse.search.internal.ui.SearchDialog.performAction (SearchDialog.java:215) at org.eclipse.search.internal.ui.util.ExtendedDialogWindow.buttonPressed (ExtendedDialogWindow.java:162) at org.eclipse.jface.dialogs.Dialog$1.widgetSelected(Dialog.java:344) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.search.internal.ui.OpenSearchDialogAction.run (OpenSearchDialogAction.java:45) at org.eclipse.search.internal.ui.OpenSearchDialogAction.run (OpenSearchDialogAction.java:32) at org.eclipse.ui.internal.PluginAction.runWithEvent (PluginAction.java:204) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.Main.main(Main.java:362) 4. Run a text search
resolved fixed
70463b8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T16:23:29Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchScopeFactory.java
private static JavaSearchScopeFactory fgInstance; private static IJavaSearchScope EMPTY_SCOPE= SearchEngine.createJavaSearchScope(new IJavaElement[] {}); private JavaSearchScopeFactory() { } public static JavaSearchScopeFactory getInstance() { if (fgInstance == null) fgInstance= new JavaSearchScopeFactory(); return fgInstance; } public IJavaSearchScope createJavaSearchScope(IResource[] resources) { if (resources == null) return EMPTY_SCOPE; Set javaElements= new HashSet(resources.length); addJavaElements(javaElements, resources); return SearchEngine.createJavaSearchScope((IJavaElement[])javaElements.toArray(new IJavaElement[javaElements.size()])); } public IJavaSearchScope createJavaSearchScope(IWorkingSet workingSet) { return createJavaSearchScope(workingSet.getResources()); } public IJavaSearchScope createJavaSearchScope(ISelection selection) { if (!selection.isEmpty() && selection instanceof IStructuredSelection) { Iterator iter= ((IStructuredSelection)selection).iterator(); Set javaElements= new HashSet(((IStructuredSelection)selection).size());
8,611
Bug 8611 NPE in text search with Compare to a Version editor open
Build: 20020125 Description: Doing a text search on "Selected Resource" causes a NullPointerException if the active editor is a comparison editor. Steps: 1. Right click on a java file in the Packages view and choose Compare With > Version... from the context menu. 2. Once the comparison editor opens, click on a version to make the comparison. 3. Choose Edit > Search... 4. In the dialog that opens, Text search should be the default tab. If not, choose it. 5. Enter some text in the search field and choose "Selected Resources" in the Scope frame. 6. Click on the Search button. 7. Here you get an error. Stack trace from the log: Log: Mon Jan 28 13:32:00 EST 2002 4 org.eclipse.core.runtime 0 Unhandled exception caught in event loop. java.lang.NullPointerException at org.eclipse.search.internal.ui.text.TextSearchPage.getSelectedResourcesScope (TextSearchPage.java:469) at org.eclipse.search.internal.ui.text.TextSearchPage.performAction (TextSearchPage.java:118) at org.eclipse.search.internal.ui.SearchDialog.performAction (SearchDialog.java:215) at org.eclipse.search.internal.ui.util.ExtendedDialogWindow.buttonPressed (ExtendedDialogWindow.java:162) at org.eclipse.jface.dialogs.Dialog$1.widgetSelected(Dialog.java:344) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.search.internal.ui.OpenSearchDialogAction.run (OpenSearchDialogAction.java:45) at org.eclipse.search.internal.ui.OpenSearchDialogAction.run (OpenSearchDialogAction.java:32) at org.eclipse.ui.internal.PluginAction.runWithEvent (PluginAction.java:204) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.Main.main(Main.java:362) 4. Run a text search
resolved fixed
70463b8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T16:23:29Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchScopeFactory.java
while (iter.hasNext()) { Object selectedElement= iter.next(); if (selectedElement instanceof IJavaElement) addJavaElements(javaElements, (IJavaElement)selectedElement); else if (selectedElement instanceof IResource) addJavaElements(javaElements, (IResource)selectedElement); else if (selectedElement instanceof IAdaptable) { IResource resource= (IResource)((IAdaptable)selectedElement).getAdapter(IResource.class); if (resource != null) addJavaElements(javaElements, resource); } } return SearchEngine.createJavaSearchScope((IJavaElement[])javaElements.toArray(new IJavaElement[javaElements.size()])); } return EMPTY_SCOPE; } private void addJavaElements(Set javaElements, IResource[] resources) { for (int i= 0; i < resources.length; i++) addJavaElements(javaElements, resources[i]); } private void addJavaElements(Set javaElements, IResource resource) { IJavaElement javaElement= JavaCore.create(resource); if (javaElement == null) return; if (javaElement.getElementType() == IJavaElement.PACKAGE_FRAGMENT) { try { addJavaElements(javaElements, ((IFolder)resource).members());
8,611
Bug 8611 NPE in text search with Compare to a Version editor open
Build: 20020125 Description: Doing a text search on "Selected Resource" causes a NullPointerException if the active editor is a comparison editor. Steps: 1. Right click on a java file in the Packages view and choose Compare With > Version... from the context menu. 2. Once the comparison editor opens, click on a version to make the comparison. 3. Choose Edit > Search... 4. In the dialog that opens, Text search should be the default tab. If not, choose it. 5. Enter some text in the search field and choose "Selected Resources" in the Scope frame. 6. Click on the Search button. 7. Here you get an error. Stack trace from the log: Log: Mon Jan 28 13:32:00 EST 2002 4 org.eclipse.core.runtime 0 Unhandled exception caught in event loop. java.lang.NullPointerException at org.eclipse.search.internal.ui.text.TextSearchPage.getSelectedResourcesScope (TextSearchPage.java:469) at org.eclipse.search.internal.ui.text.TextSearchPage.performAction (TextSearchPage.java:118) at org.eclipse.search.internal.ui.SearchDialog.performAction (SearchDialog.java:215) at org.eclipse.search.internal.ui.util.ExtendedDialogWindow.buttonPressed (ExtendedDialogWindow.java:162) at org.eclipse.jface.dialogs.Dialog$1.widgetSelected(Dialog.java:344) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java (Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:523) at org.eclipse.search.internal.ui.OpenSearchDialogAction.run (OpenSearchDialogAction.java:45) at org.eclipse.search.internal.ui.OpenSearchDialogAction.run (OpenSearchDialogAction.java:32) at org.eclipse.ui.internal.PluginAction.runWithEvent (PluginAction.java:204) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:407) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent (ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java (Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java (Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:827) at org.eclipse.core.internal.boot.InternalBootLoader.run (InternalBootLoader.java:878) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:321) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:151) at org.eclipse.core.launcher.Main.run(Main.java:502) at org.eclipse.core.launcher.Main.main(Main.java:362) 4. Run a text search
resolved fixed
70463b8
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-01-30T16:23:29Z
2002-01-28T17:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchScopeFactory.java
} catch (CoreException ex) { } } addJavaElements(javaElements, javaElement); } private void addJavaElements(Set javaElements, IJavaElement javaElement) { switch (javaElement.getElementType()) { case IJavaElement.JAVA_PROJECT: addJavaElements(javaElements, (IJavaProject)javaElement); break; default: javaElements.add(javaElement); } } private void addJavaElements(Set javaElements, IJavaProject javaProject) { IPackageFragmentRoot[] roots; try { roots= javaProject.getPackageFragmentRoots(); } catch (JavaModelException ex) { return; } for (int i= 0; i < roots.length; i++) if (!roots[i].isExternal()) javaElements.add(roots[i]); } }
9,015
Bug 9015 Organize imports feature finds errors in assert statements
Eclipse version 2.0, build 20020125, Windows, installed JDK1.4RC3 from Sun, used as external compiler, Compilation settings Java 1.4 (source and bytecode). When I use asserts of the form assert xx != null; in the code and try to invoke the Organize Imports feature, I get an error Compilation unit has syntax errors: Line <someline>: Syntax error on token "!=", ",", ";" expected. The class runs fine and shows no errors / warnings otherwise. Organize imports work fine if I place assert expression in brackets, like this: assert (xx != null);
verified fixed
37083a2
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-04T19:23:25Z
2002-02-04T13:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaStructureCreator.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.compare; import java.io.InputStream; import java.util.*; import org.eclipse.jface.text.*; import org.eclipse.core.runtime.CoreException; import org.eclipse.jdt.core.*; import org.eclipse.jdt.internal.compiler.*; import org.eclipse.jdt.internal.compiler.impl.CompilerOptions; import org.eclipse.jdt.internal.compiler.parser.*; import org.eclipse.jdt.internal.core.JavaElement; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.compare.*; import org.eclipse.compare.structuremergeviewer.*; public class JavaStructureCreator implements IStructureCreator {
9,015
Bug 9015 Organize imports feature finds errors in assert statements
Eclipse version 2.0, build 20020125, Windows, installed JDK1.4RC3 from Sun, used as external compiler, Compilation settings Java 1.4 (source and bytecode). When I use asserts of the form assert xx != null; in the code and try to invoke the Organize Imports feature, I get an error Compilation unit has syntax errors: Line <someline>: Syntax error on token "!=", ",", ";" expected. The class runs fine and shows no errors / warnings otherwise. Organize imports work fine if I place assert expression in brackets, like this: assert (xx != null);
verified fixed
37083a2
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-04T19:23:25Z
2002-02-04T13:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaStructureCreator.java
/** * Used to bail out from ProblemFactory. */ private static class ParseError extends Error { } /** * This problem factory aborts parsing on first error. */ static class ProblemFactory implements IProblemFactory { public IProblem createProblem(char[] originatingFileName, int problemId, String[] arguments, int severity, int startPosition, int endPosition, int lineNumber) { throw new ParseError(); } public Locale getLocale() { return Locale.getDefault(); } public String getLocalizedMessage(int problemId, String[] problemArguments) { return "" + problemId; } } /** * RewriteInfos are used temporarily when rewriting the diff tree * in order to combine similar diff nodes ("smart folding"). */ static class RewriteInfo {
9,015
Bug 9015 Organize imports feature finds errors in assert statements
Eclipse version 2.0, build 20020125, Windows, installed JDK1.4RC3 from Sun, used as external compiler, Compilation settings Java 1.4 (source and bytecode). When I use asserts of the form assert xx != null; in the code and try to invoke the Organize Imports feature, I get an error Compilation unit has syntax errors: Line <someline>: Syntax error on token "!=", ",", ";" expected. The class runs fine and shows no errors / warnings otherwise. Organize imports work fine if I place assert expression in brackets, like this: assert (xx != null);
verified fixed
37083a2
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-04T19:23:25Z
2002-02-04T13:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaStructureCreator.java
boolean fIsOut= false; JavaNode fAncestor= null; JavaNode fLeft= null; JavaNode fRight= null; ArrayList fChildren= new ArrayList(); void add(IDiffElement diff) { fChildren.add(diff); } void setDiff(ICompareInput diff) { if (fIsOut) return; fIsOut= true; JavaNode a= (JavaNode) diff.getAncestor(); JavaNode y= (JavaNode) diff.getLeft(); JavaNode m= (JavaNode) diff.getRight(); if (a != null) { if (fAncestor != null)
9,015
Bug 9015 Organize imports feature finds errors in assert statements
Eclipse version 2.0, build 20020125, Windows, installed JDK1.4RC3 from Sun, used as external compiler, Compilation settings Java 1.4 (source and bytecode). When I use asserts of the form assert xx != null; in the code and try to invoke the Organize Imports feature, I get an error Compilation unit has syntax errors: Line <someline>: Syntax error on token "!=", ",", ";" expected. The class runs fine and shows no errors / warnings otherwise. Organize imports work fine if I place assert expression in brackets, like this: assert (xx != null);
verified fixed
37083a2
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-04T19:23:25Z
2002-02-04T13:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaStructureCreator.java
return; fAncestor= a; } if (y != null) { if (fLeft != null) return; fLeft= y; } if (m != null) { if (fRight != null) return; fRight= m; } fIsOut= false; } /** * Returns true if some nodes could be successfully combined into one. */ boolean matches() { return !fIsOut && fAncestor != null && fLeft != null && fRight != null; } } public JavaStructureCreator() { } /** * Returns the name that appears in the enclosing pane title bar.
9,015
Bug 9015 Organize imports feature finds errors in assert statements
Eclipse version 2.0, build 20020125, Windows, installed JDK1.4RC3 from Sun, used as external compiler, Compilation settings Java 1.4 (source and bytecode). When I use asserts of the form assert xx != null; in the code and try to invoke the Organize Imports feature, I get an error Compilation unit has syntax errors: Line <someline>: Syntax error on token "!=", ",", ";" expected. The class runs fine and shows no errors / warnings otherwise. Organize imports work fine if I place assert expression in brackets, like this: assert (xx != null);
verified fixed
37083a2
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-04T19:23:25Z
2002-02-04T13:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaStructureCreator.java
*/ public String getName() { return CompareMessages.getString("JavaStructureViewer.title"); } /** * Returns a tree of JavaNodes for the given input * which must implement the IStreamContentAccessor interface. * In case of error null is returned. */ public IStructureComparator getStructure(final Object input) { String contents= null; if (input instanceof IStreamContentAccessor) { IStreamContentAccessor sca= (IStreamContentAccessor) input; try { contents= JavaCompareUtilities.readString(sca.getContents()); } catch (CoreException ex) { JavaPlugin.log(ex); return null; } } if (contents != null) { int n= contents.length(); char[] buffer= new char[n]; contents.getChars(0, n, buffer, 0); Document doc= new Document(contents); IDocumentPartitioner dp= JavaCompareUtilities.createJavaPartitioner();
9,015
Bug 9015 Organize imports feature finds errors in assert statements
Eclipse version 2.0, build 20020125, Windows, installed JDK1.4RC3 from Sun, used as external compiler, Compilation settings Java 1.4 (source and bytecode). When I use asserts of the form assert xx != null; in the code and try to invoke the Organize Imports feature, I get an error Compilation unit has syntax errors: Line <someline>: Syntax error on token "!=", ",", ";" expected. The class runs fine and shows no errors / warnings otherwise. Organize imports work fine if I place assert expression in brackets, like this: assert (xx != null);
verified fixed
37083a2
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-04T19:23:25Z
2002-02-04T13:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaStructureCreator.java
if (dp != null) { doc.setDocumentPartitioner(dp); dp.connect(doc); } boolean isEditable= false; if (input instanceof IEditableContent) isEditable= ((IEditableContent) input).isEditable(); JavaNode root= new JavaNode(doc, isEditable) { void nodeChanged(JavaNode node) { save(this, input); } }; JavaParseTreeBuilder builder= new JavaParseTreeBuilder(root, buffer); SourceElementParser parser= new SourceElementParser(builder, new ProblemFactory(), new CompilerOptions()); try { parser.parseCompilationUnit(builder, false); } catch (ParseError ex) { return null; } return root; } return null; } /** * Returns true because this IStructureCreator knows how to save.
9,015
Bug 9015 Organize imports feature finds errors in assert statements
Eclipse version 2.0, build 20020125, Windows, installed JDK1.4RC3 from Sun, used as external compiler, Compilation settings Java 1.4 (source and bytecode). When I use asserts of the form assert xx != null; in the code and try to invoke the Organize Imports feature, I get an error Compilation unit has syntax errors: Line <someline>: Syntax error on token "!=", ",", ";" expected. The class runs fine and shows no errors / warnings otherwise. Organize imports work fine if I place assert expression in brackets, like this: assert (xx != null);
verified fixed
37083a2
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-04T19:23:25Z
2002-02-04T13:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaStructureCreator.java
*/ public boolean canSave() { return true; } public void save(IStructureComparator node, Object input) { if (node instanceof JavaNode && input instanceof IEditableContent) { IDocument document= ((JavaNode)node).getDocument(); IEditableContent bca= (IEditableContent) input; bca.setContent(document.get().getBytes()); } } /** * Returns the contents of the given node as a string. * This string is used to test the content of a Java element * for equality. Is is never shown in the UI, so any string representing * the content will do. * @param node must implement the IStreamContentAccessor interface * @param ignoreWhiteSpace if true all Java white space (incl. comments) is removed from the contents. */ public String getContents(Object node, boolean ignoreWhiteSpace) { if (! (node instanceof IStreamContentAccessor)) return null; IStreamContentAccessor sca= (IStreamContentAccessor) node; String content= null; try { content= JavaCompareUtilities.readString(sca.getContents());
9,015
Bug 9015 Organize imports feature finds errors in assert statements
Eclipse version 2.0, build 20020125, Windows, installed JDK1.4RC3 from Sun, used as external compiler, Compilation settings Java 1.4 (source and bytecode). When I use asserts of the form assert xx != null; in the code and try to invoke the Organize Imports feature, I get an error Compilation unit has syntax errors: Line <someline>: Syntax error on token "!=", ",", ";" expected. The class runs fine and shows no errors / warnings otherwise. Organize imports work fine if I place assert expression in brackets, like this: assert (xx != null);
verified fixed
37083a2
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-04T19:23:25Z
2002-02-04T13:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaStructureCreator.java
} catch (CoreException ex) { JavaPlugin.log(ex); return null; } if (ignoreWhiteSpace) { StringBuffer buf= new StringBuffer(); char[] b= content.toCharArray(); Scanner scanner= new Scanner(true, true); scanner.setSourceBuffer(b); try { int token; while ((token= scanner.getNextToken()) != TerminalSymbols.TokenNameEOF) { switch (token) { case Scanner.TokenNameWHITESPACE: case Scanner.TokenNameCOMMENT_BLOCK: case Scanner.TokenNameCOMMENT_JAVADOC: case Scanner.TokenNameCOMMENT_LINE: int l= buf.length(); if (l > 0 && buf.charAt(l-1) != ' ') buf.append(' '); break; default: buf.append(b, scanner.startPosition, scanner.currentPosition - scanner.startPosition); buf.append(' ');
9,015
Bug 9015 Organize imports feature finds errors in assert statements
Eclipse version 2.0, build 20020125, Windows, installed JDK1.4RC3 from Sun, used as external compiler, Compilation settings Java 1.4 (source and bytecode). When I use asserts of the form assert xx != null; in the code and try to invoke the Organize Imports feature, I get an error Compilation unit has syntax errors: Line <someline>: Syntax error on token "!=", ",", ";" expected. The class runs fine and shows no errors / warnings otherwise. Organize imports work fine if I place assert expression in brackets, like this: assert (xx != null);
verified fixed
37083a2
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-04T19:23:25Z
2002-02-04T13:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaStructureCreator.java
break; } } content= buf.toString(); } catch (InvalidInputException ex) { } } return content; } /** * Returns true since this IStructureCreator can rewrite the diff tree * in order to fold certain combinations of additons and deletions. */ public boolean canRewriteTree() { return true; } /** * Tries to detect certain combinations of additons and deletions * as renames or signature changes and foldes them into a single node. */ public void rewriteTree(Differencer differencer, IDiffContainer root) { HashMap map= new HashMap(10); Object[] children= root.getChildren(); for (int i= 0; i < children.length; i++) { DiffNode diff= (DiffNode) children[i]; JavaNode jn= (JavaNode) diff.getId();
9,015
Bug 9015 Organize imports feature finds errors in assert statements
Eclipse version 2.0, build 20020125, Windows, installed JDK1.4RC3 from Sun, used as external compiler, Compilation settings Java 1.4 (source and bytecode). When I use asserts of the form assert xx != null; in the code and try to invoke the Organize Imports feature, I get an error Compilation unit has syntax errors: Line <someline>: Syntax error on token "!=", ",", ";" expected. The class runs fine and shows no errors / warnings otherwise. Organize imports work fine if I place assert expression in brackets, like this: assert (xx != null);
verified fixed
37083a2
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-04T19:23:25Z
2002-02-04T13:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaStructureCreator.java
if (jn == null) continue; int type= jn.getTypeCode(); if (type == JavaNode.METHOD || type == JavaNode.CONSTRUCTOR) { String name= jn.extractMethodName(); RewriteInfo nameInfo= (RewriteInfo) map.get(name); if (nameInfo == null) { nameInfo= new RewriteInfo(); map.put(name, nameInfo); } nameInfo.add(diff); String argList= jn.extractArgumentList(); RewriteInfo argInfo= null; if (argList != null && !argList.equals("()")) { argInfo= (RewriteInfo) map.get(argList); if (argInfo == null) { argInfo= new RewriteInfo(); map.put(argList, argInfo); } argInfo.add(diff); }
9,015
Bug 9015 Organize imports feature finds errors in assert statements
Eclipse version 2.0, build 20020125, Windows, installed JDK1.4RC3 from Sun, used as external compiler, Compilation settings Java 1.4 (source and bytecode). When I use asserts of the form assert xx != null; in the code and try to invoke the Organize Imports feature, I get an error Compilation unit has syntax errors: Line <someline>: Syntax error on token "!=", ",", ";" expected. The class runs fine and shows no errors / warnings otherwise. Organize imports work fine if I place assert expression in brackets, like this: assert (xx != null);
verified fixed
37083a2
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-04T19:23:25Z
2002-02-04T13:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaStructureCreator.java
switch (diff.getKind() & Differencer.CHANGE_TYPE_MASK) { case Differencer.ADDITION: case Differencer.DELETION: if (type != JavaNode.CONSTRUCTOR) nameInfo.setDiff((ICompareInput)diff); if (argInfo != null) argInfo.setDiff((ICompareInput)diff); break; default: break; } } if (diff instanceof IDiffContainer) rewriteTree(differencer, (IDiffContainer)diff); } Iterator it= map.keySet().iterator(); while (it.hasNext()) { String name= (String) it.next(); RewriteInfo i= (RewriteInfo) map.get(name); if (i.matches()) {
9,015
Bug 9015 Organize imports feature finds errors in assert statements
Eclipse version 2.0, build 20020125, Windows, installed JDK1.4RC3 from Sun, used as external compiler, Compilation settings Java 1.4 (source and bytecode). When I use asserts of the form assert xx != null; in the code and try to invoke the Organize Imports feature, I get an error Compilation unit has syntax errors: Line <someline>: Syntax error on token "!=", ",", ";" expected. The class runs fine and shows no errors / warnings otherwise. Organize imports work fine if I place assert expression in brackets, like this: assert (xx != null);
verified fixed
37083a2
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-04T19:23:25Z
2002-02-04T13:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaStructureCreator.java
DiffNode d= (DiffNode) differencer.findDifferences(true, null, root, i.fAncestor, i.fLeft, i.fRight); if (d != null) { d.setDontExpand(true); Iterator it2= i.fChildren.iterator(); while (it2.hasNext()) { IDiffElement rd= (IDiffElement) it2.next(); root.removeToRoot(rd); d.add(rd); } } } } } /** * If selector is an IJavaElement this method tries to return an * IStructureComparator object for it. * In case of error or if the given selector cannot be found * null is returned. * @param selector the IJavaElement to extract * @param input must implement the IStreamContentAccessor interface. */ public IStructureComparator locate(Object selector, Object input) { if (!(selector instanceof IJavaElement)) return null; IStructureComparator structure= getStructure(input);
9,015
Bug 9015 Organize imports feature finds errors in assert statements
Eclipse version 2.0, build 20020125, Windows, installed JDK1.4RC3 from Sun, used as external compiler, Compilation settings Java 1.4 (source and bytecode). When I use asserts of the form assert xx != null; in the code and try to invoke the Organize Imports feature, I get an error Compilation unit has syntax errors: Line <someline>: Syntax error on token "!=", ",", ";" expected. The class runs fine and shows no errors / warnings otherwise. Organize imports work fine if I place assert expression in brackets, like this: assert (xx != null);
verified fixed
37083a2
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-04T19:23:25Z
2002-02-04T13:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaStructureCreator.java
if (structure == null) return null; String[] path= createPath((IJavaElement) selector); return find(structure, path, 0); } private static String[] createPath(IJavaElement je) { List args= new ArrayList(); while (je != null) { String name= JavaCompareUtilities.getJavaElementID(je); if (name == null) return null; args.add(name); if (je instanceof IWorkingCopy || je instanceof ICompilationUnit) break; je= je.getParent(); } int n= args.size(); String[] path= new String[n];
9,015
Bug 9015 Organize imports feature finds errors in assert statements
Eclipse version 2.0, build 20020125, Windows, installed JDK1.4RC3 from Sun, used as external compiler, Compilation settings Java 1.4 (source and bytecode). When I use asserts of the form assert xx != null; in the code and try to invoke the Organize Imports feature, I get an error Compilation unit has syntax errors: Line <someline>: Syntax error on token "!=", ",", ";" expected. The class runs fine and shows no errors / warnings otherwise. Organize imports work fine if I place assert expression in brackets, like this: assert (xx != null);
verified fixed
37083a2
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-04T19:23:25Z
2002-02-04T13:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaStructureCreator.java
for (int i= 0; i < n; i++) path[i]= (String) args.get(n-1-i); return path; } /** * Recursivly extracts the given path from the tree. */ private static IStructureComparator find(IStructureComparator tree, String[] path, int index) { if (tree != null) { Object[] children= tree.getChildren(); if (children != null) { for (int i= 0; i < children.length; i++) { IStructureComparator child= (IStructureComparator) children[i]; if (child instanceof ITypedElement && child instanceof DocumentRangeNode) { String n1= null; if (child instanceof DocumentRangeNode) n1= ((DocumentRangeNode)child).getId(); if (n1 == null) n1= ((ITypedElement)child).getName(); String n2= path[index]; if (n1.equals(n2)) { if (index == path.length-1) return child; IStructureComparator result= find(child, path, index+1); if (result != null) return result; } }
9,015
Bug 9015 Organize imports feature finds errors in assert statements
Eclipse version 2.0, build 20020125, Windows, installed JDK1.4RC3 from Sun, used as external compiler, Compilation settings Java 1.4 (source and bytecode). When I use asserts of the form assert xx != null; in the code and try to invoke the Organize Imports feature, I get an error Compilation unit has syntax errors: Line <someline>: Syntax error on token "!=", ",", ";" expected. The class runs fine and shows no errors / warnings otherwise. Organize imports work fine if I place assert expression in brackets, like this: assert (xx != null);
verified fixed
37083a2
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-04T19:23:25Z
2002-02-04T13:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/compare/JavaStructureCreator.java
} } } return null; } /** * Returns true if the given IJavaElement maps to a JavaNode. * The JavaHistoryAction uses this function to determine whether * a selected Java element can be replaced by some piece of * code from the local history. */ static boolean hasEdition(IJavaElement je) { if (je instanceof IMember && ((IMember)je).isBinary()) return false; switch (je.getElementType()) { case JavaElement.COMPILATION_UNIT: case JavaElement.TYPE: case JavaElement.FIELD: case JavaElement.METHOD: case JavaElement.INITIALIZER: case JavaElement.PACKAGE_DECLARATION: case JavaElement.IMPORT_CONTAINER: case JavaElement.IMPORT_DECLARATION: return true; } return false; } }
6,408
Bug 6408 Attempts to set breakpoint on unsaved resource fails
Create an empty class call Test Paste in: public static void main(String[] args) { while(true) { try { throwIt(); } catch (Exception e) { } } } public static void throwIt() throws InterruptedException { while(true) { Thread.yield(); } } Do NOT save Attempt to add a breakpoint on the Thread.yield() line We silently do not add the breakpoint.
verified fixed
596a9af
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-04T23:13:44Z
2001-11-28T23:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/BreakpointRulerAction.java
package org.eclipse.jdt.internal.ui.javaeditor; /* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ import java.util.ArrayList; import java.util.HashMap; import java.util.Iterator; import java.util.List; import java.util.Map; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IMarker; import org.eclipse.core.resources.IResource;
6,408
Bug 6408 Attempts to set breakpoint on unsaved resource fails
Create an empty class call Test Paste in: public static void main(String[] args) { while(true) { try { throwIt(); } catch (Exception e) { } } } public static void throwIt() throws InterruptedException { while(true) { Thread.yield(); } } Do NOT save Attempt to add a breakpoint on the Thread.yield() line We silently do not add the breakpoint.
verified fixed
596a9af
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-04T23:13:44Z
2001-11-28T23:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/BreakpointRulerAction.java
import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.core.runtime.CoreException; import org.eclipse.debug.core.DebugException; import org.eclipse.debug.core.DebugPlugin; import org.eclipse.debug.core.IBreakpointManager; import org.eclipse.debug.core.model.IBreakpoint; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.debug.core.IJavaBreakpoint; import org.eclipse.jdt.debug.core.IJavaLineBreakpoint; import org.eclipse.jdt.debug.core.JDIDebugModel; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jface.dialogs.ErrorDialog; import org.eclipse.jface.text.BadLocationException; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.IRegion; import org.eclipse.jface.text.source.IVerticalRuler; import org.eclipse.swt.widgets.Shell; import org.eclipse.ui.IEditorInput; import org.eclipse.ui.IFileEditorInput; import org.eclipse.ui.texteditor.AbstractMarkerAnnotationModel; import org.eclipse.ui.texteditor.ITextEditor; import org.eclipse.ui.texteditor.MarkerRulerAction; /** * */ public class BreakpointRulerAction extends MarkerRulerAction {
6,408
Bug 6408 Attempts to set breakpoint on unsaved resource fails
Create an empty class call Test Paste in: public static void main(String[] args) { while(true) { try { throwIt(); } catch (Exception e) { } } } public static void throwIt() throws InterruptedException { while(true) { Thread.yield(); } } Do NOT save Attempt to add a breakpoint on the Thread.yield() line We silently do not add the breakpoint.
verified fixed
596a9af
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-04T23:13:44Z
2001-11-28T23:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/BreakpointRulerAction.java
public BreakpointRulerAction(IVerticalRuler ruler, ITextEditor editor) { super(JavaEditorMessages.getResourceBundle(), "ManageBreakpoints.", ruler, editor, IBreakpoint.BREAKPOINT_MARKER, false); } /** * Checks whether the element the breakpoint refers to is shown in this editor */ protected boolean breakpointElementInEditor(IBreakpointManager manager, IMarker marker) { return true; } /** * @see MarkerRulerAction#getMarkers */ protected List getMarkers() { List breakpoints= new ArrayList(); IResource resource= getResource(); IDocument document= getDocument(); AbstractMarkerAnnotationModel model= getAnnotationModel();
6,408
Bug 6408 Attempts to set breakpoint on unsaved resource fails
Create an empty class call Test Paste in: public static void main(String[] args) { while(true) { try { throwIt(); } catch (Exception e) { } } } public static void throwIt() throws InterruptedException { while(true) { Thread.yield(); } } Do NOT save Attempt to add a breakpoint on the Thread.yield() line We silently do not add the breakpoint.
verified fixed
596a9af
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-04T23:13:44Z
2001-11-28T23:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/BreakpointRulerAction.java
if (model != null) { try { IMarker[] markers= null; if (resource instanceof IFile) markers= resource.findMarkers(IBreakpoint.BREAKPOINT_MARKER, true, IResource.DEPTH_INFINITE); else { IWorkspaceRoot root= JavaPlugin.getWorkspace().getRoot(); markers= root.findMarkers(IBreakpoint.BREAKPOINT_MARKER, true, IResource.DEPTH_INFINITE); } if (markers != null) { IBreakpointManager breakpointManager= DebugPlugin.getDefault().getBreakpointManager(); for (int i= 0; i < markers.length; i++) { IBreakpoint breakpoint= breakpointManager.getBreakpoint(markers[i]); if (breakpoint != null && breakpointManager.isRegistered(breakpoint) && breakpointElementInEditor(breakpointManager, markers[i]) && includesRulerLine(model.getMarkerPosition(markers[i]), document)) breakpoints.add(markers[i]); } } } catch (CoreException x) { JavaPlugin.logErrorStatus(JavaEditorMessages.getString("ManageBreakpoints.error.retrieving.message"), x.getStatus()); } } return breakpoints; } /**
6,408
Bug 6408 Attempts to set breakpoint on unsaved resource fails
Create an empty class call Test Paste in: public static void main(String[] args) { while(true) { try { throwIt(); } catch (Exception e) { } } } public static void throwIt() throws InterruptedException { while(true) { Thread.yield(); } } Do NOT save Attempt to add a breakpoint on the Thread.yield() line We silently do not add the breakpoint.
verified fixed
596a9af
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-04T23:13:44Z
2001-11-28T23:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/BreakpointRulerAction.java
* @see MarkerRulerAction#addMarker */ protected void addMarker() { IEditorInput editorInput= getTextEditor().getEditorInput(); IDocument document= getDocument(); int rulerLine= getVerticalRuler().getLineOfLastMouseButtonActivity(); try { BreakpointLocationVerifier bv = new BreakpointLocationVerifier(); int lineNumber = bv.getValidBreakpointLocation(document, rulerLine); if (lineNumber > 0) { IRegion line= document.getLineInformation(lineNumber - 1); IType type = null; if (editorInput instanceof IClassFileEditorInput) { IClassFileEditorInput input= (IClassFileEditorInput) editorInput; type = input.getClassFile().getType(); } else if (editorInput instanceof IFileEditorInput) { IFileEditorInput input= (IFileEditorInput) editorInput; ICompilationUnit cu = (ICompilationUnit) JavaCore.create(input.getFile()); IJavaElement e = cu.getElementAt(line.getOffset()); if (e instanceof IType) type = (IType)e; else if (e != null && e instanceof IMember) { type = ((IMember)e).getDeclaringType(); } }
6,408
Bug 6408 Attempts to set breakpoint on unsaved resource fails
Create an empty class call Test Paste in: public static void main(String[] args) { while(true) { try { throwIt(); } catch (Exception e) { } } } public static void throwIt() throws InterruptedException { while(true) { Thread.yield(); } } Do NOT save Attempt to add a breakpoint on the Thread.yield() line We silently do not add the breakpoint.
verified fixed
596a9af
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-04T23:13:44Z
2001-11-28T23:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/BreakpointRulerAction.java
if (type != null) { if (!JDIDebugModel.lineBreakpointExists(type.getFullyQualifiedName(), lineNumber)) { Map attributes = new HashMap(10); JavaCore.addJavaElementMarkerAttributes(attributes, type); attributes.put("org.eclipse.jdt.debug.ui.JAVA_ELEMENT_HANDLE_ID", type.getHandleIdentifier()); IJavaLineBreakpoint bp = JDIDebugModel.createLineBreakpoint(getBreakpointResource(type), type.getFullyQualifiedName(), lineNumber, line.getOffset(), line.getOffset() + line.getLength(), 0, true, attributes); } } } } catch (DebugException e) { Shell shell= getTextEditor().getSite().getShell(); ErrorDialog.openError(shell, JavaEditorMessages.getString("ManageBreakpoints.error.adding.title1"), JavaEditorMessages.getString("ManageBreakpoints.error.adding.message1"), e.getStatus()); } catch (CoreException e) { Shell shell= getTextEditor().getSite().getShell(); ErrorDialog.openError(shell, JavaEditorMessages.getString("ManageBreakpoints.error.adding.title2"), JavaEditorMessages.getString("ManageBreakpoints.error.adding.message2"), e.getStatus()); } catch (BadLocationException e) { Shell shell= getTextEditor().getSite().getShell(); ErrorDialog.openError(shell, JavaEditorMessages.getString("ManageBreakpoints.error.adding.title3"), JavaEditorMessages.getString("ManageBreakpoints.error.adding.message3"), null); } } /** * @see MarkerRulerAction#removeMarkers */ protected void removeMarkers(List markers) { IBreakpointManager breakpointManager= DebugPlugin.getDefault().getBreakpointManager(); try { Iterator e= markers.iterator(); while (e.hasNext()) {
6,408
Bug 6408 Attempts to set breakpoint on unsaved resource fails
Create an empty class call Test Paste in: public static void main(String[] args) { while(true) { try { throwIt(); } catch (Exception e) { } } } public static void throwIt() throws InterruptedException { while(true) { Thread.yield(); } } Do NOT save Attempt to add a breakpoint on the Thread.yield() line We silently do not add the breakpoint.
verified fixed
596a9af
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-04T23:13:44Z
2001-11-28T23:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/javaeditor/BreakpointRulerAction.java
IBreakpoint breakpoint= breakpointManager.getBreakpoint((IMarker) e.next()); breakpointManager.removeBreakpoint(breakpoint, true); } } catch (CoreException e) { Shell shell= getTextEditor().getSite().getShell(); ErrorDialog.openError(shell, JavaEditorMessages.getString("ManageBreakpoints.error.removing.title1"), JavaEditorMessages.getString("ManageBreakpoints.error.removing.message1"), e.getStatus()); } } /** * Returns the resource on which a breakpoint marker should * be created for the given member. The resource returned is the * associated file, or project in the case of a class file in * a jar. * * @param member member in which a breakpoint is being created * @return resource the resource on which a breakpoint marker * should be created * @exception CoreException if an exception occurrs accessing the * underlying resource or Java model elements */ public IResource getBreakpointResource(IMember member) throws CoreException { IResource res = member.getUnderlyingResource(); if (res == null) { res = member.getJavaProject().getProject(); } return res; } }
9,127
Bug 9127 JAR Packager: Path of exported resource wrong if src folder not under project
Create J project Create folder /x/y Define y as source folder ==> x/y appears as source folder ==> Files in x don't get exported ==> Path for resource files in x/y/ are wrong (i.e. contain /x/y) Note: *.java and *.class files are exported correctly.
resolved fixed
4dcd13b
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-05T19:30:36Z
2002-02-05T17:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/jarpackager/JarFileExportOperation.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.jarpackager; import java.io.ByteArrayInputStream; import java.io.ByteArrayOutputStream; import java.io.IOException; import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import java.util.Collections; import java.util.HashMap; import java.util.Iterator; import java.util.List; import java.util.Map; import java.util.jar.Manifest; import org.eclipse.core.resources.IContainer; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IFolder;
9,127
Bug 9127 JAR Packager: Path of exported resource wrong if src folder not under project
Create J project Create folder /x/y Define y as source folder ==> x/y appears as source folder ==> Files in x don't get exported ==> Path for resource files in x/y/ are wrong (i.e. contain /x/y) Note: *.java and *.class files are exported correctly.
resolved fixed
4dcd13b
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-05T19:30:36Z
2002-02-05T17:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/jarpackager/JarFileExportOperation.java
import org.eclipse.core.resources.IResource; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.MultiStatus; import org.eclipse.core.runtime.Status; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.operation.IRunnableWithProgress; import org.eclipse.jface.operation.ModalContext; import org.eclipse.jface.util.Assert; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.IFileEditorInput; import org.xml.sax.SAXException; import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.IPackageFragment; import org.eclipse.jdt.core.IPackageFragmentRoot; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.JavaStatusConstants; import org.eclipse.jdt.internal.ui.util.BusyIndicatorRunnableContext; /** * Operation for exporting a resource and its children to a new JAR file. */ public class JarFileExportOperation implements IRunnableWithProgress { private JarWriter fJarWriter; private JarPackage fJarPackage;
9,127
Bug 9127 JAR Packager: Path of exported resource wrong if src folder not under project
Create J project Create folder /x/y Define y as source folder ==> x/y appears as source folder ==> Files in x don't get exported ==> Path for resource files in x/y/ are wrong (i.e. contain /x/y) Note: *.java and *.class files are exported correctly.
resolved fixed
4dcd13b
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-05T19:30:36Z
2002-02-05T17:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/jarpackager/JarFileExportOperation.java
private IFile[] fDescriptionFiles; private Shell fParentShell; private Map fJavaNameToClassFilesMap; private IContainer fClassFilesMapContainer; private MultiStatus fProblems; /** * Creates an instance of this class. * * @param jarPackage the JAR package specification * @param parent the parent for the dialog, * or <code>null</code> if no dialog should be presented */ public JarFileExportOperation(JarPackage jarPackage, Shell parent) { this(parent); fJarPackage= jarPackage; } /** * Creates an instance of this class. * * @param descriptions an array with JAR package descriptions * @param parent the parent for the dialog, * or <code>null</code> if no dialog should be presented */ public JarFileExportOperation(IFile[] descriptions, Shell parent) { this(parent); fDescriptionFiles= descriptions; } /** * Adds a new warning to the list with the passed information.
9,127
Bug 9127 JAR Packager: Path of exported resource wrong if src folder not under project
Create J project Create folder /x/y Define y as source folder ==> x/y appears as source folder ==> Files in x don't get exported ==> Path for resource files in x/y/ are wrong (i.e. contain /x/y) Note: *.java and *.class files are exported correctly.
resolved fixed
4dcd13b
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-02-05T19:30:36Z
2002-02-05T17:26:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/jarpackager/JarFileExportOperation.java
* Normally the export operation continues after a warning. * @param message the message * @param exception the throwable that caused the warning, or <code>null</code> */ private JarFileExportOperation(Shell parent) { fParentShell= parent; fProblems= new MultiStatus(JavaPlugin.getPluginId(), JavaStatusConstants.INTERNAL_ERROR, JarPackagerMessages.getString("JarFileExportOperation.exportFinishedWithWarnings"), null); } protected void addWarning(String message, Throwable error) { if (fJarPackage == null || fJarPackage.logWarnings()) fProblems.add(new Status(IStatus.WARNING, JavaPlugin.getPluginId(), JavaStatusConstants.INTERNAL_ERROR, message, error)); } /** * Adds a new error to the list with the passed information. * Normally an error terminates the export operation. * @param message the message * @param exception the throwable that caused the error, or <code>null</code> */ protected void addError(String message, Throwable error) { if (fJarPackage == null || fJarPackage.logErrors()) fProblems.add(new Status(IStatus.ERROR, JavaPlugin.getPluginId(), JavaStatusConstants.INTERNAL_ERROR, message, error)); } /** * Answers the number of file resources specified by the JAR package. * * @return int */ protected int countSelectedElements() { int count= 0; Iterator iter= fJarPackage.getSelectedElements().iterator();