issue_id
int64
2.04k
425k
title
stringlengths
9
251
body
stringlengths
4
32.8k
status
stringclasses
6 values
after_fix_sha
stringlengths
7
7
project_name
stringclasses
6 values
repo_url
stringclasses
6 values
repo_name
stringclasses
6 values
language
stringclasses
1 value
issue_url
null
before_fix_sha
null
pull_url
null
commit_datetime
timestamp[us, tz=UTC]
report_datetime
timestamp[us, tz=UTC]
updated_file
stringlengths
23
187
chunk_content
stringlengths
1
22k
310,704
Bug 310704 Bug in ProgramElement.getCorrespondingType()
Here is the code for the method: public String getCorrespondingType(boolean getFullyQualifiedType) { String returnType = (String) kvpairs.get("returnType"); if (returnType == null) returnType = ""; if (getFullyQualifiedType) { return returnType; } int index = returnType.lastIndexOf("."); if (index != -1) { return returnType.substring(index); } return returnType; } the line: return returnType.substring(index); should be using 'index+1'
resolved fixed
a502da8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-28T01:05:35Z
2010-04-27T20:26:40Z
asm/src/org/aspectj/asm/internal/ProgramElement.java
setFormalComment(comment); this.modifiers = modifiers; }
310,704
Bug 310704 Bug in ProgramElement.getCorrespondingType()
Here is the code for the method: public String getCorrespondingType(boolean getFullyQualifiedType) { String returnType = (String) kvpairs.get("returnType"); if (returnType == null) returnType = ""; if (getFullyQualifiedType) { return returnType; } int index = returnType.lastIndexOf("."); if (index != -1) { return returnType.substring(index); } return returnType; } the line: return returnType.substring(index); should be using 'index+1'
resolved fixed
a502da8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-28T01:05:35Z
2010-04-27T20:26:40Z
asm/src/org/aspectj/asm/internal/ProgramElement.java
public int getRawModifiers() { return this.modifiers; } public List getModifiers() { return genModifiers(this.modifiers); } public Accessibility getAccessibility() { return genAccessibility(this.modifiers); } public void setDeclaringType(String t) { if (t != null && t.length() > 0) { if (kvpairs == Collections.EMPTY_MAP) kvpairs = new HashMap(); kvpairs.put("declaringType", t); } } public String getDeclaringType() { String dt = (String) kvpairs.get("declaringType"); if (dt == null) return ""; return dt; } public String getPackageName() { if (kind == Kind.PACKAGE) return getName(); if (getParent() == null) { return ""; } return getParent().getPackageName();
310,704
Bug 310704 Bug in ProgramElement.getCorrespondingType()
Here is the code for the method: public String getCorrespondingType(boolean getFullyQualifiedType) { String returnType = (String) kvpairs.get("returnType"); if (returnType == null) returnType = ""; if (getFullyQualifiedType) { return returnType; } int index = returnType.lastIndexOf("."); if (index != -1) { return returnType.substring(index); } return returnType; } the line: return returnType.substring(index); should be using 'index+1'
resolved fixed
a502da8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-28T01:05:35Z
2010-04-27T20:26:40Z
asm/src/org/aspectj/asm/internal/ProgramElement.java
} public Kind getKind() { return kind; } public boolean isCode() { return kind.equals(Kind.CODE); } public ISourceLocation getSourceLocation() { return sourceLocation; } public void setSourceLocation(ISourceLocation sourceLocation) { } public IMessage getMessage() { return (IMessage) kvpairs.get("message"); } public void setMessage(IMessage message) { if (kvpairs == Collections.EMPTY_MAP) kvpairs = new HashMap(); kvpairs.put("message", message); } public IProgramElement getParent() { return parent; } public void setParent(IProgramElement parent) { this.parent = parent;
310,704
Bug 310704 Bug in ProgramElement.getCorrespondingType()
Here is the code for the method: public String getCorrespondingType(boolean getFullyQualifiedType) { String returnType = (String) kvpairs.get("returnType"); if (returnType == null) returnType = ""; if (getFullyQualifiedType) { return returnType; } int index = returnType.lastIndexOf("."); if (index != -1) { return returnType.substring(index); } return returnType; } the line: return returnType.substring(index); should be using 'index+1'
resolved fixed
a502da8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-28T01:05:35Z
2010-04-27T20:26:40Z
asm/src/org/aspectj/asm/internal/ProgramElement.java
} public boolean isMemberKind() { return kind.isMember(); } public void setRunnable(boolean value) { if (kvpairs == Collections.EMPTY_MAP) kvpairs = new HashMap(); if (value) kvpairs.put("isRunnable", "true"); else kvpairs.remove("isRunnable"); } public boolean isRunnable() { return kvpairs.get("isRunnable") != null; } public boolean isImplementor() { return kvpairs.get("isImplementor") != null; } public void setImplementor(boolean value) { if (kvpairs == Collections.EMPTY_MAP) kvpairs = new HashMap(); if (value) kvpairs.put("isImplementor", "true"); else kvpairs.remove("isImplementor"); }
310,704
Bug 310704 Bug in ProgramElement.getCorrespondingType()
Here is the code for the method: public String getCorrespondingType(boolean getFullyQualifiedType) { String returnType = (String) kvpairs.get("returnType"); if (returnType == null) returnType = ""; if (getFullyQualifiedType) { return returnType; } int index = returnType.lastIndexOf("."); if (index != -1) { return returnType.substring(index); } return returnType; } the line: return returnType.substring(index); should be using 'index+1'
resolved fixed
a502da8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-28T01:05:35Z
2010-04-27T20:26:40Z
asm/src/org/aspectj/asm/internal/ProgramElement.java
public boolean isOverrider() { return kvpairs.get("isOverrider") != null; } public void setOverrider(boolean value) { if (kvpairs == Collections.EMPTY_MAP) kvpairs = new HashMap(); if (value) kvpairs.put("isOverrider", "true"); else kvpairs.remove("isOverrider"); } public List getRelations() { return (List) kvpairs.get("relations"); } public void setRelations(List relations) { if (relations.size() > 0) { if (kvpairs == Collections.EMPTY_MAP) kvpairs = new HashMap(); kvpairs.put("relations", relations); } } public String getFormalComment() { return (String) kvpairs.get("formalComment"); } public String toString() {
310,704
Bug 310704 Bug in ProgramElement.getCorrespondingType()
Here is the code for the method: public String getCorrespondingType(boolean getFullyQualifiedType) { String returnType = (String) kvpairs.get("returnType"); if (returnType == null) returnType = ""; if (getFullyQualifiedType) { return returnType; } int index = returnType.lastIndexOf("."); if (index != -1) { return returnType.substring(index); } return returnType; } the line: return returnType.substring(index); should be using 'index+1'
resolved fixed
a502da8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-28T01:05:35Z
2010-04-27T20:26:40Z
asm/src/org/aspectj/asm/internal/ProgramElement.java
return toLabelString(); } private static List genModifiers(int modifiers) { List modifiersList = new ArrayList(); if ((modifiers & AccStatic) != 0) modifiersList.add(IProgramElement.Modifiers.STATIC); if ((modifiers & AccFinal) != 0) modifiersList.add(IProgramElement.Modifiers.FINAL); if ((modifiers & AccSynchronized) != 0) modifiersList.add(IProgramElement.Modifiers.SYNCHRONIZED); if ((modifiers & AccVolatile) != 0) modifiersList.add(IProgramElement.Modifiers.VOLATILE); if ((modifiers & AccTransient) != 0) modifiersList.add(IProgramElement.Modifiers.TRANSIENT); if ((modifiers & AccNative) != 0) modifiersList.add(IProgramElement.Modifiers.NATIVE); if ((modifiers & AccAbstract) != 0) modifiersList.add(IProgramElement.Modifiers.ABSTRACT); return modifiersList; } public static IProgramElement.Accessibility genAccessibility(int modifiers) { if ((modifiers & AccPublic) != 0) return IProgramElement.Accessibility.PUBLIC; if ((modifiers & AccPrivate) != 0) return IProgramElement.Accessibility.PRIVATE; if ((modifiers & AccProtected) != 0) return IProgramElement.Accessibility.PROTECTED; if ((modifiers & AccPrivileged) != 0) return IProgramElement.Accessibility.PRIVILEGED; else
310,704
Bug 310704 Bug in ProgramElement.getCorrespondingType()
Here is the code for the method: public String getCorrespondingType(boolean getFullyQualifiedType) { String returnType = (String) kvpairs.get("returnType"); if (returnType == null) returnType = ""; if (getFullyQualifiedType) { return returnType; } int index = returnType.lastIndexOf("."); if (index != -1) { return returnType.substring(index); } return returnType; } the line: return returnType.substring(index); should be using 'index+1'
resolved fixed
a502da8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-28T01:05:35Z
2010-04-27T20:26:40Z
asm/src/org/aspectj/asm/internal/ProgramElement.java
return IProgramElement.Accessibility.PACKAGE; } public String getBytecodeName() { String s = (String) kvpairs.get("bytecodeName"); if (s == null) { return UNDEFINED; } return s; } public void setBytecodeName(String s) { if (kvpairs == Collections.EMPTY_MAP) kvpairs = new HashMap(); kvpairs.put("bytecodeName", s); } public void setBytecodeSignature(String s) { initMap(); kvpairs.put("bytecodeSignature", s); } public String getBytecodeSignature() { String s = (String) kvpairs.get("bytecodeSignature");
310,704
Bug 310704 Bug in ProgramElement.getCorrespondingType()
Here is the code for the method: public String getCorrespondingType(boolean getFullyQualifiedType) { String returnType = (String) kvpairs.get("returnType"); if (returnType == null) returnType = ""; if (getFullyQualifiedType) { return returnType; } int index = returnType.lastIndexOf("."); if (index != -1) { return returnType.substring(index); } return returnType; } the line: return returnType.substring(index); should be using 'index+1'
resolved fixed
a502da8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-28T01:05:35Z
2010-04-27T20:26:40Z
asm/src/org/aspectj/asm/internal/ProgramElement.java
return s; } private void initMap() { if (kvpairs == Collections.EMPTY_MAP) { kvpairs = new HashMap(); } } public String getSourceSignature() { return (String) kvpairs.get("sourceSignature"); } public void setSourceSignature(String string) { if (kvpairs == Collections.EMPTY_MAP) kvpairs = new HashMap(); kvpairs.put("sourceSignature", string); } public void setKind(Kind kind) { this.kind = kind; } public void setCorrespondingType(String s) { if (kvpairs == Collections.EMPTY_MAP) kvpairs = new HashMap();
310,704
Bug 310704 Bug in ProgramElement.getCorrespondingType()
Here is the code for the method: public String getCorrespondingType(boolean getFullyQualifiedType) { String returnType = (String) kvpairs.get("returnType"); if (returnType == null) returnType = ""; if (getFullyQualifiedType) { return returnType; } int index = returnType.lastIndexOf("."); if (index != -1) { return returnType.substring(index); } return returnType; } the line: return returnType.substring(index); should be using 'index+1'
resolved fixed
a502da8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-28T01:05:35Z
2010-04-27T20:26:40Z
asm/src/org/aspectj/asm/internal/ProgramElement.java
kvpairs.put("returnType", s); } public void setParentTypes(List ps) { if (kvpairs == Collections.EMPTY_MAP) kvpairs = new HashMap(); kvpairs.put("parentTypes", ps); } public List getParentTypes() { return (List) (kvpairs == null ? null : kvpairs.get("parentTypes")); } /** * {@inheritDoc} */ public void setAnnotationType(String fullyQualifiedAnnotationType) { if (kvpairs == Collections.EMPTY_MAP) { kvpairs = new HashMap(); } kvpairs.put("annotationType", fullyQualifiedAnnotationType); } /** * {@inheritDoc} */ public String getAnnotationType() { return (String) (kvpairs == null ? null : kvpairs.get("annotationType")); } public String getCorrespondingType() { return getCorrespondingType(false); } public String getCorrespondingType(boolean getFullyQualifiedType) {
310,704
Bug 310704 Bug in ProgramElement.getCorrespondingType()
Here is the code for the method: public String getCorrespondingType(boolean getFullyQualifiedType) { String returnType = (String) kvpairs.get("returnType"); if (returnType == null) returnType = ""; if (getFullyQualifiedType) { return returnType; } int index = returnType.lastIndexOf("."); if (index != -1) { return returnType.substring(index); } return returnType; } the line: return returnType.substring(index); should be using 'index+1'
resolved fixed
a502da8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-28T01:05:35Z
2010-04-27T20:26:40Z
asm/src/org/aspectj/asm/internal/ProgramElement.java
String returnType = (String) kvpairs.get("returnType"); if (returnType == null) returnType = ""; if (getFullyQualifiedType) { return returnType; } int index = returnType.lastIndexOf("."); if (index != -1) { return returnType.substring(index); } return returnType; } public String getName() { return name; } public List getChildren() { return children; } public void setChildren(List children) { this.children = children; if (children == null) return; for (Iterator it = children.iterator(); it.hasNext();) { ((IProgramElement) it.next()).setParent(this); } } public void addChild(IProgramElement child) { if (children == null || children == Collections.EMPTY_LIST) children = new ArrayList(); children.add(child);
310,704
Bug 310704 Bug in ProgramElement.getCorrespondingType()
Here is the code for the method: public String getCorrespondingType(boolean getFullyQualifiedType) { String returnType = (String) kvpairs.get("returnType"); if (returnType == null) returnType = ""; if (getFullyQualifiedType) { return returnType; } int index = returnType.lastIndexOf("."); if (index != -1) { return returnType.substring(index); } return returnType; } the line: return returnType.substring(index); should be using 'index+1'
resolved fixed
a502da8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-28T01:05:35Z
2010-04-27T20:26:40Z
asm/src/org/aspectj/asm/internal/ProgramElement.java
child.setParent(this); } public void addChild(int position, IProgramElement child) { if (children == null || children == Collections.EMPTY_LIST) children = new ArrayList(); children.add(position, child); child.setParent(this); } public boolean removeChild(IProgramElement child) { child.setParent(null); return children.remove(child); } public void setName(String string) { name = string; } public IProgramElement walk(HierarchyWalker walker) { if (children != null) { for (Iterator it = children.iterator(); it.hasNext();) { IProgramElement child = (IProgramElement) it.next(); walker.process(child); } } return this; } public String toLongString() { final StringBuffer buffer = new StringBuffer(); HierarchyWalker walker = new HierarchyWalker() { private int depth = 0; public void preProcess(IProgramElement node) { for (int i = 0; i < depth; i++)
310,704
Bug 310704 Bug in ProgramElement.getCorrespondingType()
Here is the code for the method: public String getCorrespondingType(boolean getFullyQualifiedType) { String returnType = (String) kvpairs.get("returnType"); if (returnType == null) returnType = ""; if (getFullyQualifiedType) { return returnType; } int index = returnType.lastIndexOf("."); if (index != -1) { return returnType.substring(index); } return returnType; } the line: return returnType.substring(index); should be using 'index+1'
resolved fixed
a502da8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-28T01:05:35Z
2010-04-27T20:26:40Z
asm/src/org/aspectj/asm/internal/ProgramElement.java
buffer.append(' '); buffer.append(node.toString()); buffer.append('\n'); depth += 2; } public void postProcess(IProgramElement node) { depth -= 2; } }; walker.process(this); return buffer.toString(); } public void setModifiers(int i) { this.modifiers = i; } /** * Convenience mechanism for setting new modifiers which do not require knowledge of the private internal representation * * @param newModifier */ public void addModifiers(IProgramElement.Modifiers newModifier) { modifiers |= newModifier.getBit(); } public String toSignatureString() { return toSignatureString(true); } public String toSignatureString(boolean getFullyQualifiedArgTypes) { StringBuffer sb = new StringBuffer(); sb.append(name); List ptypes = getParameterTypes();
310,704
Bug 310704 Bug in ProgramElement.getCorrespondingType()
Here is the code for the method: public String getCorrespondingType(boolean getFullyQualifiedType) { String returnType = (String) kvpairs.get("returnType"); if (returnType == null) returnType = ""; if (getFullyQualifiedType) { return returnType; } int index = returnType.lastIndexOf("."); if (index != -1) { return returnType.substring(index); } return returnType; } the line: return returnType.substring(index); should be using 'index+1'
resolved fixed
a502da8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-28T01:05:35Z
2010-04-27T20:26:40Z
asm/src/org/aspectj/asm/internal/ProgramElement.java
if (ptypes != null && (!ptypes.isEmpty() || this.kind.equals(IProgramElement.Kind.METHOD)) || this.kind.equals(IProgramElement.Kind.CONSTRUCTOR) || this.kind.equals(IProgramElement.Kind.ADVICE) || this.kind.equals(IProgramElement.Kind.POINTCUT) || this.kind.equals(IProgramElement.Kind.INTER_TYPE_METHOD) || this.kind.equals(IProgramElement.Kind.INTER_TYPE_CONSTRUCTOR)) { sb.append('('); for (Iterator it = ptypes.iterator(); it.hasNext();) { char[] arg = (char[]) it.next(); if (getFullyQualifiedArgTypes) { sb.append(arg); } else { int index = CharOperation.lastIndexOf('.', arg); if (index != -1) { sb.append(CharOperation.subarray(arg, index + 1, arg.length)); } else { sb.append(arg); } } if (it.hasNext()) sb.append(","); } sb.append(')'); } return sb.toString(); } /** * TODO: move the "parent != null"==>injar heuristic to more explicit */ public String toLinkLabelString() { return toLinkLabelString(true); }
310,704
Bug 310704 Bug in ProgramElement.getCorrespondingType()
Here is the code for the method: public String getCorrespondingType(boolean getFullyQualifiedType) { String returnType = (String) kvpairs.get("returnType"); if (returnType == null) returnType = ""; if (getFullyQualifiedType) { return returnType; } int index = returnType.lastIndexOf("."); if (index != -1) { return returnType.substring(index); } return returnType; } the line: return returnType.substring(index); should be using 'index+1'
resolved fixed
a502da8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-28T01:05:35Z
2010-04-27T20:26:40Z
asm/src/org/aspectj/asm/internal/ProgramElement.java
public String toLinkLabelString(boolean getFullyQualifiedArgTypes) { String label; if (kind == Kind.CODE || kind == Kind.INITIALIZER) { label = parent.getParent().getName() + ": "; } else if (kind.isInterTypeMember()) { if (shortITDNames) { label = ""; } else { int dotIndex = name.indexOf('.'); if (dotIndex != -1) { return parent.getName() + ": " + toLabelString().substring(dotIndex + 1); } else { label = parent.getName() + '.'; } } } else if (kind == Kind.CLASS || kind == Kind.ASPECT || kind == Kind.INTERFACE) { label = ""; } else if (kind.equals(Kind.DECLARE_PARENTS)) { label = ""; } else { if (parent != null) { label = parent.getName() + '.'; } else { label = "injar aspect: "; } } label += toLabelString(getFullyQualifiedArgTypes); return label; }
310,704
Bug 310704 Bug in ProgramElement.getCorrespondingType()
Here is the code for the method: public String getCorrespondingType(boolean getFullyQualifiedType) { String returnType = (String) kvpairs.get("returnType"); if (returnType == null) returnType = ""; if (getFullyQualifiedType) { return returnType; } int index = returnType.lastIndexOf("."); if (index != -1) { return returnType.substring(index); } return returnType; } the line: return returnType.substring(index); should be using 'index+1'
resolved fixed
a502da8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-28T01:05:35Z
2010-04-27T20:26:40Z
asm/src/org/aspectj/asm/internal/ProgramElement.java
public String toLabelString() { return toLabelString(true); } public String toLabelString(boolean getFullyQualifiedArgTypes) { String label = toSignatureString(getFullyQualifiedArgTypes); String details = getDetails(); if (details != null) { label += ": " + details; } return label; } public String getHandleIdentifier() { return getHandleIdentifier(true); } public String getHandleIdentifier(boolean create) { String h = handle; if (null == handle && create) { if (asm == null && name.equals("<build to view structure>")) { h = "<build to view structure>"; } else { try { h = asm.getHandleProvider().createHandleIdentifier(this); } catch (ArrayIndexOutOfBoundsException aioobe) { throw new RuntimeException("AIOOBE whilst building handle for " + this, aioobe); } } } setHandleIdentifier(h); return h; }
310,704
Bug 310704 Bug in ProgramElement.getCorrespondingType()
Here is the code for the method: public String getCorrespondingType(boolean getFullyQualifiedType) { String returnType = (String) kvpairs.get("returnType"); if (returnType == null) returnType = ""; if (getFullyQualifiedType) { return returnType; } int index = returnType.lastIndexOf("."); if (index != -1) { return returnType.substring(index); } return returnType; } the line: return returnType.substring(index); should be using 'index+1'
resolved fixed
a502da8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-28T01:05:35Z
2010-04-27T20:26:40Z
asm/src/org/aspectj/asm/internal/ProgramElement.java
public void setHandleIdentifier(String handle) { this.handle = handle; } public List getParameterNames() { List parameterNames = (List) kvpairs.get("parameterNames"); return parameterNames; } public void setParameterNames(List list) { if (list == null || list.size() == 0) return; if (kvpairs == Collections.EMPTY_MAP) kvpairs = new HashMap(); kvpairs.put("parameterNames", list); } public List getParameterTypes() { List l = getParameterSignatures(); if (l == null || l.isEmpty()) { return Collections.EMPTY_LIST; } List params = new ArrayList(); for (Iterator iter = l.iterator(); iter.hasNext();) { char[] param = (char[]) iter.next(); params.add(NameConvertor.convertFromSignature(param)); } return params; } public List getParameterSignatures() { List parameters = (List) kvpairs.get("parameterSigs"); return parameters;
310,704
Bug 310704 Bug in ProgramElement.getCorrespondingType()
Here is the code for the method: public String getCorrespondingType(boolean getFullyQualifiedType) { String returnType = (String) kvpairs.get("returnType"); if (returnType == null) returnType = ""; if (getFullyQualifiedType) { return returnType; } int index = returnType.lastIndexOf("."); if (index != -1) { return returnType.substring(index); } return returnType; } the line: return returnType.substring(index); should be using 'index+1'
resolved fixed
a502da8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-28T01:05:35Z
2010-04-27T20:26:40Z
asm/src/org/aspectj/asm/internal/ProgramElement.java
} public List getParameterSignaturesSourceRefs() { List parameters = (List) kvpairs.get("parameterSigsSourceRefs"); return parameters; } /** * Set the parameter signatures for this method/constructor. The bit flags tell us if any were not singletypereferences in the * the source. A singletypereference would be 'String' - whilst a qualifiedtypereference would be 'java.lang.String' - this has * an effect on the handles. */ public void setParameterSignatures(List list, List sourceRefs) { if (kvpairs == Collections.EMPTY_MAP) { kvpairs = new HashMap(); } if (list == null || list.size() == 0) { kvpairs.put("parameterSigs", Collections.EMPTY_LIST); } else { kvpairs.put("parameterSigs", list); } if (sourceRefs != null && sourceRefs.size() != 0) { kvpairs.put("parameterSigsSourceRefs", sourceRefs); } } public String getDetails() { String details = (String) kvpairs.get("details"); return details; } public void setDetails(String string) { if (kvpairs == Collections.EMPTY_MAP) kvpairs = new HashMap();
310,704
Bug 310704 Bug in ProgramElement.getCorrespondingType()
Here is the code for the method: public String getCorrespondingType(boolean getFullyQualifiedType) { String returnType = (String) kvpairs.get("returnType"); if (returnType == null) returnType = ""; if (getFullyQualifiedType) { return returnType; } int index = returnType.lastIndexOf("."); if (index != -1) { return returnType.substring(index); } return returnType; } the line: return returnType.substring(index); should be using 'index+1'
resolved fixed
a502da8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-28T01:05:35Z
2010-04-27T20:26:40Z
asm/src/org/aspectj/asm/internal/ProgramElement.java
kvpairs.put("details", string); } public void setFormalComment(String txt) { if (txt != null && txt.length() > 0) { if (kvpairs == Collections.EMPTY_MAP) kvpairs = new HashMap(); kvpairs.put("formalComment", txt); } } public void setExtraInfo(ExtraInformation info) { if (kvpairs == Collections.EMPTY_MAP) kvpairs = new HashMap(); kvpairs.put("ExtraInformation", info); } public ExtraInformation getExtraInfo() { return (ExtraInformation) kvpairs.get("ExtraInformation"); } public boolean isAnnotationStyleDeclaration() { return kvpairs.get("annotationStyleDeclaration") != null; } public void setAnnotationStyleDeclaration(boolean b) { if (b) { if (kvpairs == Collections.EMPTY_MAP) { kvpairs = new HashMap(); } kvpairs.put("annotationStyleDeclaration", "true"); } } }
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
/* ******************************************************************* * Copyright (c) 2003 Contributors. * All rights reserved. * This program and the accompanying materials are made available * under the terms of the Eclipse Public License v1.0 * which accompanies this distribution and is available at * http:www.eclipse.org/legal/epl-v10.html * * Contributors: * Mik Kersten initial implementation * Andy Clement incremental support and switch on/off state * ******************************************************************/ package org.aspectj.asm; import java.io.BufferedWriter; import java.io.EOFException; import java.io.File; import java.io.FileInputStream; import java.io.FileNotFoundException; import java.io.FileOutputStream; import java.io.FileWriter;
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
import java.io.IOException; import java.io.ObjectInputStream; import java.io.ObjectOutputStream; import java.io.Writer; import java.util.ArrayList; import java.util.Collection; import java.util.Enumeration; import java.util.HashMap; import java.util.HashSet; import java.util.Hashtable; import java.util.Iterator; import java.util.List; import java.util.Map; import java.util.Properties; import java.util.Set; import org.aspectj.asm.internal.AspectJElementHierarchy; import org.aspectj.asm.internal.HandleProviderDelimiter; import org.aspectj.asm.internal.JDTLikeHandleProvider; import org.aspectj.asm.internal.RelationshipMap; import org.aspectj.bridge.ISourceLocation; import org.aspectj.util.IStructureModel; /** * The Abstract Structure Model (ASM) represents the containment hierarchy and crosscutting structure map for AspectJ programs. It * is used by IDE views such as the document outline, and by other tools such as ajdoc to show both AspectJ declarations and * crosscutting links, such as which advice affects which join point shadows. * * @author Mik Kersten * @author Andy Clement */ public class AsmManager implements IStructureModel {
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
public static boolean recordingLastActiveStructureModel = true; public static AsmManager lastActiveStructureModel; public static boolean forceSingletonBehaviour = false; public static boolean attemptIncrementalModelRepairs = false; public static boolean dumpModelPostBuild = false; private static boolean dumpModel = false; private static boolean dumpRelationships = false; private static boolean dumpDeltaProcessing = false; private static IModelFilter modelFilter = null; private static String dumpFilename = ""; private static boolean reporting = false; private static boolean completingTypeBindings = false; private final List structureListeners = new ArrayList(); protected IHierarchy hierarchy; /* * Map from String > String - it maps absolute paths for inpath dirs/jars to workspace relative paths suitable for handle * inclusion
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
*/ protected Map inpathMap; private IRelationshipMap mapper; private IElementHandleProvider handleProvider; private final CanonicalFilePathMap canonicalFilePathMap = new CanonicalFilePathMap(); private final Set lastBuildChanges = new HashSet(); final Set aspectsWeavingInLastBuild = new HashSet(); private AsmManager() { } public static AsmManager createNewStructureModel(Map inpathMap) { if (forceSingletonBehaviour && lastActiveStructureModel != null) { return lastActiveStructureModel; } AsmManager asm = new AsmManager(); asm.inpathMap = inpathMap; asm.hierarchy = new AspectJElementHierarchy(asm); asm.mapper = new RelationshipMap(asm.hierarchy); asm.handleProvider = new JDTLikeHandleProvider(asm); asm.handleProvider.initialize(); asm.resetDeltaProcessing(); setLastActiveStructureModel(asm); return asm;
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
} public IHierarchy getHierarchy() { return hierarchy; } public IRelationshipMap getRelationshipMap() { return mapper; } public void fireModelUpdated() { notifyListeners(); if (dumpModelPostBuild && hierarchy.getConfigFile() != null) { writeStructureModel(hierarchy.getConfigFile()); } } /** * Constructs map each time it's called. */ public HashMap getInlineAnnotations(String sourceFile, boolean showSubMember, boolean showMemberAndType) { if (!hierarchy.isValid()) { return null; } HashMap annotations = new HashMap(); IProgramElement node = hierarchy.findElementForSourceFile(sourceFile); if (node == IHierarchy.NO_STRUCTURE) { return null; } else { IProgramElement fileNode = node; ArrayList peNodes = new ArrayList(); getAllStructureChildren(fileNode, peNodes, showSubMember, showMemberAndType); for (Iterator it = peNodes.iterator(); it.hasNext();) { IProgramElement peNode = (IProgramElement) it.next();
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
List entries = new ArrayList(); entries.add(peNode); ISourceLocation sourceLoc = peNode.getSourceLocation(); if (null != sourceLoc) { Integer hash = new Integer(sourceLoc.getLine()); List existingEntry = (List) annotations.get(hash); if (existingEntry != null) { entries.addAll(existingEntry); } annotations.put(hash, entries); } } return annotations; } } private void getAllStructureChildren(IProgramElement node, List result, boolean showSubMember, boolean showMemberAndType) { List children = node.getChildren(); if (node.getChildren() == null) { return; } for (Iterator it = children.iterator(); it.hasNext();) { IProgramElement next = (IProgramElement) it.next(); List rels = mapper.get(next); if (next != null && ((next.getKind() == IProgramElement.Kind.CODE && showSubMember) || (next.getKind() != IProgramElement.Kind.CODE && showMemberAndType)) && rels != null && rels.size() > 0) { result.add(next); } getAllStructureChildren(next, result, showSubMember, showMemberAndType); }
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
} public void addListener(IHierarchyListener listener) { structureListeners.add(listener); } public void removeStructureListener(IHierarchyListener listener) { structureListeners.remove(listener); } public void removeAllListeners() { structureListeners.clear(); } private void notifyListeners() { for (Iterator it = structureListeners.iterator(); it.hasNext();) { ((IHierarchyListener) it.next()).elementsUpdated(hierarchy); } } public IElementHandleProvider getHandleProvider() { return handleProvider; } public void setHandleProvider(IElementHandleProvider handleProvider) { this.handleProvider = handleProvider; } public void writeStructureModel(String configFilePath) { try { String filePath = genExternFilePath(configFilePath); FileOutputStream fos = new FileOutputStream(filePath); ObjectOutputStream s = new ObjectOutputStream(fos);
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
s.writeObject(hierarchy); s.writeObject(mapper); s.flush(); fos.flush(); fos.close(); s.close(); } catch (IOException e) { } } /** * @param configFilePath path to an ".lst" file */ public void readStructureModel(String configFilePath) { boolean hierarchyReadOK = false; try { if (configFilePath == null) { hierarchy.setRoot(IHierarchy.NO_STRUCTURE); } else { String filePath = genExternFilePath(configFilePath); FileInputStream in = new FileInputStream(filePath); ObjectInputStream s = new ObjectInputStream(in); hierarchy = (AspectJElementHierarchy) s.readObject(); ((AspectJElementHierarchy) hierarchy).setAsmManager(this); hierarchyReadOK = true; mapper = (RelationshipMap) s.readObject(); ((RelationshipMap) mapper).setHierarchy(hierarchy); }
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
} catch (FileNotFoundException fnfe) { hierarchy.setRoot(IHierarchy.NO_STRUCTURE); } catch (EOFException eofe) { if (!hierarchyReadOK) { System.err.println("AsmManager: Unable to read structure model: " + configFilePath + " because of:"); eofe.printStackTrace(); hierarchy.setRoot(IHierarchy.NO_STRUCTURE); } } catch (Exception e) { hierarchy.setRoot(IHierarchy.NO_STRUCTURE); } finally { notifyListeners(); } } private String genExternFilePath(String configFilePath) { if (configFilePath.lastIndexOf(".lst") != -1) { configFilePath = configFilePath.substring(0, configFilePath.lastIndexOf(".lst")); } return configFilePath + ".ajsym"; } public String getCanonicalFilePath(File f) { return canonicalFilePathMap.get(f); } private static class CanonicalFilePathMap {
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
private static final int MAX_SIZE = 4000; private final Map pathMap = new HashMap(20);
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
public String get(File f) {
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
String ret = (String) pathMap.get(f.getPath()); if (ret == null) { try { ret = f.getCanonicalPath(); } catch (IOException ioEx) { ret = f.getPath(); } pathMap.put(f.getPath(), ret); if (pathMap.size() > MAX_SIZE) { pathMap.clear(); } } return ret; } } public static void setReporting(String filename, boolean dModel, boolean dRels, boolean dDeltaProcessing, boolean deletefile) { reporting = true; dumpModel = dModel; dumpRelationships = dRels; dumpDeltaProcessing = dDeltaProcessing; if (deletefile) { new File(filename).delete(); } dumpFilename = filename; }
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
public static void setReporting(String filename, boolean dModel, boolean dRels, boolean dDeltaProcessing, boolean deletefile, IModelFilter aFilter) { setReporting(filename, dModel, dRels, dDeltaProcessing, deletefile); modelFilter = aFilter; } public static boolean isReporting() { return reporting; } public static void setDontReport() { reporting = false; dumpDeltaProcessing = false; dumpModel = false; dumpRelationships = false; } public void reportModelInfo(String reasonForReport) { if (!dumpModel && !dumpRelationships) { return; } try { FileWriter fw = new FileWriter(dumpFilename, true); BufferedWriter bw = new BufferedWriter(fw); if (dumpModel) { bw.write("=== MODEL STATUS REPORT ========= " + reasonForReport + "\n"); dumptree(bw, hierarchy.getRoot(), 0); bw.write("=== END OF MODEL REPORT =========\n");
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
} if (dumpRelationships) { bw.write("=== RELATIONSHIPS REPORT ========= " + reasonForReport + "\n"); dumprels(bw); bw.write("=== END OF RELATIONSHIPS REPORT ==\n"); } Properties p = summarizeModel().getProperties(); Enumeration pkeyenum = p.keys(); bw.write("=== Properties of the model and relationships map =====\n"); while (pkeyenum.hasMoreElements()) { String pkey = (String) pkeyenum.nextElement(); bw.write(pkey + "=" + p.getProperty(pkey) + "\n"); } bw.flush(); fw.close(); } catch (IOException e) { System.err.println("InternalError: Unable to report model information:"); e.printStackTrace(); } } public static void dumptree(Writer w, IProgramElement node, int indent) throws IOException { for (int i = 0; i < indent; i++) { w.write(" "); } String loc = ""; if (node != null) { if (node.getSourceLocation() != null) { loc = node.getSourceLocation().toString(); if (modelFilter != null) { loc = modelFilter.processFilelocation(loc);
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
} } } w.write(node + " [" + (node == null ? "null" : node.getKind().toString()) + "] " + loc + "\n"); if (node != null) { for (Iterator i = node.getChildren().iterator(); i.hasNext();) { dumptree(w, (IProgramElement) i.next(), indent + 2); } } } public static void dumptree(IProgramElement node, int indent) throws IOException { for (int i = 0; i < indent; i++) { System.out.print(" "); } String loc = ""; if (node != null) { if (node.getSourceLocation() != null) { loc = node.getSourceLocation().toString(); } } System.out.println(node + " [" + (node == null ? "null" : node.getKind().toString()) + "] " + loc); if (node != null) { for (Iterator i = node.getChildren().iterator(); i.hasNext();) { dumptree((IProgramElement) i.next(), indent + 2); } } } public void dumprels(Writer w) throws IOException { int ctr = 1; Set entries = mapper.getEntries();
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
for (Iterator iter = entries.iterator(); iter.hasNext();) { String hid = (String) iter.next(); List rels = mapper.get(hid); for (Iterator iterator = rels.iterator(); iterator.hasNext();) { IRelationship ir = (IRelationship) iterator.next(); List targets = ir.getTargets(); for (Iterator iterator2 = targets.iterator(); iterator2.hasNext();) { String thid = (String) iterator2.next(); StringBuffer sb = new StringBuffer(); if (modelFilter == null || modelFilter.wantsHandleIds()) { sb.append("Hid:" + (ctr++) + ":"); } sb.append("(targets=" + targets.size() + ") " + hid + " (" + ir.getName() + ") " + thid + "\n"); w.write(sb.toString()); } } } } private void dumprelsStderr(String key) { System.err.println("Relationships dump follows: " + key); int ctr = 1; Set entries = mapper.getEntries(); for (Iterator iter = entries.iterator(); iter.hasNext();) { String hid = (String) iter.next(); List rels = mapper.get(hid); for (Iterator iterator = rels.iterator(); iterator.hasNext();) { IRelationship ir = (IRelationship) iterator.next(); List targets = ir.getTargets(); for (Iterator iterator2 = targets.iterator(); iterator2.hasNext();) { String thid = (String) iterator2.next();
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
System.err.println("Hid:" + (ctr++) + ":(targets=" + targets.size() + ") " + hid + " (" + ir.getName() + ") " + thid); } } } System.err.println("End of relationships dump for: " + key); } /** * Removes the hierarchy structure for the specified files from the structure model. Returns true if it deleted anything */ public boolean removeStructureModelForFiles(Writer fw, Collection files) throws IOException { boolean modelModified = false; Set deletedNodes = new HashSet(); for (Iterator iter = files.iterator(); iter.hasNext();) { File fileForCompilation = (File) iter.next(); String correctedPath = getCanonicalFilePath(fileForCompilation); IProgramElement progElem = (IProgramElement) hierarchy.findInFileMap(correctedPath); if (progElem != null) { if (dumpDeltaProcessing) { fw.write("Deleting " + progElem + " node for file " + fileForCompilation + "\n"); } removeNode(progElem); lastBuildChanges.add(fileForCompilation); deletedNodes.add(getCanonicalFilePath(progElem.getSourceLocation().getSourceFile())); if (!hierarchy.removeFromFileMap(correctedPath)) { throw new RuntimeException("Whilst repairing model, couldn't remove entry for file: " + correctedPath + " from the filemap");
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
} modelModified = true; } } if (modelModified) { hierarchy.updateHandleMap(deletedNodes); } return modelModified; } public void fixupStructureModel(Writer fw, List filesToBeCompiled, Set files_added, Set files_deleted) throws IOException { boolean modelModified = false; Set filesToRemoveFromStructureModel = new HashSet(filesToBeCompiled); filesToRemoveFromStructureModel.addAll(files_deleted); Set deletedNodes = new HashSet(); for (Iterator iter = filesToRemoveFromStructureModel.iterator(); iter.hasNext();) { File fileForCompilation = (File) iter.next(); String correctedPath = getCanonicalFilePath(fileForCompilation); IProgramElement progElem = (IProgramElement) hierarchy.findInFileMap(correctedPath); if (progElem != null) {
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
if (dumpDeltaProcessing) { fw.write("Deleting " + progElem + " node for file " + fileForCompilation + "\n"); } removeNode(progElem); deletedNodes.add(getCanonicalFilePath(progElem.getSourceLocation().getSourceFile())); if (!hierarchy.removeFromFileMap(correctedPath)) { throw new RuntimeException("Whilst repairing model, couldn't remove entry for file: " + correctedPath + " from the filemap"); } modelModified = true; } } if (modelModified) { hierarchy.flushTypeMap(); hierarchy.updateHandleMap(deletedNodes); } } public void processDelta(Collection files_tobecompiled, Set files_added, Set files_deleted) { try { Writer fw = null; if (dumpDeltaProcessing) { FileWriter filew = new FileWriter(dumpFilename, true); fw = new BufferedWriter(filew); fw.write("=== Processing delta changes for the model ===\n"); fw.write("Files for compilation:#" + files_tobecompiled.size() + ":" + files_tobecompiled + "\n"); fw.write("Files added :#" + files_added.size() + ":" + files_added + "\n"); fw.write("Files deleted :#" + files_deleted.size() + ":" + files_deleted + "\n"); } long stime = System.currentTimeMillis();
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
removeStructureModelForFiles(fw, files_deleted); long etime1 = System.currentTimeMillis(); repairRelationships(fw); long etime2 = System.currentTimeMillis(); removeStructureModelForFiles(fw, files_tobecompiled); if (dumpDeltaProcessing) { fw.write("===== Delta Processing timing ==========\n"); fw.write("Hierarchy=" + (etime1 - stime) + "ms Relationshipmap=" + (etime2 - etime1) + "ms\n"); fw.write("===== Traversal ========================\n"); fw.write("========================================\n"); fw.flush(); fw.close(); } reportModelInfo("After delta processing"); } catch (IOException e) { e.printStackTrace(); } } private String getTypeNameFromHandle(String handle, Map cache) { String typename = (String) cache.get(handle); if (typename != null) { return typename;
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
} int hasPackage = handle.indexOf('<'); int typeLocation = handle.indexOf('['); if (typeLocation == -1) { typeLocation = handle.indexOf('}'); } if (typeLocation == -1) { return ""; } StringBuffer qualifiedTypeNameFromHandle = new StringBuffer(); if (hasPackage != -1) { qualifiedTypeNameFromHandle.append(handle.substring(hasPackage + 1, handle.indexOf('(', hasPackage))); qualifiedTypeNameFromHandle.append('.'); } qualifiedTypeNameFromHandle.append(handle.substring(typeLocation + 1)); typename = qualifiedTypeNameFromHandle.toString(); cache.put(handle, typename); return typename; } /** * two kinds of relationships * * A affects B B affectedBy A * * Both of these relationships are added when 'B' is modified. Concrete examples are 'advises/advisedby' or * 'annotates/annotatedby'. *
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
* What we need to do is when 'B' is going to be woven, remove all relationships that may reoccur when it is woven. So - remove * 'affects' relationships where the target is 'B', remove all 'affectedBy' relationships where the source is 'B'. * */ public void removeRelationshipsTargettingThisType(String typename) { boolean debug = false; if (debug) { System.err.println(">>removeRelationshipsTargettingThisType " + typename); } String pkg = null; String type = typename; int lastSep = typename.lastIndexOf('.'); if (lastSep != -1) { pkg = typename.substring(0, lastSep); type = typename.substring(lastSep + 1); } boolean didsomething = false; IProgramElement typeNode = hierarchy.findElementForType(pkg, type); if (typeNode == null) { return; } Set sourcesToRemove = new HashSet(); Map handleToTypenameCache = new HashMap();
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
Set sourcehandlesSet = mapper.getEntries(); List relationshipsToRemove = new ArrayList(); for (Iterator keyiter = sourcehandlesSet.iterator(); keyiter.hasNext();) { String hid = (String) keyiter.next(); if (isPhantomHandle(hid)) { if (!getTypeNameFromHandle(hid, handleToTypenameCache).equals(typename)) { continue; } } IProgramElement sourceElement = hierarchy.getElement(hid); if (sourceElement == null || sameType(hid, sourceElement, typeNode)) { relationshipsToRemove.clear(); List relationships = mapper.get(hid); for (Iterator reliter = relationships.iterator(); reliter.hasNext();) { IRelationship rel = (IRelationship) reliter.next(); if (rel.getKind() == IRelationship.Kind.USES_POINTCUT) { continue; } if (rel.isAffects()) { continue; } relationshipsToRemove.add(rel);
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
} if (relationshipsToRemove.size() > 0) { didsomething = true; if (relationshipsToRemove.size() == relationships.size()) { sourcesToRemove.add(hid); } else { for (int i = 0; i < relationshipsToRemove.size(); i++) { relationships.remove(relationshipsToRemove.get(i)); } } } } } for (Iterator srciter = sourcesToRemove.iterator(); srciter.hasNext();) { String hid = (String) srciter.next(); mapper.removeAll(hid); IProgramElement ipe = hierarchy.getElement(hid); if (ipe != null) { if (ipe.getKind().equals(IProgramElement.Kind.CODE)) { if (debug) { System.err.println(" source handle: it was code node, removing that as well... code=" + ipe + " parent=" + ipe.getParent()); } removeSingleNode(ipe);
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
} } } if (debug) { dumprelsStderr("after processing 'affectedby'"); } if (didsomething) { sourcesToRemove.clear(); if (debug) { dumprelsStderr("before processing 'affects'"); } sourcehandlesSet = mapper.getEntries(); for (Iterator keyiter = sourcehandlesSet.iterator(); keyiter.hasNext();) { String hid = (String) keyiter.next(); relationshipsToRemove.clear(); List relationships = mapper.get(hid); for (Iterator reliter = relationships.iterator(); reliter.hasNext();) { IRelationship rel = (IRelationship) reliter.next(); if (rel.getKind() == IRelationship.Kind.USES_POINTCUT) { continue; } if (!rel.isAffects()) { continue; } List targets = rel.getTargets(); List targetsToRemove = new ArrayList();
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
for (Iterator targetsIter = targets.iterator(); targetsIter.hasNext();) { String targethid = (String) targetsIter.next(); if (isPhantomHandle(hid) && !getTypeNameFromHandle(hid, handleToTypenameCache).equals(typename)) { continue; } IProgramElement existingTarget = hierarchy.getElement(targethid); if (existingTarget == null || sameType(targethid, existingTarget, typeNode)) { targetsToRemove.add(targethid); } } if (targetsToRemove.size() != 0) { if (targetsToRemove.size() == targets.size()) { relationshipsToRemove.add(rel); } else { for (Iterator targsIter = targetsToRemove.iterator(); targsIter.hasNext();) { String togo = (String) targsIter.next(); targets.remove(togo); } } } } if (relationshipsToRemove.size() > 0) { if (relationshipsToRemove.size() == relationships.size()) {
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
sourcesToRemove.add(hid); } else { for (int i = 0; i < relationshipsToRemove.size(); i++) { relationships.remove(relationshipsToRemove.get(i)); } } } } for (Iterator srciter = sourcesToRemove.iterator(); srciter.hasNext();) { String hid = (String) srciter.next(); mapper.removeAll(hid); IProgramElement ipe = hierarchy.getElement(hid); if (ipe != null) { if (ipe.getKind().equals(IProgramElement.Kind.CODE)) { if (debug) { System.err.println(" source handle: it was code node, removing that as well... code=" + ipe + " parent=" + ipe.getParent()); } removeSingleNode(ipe); } } } if (debug) { dumprelsStderr("after processing 'affects'"); }
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
} if (debug) { System.err.println("<<removeRelationshipsTargettingThisFile"); } } /** * Return true if the target element is in the type specified. */ private boolean sameType(String hid, IProgramElement target, IProgramElement type) { IProgramElement containingType = target; if (target == null) { throw new RuntimeException("target can't be null!"); } if (type == null) { throw new RuntimeException("type can't be null!"); } if (target.getKind().isSourceFile() || target.getKind().isFile()) { if (target.getSourceLocation() == null) { return false; }
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
if (type.getSourceLocation() == null) { return false; } if (target.getSourceLocation().getSourceFile() == null) { return false; } if (type.getSourceLocation().getSourceFile() == null) { return false; } return (target.getSourceLocation().getSourceFile().equals(type.getSourceLocation().getSourceFile())); } try { while (!containingType.getKind().isType()) { containingType = containingType.getParent(); } } catch (Throwable t) { throw new RuntimeException("Exception whilst walking up from target " + target.toLabelString() + " kind=(" + target.getKind() + ") hid=(" + target.getHandleIdentifier() + ")", t); } return (type.equals(containingType)); } /** * @param handle a JDT like handle, following the form described in AsmRelationshipProvider.findOrFakeUpNode * @return true if the handle contains ';' - the char indicating that it is a phantom handle */ private boolean isPhantomHandle(String handle) {
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
return handle.indexOf(HandleProviderDelimiter.PHANTOM.getDelimiter()) != -1; } /** * Go through all the relationships in the model, if any endpoints no longer exist (the node it points to has been deleted from * the model) then delete the relationship. */ private void repairRelationships(Writer fw) { try { if (dumpDeltaProcessing) { fw.write("Repairing relationships map:\n"); } Set sourcesToRemove = new HashSet(); Set nonExistingHandles = new HashSet(); int srchandlecounter = 0; int tgthandlecounter = 0; Set keyset = mapper.getEntries(); for (Iterator keyiter = keyset.iterator(); keyiter.hasNext();) { String hid = (String) keyiter.next(); srchandlecounter++;
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
if (nonExistingHandles.contains(hid)) { sourcesToRemove.add(hid); } else if (!isPhantomHandle(hid)) { IProgramElement existingElement = hierarchy.getElement(hid); if (dumpDeltaProcessing) { fw.write("Looking for handle [" + hid + "] in model, found: " + existingElement + "\n"); } if (existingElement == null) { sourcesToRemove.add(hid); nonExistingHandles.add(hid); } else { List relationships = mapper.get(hid); List relationshipsToRemove = new ArrayList(); for (Iterator reliter = relationships.iterator(); reliter.hasNext();) { IRelationship rel = (IRelationship) reliter.next(); List targets = rel.getTargets(); List targetsToRemove = new ArrayList(); for (Iterator targetIter = targets.iterator(); targetIter.hasNext();) { String targethid = (String) targetIter.next(); tgthandlecounter++; if (nonExistingHandles.contains(targethid)) { if (dumpDeltaProcessing) {
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
fw.write("Target handle [" + targethid + "] for srchid[" + hid + "]rel[" + rel.getName() + "] does not exist\n"); } targetsToRemove.add(targethid); } else if (!isPhantomHandle(targethid)) { IProgramElement existingTarget = hierarchy.getElement(targethid); if (existingTarget == null) { if (dumpDeltaProcessing) { fw.write("Target handle [" + targethid + "] for srchid[" + hid + "]rel[" + rel.getName() + "] does not exist\n"); } targetsToRemove.add(targethid); nonExistingHandles.add(targethid); } } } if (targetsToRemove.size() != 0) { if (targetsToRemove.size() == targets.size()) { if (dumpDeltaProcessing) { fw.write("No targets remain for srchid[" + hid + "] rel[" + rel.getName() + "]: removing it\n"); } relationshipsToRemove.add(rel); } else {
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
for (Iterator targsIter = targetsToRemove.iterator(); targsIter.hasNext();) { String togo = (String) targsIter.next(); targets.remove(togo); } if (targets.size() == 0) { if (dumpDeltaProcessing) { fw.write("No targets remain for srchid[" + hid + "] rel[" + rel.getName() + "]: removing it\n"); } relationshipsToRemove.add(rel); ? } } } } if (relationshipsToRemove.size() > 0) {
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
if (relationshipsToRemove.size() == relationships.size()) { sourcesToRemove.add(hid); } else { for (int i = 0; i < relationshipsToRemove.size(); i++) { IRelationship irel = (IRelationship) relationshipsToRemove.get(i); verifyAssumption(mapper.remove(hid, irel), "Failed to remove relationship " + irel.getName() + " for shid " + hid); } List rels = mapper.get(hid); if (rels == null || rels.size() == 0) { sourcesToRemove.add(hid); } } } } } } for (Iterator srciter = sourcesToRemove.iterator(); srciter.hasNext();) { String hid = (String) srciter.next(); mapper.removeAll(hid); IProgramElement ipe = hierarchy.getElement(hid); if (ipe != null) {
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
if (ipe.getKind().equals(IProgramElement.Kind.CODE)) { removeSingleNode(ipe); } } } } catch (IOException ioe) { System.err.println("Failed to repair relationships:"); ioe.printStackTrace(); } } /** * Removes a specified program element from the structure model. We go to the parent of the program element, ask for all its * children and remove the node we want to delete from the list of children. */ private void removeSingleNode(IProgramElement progElem) { if (progElem == null) { throw new IllegalStateException("AsmManager.removeNode(): programElement unexpectedly null"); } boolean deleteOK = false; IProgramElement parent = progElem.getParent(); List kids = parent.getChildren(); for (int i = 0; i < kids.size(); i++) { if (kids.get(i).equals(progElem)) { kids.remove(i); deleteOK = true; break; } } if (!deleteOK) {
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
throw new RuntimeException("Unable to delete the node from the model. trying to delete node for handle " + progElem.getHandleIdentifier()); } } /** * Removes a specified program element from the structure model. Two processing stages: * <p> * First: We go to the parent of the program element, ask for all its children and remove the node we want to delete from the * list of children. * <p> * Second:We check if that parent has any other children. If it has no other children and it is either a CODE node or a PACKAGE * node, we delete it too. */ private void removeNode(IProgramElement progElem) { try { if (progElem == null) { throw new IllegalStateException("AsmManager.removeNode(): programElement unexpectedly null"); } IProgramElement parent = progElem.getParent(); List kids = parent.getChildren(); for (int i = 0; i < kids.size(); i++) { if (kids.get(i).equals(progElem)) { kids.remove(i);
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
break; } } if (parent.getChildren().size() == 0 && parent.getParent() != null && (parent.getKind().equals(IProgramElement.Kind.CODE) || parent.getKind().equals(IProgramElement.Kind.PACKAGE))) { removeNode(parent); } } catch (NullPointerException npe) { npe.printStackTrace(); } } public static void verifyAssumption(boolean b, String info) { if (!b) { System.err.println("=========== ASSERTION IS NOT TRUE =========v"); System.err.println(info); Thread.dumpStack(); System.err.println("=========== ASSERTION IS NOT TRUE =========^");
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
throw new RuntimeException("Assertion is false"); } } public static void verifyAssumption(boolean b) { if (!b) { Thread.dumpStack(); throw new RuntimeException("Assertion is false"); } } /** * A ModelInfo object captures basic information about the structure model. It is used for testing and producing debug info. */ public static class ModelInfo { private final Hashtable nodeTypeCount = new Hashtable(); private final Properties extraProperties = new Properties(); private ModelInfo(IHierarchy hierarchy, IRelationshipMap relationshipMap) { IProgramElement ipe = hierarchy.getRoot(); walkModel(ipe); recordStat("FileMapSize", new Integer(hierarchy.getFileMapEntrySet().size()).toString()); recordStat("RelationshipMapSize", new Integer(relationshipMap.getEntries().size()).toString()); } private void walkModel(IProgramElement ipe) { countNode(ipe); List kids = ipe.getChildren(); for (Iterator iter = kids.iterator(); iter.hasNext();) { IProgramElement nextElement = (IProgramElement) iter.next(); walkModel(nextElement); }
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
} private void countNode(IProgramElement ipe) { String node = ipe.getKind().toString(); Integer ctr = (Integer) nodeTypeCount.get(node); if (ctr == null) { nodeTypeCount.put(node, new Integer(1)); } else { ctr = new Integer(ctr.intValue() + 1); nodeTypeCount.put(node, ctr); } } public String toString() { StringBuffer sb = new StringBuffer(); sb.append("Model node summary:\n"); Enumeration nodeKeys = nodeTypeCount.keys(); while (nodeKeys.hasMoreElements()) { String key = (String) nodeKeys.nextElement(); Integer ct = (Integer) nodeTypeCount.get(key); sb.append(key + "=" + ct + "\n"); } sb.append("Model stats:\n"); Enumeration ks = extraProperties.keys(); while (ks.hasMoreElements()) { String k = (String) ks.nextElement(); String v = extraProperties.getProperty(k); sb.append(k + "=" + v + "\n"); } return sb.toString(); } public Properties getProperties() {
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
Properties p = new Properties(); Enumeration nodeKeys = nodeTypeCount.keys(); while (nodeKeys.hasMoreElements()) { String key = (String) nodeKeys.nextElement(); Integer ct = (Integer) nodeTypeCount.get(key); p.setProperty(key, ct.toString()); } p.putAll(extraProperties); return p; } public void recordStat(String string, String string2) { extraProperties.setProperty(string, string2); } } public ModelInfo summarizeModel() { return new ModelInfo(getHierarchy(), getRelationshipMap()); } /** * Set to indicate whether we are currently building a structure model, should be set up front. */
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
public static void setCompletingTypeBindings(boolean b) { completingTypeBindings = b; } public static boolean isCompletingTypeBindings() { return completingTypeBindings; } public void resetDeltaProcessing() { lastBuildChanges.clear(); aspectsWeavingInLastBuild.clear(); } /** * @return the Set of files for which the structure model was modified (they may have been removed or otherwise rebuilt). Set is * empty for a full build. */ public Set getModelChangesOnLastBuild() { return lastBuildChanges; } /** * @return the Set of aspects that wove files on the last build (either incremental or full build) */ public Set getAspectsWeavingFilesOnLastBuild() { return aspectsWeavingInLastBuild;
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
} public void addAspectInEffectThisBuild(File f) { aspectsWeavingInLastBuild.add(f); } public static void setLastActiveStructureModel(AsmManager structureModel) { if (recordingLastActiveStructureModel) { lastActiveStructureModel = structureModel; } } public String getHandleElementForInpath(String binaryPath) { return (String) inpathMap.get(new File(binaryPath)); } private List pieces = new ArrayList(); private Object intern(String substring) { int lastIdx = -1; if ((lastIdx = substring.lastIndexOf('/')) != -1) { String pkg = substring.substring(0, lastIdx); String type = substring.substring(lastIdx + 1); pkg = internOneThing(pkg); type = internOneThing(type); return new String[] { pkg, type }; } else { return internOneThing(substring); } } private String internOneThing(String substring) { for (int p = 0, max = pieces.size(); p < max; p++) { String s = (String) pieces.get(p); if (s.equals(substring)) {
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
return s; } } pieces.add(substring); return substring; } /** * What we can rely on: <br> * - it is a method signature of the form (La/B;Lc/D;)LFoo;<br> * - there are no generics<br> * * What we must allow for: - may use primitive refs (single chars rather than L) */ /* * public List compress(String s) { int openParen = 0; int closeParen = s.indexOf(')'); int pos = 1; List compressed = new * ArrayList(); do the parens while (pos < closeParen) { char ch = s.charAt(pos); if (ch == 'L') { int idx = s.indexOf(';', * pos); compressed.add(intern(s.substring(pos + 1, idx))); pos = idx + 1; } else if (ch == '[') { int x = pos; while * (s.charAt(++pos) == '[') ; now pos will point at something not an array compressed.add(intern(s.substring(x, pos))); * intern the [[[[[[ char ch2 = s.charAt(pos); if (ch2 == 'L') { int idx = s.indexOf(';', pos); * compressed.add(intern(s.substring(pos + 1, idx))); pos = idx + 1; } else if (ch2 == 'T') { int idx = s.indexOf(';'); * compressed.add(intern(s.substring(pos, idx + 1))); should be TT; pos = idx + 1; } else { * compressed.add(toCharacter(s.charAt(pos))); pos++; } } else { it is a primitive ref (SVBCZJ) * compressed.add(toCharacter(ch)); pos++; } } do the return type pos++; char ch = s.charAt(pos); if (ch == 'L') { int idx = * s.indexOf(';', pos); compressed.add(intern(s.substring(pos, idx))); } else if (ch == '[') { int x = pos; while * (s.charAt(++pos) == '[') ; now pos will point at something not an array compressed.add(intern(s.substring(x, pos))); * intern the [[[[[[ char ch2 = s.charAt(pos); if (ch2 == 'L') { int idx = s.indexOf(';', pos); * compressed.add(intern(s.substring(pos + 1, idx))); pos = idx + 1; } else if (ch2 == 'T') { int idx = s.indexOf(';'); * compressed.add(intern(s.substring(pos, idx + 1))); should be TT; pos = idx + 2; } else { * compressed.add(toCharacter(s.charAt(pos))); pos++; } } else { it is a primitive ref (SVBCZJ) compressed.add(new * Character(ch)); } return compressed;
310,144
Bug 310144 java.lang.RuntimeException at AsmManager.java:1143
Build Identifier: Eclipse AspectJ Development Tools Version: 2.0.3.e35x-20100419-1200 AspectJ version: 1.6.9.20100416110000 java.lang.RuntimeException at org.aspectj.asm.AsmManager.removeSingleNode(AsmManager.java:1143) at org.aspectj.asm.AsmManager.removeRelationshipsTargettingThisType(AsmManager.java:798) at org.aspectj.weaver.bcel.BcelWeaver.weave(BcelWeaver.java:1173) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter.weaveQueuedEntries(AjPipeliningCompilerAdapter.java:455) at org.aspectj.ajdt.internal.compiler.AjPipeliningCompilerAdapter. ... for handle =xstm/stm<com.argilsoft.xstm.core{TKeyed.java[TKeyed[Visitor?field-set(java.util.ArrayList com.argilsoft.xstm.core.Visitor._continueStack) Reproducible: Sometimes Steps to Reproduce: Random exception popup in Eclipse
resolved fixed
728ecb8
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-04-29T19:54:09Z
2010-04-22T15:26:40Z
asm/src/org/aspectj/asm/AsmManager.java
* * char delimiter = '/'; int pos = -1; List compressed = new ArrayList(); int start = 0; while ((pos = * s.indexOf(delimiter, start)) != -1) { String part = s.substring(start, pos); int alreadyRecorded = * pieces.indexOf(part); if (alreadyRecorded != -1) { compressed.add(new Integer(alreadyRecorded)); else { * compressed.add(new Integer(pieces.size())); pieces.add(part); start = pos + 1; last piece String * part = s.substring(start, s.length()); int alreadyRecorded = pieces.indexOf(part); if (alreadyRecorded != -1) { * compressed.add(youkirtyounew Integer(alreadyRecorded)); else { compressed.add(new Integer(pieces.size())); * pieces.add(part); return compressed; } * * static final Character charB = new Character('B'); static final Character charS = new Character('S'); static final Character * charI = new Character('I'); static final Character charF = new Character('F'); static final Character charD = new * Character('D'); static final Character charJ = new Character('J'); static final Character charC = new Character('C'); static * final Character charV = new Character('V'); static final Character charZ = new Character('Z'); * * private Character toCharacter(char ch) { switch (ch) { case 'B': return charB; case 'S': return charS; case 'I': return * charI; case 'F': return charF; case 'D': return charD; case 'J': return charJ; case 'C': return charC; case 'V': return * charV; case 'Z': return charZ; default: throw new IllegalStateException(new Character(ch).toString()); } } * * public String decompress(List refs, char delimiter) { StringBuilder result = new StringBuilder(); result.append("("); for * (int i = 0, max = refs.size() - 1; i < max; i++) { result.append(unintern(refs.get(i))); } result.append(")"); * result.append(unintern(refs.get(refs.size() - 1))); return result.toString(); } * * private String unintern(Object o) { if (o instanceof Character) { return ((Character) o).toString(); } else if (o instanceof * String[]) { String[] strings = (String[]) o; StringBuilder sb = new StringBuilder(); sb.append('L'); * sb.append(strings[0]).append('/').append(strings[1]); sb.append(';'); return sb.toString(); } else { String String so = * (String) o; if (so.endsWith(";")) { will be TT; return so; } else { StringBuilder sb = new StringBuilder(); * sb.append('L'); sb.append(so); sb.append(';'); return sb.toString(); } } } */ }
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
/* ******************************************************************* * Copyright (c) 2002 Palo Alto Research Center, Incorporated (PARC). * All rights reserved. * This program and the accompanying materials are made available * under the terms of the Eclipse Public License v1.0 * which accompanies this distribution and is available at * http://www.eclipse.org/legal/epl-v10.html * * Contributors: * PARC initial implementation * ******************************************************************/ package org.aspectj.weaver.model; import java.io.File; import java.lang.reflect.Modifier; import java.util.ArrayList; import java.util.Collection; import java.util.Collections; import java.util.Iterator; import java.util.List; import org.aspectj.asm.AsmManager;
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
import org.aspectj.asm.IHierarchy; import org.aspectj.asm.IProgramElement; import org.aspectj.asm.IRelationship; import org.aspectj.asm.IRelationshipMap; import org.aspectj.asm.internal.HandleProviderDelimiter; import org.aspectj.asm.internal.ProgramElement; import org.aspectj.bridge.ISourceLocation; import org.aspectj.bridge.SourceLocation; import org.aspectj.weaver.Advice; import org.aspectj.weaver.AdviceKind; import org.aspectj.weaver.Checker; import org.aspectj.weaver.Lint; import org.aspectj.weaver.Member; import org.aspectj.weaver.NewParentTypeMunger; import org.aspectj.weaver.ReferenceType; import org.aspectj.weaver.ResolvedMember; import org.aspectj.weaver.ResolvedPointcutDefinition; import org.aspectj.weaver.ResolvedType; import org.aspectj.weaver.ResolvedTypeMunger; import org.aspectj.weaver.Shadow; import org.aspectj.weaver.ShadowMunger; import org.aspectj.weaver.UnresolvedType; import org.aspectj.weaver.World; import org.aspectj.weaver.ResolvedTypeMunger.Kind; import org.aspectj.weaver.bcel.BcelShadow; import org.aspectj.weaver.bcel.BcelTypeMunger; import org.aspectj.weaver.patterns.DeclareErrorOrWarning; import org.aspectj.weaver.patterns.DeclareParents; import org.aspectj.weaver.patterns.Pointcut; public class AsmRelationshipProvider {
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
public static final String ADVISES = "advises"; public static final String ADVISED_BY = "advised by"; public static final String DECLARES_ON = "declares on"; public static final String DECLAREDY_BY = "declared by"; public static final String SOFTENS = "softens"; public static final String SOFTENED_BY = "softened by"; public static final String MATCHED_BY = "matched by"; public static final String MATCHES_DECLARE = "matches declare"; public static final String INTER_TYPE_DECLARES = "declared on"; public static final String INTER_TYPE_DECLARED_BY = "aspect declarations"; public static final String ANNOTATES = "annotates"; public static final String ANNOTATED_BY = "annotated by"; /** * Add a relationship for a declare error or declare warning */
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
public static void addDeclareErrorOrWarningRelationship(AsmManager model, Shadow affectedShadow, Checker deow) { if (model == null) { return; } if (affectedShadow.getSourceLocation() == null || deow.getSourceLocation() == null) { return; } if (World.createInjarHierarchy) { createHierarchyForBinaryAspect(model, deow); } IProgramElement targetNode = getNode(model, affectedShadow); if (targetNode == null) { return; } String targetHandle = targetNode.getHandleIdentifier(); if (targetHandle == null) { return; } IProgramElement sourceNode = model.getHierarchy().findElementForSourceLine(deow.getSourceLocation()); String sourceHandle = sourceNode.getHandleIdentifier(); if (sourceHandle == null) { return; } IRelationshipMap relmap = model.getRelationshipMap(); IRelationship foreward = relmap.get(sourceHandle, IRelationship.Kind.DECLARE, MATCHED_BY, false, true); foreward.addTarget(targetHandle); IRelationship back = relmap.get(targetHandle, IRelationship.Kind.DECLARE, MATCHES_DECLARE, false, true); if (back != null && back.getTargets() != null) { back.addTarget(sourceHandle); }
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
if (sourceNode.getSourceLocation() != null) { model.addAspectInEffectThisBuild(sourceNode.getSourceLocation().getSourceFile()); } } private static boolean isMixinRelated(ResolvedTypeMunger typeTransformer) { Kind kind = typeTransformer.getKind(); return kind == ResolvedTypeMunger.MethodDelegate2 || kind == ResolvedTypeMunger.FieldHost || (kind == ResolvedTypeMunger.Parent && ((NewParentTypeMunger) typeTransformer).isMixin()); } /** * Add a relationship for a type transformation (declare parents, intertype method declaration, declare annotation on type). */ public static void addRelationship(AsmManager model, ResolvedType onType, ResolvedTypeMunger typeTransformer, ResolvedType originatingAspect) { if (model == null) { return; } if (World.createInjarHierarchy && isBinaryAspect(originatingAspect)) { createHierarchy(model, typeTransformer, originatingAspect); } if (originatingAspect.getSourceLocation() != null) { String sourceHandle = ""; IProgramElement sourceNode = null; if (typeTransformer.getSourceLocation() != null && typeTransformer.getSourceLocation().getOffset() != -1 && !isMixinRelated(typeTransformer)) { sourceNode = model.getHierarchy().findElementForType(originatingAspect.getPackageName(), originatingAspect.getClassName()); IProgramElement closer = model.getHierarchy().findCloserMatchForLineNumber(sourceNode, typeTransformer.getSourceLocation().getLine()); if (closer != null) {
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
sourceNode = closer; } if (sourceNode == null) { if (World.createInjarHierarchy) { createHierarchy(model, typeTransformer, originatingAspect); if (typeTransformer.getSourceLocation() != null && typeTransformer.getSourceLocation().getOffset() != -1 && !isMixinRelated(typeTransformer)) { sourceNode = model.getHierarchy().findElementForType(originatingAspect.getPackageName(), originatingAspect.getClassName()); IProgramElement closer2 = model.getHierarchy().findCloserMatchForLineNumber(sourceNode, typeTransformer.getSourceLocation().getLine()); if (closer2 != null) { sourceNode = closer2; } } else { sourceNode = model.getHierarchy().findElementForType(originatingAspect.getPackageName(), originatingAspect.getClassName()); } } } sourceHandle = sourceNode.getHandleIdentifier(); } else { sourceNode = model.getHierarchy().findElementForType(originatingAspect.getPackageName(), originatingAspect.getClassName());
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
sourceHandle = sourceNode.getHandleIdentifier(); } if (sourceHandle == null) { return; } String targetHandle = findOrFakeUpNode(model, onType); if (targetHandle == null) { return; } IRelationshipMap mapper = model.getRelationshipMap(); IRelationship foreward = mapper.get(sourceHandle, IRelationship.Kind.DECLARE_INTER_TYPE, INTER_TYPE_DECLARES, false, true); foreward.addTarget(targetHandle); IRelationship back = mapper.get(targetHandle, IRelationship.Kind.DECLARE_INTER_TYPE, INTER_TYPE_DECLARED_BY, false, true); back.addTarget(sourceHandle); if (sourceNode != null && sourceNode.getSourceLocation() != null) { model.addAspectInEffectThisBuild(sourceNode.getSourceLocation().getSourceFile()); }
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
} } private static String findOrFakeUpNode(AsmManager model, ResolvedType onType) { IHierarchy hierarchy = model.getHierarchy(); ISourceLocation sourceLocation = onType.getSourceLocation(); String canonicalFilePath = model.getCanonicalFilePath(sourceLocation.getSourceFile()); int lineNumber = sourceLocation.getLine(); IProgramElement node = hierarchy.findNodeForSourceFile(hierarchy.getRoot(), canonicalFilePath); if (node == null) { String bpath = onType.getBinaryPath(); if (bpath == null) { return model.getHandleProvider().createHandleIdentifier(createFileStructureNode(model, canonicalFilePath)); } else { IProgramElement programElement = model.getHierarchy().getRoot(); StringBuffer phantomHandle = new StringBuffer(); phantomHandle.append(programElement.getHandleIdentifier()); phantomHandle.append(HandleProviderDelimiter.PACKAGEFRAGMENTROOT.getDelimiter()).append( HandleProviderDelimiter.PHANTOM.getDelimiter()); int pos = bpath.indexOf('!'); if (pos != -1) { String jarPath = bpath.substring(0, pos); String element = model.getHandleElementForInpath(jarPath); if (element != null) { phantomHandle.append(element);
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
} } String packageName = onType.getPackageName(); phantomHandle.append(HandleProviderDelimiter.PACKAGEFRAGMENT.getDelimiter()).append(packageName); int dotClassPosition = bpath.lastIndexOf(".class"); if (dotClassPosition == -1) { phantomHandle.append(HandleProviderDelimiter.CLASSFILE.getDelimiter()).append("UNKNOWN.class"); } else { int startPosition = dotClassPosition; char ch; while (startPosition > 0 && ((ch = bpath.charAt(startPosition)) != '/' && ch != '\\' && ch != '!')) { startPosition--; } String classFile = bpath.substring(startPosition + 1, dotClassPosition + 6); phantomHandle.append(HandleProviderDelimiter.CLASSFILE.getDelimiter()).append(classFile); } phantomHandle.append(HandleProviderDelimiter.TYPE.getDelimiter()).append(onType.getClassName()); return phantomHandle.toString(); } } else { IProgramElement closernode = hierarchy.findCloserMatchForLineNumber(node, lineNumber); if (closernode == null) { return node.getHandleIdentifier(); } else { return closernode.getHandleIdentifier();
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
} } } public static IProgramElement createFileStructureNode(AsmManager asm, String sourceFilePath) { int lastSlash = sourceFilePath.lastIndexOf('\\'); if (lastSlash == -1) { lastSlash = sourceFilePath.lastIndexOf('/'); } int i = sourceFilePath.lastIndexOf('!'); int j = sourceFilePath.indexOf(".class"); if (i > lastSlash && i != -1 && j != -1) { lastSlash = i; } String fileName = sourceFilePath.substring(lastSlash + 1); IProgramElement fileNode = new ProgramElement(asm, fileName, IProgramElement.Kind.FILE_JAVA, new SourceLocation(new File( sourceFilePath), 1, 1), 0, null, null); fileNode.addChild(IHierarchy.NO_STRUCTURE); return fileNode; } private static boolean isBinaryAspect(ResolvedType aspect) { return aspect.getBinaryPath() != null; } /** * Returns the binarySourceLocation for the given sourcelocation. This isn't cached because it's used when faulting in the * binary nodes and is called with ISourceLocations for all advice, pointcuts and deows contained within the * resolvedDeclaringAspect.
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
*/ private static ISourceLocation getBinarySourceLocation(ResolvedType aspect, ISourceLocation sl) { if (sl == null) { return null; } String sourceFileName = null; if (aspect instanceof ReferenceType) { String s = ((ReferenceType) aspect).getDelegate().getSourcefilename(); int i = s.lastIndexOf('/'); if (i != -1) { sourceFileName = s.substring(i + 1); } else { sourceFileName = s; } } ISourceLocation sLoc = new SourceLocation(getBinaryFile(aspect), sl.getLine(), sl.getEndLine(), ((sl.getColumn() == 0) ? ISourceLocation.NO_COLUMN : sl.getColumn()), sl.getContext(), sourceFileName); return sLoc; } private static ISourceLocation createSourceLocation(String sourcefilename, ResolvedType aspect, ISourceLocation sl) { ISourceLocation sLoc = new SourceLocation(getBinaryFile(aspect), sl.getLine(), sl.getEndLine(), ((sl.getColumn() == 0) ? ISourceLocation.NO_COLUMN : sl.getColumn()), sl.getContext(), sourcefilename); return sLoc; } private static String getSourceFileName(ResolvedType aspect) { String sourceFileName = null; if (aspect instanceof ReferenceType) { String s = ((ReferenceType) aspect).getDelegate().getSourcefilename(); int i = s.lastIndexOf('/'); if (i != -1) {
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
sourceFileName = s.substring(i + 1); } else { sourceFileName = s; } } return sourceFileName; } /** * Returns the File with pathname to the class file, for example either C:\temp * \ajcSandbox\workspace\ajcTest16957.tmp\simple.jar!pkg\BinaryAspect.class if the class file is in a jar file, or * C:\temp\ajcSandbox\workspace\ajcTest16957.tmp!pkg\BinaryAspect.class if the class file is in a directory */ private static File getBinaryFile(ResolvedType aspect) { String s = aspect.getBinaryPath(); File f = aspect.getSourceLocation().getSourceFile(); int i = f.getPath().lastIndexOf('.'); String path = null; if (i != -1) { path = f.getPath().substring(0, i) + ".class"; } else { path = f.getPath() + ".class"; } return new File(s + "!" + path); } /** * Create a basic hierarchy to represent an aspect only available in binary (from the aspectpath). */ private static void createHierarchy(AsmManager model, ResolvedTypeMunger typeTransformer, ResolvedType aspect) {
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
IProgramElement filenode = model.getHierarchy().findElementForSourceLine(typeTransformer.getSourceLocation()); if (filenode == null) { if (typeTransformer.getKind() == ResolvedTypeMunger.MethodDelegate2 || typeTransformer.getKind() == ResolvedTypeMunger.FieldHost) { return; } } if (!filenode.getKind().equals(IProgramElement.Kind.FILE_JAVA)) { return; } ISourceLocation binLocation = getBinarySourceLocation(aspect, aspect.getSourceLocation()); String f = getBinaryFile(aspect).getName(); IProgramElement classFileNode = new ProgramElement(model, f, IProgramElement.Kind.FILE, binLocation, 0, null, null); IProgramElement root = model.getHierarchy().getRoot(); IProgramElement binaries = model.getHierarchy().findElementForLabel(root, IProgramElement.Kind.SOURCE_FOLDER, "binaries");
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
if (binaries == null) { binaries = new ProgramElement(model, "binaries", IProgramElement.Kind.SOURCE_FOLDER, new ArrayList()); root.addChild(binaries); } String packagename = aspect.getPackageName() == null ? "" : aspect.getPackageName(); IProgramElement pkgNode = model.getHierarchy().findElementForLabel(binaries, IProgramElement.Kind.PACKAGE, packagename); if (pkgNode == null) { pkgNode = new ProgramElement(model, packagename, IProgramElement.Kind.PACKAGE, new ArrayList()); binaries.addChild(pkgNode); pkgNode.addChild(classFileNode); } else { pkgNode.addChild(classFileNode); for (Iterator iter = pkgNode.getChildren().iterator(); iter.hasNext();) { IProgramElement element = (IProgramElement) iter.next(); if (!element.equals(classFileNode) && element.getHandleIdentifier().equals(classFileNode.getHandleIdentifier())) { pkgNode.removeChild(classFileNode); return; } } }
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
IProgramElement aspectNode = new ProgramElement(model, aspect.getSimpleName(), IProgramElement.Kind.ASPECT, getBinarySourceLocation(aspect, aspect.getSourceLocation()), aspect.getModifiers(), null, null); classFileNode.addChild(aspectNode); addChildNodes(model, aspect, aspectNode, aspect.getDeclaredPointcuts()); addChildNodes(model, aspect, aspectNode, aspect.getDeclaredAdvice()); addChildNodes(model, aspect, aspectNode, aspect.getDeclares()); addChildNodes(model, aspect, aspectNode, aspect.getTypeMungers()); } /**
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
* Adds a declare annotation relationship, sometimes entities don't have source locs (methods/fields) so use other variants of * this method if that is the case as they will look the entities up in the structure model. */ public static void addDeclareAnnotationRelationship(AsmManager model, ISourceLocation declareAnnotationLocation, ISourceLocation annotatedLocation) { if (model == null) { return; } IProgramElement sourceNode = model.getHierarchy().findElementForSourceLine(declareAnnotationLocation); String sourceHandle = sourceNode.getHandleIdentifier(); if (sourceHandle == null) { return; } IProgramElement targetNode = model.getHierarchy().findElementForSourceLine(annotatedLocation); String targetHandle = targetNode.getHandleIdentifier(); if (targetHandle == null) { return; } IRelationshipMap mapper = model.getRelationshipMap(); IRelationship foreward = mapper.get(sourceHandle, IRelationship.Kind.DECLARE_INTER_TYPE, ANNOTATES, false, true); foreward.addTarget(targetHandle); IRelationship back = mapper.get(targetHandle, IRelationship.Kind.DECLARE_INTER_TYPE, ANNOTATED_BY, false, true); back.addTarget(sourceHandle); if (sourceNode.getSourceLocation() != null) { model.addAspectInEffectThisBuild(sourceNode.getSourceLocation().getSourceFile()); } } /** * Creates the hierarchy for binary aspects */
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
public static void createHierarchyForBinaryAspect(AsmManager asm, ShadowMunger munger) { if (!munger.isBinary()) { return; } IProgramElement sourceFileNode = asm.getHierarchy().findElementForSourceLine(munger.getSourceLocation()); if (!sourceFileNode.getKind().equals(IProgramElement.Kind.FILE_JAVA)) { return; } ResolvedType aspect = munger.getDeclaringType(); IProgramElement classFileNode = new ProgramElement(asm, sourceFileNode.getName(), IProgramElement.Kind.FILE, munger .getBinarySourceLocation(aspect.getSourceLocation()), 0, null, null); IProgramElement root = asm.getHierarchy().getRoot(); IProgramElement binaries = asm.getHierarchy().findElementForLabel(root, IProgramElement.Kind.SOURCE_FOLDER, "binaries"); if (binaries == null) { binaries = new ProgramElement(asm, "binaries", IProgramElement.Kind.SOURCE_FOLDER, new ArrayList()); root.addChild(binaries); } String packagename = aspect.getPackageName() == null ? "" : aspect.getPackageName(); IProgramElement pkgNode = asm.getHierarchy().findElementForLabel(binaries, IProgramElement.Kind.PACKAGE, packagename);
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
if (pkgNode == null) { pkgNode = new ProgramElement(asm, packagename, IProgramElement.Kind.PACKAGE, new ArrayList()); binaries.addChild(pkgNode); pkgNode.addChild(classFileNode); } else { pkgNode.addChild(classFileNode); for (Iterator iter = pkgNode.getChildren().iterator(); iter.hasNext();) { IProgramElement element = (IProgramElement) iter.next(); if (!element.equals(classFileNode) && element.getHandleIdentifier().equals(classFileNode.getHandleIdentifier())) { pkgNode.removeChild(classFileNode); return; } } }
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
IProgramElement aspectNode = new ProgramElement(asm, aspect.getSimpleName(), IProgramElement.Kind.ASPECT, munger .getBinarySourceLocation(aspect.getSourceLocation()), aspect.getModifiers(), null, null); classFileNode.addChild(aspectNode); String sourcefilename = getSourceFileName(aspect); addPointcuts(asm, sourcefilename, aspect, aspectNode, aspect.getDeclaredPointcuts()); addChildNodes(asm, aspect, aspectNode, aspect.getDeclaredAdvice()); addChildNodes(asm, aspect, aspectNode, aspect.getDeclares()); addChildNodes(asm, aspect, aspectNode, aspect.getTypeMungers()); } private static void addPointcuts(AsmManager model, String sourcefilename, ResolvedType aspect, IProgramElement containingAspect, ResolvedMember[] pointcuts) { for (int i = 0; i < pointcuts.length; i++) { ResolvedMember pointcut = pointcuts[i]; if (pointcut instanceof ResolvedPointcutDefinition) { ResolvedPointcutDefinition rpcd = (ResolvedPointcutDefinition) pointcut; Pointcut p = rpcd.getPointcut(); ISourceLocation sLoc = (p == null ? null : p.getSourceLocation()); if (sLoc == null) {
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
sLoc = rpcd.getSourceLocation(); } ISourceLocation pointcutLocation = createSourceLocation(sourcefilename, aspect, sLoc); ProgramElement pointcutElement = new ProgramElement(model, pointcut.getName(), IProgramElement.Kind.POINTCUT, pointcutLocation, pointcut.getModifiers(), NO_COMMENT, Collections.EMPTY_LIST); containingAspect.addChild(pointcutElement); } } } private static final String NO_COMMENT = null; private static void addChildNodes(AsmManager asm, ResolvedType aspect, IProgramElement parent, ResolvedMember[] children) { for (int i = 0; i < children.length; i++) { ResolvedMember pcd = children[i]; if (pcd instanceof ResolvedPointcutDefinition) { ResolvedPointcutDefinition rpcd = (ResolvedPointcutDefinition) pcd; Pointcut p = rpcd.getPointcut(); ISourceLocation sLoc = (p == null ? null : p.getSourceLocation()); if (sLoc == null) { sLoc = rpcd.getSourceLocation(); } parent.addChild(new ProgramElement(asm, pcd.getName(), IProgramElement.Kind.POINTCUT, getBinarySourceLocation( aspect, sLoc), pcd.getModifiers(), null, Collections.EMPTY_LIST)); } } } private static void addChildNodes(AsmManager asm, ResolvedType aspect, IProgramElement parent, Collection children) { int deCtr = 1; int dwCtr = 1; for (Iterator iter = children.iterator(); iter.hasNext();) { Object element = iter.next();
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
if (element instanceof DeclareErrorOrWarning) { DeclareErrorOrWarning decl = (DeclareErrorOrWarning) element; int counter = 0; if (decl.isError()) { counter = deCtr++; } else { counter = dwCtr++; } parent.addChild(createDeclareErrorOrWarningChild(asm, aspect, decl, counter)); } else if (element instanceof Advice) { Advice advice = (Advice) element; parent.addChild(createAdviceChild(asm, advice)); } else if (element instanceof DeclareParents) { parent.addChild(createDeclareParentsChild(asm, (DeclareParents) element)); } else if (element instanceof BcelTypeMunger) { IProgramElement newChild = createIntertypeDeclaredChild(asm, aspect, (BcelTypeMunger) element); if (newChild != null) { parent.addChild(newChild); } } } }
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
private static IProgramElement createDeclareErrorOrWarningChild(AsmManager model, ResolvedType aspect, DeclareErrorOrWarning decl, int count) { IProgramElement deowNode = new ProgramElement(model, decl.getName(), decl.isError() ? IProgramElement.Kind.DECLARE_ERROR : IProgramElement.Kind.DECLARE_WARNING, getBinarySourceLocation(aspect, decl.getSourceLocation()), decl .getDeclaringType().getModifiers(), null, null); deowNode.setDetails("\"" + AsmRelationshipUtils.genDeclareMessage(decl.getMessage()) + "\""); if (count != -1) { deowNode.setBytecodeName(decl.getName() + "_" + count); } return deowNode; } private static IProgramElement createAdviceChild(AsmManager model, Advice advice) { IProgramElement adviceNode = new ProgramElement(model, advice.getKind().getName(), IProgramElement.Kind.ADVICE, advice .getBinarySourceLocation(advice.getSourceLocation()), advice.getSignature().getModifiers(), null, Collections.EMPTY_LIST); adviceNode.setDetails(AsmRelationshipUtils.genPointcutDetails(advice.getPointcut())); adviceNode.setBytecodeName(advice.getSignature().getName()); return adviceNode; } /** * Half baked implementation - will need completing if we go down this route rather than replacing it all for binary aspects. * Doesn't attempt to get parameter names correct - they may have been lost during (de)serialization of the munger, but the
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
* member could still be located so they might be retrievable. */ private static IProgramElement createIntertypeDeclaredChild(AsmManager model, ResolvedType aspect, BcelTypeMunger itd) { ResolvedTypeMunger rtMunger = itd.getMunger(); ResolvedMember sig = rtMunger.getSignature(); Kind kind = rtMunger.getKind(); if (kind == ResolvedTypeMunger.Field) { String name = sig.getDeclaringType().getClassName() + "." + sig.getName(); if (name.indexOf("$") != -1) { name = name.substring(name.indexOf("$") + 1); } IProgramElement pe = new ProgramElement(model, name, IProgramElement.Kind.INTER_TYPE_FIELD, getBinarySourceLocation( aspect, itd.getSourceLocation()), rtMunger.getSignature().getModifiers(), null, Collections.EMPTY_LIST); pe.setCorrespondingType(sig.getReturnType().getName()); return pe; } else if (kind == ResolvedTypeMunger.Method) { String name = sig.getDeclaringType().getClassName() + "." + sig.getName(); if (name.indexOf("$") != -1) { name = name.substring(name.indexOf("$") + 1); } IProgramElement pe = new ProgramElement(model, name, IProgramElement.Kind.INTER_TYPE_METHOD, getBinarySourceLocation( aspect, itd.getSourceLocation()), rtMunger.getSignature().getModifiers(), null, Collections.EMPTY_LIST); setParams(pe, sig); return pe; } else if (kind == ResolvedTypeMunger.Constructor) { String name = sig.getDeclaringType().getClassName() + "." + sig.getDeclaringType().getClassName(); if (name.indexOf("$") != -1) { name = name.substring(name.indexOf("$") + 1);
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
} IProgramElement pe = new ProgramElement(model, name, IProgramElement.Kind.INTER_TYPE_CONSTRUCTOR, getBinarySourceLocation(aspect, itd.getSourceLocation()), rtMunger.getSignature().getModifiers(), null, Collections.EMPTY_LIST); setParams(pe, sig); return pe; } return null; } private static void setParams(IProgramElement pe, ResolvedMember sig) { UnresolvedType[] ts = sig.getParameterTypes(); pe.setParameterNames(Collections.EMPTY_LIST); if (ts == null) { pe.setParameterSignatures(Collections.EMPTY_LIST, Collections.EMPTY_LIST); } else { List paramSigs = new ArrayList(); for (int i = 0; i < ts.length; i++) {
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
paramSigs.add(ts[i].getSignature().toCharArray()); } pe.setParameterSignatures(paramSigs, Collections.EMPTY_LIST); } pe.setCorrespondingType(sig.getReturnType().getName()); } private static IProgramElement createDeclareParentsChild(AsmManager model, DeclareParents decp) { IProgramElement decpElement = new ProgramElement(model, "declare parents", IProgramElement.Kind.DECLARE_PARENTS, getBinarySourceLocation(decp.getDeclaringType(), decp.getSourceLocation()), Modifier.PUBLIC, null, Collections.EMPTY_LIST); return decpElement; } public static String getHandle(AsmManager asm, Advice advice) { if (null == advice.handle) { ISourceLocation sl = advice.getSourceLocation(); if (sl != null) { IProgramElement ipe = asm.getHierarchy().findElementForSourceLine(sl); advice.handle = ipe.getHandleIdentifier(); } } return advice.handle; } public static void addAdvisedRelationship(AsmManager model, Shadow matchedShadow, ShadowMunger munger) { if (model == null) { return; } if (munger instanceof Advice) { Advice advice = (Advice) munger;
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
if (advice.getKind().isPerEntry() || advice.getKind().isCflow()) { return; } if (World.createInjarHierarchy) { createHierarchyForBinaryAspect(model, advice); } IRelationshipMap mapper = model.getRelationshipMap(); IProgramElement targetNode = getNode(model, matchedShadow); if (targetNode == null) { return; } boolean runtimeTest = advice.hasDynamicTests(); IProgramElement.ExtraInformation extra = new IProgramElement.ExtraInformation(); String adviceHandle = getHandle(model, advice); if (adviceHandle == null) { return; } extra.setExtraAdviceInformation(advice.getKind().getName()); IProgramElement adviceElement = model.getHierarchy().findElementForHandle(adviceHandle); if (adviceElement != null) { adviceElement.setExtraInfo(extra); } String targetHandle = targetNode.getHandleIdentifier(); if (advice.getKind().equals(AdviceKind.Softener)) { IRelationship foreward = mapper.get(adviceHandle, IRelationship.Kind.DECLARE_SOFT, SOFTENS, runtimeTest, true); if (foreward != null) { foreward.addTarget(targetHandle); } IRelationship back = mapper.get(targetHandle, IRelationship.Kind.DECLARE, SOFTENED_BY, runtimeTest, true);
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
if (back != null) { back.addTarget(adviceHandle); } } else { IRelationship foreward = mapper.get(adviceHandle, IRelationship.Kind.ADVICE, ADVISES, runtimeTest, true); if (foreward != null) { foreward.addTarget(targetHandle); } IRelationship back = mapper.get(targetHandle, IRelationship.Kind.ADVICE, ADVISED_BY, runtimeTest, true); if (back != null) { back.addTarget(adviceHandle); } } if (adviceElement.getSourceLocation() != null) { model.addAspectInEffectThisBuild(adviceElement.getSourceLocation().getSourceFile()); } } } protected static IProgramElement getNode(AsmManager model, Shadow shadow) { Member enclosingMember = shadow.getEnclosingCodeSignature();
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
IProgramElement enclosingNode = null; if (shadow instanceof BcelShadow) { Member actualEnclosingMember = ((BcelShadow) shadow).getRealEnclosingCodeSignature(); if (actualEnclosingMember == null) { enclosingNode = lookupMember(model.getHierarchy(), shadow.getEnclosingType(), enclosingMember); } else { UnresolvedType type = enclosingMember.getDeclaringType(); UnresolvedType actualType = actualEnclosingMember.getDeclaringType(); if (type.equals(actualType)) { enclosingNode = lookupMember(model.getHierarchy(), shadow.getEnclosingType(), enclosingMember); } else { enclosingNode = lookupMember(model.getHierarchy(), shadow.getEnclosingType(), actualEnclosingMember); } } } else { enclosingNode = lookupMember(model.getHierarchy(), shadow.getEnclosingType(), enclosingMember); } if (enclosingNode == null) { Lint.Kind err = shadow.getIWorld().getLint().shadowNotInStructure; if (err.isEnabled()) { err.signal(shadow.toString(), shadow.getSourceLocation()); } return null;
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
} Member shadowSig = shadow.getSignature(); if (shadow.getKind() == Shadow.MethodCall || shadow.getKind() == Shadow.ConstructorCall || !shadowSig.equals(enclosingMember)) { IProgramElement bodyNode = findOrCreateCodeNode(model, enclosingNode, shadowSig, shadow); return bodyNode; } else { return enclosingNode; } } private static boolean sourceLinesMatch(ISourceLocation location1, ISourceLocation location2) { return (location1.getLine() == location2.getLine()); } /** * Finds or creates a code IProgramElement for the given shadow. * * The byteCodeName of the created node is set to 'shadowSig.getName() + "!" + counter', eg "println!3". The counter is the * occurence count of children within the enclosingNode which have the same name. So, for example, if a method contains two * System.out.println statements, the first one will have byteCodeName 'println!1' and the second will have byteCodeName * 'println!2'. This is to ensure the two nodes have unique handles when the handles do not depend on sourcelocations. * * Currently the shadows are examined in the sequence they appear in the source file. This means that the counters are * consistent over incremental builds. All aspects are compiled up front and any new aspect created will force a full build. * Moreover, if the body of the enclosingShadow is changed, then the model for this is rebuilt from scratch. */ private static IProgramElement findOrCreateCodeNode(AsmManager asm, IProgramElement enclosingNode, Member shadowSig, Shadow shadow) { for (Iterator it = enclosingNode.getChildren().iterator(); it.hasNext();) { IProgramElement node = (IProgramElement) it.next();
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
int excl = node.getBytecodeName().lastIndexOf('!'); if (((excl != -1 && shadowSig.getName().equals(node.getBytecodeName().substring(0, excl))) || shadowSig.getName() .equals(node.getBytecodeName())) && shadowSig.getSignature().equals(node.getBytecodeSignature()) && sourceLinesMatch(node.getSourceLocation(), shadow.getSourceLocation())) { return node; } } ISourceLocation sl = shadow.getSourceLocation(); SourceLocation peLoc = new SourceLocation(enclosingNode.getSourceLocation().getSourceFile(), sl.getLine()); peLoc.setOffset(sl.getOffset()); IProgramElement peNode = new ProgramElement(asm, shadow.toString(), IProgramElement.Kind.CODE, peLoc, 0, null, null); int numberOfChildrenWithThisName = 0; for (Iterator it = enclosingNode.getChildren().iterator(); it.hasNext();) { IProgramElement child = (IProgramElement) it.next(); if (child.getName().equals(shadow.toString())) { numberOfChildrenWithThisName++; } } peNode.setBytecodeName(shadowSig.getName() + "!" + String.valueOf(numberOfChildrenWithThisName + 1)); peNode.setBytecodeSignature(shadowSig.getSignature()); enclosingNode.addChild(peNode); return peNode; }
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
private static IProgramElement lookupMember(IHierarchy model, UnresolvedType declaringType, Member member) { IProgramElement typeElement = model.findElementForType(declaringType.getPackageName(), declaringType.getClassName()); if (typeElement == null) { return null; } for (Iterator it = typeElement.getChildren().iterator(); it.hasNext();) { IProgramElement element = (IProgramElement) it.next(); if (member.getName().equals(element.getBytecodeName()) && member.getSignature().equals(element.getBytecodeSignature())) { return element; } } return typeElement; } /** * Add a relationship for a matching declare annotation method or declare annotation constructor. Locating the method is a messy * (for messy read 'fragile') bit of code that could break at any moment but it's working for my simple testcase. */ public static void addDeclareAnnotationMethodRelationship(ISourceLocation sourceLocation, String affectedTypeName, ResolvedMember affectedMethod, AsmManager model) { if (model == null) { return; } String pkg = null; String type = affectedTypeName; int packageSeparator = affectedTypeName.lastIndexOf("."); if (packageSeparator != -1) { pkg = affectedTypeName.substring(0, packageSeparator); type = affectedTypeName.substring(packageSeparator + 1); }
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
IHierarchy hierarchy = model.getHierarchy(); IProgramElement typeElem = hierarchy.findElementForType(pkg, type); if (typeElem == null) return; StringBuffer parmString = new StringBuffer("("); UnresolvedType[] args = affectedMethod.getParameterTypes(); for (int i = 0; i < args.length; i++) { String s = args[i].getName(); parmString.append(s); if ((i + 1) < args.length) parmString.append(","); } parmString.append(")"); IProgramElement methodElem = null; if (affectedMethod.getName().startsWith("<init>")) { methodElem = hierarchy.findElementForSignature(typeElem, IProgramElement.Kind.CONSTRUCTOR, type + parmString); if (methodElem == null && args.length == 0) methodElem = typeElem; } else { methodElem = hierarchy.findElementForSignature(typeElem, IProgramElement.Kind.METHOD, affectedMethod.getName() + parmString); } if (methodElem == null) return; try { String targetHandle = methodElem.getHandleIdentifier();
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
if (targetHandle == null) return; IProgramElement sourceNode = hierarchy.findElementForSourceLine(sourceLocation); String sourceHandle = sourceNode.getHandleIdentifier(); if (sourceHandle == null) return; IRelationshipMap mapper = model.getRelationshipMap(); IRelationship foreward = mapper.get(sourceHandle, IRelationship.Kind.DECLARE_INTER_TYPE, ANNOTATES, false, true); foreward.addTarget(targetHandle); IRelationship back = mapper.get(targetHandle, IRelationship.Kind.DECLARE_INTER_TYPE, ANNOTATED_BY, false, true); back.addTarget(sourceHandle); } catch (Throwable t) { t.printStackTrace(); } } /** * Add a relationship for a matching declare ATfield. Locating the field is trickier than it might seem since we have no line * number info for it, we have to dig through the structure model under the fields' type in order to locate it. */ public static void addDeclareAnnotationFieldRelationship(AsmManager model, ISourceLocation declareLocation, String affectedTypeName, ResolvedMember affectedFieldName) { if (model == null) { return; } String pkg = null; String type = affectedTypeName; int packageSeparator = affectedTypeName.lastIndexOf("."); if (packageSeparator != -1) {
311,910
Bug 311910 AspectJ internal Compiler Error
Stack Trace: java.lang.NullPointerException at org.aspectj.weaver.model.AsmRelationshipProvider.createSourceLocation(AsmRelationshipProvider.java:303) at org.aspectj.weaver.model.AsmRelationshipProvider.addPointcuts(AsmRelationshipProvider.java:580) at org.aspectj.weaver.model.AsmRelationshipProvider.createHierarchyForBinaryAspect(AsmRelationshipProvider.java:562) at org.aspectj.weaver.model.AsmRelationshipProvider.addAdvisedRelationship(AsmRelations ... ARETURN end public Object run(Object[]) end public class com.cerner.isis.biz.services.asclepius.patient.PatientManagerImplTest$AjcClosure3 Happening when weaving a jar with a aspect jar.
resolved fixed
3be69a2
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-06T16:34:47Z
2010-05-06T15:33:20Z
weaver/src/org/aspectj/weaver/model/AsmRelationshipProvider.java
pkg = affectedTypeName.substring(0, packageSeparator); type = affectedTypeName.substring(packageSeparator + 1); } IHierarchy hierarchy = model.getHierarchy(); IProgramElement typeElem = hierarchy.findElementForType(pkg, type); if (typeElem == null) { return; } IProgramElement fieldElem = hierarchy.findElementForSignature(typeElem, IProgramElement.Kind.FIELD, affectedFieldName .getName()); if (fieldElem == null) { return; } String targetHandle = fieldElem.getHandleIdentifier(); if (targetHandle == null) { return; } IProgramElement sourceNode = hierarchy.findElementForSourceLine(declareLocation); String sourceHandle = sourceNode.getHandleIdentifier(); if (sourceHandle == null) { return; } IRelationshipMap relmap = model.getRelationshipMap(); IRelationship foreward = relmap.get(sourceHandle, IRelationship.Kind.DECLARE_INTER_TYPE, ANNOTATES, false, true); foreward.addTarget(targetHandle); IRelationship back = relmap.get(targetHandle, IRelationship.Kind.DECLARE_INTER_TYPE, ANNOTATED_BY, false, true); back.addTarget(sourceHandle); } }
314,365
Bug 314365 pointcut rewriter can have issues for large hashcode values
AJDT uses a pointcut like this: (persingleton(org.eclipse.ajdt.internal.ui.ras.UIFFDC) && ((handler(java.lang.Throwable+) && args(arg1)) && ((within(org.eclipse.ajdt..*) && (!within(org.eclipse.ajdt.internal.ui.lazystart..*) && (!within(org.eclipse.ajdt.internal.ui.dialogs.OpenTypeSelectionDialog2) && !(within(org.eclipse.ajdt.internal.ui.editor.AspectJBreakpointRulerAction) && handler(org.eclipse.jface.text.BadLocationException))))) && (!(within(org.eclipse.ajdt.core.ras.FFDC+) || handler(org.eclipse.core.runtime.OperationCanceledException)) && !this(java.lang.Object))))) After the pointcut rewriter has chewed on it, it is reduced to a normal form. This is meant to be a stable form such that further rewrites of it would not change it. This turned out not to be the case. The hashcodes for some of the components were quite large and manifested as negative integers. The arithmetic in the comparator for the elements would have a problem and give unhelpful responses. For example, if the elements were C,B,A it might rewrite them to A,B,C but on a subsequent rewrite it would realise that C was less than A, giving B,C,A. Whether it went wrong was dependent on the order in which the elements were collected by the rewriter. This is now fixed. It impacts incremental compilation sometimes as two pointcuts that should be identical look different because one has been through the rewritter more times than the other...
resolved fixed
1e28b92
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-25T23:03:13Z
2010-05-25T20:40:00Z
org.aspectj.matcher/src/org/aspectj/weaver/patterns/PointcutEvaluationExpenseComparator.java
/* ******************************************************************* * Copyright (c) 2004 IBM Corporation. * All rights reserved. * This program and the accompanying materials are made available * under the terms of the Eclipse Public License v1.0 * which accompanies this distribution and is available at * http://www.eclipse.org/legal/epl-v10.html * * ******************************************************************/ package org.aspectj.weaver.patterns; import java.util.Comparator; import org.aspectj.weaver.Shadow; public class PointcutEvaluationExpenseComparator implements Comparator<Pointcut> {
314,365
Bug 314365 pointcut rewriter can have issues for large hashcode values
AJDT uses a pointcut like this: (persingleton(org.eclipse.ajdt.internal.ui.ras.UIFFDC) && ((handler(java.lang.Throwable+) && args(arg1)) && ((within(org.eclipse.ajdt..*) && (!within(org.eclipse.ajdt.internal.ui.lazystart..*) && (!within(org.eclipse.ajdt.internal.ui.dialogs.OpenTypeSelectionDialog2) && !(within(org.eclipse.ajdt.internal.ui.editor.AspectJBreakpointRulerAction) && handler(org.eclipse.jface.text.BadLocationException))))) && (!(within(org.eclipse.ajdt.core.ras.FFDC+) || handler(org.eclipse.core.runtime.OperationCanceledException)) && !this(java.lang.Object))))) After the pointcut rewriter has chewed on it, it is reduced to a normal form. This is meant to be a stable form such that further rewrites of it would not change it. This turned out not to be the case. The hashcodes for some of the components were quite large and manifested as negative integers. The arithmetic in the comparator for the elements would have a problem and give unhelpful responses. For example, if the elements were C,B,A it might rewrite them to A,B,C but on a subsequent rewrite it would realise that C was less than A, giving B,C,A. Whether it went wrong was dependent on the order in which the elements were collected by the rewriter. This is now fixed. It impacts incremental compilation sometimes as two pointcuts that should be identical look different because one has been through the rewritter more times than the other...
resolved fixed
1e28b92
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-25T23:03:13Z
2010-05-25T20:40:00Z
org.aspectj.matcher/src/org/aspectj/weaver/patterns/PointcutEvaluationExpenseComparator.java
private static final int MATCHES_NOTHING = -1; private static final int WITHIN = 1; private static final int ATWITHIN = 2; private static final int STATICINIT = 3; private static final int ADVICEEXECUTION = 4; private static final int HANDLER = 5; private static final int GET_OR_SET = 6; private static final int WITHINCODE = 7; private static final int ATWITHINCODE = 8; private static final int EXE_INIT_PREINIT = 9; private static final int THIS_OR_TARGET = 10; private static final int CALL = 11; private static final int ANNOTATION = 12; private static final int AT_THIS_OR_TARGET = 13; private static final int ARGS = 14; private static final int AT_ARGS = 15; private static final int CFLOW = 16; private static final int IF = 17; private static final int OTHER = 20; /** * Compare 2 pointcuts based on an estimate of how expensive they may be to evaluate. * * within * * @within staticinitialization [make sure this has a fast match method] adviceexecution handler get, set withincode * @withincode execution, initialization, preinitialization call * @annotation this, target * @this, @target args * @args cflow, cflowbelow if */
314,365
Bug 314365 pointcut rewriter can have issues for large hashcode values
AJDT uses a pointcut like this: (persingleton(org.eclipse.ajdt.internal.ui.ras.UIFFDC) && ((handler(java.lang.Throwable+) && args(arg1)) && ((within(org.eclipse.ajdt..*) && (!within(org.eclipse.ajdt.internal.ui.lazystart..*) && (!within(org.eclipse.ajdt.internal.ui.dialogs.OpenTypeSelectionDialog2) && !(within(org.eclipse.ajdt.internal.ui.editor.AspectJBreakpointRulerAction) && handler(org.eclipse.jface.text.BadLocationException))))) && (!(within(org.eclipse.ajdt.core.ras.FFDC+) || handler(org.eclipse.core.runtime.OperationCanceledException)) && !this(java.lang.Object))))) After the pointcut rewriter has chewed on it, it is reduced to a normal form. This is meant to be a stable form such that further rewrites of it would not change it. This turned out not to be the case. The hashcodes for some of the components were quite large and manifested as negative integers. The arithmetic in the comparator for the elements would have a problem and give unhelpful responses. For example, if the elements were C,B,A it might rewrite them to A,B,C but on a subsequent rewrite it would realise that C was less than A, giving B,C,A. Whether it went wrong was dependent on the order in which the elements were collected by the rewriter. This is now fixed. It impacts incremental compilation sometimes as two pointcuts that should be identical look different because one has been through the rewritter more times than the other...
resolved fixed
1e28b92
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-25T23:03:13Z
2010-05-25T20:40:00Z
org.aspectj.matcher/src/org/aspectj/weaver/patterns/PointcutEvaluationExpenseComparator.java
public int compare(Pointcut p1, Pointcut p2) { if (p1.equals(p2)) { return 0; } int result = getScore(p1) - getScore(p2); if (result == 0) { result = p1.hashCode() - p2.hashCode(); if (result == 0) { return -1; } } return result; } private int getScore(Pointcut p) { if (p.couldMatchKinds() == Shadow.NO_SHADOW_KINDS_BITS) { return MATCHES_NOTHING; } if (p instanceof WithinPointcut) { return WITHIN; } if (p instanceof WithinAnnotationPointcut) { return ATWITHIN; } if (p instanceof KindedPointcut) { KindedPointcut kp = (KindedPointcut) p; Shadow.Kind kind = kp.getKind();
314,365
Bug 314365 pointcut rewriter can have issues for large hashcode values
AJDT uses a pointcut like this: (persingleton(org.eclipse.ajdt.internal.ui.ras.UIFFDC) && ((handler(java.lang.Throwable+) && args(arg1)) && ((within(org.eclipse.ajdt..*) && (!within(org.eclipse.ajdt.internal.ui.lazystart..*) && (!within(org.eclipse.ajdt.internal.ui.dialogs.OpenTypeSelectionDialog2) && !(within(org.eclipse.ajdt.internal.ui.editor.AspectJBreakpointRulerAction) && handler(org.eclipse.jface.text.BadLocationException))))) && (!(within(org.eclipse.ajdt.core.ras.FFDC+) || handler(org.eclipse.core.runtime.OperationCanceledException)) && !this(java.lang.Object))))) After the pointcut rewriter has chewed on it, it is reduced to a normal form. This is meant to be a stable form such that further rewrites of it would not change it. This turned out not to be the case. The hashcodes for some of the components were quite large and manifested as negative integers. The arithmetic in the comparator for the elements would have a problem and give unhelpful responses. For example, if the elements were C,B,A it might rewrite them to A,B,C but on a subsequent rewrite it would realise that C was less than A, giving B,C,A. Whether it went wrong was dependent on the order in which the elements were collected by the rewriter. This is now fixed. It impacts incremental compilation sometimes as two pointcuts that should be identical look different because one has been through the rewritter more times than the other...
resolved fixed
1e28b92
AspectJ
https://github.com/eclipse/org.aspectj
eclipse/org.aspectj
java
null
null
null
2010-05-25T23:03:13Z
2010-05-25T20:40:00Z
org.aspectj.matcher/src/org/aspectj/weaver/patterns/PointcutEvaluationExpenseComparator.java
if (kind == Shadow.AdviceExecution) { return ADVICEEXECUTION; } else if ((kind == Shadow.ConstructorCall) || (kind == Shadow.MethodCall)) { return CALL; } else if ((kind == Shadow.ConstructorExecution) || (kind == Shadow.MethodExecution) || (kind == Shadow.Initialization) || (kind == Shadow.PreInitialization)) { return EXE_INIT_PREINIT; } else if (kind == Shadow.ExceptionHandler) { return HANDLER; } else if ((kind == Shadow.FieldGet) || (kind == Shadow.FieldSet)) { return GET_OR_SET; } else if (kind == Shadow.StaticInitialization) { return STATICINIT; } else { return OTHER; } } if (p instanceof AnnotationPointcut) { return ANNOTATION; } if (p instanceof ArgsPointcut) { return ARGS; } if (p instanceof ArgsAnnotationPointcut) { return AT_ARGS; } if (p instanceof CflowPointcut) { return CFLOW; } if (p instanceof HandlerPointcut) {