issue_id
int64
2.04k
425k
title
stringlengths
9
251
body
stringlengths
4
32.8k
status
stringclasses
6 values
after_fix_sha
stringlengths
7
7
project_name
stringclasses
6 values
repo_url
stringclasses
6 values
repo_name
stringclasses
6 values
language
stringclasses
1 value
issue_url
null
before_fix_sha
null
pull_url
null
commit_datetime
timestamp[us, tz=UTC]
report_datetime
timestamp[us, tz=UTC]
updated_file
stringlengths
23
187
chunk_content
stringlengths
1
22k
15,604
Bug 15604 Promote Fill arguments on method completion to a real preference
It is still in work in progress but it has become an established feature by now. Promote the preference to the code assist preference page.
resolved fixed
4820fe3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T13:23:20Z
2002-05-09T13:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/JavaCompletionProcessor.java
fExperimentalCollector.reset(offset, unit.getJavaProject(), fAllowAddImports ? unit : null); fExperimentalCollector.setViewer(viewer); Point selection= viewer.getSelectedRange(); if (selection.y > 0) fExperimentalCollector.setReplacementLength(selection.y); unit.codeComplete(offset, fExperimentalCollector); } } catch (JavaModelException x) { Shell shell= viewer.getTextWidget().getShell(); ErrorDialog.openError(shell, JavaTextMessages.getString("CompletionProcessor.error.accessing.title"), JavaTextMessages.getString("CompletionProcessor.error.accessing.message"), x.getStatus()); } results= fExperimentalCollector.getResults(); } else { try { if (unit != null) { fCollector.reset(offset, unit.getJavaProject(), fAllowAddImports ? unit : null); Point selection= viewer.getSelectedRange(); if (selection.y > 0) fCollector.setReplacementLength(selection.y); unit.codeComplete(offset, fCollector); } } catch (JavaModelException x) { Shell shell= viewer.getTextWidget().getShell(); ErrorDialog.openError(shell, JavaTextMessages.getString("CompletionProcessor.error.accessing.title"), JavaTextMessages.getString("CompletionProcessor.error.accessing.message"), x.getStatus()); }
15,604
Bug 15604 Promote Fill arguments on method completion to a real preference
It is still in work in progress but it has become an established feature by now. Promote the preference to the code assist preference page.
resolved fixed
4820fe3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T13:23:20Z
2002-05-09T13:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/java/JavaCompletionProcessor.java
results= fCollector.getResults(); } if (fTemplateEngine != null) { try { fTemplateEngine.reset(); fTemplateEngine.complete(viewer, offset, unit); } catch (JavaModelException x) { Shell shell= viewer.getTextWidget().getShell(); ErrorDialog.openError(shell, JavaTextMessages.getString("CompletionProcessor.error.accessing.title"), JavaTextMessages.getString("CompletionProcessor.error.accessing.message"), x.getStatus()); } IJavaCompletionProposal[] templateResults= fTemplateEngine.getResults(); IJavaCompletionProposal[] total= new IJavaCompletionProposal[results.length + templateResults.length]; System.arraycopy(templateResults, 0, total, 0, templateResults.length); System.arraycopy(results, 0, total, templateResults.length, results.length); results= total; } fNumberOfComputedResults= (results == null ? 0 : results.length); /* * Order here and not in result collector to make sure that the order * applies to all proposals and not just those of the compilation unit. */ return order(results); } }
15,604
Bug 15604 Promote Fill arguments on method completion to a real preference
It is still in work in progress but it has become an established feature by now. Promote the preference to the code assist preference page.
resolved fixed
4820fe3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T13:23:20Z
2002-05-09T13:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/PreferencesConstants.java
package org.eclipse.jdt.ui; import org.eclipse.jface.preference.IPreferenceStore; import org.eclipse.ui.texteditor.AbstractTextEditor; import org.eclipse.jdt.ui.text.IJavaColorConstants; import org.eclipse.jdt.ui.text.JavaSourceViewerConfiguration; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitDocumentProvider; import org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor; import org.eclipse.jdt.internal.ui.javaeditor.JavaEditor; import org.eclipse.jdt.internal.ui.preferences.AppearancePreferencePage; import org.eclipse.jdt.internal.ui.preferences.CodeGenerationPreferencePage; import org.eclipse.jdt.internal.ui.preferences.ImportOrganizePreferencePage; import org.eclipse.jdt.internal.ui.preferences.JavaBasePreferencePage; import org.eclipse.jdt.internal.ui.preferences.JavaBrowsingPreferencePage; import org.eclipse.jdt.internal.ui.preferences.JavaEditorPreferencePage; import org.eclipse.jdt.internal.ui.preferences.JavadocPreferencePage; import org.eclipse.jdt.internal.ui.preferences.RefactoringPreferencePage; import org.eclipse.jdt.internal.ui.preferences.WorkInProgressPreferencePage; import org.eclipse.jdt.internal.ui.text.ContentAssistPreference; import org.eclipse.jdt.internal.ui.text.java.ExperimentalPreference; /** * Preference constants used in the JDT-UI preference store. * @since 2.0 */ public class PreferencesConstants {
15,604
Bug 15604 Promote Fill arguments on method completion to a real preference
It is still in work in progress but it has become an established feature by now. Promote the preference to the code assist preference page.
resolved fixed
4820fe3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T13:23:20Z
2002-05-09T13:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/PreferencesConstants.java
private PreferencesConstants() { super(); } /** * Enable / Disable showing the method return type. Boolean value. */
15,604
Bug 15604 Promote Fill arguments on method completion to a real preference
It is still in work in progress but it has become an established feature by now. Promote the preference to the code assist preference page.
resolved fixed
4820fe3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T13:23:20Z
2002-05-09T13:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/PreferencesConstants.java
public static final String APPEARANCE_METHOD_RETURNTYPE= AppearancePreferencePage.PREF_METHOD_RETURNTYPE; /** * Enable / Disable showing the override indicators. Boolean value. */ public static final String APPEARANCE_OVERRIDE_INDICATOR= AppearancePreferencePage.PREF_OVERRIDE_INDICATOR; /** * Package name compression pattern. String value. */ public static final String APPEARANCE_PKG_NAME_PATTERN_FOR_PKG_VIEW= AppearancePreferencePage.PREF_PKG_NAME_PATTERN_FOR_PKG_VIEW; /** * Enable / Disable showing the package name compression. Boolean value. */ public static final String APPEARANCE_COMPRESS_PACKAGE_NAMES= AppearancePreferencePage.PREF_COMPRESS_PACKAGE_NAMES; /** * Enable / Disable removing prefixes when creating getters. Boolean value. */ public static final String CODEGEN_USE_GETTERSETTER_PREFIX= CodeGenerationPreferencePage.PREF_USE_GETTERSETTER_PREFIX; /** * List of prefixes. String value; comma separated list */ public static final String CODEGEN_GETTERSETTER_PREFIX= CodeGenerationPreferencePage.PREF_GETTERSETTER_PREFIX; /** * Enable / Disable removing suffixes when creating getters. Boolean value. */ public static final String CODEGEN_USE_GETTERSETTER_SUFFIX= CodeGenerationPreferencePage.PREF_USE_GETTERSETTER_SUFFIX; /** * List of suffixes. String value; comma separated list. */ public static final String CODEGEN_GETTERSETTER_SUFFIX= CodeGenerationPreferencePage.PREF_USE_GETTERSETTER_SUFFIX; /**
15,604
Bug 15604 Promote Fill arguments on method completion to a real preference
It is still in work in progress but it has become an established feature by now. Promote the preference to the code assist preference page.
resolved fixed
4820fe3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T13:23:20Z
2002-05-09T13:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/PreferencesConstants.java
* Enable / Disable adding JavaDoc stubs to types and methods. Boolean value. */ public static final String CODEGEN__JAVADOC_STUBS= CodeGenerationPreferencePage.PREF_JAVADOC_STUBS; /** * Enable / Disable adding a non-javadoc comment to methods that override. */ public static final String CODEGEN__NON_JAVADOC_COMMENTS= CodeGenerationPreferencePage.PREF_NON_JAVADOC_COMMENTS; /** * Enable / Disable adding a file comment to new created files. Boolean value. */ public static final String CODEGEN__FILE_COMMENTS= CodeGenerationPreferencePage.PREF_FILE_COMMENTS; /** * Specifies the import order. Strung value, semicolon separated. */ public static final String ORGIMPORTS_IMPORTORDER= ImportOrganizePreferencePage.PREF_IMPORTORDER; /** * Specifies the number of imports added before using an start-import declaration. Int value. */ public static final String ORGIMPORTS_ONDEMANDTHRESHOLD= ImportOrganizePreferencePage.PREF_ONDEMANDTHRESHOLD; /** * Specifies to never import types that start with a lower case character. Boolean value. */ public static final String ORGIMPORTS_IGNORELOWERCASE= ImportOrganizePreferencePage.PREF_IGNORELOWERCASE; /** * Enable / Disable showing cu children in the packages view. Boolean value. */ public static final String SHOW_CU_CHILDREN=JavaBasePreferencePage.SHOW_CU_CHILDREN; /**
15,604
Bug 15604 Promote Fill arguments on method completion to a real preference
It is still in work in progress but it has become an established feature by now. Promote the preference to the code assist preference page.
resolved fixed
4820fe3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T13:23:20Z
2002-05-09T13:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/PreferencesConstants.java
* Enable / Disable to update the packages view selection when editors are switched. Boolean value. */ public static final String LINK_PACKAGES_TO_EDITOR= JavaBasePreferencePage.LINK_PACKAGES_TO_EDITOR; /** * Enable / Disable to update the hierarchy selection when editors are switched. Boolean value. */ public static final String LINK_TYPEHIERARCHY_TO_EDITOR= JavaBasePreferencePage.LINK_TYPEHIERARCHY_TO_EDITOR; /** * Enable / Disable to use folders for source and output when creating a new Java project. Boolean value. */ public static final String SRCBIN_FOLDERS_IN_NEWPROJ= JavaBasePreferencePage.SRCBIN_FOLDERS_IN_NEWPROJ; /** * Source folder name used when creating a new Java project. String value. */ public static final String SRCBIN_SRCNAME= JavaBasePreferencePage.SRCBIN_SRCNAME; /** * Output folder name used when creating a new Java project. String value. */ public static final String SRCBIN_BINNAME= JavaBasePreferencePage.SRCBIN_BINNAME; /** * Selects the behaviour when opening a type in the hierarchy. String value, OPEN_TYPE_HIERARCHY_IN_PERSPECTIVE or OPEN_TYPE_HIERARCHY_IN_VIEW_PART. */ public static final String OPEN_TYPE_HIERARCHY= JavaBasePreferencePage.OPEN_TYPE_HIERARCHY; /** * String value used by OPEN_TYPE_HIERARCHY. */ public static final String OPEN_TYPE_HIERARCHY_IN_PERSPECTIVE= JavaBasePreferencePage.OPEN_TYPE_HIERARCHY_IN_PERSPECTIVE; /** * String value used by OPEN_TYPE_HIERARCHY. */
15,604
Bug 15604 Promote Fill arguments on method completion to a real preference
It is still in work in progress but it has become an established feature by now. Promote the preference to the code assist preference page.
resolved fixed
4820fe3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T13:23:20Z
2002-05-09T13:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/PreferencesConstants.java
public static final String OPEN_TYPE_HIERARCHY_IN_VIEW_PART= JavaBasePreferencePage.OPEN_TYPE_HIERARCHY_IN_VIEW_PART; /** * Selects the behaviour when double clicking in the packages view. String value, DOUBLE_CLICK_GOES_INTO or DOUBLE_CLICK_EXPANDS. */ public static final String DOUBLE_CLICK= JavaBasePreferencePage.DOUBLE_CLICK; /** * String value used by DOUBLE_CLICK. */ public static final String DOUBLE_CLICK_GOES_INTO= JavaBasePreferencePage.DOUBLE_CLICK_GOES_INTO; /** * String value used by DOUBLE_CLICK. */ public static final String DOUBLE_CLICK_EXPANDS= JavaBasePreferencePage.DOUBLE_CLICK_EXPANDS; /** * Enable / Disable showing reconciled elements in viewes. Boolean value. */ public static final String RECONCILE_JAVA_VIEWS= JavaBasePreferencePage.RECONCILE_JAVA_VIEWS; /** * Path of the Javadoc command used by the Javadoc creation wizard. String value. */ public static final String JAVADOC_COMMAND= JavadocPreferencePage.PREF_JAVADOC_COMMAND; /** * Enable / Disable the highlighting of matching brackets. Boolean value. */ public final static String EDITOR_MATCHING_BRACKETS= CompilationUnitEditor.MATCHING_BRACKETS; /** * Color used for highlighting matching brackets. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter
15,604
Bug 15604 Promote Fill arguments on method completion to a real preference
It is still in work in progress but it has become an established feature by now. Promote the preference to the code assist preference page.
resolved fixed
4820fe3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T13:23:20Z
2002-05-09T13:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/PreferencesConstants.java
*/ public final static String EDITOR_MATCHING_BRACKETS_COLOR= CompilationUnitEditor.MATCHING_BRACKETS_COLOR; /** * Enable / Disable highlighting the current line. Boolean value. */ public final static String EDITOR_CURRENT_LINE= CompilationUnitEditor.CURRENT_LINE; /** * Color used for highlighting the current line. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter */ public final static String EDITOR_CURRENT_LINE_COLOR= CompilationUnitEditor.CURRENT_LINE_COLOR; /** * Enable / Disable the print margin. Boolean value. */ public final static String EDITOR_PRINT_MARGIN= CompilationUnitEditor.PRINT_MARGIN; /** * Color used for the print margin. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter */ public final static String EDITOR_PRINT_MARGIN_COLOR= CompilationUnitEditor.PRINT_MARGIN_COLOR; /** * Print margin column. Int value. */ public final static String EDITOR_PRINT_MARGIN_COLUMN= CompilationUnitEditor.PRINT_MARGIN_COLUMN; /** * Color used for the find/replace scope. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter
15,604
Bug 15604 Promote Fill arguments on method completion to a real preference
It is still in work in progress but it has become an established feature by now. Promote the preference to the code assist preference page.
resolved fixed
4820fe3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T13:23:20Z
2002-05-09T13:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/PreferencesConstants.java
* @see org.eclipse.jface.preference.PreferenceConverter */ public final static String EDITOR_FIND_SCOPE_COLOR= AbstractTextEditor.PREFERENCE_COLOR_FIND_SCOPE; /** * Enable / Disable using spaces for tabs in the editor. Boolean value. */ public final static String EDITOR_SPACES_FOR_TABS= CompilationUnitEditor.SPACES_FOR_TABS; /** * Number of spaces per tab in the editor. Int value. */ public final static String EDITOR_TAB_WIDTH= JavaSourceViewerConfiguration.PREFERENCE_TAB_WIDTH; /** * Enable / Disable showing problem indicators. Boolean value. */ public final static String EDITOR_PROBLEM_INDICATION= CompilationUnitEditor.PROBLEM_INDICATION; /** * Color used for the problem indicators. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter */ public final static String EDITOR_PROBLEM_INDICATION_COLOR= CompilationUnitEditor.PROBLEM_INDICATION_COLOR; /** * Enable / Disable showing the correction indicator. Boolean value. */ public final static String EDITOR_CORRECTION_INDICATION= WorkInProgressPreferencePage.PREF_SHOW_TEMP_PROBLEMS; /** * Enable / Disable evaluating temporary problems. Boolean value. */ public final static String EDITOR_EVALUTE_TEMPORARY_PROBLEMS= CompilationUnitDocumentProvider.HANDLE_TEMPORARY_PROBLEMS; /**
15,604
Bug 15604 Promote Fill arguments on method completion to a real preference
It is still in work in progress but it has become an established feature by now. Promote the preference to the code assist preference page.
resolved fixed
4820fe3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T13:23:20Z
2002-05-09T13:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/PreferencesConstants.java
* Enable / Disable the overview ruler. Boolean value. */ public final static String EDITOR_OVERVIEW_RULER= CompilationUnitEditor.OVERVIEW_RULER; /** * Enable / Disable the line number ruler. Boolean value. */ public final static String EDITOR_LINE_NUMBER_RULER= JavaEditor.LINE_NUMBER_RULER; /** * Color used for the line number ruler. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter */ public final static String EDITOR_LINE_NUMBER_RULER_COLOR= JavaEditor.LINE_NUMBER_COLOR; /** * Color used for the linked positions (templates). RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter */ public final static String EDITOR_LINKED_POSITION_COLOR= CompilationUnitEditor.LINKED_POSITION_COLOR; /** * Color used for the text foreground. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter */ public final static String EDITOR_FOREGROUND_COLOR= AbstractTextEditor.PREFERENCE_COLOR_FOREGROUND; /** * Default color used for text foreground. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter */
15,604
Bug 15604 Promote Fill arguments on method completion to a real preference
It is still in work in progress but it has become an established feature by now. Promote the preference to the code assist preference page.
resolved fixed
4820fe3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T13:23:20Z
2002-05-09T13:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/PreferencesConstants.java
public final static String EDITOR_FOREGROUND_DEFAULT_COLOR= AbstractTextEditor.PREFERENCE_COLOR_FOREGROUND_SYSTEM_DEFAULT; /** * Color used for the text background. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter */ public final static String EDITOR_BACKGROUND_COLOR= AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND; /** * Default color used for the text background. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter */ public final static String EDITOR_BACKGROUND_DEFAULT_COLOR= AbstractTextEditor.PREFERENCE_COLOR_BACKGROUND_SYSTEM_DEFAULT; /** * Color used for multi line comments. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter */ public final static String EDITOR_MULTI_LINE_COMMENT_COLOR= IJavaColorConstants.JAVA_MULTI_LINE_COMMENT; /** * Enable / Disable the usage of bold style for multi line comments. */ public final static String EDITOR_MULTI_LINE_COMMENT_BOLD= IJavaColorConstants.JAVA_MULTI_LINE_COMMENT + JavaEditorPreferencePage.BOLD; /** * Color used for single line comments. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter */ public final static String EDITOR_SINGLE_LINE_COMMENT_COLOR= IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT; /**
15,604
Bug 15604 Promote Fill arguments on method completion to a real preference
It is still in work in progress but it has become an established feature by now. Promote the preference to the code assist preference page.
resolved fixed
4820fe3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T13:23:20Z
2002-05-09T13:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/PreferencesConstants.java
* Enable / Disable the usage of bold style for single line comments. */ public final static String EDITOR_SINGLE_LINE_COMMENT_BOLD= IJavaColorConstants.JAVA_SINGLE_LINE_COMMENT + JavaEditorPreferencePage.BOLD; /** * Color used for java keywords. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter */ public final static String EDITOR_JAVA_KEYWORD_COLOR= IJavaColorConstants.JAVA_KEYWORD; /** * Enable / Disable the usage of bold style for java keywords. */ public final static String EDITOR_JAVA_KEYWORD_BOLD= IJavaColorConstants.JAVA_KEYWORD + JavaEditorPreferencePage.BOLD; /** * Color used for string constants. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter */ public final static String EDITOR_STRING_COLOR= IJavaColorConstants.JAVA_STRING; /** * Enable / Disable the usage of bold style for string constants. */ public final static String EDITOR_STRING_BOLD= IJavaColorConstants.JAVA_STRING + JavaEditorPreferencePage.BOLD; /** * Color used for java default text. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter */ public final static String EDITOR_JAVA_DEFAULT_COLOR= IJavaColorConstants.JAVA_DEFAULT; /**
15,604
Bug 15604 Promote Fill arguments on method completion to a real preference
It is still in work in progress but it has become an established feature by now. Promote the preference to the code assist preference page.
resolved fixed
4820fe3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T13:23:20Z
2002-05-09T13:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/PreferencesConstants.java
* Enable / Disable the usage of bold style for java default text. */ public final static String EDITOR_JAVA_DEFAULT_BOLD= IJavaColorConstants.JAVA_DEFAULT + JavaEditorPreferencePage.BOLD; /** * Color used for javadoc keywords. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter */ public final static String EDITOR_JAVADOC_KEYWORD_COLOR= IJavaColorConstants.JAVADOC_KEYWORD; /** * Enable / Disable the usage of bold style for javadoc keywords. */ public final static String EDITOR_JAVADOC_KEYWORD_BOLD= IJavaColorConstants.JAVADOC_KEYWORD + JavaEditorPreferencePage.BOLD; /** * Color used for javadoc tags. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter */ public final static String EDITOR_JAVADOC_TAG_COLOR= IJavaColorConstants.JAVADOC_TAG; /** * Enable / Disable the usage of bold style for javadoc tags. */ public final static String EDITOR_JAVADOC_TAG_BOLD= IJavaColorConstants.JAVADOC_TAG + JavaEditorPreferencePage.BOLD; /** * Color used for javadoc links. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter */ public final static String EDITOR_JAVADOC_LINKS_COLOR= IJavaColorConstants.JAVADOC_LINK; /**
15,604
Bug 15604 Promote Fill arguments on method completion to a real preference
It is still in work in progress but it has become an established feature by now. Promote the preference to the code assist preference page.
resolved fixed
4820fe3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T13:23:20Z
2002-05-09T13:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/PreferencesConstants.java
* Enable / Disable the usage of bold style for javadoc links. */ public final static String EDITOR_JAVADOC_LINKS_BOLD= IJavaColorConstants.JAVADOC_LINK + JavaEditorPreferencePage.BOLD; /** * Color used for javadoc default text. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter */ public final static String EDITOR_JAVADOC_DEFAULT_COLOR= IJavaColorConstants.JAVADOC_DEFAULT; /** * Enable / Disable the usage of bold style for javadoc default text. */ public final static String EDITOR_JAVADOC_DEFAULT_BOLD= IJavaColorConstants.JAVADOC_DEFAULT + JavaEditorPreferencePage.BOLD; /** * Enable / Disable the auto activation of the Java code assist. Boolean value. */ public final static String CODEASSIST_AUTOACTIVATION= ContentAssistPreference.AUTOACTIVATION; /** * Specifies the auto activation delay time. Int value. */ public final static String CODEASSIST_AUTOACTIVATION_DELAY= ContentAssistPreference.AUTOACTIVATION_DELAY; /** * Show only visible elements as code assist proposals. Boolean value. */ public final static String CODEASSIST_SHOW_VISIBLE_PROPOSALS= ContentAssistPreference.SHOW_VISIBLE_PROPOSALS; /** * Enable / Disable case sensitivity for filtering code assist proposals. Boolean value. */ public final static String CODEASSIST_CASE_SENSITIVITY= ContentAssistPreference.CASE_SENSITIVITY;
15,604
Bug 15604 Promote Fill arguments on method completion to a real preference
It is still in work in progress but it has become an established feature by now. Promote the preference to the code assist preference page.
resolved fixed
4820fe3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T13:23:20Z
2002-05-09T13:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/PreferencesConstants.java
/** * Enable / Disable ordering of code assist proposals. Boolean value. */ public final static String CODEASSIST_ORDER_PROPOSALS= ContentAssistPreference.ORDER_PROPOSALS; /** * Enable / Disable filling argument names for method completions. Boolean value. */ public final static String CODEASSIST_FILL_ARGUMENT_NAMES= ExperimentalPreference.CODE_ASSIST_EXPERIMENTAL; /** * The characters that select an entry in the code assist selection dialog on Java code. String value. String containing all characters. */ public final static String CODEASSIST_AUTOACTIVATION_TRIGGERS_JAVA= ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVA; /** * The characters that select an entry in the code assist selection dialog on Javadoc code. String value. String containing all characters. */ public final static String CODEASSIST_AUTOACTIVATION_TRIGGERS_JAVADOC= ContentAssistPreference.AUTOACTIVATION_TRIGGERS_JAVADOC; /** * Background color used in the code assist selection dialog. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter */ public final static String CODEASSIST_PROPOSALS_BACKGROUND= ContentAssistPreference.PROPOSALS_BACKGROUND; /** * Foreground color used in the code assist selection dialog. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter */ public final static String CODEASSIST_PROPOSALS_FOREGROUND= ContentAssistPreference.PROPOSALS_FOREGROUND;
15,604
Bug 15604 Promote Fill arguments on method completion to a real preference
It is still in work in progress but it has become an established feature by now. Promote the preference to the code assist preference page.
resolved fixed
4820fe3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T13:23:20Z
2002-05-09T13:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/PreferencesConstants.java
/** * Background color used for parameter hints. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter */ public final static String CODEASSIST_PARAMETERS_BACKGROUND= ContentAssistPreference.PARAMETERS_BACKGROUND; /** * Foreground color used for parameter hints. RGB color encoded using PreferenceConverter. * @see org.eclipse.jface.resource.StringConverter * @see org.eclipse.jface.preference.PreferenceConverter */ public final static String CODEASSIST_PARAMETERS_FOREGROUND= ContentAssistPreference.PARAMETERS_FOREGROUND; /** * Sets the behaviour of the refactoring wizard for showing the error page. String value: * REFACTOR_FATAL_SEVERITY, REFACTOR_ERROR_SEVERITY, REFACTOR_WARNING_SEVERITY, REFACTOR_INFO_SEVERITY or REFACTOR_OK_SEVERITY. */ public static final String REFACTOR_ERROR_PAGE_SEVERITY_THRESHOLD= RefactoringPreferencePage.PREF_ERROR_PAGE_SEVERITY_THRESHOLD; /** * String value used by REFACTOR_ERROR_PAGE_SEVERITY_THRESHOLD. */ public static final String REFACTOR_FATAL_SEVERITY= RefactoringPreferencePage.FATAL_SEVERITY; /** * String value used by REFACTOR_ERROR_PAGE_SEVERITY_THRESHOLD. */ public static final String REFACTOR_ERROR_SEVERITY= RefactoringPreferencePage.ERROR_SEVERITY; /** * String value used by REFACTOR_ERROR_PAGE_SEVERITY_THRESHOLD. */ public static final String REFACTOR_WARNING_SEVERITY= RefactoringPreferencePage.WARNING_SEVERITY;
15,604
Bug 15604 Promote Fill arguments on method completion to a real preference
It is still in work in progress but it has become an established feature by now. Promote the preference to the code assist preference page.
resolved fixed
4820fe3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T13:23:20Z
2002-05-09T13:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/ui/PreferencesConstants.java
/** * String value used by REFACTOR_ERROR_PAGE_SEVERITY_THRESHOLD. */ public static final String REFACTOR_INFO_SEVERITY= RefactoringPreferencePage.INFO_SEVERITY; /** * String value used by REFACTOR_ERROR_PAGE_SEVERITY_THRESHOLD. */ public static final String REFACTOR_OK_SEVERITY= RefactoringPreferencePage.OK_SEVERITY; /** * Automatically save all editor before refactoring. */ public static final String REFACTOR_SAVE_ALL_EDITORS= RefactoringPreferencePage.PREF_SAVE_ALL_EDITORS; /** * Link Java Browsing views to the active editor. Boolean value. */ public static final String BROWSING_LINK_VIEW_TO_EDITOR= JavaBrowsingPreferencePage.LINK_VIEW_TO_EDITOR; /** * Stack Java Browsing views vertically. Boolean value. */ public static final String BROWSING_STACK_VERTICALLY= JavaBrowsingPreferencePage.STACK_VERTICALLY; /** * Returns the jdt ui preference store. */ public IPreferenceStore getPreferenceStore() { return JavaPlugin.getDefault().getPreferenceStore(); } }
14,943
Bug 14943 Code Assist does not respect platform line ends
I performed the following scenario: 1. Created a new class 2. Added a method. 3. Defined a local variable for an array 4. Used code assist to create a for loop with temporary variable. The resulting code has LF as linefeeds on a windows machine. They should be CR/LF.
resolved fixed
9e0b65b
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T14:16:52Z
2002-04-30T18:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/template/TemplateEngine.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.text.template; import java.util.ArrayList; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.IRegion; import org.eclipse.jface.text.ITextViewer; import org.eclipse.jface.text.Region; import org.eclipse.jface.viewers.ITableLabelProvider; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.Assert; import org.eclipse.jdt.internal.corext.template.ContextType; import org.eclipse.jdt.internal.corext.template.Template; import org.eclipse.jdt.internal.corext.template.Templates; import org.eclipse.jdt.internal.corext.template.java.CompilationUnitContext; import org.eclipse.jdt.internal.corext.template.java.CompilationUnitContextType; import org.eclipse.jdt.internal.ui.text.java.IJavaCompletionProposal; import org.eclipse.jdt.internal.ui.text.link.LinkedPositionManager; public class TemplateEngine {
14,943
Bug 14943 Code Assist does not respect platform line ends
I performed the following scenario: 1. Created a new class 2. Added a method. 3. Defined a local variable for an array 4. Used code assist to create a for loop with temporary variable. The resulting code has LF as linefeeds on a windows machine. They should be CR/LF.
resolved fixed
9e0b65b
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T14:16:52Z
2002-04-30T18:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/template/TemplateEngine.java
private ContextType fContextType; private ITableLabelProvider fLabelProvider= new TemplateLabelProvider(); private ArrayList fProposals= new ArrayList(); /** * Creates the template engine for a particular context type. * See <code>TemplateContext</code> for supported context types. */ public TemplateEngine(ContextType contextType) { Assert.isNotNull(contextType); fContextType= contextType; } /** * Empties the collector. * * @param viewer the text viewer * @param unit the compilation unit (may be <code>null</code>) */ public void reset() { fProposals.clear(); } /** * Returns the array of matching templates. */ public IJavaCompletionProposal[] getResults() { return (IJavaCompletionProposal[]) fProposals.toArray(new IJavaCompletionProposal[fProposals.size()]); }
14,943
Bug 14943 Code Assist does not respect platform line ends
I performed the following scenario: 1. Created a new class 2. Added a method. 3. Defined a local variable for an array 4. Used code assist to create a for loop with temporary variable. The resulting code has LF as linefeeds on a windows machine. They should be CR/LF.
resolved fixed
9e0b65b
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T14:16:52Z
2002-04-30T18:06:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/template/TemplateEngine.java
/** * Inspects the context of the compilation unit around <code>completionPosition</code> * and feeds the collector with proposals. * @param viewer the text viewer * @param completionPosition the context position in the document of the text viewer * @param compilationUnit the compilation unit (may be <code>null</code>) */ public void complete(ITextViewer viewer, int completionPosition, ICompilationUnit compilationUnit) throws JavaModelException { IDocument document= viewer.getDocument(); if (LinkedPositionManager.hasActiveManager(document)) return; if (!(fContextType instanceof CompilationUnitContextType)) return; ((CompilationUnitContextType) fContextType).setContextParameters(document.get(), completionPosition, compilationUnit); CompilationUnitContext context= (CompilationUnitContext) fContextType.createContext(); int start= context.getStart(); int end= context.getEnd(); IRegion region= new Region(start, end - start); Template[] templates= Templates.getInstance().getTemplates(); for (int i= 0; i != templates.length; i++) if (context.canEvaluate(templates[i])) fProposals.add(new TemplateProposal(templates[i], context, region, viewer, fLabelProvider.getColumnImage(templates[i], 0))); } }
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/ClasspathContainerWizard.java
package org.eclipse.jdt.internal.ui.wizards.buildpaths; import org.eclipse.core.runtime.CoreException; import org.eclipse.jface.wizard.IWizardPage; import org.eclipse.jface.wizard.Wizard; import org.eclipse.jdt.core.IClasspathEntry; import org.eclipse.jdt.ui.wizards.IClasspathContainerPage; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jdt.internal.ui.wizards.NewWizardMessages; /** */ public class ClasspathContainerWizard extends Wizard {
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/ClasspathContainerWizard.java
private ClasspathContainerDescriptor fPageDesc; private IClasspathEntry fEntryToEdit; private IClasspathEntry fNewEntry; private IClasspathContainerPage fContainerPage; /** * Constructor for ClasspathContainerWizard. */ public ClasspathContainerWizard(IClasspathEntry entryToEdit) { super(); fEntryToEdit= entryToEdit; fPageDesc= null; fNewEntry= null; } /** * Constructor for ClasspathContainerWizard. */ public ClasspathContainerWizard(ClasspathContainerDescriptor pageDesc) { super(); fEntryToEdit= null; fPageDesc= pageDesc; fNewEntry= null; }
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/ClasspathContainerWizard.java
public IClasspathEntry getNewEntry() { return fNewEntry; } /* (non-Javadoc) * @see IWizard#performFinish() */ public boolean performFinish() { if (fContainerPage != null) { if (fContainerPage.finish()) { fNewEntry= fContainerPage.getSelection(); return true; } } return false; } /* (non-Javadoc) * @see IWizard#addPages() */ public void addPages() { if (fPageDesc == null && fEntryToEdit != null) { ClasspathContainerDescriptor[] containers= ClasspathContainerDescriptor.getDescriptors(); fPageDesc= findDescriptorPage(containers, fEntryToEdit); } if (fPageDesc != null) { IClasspathContainerPage containerPage= null; try { containerPage= fPageDesc.createPage(); } catch (CoreException e) { handlePageCreationFailed(e);
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/ClasspathContainerWizard.java
} if (containerPage == null) { containerPage= new ClasspathContainerDefaultPage(); } containerPage.setSelection(fEntryToEdit); fContainerPage= containerPage; addPage(containerPage); } super.addPages(); } private void handlePageCreationFailed(CoreException e) { String title= NewWizardMessages.getString("ClasspathContainerWizard.pagecreationerror.title"); String message= NewWizardMessages.getString("ClasspathContainerWizard.pagecreationerror.message"); ExceptionHandler.handle(e, getShell(), title, message); } private ClasspathContainerDescriptor findDescriptorPage(ClasspathContainerDescriptor[] containers, IClasspathEntry entry) { for (int i = 0; i < containers.length; i++) { if (containers[i].canEdit(fEntryToEdit)) { return containers[i]; } } return null; } }
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/LibrariesWorkbookPage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.wizards.buildpaths; import java.util.ArrayList; import java.util.List; import org.eclipse.core.resources.IContainer; import org.eclipse.core.resources.IFile; import org.eclipse.core.resources.IFolder; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IStatus; import org.eclipse.core.runtime.Path; import org.eclipse.swt.SWT; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.FileDialog; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.dialogs.Dialog; import org.eclipse.jface.dialogs.IDialogSettings; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.ITreeContentProvider;
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/LibrariesWorkbookPage.java
import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.jface.viewers.ViewerFilter; import org.eclipse.jface.wizard.WizardDialog; import org.eclipse.ui.dialogs.ElementTreeSelectionDialog; import org.eclipse.ui.help.WorkbenchHelp; import org.eclipse.ui.model.WorkbenchContentProvider; import org.eclipse.ui.model.WorkbenchLabelProvider; import org.eclipse.jdt.core.IClasspathEntry; import org.eclipse.jdt.core.IJavaModel; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.ui.IJavaHelpContextIds; import org.eclipse.jdt.internal.ui.IUIConstants; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.dialogs.StatusDialog; import org.eclipse.jdt.internal.ui.util.PixelConverter; import org.eclipse.jdt.internal.ui.wizards.IStatusChangeListener; import org.eclipse.jdt.internal.ui.wizards.NewWizardMessages; import org.eclipse.jdt.internal.ui.wizards.TypedElementSelectionValidator; import org.eclipse.jdt.internal.ui.wizards.TypedViewerFilter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.ComboDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.DialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IDialogFieldListener; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IListAdapter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.LayoutUtil; import org.eclipse.jdt.internal.ui.wizards.dialogfields.ListDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.SelectionButtonDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.SelectionButtonDialogFieldGroup; public class LibrariesWorkbookPage extends BuildPathBasePage {
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/LibrariesWorkbookPage.java
private ListDialogField fClassPathList; private IJavaProject fCurrJProject; private ListDialogField fLibrariesList; private IWorkspaceRoot fWorkspaceRoot; private IDialogSettings fDialogSettings; private Control fSWTControl; private final int IDX_ADDJAR= 0; private final int IDX_ADDEXT= 1; private final int IDX_ADDVAR= 2; private final int IDX_ADDADV= 3; private final int IDX_EDIT= 5; private final int IDX_REMOVE= 7;
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/LibrariesWorkbookPage.java
public LibrariesWorkbookPage(IWorkspaceRoot root, ListDialogField classPathList) { fClassPathList= classPathList; fWorkspaceRoot= root; fSWTControl= null; fDialogSettings= JavaPlugin.getDefault().getDialogSettings(); String[] buttonLabels= new String[] { NewWizardMessages.getString("LibrariesWorkbookPage.libraries.addjar.button"), NewWizardMessages.getString("LibrariesWorkbookPage.libraries.addextjar.button"), NewWizardMessages.getString("LibrariesWorkbookPage.libraries.addvariable.button"), NewWizardMessages.getString("LibrariesWorkbookPage.libraries.advanced.button"), null, NewWizardMessages.getString("LibrariesWorkbookPage.libraries.setsource.button"), null, NewWizardMessages.getString("LibrariesWorkbookPage.libraries.remove.button") }; LibrariesAdapter adapter= new LibrariesAdapter(); fLibrariesList= new ListDialogField(adapter, buttonLabels, new CPListLabelProvider()); fLibrariesList.setDialogFieldListener(adapter); fLibrariesList.setLabelText(NewWizardMessages.getString("LibrariesWorkbookPage.libraries.label")); fLibrariesList.setRemoveButtonIndex(IDX_REMOVE); fLibrariesList.enableButton(IDX_EDIT, false); fLibrariesList.setViewerSorter(new CPListElementSorter()); }
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/LibrariesWorkbookPage.java
public void init(IJavaProject jproject) { fCurrJProject= jproject; updateLibrariesList(); } private boolean isLibraryKind(int kind) { return kind == IClasspathEntry.CPE_LIBRARY || kind == IClasspathEntry.CPE_VARIABLE || kind == IClasspathEntry.CPE_CONTAINER; } private void updateLibrariesList() { List cpelements= fClassPathList.getElements(); List libelements= new ArrayList(cpelements.size()); int nElements= cpelements.size(); for (int i= 0; i < nElements; i++) { CPListElement cpe= (CPListElement)cpelements.get(i); if (isLibraryKind(cpe.getEntryKind())) { libelements.add(cpe); } } fLibrariesList.setElements(libelements); } public Control getControl(Composite parent) { PixelConverter converter= new PixelConverter(parent); Composite composite= new Composite(parent, SWT.NONE);
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/LibrariesWorkbookPage.java
LayoutUtil.doDefaultLayout(composite, new DialogField[] { fLibrariesList }, true, SWT.DEFAULT, SWT.DEFAULT); LayoutUtil.setHorizontalGrabbing(fLibrariesList.getListControl(null)); int buttonBarWidth= converter.convertWidthInCharsToPixels(24); fLibrariesList.setButtonsMinWidth(buttonBarWidth); fLibrariesList.getTableViewer().setSorter(new CPListElementSorter()); fSWTControl= composite; return composite; } private Shell getShell() { if (fSWTControl != null) { return fSWTControl.getShell(); } return JavaPlugin.getActiveWorkbenchShell(); } private class LibrariesAdapter implements IDialogFieldListener, IListAdapter { public void customButtonPressed(DialogField field, int index) { libaryPageCustomButtonPressed(field, index); } public void selectionChanged(DialogField field) {
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/LibrariesWorkbookPage.java
libaryPageSelectionChanged(field); } public void dialogFieldChanged(DialogField field) { libaryPageDialogFieldChanged(field); } } private void libaryPageCustomButtonPressed(DialogField field, int index) { CPListElement[] libentries= null; switch (index) { case IDX_ADDJAR: libentries= chooseJarFiles(); break; case IDX_ADDEXT: libentries= chooseExtJarFiles(); break; case IDX_ADDVAR: libentries= chooseVariableEntries(); break; case IDX_ADDADV: AdvancedDialog advDialog= new AdvancedDialog(getShell()); if (advDialog.open() == advDialog.OK) { libentries= advDialog.getResult(); } break; case IDX_EDIT: List selElements= fLibrariesList.getSelectedElements();
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/LibrariesWorkbookPage.java
CPListElement selElement= (CPListElement) selElements.get(0); SourceAttachmentDialog dialog= new SourceAttachmentDialog(getShell(), fWorkspaceRoot, selElement.getClasspathEntry()); if (dialog.open() == dialog.OK) { selElement.setSourceAttachment(dialog.getSourceAttachmentPath(), dialog.getSourceAttachmentRootPath()); fLibrariesList.refresh(); fClassPathList.refresh(); } break; } if (libentries != null) { int nElementsChosen= libentries.length; List cplist= fLibrariesList.getElements(); List elementsToAdd= new ArrayList(nElementsChosen); for (int i= 0; i < nElementsChosen; i++) { CPListElement curr= libentries[i]; if (!cplist.contains(curr) && !elementsToAdd.contains(curr)) { elementsToAdd.add(curr); addAttachmentsFromExistingLibs(curr); } } fLibrariesList.addElements(elementsToAdd); fLibrariesList.postSetSelection(new StructuredSelection(libentries)); } } private void libaryPageSelectionChanged(DialogField field) { List selElements= fLibrariesList.getSelectedElements(); fLibrariesList.enableButton(IDX_EDIT, canDoSourceAttachment(selElements));
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/LibrariesWorkbookPage.java
} private void libaryPageDialogFieldChanged(DialogField field) { if (fCurrJProject != null) { updateClasspathList(); } } private boolean canDoSourceAttachment(List selElements) { if (selElements != null && selElements.size() == 1) { CPListElement elem= (CPListElement) selElements.get(0); if (elem.getEntryKind() == IClasspathEntry.CPE_LIBRARY) { return (!(elem.getResource() instanceof IFolder)); } else if (elem.getEntryKind() == IClasspathEntry.CPE_VARIABLE) { return true; } } return false; } private void updateClasspathList() { List projelements= fLibrariesList.getElements(); boolean remove= false; List cpelements= fClassPathList.getElements(); for (int i= cpelements.size() - 1; i >= 0; i--) { CPListElement cpe= (CPListElement)cpelements.get(i); int kind= cpe.getEntryKind();
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/LibrariesWorkbookPage.java
if (isLibraryKind(kind)) { if (!projelements.remove(cpe)) { cpelements.remove(i); remove= true; } } } for (int i= 0; i < projelements.size(); i++) { cpelements.add(projelements.get(i)); } if (remove || (projelements.size() > 0)) { fClassPathList.setElements(cpelements); } } private CPListElement[] createNewClassContainer() { String title= NewWizardMessages.getString("LibrariesWorkbookPage.NewClassFolderDialog.title"); IProject currProject= fCurrJProject.getProject(); NewContainerDialog dialog= new NewContainerDialog(getShell(), title, currProject, getUsedContainers()); IPath projpath= currProject.getFullPath(); dialog.setMessage(NewWizardMessages.getFormattedString("LibrariesWorkbookPage.NewClassFolderDialog.description", projpath.toString())); int ret= dialog.open(); if (ret == dialog.OK) { IFolder folder= dialog.getFolder(); return new CPListElement[] { newCPLibraryElement(folder) }; } return null; }
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/LibrariesWorkbookPage.java
private CPListElement[] chooseClassContainers() { Class[] acceptedClasses= new Class[] { IFolder.class }; TypedElementSelectionValidator validator= new TypedElementSelectionValidator(acceptedClasses, true); acceptedClasses= new Class[] { IProject.class, IFolder.class }; ViewerFilter filter= new TypedViewerFilter(acceptedClasses, getUsedContainers()); ILabelProvider lp= new WorkbenchLabelProvider(); ITreeContentProvider cp= new WorkbenchContentProvider(); ElementTreeSelectionDialog dialog= new ElementTreeSelectionDialog(getShell(), lp, cp); dialog.setValidator(validator); dialog.setTitle(NewWizardMessages.getString("LibrariesWorkbookPage.ExistingClassFolderDialog.title")); dialog.setMessage(NewWizardMessages.getString("LibrariesWorkbookPage.ExistingClassFolderDialog.description")); dialog.addFilter(filter); dialog.setInput(fWorkspaceRoot); dialog.setInitialSelection(fCurrJProject.getProject()); if (dialog.open() == dialog.OK) { Object[] elements= dialog.getResult(); CPListElement[] res= new CPListElement[elements.length]; for (int i= 0; i < res.length; i++) { IResource elem= (IResource) elements[i]; res[i]= newCPLibraryElement(elem); } return res; } return null; }
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/LibrariesWorkbookPage.java
private CPListElement[] chooseJarFiles() { Class[] acceptedClasses= new Class[] { IFile.class }; TypedElementSelectionValidator validator= new TypedElementSelectionValidator(acceptedClasses, true); ViewerFilter filter= new ArchiveFileFilter(getUsedJARFiles()); ILabelProvider lp= new WorkbenchLabelProvider(); ITreeContentProvider cp= new WorkbenchContentProvider(); ElementTreeSelectionDialog dialog= new ElementTreeSelectionDialog(getShell(), lp, cp); dialog.setValidator(validator); dialog.setTitle(NewWizardMessages.getString("LibrariesWorkbookPage.JARArchiveDialog.title")); dialog.setMessage(NewWizardMessages.getString("LibrariesWorkbookPage.JARArchiveDialog.description")); dialog.addFilter(filter); dialog.setInput(fWorkspaceRoot); dialog.setInitialSelection(fCurrJProject.getProject()); if (dialog.open() == dialog.OK) { Object[] elements= dialog.getResult(); CPListElement[] res= new CPListElement[elements.length]; for (int i= 0; i < res.length; i++) { IResource elem= (IResource)elements[i]; res[i]= newCPLibraryElement(elem); } return res; } return null; } private IContainer[] getUsedContainers() { ArrayList res= new ArrayList(); if (fCurrJProject.exists()) {
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/LibrariesWorkbookPage.java
try { IPath outputLocation= fCurrJProject.getOutputLocation(); if (outputLocation != null) { IResource resource= fWorkspaceRoot.findMember(outputLocation); if (resource instanceof IFolder) { res.add(resource); } } } catch (JavaModelException e) { JavaPlugin.log(e.getStatus()); } } List cplist= fLibrariesList.getElements(); for (int i= 0; i < cplist.size(); i++) { CPListElement elem= (CPListElement)cplist.get(i); if (elem.getEntryKind() == IClasspathEntry.CPE_LIBRARY) { IResource resource= elem.getResource(); if (resource instanceof IContainer) { res.add(resource); } } } return (IContainer[]) res.toArray(new IContainer[res.size()]); } private IFile[] getUsedJARFiles() { List res= new ArrayList(); List cplist= fLibrariesList.getElements();
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/LibrariesWorkbookPage.java
for (int i= 0; i < cplist.size(); i++) { CPListElement elem= (CPListElement)cplist.get(i); if (elem.getEntryKind() == IClasspathEntry.CPE_LIBRARY) { IResource resource= elem.getResource(); if (resource instanceof IFile) { res.add(resource); } } } return (IFile[]) res.toArray(new IFile[res.size()]); } private CPListElement newCPLibraryElement(IResource res) { return new CPListElement(fCurrJProject, IClasspathEntry.CPE_LIBRARY, res.getFullPath(), res); }; private CPListElement[] chooseExtJarFiles() { String lastUsedPath= fDialogSettings.get(IUIConstants.DIALOGSTORE_LASTEXTJAR); if (lastUsedPath == null) { lastUsedPath= ""; } FileDialog dialog= new FileDialog(getShell(), SWT.MULTI); dialog.setText(NewWizardMessages.getString("LibrariesWorkbookPage.ExtJARArchiveDialog.title")); dialog.setFilterExtensions(new String[] {"*.jar;*.zip"}); dialog.setFilterPath(lastUsedPath); String res= dialog.open(); if (res == null) { return null; } String[] fileNames= dialog.getFileNames();
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/LibrariesWorkbookPage.java
int nChosen= fileNames.length; IPath filterPath= new Path(dialog.getFilterPath()); CPListElement[] elems= new CPListElement[nChosen]; for (int i= 0; i < nChosen; i++) { IPath path= filterPath.append(fileNames[i]).makeAbsolute(); elems[i]= new CPListElement(fCurrJProject, IClasspathEntry.CPE_LIBRARY, path, null); } fDialogSettings.put(IUIConstants.DIALOGSTORE_LASTEXTJAR, filterPath.toOSString()); return elems; } private CPListElement[] chooseVariableEntries() { NewVariableEntryDialog dialog= new NewVariableEntryDialog(getShell(), null); if (dialog.open() == dialog.OK) { List existingElements= fLibrariesList.getElements(); IPath[] paths= dialog.getResult(); ArrayList result= new ArrayList(); for (int i = 0; i < paths.length; i++) { CPListElement elem= new CPListElement(fCurrJProject, IClasspathEntry.CPE_VARIABLE, paths[i], null); IPath resolvedPath= JavaCore.getResolvedVariablePath(paths[i]); elem.setIsMissing((resolvedPath == null) || !resolvedPath.toFile().exists()); if (!existingElements.contains(elem)) { result.add(elem); } } return (CPListElement[]) result.toArray(new CPListElement[result.size()]); }
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/LibrariesWorkbookPage.java
return null; } private CPListElement[] chooseContainerEntry(ClasspathContainerDescriptor desc) { ClasspathContainerWizard wizard= new ClasspathContainerWizard(desc); WizardDialog dialog= new WizardDialog(getShell(), wizard); PixelConverter converter= new PixelConverter(getShell()); dialog.setMinimumPageSize(converter.convertWidthInCharsToPixels(40), converter.convertHeightInCharsToPixels(20)); dialog.create(); dialog.getShell().setText(NewWizardMessages.getString("LibrariesWorkbookPage.ContainerDialog.title")); if (dialog.open() == dialog.OK) { IClasspathEntry created= wizard.getNewEntry(); if (created != null) { CPListElement elem= new CPListElement(fCurrJProject, IClasspathEntry.CPE_CONTAINER, created.getPath(), null); return new CPListElement[] { elem }; } } return null; } private void addAttachmentsFromExistingLibs(CPListElement elem) { if (elem.getEntryKind() == IClasspathEntry.CPE_CONTAINER) { return; } try { IJavaModel jmodel= fCurrJProject.getJavaModel();
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/LibrariesWorkbookPage.java
IJavaProject[] jprojects= jmodel.getJavaProjects(); for (int i= 0; i < jprojects.length; i++) { IJavaProject curr= jprojects[i]; if (!curr.equals(fCurrJProject)) { IClasspathEntry[] entries= curr.getRawClasspath(); for (int k= 0; k < entries.length; k++) { IClasspathEntry entry= entries[k]; if (entry.getEntryKind() == elem.getEntryKind() && entry.getPath().equals(elem.getPath())) { IPath attachPath= entry.getSourceAttachmentPath(); if (attachPath != null && !attachPath.isEmpty()) { elem.setSourceAttachment(attachPath, entry.getSourceAttachmentRootPath()); return; } } } } } } catch (JavaModelException e) { JavaPlugin.log(e.getStatus()); } } private class AdvancedDialog extends Dialog { private DialogField fLabelField; private SelectionButtonDialogField fCreateFolderField; private SelectionButtonDialogField fAddFolderField; private SelectionButtonDialogField fAddContainerField; private ComboDialogField fCombo; private CPListElement[] fResult;
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/LibrariesWorkbookPage.java
private ClasspathContainerDescriptor[] fDescriptors; public AdvancedDialog(Shell parent) { super(parent); fDescriptors= ClasspathContainerDescriptor.getDescriptors(); fLabelField= new DialogField(); fLabelField.setLabelText(NewWizardMessages.getString("LibrariesWorkbookPage.AdvancedDialog.description")); fCreateFolderField= new SelectionButtonDialogField(SWT.RADIO); fCreateFolderField.setLabelText(NewWizardMessages.getString("LibrariesWorkbookPage.AdvancedDialog.createfolder")); fAddFolderField= new SelectionButtonDialogField(SWT.RADIO); fAddFolderField.setLabelText(NewWizardMessages.getString("LibrariesWorkbookPage.AdvancedDialog.addfolder")); fAddContainerField= new SelectionButtonDialogField(SWT.RADIO); fAddContainerField.setLabelText(NewWizardMessages.getString("LibrariesWorkbookPage.AdvancedDialog.addcontainer")); String[] names= new String[fDescriptors.length]; for (int i = 0; i < names.length; i++) { names[i]= fDescriptors[i].getName(); } fCombo= new ComboDialogField(SWT.READ_ONLY); fCombo.setItems(names); fCombo.selectItem(0); fAddContainerField.attachDialogField(fCombo); } /* * @see Window#create(Shell) */
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/LibrariesWorkbookPage.java
protected void configureShell(Shell shell) { super.configureShell(shell); shell.setText(NewWizardMessages.getString("LibrariesWorkbookPage.AdvancedDialog.title")); } protected Control createDialogArea(Composite parent) { initializeDialogUnits(parent); Composite composite= (Composite) super.createDialogArea(parent); Composite inner= new Composite(composite, SWT.NONE); GridLayout layout= new GridLayout(); layout.marginHeight= 0; layout.marginWidth= 0; inner.setLayout(layout); fLabelField.doFillIntoGrid(inner, 1); fCreateFolderField.doFillIntoGrid(inner, 1); fAddFolderField.doFillIntoGrid(inner, 1); fAddContainerField.doFillIntoGrid(inner, 1); Control control= fCombo.getComboControl(inner); GridData gd= new GridData(GridData.HORIZONTAL_ALIGN_FILL); gd.horizontalIndent= convertWidthInCharsToPixels(3); control.setLayoutData(gd); return composite; } /* (non-Javadoc) * @see Dialog#okPressed() */
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/LibrariesWorkbookPage.java
protected void okPressed() { fResult= null; if (fCreateFolderField.isSelected()) { fResult= createNewClassContainer(); } else if (fAddFolderField.isSelected()) { fResult= chooseClassContainers(); } else if (fAddContainerField.isSelected()) { String selected= fCombo.getText(); for (int i = 0; i < fDescriptors.length; i++) { if (fDescriptors[i].getName().equals(selected)) { fResult= chooseContainerEntry(fDescriptors[i]); break; } } } if (fResult != null) { super.okPressed(); } } public CPListElement[] getResult() { return fResult; } } private static class SourceAttachmentDialog extends StatusDialog implements IStatusChangeListener {
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/LibrariesWorkbookPage.java
private SourceAttachmentBlock fSourceAttachmentBlock; public SourceAttachmentDialog(Shell parent, IWorkspaceRoot root, IClasspathEntry entry) { super(parent); setTitle(NewWizardMessages.getFormattedString("LibrariesWorkbookPage.SourceAttachmentDialog.title", entry.getPath().toString())); fSourceAttachmentBlock= new SourceAttachmentBlock(root, this, entry); } /* * @see Windows#configureShell */ protected void configureShell(Shell newShell) { super.configureShell(newShell); WorkbenchHelp.setHelp(newShell, IJavaHelpContextIds.SOURCE_ATTACHMENT_DIALOG); } protected Control createDialogArea(Composite parent) { Composite composite= (Composite)super.createDialogArea(parent); Control inner= fSourceAttachmentBlock.createControl(composite); inner.setLayoutData(new GridData(GridData.FILL_BOTH)); return composite; } public void statusChanged(IStatus status) { updateStatus(status); }
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/LibrariesWorkbookPage.java
public IPath getSourceAttachmentPath() { return fSourceAttachmentBlock.getSourceAttachmentPath(); } public IPath getSourceAttachmentRootPath() { return fSourceAttachmentBlock.getSourceAttachmentRootPath(); } } /* * @see BuildPathBasePage#getSelection */ public List getSelection() { return fLibrariesList.getSelectedElements(); } /* * @see BuildPathBasePage#setSelection */ public void setSelection(List selElements) { for (int i= selElements.size()-1; i >= 0; i--) { CPListElement curr= (CPListElement) selElements.get(i); if (!isLibraryKind(curr.getEntryKind())) { selElements.remove(i); } } fLibrariesList.selectElements(new StructuredSelection(selElements)); } }
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/NewContainerDialog.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.wizards.buildpaths; import org.eclipse.swt.SWT; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Shell; import org.eclipse.core.resources.IContainer; import org.eclipse.core.resources.IFolder; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IWorkspace; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.IStatus; import org.eclipse.jdt.internal.ui.dialogs.StatusDialog; import org.eclipse.jdt.internal.ui.dialogs.StatusInfo; import org.eclipse.jdt.internal.ui.wizards.NewWizardMessages; import org.eclipse.jdt.internal.ui.wizards.dialogfields.DialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IDialogFieldListener; import org.eclipse.jdt.internal.ui.wizards.dialogfields.LayoutUtil; import org.eclipse.jdt.internal.ui.wizards.dialogfields.StringDialogField; import org.eclipse.swt.layout.GridLayout; public class NewContainerDialog extends StatusDialog {
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/NewContainerDialog.java
private StringDialogField fContainerDialogField; private StatusInfo fContainerFieldStatus; private IFolder fFolder; private IContainer[] fExistingFolders; private IProject fCurrProject; public NewContainerDialog(Shell parent, String title, IProject project, IContainer[] existingFolders) { super(parent); setTitle(title); fContainerFieldStatus= new StatusInfo(); SourceContainerAdapter adapter= new SourceContainerAdapter(); fContainerDialogField= new StringDialogField(); fContainerDialogField.setDialogFieldListener(adapter); fFolder= null; fExistingFolders= existingFolders; fCurrProject= project; fContainerDialogField.setText(""); }
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/NewContainerDialog.java
public void setMessage(String message) { fContainerDialogField.setLabelText(message); } protected Control createDialogArea(Composite parent) { Composite composite= (Composite)super.createDialogArea(parent); int widthHint= convertWidthInCharsToPixels(80); Composite inner= new Composite(composite, SWT.NONE); GridLayout layout= new GridLayout(); layout.marginHeight= 0; layout.marginWidth= 0; layout.numColumns= 1; inner.setLayout(layout); fContainerDialogField.doFillIntoGrid(inner, 2); LayoutUtil.setWidthHint(fContainerDialogField.getLabelControl(null), widthHint); LayoutUtil.setWidthHint(fContainerDialogField.getTextControl(null), widthHint); LayoutUtil.setHorizontalGrabbing(fContainerDialogField.getTextControl(null)); fContainerDialogField.postSetFocusOnDialogField(parent.getDisplay()); return composite; } private class SourceContainerAdapter implements IDialogFieldListener {
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/NewContainerDialog.java
public void dialogFieldChanged(DialogField field) { doStatusLineUpdate(); } } protected void doStatusLineUpdate() { checkIfPathValid(); updateStatus(fContainerFieldStatus); } protected void checkIfPathValid() { fFolder= null; String pathStr= fContainerDialogField.getText(); if (pathStr.length() == 0) { fContainerFieldStatus.setError(NewWizardMessages.getString("NewContainerDialog.error.enterpath")); return; } IPath path= fCurrProject.getFullPath().append(pathStr); IWorkspace workspace= fCurrProject.getWorkspace(); IStatus pathValidation= workspace.validatePath(path.toString(), IResource.FOLDER);
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/NewContainerDialog.java
if (!pathValidation.isOK()) { fContainerFieldStatus.setError(NewWizardMessages.getFormattedString("NewContainerDialog.error.invalidpath", pathValidation.getMessage())); return; } IFolder folder= fCurrProject.getFolder(pathStr); if (isFolderExisting(folder)) { fContainerFieldStatus.setError(NewWizardMessages.getString("NewContainerDialog.error.pathexists")); return; } fContainerFieldStatus.setOK(); fFolder= folder; } private boolean isFolderExisting(IFolder folder) { for (int i= 0; i < fExistingFolders.length; i++) { if (folder.equals(fExistingFolders[i])) { return true; } } return false; } public IFolder getFolder() { return fFolder; } }
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/NewVariableEntryDialog.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.wizards.buildpaths; import java.io.File; import java.util.List; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.Path; import org.eclipse.swt.graphics.Image; import org.eclipse.swt.widgets.Button; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.dialogs.Dialog; import org.eclipse.jface.dialogs.IDialogConstants; import org.eclipse.jface.viewers.DoubleClickEvent; import org.eclipse.jface.viewers.IDoubleClickListener; import org.eclipse.jface.viewers.ILabelProvider; import org.eclipse.jface.viewers.ISelectionChangedListener; import org.eclipse.jface.viewers.ITreeContentProvider; import org.eclipse.jface.viewers.LabelProvider; import org.eclipse.jface.viewers.SelectionChangedEvent; import org.eclipse.jface.viewers.Viewer; import org.eclipse.ui.dialogs.ElementTreeSelectionDialog; import org.eclipse.ui.ISharedImages; import org.eclipse.ui.PlatformUI; import org.eclipse.jdt.internal.ui.wizards.NewWizardMessages; public class NewVariableEntryDialog extends Dialog {
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/NewVariableEntryDialog.java
private class VariableSelectionListener implements IDoubleClickListener, ISelectionChangedListener { public void doubleClick(DoubleClickEvent event) { doDoubleClick(); } public void selectionChanged(SelectionChangedEvent event) { doSelectionChanged(); } } private static class FileLabelProvider extends LabelProvider {
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/NewVariableEntryDialog.java
private final Image IMG_FOLDER= PlatformUI.getWorkbench().getSharedImages().getImage(ISharedImages.IMG_OBJ_FOLDER); private final Image IMG_FILE= PlatformUI.getWorkbench().getSharedImages().getImage(ISharedImages.IMG_OBJ_FILE); public Image getImage(Object element) { if (element instanceof File) { File curr= (File) element; if (curr.isDirectory()) { return IMG_FOLDER; } else { return IMG_FILE; } } return null; } public String getText(Object element) { if (element instanceof File) { return ((File) element).getName(); } return super.getText(element); } } private static class FileContentProvider implements ITreeContentProvider {
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/NewVariableEntryDialog.java
private final Object[] EMPTY= new Object[0]; public Object[] getChildren(Object parentElement) { if (parentElement instanceof File) { File[] children= ((File) parentElement).listFiles(); if (children != null) { return children; } }
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/NewVariableEntryDialog.java
return EMPTY; } public Object getParent(Object element) { if (element instanceof File) { return ((File) element).getParentFile(); } return null; } public boolean hasChildren(Object element) { return getChildren(element).length > 0; } public Object[] getElements(Object element) { return getChildren(element); } public void dispose() { } public void inputChanged(Viewer viewer, Object oldInput, Object newInput) { } } private VariableBlock fVariableBlock; private Button fExtensionButton; private Button fOkButton; private IPath[] fResultPaths;
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/NewVariableEntryDialog.java
public NewVariableEntryDialog(Shell parent, String variableSelection) { super(parent); fVariableBlock= new VariableBlock(false, variableSelection); fResultPaths= null; } /* (non-Javadoc) * @see Window#configureShell(Shell) */ protected void configureShell(Shell shell) { shell.setText(NewWizardMessages.getString("NewVariableEntryDialog.title")); super.configureShell(shell); } protected Control createDialogArea(Composite parent) { VariableSelectionListener listener= new VariableSelectionListener(); Composite composite= (Composite)super.createDialogArea(parent); fVariableBlock.createContents(composite); fVariableBlock.addDoubleClickListener(listener); fVariableBlock.addSelectionChangedListener(listener); return composite; } /** * @see Dialog#createButtonsForButtonBar(Composite) */ protected void createButtonsForButtonBar(Composite parent) { fOkButton= createButton(parent, IDialogConstants.OK_ID, NewWizardMessages.getString("NewVariableEntryDialog.add.button"), true);
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/NewVariableEntryDialog.java
fExtensionButton= createButton(parent, IDialogConstants.CLIENT_ID, NewWizardMessages.getString("NewVariableEntryDialog.addextension.button"), false); createButton(parent, IDialogConstants.CANCEL_ID, IDialogConstants.CANCEL_LABEL, false); } protected void okPressed() { fVariableBlock.performOk(); super.okPressed(); } public IPath[] getResult() { return fResultPaths; } /* * @see IDoubleClickListener#doubleClick(DoubleClickEvent) */ private void doDoubleClick() { List selected= fVariableBlock.getSelectedElements(); if (!selected.isEmpty()) { okPressed(); } } private void doSelectionChanged() { boolean isValidSelection= true; List selected= fVariableBlock.getSelectedElements(); int nSelected= selected.size();
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/NewVariableEntryDialog.java
boolean canExtend= false; if (nSelected > 0) { fResultPaths= new Path[nSelected]; for (int i= 0; i < nSelected; i++) { CPVariableElement curr= (CPVariableElement) selected.get(i); fResultPaths[i]= new Path(curr.getName()); if (!curr.getPath().toFile().isFile()) { isValidSelection= false; } } } else { isValidSelection= false; } fExtensionButton.setEnabled(nSelected == 1 && !isValidSelection); fOkButton.setEnabled(isValidSelection); } private IPath[] chooseExtensions(CPVariableElement elem) { File file= elem.getPath().toFile(); ILabelProvider lp= new FileLabelProvider(); ITreeContentProvider cp= new FileContentProvider(); ElementTreeSelectionDialog dialog= new ElementTreeSelectionDialog(getShell(), lp, cp); dialog.setTitle(NewWizardMessages.getString("NewVariableEntryDialog.ExtensionDialog.title")); dialog.setMessage(NewWizardMessages.getFormattedString("NewVariableEntryDialog.ExtensionDialog.description", elem.getName())); dialog.setInput(file); if (dialog.open() == dialog.OK) { Object[] selected= dialog.getResult(); IPath[] paths= new IPath[selected.length];
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/NewVariableEntryDialog.java
for (int i= 0; i < selected.length; i++) { IPath filePath= new Path(((File) selected[i]).getPath()); IPath resPath= new Path(elem.getName()); for (int k= elem.getPath().segmentCount(); k < filePath.segmentCount(); k++) { resPath= resPath.append(filePath.segment(k)); } paths[i]= resPath; } return paths; } return null; } /* * @see Dialog#buttonPressed(int) */ protected void buttonPressed(int buttonId) { if (buttonId == IDialogConstants.CLIENT_ID) { List selected= fVariableBlock.getSelectedElements(); if (selected.size() == 1) { IPath[] extendedPaths= chooseExtensions((CPVariableElement) selected.get(0)); if (extendedPaths != null) { fResultPaths= extendedPaths; super.buttonPressed(IDialogConstants.OK_ID); } } } else { super.buttonPressed(buttonId); } } }
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/SourceContainerWorkbookPage.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.wizards.buildpaths; import java.util.ArrayList; import java.util.List; import org.eclipse.core.resources.IContainer; import org.eclipse.core.resources.IFolder; import org.eclipse.core.resources.IProject; import org.eclipse.core.resources.IResource; import org.eclipse.core.resources.IWorkspaceRoot; import org.eclipse.core.runtime.IPath; import org.eclipse.core.runtime.Path; import org.eclipse.swt.SWT; import org.eclipse.swt.layout.GridData; import org.eclipse.swt.layout.GridLayout; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.util.Assert; import org.eclipse.jface.viewers.ILabelProvider;
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/SourceContainerWorkbookPage.java
import org.eclipse.jface.viewers.ITreeContentProvider; import org.eclipse.jface.viewers.StructuredSelection; import org.eclipse.jface.viewers.ViewerFilter; import org.eclipse.ui.dialogs.ElementTreeSelectionDialog; import org.eclipse.ui.model.WorkbenchContentProvider; import org.eclipse.ui.model.WorkbenchLabelProvider; import org.eclipse.jdt.core.IClasspathEntry; import org.eclipse.jdt.core.IJavaProject; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.preferences.JavaBasePreferencePage; import org.eclipse.jdt.internal.ui.util.PixelConverter; import org.eclipse.jdt.internal.ui.wizards.NewWizardMessages; import org.eclipse.jdt.internal.ui.wizards.TypedElementSelectionValidator; import org.eclipse.jdt.internal.ui.wizards.TypedViewerFilter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.DialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IDialogFieldListener; import org.eclipse.jdt.internal.ui.wizards.dialogfields.IListAdapter; import org.eclipse.jdt.internal.ui.wizards.dialogfields.ListDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.SelectionButtonDialogField; import org.eclipse.jdt.internal.ui.wizards.dialogfields.StringDialogField; public class SourceContainerWorkbookPage extends BuildPathBasePage { private ListDialogField fClassPathList; private IJavaProject fCurrJProject; private IPath fProjPath; private Control fSWTControl; private IWorkspaceRoot fWorkspaceRoot; private SelectionButtonDialogField fProjectRadioButton;
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/SourceContainerWorkbookPage.java
private SelectionButtonDialogField fFolderRadioButton; private ListDialogField fFoldersList; private CPListElement fProjectCPEntry; private StringDialogField fOutputLocationField; private boolean fIsProjSelected; public SourceContainerWorkbookPage(IWorkspaceRoot root, ListDialogField classPathList, StringDialogField outputLocationField) { fWorkspaceRoot= root; fClassPathList= classPathList; fProjectCPEntry= null; fOutputLocationField= outputLocationField; fSWTControl= null; SourceContainerAdapter adapter= new SourceContainerAdapter(); fProjectRadioButton= new SelectionButtonDialogField(SWT.RADIO); fProjectRadioButton.setDialogFieldListener(adapter); fProjectRadioButton.setLabelText(NewWizardMessages.getString("SourceContainerWorkbookPage.rb1.label")); fFolderRadioButton= new SelectionButtonDialogField(SWT.RADIO); fFolderRadioButton.setDialogFieldListener(adapter); fFolderRadioButton.setLabelText(NewWizardMessages.getString("SourceContainerWorkbookPage.rb2.label")); String[] buttonLabels; int removeIndex; buttonLabels= new String[] { NewWizardMessages.getString("SourceContainerWorkbookPage.folders.addnew.button"), NewWizardMessages.getString("SourceContainerWorkbookPage.folders.addnew.addexisting.button"),
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/SourceContainerWorkbookPage.java
null, NewWizardMessages.getString("SourceContainerWorkbookPage.folders.remove.button") }; removeIndex= 3; fFoldersList= new ListDialogField(adapter, buttonLabels, new CPListLabelProvider()); fFoldersList.setDialogFieldListener(adapter); fFoldersList.setLabelText(NewWizardMessages.getString("SourceContainerWorkbookPage.folders.label")); fFoldersList.setRemoveButtonIndex(removeIndex); fFoldersList.setViewerSorter(new CPListElementSorter()); fFolderRadioButton.setSelection(true); fProjectRadioButton.setSelection(false); fFolderRadioButton.attachDialogField(fFoldersList); } public void init(IJavaProject jproject) { fCurrJProject= jproject; fProjPath= fCurrJProject.getProject().getFullPath(); updateFoldersList(); } private void updateFoldersList() { fIsProjSelected= false; List srcelements= new ArrayList(fClassPathList.getSize()); List cpelements= fClassPathList.getElements(); for (int i= 0; i < cpelements.size(); i++) { CPListElement cpe= (CPListElement)cpelements.get(i);
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/SourceContainerWorkbookPage.java
if (cpe.getEntryKind() == IClasspathEntry.CPE_SOURCE) { if (fProjPath.equals(cpe.getPath())) { srcelements.clear(); fProjectCPEntry= cpe; fIsProjSelected= true; break; } else { srcelements.add(cpe); } } } fFoldersList.setElements(srcelements); fFolderRadioButton.setSelection(!fIsProjSelected); fProjectRadioButton.setSelection(fIsProjSelected); } public Control getControl(Composite parent) { PixelConverter converter= new PixelConverter(parent); Composite composite= new Composite(parent, SWT.NONE); GridLayout layout= new GridLayout(); layout.numColumns= 2; composite.setLayout(layout); fProjectRadioButton.doFillIntoGrid(composite, 2); fFolderRadioButton.doFillIntoGrid(composite, 2);
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/SourceContainerWorkbookPage.java
Control control= fFoldersList.getListControl(composite); GridData gd= new GridData(GridData.FILL_BOTH); gd.horizontalIndent= converter.convertWidthInCharsToPixels(2); gd.widthHint= converter.convertWidthInCharsToPixels(50); gd.heightHint= converter.convertWidthInCharsToPixels(15); gd.grabExcessHorizontalSpace= true; control.setLayoutData(gd); control= fFoldersList.getButtonBox(composite); gd= new GridData(gd.VERTICAL_ALIGN_FILL + gd.HORIZONTAL_ALIGN_FILL); control.setLayoutData(gd); int buttonBarWidth= converter.convertWidthInCharsToPixels(24); fFoldersList.setButtonsMinWidth(buttonBarWidth); fSWTControl= composite; return composite; } private Shell getShell() { if (fSWTControl != null) { return fSWTControl.getShell(); } return JavaPlugin.getActiveWorkbenchShell(); } private class SourceContainerAdapter implements IListAdapter, IDialogFieldListener {
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/SourceContainerWorkbookPage.java
public void customButtonPressed(DialogField field, int index) { sourcePageCustomButtonPressed(field, index); } public void selectionChanged(DialogField field) {} public void dialogFieldChanged(DialogField field) { sourcePageDialogFieldChanged(field); } } private void sourcePageCustomButtonPressed(DialogField field, int index) { if (field == fFoldersList) { List elementsToAdd= new ArrayList(10); switch (index) { case 0: CPListElement srcentry= createNewSourceContainer(); if (srcentry != null) { elementsToAdd.add(srcentry); } break; case 1: CPListElement[] srcentries= chooseSourceContainers(); if (srcentries != null) { for (int i= 0; i < srcentries.length; i++) {
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/SourceContainerWorkbookPage.java
elementsToAdd.add(srcentries[i]); } } break; } if (!elementsToAdd.isEmpty()) { fFoldersList.addElements(elementsToAdd); fFoldersList.postSetSelection(new StructuredSelection(elementsToAdd)); if (fFoldersList.getSize() == elementsToAdd.size()) { askForChangingBuildPathDialog(); } } } } private void sourcePageDialogFieldChanged(DialogField field) { if (fCurrJProject == null) { return; } if (field == fFolderRadioButton) { if (fFolderRadioButton.isSelected()) { fIsProjSelected= false; updateClasspathList(); if (fFoldersList.getSize() > 0) { askForChangingBuildPathDialog(); } }
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/SourceContainerWorkbookPage.java
} else if (field == fProjectRadioButton) { if (fProjectRadioButton.isSelected()) { fIsProjSelected= true; updateClasspathList(); } } else if (field == fFoldersList) { updateClasspathList(); } } private void updateClasspathList() { List cpelements= fClassPathList.getElements(); List srcelements; if (fIsProjSelected) { srcelements= new ArrayList(1); if (fProjectCPEntry == null) { fProjectCPEntry= newCPSourceElement(fCurrJProject.getProject()); } srcelements.add(fProjectCPEntry); } else { srcelements= fFoldersList.getElements(); } boolean changeDone= false; CPListElement lastSourceFolder= null; for (int i= cpelements.size() - 1; i >= 0 ; i--) { CPListElement cpe= (CPListElement)cpelements.get(i);
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/SourceContainerWorkbookPage.java
if (cpe.getEntryKind() == IClasspathEntry.CPE_SOURCE) { if (!srcelements.remove(cpe)) { cpelements.remove(i); changeDone= true; } else if (lastSourceFolder == null) { lastSourceFolder= cpe; } } } if (!srcelements.isEmpty()) { int insertIndex= (lastSourceFolder == null) ? 0 : cpelements.indexOf(lastSourceFolder) + 1; cpelements.addAll(insertIndex, srcelements); changeDone= true; } if (changeDone) { fClassPathList.setElements(cpelements); } } private CPListElement createNewSourceContainer() { IProject proj= fCurrJProject.getProject(); String title= NewWizardMessages.getString("SourceContainerWorkbookPage.NewSourceFolderDialog.title"); NewContainerDialog dialog= new NewContainerDialog(getShell(), title, proj, getExistingContainers()); dialog.setMessage(NewWizardMessages.getFormattedString("SourceContainerWorkbookPage.NewSourceFolderDialog.description", fProjPath.toString())); if (dialog.open() == dialog.OK) { IFolder folder= dialog.getFolder(); return newCPSourceElement(folder); }
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/SourceContainerWorkbookPage.java
return null; } /** * Asks to change the output folder to 'proj/bin' when no source folders were existing */ private void askForChangingBuildPathDialog() { IPath outputFolder= new Path(fOutputLocationField.getText()); if (outputFolder.segmentCount() == 1) { String outputFolderName= JavaBasePreferencePage.getOutputLocationName(); IPath newPath= outputFolder.append(outputFolderName); String title= NewWizardMessages.getString("SourceContainerWorkbookPage.ChangeOutputLocationDialog.title"); String message= NewWizardMessages.getFormattedString("SourceContainerWorkbookPage.ChangeOutputLocationDialog.message", newPath); if (MessageDialog.openQuestion(getShell(), title, message)) { fOutputLocationField.setText(newPath.toString()); } } } private CPListElement[] chooseSourceContainers() { Class[] acceptedClasses= new Class[] { IFolder.class }; TypedElementSelectionValidator validator= new TypedElementSelectionValidator(acceptedClasses, true); acceptedClasses= new Class[] { IFolder.class }; ViewerFilter filter= new TypedViewerFilter(acceptedClasses, getExistingContainers()); ILabelProvider lp= new WorkbenchLabelProvider(); ITreeContentProvider cp= new WorkbenchContentProvider();
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/SourceContainerWorkbookPage.java
ElementTreeSelectionDialog dialog= new ElementTreeSelectionDialog(getShell(), lp, cp); dialog.setValidator(validator); dialog.setTitle(NewWizardMessages.getString("SourceContainerWorkbookPage.ExistingSourceFolderDialog.title")); dialog.setMessage(NewWizardMessages.getString("SourceContainerWorkbookPage.ExistingSourceFolderDialog.description")); dialog.addFilter(filter); dialog.setInput(fCurrJProject.getProject()); if (dialog.open() == dialog.OK) { Object[] elements= dialog.getResult(); CPListElement[] res= new CPListElement[elements.length]; for (int i= 0; i < res.length; i++) { IResource elem= (IResource)elements[i]; res[i]= newCPSourceElement(elem); } return res; } return null; } private IContainer[] getExistingContainers() { List res= new ArrayList(); List cplist= fFoldersList.getElements(); for (int i= 0; i < cplist.size(); i++) { CPListElement elem= (CPListElement)cplist.get(i); IResource resource= elem.getResource(); if (resource instanceof IContainer) { res.add(resource); } } return (IContainer[]) res.toArray(new IContainer[res.size()]); }
4,240
Bug 4240 Can't edit class path entry (1GKEPIF)
There is no way to edit an existing entry for a library on the Java Build Path project properties page (other than editing the .classpath file directly). NOTES: EG (9/22/2001 11:42:11 AM) this is particularly annoying for variables. we should have an Edit button when a variable is selected.
resolved fixed
b717ba0
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-16T21:17:21Z
2001-10-11T03:13:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/wizards/buildpaths/SourceContainerWorkbookPage.java
private CPListElement newCPSourceElement(IResource res) { Assert.isNotNull(res); return new CPListElement(fCurrJProject, IClasspathEntry.CPE_SOURCE, res.getFullPath(), res); } /* * @see BuildPathBasePage#getSelection */ public List getSelection() { if (fIsProjSelected) { ArrayList list= new ArrayList(1); list.add(fProjectCPEntry); return list; } else { return fFoldersList.getSelectedElements(); } } /* * @see BuildPathBasePage#setSelection */ public void setSelection(List selElements) { if (!fIsProjSelected) { filterSelection(selElements, IClasspathEntry.CPE_SOURCE); fFoldersList.selectElements(new StructuredSelection(selElements)); } } }
16,527
Bug 16527 New API in ISearchResultView breaks old if null is used
Build 20020519 ISearchResultView.searchStarted(.....). Clients were passing a null parameter that now has to be cast to IActionGroupFactory or IContextMenuProvider to get rid of compile errors.
resolved fixed
0fb5099
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T07:11:15Z
2002-05-21T05:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchResultCollector.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.search; import java.util.HashMap; import java.text.MessageFormat; import org.eclipse.core.resources.IMarker; import org.eclipse.core.resources.IResource; import org.eclipse.core.runtime.CoreException; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.action.IMenuManager; import org.eclipse.jface.viewers.IInputSelectionProvider; import org.eclipse.jface.viewers.ISelection; import org.eclipse.ui.IViewPart; import org.eclipse.ui.IWorkbenchPage; import org.eclipse.ui.IWorkbenchWindow; import org.eclipse.ui.actions.ActionContext; import org.eclipse.ui.actions.ActionGroup; import org.eclipse.search.ui.IActionGroupFactory; import org.eclipse.search.ui.IContextMenuContributor; import org.eclipse.search.ui.ISearchResultView; import org.eclipse.search.ui.ISearchResultViewEntry; import org.eclipse.search.ui.SearchUI; import org.eclipse.jdt.core.ICompilationUnit;
16,527
Bug 16527 New API in ISearchResultView breaks old if null is used
Build 20020519 ISearchResultView.searchStarted(.....). Clients were passing a null parameter that now has to be cast to IActionGroupFactory or IContextMenuProvider to get rid of compile errors.
resolved fixed
0fb5099
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T07:11:15Z
2002-05-21T05:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchResultCollector.java
import org.eclipse.jdt.core.IJavaElement; import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.search.IJavaSearchResultCollector; import org.eclipse.jdt.ui.JavaUI; import org.eclipse.jdt.ui.actions.JavaSearchActionGroup; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jdt.internal.ui.util.OpenTypeHierarchyUtil; import org.eclipse.jdt.internal.ui.util.SelectionUtil; public class JavaSearchResultCollector implements IJavaSearchResultCollector { private static final String MATCH= SearchMessages.getString("SearchResultCollector.match"); private static final String MATCHES= SearchMessages.getString("SearchResultCollector.matches"); private static final String DONE= SearchMessages.getString("SearchResultCollector.done"); private static final String SEARCHING= SearchMessages.getString("SearchResultCollector.searching"); private static final Boolean POTENTIAL_MATCH_VALUE= new Boolean(true); private IProgressMonitor fMonitor; private IContextMenuContributor fContextMenu; private ISearchResultView fView; private JavaSearchOperation fOperation; private int fMatchCount= 0; private int fPotentialMatchCount= 0; private Integer[] fMessageFormatArgs= new Integer[1]; private class ActionGroupFactory implements IActionGroupFactory { public ActionGroup createActionGroup(ISearchResultView part) { return new SearchViewActionGroup(part); } }
16,527
Bug 16527 New API in ISearchResultView breaks old if null is used
Build 20020519 ISearchResultView.searchStarted(.....). Clients were passing a null parameter that now has to be cast to IActionGroupFactory or IContextMenuProvider to get rid of compile errors.
resolved fixed
0fb5099
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T07:11:15Z
2002-05-21T05:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchResultCollector.java
public JavaSearchResultCollector() { JavaPlugin.getDefault().getImageRegistry(); } /** * @see IJavaSearchResultCollector#aboutToStart(). */ public void aboutToStart() { fPotentialMatchCount= 0; fView= SearchUI.getSearchResultView(); fMatchCount= 0; if (fView != null) { fView.searchStarted( JavaSearchPage.EXTENSION_POINT_ID, fOperation.getSingularLabel(), fOperation.getPluralLabelPattern(), fOperation.getImageDescriptor(), new ActionGroupFactory(), new JavaSearchResultLabelProvider(), new GotoMarkerAction(), new GroupByKeyComputer(), fOperation); } if (!getProgressMonitor().isCanceled()) getProgressMonitor().subTask(SEARCHING); } /** * @see IJavaSearchResultCollector#accept
16,527
Bug 16527 New API in ISearchResultView breaks old if null is used
Build 20020519 ISearchResultView.searchStarted(.....). Clients were passing a null parameter that now has to be cast to IActionGroupFactory or IContextMenuProvider to get rid of compile errors.
resolved fixed
0fb5099
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T07:11:15Z
2002-05-21T05:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchResultCollector.java
*/ public void accept(IResource resource, int start, int end, IJavaElement enclosingElement, int accuracy) throws CoreException { IMarker marker= resource.createMarker(SearchUI.SEARCH_MARKER); HashMap attributes; Object groupKey= enclosingElement; attributes= new HashMap(7); if (accuracy == POTENTIAL_MATCH) { fPotentialMatchCount++; attributes.put(SearchUI.POTENTIAL_MATCH, POTENTIAL_MATCH_VALUE); if (groupKey == null) groupKey= "?:null"; else groupKey= "?:" + enclosingElement.getHandleIdentifier(); } ICompilationUnit cu= SearchUtil.findCompilationUnit(enclosingElement); if (cu != null && cu.isWorkingCopy()) attributes.put(IJavaSearchUIConstants.ATT_IS_WORKING_COPY, new Boolean(true)); JavaCore.addJavaElementMarkerAttributes(attributes, enclosingElement); attributes.put(IJavaSearchUIConstants.ATT_JE_HANDLE_ID, enclosingElement.getHandleIdentifier()); attributes.put(IMarker.CHAR_START, new Integer(Math.max(start, 0))); attributes.put(IMarker.CHAR_END, new Integer(Math.max(end, 0))); if (enclosingElement instanceof IMember && ((IMember)enclosingElement).isBinary()) attributes.put(IWorkbenchPage.EDITOR_ID_ATTR, JavaUI.ID_CF_EDITOR); else attributes.put(IWorkbenchPage.EDITOR_ID_ATTR, JavaUI.ID_CU_EDITOR); marker.setAttributes(attributes); fView.addMatch(enclosingElement.getElementName(), groupKey, resource, marker); fMatchCount++; if (!getProgressMonitor().isCanceled())
16,527
Bug 16527 New API in ISearchResultView breaks old if null is used
Build 20020519 ISearchResultView.searchStarted(.....). Clients were passing a null parameter that now has to be cast to IActionGroupFactory or IContextMenuProvider to get rid of compile errors.
resolved fixed
0fb5099
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T07:11:15Z
2002-05-21T05:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchResultCollector.java
getProgressMonitor().subTask(getFormattedMatchesString(fMatchCount)); } /** * @see IJavaSearchResultCollector#done(). */ public void done() { if (!getProgressMonitor().isCanceled()) { String matchesString= getFormattedMatchesString(fMatchCount); getProgressMonitor().setTaskName(MessageFormat.format(DONE, new String[]{matchesString})); } if (fView != null) { if (fPotentialMatchCount > 0 && PotentialMatchDialog.shouldExplain()) explainPotentialMatch(fPotentialMatchCount); fView.searchFinished(); } fView= null; fMonitor= null; } private void explainPotentialMatch(final int potentialMatchCount) { final Shell shell= fView.getSite().getShell(); shell.getDisplay().syncExec(new Runnable() { public void run() { PotentialMatchDialog.open(shell, potentialMatchCount); } }); }
16,527
Bug 16527 New API in ISearchResultView breaks old if null is used
Build 20020519 ISearchResultView.searchStarted(.....). Clients were passing a null parameter that now has to be cast to IActionGroupFactory or IContextMenuProvider to get rid of compile errors.
resolved fixed
0fb5099
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T07:11:15Z
2002-05-21T05:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/JavaSearchResultCollector.java
/* * @see IJavaSearchResultCollector#getProgressMonitor(). */ public IProgressMonitor getProgressMonitor() { return fMonitor; }; void setProgressMonitor(IProgressMonitor pm) { fMonitor= pm; } void setOperation(JavaSearchOperation operation) { fOperation= operation; } private String getFormattedMatchesString(int count) { if (fMatchCount == 1) return MATCH; fMessageFormatArgs[0]= new Integer(count); return MessageFormat.format(MATCHES, fMessageFormatArgs); } private IWorkbenchWindow getWorbenchWindow() { IWorkbenchWindow wbWindow= null; if (fView != null && fView.getSite() != null) wbWindow= fView.getSite().getWorkbenchWindow(); if (wbWindow == null) wbWindow= JavaPlugin.getActiveWorkbenchWindow(); return wbWindow; } }
16,531
Bug 16531 templates: @author has incorrect icon on preference page
20020520 it has a 'java context' icon although it's a 'javadoc context' template
resolved fixed
a0f2777
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T09:31:03Z
2002-05-21T08:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/template/TemplateEngine.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.text.template; import java.util.ArrayList; import org.eclipse.jface.text.IDocument; import org.eclipse.jface.text.IRegion; import org.eclipse.jface.text.ITextViewer; import org.eclipse.jface.text.Region; import org.eclipse.jface.viewers.ITableLabelProvider; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.internal.corext.Assert; import org.eclipse.jdt.internal.corext.template.ContextType; import org.eclipse.jdt.internal.corext.template.Template; import org.eclipse.jdt.internal.corext.template.Templates; import org.eclipse.jdt.internal.corext.template.java.CompilationUnitContext; import org.eclipse.jdt.internal.corext.template.java.CompilationUnitContextType; import org.eclipse.jdt.internal.ui.text.java.IJavaCompletionProposal; import org.eclipse.jdt.internal.ui.text.link.LinkedPositionManager; public class TemplateEngine {
16,531
Bug 16531 templates: @author has incorrect icon on preference page
20020520 it has a 'java context' icon although it's a 'javadoc context' template
resolved fixed
a0f2777
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T09:31:03Z
2002-05-21T08:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/template/TemplateEngine.java
private ContextType fContextType; private ITableLabelProvider fLabelProvider= new TemplateLabelProvider(); private ArrayList fProposals= new ArrayList(); /** * Creates the template engine for a particular context type. * See <code>TemplateContext</code> for supported context types. */ public TemplateEngine(ContextType contextType) { Assert.isNotNull(contextType); fContextType= contextType; } /** * Empties the collector. * * @param viewer the text viewer * @param unit the compilation unit (may be <code>null</code>) */ public void reset() { fProposals.clear(); } /** * Returns the array of matching templates. */ public IJavaCompletionProposal[] getResults() { return (IJavaCompletionProposal[]) fProposals.toArray(new IJavaCompletionProposal[fProposals.size()]); }
16,531
Bug 16531 templates: @author has incorrect icon on preference page
20020520 it has a 'java context' icon although it's a 'javadoc context' template
resolved fixed
a0f2777
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T09:31:03Z
2002-05-21T08:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/template/TemplateEngine.java
/** * Inspects the context of the compilation unit around <code>completionPosition</code> * and feeds the collector with proposals. * @param viewer the text viewer * @param completionPosition the context position in the document of the text viewer * @param compilationUnit the compilation unit (may be <code>null</code>) */ public void complete(ITextViewer viewer, int completionPosition, ICompilationUnit compilationUnit) throws JavaModelException { IDocument document= viewer.getDocument(); if (LinkedPositionManager.hasActiveManager(document)) return; if (!(fContextType instanceof CompilationUnitContextType)) return; ((CompilationUnitContextType) fContextType).setContextParameters(document, completionPosition, compilationUnit); CompilationUnitContext context= (CompilationUnitContext) fContextType.createContext(); int start= context.getStart(); int end= context.getEnd(); IRegion region= new Region(start, end - start); Template[] templates= Templates.getInstance().getTemplates(); for (int i= 0; i != templates.length; i++) if (context.canEvaluate(templates[i])) fProposals.add(new TemplateProposal(templates[i], context, region, viewer, fLabelProvider.getColumnImage(templates[i], 0))); } }
16,531
Bug 16531 templates: @author has incorrect icon on preference page
20020520 it has a 'java context' icon although it's a 'javadoc context' template
resolved fixed
a0f2777
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T09:31:03Z
2002-05-21T08:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/template/TemplateLabelProvider.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.text.template; import org.eclipse.swt.graphics.Image; import org.eclipse.jface.viewers.ILabelProviderListener; import org.eclipse.jface.viewers.ITableLabelProvider; import org.eclipse.jdt.internal.corext.template.Template; import org.eclipse.jdt.internal.ui.JavaPluginImages; public class TemplateLabelProvider implements ITableLabelProvider {
16,531
Bug 16531 templates: @author has incorrect icon on preference page
20020520 it has a 'java context' icon although it's a 'javadoc context' template
resolved fixed
a0f2777
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T09:31:03Z
2002-05-21T08:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/template/TemplateLabelProvider.java
/* * @see ITableLabelProvider#getColumnImage(Object, int) */ public Image getColumnImage(Object element, int columnIndex) { if (columnIndex != 0) return null; Template template= (Template) element; if (template.getContextTypeName().equals("javadoc") && template.getName().startsWith("<")) return JavaPluginImages.get(JavaPluginImages.IMG_OBJS_HTMLTAG); else return JavaPluginImages.get(JavaPluginImages.IMG_OBJS_TEMPLATE); } /* * @see ITableLabelProvider#getColumnText(Object, int) */ public String getColumnText(Object element, int columnIndex) { Template template = (Template) element; switch (columnIndex) { case 0: return template.getName(); case 1:
16,531
Bug 16531 templates: @author has incorrect icon on preference page
20020520 it has a 'java context' icon although it's a 'javadoc context' template
resolved fixed
a0f2777
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T09:31:03Z
2002-05-21T08:33:20Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/text/template/TemplateLabelProvider.java
return template.getContextTypeName(); case 2: return template.getDescription(); default: return null; } } /* * @see IBaseLabelProvider#addListener(ILabelProviderListener) */ public void addListener(ILabelProviderListener listener) { } /* * @see IBaseLabelProvider#dispose() */ public void dispose() { } /* * @see IBaseLabelProvider#isLabelProperty(Object, String) */ public boolean isLabelProperty(Object element, String property) { return false; } /* * @see IBaseLabelProvider#removeListener(ILabelProviderListener) */ public void removeListener(ILabelProviderListener listener) { } }
15,906
Bug 15906 MultiTypeSelectionDialog ignores "filter" setting
If you use JavaUI.createTypeDialog to create a type selection dialog and pass in a filter string, the MultiTypeSelectionDialog ignores this filter. The problem is in the open(), it does a: setFilter("A"); //$NON-NLS-1$ And this overrides any current setting. It needs to first check if the filter has not already been set, and if not, then set "A". Thanks.
resolved fixed
d8417c3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T09:35:19Z
2002-05-13T22:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/MultiTypeSelectionDialog.java
/* * (c) Copyright IBM Corp. 2000, 2001. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.dialogs; import java.lang.reflect.InvocationTargetException; import java.util.ArrayList; import java.util.Arrays; import java.util.List; import org.eclipse.core.runtime.IProgressMonitor; import org.eclipse.swt.widgets.Shell; import org.eclipse.jface.dialogs.MessageDialog; import org.eclipse.jface.operation.IRunnableContext; import org.eclipse.jface.operation.IRunnableWithProgress; import org.eclipse.jface.util.Assert; import org.eclipse.ui.dialogs.ElementListSelectionDialog; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.core.search.IJavaSearchScope; import org.eclipse.jdt.internal.corext.util.AllTypesCache; import org.eclipse.jdt.internal.corext.util.TypeInfo; import org.eclipse.jdt.internal.ui.JavaUIMessages; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; import org.eclipse.jdt.internal.ui.util.TypeInfoLabelProvider; /** * A dialog to select a type from a list of types. The dialog allows * multiple selections. */ public class MultiTypeSelectionDialog extends ElementListSelectionDialog { private IRunnableContext fRunnableContext;
15,906
Bug 15906 MultiTypeSelectionDialog ignores "filter" setting
If you use JavaUI.createTypeDialog to create a type selection dialog and pass in a filter string, the MultiTypeSelectionDialog ignores this filter. The problem is in the open(), it does a: setFilter("A"); //$NON-NLS-1$ And this overrides any current setting. It needs to first check if the filter has not already been set, and if not, then set "A". Thanks.
resolved fixed
d8417c3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T09:35:19Z
2002-05-13T22:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/MultiTypeSelectionDialog.java
private IJavaSearchScope fScope; private int fElementKinds; /** * Constructs an instance of <code>MultiTypeSelectionDialog</code>. * @param parent the parent shell. * @param context the context. * @param elementKinds IJavaSearchConstants.CLASS, IJavaSearchConstants.INTERFACE * or IJavaSearchConstants.TYPE * @param scope the java search scope. */ public MultiTypeSelectionDialog(Shell parent, IRunnableContext context, int elementKinds, IJavaSearchScope scope) { super(parent, new TypeInfoLabelProvider(TypeInfoLabelProvider.SHOW_PACKAGE_POSTFIX)); setMultipleSelection(true); Assert.isNotNull(context); Assert.isNotNull(scope); fRunnableContext= context; fScope= scope; fElementKinds= elementKinds; } /* * @see Window#open() */ public int open() { final ArrayList typesFound= new ArrayList(); IRunnableWithProgress runnable= new IRunnableWithProgress() { public void run(IProgressMonitor monitor) throws InvocationTargetException, InterruptedException {
15,906
Bug 15906 MultiTypeSelectionDialog ignores "filter" setting
If you use JavaUI.createTypeDialog to create a type selection dialog and pass in a filter string, the MultiTypeSelectionDialog ignores this filter. The problem is in the open(), it does a: setFilter("A"); //$NON-NLS-1$ And this overrides any current setting. It needs to first check if the filter has not already been set, and if not, then set "A". Thanks.
resolved fixed
d8417c3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T09:35:19Z
2002-05-13T22:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/MultiTypeSelectionDialog.java
try { AllTypesCache.getTypes(fScope, fElementKinds, monitor, typesFound); } catch (JavaModelException e) { throw new InvocationTargetException(e); } if (monitor.isCanceled()) { throw new InterruptedException(); } } }; try { fRunnableContext.run(true, true, runnable); } catch (InvocationTargetException e) { ExceptionHandler.handle(e, JavaUIMessages.getString("MultiTypeSelectionDialog.error2Title"), JavaUIMessages.getString("MultiTypeSelectionDialog.error2Message")); } catch (InterruptedException e) { return CANCEL; } setFilter("A"); setElements(typesFound.toArray()); return super.open(); } /* * @see SelectionStatusDialog#computeResult() */ protected void computeResult() {
15,906
Bug 15906 MultiTypeSelectionDialog ignores "filter" setting
If you use JavaUI.createTypeDialog to create a type selection dialog and pass in a filter string, the MultiTypeSelectionDialog ignores this filter. The problem is in the open(), it does a: setFilter("A"); //$NON-NLS-1$ And this overrides any current setting. It needs to first check if the filter has not already been set, and if not, then set "A". Thanks.
resolved fixed
d8417c3
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T09:35:19Z
2002-05-13T22:46:40Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/dialogs/MultiTypeSelectionDialog.java
List selection= Arrays.asList(getSelectedElements()); int size= selection.size(); if (size == 0) { setResult(null); return; } List result= new ArrayList(size); if (result != null) { for (int i= 0; i < size; i++) { try { IType type= ((TypeInfo)selection.get(i)).resolveType(fScope); if (type == null) { String title= JavaUIMessages.getString("MultiTypeSelectionDialog.dialogTitle"); String message= JavaUIMessages.getString("MultiTypeSelectionDialog.dialogMessage"); MessageDialog.openError(getShell(), title, message); } else { result.add(type); } } catch (JavaModelException e) { String title= JavaUIMessages.getString("MultiTypeSelectionDialog.errorTitle"); String message= JavaUIMessages.getString("MultiTypeSelectionDialog.errorMessage"); MessageDialog.openError(getShell(), title, message); } } } setResult(result); } }
16,392
Bug 16392 Exception removing search results
build 2002-05-19 on WinXP. IBM JRE 1.3.1. I did a text search and got over 100 hits. I selected a handful of them and then chose "remove entries" from the context menu. I got error dialogs for each result I wanted to remove. Looks like the markers have been removed and the search view is trying to access attributes? I will attach the log file.
resolved fixed
1ca9446
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T09:38:18Z
2002-05-19T17:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/SearchUtil.java
/* * (c) Copyright IBM Corp. 2000, 2002. * All Rights Reserved. */ package org.eclipse.jdt.internal.ui.search; import java.util.ArrayList; import java.util.Arrays; import java.util.HashSet; import java.util.Iterator; import java.util.List; import java.util.Set; import org.eclipse.core.resources.IMarker; import org.eclipse.core.runtime.CoreException; import org.eclipse.jface.dialogs.IDialogSettings; import org.eclipse.ui.IEditorPart; import org.eclipse.ui.IWorkbench; import org.eclipse.ui.IWorkbenchPage; import org.eclipse.ui.IWorkbenchWindow; import org.eclipse.ui.IWorkingSet; import org.eclipse.ui.PlatformUI; import org.eclipse.jdt.core.ICompilationUnit; import org.eclipse.jdt.core.IJavaElement;
16,392
Bug 16392 Exception removing search results
build 2002-05-19 on WinXP. IBM JRE 1.3.1. I did a text search and got over 100 hits. I selected a handful of them and then chose "remove entries" from the context menu. I got error dialogs for each result I wanted to remove. Looks like the markers have been removed and the search view is trying to access attributes? I will attach the log file.
resolved fixed
1ca9446
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T09:38:18Z
2002-05-19T17:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/SearchUtil.java
import org.eclipse.jdt.core.IMember; import org.eclipse.jdt.core.IMethod; import org.eclipse.jdt.core.IType; import org.eclipse.jdt.core.IWorkingCopy; import org.eclipse.jdt.core.JavaCore; import org.eclipse.jdt.core.JavaModelException; import org.eclipse.jdt.ui.JavaUI; import org.eclipse.jdt.internal.corext.util.JavaModelUtil; import org.eclipse.jdt.internal.ui.JavaPlugin; import org.eclipse.jdt.internal.ui.util.ExceptionHandler; /** * This class contains some utility methods for J Search. */ public class SearchUtil extends JavaModelUtil { public static int LRU_WORKINGSET_LIST_SIZE= 3; private static LRUWorkingSetsList fgLRUWorkingSets; private static final String DIALOG_SETTINGS_KEY= "JavaElementSearchActions"; private static final String STORE_LRU_WORKING_SET_NAMES= "lastUsedWorkingSetNames"; private static IDialogSettings fgSettingsStore; public static IJavaElement getJavaElement(IMarker marker) { try { String handleId= (String)marker.getAttribute(IJavaSearchUIConstants.ATT_JE_HANDLE_ID); IJavaElement je= JavaCore.create(handleId); if (!marker.getAttribute(IJavaSearchUIConstants.ATT_IS_WORKING_COPY, false)) { if (je != null&& je.exists()) return je; else { IJavaElement fixedJe= fixCUName(marker, handleId);
16,392
Bug 16392 Exception removing search results
build 2002-05-19 on WinXP. IBM JRE 1.3.1. I did a text search and got over 100 hits. I selected a handful of them and then chose "remove entries" from the context menu. I got error dialogs for each result I wanted to remove. Looks like the markers have been removed and the search view is trying to access attributes? I will attach the log file.
resolved fixed
1ca9446
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T09:38:18Z
2002-05-19T17:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/SearchUtil.java
if (fixedJe != null) return fixedJe; else return je; } } ICompilationUnit cu= findCompilationUnit(je); if (cu == null) return null; IWorkingCopy[] workingCopies= JavaUI.getSharedWorkingCopies(); int i= 0; while (i < workingCopies.length) { if (workingCopies[i].getOriginalElement().equals(cu)) { je= findInWorkingCopy(workingCopies[i], je, true); break; } i++; } if (je != null && !je.exists()) je= cu.getElementAt(marker.getAttribute(IMarker.CHAR_START, 0)); return je; } catch (CoreException ex) { ExceptionHandler.handle(ex, SearchMessages.getString("Search.Error.createJavaElement.title"), SearchMessages.getString("Search.Error.createJavaElement.message")); return null; } } private static IJavaElement fixCUName(IMarker marker, String handle) { if (handle != null) {
16,392
Bug 16392 Exception removing search results
build 2002-05-19 on WinXP. IBM JRE 1.3.1. I did a text search and got over 100 hits. I selected a handful of them and then chose "remove entries" from the context menu. I got error dialogs for each result I wanted to remove. Looks like the markers have been removed and the search view is trying to access attributes? I will attach the log file.
resolved fixed
1ca9446
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T09:38:18Z
2002-05-19T17:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/SearchUtil.java
String resourceName= ""; if (marker.getResource() != null) resourceName= marker.getResource().getName(); if (!handleContainsWrongCU(handle, resourceName)) { handle= computeFixedHandle(handle, resourceName); IJavaElement je= JavaCore.create(handle); if (je != null && je.exists()) { try { marker.setAttribute(IJavaSearchUIConstants.ATT_JE_HANDLE_ID, handle); } catch (CoreException ex) { } finally { return je; } } } } return null; } private static boolean handleContainsWrongCU(String handle, String resourceName) { int start= handle.indexOf('{'); int end= handle.indexOf(".java"); if (start >= end) return false; String name= handle.substring(start + 1, end + 5); return name.equals(resourceName); } private static String computeFixedHandle(String handle, String resourceName) {
16,392
Bug 16392 Exception removing search results
build 2002-05-19 on WinXP. IBM JRE 1.3.1. I did a text search and got over 100 hits. I selected a handful of them and then chose "remove entries" from the context menu. I got error dialogs for each result I wanted to remove. Looks like the markers have been removed and the search view is trying to access attributes? I will attach the log file.
resolved fixed
1ca9446
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T09:38:18Z
2002-05-19T17:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/SearchUtil.java
int start= handle.indexOf('{'); int end= handle.indexOf(".java"); handle= handle.substring(0, start + 1) + resourceName + handle.substring(end + 5); return handle; } /** * Returns an array of all editors. If the identical content is presented in * more than one editor, only one of those editor parts is part of the result. * * @return an array of all editor parts. */ public static IEditorPart[] getEditors() { Set inputs= new HashSet(7); List result= new ArrayList(0); IWorkbench workbench= JavaPlugin.getDefault().getWorkbench(); IWorkbenchWindow[] windows= workbench.getWorkbenchWindows(); for (int i= 0; i < windows.length; i++) { IWorkbenchPage[] pages= windows[i].getPages(); for (int x= 0; x < pages.length; x++) { IEditorPart[] editors= pages[x].getDirtyEditors(); for (int z= 0; z < editors.length; z++) { result.add(editors[z]); } } } return (IEditorPart[])result.toArray(new IEditorPart[result.size()]); } /** * Returns the working copy of the given java element.
16,392
Bug 16392 Exception removing search results
build 2002-05-19 on WinXP. IBM JRE 1.3.1. I did a text search and got over 100 hits. I selected a handful of them and then chose "remove entries" from the context menu. I got error dialogs for each result I wanted to remove. Looks like the markers have been removed and the search view is trying to access attributes? I will attach the log file.
resolved fixed
1ca9446
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T09:38:18Z
2002-05-19T17:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/SearchUtil.java
* @param javaElement the javaElement for which the working copyshould be found * @param reconcile indicates whether the working copy must be reconcile prior to searching it * @return the working copy of the given element or <code>null</code> if none */ private static IJavaElement findInWorkingCopy(IWorkingCopy workingCopy, IJavaElement element, boolean reconcile) throws JavaModelException { if (workingCopy != null) { if (reconcile) { synchronized (workingCopy) { workingCopy.reconcile(); return SearchUtil.findInCompilationUnit((ICompilationUnit)workingCopy, element); } } else { return SearchUtil.findInCompilationUnit((ICompilationUnit)workingCopy, element); } } return null; } /** * Returns the compilation unit for the given java element. * * @param element the java element whose compilation unit is searched for * @return the compilation unit of the given java element */ static ICompilationUnit findCompilationUnit(IJavaElement element) { if (element == null) return null; if (element.getElementType() == IJavaElement.COMPILATION_UNIT) return (ICompilationUnit)element; if (element instanceof IMember)
16,392
Bug 16392 Exception removing search results
build 2002-05-19 on WinXP. IBM JRE 1.3.1. I did a text search and got over 100 hits. I selected a handful of them and then chose "remove entries" from the context menu. I got error dialogs for each result I wanted to remove. Looks like the markers have been removed and the search view is trying to access attributes? I will attach the log file.
resolved fixed
1ca9446
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T09:38:18Z
2002-05-19T17:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/SearchUtil.java
return ((IMember)element).getCompilationUnit(); return findCompilationUnit(element.getParent()); } /* * Copied from JavaModelUtil and patched to allow members which do not exist. * The only case where this is a problem is for methods which have same name and * paramters as a constructor. The constructor will win in such a situation. * * @see JavaModelUtil#findMemberInCompilationUnit(ICompilationUnit, IMember) */ public static IMember findMemberInCompilationUnit(ICompilationUnit cu, IMember member) throws JavaModelException { if (member.getElementType() == IJavaElement.TYPE) { return findTypeInCompilationUnit(cu, getTypeQualifiedName((IType)member)); } else { IType declaringType= findTypeInCompilationUnit(cu, getTypeQualifiedName(member.getDeclaringType())); if (declaringType != null) { IMember result= null; switch (member.getElementType()) { case IJavaElement.FIELD: result= declaringType.getField(member.getElementName()); break; case IJavaElement.METHOD: IMethod meth= (IMethod) member; boolean isConstructor; if (meth.exists()) isConstructor= meth.isConstructor(); else isConstructor= declaringType.getElementName().equals(meth.getElementName());
16,392
Bug 16392 Exception removing search results
build 2002-05-19 on WinXP. IBM JRE 1.3.1. I did a text search and got over 100 hits. I selected a handful of them and then chose "remove entries" from the context menu. I got error dialogs for each result I wanted to remove. Looks like the markers have been removed and the search view is trying to access attributes? I will attach the log file.
resolved fixed
1ca9446
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T09:38:18Z
2002-05-19T17:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/SearchUtil.java
result= findMethod(meth.getElementName(), meth.getParameterTypes(), isConstructor, declaringType); break; case IJavaElement.INITIALIZER: result= declaringType.getInitializer(1); break; } if (result != null && result.exists()) { return result; } } } return null; } /* * XXX: Unchanged copy from JavaModelUtil */ public static IJavaElement findInCompilationUnit(ICompilationUnit cu, IJavaElement element) throws JavaModelException { if (element instanceof IMember) return findMemberInCompilationUnit(cu, (IMember) element); int type= element.getElementType(); switch (type) { case IJavaElement.IMPORT_CONTAINER: return cu.getImportContainer(); case IJavaElement.PACKAGE_DECLARATION: return find(cu.getPackageDeclarations(), element.getElementName()); case IJavaElement.IMPORT_DECLARATION:
16,392
Bug 16392 Exception removing search results
build 2002-05-19 on WinXP. IBM JRE 1.3.1. I did a text search and got over 100 hits. I selected a handful of them and then chose "remove entries" from the context menu. I got error dialogs for each result I wanted to remove. Looks like the markers have been removed and the search view is trying to access attributes? I will attach the log file.
resolved fixed
1ca9446
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T09:38:18Z
2002-05-19T17:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/SearchUtil.java
return find(cu.getImports(), element.getElementName()); case IJavaElement.COMPILATION_UNIT: return cu; } return null; } /* * XXX: Unchanged copy from JavaModelUtil */ private static IJavaElement find(IJavaElement[] elements, String name) { if (elements == null || name == null) return null; for (int i= 0; i < elements.length; i++) { if (name.equals(elements[i].getElementName())) return elements[i]; } return null; } public static String toString(IWorkingSet[] workingSets) { Arrays.sort(workingSets, new WorkingSetComparator()); String result= ""; if (workingSets != null && workingSets.length > 0) { boolean firstFound= false; for (int i= 0; i < workingSets.length; i++) { String workingSetName= workingSets[i].getName();
16,392
Bug 16392 Exception removing search results
build 2002-05-19 on WinXP. IBM JRE 1.3.1. I did a text search and got over 100 hits. I selected a handful of them and then chose "remove entries" from the context menu. I got error dialogs for each result I wanted to remove. Looks like the markers have been removed and the search view is trying to access attributes? I will attach the log file.
resolved fixed
1ca9446
JDT
https://github.com/eclipse-jdt/eclipse.jdt.ui
eclipse-jdt/eclipse.jdt.ui
java
null
null
null
2002-05-21T09:38:18Z
2002-05-19T17:40:00Z
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/search/SearchUtil.java
if (firstFound) result= SearchMessages.getFormattedString("SearchUtil.workingSetConcatenation", new String[] {result, workingSetName}); else { result= workingSetName; firstFound= true; } } } return result; } /** * Updates the LRU list of working sets. * * @param workingSets the workings sets to be added to the LRU list */ public static void updateLRUWorkingSets(IWorkingSet[] workingSets) { if (workingSets == null || workingSets.length < 1) return; getLRUWorkingSets().add(workingSets); saveState(); } private static void saveState() { IWorkingSet[] workingSets; Iterator iter= fgLRUWorkingSets.iterator(); int i= 0; while (iter.hasNext()) { workingSets= (IWorkingSet[])iter.next(); String[] names= new String[workingSets.length];