status
stringclasses 1
value | repo_name
stringclasses 13
values | repo_url
stringclasses 13
values | issue_id
int64 1
104k
| updated_files
stringlengths 11
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 38
55
| pull_url
stringlengths 38
53
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
timestamp[ns, tz=UTC] | language
stringclasses 5
values | commit_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,910 | ["docs/reference/eql/syntax.asciidoc"] | [DOCS] EQL: Document optional fields and null value restrictions | https://github.com/elastic/elasticsearch/pull/79677 adds a new optional fields syntax to EQL. It also enforces some restrictions on when you can pass a `null` value as a join key.
This issue covers related documentation changes. | https://github.com/elastic/elasticsearch/issues/79910 | https://github.com/elastic/elasticsearch/pull/80150 | b335bb76650b6727d6cb598c358bbcf5b2fade2b | a509205f526e94da3c4c3cbdcdfbf6100baece0d | 2021-10-27T13:14:03Z | java | 2021-11-03T12:48:48Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,881 | ["qa/os/src/test/java/org/elasticsearch/packaging/test/ArchiveTests.java", "qa/os/src/test/java/org/elasticsearch/packaging/test/ConfigurationTests.java", "qa/os/src/test/java/org/elasticsearch/packaging/util/ServerUtils.java", "x-pack/plugin/security/cli/src/main/java/org/elasticsearch/xpack/security/cli/AutoConfigureNode.java"] | Security auto configuration assumes node.name == hostname | Security autoconfiguration sets
```
cluster.initial_master_nodes: ["${HOSTNAME}"]
```
But it is possible that the local node already has a `node.name` configured.
If that's the case then the node cannot bootstrap a cluster.
We should either:
1. Skip auto configuration if the node has a name
2. Respect the node's name in the initial master nodes setting.
| https://github.com/elastic/elasticsearch/issues/79881 | https://github.com/elastic/elasticsearch/pull/81007 | fbda52493cd1a0bbbf7550bf18a74202e1e59348 | d9ce0b01dd3efd3efcb2f77b0e9828be7c763f59 | 2021-10-27T02:18:12Z | java | 2021-11-30T17:54:19Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,866 | ["docs/changelog/82896.yaml", "server/src/main/java/org/elasticsearch/cluster/metadata/MetadataUpdateSettingsService.java", "server/src/test/java/org/elasticsearch/indices/cluster/ClusterStateChanges.java"] | Batch Index Settings Update Requests | Same as #79782 but for index settings. Each index setting upgrade does a reroute which can be very slow, we should have batching on these tasks to avoid queuing up lots of them and blocking CS updates for extended periods of time. | https://github.com/elastic/elasticsearch/issues/79866 | https://github.com/elastic/elasticsearch/pull/82896 | eda391a7edd99b700b5ec6ce8485667c1d6fb3ba | 4bf8aecab6169ace068bd53610d5510974832df9 | 2021-10-26T19:52:04Z | java | 2022-01-25T21:42:38Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,811 | ["x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/MachineLearningField.java", "x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/inference/TrainedModelConfig.java", "x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/action/TransportInternalInferModelAction.java", "x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/action/TransportPutTrainedModelAliasAction.java", "x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/aggs/inference/InferencePipelineAggregationBuilder.java"] | Remove use of `XPackLicenseState::isAllowedByLicense` for ML models | XPackLicenseState is meant to be an opaque view of the current license level. The `LicensedFeature` class should be used to determine whether a feature is used, so that tracking is always. However, there are a few special methods on XPackLicenseState that currently avoid feature tracking. This issue is about one of those: `isMachineLearningAllowedForOperationMode`.
We should convert the one user of this method to using a proper `LicensedFeature`. | https://github.com/elastic/elasticsearch/issues/79811 | https://github.com/elastic/elasticsearch/pull/79908 | 499f84aecaf97a709a36361fd0a09e18daa5772d | 8a8d868ad1f20905e20d166df94cce988f04b720 | 2021-10-26T13:49:23Z | java | 2021-10-28T14:07:38Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,803 | ["distribution/docker/docker-compose.yml"] | [CI] DockerYmlTestSuiteIT test {p0=/11_nodes/Test cat nodes output with full_id set} (and 1 more) failing | Similar failure mode seems to happen for `test {p0=/11_nodes/Test cat nodes output with full_id set}` as well.
**Build scan:**
https://gradle-enterprise.elastic.co/s/jqiynex57roww/tests/:distribution:docker:integTest/org.elasticsearch.docker.test.DockerYmlTestSuiteIT/test%20%7Bp0=%2F11_nodes%2FTest%20cat%20nodes%20output%20with%20full_id%20set%7D
and
https://gradle-enterprise.elastic.co/s/jqiynex57roww/tests/:distribution:docker:integTest/org.elasticsearch.docker.test.DockerYmlTestSuiteIT/test%20%7Bp0=%2F11_nodes%2FTest%20cat%20nodes%20output%20with%20full_id%20set%7D?top-execution=1
**Reproduction line:**
`./gradlew ':distribution:docker:integTest' --tests "org.elasticsearch.docker.test.DockerYmlTestSuiteIT.test {p0=/11_nodes/Test cat nodes output with full_id set}" -Dtests.seed=F21346016F4B686B -Dtests.locale=bg -Dtests.timezone=America/Asuncion -Druntime.java=16`
**Applicable branches:**
master
**Reproduces locally?:**
No
**Failure history:**
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.docker.test.DockerYmlTestSuiteIT&tests.test=test%20%7Bp0%3D/11_nodes/Test%20cat%20nodes%20output%20with%20full_id%20set%7D
and
https://gradle-enterprise.elastic.co/scans/tests?search.relativeStartTime=P7D&search.timeZoneId=Europe/Zurich&tests.container=org.elasticsearch.docker.test.DockerYmlTestSuiteIT&tests.sortField=FAILED&tests.test=test%20%7Bp0%3D/11_nodes/Test%20cat%20nodes%20output%20with%20full_id%20set%7D&tests.unstableOnly=true
**Failure excerpt:**
```
org.elasticsearch.client.ResponseException: method [DELETE], host [https://localhost:49156], URI [*,-.ds-ilm-history-*?expand_wildcards=open%2Cclosed%2Chidden], status line [HTTP/1.1 400 Bad Request]
{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"index [.ds-.logs-deprecation.elasticsearch-default-2021.10.26-000001] is the write index for data stream [.logs-deprecation.elasticsearch-default] and cannot be deleted"}],"type":"illegal_argument_exception","reason":"index [.ds-.logs-deprecation.elasticsearch-default-2021.10.26-000001] is the write index for data stream [.logs-deprecation.elasticsearch-default] and cannot be deleted"},"status":400}
at __randomizedtesting.SeedInfo.seed([F21346016F4B686B:7A4779DBC1B70593]:0)
at org.elasticsearch.client.RestClient.convertResponse(RestClient.java:329)
at org.elasticsearch.client.RestClient.performRequest(RestClient.java:295)
at org.elasticsearch.client.RestClient.performRequest(RestClient.java:269)
at org.elasticsearch.test.rest.ESRestTestCase.wipeAllIndices(ESRestTestCase.java:801)
at org.elasticsearch.test.rest.ESRestTestCase.wipeCluster(ESRestTestCase.java:636)
at org.elasticsearch.test.rest.ESRestTestCase.cleanUpCluster(ESRestTestCase.java:371)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(NativeMethodAccessorImpl.java:-2)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:567)
at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:1004)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:44)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:375)
at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:824)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:475)
at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:375)
at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:831)
at java.lang.Thread.run(Thread.java:831)
``` | https://github.com/elastic/elasticsearch/issues/79803 | https://github.com/elastic/elasticsearch/pull/85150 | 3d3eb316379729e8b2e29b8adae94e70c5e8b12e | 4958642404cd8e346c5f90fc4b6d5bee2a4cdeae | 2021-10-26T12:09:28Z | java | 2022-03-21T11:05:49Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,800 | ["build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/rest/compat/YamlRestCompatTestPlugin.java"] | [CI] Deprecated Gradle features in periodic+release-tests | **Build scan**:
https://gradle-enterprise.elastic.co/s/ndlklcfdwuiac
**Repro line**:
none
**Reproduces locally?**:
Didn't try
**Applicable branches**:
master
**Failure history**:
First failure like this in CI: https://gradle-enterprise.elastic.co/scans/failures?failures.failureClassification=all_failures&failures.failureMessage=Deprecated%20Gradle%20features%20were%20used%20in%20this%20build,%20making%20it%20incompatible%20with%20Gradle%208.0&search.relativeStartTime=P7D&search.tags=ci&search.timeZoneId=Europe/Zurich
**Failure excerpt**:
```
build complete, generating: /dev/shm/elastic+elasticsearch+master+periodic+release-tests/build/347.tar.bz2
FAILURE: Build failed with an exception.
* What went wrong:
Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0
* Try:
Run with --info or --debug option to get more log output. Run with --scan to get full insights.
* Exception is:
org.gradle.api.GradleException: Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0
at org.gradle.internal.featurelifecycle.LoggingDeprecatedFeatureHandler.featureUsed(LoggingDeprecatedFeatureHandler.java:79)
at org.gradle.internal.deprecation.DeprecationLogger.nagUserWith(DeprecationLogger.java:264)
at org.gradle.internal.deprecation.DeprecationLogger.nagUserWith(DeprecationLogger.java:236)
at org.gradle.internal.deprecation.DeprecationMessageBuilder$WithDocumentation.nagUser(DeprecationMessageBuilder.java:155)
at org.gradle.execution.DefaultWorkValidationWarningRecorder.lambda$recordValidationWarnings$1(DefaultWorkValidationWarningRecorder.java:49)
at com.google.common.collect.ImmutableList.forEach(ImmutableList.java:406)
at com.google.common.collect.RegularImmutableSortedSet.forEach(RegularImmutableSortedSet.java:86)
at org.gradle.execution.DefaultWorkValidationWarningRecorder.recordValidationWarnings(DefaultWorkValidationWarningRecorder.java:45)
at org.gradle.internal.execution.steps.ValidateStep.execute(ValidateStep.java:91)
at org.gradle.internal.execution.steps.ValidateStep.execute(ValidateStep.java:57)
at org.gradle.internal.execution.steps.CaptureStateBeforeExecutionStep.execute(CaptureStateBeforeExecutionStep.java:73)
at org.gradle.internal.execution.steps.CaptureStateBeforeExecutionStep.execute(CaptureStateBeforeExecutionStep.java:47)
at org.gradle.internal.execution.steps.SkipEmptyWorkStep.lambda$execute$2(SkipEmptyWorkStep.java:92)
at java.base/java.util.Optional.orElseGet(Optional.java:364)
at org.gradle.internal.execution.steps.SkipEmptyWorkStep.execute(SkipEmptyWorkStep.java:92)
at org.gradle.internal.execution.steps.SkipEmptyWorkStep.execute(SkipEmptyWorkStep.java:33)
at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsStartedStep.execute(MarkSnapshottingInputsStartedStep.java:38)
at org.gradle.internal.execution.steps.LoadExecutionStateStep.execute(LoadExecutionStateStep.java:43)
at org.gradle.internal.execution.steps.LoadExecutionStateStep.execute(LoadExecutionStateStep.java:31)
at org.gradle.internal.execution.steps.AssignWorkspaceStep.lambda$execute$0(AssignWorkspaceStep.java:40)
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$TaskExecution$2.withWorkspace(ExecuteActionsTaskExecuter.java:284)
at org.gradle.internal.execution.steps.AssignWorkspaceStep.execute(AssignWorkspaceStep.java:40)
at org.gradle.internal.execution.steps.AssignWorkspaceStep.execute(AssignWorkspaceStep.java:30)
at org.gradle.internal.execution.steps.IdentityCacheStep.execute(IdentityCacheStep.java:37)
at org.gradle.internal.execution.steps.IdentityCacheStep.execute(IdentityCacheStep.java:27)
at org.gradle.internal.execution.steps.IdentifyStep.execute(IdentifyStep.java:44)
at org.gradle.internal.execution.steps.IdentifyStep.execute(IdentifyStep.java:33)
at org.gradle.internal.execution.impl.DefaultExecutionEngine$1.execute(DefaultExecutionEngine.java:76)
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:185)
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:174)
at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:109)
at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:51)
at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)
at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:200)
at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:195)
at org.gradle.internal.operations.DefaultBuildOperationRunner$3.execute(DefaultBuildOperationRunner.java:75)
at org.gradle.internal.operations.DefaultBuildOperationRunner$3.execute(DefaultBuildOperationRunner.java:68)
at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:153)
at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:68)
at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:62)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.lambda$call$2(DefaultBuildOperationExecutor.java:79)
at org.gradle.internal.operations.UnmanagedBuildOperationWrapper.callWithUnmanagedSupport(UnmanagedBuildOperationWrapper.java:54)
at org.gradle.internal.operations.DefaultBuildOperationExecutor.call(DefaultBuildOperationExecutor.java:79)
at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter.execute(EventFiringTaskExecuter.java:52)
at org.gradle.execution.plan.LocalTaskNodeExecutor.execute(LocalTaskNodeExecutor.java:74)
at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:402)
at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:389)
at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:382)
at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:368)
at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.lambda$run$0(DefaultPlanExecutor.java:127)
at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.execute(DefaultPlanExecutor.java:191)
at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.executeNextNode(DefaultPlanExecutor.java:182)
at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.run(DefaultPlanExecutor.java:124)
at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:48)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:61)
at java.base/java.lang.Thread.run(Thread.java:831)
``` | https://github.com/elastic/elasticsearch/issues/79800 | https://github.com/elastic/elasticsearch/pull/79812 | d76a64a6c0e126277f763573f6b345d6511d2fbd | 8f5069df5ba083d154f05cc99c7120ba84b6c395 | 2021-10-26T11:53:10Z | java | 2021-10-27T09:31:55Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,788 | ["docs/reference/cluster/stats.asciidoc", "rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/cluster.stats/20_indexing_pressure.yml", "server/src/main/java/org/elasticsearch/action/admin/cluster/stats/ClusterStatsNodes.java", "server/src/main/java/org/elasticsearch/index/stats/IndexingPressureStats.java", "server/src/test/java/org/elasticsearch/action/admin/cluster/node/stats/NodeStatsTests.java", "server/src/test/java/org/elasticsearch/action/admin/cluster/stats/ClusterStatsNodesTests.java", "x-pack/plugin/monitoring/src/test/java/org/elasticsearch/xpack/monitoring/collector/cluster/ClusterStatsMonitoringDocTests.java"] | Aggregate indexing pressure stats in cluster stats | Today `GET _nodes/stats` returns stats about indexing pressure on each node, but it would also be useful to aggregate this info across the whole cluster and expose it in `GET _cluster/stats`. | https://github.com/elastic/elasticsearch/issues/79788 | https://github.com/elastic/elasticsearch/pull/80303 | f01871464bdfca570a5f258142583f3071bca1fb | 90e4e8ce630aecba6b1d631cad77c903f892d655 | 2021-10-26T08:41:20Z | java | 2021-12-09T12:41:08Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,782 | ["server/src/main/java/org/elasticsearch/action/admin/indices/create/CreateIndexClusterStateUpdateRequest.java", "server/src/main/java/org/elasticsearch/action/admin/indices/rollover/MetadataRolloverService.java", "server/src/main/java/org/elasticsearch/action/admin/indices/rollover/TransportRolloverAction.java", "server/src/main/java/org/elasticsearch/cluster/metadata/MetadataCreateIndexService.java", "server/src/test/java/org/elasticsearch/action/admin/indices/rollover/TransportRolloverActionTests.java"] | Batch Cluster State Updates in Datastream Rollover | When using a large number of data-streams combined with rollover schedules that could cause the rollovers to collide a significant number of slow rollover CS updates can queue up. They are mainly slow due to having to run a reroute on every index creation, but also just come with the latency associated with any CS update.
This could lead to the normal priority CS updates getting blocked for many minutes which is not ideal.
Batching the cluster state updates in the `TransportRolloverAction` would allow for an efficient batching of reroutes out of the box as well as of the cluster state updates in general speed up the functionality.
relates #77466 | https://github.com/elastic/elasticsearch/issues/79782 | https://github.com/elastic/elasticsearch/pull/79945 | 54d69182fdf316375aa3f5df6d1badf970a10851 | ce1ed43d401729e1b6fa423d8086d608c496924c | 2021-10-26T07:57:56Z | java | 2021-11-05T08:28:25Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,762 | ["docs/reference/setup/sysconfig.asciidoc", "docs/reference/setup/sysconfig/configuring.asciidoc"] | "Important System Configuration" doc page is missing a "Configuring system settings" entry | **Elasticsearch version**: 7.15 (and current)
**Plugins installed**: n/a
**JVM version**: n/a
**OS version**: n/a
**Description of the problem including expected versus actual behavior**:
The "Important System Configuration" doc page has two ways to navigate through the next 8 pages.
- Bullet point list of items, or
- Click the next page link 8 times
The bullet point list should contain 8 entries. It is missing an entry to jump to the "Configuring system settings" page.
**Steps to reproduce**:
1. Open https://www.elastic.co/guide/en/elasticsearch/reference/current/system-config.html in two browser windows.
2. In browser 1, stay on that page. Notice the bullet point list contains 7 entries in this order.
- Disable swapping
- Increase file descriptors
- Ensure sufficient virtual memory
- Ensure sufficient threads
- JVM DNS cache settings
- Temporary directory not mounted with noexec
- TCP retransmission timeout
3. In browser 2, successively click on the next page link. Notice the next 8 pages are in this order:
- Configuring system settings
- Disable swapping
- File descriptors
- Virtual memory
- Number of threads
- DNS cache settings
- JNA temporary directory not mounted with noexec
- TCP retransmission timeout
4. Compare the bullet point navigation list to the next pages. The bullet point list should have 8 entries. It is missing an entry to be able to jump to the "Configuring system settings" page.
**Provide logs (if relevant)**: n/a | https://github.com/elastic/elasticsearch/issues/79762 | https://github.com/elastic/elasticsearch/pull/79830 | b4286a217e091ceb87c62d423eddeed7b7f5b213 | ca9d8f638d28ee9b6c0cff247446ae22a3026c30 | 2021-10-25T22:00:48Z | java | 2021-10-26T16:04:58Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,719 | ["docs/changelog/86984.yaml", "server/src/main/java/org/elasticsearch/rest/action/RestActions.java", "server/src/main/java/org/elasticsearch/rest/action/search/RestSearchAction.java", "server/src/test/java/org/elasticsearch/rest/action/RestActionsTests.java", "server/src/test/java/org/elasticsearch/rest/action/search/RestSearchActionTests.java"] | Improve error message for search API query parameters that require other parameters | Some search API query parameters, such as `analyzer`, require the `q` query parameter. Similarly, the `suggest_mode` query parameter requires both the `suggest_field` and `suggest_text` query parameters.
If you attempt to use these parameters without the required parameters, Elasticsearch returns the following message:
```
request [/<index>/_search] contains unrecognized parameter: [<parameter>]
```
This suggests the parameter is invalid, which isn't true. It'd be more helpful to list the other required parameters.
Relates to #79674 and #79716. | https://github.com/elastic/elasticsearch/issues/79719 | https://github.com/elastic/elasticsearch/pull/86984 | 1fb6f43b8bcfcd95fe0ee180360bce0e7b755c9b | 2b2e32e86525f6bec3b2088f0c8defcafa085fe7 | 2021-10-25T14:17:57Z | java | 2022-05-20T18:15:48Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,718 | ["server/src/internalClusterTest/java/org/elasticsearch/snapshots/SnapshotStressTestsIT.java"] | [CI] SnapshotStressTestsIT testRandomActivities failing | Test failed because of a MasterNotDiscoveredException. Not sure if this was a random issue or worth investigating so raising the issue.
**Build scan:**
https://gradle-enterprise.elastic.co/s/6wiigan6zqcyy/tests/:server:internalClusterTest/org.elasticsearch.snapshots.SnapshotStressTestsIT/testRandomActivities
**Reproduction line:**
`./gradlew ':server:internalClusterTest' --tests "org.elasticsearch.snapshots.SnapshotStressTestsIT.testRandomActivities" -Dtests.seed=FF84BCB3D914AD7C -Dtests.locale=es-US -Dtests.timezone=America/Dawson -Druntime.java=11`
**Applicable branches:**
master
**Reproduces locally?:**
No
**Failure history:**
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.snapshots.SnapshotStressTestsIT&tests.test=testRandomActivities
**Failure excerpt:**
```
org.elasticsearch.discovery.MasterNotDiscoveredException: (No message provided)
at org.elasticsearch.action.support.master.TransportMasterNodeAction$AsyncSingleAction$2.onTimeout(TransportMasterNodeAction.java:253)
at org.elasticsearch.cluster.ClusterStateObserver$ContextPreservingListener.onTimeout(ClusterStateObserver.java:324)
at org.elasticsearch.cluster.ClusterStateObserver$ObserverClusterStateListener.onTimeout(ClusterStateObserver.java:241)
at org.elasticsearch.cluster.service.ClusterApplierService$NotifyTimeout.run(ClusterApplierService.java:621)
at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:678)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.lang.Thread.run(Thread.java:834)
``` | https://github.com/elastic/elasticsearch/issues/79718 | https://github.com/elastic/elasticsearch/pull/82020 | 555c5b4cf9e33ca3f3d052d1777a421930a3cae3 | 69b277128a8f539eba00751693ff1638814101ae | 2021-10-25T14:17:44Z | java | 2021-12-22T11:37:07Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,711 | ["docs/reference/query-dsl/wildcard-query.asciidoc"] | XContent'ified wildcard query contains undocumented parameter | The wildcard query accepts both `"wildcard"` and `"value"` as the name of the parameter holding the value to be matched. However, it prefers to use `"wildcard"` when serialising the query, despite the documentation only mentioning the `"value"` name of the parameter.
This seems to have been working like that for a good while now, I reckon updating the documentation should bring clarity.
Related to https://github.com/elastic/elasticsearch-net/issues/6033. | https://github.com/elastic/elasticsearch/issues/79711 | https://github.com/elastic/elasticsearch/pull/79722 | 90102d5d550df5310ec8915b64980d2eac845134 | 0333d89f6ef857812c441864f656a26bae0dbaea | 2021-10-25T12:35:19Z | java | 2021-10-26T16:35:11Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,680 | ["modules/reindex/src/internalClusterTest/java/org/elasticsearch/migration/FeatureMigrationIT.java", "server/src/main/java/org/elasticsearch/action/admin/cluster/migration/TransportGetFeatureUpgradeStatusAction.java"] | POST system feature migration request returns before migration is in progress | The POST request to `/_migration/system_features` returns after the migration task has been submitted, but before it actually begins. This means that an immediately subsequent call to `GET /_migration/system_features` may return `MIGRATION_NEEDED` rather than `IN_PROGRESS`. This, in fact, happens consistently in the Upgrade Assistant. We should find a way to make sure that a call to `GET /_migration/system_features` returns state relevant to the most recent POST request.
cc @sabarasaba | https://github.com/elastic/elasticsearch/issues/79680 | https://github.com/elastic/elasticsearch/pull/80572 | 2cb182fbff33f49dbfdb0fe45cae7f33df2b75c2 | c5baf47be048e25d810e3b37e10cbd2759c9af59 | 2021-10-22T17:55:52Z | java | 2021-11-10T20:23:43Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,674 | ["docs/reference/rest-api/common-parms.asciidoc", "docs/reference/search/search.asciidoc"] | lenient option in _update_by_query API doesn't work | <!--
GitHub is reserved for bug reports and feature requests; it is not the place
for general questions. If you have a question or an unconfirmed bug , please
visit the [forums](https://discuss.elastic.co/c/elasticsearch). Please also
check your OS is [supported](https://www.elastic.co/support/matrix#show_os).
If it is not, the issue is likely to be closed.
For security vulnerabilities please only send reports to [email protected].
See https://www.elastic.co/community/security for more information.
Please fill in the following details to help us reproduce the bug:
-->
**Elasticsearch version** (`bin/elasticsearch --version`): 7.8
**Plugins installed**: []
**JVM version** (`java -version`):
openjdk 11.0.11 2021-04-20
OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode, sharing)
**OS version** (`uname -a` if on a Unix-like system):
Linux 456e4fcbb16b 5.11.0-37-generic #41~20.04.2-Ubuntu SMP Fri Sep 24 09:06:38 UTC 2021 x86_64 GNU/Linux
**Description of the problem including expected versus actual behavior**:
lenient option in _update_by_query API doesn't work, an error occurred:
```
{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"request [/my_index_name/_update_by_query] contains unrecognized parameter: [lenient]"}],"type":"illegal_argument_exception","reason":"request [/my_index_name/_update_by_query] contains unrecognized parameter: [lenient]"},"status":400}
```
**Steps to reproduce**:
Just run:
```
curl -XPOST -H "Content-Type: application/json" "http://localhost:9200/index_name/_update_by_query?lenient=true&conflicts=proceed" -d '{"script": "ctx._source.remove(\"field_name\")"}'
```
Please include a *minimal* but *complete* recreation of the problem,
including (e.g.) index creation, mappings, settings, query etc. The easier
you make for us to reproduce it, the more likely that somebody will take the
time to look at it.
1.
2.
3.
**Provide logs (if relevant)**:
```
{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"request [/my_index_name/_update_by_query] contains unrecognized parameter: [lenient]"}],"type":"illegal_argument_exception","reason":"request [/my_index_name/_update_by_query] contains unrecognized parameter: [lenient]"},"status":400}
```
| https://github.com/elastic/elasticsearch/issues/79674 | https://github.com/elastic/elasticsearch/pull/79716 | ebb1d3ad57371c6fd83f5c7c7a174c62224df170 | 7940e0777ce1f167a40eab55e57b4ce36c796aa6 | 2021-10-22T10:14:08Z | java | 2021-10-25T15:58:54Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,636 | ["x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/annotations/AnnotationIndex.java", "x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/job/persistence/AnomalyDetectorsIndex.java", "x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/dataframe/DataFrameAnalyticsManager.java", "x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/job/process/autodetect/AutodetectProcessManager.java", "x-pack/plugin/ml/src/test/java/org/elasticsearch/xpack/ml/job/process/autodetect/AutodetectProcessManagerTests.java"] | [CI] UpgradeClusterClientYamlTestSuiteIT test {p0=upgraded_cluster/30_ml_jobs_crud/Test open old jobs} failing | In this failure the `.ml-state-write` alias did not exist after upgrading a 7.3.2 cluster to 7.16.0. This is a bit worrying - have we done anything recently that would mean we don't reliably set up the `.ml-state-write` alias when upgrading from a version that didn't have it?
**Build scan:**
https://gradle-enterprise.elastic.co/s/2uxstqtvl3e2c/tests/:x-pack:qa:rolling-upgrade:v7.3.2%23upgradedClusterTest/org.elasticsearch.upgrades.UpgradeClusterClientYamlTestSuiteIT/test%20%7Bp0=upgraded_cluster%2F30_ml_jobs_crud%2FTest%20open%20old%20jobs%7D
**Reproduction line:**
`./gradlew ':x-pack:qa:rolling-upgrade:v7.3.2#upgradedClusterTest' -Dtests.class="org.elasticsearch.upgrades.UpgradeClusterClientYamlTestSuiteIT" -Dtests.method="test {p0=upgraded_cluster/30_ml_jobs_crud/Test open old jobs}" -Dtests.seed=BD58859DCE7F0251 -Dtests.bwc=true -Dtests.locale=fi -Dtests.timezone=America/Guatemala -Druntime.java=8`
**Applicable branches:**
7.16
**Reproduces locally?:**
No
**Failure history:**
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.upgrades.UpgradeClusterClientYamlTestSuiteIT&tests.test=test%20%7Bp0%3Dupgraded_cluster/30_ml_jobs_crud/Test%20open%20old%20jobs%7D
**Failure excerpt:**
```
java.lang.AssertionError: Failure at [upgraded_cluster/30_ml_jobs_crud:110]: field [] doesn't have a true value
Expected: not a string equal to "false" ignoring case
but: was "false"
at __randomizedtesting.SeedInfo.seed([BD58859DCE7F0251:350CBA4760836FA9]:0)
at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:462)
at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.test(ESClientYamlSuiteTestCase.java:439)
at sun.reflect.NativeMethodAccessorImpl.invoke0(NativeMethodAccessorImpl.java:-2)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1750)
at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:938)
at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:974)
at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:988)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:49)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
at org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:48)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:817)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:468)
at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:947)
at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:832)
at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:883)
at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:894)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:41)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
at org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:54)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.AssertionError: field [] doesn't have a true value
Expected: not a string equal to "false" ignoring case
but: was "false"
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
at org.junit.Assert.assertThat(Assert.java:956)
at org.elasticsearch.test.rest.yaml.section.IsTrueAssertion.doAssert(IsTrueAssertion.java:47)
at org.elasticsearch.test.rest.yaml.section.Assertion.execute(Assertion.java:65)
at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:455)
at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.test(ESClientYamlSuiteTestCase.java:439)
at sun.reflect.NativeMethodAccessorImpl.invoke0(NativeMethodAccessorImpl.java:-2)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1750)
at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:938)
at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:974)
at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:988)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:49)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
at org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:48)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:817)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:468)
at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:947)
at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:832)
at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:883)
at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:894)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:41)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
at org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:54)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
at java.lang.Thread.run(Thread.java:748)
``` | https://github.com/elastic/elasticsearch/issues/79636 | https://github.com/elastic/elasticsearch/pull/79731 | e04911bf97b267808118210dd883cf20a4b4da92 | 17727e590c31a830186bb40551c7ae96415940c2 | 2021-10-21T15:06:34Z | java | 2021-10-26T11:22:36Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,611 | ["x-pack/qa/full-cluster-restart/build.gradle"] | [CI] CoreFullClusterRestartIT testSearchTimeSeriesMode failing | testNewReplicasTimeSeriesMode is failing too
**Build scan:**
https://gradle-enterprise.elastic.co/s/7llgym7b4xauq/tests/:x-pack:qa:full-cluster-restart:v8.0.0%23oldClusterTest/org.elasticsearch.xpack.restart.CoreFullClusterRestartIT/testSearchTimeSeriesMode
**Reproduction line:**
`./gradlew ':x-pack:qa:full-cluster-restart:v8.0.0#oldClusterTest' -Dtests.class="org.elasticsearch.xpack.restart.CoreFullClusterRestartIT" -Dtests.method="testSearchTimeSeriesMode" -Dtests.seed=69552D066F069529 -Dtests.bwc=true -Dbuild.snapshot=false -Dtests.jvm.argline="-Dbuild.snapshot=false" -Dtests.locale=en -Dtests.timezone=US/Michigan -Druntime.java=11`
**Applicable branches:**
master
**Reproduces locally?:**
Didn't try
**Failure history:**
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.xpack.restart.CoreFullClusterRestartIT&tests.test=testSearchTimeSeriesMode
**Failure excerpt:**
```
org.elasticsearch.client.ResponseException: method [PUT], host [http://127.0.0.1:41691], URI [/testsearchtimeseriesmode], status line [HTTP/1.1 400 Bad Request]
{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"unknown setting [index.routing_path] please check that any required plugins are installed, or check the breaking changes documentation for removed settings"}],"type":"illegal_argument_exception","reason":"unknown setting [index.routing_path] please check that any required plugins are installed, or check the breaking changes documentation for removed settings","suppressed":[{"type":"illegal_argument_exception","reason":"unknown setting [index.mode] did you mean [index.codec]?"}]},"status":400}
at __randomizedtesting.SeedInfo.seed([69552D066F069529:102524743FE8BCAC]:0)
at org.elasticsearch.client.RestClient.convertResponse(RestClient.java:329)
at org.elasticsearch.client.RestClient.performRequest(RestClient.java:295)
at org.elasticsearch.client.RestClient.performRequest(RestClient.java:269)
at org.elasticsearch.upgrades.FullClusterRestartIT.createTimeSeriesModeIndex(FullClusterRestartIT.java:325)
at org.elasticsearch.upgrades.FullClusterRestartIT.testSearchTimeSeriesMode(FullClusterRestartIT.java:230)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(NativeMethodAccessorImpl.java:-2)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:566)
at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:44)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:375)
at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:824)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:475)
at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:375)
at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:831)
at java.lang.Thread.run(Thread.java:834)
``` | https://github.com/elastic/elasticsearch/issues/79611 | https://github.com/elastic/elasticsearch/pull/79648 | 6cc0a41af0b8e14317ab817938d4144ec31fd005 | 35cc2014e226408d3cbbc8b6d1473de2df40f6f5 | 2021-10-21T09:52:23Z | java | 2021-10-21T21:21:02Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,606 | ["build-conventions/src/main/java/org/elasticsearch/gradle/internal/conventions/precommit/FormattingPrecommitPlugin.java"] | [CI] Building 6.8.21 didn't generate expected artifact | Generating the tar package for `6.8.21` is failing due to some mismatch
```
Execution failed for task ':distribution:bwc:maintenance:buildBwcOssTar'.
> Building 6.8.21 didn't generate expected artifact /dev/shm/elastic+elasticsearch+7.16+periodic+release-tests/distribution/bwc/maintenance/build/bwc/checkout-6.8/distribution/archives/oss-tar/build/distributions/elasticsearch-oss-6.8.21-SNAPSHOT.tar
```
https://gradle-enterprise.elastic.co/s/jdmgf5tqstlxm
https://gradle-enterprise.elastic.co/s/4ldz56g4htl5a
| https://github.com/elastic/elasticsearch/issues/79606 | https://github.com/elastic/elasticsearch/pull/79743 | f522de6b56ac472d6293ba2cac747894a7a1fadc | bf70073a456c4de0e0726e72c706583a29d70cdb | 2021-10-21T08:34:18Z | java | 2021-10-25T19:24:13Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,605 | ["docs/reference/mapping/fields/ignored-field.asciidoc"] | _ignored fields documentation incomplete | The documentation of the [`_ignored`](https://www.elastic.co/guide/en/elasticsearch/reference/master/mapping-ignored-field.html) field currently only talks about `ignored_malformed`. Since https://github.com/elastic/elasticsearch/pull/74434 this field also included `ignore_above` fields. I think we should mention this in the documentation. | https://github.com/elastic/elasticsearch/issues/79605 | https://github.com/elastic/elasticsearch/pull/79705 | 8b3a61574f24a336e44f6f38c009c18ffd90383c | f522de6b56ac472d6293ba2cac747894a7a1fadc | 2021-10-21T08:27:30Z | java | 2021-10-25T18:27:02Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,585 | ["x-pack/plugin/vector-tile/src/javaRestTest/java/org/elasticsearch/xpack/vectortile/VectorTileRestIT.java", "x-pack/plugin/vector-tile/src/main/java/org/elasticsearch/xpack/vectortile/rest/RestVectorTileAction.java"] | Features in AGGS-layer of _mvt tile should have id assigned | The AGGS-layer of the _mvt response contains features where the `id` property is `undefined`. This causes problems when clients are trying to do feature identification when reading out the tile-contents from the AGGS-layer.
Ideally, this `id` would be the bucket-key `{z}/{x}/{y}`. e.g. `12/456/1214` or `7/12/5`.
Having an unambiguous `feature.id` is important for clients to identify uniquely a feature inside a tile or across different requests/tiles.
Most client-libraries treat `Feature#id` property as "special" as well. E.g. the mapbox-gl styling language allows expressions against the feature-id (https://docs.mapbox.com/mapbox-gl-js/style-spec/expressions/#id). Developrs can then write expressions to highlight a feature in different color (e.g. after user-selection).
Adding this `id` value to features in the aggs-layer is similar to how features in the `hits`-layer have ids. Hits could be present in multiple tiles too. The feature-id allows clients to make this relationship. Similarly, the bucket-key could identify identical cells across different tile-levels (e.g. level-0 request with precisions of `5` would contain the same cells from a level-1 request with grid-precision of `4`.
cc @iverase @nreese
| https://github.com/elastic/elasticsearch/issues/79585 | https://github.com/elastic/elasticsearch/pull/79634 | d9299e0e1190a7be76a30acaeb29c2b0c41ad91e | 33f5c9a99977ed7b2d3a2408719ab8ca5c385223 | 2021-10-20T20:28:34Z | java | 2021-10-25T05:23:25Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,550 | ["server/src/main/java/org/elasticsearch/discovery/PeerFinder.java"] | [CI] CoordinatorTests.testUnresponsiveFollowerDetectedEventually failing | <!--
Please fill out the following information, and ensure you have attempted
to reproduce locally
-->
**Build scan**: https://gradle-enterprise.elastic.co/s/2za2opyqfj4zo/tests/:server:test/org.elasticsearch.cluster.coordination.CoordinatorTests/testUnresponsiveFollowerDetectedEventually?top-execution=1
**Repro line**: `./gradlew ':server:test' --tests "org.elasticsearch.cluster.coordination.CoordinatorTests.testUnresponsiveFollowerDetectedEventually" -Dtests.seed=A7A2DD10E609041A -Dtests.locale=sr-CS -Dtests.timezone=Africa/Kinshasa -Druntime.java=8`
**Reproduces locally?**:
**Applicable branches**: 7.x
**Failure history**:
<!--
Link to build stats and possible indication of when this started failing and how often it fails
<https://build-stats.elastic.co/app/kibana>
-->
**Failure excerpt**:
```
java.lang.AssertionError: node2 is not connected to removed node node0
at org.elasticsearch.cluster.coordination.AbstractCoordinatorTestCase$Cluster.stabilise(AbstractCoordinatorTestCase.java:593) |
-- | --
| | at org.elasticsearch.cluster.coordination.CoordinatorTests.testUnresponsiveFollowerDetectedEventually(CoordinatorTests.java:701)
```
| https://github.com/elastic/elasticsearch/issues/79550 | https://github.com/elastic/elasticsearch/pull/79557 | 0b1e11874f7ecd498054d0416eefdf18cc3ef1ab | b9ca75595fe0b4722f5ec4772169a406caec10f0 | 2021-10-20T08:32:08Z | java | 2021-10-20T11:02:07Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,549 | ["x-pack/plugin/ilm/qa/multi-node/src/javaRestTest/java/org/elasticsearch/xpack/slm/SnapshotLifecycleRestIT.java"] | [CI] SnapshotLifecycleRestIT.testBasicTimeBasedRetention failing | <!--
Please fill out the following information, and ensure you have attempted
to reproduce locally
-->
**Build scan**: https://gradle-enterprise.elastic.co/s/sluoev3ttfqtm/tests/:x-pack:plugin:ilm:qa:multi-node:javaRestTest/org.elasticsearch.xpack.slm.SnapshotLifecycleRestIT/testBasicTimeBasedRetention?top-execution=1
**Repro line**: `./gradlew ':x-pack:plugin:ilm:qa:multi-node:javaRestTest' --tests "org.elasticsearch.xpack.slm.SnapshotLifecycleRestIT.testBasicTimeBasedRetention" -Dtests.seed=9C07192018733E66 -Dtests.locale=nl-BE -Dtests.timezone=America/Guatemala -Druntime.java=11`
**Reproduces locally?**: didn't try
**Applicable branches**: master
**Failure history**: https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.xpack.slm.SnapshotLifecycleRestIT&tests.test=testBasicTimeBasedRetention
<!--
Link to build stats and possible indication of when this started failing and how often it fails
<https://build-stats.elastic.co/app/kibana>
-->
**Failure excerpt**:
```
AssertionError: expected snapshot to exist but it does not: {"error":{"root_cause":[{"type":"snapshot_missing_exception","reason":"[time-based-retention-repo:snap-jtopkav2rvqjzxd0eeljtw] is missing"}],"type":"snapshot_missing_exception","reason":"[time-based-retention-repo:snap-jtopkav2rvqjzxd0eeljtw] is missing"},"status":404} |
```
| https://github.com/elastic/elasticsearch/issues/79549 | https://github.com/elastic/elasticsearch/pull/81018 | 31011184408a1c3799635c902307f10a10477191 | 7a04ec68aed6d02fcf205913607c8b3f0406d67f | 2021-10-20T08:28:59Z | java | 2021-11-29T14:06:28Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,545 | ["qa/full-cluster-restart/build.gradle"] | [CI] FullClusterRestartIT testNewReplicasTimeSeriesMode failing | ```
org.elasticsearch.client.ResponseException: method [PUT], host [http://[::1]:39049], URI [/testnewreplicastimeseriesmode], status line [HTTP/1.1 400 Bad Request]
{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"unknown setting [index.routing_path] please check that any required plugins are installed, or check the breaking changes documentation for removed settings"}],"type":"illegal_argument_exception","reason":"unknown setting [index.routing_path] please check that any required plugins are installed, or check the breaking changes documentation for removed settings","suppressed":[{"type":"illegal_argument_exception","reason":"unknown setting [index.mode] did you mean [index.codec]?"}]},"status":400}
```
**Build scan:**
https://gradle-enterprise.elastic.co/s/xserxjr2waff4/tests/:qa:full-cluster-restart:v8.0.0%23oldClusterTest/org.elasticsearch.upgrades.FullClusterRestartIT/testNewReplicasTimeSeriesMode
**Reproduction line:**
`./gradlew ':qa:full-cluster-restart:v8.0.0#oldClusterTest' -Dtests.class="org.elasticsearch.upgrades.FullClusterRestartIT" -Dtests.method="testNewReplicasTimeSeriesMode" -Dtests.seed=FC07843ADED8630D -Dtests.bwc=true -Dbuild.snapshot=false -Dtests.jvm.argline="-Dbuild.snapshot=false" -Dtests.locale=be -Dtests.timezone=Africa/Libreville -Druntime.java=11`
**Applicable branches:**
master
**Reproduces locally?:**
Didn't try
**Failure history:**
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.upgrades.FullClusterRestartIT&tests.test=testNewReplicasTimeSeriesMode
**Failure excerpt:**
```
org.elasticsearch.client.ResponseException: method [PUT], host [http://[::1]:39049], URI [/testnewreplicastimeseriesmode], status line [HTTP/1.1 400 Bad Request]
{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"unknown setting [index.routing_path] please check that any required plugins are installed, or check the breaking changes documentation for removed settings"}],"type":"illegal_argument_exception","reason":"unknown setting [index.routing_path] please check that any required plugins are installed, or check the breaking changes documentation for removed settings","suppressed":[{"type":"illegal_argument_exception","reason":"unknown setting [index.mode] did you mean [index.codec]?"}]},"status":400}
at __randomizedtesting.SeedInfo.seed([FC07843ADED8630D:76A5BDA74FAB2778]:0)
at org.elasticsearch.client.RestClient.convertResponse(RestClient.java:329)
at org.elasticsearch.client.RestClient.performRequest(RestClient.java:295)
at org.elasticsearch.client.RestClient.performRequest(RestClient.java:269)
at org.elasticsearch.upgrades.FullClusterRestartIT.createTimeSeriesModeIndex(FullClusterRestartIT.java:325)
at org.elasticsearch.upgrades.FullClusterRestartIT.testNewReplicasTimeSeriesMode(FullClusterRestartIT.java:271)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(NativeMethodAccessorImpl.java:-2)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:566)
at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:44)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:375)
at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:824)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:475)
at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:375)
at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:831)
at java.lang.Thread.run(Thread.java:834)
``` | https://github.com/elastic/elasticsearch/issues/79545 | https://github.com/elastic/elasticsearch/pull/79572 | 6aa0db817cb3a4695bd32f4f011bf5faa59dbb02 | b7856b8c79e72c50febac36285f156df5f098b9d | 2021-10-20T07:59:43Z | java | 2021-10-20T16:09:24Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,518 | ["x-pack/plugin/build.gradle", "x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MachineLearning.java", "x-pack/plugin/ml/src/test/java/org/elasticsearch/xpack/ml/MachineLearningInfoTransportActionTests.java", "x-pack/plugin/ml/src/test/java/org/elasticsearch/xpack/ml/action/TransportStartDataFrameAnalyticsActionTests.java", "x-pack/plugin/ml/src/test/java/org/elasticsearch/xpack/ml/autoscaling/MlAutoscalingDeciderServiceTests.java", "x-pack/plugin/ml/src/test/java/org/elasticsearch/xpack/ml/job/JobNodeSelectorTests.java", "x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/ml/jobs_get_stats.yml"] | [CI] XPackRestIT test {p0=ml/jobs_get_stats/Test get job stats after uploading data prompting the creation of some stats} failing | **Build scan:**
https://gradle-enterprise.elastic.co/s/xhcwxk6kvhqtc/tests/:x-pack:plugin:yamlRestTestV7CompatTest/org.elasticsearch.xpack.test.rest.XPackRestIT/test%20%7Bp0=ml%2Fjobs_get_stats%2FTest%20get%20job%20stats%20after%20uploading%20data%20prompting%20the%20creation%20of%20some%20stats%7D
**Reproduction line:**
`./gradlew ':x-pack:plugin:yamlRestTestV7CompatTest' --tests "org.elasticsearch.xpack.test.rest.XPackRestIT.test {p0=ml/jobs_get_stats/Test get job stats after uploading data prompting the creation of some stats}" -Dtests.seed=EF079440456288AA -Dtests.locale=fr-CH -Dtests.timezone=Asia/Dushanbe -Druntime.java=11`
**Applicable branches:**
master
**Reproduces locally?:**
Yes
**Failure history:**
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.xpack.test.rest.XPackRestIT&tests.test=test%20%7Bp0%3Dml/jobs_get_stats/Test%20get%20job%20stats%20after%20uploading%20data%20prompting%20the%20creation%20of%20some%20stats%7D
**Failure excerpt:**
```
java.lang.AssertionError: Failure at [ml/jobs_get_stats:152]: field [jobs.0.node.attributes.ml\.max_open_jobs] is null
at __randomizedtesting.SeedInfo.seed([EF079440456288AA:6753AB9AEB9EE552]:0)
at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:463)
at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.test(ESClientYamlSuiteTestCase.java:440)
at jdk.internal.reflect.GeneratedMethodAccessor13.invoke(null:-1)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:566)
at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:44)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:375)
at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:824)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:475)
at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:375)
at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:831)
at java.lang.Thread.run(Thread.java:834)
Caused by: java.lang.AssertionError: field [jobs.0.node.attributes.ml\.max_open_jobs] is null
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertNotNull(Assert.java:712)
at org.elasticsearch.test.rest.yaml.section.MatchAssertion.doAssert(MatchAssertion.java:73)
at org.elasticsearch.test.rest.yaml.section.Assertion.execute(Assertion.java:65)
at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:456)
at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.test(ESClientYamlSuiteTestCase.java:440)
at jdk.internal.reflect.GeneratedMethodAccessor13.invoke(null:-1)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:566)
at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:44)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:375)
at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:824)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:475)
at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:375)
at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:831)
at java.lang.Thread.run(Thread.java:834)
``` | https://github.com/elastic/elasticsearch/issues/79518 | https://github.com/elastic/elasticsearch/pull/79623 | 24c659e9cec4e9c45f9c6615d29040d4bbf98b80 | 9b92926ed961f73ce95a185629c577dbca43fc14 | 2021-10-19T20:36:05Z | java | 2021-10-21T14:47:49Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,502 | ["server/src/test/java/org/elasticsearch/indices/recovery/RecoverySourceHandlerTests.java"] | [CI] RecoverySourceHandlerTests testSeqNoBasedRecoveryRecoversFromFallbackPlanAfterAFailure failing | **Build scan:**
https://gradle-enterprise.elastic.co/s/n2tkjnpwe7gri/tests/:server:test/org.elasticsearch.indices.recovery.RecoverySourceHandlerTests/testSeqNoBasedRecoveryRecoversFromFallbackPlanAfterAFailure
**Reproduction line:**
`./gradlew ':server:test' --tests "org.elasticsearch.indices.recovery.RecoverySourceHandlerTests.testSeqNoBasedRecoveryRecoversFromFallbackPlanAfterAFailure" -Dtests.seed=2ECBBD728F63B256 -Dtests.locale=ar-TN -Dtests.timezone=Pacific/Wake -Druntime.java=8`
**Applicable branches:**
7.x
**Reproduces locally?:**
Yes
**Failure history:**
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.indices.recovery.RecoverySourceHandlerTests&tests.test=testSeqNoBasedRecoveryRecoversFromFallbackPlanAfterAFailure
**Failure excerpt:**
```
java.lang.Exception: Test abandoned because suite timeout was reached.
at __randomizedtesting.SeedInfo.seed([2ECBBD728F63B256]:0)
``` | https://github.com/elastic/elasticsearch/issues/79502 | https://github.com/elastic/elasticsearch/pull/79546 | 9113ff13728d8d0cf434f8d84fe7e3852d33e9a7 | f8838aac70c72b8a98e332ff24bf858b9e924ffa | 2021-10-19T17:50:35Z | java | 2021-10-28T08:55:17Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,480 | ["docs/reference/sql/endpoints/jdbc.asciidoc"] | SQL: JDBC timeout properties are parsed in ms instead of seconds | The documentation for the [ES JDBC](https://www.elastic.co/guide/en/elasticsearch/reference/master/sql-jdbc.html) driver states that all timeout system properties (like `query.timeout`) are parsed as seconds. This is currently not the case.
E.g. the following program
```
public class Main {
public static void main(String[] args) {
Properties props = new Properties();
props.put("query.timeout", "10");
props.put("page.timeout", "20");
props.put("binary.format", "false");
try (Connection conn = DriverManager.getConnection("jdbc:es://localhost:9202/", props);
Statement stmt = conn.createStatement();
ResultSet rs = stmt.executeQuery("SELECT 1");) {
rs.next();
} catch (SQLException e) {
e.printStackTrace();
}
}
}
```
triggers a request with the body
```
{
"binary_format": false,
"columnar": false,
"field_multi_value_leniency": true,
"keep_alive": "5d",
"mode": "jdbc",
"page_timeout": "10ms",
"query": "SELECT 1",
"request_timeout": "20ms",
"time_zone": "Europe/Zurich",
"version": "7.14.0"
}
```
The same issue probably applies to the other timeout properties.
Also, the properties are treated as ms when read from the connection URL as in `jdbc:es://localhost:9202/?query.timeout=10`.
If the queryTimeout is set with `Statement.setQueryTimeout` it is interpreted in seconds as expected by the JDBC specs.
| https://github.com/elastic/elasticsearch/issues/79480 | https://github.com/elastic/elasticsearch/pull/79628 | 4a36d5cd79d9937c07951bf1de3ea74433fbeab3 | 008daa17a37839516b8dc3665d8ee892b6fb49a7 | 2021-10-19T14:47:30Z | java | 2021-10-26T11:44:15Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,454 | ["server/src/main/java/org/elasticsearch/action/admin/cluster/health/ClusterHealthRequest.java", "server/src/test/java/org/elasticsearch/action/admin/cluster/health/ClusterHealthRequestTests.java"] | `ClusterHealthRequestTests.testBwcSerialization` shouldn't be a unit test | There is a specific set of tests which deals with BWC according to the backward compatibility guarantees of ES as a product. `testBwcSerialization` manually checks the compatibility all the way back to 7.2.0. | https://github.com/elastic/elasticsearch/issues/79454 | https://github.com/elastic/elasticsearch/pull/79551 | b9ca75595fe0b4722f5ec4772169a406caec10f0 | b9fbe66ab00398789fad8cc751ffecf13fc174d9 | 2021-10-19T11:52:52Z | java | 2021-10-20T11:17:09Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,377 | ["rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/ingest/10_basic.yml"] | [CI] MixedClusterClientYamlTestSuiteIT test {p0=ingest/10_basic/Test basic pipeline crud} failing | **Build scan:**
https://gradle-enterprise.elastic.co/s/cdwbu27aigfmw/tests/:qa:mixed-cluster:v7.16.0%23mixedClusterTest/org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT/test%20%7Bp0=ingest%2F10_basic%2FTest%20basic%20pipeline%20crud%7D
**Reproduction line:**
`./gradlew ':qa:mixed-cluster:v7.16.0#mixedClusterTest' -Dtests.class="org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT" -Dtests.method="test {p0=ingest/10_basic/Test basic pipeline crud}" -Dtests.seed=5312A9E4D3792FBF -Dtests.bwc=true -Dtests.locale=es-MX -Dtests.timezone=Europe/Ulyanovsk -Druntime.java=11`
**Applicable branches:**
master
**Reproduces locally?:**
Yes
**Failure history:**
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.backwards.MixedClusterClientYamlTestSuiteIT&tests.test=test%20%7Bp0%3Dingest/10_basic/Test%20basic%20pipeline%20crud%7D
**Failure excerpt:**
```
java.lang.AssertionError: Failure at [ingest/10_basic:3]: expected [2xx] status code but api [ingest.put_pipeline] returned [500 Internal Server Error] [{"error":{"root_cause":[{"type":"e_o_f_exception","reason":null,"stack_trace":"org.elasticsearch.ElasticsearchException$1\n\tat org.elasticsearch.ElasticsearchException.guessRootCauses(ElasticsearchException.java:633)\n\tat org.elasticsearch.ElasticsearchException.generateFailureXContent(ElasticsearchException.java:561)\n\tat org.elasticsearch.rest.BytesRestResponse.build(BytesRestResponse.java:138)\n\tat org.elasticsearch.rest.BytesRestResponse.<init>(BytesRestResponse.java:99)\n\tat org.elasticsearch.rest.BytesRestResponse.<init>(BytesRestResponse.java:82)\n\tat org.elasticsearch.rest.action.RestActionListener.onFailure(RestActionListener.java:55)\n\tat org.elasticsearch.client.node.NodeClient.lambda$executeLocally$1(NodeClient.java:110)\n\tat org.elasticsearch.tasks.TaskManager$1.onFailure(TaskManager.java:178)\n\tat org.elasticsearch.action.support.master.TransportMasterNodeAction$AsyncSingleAction$1.handleException(TransportMasterNodeAction.java:209)\n\tat org.elasticsearch.transport.TransportService$4.handleException(TransportService.java:628)\n\tat org.elasticsearch.transport.TransportService$ContextRestoreResponseHandler.handleException(TransportService.java:1194)\n\tat org.elasticsearch.transport.InboundHandler.lambda$handleException$3(InboundHandler.java:313)\n\tat org.elasticsearch.common.util.concurrent.EsExecutors$DirectExecutorService.execute(EsExecutors.java:178)\n\tat org.elasticsearch.transport.InboundHandler.handleException(InboundHandler.java:311)\n\tat org.elasticsearch.transport.InboundHandler.handlerResponseError(InboundHandler.java:303)\n\tat org.elasticsearch.transport.InboundHandler.messageReceived(InboundHandler.java:124)\n\tat org.elasticsearch.transport.InboundHandler.inboundMessage(InboundHandler.java:82)\n\tat org.elasticsearch.transport.TcpTransport.inboundMessage(TcpTransport.java:685)\n\tat org.elasticsearch.transport.InboundPipeline.forwardFragments(InboundPipeline.java:132)\n\tat org.elasticsearch.transport.InboundPipeline.doHandleBytes(InboundPipeline.java:104)\n\tat org.elasticsearch.transport.InboundPipeline.handleBytes(InboundPipeline.java:69)\n\tat org.elasticsearch.transport.netty4.Netty4MessageChannelHandler.channelRead(Netty4MessageChannelHandler.java:63)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)\n\tat io.netty.handler.logging.LoggingHandler.channelRead(LoggingHandler.java:280)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)\n\tat io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)\n\tat io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)\n\tat io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)\n\tat io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:719)\n\tat io.netty.channel.nio.NioEventLoop.processSelectedKeysPlain(NioEventLoop.java:620)\n\tat io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:583)\n\tat io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:493)\n\tat io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986)\n\tat io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)\n\tat java.base/java.lang.Thread.run(Thread.java:834)\nCaused by: java.io.EOFException\n\tat org.elasticsearch.common.bytes.BytesReferenceStreamInput.moveToNextSlice(BytesReferenceStreamInput.java:195)\n\tat org.elasticsearch.common.bytes.BytesReferenceStreamInput.maybeNextSlice(BytesReferenceStreamInput.java:184)\n\tat org.elasticsearch.common.bytes.BytesReferenceStreamInput.readByte(BytesReferenceStreamInput.java:44)\n\tat org.elasticsearch.common.io.stream.FilterStreamInput.readByte(FilterStreamInput.java:30)\n\tat org.elasticsearch.common.io.stream.StreamInput.readBoolean(StreamInput.java:583)\n\tat org.elasticsearch.common.io.stream.StreamInput.readOptionalInt(StreamInput.java:200)\n\tat org.elasticsearch.action.ingest.PutPipelineRequest.<init>(PutPipelineRequest.java:51)\n\tat org.elasticsearch.transport.RequestHandlerRegistry.newRequest(RequestHandlerRegistry.java:48)\n\tat org.elasticsearch.transport.InboundHandler.handleRequest(InboundHandler.java:188)\n\tat org.elasticsearch.transport.InboundHandler.messageReceived(InboundHandler.java:100)\n\tat org.elasticsearch.transport.InboundHandler.inboundMessage(InboundHandler.java:82)\n\tat org.elasticsearch.transport.TcpTransport.inboundMessage(TcpTransport.java:700)\n\tat org.elasticsearch.transport.InboundPipeline.forwardFragments(InboundPipeline.java:132)\n\tat org.elasticsearch.transport.InboundPipeline.doHandleBytes(InboundPipeline.java:104)\n\tat org.elasticsearch.transport.InboundPipeline.handleBytes(InboundPipeline.java:69)\n\tat org.elasticsearch.transport.netty4.Netty4MessageChannelHandler.channelRead(Netty4MessageChannelHandler.java:63)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)\n\tat io.netty.handler.logging.LoggingHandler.channelRead(LoggingHandler.java:280)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)\n\tat io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)\n\tat io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)\n\tat io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)\n\tat io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:719)\n\tat io.netty.channel.nio.NioEventLoop.processSelectedKeysPlain(NioEventLoop.java:620)\n\tat io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:583)\n\tat io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:493)\n\tat io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986)\n\tat io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)\n\tat java.lang.Thread.run(Thread.java:833)\n"}],"type":"e_o_f_exception","reason":null,"stack_trace":"java.io.EOFException\n\tat org.elasticsearch.common.bytes.BytesReferenceStreamInput.moveToNextSlice(BytesReferenceStreamInput.java:195)\n\tat org.elasticsearch.common.bytes.BytesReferenceStreamInput.maybeNextSlice(BytesReferenceStreamInput.java:184)\n\tat org.elasticsearch.common.bytes.BytesReferenceStreamInput.readByte(BytesReferenceStreamInput.java:44)\n\tat org.elasticsearch.common.io.stream.FilterStreamInput.readByte(FilterStreamInput.java:30)\n\tat org.elasticsearch.common.io.stream.StreamInput.readBoolean(StreamInput.java:583)\n\tat org.elasticsearch.common.io.stream.StreamInput.readOptionalInt(StreamInput.java:200)\n\tat org.elasticsearch.action.ingest.PutPipelineRequest.<init>(PutPipelineRequest.java:51)\n\tat org.elasticsearch.transport.RequestHandlerRegistry.newRequest(RequestHandlerRegistry.java:48)\n\tat org.elasticsearch.transport.InboundHandler.handleRequest(InboundHandler.java:188)\n\tat org.elasticsearch.transport.InboundHandler.messageReceived(InboundHandler.java:100)\n\tat org.elasticsearch.transport.InboundHandler.inboundMessage(InboundHandler.java:82)\n\tat org.elasticsearch.transport.TcpTransport.inboundMessage(TcpTransport.java:700)\n\tat org.elasticsearch.transport.InboundPipeline.forwardFragments(InboundPipeline.java:132)\n\tat org.elasticsearch.transport.InboundPipeline.doHandleBytes(InboundPipeline.java:104)\n\tat org.elasticsearch.transport.InboundPipeline.handleBytes(InboundPipeline.java:69)\n\tat org.elasticsearch.transport.netty4.Netty4MessageChannelHandler.channelRead(Netty4MessageChannelHandler.java:63)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)\n\tat io.netty.handler.logging.LoggingHandler.channelRead(LoggingHandler.java:280)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)\n\tat io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)\n\tat io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)\n\tat io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)\n\tat io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:719)\n\tat io.netty.channel.nio.NioEventLoop.processSelectedKeysPlain(NioEventLoop.java:620)\n\tat io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:583)\n\tat io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:493)\n\tat io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986)\n\tat io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)\n\tat java.lang.Thread.run(Thread.java:833)\n"},"status":500}]
at __randomizedtesting.SeedInfo.seed([5312A9E4D3792FBF:DB46963E7D854247]:0)
at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:463)
at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.test(ESClientYamlSuiteTestCase.java:440)
at jdk.internal.reflect.GeneratedMethodAccessor19.invoke(null:-1)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:566)
at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:44)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:375)
at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:824)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:475)
at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:375)
at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:831)
at java.lang.Thread.run(Thread.java:834)
Caused by: java.lang.AssertionError: expected [2xx] status code but api [ingest.put_pipeline] returned [500 Internal Server Error] [{"error":{"root_cause":[{"type":"e_o_f_exception","reason":null,"stack_trace":"org.elasticsearch.ElasticsearchException$1\n\tat org.elasticsearch.ElasticsearchException.guessRootCauses(ElasticsearchException.java:633)\n\tat org.elasticsearch.ElasticsearchException.generateFailureXContent(ElasticsearchException.java:561)\n\tat org.elasticsearch.rest.BytesRestResponse.build(BytesRestResponse.java:138)\n\tat org.elasticsearch.rest.BytesRestResponse.<init>(BytesRestResponse.java:99)\n\tat org.elasticsearch.rest.BytesRestResponse.<init>(BytesRestResponse.java:82)\n\tat org.elasticsearch.rest.action.RestActionListener.onFailure(RestActionListener.java:55)\n\tat org.elasticsearch.client.node.NodeClient.lambda$executeLocally$1(NodeClient.java:110)\n\tat org.elasticsearch.tasks.TaskManager$1.onFailure(TaskManager.java:178)\n\tat org.elasticsearch.action.support.master.TransportMasterNodeAction$AsyncSingleAction$1.handleException(TransportMasterNodeAction.java:209)\n\tat org.elasticsearch.transport.TransportService$4.handleException(TransportService.java:628)\n\tat org.elasticsearch.transport.TransportService$ContextRestoreResponseHandler.handleException(TransportService.java:1194)\n\tat org.elasticsearch.transport.InboundHandler.lambda$handleException$3(InboundHandler.java:313)\n\tat org.elasticsearch.common.util.concurrent.EsExecutors$DirectExecutorService.execute(EsExecutors.java:178)\n\tat org.elasticsearch.transport.InboundHandler.handleException(InboundHandler.java:311)\n\tat org.elasticsearch.transport.InboundHandler.handlerResponseError(InboundHandler.java:303)\n\tat org.elasticsearch.transport.InboundHandler.messageReceived(InboundHandler.java:124)\n\tat org.elasticsearch.transport.InboundHandler.inboundMessage(InboundHandler.java:82)\n\tat org.elasticsearch.transport.TcpTransport.inboundMessage(TcpTransport.java:685)\n\tat org.elasticsearch.transport.InboundPipeline.forwardFragments(InboundPipeline.java:132)\n\tat org.elasticsearch.transport.InboundPipeline.doHandleBytes(InboundPipeline.java:104)\n\tat org.elasticsearch.transport.InboundPipeline.handleBytes(InboundPipeline.java:69)\n\tat org.elasticsearch.transport.netty4.Netty4MessageChannelHandler.channelRead(Netty4MessageChannelHandler.java:63)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)\n\tat io.netty.handler.logging.LoggingHandler.channelRead(LoggingHandler.java:280)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)\n\tat io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)\n\tat io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)\n\tat io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)\n\tat io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:719)\n\tat io.netty.channel.nio.NioEventLoop.processSelectedKeysPlain(NioEventLoop.java:620)\n\tat io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:583)\n\tat io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:493)\n\tat io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986)\n\tat io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)\n\tat java.base/java.lang.Thread.run(Thread.java:834)\nCaused by: java.io.EOFException\n\tat org.elasticsearch.common.bytes.BytesReferenceStreamInput.moveToNextSlice(BytesReferenceStreamInput.java:195)\n\tat org.elasticsearch.common.bytes.BytesReferenceStreamInput.maybeNextSlice(BytesReferenceStreamInput.java:184)\n\tat org.elasticsearch.common.bytes.BytesReferenceStreamInput.readByte(BytesReferenceStreamInput.java:44)\n\tat org.elasticsearch.common.io.stream.FilterStreamInput.readByte(FilterStreamInput.java:30)\n\tat org.elasticsearch.common.io.stream.StreamInput.readBoolean(StreamInput.java:583)\n\tat org.elasticsearch.common.io.stream.StreamInput.readOptionalInt(StreamInput.java:200)\n\tat org.elasticsearch.action.ingest.PutPipelineRequest.<init>(PutPipelineRequest.java:51)\n\tat org.elasticsearch.transport.RequestHandlerRegistry.newRequest(RequestHandlerRegistry.java:48)\n\tat org.elasticsearch.transport.InboundHandler.handleRequest(InboundHandler.java:188)\n\tat org.elasticsearch.transport.InboundHandler.messageReceived(InboundHandler.java:100)\n\tat org.elasticsearch.transport.InboundHandler.inboundMessage(InboundHandler.java:82)\n\tat org.elasticsearch.transport.TcpTransport.inboundMessage(TcpTransport.java:700)\n\tat org.elasticsearch.transport.InboundPipeline.forwardFragments(InboundPipeline.java:132)\n\tat org.elasticsearch.transport.InboundPipeline.doHandleBytes(InboundPipeline.java:104)\n\tat org.elasticsearch.transport.InboundPipeline.handleBytes(InboundPipeline.java:69)\n\tat org.elasticsearch.transport.netty4.Netty4MessageChannelHandler.channelRead(Netty4MessageChannelHandler.java:63)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)\n\tat io.netty.handler.logging.LoggingHandler.channelRead(LoggingHandler.java:280)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)\n\tat io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)\n\tat io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)\n\tat io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)\n\tat io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:719)\n\tat io.netty.channel.nio.NioEventLoop.processSelectedKeysPlain(NioEventLoop.java:620)\n\tat io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:583)\n\tat io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:493)\n\tat io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986)\n\tat io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)\n\tat java.lang.Thread.run(Thread.java:833)\n"}],"type":"e_o_f_exception","reason":null,"stack_trace":"java.io.EOFException\n\tat org.elasticsearch.common.bytes.BytesReferenceStreamInput.moveToNextSlice(BytesReferenceStreamInput.java:195)\n\tat org.elasticsearch.common.bytes.BytesReferenceStreamInput.maybeNextSlice(BytesReferenceStreamInput.java:184)\n\tat org.elasticsearch.common.bytes.BytesReferenceStreamInput.readByte(BytesReferenceStreamInput.java:44)\n\tat org.elasticsearch.common.io.stream.FilterStreamInput.readByte(FilterStreamInput.java:30)\n\tat org.elasticsearch.common.io.stream.StreamInput.readBoolean(StreamInput.java:583)\n\tat org.elasticsearch.common.io.stream.StreamInput.readOptionalInt(StreamInput.java:200)\n\tat org.elasticsearch.action.ingest.PutPipelineRequest.<init>(PutPipelineRequest.java:51)\n\tat org.elasticsearch.transport.RequestHandlerRegistry.newRequest(RequestHandlerRegistry.java:48)\n\tat org.elasticsearch.transport.InboundHandler.handleRequest(InboundHandler.java:188)\n\tat org.elasticsearch.transport.InboundHandler.messageReceived(InboundHandler.java:100)\n\tat org.elasticsearch.transport.InboundHandler.inboundMessage(InboundHandler.java:82)\n\tat org.elasticsearch.transport.TcpTransport.inboundMessage(TcpTransport.java:700)\n\tat org.elasticsearch.transport.InboundPipeline.forwardFragments(InboundPipeline.java:132)\n\tat org.elasticsearch.transport.InboundPipeline.doHandleBytes(InboundPipeline.java:104)\n\tat org.elasticsearch.transport.InboundPipeline.handleBytes(InboundPipeline.java:69)\n\tat org.elasticsearch.transport.netty4.Netty4MessageChannelHandler.channelRead(Netty4MessageChannelHandler.java:63)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)\n\tat io.netty.handler.logging.LoggingHandler.channelRead(LoggingHandler.java:280)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)\n\tat io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)\n\tat io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)\n\tat io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)\n\tat io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)\n\tat io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)\n\tat io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:719)\n\tat io.netty.channel.nio.NioEventLoop.processSelectedKeysPlain(NioEventLoop.java:620)\n\tat io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:583)\n\tat io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:493)\n\tat io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986)\n\tat io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)\n\tat java.lang.Thread.run(Thread.java:833)\n"},"status":500}]
at org.junit.Assert.fail(Assert.java:88)
at org.elasticsearch.test.rest.yaml.section.DoSection.execute(DoSection.java:353)
at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.executeSection(ESClientYamlSuiteTestCase.java:456)
at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.test(ESClientYamlSuiteTestCase.java:440)
at jdk.internal.reflect.GeneratedMethodAccessor19.invoke(null:-1)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:566)
at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1758)
at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:946)
at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:982)
at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:996)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:44)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:375)
at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:824)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:475)
at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:955)
at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:840)
at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:891)
at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:902)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
at org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:375)
at com.carrotsearch.randomizedtesting.ThreadLeakControl.lambda$forkTimeoutingTask$0(ThreadLeakControl.java:831)
at java.lang.Thread.run(Thread.java:834)
``` | https://github.com/elastic/elasticsearch/issues/79377 | https://github.com/elastic/elasticsearch/pull/79565 | fd68b040498d2905856c12d1ccbccc7e08ccd9d5 | 1621c8666569f03b09db60ead75a028fe4a55981 | 2021-10-18T16:57:36Z | java | 2021-10-21T11:49:24Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,354 | ["x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/SecurityContext.java", "x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/SecurityContextTests.java", "x-pack/qa/rolling-upgrade/build.gradle", "x-pack/qa/rolling-upgrade/src/test/resources/operator_users.yml", "x-pack/qa/rolling-upgrade/src/test/resources/rest-api-spec/test/mixed_cluster/130_operator_privileges.yml"] | Operator privileges do not work properly in a mixed version cluster | The operator privilege feature works by settng a special header in authenticating user's threadContext. This header is not preserved in a mixed version cluster when the request must be rerouted from a local node to a remote node of different version:
https://github.com/elastic/elasticsearch/blob/6895511df75c261963204ea754eda3adea5fe0da/x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/transport/SecurityServerTransportInterceptor.java#L104-L107
When sending request across nodes of different version, only the authentication object of the original request is preserved and other security related information is dropped. This leads to the remote node not recognising the user as an operator and in turns fails with and "unauthorized" (403) error. | https://github.com/elastic/elasticsearch/issues/79354 | https://github.com/elastic/elasticsearch/pull/79412 | 4416206403ce763e1010fe65a71ae6a74ad9bb21 | 75319f4e949a4f6778d17d95ce93aedf256ed394 | 2021-10-18T12:04:07Z | java | 2021-10-19T08:50:34Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,339 | ["server/build.gradle"] | org.elasticsearch.index.TimeSeriesModeTests fails on master | **Build scan**:
https://gradle-enterprise.elastic.co/s/3e5lelduphc6w
**Repro line**:
```
REPRODUCE WITH: ./gradlew ':server:test' --tests "org.elasticsearch.index.TimeSeriesModeTests.testRequiredRouting" \
-Dtests.seed=79B9B361136DDB62 \
-Dbuild.snapshot=false \
-Dtests.jvm.argline="-Dbuild.snapshot=false" \
-Dtests.locale=fi \
-Dtests.timezone=America/Creston \
-Druntime.java=11
REPRODUCE WITH: ./gradlew ':server:test' --tests "org.elasticsearch.index.TimeSeriesModeTests.testRequiredRouting" \
-Dtests.seed=79B9B361136DDB62 \
-Dbuild.snapshot=false \
-Dtests.jvm.argline="-Dbuild.snapshot=false" \
-Dtests.locale=fi \
-Dtests.timezone=America/Creston \
-Druntime.java=11
```
**Reproduces locally?**:
yes
**Applicable branches**:
master
**Failure history**:
5 failures in the last 3 days.
**Failure excerpt**:
```
09:30:44 org.elasticsearch.index.TimeSeriesModeTests > testRequiredRouting FAILED
09:30:44 junit.framework.AssertionFailedError: Expected exception IllegalArgumentException but no exception was thrown
09:30:44 at __randomizedtesting.SeedInfo.seed([79B9B361136DDB62:C88A62A74DF8013E]:0)
09:30:44 at org.apache.lucene.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2874)
09:30:44 at org.apache.lucene.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2860)
09:30:44 at org.elasticsearch.index.TimeSeriesModeTests.testRequiredRouting(TimeSeriesModeTests.java:73)
``` | https://github.com/elastic/elasticsearch/issues/79339 | https://github.com/elastic/elasticsearch/pull/79366 | fea9c34dd96d56e45d97f5be09b9ab8acf6d6219 | d4f698d16a46658d8b790b2c6e89abc35fba0fb5 | 2021-10-18T07:55:39Z | java | 2021-10-18T17:15:15Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,270 | ["x-pack/plugin/ml/qa/native-multi-node-tests/src/javaRestTest/java/org/elasticsearch/xpack/ml/integration/RunDataFrameAnalyticsIT.java", "x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MachineLearning.java", "x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/MlAssignmentNotifier.java", "x-pack/plugin/ml/src/test/java/org/elasticsearch/xpack/ml/MlAssignmentNotifierTests.java"] | [ML] Make the job notifications related to node assignment more user friendly | There are a number of problems with job notifications related to node assignment:
1. They contain low level printouts of the `DiscoveryNode` class, which includes low level detail that's unsuited to UI messages.
2. Assignment failure messages are usually transitory, but are warnings, so result in a yellow triangle next to the job in the UI for 24 hours afterwards.
3. Assignment failure messages are very verbose, and you can get several in quick succession before a successful assignment, which causes them to dominate the job messages tab in the UI.
A potential improvement is as follows:
1. Instead of creating notifications for assignment failures, notify on unassignment. These notifications should be at the info level rather than warning, because usually the job will get assigned to a new node very soon.
2. In both unassignment and successful assignment notifications, just include the node name, not the node ID, IP address or other low level details. The full printout of the `DiscoveryNode` class can still go in the debug log, just not in the user-facing job notification.
This would move from what we have today, which is like:
* INFO: Job assigned to node A, ID 1234567, IP 1.2.3.4
\<days later\>
* WARN: Job could not be assigned because memory requirements are stale
* WARN: Job could not be assigned because indices are not ready
* WARN: Job could not be assigned to node B because x, could not be assigned to node C because y, could not be assigned to node D because z
* INFO: Job assigned to node B, ID 7654321, IP 5.6.7.8
To something less worrying like:
* INFO: Job assigned to node A
\<days later\>
* INFO: Job unassigned from node A
* INFO: Job assigned to node B | https://github.com/elastic/elasticsearch/issues/79270 | https://github.com/elastic/elasticsearch/pull/79578 | 9b92926ed961f73ce95a185629c577dbca43fc14 | 947e3656cccf34a0ee892fdce05b840c63c06ae6 | 2021-10-15T15:26:07Z | java | 2021-10-21T15:43:32Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,207 | ["docs/changelog/85393.yaml", "x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authz/store/RoleDescriptorStore.java", "x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authz/store/CompositeRolesStoreTests.java"] | Warn when a role is skipped due to licensing limitations | When resolving a user's roles, if there are any roles that depend on DLS/FLS, and that is not permitted by the current license, we skip them.
https://github.com/elastic/elasticsearch/blob/f435488484ec844962d49371b8917c135fe6f714/x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authz/store/CompositeRolesStore.java#L188-L192
However, we do not perform any logging in this circumstance, and rely on the user discovering that their roles are missing.
We should
1. Add a `WARN` log message
2. Add a Warning header
when this occurs. | https://github.com/elastic/elasticsearch/issues/79207 | https://github.com/elastic/elasticsearch/pull/85393 | 8eb920a4212806de48bc3ca340d4a3b58fc0c258 | 83d01f49a793193e077b23162ac1dc274743c809 | 2021-10-14T23:54:02Z | java | 2022-04-01T13:17:04Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,187 | ["docs/reference/cluster/nodes-info.asciidoc", "rest-api-spec/src/main/resources/rest-api-spec/api/nodes.info.json", "rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/nodes.info/50_metrics.yml", "server/src/main/java/org/elasticsearch/action/admin/cluster/node/info/NodesInfoRequest.java", "server/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestNodesInfoAction.java"] | Support something like GET _nodes/<node_selector>/none | Sometimes one needs to get just the identity of some node and doesn't need anything else. For example, if I want to get the name of the currently elected master node I might use:
```
GET _nodes/_master
```
And then I can pick the `"name"` out of the response body. Of course, this returns _far_ more information than I need because of all the metrics, but I can pare it down by picking some arbitrary metric filter:
```
GET _nodes/_master/process
```
But this feels a bit awkward because it does not convey my intent. I don't actually care about the process metrics, so someone reading my code might be confused as to why I'm doing it.
Incidentally, it turns out that you can legally put _whatever you want_ in the metric filter, and if it doesn't match anything, you will get zero metrics (but still get the node identity information). So any of these, for example, seem to work:
```
GET _nodes/_master/none
GET _nodes/_master/foobar
GET _nodes/_master/aManWearingAParticularlyFashionableHat
```
This is probably abuse of an undocumented, accidental feature. It would be great if there was some official way to ask for just node identity information. Perhaps:
```
GET _nodes/_master/_none
``` | https://github.com/elastic/elasticsearch/issues/79187 | https://github.com/elastic/elasticsearch/pull/79223 | dbb1e49e568920239a911e5e2d8264896980555b | 5767d51c2b960d6a9fc0433f4a78a54272114c40 | 2021-10-14T19:01:19Z | java | 2021-10-15T14:57:52Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,186 | ["server/src/internalClusterTest/java/org/elasticsearch/indices/recovery/SnapshotBasedIndexRecoveryIT.java"] | [CI] SnapshotBasedIndexRecoveryIT testRecoveryIsCancelledAfterDeletingTheIndex failing | **Build scan:**
https://gradle-enterprise.elastic.co/s/alnuz22ekab5s/tests/:server:internalClusterTest/org.elasticsearch.indices.recovery.SnapshotBasedIndexRecoveryIT/testRecoveryIsCancelledAfterDeletingTheIndex
**Reproduction line:**
`./gradlew ':server:internalClusterTest' --tests "org.elasticsearch.indices.recovery.SnapshotBasedIndexRecoveryIT.testRecoveryIsCancelledAfterDeletingTheIndex" -Dtests.seed=6EC84510B53C7078 -Dtests.locale=vi-VN -Dtests.timezone=America/Indiana/Vevay -Druntime.java=11`
**Applicable branches:**
master, 7.x
**Reproduces locally?:**
Didn't try
**Failure history:**
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.indices.recovery.SnapshotBasedIndexRecoveryIT&tests.test=testRecoveryIsCancelledAfterDeletingTheIndex
**Failure excerpt:**
```
java.lang.Exception: Test abandoned because suite timeout was reached.
at __randomizedtesting.SeedInfo.seed([6EC84510B53C7078]:0)
``` | https://github.com/elastic/elasticsearch/issues/79186 | https://github.com/elastic/elasticsearch/pull/79269 | e59443f7a316db04eafb610e26938a754c583a93 | 510f54a1ffa0dec82d3b2157a807372b28b75ad8 | 2021-10-14T19:00:07Z | java | 2021-10-16T10:43:39Z |
closed | elastic/elasticsearch | https://github.com/elastic/elasticsearch | 79,128 | ["x-pack/plugin/spatial/src/main/java/org/elasticsearch/xpack/spatial/search/aggregations/GeoLineAggregator.java", "x-pack/plugin/spatial/src/yamlRestTest/resources/rest-api-spec/test/60_geo_line.yml"] | Geoline aggregator might throw an AIOOBE if parent aggregation emits empty buckets | to reproduce the issue:
create two indexes:
```
PUT /test1
{
"mappings": {
"properties": {
"location": {
"type": "geo_point"
},
"date": {
"type": "date"
},
"entity": {
"type": "keyword"
}
}
}
}
PUT /test2
{
"mappings": {
"properties": {
"location": {
"type": "geo_point"
},
"date": {
"type": "date"
},
"entity": {
"type": "keyword"
}
}
}
}
```
Insert some data:
```
POST /_bulk
{ "index" : { "_id" : "1", "_index" : "test2" } }
{ "date" : "2020-01-01T01:00:00.0Z", "entity" : "e1", "location" : { "lat" : 50.3, "lon" : 0.13 } }
{ "index" : { "_id" : "1", "_index" : "test2" } }
{ "date" : "2020-01-01T01:00:00.0Z", "entity" : "e2", "location" : { "lat" : 50.3, "lon" : 0.13 } }
```
execute the following query:
```
GET test1,test2/_search
{
"size": 0,
"aggs": {
"tracks": {
"filters": {
"filters": {
"1": {
"term": {
"entity": "e1"
}
},
"2": {
"term": {
"entity": "e2"
}
}
}
},
"aggs": {
"path": {
"geo_line": {
"point": {
"field": "location"
},
"sort": {
"field": "date"
}
}
}
}
}
}
}
```
you would see something like:
```
{
"shard" : 0,
"index" : "test1",
"node" : "oOjCv2xpQmm-rWmAo0mcZg",
"reason" : {
"type" : "array_index_out_of_bounds_exception",
"reason" : "Index 1 out of bounds for length 1"
}
}
``` | https://github.com/elastic/elasticsearch/issues/79128 | https://github.com/elastic/elasticsearch/pull/79129 | 7ad1424612c08ac148a8b8ae32b3f486559ac797 | 5474d4cdf85f057cd8243512a21fe686a1927ac9 | 2021-10-14T08:53:10Z | java | 2021-10-19T05:17:11Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 86,206 | ["modules/minimp3/register_types.cpp", "modules/vorbis/register_types.cpp"] | Some GDExtension methods are unavailable in Release builds | ### Tested versions
4.2.0-stable
4.2.1-stable
### System information
Windows 10
### Issue description
Godot release builds (aka export templates) do not provide the `ResourceImporterOggVorbis` methods `load_from_buffer()` and `load_from_file()`. There might be more (now or in the future).
In godot-rust, we noticed it because we check for method availability at startup time. Downstream issue: https://github.com/godot-rust/gdext/issues/489.
**However, this affects all bindings**, including godot-cpp. If someone tries to call the methods, it will fail for exported games. What makes this delicate is that it works in Debug mode but breaks in Release, so it can go undetected.
I think it's OK that not all methods are available, but this information should be exposed via `extension_api.json`, so that bindings can take appropriate steps, e.g. to remove the methods or warn upon their usage.
### Steps to reproduce
In a GDExtension binding, try to call either of the following methods:
- `ResourceImporterOggVorbis::load_from_buffer`
- `ResourceImporterOggVorbis::load_from_file`
### Minimal reproduction project (MRP)
N/A | https://github.com/godotengine/godot/issues/86206 | https://github.com/godotengine/godot/pull/86209 | df9be54b2fbe93fb7325049b063b0a08c76cd868 | 30e77a63214b8dec13d5f497425bcae8b3c4566f | 2023-12-15T17:39:13Z | c++ | 2023-12-16T16:50:07Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 86,174 | ["core/io/resource_format_binary.cpp", "scene/resources/resource_format_text.cpp"] | Renaming a .gd file deletes the previously linked .tscn | ### Tested versions
- Reproducible in 4.2.stable, 4.2.1.stable
- Not reproducible in 4.1.stable
### System information
Godot v4.2.1.stable - Ubuntu 22.04.3 LTS 22.04 - X11 - GLES3 (Compatibility) - NVIDIA GeForce GTX 1080 Ti (nvidia; 535.129.03) - 12th Gen Intel(R) Core(TM) i3-12100F (8 Threads)
### Issue description
Godot deletes the `.tscn` file when renaming a previously linked `.gd` file. The deleted file can't be recovered.
### Steps to reproduce
1. Create a new project.
2. Create a new scene of type Control, and save it
3. Right click the root node "Control", and select "Attach Script..."
4. Right click the root node "Control", and select "Detach Script..."
5. On the FileSystem tab right click "control.gd", and select "Rename..."
6. Move the cursor just before the dot and write "_old", the new name should be "control_old.gd"
7. Press enter
### Minimal reproduction project (MRP)
Test Project for Godot 4.2.1
You can start from step **4**.
[RenamingBugTest.zip](https://github.com/godotengine/godot/files/13677960/RenamingBugTest.zip)
| https://github.com/godotengine/godot/issues/86174 | https://github.com/godotengine/godot/pull/86177 | 9c425c592fc626c7fb48d0f73ee2b2cee45c668b | df9be54b2fbe93fb7325049b063b0a08c76cd868 | 2023-12-14T20:23:22Z | c++ | 2023-12-16T16:50:05Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 86,168 | ["editor/gui/editor_file_dialog.cpp"] | Selecting export path for exports results in a black "save" pop-up | ### Tested versions
Caused by [0d6300d269b818e6c3d3ea9cbc592480103aa6d0] Fix folder color not showing up in file dialogs
https://github.com/godotengine/godot/pull/84837
(git bisection)
### System information
Godot v4.3.dev (6faa5c6dc) - Fedora Linux 39 (Workstation Edition) - Wayland - Vulkan (Forward+) - dedicated AMD Radeon RX Vega (RADV VEGA10) () - AMD Ryzen 7 5800X 8-Core Processor (16 Threads)
### Issue description
When opening the export path, it results in a black popup.
### Steps to reproduce
1. Open export settings
2. Add an export target
3. Try to select an export path
### Minimal reproduction project (MRP)
n/a | https://github.com/godotengine/godot/issues/86168 | https://github.com/godotengine/godot/pull/86171 | c3579769d84e2c085c6633db85960b21c9b6ddc0 | f8a2a9193662b2e8c1d04d65e647399dee94f31e | 2023-12-14T19:28:59Z | c++ | 2023-12-14T20:22:46Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 86,155 | ["servers/rendering/renderer_rd/forward_clustered/render_forward_clustered.cpp", "servers/rendering/renderer_rd/forward_mobile/render_forward_mobile.cpp", "servers/rendering/renderer_rd/shaders/forward_clustered/scene_forward_clustered.glsl", "servers/rendering/renderer_rd/shaders/forward_clustered/scene_forward_clustered_inc.glsl", "servers/rendering/renderer_rd/shaders/forward_mobile/scene_forward_mobile.glsl", "servers/rendering/renderer_rd/shaders/forward_mobile/scene_forward_mobile_inc.glsl", "servers/rendering/renderer_rd/shaders/scene_forward_gi_inc.glsl", "servers/rendering/renderer_rd/shaders/scene_forward_lights_inc.glsl"] | Vulkan Forward+ shader fails to compile on Mac | ### Tested versions
Reproducible on custom build from main (4.3.dev aa5b6ed)
Unreproducible if set renderer to "Compatibility"
Unreproducible if undo ee1bf15 locally
### System information
M1 Mac 14.2 , Vulkan SDK 1.3.268.1, Vulkan Forward+ renderer
### Issue description
Vulkan validation error keeps popping up, notably
`program_source:514:427: error: 'sampler' attribute parameter is out of bounds: must be between 0 and 15` and
`VK_ERROR_INVALID_SHADER_NV: Fragment shader function could not be compiled into pipeline. See previous logged error.`
```
--- Debug adapter server started ---
--- GDScript language server started on port 6005 ---
[LSP] Connection Taken
drivers/vulkan/vulkan_context.cpp:267 - VALIDATION - Message Id Number: 0 | Message Id Name:
VK_ERROR_INITIALIZATION_FAILED: Shader library compile failed (Error code 3):
program_source:456:12: warning: unused variable 'vertex0' [-Wunused-variable]
float3 vertex0 = vertex_interp;
^
program_source:457:12: warning: unused variable 'eye_offset' [-Wunused-variable]
float3 eye_offset = float3(0.0);
^
program_source:458:12: warning: unused variable 'view' [-Wunused-variable]
float3 view = -fast::normalize(vertex_interp);
^
program_source:460:12: warning: unused variable 'backlight' [-Wunused-variable]
float3 backlight = float3(0.0);
^
program_source:461:12: warning: unused variable 'transmittance_color' [-Wunused-variable]
float4 transmittance_color = float4(0.0, 0.0, 0.0, 1.0);
^
program_source:462:11: warning: unused variable 'transmittance_depth' [-Wunused-variable]
float transmittance_depth = 0.0;
^
program_source:463:11: warning: unused variable 'transmittance_boost' [-Wunused-variable]
float transmittance_boost = 0.0;
^
program_source:466:12: warning: unused variable 'emission' [-Wunused-variable]
float3 emission = float3(0.0);
^
program_source:468:11: warning: unused variable 'rim' [-Wunused-variable]
float rim = 0.0;
^
program_source:469:11: warning: unused variable 'rim_tint' [-Wunused-variable]
float rim_tint = 0.0;
^
program_source:470:11: warning: unused variable 'clearcoat' [-Wunused-variable]
float clearcoat = 0.0;
^
program_source:471:11: warning: unused variable 'clearcoat_roughness' [-Wunused-variable]
float clearcoat_roughness = 0.0;
^
program_source:472:11: warning: unused variable 'anisotropy' [-Wunused-variable]
float anisotropy = 0.0;
^
program_source:473:12: warning: unused variable 'anisotropy_flow' [-Wunused-variable]
float2 anisotropy_flow = float2(1.0, 0.0);
^
program_source:474:11: warning: unused variable 'ao' [-Wunused-variable]
float ao = 1.0;
^
program_source:475:11: warning: unused variable 'ao_light_affect' [-Wunused-variable]
float ao_light_affect = 0.0;
^
program_source:477:12: warning: unused variable 'binormal' [-Wunused-variable]
float3 binormal = float3(0.0);
^
program_source:478:12: warning: unused variable 'tangent' [-Wunused-variable]
float3 tangent = float3(0.0);
^
program_source:479:12: warning: unused variable 'uv' [-Wunused-variable]
float2 uv = uv_interp;
^
program_source:480:12: warning: unused variable 'color' [-Wunused-variable]
float4 color = color_interp;
^
program_source:481:11: warning: unused variable 'normal_map_depth' [-Wunused-variable]
float normal_map_depth = 1.0;
^
program_source:482:12: warning: unused variable 'screen_uv' [-Wunused-variable]
float2 screen_uv = gl_FragCoord.xy * scene_data.screen_pixel_size;
^
program_source:483:11: warning: unused variable 'sss_strength' [-Wunused-variable]
float sss_strength = 0.0;
^
program_source:492:14: warning: unused variable 'read_view_matrix' [-Wunused-variable]
float4x4 read_view_matrix = scene_data.view_matrix;
^
program_source:493:12: warning: unused variable 'read_viewport_size' [-Wunused-variable]
float2 read_viewport_size = scene_data.viewport_size;
^
program_source:509:12: warning: unused variable 'specular_light' [-Wunused-variable]
float3 specular_light = float3(0.0);
^
program_source:510:12: warning: unused variable 'diffuse_light' [-Wunused-variable]
float3 diffuse_light = float3(0.0);
^
program_source:511:12: warning: unused variable 'ambient_light' [-Wunused-variable]
float3 ambient_light = float3(0.0);
^
program_source:514:427: error: 'sampler' attribute parameter is out of bounds: must be between 0 and 15
fragment void main0(main0_in in [[stage_in]], constant SceneDataBlock& scene_data_block [[buffer(10)]], const device InstanceDataBuffer& instances [[buffer(12)]], constant MaterialUniforms& material [[buffer(16)]], texture2d<float> m_texture_albedo [[texture(32)]], texture2d<float> m_texture_metallic [[texture(33)]], texture2d<float> m_texture_roughness [[texture(34)]], sampler SAMPLER_LINEAR_WITH_MIPMAPS_REPEAT [[sampler(24)]], float4 gl_FragCoord [[position]])
^
.
Objects - 1
Object[0] - VK_OBJECT_TYPE_PIPELINE_CACHE, Handle 4741973040
drivers/vulkan/vulkan_context.cpp:267 - VALIDATION - Message Id Number: 0 | Message Id Name:
VK_ERROR_INVALID_SHADER_NV: Fragment shader function could not be compiled into pipeline. See previous logged error.
Objects - 1
Object[0] - VK_OBJECT_TYPE_PIPELINE, Handle 11339407872
vkCreateGraphicsPipelines failed with error -1000012000 for shader 'SceneForwardClusteredShaderRD:0'.
servers/rendering/renderer_rd/pipeline_cache_rd.cpp:61 - Condition "pipeline.is_null()" is true. Returning: RID()
This render pipeline requires (0) bytes of push constant data, supplied: (16)
No render pipeline was set before attempting to draw.
drivers/vulkan/vulkan_context.cpp:267 - VALIDATION - Message Id Number: 0 | Message Id Name:
VK_ERROR_INITIALIZATION_FAILED: Shader library compile failed (Error code 3):
program_source:498:12: warning: unused variable 'eye_offset' [-Wunused-variable]
float3 eye_offset = float3(0.0);
^
program_source:499:12: warning: unused variable 'view' [-Wunused-variable]
float3 view = -fast::normalize(vertex_interp);
^
program_source:501:12: warning: unused variable 'backlight' [-Wunused-variable]
float3 backlight = float3(0.0);
^
program_source:502:12: warning: unused variable 'transmittance_color' [-Wunused-variable]
float4 transmittance_color = float4(0.0, 0.0, 0.0, 1.0);
^
program_source:503:11: warning: unused variable 'transmittance_depth' [-Wunused-variable]
float transmittance_depth = 0.0;
^
program_source:504:11: warning: unused variable 'transmittance_boost' [-Wunused-variable]
float transmittance_boost = 0.0;
^
program_source:509:11: warning: unused variable 'rim' [-Wunused-variable]
float rim = 0.0;
^
program_source:510:11: warning: unused variable 'rim_tint' [-Wunused-variable]
float rim_tint = 0.0;
^
program_source:511:11: warning: unused variable 'clearcoat' [-Wunused-variable]
float clearcoat = 0.0;
^
program_source:512:11: warning: unused variable 'clearcoat_roughness' [-Wunused-variable]
float clearcoat_roughness = 0.0;
^
program_source:513:11: warning: unused variable 'anisotropy' [-Wunused-variable]
float anisotropy = 0.0;
^
program_source:514:12: warning: unused variable 'anisotropy_flow' [-Wunused-variable]
float2 anisotropy_flow = float2(1.0, 0.0);
^
program_source:516:11: warning: unused variable 'ao_light_affect' [-Wunused-variable]
float ao_light_affect = 0.0;
^
program_source:518:12: warning: unused variable 'binormal' [-Wunused-variable]
float3 binormal = float3(0.0);
^
program_source:519:12: warning: unused variable 'tangent' [-Wunused-variable]
float3 tangent = float3(0.0);
^
program_source:521:12: warning: unused variable 'uv' [-Wunused-variable]
float2 uv = uv_interp;
^
program_source:522:12: warning: unused variable 'color' [-Wunused-variable]
float4 color = color_interp;
^
program_source:523:11: warning: unused variable 'normal_map_depth' [-Wunused-variable]
float normal_map_depth = 1.0;
^
program_source:524:12: warning: unused variable 'screen_uv' [-Wunused-variable]
float2 screen_uv = gl_FragCoord.xy * scene_data.screen_pixel_size;
^
program_source:525:11: warning: unused variable 'sss_strength' [-Wunused-variable]
float sss_strength = 0.0;
^
program_source:534:14: warning: unused variable 'read_view_matrix' [-Wunused-variable]
float4x4 read_view_matrix = scene_data.view_matrix;
^
program_source:535:12: warning: unused variable 'read_viewport_size' [-Wunused-variable]
float2 read_viewport_size = scene_data.viewport_size;
^
program_source:707:744: error: 'sampler' attribute parameter is out of bounds: must be between 0 and 15
fragment main0_out main0(main0_in in [[stage_in]], const device Decals& decals [[buffer(7)]], constant SceneDataBlock& scene_data_block [[buffer(10)]], constant ImplementationDataBlock& implementation_data_block [[buffer(11)]], const device InstanceDataBuffer& instances [[buffer(12)]], const device ClusterBuffer& cluster_buffer [[buffer(13)]], constant MaterialUniforms& material [[buffer(16)]], texture2d<float> decal_atlas [[texture(0)]], texture2d<float> decal_atlas_srgb [[texture(1)]], texture2d<float> m_texture_albedo [[texture(32)]], texture2d<float> m_texture_metallic [[texture(33)]], texture2d<float> m_texture_roughness [[texture(34)]], sampler decal_sampler [[sampler(13)]], sampler SAMPLER_LINEAR_WITH_MIPMAPS_REPEAT [[sampler(24)]], float4 gl_FragCoord [[position]])
^
.
Objects - 1
Object[0] - VK_OBJECT_TYPE_PIPELINE_CACHE, Handle 4741973040
drivers/vulkan/vulkan_context.cpp:267 - VALIDATION - Message Id Number: 0 | Message Id Name:
VK_ERROR_INVALID_SHADER_NV: Fragment shader function could not be compiled into pipeline. See previous logged error.
Objects - 1
Object[0] - VK_OBJECT_TYPE_PIPELINE, Handle 11380276224
vkCreateGraphicsPipelines failed with error -1000012000 for shader 'SceneForwardClusteredShaderRD:9'.
servers/rendering/renderer_rd/pipeline_cache_rd.cpp:61 - Condition "pipeline.is_null()" is true. Returning: RID()
This render pipeline requires (0) bytes of push constant data, supplied: (16)
No render pipeline was set before attempting to draw.
drivers/vulkan/vulkan_context.cpp:267 - VALIDATION - Message Id Number: 0 | Message Id Name:
VK_ERROR_INVALID_SHADER_NV: Fragment shader function could not be compiled into pipeline. See previous logged error.
Objects - 1
Object[0] - VK_OBJECT_TYPE_PIPELINE, Handle 4790395904
vkCreateGraphicsPipelines failed with error -1000012000 for shader 'SceneForwardClusteredShaderRD:0'.
servers/rendering/renderer_rd/pipeline_cache_rd.cpp:61 - Condition "pipeline.is_null()" is true. Returning: RID()
This render pipeline requires (0) bytes of push constant data, supplied: (16)
No render pipeline was set before attempting to draw.
...
```
<img width="1106" alt="image" src="https://github.com/godotengine/godot/assets/5029519/dd3e7743-e551-4490-954d-41044e038ec4">
### Steps to reproduce
1. Build Godot with `platform=osx arch=arm64 dev_build=true` and open launcher
2. Create a blank project with Forward+ and open
3. observe errors pop up
### Minimal reproduction project (MRP)
[godot_test.zip](https://github.com/godotengine/godot/files/13673668/godot_test.zip)
(it's a blank project) | https://github.com/godotengine/godot/issues/86155 | https://github.com/godotengine/godot/pull/86219 | 30e77a63214b8dec13d5f497425bcae8b3c4566f | 2d0ee20ff30461b6b10f6fdfba87511a0ebc6642 | 2023-12-14T13:13:14Z | c++ | 2023-12-16T16:50:10Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 86,108 | ["modules/gdscript/gdscript_editor.cpp"] | Drag & Drop intellisense with inferred type not working | ### Tested versions
- Reproducible in: 4.2.1 Stable
- Testing working functionality in: 4.2 Stable and 4.1 Stable
### System information
Windows 11 - Godot v4.2.1-stable - Vulkan (Forward+)
### Issue description
I have a timer as shown in the attached image. When I tried to drag the timer to the script and use the dot notation to autocomplete the in-built functions of the Timer class, I didn't get suggestions.
While in v4.1 opening the same project gave intellisense.
### Steps to reproduce
1. Create a Timer
2. Drag and drop in the gdscript editor.
3. Try to invoke the start method.
### Minimal reproduction project (MRP)
[Test DnD.zip](https://github.com/godotengine/godot/files/13658039/Test.DnD.zip)
| https://github.com/godotengine/godot/issues/86108 | https://github.com/godotengine/godot/pull/86111 | 7635530e11aa20495301f07eb7a4085fcf83c60a | aa5b6ed13e4644633baf2a8a1384c82e91c533a1 | 2023-12-13T08:17:24Z | c++ | 2023-12-13T11:21:05Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 86,080 | ["core/extension/extension_api_dump.cpp"] | --dump-extension-api-with-docs produces incorrect documentation for some data types | ### Tested versions
4.3-dev, d76c1d0e516fedc535a2e394ab780cac79203477 the first commit after 4.2
### System information
MacOS Sonoma 14.0
### Issue description
MacOS
### Steps to reproduce
Run the Godot editor with the option --dump-extension-api-with-docs
And it seems to be filling some stubs for Vector operations with the stock documentation for it
Consider Vector4i, the operator '/' instead of producing this:
```
Divides each component of the [Vector4i] by the given [float].
```
Gets this node:
```
Divides each component of the [Vector4i] by the given [int].
```
Judging from my tool, this only happens for the Vector types:
```
generated-builtin/Vector2.swift | 18 -
generated-builtin/Vector2i.swift | 15 -
generated-builtin/Vector3.swift | 30 --
generated-builtin/Vector3i.swift | 15 -
generated-builtin/Vector4.swift | 18 -
generated-builtin/Vector4i.swift | 19 -
```
### Minimal reproduction project (MRP)
No need for a project. | https://github.com/godotengine/godot/issues/86080 | https://github.com/godotengine/godot/pull/86087 | d3414d80bff9d60730025662c9e6ffc585e871dd | 45b97ca4e12288e31b9b3b32436480aaf14c2844 | 2023-12-12T15:42:25Z | c++ | 2023-12-13T09:34:00Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 86,063 | ["editor/editor_node.cpp", "scene/gui/color_picker.cpp"] | No picker mode is recorded after the next switchover | ### Tested versions
v4.2.stable.official [46dc27791]
### System information
Windows 11- Godot v4.2.stable.official [46dc27791] - Vulkan (Forward+)
### Issue description
When I switch picker mode the next time I open it should be the pick mode I selected last time but it's not
https://github.com/godotengine/godot/assets/46812028/522c8b55-14cf-4781-963f-a465a03c9432
### Steps to reproduce
Toggle a picker mode off and on again
### Minimal reproduction project (MRP)
N/A | https://github.com/godotengine/godot/issues/86063 | https://github.com/godotengine/godot/pull/86129 | 302e41c26478b72171226244ae57122581cdd880 | a5529f759c2907746e39d10d9ebf6b352a9a59e4 | 2023-12-12T07:28:12Z | c++ | 2023-12-14T20:22:39Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 86,030 | ["scene/gui/color_picker.cpp"] | The UI is not on the far right when the color selector alpha value is 255 | ### Tested versions
v4.2.stable.official [46dc27791]
### System information
Windows 11- Godot v4.2.stable.official [46dc27791] - Vulkan (Forward+)
### Issue description
### Steps to reproduce
Create a new project and select a color in modulate
### Minimal reproduction project (MRP)
N/A | https://github.com/godotengine/godot/issues/86030 | https://github.com/godotengine/godot/pull/86034 | abaf99d22d9968131d1d96eabafbf0e9f01bd8b1 | 15a03ed98e63590c85dac62405d785e1b7ca7fed | 2023-12-11T12:07:54Z | c++ | 2023-12-11T23:34:37Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,992 | ["editor/groups_editor.cpp"] | UI Icons not rendering for `Group Editor` Window | ### Tested versions
- Reproducible in: v4.2.stable.arch_linux
- Not Reproducible in: v4.1.3.stable.official [f06b6836a]
### System information
Garuda Linux (2.6.19-2)
### Issue description
A minor issue where UI Icons are not rendering on the Group Editor window, attaching a screenshot for reference:
The icons were expected for Buttons like Add, Remove, Filter, etc.
### Steps to reproduce
Select any Node and go to the `Node` panel, click `Manage Groups` and the window will open.
### Minimal reproduction project (MRP)
Minor issue, easily reproducible following the above steps. | https://github.com/godotengine/godot/issues/85992 | https://github.com/godotengine/godot/pull/86031 | 49211440248e9d8e112ff2e2433f9828add962ab | abaf99d22d9968131d1d96eabafbf0e9f01bd8b1 | 2023-12-10T09:09:24Z | c++ | 2023-12-11T23:34:12Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,983 | ["editor/editor_node.cpp"] | [GodotEditor - Mono] CSharp Script of a Scene Dependency Not Freed when Closing Scene Tab under Certain Condition | ### Tested versions
A custom build of Godot 4.2.1.rc.mono, with the following `print_error` line added to the `./modules/mono/csharp_script.cpp`
```cpp
CSharpScript::~CSharpScript() {
#ifdef DEBUG_ENABLED
MutexLock lock(CSharpLanguage::get_singleton()->script_instances_mutex);
CSharpLanguage::get_singleton()->script_list.remove(&this->script_list);
#endif
/*This line ------->*/ print_error("CSharpScript::Delete: " + get_class_name());
if (GDMonoCache::godot_api_cache_updated) {
GDMonoCache::managed_callbacks.ScriptManagerBridge_RemoveScriptBridge(this);
}
}
void CSharpScript::get_members(HashSet<StringName> *p_members) {
#if defined(TOOLS_ENABLED) || defined(DEBUG_ENABLED)
if (p_members) {
for (const StringName &member_name : exported_members_names) {
p_members->insert(member_name);
}
}
#endif
}
/*************** RESOURCE ***************/
Ref<Resource> ResourceFormatLoaderCSharpScript::load(const String &p_path, const String &p_original_path, Error *r_error, bool p_use_sub_threads, float *r_progress, CacheMode p_cache_mode) {
if (r_error) {
*r_error = ERR_FILE_CANT_OPEN;
}
// TODO ignore anything inside bin/ and obj/ in tools builds?
Ref<CSharpScript> scr;
/*This line ------->*/ print_error("CSharpScript::Create: " + p_path);
if (GDMonoCache::godot_api_cache_updated) {
GDMonoCache::managed_callbacks.ScriptManagerBridge_GetOrCreateScriptBridgeForPath(&p_path, &scr);
} else {
scr = Ref<CSharpScript>(memnew(CSharpScript));
}
```
### System information
Godot v4.2.1.rc.mono (daeb1c729) - Windows 10.0.17763 - GLES3 (Compatibility) - NVIDIA GeForce RTX 4060 Ti (NVIDIA; 31.0.15.4601) - AMD Ryzen 9 5900X 12-Core Processor (24 Threads)
### Issue description
A CSharp script, as a dependency of a scene, sometimes will not get freed when closing that scene tab, based on the testing result, this issue occurs when:
1. There is more than one scene tab, and the closing scene is not the first scene tab.
2. There is only one scene tab.
I have found this issue in the process of identifying/addressing the [.NET: Failed to unload assemblies](https://github.com/godotengine/godot/issues/78513) issue, specifically the issue that prints the following error:
```
modules/mono/glue/runtime_interop.cpp:1324 - System.ArgumentException: An item with the same key has already been added. Key: Game.WeaponAbilityData
at System.Collections.Generic.Dictionary`2.TryInsert(TKey key, TValue value, InsertionBehavior behavior)
at System.Collections.Generic.Dictionary`2.Add(TKey key, TValue value)
at Godot.Bridge.ScriptManagerBridge.ScriptTypeBiMap.Add(IntPtr scriptPtr, Type scriptType) in /root/godot/modules/mono/glue/GodotSharp/GodotSharp/Core/Bridge/ScriptManagerBridge.types.cs:line 23
at Godot.Bridge.ScriptManagerBridge.AddScriptBridge(IntPtr scriptPtr, godot_string* scriptPath) in /root/godot/modules/mono/glue/GodotSharp/GodotSharp/Core/Bridge/ScriptManagerBridge.cs:line 419
```
### Steps to reproduce
0. Add the mentioned line to the source code at the corresponding position, then compile the godot source with mono module enabled.
1. Open the included project, close any opened scene, then go to `Project/Reload Current Project`.
2. There are three behaviors this project can produce: `Expected`, `Error - MoreThanOneTab`, `Error - OnlyOneTab`
## Expected:
1. Open `scene_a.tscn`, print: `CSharpScript::Create: res://Script.cs`
2. Open `empty.tscn`
3. Close `scene_a.tscn`, print: `CSharpScript::Dtor: CSharpScript`
4. Close `empty.tscn`
Video:
https://github.com/godotengine/godot/assets/71481700/6c7f29ec-f292-4dea-ae62-cc4496720a14
## Error - MoreThanOneTab:
1. Open `empty.tscn`
2. Open `scene_a.tscn`, print: `CSharpScript::Create: res://Script.cs`
3. Close `scene_a.tscn`, nothing is printed (the script is not freed)
4. Close `empty.tscn`, print: `CSharpScript::Dtor: CSharpScript`, which is an unexpected behavior
Video:
https://github.com/godotengine/godot/assets/71481700/24ae4de6-d369-4479-8c53-398483c10403
## Error - OnlyOneTab:
1. Open `scene_a.tscn`, print: `CSharpScript::Create: res://Script.cs`
2. Close `scene_a.tscn`, nothing is printed (the script is not freed)
3. Close the `[empty]` tab, [nothing is printed (the script is not freed)](print: `CSharpScript::Dtor: CSharpScript`, which is an unexpected behavior)
Video:
https://github.com/godotengine/godot/assets/71481700/6340c65e-a2ac-4feb-85a1-ec6574be3b6f
### Minimal reproduction project (MRP)
[Issue Demo.zip](https://github.com/godotengine/godot/files/13626080/Issue.Demo.zip)
| https://github.com/godotengine/godot/issues/85983 | https://github.com/godotengine/godot/pull/86008 | a9a50938c08fc5f7410e7edfdea4bde004119362 | c3ee2b9c52b5c06ce7f0be2f12faf1985889141f | 2023-12-10T00:34:46Z | c++ | 2023-12-18T17:18:05Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,961 | ["platform/windows/display_server_windows.cpp"] | Editor rendering issue on Windows on ARM device since 4.2 | ### Tested versions
4.2.stable
### System information
Godot v4.2.stable - Windows 10.0.22621 - GLES3 (Compatibility) - D3D12 (Qualcomm(R) Adreno(TM) 685 GPU) () - Snapdragon (TM) 8cx Gen 2 @ 3.0 GHz (8 Threads)
### Issue description
well~ i have full interests in using godot engine and now i am a Chinese graduate which has more free time to learn it. but it seems that there is a bug when i use Godot 4.2 stable version - although the workspace might run well, i feel a bit confused when i **create a new project or add one node**, the places of settings will **show incorrectly** when i try to **maximize the setting window and restore it** (luckily, only show incorrectly, the settings can still run correctly).
i am using Windows 11 on ARM laptop to run Godot engine 3/4 - it can runs well in using OpenGL compatibility Pack in Microsoft Store (awesome!!! but of course, only GLES2/GLES3). but this bug **does not exist** in **Godot 4.1.3 stable version** or before (iMPORTANT...), and i have tried to restart many times, the bug didn't disappear. i will upload the main screenshot as well.
now i have rollbacked in Godot 4.1.3 stable. so i hope this bug can be solved in Godot 4.2.1 or as quickly as possible, or... i'd like to find everyone's help? (tears of joy~)
### Steps to reproduce
1. i try to create new project, or add one node.
2. i maximize the setting window.
3. i restore the setting window.
4. the places of settings show incorrectly.
### Minimal reproduction project (MRP)
it can appear when i try to create new project so there is no nessesary to upload a project.godot... maybe? | https://github.com/godotengine/godot/issues/85961 | https://github.com/godotengine/godot/pull/86001 | e551672c2d7e0b4a484a647d5bf07acf08f59766 | 49211440248e9d8e112ff2e2433f9828add962ab | 2023-12-09T14:04:41Z | c++ | 2023-12-11T23:33:49Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,945 | ["drivers/gles3/rasterizer_canvas_gles3.cpp"] | 4.2.1 - No GPUParticles2D in Compatibility Mode | ### Tested versions
Reproducible in: 4.2.1 - RC1
Not reproducible in: 4.2
### System information
Windows 11 - Godot 4.2 - Compatibility
### Issue description
When using a GPUParticles2D in Godot 4.2.1-RC1 no particles are rendered on screen
### Steps to reproduce
Create a project using 4.2.1-RC1
Set the rending mode to Compatibility.
Create a GPUParticles2D system.
No particles are rendered.
### Minimal reproduction project (MRP)
[ParticlesTest.zip](https://github.com/godotengine/godot/files/13621559/ParticlesTest.zip) | https://github.com/godotengine/godot/issues/85945 | https://github.com/godotengine/godot/pull/85972 | b94eb58d35b3dd8a9f522bc90df0db73862ef326 | a9f444bbc307004c022e85e1b31fcfbd2e73566d | 2023-12-08T22:59:38Z | c++ | 2023-12-11T10:29:03Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,875 | ["scene/2d/tile_map.cpp", "scene/2d/tile_map.h"] | TileSet's set_occlusion_layer_light_mask method doesn't work in 4.2 (worked in 4.1.1) | ### Tested versions
- First reproducible in: v4.2.dev5.official [e3e2528ba]
- Reproducible in: v4.2.stable.official [46dc27791], v4.2.dev5.official [e3e2528ba], v4.2.dev6.official [57a6813bb]
- Not reproducible in: v4.1.3.stable.official [f06b6836a], v4.2.dev1.official [0c2144da9], v4.2.dev2.official [da81ca62a], v4.2.dev3.official [013e8e3af], v4.2.dev4.official [549fcce5f]
### System information
Godot v4.2.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1080 (NVIDIA; 31.0.15.4617) - Intel(R) Core(TM) i5-8600K CPU @ 3.60GHz (6 Threads)
### Issue description
The `TileSet` `set_occlusion_layer_light_mask` method does not properly update the `TileSet`'s light mask, causing shadows to still be cast by the `TileSet` even when the light mask is changed using the method to a mask different from a given light source (or even an empty light mask). In v4.1.3.stable.official [f06b6836a] this method was working properly.
### Steps to reproduce
- Download and open the `MRPSetOcclusionLayerTileSet_4.2-stable` project folder using one of the reproducible Godot versions noted above.
- Run the project, and press the spacebar key. This will toggle the occlusion layer light mask value of the on-screen `TileMap`'s `TileSet` occlusion light mask between 0 and 1. You will see that the `TileMap` still casts shadows regardless of the new value of its `TileSets`'s occlusion layer light mask.
### Minimal reproduction project (MRP)
[MRPSetOcclusionLayerTileSetBug.zip](https://github.com/godotengine/godot/files/13592741/MRPSetOcclusionLayerTileSetBug.zip)
| https://github.com/godotengine/godot/issues/85875 | https://github.com/godotengine/godot/pull/85893 | 5c95fd59051baa04d54382a39571df767b8782d0 | b94eb58d35b3dd8a9f522bc90df0db73862ef326 | 2023-12-06T23:42:48Z | c++ | 2023-12-08T17:46:08Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,873 | ["servers/rendering/renderer_rd/storage_rd/light_storage.cpp"] | Reflection probes not working on Vulkan Mobile and Compatibility renderers in 4.2 | ### Tested versions
Reproductible in 4.2 stable
Not reproductible in 4.1.3 stable
### System information
Godot v4.2.stable - Windows 10.0.19045 - Vulkan (Mobile) - dedicated NVIDIA GeForce GTX 650 Ti (NVIDIA; 30.0.14.7444) - AMD Ryzen 5 3600 6-Core Processor (12 Threads)
### Issue description
Reflection probes simply don't work on Vulkan mobile and Compatibility renderer.
Godot 4.1.3:
Godot 4.2:
### Steps to reproduce
1. Create a sphere with a metallic material with low roughness.
2. Create some geometry to reflect off of the sphere
3. Add a reflection probe to the scene
### Minimal reproduction project (MRP)
[ReflectionProbes.zip](https://github.com/godotengine/godot/files/13592653/ReflectionProbes.zip)
| https://github.com/godotengine/godot/issues/85873 | https://github.com/godotengine/godot/pull/85635 | 6a10b9922837c2cab694d6babe074a79f714db36 | 4c3d95e02cc9e89ffc0d68690d6b8881505bcb4c | 2023-12-06T23:19:48Z | c++ | 2023-12-04T22:20:47Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,859 | ["editor/import/resource_importer_texture.cpp"] | `Missing required editor-specific import metadata for a texture ...` when checking out a new project/plugin | ### Tested versions
Godot 4.2
But the version doesn't matter.
### System information
Godot v4.2.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated AMD Radeon RX 6900 XT (Advanced Micro Devices, Inc.; 31.0.22023.1014) - AMD Ryzen 9 5900X 12-Core Processor (24 Threads)
### Issue description
When you checkout a new project or plugin (e.g. via Git, AssetLib) that uses icons where the import setting were modified, an error is spamed in the log for every icon.
Example:
- `icon.svg` with import settings modified
- `Missing required editor-specific import metadata for a texture (please reimport it using the 'Import' tab): 'res://.godot/imported/icon.svg-218a8f2b3041327d8a5756f3a245f83b.editor.meta'`
### Steps to reproduce
1. Modify an icon (e.g. the default `icon.svg`)
2. Change an import setting (e.g. `Scale With Editor Scale`)
3. Close Godot and delete the `.godot` folder (To simulate a new project, e.g. when someone is checking out the project it will not exist yet)
4. Open Godot, see that there will be an error printed to the console
_Details:_
When changing some setting the `has_editor_variant` flag is set. In this case Godot expects that there must be a file in the `.godot` folder, and prints an error when not.
Content of the `icon.svg.import`
_Note:_
The icons will work fine from my testing, e.g. `Scale With Editor Scale` works even though the error was printed. The import file is also created after the error was printed, so this is fine as well.
### Minimal reproduction project (MRP)
[Icon.zip](https://github.com/godotengine/godot/files/13589632/Icon.zip)
| https://github.com/godotengine/godot/issues/85859 | https://github.com/godotengine/godot/pull/86137 | 4e29b16166cd6cf519952936c533f77a169699dd | e63f1d44943d3cf73817b4df8b49c510a1b2bb38 | 2023-12-06T18:01:00Z | c++ | 2023-12-16T16:49:58Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,858 | ["scene/resources/animation.cpp"] | Linear keyframe interpolation not working for Control anchor offsets | ### Tested versions
- Reproducible in: v4.2.stable.official [46dc27791]
- Not reproducible in: v4.1.3.stable
### System information
Godot v4.2.stable - Windows 10.0.22621 - Vulkan (Forward+) - dedicated AMD Radeon RX 6600 (Advanced Micro Devices, Inc.; 31.0.21023.2010) - AMD Ryzen 7 5700X 8-Core Processor (16 Threads)
### Issue description
Starting with Godot 4.2, changing a Control node's anchor offsets with an AnimationPlayer node results in the offsets "snapping" to the keyframes, as if Nearest interpolation were used.
This only applies to the Linear Interpolation Mode; Cubic still works as expected.
I encountered this regression when upgrading my project from 4.1.3 to 4.2. Minimum reproduction project provided below.
### Steps to reproduce
- Create a Control node with a Custom anchor preset.
- Create an AnimationPlayer track for one or more of its anchor offsets, with the Continuous update mode and Linear interpolation.
- Add keyframes to track(s)
- Play animation (either in the editor or in-game)
### Minimal reproduction project (MRP)
[ControlResize.zip](https://github.com/godotengine/godot/files/13589517/ControlResize.zip)
| https://github.com/godotengine/godot/issues/85858 | https://github.com/godotengine/godot/pull/86046 | bbf64a5cea1d0cb02f9ae9245a9ee7711752a2c0 | 7635530e11aa20495301f07eb7a4085fcf83c60a | 2023-12-06T17:48:08Z | c++ | 2023-12-13T11:20:38Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,848 | ["modules/gdscript/editor/gdscript_translation_parser_plugin.cpp", "modules/gdscript/editor/gdscript_translation_parser_plugin.h"] | POT generation ignores subscripts | ### Tested versions
See "System information" below.
### System information
Godot v4.1.4.rc (2d3b2abcf) - Windows 10.0.19045 - Vulkan (Compatibility) - NVIDIA GeForce GTX 970 (NVIDIA; 31.0.15.2698) - Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 Threads)
### Issue description
POT generation ignores tr() expression in dictionaries:
```python
var strDeclarer = { 'N':tr("North"), 'E':tr("East"), 'S':tr("South"), 'W':tr("West") }[declarer]
var strVulnerable = { 0:tr("none"), 1:tr("both"), 2:tr("NS"), 3:tr("EW") }[vulnerable]
```
Strings as tr() parameters do not show up in the POT file.
### Steps to reproduce
FYI: [Creating the PO template - Automatic generation using the editor](https://docs.godotengine.org/en/stable/tutorials/i18n/localization_using_gettext.html#automatic-generation-using-the-editor)
### Minimal reproduction project (MRP)
N/A | https://github.com/godotengine/godot/issues/85848 | https://github.com/godotengine/godot/pull/86091 | 26834d298de76add5cb9fa3163d84c8f85b5878c | fc082dd7350c87e96b7d435a4c0aaee2ba4658dd | 2023-12-06T15:09:21Z | c++ | 2023-12-19T19:33:09Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,814 | ["editor/export/editor_export_platform.cpp", "editor/export/editor_export_platform_pc.cpp", "editor/export/project_export.cpp", "platform/android/export/export_plugin.cpp", "platform/ios/export/export_plugin.cpp", "platform/linuxbsd/export/export_plugin.cpp", "platform/macos/export/export_plugin.cpp", "platform/web/export/export_plugin.cpp", "platform/windows/export/export_plugin.cpp"] | Export to web fails with "Attempting to make child window exclusive" error | ### Tested versions
Godot Engine v4.2.stable.official.46dc27791
### System information
Windows 10
### Issue description
When exporting to web, Godot fails with this error in the console:
> scene/main/window.cpp:884 - Attempting to make child window exclusive, but the parent window already has another exclusive child. This window: /root/@<!-- -->EditorNode@<!-- -->17120/@<!-- -->Panel@<!-- -->13/@<!-- -->ProjectExportDialog@<!-- -->559/@<!-- -->VBoxContainer@<!-- -->137/@<!-- -->AcceptDialog@<!-- -->411, parent window: /root/@<!-- -->EditorNode@<!-- -->17120/@<!-- -->Panel@<!-- -->13/@<!-- -->ProjectExportDialog@<!-- -->559, current exclusive child window: /root/@<!-- -->EditorNode@<!-- -->17120/@<!-- -->Panel@<!-- -->13/@<!-- -->ProjectExportDialog@<!-- -->559/@<!-- -->ProgressDialog@<!-- -->17444
This happens for newly created empty projects.
### Steps to reproduce
1. Open the attached project (or create a new project).
2. Project->Export->Export All
3. Observe the console error. No output files are generated.
### Minimal reproduction project (MRP)
[export_test.zip](https://github.com/godotengine/godot/files/13574810/export_test.zip)
| https://github.com/godotengine/godot/issues/85814 | https://github.com/godotengine/godot/pull/85845 | 74b6fad3c8a884b6c628365b6bddcb0b739a1e51 | 26ba7068319e7786aa054162e515461aacab7ef8 | 2023-12-06T01:34:11Z | c++ | 2023-12-08T15:59:04Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,804 | ["main/main.cpp"] | AMD R5 M330 graphic issues | ### Tested versions
- Reproducible: all godot 4 versions - Godot_v4.2-stable_win64 (last version I tested)
- Not reproducible: before godot 4 versions - I'm currently working on Godot_v3.5.3-stable_win64, and there is no issue
### System information
Godot v4.2.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated AMD Radeon (TM) R5 M330 () - AMD A8-7410 APU with AMD Radeon R5 Graphics (4 Threads)
### Issue description
The bug appears as soon as I start godot, all the interface is not properly shown, when I move over any option on the interface with the mouse the interface start to blink and the options are not shown, and I've already tested other godot 4 versions and the problem persist, only on the godot 3 versions the problem is not happening.
### Steps to reproduce
There are not steps, the problem can be noticed on the interface where we create a new project or select an exiting one, any clickeable option triggers this problem.
### Minimal reproduction project (MRP)
https://youtu.be/VTGknO_ML-o
_Production edit: updated the system info_ | https://github.com/godotengine/godot/issues/85804 | https://github.com/godotengine/godot/pull/85273 | 5352490cc98735652fd881db0632d156dc05ee45 | 748113280f3ec6e16a449c667a2d87f563d9b668 | 2023-12-05T20:09:33Z | c++ | 2023-12-12T09:39:52Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,766 | ["scene/2d/tile_map.cpp", "scene/2d/tile_map.h"] | TileMaps do not remove their tile occluders when the tile changes. | ### Tested versions
Reproducible in 4.2-stable
### System information
Godot v4.2.stable (46dc27791) - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1660 Ti (NVIDIA; 31.0.15.1640) - AMD Ryzen 7 4800H with Radeon Graphics (16 Threads)
### Issue description
If you have a tile_set with an occlusion layer, and you remove a tile with an occlusion shape at runtime, the occlusion shape will remain.
### Steps to reproduce
- Setup a scene with CanvasModulate and a 2D Light
- Create a tilemap & tileset
- Add an occlusion layer
- Give one or more tiles an occlusion shape
- Make a script run sometime during process to randomly remove and add the tiles with occlusion shapes, and tiles without.
You should now see errant shadows.
Or, in the MRP, just play the scene and you should see the problem once tiles alternate.
### Minimal reproduction project (MRP)
[OccluderProblem.zip](https://github.com/godotengine/godot/files/13552364/OccluderProblem.zip)
| https://github.com/godotengine/godot/issues/85766 | https://github.com/godotengine/godot/pull/85893 | 5c95fd59051baa04d54382a39571df767b8782d0 | b94eb58d35b3dd8a9f522bc90df0db73862ef326 | 2023-12-04T23:12:07Z | c++ | 2023-12-08T17:46:08Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,743 | ["scene/gui/color_picker.cpp"] | Color changes when opening color picker | ### Godot version
v4.3.dev.custom_build [d76c1d0e5]
### System information
Linux
### Issue description
When opening the color picker by clicking on a color property the color changes slightly.
### Steps to reproduce
* Click on a property with value `Color(.5, .5, .5) ` in the inspector
* Click away
* Open the color picker again
* See the color change to Color(0.502, 0.502, 0.502) in the "RAW" tab
### Minimal reproduction project
[ColorChangeBug.zip](https://github.com/godotengine/godot/files/13545089/ColorChangeBug.zip)
| https://github.com/godotengine/godot/issues/85743 | https://github.com/godotengine/godot/pull/85749 | 4600acfc41a5f34ee905829d224eb443a4b2c83f | 1125235c95abcb2948cbfc6f1c2c7eed6a44c4b1 | 2023-12-04T11:00:13Z | c++ | 2023-12-18T17:17:53Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,727 | ["editor/input_event_configuration_dialog.cpp"] | The configure menu in the InputEventJoypadButton and InputEventJoypadMotion Resource is so big, it cannot be closed. | ### Godot version
4.2.stable (most likely over versions aswell)
### System information
Godot v4.2.stable - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3070 Ti (NVIDIA; 31.0.15.4592) - AMD Ryzen 7 5800X 8-Core Processor (16 Threads)
### Issue description
When creating a custom InputEventJoypadButton resource, you are able to configure what the button actually is. In the list, that appears of every single button, however because the list is so large, it cannot fit onto the screen vertically, and therefore cannot be closed, forcing the whole engine to be closed through task manager. This problem also applies to the InputEventJoypadMotion Resource too.
### Steps to reproduce
Create a new InputEventJoypadButton or InputEventJoypadMotion Resource.
Select the configure button, which will display a list of all possible buttons.
Observe how the popup menu is so big, it cannot be closed. double clicking a selection dosent close the menu either.
### Minimal reproduction project
n/a | https://github.com/godotengine/godot/issues/85727 | https://github.com/godotengine/godot/pull/85790 | d847b6c3b7010e7ecaf3600b483bf708c7746ad4 | 8ffb7bd2083cbc963ebf32a7953cf9992ef83278 | 2023-12-03T22:22:52Z | c++ | 2023-12-06T11:36:34Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,718 | ["core/string/translation.cpp"] | Performance regression since 4.2-beta1 when calling `TranslationServer.set_locale()` every frame | ### Godot version
4.2
### System information
Windows 11
### Issue description
I started a project in Godot 4 and updated Godot and ended up with Godot 4.2dev_6 because this was compatible with the modi_player addon and Glow at the same time. Other Versions either had framrate issues (like the main problem i have now) or the addon not working.
After Godot 4.2 stable came out, I tried to work in my game with this Version and get massive framerate issues (5fps) in the forward+ and mobile renderer, even in an empty scene. I tried turning off hdr / glow and changed other project settings, but nothing works.
When I change to the Compatibility render I get the maximum amount of frames possible.
I have a Asus Rog Flow X13, Ryzen 7, GTX 1650 with Max-Q Design and a AMD Radeon Graphics
### Steps to reproduce
its only in this project, no else, but here are the stept I did with the Game.
- Started dev. in Godot 4.0
- Updated to Godot 4.1
- Installed Godot4.2_dev 3 for hdr glow (in 2D)
- changed to Godot 4.2dev6 because of the midi player addon
- now used a backup copy of my game to test Godot 4.2 stable
### Minimal reproduction project
I won't upload my game here, because I'm pretty far in developement. | https://github.com/godotengine/godot/issues/85718 | https://github.com/godotengine/godot/pull/85787 | 7233bc6736e6a9e12758a52402660f9a3a892a78 | d847b6c3b7010e7ecaf3600b483bf708c7746ad4 | 2023-12-03T19:11:58Z | c++ | 2023-12-06T11:36:27Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,706 | ["scene/2d/tile_map.cpp", "scene/2d/tile_map.h"] | Shadows not updating when setting tiles in code | ### Godot version
4.2
### System information
Godot v4.2.stable - Windows 10.0.19045 - Vulkan (Mobile) - dedicated AMD Radeon RX 6700 XT (Advanced Micro Devices, Inc.; 31.0.21001.45002) - AMD Ryzen 5 3600 6-Core Processor (12 Threads)
### Issue description
Tiles with light occluders still show shadows, when replacing them by code (set_cell) with a not occluding tile.
This does not happen when they are replaced with an empty cell (cell_id = -1) or erase_cell.
### Steps to reproduce
Make a new project with a Tilemap2D and a PointLight2D
Make 2 Tiles: One with an occluder and one without
Make the tiles placed by code.
Replace an occluding tile with a non occluding
### Minimal reproduction project
[TestForTilemap.zip](https://github.com/godotengine/godot/files/13539067/TestForTilemap.zip)
| https://github.com/godotengine/godot/issues/85706 | https://github.com/godotengine/godot/pull/85893 | 5c95fd59051baa04d54382a39571df767b8782d0 | b94eb58d35b3dd8a9f522bc90df0db73862ef326 | 2023-12-03T13:28:27Z | c++ | 2023-12-08T17:46:08Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,676 | ["editor/export/editor_export_platform.cpp", "modules/zip/zip_packer.cpp"] | It is not possible to add/read files named by non-ASCII characters using ZIPPackage and ZIPReader | ### Godot version
4.2 stable
### System information
Godot v4.2.stable - Windows 10.0.19045 - GLES3 (Compatibility) - AMD Radeon(TM) Graphics (Advanced Micro Devices, Inc.; 30.0.13014.10001) - AMD Ryzen 5 5500U with Radeon Graphics (12 Threads)
### Issue description
version : Godot 4.2
When debugging the code, when using ZIPPacker to create a compressed package, I couldn't successfully write any non-ASCII characters as the file name, he would sometimes output garbled characters, and sometimes he wouldn't even write the file properly.
And most of the time, he just outputs garbled characters, and it is incorrect to check the compressed file name in the Windows compression manager interface.
However, the same file can be read with the same name in the code.
There are times when I use ZIPReader to unzip a file named with non-ASCII characters, I also get an error:
```
Unicode parsing error, some characters were replaced with � (U+FFFD): Invalid UTF-8 leading byte (b2)
`Unicode parsing error, some characters were replaced with � (U+FFFD): Invalid UTF-8 continuation byte (e3 ... c2 ...)`
```
### Steps to reproduce
code:
```
var path: String = "res://test.zip";
func _ready():
var writer = ZIPPacker.new();
var err = writer.open(path);
if (err != OK) :
print("ERROR!");
writer.start_file("你好Godot.txt");
writer.write_file("Hello World!".to_utf8_buffer());
writer.close_file();
# ...
writer.close();
```
After running, the file name becomes garbled characters: "浣犲ソGodot.txt";
The ASCLL section is not affected
### Minimal reproduction project
[Test.zip](https://github.com/godotengine/godot/files/13536959/Test.zip)
| https://github.com/godotengine/godot/issues/85676 | https://github.com/godotengine/godot/pull/78732 | 654132cb9c6ff1f27be0bf325e348e74b3e49fba | 375d89ced067dab809ae43232143609ca90eb9ff | 2023-12-02T17:45:35Z | c++ | 2023-12-05T12:05:02Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,650 | ["scene/gui/tree.cpp"] | calling TreeItem set_text() on a TreeItem that was removed via remove_child() causes debugging to end without any error message | ### Godot version
4.2 Stable
### System information
Linux
### Issue description
Calling TreeItem set_text() on a TreeItem that was removed via remove_child() causes debugging to end and the application to close without any error message.
### Steps to reproduce
Run the included example to get the debugger to crash. Comment out "treeItem.remove_child(subTreeItem)" for normal behaviour.
### Minimal reproduction project
[treeItemCrash.zip](https://github.com/godotengine/godot/files/13534005/treeItemCrash.zip)
| https://github.com/godotengine/godot/issues/85650 | https://github.com/godotengine/godot/pull/86028 | 5088cd8ab7df3ed473dc13fa8162fcbc05109d8b | 2d5ceaab3ea05d9dc6592b679c961a46171d3a64 | 2023-12-02T09:35:08Z | c++ | 2023-12-13T09:32:48Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,644 | ["scene/animation/tween.cpp", "scene/animation/tween.h"] | Tweening modulate property doesn't behave right on 4.2 | ### Godot version
4.2-stable_mono
### System information
Windows 10, NVidiaRTX 2070
### Issue description
After updating to 4.2 I've realized that all my tweens working with the property "modulate" or "self_modulate" were behaving strangely... it happens when you use loops.. for instance if you have:
```
tween.SetLoop();
tween.TweenProperty(godotObject, "modulate", Colors.Red, 0.5f)
tween.TweenProperty(godotObject, "modulate", Colors.Blue, 0.5f);
```
that object should change its color from red to blue and then from blue to red and then loop, right? (basically, because its final value should be blue)
well, after 4.2 .. the color resets to its default color before starting a new loop, this didn't happen on older versions.
If you don't use Loops its final value persists, so the problem is only when using Loops.
so, for example if you had a modulate value of White before starting the loop.. the tween will change its modulate from red to blue, then resets to white and then start over again...
* I haven't tested on GDScript
### Steps to reproduce
1- Create a CanvasItem such as a white ColorRect, so that you can tween its modulate property.
2- Attach a script that runs the following code (C#):
```
tweener = this.CreateTween();
tweener.SetLoops(0);
tweener.SetEase(Tween.EaseType.Out);
tweener.TweenProperty(godotObject, "modulate", Colors.Red, 0.5f);
tweener.TweenProperty(godotObject, "modulate", Colors.Blue, 0.5f);
```
The modulate will change its value to default each time before starting a new loop
### Minimal reproduction project
N/A | https://github.com/godotengine/godot/issues/85644 | https://github.com/godotengine/godot/pull/85681 | 7b2b408410860ec2fc4e0517c93863c220512edc | 1d520f5d11f9f1af943483072e3a45aacc2882e0 | 2023-12-02T05:51:49Z | c++ | 2023-12-04T22:21:34Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,640 | ["scene/animation/animation_node_state_machine.cpp", "scene/animation/animation_tree.cpp", "scene/animation/animation_tree.h"] | AnimationNodeStateMachinePlayback.travel() gets stuck for nested state machines | ### Godot version
4.2
### System information
Linux
### Issue description
A nested state machine isn't traveling to its animation in `_ready()` in 4.2 as it was in 4.1.3.
In the ready function, we make the `root` state machine travel to the state of the `Stages` nested state machine. Then we immediately call the `Stages` nested state machine to travel to `Stage2`. This works fine in Godot v4.1.3, but not in Godot v4.2, where it seems a delay is first needed for the second travel animation to work.
### Steps to reproduce
Run the MRP below in 4.1.3 and 4.2.
In 4.1.3, the animation tree will reach `Stage2` and show Finished on the screen.
In 4.2, the animation tree will only reach `Stage1` and show Stuck on the screen.
### Minimal reproduction project
[MRP-AnimationNodeStateMachinePlayback.zip](https://github.com/godotengine/godot/files/13533132/MRP-AnimationNodeStateMachinePlayback.zip)
| https://github.com/godotengine/godot/issues/85640 | https://github.com/godotengine/godot/pull/85794 | 2df8c3c63210958aba2858b17abd0f8a436a9764 | e1d4b3cc07605a28f182e23d1924b6432fda2186 | 2023-12-02T02:24:39Z | c++ | 2023-12-11T23:33:01Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,638 | ["scene/gui/slider.cpp"] | Warning spammed when scrolling sliders of the color picker in the Editor | ### Godot version
4.2.stable
### System information
Godot v4.2.stable - Windows 10.0.22621 - GLES3 (Compatibility) - Intel(R) Iris(R) Plus Graphics (Intel Corporation; 27.20.100.9621) - Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz (8 Threads)
### Issue description
This warning gets spammed when scrolling any slider on the color picker of the editor using the mouse wheel.
The value of the slider gets affected nevertheless
```
scene/gui/control.cpp:2012 - This control can't grab focus. Use set_focus_mode() to allow a control to get focus.
```
### Steps to reproduce
For example having a script that exports a color
and scrolling the A slider in the Inspector
```
@export var color : Color
```
### Minimal reproduction project
N/A | https://github.com/godotengine/godot/issues/85638 | https://github.com/godotengine/godot/pull/85652 | 252c462a9d14befe19d5a9e8774fd71f91ac1bb3 | 26834d298de76add5cb9fa3163d84c8f85b5878c | 2023-12-02T01:59:01Z | c++ | 2023-12-19T19:33:05Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,632 | ["scene/animation/animation_player.cpp"] | Animations created in AnimationPlayer in 4.2 don't update frames while scrubbing the timeline | ### Godot version
4.2
### System information
M1 Mac
### Issue description
Since I updated to 4.2 any animation player that I create which changes a Sprite2D texture or offset is not updating the texture value if I scrub the timeline of my animation. I can see in the sidebar that the frames are changing and the frames change if I press play on the animation. But it won't change the Sprite2D's frame if I drag the scrubber back and further between frames. I need to do this in order to determine the offsets of the sprite2D frames.
Somehow scenes I previously created in 4.1.3 or earlier are not affected by this. But new scenes / animation players are.
### Steps to reproduce
1. Create a new scene in 4.2
2. Add a Sprite2D
3. Add an AnimationPlayer
4. Add a track to change the Sprite2D texture to the AnimationPlayer
5. Add keys into the animation player which change the textures of a sprite
6. Verify the texture is changing in the animation by pressing play and seeing the changes
7. Press stop
8. Drag the scrubber between frames
9. Observe that the texture is NOT updated moving from key-to-key*
* It appears that it will transition between frames for the first 3 frames or so, but beyond those frames it stops working correctly. I don't know exactly why that is.
### Minimal reproduction project
[Test.zip](https://github.com/godotengine/godot/files/13532350/Test.zip)
| https://github.com/godotengine/godot/issues/85632 | https://github.com/godotengine/godot/pull/85569 | 6cfb3f61f25f5f90d1349887280ce7ce9b0f03d6 | b8ba602e8c060c170cc2bfea7bbc652bb1c1199e | 2023-12-01T22:19:32Z | c++ | 2023-12-04T22:19:58Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,625 | ["scene/2d/tile_map.cpp"] | Player isn't colliding with scene tiles when they aren't visible. | ### Godot version
v4.2.stable.official [46dc27791]
### System information
Godot v4.2.stable - Windows 10.0.19045 - Vulkan (Forward+) - integrated Intel(R) HD Graphics 630 (Intel Corporation; 31.0.101.2111) - Intel(R) Core(TM) i5-7400 CPU @ 3.00GHz (4 Threads)
### Issue description
I have a tileset that disables its visibility during it's `_ready()` function. The tileset is made up of scene tiles. I didn't have a problem with this until recently I discovered my player goes right through the tiles unless they're visible. This didn't happen before, it could be something to do with the 4.2 update.
### Steps to reproduce
In my minimal reproduction project I removed the script that disables the tileset's visibility.
- Run the game with the tileset visible and use wasd keys to move downward. The tileset should block the player (it's using `move_and_slide()`).
- Run the game with the tileset non-visible and use wasd keys to move downward. The tileset isn't block the player.
### Minimal reproduction project
[Bug Demo.zip](https://github.com/godotengine/godot/files/13531278/Bug.Demo.zip)
| https://github.com/godotengine/godot/issues/85625 | https://github.com/godotengine/godot/pull/85753 | bf7425889062f9d8e1590fe6259bd9476cdd7e0e | 654132cb9c6ff1f27be0bf325e348e74b3e49fba | 2023-12-01T19:32:23Z | c++ | 2023-12-04T22:29:33Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,619 | ["main/main.cpp", "platform/macos/gl_manager_macos_angle.mm"] | MacBook Pro quickly maxes out its memory when running a project on Compatibility rendering method with ANGLE | ### Godot version
4.2.stable (.NET version)
### System information
macOS Ventura 13.6.1, MacBook 2017 Intel Core i5, Iris Plus 650, 16 GB ram
### Issue description
My friend was testing my Godot project (which has the Compatibility rendering method configured) and he said that his MacBook quickly ran out of memory. The game was allocating 15 GB of RAM after a minute or two. More interestingly, the same happened with the 2D platformer demo project from https://github.com/godotengine/godot-demo-projects, when running in Compatibility mode. My Windows machine doesn't suffer from this at all.
Fortunately, we figured out that switching to Forward+ mode fixed the issue. The downside is that I have now lost a potential audience of devices that need Compatibility rendering.
Here's what he saw in the profiler:
By the way, when my friend closes the editor, he gets the following which might be related (I have no idea but who knows):
### Steps to reproduce
Run the 2D platformer demo project from https://github.com/godotengine/godot-demo-projects and set it to the Compatibility rendering method (or possibly any other game that can run in this mode) on a MacBook (maybe only one that matches the provided system specs or maybe any Mac, I don't know).
### Minimal reproduction project
2D/platformer demo from https://github.com/godotengine/godot-demo-projects in Compatibility rendering mode | https://github.com/godotengine/godot/issues/85619 | https://github.com/godotengine/godot/pull/85785 | 1af8228ced0b2898bee3952d91f5b901b3952513 | 7233bc6736e6a9e12758a52402660f9a3a892a78 | 2023-12-01T17:04:17Z | c++ | 2023-12-05T14:15:48Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,601 | ["doc/classes/CameraAttributesPhysical.xml"] | `CameraAttributesPhysical.exposure_shutter_speed` description is incorrect. | ### Godot version
4.2 stable
### System information
Windows 10.0.22631 - Vulkan (Forward+) - dedicated AMD Radeon RX 7900 XTX (Advanced Micro Devices, Inc.; 31.0.22023.1014) - AMD Ryzen 7 7800X3D 8-Core Processor (16 Threads)
### Issue description
As shutter speed increases, the image becomes darker. This is not reflected in the documentation.
### Steps to reproduce
n/a
### Minimal reproduction project
n/a | https://github.com/godotengine/godot/issues/85601 | https://github.com/godotengine/godot/pull/85599 | 75d7aab0156e08795e07b750f2b4c253d51902b8 | c4f872e38e577d8d6fedeaba99b144590113f751 | 2023-12-01T09:40:25Z | c++ | 2023-12-05T12:05:32Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,593 | ["scene/3d/camera_3d.cpp"] | `Camera3D.current` is set to true when setting `Camera3D.current` to false on another node | ### Godot version
Godot v4.2.stable
### System information
Windows 10.0.22631 - Vulkan (Forward+) - dedicated AMD Radeon RX 7900 XTX (Advanced Micro Devices, Inc.; 31.0.22023.1014) - AMD Ryzen 7 7800X3D 8-Core Processor (16 Threads)
### Issue description
When you disable `current` on a Camera3D, the first available Camera3D in the scene will have it's `current` property set to true.
### Steps to reproduce
Add 2 Camera3D nodes to a scene, note both have `current` disabled.
Enable and disable `current` on one Camera3D.
After `current` is disabled on one Camera3D, the other Camera3D has it's `current` property set to true
### Minimal reproduction project
[minimal.zip](https://github.com/godotengine/godot/files/13522846/minimal.zip)
| https://github.com/godotengine/godot/issues/85593 | https://github.com/godotengine/godot/pull/85594 | 4d695985c18794570080fbd3d3ddba50c69c310e | 252c462a9d14befe19d5a9e8774fd71f91ac1bb3 | 2023-12-01T08:36:44Z | c++ | 2023-12-19T19:33:00Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,574 | ["editor/icons/SnapGrid.svg"] | "Use Grid Snap" icon is hardly visible with Light theme | ### Godot version
v4.2.stable.official [46dc27791]
### System information
Linux (Fedora Silverblue), v4.2.stable.official [46dc27791], AMD RX570, Forward+
### Issue description
I have hard time looking at Grid Snap icon in light theme:
Also, when this button active, it have cyan color, while other such buttons become blue:
### Steps to reproduce
1. Open Godot
2. Open any project
3. Editor -> Editor Settings...
4. Interface -> Theme
5. Select "Light" in "Preset"
### Minimal reproduction project
Not specific to any project. | https://github.com/godotengine/godot/issues/85574 | https://github.com/godotengine/godot/pull/85585 | 708efe9b9448c72ada0aafa195106542c4a3e84d | 1af8228ced0b2898bee3952d91f5b901b3952513 | 2023-11-30T22:19:18Z | c++ | 2023-12-05T14:15:44Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,564 | ["platform/web/detect.py"] | `ZIPPacker.open()` causes index out of bounds error in Web after updating from Emscripten 3.1.18 to 3.1.39 | ### Godot version
4.2.stable
### System information
openSUSE Tumbleweed 20231122 - X11 - GLES3 (Compatibility) - NVIDIA GeForce GTX 1060 6GB (nvidia) - AMD Ryzen 5 1600 Six-Core Processor (12 Threads)
Browsers tested: Mozilla Firefox 119.0.1 and Chromium 119.0.6045.159
### Issue description
Using ZIPPacker.open() crashes in the Web version in Godot 4.2, giving an "index out of bounds" error. This did not happen in Godot 4.1.2. ZIPReader seems to be working correctly. I have only tested Mozilla Firefox 119.0.1 and Chromium 119.0.6045.159 on openSUSE Tumbleweed.
EDIT: The issue seems to have been introduced in Godot 4.2-beta3. In beta 2 this does not happen.
Firefox:
Chromium:
Errors keep appearing in the console as long as the tab is open.
### Steps to reproduce
Create an empty project, add a node and attach this script to it:
```
extends Node
func _ready() -> void:
var zip_packer := ZIPPacker.new()
var err := zip_packer.open("user://test.zip")
print(err)
zip_packer.close()
```
And run it on the Web version. It should crash.
### Minimal reproduction project
[ZIPPackerWeb.zip](https://github.com/godotengine/godot/files/13517053/ZIPPackerWeb.zip) | https://github.com/godotengine/godot/issues/85564 | https://github.com/godotengine/godot/pull/86036 | a9f444bbc307004c022e85e1b31fcfbd2e73566d | 0c03d25ba499214bd04a55e5df9ea17c9b3a344a | 2023-11-30T19:36:55Z | c++ | 2023-12-11T19:23:13Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,539 | ["platform/ios/export/export_plugin.cpp", "platform/ios/export/export_plugin.h"] | iOS one-click deploy not compatible with current Xcode 15 / iOS 17 | ### Godot version
4.2
### System information
Godot v4.2.stable - macOS 14.1.1 - Vulkan (Mobile) - dedicated AMD Radeon RX 6800
### Issue description
The new [iOS one-click deploy](https://github.com/godotengine/godot/pull/70662) is a great new feature!
When using it with a physical iPhone SE on iOS 17.1.1 (current) and Xcode 15.0.1 (current), the building phase of the export is successful, but then fails on the debug phase:
```
------ Debug phase ------
[...]
2023-11-30 14:42:08.089 ios-deploy[15462:194557] [ !! ] Unable to locate DeviceSupport directory with suffix 'DeveloperDiskImage.dmg'. This probably means you don't have Xcode installed, you will need to launch the app manually and logging output will not be shown!
```
The developers of ios-deploy [indicated](https://github.com/ios-control/ios-deploy/issues/588#issuecomment-1667938056) that Xcode 15 support will probably not be added. There is some additional discussion about it in [this flutter issue](https://github.com/flutter/flutter/issues/133465).
`devicectl` from Apple seems to replace some of the functionality, although it seems like the debug output isn't routed with this tool.
Until a fix or workaround is found, it should probably be documented that `ios-deploy` doesn't support Xcode 15.
### Steps to reproduce
One-click deploy to physical device
### Minimal reproduction project
N/A | https://github.com/godotengine/godot/issues/85539 | https://github.com/godotengine/godot/pull/85546 | 6269341461006144c30b6362084e8e836a341bd7 | dea7597111e60a187a330c99993de16266d3a946 | 2023-11-30T13:56:03Z | c++ | 2023-12-08T17:45:58Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,483 | ["scene/animation/animation_player.cpp"] | AnimationPlayer does not get the Discrete key correctly when seeking if there is an precision error | ### Godot version
4.2 RC2
### System information
Any
### Issue description
AnimationMixer separates the accuracy of how discrete keys are retrieved when seeking between internal seeking and external seeking. FYI: https://github.com/godotengine/godot/pull/80708.
Since AnimationPlayer currently treats everything as an internal seek, so it needs to propagate the external seek information.
### Steps to reproduce
Seek AnimationTrackEditor
### Minimal reproduction project
[gd_anim_unittest_1.zip](https://github.com/godotengine/godot/files/13492063/gd_anim_unittest_1.zip)
| https://github.com/godotengine/godot/issues/85483 | https://github.com/godotengine/godot/pull/85569 | 6cfb3f61f25f5f90d1349887280ce7ce9b0f03d6 | b8ba602e8c060c170cc2bfea7bbc652bb1c1199e | 2023-11-28T19:05:49Z | c++ | 2023-12-04T22:19:58Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,478 | ["editor/editor_audio_buses.cpp"] | Unable to deselect Audio bus effects (including selecting nodes or files, switching tabs, etc.) | ### Godot version
3.5.3.stable.official [6c814135b]
### System information
OS: Windows 11 - CPU: Intel Core i7-8700 @ 3.20GHz - GPU: NVIDIA GeForce GTX 1060 3GB
### Issue description
When I create an effect on an Audio Bus, selecting it is permanent unless I select another effect.
I've had this issue for a while and, when first discovering thought to myself "Eh, somebody else probably found it, it's already fixed". That was about a year ago now (_maybe longer_), and it's still the exact same.
The way I'd expect it to work is it would deselect if I clicked **anywhere** outside of the effect itself or the Inspector window (_or if I switch to the Output, Debugger, etc._).
### Demonstration video
https://github.com/godotengine/godot/assets/42562727/42ee9699-0420-4b97-9644-8de62204c78e
### Steps to reproduce
1. Open a Godot project (_happens in anyone for me_) or create a new one
2. Open the Audio tab
3. Create an effect and select it or select an existing one
4. Attempting to click outside the box will never deselect it. Attempting to delete a node or clicking DEL will only delete the effect (_even when it's not visible_).
### Temporary Fix
Create a deselection effect on the same bus and delete it. While it is an easy fix, this can get in the way of many developers, as it did with me (_it took me months to realize this_).
### Minimal reproduction project
N/A | https://github.com/godotengine/godot/issues/85478 | https://github.com/godotengine/godot/pull/85879 | 4269a57b0cafd2fc4724de758002c68928f4586b | 9d280f8b1c826b635ea3bff69267cbf7782b5199 | 2023-11-28T18:07:35Z | c++ | 2023-12-14T16:38:49Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,466 | ["editor/import/resource_importer_wav.cpp"] | WAV file that works everywhere else is silent in Godot | ### Godot version
4.2.rc2,3.5.1
### System information
Godot v4.2.rc (fc7920185) - NixOS 23.11 (Tapir) - Wayland - Vulkan (Mobile) - integrated Intel(R) Graphics (ADL GT2) - 12th Gen Intel(R) Core(TM) i5-1240P (16 Threads)
### Issue description
This short 1.5second WAV file came from a site with free sounds (None of the other sounds from the same source worked either).
Godot imports this sound file with a duration of 0, so it doesn't play anything. There are no error messages that I can see. I have attempted to re-import it with various different settings, and have tried it with an online inspection tool that didn't throw up any clues. This file plays properly in Audacity and VLC.
This problem is the same for Godot3.5.1, and probably applies to all versions.
### Steps to reproduce
Unzip and preview Cloth_02.wav in Godot. It doesn't play.
The second file Cloth_02_savedfromaudacity.wav is what happens if I load and save it from Audacity. Then Godot loads and plays it as it should.
[Cloth_02.zip](https://github.com/godotengine/godot/files/13488036/Cloth_02.zip)
### Minimal reproduction project
N/A | https://github.com/godotengine/godot/issues/85466 | https://github.com/godotengine/godot/pull/85556 | b38a7ae1061d0b2df3dd2371b6b249aad72108d6 | 6cfb3f61f25f5f90d1349887280ce7ce9b0f03d6 | 2023-11-28T12:44:29Z | c++ | 2023-12-04T22:19:34Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,439 | ["scene/resources/importer_mesh.cpp"] | Crash when configuring the import of a gltf file and enabling Physics in a MeshInstance3D and switching body and shape types | ### Godot version
v4.2.rc2.official [1ba920fad]
### System information
Windows 11, Intel Core i5 10300H, nVidia GTX 1650
### Issue description
When configuring the import of a gltf file, I'm trying to configure a mesh to use physics. When switching the body and shape type of this mesh, the engine will sometimes crash.
I couldn't detect the specific action that triggered the crash. Switching possible shape types appears to make the crash happen more often, but sometimes it will crash on the first shape type I choose and sometimes I can switch the shape type several times before it crashes.
The bug also happens in 4.2_RC1, but it's WAY easier to reproduce there. Sometimes merely checking Physics on will already trigger the crash. At most, doing one switch of body type (not even shape type) will also trigger the crash.
### Steps to reproduce
- Open the sample project
- Double click `room_model.glb`
- Click the `ComputerScreen` mesh instance
- Check `Physics` on
- Change body type to Area
- Change shape types
It can take a few changes to shape type to trigger the bug in RC2, but in RC1 sometimes merely checking Physics on can trigger it.
### Minimal reproduction project
Project to reproduce the bug.
[bug_project.zip](https://github.com/godotengine/godot/files/13477636/bug_project.zip)
Video of bug happening on my machine (I was "lucky" and it happened right away, sometimes it takes a few switches to shape type before it happens).
https://github.com/godotengine/godot/assets/1204296/797262fd-a881-4b8d-a6f8-2ed6aa593995
| https://github.com/godotengine/godot/issues/85439 | https://github.com/godotengine/godot/pull/85631 | b8ba602e8c060c170cc2bfea7bbc652bb1c1199e | 6a10b9922837c2cab694d6babe074a79f714db36 | 2023-11-27T16:31:07Z | c++ | 2023-12-04T22:20:23Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,435 | ["modules/gdscript/gdscript.cpp", "modules/gdscript/gdscript.h"] | Exponentially slow quitting time with dependencies between (gdscript) scripts | ### Godot version
Godot v4.2.rc2
### System information
Godot v4.2.rc2 - Ubuntu 22.04.3 LTS 22.04 - X11 - Vulkan (Forward+) - integrated Intel(R) UHD Graphics (CML GT2) () - Intel(R) Core(TM) i7-10850H CPU @ 2.70GHz (12 Threads)
### Issue description
When there is a lot of dependencies between types defined with class_name or class, the quitting time for game (and editor) grows exponentially.
With a "real" project (nb of scripts: 97, nb lignes of code: 11638, nb dependencies between script: 336) the quitting time is ~8.0s.
I could manage to reduce it to ~5.0s just by moving an inner class from one file to another.
On a "toy" project, with N scripts doing nothing except depending on each others, the quitting time seems exponential:
- 40 scripts : 1.5s
- 50 scripts : 2.5s
- 60 scripts : 4.5s
- 70 scripts : 8.4s
- 80 scripts : 15.7s
- 90 scripts : 27.1s
- 100 scripts : 46.8s
Adding the dependencies as a type check (`if my_var is MyType`) triggers the issue.
Adding the dependencies as a type creation (`MyType.new()`) triggers the issue.
Adding the dependencies as type hinting (`var my_var : MyType`) doesn't triggers the issue.
Adding inner (unused) classes inside these script increases a lot the time.
The dependencies being cyclical or not doesn't seems to change the behavior.
Same issue with 4.1.2-stable.
### Steps to reproduce
1) Create N scripts, each depending on each others
for example for script0.gd:
```
class_name Script0
static func some_func():
print(Script0.new())
print(Script1.new())
print(Script2.new())
print(Script3.new())
...
```
2) in the script of the main scene, add a dependency to one of the N inter-depending scripts, for example with `print(null is Script0)`
3) then quit directly the scene, with `get_tree().quit()`
4) launch the main scene
If N is high enough (>50), it will start to quit directly, but the quitting time will be long.
5) quit the editor.
The quitting time will also be quite long.
note: a python script has been provided in the minimal project to create all the N inter-depending gdscript scripts of step 1.
### Minimal reproduction project
[quitting_time_dependencies.zip](https://github.com/godotengine/godot/files/13476840/quitting_time_dependencies.zip)
| https://github.com/godotengine/godot/issues/85435 | https://github.com/godotengine/godot/pull/85603 | 3fef8910c768300e2b0350e79c8e81ffb0c08e58 | f4b32b228abe55979a42dd429c82848addce7647 | 2023-11-27T15:19:03Z | c++ | 2023-12-16T16:49:47Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,423 | ["scene/2d/tile_map.cpp"] | Error when trying to use `TileMap.cell_quadrant_size` in 4.2 | ### Godot version
v4.2.rc2.official [1ba920fad]
### System information
Godot v4.2.rc2 - macOS 14.1.1 - Vulkan (Forward+) - integrated Apple M1 - Apple M1 (8 Threads)
### Issue description
Crash when trying to use "cell_quadrant_size".
The same project works without problems in 4.1.3
### Steps to reproduce
Open the attached project and run it, it'll crash. "Invalid get index"
Here is what the same project looks like when launched from 4.1.3:
### Minimal reproduction project
[engage bug 03.zip](https://github.com/godotengine/godot/files/13471828/engage.bug.03.zip)
| https://github.com/godotengine/godot/issues/85423 | https://github.com/godotengine/godot/pull/85463 | 83ae2b158f19cf44a2431514175a351794fe0c2e | a0d764919276edfa1560a7c3d74fcd8708615398 | 2023-11-27T08:57:21Z | c++ | 2023-11-28T12:37:32Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,410 | ["scene/animation/animation_mixer.cpp"] | AnimationPlaybackTrack assigned animation is seeked to 0 unintentionally after stopping host AnimationPlayer | ### Godot version
4.2 RC2
### System information
Any
### Issue description
https://github.com/godotengine/godot/assets/61938263/42ed582f-7b87-424c-8d19-ba0650ead5aa
It should not be reset by pausing.
### Steps to reproduce
Pause AnimationPlaybackTrack
### Minimal reproduction project
N/A | https://github.com/godotengine/godot/issues/85410 | https://github.com/godotengine/godot/pull/85411 | d6dd1de64409a74e27abc92d5756799c0b60b630 | a008a85443cf95f8188fa68471c78d5597b3df68 | 2023-11-27T03:23:27Z | c++ | 2023-11-28T07:28:25Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,401 | ["scene/gui/code_edit.cpp"] | Argument autocompletion hides the argument list | ### Godot version
4.2 rc2
### System information
Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 30.0.15.1403) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)
### Issue description
https://github.com/godotengine/godot/assets/2223172/2c1829fa-1dd7-4f5b-b04a-f557ace35b5e
You can either see autocompletion or argument list. It's especially annoying when using e.g. `Input.get_vector()` method which has multiple arguments difficult to remember.
### Steps to reproduce
1. Write `Input.get_vector(`
2. Remove `(`
3. Add `(`
### Minimal reproduction project
N/A | https://github.com/godotengine/godot/issues/85401 | https://github.com/godotengine/godot/pull/85436 | dee2604d99e1f7e219574e03469559fe205d3894 | 7182c473095d1c0c08a89499dfd27f8290ad3f06 | 2023-11-26T21:16:40Z | c++ | 2023-12-19T19:32:50Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,398 | ["editor/editor_node.cpp", "editor/editor_node.h"] | Unable to exit out of editor fullscreen mode in Godot 4.2 rc2 | ### Godot version
v4.2.rc2.official [1ba920fad]
### System information
Godot v4.2.rc2 - Windows 10.0.22631 - Vulkan (Forward+) - dedicated AMD Radeon RX 6700 XT (Advanced Micro Devices, Inc.; 31.0.22023.1014) - AMD Ryzen 9 5900X 12-Core Processor (24 Threads)
### Issue description
When I enter fullscreen mode in the editor with shift + f11 while being in or then going to the 3D editor, I can't exit it anymore by pressing the same keybind.
### Steps to reproduce
Create a new Godot project
Press shift + f11 to enable editor fullscreen
Go to the 3D editor
Try to exit editor fullscreen with shift + f11
### Minimal reproduction project
Create a new Godot project | https://github.com/godotengine/godot/issues/85398 | https://github.com/godotengine/godot/pull/85427 | b3a0e077ebd29bc4e2456dea816b525b691932ab | 03c251e659e2dbe33f15c7cf86a87dc3c12a872c | 2023-11-26T19:21:08Z | c++ | 2023-11-27T18:42:38Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,395 | ["scene/main/window.cpp"] | Crash on Exporting Android AAB using 'Hello World' Sample Android Plugin in Godot 4.2.rc2 | ### Godot version
v4.2.rc2.official
### System information
macOS Sonoma 14.0 - Mac Mini Apple M1 - Godot v4.2.rc2.official
### Issue description
Testing the new system for Android plugins I found this bug when I tried to export the demo for Android using the **[Hello World plugin](https://github.com/m4gr3d/Godot-Android-Samples/blob/master/plugins/hello_world/README.md)**
If I select the Gradle Build with **Export Format**: **Export APK** it works. But when I change it to **Export AAB** Godot displays an error and then crashes, as mentioned in @https://github.com/godotengine/godot/issues/76497
### Steps to reproduce
Clone the project Godot-Android-Samples from:
`https://github.com/m4gr3d/Godot-Android-Samples.git` (commit 09386ad)
Build the Hello World plugin:
Using terminal go to
`cd Godot-Android-Samples`
Run the gradlew command
`./gradlew :plugins:hello_world:assemble`
Using Godot v4.2.rc2, import the demo Godot project for Hello World plugin from:
`plugins/hello_world/demo`
If you haven't already installed the Android Build Template for Godot v4.2.rc2, install it.
Make sure the plugin is enabled
> Project->Project Settings..-> Plugins
**HelloWorldPlugin** status Enable (checked)
Go to
> `Project->Export`
Confirm that Android is already defined in Preset and select **Android (Runnable)**
Confirm **Use Gradle Build:** is On
Set **Export Format:** to **Export AAB**
In **Export Path** set the file extension with aab
Select **Export All...** and then **Debug**
Wait for the build to complete and check for the 'Build FAILED' message and Godot crashing.
The error only occurs with the 'Export AAB' option, not with the 'Export APK' option.
### Minimal reproduction project
[Godot-Android-Samples-master.zip](https://github.com/godotengine/godot/files/13467705/Godot-Android-Samples-master.zip) | https://github.com/godotengine/godot/issues/85395 | https://github.com/godotengine/godot/pull/85418 | b20ecc91e4112a6f5918dc98045bbe9e56d7399d | a807d4bfa79f7308ad87d78002269a05b0a4841b | 2023-11-26T18:27:07Z | c++ | 2023-11-27T15:01:30Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,328 | ["scene/gui/rich_text_label.cpp"] | CharFXTransform - relative_index is substracted by 1 each RichTextLabel bbcode effect block | ### Godot version
v4.2.rc1.official [ad72de508]
### System information
Godot v4.2.rc1 - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1660 Ti (NVIDIA; 31.0.15.3742) - Intel(R) Core(TM) i7-10700F CPU @ 2.90GHz (16 Threads)
### Issue description
While trying to use a custom effect script as a workaround for the [rainbow bbcode effect](https://github.com/godotengine/godot/issues/85031) at the RichTextLabel I found a bug regarding the `CharFXTransform.relative_index`.
The variable is explained as follows in the [documentation](https://docs.godotengine.org/en/4.0/classes/class_charfxtransform.html#class-charfxtransform-property-relative-index):
```
The character offset of the glyph, relative to the current RichTextEffect custom block.
```
However, when using the script below, the character index shifts one to the left each time instead of being at the same position for each new effect block.
### Steps to reproduce
Add this script as Custom Effect to the RichTextLabel (or see the MRP):
```@tool
extends RichTextEffect
class_name test
var bbcode = "test"
func _process_custom_fx(char_fx):
if char_fx.relative_index == 5:
char_fx.color = Color.BLACK
pass
```
Add this Text to a Rich TextLabel:
```
[test]0123456789[/test]
[test]0123456789[/test]
[test]0123456789[/test]
[test]0123456789[/test]
[test]0123456789[/test]
[test]0123456789[/test]
```
### Minimal reproduction project
[relative_index_issue.zip](https://github.com/godotengine/godot/files/13462368/relative_index_issue.zip)
| https://github.com/godotengine/godot/issues/85328 | https://github.com/godotengine/godot/pull/85363 | 3e7cc5ec32b9dc55a8f55300c0b3faf7b655448c | 8580874d0f1a140cd751c4cf29d8e7240ddf886d | 2023-11-24T22:49:31Z | c++ | 2023-12-04T22:12:48Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,315 | ["scene/animation/animation_player.cpp", "scene/animation/animation_player.h"] | Using `advance()` has no effect on Discrete animation tracks and stops playback | ### Godot version
4.2 1ba920f
### System information
Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 30.0.15.1403) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)
### Issue description
```GDScript
func _ready() -> void:
$AnimationPlayer.play("new_animation")
$AnimationPlayer.advance(0)
```
The animation has a single track with Update Mode set to discrete. It does not play, no matter the argument used.
Removing `advance()` will make it play.
Works correctly in rc1.
### Steps to reproduce
1. Run MRP on master
2. Run MRP in 4.2 rc1
### Minimal reproduction project
[brokedvance.zip](https://github.com/godotengine/godot/files/13460977/brokedvance.zip)
| https://github.com/godotengine/godot/issues/85315 | https://github.com/godotengine/godot/pull/85366 | 5df98679672c12d96b4ac4d96ee17f1559207401 | b20ecc91e4112a6f5918dc98045bbe9e56d7399d | 2023-11-24T16:26:15Z | c++ | 2023-11-27T15:01:03Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,307 | ["scene/animation/animation_mixer.cpp"] | Saving project crashes if animation mixer contains METHOD or ANIMATION tracks | ### Godot version
v4.2.rc.custom_build [d6a1db2b0]
### System information
Godot v4.2.rc (d6a1db2b0) - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3090 Ti (NVIDIA; 31.0.15.4592) - AMD Ryzen 9 7950X 16-Core Processor (32 Threads)
### Issue description
`AnimatedValuesBackup::get_data()` can crash as the internal data map can have nullptr values if any of the tracks were METHOD or ANIMATION types, as `AnimatedValuesBackup::get_cache_copy()` defines that these types of tracks do not get valid copies.
The resulting crash is therefore a null pointer exception.
### Steps to reproduce
1. Open a project with these type of animation tracks.
2. Save the project.
### Minimal reproduction project
https://github.com/godotengine/godot-demo-projects/tree/master/3d/platformer | https://github.com/godotengine/godot/issues/85307 | https://github.com/godotengine/godot/pull/85308 | d6a1db2b07595f80c0f19ab01c6b4d0b66002b18 | 1ba920fada9efc8c4476ded50fe673b8db541366 | 2023-11-24T12:41:25Z | c++ | 2023-11-24T13:43:04Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,277 | ["scene/main/viewport.cpp", "scene/main/viewport.h"] | Crash when hiding a panel from a `NOTIFICATION_MOUSE_ENTER` notification | ### Godot version
v4.2.rc.custom_build [702227129]
### System information
Godot v4.2.rc (702227129) - Debian GNU/Linux trixie/sid trixie - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 6GB (nvidia) - AMD Ryzen 5 1600 Six-Core Processor (12 Threads)
### Issue description
Found a consistent crash when calling `hide()` from `_notification()`.
It does not happen if the call is deferred.
### Steps to reproduce
The `hide_test.gd` script has a boolean `cause_crash`. If it is true, hovering the mouse over the label crashes without an error in the Godot Editor Console. If it's false it hides the label as expected.
### Minimal reproduction project
[hide_crash.zip](https://github.com/godotengine/godot/files/13452818/hide_crash.zip)
| https://github.com/godotengine/godot/issues/85277 | https://github.com/godotengine/godot/pull/85313 | 44d544fc98d55cd71e53f384e11989d62f736ea0 | dcbb18ded855ab1b18207c13e7a1258f0055c814 | 2023-11-23T18:29:28Z | c++ | 2023-12-08T14:23:32Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,251 | ["doc/classes/SceneTree.xml"] | get_tree() returning null immediately after calling change_scene_to_file() in _process or _physics_process() | ### Godot version
v4.2.beta4.official [93cdacbb0]
### System information
Windows 10
### Issue description
`get_tree()` returns null when called immediately after calling `change_scene_to_file()` in `_process()` or `_physics_process()`. The error printed in debugger: `scene1.gd:14 @ _process(): Parameter "data.tree" is null.` Regardless of this the scene gets properly changed.
Doing the same from `_ready()` works as expected.
### Steps to reproduce
Make a scene with a node and another test scene to change to. Attach the following script to the node in the first scene:
~~~
extends Node
func _process(delta):
if Input.is_action_just_pressed("ui_accept"):
print(get_tree())
get_tree().change_scene_to_file("res://scene2.tscn")
print(get_tree())
~~~
Press enter and the output will be:
~~~
<SceneTree#25987908681>
<Object#null>
~~~
### Minimal reproduction project
N/A | https://github.com/godotengine/godot/issues/85251 | https://github.com/godotengine/godot/pull/85279 | 066e7d483a8f699fd94e7133ac23978cd460a72d | 8d43168fd73fc19563adc947bb48e488db95c7f6 | 2023-11-22T23:36:21Z | c++ | 2023-11-24T10:56:11Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,247 | ["doc/classes/NavigationAgent2D.xml", "doc/classes/NavigationAgent3D.xml", "scene/2d/navigation_agent_2d.cpp", "scene/2d/navigation_agent_2d.h", "scene/3d/navigation_agent_3d.cpp", "scene/3d/navigation_agent_3d.h"] | The "Target Reached" signal on the NavigationAgent2D node does not reliably trigger when the path desired distance is set above the target desired distance | ### Godot version
4.2-rc1
### System information
Windows 11, Vulkan
### Issue description
When using the NavigationAgent2D the "target reached" signal usually does not trigger if the target desired distance value is below the path desired distance. If, however, the navigation agent target position is set while the agent is within the desired distance then it will reliably trigger.
This can be simulated by either issuing a nearby move command or by setting (and thus recalculating) the target position every frame.
### Steps to reproduce
1. Implement a basic CharacterBody2D
2. Add a NavigationAgent2D node and leave the default values
3. Set up the CharacterBody2D to move when its NavigationAgent2D has its movement position set (based on the Using NavigationAgents documentation)
4. Connect the on_target_reached and on_navigation_finished signals
5. Move the character around and observe that navigation is finished before the target is reached when the target position is set beyond the target desired distance
6. Move the character a small distance within the target desired distance; observe the target reached signal reliably triggers
7. Set the target desired distance higher than the path desired distance (or vice versa); observe that the target reached signal more reliably triggers.
### Minimal reproduction project
[target-reached-test.zip](https://github.com/godotengine/godot/files/13444552/target-reached-test.zip)
| https://github.com/godotengine/godot/issues/85247 | https://github.com/godotengine/godot/pull/82561 | 58e68590a3b4455932ac931ced8ef3a5c36e4597 | 302e41c26478b72171226244ae57122581cdd880 | 2023-11-22T22:13:28Z | c++ | 2023-12-14T20:22:35Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,242 | ["scene/2d/navigation_region_2d.cpp"] | NavRegion2d merge indicators are only generated when the scene is loaded | ### Godot version
4.2 beta 3
### System information
Godot v4.2.beta3 - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 Laptop GPU (NVIDIA; 31.0.15.3699) - AMD Ryzen 9 6900HS with Radeon Graphics (16 Threads)
### Issue description
The connection indicators between two NavRegion2D (the pink circles) are not redrawn when they are moved around, instead each nav region move its indicators with it. When the scene is reloaded the indicators are drawn correctly, but then if you move the regions you have to reload the scene to get the correct indicators.
Here is a gif to illustrate the issue.
### Steps to reproduce
This happens with any 2d scene that have 2 or more connected nav regions 2d.
But to simplify things, you can go to the [attached project](https://github.com/godotengine/godot/files/13444254/nav-issues.zip), open the Scene3 and move one of the nav regions in the editor to notice the issue
### Minimal reproduction project
[nav-issues.zip](https://github.com/godotengine/godot/files/13444262/nav-issues.zip)
| https://github.com/godotengine/godot/issues/85242 | https://github.com/godotengine/godot/pull/85258 | a8bc2072528292bd631714c4274f4f0b8384d768 | 0e4aead7a1b65b2cd49354cd8a403ace8b60cd47 | 2023-11-22T20:59:02Z | c++ | 2023-12-04T22:11:15Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,233 | ["scene/animation/animation_mixer.cpp", "scene/animation/animation_mixer.h"] | Crash on reimport when applying AnimatedValueBackups from an Apply Reset | ### Godot version
4.2.rc 7022271
### System information
Godot v4.2.rc (702227129) - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3090 (NVIDIA; 31.0.15.3713) - Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 Threads)
### Issue description
Godot crashes due to a complicated chain of events in the stack trace involving `reimport_files`, `reload_scene` and a synchronous `clear_history` which memdeletes several dangling TrackCache pointers in this RefCounted AnimatedValuesBackup ?!
```
Critical error detected c0000374
A breakpoint instruction (__debugbreak() statement or a similar call) was executed in godot.windows.editor.x86_64.exe.
```
Something feels very wrong about holding raw pointers to an AnimationMixer TrackCache in AnimatedValuesBackup. I can't follow the flow at all of how values get stored in AnimatedValuesBackup.
To maintain single-free semantics, these `TrackCache*` values must be **moved** and **owned by** the AnimatedValuesBackup.
TrackCache pointers must never be shared by other objects, otherwise a use-after-free or double-delete is likely to happen
### Steps to reproduce
1. Follow the steps in #85232 to Apply Reset on an opened gltf
2. Select the gltf in the filesystem (it will already be selected if you followed the steps)
3. Open the Import dock and click Reimport
4. Godot will crash.
### Minimal reproduction project
[ApplyReset.zip](https://github.com/godotengine/godot/files/13442920/ApplyReset.zip)
| https://github.com/godotengine/godot/issues/85233 | https://github.com/godotengine/godot/pull/85254 | 1524972aa5c5fe128b60a1a10256b62a379f45db | bb63963486a389d4417ba13249a40219f3774df0 | 2023-11-22T18:10:03Z | c++ | 2023-11-23T14:35:15Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,232 | ["scene/animation/animation_mixer.cpp", "scene/animation/animation_mixer.h"] | Animation window Edit -> Apply Reset fails because `AnimationMixer::_reset` is not exposed | ### Godot version
4.2.rc 7022271
### System information
Godot v4.2.rc (702227129) - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3090 (NVIDIA; 31.0.15.3713) - Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 Threads)
### Issue description
Attempting to run Edit -> Apply Reset on an animation player with a RESET track fails because the `AnimationMixer::apply_reset` method is called with `p_user_initiated` true.
In this case, it attempts to use UndoRedo to apply `"_reset"` which does not exist / is not exposed on AnimationPlayer.
```
Animation Apply Reset
core\object\undo_redo.cpp:345 - Error calling UndoRedo method operation '_reset': 'AnimationPlayer::_reset': Instance is null
```
Other uses of `apply_reset` pass false which directly calls `AnimationMixer::reset()` and works fine.
Is there any reason that `reset` or `apply_reset` aren't exposed to scripting normally?
### Steps to reproduce
1. Import a model with a reset track
2. New Inherited Scene
3. Select the scene button in the hierarchy to open the base model directly.
4. Click "Open Anyway"
5. Select the AnimationPlayer
6. Choose the `_T-Pose_` animation or any animation other than `RESET`
7. Click the Edit menu -> `Apply Reset`. Nothing happens.
8. An error is printed in the log
### Minimal reproduction project
[ApplyReset.zip](https://github.com/godotengine/godot/files/13442920/ApplyReset.zip)
| https://github.com/godotengine/godot/issues/85232 | https://github.com/godotengine/godot/pull/85254 | 1524972aa5c5fe128b60a1a10256b62a379f45db | bb63963486a389d4417ba13249a40219f3774df0 | 2023-11-22T17:47:53Z | c++ | 2023-11-23T14:35:15Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,202 | ["editor/editor_node.cpp", "editor/editor_node.h", "editor/surface_upgrade_tool.cpp", "editor/surface_upgrade_tool.h"] | Deadlock during Godot startup | ### Godot version
7022271291a3d2a9cbd6a223d22a29fd775dfc5d
### System information
Windows 11, gl_compatibility, NVidia RTX 3070 TI
### Issue description
A deadlock can occur during application startup with the following:
* Main Thread: locks the DisplayServerWindows mutex during DisplayServerWindows::_get_screens_origin()
* Worker Thread: Surface Upgrade Tool attempts to change window title calling DisplayServerWindows::window_set_title()
The Worker Thread owns the DisplayServerWindows mutex and is trying to do a blocking SetWindowTextW call - a call which requires the Main Thread message pump to process; however the Main Thread is blocked trying to get hold of the very mutex locked by the worker thread.
Main Thread Call Stack:
```
godot.windows.editor.dev.x86_64.exe!MutexLock<MutexImpl<std::recursive_mutex>>::MutexLock<MutexImpl<std::recursive_mutex>>(const MutexImpl<std::recursive_mutex> & p_mutex) Line 129 C++
godot.windows.editor.dev.x86_64.exe!DisplayServerWindows::_get_screens_origin() Line 663 C++
godot.windows.editor.dev.x86_64.exe!DisplayServerWindows::mouse_get_position() Line 429 C++
godot.windows.editor.dev.x86_64.exe!Viewport::get_mouse_position() Line 1391 C++
godot.windows.editor.dev.x86_64.exe!CanvasItem::get_global_mouse_position() Line 1047 C++
godot.windows.editor.dev.x86_64.exe!CanvasItem::get_local_mouse_position() Line 1054 C++
godot.windows.editor.dev.x86_64.exe!EditorToaster::_notification(int p_what) Line 51 C++
godot.windows.editor.dev.x86_64.exe!EditorToaster::_notificationv(int p_notification, bool p_reversed) Line 43 C++
godot.windows.editor.dev.x86_64.exe!Object::notification(int p_notification, bool p_reversed) Line 840 C++
godot.windows.editor.dev.x86_64.exe!SceneTree::_process_group(SceneTree::ProcessGroup * p_group, bool p_physics) Line 950 C++
godot.windows.editor.dev.x86_64.exe!SceneTree::_process(bool p_physics) Line 1031 C++
godot.windows.editor.dev.x86_64.exe!SceneTree::process(double p_time) Line 510 C++
godot.windows.editor.dev.x86_64.exe!Main::iteration() Line 3636 C++
godot.windows.editor.dev.x86_64.exe!OS_Windows::run() Line 1474 C++
godot.windows.editor.dev.x86_64.exe!widechar_main(int argc, wchar_t * * argv) Line 182 C++
godot.windows.editor.dev.x86_64.exe!_main() Line 204 C++
godot.windows.editor.dev.x86_64.exe!main(int argc, char * * argv) Line 218 C++
godot.windows.editor.dev.x86_64.exe!WinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, char * lpCmdLine, int nCmdShow) Line 232 C++
[External Code]
```
Worker Thread Call Stack:
```
godot.windows.editor.dev.x86_64.exe!DisplayServerWindows::window_set_title(const String & p_title, int p_window) Line 1228 C++
godot.windows.editor.dev.x86_64.exe!EditorNode::_update_title() Line 303 C++
godot.windows.editor.dev.x86_64.exe!EditorNode::_update_from_settings() Line 349 C++
godot.windows.editor.dev.x86_64.exe!call_with_variant_args_helper<EditorNode>(EditorNode * p_instance, void(EditorNode::*)() p_method, const Variant * * p_args, Callable::CallError & r_error, IndexSequence<> __formal) Line 308 C++
godot.windows.editor.dev.x86_64.exe!call_with_variant_args<EditorNode>(EditorNode * p_instance, void(EditorNode::*)() p_method, const Variant * * p_args, int p_argcount, Callable::CallError & r_error) Line 418 C++
godot.windows.editor.dev.x86_64.exe!CallableCustomMethodPointer<EditorNode>::call(const Variant * * p_arguments, int p_argcount, Variant & r_return_value, Callable::CallError & r_call_error) Line 105 C++
godot.windows.editor.dev.x86_64.exe!Callable::callp(const Variant * * p_arguments, int p_argcount, Variant & r_return_value, Callable::CallError & r_call_error) Line 58 C++
godot.windows.editor.dev.x86_64.exe!Object::emit_signalp(const StringName & p_name, const Variant * * p_args, int p_argcount) Line 1128 C++
godot.windows.editor.dev.x86_64.exe!Object::emit_signal<>(const StringName & p_name) Line 922 C++
godot.windows.editor.dev.x86_64.exe!ProjectSettings::_emit_changed() Line 458 C++
godot.windows.editor.dev.x86_64.exe!call_with_variant_args_helper<ProjectSettings>(ProjectSettings * p_instance, void(ProjectSettings::*)() p_method, const Variant * * p_args, Callable::CallError & r_error, IndexSequence<> __formal) Line 308 C++
godot.windows.editor.dev.x86_64.exe!call_with_variant_args<ProjectSettings>(ProjectSettings * p_instance, void(ProjectSettings::*)() p_method, const Variant * * p_args, int p_argcount, Callable::CallError & r_error) Line 418 C++
godot.windows.editor.dev.x86_64.exe!CallableCustomMethodPointer<ProjectSettings>::call(const Variant * * p_arguments, int p_argcount, Variant & r_return_value, Callable::CallError & r_call_error) Line 105 C++
godot.windows.editor.dev.x86_64.exe!Callable::callp(const Variant * * p_arguments, int p_argcount, Variant & r_return_value, Callable::CallError & r_call_error) Line 58 C++
godot.windows.editor.dev.x86_64.exe!CallQueue::_call_function(const Callable & p_callable, const Variant * p_args, int p_argcount, bool p_show_error) Line 220 C++
godot.windows.editor.dev.x86_64.exe!CallQueue::flush() Line 326 C++
godot.windows.editor.dev.x86_64.exe!Main::iteration() Line 3615 C++
godot.windows.editor.dev.x86_64.exe!EditorNode::immediate_confirmation_dialog(const String & p_text, const String & p_ok_text, const String & p_cancel_text, unsigned int p_wrap_width) Line 5579 C++
godot.windows.editor.dev.x86_64.exe!SurfaceUpgradeTool::_show_popup() Line 89 C++
godot.windows.editor.dev.x86_64.exe!SurfaceUpgradeTool::_try_show_popup() Line 75 C++
godot.windows.editor.dev.x86_64.exe!RenderingServer::fix_surface_compatibility(RenderingServer::SurfaceData & p_surface, const String & p_path) Line 2138 C++
godot.windows.editor.dev.x86_64.exe!ArrayMesh::_set_surfaces(const Array & p_surfaces) Line 1643 C++
godot.windows.editor.dev.x86_64.exe!call_with_variant_args_helper<ArrayMesh,Array const &,0>(ArrayMesh * p_instance, void(ArrayMesh::*)(const Array &) p_method, const Variant * * p_args, Callable::CallError & r_error, IndexSequence<0> __formal) Line 303 C++
godot.windows.editor.dev.x86_64.exe!call_with_variant_args_dv<ArrayMesh,Array const &>(ArrayMesh * p_instance, void(ArrayMesh::*)(const Array &) p_method, const Variant * * p_args, int p_argcount, Callable::CallError & r_error, const Vector<Variant> & default_values) Line 451 C++
godot.windows.editor.dev.x86_64.exe!MethodBindT<ArrayMesh,Array const &>::call(Object * p_object, const Variant * * p_args, int p_arg_count, Callable::CallError & r_error) Line 337 C++
godot.windows.editor.dev.x86_64.exe!ClassDB::set_property(Object * p_object, const StringName & p_property, const Variant & p_value, bool * r_valid) Line 1235 C++
godot.windows.editor.dev.x86_64.exe!Object::set(const StringName & p_name, const Variant & p_value, bool * r_valid) Line 257 C++
godot.windows.editor.dev.x86_64.exe!ResourceLoaderBinary::load() Line 836 C++
godot.windows.editor.dev.x86_64.exe!ResourceFormatLoaderBinary::load(const String & p_path, const String & p_original_path, Error * r_error, bool p_use_sub_threads, float * r_progress, ResourceFormatLoader::CacheMode p_cache_mode) Line 1198 C++
godot.windows.editor.dev.x86_64.exe!ResourceLoader::_load(const String & p_path, const String & p_original_path, const String & p_type_hint, ResourceFormatLoader::CacheMode p_cache_mode, Error * r_error, bool p_use_sub_threads, float * r_progress) Line 261 C++
godot.windows.editor.dev.x86_64.exe!ResourceLoader::_thread_load_function(void * p_userdata) Line 319 C++
godot.windows.editor.dev.x86_64.exe!ResourceLoader::_load_start(const String & p_path, const String & p_type_hint, ResourceLoader::LoadThreadMode p_thread_mode, ResourceFormatLoader::CacheMode p_cache_mode) Line 501 C++
godot.windows.editor.dev.x86_64.exe!ResourceLoader::load(const String & p_path, const String & p_type_hint, ResourceFormatLoader::CacheMode p_cache_mode, Error * r_error) Line 418 C++
godot.windows.editor.dev.x86_64.exe!EditorResourcePreviewGenerator::generate_from_path(const String & p_path, const Vector2 & p_size, Dictionary & p_metadata) Line 68 C++
godot.windows.editor.dev.x86_64.exe!EditorResourcePreview::_generate_preview(Ref<ImageTexture> & r_texture, Ref<ImageTexture> & r_small_texture, const EditorResourcePreview::QueueItem & p_item, const String & cache_base, Dictionary & p_metadata) Line 159 C++
godot.windows.editor.dev.x86_64.exe!EditorResourcePreview::_iterate() Line 251 C++
godot.windows.editor.dev.x86_64.exe!EditorResourcePreview::_thread() Line 338 C++
godot.windows.editor.dev.x86_64.exe!EditorResourcePreview::_thread_func(void * ud) Line 103 C++
godot.windows.editor.dev.x86_64.exe!Thread::callback(unsigned __int64 p_caller_id, const Thread::Settings & p_settings, void(*)(void *) p_callback, void * p_userdata) Line 63 C++
[External Code]
godot.windows.editor.dev.x86_64.exe!thread_start<unsigned int (__cdecl*)(void *),1>(void * const parameter) Line 97 C++
```
### Steps to reproduce
Happens when opening a project that has many meshes. This occurred opening https://github.com/Malcolmnixon/TiltFiveMapTest
### Minimal reproduction project
It seems to be a russian-roulette with large projects - the project in the reproduce steps causes it. | https://github.com/godotengine/godot/issues/85202 | https://github.com/godotengine/godot/pull/85222 | bd74d92ef79031379a2010a0110b48e71c8f7ebc | ee14dc6ce5d9f72c25bad3337bb568997e09b6a8 | 2023-11-22T02:30:47Z | c++ | 2023-11-22T20:56:50Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,201 | ["editor/editor_node.cpp", "editor/editor_node.h", "editor/surface_upgrade_tool.cpp", "editor/surface_upgrade_tool.h"] | Crash during startup editing a project | ### Godot version
7022271291a3d2a9cbd6a223d22a29fd775dfc5d
### System information
Windows 11, gl_compatibility, NVidia RTX 3070 TI
### Issue description
Crash doing a memcpy to null doing the surface upgrade. The code in question is:
```c++
// Copy over all data needed for rendering.
glBindBuffer(GL_ARRAY_BUFFER, state.canvas_instance_data_buffers[state.current_data_buffer_index].instance_buffers[state.current_instance_buffer_index]);
#ifdef WEB_ENABLED
glBufferSubData(GL_ARRAY_BUFFER, state.last_item_index * sizeof(InstanceData), sizeof(InstanceData) * index, state.instance_data_array);
#else
// On Desktop and mobile we map the memory without synchronizing for maximum speed.
void *buffer = glMapBufferRange(GL_ARRAY_BUFFER, state.last_item_index * sizeof(InstanceData), index * sizeof(InstanceData), GL_MAP_WRITE_BIT | GL_MAP_UNSYNCHRONIZED_BIT);
memcpy(buffer, state.instance_data_array, index * sizeof(InstanceData));
glUnmapBuffer(GL_ARRAY_BUFFER);
#endif
```
The call stack is:
```
godot.windows.editor.dev.x86_64.exe!memcpy_repmovs() Line 40 Unknown
godot.windows.editor.dev.x86_64.exe!RasterizerCanvasGLES3::_render_items(RID p_to_render_target, int p_item_count, const Transform2D & p_canvas_transform_inverse, RendererCanvasRender::Light * p_lights, bool & r_sdf_used, bool p_to_backbuffer) Line 652 C++
godot.windows.editor.dev.x86_64.exe!RasterizerCanvasGLES3::canvas_render_items(RID p_to_render_target, RendererCanvasRender::Item * p_item_list, const Color & p_modulate, RendererCanvasRender::Light * p_light_list, RendererCanvasRender::Light * p_directional_light_list, const Transform2D & p_canvas_transform, RenderingServer::CanvasItemTextureFilter p_default_filter, RenderingServer::CanvasItemTextureRepeat p_default_repeat, bool p_snap_2d_vertices_to_pixel, bool & r_sdf_used) Line 549 C++
godot.windows.editor.dev.x86_64.exe!RendererCanvasCull::_render_canvas_item_tree(RID p_to_render_target, RendererCanvasCull::Canvas::ChildItem * p_child_items, int p_child_item_count, RendererCanvasCull::Item * p_canvas_item, const Transform2D & p_transform, const Rect2 & p_clip_rect, const Color & p_modulate, RendererCanvasRender::Light * p_lights, RendererCanvasRender::Light * p_directional_lights, RenderingServer::CanvasItemTextureFilter p_default_filter, RenderingServer::CanvasItemTextureRepeat p_default_repeat, bool p_snap_2d_vertices_to_pixel, unsigned int canvas_cull_mask) Line 73 C++
godot.windows.editor.dev.x86_64.exe!RendererCanvasCull::render_canvas(RID p_render_target, RendererCanvasCull::Canvas * p_canvas, const Transform2D & p_transform, RendererCanvasRender::Light * p_lights, RendererCanvasRender::Light * p_directional_lights, const Rect2 & p_clip_rect, RenderingServer::CanvasItemTextureFilter p_default_filter, RenderingServer::CanvasItemTextureRepeat p_default_repeat, bool p_snap_2d_transforms_to_pixel, bool p_snap_2d_vertices_to_pixel, unsigned int canvas_cull_mask) Line 382 C++
godot.windows.editor.dev.x86_64.exe!RendererViewport::_draw_viewport(RendererViewport::Viewport * p_viewport) Line 590 C++
godot.windows.editor.dev.x86_64.exe!RendererViewport::draw_viewports(bool p_swap_buffers) Line 772 C++
godot.windows.editor.dev.x86_64.exe!RenderingServerDefault::_draw(bool p_swap_buffers, double frame_step) Line 92 C++
godot.windows.editor.dev.x86_64.exe!RenderingServerDefault::draw(bool p_swap_buffers, double frame_step) Line 387 C++
godot.windows.editor.dev.x86_64.exe!Main::iteration() Line 3648 C++
godot.windows.editor.dev.x86_64.exe!EditorNode::immediate_confirmation_dialog(const String & p_text, const String & p_ok_text, const String & p_cancel_text, unsigned int p_wrap_width) Line 5579 C++
godot.windows.editor.dev.x86_64.exe!SurfaceUpgradeTool::_show_popup() Line 89 C++
godot.windows.editor.dev.x86_64.exe!SurfaceUpgradeTool::_try_show_popup() Line 75 C++
godot.windows.editor.dev.x86_64.exe!RenderingServer::fix_surface_compatibility(RenderingServer::SurfaceData & p_surface, const String & p_path) Line 2138 C++
godot.windows.editor.dev.x86_64.exe!ArrayMesh::_set_surfaces(const Array & p_surfaces) Line 1643 C++
godot.windows.editor.dev.x86_64.exe!call_with_variant_args_helper<ArrayMesh,Array const &,0>(ArrayMesh * p_instance, void(ArrayMesh::*)(const Array &) p_method, const Variant * * p_args, Callable::CallError & r_error, IndexSequence<0> __formal) Line 303 C++
godot.windows.editor.dev.x86_64.exe!call_with_variant_args_dv<ArrayMesh,Array const &>(ArrayMesh * p_instance, void(ArrayMesh::*)(const Array &) p_method, const Variant * * p_args, int p_argcount, Callable::CallError & r_error, const Vector<Variant> & default_values) Line 451 C++
godot.windows.editor.dev.x86_64.exe!MethodBindT<ArrayMesh,Array const &>::call(Object * p_object, const Variant * * p_args, int p_arg_count, Callable::CallError & r_error) Line 337 C++
godot.windows.editor.dev.x86_64.exe!ClassDB::set_property(Object * p_object, const StringName & p_property, const Variant & p_value, bool * r_valid) Line 1235 C++
godot.windows.editor.dev.x86_64.exe!Object::set(const StringName & p_name, const Variant & p_value, bool * r_valid) Line 257 C++
godot.windows.editor.dev.x86_64.exe!ResourceLoaderBinary::load() Line 836 C++
godot.windows.editor.dev.x86_64.exe!ResourceFormatLoaderBinary::load(const String & p_path, const String & p_original_path, Error * r_error, bool p_use_sub_threads, float * r_progress, ResourceFormatLoader::CacheMode p_cache_mode) Line 1198 C++
godot.windows.editor.dev.x86_64.exe!ResourceLoader::_load(const String & p_path, const String & p_original_path, const String & p_type_hint, ResourceFormatLoader::CacheMode p_cache_mode, Error * r_error, bool p_use_sub_threads, float * r_progress) Line 261 C++
godot.windows.editor.dev.x86_64.exe!ResourceLoader::_thread_load_function(void * p_userdata) Line 319 C++
godot.windows.editor.dev.x86_64.exe!ResourceLoader::_load_start(const String & p_path, const String & p_type_hint, ResourceLoader::LoadThreadMode p_thread_mode, ResourceFormatLoader::CacheMode p_cache_mode) Line 501 C++
godot.windows.editor.dev.x86_64.exe!ResourceLoader::load(const String & p_path, const String & p_type_hint, ResourceFormatLoader::CacheMode p_cache_mode, Error * r_error) Line 418 C++
godot.windows.editor.dev.x86_64.exe!EditorResourcePreviewGenerator::generate_from_path(const String & p_path, const Vector2 & p_size, Dictionary & p_metadata) Line 68 C++
godot.windows.editor.dev.x86_64.exe!EditorResourcePreview::_generate_preview(Ref<ImageTexture> & r_texture, Ref<ImageTexture> & r_small_texture, const EditorResourcePreview::QueueItem & p_item, const String & cache_base, Dictionary & p_metadata) Line 159 C++
godot.windows.editor.dev.x86_64.exe!EditorResourcePreview::_iterate() Line 251 C++
godot.windows.editor.dev.x86_64.exe!EditorResourcePreview::_thread() Line 338 C++
godot.windows.editor.dev.x86_64.exe!EditorResourcePreview::_thread_func(void * ud) Line 103 C++
godot.windows.editor.dev.x86_64.exe!Thread::callback(unsigned __int64 p_caller_id, const Thread::Settings & p_settings, void(*)(void *) p_callback, void * p_userdata) Line 63 C++
[External Code]
godot.windows.editor.dev.x86_64.exe!thread_start<unsigned int (__cdecl*)(void *),1>(void * const parameter) Line 97 C++
[External Code]
```
### Steps to reproduce
There's a demo project at https://github.com/Malcolmnixon/TiltFiveMapTest which produces the problem.
The first time its loaded without a .godot folder there are a bunch of assert failures on in vhacdVolume.h line 365.
### Minimal reproduction project
The link in the reproduce steps does it. I'm not sure about making anything smaller as it seems to require special circumstances to occur. | https://github.com/godotengine/godot/issues/85201 | https://github.com/godotengine/godot/pull/85222 | bd74d92ef79031379a2010a0110b48e71c8f7ebc | ee14dc6ce5d9f72c25bad3337bb568997e09b6a8 | 2023-11-22T02:13:24Z | c++ | 2023-11-22T20:56:50Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,152 | ["core/variant/variant_parser.cpp"] | Can't open scene missing tres external resource | ### Godot version
4.2 fa1fb2a
### System information
Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 30.0.15.1403) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)
### Issue description
I have a scene that has a dependency on a tres resource (doesn't matter type). You can't open it, there is parse error. In this case:
```
Cannot open file 'res://new_gradient_texture_2d.tres'.
Failed loading resource: res://new_gradient_texture_2d.tres. Make sure resources have been imported by opening the project in the editor at least once.
C:\godot_source\scene/resources/resource_format_text.cpp:284 - res://s.tscn:6 - Parse Error:
Failed loading resource: res://s.tscn. Make sure resources have been imported by opening the project in the editor at least once.
C:\godot_source\editor/editor_data.cpp:626 - Index p_idx = 1 is out of bounds (edited_scene.size() = 1).
```
A missing dependencies prompt shows normally, but pressing "Open Anyway" will just print the same errors and fail again. If an importable resource is missing (e.g. icon.svg), the scene will open normally.
### Steps to reproduce
1. Create scene
2. Add any text-based resource to it (GradientTexture for example)
3. Close the scene
4. Delete resource
5. Try to open the scene
### Minimal reproduction project
[s.tscn.txt](https://github.com/godotengine/godot/files/13419197/s.tscn.txt)
| https://github.com/godotengine/godot/issues/85152 | https://github.com/godotengine/godot/pull/85159 | 1f3c16dd1cd06e9d20df4c850467e9ae5d10cb84 | ea15b4ad44bd7ebc33ca4b2fa746cc117d12f20c | 2023-11-20T20:44:16Z | c++ | 2023-12-11T23:18:58Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,143 | ["editor/editor_node.cpp", "editor/editor_node.h", "servers/rendering/renderer_rd/renderer_compositor_rd.cpp"] | `--rendering-method` CLI arguments are not effective on the actual scene rendering, only on warning messages | ### Godot version
4.0.stable, 4.1.3.stable, 4.2.rc1
### System information
Fedora 38, GeForce RTX 4090 (NVIDIA 535.129.03)
### Issue description
`--rendering-method mobile` doesn't *actually* make a Forward+ project use the Mobile rendering method, even though the command line output says so.
### Project using Forward+ rendering method
### No CLI argument (use Forward+)
Looks like Forward+.
```
❯ bin/godot.linuxbsd.editor.x86_64 --path ~/Documents/Godot/test_rendering_method_cli_arguments
Godot Engine v4.2.rc.custom_build.368e87aa0 - https://godotengine.org
Vulkan API 1.3.242 - Forward+ - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce RTX 4090
```
### `--rendering-method mobile`
Looks like Forward+.
```
❯ bin/godot.linuxbsd.editor.x86_64 --path ~/Documents/Godot/test_rendering_method_cli_arguments --rendering-method mobile
Godot Engine v4.2.rc.custom_build.368e87aa0 - https://godotengine.org
Vulkan API 1.3.242 - Forward Mobile - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce RTX 4090
WARNING: SDFGI can only be enabled when using the Forward+ rendering backend.
at: environment_set_sdfgi (./servers/rendering/storage/environment_storage.cpp:652)
```
#### `--rendering-method gl_compatibility` (or `--rendering-driver opengl3`)
Looks like Compatibility.
```
❯ bin/godot.linuxbsd.editor.x86_64 --path ~/Documents/Godot/test_rendering_method_cli_arguments --rendering-method gl_compatibility
Godot Engine v4.2.rc.custom_build.368e87aa0 - https://godotengine.org
OpenGL API 3.3.0 NVIDIA 535.129.03 - Compatibility - Using Device: NVIDIA - NVIDIA GeForce RTX 4090
WARNING: SDFGI can only be enabled when using the Forward+ rendering backend.
at: environment_set_sdfgi (./servers/rendering/storage/environment_storage.cpp:652)
WARNING: Glow is not supported when using the GL Compatibility backend yet. Support will be added in a future release.
at: environment_set_glow (./servers/rendering/storage/environment_storage.cpp:387)
```
### Project using Mobile rendering method
### No CLI argument (use Mobile)
Looks like Mobile.
```
❯ bin/godot.linuxbsd.editor.x86_64 --path ~/Documents/Godot/test_rendering_method_cli_arguments
Godot Engine v4.2.rc.custom_build.368e87aa0 - https://godotengine.org
Vulkan API 1.3.242 - Forward Mobile - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce RTX 4090
WARNING: SDFGI can only be enabled when using the Forward+ rendering backend.
at: environment_set_sdfgi (./servers/rendering/storage/environment_storage.cpp:652)
```
### `--rendering-method forward_plus`
Looks like Mobile.
```
❯ bin/godot.linuxbsd.editor.x86_64 --path ~/Documents/Godot/test_rendering_method_cli_arguments --rendering-method forward_plus
Godot Engine v4.2.rc.custom_build.368e87aa0 - https://godotengine.org
Vulkan API 1.3.242 - Forward+ - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce RTX 4090
```
#### `--rendering-method gl_compatibility` (or `--rendering-driver opengl3`)
Looks like Compatibility.
```
❯ bin/godot.linuxbsd.editor.x86_64 --path ~/Documents/Godot/test_rendering_method_cli_arguments --rendering-driver opengl3
Godot Engine v4.2.rc.custom_build.368e87aa0 - https://godotengine.org
OpenGL API 3.3.0 NVIDIA 535.129.03 - Compatibility - Using Device: NVIDIA - NVIDIA GeForce RTX 4090
WARNING: SDFGI can only be enabled when using the Forward+ rendering backend.
at: environment_set_sdfgi (./servers/rendering/storage/environment_storage.cpp:652)
WARNING: Glow is not supported when using the GL Compatibility backend yet. Support will be added in a future release.
at: environment_set_glow (./servers/rendering/storage/environment_storage.cpp:387)
```
MRP visuals for reference:
Forward+ | Mobile | Compatibility
-|-|-
 |  | 
### Steps to reproduce
- Use `--rendering-method mobile` to [run a project from the command line](https://docs.godotengine.org/en/latest/tutorials/editor/command_line_tutorial.html) that uses Forward+ in its project settings.
- Alternatively, use `--rendering-method forward_plus` on a project that uses the Mobile rendering method.
### Minimal reproduction project
[test_rendering_method_cli_arguments.zip](https://github.com/godotengine/godot/files/13417650/test_rendering_method_cli_arguments.zip)
| https://github.com/godotengine/godot/issues/85143 | https://github.com/godotengine/godot/pull/85387 | a3024d0395915ad0f511db86a4397780d975872d | 4269a57b0cafd2fc4724de758002c68928f4586b | 2023-11-20T17:17:54Z | c++ | 2023-12-14T16:38:43Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,129 | ["editor/animation_bezier_editor.cpp", "editor/animation_track_editor.cpp", "editor/animation_track_editor.h", "editor/plugins/animation_player_editor_plugin.cpp", "editor/plugins/animation_player_editor_plugin.h"] | [Animation] For existing animations, iterating to next/previous step does not update 'frame' or 'animation' properties of Animated Sprite | ### Godot version
4.2 rc1
### System information
Windows 11
### Issue description
In projects with existing animations, cycling through next/previous steps in an animation, IN the editor, does not update the 'frame' or 'animation' properties for 'AnimatedSprite'.
The issue goes away if you create a new animation with duplicate functionality.
### Steps to reproduce
-
### Minimal reproduction project
Needs a project with existing animations made in the previous version. | https://github.com/godotengine/godot/issues/85129 | https://github.com/godotengine/godot/pull/85193 | 51bca1b586ca8f3d0f18eea6a9ef42a68c8fb3dc | ca245295aef490ddd13a443dd9af8cf1c05cbd80 | 2023-11-20T10:58:20Z | c++ | 2023-11-22T12:59:45Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,119 | ["scene/main/scene_tree.cpp"] | GPUParticles3D Spawn Incorrectly When Changing Scenes | ### Godot version
4.2 RC 1
### System information
Godot v4.2.rc1 - Windows 10.0.19045 - Vulkan (Forward+) - dedicated AMD Radeon RX 6700 XT (Advanced Micro Devices, Inc.; 31.0.21018.5001) - AMD Ryzen 5 5600X 6-Core Processor (12 Threads)
### Issue description
when using get_tree().change_scene_to_file(), all GPUParticles3D in the scene initially spawn at 0,0,0
this behavior only occurs when changing scenes, and not when initially booting the project from the scene.
https://github.com/godotengine/godot/assets/60982612/98709943-744e-4846-9ffc-0db3b09d9d91
In this video clip, the camera is near the 0,0,0 origin and all of the particles cover the screen upon reloading the scene
### Steps to reproduce
1. Create GPUParticles3D and have them emitting somewhere not at position 0,0,0
2. Reload the scene using get_tree().change_to_file()
### Minimal reproduction project
[4.2 rc1 particle issue.zip](https://github.com/godotengine/godot/files/13405847/4.2.rc1.particle.issue.zip) | https://github.com/godotengine/godot/issues/85119 | https://github.com/godotengine/godot/pull/85184 | 7022271291a3d2a9cbd6a223d22a29fd775dfc5d | fafc5c2e56b427c3dd0164e09c54c80e2544f468 | 2023-11-20T03:12:18Z | c++ | 2023-11-22T09:48:14Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,118 | ["editor/project_manager.cpp", "scene/main/window.cpp"] | Install Project popup's child controls reset their layout after changing project path, but the popup's size doesn't | ### Godot version
v4.2.rc1.official [ad72de508]
### System information
Godot v4.2.rc1 - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2080 Ti (NVIDIA; 30.0.14.7280) - Intel(R) Core(TM) i7-8700K CPU @ 3.70GHz (12 Threads)
### Issue description
When installing anything with a long name from the Asset Library Projects, the Install Project popup is wider than normal to fit the name comfortably in the popup.
However, when you browse into a different folder, it resets to the 4.1.x layout while keeping the larger window size.
This results in ghosts of the wider design still being visible to the right of the actual buttons. This is only a visual glitch and does not break the functionality of the popup, and the ghosts of the buttons to the right does not react to mouse input.
### Steps to reproduce
1. Open up Godot 4.2-rc1
2. Switch to Asset Library Projects
3. Search for "Shape Manipulation"
4. Click the asset "Shape Manipulation Basics - Line2D…"
5. Click download
6. Wait for download
7. Note the wide layout of the UI
8. Click Browse
9. Click Select Current Folder, you do not need to change folder to test this
Note that the layout is now narrower, but has the ghosts of the wider layout still showing.
The ghost elements are just a visual glitch and cannot be interacted with.
Besides the visual glitch the popup still functions as normal.
This was confirmed to not happen in version v4.1.1.stable.mono.official [bd6af8e0e], in this version the layout is never widened when picking an asset with a long name.
### Minimal reproduction project
None possible, the bug is in the Project Manager | https://github.com/godotengine/godot/issues/85118 | https://github.com/godotengine/godot/pull/85312 | 7c8dfea9e320b720a271a4e17bf9b8bda559375a | 36e033bce8666572a0e56d9de170aae995d5a157 | 2023-11-20T02:38:44Z | c++ | 2023-12-05T12:05:23Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,112 | ["modules/gdscript/gdscript.cpp", "modules/gdscript/gdscript.h", "modules/gdscript/gdscript_lambda_callable.h"] | Lambda/Callable memory leak | ### Godot version
v4.2.beta6.official [64150060f]
### System information
Godot v4.2.beta6 - Windows 10.0.19044 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 970 (NVIDIA; 31.0.15.3623) - Intel(R) Core(TM) i7-10700K CPU @ 3.80GHz (16 Threads)
### Issue description
Was testing benchmarks on the latest RC and this snippet started leaking memory as of 4.2beta6 up to the master branch. Does not happen in any version I tested from 4.1 stable to 4.2beta5.
https://github.com/godotengine/godot/assets/3820082/86283a44-2ce9-46a0-a60b-3365c016fca8
### Steps to reproduce
```gdscript
func _process(delta: float) -> void:
for i in 10000: (func(): randf()).call()
print(OS.get_static_memory_usage())
```
### Minimal reproduction project
N/A | https://github.com/godotengine/godot/issues/85112 | https://github.com/godotengine/godot/pull/85170 | 9c0692f30e01031dab1d83338320059a0983c421 | 9f5111e9288bb9325e50394ea73d66c94a67dfd8 | 2023-11-19T23:29:13Z | c++ | 2023-11-21T14:07:19Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,093 | ["editor/editor_node.cpp", "editor/editor_node.h"] | Editor crashes when saving built-in script with a non empty last line | ### Godot version
4.2.rc1
### System information
Godot v4.2.rc1 - Windows 10.0.22621 - GLES3 (Compatibility) - Intel(R) Iris(R) Plus Graphics (Intel Corporation; 27.20.100.9621) - Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz (8 Threads)
### Issue description
The editor crashes when saving a scene that contains a built-in script with a non empty last line.
The save always seem to take place anyway with an empty line added to the problematic script.
### Steps to reproduce
- Add a built-in script to a node
- Give it the script below
- Save the scene
```
extends Node
func _ready() -> void:
pass
```
### Minimal reproduction project
N/A | https://github.com/godotengine/godot/issues/85093 | https://github.com/godotengine/godot/pull/85154 | 1faf2f5bfe97edcb606d82b81094cb35e2b8e18c | 51bca1b586ca8f3d0f18eea6a9ef42a68c8fb3dc | 2023-11-19T15:45:57Z | c++ | 2023-11-22T12:59:37Z |
closed | godotengine/godot | https://github.com/godotengine/godot | 85,077 | ["editor/plugins/tiles/tile_map_editor.cpp"] | TileMap Painting by accident when switching between editor Select Mode (Q) and Move Mode (W) | ### Godot version
4.2 RC1
### System information
Windows 11
### Issue description
While working with the TileMap following a tutorial I've ran into several issues that turned out to be related to persistence of modes between tools (Select, Scale, Erase, and Move). I tried to write a report only to stumble on the reproduction steps, but solved most the issue myself when figuring out persistence of these modes.
The remaining bug I've identified is when in paint mode in the tilemap, select mode in the editor, where you paint a large line between move positions when using hotkeys to switch between move and select mode.
### Steps to reproduce
1) Pain a tile line of tiles (any direction or length)
2) Press W to switch to move mode while having not released the left mouse button
3) Let got of left mouse, use move mode drag the screen to a new position (method doesn't matter middles click or left mouse)
4) Press Q to switch editor to select mode.
5) A line will be created for the entire path you have move the mouse through, further you'll be stuck active painting where ever the mouse moves until you left click again.
I've also observed some others behaviors that are odd such as snap moving to the mouse position when transitioning to move mode. I suspect its related.
### Minimal reproduction project
N/A | https://github.com/godotengine/godot/issues/85077 | https://github.com/godotengine/godot/pull/86066 | f79f2ef801c5c0b8089c91e70219276b2f65ebe6 | a6c0c90058eb14bb14285ccf5eb6f99cbb8977b4 | 2023-11-19T05:28:39Z | c++ | 2023-12-14T16:38:57Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.