issue_id
int64 2.03k
426k
| title
stringlengths 9
251
| body
stringlengths 1
32.8k
⌀ | status
stringclasses 6
values | after_fix_sha
stringlengths 7
7
| updated_files
stringlengths 29
34.1k
| project_name
stringclasses 6
values | repo_url
stringclasses 6
values | repo_name
stringclasses 6
values | language
stringclasses 1
value | issue_url
null | before_fix_sha
null | pull_url
null | commit_datetime
timestamp[us, tz=UTC] | report_datetime
timestamp[us, tz=UTC] |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
82,914 | Bug 82914 [KeyBindings] performance: Too many MissingResourceException from NativeKeyFormatter | I'm trying to debug Eclipse plugins in Eclipse 3.1, and I have *tons* of MissingResourceException from NativeKeyFormatter (I have added exception breakpoint on RuntimeException). Here is the stack trace from debugger: Thread [main] (Suspended (exception MissingResourceException)) PropertyResourceBundle(ResourceBundle).getObject(String) line: 326 PropertyResourceBundle(ResourceBundle).getString(String) line: 286 Util.translateString(ResourceBundle, String, String, boolean, boolean) line: 453 NativeKeyFormatter(AbstractKeyFormatter).format(Key) line: 66 NativeKeyFormatter.format(Key) line: 123 NativeKeyFormatter(AbstractKeyFormatter).format(KeyStroke) line: 110 NativeKeyFormatter(AbstractKeyFormatter).format(KeySequence) line: 79 KeySequence.format() line: 272 CommandCallback.getAcceleratorText(String) line: 170 ActionContributionItem.update(String) line: 792 SubContributionItem.update(String) line: 160 MenuManager.update(String) line: 680 MenuManager.update(String) line: 680 Workbench.updateActiveWorkbenchWindowMenuManager(boolean) line: 2070 Workbench.access$0(Workbench, boolean) line: 2058 Workbench$3.windowActivated(IWorkbenchWindow) line: 2042 Workbench$8.run() line: 406 InternalPlatform.run(ISafeRunnable) line: 1007 Platform.run(ISafeRunnable) line: 747 Workbench.fireWindowActivated(IWorkbenchWindow) line: 404 WorkbenchWindow$5.shellActivated(ShellEvent) line: 2215 TypedListener.handleEvent(Event) line: 163 EventTable.sendEvent(Event) line: 82 Shell(Widget).sendEvent(Event) line: 833 Shell(Widget).sendEvent(int, Event, boolean) line: 857 Shell(Widget).sendEvent(int) line: 838 Shell(Decorations).WM_ACTIVATE(int, int) line: 1507 Shell.WM_ACTIVATE(int, int) line: 1444 Shell(Control).windowProc(int, int, int, int) line: 3016 Shell(Decorations).windowProc(int, int, int, int) line: 1483 Display.windowProc(int, int, int, int) line: 3376 OS.PeekMessageW(MSG, int, int, int, int) line: not available [native method] OS.PeekMessage(MSG, int, int, int, int) line: 1999 Display.readAndDispatch() line: 2449 Workbench.runEventLoop(Window$IExceptionHandler, Display) line: 1577 Workbench.runUI() line: 1543 Workbench.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 287 PlatformUI.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 144 IDEApplication.run(Object) line: 102 PlatformActivator$1.run(Object) line: 220 EclipseStarter.run(Object) line: 274 EclipseStarter.run(String[], Runnable) line: 129 NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method] NativeMethodAccessorImpl.invoke(Object, Object[]) line: 39 DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: 25 Method.invoke(Object, Object...) line: 585 Main.basicRun(String[]) line: 255 Main.run(String[]) line: 811 Main.main(String[]) line: 795 The problem is, that NativeKeyFormatter tries to get internationalized keys for all possible key strokes for many menu entries in Eclipse, and for most of them (like ',', 'A', 'B', 'C', ... , 'Z') there is no translation in resource bundle. Ergo => ResourceBundle create and throws every time a new MissingResourceException, which will be ignored by NativeKeyFormatter and this happens *every time* on *every* mouse/key move in Eclipse. Two reasons to fix this behavoir: 1) Create and throw an exception is costly - it takes time and memory. In this case, this happens on *every* typeEvent and is therefore *very* bad for Eclipse editor performance. 2) I can't filter out *my* RuntimeExceptions because there are simply too many MissingResourceException from AbstractKeyFormatter. I would propose simply remember missing keys in internal cache of org.eclipse. ui.internal.util.Util class (or wherever it could be stored) and do not ask PropertyResourceBundle any time for key, if this key is already in "MissingKeysCache". eclipse.buildId=I200411050810 java.runtime.version=1.5.0_01-b08 osgi.nl=de_DE osgi.os=win32 | verified fixed | 9712355 | ["bundles/org.eclipse.jface/src/org/eclipse/jface/bindings/keys/formatting/AbstractKeyFormatter.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-18T19:39:00Z | 2005-01-15T17:26:40Z |
91,747 | Bug 91747 [ViewMgmt] [EditorMgmt] IWorkbenchPart.createPartControl refers to non-existent interfaces | build I20050413 IWorkbenchPart.createPartControl's Javadoc has: * <li>Register any global actions with the <code>IActionService</code>.</li> * <li>Register any popup menus with the <code>IActionService</code>.</li> * <li>Register a selection provider with the <code>ISelectionService</code> * (optional). </li> There is no such interface IActionService. | verified fixed | 9c8281c | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/IWorkbenchPart.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-18T15:26:29Z | 2005-04-18T16:00:00Z |
91,462 | Bug 91462 [Wizards] WizardDialog Javadoc Typo | The Javadoc for WizardDialog.aboutToStart says "tiggered" instead of "triggered". | verified fixed | 55dbe95 | ["bundles/org.eclipse.jface/src/org/eclipse/jface/wizard/WizardDialog.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-15T19:35:12Z | 2005-04-14T20:20:00Z |
91,384 | Bug 91384 [Preferences] CCE in FileEditorsPreferencePage.createContents when running automated tests | build I20050413-0910 Looking through the console output for this build, I saw the following during: org.eclipse.ui.tests.UiTestSuite. The File Associations pref page comes up OK in the build though. [java] !ENTRY org.eclipse.jface 4 2 2005-04-13 13:17:14.682 [java] !MESSAGE Problems occurred when invoking code from plug-in: "org.eclipse.jface". [java] !STACK 0 [java] java.lang.ClassCastException [java] at org.eclipse.ui.internal.dialogs.FileEditorsPreferencePage.createContents(FileEditorsPreferencePage.java:167) [java] at org.eclipse.jface.preference.PreferencePage.createControl(PreferencePage.java:423) [java] at org.eclipse.jface.preference.PreferencePage.createControl(PreferencePage.java:388) [java] at org.eclipse.jface.preference.PreferenceDialog.createPageControl(PreferenceDialog.java:1407) [java] at org.eclipse.jface.preference.PreferenceDialog$13.run(PreferenceDialog.java:1119) [java] at org.eclipse.core.internal.runtime.InternalPlatform.run(InternalPlatform.java:1021) [java] at org.eclipse.core.runtime.Platform.run(Platform.java:757) [java] at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:40) [java] at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:148) [java] at org.eclipse.jface.preference.PreferenceDialog.showPage(PreferenceDialog.java:1113) [java] at org.eclipse.ui.tests.dialogs.PreferenceDialogWrapper.showPage(PreferenceDialogWrapper.java:26) [java] at org.eclipse.ui.tests.dialogs.UIPreferencesAuto.getPreferenceDialog(UIPreferencesAuto.java:94) [java] at org.eclipse.ui.tests.dialogs.UIPreferencesAuto.testFileEditorsPref(UIPreferencesAuto.java:165) [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [java] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [java] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [java] at java.lang.reflect.Method.invoke(Method.java:324) | verified fixed | c7a5e8b | ["tests/org.eclipse.ui.tests/Eclipse", "UI", "Tests/org/eclipse/ui/tests/dialogs/PreferenceDialogWrapper.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-15T18:22:59Z | 2005-04-14T09:13:20Z |
89,637 | Bug 89637 [RCP] Need regression test for new advisor saveState/restoreState APIs | null | verified fixed | 5b329a2 | ["tests/org.eclipse.ui.tests.rcp/Eclipse", "RCP", "Tests/org/eclipse/ui/tests/rcp/RcpTestSuite.java", "tests/org.eclipse.ui.tests.rcp/Eclipse", "RCP", "Tests/org/eclipse/ui/tests/rcp/WorkbenchSaveRestoreStateTest.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-14T14:07:34Z | 2005-03-30T19:13:20Z |
91,387 | Bug 91387 [DynamicUI] NPE in WorkbenchWindow$1.addExtension | build I20050413-0910 While looking through the console output for this build, I saw the following. If this exception is thrown deliberately for the tests, its message should flag it as such. !ENTRY org.eclipse.ui 4 4 2005-04-13 13:18:41.746 [java] !MESSAGE Exception in org.eclipse.ui.internal.registry.UIExtensionTracker$2.doAdd: java.lang.NullPointerException [java] Exception in org.eclipse.ui.internal.registry.UIExtensionTracker$2.doAdd: java.lang.NullPointerException [java] Reason: [java] !ENTRY org.eclipse.ui 4 4 2005-04-13 13:18:41.746 [java] !MESSAGE Exception in org.eclipse.ui.internal.registry.UIExtensionTracker$2.doAdd: java.lang.NullPointerException [java] !STACK 0 [java] java.lang.NullPointerException [java] at org.eclipse.ui.internal.WorkbenchWindow$1.addExtension(WorkbenchWindow.java:404) [java] at org.eclipse.ui.internal.registry.UIExtensionTracker$2.run(UIExtensionTracker.java:58) [java] at org.eclipse.ui.internal.UILockListener.doPendingWork(UILockListener.java:150) [java] at org.eclipse.ui.internal.UISynchronizer$1.run(UISynchronizer.java:36) [java] at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) [java] at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:118) [java] at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:2872) [java] at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2531) [java] at org.eclipse.ui.tests.util.UITestCase.processEvents(UITestCase.java:155) [java] at org.eclipse.ui.tests.dynamicplugins.DynamicTestCase.getBundle(DynamicTestCase.java:99) [java] at org.eclipse.ui.tests.dynamicplugins.ActionSetTests.testActionSets(ActionSetTests.java:42) [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [java] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [java] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [java] at java.lang.reflect.Method.invoke(Method.java:324) [java] at junit.framework.TestCase.runTest(TestCase.java:154) [java] at junit.framework.TestCase.runBare(TestCase.java:127) [java] at junit.framework.TestResult$1.protect(TestResult.java:106) [java] at junit.framework.TestResult.runProtected(TestResult.java:124) [java] at junit.framework.TestResult.run(TestResult.java:109) [java] at junit.framework.TestCase.run(TestCase.java:118) [java] at junit.framework.TestSuite.runTest(TestSuite.java:208) [java] at junit.framework.TestSuite.run(TestSuite.java:203) [java] at junit.framework.TestSuite.runTest(TestSuite.java:208) [java] at junit.framework.TestSuite.run(TestSuite.java:203) [java] at junit.framework.TestSuite.runTest(TestSuite.java:208) [java] at junit.framework.TestSuite.run(TestSuite.java:203) [java] at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:313) [java] at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:199) [java] at org.eclipse.test.UITestApplication$3.run(UITestApplication.java:188) [java] at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) [java] at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:118) [java] at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:2872) [java] at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2531) [java] at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1570) [java] at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1534) [java] at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:306) [java] at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:143) [java] at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:103) [java] Exception in org.eclipse.ui.internal.registry.UIExtensionTracker$2.doAdd: java.lang.NullPointerException [java] at org.eclipse.test.UITestApplication.runApplication(UITestApplication.java:131) [java] at org.eclipse.test.UITestApplication.run(UITestApplication.java:58) [java] at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:228) [java] at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344) [java] at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:156) [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [java] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [java] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [java] at java.lang.reflect.Method.invoke(Method.java:324) [java] at org.eclipse.core.launcher.Main.invokeFramework(Main.java:316) [java] at org.eclipse.core.launcher.Main.basicRun(Main.java:269) [java] at org.eclipse.core.launcher.Main.run(Main.java:948) [java] at org.eclipse.core.launcher.Main.main(Main.java:932) [java] testActionSets: tearDown... [java] ----- testActionSetPartAssociations [java] testActionSetPartAssociations: setUp... [java] !ENTRY org.eclipse.ui 4 4 2005-04-13 13:18:44.184 [java] !MESSAGE Exception in org.eclipse.ui.internal.registry.UIExtensionTracker$2.doAdd: java.lang.NullPointerException [java] !ENTRY org.eclipse.ui 4 4 2005-04-13 13:18:44.184 [java] !MESSAGE Exception in org.eclipse.ui.internal.registry.UIExtensionTracker$2.doAdd: java.lang.NullPointerException [java] !STACK 0 [java] java.lang.NullPointerException [java] at org.eclipse.ui.internal.WorkbenchWindow$1.addExtension(WorkbenchWindow.java:404) [java] at org.eclipse.ui.internal.registry.UIExtensionTracker$2.run(UIExtensionTracker.java:58) [java] at org.eclipse.ui.internal.UILockListener.doPendingWork(UILockListener.java:150) [java] at org.eclipse.ui.internal.UISynchronizer$1.run(UISynchronizer.java:36) [java] at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) [java] at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:118) [java] at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:2872) [java] at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2531) [java] at org.eclipse.ui.tests.util.UITestCase.processEvents(UITestCase.java:155) [java] at org.eclipse.ui.tests.dynamicplugins.DynamicTestCase.getBundle(DynamicTestCase.java:99) [java] at org.eclipse.ui.tests.dynamicplugins.ActionSetTests.testActionSetPartAssociations(ActionSetTests.java:81) [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [java] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [java] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [java] at java.lang.reflect.Method.invoke(Method.java:324) [java] at junit.framework.TestCase.runTest(TestCase.java:154) [java] at junit.framework.TestCase.runBare(TestCase.java:127) [java] at junit.framework.TestResult$1.protect(TestResult.java:106) [java] at junit.framework.TestResult.runProtected(TestResult.java:124) [java] at junit.framework.TestResult.run(TestResult.java:109) [java] at junit.framework.TestCase.run(TestCase.java:118) [java] at junit.framework.TestSuite.runTest(TestSuite.java:208) [java] at junit.framework.TestSuite.run(TestSuite.java:203) [java] at junit.framework.TestSuite.runTest(TestSuite.java:208) [java] at junit.framework.TestSuite.run(TestSuite.java:203) [java] at junit.framework.TestSuite.runTest(TestSuite.java:208) [java] at junit.framework.TestSuite.run(TestSuite.java:203) [java] at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:313) [java] at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:199) [java] at org.eclipse.test.UITestApplication$3.run(UITestApplication.java:188) [java] at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) [java] at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:118) [java] at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:2872) [java] at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2531) [java] at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1570) [java] at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1534) [java] at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:306) [java] Exception in org.eclipse.ui.internal.registry.UIExtensionTracker$2.doAdd: java.lang.NullPointerException [java] at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:143) [java] Reason: [java] at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:103) [java] Exception in org.eclipse.ui.internal.registry.UIExtensionTracker$2.doAdd: java.lang.NullPointerException [java] at org.eclipse.test.UITestApplication.runApplication(UITestApplication.java:131) [java] at org.eclipse.test.UITestApplication.run(UITestApplication.java:58) [java] at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:228) [java] at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344) [java] at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:156) [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [java] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [java] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [java] at java.lang.reflect.Method.invoke(Method.java:324) [java] at org.eclipse.core.launcher.Main.invokeFramework(Main.java:316) [java] at org.eclipse.core.launcher.Main.basicRun(Main.java:269) [java] at org.eclipse.core.launcher.Main.run(Main.java:948) [java] at org.eclipse.core.launcher.Main.main(Main.java:932) [java] testActionSetPartAssociations: tearDown... | verified fixed | 3e5ebc5 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/WorkbenchWindow.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-14T10:45:06Z | 2005-04-14T09:13:20Z |
81,076 | Bug 81076 [Preferences] Project properties dialog: tree needs a border | M4 test pass Project properties dialog: the tree on the left hand needs a border. | verified fixed | a8f286b | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/dialogs/FilteredPreferenceDialog.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/dialogs/PropertyDialog.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-13T20:06:08Z | 2004-12-15T11:26:40Z |
90,073 | Bug 90073 [Viewers] AbstractTreeViewer.add method slow for elements added at end | When implementing deferred loading for the TreeViewer I stumbled upon serious performance problems in the AbstractTreeViewer.add(Object parentElement, Object[] childElements) method. The amount of time this method takes grows exponentially with the size of the childElements array. After profiling it turns out that the problem is that the method is not optimized for loading multiple elements. It essentially adds each element separately. The main problem is that getItems(Item) method is called several times for each element in the childElements array. This method sends message to native Windows control to get children for a given item. The time it takes for getItems to execute grows exponentially with the each item added. We do not have control over the performance of the native widgets but we can optimize calls to them. I created OptimizedTreeViewer class that overrides the internalAdd method and uses a single call to getItems to load all the children. The difference in performance is huge. To add 5000 items in the original tree is ~10 sec with my implementation it takes less then 1 sec. The optimized class below. Thanks. Dimitry Fayerman /* Copyright 2005 Wyeth. All Rights Reserved. */ package com.wyeth.clinical.rcp.common; import java.util.Arrays; import java.util.Comparator; import java.util.HashMap; import java.util.Map; import org.eclipse.jface.viewers.TreeViewer; import org.eclipse.jface.viewers.ViewerSorter; import org.eclipse.swt.widgets.Composite; import org.eclipse.swt.widgets.Control; import org.eclipse.swt.widgets.Item; import org.eclipse.swt.widgets.Tree; import org.eclipse.swt.widgets.Widget; /** * The TreeViewer descendant that optimizes loading multiple the child elements * for a tree node (method * <code>add(Object parentElement, Object[] childElements)</code>). * <p> * This method is called in particular by the DeferredContentProvider to load * child elements asynchronosely. In this class the optimized method is 5 times * faster. * * @author Dimitry Fayerman (DF) * @version $Revision: 1.1 $, $Date: 2005/04/01 22:15:02 $ * @lastModifiedBy $Author: dfayerma $ */ public class OptimizedTreeViewer extends TreeViewer { // ========================================================================= // Static Attributes // ========================================================================= // ========================================================================= // Static Methods // ========================================================================= // ========================================================================= // Static Classes // ========================================================================= // ========================================================================= // Attributes // ========================================================================= /** * Indicates if this object should match newly added child elements to the * existing elements and if match found just refresh the existing nodes. * This is needed to make it compitable with current TreeViewer * implementation but comes with the performance overhead. By default this * option is disabled end can be enabled by calling * <code>setSupportMultipleEqualElements()</code> method. */ private boolean supportMultipleEqualElements = false; // ========================================================================= // Constructors // ========================================================================= /** * Creates a tree viewer on a newly-created tree control under the given * parent. The tree control is created using the SWT style bits * <code>MULTI, H_SCROLL, V_SCROLL,</code> and <code>BORDER</code>. The * viewer has no input, no content provider, a default label provider, no * sorter, and no filters. * * @param parent * the parent control */ public OptimizedTreeViewer(Composite parent) { super(parent); } /** * Creates a tree viewer on a newly-created tree control under the given * parent. The tree control is created using the given SWT style bits. The * viewer has no input, no content provider, a default label provider, no * sorter, and no filters. * * @param parent * the parent control * @param style * the SWT style bits used to create the tree. */ public OptimizedTreeViewer(Composite parent, int style) { super(parent, style); } /** * Creates a tree viewer on the given tree control. The viewer has no input, * no content provider, a default label provider, no sorter, and no filters. * * @param tree * the tree control */ public OptimizedTreeViewer(Tree tree) { super(tree); } // ========================================================================= // Methods // ========================================================================= /** * Indicates if this object should match newly added child elements to the * existing elements and if match found just refresh the existing nodes. * This is needed to make it compitable with current TreeViewer * implementation but comes with the performance overhead. By default this * option is disabled end can be enabled by calling * <code>setSupportMultipleEqualElements()</code> method. * * @return <code>true</code> if multiple equal elements are examined in * the add method. */ public boolean isSupportingMultipleEqualElements() { return supportMultipleEqualElements; } /** * Sets flag indicating if this object should match newly added child * elements to the existing elements and if match found just refresh the * existing nodes. This is needed to make it compitable with current * TreeViewer implementation but comes with the performance overhead. By * default this option is disabled end can be enabled by calling * <code>setSupportMultipleEqualElements()</code> method. * * @param value * the new value for the attribute */ public void setSupportMultipleEqualElements(boolean value) { this.supportMultipleEqualElements = value; } /** * Add multiple child elements to a given parent element. This method is * optimized by reducing number of costly calls to getItems(Item) method. In * the original implementation the getItems() is called several times for * each element being added. This implementation perfroms only one call to * getItems(Item) * * * @param widget * the Tree or parent Item to add children to * @param parentElement * the parent domain object * @param childElements * the array of domain objects to add to the parent */ protected void internalAdd( Widget widget, Object parentElement, Object[] childElements) { Control tree = getControl(); if (childElements.length > 0) { Object[] filtered = filter(childElements); Item[] items = getChildren(widget); if (supportMultipleEqualElements) { filtered = refreshMatchingAddedElements(widget, items, filtered); } createAddedElements(widget, items, filtered); } } /** * Refreshes items that correspond to elements in additions array. And * returns array of additions that did not match elements associated with * existing items. * * @param parent * the parent Tree or Item * @param items * the array of existing child items of the parent * @param additions * the array of objects to add. * @return the array that contains unique objects in the addition attribute * that did not match elements associated with Items in the items * array. */ private Object[] refreshMatchingAddedElements( Widget parent, Item[] items, Object[] additions) { // Add additions to the HashMap for faster lookup and to ensure // uniqueness. Map additionsMap = new HashMap(additions.length); for (int i = 0; i < additions.length; i++) { additionsMap.put(additions[i], additions[i]); } additionsMap.remove(parent.getData()); // If any of the new elements match an element associated with existing // items, refresh the item and skip adding the element for (int i = 0; i < items.length; i++) { Object match = additionsMap.remove(items[i].getData()); if (match != null) { // refresh the element in case it has new children refresh(match); } } if (additionsMap.size() == additions.length) { // we did not remove anything, just return the original array return additions; } else { // to preserve the order we have to drive from original array Object[] result = new Object[additionsMap.size()]; for (int i = 0, k = 0; i < additions.length; i++) { if (additionsMap.containsKey(additions[i])) { result[k] = additions[i]; k++; } } return result; } } /** * Create the new elements in the parent widget. * * @param widget * the parent Tree or Item * @param items * the array of existing child items * @param elements * the elements to add. * */ private void createAddedElements( Widget widget, Item[] items, Object[] elements) { final ViewerSorter sorter = getSorter(); // If we have sorter, sort elements to add // This way when calling indexForElement we do not have to worry about // new elements. if (sorter != null) { Arrays.sort(elements, new Comparator() { public int compare(Object o1, Object o2) { return sorter.compare(OptimizedTreeViewer.this, o1, o2); } }); } int position = 0; for (int i = 0; i < elements.length; i++) { Object element = elements[i]; position = indexForElement(items, position, element); createTreeItem(widget, element, position + i); } } /** * Returns the index where the item should be inserted. It uses sorter to * determine the correct position, if sorter is not assigned, returns the * index of the element after the last. * * @param items * the existing items * @param startIndex * the start index to start search for position from this allows * optimising search for multiple elements that are sorted * themself. * @param element * element to find position for. * @return the index to use when inserting the element. * */ protected int indexForElement(Item[] items, int startIndex, Object element) { ViewerSorter sorter = getSorter(); if (sorter == null) { return items.length; } int count = items.length; int min = startIndex, max = count - 1; while (min <= max) { int mid = (min + max) / 2; Object data = items[mid].getData(); int compare = sorter.compare(this, data, element); if (compare == 0) { // find first item > element while (compare == 0) { ++mid; if (mid >= count) { break; } data = items[mid].getData(); compare = sorter.compare(this, data, element); } return mid; } if (compare < 0) min = mid + 1; else max = mid - 1; } return min; } // ========================================================================= // Inner classes // ========================================================================= } | verified fixed | 9478b23 | ["bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/AbstractTreeViewer.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-13T15:35:24Z | 2005-04-02T05:33:20Z |
91,137 | Bug 91137 hashCode() + equals() inefficiencies | null | verified fixed | 93a9ee7 | ["bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/Parameterization.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/commands/HandlerSubmission.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/commands/Priority.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/contexts/EnabledSubmission.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/activities/Activity.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/activities/ActivityDefinition.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/activities/ActivityPatternBinding.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/activities/ActivityPatternBindingDefinition.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/activities/ActivityRequirementBinding.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/activities/ActivityRequirementBindingDefinition.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/activities/Category.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/activities/CategoryActivityBinding.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/activities/CategoryActivityBindingDefinition.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/activities/CategoryDefinition.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/activities/Identifier.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/keys/KeySequenceBinding.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/misc/AcceleratorHook.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/misc/CheckboxDoubleListGroup.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/misc/OverlayComposite.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/misc/Stopwatch.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/misc/TestPageListener.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/misc/TestSelectionListener.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/misc/UIHackFinder.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/misc/Workbook.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/misc/WorkbookPage.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-12T19:36:13Z | 2005-04-12T15:33:20Z |
90,521 | Bug 90521 [Import/Export] NumberFormatException during import zip file | null | verified fixed | 9351720 | ["bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/DataTransferMessages.java", "bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/TarException.java", "bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/datatransfer/TarInputStream.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-11T21:11:56Z | 2005-04-06T20:40:00Z |
90,651 | Bug 90651 [Import/Export][Preferences] Unused messages in WorkbenchMessages | WorkbenchMessages in org.eclipse.ui.workbench, from HEAD, has the following unused messages. It looks like someone made changes to import/export but forgot to update/remove the corresponding messages. ActionSetRegistry_otherCategory ImportExportPages_browseButton ImportExportPages_deselectAll ImportExportPages_errorDirectoryDoesNotExist ImportExportPages_errorImportFileDoesNotExist ImportExportPages_exportFileSelect ImportExportPages_exportSettingsSelect ImportExportPages_exportTitle ImportExportPages_exportWindowTitle ImportExportPages_fileLabel ImportExportPages_importFileSelect ImportExportPages_importSettingsSelect ImportExportPages_importTitle ImportExportPages_importWindowTitle ImportExportPages_invertSelection ImportExportPages_name ImportExportPages_preferenceFileName ImportExportPages_selectAll ImportExportPages_value EditorManager_editorInputIncorrect EditorPane_errorMessage PreferencesExportDialog_ExportDialogTitle PreferencesExportDialog_ErrorDialogMessage PreferencesExportDialog_ConfigurationScope PreferencesExportDialog_PreferencesListLabel PreferencesExportDialog_SelectMessage PreferencesExportDialog_WorkspaceScope PreferencesExportDialog_PluginLabel | verified fixed | 874b165 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/WorkbenchMessages.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-11T20:47:55Z | 2005-04-07T16:06:40Z |
90,508 | Bug 90508 [RCP] [Progress] NullPointerException in ProgressManagerUtil.java | A NullPointerException is thrown in ProgressManagerUtil.java when and RCP application overrides createWindowContents and does not provide/specify a progress region. Code snippet to reproduce the problem to follow. | verified fixed | 27fad43 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/progress/ProgressManagerUtil.java", "tests/org.eclipse.ui.tests.rcp/Eclipse", "RCP", "Tests/org/eclipse/ui/tests/rcp/WorkbenchAdvisorTest.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-11T20:31:24Z | 2005-04-06T17:53:20Z |
89,406 | Bug 89406 [WorkbenchParts] OpenCloseEditorTest failing | null | resolved wontfix | d9fb1b7 | ["tests/org.eclipse.ui.tests/Eclipse", "UI", "Tests/org/eclipse/ui/tests/performance/OpenCloseEditorTest.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-11T18:11:25Z | 2005-03-29T21:00:00Z |
89,034 | Bug 89034 [ActivityMgmt] Activities javadoc issues | Should ITriggerPointManager#UNKNOWN_TRIGGER be deprecated? WorkbenchActivityHelper#allowUseOf is deprecated and new - can it be deleted? ActivityCategoryPreferencePage needs more javadoc | verified fixed | 6bb18b0 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/activities/ActivityCategoryPreferencePage.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-07T20:44:54Z | 2005-03-24T18:46:40Z |
90,698 | Bug 90698 [EditorMgmt] FileEditorInput.getStorage() API change | Eclipse 3.1 M6 FileEditorInput.getStorage() has changed to no longer throw a CoreException. Since this class is public this is a breaking API change. Workaround is to cast the FileEditorInput to an IFileEditorInput. | verified fixed | 3ff64eb | ["bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/part/FileEditorInput.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-07T20:40:40Z | 2005-04-07T18:53:20Z |
88,926 | Bug 88926 [Preferences] IDE should subclass FileEditorsPreferencePage | Currently the link to the content types editor page lives in Workbench despite the target living in IDE. This should be resolved for 3.1 | verified fixed | 8cde525 | ["bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDEWorkbenchMessages.java", "bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/ContentTypesPreferencePage.java", "bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/NewContentTypeFileAssociationDialog.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/WorkbenchMessages.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/dialogs/ContentTypesPreferencePage.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/dialogs/NewContentTypeFileAssociationDialog.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-07T20:35:02Z | 2005-03-23T20:33:20Z |
66,497 | Bug 66497 All projects deletion triggers full workspace reindexing | Build RC1 Tracing transient memory allocation, I observed that when selecting all (binary linked) projects from a self-hosting workspace, lots of memory was allocated due to Java indexing activity. Looking deeper, I observed that the PDE container was being reset as soon as notified from resource deletions (likely to compensate project deletion, and rebinding using the target platform material instead). From our end, these classpath settings are trusted and honoured, thus inducing major model refresh, and index rebuilds. However, the updated projects are all being deleted as well, since I selected them all for deletion. So PDE seems to induce tons of work for no reason. You could check the PRE_DELETE event, so as to figure the list of projects which are pointless to update since going to be discarded anyway. | verified fixed | e558b91 | ["bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/actions/DeleteResourceAction.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-07T20:05:46Z | 2004-06-10T12:20:00Z |
88,653 | Bug 88653 [Commands] performance: 50% of perspective switch in ParameterizedCommand.equals() | Build: I20050315 Setup: 1) Workspace with three projects, org.eclipse.jdt.core, org.eclipse.swt, and org.eclipse.swt.win32 2) Editor open on org.eclipse.jdt.internal.compiler.parser.Parser.java 3) Default Java perspective and Resource perspective open My test was to switch between the two open perspectives about five times using Ctrl+F8. The profiler showed 50% of the time in ParameterizedCommand.equals() and in the methods called by that equals implementation (Util.equals() and Command.equals()). The main problem is probably in the number of times this method is called (about 1.6 million times). This seems to be caused by a large number of property change events: ExternalActionManager$CommandCallback.bindingManagerChanged is called 30 times. This in turn calls ActionContributionItem$1.propertyChange, which is called 4787 times. The number of method calls explodes as you go down the call stack, until the equals method that is called 1.6 million times. I will attach profiler output to show more details. If the number of change events can't be reduced, it looks like the implementation of ParameterizedCommand.equals() can be made faster by first comparing the cached hash code. Only if the hash codes are the same does it need to do the remainder of the equality testing. | verified fixed | 2cd3413 | ["bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/Category.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/Command.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/ParameterizedCommand.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-07T19:56:58Z | 2005-03-21T15:46:40Z |
58,930 | Bug 58930 [About] Unable to open web browser: Help->About Eclipse Platform->Feature Details->More Info | Platforms: Solaris 9 and HP-UX11.11 Eclipse 3.0M8, Build Id: 200403261517 First I will prove that I can open the web browser via Eclipse Help: - Go to Window->Preferences->Help. Enter in the browser's path and command (e.g <path>/netscape %1) into "Customer Browser command". Click OK. - Go to Help->Help Contents. The browser opens with Eclipse Help System content. The browser is working O.K. I now go to Help again: - Help->About Eclipse Platform->Feature Details. Select an item and click 'More Info'. An error dialog box comes up with an "Unable to open web browser" message. Same with Help->About Eclipse Platform->Plug-in Details Is there any place on Eclipse that I can set the 'More Info' web browser preference? | resolved fixed | 448e052 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/dialogs/AboutSystemDialog.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/dialogs/ProductInfoDialog.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-07T17:03:52Z | 2004-04-16T21:13:20Z |
89,019 | Bug 89019 [ActivityMgmt] ImageBindingRegistry is never hooked into the extension registry | Despite being wired to listen to registry events, this registry is not actually hooked into the extension registry. | verified fixed | 18aa626 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/activities/ws/ImageBindingRegistry.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/activities/ws/WorkbenchActivitySupport.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/IWorkbenchRegistryConstants.java", "tests/org.eclipse.ui.tests/Eclipse", "UI", "Tests/org/eclipse/ui/tests/dynamicplugins/ActivitySupportTests.java", "tests/org.eclipse.ui.tests/Eclipse", "UI", "Tests/org/eclipse/ui/tests/dynamicplugins/DynamicPluginsTestSuite.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-07T16:39:29Z | 2005-03-24T18:46:40Z |
88,552 | Bug 88552 [Contributions] Can't filter out actions from popup menu that are contributed by other plugins | Found in eclipse3.1M5a org.eclipse.compare use objectContribution on IFile and IResource to contribute menus to the popupextender, and they set adaptable=true. My multipage editor popup menu contains the above menu actions, and they appear to be contributed for the editor input (IFileEditorInput). I stepped into PopupMenuExtender's menuAboutToShow, and the actions are added from addEditorActions(mgr). I do not want the above menu contributions to appear in the graph view page of my two-page-editor, and I don't see any possible workaround. BTW, I'm not quite sure what is the effect of the adaptable attribute, because if I set adaptable=false in org.eclipse.compare's plugin.xml, then I don't see any of their menu contributions at all in my editor. My model objects are XSD Infoset Model objects...I'll have to check, but I don't believe they adapt IResource. | verified fixed | 7d8d6ef | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/PartSite.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/PopupMenuExtender.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/part/CompatibilityPartSite.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-07T14:26:46Z | 2005-03-19T02:40:00Z |
67,478 | Bug 67478 [Workbench] Title does not change when closing projects | A small bug: When I close a project, open editors close, but the main Eclipse title bar do not change the title (and it still show the name of the resource which was edited before). My setup: WinXP SP1, Eclipse 3.0 RC2. Also, some editors (e.g. EclipseUML) do not close at all (but maybe it's their fault). | verified fixed | 0501474 | ["bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDEWorkbenchWindowAdvisor.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-06T20:17:10Z | 2004-06-16T15:33:20Z |
89,550 | Bug 89550 [Undo] - beef up javadoc for event notification and dispose | I20050330-0500 This is maybe a problem in the commands plugin - if so, please move the bug up. - Have compilation unit p/A.java: ----------------------- package p; public class B { } ----------------------- - Change "B" to "A" - Edit > Undo Typing - Ctrl+1, choose "Rename compilation unit to 'B.java'" => The following exception is written to the console (but not to the log): java.lang.NullPointerException at org.eclipse.jface.text.DefaultUndoManager$TextCommand.canRedo(DefaultUndoManager.java:166) at org.eclipse.core.commands.operations.DefaultOperationHistory.canRedo(DefaultOperationHistory.java:183) at org.eclipse.ui.operations.RedoActionHandler.shouldBeEnabled(RedoActionHandler.java:72) at org.eclipse.ui.operations.OperationHistoryActionHandler.update(OperationHistoryActionHandler.java:258) at org.eclipse.ui.operations.OperationHistoryActionHandler.historyNotification(OperationHistoryActionHandler.java:243) at org.eclipse.core.commands.operations.DefaultOperationHistory.notifyRemoved(DefaultOperationHistory.java:925) at org.eclipse.core.commands.operations.DefaultOperationHistory.internalRemove(DefaultOperationHistory.java:750) at org.eclipse.core.commands.operations.DefaultOperationHistory.flushUndo(DefaultOperationHistory.java:547) at org.eclipse.core.commands.operations.DefaultOperationHistory.dispose(DefaultOperationHistory.java:253) at org.eclipse.jface.text.DefaultUndoManager.disposeCommandStack(DefaultUndoManager.java:882) at org.eclipse.jface.text.DefaultUndoManager.disconnect(DefaultUndoManager.java:1165) at org.eclipse.jface.text.source.SourceViewer.unconfigure(SourceViewer.java:554) at org.eclipse.jdt.internal.ui.javaeditor.JavaSourceViewer.unconfigure(JavaSourceViewer.java:329) at org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor$AdaptedSourceViewer.unconfigure(CompilationUnitEditor.java:228) at org.eclipse.jdt.internal.ui.javaeditor.JavaEditor.doSetInput(JavaEditor.java:2224) at org.eclipse.jdt.internal.ui.javaeditor.CompilationUnitEditor.doSetInput(CompilationUnitEditor.java:1500) at org.eclipse.ui.texteditor.AbstractTextEditor.setInput(AbstractTextEditor.java:3019) at org.eclipse.ui.texteditor.AbstractTextEditor$7.run(AbstractTextEditor.java:402) at org.eclipse.ui.texteditor.AbstractTextEditor$ElementStateListener.execute(AbstractTextEditor.java:459) at org.eclipse.ui.texteditor.AbstractTextEditor$ElementStateListener.elementMoved(AbstractTextEditor.java:420) at org.eclipse.ui.editors.text.TextFileDocumentProvider$FileBufferListener.underlyingFileMoved(TextFileDocumentProvider.java:305) at org.eclipse.core.internal.filebuffers.TextFileBufferManager$6.run(TextFileBufferManager.java:390) at org.eclipse.core.internal.runtime.InternalPlatform.run(InternalPlatform.java:1021) at org.eclipse.core.runtime.Platform.run(Platform.java:757) at org.eclipse.core.internal.filebuffers.TextFileBufferManager.fireUnderlyingFileMoved(TextFileBufferManager.java:388) at org.eclipse.core.internal.filebuffers.ResourceFileBuffer.handleFileMoved(ResourceFileBuffer.java:431) at org.eclipse.core.internal.filebuffers.ResourceFileBuffer$3.execute(ResourceFileBuffer.java:153) at org.eclipse.core.internal.filebuffers.ResourceFileBuffer$SafeFileChange.run(ResourceFileBuffer.java:78) at org.eclipse.ui.internal.editors.text.UISynchronizationContext.run(UISynchronizationContext.java:34) at org.eclipse.core.internal.filebuffers.TextFileBufferManager.execute(TextFileBufferManager.java:334) at org.eclipse.core.internal.filebuffers.ResourceFileBuffer$FileSynchronizer.resourceChanged(ResourceFileBuffer.java:170) at org.eclipse.core.internal.events.NotificationManager$2.run(NotificationManager.java:276) at org.eclipse.core.internal.runtime.InternalPlatform.run(InternalPlatform.java:1021) at org.eclipse.core.runtime.Platform.run(Platform.java:757) at org.eclipse.core.internal.events.NotificationManager.notify(NotificationManager.java:270) at org.eclipse.core.internal.events.NotificationManager.broadcastChanges(NotificationManager.java:144) at org.eclipse.core.internal.resources.Workspace.broadcastPostChange(Workspace.java:180) at org.eclipse.core.internal.resources.Workspace.endOperation(Workspace.java:912) at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:1723) at org.eclipse.jdt.internal.core.JavaModelOperation.runOperation(JavaModelOperation.java:771) at org.eclipse.jdt.internal.core.JavaModel.rename(JavaModel.java:303) at org.eclipse.jdt.internal.core.CompilationUnit.rename(CompilationUnit.java:1102) at org.eclipse.jdt.internal.corext.refactoring.changes.RenameCompilationUnitChange.doRename(RenameCompilationUnitChange.java:67) at org.eclipse.jdt.internal.corext.refactoring.AbstractJavaElementRenameChange.perform(AbstractJavaElementRenameChange.java:72) at org.eclipse.jdt.internal.ui.text.correction.ChangeCorrectionProposal.performChange(ChangeCorrectionProposal.java:109) at org.eclipse.jdt.internal.ui.text.correction.ChangeCorrectionProposal.apply(ChangeCorrectionProposal.java:72) at org.eclipse.jface.text.contentassist.CompletionProposalPopup.insertProposal(CompletionProposalPopup.java:425) at org.eclipse.jface.text.contentassist.CompletionProposalPopup.selectProposalWithMask(CompletionProposalPopup.java:367) at org.eclipse.jface.text.contentassist.CompletionProposalPopup.access$19(CompletionProposalPopup.java:363) at org.eclipse.jface.text.contentassist.CompletionProposalPopup$3.widgetDefaultSelected(CompletionProposalPopup.java:328) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:96) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:82) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:842) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:2894) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2527) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1570) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1534) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:306) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:143) at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:103) at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:228) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:338) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:151) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.eclipse.core.launcher.Main.invokeFramework(Main.java:268) at org.eclipse.core.launcher.Main.basicRun(Main.java:260) at org.eclipse.core.launcher.Main.run(Main.java:887) at org.eclipse.core.launcher.Main.main(Main.java:871) | verified fixed | cb1766f | ["bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/IOperationHistory.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/OperationHistoryEvent.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-06T04:15:32Z | 2005-03-30T13:40:00Z |
78,460 | Bug 78460 [Contributions] [ViewMgmt] Console actions leaking after each launch | For each launch that terminates and is removed, two console actions are leaked (which also keep a fair bit of the previous launch session in memory). Test case: Ran a program to termination. Removed the program via the Debug view ConsoleTerminateActionDelegate and ConsoleRemoveAllTerminatedActionDelegate leaked per launch. The reference that is keeping them in memory is that addition as selection changed listeners. But I don't understand why the dispose is not freeing them up....? | verified fixed | 16f10c8 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/EditorActionBuilder.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/EditorPluginAction.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/PluginActionBuilder.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/ViewPluginAction.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/ViewerActionBuilder.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-05T20:47:42Z | 2004-11-12T00:40:00Z |
78,860 | Bug 78860 [Progress] UIJob uses lots of resources | I had a memory monitor plugin that graphed the available memory over time. I wrote it using java.util.Timer. The graph looked flat. I re-implemented it using UIJob. The graph became a saw-tooth. The following code illustrates the problem. Create a plugin project. Add the org.eclipse.ui.ActionSets extension and choose the Hello World example. In the run method, add the following code: UIJob j = new UIJob("Tester"){ private int count = 10000; public IStatus runInUIThread(IProgressMonitor monitor) { long total = Runtime.getRuntime().totalMemory()/1024; long free = Runtime.getRuntime().freeMemory()/1024; System.out.println("Total= "+total+" free= "+free); if (--count > 0) schedule(1000); return Status.OK_STATUS; }}; j.schedule(1000); Run the workbench and run the action set. The output should be something like this: Total= # free= # The free value should not be changing. In this instance it is going down continually until there is a GC when it jumps back up. | verified fixed | 2f2bb34 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/progress/FinishedJobs.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/progress/ProgressManager.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-05T19:43:55Z | 2004-11-17T19:33:20Z |
89,393 | Bug 89393 [Undo] - Rename CU scenario - undo becomes disabled in renamed editor | (from Dirk email) - open a compilation unit in the editor - select the type name of the top level type - execute refactoring rename - this correctly opens a triggered operation. However, the operation gets closed by the fact that the editor get set a new input. The stack trace is as follows: Thread [main] (Suspended (breakpoint at line 531 in DefaultOperationHistory)) DefaultOperationHistory.flushUndo(IUndoContext) line: 531 DefaultOperationHistory.dispose(IUndoContext, boolean, boolean, boolean) line: 255 DefaultUndoManager.initializeCommandStack() line: 892 DefaultUndoManager.reset() line: 1178 CompilationUnitEditor$AdaptedSourceViewer(TextViewer).activatePlugins () line: 1508 CompilationUnitEditor$AdaptedSourceViewer(SourceViewer).activatePlugins () line: 414 CompilationUnitEditor$AdaptedSourceViewer(SourceViewer).configure (SourceViewerConfiguration) line: 385 CompilationUnitEditor$AdaptedSourceViewer(JavaSourceViewer).configure (SourceViewerConfiguration) line: 201 CompilationUnitEditor$AdaptedSourceViewer.configure (SourceViewerConfiguration) line: 296 CompilationUnitEditor(JavaEditor).doSetInput(IEditorInput) line: 2229 CompilationUnitEditor.doSetInput(IEditorInput) line: 1501 CompilationUnitEditor(AbstractTextEditor).setInput(IEditorInput) line: 3019 AbstractTextEditor$7.run() line: 402 AbstractTextEditor$ElementStateListener.execute(Runnable, boolean) line: 459 AbstractTextEditor$ElementStateListener.elementMoved(Object, Object) line: 420 TextFileDocumentProvider$FileBufferListener.underlyingFileMoved (IFileBuffer, IPath) line: 305 TextFileBufferManager$6.run() line: 390 InternalPlatform.run(ISafeRunnable) line: 1015 Platform.run(ISafeRunnable) line: 757 TextFileBufferManager.fireUnderlyingFileMoved(IFileBuffer, IPath) line: 388 ResourceTextFileBuffer(ResourceFileBuffer).handleFileMoved(IPath) line: 431 ResourceFileBuffer$3.execute() line: 153 ResourceFileBuffer$3(ResourceFileBuffer$SafeFileChange).run() line: 78 UISynchronizationContext.run(Runnable) line: 34 TextFileBufferManager.execute(Runnable, boolean) line: 334 ResourceFileBuffer$FileSynchronizer.resourceChanged (IResourceChangeEvent) line: 170 NotificationManager$2.run() line: 275 InternalPlatform.run(ISafeRunnable) line: 1015 Platform.run(ISafeRunnable) line: 757 NotificationManager.notify(ResourceChangeListenerList$ListenerEntry[], IResourceChangeEvent, boolean) line: 269 NotificationManager.broadcastChanges(ElementTree, ResourceChangeEvent, boolean) line: 143 Workspace.broadcastPostChange() line: 180 Workspace.checkpoint(boolean) line: 243 PerformChangeOperation$1.run(IProgressMonitor) line: 237 Workspace.run(IWorkspaceRunnable, ISchedulingRule, int, IProgressMonitor) line: 1714 Workspace.run(IWorkspaceRunnable, IProgressMonitor) line: 1734 UIPerformChangeOperation(PerformChangeOperation).executeChange (IProgressMonitor) line: 280 UIPerformChangeOperation.access$1(UIPerformChangeOperation, IProgressMonitor) line: 1 UIPerformChangeOperation$1.run() line: 60 RunnableLock.run() line: 35 UISynchronizer(Synchronizer).runAsyncMessages(boolean) line: 118 Display.runAsyncMessages(boolean) line: 2871 Display.readAndDispatch() line: 2530 ModalContext$ModalContextThread.block() line: 151 ModalContext.run(IRunnableWithProgress, boolean, IProgressMonitor, Display) line: 301 RefactoringWizardDialog2.run(boolean, boolean, IRunnableWithProgress) line: 282 RenameTypeWizard(RefactoringWizard).internalPerformFinish(InternalAPI, PerformChangeOperation) line: 544 RenameRefactoringWizard$1(UserInputWizardPage).performFinish() line: 153 RenameTypeWizard(RefactoringWizard).performFinish() line: 610 RefactoringWizardDialog2.okPressed() line: 406 RefactoringWizardDialog2(Dialog).buttonPressed(int) line: 407 Dialog$2.widgetSelected(SelectionEvent) line: 554 TypedListener.handleEvent(Event) line: 89 EventTable.sendEvent(Event) line: 82 Button(Widget).sendEvent(Event) line: 842 Display.runDeferredEvents() line: 2894 Display.readAndDispatch() line: 2527 RefactoringWizardDialog2(Window).runEventLoop(Shell) line: 801 RefactoringWizardDialog2(Window).open() line: 779 RefactoringWizardOpenOperation$1.run() line: 125 BusyIndicator.showWhile(Display, Runnable) line: 69 RefactoringWizardOpenOperation.run(Shell, String) line: 138 RefactoringStarter.activate(Refactoring, RefactoringWizard, Shell, String, boolean) line: 40 RenameUserInterfaceStarter(UserInterfaceStarter).activate(Refactoring, Shell, boolean) line: 56 RenameUserInterfaceStarter.activate(Refactoring, Shell, boolean) line: 113 RenameSupport.openDialog(Shell) line: 114 RenameJavaElementAction.run(IJavaElement, RenameSupport) line: 180 RenameJavaElementAction.run(ITextSelection) line: 133 RenameAction.run(ITextSelection) line: 116 RenameAction(SelectionDispatchAction).dispatchRun(ISelection) line: 216 RenameAction(SelectionDispatchAction).run() line: 188 RenameAction(Action).runWithEvent(Event) line: 1003 ActionContributionItem.handleWidgetSelection(Event, boolean) line: 557 ActionContributionItem.access$2(ActionContributionItem, Event, boolean) line: 507 ActionContributionItem$6.handleEvent(Event) line: 421 ... This leads to the fact that the undo pushed onto the stack isn't functional. I don't know if this is something the editor, the framework or refactoring has to handle. | verified fixed | 6825a35 | ["bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/DefaultOperationHistory.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-05T19:28:59Z | 2005-03-29T21:00:00Z |
19,336 | Bug 19336 [View Mgmt] Leak: Closed fast view is not GCed. | Build F2 Run Eclipse with OptimizeIt. See the number of ResourceNavigator(s). Should be 1. Make it a fast view. Close it. GC. There are lots of references to ResourceNavigator. Tryied to change Perspective.hideView(IViewPart view) adding if(previousActiveFastView == view) previousActiveFastView = null; but it was not enough to fix the problem. | verified fixed | c8d1166 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/FastViewPane.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/ViewPane.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-04T21:58:24Z | 2002-06-05T15:13:20Z |
89,374 | Bug 89374 [WorkbenchParts] partVisible not sent when editor restored | null | verified fixed | 44863b3 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/WWinPartService.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/WorkbenchPage.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/WorkbenchPartReference.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/WorkbenchWindow.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/misc/UIListenerLogging.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-04T21:11:14Z | 2005-03-29T18:13:20Z |
89,109 | Bug 89109 Need Workspace preference page doc and code fixup | There is currently an illegal reference from IDE to the IWorkspacehelpIds class where we set the Workbench pref. page as the context help id for the workspace page. We should add a new help page for the workspace page and add the context id to IIDEHelpContextIDs and remove the illegal reference. As well the workbench help should not contain references to the preferences that have been moved. see code public class IDEWorkspacePreferencePage extends PreferencePage implements IWorkbenchPreferencePage{ private Button autoBuildButton; private Button autoSaveAllButton; private IntegerFieldEditor saveInterval; private Button autoRefreshButton; /* * (non-Javadoc) * * @see org.eclipse.jface.preference.PreferencePage */ protected Control createContents(Composite parent) { PlatformUI.getWorkbench().getHelpSystem().setHelp(parent, >>>>>>IWorkbenchHelpContextIds.WORKBENCH_PREFERENCE_PAGE); | verified fixed | 669e2ee | ["bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IIDEHelpContextIds.java", "bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/IDEWorkspacePreferencePage.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-04T20:02:06Z | 2005-03-25T17:00:00Z |
89,959 | Bug 89959 [Progress] Progress dialog stayed up when no activity happening, with no details and only cancel button | build I20050331-2000 - had a workspace sync going on in the background - it was near completion - did a sync on another resource from PE - got the Progress Information / Operation in progress... dialog, but it showed no further details - just before this came up, I saw an error dialog come up from the first sync (it's complaining that it was unable to connect to one repo, but this is an expected error given my workspace) - the error dialog is not visible, even if I move the progress dialog - but a button for it does appear in the task tray titled "Synchronizing CVS (Workspace)" (though maybe this is the original progress dialog for the first sync, not the error dialog) - stack traces show only activity in the UI thread (no deadlock), waiting on ErrorNotificationManager's ErrorDialog In a twist of irony, the first sync was showing the incoming change for ErrorNotificationManager <g>. | verified fixed | 74e56ac | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/progress/BlockedJobsDialog.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/progress/ErrorNotificationManager.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/progress/JobErrorDialog.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/progress/ProgressManager.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/progress/ProgressManagerUtil.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-04T19:43:06Z | 2005-04-01T15:40:00Z |
84,499 | Bug 84499 [PerspectiveBar] Ordered perspectives in perspective switcher by drag and drop not maintained | N20050202-0010 I drag and drop to rearrange my perspectives in the perspective switcher Exit Eclipse Restart Eclipse I must reorder the perspectives again. I expected the order to be preserved. | verified fixed | 18cbef2 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/IReorderListener.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/PerspectiveSwitcher.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/WorkbenchPage.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/WorkbenchWindow.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-04T19:09:04Z | 2005-02-04T23:33:20Z |
89,707 | Bug 89707 Undo menu item missing text and wrongly enabled when undo history is 0 | Build: I20050330-0500 From a new workspace 1) Set the text editor undo history size to 0. 2) Create a simple project 3) Create a text file 4) Type some text in the text file 5) Right click in the text editor. -> The "Undo" action text is missing - showing just a blank space in the menu. When I increase the history size it reappears. | verified fixed | 267a30a | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/operations/OperationHistoryActionHandler.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-04T18:40:31Z | 2005-03-30T22:00:00Z |
89,591 | Bug 89591 ContainerCheckedTreeViewer can be deleted | 20050330 The internal ContainerCheckedTreeViewer is not longer referenced in the UI and can be deleted. | verified fixed | 824bc8b | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/dialogs/ContainerCheckedTreeViewer.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-04T15:29:35Z | 2005-03-30T16:26:40Z |
89,029 | Bug 89029 ActionFactory javadoc references do not have the same format as the rest of the workbench | ActionFactory javadoc references do not have the same format as the rest of the workbench - i.e. they do not use the style generated by the javadoc tool | verified fixed | 05e0375 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/actions/ActionFactory.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-04T15:19:09Z | 2005-03-24T18:46:40Z |
89,903 | Bug 89903 [EditorMgmt] EditorRegistry returns null as one of the default editors | The following is the contract for 'setDefaultEditor' in IEditorRegistry: /** * Sets the default editor id for the files that match that * specified file name or extension. The specified editor must be * defined as an editor for that file name or extension. * * @param fileNameOrExtension the file name or extension pattern (e.g. "*.xml"); * @param editorId the editor id or <code>null</code> for no default */ public void setDefaultEditor(String fileNameOrExtension, String editorId); However, when we set the default editor to null, OpenWithMenu chokes and throws null exception. It happens when it wants to sort the default editors because one of the editors returned by IEditorRegistry is null, and the sorter does not expect that. The culprit is the following method in EditorRegistry: public IEditorDescriptor[] getEditors(String fileName, IContentType contentType); It does filter the array before returning it, but for some reason null goes through the filter. I would have fixed the problem and provided the patch, but I am a bit scared of the new content code, so you are better off fixing it yourselves. | verified fixed | d7b8d8b | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/EditorRegistry.java", "tests/org.eclipse.ui.tests/Eclipse", "UI", "Tests/org/eclipse/ui/tests/api/IEditorRegistryTest.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-04T13:13:42Z | 2005-03-31T23:00:00Z |
89,971 | Bug 89971 [Viewers] Viewers that use IViewerLabelProvider do too many instanceof checks | M6 Checking our viewer the calls to buildLabel are doing too many instanceof checks. As a result certain viewers (such as the table viewer) are twice as slow as they were in 3.0 due to these checks. I have written some performance suites to test the Table, Tree, List and Combo viewers. Table and Tree have this issue. | verified fixed | 3d7be21 | ["bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/StructuredViewer.java", "bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/TableViewer.java", "bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/TreeViewer.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-04-04T12:36:36Z | 2005-04-01T15:40:00Z |
89,891 | Bug 89891 [Progress] ErrorNotificationManager parenting off of the wrong shell | 20050331 When we open an error dialog we parent off of the current window. In the case where there is already a modal dialog open this can result in two dialogs blocked on a readAndDispatch. We should use Stefans new shell provider. | verified fixed | 0d7620a | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/progress/ErrorNotificationManager.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-31T21:08:18Z | 2005-03-31T20:13:20Z |
89,816 | Bug 89816 [Workbench] Cannot unlock toolbar | build i0331-0010 I started up this build and I have the coolbar locked. But I noticed that when I look at the coolbar context menu, the "Lock the Toolbar" item is checked but greyed out. It doesn't seem to matter where I click to bring up the menu...the option to unlock the toolbar is always greyed out. | verified fixed | 55ace94 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/LockToolBarAction.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-31T16:40:22Z | 2005-03-31T11:53:20Z |
89,246 | Bug 89246 [EditorMgmt] PartInitException: No saved state can be found for this editor, when closing editors | build N20050328 I've seen this in my own workspace as well, since I20050315. When this happens, it leaves zombie editors around in the list (e.g. they show up in the Ctrl+F6 list). Could this be due to recent EditorManager changes? It should not be trying to restore editors while closing all editors. Also, why does unzooming trigger part restoration? Unzooming should not change the active part, which should already be restored. [java] !ENTRY org.eclipse.ui 4 0 2005-03-28 08:48:52.656 [java] !MESSAGE Unable to create editor ID : No saved state can be found for this editor [java] !STACK 1 [java] org.eclipse.ui.PartInitException: No saved state can be found for this editor [java] at org.eclipse.ui.internal.EditorManager$Editor.getRestoredInput(EditorManager.java:1693) [java] at org.eclipse.ui.internal.EditorManager.busyRestoreEditorHelper(EditorManager.java:1152) [java] at org.eclipse.ui.internal.EditorManager.busyRestoreEditor(EditorManager.java:1077) [java] at org.eclipse.ui.internal.EditorManager$7.run(EditorManager.java:1039) [java] at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:69) [java] at org.eclipse.ui.internal.EditorManager.restoreEditor(EditorManager.java:1037) [java] at org.eclipse.ui.internal.EditorManager$Editor.getEditor(EditorManager.java:1623) [java] at org.eclipse.ui.internal.EditorManager$Editor.getPart(EditorManager.java:1614) [java] at org.eclipse.ui.internal.PartPane.setVisible(PartPane.java:260) [java] at org.eclipse.ui.internal.presentations.PresentablePart.setVisible(PresentablePart.java:126) [java] at org.eclipse.ui.internal.presentations.newapi.TabbedStackPresentation.setVisible(TabbedStackPresentation.java:310) [java] at org.eclipse.ui.internal.PartStack.setVisible(PartStack.java:924) [java] at org.eclipse.ui.internal.PartSashContainer.zoomOut(PartSashContainer.java:925) [java] at org.eclipse.ui.internal.PartSashContainer.childRequestZoomOut(PartSashContainer.java:867) [java] at org.eclipse.ui.internal.PartSashContainer.remove(PartSashContainer.java:670) [java] at org.eclipse.ui.internal.EditorSashContainer.removeEditor(EditorSashContainer.java:221) [java] at org.eclipse.ui.internal.EditorAreaHelper.closeEditor(EditorAreaHelper.java:119) [java] at org.eclipse.ui.internal.EditorAreaHelper.closeEditor(EditorAreaHelper.java:108) [java] at org.eclipse.ui.internal.EditorManager.closeEditor(EditorManager.java:225) [java] at org.eclipse.ui.internal.WorkbenchPage.closeEditors(WorkbenchPage.java:1021) [java] at org.eclipse.ui.internal.WorkbenchPage.closeAllEditors(WorkbenchPage.java:959) [java] at org.eclipse.ui.internal.WorkbenchPage.dispose(WorkbenchPage.java:1329) [java] at org.eclipse.ui.internal.WorkbenchWindow.closeAllPages(WorkbenchWindow.java:654) [java] at org.eclipse.ui.internal.WorkbenchWindow.hardClose(WorkbenchWindow.java:1243) [java] at org.eclipse.ui.internal.WorkbenchWindow.busyClose(WorkbenchWindow.java:537) [java] at org.eclipse.ui.internal.WorkbenchWindow.access$0(WorkbenchWindow.java:518) [java] at org.eclipse.ui.internal.WorkbenchWindow$1.run(WorkbenchWindow.java:619) [java] at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:69) [java] at org.eclipse.ui.internal.WorkbenchWindow.close(WorkbenchWindow.java:617) [java] at org.eclipse.ui.tests.util.UITestCase.closeAllTestWindows(UITestCase.java:186) [java] at org.eclipse.ui.tests.util.UITestCase.doTearDown(UITestCase.java:148) [java] at org.eclipse.ui.tests.zoom.ZoomTestCase.doTearDown(ZoomTestCase.java:75) [java] at org.eclipse.ui.tests.util.UITestCase.tearDown(UITestCase.java:136) [java] at junit.framework.TestCase.runBare(TestCase.java:130) [java] at junit.framework.TestResult$1.protect(TestResult.java:106) [java] at junit.framework.TestResult.runProtected(TestResult.java:124) [java] at junit.framework.TestResult.run(TestResult.java:109) [java] at junit.framework.TestCase.run(TestCase.java:118) [java] at junit.framework.TestSuite.runTest(TestSuite.java:208) [java] at junit.framework.TestSuite.run(TestSuite.java:203) [java] at junit.framework.TestSuite.runTest(TestSuite.java:208) [java] at junit.framework.TestSuite.run(TestSuite.java:203) [java] at junit.framework.TestSuite.runTest(TestSuite.java:208) [java] at junit.framework.TestSuite.run(TestSuite.java:203) [java] at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:313) [java] at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:199) [java] at org.eclipse.test.UITestApplication$3.run(UITestApplication.java:188) [java] at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) [java] at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:118) [java] at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:2871) [java] at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2530) [java] at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1563) [java] at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1527) [java] at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:306) [java] at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:143) [java] at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:103) [java] at org.eclipse.test.UITestApplication.runApplication(UITestApplication.java:131) [java] at org.eclipse.test.UITestApplication.run(UITestApplication.java:58) [java] at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:228) [java] at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:338) [java] at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:151) [java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [java] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [java] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [java] at java.lang.reflect.Method.invoke(Method.java:324) [java] at org.eclipse.core.launcher.Main.invokeFramework(Main.java:315) [java] at org.eclipse.core.launcher.Main.basicRun(Main.java:268) [java] at org.eclipse.core.launcher.Main.run(Main.java:942) [java] at org.eclipse.core.launcher.Main.main(Main.java:926) [java] !SUBENTRY 1 org.eclipse.ui 4 0 2005-03-28 08:48:52.656 [java] !MESSAGE No saved state can be found for this editor [java] ----- testCloseActiveFastView [java] testCloseActiveFastView: setUp... [java] testCloseActiveFastView: tearDown... | verified fixed | d3367ab | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/EditorManager.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-31T04:28:56Z | 2005-03-28T17:13:20Z |
89,530 | Bug 89530 [Preferences] Performance pref page is layer breaker and causes errors | I20050329-2000 The new Performance preference page directly reference JDT UI stuff but is located in org.eclipse.ui.ide. In addition to being a layer breaker this causes errors for users which do not have JDT installed (e.g. the Platform SDK drop) and it also shows a dialog saying that the page contains invalid values. Here's the .log: !SESSION 2005-03-30 15:31:47.340 ----------------------------------------------- eclipse.buildId=I20050330-0500 java.version=1.4.2_03 java.vendor=Sun Microsystems Inc. BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=de_CH Command-line arguments: -os win32 -ws win32 -arch x86 !ENTRY org.eclipse.jface 4 2 2005-03-30 15:31:47.340 !MESSAGE Problems occurred when invoking code from plug-in: "org.eclipse.jface". !STACK 0 java.lang.IllegalArgumentException: Node not found at org.eclipse.ui.dialogs.PreferenceLinkArea.<init>(PreferenceLinkArea.java:65) at org.eclipse.ui.internal.performance.PerformancePrefererencePage.createContents(PerformancePrefererencePage.java:64) at org.eclipse.jface.preference.PreferencePage.createControl(PreferencePage.java:423) at org.eclipse.jface.preference.PreferencePage.createControl(PreferencePage.java:388) at org.eclipse.ui.internal.dialogs.WorkbenchPreferenceDialog.createPageControl(WorkbenchPreferenceDialog.java:375) at org.eclipse.jface.preference.PreferenceDialog$13.run(PreferenceDialog.java:1119) at org.eclipse.core.internal.runtime.InternalPlatform.run(InternalPlatform.java:1021) at org.eclipse.core.runtime.Platform.run(Platform.java:757) at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:40) at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:148) at org.eclipse.jface.preference.PreferenceDialog.showPage(PreferenceDialog.java:1113) at org.eclipse.ui.internal.dialogs.WorkbenchPreferenceDialog.showPage(WorkbenchPreferenceDialog.java:440) at org.eclipse.jface.preference.PreferenceDialog$9.selectionChanged(PreferenceDialog.java:618) at org.eclipse.jface.viewers.StructuredViewer$3.run(StructuredViewer.java:680) at org.eclipse.core.internal.runtime.InternalPlatform.run(InternalPlatform.java:1021) at org.eclipse.core.runtime.Platform.run(Platform.java:757) at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:40) at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:148) at org.eclipse.jface.viewers.StructuredViewer.firePostSelectionChanged(StructuredViewer.java:678) at org.eclipse.jface.viewers.StructuredViewer.handlePostSelect(StructuredViewer.java:949) at org.eclipse.jface.viewers.StructuredViewer$5.widgetSelected(StructuredViewer.java:969) at org.eclipse.jface.util.OpenStrategy.firePostSelectionEvent(OpenStrategy.java:231) at org.eclipse.jface.util.OpenStrategy.access$4(OpenStrategy.java:226) at org.eclipse.jface.util.OpenStrategy$3.run(OpenStrategy.java:392) at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:118) at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:2871) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2530) at org.eclipse.jface.window.Window.runEventLoop(Window.java:803) at org.eclipse.jface.window.Window.open(Window.java:781) at org.eclipse.ui.internal.OpenPreferencesAction.run(OpenPreferencesAction.java:66) at org.eclipse.jface.action.Action.runWithEvent(Action.java:996) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:538) at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:488) at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:400) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:82) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:842) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:2894) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2527) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1570) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1534) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:306) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:143) at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:103) at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:228) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:338) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:151) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at org.eclipse.core.launcher.Main.invokeFramework(Main.java:268) at org.eclipse.core.launcher.Main.basicRun(Main.java:260) at org.eclipse.core.launcher.Main.run(Main.java:887) at org.eclipse.core.launcher.Main.main(Main.java:871) | verified fixed | 8313b25 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/dialogs/PreferenceLinkArea.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/WorkbenchMessages.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-30T21:23:28Z | 2005-03-30T13:40:00Z |
89,504 | Bug 89504 [Contributions] ResourceException when opening context menu on closed project | I20050329-2000 Close a project and the open the context menu on it. I guess the problem is that org.eclipse.ui.internal.ide.model.ProjectPersistentPropertyTester accesses a closed project. Error 2005-03-30 12:42:44.675 Core exception while testing project persistent property org.eclipse.core.internal.resources.ResourceException: Resource /org.eclipse.jface.text.tests is not open. at org.eclipse.core.internal.resources.Project.checkAccessible(Project.java:127) at org.eclipse.core.internal.resources.Resource.getPersistentProperty(Resource.java:924) at org.eclipse.ui.internal.ide.model.ProjectPersistentPropertyTester.test(ProjectPersistentPropertyTester.java:68) at org.eclipse.core.internal.expressions.Property.test(Property.java:52) at org.eclipse.core.internal.expressions.TestExpression.evaluate(TestExpression.java:57) at org.eclipse.core.internal.expressions.CompositeExpression.evaluateAnd(CompositeExpression.java:47) at org.eclipse.core.internal.expressions.AdaptExpression.evaluate(AdaptExpression.java:58) at org.eclipse.core.internal.expressions.CompositeExpression.evaluateAnd(CompositeExpression.java:47) at org.eclipse.core.internal.expressions.EnablementExpression.evaluate(EnablementExpression.java:29) at org.eclipse.ui.internal.ObjectActionContributor$ObjectContribution.isApplicableTo(ObjectActionContributor.java:337) at org.eclipse.ui.internal.ObjectActionContributor.isApplicableTo(ObjectActionContributor.java:208) at org.eclipse.ui.internal.ObjectContributorManager.isApplicableTo(ObjectContributorManager.java:274) at org.eclipse.ui.internal.ObjectActionContributorManager.contributeObjectActions(ObjectActionContributorManager.java:124) at org.eclipse.ui.internal.PopupMenuExtender.addObjectActions(PopupMenuExtender.java:201) at org.eclipse.ui.internal.PopupMenuExtender.menuAboutToShow(PopupMenuExtender.java:226) at org.eclipse.jface.action.MenuManager.fireAboutToShow(MenuManager.java:285) at org.eclipse.jface.action.MenuManager.handleAboutToShow(MenuManager.java:372) at org.eclipse.jface.action.MenuManager.access$0(MenuManager.java:369) at org.eclipse.jface.action.MenuManager$2.menuShown(MenuManager.java:386) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:116) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:82) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:842) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:866) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:847) at org.eclipse.swt.widgets.Control.WM_INITMENUPOPUP(Control.java:3327) at org.eclipse.swt.widgets.Control.windowProc(Control.java:3055) at org.eclipse.swt.widgets.Decorations.windowProc(Decorations.java:1493) at org.eclipse.swt.widgets.Display.windowProc(Display.java:3466) at org.eclipse.swt.internal.win32.OS.TrackPopupMenu(Native Method) at org.eclipse.swt.widgets.Menu._setVisible(Menu.java:225) at org.eclipse.swt.widgets.Display.runPopups(Display.java:2920) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2521) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1570) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1534) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:306) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:143) at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:103) at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:228) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:338) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:151) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.eclipse.core.launcher.Main.invokeFramework(Main.java:268) at org.eclipse.core.launcher.Main.basicRun(Main.java:260) at org.eclipse.core.launcher.Main.run(Main.java:887) at org.eclipse.core.launcher.Main.main(Main.java:871) | verified fixed | baada10 | ["bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/model/ProjectPersistentPropertyTester.java", "tests/org.eclipse.ui.tests/Eclipse", "UI", "Tests/org/eclipse/ui/tests/adaptable/WorkingSetTestCase.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-30T20:45:15Z | 2005-03-30T10:53:20Z |
83,059 | Bug 83059 [RCP] No enablement of perspective menu items | RCP application using factory methods to create menu items for Close Perspective , Close All Perspectives, Reset Perspective, etc. does not maintain enablement state of actions. This code in WorkbenchAdvisor's fillActionBars() method recreates the problem: //Use standard factory methods for actions IWorkbenchAction resetPersAction = ActionFactory.RESET_PERSPECTIVE.create(window); IWorkbenchAction closePersAction = ActionFactory.CLOSE_PERSPECTIVE.create(window); IWorkbenchAction closeAllPersAction = ActionFactory.CLOSE_ALL_PERSPECTIVES.create(window); //Create menu items IMenuManager mgr = configurer.getMenuManager(); MenuManager windowMenu = new MenuManager("&Window", IWorkbenchActionConstants.M_WINDOW); mgr.add(windowMenu); windowMenu.add(resetPersAction); windowMenu.add(closePersAction); windowMenu.add(closeAllPersAction); //Register global actions configurer.registerGlobalAction(resetPersAction); configurer.registerGlobalAction(closePersAction); configurer.registerGlobalAction(closeAllPersAction); I have posted this issue to the RCP news group and received a reply stating that the enablement of these actions should be handled by the RCP developer. However, the ActionFactory API suggests that these actions maintain their enablement state. | verified fixed | 1aadb33 | ["bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/WorkbenchActionBuilder.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/actions/ActionFactory.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/actions/ExportResourcesAction.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/actions/ImportResourcesAction.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/actions/NewWizardAction.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/actions/NewWizardDropDownAction.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/CloseAllPerspectivesAction.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/ClosePerspectiveAction.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/EditActionSetsAction.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/PerspectiveAction.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/PerspectiveTracker.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/ResetPerspectiveAction.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/SavePerspectiveAction.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/ToggleEditorsVisibilityAction.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-30T17:48:17Z | 2005-01-18T06:33:20Z |
89,625 | Bug 89625 [IDE] IDEWorkbenchWindowAdvisor refers to workbench internals for backdrop | 3.1 M5 The code in IDEWorkbenchWindowAdvisor to provide the backdrop when all perspectives are closed refers to internal workbench classes: import org.eclipse.ui.internal.IWorkbenchGraphicConstants; import org.eclipse.ui.internal.WorkbenchImages; import org.eclipse.ui.internal.dialogs.SelectPerspectiveDialog; This should be done using only API. | verified fixed | e643399 | ["bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDEWorkbenchMessages.java", "bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDEWorkbenchWindowAdvisor.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/WorkbenchMessages.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/actions/OpenPerspectiveDialogAction.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-30T17:47:32Z | 2005-03-30T16:26:40Z |
89,415 | Bug 89415 [Commands] handlers: Ctrl+E has no effect | build I20050324-1400 - Ctrl+E in an open editor (plain text or Java) has no effect at the moment - Choosing Switch to Editor from the Window > Navigation menu works OK | verified fixed | ebf8f73 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/EditorAreaHelper.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/WorkbenchWindow.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-30T16:20:06Z | 2005-03-29T21:00:00Z |
89,340 | Bug 89340 [Preferences] Preferences working copy: Pages want to submit update jobs | 20040329 The preference working copies are applied after all pages have their 'performOk()' called. That's fine, but raises the problem for pages that need to do a full build after changes. Before they could do it on 'performOk()', now this doesn't do anything as changes are not yet applied to the preference store. Suggestion is that pages can post update jobs that will be ran after the working copies have been applied. Advantage of that is also that the preferences infrastructure can detect and merge Jobs doings the same (e.g. full build jobs, using a unique job-familiy). Other advantage is that when a page cancels the 'OK' (by returning 'false' on performOk()) the infrastructure would not apply the working copy settings (not implemented at the moment) and also not run the update jobs. API: IWorkbenchPreferenceContainer.registerUpdateJob(Job job) | verified fixed | 804c29a | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/dialogs/FilteredPreferenceDialog.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/preferences/IWorkbenchPreferenceContainer.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-29T20:26:22Z | 2005-03-29T12:40:00Z |
80,793 | Bug 80793 [Viewers] null image returned from ILabelProvider.getImage should remove any image | I20041208 (-gtk) I have an ILabelProvider which in some cases returns an image in its getImage method, in some cases it does not. If I have once set an image, and then want to remove it, I return null; however, ViewerLabel.hasNewImage treats null as "no change". IMO, if a null image is returned, the viewer should remove the image from the label, alternatively, you could provide a "NullImage" and doc its usage. Currently, there is no way I can remove an image I once set without creating an empty image myself. | verified fixed | fd10ea2 | ["bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/ViewerLabel.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-29T14:35:19Z | 2004-12-13T09:26:40Z |
89,324 | Bug 89324 [Preferences] PreferenceLinkArea uses java.security.InvalidParameterException | 20050329 PreferenceLinkArea uses java.security.InvalidParameterException which is 'designed for use by the JCA/JCE engine classes'. I guess IllegalArgumentException was meant | verified fixed | 25b0ab7 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/dialogs/PreferenceLinkArea.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-29T12:56:30Z | 2005-03-29T07:06:40Z |
73,587 | Bug 73587 [RCP] Allow separation of declaration and placement of workbench extensions | null | verified fixed | 57d4da0 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/ExtensionFactory.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-29T05:33:44Z | 2004-09-09T17:13:20Z |
89,303 | Bug 89303 [Help] Add support for resolving hrefs in the workbench help system | There are several use cases where a help resource href needs to be resolved into a URL so that it can be manipulated (opened, shown in a browser etc.). This task is dependent on the help system plugged in. I have added two methods to IWorkbenchHelpSystem: resolve and unresolve. The former takes a String href and returns a resolved URL according to the active help system. The later takes a URL and returns the original href if the first part of the URL matches the base URL. The changes I made are backward-compatible in that AbstractHelpSystem has default implementations of the methods. Our own help implementation (DefaultHelpSystem) implements these methods in a non-trivial way. Please release the attached patch because Intro needs it in order to be able to embed help documents inside Intro pages. | resolved fixed | 34abbd0 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/help/AbstractHelpUI.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/help/IWorkbenchHelpSystem.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/help/WorkbenchHelpSystem.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-29T01:26:10Z | 2005-03-28T22:46:40Z |
89,259 | Bug 89259 [WorkbenchParts] assertion failed when opening Compare editor for MANIFEST.MF | N20050328-0010 Not sure what the right component to report this against is. Opening compare editor for MANIFEST.MF files fails with the following AssertionFailedException. It looks quite critical, but I am leaving severity as normal since it is a nightly build. Steps: - select two random MANIFEST.MF files - compare with each other The same happens when comparing with CVS resource history. !SESSION 2005-03-28 13:41:05.772 ----------------------------------------------- eclipse.buildId=N20050328-0010 java.version=1.5.0 java.vendor=Sun Microsystems Inc. BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=en_CA Framework arguments: -keyring d:\temp\.keyring -showlocation Command-line arguments: -data d:\dev\head -os win32 -ws win32 -arch x86 -keyring d:\temp\.keyring -consolelog -console -debug -showlocation !ENTRY org.eclipse.ui 4 0 2005-03-28 13:41:05.787 !MESSAGE Unable to create editor ID org.eclipse.compare.CompareEditor: null argument; !STACK 0 org.eclipse.ui.internal.misc.AssertionFailedException: null argument; at org.eclipse.ui.internal.misc.Assert.isNotNull(Assert.java:81) at org.eclipse.ui.internal.misc.Assert.isNotNull(Assert.java:68) at org.eclipse.ui.internal.PartTester.testEditorInput(PartTester.java:51) at org.eclipse.ui.internal.PartTester.testEditor(PartTester.java:42) at org.eclipse.ui.internal.EditorManager.busyRestoreEditorHelper(EditorManager.java:1222) at org.eclipse.ui.internal.EditorManager.busyRestoreEditor(EditorManager.java:1077) at org.eclipse.ui.internal.EditorManager$7.run(EditorManager.java:1039) at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:69) at org.eclipse.ui.internal.EditorManager.restoreEditor(EditorManager.java:1037) at org.eclipse.ui.internal.EditorManager$Editor.getEditor(EditorManager.java:1623) at org.eclipse.ui.internal.EditorManager$Editor.getPart(EditorManager.java:1614) at org.eclipse.ui.internal.PartPane.setVisible(PartPane.java:260) at org.eclipse.ui.internal.presentations.PresentablePart.setVisible(PresentablePart.java:126) at org.eclipse.ui.internal.presentations.newapi.PresentablePartFolder.select(PresentablePartFolder.java:268) at org.eclipse.ui.internal.presentations.newapi.LeftToRightTabOrder.select(LeftToRightTabOrder.java:65) at org.eclipse.ui.internal.presentations.newapi.TabbedStackPresentation.selectPart(TabbedStackPresentation.java:391) at org.eclipse.ui.internal.PartStack.refreshPresentationSelection(PartStack.java:1070) at org.eclipse.ui.internal.PartStack.setSelection(PartStack.java:1019) at org.eclipse.ui.internal.PartStack.showPart(PartStack.java:1223) at org.eclipse.ui.internal.PartStack.add(PartStack.java:406) at org.eclipse.ui.internal.EditorStack.add(EditorStack.java:109) at org.eclipse.ui.internal.EditorSashContainer.addEditor(EditorSashContainer.java:63) at org.eclipse.ui.internal.EditorAreaHelper.addToLayout(EditorAreaHelper.java:266) at org.eclipse.ui.internal.EditorManager$4.run(EditorManager.java:804) at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:69) at org.eclipse.ui.internal.EditorManager.createEditorTab(EditorManager.java:784) at org.eclipse.ui.internal.EditorManager.openEditorFromDescriptor(EditorManager.java:672) at org.eclipse.ui.internal.EditorManager.openEditor(EditorManager.java:635) at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditorBatched(WorkbenchPage.java:2229) at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(WorkbenchPage.java:2163) at org.eclipse.ui.internal.WorkbenchPage.access$7(WorkbenchPage.java:2155) at org.eclipse.ui.internal.WorkbenchPage$9.run(WorkbenchPage.java:2141) at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:69) at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2136) at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2121) at org.eclipse.compare.internal.CompareUIPlugin.openCompareEditor(CompareUIPlugin.java:444) at org.eclipse.compare.CompareUI.openCompareEditorOnPage(CompareUI.java:136) at org.eclipse.team.internal.ccvs.ui.actions.CompareRemoteResourcesAction.execute(CompareRemoteResourcesAction.java:42) at org.eclipse.team.internal.ccvs.ui.actions.CVSAction.run(CVSAction.java:117) at org.eclipse.ui.actions.ActionDelegate.runWithEvent(ActionDelegate.java:70) at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:231) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:538) at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:488) at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:400) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:82) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:842) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:2894) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2527) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1563) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1527) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:306) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:143) at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:103) at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:228) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:338) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:151) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.eclipse.core.launcher.Main.invokeFramework(Main.java:315) at org.eclipse.core.launcher.Main.basicRun(Main.java:268) at org.eclipse.core.launcher.Main.run(Main.java:942) at org.eclipse.core.launcher.Main.main(Main.java:926) | resolved fixed | bfb24e0 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/IEditorInput.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/PartTester.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-29T00:54:18Z | 2005-03-28T20:00:00Z |
89,311 | Bug 89311 [Workbench] clean up registry constants | The various constants that live in RegistryReader subclasses should be moved to IWorkbenchRegistryConstants. | verified fixed | 79b9db4 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/SelectionEnabler.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/WorkbenchEncoding.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/ObjectActionContributor.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/ObjectActionContributorReader.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/Perspective.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/PluginAction.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/PluginActionBuilder.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/PluginActionSetReader.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/PopupMenuExtender.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/ViewerActionBuilder.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/WorkbenchPage.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/decorators/DecoratorRegistryReader.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/dialogs/RegistryPageContributor.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/dialogs/WizardCollectionElement.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/dialogs/WorkbenchWizardElement.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/ActionSetPartAssociationsReader.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/ActionSetRegistryReader.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/EditorRegistryReader.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/IWorkbenchRegistryConstants.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/PerspectiveExtensionReader.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/PerspectiveRegistryReader.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/PreferencePageRegistryReader.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/PreferenceTransferRegistryReader.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/PropertyPagesRegistryReader.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/RegistryReader.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/WizardsRegistryReader.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/WorkingSetRegistryReader.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/themes/ThemeElementCategory.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/themes/ThemeRegistryReader.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/preferences/PreferenceTransferElement.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-29T00:53:53Z | 2005-03-29T01:33:20Z |
89,139 | Bug 89139 [JFace] - API Review - DerivedImageDescriptor not complete | while reviewing the API for DerivedImageDescriptor, I noticed that the constructor parameter originalImage is never assigned in the constructor to the instance variable originalImage, which is used in all the creation methods. I doubt this class works...?? Also, the #createResource method doesn't throw the DeviceResourceException as documented. | resolved fixed | 5322320 | ["bundles/org.eclipse.jface/src/org/eclipse/jface/resource/DerivedImageDescriptor.java", "bundles/org.eclipse.jface/src/org/eclipse/jface/resource/DeviceResourceException.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-29T00:52:26Z | 2005-03-25T22:33:20Z |
89,031 | Bug 89031 [Undo/Redo] IWorkbench#getOperationSupport() marked experimental | IWorkbench#getOperationSupport() marked experimental | verified fixed | 3bad50e | ["bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/AbstractOperation.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/DefaultOperationHistory.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/ICompositeOperation.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/IHistoryNotificationAwareOperation.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/IOperationApprover.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/IOperationHistory.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/IOperationHistoryListener.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/IUndoContext.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/IUndoableOperation.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/LinearUndoEnforcer.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/LinearUndoViolationDetector.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/ObjectUndoContext.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/OperationHistoryEvent.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/OperationHistoryFactory.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/OperationStatus.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/TriggeredOperations.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/UndoContext.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/internal/commands/operations/GlobalUndoContext.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/IWorkbench.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/operations/IWorkbenchOperationSupport.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/operations/OperationHistoryActionHandler.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/operations/RedoActionHandler.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/operations/UndoActionHandler.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/operations/UndoRedoActionGroup.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/operations/WorkbenchOperationSupport.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-28T21:06:50Z | 2005-03-24T18:46:40Z |
89,218 | Bug 89218 [DynamicUI] There needs to be a browser dynamic test | The browser support needs an associated dynamic test suite. I've written one but will hold off on releasing it until Dejan has the fix for 89215 ready (so we're not stepping on each others toes). | verified fixed | 54ba221 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/browser/WorkbenchBrowserSupport.java", "tests/org.eclipse.ui.tests/Eclipse", "UI", "Tests/org/eclipse/ui/tests/dynamicplugins/BrowserTests.java", "tests/org.eclipse.ui.tests/Eclipse", "UI", "Tests/org/eclipse/ui/tests/dynamicplugins/DynamicPluginsTestSuite.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-28T20:13:36Z | 2005-03-28T14:26:40Z |
85,192 | Bug 85192 [KeyBindings] preference page: ArrayIndexOutOfBounds if add special key while modifier pressed | I20050214-0927 Window>Preferences>General>Keys>Modify Key Sequence "Name:" text field Hold Ctrl key Click the Insert Special Key button Select an entry java.lang.ArrayIndexOutOfBoundsException: -1 at java.util.ArrayList.get(ArrayList.java:326) at org.eclipse.jface.bindings.keys.KeySequenceText.insertStrokeAt (KeySequenceText.java:682) at org.eclipse.jface.bindings.keys.KeySequenceText.insert (KeySequenceText.java:659) at org.eclipse.ui.internal.commands.KeysPreferencePage$8.widgetSelected (KeysPreferencePage.java:754) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:89) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:82) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:842) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:2878) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2516) at org.eclipse.jface.window.Window.runEventLoop(Window.java:718) at org.eclipse.jface.window.Window.open(Window.java:696) at org.eclipse.ui.internal.OpenPreferencesAction.run (OpenPreferencesAction.java:66) at org.eclipse.jface.action.Action.runWithEvent(Action.java:1003) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection (ActionContributionItem.java:557) at org.eclipse.jface.action.ActionContributionItem.access$2 (ActionContributionItem.java:507) at org.eclipse.jface.action.ActionContributionItem$6.handleEvent (ActionContributionItem.java:421) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:82) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:842) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:2878) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2516) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1612) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1578) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:293) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:144) at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:102) at org.eclipse.core.internal.runtime.PlatformActivator$1.run (PlatformActivator.java:228) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:332) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:149) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at org.eclipse.core.launcher.Main.invokeFramework(Main.java:268) at org.eclipse.core.launcher.Main.basicRun(Main.java:260) at org.eclipse.core.launcher.Main.run(Main.java:887) at org.eclipse.core.launcher.Main.main(Main.java:871) | verified fixed | 163402a | ["bundles/org.eclipse.jface/src/org/eclipse/jface/bindings/keys/KeySequenceText.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-28T18:53:40Z | 2005-02-14T22:26:40Z |
88,134 | Bug 88134 [Commands] errors: Incomplete and confusing warning | null | verified fixed | f1aef80 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/commands/CommandPersistence.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-28T18:23:08Z | 2005-03-15T23:40:00Z |
89,224 | Bug 89224 [Preferences] Policy.SHOW_PREFERENCES_NEWLOOK is unused | latest from head The Policy.SHOW_PREFERENCES_NEWLOOK setting (new in 3.1) is currently unused. Can it be removed? | verified fixed | a36044d | ["bundles/org.eclipse.jface/src/org/eclipse/jface/util/Policy.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/JFaceUtil.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-28T18:18:14Z | 2005-03-28T14:26:40Z |
89,020 | Bug 89020 [Undo] Operation throws assertion failure if undo limit is set to 0 | I20050324-0800 Unfortunately existing clients of text's undo manager were allowed to set any number without failing. This is no longer possible: an assertion failure occurrs if the limit is smaller than 1. I will add code on my side that will handle the negative numbers but the operation history must allow 0. | verified fixed | ad9d7ef | ["bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/DefaultOperationHistory.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/IOperationHistory.java", "tests/org.eclipse.ui.tests/Eclipse", "UI", "Tests/org/eclipse/ui/tests/operations/OperationsAPITest.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-28T18:08:51Z | 2005-03-24T18:46:40Z |
89,032 | Bug 89032 javadoc issues with contributions | CompoundContributionItem marked experimental CompoundContributionItem IContributionItem[] getContributionItems() has no javadoc | verified fixed | 8d5afc0 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/actions/CompoundContributionItem.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-28T17:40:08Z | 2005-03-24T18:46:40Z |
89,025 | Bug 89025 [Commands] javadoc issues in commands | ActiveShellExpression - no javadoc for public final EvaluationResult evaluate(final IEvaluationContext context) { LegacyHandlerSubmission#evalate has no javadoc ActionHandler#addHandlerListener javadioc is wierd (since tag and reference to an interface) ExtensionParameterValues missing javadoc | verified fixed | eb21570 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/ActiveShellExpression.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/LegacyHandlerSubmissionExpression.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-28T16:32:29Z | 2005-03-24T18:46:40Z |
89,071 | Bug 89071 [Progress] Progress dialog prevents access to modal error dialog | build I20050323 - went to commit a change to a file - it had meanwhile been modified in the repo - it brought up an error dialog and a progress dialog - the error dialog must have come up first - the progress dialog is top-most, but is application modal and disabled, so I can't dismiss the modal error dialog - had to kill eclipse and restart The progress dialog was triggered by a busyCursorWhile timing out. | verified fixed | fe0055d | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/progress/ProgressMonitorJobsDialog.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-28T16:31:06Z | 2005-03-25T03:06:40Z |
89,137 | Bug 89137 [JFace] - API Review - "temporary" API in AbstractTreeViewer | AbstractTreeViewer contains two methods documented as "temporary" internalRefresh(Widget, Object) internalAdd(Widget, Object, Object []) | verified fixed | 7db3e25 | ["bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/AbstractTreeViewer.java", "bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/StructuredViewer.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-28T16:20:04Z | 2005-03-25T22:33:20Z |
72,397 | Bug 72397 [Dialogs] DialogSettings Javadoc example needs <pre> and </pre> tags | The Javadoc for the class DialogSettings includes an example, but when displayed as HTML is displayed word-wrapped. This example, as with all code examples, should be considered preformatted by the browser. To do this, add a <pre> tag before the example and a </pre> tag after the example. | verified fixed | cf020cb | ["bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/DialogSettings.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-28T15:37:27Z | 2004-08-22T02:00:00Z |
89,123 | Bug 89123 [Wizards] Typo in WizardDataTransferPage Javadoc | Small typo in the description of the subject class: This class is not intended to be subclassed outside outside of the workbench. (Duplicate "outside".) | verified fixed | 083a5c2 | ["bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/dialogs/WizardDataTransferPage.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-28T15:34:19Z | 2005-03-25T19:46:40Z |
89,033 | Bug 89033 Workbench javadoc issues | NewWizardDropDOwn#run, #createDropDownMenuMgr missing javadoc RetargetAction #isHandled is missing javadoc WorkbenchWindowAdvisor has TODO tags | verified fixed | 6d94228 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/actions/NewWizardDropDownAction.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/application/WorkbenchWindowAdvisor.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-25T04:18:14Z | 2005-03-24T18:46:40Z |
88,737 | Bug 88737 [GlobalActions] Close All is disabled while an editor is open | I20050315-1100 - new workspace, new project, new file "Test.txt" -> editor for Test.txt is open, but File > Close All is disabled | verified fixed | bd4055f | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/EditorManager.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-24T22:43:33Z | 2005-03-22T14:00:00Z |
88,873 | Bug 88873 [DynamicUI] remove Experimental from IExtensionTracker API | See IWorkbench.getExtensionTracker WorkbenchWindow WorkbenchPage | verified fixed | 22400f6 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/IWorkbench.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/IWorkbenchPage.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/IWorkbenchWindow.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-24T21:55:50Z | 2005-03-23T15:00:00Z |
88,993 | Bug 88993 [Viewers] CCE in AbstractTreeViewer.indexForElement(..) | null | verified fixed | a33eca8 | ["bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/AbstractTreeViewer.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-24T16:04:15Z | 2005-03-24T13:13:20Z |
63,293 | Bug 63293 [Workbench] Should deprecate IWorkbench.getPreferenceStore() | build I20040520 IWorkbench.getPreferenceStore() returns the preference store for org.eclipse.ui.workbench, where we store only internal preference settings. The method has been here since 2.0, and has been implemented this way since 2.1. Clients should use the new PlatformUI.getPreferenceStore() instead. Propose deprecating it with the following note: * @deprecated this returns the preference store for the <code>org.eclipse.ui.workbench</code> * plug-in. Only internal preferences are stored here. Clients should use * {@link PlatformUI#getPreferenceStore()} instead. | verified fixed | 0a88e65 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/IWorkbench.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-24T03:54:45Z | 2004-05-20T19:06:40Z |
88,838 | Bug 88838 [Undo] - API cleanup - remove IContextConsultingOperationApprover | Early on this was involved in scenarios where editors examined other operations. This is no longer used. Operation approvers generally apply to all contexts and are installed at the OperationHistory level. Until there is a concrete need for this API it should be removed. It is gratuitous at this point. | verified fixed | c5bc2e0 | ["bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/ContextConsultingOperationApprover.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/DefaultOperationHistory.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/ICompositeOperation.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/IContextOperationApprover.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/IOperationHistory.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/IUndoContext.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/LinearUndoViolationDetector.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/ObjectUndoContext.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/TriggeredOperations.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/UndoContext.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/internal/commands/operations/GlobalUndoContext.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/operations/OperationHistoryActionHandler.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/operations/RedoActionHandler.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/operations/UndoActionHandler.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/operations/WorkbenchOperationSupport.java", "tests/org.eclipse.ui.tests/Eclipse", "UI", "Tests/org/eclipse/ui/tests/operations/OperationsAPITest.java", "tests/org.eclipse.ui.tests/Eclipse", "UI", "Tests/org/eclipse/ui/tests/operations/WorkbenchOperationHistoryTests.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-24T00:37:52Z | 2005-03-23T03:53:20Z |
86,958 | Bug 86958 [Viewers] Adding many adjacent children to a TreeViewer is slow | This is on 3.1M5a, GTK2 build. If you add several thousand children to a Tree, it can take several minutes to complete. A concrete example is browsing a CVS repository containing thousands of directories (e.g. cvs.fedora.redhat.com/cvs/dist). If you browse through that repo, the UI becomes unresponsive for several minutes while the tree is updated. This is unacceptable. Adding N children to a tree node is currently an O(N^2) operation (at least on GTK2; I haven't checked other platforms). This is because, for every child, an O(N) read of all the children on that node, and an O(N) linear search to check for duplicates, is performed. The attached patch reduces the "add N children" cost to O(N log N) - which in practice means that, for my CVS repo test case, the UI only takes a few seconds to update instead of several minutes - but only in the case of sorted trees, by doing two things: 1. AbstractTreeViewer.indexForElement now requests only the children that are actually needed in its binary search, rather than requesting all the children of the current node. 2. This optimisation is only performed for sorted trees: In AbstractTreeViewer.createAddedElement, given that we now know the index where we need to insert the new item, and given the reasonable assumption (which needs to be explicitly required in the Javadoc!) that the sorter is consistent with equals(), we don't have to search through all the children to find possible duplicates. We need only look at the item prior to that index, if the index is positive. If the index is 0, we know it is not a duplicate, because of the algorithm used in indexForElement. No new fields have been added, but some new public methods have been added. Unfortunately, because it straddles the platform-specific interface, if this patch were accepted, it would need to be implemented for every platform, and my patch only implements the GTK2 part of it, because I don't develop on Windows. | verified fixed | d94e309 | ["bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/AbstractTreeViewer.java", "bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/TableTreeViewer.java", "bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/TreeViewer.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-23T21:23:00Z | 2005-03-01T23:33:20Z |
67,413 | Bug 67413 [KeyBindings] misc: Block accelerators that are in use | I meet a error after following these steps: - Remove hot keys Navigate->Open:F3 then add a new one Ctrl+Enter - Remove hot keys Edit->Find Previous:Ctrl+Shift+K then add a new one Shift+F3 - Remove hot keys Edit->Find Next:Ctrl+K then add a new one F3 Everything work fine with the new assigned keys except for editing an ant file (build.xml). When editing ant file, the ui understand the old hot keys: F3 for open and Ctrl+K for Find Next. | verified fixed | cdb8444 | ["bundles/org.eclipse.jface/src/org/eclipse/jface/action/ActionContributionItem.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-23T20:48:19Z | 2004-06-16T07:13:20Z |
88,878 | Bug 88878 [Preferences] File and Content Type pages should link to one another | There should be some mention of the relationship between content type and file association pages. | verified fixed | 24d68c6 | ["bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDEWorkbenchMessages.java", "bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/ContentTypesPreferencePage.java", "bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/IDEEditorsPreferencePage.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/WorkbenchMessages.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/dialogs/FileEditorsPreferencePage.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-23T20:41:25Z | 2005-03-23T17:46:40Z |
88,890 | Bug 88890 [WorkbenchLauncher] missing "select workspace" dialog | i200503230842 Running with this build for the first time, I noticed it did not bother asking me for the workspace location. Just opened the default location. Note UI preferences are being created in the configuration area: #Wed Mar 23 12:25:49 EST 2005 RECENT_WORKSPACES_PROTOCOL=2 SHOW_WORKSPACE_SELECTION_DIALOG=false MAX_RECENT_WORKSPACES=5 eclipse.preferences.version=1 RECENT_WORKSPACES=C\:\\Documents and Settings\\rchaves\\workspace Deleting this file does not help, it is recreated again. | verified fixed | 5566727 | ["bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/ChooseWorkspaceData.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-23T19:08:06Z | 2005-03-23T17:46:40Z |
87,208 | Bug 87208 [GlobalActions] CCE in RetargetAction while switching between views and editors | java.lang.ClassCastException: org.eclipse.ui.actions.RetargetAction at org.eclipse.ui.actions.RetargetAction.propagateChange(RetargetAction.java:197) at org.eclipse.ui.actions.RetargetAction$1.propertyChange(RetargetAction.java:60) at org.eclipse.jface.action.Action.firePropertyChange(Action.java:597) at org.eclipse.jface.action.Action.firePropertyChange(Action.java:582) at org.eclipse.ui.actions.RetargetAction.setActionHandler(RetargetAction.java:265) at org.eclipse.ui.actions.RetargetAction.partActivated(RetargetAction.java:146) at org.eclipse.ui.internal.PartListenerList$1.run(PartListenerList.java:52) at org.eclipse.core.internal.runtime.InternalPlatform.run(InternalPlatform.java:1015) at org.eclipse.core.runtime.Platform.run(Platform.java:757) at org.eclipse.ui.internal.PartListenerList.firePartActivated(PartListenerList.java:50) at org.eclipse.ui.internal.WWinPartService.firePartActivated(WWinPartService.java:209) at org.eclipse.ui.internal.WWinPartService.access$0(WWinPartService.java:206) at org.eclipse.ui.internal.WWinPartService$1.partActivated(WWinPartService.java:36) at org.eclipse.ui.internal.PartListenerList2$1.run(PartListenerList2.java:48) at org.eclipse.core.internal.runtime.InternalPlatform.run(InternalPlatform.java:1015) at org.eclipse.core.runtime.Platform.run(Platform.java:757) at org.eclipse.ui.internal.PartListenerList2.firePartActivated(PartListenerList2.java:46) at org.eclipse.ui.internal.WorkbenchPage.firePartActivated(WorkbenchPage.java:1501) at org.eclipse.ui.internal.WorkbenchPage.setActivePart(WorkbenchPage.java:2821) at org.eclipse.ui.internal.WorkbenchPage.requestActivation(WorkbenchPage.java:2479) at org.eclipse.ui.internal.PartPane.requestActivation(PartPane.java:314) at org.eclipse.ui.internal.PartPane.setFocus(PartPane.java:356) at org.eclipse.ui.internal.PartStack.presentationSelectionChanged(PartStack.java:728) at org.eclipse.ui.internal.PartStack.access$0(PartStack.java:711) at org.eclipse.ui.internal.PartStack$1.selectPart(PartStack.java:93) at org.eclipse.ui.internal.presentations.newapi.TabbedStackPresentation$1.handleEvent(TabbedStackPresentation.java:116) at org.eclipse.ui.internal.presentations.newapi.AbstractTabFolder.fireEvent(AbstractTabFolder.java:263) at org.eclipse.ui.internal.presentations.newapi.AbstractTabFolder.fireEvent(AbstractTabFolder.java:272) at org.eclipse.ui.internal.presentations.defaultpresentation.DefaultTabFolder.access$1(DefaultTabFolder.java:1) at org.eclipse.ui.internal.presentations.defaultpresentation.DefaultTabFolder$2.handleEvent(DefaultTabFolder.java:81) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:82) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:842) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:866) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:851) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:659) at org.eclipse.swt.custom.CTabFolder.setSelection(CTabFolder.java:3141) at org.eclipse.swt.custom.CTabFolder.onMouse(CTabFolder.java:1925) at org.eclipse.swt.custom.CTabFolder$1.handleEvent(CTabFolder.java:287) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:82) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:842) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:2908) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2541) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1612) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1578) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:293) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:144) at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:102) at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:228) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:333) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:150) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.eclipse.core.launcher.Main.invokeFramework(Main.java:268) at org.eclipse.core.launcher.Main.basicRun(Main.java:260) at org.eclipse.core.launcher.Main.run(Main.java:887) at org.eclipse.core.launcher.Main.main(Main.java:871) | resolved fixed | 186394e | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/actions/RetargetAction.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/commands/ActionHandler.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-23T17:23:35Z | 2005-03-05T10:53:20Z |
88,872 | Bug 88872 [Keys] (tests) Bug43597Test is platform-specific | null | verified fixed | 7b6b574 | ["tests/org.eclipse.ui.tests/Eclipse", "UI", "Tests/org/eclipse/ui/tests/keys/Bug43597Test.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-23T16:08:50Z | 2005-03-23T15:00:00Z |
88,863 | Bug 88863 [Preferences] PreferencesLinkArea should be API | We need to make the preferences link area API. | verified fixed | 3015a56 | ["bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/IDEEditorsPreferencePage.java", "bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/IDEWorkspacePreferencePage.java", "bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/performance/PerformancePrefererencePage.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/dialogs/PreferenceLinkArea.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/dialogs/PreferenceLinkArea.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-23T14:52:07Z | 2005-03-23T15:00:00Z |
85,601 | Bug 85601 [Preferences] export preferences wizard - "Choose Specific" not working | M5 v20050215-2300 Select File>Export>Preferences Enable the radio button "Choose Specific Preferences to Export" The only preference shown is "Keys Preferences" Worse, if I select this choice and export, I get an empty file. Why is this the only choice? Should I be seeing all preference categories in this list? or just the ones that I've changed? | verified fixed | a3932e9 | ["bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/preferences/WizardPreferencesExportPage1.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-22T22:34:18Z | 2005-02-16T21:40:00Z |
70,856 | Bug 70856 [Viewers] ComboViewer internalRefresh is slow | When you call ComboViewer internalRefresh (via StructuredViewer.refresh), the viewer clears the model, gets the list of items from the data model and walks through them one by one, adding them to the combo and the element map: ILabelProvider labelProvider= (ILabelProvider) getLabelProvider(); for (int i= 0; i < children.length; i++) { Object el = children[i]; listAdd(labelProvider.getText(el), i); listMap.add(el); mapElement(el, list); // must map it, since findItem only looks in map, if enabled } However, this is a slow process because listAdd() calls combo.add(), which copies over the current list and adds one item to it. So in my list of 376 items, 376 new Arrays are created, weahc one larger than the last, and 376 arrayCopy's are done and combo.setItems() is callled 376 times, and from my profiling, it looks like a lot of time is spent in setItems. Would it be better to do: ILabelProvider labelProvider= (ILabelProvider) getLabelProvider(); String[] items = new String[children.length]; for (int i= 0; i < children.length; i++) { Object el = children[i]; //listAdd(labelProvider.getText(el), i); item[i] = labelProvider.getText(el); listMap.add(el); mapElement(el, list); // must map it, since findItem only looks in map, if enabled } listSetItems(items); which will call combo.setItems() only once? I have not been able to test this, because of the listMap variable referred to above is private and I can't subclass ComboViewer anyway because it is final. | verified fixed | c79a03a | ["bundles/org.eclipse.jface/src/org/eclipse/jface/viewers/AbstractListViewer.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-22T19:43:27Z | 2004-07-26T19:26:40Z |
77,468 | Bug 77468 [ErrorHandling] NPE in Perspective.loadPredefinedPersp | eclipse.buildId=I200411020010 java.version=1.4.2_03 java.vendor=Sun Microsystems Inc. BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=en Command-line arguments: -showlocation 1) Launch eclipse with a brand new workspace 2) Try to open the CVS perspective java.lang.NullPointerException at org.eclipse.ui.internal.Perspective.loadPredefinedPersp (Perspective.java:715) at org.eclipse.ui.internal.Perspective.createPresentation (Perspective.java:229) at org.eclipse.ui.internal.Perspective.<init>(Perspective.java:123) at org.eclipse.ui.internal.WorkbenchPage.createPerspective (WorkbenchPage.java:1159) at org.eclipse.ui.internal.WorkbenchPage.busySetPerspective (WorkbenchPage.java:760) at org.eclipse.ui.internal.WorkbenchPage.access$8 (WorkbenchPage.java:752) at org.eclipse.ui.internal.WorkbenchPage$12.run (WorkbenchPage.java:3019) at org.eclipse.swt.custom.BusyIndicator.showWhile (BusyIndicator.java:69) at org.eclipse.ui.internal.WorkbenchPage.setPerspective (WorkbenchPage.java:3017) at org.eclipse.ui.internal.ChangeToPerspectiveMenu.run (ChangeToPerspectiveMenu.java:88) at org.eclipse.ui.actions.PerspectiveMenu.run(PerspectiveMenu.java:306) at org.eclipse.ui.actions.PerspectiveMenu$3.widgetSelected (PerspectiveMenu.java:117) at org.eclipse.swt.widgets.TypedListener.handleEvent (TypedListener.java:89) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:82) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:800) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:2794) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2448) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1527) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1498) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench (Workbench.java:276) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:144) at org.eclipse.ui.internal.ide.IDEApplication.run (IDEApplication.java:102) at org.eclipse.core.internal.runtime.PlatformActivator$1.run (PlatformActivator.java:335) at org.eclipse.core.runtime.adaptor.EclipseStarter.run (EclipseStarter.java:273) at org.eclipse.core.runtime.adaptor.EclipseStarter.run (EclipseStarter.java:129) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at org.eclipse.core.launcher.Main.basicRun(Main.java:185) at org.eclipse.core.launcher.Main.run(Main.java:704) at org.eclipse.core.launcher.Main.main(Main.java:688) Also get a ClassNotFoundException for the CVSPerspective: java.lang.ClassNotFoundException: org.eclipse.team.internal.ccvs.ui.CVSPerspective at org.eclipse.osgi.framework.internal.core.BundleLoader.findClass (BundleLoader.java:404) at org.eclipse.osgi.framework.adaptor.core.AbstractClassLoader.loadClass (AbstractClassLoader.java:93) at java.lang.ClassLoader.loadClass(ClassLoader.java:235) at org.eclipse.osgi.framework.internal.core.BundleLoader.loadClass (BundleLoader.java:307) at org.eclipse.osgi.framework.internal.core.BundleHost.loadClass (BundleHost.java:336) at org.eclipse.osgi.framework.internal.core.AbstractBundle.loadClass (AbstractBundle.java:1313) at org.eclipse.core.internal.registry.ConfigurationElement.createExecutableExtensi on(ConfigurationElement.java:131) at org.eclipse.core.internal.registry.ConfigurationElement.createExecutableExtensi on(ConfigurationElement.java:124) at org.eclipse.core.internal.registry.ConfigurationElement.createExecutableExtensi on(ConfigurationElement.java:113) at org.eclipse.ui.internal.registry.InstanceTracker.getExecutableExtension (InstanceTracker.java:64) at org.eclipse.ui.internal.registry.PerspectiveDescriptor.createFactory (PerspectiveDescriptor.java:179) at org.eclipse.ui.internal.Perspective.loadPredefinedPersp (Perspective.java:654) at org.eclipse.ui.internal.Perspective.createPresentation(Perspective.java:229) at org.eclipse.ui.internal.Perspective.<init>(Perspective.java:123) at org.eclipse.ui.internal.WorkbenchPage.createPerspective (WorkbenchPage.java:1159) at org.eclipse.ui.internal.WorkbenchPage.busySetPerspective (WorkbenchPage.java:760) at org.eclipse.ui.internal.WorkbenchPage.access$8(WorkbenchPage.java:752) at org.eclipse.ui.internal.WorkbenchPage$12.run(WorkbenchPage.java:3019) at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:69) at org.eclipse.ui.internal.WorkbenchPage.setPerspective (WorkbenchPage.java:3017) at org.eclipse.ui.internal.ChangeToPerspectiveMenu.run (ChangeToPerspectiveMenu.java:88) at org.eclipse.ui.actions.PerspectiveMenu.run(PerspectiveMenu.java:306) at org.eclipse.ui.actions.PerspectiveMenu$3.widgetSelected (PerspectiveMenu.java:117) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:89) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:82) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:800) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:2794) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2448) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1527) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1498) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:276) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:144) at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:102) at org.eclipse.core.internal.runtime.PlatformActivator$1.run (PlatformActivator.java:335) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:273) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:129) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:324) at org.eclipse.core.launcher.Main.basicRun(Main.java:185) at org.eclipse.core.launcher.Main.run(Main.java:704) at org.eclipse.core.launcher.Main.main(Main.java:688) | verified fixed | dc8ae1f | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/Perspective.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-22T14:35:03Z | 2004-11-02T12:53:20Z |
88,352 | Bug 88352 Operation supports leaks contexts via action handler | I20050315-1100 Susan, this is a different leak from the one that I reported. Test Case: 1. open text editor 2. close text editor ==> DefaultUndoManager is leaked due to undo/redo actions handlers still holding on to the context. | verified fixed | f2e3de5 | ["bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/AbstractOperation.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/DefaultOperationHistory.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/IOperationHistory.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/IUndoableOperation.java", "bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/operations/ObjectUndoContext.java", "bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/navigator/ResourceNavigator.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/misc/Policy.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/operations/OperationHistoryActionHandler.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/operations/RedoActionHandler.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/operations/UndoActionHandler.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/operations/UndoRedoActionGroup.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/operations/WorkbenchOperationSupport.java", "tests/org.eclipse.ui.tests/Eclipse", "UI", "Tests/org/eclipse/ui/tests/operations/OperationsAPITest.java", "tests/org.eclipse.ui.tests/Eclipse", "UI", "Tests/org/eclipse/ui/tests/operations/TestOperation.java", "tests/org.eclipse.ui.tests/Eclipse", "UI", "Tests/org/eclipse/ui/tests/operations/WorkbenchOperationHistoryTests.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-21T23:34:59Z | 2005-03-17T17:20:00Z |
67,890 | Bug 67890 [PropertiesView] Exception when entries added to properties view | null | verified fixed | bc8051c | ["bundles/org.eclipse.ui.ide/src/org/eclipse/ui/views/properties/ResourcePropertySource.java", "bundles/org.eclipse.ui.views/src/org/eclipse/ui/views/properties/PropertySheetEntry.java", "bundles/org.eclipse.ui.views/src/org/eclipse/ui/views/properties/PropertySheetViewer.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-21T21:48:10Z | 2004-06-18T20:20:00Z |
88,191 | Bug 88191 [Preferences] Temporary shell created in PreferenceConverter | org.eclipse.jface.preference.PreferenceConverter has this code to set its default font data: Shell shell = new Shell(); FONTDATA_ARRAY_DEFAULT_DEFAULT = shell.getFont().getFontData(); shell.dispose(); Rather than creating an extra Shell, is it not sufficient to use display.getSystemFont() ? | verified fixed | ee19a1c | ["bundles/org.eclipse.jface/src/org/eclipse/jface/preference/PreferenceConverter.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-21T20:22:08Z | 2005-03-16T16:20:00Z |
58,617 | Bug 58617 [Dialogs] DCR: Make StatusDialog public API | 20040415 StatusDialog is an extension of Dialog, having an ok and cancel button with a status line. Status is set using 'updateStatus'. It is similar that the SelectionStatusDialog which is in 'org.eclipse.ui.dialogs'. It also handles that usability rule that says that no dialog should come up with an error message. There are already 6 duplications of the StatusDialog (in 6 plugins). I would like to make another dialog public that extend StatusDialog. Offering StatusDialog as API in jdt.ui is not optimal and merging the functionality is also a bit ugly. | verified fixed | 19c503c | ["bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/StatusDialog.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-21T15:30:06Z | 2004-04-15T09:06:40Z |
86,011 | Bug 86011 [Wizards] Need to support creating multiple folders at once | It is currently not possible to create more than one folder at a time using the New folder wizard like it is with the import dialogs for instance. We would need to change ResourceAndContainerGroup so that it accepted paths in validateResourceName() and WizardNewFolderPage to build these. | verified fixed | 9e31f03 | ["bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/dialogs/WizardNewFileCreationPage.java", "bundles/org.eclipse.ui.ide/extensions/org/eclipse/ui/dialogs/WizardNewFolderMainPage.java", "bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/misc/ResourceAndContainerGroup.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-21T14:41:40Z | 2005-02-21T21:06:40Z |
87,111 | Bug 87111 [Dialogs] Feature: add general-purpose page change notification for dialogs | New dynamic help pane attaches itself to all the dialogs that JFace provides. Some of these dialogs manage multiple pages but dynamic help has no way of registering for page change notification. Examples of dialogs that exhibit this behaviour are WizardDialog, PreferenceDialog, LaunchConfigurationDialog (in Debug), PropertiesDialog etc. Attached is the code for the following proposed enhancement: 1) A new interface 'IBaseDialogPage' that interfaces like IDialogPage and ILaunchConfigurationTab can extend 2) A class PageChangedEvent for page change notification 3) A new interface 'IPageChangeProvider' 4) A new interface 'IPageChangedListener' In the attached patch, WizardDialog and PreferenceDialog implement IPageChangeProvider and notify page changed listeners whenever current page changes. This allows dynamic help to update its content and show the relevant help for the currently selected page. Since IBaseDialogPage is now a base interface for IDialogPage, two methods (getTitle() and getControl()) are moved up from IDialogPage. This is consistent with ILaunchConfigurationTab and does not clash with any existing method. | verified fixed | 1ed996e | ["bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/IPageChangeProvider.java", "bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/IPageChangedListener.java", "bundles/org.eclipse.jface/src/org/eclipse/jface/dialogs/PageChangedEvent.java", "bundles/org.eclipse.jface/src/org/eclipse/jface/preference/PreferenceDialog.java", "bundles/org.eclipse.jface/src/org/eclipse/jface/wizard/WizardDialog.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-21T14:19:34Z | 2005-03-03T22:46:40Z |
88,634 | Bug 88634 [ActivityMgmt] move activity image binding to the activitySupport extension point | Images are really peripheral to activities and their declaration should be moved to the activitySupport extension point | verified fixed | 020d258 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/activities/ws/ImageBindingRegistry.java", "tests/org.eclipse.ui.tests/Eclipse", "UI", "Tests/org/eclipse/ui/tests/activities/ActivitiesTestSuite.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-21T14:07:35Z | 2005-03-21T13:00:00Z |
88,635 | Bug 88635 [EditorMgmt] add performance tracking for content type resolution | This operation could be expensive and should be tracked. | verified fixed | 2d8b474 | ["bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/IDE.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/misc/UIStats.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-21T13:51:08Z | 2005-03-21T13:00:00Z |
88,604 | Bug 88604 [EditorMgmt] [Perspectives] NPE in PerspectiveListenerList.fireEvent when debug flag is on | build I20050315 + latest UI from head When running the tests, the perspective-oriented tests in IWorkbenchPageTests fail with an NPE like the following Thread [main] (Suspended (exception NullPointerException)) PerspectiveListenerList.fireEvent(SafeRunnable, IPerspectiveListener, IPerspectiveDescriptor, String) line: 55 PerspectiveListenerList.firePerspectiveChanged(IWorkbenchPage, IPerspectiveDescriptor, String) line: 107 WorkbenchWindow.firePerspectiveChanged(IWorkbenchPage, IPerspectiveDescriptor, String) line: 1035 WorkbenchPage.closeEditors(IEditorReference[], boolean) line: 1041 WorkbenchPage.closeAllEditors(boolean) line: 967 WorkbenchPage.dispose() line: 1334 WorkbenchWindow.closePage(IWorkbenchPage, boolean) line: 698 WorkbenchPage$5.run() line: 933 BusyIndicator.showWhile(Display, Runnable) line: 69 WorkbenchPage.close() line: 931 IWorkbenchPageTest.testGetOpenPerspectives() line: 1606 NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method] NativeMethodAccessorImpl.invoke(Object, Object[]) line: 85 NativeMethodAccessorImpl.invoke(Method, Object, Object[]) line: 58 DelegatingMethodAccessorImpl.invoke(Method, Object, Object[]) line: 60 Method.invoke(Object, Object[]) line: 391 IWorkbenchPageTest(TestCase).runTest() line: 154 IWorkbenchPageTest(TestCase).runBare() line: 127 TestResult$1.protect() line: 106 TestResult.runProtected(Test, Protectable) line: 124 TestResult.run(TestCase) line: 109 IWorkbenchPageTest(TestCase).run(TestResult) line: 118 TestSuite.runTest(Test, TestResult) line: 208 TestSuite.run(TestResult) line: 203 ApiTestSuite(TestSuite).runTest(Test, TestResult) line: 208 ApiTestSuite(TestSuite).run(TestResult) line: 203 UiTestSuite(TestSuite).runTest(Test, TestResult) line: 208 UiTestSuite(TestSuite).run(TestResult) line: 203 RemotePluginTestRunner(RemoteTestRunner).runTests(String[], String) line: 474 RemotePluginTestRunner(RemoteTestRunner).run() line: 342 RemotePluginTestRunner.main(String[]) line: 36 UITestApplication$1.run() line: 110 RunnableLock.run() line: 35 UISynchronizer(Synchronizer).runAsyncMessages(boolean) line: 118 Display.runAsyncMessages(boolean) line: 2873 Display.readAndDispatch() line: 2532 Workbench.runEventLoop(Window$IExceptionHandler, Display) line: 1501 Workbench.runUI() line: 1465 Workbench.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 305 PlatformUI.createAndRunWorkbench(Display, WorkbenchAdvisor) line: 143 IDEApplication.run(Object) line: 103 UITestApplication.run(Object) line: 39 PlatformActivator$1.run(Object) line: 228 EclipseStarter.run(Object) line: 338 EclipseStarter.run(String[], Runnable) line: 151 NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method] NativeMethodAccessorImpl.invoke(Object, Object[]) line: 85 NativeMethodAccessorImpl.invoke(Method, Object, Object[]) line: 58 DelegatingMethodAccessorImpl.invoke(Method, Object, Object[]) line: 60 Method.invoke(Object, Object[]) line: 391 Main.invokeFramework(String[], URL[]) line: 315 Main.basicRun(String[]) line: 268 Main.run(String[]) line: 942 Main.main(String[]) line: 926 Lines 54 and 55 of PerspectiveListenerList are: if (UIStats.isDebugging(UIStats.NOTIFY_PERSPECTIVE_LISTENERS)) { label = description + perspective.getId(); It's failing because perspective is null. This is only hit when -debug is set (NOTIFY_PERSPECTIVE_LISTENERS is now on by default when -debug is set). | verified fixed | 35396f8 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/WorkbenchPage.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/WorkbenchWindow.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-21T00:50:13Z | 2005-03-21T01:53:20Z |
85,506 | Bug 85506 [Import/Export] [Preferences] import preference wizard uses a "save" dialog. | I20050215-2300 The import preferences wizard provides a browse button to select the file you wish to import from. However, it creates a Save As dialog. When you select the file you wish to import you are greeted with a warning that the file will be overwritten. No such thing occurrs, and otherwise the import succeeds. | verified fixed | d526694 | ["bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/preferences/PreferencesMessages.java", "bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/preferences/WizardPreferencesExportPage1.java", "bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/preferences/WizardPreferencesImportPage1.java", "bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/wizards/preferences/WizardPreferencesPage.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-18T21:30:20Z | 2005-02-16T18:53:20Z |
88,273 | Bug 88273 [ViewMgmt] (regression) Show view dialog does not remember last selection or expanded state | null | verified fixed | e94da57 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/ViewRegistry.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-17T14:09:24Z | 2005-03-17T03:26:40Z |
86,610 | Bug 86610 Lots of Worker threads (around 100) | 3.1 M5a When running all our tests together (see attached class AllZRZHTests.java) on our buildmachine (Linux Fedora Core using Sun VM 1.4.2_06) we see that more and more Worker threads get created but not terminated. When the last test cases are reached, tons of "java.lang.StackOverflowError" are written to the console but no stack trace. The .log is empty. Note: - this worked with 3.1 M4 i.e. no errors written to the Console. - this still works when using another VM but the amount of Workers is huge too When running in the Debugger the VM often "dies" (or freezes) and the tests never finish. I put a breakpoint into the Worker constructor and it looked as if the DecorationScheduler is causing the creation of the Worker in the UI/main thread. I would expect that there's an upper bound for the Workers and unused Workers get removed again. | verified fixed | 23e6571 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/decorators/DecorationScheduler.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-16T21:49:15Z | 2005-02-25T11:13:20Z |
88,137 | Bug 88137 [Model] NPE on editor resource save | When the editor part has no title tool tip set (null) or when there is an editor input with null toolTipText the EditorPart.getTitleToolTip() will return null. This will result in NPE thrown in org.eclipse.ui.mode.WorkbenchPartLabelProvider.getText(Object) at line 56: String path = part.getTitleToolTip(); if (path.length() == 0) { <-- NPE here return part.getTitle(); } else { return part.getTitle() + " [" + part.getTitleToolTip() + "]"; //$NON-NLS-1$ //$NON-NLS-2$ } when this editor part is dirty and the workbench is closed. To fix: modify the code as String path = part.getTitleToolTip(); if (path == null || path.trim().length() == 0) { return part.getTitle(); } else { return part.getTitle() + " [" + path + "]"; //$NON-NLS-1$ //$NON-NLS-2$ } | verified fixed | 7472e07 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/model/WorkbenchPartLabelProvider.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-16T17:21:56Z | 2005-03-15T23:40:00Z |
88,175 | Bug 88175 NPE opening ShowViewDialog | 20040315 with platform-ui from HEAD When I open the ShowView dialog I get the following NPE !ENTRY org.eclipse.ui 4 0 2005-03-16 09:35:51.555 !MESSAGE java.lang.NullPointerException !STACK 0 java.lang.NullPointerException at org.eclipse.ui.internal.dialogs.ViewSorter.compare(ViewSorter.java:46) at org.eclipse.jface.viewers.ViewerSorter$1.compare(ViewerSorter.java:177) at java.util.Arrays.mergeSort(Arrays.java:1292) at java.util.Arrays.mergeSort(Arrays.java:1303) at java.util.Arrays.sort(Arrays.java:1233) at org.eclipse.jface.viewers.ViewerSorter.sort(ViewerSorter.java:175) at org.eclipse.jface.viewers.StructuredViewer.getSortedChildren(StructuredViewer.java:827) at org.eclipse.jface.viewers.AbstractTreeViewer$1.run(AbstractTreeViewer.java:381) at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:69) at org.eclipse.jface.viewers.AbstractTreeViewer.createChildren(AbstractTreeViewer.java:363) at org.eclipse.jface.viewers.AbstractTreeViewer$5.run(AbstractTreeViewer.java:834) at org.eclipse.jface.viewers.StructuredViewer.preservingSelection(StructuredViewer.java:1109) at org.eclipse.jface.viewers.AbstractTreeViewer.inputChanged(AbstractTreeViewer.java:824) at org.eclipse.jface.viewers.ContentViewer.setInput(ContentViewer.java:248) at org.eclipse.jface.viewers.StructuredViewer.setInput(StructuredViewer.java:1323) at org.eclipse.ui.internal.dialogs.ShowViewDialog.createViewer(ShowViewDialog.java:160) at org.eclipse.ui.internal.dialogs.ShowViewDialog.createDialogArea(ShowViewDialog.java:138) at org.eclipse.jface.dialogs.Dialog.createContents(Dialog.java:685) at org.eclipse.jface.window.Window.create(Window.java:416) at org.eclipse.jface.dialogs.Dialog.create(Dialog.java:994) at org.eclipse.jface.window.Window.open(Window.java:768) at org.eclipse.ui.internal.commands.ws.ShowViewHandler.openOther(ShowViewHandler.java:68) at org.eclipse.ui.internal.commands.ws.ShowViewHandler.execute(ShowViewHandler.java:48) at org.eclipse.ui.internal.ShowViewMenu$2.run(ShowViewMenu.java:71) at org.eclipse.jface.action.Action.runWithEvent(Action.java:1003) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:557) at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:507) at org.eclipse.jface.action.ActionContributionItem$6.handleEvent(ActionContributionItem.java:421) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:82) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:842) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:2894) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2527) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1520) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1484) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:305) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:143) at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:103) at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:228) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:338) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:151) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:85) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:58) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:60) at java.lang.reflect.Method.invoke(Method.java:391) at org.eclipse.core.launcher.Main.invokeFramework(Main.java:268) at org.eclipse.core.launcher.Main.basicRun(Main.java:260) at org.eclipse.core.launcher.Main.run(Main.java:887) at org.eclipse.core.launcher.Main.main(Main.java:871) | verified fixed | 9b9698e | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/dialogs/ViewSorter.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-16T14:58:02Z | 2005-03-16T13:33:20Z |
88,116 | Bug 88116 [ViewMgmt] ClassCastException in show view dialog | HEAD on 2005/03/15 There is a CCE when you try and open a view in the show view dialog. Introduced with the view category changes. | verified fixed | f41cf09 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/dialogs/ShowViewDialog.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/dialogs/ViewSorter.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/ViewRegistry.java", "tests/org.eclipse.ui.tests/Eclipse", "UI", "Tests/org/eclipse/ui/tests/dynamicplugins/ViewTests.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-15T21:09:35Z | 2005-03-15T20:53:20Z |
48,138 | Bug 48138 [Dialogs] Public API for ContainerCheckedTreeViewer, ResourceTreeAndListGroup | These are very useful classes. They are good for use in wizards. | verified fixed | 0de2fdc | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/dialogs/CheckedTreeSelectionDialog.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/dialogs/ContainerCheckedTreeViewer.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/dialogs/ContainerCheckedTreeViewer.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-15T20:19:54Z | 2003-12-05T10:26:40Z |
86,166 | Bug 86166 [Preferences] need preference pages for content types | null | verified fixed | b06c770 | ["bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/IDEWorkbenchMessages.java", "bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/ContentTypesPreferencePage.java", "bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/dialogs/NewContentTypeFileAssociationDialog.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-15T19:29:37Z | 2005-02-22T16:33:20Z |
53,176 | Bug 53176 [KeyBindings] misc: WorkbenchContextSupport should not add/remove key filter more than once | On platform-swt-dev, its becoming more known that Display.addFilter(..) exists, and people may (will) use it to circumvent our system in some cases. My big concern is that the method WorkbenchCommandSupport.setKeyFilterEnabled adds and removes us from Display's listener list. If other clients are adding listeners to this list, the order of the listeners in this list will change over time. Could this inconsistency not lead to bugs - those ferocious, nearly undebuggable kind that eventually someone will sweat over for days. | verified fixed | 0289d1e | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/contexts/ws/WorkbenchContextSupport.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/keys/WorkbenchKeyboard.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-15T16:22:50Z | 2004-02-26T15:40:00Z |
87,951 | Bug 87951 [ViewMgmt] View registry API exposes internal Category class | 3.1 M5 IViewRegistry has: public Category[] getCategories(); but Category is internal. Either we need to provide an IViewCategory (similar to IWizardCategory) or provide a shared ICategory interface that can be used across multiple extension registries. | verified fixed | 23cbb9b | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/dialogs/CustomizePerspectiveDialog.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/dialogs/ViewContentProvider.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/dialogs/ViewLabelProvider.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/Category.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/IWorkbenchRegistryConstants.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/OpenPerspectiveHandler.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/PerspectiveDescriptor.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/PerspectiveRegistryReader.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/StickyViewDescriptor.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/ViewDescriptor.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/ViewRegistry.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/registry/ViewRegistryReader.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/views/IViewCategory.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/views/IViewRegistry.java", "tests/org.eclipse.ui.tests/Eclipse", "UI", "Tests/org/eclipse/ui/tests/dynamicplugins/ViewTests.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-15T12:35:21Z | 2005-03-14T17:06:40Z |
86,633 | Bug 86633 [Themes] Cascading*Registry should not use Display.getCurrent().asyncExec | 3.1 M5 org.eclipse.ui.internal.themes.CascadingColorRegistry.dispose() org.eclipse.ui.internal.themes.CascadingFontRegistry.dispose() have the following pattern: Display.getCurrent().asyncExec(displayRunnable); If this is not running in the UI thread, then Display.getCurrent() will return null. If it is running in the UI thread, can the code not be called immediately? If it does need to be deferred until events run (are they even guaranteed to run after the registry is disposed?), then I suggest using IWorkbench.getDisplay() instead. | verified fixed | 640f958 | ["bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/themes/CascadingColorRegistry.java", "bundles/org.eclipse.ui.workbench/Eclipse", "UI/org/eclipse/ui/internal/themes/CascadingFontRegistry.java"] | Eclipse_Platform_UI | https://github.com/eclipse-platform/eclipse.platform.ui | eclipse-platform/eclipse.platform.ui | java | null | null | null | 2005-03-14T21:04:05Z | 2005-02-25T14:00:00Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.