instance_id stringlengths 17 39 | repo stringclasses 8
values | issue_id stringlengths 14 34 | pr_id stringlengths 14 34 | linking_methods listlengths 1 3 | base_commit stringlengths 40 40 | merge_commit stringlengths 0 40 ⌀ | hints_text listlengths 0 106 | resolved_comments listlengths 0 119 | created_at timestamp[ns, tz=UTC] | labeled_as listlengths 0 7 | problem_title stringlengths 7 174 | problem_statement stringlengths 0 55.4k | gold_files listlengths 0 10 | gold_files_postpatch listlengths 1 10 | test_files listlengths 0 60 | gold_patch stringlengths 220 5.83M | test_patch stringlengths 386 194k ⌀ | split_random stringclasses 3
values | split_time stringclasses 3
values | issue_start_time timestamp[ns] | issue_created_at timestamp[ns, tz=UTC] | issue_by_user stringlengths 3 21 | split_repo stringclasses 3
values |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
pinpoint-apm/pinpoint/4630_4694 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/4630 | pinpoint-apm/pinpoint/4694 | [
"keyword_issue_to_pr"
] | f1e3a14ea2e65945f456c9aacc995a968a3dd0e0 | 071836693df5dd563215b9422ef33869c6cf52d5 | [
"I found that there isn't \" java.lang.management\" in the IBM JDK 1.6\r\nSo pp-agent can't suppot the IBM JDK 1.6, is it right?\r\n@emeroad\r\n\r\n\r\n\r\n\r\n` method? \r\nIt should be there as per the [documentation]( https://www.ibm.com/support/knowledgecenter/en/SSYKE2_6.0.0/com.ibm.java.api.60.doc/com.ibm... | [] | 2018-10-01T10:01:03Z | [
"question"
] | pinpoint start failed. | After deploymented agent1.70 ,the following error after start the websphere server:
native_stderr.log:
2017-11-21 14:40:30 [WARN ](com.navercorp.pinpoint.bootstrap.PinpointStarter) pinpoint start failed.
com.navercorp.pinpoint.bootstrap.BootStrapException: execute fail. Error:null
at com.navercorp.pinpoint.bo... | [
"bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/classloader/BootLoaderFactory.java",
"bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/classloader/J9BootLoader.java",
"commons/src/main/java/com/navercorp/pinpoint/common/util/JvmType.java",
"profiler-optional/profiler-optional-jdk6/... | [
"bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/classloader/BootLoaderFactory.java",
"bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/classloader/J9BootLoader.java",
"commons/src/main/java/com/navercorp/pinpoint/common/util/JvmType.java",
"profiler-optional/profiler-optional-jdk6/... | [] | diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/classloader/BootLoaderFactory.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/classloader/BootLoaderFactory.java
index f16ce008cb6e..da036fdac33a 100644
--- a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/cla... | null | train | test | 2018-10-01T10:11:31 | 2017-11-21T07:54:36Z | saver123sc | test |
pinpoint-apm/pinpoint/4698_4699 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/4698 | pinpoint-apm/pinpoint/4699 | [
"keyword_pr_to_issue"
] | 6f136c24ff92d6641a12f46fa132c9e09c336a30 | 5448471fd5fdc1711f27b9919dcb6c94ded18cc6 | [
"Hello, @bbvch13531 \r\n\r\nOf course, Go ahead. Let us know when you finish",
"Hi @RoySRose, Thank you for your kind answer. 😃 \r\nI send PR #4699. \r\nPTAL!"
] | [] | 2018-10-03T03:01:12Z | [] | There are typo in doc/per-request_feature_guide.md | <!--
Please be as detailed as possible so that we can help answer your question as quickly as possible.
-->
There are typo in doc/per-request_feature_guide.md
line 288: `로그 메세지` -> `log message` for consistency
line 289: `출려된` -> `출력된` typo
line 511: `추가되야` -> `추가돼야` typo
Also other spacing grammer erro... | [
"doc/per-request_feature_guide.md"
] | [
"doc/per-request_feature_guide.md"
] | [] | diff --git a/doc/per-request_feature_guide.md b/doc/per-request_feature_guide.md
index 0aff94bcb84a..6731d35e4d45 100644
--- a/doc/per-request_feature_guide.md
+++ b/doc/per-request_feature_guide.md
@@ -279,18 +279,18 @@ For details in how the log buttons are generated, please refer to Pinpoint Web
### 1. 기능 설명
-P... | null | test | test | 2018-10-02T07:09:12 | 2018-10-03T02:57:40Z | bbvch13531 | test |
pinpoint-apm/pinpoint/4755_4763 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/4755 | pinpoint-apm/pinpoint/4763 | [
"keyword_pr_to_issue"
] | adb4cc9a1a7e0a820f43aa6cb63ed4ee4e111cfb | 0c579d661a55e8444c97483d2d407052987bc723 | [] | [] | 2018-10-17T09:54:25Z | [
"enhancement",
"module:plugin"
] | Add support for spring-amqp-rabbit 2.1.0.RELEASE | #### Description
Constructor for `org.springframework.amqp.rabbit.support.Delivery` got an extra parameter in 2.1.0.RELEASE.
`org.springframework.amqp.rabbit.listener.BlockingQueueConsumer$ConsumerDecorator` has been removed in 2.1.0.RELEASE. | [
"plugins/rabbitmq/src/main/java/com/navercorp/pinpoint/plugin/rabbitmq/client/RabbitMQClientPlugin.java"
] | [
"plugins/rabbitmq/src/main/java/com/navercorp/pinpoint/plugin/rabbitmq/client/RabbitMQClientPlugin.java"
] | [
"agent-it/src/test/java/com/navercorp/pinpoint/plugin/jdk7/rabbitmq/spring/SpringAmqpRabbit_1_7_7_to_2_0_0_IT.java",
"agent-it/src/test/java/com/navercorp/pinpoint/plugin/jdk7/rabbitmq/spring/SpringAmqpRabbit_2_0_3_to_2_1_0_IT.java",
"agent-it/src/test/java/com/navercorp/pinpoint/plugin/jdk7/rabbitmq/spring/Spr... | diff --git a/plugins/rabbitmq/src/main/java/com/navercorp/pinpoint/plugin/rabbitmq/client/RabbitMQClientPlugin.java b/plugins/rabbitmq/src/main/java/com/navercorp/pinpoint/plugin/rabbitmq/client/RabbitMQClientPlugin.java
index fe0a042d21ef..930eb5699c53 100644
--- a/plugins/rabbitmq/src/main/java/com/navercorp/pinpoint... | diff --git a/agent-it/src/test/java/com/navercorp/pinpoint/plugin/jdk7/rabbitmq/spring/SpringAmqpRabbit_1_7_7_to_2_0_0_IT.java b/agent-it/src/test/java/com/navercorp/pinpoint/plugin/jdk7/rabbitmq/spring/SpringAmqpRabbit_1_7_7_to_2_0_0_IT.java
index a7e725ce595b..e369b45d0f4c 100644
--- a/agent-it/src/test/java/com/nave... | test | test | 2018-10-17T08:17:48 | 2018-10-16T09:19:10Z | Xylus | test |
pinpoint-apm/pinpoint/4798_4799 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/4798 | pinpoint-apm/pinpoint/4799 | [
"keyword_pr_to_issue"
] | 6b218601e88cc1795c0ab3b9db5555d59a53e774 | 9b97968a49122284a33daec06cc34ca225eaffe6 | [] | [] | 2018-10-25T06:28:54Z | [
"enhancement",
"module:plugin"
] | Replace embedded Cassandra with stubbed Cassandra for Datastax plugin integration tests | #### Description
Starting and stopping embedded Cassandra for every Datastax plugin integration test (for every version of Datastax java driver) was a bit too heavy and took too long.
It would also very occasionally hang the forked JVM process if embedded Cassandra was not started up or initialized correctly/promptly... | [
"agent-it/pom.xml",
"plugins/cassandra/src/main/java/com/navercorp/pinpoint/plugin/cassandra/CassandraPlugin.java",
"plugins/cassandra/src/main/java/com/navercorp/pinpoint/plugin/cassandra/interceptor/CassandraStatementExecuteQueryInterceptor.java"
] | [
"agent-it/pom.xml",
"plugins/cassandra/src/main/java/com/navercorp/pinpoint/plugin/cassandra/CassandraPlugin.java",
"plugins/cassandra/src/main/java/com/navercorp/pinpoint/plugin/cassandra/field/WrappedStatementGetter.java",
"plugins/cassandra/src/main/java/com/navercorp/pinpoint/plugin/cassandra/interceptor/... | [
"agent-it/src/test/java/com/navercorp/pinpoint/plugin/jdk7/cassandra/CassandraDatastaxITBase.java",
"agent-it/src/test/java/com/navercorp/pinpoint/plugin/jdk7/cassandra/CassandraDatastax_2_0_x_IT.java",
"agent-it/src/test/java/com/navercorp/pinpoint/plugin/jdk7/cassandra/CassandraDatastax_2_1_x_IT.java",
"age... | diff --git a/agent-it/pom.xml b/agent-it/pom.xml
index 4f49e28169fa..bfd4e9756941 100644
--- a/agent-it/pom.xml
+++ b/agent-it/pom.xml
@@ -207,9 +207,9 @@
<scope>test</scope>
</dependency>
<dependency>
- <groupId>org.apache.cassandra</groupId>
- <artifactId>cassandra... | diff --git a/agent-it/src/test/java/com/navercorp/pinpoint/plugin/jdk7/cassandra/CassandraDatastaxITBase.java b/agent-it/src/test/java/com/navercorp/pinpoint/plugin/jdk7/cassandra/CassandraDatastaxITBase.java
index c0da2aca8637..00b88ce46739 100644
--- a/agent-it/src/test/java/com/navercorp/pinpoint/plugin/jdk7/cassand... | test | test | 2018-10-24T09:50:56 | 2018-10-25T06:02:16Z | Xylus | test |
pinpoint-apm/pinpoint/4367_4805 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/4367 | pinpoint-apm/pinpoint/4805 | [
"keyword_pr_to_issue"
] | caa438cab57d5dbfacfec200de12363a5f584d93 | a844abba1f8f4cbd7fe64a7da178e1eef13b7aaf | [
"Hello, @VictorZeng \r\n\r\nWe hope that we can provide all the features. But unfortunately, it's not easy due to lack of time.\r\nIt would be GREAT for Pinpoint Community if you can make Hbase-plugin and share with us:)",
"@RoySRose I will make the Hbase-plugin.",
"@VictorZeng \r\nOh! Perfect~! We are really l... | [] | 2018-10-26T06:08:36Z | [
"enhancement",
"module:plugin"
] | Why is there no Hbase plugin support? | **Which module is your feature request related to?**
Plugin/Hbase
**Is your feature request related to a problem?**
A clear and concise description of what the problem is.
**Describe the solution you'd like**
Hbase GET/PUT/DELETE/SCAN etc
**Describe alternatives you've considered**
A clear and concise desc... | [
"plugins/hbase/pom.xml",
"plugins/hbase/src/main/java/com/navercorp/pinpoint/plugin/hbase/interceptor/HbaseTableMethodInterceptor.java"
] | [
"plugins/hbase/pom.xml",
"plugins/hbase/src/main/java/com/navercorp/pinpoint/plugin/hbase/interceptor/HbaseTableMethodInterceptor.java"
] | [
"agent-it/src/test/java/com/navercorp/pinpoint/plugin/hbase/HbaseClientIT.java"
] | diff --git a/plugins/hbase/pom.xml b/plugins/hbase/pom.xml
index 43e62534ee35..db1e83651b21 100644
--- a/plugins/hbase/pom.xml
+++ b/plugins/hbase/pom.xml
@@ -27,12 +27,35 @@
<name>pinpoint-hbase-plugin</name>
<packaging>jar</packaging>
+ <properties>
+ <jdk.version>1.6</jdk.version>
+ <jdk... | diff --git a/agent-it/src/test/java/com/navercorp/pinpoint/plugin/hbase/HbaseClientIT.java b/agent-it/src/test/java/com/navercorp/pinpoint/plugin/hbase/HbaseClientIT.java
index f0f57f671ee9..d437fc16f414 100644
--- a/agent-it/src/test/java/com/navercorp/pinpoint/plugin/hbase/HbaseClientIT.java
+++ b/agent-it/src/test/j... | train | test | 2018-10-26T08:07:11 | 2018-07-14T01:50:25Z | VictorZeng | test |
pinpoint-apm/pinpoint/4723_4830 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/4723 | pinpoint-apm/pinpoint/4830 | [
"keyword_pr_to_issue"
] | 49a454e165d47e5d7e6fc81c2ba299dc0a8e2f5a | 8a55efc2246d0cbb8f3e9df1fd018598894f4c6a | [
"Hi @pikuzi \r\nAre you using okhttp version 2.7.x?\r\nWe add a getter for `private Connection connection` field in **HttpEngine** to use it in our interceptor but okhttp 2.7.0+ does not have this field. This would have led to your issue.\r\nWe'll try to fix this for 1.8.1 (or you could cook up a fix and throw us a... | [] | 2018-10-31T09:41:45Z | [] | com.navercorp.pinpoint.bootstrap.instrument.InstrumentException: Failed to add getter: com.navercorp.pinpoint.plugin.okhttp.v2.ConnectionGetter | **What version of pinpoint are you using?**
v1.7.3
**Describe your problem**
I have one java application which can not post interaction data from pp agent to pp collector.
I can see the agent was registered successfully in the application list from pp web, but there is no any line which connects to other apps.
F... | [
"agent-it/pom.xml",
"plugins/okhttp/src/main/java/com/navercorp/pinpoint/plugin/okhttp/v2/OkHttpPlugin.java",
"plugins/okhttp/src/main/java/com/navercorp/pinpoint/plugin/okhttp/v2/interceptor/HttpEngineReadResponseMethodInterceptor.java",
"plugins/okhttp/src/main/java/com/navercorp/pinpoint/plugin/okhttp/v2/i... | [
"agent-it/pom.xml",
"plugins/okhttp/src/main/java/com/navercorp/pinpoint/plugin/okhttp/v2/OkHttpPlugin.java",
"plugins/okhttp/src/main/java/com/navercorp/pinpoint/plugin/okhttp/v2/interceptor/HttpEngineConnectMethodFromUserRequestInterceptor.java",
"plugins/okhttp/src/main/java/com/navercorp/pinpoint/plugin/o... | [
"agent-it/src/test/java/com/navercorp/pinpoint/plugin/jdk7/okhttp/OkHttpClient_2_x_IT.java",
"agent-it/src/test/java/com/navercorp/pinpoint/plugin/jdk7/okhttp/OkHttpClient_3_0_0_to_3_3_x_IT.java",
"agent-it/src/test/java/com/navercorp/pinpoint/plugin/jdk7/okhttp/OkHttpClient_3_4_0_to_3_x_IT.java"
] | diff --git a/agent-it/pom.xml b/agent-it/pom.xml
index bfd4e9756941..a96b3cb54eae 100644
--- a/agent-it/pom.xml
+++ b/agent-it/pom.xml
@@ -188,11 +188,15 @@
<scope>test</scope>
</dependency>
-
<dependency>
<groupId>com.squareup.okhttp</groupId>
<artifactId>okht... | diff --git a/agent-it/src/test/java/com/navercorp/pinpoint/plugin/jdk7/okhttp/OkHttpClientBackwardCompatibilityIT.java b/agent-it/src/test/java/com/navercorp/pinpoint/plugin/jdk7/okhttp/OkHttpClientBackwardCompatibilityIT.java
deleted file mode 100644
index bd0298537a4e..000000000000
--- a/agent-it/src/test/java/com/na... | val | test | 2018-10-31T09:09:34 | 2018-10-11T09:13:24Z | pikuzi | test |
pinpoint-apm/pinpoint/4873_4880 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/4873 | pinpoint-apm/pinpoint/4880 | [
"keyword_pr_to_issue"
] | 6ba94ec415c54382d3939810649e31f03a2fabe9 | 987c2e61b7996e5f3e2915852347ff821878a587 | [] | [] | 2018-11-09T09:11:06Z | [
"enhancement",
"module:plugin"
] | Add trace support when using Thrift over HTTP | #### Description
When using Thrift over HTTP (using **THttpClient** and **TServlet**), jdk/apache http client is used internally to send HTTP request client side. Similarly, **TServlet** operates inside a servlet container, and the container will process these requests first.
We have plugins for both of these, so the... | [
"agent-it/pom.xml",
"plugins/thrift/src/main/java/com/navercorp/pinpoint/plugin/thrift/ThriftClientCallContext.java",
"plugins/thrift/src/main/java/com/navercorp/pinpoint/plugin/thrift/ThriftConstants.java",
"plugins/thrift/src/main/java/com/navercorp/pinpoint/plugin/thrift/ThriftPlugin.java",
"plugins/thri... | [
"agent-it/pom.xml",
"plugins/thrift/src/main/java/com/navercorp/pinpoint/plugin/thrift/ThriftClientCallContext.java",
"plugins/thrift/src/main/java/com/navercorp/pinpoint/plugin/thrift/ThriftConstants.java",
"plugins/thrift/src/main/java/com/navercorp/pinpoint/plugin/thrift/ThriftPlugin.java",
"plugins/thri... | [
"agent-it/src/test/java/com/navercorp/pinpoint/plugin/thrift/common/TestEnvironment.java",
"agent-it/src/test/java/com/navercorp/pinpoint/plugin/thrift/common/client/AsyncEchoTestClient.java",
"agent-it/src/test/java/com/navercorp/pinpoint/plugin/thrift/common/client/HttpEchoTestClient.java",
"agent-it/src/te... | diff --git a/agent-it/pom.xml b/agent-it/pom.xml
index 12c67cd20112..618c0d830418 100644
--- a/agent-it/pom.xml
+++ b/agent-it/pom.xml
@@ -365,6 +365,13 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-ser... | diff --git a/agent-it/src/test/java/com/navercorp/pinpoint/plugin/thrift/common/TestEnvironment.java b/agent-it/src/test/java/com/navercorp/pinpoint/plugin/thrift/common/TestEnvironment.java
index 21b2c1274117..80ec15f2ecdc 100644
--- a/agent-it/src/test/java/com/navercorp/pinpoint/plugin/thrift/common/TestEnvironment.... | test | test | 2018-11-09T07:57:55 | 2018-11-09T02:22:24Z | Xylus | test |
pinpoint-apm/pinpoint/4970_4972 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/4970 | pinpoint-apm/pinpoint/4972 | [
"keyword_pr_to_issue"
] | 4026eab38232d4c116748c56df5b61ff5e207610 | 07e21a66298e74f4759cde3ec23b808ed8bf51c9 | [] | [] | 2018-12-06T07:33:38Z | [
"enhancement",
"module:plugin"
] | Add support for MySQL java connector 8+ | #### Description
Add trace support for MySQL java connector 8.
related issue - #4958 | [
"plugins/mysql-jdbc/src/main/java/com/navercorp/pinpoint/plugin/jdbc/mysql/MySqlPlugin.java"
] | [
"plugins/mysql-jdbc/src/main/java/com/navercorp/pinpoint/plugin/jdbc/mysql/MySqlPlugin.java"
] | [] | diff --git a/plugins/mysql-jdbc/src/main/java/com/navercorp/pinpoint/plugin/jdbc/mysql/MySqlPlugin.java b/plugins/mysql-jdbc/src/main/java/com/navercorp/pinpoint/plugin/jdbc/mysql/MySqlPlugin.java
index c40113ddd0c8..ed952dad2f90 100644
--- a/plugins/mysql-jdbc/src/main/java/com/navercorp/pinpoint/plugin/jdbc/mysql/MyS... | null | train | test | 2018-12-06T06:34:08 | 2018-12-06T05:22:11Z | Xylus | test |
pinpoint-apm/pinpoint/5026_5134 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/5026 | pinpoint-apm/pinpoint/5134 | [
"keyword_pr_to_issue"
] | 18ac6db340a3e9e5207ad6ae79e9bebaeebe9826 | 08cbfd2ba90abedc08801e9daa7b81a5e77665f1 | [] | [] | 2019-01-14T10:49:56Z | [
"enhancement",
"module:web"
] | Sort agent ids in containers by start timestamp in descending order | #### Description
Sort container agent ids in Inspector View's agent list by their start timestamp in descending order. | [
"web/src/main/java/com/navercorp/pinpoint/web/vo/ApplicationAgentsList.java"
] | [
"web/src/main/java/com/navercorp/pinpoint/web/vo/ApplicationAgentsList.java"
] | [
"web/src/test/java/com/navercorp/pinpoint/web/vo/ApplicationAgentsListTest.java"
] | diff --git a/web/src/main/java/com/navercorp/pinpoint/web/vo/ApplicationAgentsList.java b/web/src/main/java/com/navercorp/pinpoint/web/vo/ApplicationAgentsList.java
index 62529b25c1bc..2b12a9184c02 100644
--- a/web/src/main/java/com/navercorp/pinpoint/web/vo/ApplicationAgentsList.java
+++ b/web/src/main/java/com/naverc... | diff --git a/web/src/test/java/com/navercorp/pinpoint/web/vo/ApplicationAgentsListTest.java b/web/src/test/java/com/navercorp/pinpoint/web/vo/ApplicationAgentsListTest.java
index db813b604f05..a05f62b51b1b 100644
--- a/web/src/test/java/com/navercorp/pinpoint/web/vo/ApplicationAgentsListTest.java
+++ b/web/src/test/jav... | train | test | 2019-01-14T06:37:54 | 2018-12-19T05:42:29Z | Xylus | test |
pinpoint-apm/pinpoint/5274_5278 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/5274 | pinpoint-apm/pinpoint/5278 | [
"keyword_pr_to_issue"
] | 3dac9297635315914a7933b27d7e1a32aa189586 | 14d970d743d27c9d3196ae11c294f1979da0ecd3 | [] | [] | 2019-02-26T06:30:29Z | [
"bug",
"module:agent"
] | Parent application namespace header is not set correctly | #### What version of pinpoint are you using?
Affects 1.8.0, 1.8.1, 1.8.2
#### Describe the bug
Value set for `profiler.application.namespace` in *pinpoint.config*, is not propagated to a remote node via **Pinpoint-pAppNamespace**. Instead, the application name is propagated over to a remote node.
If both sender a... | [
"bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/request/DefaultRequestTraceWriter.java"
] | [
"bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/request/DefaultRequestTraceWriter.java"
] | [] | diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/request/DefaultRequestTraceWriter.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/plugin/request/DefaultRequestTraceWriter.java
index b37e3c97d9af..93e8988fc82e 100644
--- a/bootstrap-core/src/main/java/com/navercorp/... | null | train | test | 2019-02-25T11:21:33 | 2019-02-25T08:17:01Z | Xylus | test |
pinpoint-apm/pinpoint/5297_5328 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/5297 | pinpoint-apm/pinpoint/5328 | [
"keyword_issue_to_pr"
] | 01cc80190727e3afe037a948b1e825249f410cdd | e16e39cf4da395b4d15a1dc7b481e53218ddb095 | [
"@jicai There isn't any yet.",
"Please replace the driver with hbase-2.0.\r\n\r\nIt will probably work normally.",
"@RoySRose @emeroad \r\nThank you for your reply.",
"https://hbase.apache.org/book.html#hbase.versioning\r\n> Client-Server wire protocol compatibility\r\nAllows updating client and server out ... | [] | 2019-03-11T10:24:51Z | [
"question"
] | support for hbase 2.x | Are there any plans to support HBase 2.x ? thank you!
| [
"agent-it/pom.xml",
"commons-hbase/src/main/java/com/navercorp/pinpoint/common/hbase/parallel/ParallelResultScanner.java",
"doc/compatibilityHbase.md",
"doc/faq.md",
"plugins/hbase/pom.xml",
"pom.xml"
] | [
"agent-it/pom.xml",
"commons-hbase/src/main/java/com/navercorp/pinpoint/common/hbase/parallel/ParallelResultScanner.java",
"doc/compatibilityHbase.md",
"doc/faq.md",
"doc/hbase-upgrade.md",
"plugins/hbase/pom.xml",
"pom.xml"
] | [
"web/src/test/java/com/navercorp/pinpoint/web/filter/AcceptUrlFilterTest.java",
"web/src/test/java/com/navercorp/pinpoint/web/filter/Base64.java",
"web/src/test/java/com/navercorp/pinpoint/web/filter/LinkFilterTest.java",
"web/src/test/java/com/navercorp/pinpoint/web/filter/RpcURLPatternFilterTest.java"
] | diff --git a/agent-it/pom.xml b/agent-it/pom.xml
index e9be76f4d79a..15f2d273faa4 100644
--- a/agent-it/pom.xml
+++ b/agent-it/pom.xml
@@ -367,6 +367,7 @@
<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-shaded-client</artifactId>
+ <version>1.2.6.1</versi... | diff --git a/web/src/test/java/com/navercorp/pinpoint/web/filter/AcceptUrlFilterTest.java b/web/src/test/java/com/navercorp/pinpoint/web/filter/AcceptUrlFilterTest.java
index 1bdf41cc5022..5e3351508cbf 100644
--- a/web/src/test/java/com/navercorp/pinpoint/web/filter/AcceptUrlFilterTest.java
+++ b/web/src/test/java/com/... | train | test | 2019-03-11T07:11:50 | 2019-03-05T05:59:12Z | jicai | test |
pinpoint-apm/pinpoint/5445_5447 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/5445 | pinpoint-apm/pinpoint/5447 | [
"keyword_pr_to_issue"
] | 23f5c145bffac8a53c2769801a1d19ff8b1eb364 | 4ce5976eec1a2e72176a8e41f3ad39e719bcf3a4 | [] | [] | 2019-04-02T05:28:43Z | [
"bug",
"module:web"
] | Running container agents may be missing in Inspector View agent list when queried for less than 5 minutes | #### What version of pinpoint are you using?
master
#### Describe the bug
Some agents with `pinpoint.container` option are missing from the agent list in Inspector View even if they are alive. This is because the agent list currently filters out any agents that do not have any events (such as ping, or connected) i... | [
"web/src/main/java/com/navercorp/pinpoint/web/controller/AgentInfoController.java"
] | [
"web/src/main/java/com/navercorp/pinpoint/web/controller/AgentInfoController.java"
] | [] | diff --git a/web/src/main/java/com/navercorp/pinpoint/web/controller/AgentInfoController.java b/web/src/main/java/com/navercorp/pinpoint/web/controller/AgentInfoController.java
index 56ae264db941..907ad3d59575 100644
--- a/web/src/main/java/com/navercorp/pinpoint/web/controller/AgentInfoController.java
+++ b/web/src/ma... | null | test | test | 2019-04-02T07:17:44 | 2019-04-02T04:56:04Z | Xylus | test |
pinpoint-apm/pinpoint/5523_5524 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/5523 | pinpoint-apm/pinpoint/5524 | [
"keyword_pr_to_issue"
] | f5876b638ffaf615ffcb57cf4fe95f8ea607f02a | b4f696f2748c39815b15ea938818ea3ca2d4c2b7 | [] | [] | 2019-04-25T06:27:10Z | [
"bug",
"module:agent"
] | Agent cannot send traces over TCP to the collector | #### What version of pinpoint are you using?
1.8.1, 1.8.2, 1.8.3
#### Describe the bug
Agent cannot send traces over to the collector when using TCP to send spans.
The default UDP works fine.
#### What did you do to trigger the bug?
Steps to reproduce, for example:
1. Configure collector and agent to send sp... | [
"profiler/src/main/java/com/navercorp/pinpoint/profiler/context/provider/SpanDataSenderProvider.java",
"profiler/src/main/java/com/navercorp/pinpoint/profiler/context/provider/StatDataSenderProvider.java",
"profiler/src/main/java/com/navercorp/pinpoint/profiler/sender/TcpDataSender.java"
] | [
"profiler/src/main/java/com/navercorp/pinpoint/profiler/context/provider/SpanDataSenderProvider.java",
"profiler/src/main/java/com/navercorp/pinpoint/profiler/context/provider/StatDataSenderProvider.java",
"profiler/src/main/java/com/navercorp/pinpoint/profiler/sender/TcpDataSender.java"
] | [] | diff --git a/profiler/src/main/java/com/navercorp/pinpoint/profiler/context/provider/SpanDataSenderProvider.java b/profiler/src/main/java/com/navercorp/pinpoint/profiler/context/provider/SpanDataSenderProvider.java
index d487bfdcfb05..4e2f0e435a90 100644
--- a/profiler/src/main/java/com/navercorp/pinpoint/profiler/cont... | null | test | test | 2019-04-04T07:40:33 | 2019-04-25T06:18:50Z | Xylus | test |
pinpoint-apm/pinpoint/5878_5885 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/5878 | pinpoint-apm/pinpoint/5885 | [
"keyword_issue_to_pr"
] | 88dc111fdcd87257e1cb86f2c602358be082e471 | 443a9ddb73d97e29941e13b275138f3e3418567b | [
"hi @gwagdalf \r\n\r\nI make plugins, but sometimes I am not expert, so I might miss out on what real users need. \r\n\r\nI checked your offer. \r\nI think it's a very good solution. \r\n\r\nBased on the following method. Could you make code and send me pull request. \r\nhttps://github.com/spring-projects/spring-ka... | [] | 2019-08-17T00:41:00Z | [] | Suggest adding RetryingMessageListenerAdapter to KafkaPlugin | **Which module is your feature request related to?**
pinpoint-kafka-plugin
KafkaPlugin.class
**Is your feature request related to a problem?**
I'm using spring-cloud-starter-stream-kafka.
It is set as maxAttempts 3 by default and in this case, it was confirmed to use **RetryingMessageListenerAdapter** as shown b... | [
"plugins/kafka/src/main/java/com/navercorp/pinpoint/plugin/kafka/KafkaPlugin.java"
] | [
"plugins/kafka/src/main/java/com/navercorp/pinpoint/plugin/kafka/KafkaPlugin.java"
] | [] | diff --git a/plugins/kafka/src/main/java/com/navercorp/pinpoint/plugin/kafka/KafkaPlugin.java b/plugins/kafka/src/main/java/com/navercorp/pinpoint/plugin/kafka/KafkaPlugin.java
index aaff75dc805c..4f224e82662a 100644
--- a/plugins/kafka/src/main/java/com/navercorp/pinpoint/plugin/kafka/KafkaPlugin.java
+++ b/plugins/ka... | null | train | test | 2019-08-16T11:43:55 | 2019-08-16T00:52:47Z | gwagdalf | test |
pinpoint-apm/pinpoint/6048_6079 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/6048 | pinpoint-apm/pinpoint/6079 | [
"keyword_pr_to_issue"
] | af464b1c16814362c9de533d41749433ad81104c | b4f2d6b4bb125f9bcde66b4f0e11fa09b9ecd453 | [
"Ok, let me look at this problem and solve it",
"attaching log, which may help you better\r\n```\r\nError Message\r\njava.lang.AssertionError: Cannot find apiId of [org.frameworkset.elasticsearch.client.ConfigRestClientUtil.createIndiceMapping(java.lang.String, java.lang.String)]\r\nStacktrace\r\ncom.navercorp.pi... | [] | 2019-10-11T09:05:02Z | [
"bug",
"module:plugin"
] | elasticsearch bboss test failure | Hello, @yin-bp
I've noticed that bboss plugin integration tests are failing in our daily routine test.
Do you mind checking `ElasticsearchExecutorIT.java` out?
| [
"agent/src/main/resources-local/pinpoint.config",
"agent/src/main/resources-release/pinpoint-real-env-lowoverhead-sample.config",
"agent/src/main/resources-release/pinpoint.config"
] | [
"agent/src/main/resources-local/pinpoint.config",
"agent/src/main/resources-release/pinpoint-real-env-lowoverhead-sample.config",
"agent/src/main/resources-release/pinpoint.config"
] | [
"agent-it8/src/test/java/com/navercorp/pinpoint/plugin/elasticsearchbboss/ElasticsearchExecutorIT.java",
"agent-it8/src/test/java/com/navercorp/pinpoint/plugin/elasticsearchbboss/ElasticsearchExecutorIT569.java"
] | diff --git a/agent/src/main/resources-local/pinpoint.config b/agent/src/main/resources-local/pinpoint.config
index cd2275f432d6..349b83c6b89d 100644
--- a/agent/src/main/resources-local/pinpoint.config
+++ b/agent/src/main/resources-local/pinpoint.config
@@ -1071,7 +1071,7 @@ profiler.elasticsearch.recordESVersion=fals... | diff --git a/agent-it8/src/test/java/com/navercorp/pinpoint/plugin/elasticsearchbboss/ElasticsearchExecutorIT.java b/agent-it8/src/test/java/com/navercorp/pinpoint/plugin/elasticsearchbboss/ElasticsearchExecutorIT.java
index f536a6027303..d164ba8a294d 100644
--- a/agent-it8/src/test/java/com/navercorp/pinpoint/plugin/e... | train | test | 2019-10-11T10:40:51 | 2019-10-02T05:16:49Z | RoySRose | test |
pinpoint-apm/pinpoint/6148_6149 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/6148 | pinpoint-apm/pinpoint/6149 | [
"keyword_issue_to_pr"
] | ddbb2cac267acea54dc506bb9b229e75647907ba | f946e3305e7be91154dc5878528b29ec9183f9d6 | [
"resolved via #6149 #6154 "
] | [] | 2019-11-07T02:11:26Z | [
"bug",
"module:plugin"
] | Fixes a problem where Kafka Plugin doesn't work in certain situations | Fixes a problem where Kafka Plugin doesn't work in certain situations
#### description
If Sampling is not set to 1, Kafka Plugin may not handle traces properly, which may cause problems. | [
"plugins/kafka/src/main/java/com/navercorp/pinpoint/plugin/kafka/interceptor/ConsumerRecordEntryPointInterceptor.java"
] | [
"plugins/kafka/src/main/java/com/navercorp/pinpoint/plugin/kafka/interceptor/ConsumerRecordEntryPointInterceptor.java"
] | [] | diff --git a/plugins/kafka/src/main/java/com/navercorp/pinpoint/plugin/kafka/interceptor/ConsumerRecordEntryPointInterceptor.java b/plugins/kafka/src/main/java/com/navercorp/pinpoint/plugin/kafka/interceptor/ConsumerRecordEntryPointInterceptor.java
index 0c8604f14bd6..b0ca62488086 100644
--- a/plugins/kafka/src/main/ja... | null | train | test | 2019-11-06T03:06:27 | 2019-11-07T02:09:52Z | koo-taejin | test |
pinpoint-apm/pinpoint/6148_6154 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/6148 | pinpoint-apm/pinpoint/6154 | [
"keyword_issue_to_pr"
] | a2f4df5610a10e8164983bfa2934a367ded786ec | ead87bcd571f7b1766e248dfb31de869d84c9b56 | [
"resolved via #6149 #6154 "
] | [] | 2019-11-07T09:12:06Z | [
"bug",
"module:plugin"
] | Fixes a problem where Kafka Plugin doesn't work in certain situations | Fixes a problem where Kafka Plugin doesn't work in certain situations
#### description
If Sampling is not set to 1, Kafka Plugin may not handle traces properly, which may cause problems. | [
"plugins/kafka/src/main/java/com/navercorp/pinpoint/plugin/kafka/interceptor/ConsumerRecordEntryPointInterceptor.java"
] | [
"plugins/kafka/src/main/java/com/navercorp/pinpoint/plugin/kafka/interceptor/ConsumerRecordEntryPointInterceptor.java"
] | [] | diff --git a/plugins/kafka/src/main/java/com/navercorp/pinpoint/plugin/kafka/interceptor/ConsumerRecordEntryPointInterceptor.java b/plugins/kafka/src/main/java/com/navercorp/pinpoint/plugin/kafka/interceptor/ConsumerRecordEntryPointInterceptor.java
index 0c8604f14bd6..b0ca62488086 100644
--- a/plugins/kafka/src/main/ja... | null | val | test | 2019-10-14T09:23:11 | 2019-11-07T02:09:52Z | koo-taejin | test |
pinpoint-apm/pinpoint/6150_6155 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/6150 | pinpoint-apm/pinpoint/6155 | [
"keyword_issue_to_pr"
] | ead87bcd571f7b1766e248dfb31de869d84c9b56 | 29a0a994ae515e25d322dce16b5721ee443feb91 | [
"resolved via #6151 #6155 "
] | [] | 2019-11-07T09:50:55Z | [
"enhancement",
"module:plugin"
] | Adds support Kafka 2.2.0+ | #### description
There are major method changes in version 2.2.0.
* KafkaCosumer poll method
```
# 2.0.0+
org.apache.kafka.clients.consumer.KafkaConsumer#poll(long, boolean)
->
# 2.2.0+
org.apache.kafka.clients.consumer.KafkaConsumer#poll(org.apache.kafka.common.utils.Timer, boolean)
```
* KafkaProdu... | [
"plugins/kafka/src/main/java/com/navercorp/pinpoint/plugin/kafka/KafkaPlugin.java",
"plugins/kafka/src/main/java/com/navercorp/pinpoint/plugin/kafka/interceptor/ProducerConstructorInterceptor.java"
] | [
"plugins/kafka/src/main/java/com/navercorp/pinpoint/plugin/kafka/KafkaPlugin.java",
"plugins/kafka/src/main/java/com/navercorp/pinpoint/plugin/kafka/interceptor/ProducerConstructorInterceptor.java"
] | [] | diff --git a/plugins/kafka/src/main/java/com/navercorp/pinpoint/plugin/kafka/KafkaPlugin.java b/plugins/kafka/src/main/java/com/navercorp/pinpoint/plugin/kafka/KafkaPlugin.java
index d1c527d52792..dc5cb7e9cbac 100644
--- a/plugins/kafka/src/main/java/com/navercorp/pinpoint/plugin/kafka/KafkaPlugin.java
+++ b/plugins/ka... | null | train | test | 2019-11-07T10:39:37 | 2019-11-07T07:21:47Z | koo-taejin | test |
pinpoint-apm/pinpoint/6152_6158 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/6152 | pinpoint-apm/pinpoint/6158 | [
"keyword_issue_to_pr"
] | 29a0a994ae515e25d322dce16b5721ee443feb91 | 9ace68f76243a524558bc3da0d00846baa5d9f15 | [
"resolved via #6153 #6158 "
] | [] | 2019-11-08T02:08:12Z | [
"bug",
"module:agent"
] | Allows to set queueSize in the TcpDataSender | #### description
Allows to set queueSize on the TcpDataSender.
related issue #6144
| [
"profiler/src/main/java/com/navercorp/pinpoint/profiler/context/provider/SpanDataSenderProvider.java",
"profiler/src/main/java/com/navercorp/pinpoint/profiler/context/provider/StatDataSenderProvider.java",
"profiler/src/main/java/com/navercorp/pinpoint/profiler/sender/TcpDataSender.java"
] | [
"profiler/src/main/java/com/navercorp/pinpoint/profiler/context/provider/SpanDataSenderProvider.java",
"profiler/src/main/java/com/navercorp/pinpoint/profiler/context/provider/StatDataSenderProvider.java",
"profiler/src/main/java/com/navercorp/pinpoint/profiler/sender/TcpDataSender.java"
] | [] | diff --git a/profiler/src/main/java/com/navercorp/pinpoint/profiler/context/provider/SpanDataSenderProvider.java b/profiler/src/main/java/com/navercorp/pinpoint/profiler/context/provider/SpanDataSenderProvider.java
index e83689d3ef00..002e8f471731 100644
--- a/profiler/src/main/java/com/navercorp/pinpoint/profiler/cont... | null | train | test | 2019-11-08T02:32:16 | 2019-11-07T08:17:48Z | koo-taejin | test |
pinpoint-apm/pinpoint/6507_6510 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/6507 | pinpoint-apm/pinpoint/6510 | [
"keyword_issue_to_pr"
] | 511872a4553f23ebd93ee7aa1bc824a253087284 | 3276a81109c697f64221af4e4777e80e55f20022 | [
"This issue expect to have resolved via #6508, #6510"
] | [] | 2020-02-18T02:44:16Z | [
"bug",
"module:plugin"
] | Fix problem that do not set some fields when an exception occurs | #### related module
Kafka-Plugin
#### description
If service type has record statistics, destnationId value have to send for to draw servermap.
But, current ProducerSendInterceptor code do not set destinationId field when exception occurred while send() method invoked.
For this reason, servermap has not draw... | [
"plugins/rabbitmq/src/main/java/com/navercorp/pinpoint/plugin/rabbitmq/client/interceptor/ChannelBasicPublishInterceptor.java"
] | [
"plugins/rabbitmq/src/main/java/com/navercorp/pinpoint/plugin/rabbitmq/client/interceptor/ChannelBasicPublishInterceptor.java"
] | [] | diff --git a/plugins/rabbitmq/src/main/java/com/navercorp/pinpoint/plugin/rabbitmq/client/interceptor/ChannelBasicPublishInterceptor.java b/plugins/rabbitmq/src/main/java/com/navercorp/pinpoint/plugin/rabbitmq/client/interceptor/ChannelBasicPublishInterceptor.java
index 78961d8b9fa1..0618de2e382c 100644
--- a/plugins/r... | null | train | test | 2020-02-18T03:41:14 | 2020-02-17T08:32:50Z | koo-taejin | test |
pinpoint-apm/pinpoint/7527_7528 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/7527 | pinpoint-apm/pinpoint/7528 | [
"keyword_pr_to_issue",
"connected"
] | 4bb8ea6eb71a50edca7477b5d6c3dc48a174616f | 418503ec9a74fac2f57c45a68a2cafdb4d635937 | [
"I will post a PR to fix it.",
"@emeroad Do you think this is a bug?",
"@tankilo \r\nThanks for your contribution.\r\n\r\nI fully agree with your opinion.\r\nI really like this PR. :+1: ",
"Thank you for your contribution"
] | [] | 2021-01-03T02:18:59Z | [
"bug",
"module:plugin",
"module:agent"
] | HttpClient4 plugin's BasicFutureMethodInterceptor failed to record exception detatils when intercepting method `org.apache.http.concurrent.BasicFuture#failed` | #### contribution info
* Contributor : @tankilo
#### Prerequisites
Please check the [FAQ](http://pinpoint-apm.github.io/pinpoint/faq.html), and search existing [issues](https://github.com/pinpoint-apm/pinpoint/issues) for similar questions before creating a new issue.**YOU MAY DELETE THIS PREREQUISITES SECTION.*... | [
"plugins/httpclient4/src/main/java/com/navercorp/pinpoint/plugin/httpclient4/HttpClient4Plugin.java",
"plugins/httpclient4/src/main/java/com/navercorp/pinpoint/plugin/httpclient4/interceptor/BasicFutureMethodInterceptor.java"
] | [
"plugins/httpclient4/src/main/java/com/navercorp/pinpoint/plugin/httpclient4/HttpClient4Plugin.java",
"plugins/httpclient4/src/main/java/com/navercorp/pinpoint/plugin/httpclient4/interceptor/BasicFutureFailedMethodInterceptor.java",
"plugins/httpclient4/src/main/java/com/navercorp/pinpoint/plugin/httpclient4/in... | [] | diff --git a/plugins/httpclient4/src/main/java/com/navercorp/pinpoint/plugin/httpclient4/HttpClient4Plugin.java b/plugins/httpclient4/src/main/java/com/navercorp/pinpoint/plugin/httpclient4/HttpClient4Plugin.java
index 99a6dddd5f53..28e723a09b67 100644
--- a/plugins/httpclient4/src/main/java/com/navercorp/pinpoint/plug... | null | test | test | 2021-05-07T10:36:14 | 2021-01-03T02:09:13Z | tankilo | test |
pinpoint-apm/pinpoint/7628_7631 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/7628 | pinpoint-apm/pinpoint/7631 | [
"keyword_pr_to_issue"
] | 1bfefa9bbcba69fde998d9ccce0d79a72a0780a8 | b8caf43e8059bd62d0dcff7821277effa3fcfc97 | [
"Yes. It looks like it's a bug. Any suggestions?",
"> Yes. It looks like it's a bug. Any suggestions?\r\n\r\nplease fix it like this: ```profilableClass != null && !profilableClass.isEmpty() ```\r\nI already tested in local env \r\nAlso need I create a pr for this?"
] | [] | 2021-02-08T03:54:09Z | [
"bug",
"module:agent"
] | I found a bug in DefaultProfilerConfig.java | problem: pinpoint.config's properties ``` profiler.include``` not work
so I review the code ,and find something maybe wrong
#### What version of pinpoint are you using?
master
``` java
//. file: https://github.com/pinpoint-apm/pinpoint/blob/master/bootstrap-core/src/main/java/com/navercorp/pinpoint/boo... | [
"bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/config/DefaultProfilerConfig.java"
] | [
"bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/config/DefaultProfilerConfig.java"
] | [] | diff --git a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/config/DefaultProfilerConfig.java b/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/config/DefaultProfilerConfig.java
index 0d70dcd66d74..750969f65436 100644
--- a/bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/confi... | null | train | test | 2021-02-08T03:49:39 | 2021-02-06T13:26:37Z | snaigle | test |
pinpoint-apm/pinpoint/7748_7749 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/7748 | pinpoint-apm/pinpoint/7749 | [
"keyword_pr_to_issue"
] | 9ad18b7a64af84b4c5141feeaadbf5dca404b6db | d0d9d63b7cb1a0f5a427d9f282b26f5bf3c7d939 | [
"Thank you for your contribution."
] | [] | 2021-03-18T11:11:55Z | [
"bug",
"module:agent"
] | Spring cloud gateway call tree/servermap is incorrect | #### What version of pinpoint are you using?
master/v2.2.2
#### Describe the bug
When the call path is as: _gateway_(optional) -> _appA_ -> _gateway_(spring cloud gateway with netty-http) -> _appB_, the call tree and the servermap would be incorrect. The call tree after gateway is missing.
... | [
"plugins/reactor-netty/src/main/java/com/navercorp/pinpoint/plugin/reactor/netty/interceptor/HttpClientRequestHeaderAdaptor.java"
] | [
"plugins/reactor-netty/src/main/java/com/navercorp/pinpoint/plugin/reactor/netty/interceptor/HttpClientRequestHeaderAdaptor.java"
] | [] | diff --git a/plugins/reactor-netty/src/main/java/com/navercorp/pinpoint/plugin/reactor/netty/interceptor/HttpClientRequestHeaderAdaptor.java b/plugins/reactor-netty/src/main/java/com/navercorp/pinpoint/plugin/reactor/netty/interceptor/HttpClientRequestHeaderAdaptor.java
index b195e6d6a24e..839c462d46f4 100644
--- a/plu... | null | val | test | 2021-03-16T11:46:47 | 2021-03-18T11:11:10Z | yjqg6666 | test |
pinpoint-apm/pinpoint/7895_7896 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/7895 | pinpoint-apm/pinpoint/7896 | [
"keyword_pr_to_issue",
"connected"
] | af77f082c2e44c5b1c6e3f4d4355e90c487104a8 | 3436a0d582899310ee54f013cd04c16a0d026c2e | [] | [] | 2021-05-26T12:34:09Z | [
"bug",
"module:plugin"
] | Jedis get `Unknown` endpoint when using `spring-boot-starter-data-redis` | #### contribution info
* Contributor : @hoverwinter
- spring-boot 2.4.2 (spring-boot-starter-data-redis) with default configuration.
Reason:
`JedisPlugin` has no interceptor for following constructor of `BinaryJedis`:
- public BinaryJedis(String host, int port, int connectionTimeout, int soTimeout, int ... | [
"plugins/bom/pom.xml",
"plugins/redis/src/main/java/com/navercorp/pinpoint/plugin/redis/jedis/JedisPlugin.java",
"plugins/redis/src/main/java/com/navercorp/pinpoint/plugin/redis/jedis/interceptor/SetEndPointInterceptor.java"
] | [
"plugins/bom/pom.xml",
"plugins/redis/src/main/java/com/navercorp/pinpoint/plugin/redis/jedis/JedisPlugin.java",
"plugins/redis/src/main/java/com/navercorp/pinpoint/plugin/redis/jedis/interceptor/SetEndPointInterceptor.java"
] | [] | diff --git a/plugins/bom/pom.xml b/plugins/bom/pom.xml
index 02637114fffc..f032d39c78c3 100644
--- a/plugins/bom/pom.xml
+++ b/plugins/bom/pom.xml
@@ -30,7 +30,7 @@
<name>pinpoint-plugin-bom</name>
<properties>
- <jedis.version>2.4.2</jedis.version>
+ <jedis.version>3.4.0</jedis.version>
... | null | train | test | 2021-05-26T04:13:10 | 2021-05-26T12:20:01Z | hoverwinter | test |
pinpoint-apm/pinpoint/8019_8024 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/8019 | pinpoint-apm/pinpoint/8024 | [
"keyword_pr_to_issue"
] | be5a28d31fce4a209a82f7e191a8519ca7bf5a85 | 96254db2f83a05da89b4057c59487fb73646ac1d | [] | [] | 2021-07-12T03:20:15Z | [
"enhancement",
"module:plugin"
] | jdk http client can not profiling https request | #### What version of pinpoint are you using?
master/v2.2.2
#### Describe the bug
the plugin jdk-http can only profiling/sampling http request, https request is not supported.
#### Expected behavior
request traced.
A PR would be made to fix it.
Update: see PR #8024. | [
"agent-testweb/pom.xml",
"agent/src/main/resources/profiles/local/pinpoint.config",
"agent/src/main/resources/profiles/release/pinpoint.config",
"plugins/jdk-http/src/main/java/com/navercorp/pinpoint/plugin/jdk/http/JdkHttpPlugin.java",
"plugins/jdk-http/src/main/java/com/navercorp/pinpoint/plugin/jdk/http/... | [
"agent-testweb/jdk-http-plugin-testweb/README.md",
"agent-testweb/jdk-http-plugin-testweb/pom.xml",
"agent-testweb/jdk-http-plugin-testweb/src/main/resources/application.yml",
"agent-testweb/pom.xml",
"agent/src/main/resources/profiles/local/pinpoint.config",
"agent/src/main/resources/profiles/release/pin... | [
"agent-testweb/jdk-http-plugin-testweb/src/main/java/com/pinpointest/plugin/CertService.java",
"agent-testweb/jdk-http-plugin-testweb/src/main/java/com/pinpointest/plugin/JdkHttpPluginTestStarter.java",
"agent-testweb/jdk-http-plugin-testweb/src/main/java/com/pinpointest/plugin/controller/HelloWorldController.j... | diff --git a/agent-testweb/jdk-http-plugin-testweb/README.md b/agent-testweb/jdk-http-plugin-testweb/README.md
new file mode 100644
index 000000000000..a09b57f7e64e
--- /dev/null
+++ b/agent-testweb/jdk-http-plugin-testweb/README.md
@@ -0,0 +1,16 @@
+
+## Install
+```
+$ mvnw -P pinpoint-jdk-http-plugin-testweb install... | diff --git a/agent-testweb/jdk-http-plugin-testweb/src/main/java/com/pinpointest/plugin/CertService.java b/agent-testweb/jdk-http-plugin-testweb/src/main/java/com/pinpointest/plugin/CertService.java
new file mode 100644
index 000000000000..d460e6b38baf
--- /dev/null
+++ b/agent-testweb/jdk-http-plugin-testweb/src/main/... | test | test | 2021-08-10T09:48:59 | 2021-07-09T06:31:35Z | yjqg6666 | test |
pinpoint-apm/pinpoint/9614_9615 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/9614 | pinpoint-apm/pinpoint/9615 | [
"keyword_pr_to_issue",
"connected"
] | 0a049cc7131e042fcb7f275c91f24d9e9d6a88c9 | 00fa07c24f3a8d17417bb2246f84682bb814f676 | [] | [] | 2023-01-09T05:49:17Z | [] | Apply temporary fix to Pinot #6834 issue | https://github.com/apache/pinot/issues/6834
| [
"commons-pinot/src/main/java/com/navercorp/pinpoint/common/pinot/datasource/WrappedPinotPreparedStatement.java"
] | [
"commons-pinot/src/main/java/com/navercorp/pinpoint/common/pinot/datasource/WrappedPinotPreparedStatement.java"
] | [] | diff --git a/commons-pinot/src/main/java/com/navercorp/pinpoint/common/pinot/datasource/WrappedPinotPreparedStatement.java b/commons-pinot/src/main/java/com/navercorp/pinpoint/common/pinot/datasource/WrappedPinotPreparedStatement.java
index e39316e38d25..6226f2186b68 100644
--- a/commons-pinot/src/main/java/com/naverco... | null | test | test | 2023-01-09T05:51:38 | 2023-01-09T05:43:36Z | ga-ram | test |
pinpoint-apm/pinpoint/5_8 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/5 | pinpoint-apm/pinpoint/8 | [
"timestamp(timedelta=1185.0, similarity=0.8948048723314214)"
] | 08ad403d69d57644b75c96d2c5371244d8e6f38b | e153099b20124570274842a6b913d42b83669f69 | [
"Decided to use doc directory for images.\n"
] | [] | 2014-12-26T07:44:34Z | [] | Images for README and docs | Creating an issue to upload images for ref-linking in README and docs.
| [
"README.md",
"quickstart/README.md"
] | [
"README.md",
"quickstart/README.md"
] | [] | diff --git a/README.md b/README.md
index 3c13dadde3f1..398c6f92c4e1 100644
--- a/README.md
+++ b/README.md
@@ -6,26 +6,26 @@
* Minimal impact on performance (approximately 3% increase in resource usage)
## Overview
-Services nowadays often consists of many different components, communicating amongst themselves as w... | null | train | train | 2014-12-26T07:59:37 | 2014-12-26T06:07:54Z | Xylus | test |
pinpoint-apm/pinpoint/85_86 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/85 | pinpoint-apm/pinpoint/86 | [
"timestamp(timedelta=4984.0, similarity=0.9205776189652282)"
] | 37186eae8b31733e89d97a3be0404bcc37f4aa12 | d03dc824ecaf451e147ed1e5c51866e358442bbe | [] | [] | 2015-01-08T04:35:11Z | [
"bug",
"enhancement"
] | Improvement thread safety of InterceptorRegistry | improvement thread safety of `InterceptorRegistry`
`array[index]=value` is not thread safe.
| [
"bootstrap-core/pom.xml",
"bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/interceptor/InterceptorRegistry.java",
"bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/interceptor/LoggingInterceptor.java",
"commons/src/main/java/com/navercorp/pinpoint/common/util/DelegateEnumeration.jav... | [
"bootstrap-core/pom.xml",
"bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/interceptor/InterceptorRegistry.java",
"bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/interceptor/LoggingInterceptor.java",
"bootstrap-core/src/main/java/com/navercorp/pinpoint/bootstrap/interceptor/WeakAt... | [
"bootstrap-core/src/test/java/com/navercorp/pinpoint/bootstrap/interceptor/AtomicMaxUpdater.java",
"bootstrap-core/src/test/java/com/navercorp/pinpoint/bootstrap/interceptor/InterceptorRegistryTest.java",
"bootstrap-core/src/test/java/com/navercorp/pinpoint/bootstrap/interceptor/WeakAtomicReferenceArrayTest.jav... | diff --git a/bootstrap-core/pom.xml b/bootstrap-core/pom.xml
index 1d3b70ebedc2..7f53514ed877 100644
--- a/bootstrap-core/pom.xml
+++ b/bootstrap-core/pom.xml
@@ -13,6 +13,26 @@
<packaging>jar</packaging>
<dependencies>
+ <!-- Logging depedencies -->
+ <dependency>
+ <groupId>org.sl... | diff --git a/bootstrap-core/src/test/java/com/navercorp/pinpoint/bootstrap/interceptor/AtomicMaxUpdater.java b/bootstrap-core/src/test/java/com/navercorp/pinpoint/bootstrap/interceptor/AtomicMaxUpdater.java
new file mode 100644
index 000000000000..2bf67518386d
--- /dev/null
+++ b/bootstrap-core/src/test/java/com/naverc... | train | train | 2015-01-07T02:34:47 | 2015-01-08T04:14:33Z | emeroad | test |
pinpoint-apm/pinpoint/91_93 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/91 | pinpoint-apm/pinpoint/93 | [
"timestamp(timedelta=330.0, similarity=0.9231018481336303)"
] | ffea8a79e1bb8eea86853ea6691d34a4e6766ebb | 014e675d01cb9fabcf85225ecd0f5a010568cc5c | [] | [] | 2015-01-12T06:32:03Z | [
"enhancement"
] | Extended URL matcher function | [
"web/src/main/java/com/navercorp/pinpoint/web/applicationmap/link/MatcherGroup.java"
] | [
"web/src/main/java/com/navercorp/pinpoint/web/applicationmap/link/MatcherGroup.java",
"web/src/main/java/com/navercorp/pinpoint/web/applicationmap/link/PostfixServerMatcher.java"
] | [
"web/src/test/java/com/navercorp/pinpoint/web/applicationmap/link/PostfixServerMatcherTest.java"
] | diff --git a/web/src/main/java/com/navercorp/pinpoint/web/applicationmap/link/MatcherGroup.java b/web/src/main/java/com/navercorp/pinpoint/web/applicationmap/link/MatcherGroup.java
index bc1d9841120e..be01593f4a70 100644
--- a/web/src/main/java/com/navercorp/pinpoint/web/applicationmap/link/MatcherGroup.java
+++ b/web/... | diff --git a/web/src/test/java/com/navercorp/pinpoint/web/applicationmap/link/PostfixServerMatcherTest.java b/web/src/test/java/com/navercorp/pinpoint/web/applicationmap/link/PostfixServerMatcherTest.java
new file mode 100644
index 000000000000..e09c02f0fc7f
--- /dev/null
+++ b/web/src/test/java/com/navercorp/pinpoint/... | train | train | 2015-01-12T05:50:14 | 2015-01-12T02:10:05Z | minwoo-jung | test | |
pinpoint-apm/pinpoint/94_96 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/94 | pinpoint-apm/pinpoint/96 | [
"timestamp(timedelta=38.0, similarity=0.9612864887245522)"
] | e5a47fbd9595183834b46224a2f05fdbe8126e96 | 9eaa863ceeae20aa3ed7c4516fc7dcb07764f0d0 | [] | [] | 2015-01-12T07:59:34Z | [
"enhancement"
] | Change position and url Monitor site link in inspector page | [
"web/src/main/java/com/navercorp/pinpoint/web/view/ApplicationAgentListSerializer.java",
"web/src/main/webapp/views/agentInfoMain.html"
] | [
"web/src/main/java/com/navercorp/pinpoint/web/view/ApplicationAgentListSerializer.java",
"web/src/main/webapp/views/agentInfoMain.html"
] | [] | diff --git a/web/src/main/java/com/navercorp/pinpoint/web/view/ApplicationAgentListSerializer.java b/web/src/main/java/com/navercorp/pinpoint/web/view/ApplicationAgentListSerializer.java
index a4dc85753f4d..2f8e1f83c78c 100644
--- a/web/src/main/java/com/navercorp/pinpoint/web/view/ApplicationAgentListSerializer.java
+... | null | train | train | 2015-01-12T07:43:56 | 2015-01-12T06:41:34Z | minwoo-jung | test | |
pinpoint-apm/pinpoint/140_141 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/140 | pinpoint-apm/pinpoint/141 | [
"timestamp(timedelta=58546.0, similarity=0.9608887208928373)"
] | 473df4e30e98726718646496d9161e31240be4aa | d9fc90c86793fab2c32b6fed4e7cb0309d34327b | [] | [] | 2015-01-27T08:32:23Z | [
"bug"
] | Timer thread leak when client reconnect to server. | Timer thread leak when client reconnect to server.
Client auto reconnect when socket disconnect from peer.
In this situation client does not clean up running timer thread.
It can be problem when agent running for a long time or collector restart frequently.
| [
"rpc/src/main/java/com/navercorp/pinpoint/rpc/client/PinpointSocketHandler.java"
] | [
"rpc/src/main/java/com/navercorp/pinpoint/rpc/client/PinpointSocketHandler.java"
] | [
"rpc/src/test/java/com/navercorp/pinpoint/rpc/client/ReconnectTest.java"
] | diff --git a/rpc/src/main/java/com/navercorp/pinpoint/rpc/client/PinpointSocketHandler.java b/rpc/src/main/java/com/navercorp/pinpoint/rpc/client/PinpointSocketHandler.java
index f3018f3bc0dd..2f4761836b68 100644
--- a/rpc/src/main/java/com/navercorp/pinpoint/rpc/client/PinpointSocketHandler.java
+++ b/rpc/src/main/jav... | diff --git a/rpc/src/test/java/com/navercorp/pinpoint/rpc/client/ReconnectTest.java b/rpc/src/test/java/com/navercorp/pinpoint/rpc/client/ReconnectTest.java
index fe40921cb1ae..d307e0b620f6 100644
--- a/rpc/src/test/java/com/navercorp/pinpoint/rpc/client/ReconnectTest.java
+++ b/rpc/src/test/java/com/navercorp/pinpoint... | train | train | 2015-01-26T07:53:18 | 2015-01-26T09:20:06Z | koo-taejin | test |
pinpoint-apm/pinpoint/173_174 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/173 | pinpoint-apm/pinpoint/174 | [
"timestamp(timedelta=32.0, similarity=0.9506279071029448)"
] | 9c095f8dce5fa6d2a63af39e85097bf9ca8a1dc3 | 5cb1c2485bc738ada1acfcbee64f45145859e8ea | [] | [] | 2015-02-12T06:09:25Z | [
"enhancement"
] | Add pinpoint version to system properties while bootstrap start | [
"bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/PinpointBootStrap.java",
"bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/ProfilerLibClass.java"
] | [
"bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/PinpointBootStrap.java",
"bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/ProfilerLibClass.java"
] | [] | diff --git a/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/PinpointBootStrap.java b/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/PinpointBootStrap.java
index 4deb31928844..3f64842b1c5a 100644
--- a/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/PinpointBootStrap.java
+++ b/bootstrap/src... | null | test | train | 2015-02-11T08:08:21 | 2015-02-12T02:17:19Z | minwoo-jung | test | |
pinpoint-apm/pinpoint/215_222 | pinpoint-apm/pinpoint | pinpoint-apm/pinpoint/215 | pinpoint-apm/pinpoint/222 | [
"timestamp(timedelta=11044.0, similarity=0.8815885731887749)"
] | f101d233a2706443085010e78854102ad50f0867 | 3435c5300d43b0455f9feb9f5f08171e27404dfb | [
"Making further modifications, It would be better for `PinpointBootstrap` to govern the agent's lifecycle (ie. start/stop methods).\n"
] | [] | 2015-03-10T02:54:21Z | [
"enhancement"
] | Sending server meta data should be separated from the agent's lifecycle | The agent's lifecycle (and sending agent information) is currently controlled by plugins. Each plugin must specify if it will control the agent's lifecycle, and call `Agent.start()` manually if it does.
For example, a Tomcat 6 application is modified to invoke `Agent.start()` after `org.apache.catalina.core.StandardSe... | [
"bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/context/ServerMetaDataHolder.java",
"plugins/tomcat/src/main/java/com/navercorp/pinpoint/plugin/tomcat/interceptor/StandardServiceStartInterceptor.java",
"profiler/src/main/java/com/navercorp/pinpoint/profiler/AgentInfoSender.java",
"profiler/src/main/... | [
"bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/context/ServerMetaDataHolder.java",
"plugins/tomcat/src/main/java/com/navercorp/pinpoint/plugin/tomcat/interceptor/StandardServiceStartInterceptor.java",
"profiler/src/main/java/com/navercorp/pinpoint/profiler/AgentInfoSender.java",
"profiler/src/main/... | [
"profiler/src/main/java/com/navercorp/pinpoint/test/PluginTestAgent.java",
"profiler/src/main/java/com/navercorp/pinpoint/test/TestableServerMetaDataListener.java",
"profiler/src/main/java/com/navercorp/pinpoint/test/junit4/BasePinpointTest.java",
"profiler/src/test/java/com/navercorp/pinpoint/profiler/AgentI... | diff --git a/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/context/ServerMetaDataHolder.java b/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/context/ServerMetaDataHolder.java
index e6be6dc7f6a0..a46ba77f9498 100644
--- a/bootstrap/src/main/java/com/navercorp/pinpoint/bootstrap/context/ServerMetaDa... | diff --git a/profiler/src/main/java/com/navercorp/pinpoint/test/PluginTestAgent.java b/profiler/src/main/java/com/navercorp/pinpoint/test/PluginTestAgent.java
index 45783d9ba5b1..2eb9896f4611 100644
--- a/profiler/src/main/java/com/navercorp/pinpoint/test/PluginTestAgent.java
+++ b/profiler/src/main/java/com/navercorp/... | train | train | 2015-03-10T06:57:20 | 2015-03-06T10:11:55Z | Xylus | test |
iluwatar/java-design-patterns/53_54 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/53 | iluwatar/java-design-patterns/54 | [
"timestamp(timedelta=0.0, similarity=1.0000000000000002)",
"keyword_pr_to_issue"
] | b87918050c4091c9719eeaeef46edb667f83dd70 | 5ffaa138fa1524ad8bf68606898e1f32ffc918a1 | [] | [] | 2015-05-18T06:15:19Z | [] | Documentation change in DAO pattern | Removed a redundant word and added an Acronym.
| [
"dao/src/main/java/com/iluwatar/App.java"
] | [
"dao/src/main/java/com/iluwatar/App.java"
] | [] | diff --git a/dao/src/main/java/com/iluwatar/App.java b/dao/src/main/java/com/iluwatar/App.java
index 878f7b5bfba7..29578d74ea21 100644
--- a/dao/src/main/java/com/iluwatar/App.java
+++ b/dao/src/main/java/com/iluwatar/App.java
@@ -6,7 +6,7 @@
/**
*
* With the DAO pattern, we can use various method calls to retr... | null | train | train | 2015-05-17T21:04:07 | 2015-05-18T05:43:36Z | hobbyexplorer | train |
iluwatar/java-design-patterns/181_193 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/181 | iluwatar/java-design-patterns/193 | [
"timestamp(timedelta=53733.0, similarity=0.8708915252422907)",
"keyword_pr_to_issue"
] | 3dc6b81962bcfb492752bea1a204ae0ba94c58e5 | 5f40d0a157da6343cc1167725556c8f2a29139c5 | [
"Shouldn't this be replicable in my fork?\n\nI get `This job is running on container-based infrastructure, which does not allow use of 'sudo', setuid and setguid executables.`\n",
"@mafagafogigante Yes that is normal. `sudo` is not yet supported in Travis container environment but as we don't need that we are goo... | [] | 2015-08-07T07:06:14Z | [] | Migrate travis build to container based infrastructure | I was viewing build logs when I found out that we are running build on legacy infrastructure and got a notification for migration to container based infrastructure.
[Travis CI - Why migrate to container based infrastructure](http://docs.travis-ci.com/user/migrating-from-legacy/?utm_source=legacy-notice&utm_medium=bann... | [
".travis.yml"
] | [
".travis.yml"
] | [] | diff --git a/.travis.yml b/.travis.yml
index 8ae7361f3b00..e69a17a4f8e1 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -13,4 +13,7 @@ before_install:
- "sh -e /etc/init.d/xvfb start"
after_success:
- - mvn clean test jacoco:report coveralls:report
\ No newline at end of file
+ - mvn clean test jacoco:report co... | null | train | train | 2015-08-07T07:23:10 | 2015-07-30T05:47:06Z | npathai | train |
iluwatar/java-design-patterns/192_196 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/192 | iluwatar/java-design-patterns/196 | [
"timestamp(timedelta=0.0, similarity=0.8427068570942038)",
"keyword_pr_to_issue"
] | 3a0ee1fea5016b57732f58809caf680cd9c64d70 | 588a35077800750a19bcdea935e499e6fe8117f3 | [] | [] | 2015-08-08T13:31:45Z | [
"type: enhancement"
] | README is ugly and could easily be fixed. | Many lines of the file are HUGE. The longest line is terribly **598** characters long!
Some of us (I can't be the only one) use text editors that work better with reasonable line lengths (70 or 80 characters per line).
Even Git diffs become much better when line lengths are moderate.
Also, the last PR I opened (#191... | [
"README.md"
] | [
"README.md"
] | [] | diff --git a/README.md b/README.md
index a7390336785f..910e9d485796 100644
--- a/README.md
+++ b/README.md
@@ -307,8 +307,8 @@ are several common situations in which the Proxy pattern is applicable
**Typical Use Case:**
-* Control access to another object
-* Lazy initialization
+* control access to another object
... | null | train | train | 2015-08-07T18:39:00 | 2015-08-06T23:19:24Z | bernardosulzbach | train |
iluwatar/java-design-patterns/185_202 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/185 | iluwatar/java-design-patterns/202 | [
"timestamp(timedelta=185.0, similarity=0.8774521868148941)"
] | f14bb28db8448ef6fc5084b13e1c29f366a497b3 | fc43018684b0cb5af978db761c07c3fc856e91a2 | [
"Yes, why not. We could also setup a mailing list.\n",
"@iluwatar Great then. Let's do that. There is one more thing, I was thinking of setting up a wiki page describing usages of all design patterns. Do you think that is a good idea? IMO it would be better search optimized than README.md. We should continue doin... | [] | 2015-08-11T19:33:28Z | [
"type: enhancement"
] | Integrate with Gitter chat room | I recently stumbled upon [Gitter - chat rooms for github](https://gitter.im/) and I think it would be a great idea to integrate with it, because discussions regarding design patterns can be really interesting and may be more suitable in chat format.
| [
"README.md"
] | [
"README.md"
] | [] | diff --git a/README.md b/README.md
index 358dfa3f3934..b2b72a358d2f 100644
--- a/README.md
+++ b/README.md
@@ -1,5 +1,7 @@
# Design pattern samples in Java.
+[](https://gitter.im/iluwatar/java-design-patterns... | null | val | train | 2015-08-11T18:04:47 | 2015-08-02T07:39:26Z | npathai | train |
iluwatar/java-design-patterns/109_204 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/109 | iluwatar/java-design-patterns/204 | [
"keyword_issue_to_pr"
] | 76fe68f591f6b341a4b6d254a5c4d2d4b4e0cba5 | 27956b0eebd322f85a324fb6cc55d2075268817d | [
"Great find, thanks for reporting this.\n",
"I am working on it. \n",
"Note to self - we also need to add reference to POSA book with this task in README\n",
"Please close this issue, if you are satisfied.\n",
"Once #204 is merged we can close this.\n"
] | [] | 2015-08-12T06:14:50Z | [
"info: help wanted",
"epic: pattern"
] | Half Sync/Half Async pattern | This is a _concurrency_ pattern. The pattern separates asynchronous I/O from the synchronous one. Main thread doesn't block on incoming client requests and long-running operations are offloaded to a dedicated synchronous layer. Processing results are delivered by the means of callbacks.
Some resources:
- http://www.cs.... | [
"README.md"
] | [
"README.md"
] | [] | diff --git a/README.md b/README.md
index b2b72a358d2f..dc43a2dc5855 100644
--- a/README.md
+++ b/README.md
@@ -1037,6 +1037,8 @@ other words, version numbers are used only for project planning sake.
* [Spring Data](http://www.amazon.com/Spring-Data-Mark-Pollack/dp/1449323952/ref=sr_1_1)
* [J2EE Design Patterns](http:... | null | val | train | 2015-08-11T21:40:53 | 2015-07-23T06:07:31Z | npathai | train |
iluwatar/java-design-patterns/143_227 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/143 | iluwatar/java-design-patterns/227 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.9779156313707427)"
] | 4135179040ba9c06b347802d51d75952284dfae7 | a3f76fe30fb010c49c174c00aff7c613eb27afe8 | [] | [
"@iluwatar Why duplicated?\n",
"Doesn't `` produces the same result? It is clearer, shorter and more readable.\n",
"Should we really **ensure** that all DPs have an applicability field? In this case it is redundant (Intent already said this).\n",
"Why this dependen... | 2015-08-22T16:50:29Z | [
"epic: pattern",
"status: under review"
] | Message Channel (EIP) | [
"pom.xml"
] | [
"message-channel/.gitignore",
"message-channel/etc/message-channel.ucls",
"message-channel/index.md",
"message-channel/pom.xml",
"message-channel/src/main/java/com/iluwatar/message/channel/App.java",
"pom.xml"
] | [
"message-channel/src/test/java/com/iluwatar/message/channel/AppTest.java"
] | diff --git a/message-channel/.gitignore b/message-channel/.gitignore
new file mode 100644
index 000000000000..b83d22266ac8
--- /dev/null
+++ b/message-channel/.gitignore
@@ -0,0 +1,1 @@
+/target/
diff --git a/message-channel/etc/message-channel.ucls b/message-channel/etc/message-channel.ucls
new file mode 100644
index ... | diff --git a/message-channel/src/test/java/com/iluwatar/message/channel/AppTest.java b/message-channel/src/test/java/com/iluwatar/message/channel/AppTest.java
new file mode 100644
index 000000000000..fa3af1161dbe
--- /dev/null
+++ b/message-channel/src/test/java/com/iluwatar/message/channel/AppTest.java
@@ -0,0 +1,17 @... | val | train | 2015-09-02T11:47:06 | 2015-07-27T17:14:45Z | iluwatar | train | |
iluwatar/java-design-patterns/208_245 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/208 | iluwatar/java-design-patterns/245 | [
"timestamp(timedelta=97.0, similarity=0.845097672222473)"
] | 9ecb1b25462402e39cdf52596669789330f9105a | 8fdba13888c25d44b6e4875f009113a2946d909e | [
":+1: \n",
"This could be its own section, like for example the \"Idioms\" is.\n",
"We should borrow some things from here http://webpro.github.io/programming-principles/\n",
"@iluwatar That's a great link. I will go through it. Yes it should be in a dedicated section something like \"Design guidelines or pri... | [] | 2015-09-08T07:29:13Z | [
"type: enhancement",
"info: good first issue"
] | Document design principles | SOLID | YAGNI | Some of the design principles that I know of are:
- [SOLID](https://en.wikipedia.org/wiki/SOLID_%28object-oriented_design%29)
- [Tell Don't Ask](http://martinfowler.com/bliki/TellDontAsk.html)
- [YAGNI](https://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it)
- [KISS](https://en.wikipedia.org/wiki/KISS_principle)
- [... | [
"README.md"
] | [
"README.md"
] | [] | diff --git a/README.md b/README.md
index a4ec970c9d9b..77282f569fb7 100644
--- a/README.md
+++ b/README.md
@@ -21,6 +21,17 @@ Reusing design patterns helps to prevent subtle issues that can cause major
problems, and it also improves code readability for coders and architects who
are familiar with the patterns.
+# G... | null | train | train | 2015-09-11T09:54:15 | 2015-08-14T10:57:29Z | npathai | train |
iluwatar/java-design-patterns/247_253 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/247 | iluwatar/java-design-patterns/253 | [
"timestamp(timedelta=23.0, similarity=0.9613100109898698)"
] | b3e4e8a47bf5f88277029534456334d9e2c59432 | 9e25e7b518c98189098de17b586fbfeb6f96596e | [] | [] | 2015-09-23T17:00:37Z | [
"info: help wanted",
"type: enhancement",
"info: good first issue"
] | add getAttackPower method to pattern decorator | Add getAttackPower method to pattern decorator may make it more easily to understand .
when the troll not add smart decorator , his attack power is 10 ,but when we build the smartTroll , his attack power is 10(the normal troll's attack power) + 20(because smart). So ,it's more easy to understand .
| [
"decorator/src/main/java/com/iluwatar/decorator/App.java",
"decorator/src/main/java/com/iluwatar/decorator/Hostile.java",
"decorator/src/main/java/com/iluwatar/decorator/SmartTroll.java",
"decorator/src/main/java/com/iluwatar/decorator/Troll.java"
] | [
"decorator/src/main/java/com/iluwatar/decorator/App.java",
"decorator/src/main/java/com/iluwatar/decorator/Hostile.java",
"decorator/src/main/java/com/iluwatar/decorator/SmartTroll.java",
"decorator/src/main/java/com/iluwatar/decorator/Troll.java"
] | [] | diff --git a/decorator/src/main/java/com/iluwatar/decorator/App.java b/decorator/src/main/java/com/iluwatar/decorator/App.java
index 88e1c7103175..a9eabf6068c0 100644
--- a/decorator/src/main/java/com/iluwatar/decorator/App.java
+++ b/decorator/src/main/java/com/iluwatar/decorator/App.java
@@ -23,11 +23,13 @@ public st... | null | train | train | 2015-09-22T14:55:56 | 2015-09-10T10:38:26Z | liangpengfei | train |
iluwatar/java-design-patterns/161_272 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/161 | iluwatar/java-design-patterns/272 | [
"timestamp(timedelta=331.0, similarity=0.8542647842238095)"
] | a2b8359ab5b844f9c2ae4abcff304181121545f7 | bac87ba5267ff0b74149c228e38f04ccdf30f6df | [
"This pattern is similar in intent to Observer pattern. \n\n## Observer\n- Is used for same process events\n- Subscriber is aware of the publisher's existence\n- It is one (pub) to many (subs)\n- Publisher fires the on change events\n- Events are fired in sync\n- Implementation: `Observable` and `Observer` classes ... | [
"You could have pluralized Subscriber. It sounds more natural.\n"
] | 2015-10-25T06:12:20Z | [
"epic: pattern"
] | Publish-Subscribe Channel (EIP) | [
"pom.xml"
] | [
"pom.xml",
"publish-subscribe/.gitignore",
"publish-subscribe/etc/publish-subscribe.ucls",
"publish-subscribe/index.md",
"publish-subscribe/pom.xml",
"publish-subscribe/src/main/java/com/iluwatar/publish/subscribe/App.java"
] | [
"publish-subscribe/src/test/java/com/iluwatar/publish/subscribe/AppTest.java"
] | diff --git a/pom.xml b/pom.xml
index 3064f3c0dd8f..e01dc10018b6 100644
--- a/pom.xml
+++ b/pom.xml
@@ -80,6 +80,7 @@
<module>message-channel</module>
<module>fluentinterface</module>
<module>reactor</module>
+ <module>publish-subscribe</module>
</modules>
<dependencyManagement>
diff --git a/publish-subs... | diff --git a/publish-subscribe/src/test/java/com/iluwatar/publish/subscribe/AppTest.java b/publish-subscribe/src/test/java/com/iluwatar/publish/subscribe/AppTest.java
new file mode 100644
index 000000000000..743e4200d161
--- /dev/null
+++ b/publish-subscribe/src/test/java/com/iluwatar/publish/subscribe/AppTest.java
@@ ... | train | train | 2015-10-20T22:37:39 | 2015-07-27T17:21:45Z | iluwatar | train | |
iluwatar/java-design-patterns/286_291 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/286 | iluwatar/java-design-patterns/291 | [
"timestamp(timedelta=1791.0, similarity=0.9041927577945027)"
] | 27199325ec5c45260b9ea6849ea91bffe0ab7864 | efd771e0723357f20fe165765964e97bbc4eca49 | [
"I'm working on it!\n",
"@tainarareis do you want me to help you?\n"
] | [] | 2015-11-14T18:58:35Z | [
"type: bug",
"info: good first issue"
] | No main method in the Abstract Factory example | There is no `main` method in the Abstract Factory example.
| [
"abstract-factory/src/main/java/com/iluwatar/abstractfactory/App.java"
] | [
"abstract-factory/src/main/java/com/iluwatar/abstractfactory/App.java"
] | [] | diff --git a/abstract-factory/src/main/java/com/iluwatar/abstractfactory/App.java b/abstract-factory/src/main/java/com/iluwatar/abstractfactory/App.java
index 5b93f0e46b0c..9a32a091a899 100644
--- a/abstract-factory/src/main/java/com/iluwatar/abstractfactory/App.java
+++ b/abstract-factory/src/main/java/com/iluwatar/ab... | null | test | train | 2015-11-07T10:48:51 | 2015-11-11T06:05:52Z | iluwatar | train |
iluwatar/java-design-patterns/216_305 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/216 | iluwatar/java-design-patterns/305 | [
"keyword_pr_to_issue",
"timestamp(timedelta=3.0, similarity=0.9066002615815714)"
] | 092d48d15091cb950232c44d76c0243fa8de53a2 | c1f85587d65f557e4148b5f98ee71a13716b64e9 | [
"Hi @stephen-lazarionok and thanks for pointing out the interesting article. We would like to improve the example so that it would better distinguish Repository from DAO. I noticed that the class naming could be improved and maybe add a query method that takes criteria as a parameter like they have in the article. ... | [] | 2015-11-27T03:30:15Z | [
"type: bug",
"info: help wanted",
"type: enhancement"
] | Repository vs DAO | I think that Repository pattern is not implemented in the correct way and it looks like DAO. Here is a good article about this http://thinkinginobjects.com/2012/08/26/dont-use-dao-use-repository/
| [
"pom.xml",
"repository/etc/repository.ucls",
"repository/index.md",
"repository/pom.xml",
"repository/src/main/java/com/iluwatar/repository/App.java",
"repository/src/main/java/com/iluwatar/repository/Person.java",
"repository/src/main/java/com/iluwatar/repository/PersonRepository.java",
"repository/s... | [
"pom.xml",
"repository/etc/repository.ucls",
"repository/index.md",
"repository/pom.xml",
"repository/src/main/java/com/iluwatar/repository/App.java",
"repository/src/main/java/com/iluwatar/repository/Person.java",
"repository/src/main/java/com/iluwatar/repository/PersonRepository.java",
"repository/s... | [
"repository/src/test/java/com/iluwatar/repository/RepositoryTest.java"
] | diff --git a/pom.xml b/pom.xml
index bcdf9affe8f1..e6603b06c58e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -11,6 +11,7 @@
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<hibernate.version>5.0.1.Final</hibernate.version>
+ <spring.version>4.1.7.RELEASE</spring.version>
<spring-dat... | diff --git a/repository/src/test/java/com/iluwatar/repository/AppTest.java b/repository/src/test/java/com/iluwatar/repository/AppTest.java
deleted file mode 100644
index 929f619414e4..000000000000
--- a/repository/src/test/java/com/iluwatar/repository/AppTest.java
+++ /dev/null
@@ -1,19 +0,0 @@
-package com.iluwatar.re... | val | train | 2015-11-22T07:44:13 | 2015-08-16T18:43:28Z | stephen-lazarionok | train |
iluwatar/java-design-patterns/310_314 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/310 | iluwatar/java-design-patterns/314 | [
"timestamp(timedelta=33.0, similarity=0.9488786238260379)"
] | e85308fbc47202203d61ed373957003a10753c1e | d4dfcfbf6af7fa03a9d6360f63fc76d8fca212d2 | [] | [] | 2015-12-08T21:26:21Z | [
"info: help wanted",
"type: enhancement",
"info: good first issue"
] | Functional approach to Strategy pattern | The Strategy pattern example should include Java 8 specific solution.
For inspiration, read this: http://alvinalexander.com/scala/how-scala-killed-oop-strategy-design-pattern
| [
"strategy/src/main/java/com/iluwatar/strategy/App.java",
"strategy/src/main/java/com/iluwatar/strategy/DragonSlayingStrategy.java"
] | [
"strategy/src/main/java/com/iluwatar/strategy/App.java",
"strategy/src/main/java/com/iluwatar/strategy/DragonSlayingStrategy.java"
] | [] | diff --git a/strategy/src/main/java/com/iluwatar/strategy/App.java b/strategy/src/main/java/com/iluwatar/strategy/App.java
index 272e56cf9e51..e2bcfef8a35e 100644
--- a/strategy/src/main/java/com/iluwatar/strategy/App.java
+++ b/strategy/src/main/java/com/iluwatar/strategy/App.java
@@ -5,6 +5,10 @@
* The Strategy pat... | null | train | train | 2015-12-08T19:53:15 | 2015-12-06T11:32:15Z | iluwatar | train |
iluwatar/java-design-patterns/334_337 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/334 | iluwatar/java-design-patterns/337 | [
"timestamp(timedelta=3.0, similarity=0.8682567792127716)"
] | e0e51324dbbfdfbc54c41327ea22e25f0b849278 | dd91243ff038934f9fc888bf430a5994c67a080f | [
"I have added an example, not sure if this is really what you're asking for.\n"
] | [] | 2016-01-01T23:44:03Z | [
"info: help wanted",
"type: enhancement",
"info: good first issue"
] | Callback implemented with lambdas | In the Callback example show how to implement the same thing with Java 8 lambdas.
| [] | [
"callback/src/main/java/com/iluwatar/callback/LambdasApp.java"
] | [
"callback/src/test/java/com/iluwatar/callback/AppTest.java"
] | diff --git a/callback/src/main/java/com/iluwatar/callback/LambdasApp.java b/callback/src/main/java/com/iluwatar/callback/LambdasApp.java
new file mode 100644
index 000000000000..19dd17eae441
--- /dev/null
+++ b/callback/src/main/java/com/iluwatar/callback/LambdasApp.java
@@ -0,0 +1,19 @@
+package com.iluwatar.callback;... | diff --git a/callback/src/test/java/com/iluwatar/callback/AppTest.java b/callback/src/test/java/com/iluwatar/callback/AppTest.java
index 67046a175590..28d6eaa1cea1 100644
--- a/callback/src/test/java/com/iluwatar/callback/AppTest.java
+++ b/callback/src/test/java/com/iluwatar/callback/AppTest.java
@@ -36,4 +36,22 @@ pu... | train | train | 2016-01-01T19:39:20 | 2015-12-31T09:46:51Z | iluwatar | train |
iluwatar/java-design-patterns/264_340 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/264 | iluwatar/java-design-patterns/340 | [
"timestamp(timedelta=79.0, similarity=0.981666368921619)"
] | 4c5f9ae44c36f7fcc9dd8e2b4ef7bcfca0207720 | 2d4e1118113926ff91062d8a5d826b56462d9fd6 | [
"I would suggest that we change the example so that `SmartTroll extends Troll`. It wouldn't hurt to add `Goblin` to the example too :smile: \n",
"@iluwatar \nThat would be a possible solution too, but the SmartTroll doesn't do anything Troll-specific (allthough the string \"The troll throws a rock at you!\" is ha... | [
"This method should be renamed to testSmartHostile\n"
] | 2016-01-04T15:12:59Z | [
"info: help wanted",
"info: good first issue"
] | Decorator pattern: SmartTroll should be SmartHostile | As the SmartTroll decorates any Hostile object, it should be named SmartHostile instead. Because if there's a Goblin class implementing the Hostile interface, the SmartTroll class is technically able to decorate it too, even though it is named SmartTroll (which indicates that it should only be a Troll).
| [
"decorator/etc/decorator.ucls",
"decorator/src/main/java/com/iluwatar/decorator/App.java",
"decorator/src/main/java/com/iluwatar/decorator/SmartTroll.java"
] | [
"decorator/etc/decorator.ucls",
"decorator/src/main/java/com/iluwatar/decorator/App.java",
"decorator/src/main/java/com/iluwatar/decorator/SmartHostile.java"
] | [
"decorator/src/test/java/com/iluwatar/decorator/SmartHostileTest.java"
] | diff --git a/decorator/etc/decorator.ucls b/decorator/etc/decorator.ucls
index 7adb8c3a685a..a5353d4ecf4a 100644
--- a/decorator/etc/decorator.ucls
+++ b/decorator/etc/decorator.ucls
@@ -1,18 +1,18 @@
<?xml version="1.0" encoding="UTF-8"?>
-<class-diagram version="1.1.8" icons="true" automaticImage="PNG" always-add-re... | diff --git a/decorator/src/test/java/com/iluwatar/decorator/SmartTrollTest.java b/decorator/src/test/java/com/iluwatar/decorator/SmartHostileTest.java
similarity index 85%
rename from decorator/src/test/java/com/iluwatar/decorator/SmartTrollTest.java
rename to decorator/src/test/java/com/iluwatar/decorator/SmartHostile... | train | train | 2016-01-04T02:15:37 | 2015-10-12T13:41:41Z | Niko-O | train |
iluwatar/java-design-patterns/343_344 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/343 | iluwatar/java-design-patterns/344 | [
"timestamp(timedelta=8211.0, similarity=0.9325257067946403)",
"keyword_pr_to_issue"
] | 150c4e0d5d6f4e1831f997cfbb018ede3b6bd8d1 | 2fdc1d099bffbaa19e947595b2096b6e90dba93d | [
"From the log file of [Travis-Ci](https://api.travis-ci.org/jobs/101915401/log.txt?deansi=true), it pointouts that reader thread submited to the thread pool cannot be executed in 149(99+50)ms. I suspect that the Travis-Ci has a high load and it can't assume the read can executed in accurate time. I have revised t... | [] | 2016-01-14T01:01:02Z | [
"type: bug"
] | ReaderWriterLock unit tests fail on CI | Something wrong with the ReaderWriterLock unit tests.
See Travis builds:
https://travis-ci.org/iluwatar/java-design-patterns/builds/101906103
https://travis-ci.org/iluwatar/java-design-patterns/builds/101915400
https://travis-ci.org/iluwatar/java-design-patterns/builds/101917864
| [
"reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/App.java",
"reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/Reader.java",
"reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/Writer.java"
] | [
"reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/App.java",
"reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/Reader.java",
"reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/Writer.java"
] | [
"reader-writer-lock/src/test/java/com/iluwatar/reader/writer/lock/ReaderAndWriterTest.java",
"reader-writer-lock/src/test/java/com/iluwatar/reader/writer/lock/ReaderTest.java",
"reader-writer-lock/src/test/java/com/iluwatar/reader/writer/lock/StdOutTest.java",
"reader-writer-lock/src/test/java/com/iluwatar/re... | diff --git a/reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/App.java b/reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/App.java
index 1d02b6cadc96..b11b11be76ca 100644
--- a/reader-writer-lock/src/main/java/com/iluwatar/reader/writer/lock/App.java
+++ b/reader-writer-lock/src/main/jav... | diff --git a/reader-writer-lock/src/test/java/com/iluwatar/reader/writer/lock/ReaderAndWriterTest.java b/reader-writer-lock/src/test/java/com/iluwatar/reader/writer/lock/ReaderAndWriterTest.java
index 3f3809be9b38..e29f578894b5 100644
--- a/reader-writer-lock/src/test/java/com/iluwatar/reader/writer/lock/ReaderAndWrite... | val | train | 2016-01-12T20:16:39 | 2016-01-12T19:23:25Z | iluwatar | train |
iluwatar/java-design-patterns/349_362 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/349 | iluwatar/java-design-patterns/362 | [
"timestamp(timedelta=96.0, similarity=0.9023621712956228)"
] | 33224dd7d7b6d4d3a0845ba8f9ecdf5d699ca2e9 | a3a075b38e6dd437a976822ecfceb0c24c4110ea | [
"I think the definition of the Value Object is fairly comprehensive.\nThinking of implementing a pattern. How about this : VALJO - Value Java Objects\nwhich has more strict set of rules for a correctly defined immutable value object. \nSuggested by Stephen Colebourne.\nhttp://blog.joda.org/2014/03/valjos-value-java... | [
"Did you mean to change this file?\n",
"Did you mean to change this?\n",
"Please describe the pattern and the example here. For reference, see other pattern examples.\n",
"I don't know why these blanks exist and make differences in this file. I only added one line <module>value-object</module>.\n"
] | 2016-01-28T16:01:16Z | [
"epic: pattern"
] | Value Object pattern | http://martinfowler.com/bliki/ValueObject.html
| [
"pom.xml"
] | [
"pom.xml",
"value-object/etc/value-object.ucls",
"value-object/index.md",
"value-object/pom.xml",
"value-object/src/main/java/com/iluwatar/value/object/App.java",
"value-object/src/main/java/com/iluwatar/value/object/HeroStat.java"
] | [
"value-object/src/test/java/com/iluwatar/value/object/AppTest.java",
"value-object/src/test/java/com/iluwatar/value/object/HeroStatTest.java"
] | diff --git a/pom.xml b/pom.xml
index 482110e64d06..c15ca20cfb1c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -120,6 +120,7 @@
<module>delegation</module>
<module>event-driven-architecture</module>
<module>feature-toggle</module>
+ <module>value-object</module>
</modules>
<dependencyManagement>
@@ -199,8 +200,8... | diff --git a/value-object/src/test/java/com/iluwatar/value/object/AppTest.java b/value-object/src/test/java/com/iluwatar/value/object/AppTest.java
new file mode 100644
index 000000000000..aed3c2f20511
--- /dev/null
+++ b/value-object/src/test/java/com/iluwatar/value/object/AppTest.java
@@ -0,0 +1,15 @@
+package com.ilu... | test | train | 2016-02-02T21:14:20 | 2016-01-16T10:48:23Z | iluwatar | train |
iluwatar/java-design-patterns/333_377 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/333 | iluwatar/java-design-patterns/377 | [
"timestamp(timedelta=94187.0, similarity=0.8532308169437328)"
] | 823dc6395fbba21d77d793ac8997381b045824e9 | 985232ceaa1e0ac0ec2ea14a706b9063218edad7 | [] | [] | 2016-02-12T10:25:05Z | [
"info: help wanted",
"epic: pattern",
"type: enhancement"
] | Abstract Factory implemented with lambdas | In the Abstract Factory example show how to implement the pattern with Java 8 lambdas.
There is an example in this talk: https://youtu.be/-k2X7guaArU
| [
"abstract-factory/src/main/java/com/iluwatar/abstractfactory/App.java",
"factory-method/src/main/java/com/iluwatar/factory/method/App.java"
] | [
"abstract-factory/src/main/java/com/iluwatar/abstractfactory/App.java",
"factory-method/src/main/java/com/iluwatar/factory/method/App.java"
] | [
"abstract-factory/src/test/java/com/iluwatar/abstractfactory/AbstractFactoryTest.java",
"factory-method/src/test/java/com/iluwatar/factory/method/FactoryMethodTest.java"
] | diff --git a/abstract-factory/src/main/java/com/iluwatar/abstractfactory/App.java b/abstract-factory/src/main/java/com/iluwatar/abstractfactory/App.java
index 15265c0d4e8f..aae396f1dc26 100644
--- a/abstract-factory/src/main/java/com/iluwatar/abstractfactory/App.java
+++ b/abstract-factory/src/main/java/com/iluwatar/ab... | diff --git a/abstract-factory/src/test/java/com/iluwatar/abstractfactory/AbstractFactoryTest.java b/abstract-factory/src/test/java/com/iluwatar/abstractfactory/AbstractFactoryTest.java
index 5eb083deb2ef..216f0443ae1c 100644
--- a/abstract-factory/src/test/java/com/iluwatar/abstractfactory/AbstractFactoryTest.java
+++ ... | test | train | 2016-02-12T11:14:31 | 2015-12-31T09:41:49Z | iluwatar | train |
iluwatar/java-design-patterns/335_388 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/335 | iluwatar/java-design-patterns/388 | [
"timestamp(timedelta=57.0, similarity=1.0000000000000002)"
] | dfef28e93eb942fc8e9ca12eca64e0ae568aa6b2 | 885018b7485f20d8817246a73df819e21fb1e8e6 | [
"One more useful link: https://channel9.msdn.com/Shows/Going+Deep/Brian-Beckman-Dont-fear-the-Monads\n\nA rather detailed discussion explaining the fundamentals of monads.\n",
"I will work on that issue tomorrow \n",
"Ok @Crossy147 I will update the issue tags.\n"
] | [] | 2016-02-19T18:14:15Z | [
"epic: pattern"
] | Monad pattern | It is described in this talk: https://youtu.be/-k2X7guaArU
| [
"pom.xml"
] | [
"monad/etc/monad.ucls",
"monad/index.md",
"monad/pom.xml",
"monad/src/main/java/com/iluwatar/monad/App.java",
"monad/src/main/java/com/iluwatar/monad/Sex.java",
"monad/src/main/java/com/iluwatar/monad/User.java",
"monad/src/main/java/com/iluwatar/monad/Validator.java",
"pom.xml"
] | [
"monad/src/test/java/com/iluwatar/monad/AppTest.java",
"monad/src/test/java/com/iluwatar/monad/MonadTest.java"
] | diff --git a/monad/etc/monad.ucls b/monad/etc/monad.ucls
new file mode 100644
index 000000000000..9c98df7c6331
--- /dev/null
+++ b/monad/etc/monad.ucls
@@ -0,0 +1,54 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<class-diagram version="1.1.9" icons="true" always-add-relationships="false" generalizations="true" realizatio... | diff --git a/monad/src/test/java/com/iluwatar/monad/AppTest.java b/monad/src/test/java/com/iluwatar/monad/AppTest.java
new file mode 100644
index 000000000000..5d23b41a6759
--- /dev/null
+++ b/monad/src/test/java/com/iluwatar/monad/AppTest.java
@@ -0,0 +1,13 @@
+package com.iluwatar.monad;
+
+import org.junit.Test;
+
+... | train | train | 2016-02-18T08:09:06 | 2015-12-31T09:51:48Z | iluwatar | train |
iluwatar/java-design-patterns/385_402 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/385 | iluwatar/java-design-patterns/402 | [
"timestamp(timedelta=165318.0, similarity=0.9157572033852361)"
] | 2f5a2be27a9541b894b94049e02010f6dabd5b76 | 100a72a5e2d2675b6f9c4624219658a73af2a3f7 | [
"Have used this idiom numerous times. On it.\n\nI will be creating two mute methods:\n- `mute()` throws `AssertionError` if unexpected exception occurs. Should be used when some class declares exception but should never throw exception.\n- `loggedMute()` swallows exception by logging it on err stream. Should be use... | [
"Check indentation\n"
] | 2016-03-16T07:22:39Z | [
"epic: pattern"
] | Mute idiom | http://blog.jooq.org/2016/02/18/the-mute-design-pattern/
| [
"pom.xml"
] | [
"mute-idiom/README.md",
"mute-idiom/etc/mute-idiom.ucls",
"mute-idiom/pom.xml",
"mute-idiom/src/main/java/com/iluwatar/mute/App.java",
"mute-idiom/src/main/java/com/iluwatar/mute/CheckedRunnable.java",
"mute-idiom/src/main/java/com/iluwatar/mute/Mute.java",
"mute-idiom/src/main/java/com/iluwatar/mute/Re... | [
"mute-idiom/src/test/java/com/iluwatar/mute/AppTest.java",
"mute-idiom/src/test/java/com/iluwatar/mute/MuteTest.java"
] | diff --git a/mute-idiom/README.md b/mute-idiom/README.md
new file mode 100644
index 000000000000..efc09f3069d0
--- /dev/null
+++ b/mute-idiom/README.md
@@ -0,0 +1,28 @@
+---
+layout: pattern
+title: Mute Idiom
+folder: mute-idiom
+permalink: /patterns/mute-idiom/
+categories: Other
+tags:
+ - Java
+ - Difficulty-Begin... | diff --git a/mute-idiom/src/test/java/com/iluwatar/mute/AppTest.java b/mute-idiom/src/test/java/com/iluwatar/mute/AppTest.java
new file mode 100644
index 000000000000..8075d9c855fa
--- /dev/null
+++ b/mute-idiom/src/test/java/com/iluwatar/mute/AppTest.java
@@ -0,0 +1,38 @@
+/**
+ * The MIT License
+ * Copyright (c) 201... | test | train | 2016-03-25T21:00:08 | 2016-02-18T16:33:13Z | iluwatar | train |
iluwatar/java-design-patterns/463_464 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/463 | iluwatar/java-design-patterns/464 | [
"timestamp(timedelta=122.0, similarity=0.862426888756227)"
] | 9f0320aeaf31e9376da44b53e3e6ecdad7cbbfde | d4c2f0392d2588c1de95659b90bd356d7a057a2e | [
"Thanks @pnowy Please create a pull request and we'll review it.\n",
"Pull request has been created!\n"
] | [] | 2016-07-17T14:08:35Z | [
"type: enhancement",
"epic: web site"
] | Chain of responsiblity pattern - javax.servlet.Filter as real example is missed | I think that on the chain of responsibility pattern on the section real word examples the most important java real word example is missed.
I suggest to add there **javax.servlet.Filter** as the best patter for the people who meet this patter the first time.
I could create the pull request if it is needed.
| [
"intercepting-filter/README.md"
] | [
"intercepting-filter/README.md"
] | [] | diff --git a/intercepting-filter/README.md b/intercepting-filter/README.md
index 327f091b1e93..7d53472a077f 100644
--- a/intercepting-filter/README.md
+++ b/intercepting-filter/README.md
@@ -24,6 +24,7 @@ Use the Intercepting Filter pattern when
## Real world examples
+* [javax.servlet.FilterChain](https://tomcat.... | null | train | train | 2016-07-12T23:02:20 | 2016-07-17T09:55:03Z | pnowy | train |
iluwatar/java-design-patterns/440_495 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/440 | iluwatar/java-design-patterns/495 | [
"timestamp(timedelta=324.0, similarity=0.8920156408089317)"
] | 6026eedd51b9753250051b620312bbedd2ccd6ef | 64bdab46b9771d1d8aa7497b6e30cd3843ba011e | [
"Thanks for an excellent project, I thought I should contribute something back and this one seemed like a low-hanging fruit.\n\nWould it make sense to simply add two helper methods in AppManager, e.g. `saveAside` and `findAside`\n\n``` java\nprivate static void saveAside(UserAccount userAccount) {\n DbManager.up... | [
"Is there any reason for not using logging framework like SLF4J or LOG4J Or Common logging?\n",
"@chinnachalam you are right, using a logging framework would give some advantages such as ability to redirect output and filter output based on logging levels. But I think we should handle this issue on a more general... | 2016-09-22T18:54:46Z | [
"epic: pattern"
] | Cache Aside pattern | https://msdn.microsoft.com/en-us/library/dn589799.aspx
This pattern could be incorporated into https://github.com/iluwatar/java-design-patterns/tree/master/caching example.
| [
"caching/README.md",
"caching/etc/caching.ucls",
"caching/src/main/java/com/iluwatar/caching/App.java",
"caching/src/main/java/com/iluwatar/caching/AppManager.java",
"caching/src/main/java/com/iluwatar/caching/CacheStore.java",
"caching/src/main/java/com/iluwatar/caching/CachingPolicy.java",
"caching/sr... | [
"caching/README.md",
"caching/etc/caching.ucls",
"caching/src/main/java/com/iluwatar/caching/App.java",
"caching/src/main/java/com/iluwatar/caching/AppManager.java",
"caching/src/main/java/com/iluwatar/caching/CacheStore.java",
"caching/src/main/java/com/iluwatar/caching/CachingPolicy.java",
"caching/sr... | [
"caching/src/test/java/com/iluwatar/caching/CachingTest.java"
] | diff --git a/caching/README.md b/caching/README.md
index 6432ffcea26e..b48d060f0012 100644
--- a/caching/README.md
+++ b/caching/README.md
@@ -27,3 +27,4 @@ Use the Caching pattern(s) when
* [Write-through, write-around, write-back: Cache explained](http://www.computerweekly.com/feature/Write-through-write-around-wr... | diff --git a/caching/src/test/java/com/iluwatar/caching/CachingTest.java b/caching/src/test/java/com/iluwatar/caching/CachingTest.java
index 19262a3b6e35..9d2299902a8c 100644
--- a/caching/src/test/java/com/iluwatar/caching/CachingTest.java
+++ b/caching/src/test/java/com/iluwatar/caching/CachingTest.java
@@ -60,4 +60,... | train | train | 2016-09-18T16:51:09 | 2016-07-02T16:56:23Z | iluwatar | train |
iluwatar/java-design-patterns/437_500 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/437 | iluwatar/java-design-patterns/500 | [
"timestamp(timedelta=6.0, similarity=0.8973045866339322)"
] | 4ca205c03cc03ea5bc80fe27c0a4594f0d087582 | a37a29e12b43055dea72902e6bae1f3b72bddd41 | [
"https://sites.google.com/site/steveyegge2/singleton-considered-stupid\n",
"http://www.yegor256.com/2016/06/27/singletons-must-die.html\n",
"http://misko.hevery.com/2008/08/17/singletons-are-pathological-liars/\n",
"HI!\n\nI would like to pick this one and #436 as well.\n",
"@dmitraver you're good to go!\n"... | [] | 2016-10-04T12:37:44Z | [
"type: enhancement",
"info: good first issue"
] | Add criticism to Singleton | http://stackoverflow.com/questions/137975/what-is-so-bad-about-singletons
| [
"service-locator/README.md",
"singleton/README.md"
] | [
"service-locator/README.md",
"singleton/README.md"
] | [] | diff --git a/service-locator/README.md b/service-locator/README.md
index 31d82b13f8bd..479c9ed0f942 100644
--- a/service-locator/README.md
+++ b/service-locator/README.md
@@ -33,6 +33,12 @@ improves the performance of application to great extent.
* lookups of services are done quite frequently
* large number of servi... | null | train | train | 2016-09-30T18:40:28 | 2016-06-28T18:36:46Z | iluwatar | train |
iluwatar/java-design-patterns/436_500 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/436 | iluwatar/java-design-patterns/500 | [
"timestamp(timedelta=0.0, similarity=0.9452600425800433)"
] | 4ca205c03cc03ea5bc80fe27c0a4594f0d087582 | a37a29e12b43055dea72902e6bae1f3b72bddd41 | [
"Assigned to @dmitraver\n"
] | [] | 2016-10-04T12:37:44Z | [
"type: enhancement",
"info: good first issue"
] | Add criticism to Service Locator | More information could be added to `Consequences` section of the Service Locator pattern.
http://criticalsoftwareblog.com/index.php/2015/10/25/object-composability-another-reason-why-the-service-locator-is-an-anti-pattern/
See the pattern template here: https://github.com/iluwatar/java-design-patterns/wiki/02.-Patter... | [
"service-locator/README.md",
"singleton/README.md"
] | [
"service-locator/README.md",
"singleton/README.md"
] | [] | diff --git a/service-locator/README.md b/service-locator/README.md
index 31d82b13f8bd..479c9ed0f942 100644
--- a/service-locator/README.md
+++ b/service-locator/README.md
@@ -33,6 +33,12 @@ improves the performance of application to great extent.
* lookups of services are done quite frequently
* large number of servi... | null | train | train | 2016-09-30T18:40:28 | 2016-06-26T07:56:03Z | iluwatar | train |
iluwatar/java-design-patterns/498_503 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/498 | iluwatar/java-design-patterns/503 | [
"timestamp(timedelta=72.0, similarity=0.9380508949000216)"
] | 19cb715d20f269eb00aa6569244bf090459eb6b7 | cc02ff472b217a9b19d07dd4af84fa888ef469cb | [
"Hi! Great library :+1: \nI want to take this one but what is the main difference to a simple [factory pattern](https://www.tutorialspoint.com/design_pattern/factory_pattern.htm)?\n\nSince the link you shared was working with employees i have thought for something like this:\n\n``` java\nEmployeeMother mother = new... | [
"Confusing naming here\n",
"Confusing naming here\n",
"Confusing naming here\n"
] | 2016-10-06T18:15:38Z | [
"epic: pattern",
"info: good first issue"
] | Object Mother pattern | http://martinfowler.com/bliki/ObjectMother.html
| [
"pom.xml"
] | [
"object-mother/README.md",
"object-mother/etc/object-mother.ucls",
"object-mother/etc/object-mother.urm.puml",
"object-mother/pom.xml",
"object-mother/src/main/java/com/iluwatar/objectmother/King.java",
"object-mother/src/main/java/com/iluwatar/objectmother/Queen.java",
"object-mother/src/main/java/com/... | [
"object-mother/src/test/java/com/iluwatar/objectmother/test/RoyaltyObjectMotherTest.java"
] | diff --git a/object-mother/README.md b/object-mother/README.md
new file mode 100644
index 000000000000..9188c8b4128d
--- /dev/null
+++ b/object-mother/README.md
@@ -0,0 +1,31 @@
+---
+layout: pattern
+title: Object Mother
+folder: object-mother
+permalink: /patterns/object-mother/
+pumlid:
+categories: Creational
+tag... | diff --git a/object-mother/src/test/java/com/iluwatar/objectmother/test/RoyaltyObjectMotherTest.java b/object-mother/src/test/java/com/iluwatar/objectmother/test/RoyaltyObjectMotherTest.java
new file mode 100644
index 000000000000..ebe536d24bcc
--- /dev/null
+++ b/object-mother/src/test/java/com/iluwatar/objectmother/t... | train | train | 2016-10-19T22:08:51 | 2016-10-02T04:36:47Z | iluwatar | train |
iluwatar/java-design-patterns/621_623 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/621 | iluwatar/java-design-patterns/623 | [
"keyword_pr_to_issue"
] | f28ed7b46e5897f53efb20041e92f13a90fb9209 | 6c9e005a799fddd0200b4276d96b338dcb13b488 | [
"I'm happy to submit a PR for this"
] | [] | 2017-09-01T01:29:35Z | [
"type: bug",
"info: help wanted",
"info: good first issue"
] | Missing synchronized keyword | Hi,
https://github.com/iluwatar/java-design-patterns/blob/master/object-pool/src/main/java/com/iluwatar/object/pool/ObjectPool.java#L58 - the method should also be `synchronized`.
Best regards,
Martin | [
"object-pool/src/main/java/com/iluwatar/object/pool/ObjectPool.java"
] | [
"object-pool/src/main/java/com/iluwatar/object/pool/ObjectPool.java"
] | [] | diff --git a/object-pool/src/main/java/com/iluwatar/object/pool/ObjectPool.java b/object-pool/src/main/java/com/iluwatar/object/pool/ObjectPool.java
index df6e887b86f1..e76d003521a5 100644
--- a/object-pool/src/main/java/com/iluwatar/object/pool/ObjectPool.java
+++ b/object-pool/src/main/java/com/iluwatar/object/pool/O... | null | train | train | 2017-08-31T21:11:58 | 2017-08-29T21:18:36Z | MartyIX | train |
iluwatar/java-design-patterns/631_636 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/631 | iluwatar/java-design-patterns/636 | [
"timestamp(timedelta=79.0, similarity=0.88090052548208)"
] | 1b0f55c3eb398fb12591619bd7e822beabd48825 | 99de0e1644aa1e2c1f6cfc47d87f088b562fdaf4 | [
"@iluwatar: I am picking this up for development.",
"Ok @gopinath-langote "
] | [
"Please keep the copyright unchanged e.g. Copyright (c) 2014-2017 Ilkka Seppälä. Check the other files for this too.",
"The class looks immutable the private fields should be declared final.",
"Can we name this class just `App` for consistency? This way it is easier for users to find the main class where to sta... | 2017-09-19T13:40:06Z | [
"epic: pattern"
] | Partial Response pattern | Pattern where an API lets clients specify the structure of the response.
http://yaoganglian.com/2013/07/01/partial-response/ | [
"pom.xml"
] | [
"partial-response/README.md",
"partial-response/etc/partial-response.ucls",
"partial-response/etc/partial-response.urm.puml",
"partial-response/pom.xml",
"partial-response/src/main/java/com/iluwatar/partialresponse/App.java",
"partial-response/src/main/java/com/iluwatar/partialresponse/FieldJsonMapper.jav... | [
"partial-response/src/test/java/com/iluwatar/partialresponse/AppTest.java",
"partial-response/src/test/java/com/iluwatar/partialresponse/FieldJsonMapperTest.java",
"partial-response/src/test/java/com/iluwatar/partialresponse/VideoResourceTest.java"
] | diff --git a/partial-response/README.md b/partial-response/README.md
new file mode 100644
index 000000000000..5d03cb359fb2
--- /dev/null
+++ b/partial-response/README.md
@@ -0,0 +1,29 @@
+---
+layout: pattern
+title: Partial Response
+folder: partial-response
+permalink: /patterns/partial-response/
+categories: Archite... | diff --git a/partial-response/src/test/java/com/iluwatar/partialresponse/AppTest.java b/partial-response/src/test/java/com/iluwatar/partialresponse/AppTest.java
new file mode 100644
index 000000000000..2ac34dd0d0a3
--- /dev/null
+++ b/partial-response/src/test/java/com/iluwatar/partialresponse/AppTest.java
@@ -0,0 +1,4... | train | train | 2017-09-19T07:48:23 | 2017-09-12T14:58:23Z | gopinath-langote | train |
iluwatar/java-design-patterns/176_651 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/176 | iluwatar/java-design-patterns/651 | [
"timestamp(timedelta=70.0, similarity=0.8823058885599248)"
] | dfb43299a88507211e9acb9a9f21a8ba54f0205a | 41710cbe9e3cb1f83e5f8eb9fce8bf2d4323aba0 | [
"Some Informations:\n- Description from EIP: http://www.enterpriseintegrationpatterns.com/patterns/messaging/WireTap.html\n- Implementation inside Apache Camel: http://camel.apache.org/wire-tap.html\n",
"I can help you out with most EIP patterns, starting from this one.",
"Thanks @codinghog go ahead :+1: "
] | [] | 2017-10-04T17:12:58Z | [
"epic: pattern"
] | Wire Tap (EIP) | [
"pom.xml"
] | [
"eip-wire-tap/README.md",
"eip-wire-tap/pom.xml",
"eip-wire-tap/src/main/java/com/iluwatar/eip/wiretap/App.java",
"eip-wire-tap/src/main/java/com/iluwatar/eip/wiretap/routes/WireTapRoute.java",
"eip-wire-tap/src/main/resources/application.properties",
"eip-wire-tap/src/test/resources/application-test.prop... | [
"eip-wire-tap/src/test/java/com/iluwatar/eip/wiretap/AppTest.java",
"eip-wire-tap/src/test/java/com/iluwatar/eip/wiretap/routes/WireTapRouteTest.java"
] | diff --git a/eip-wire-tap/README.md b/eip-wire-tap/README.md
new file mode 100644
index 000000000000..d2742aa313f9
--- /dev/null
+++ b/eip-wire-tap/README.md
@@ -0,0 +1,29 @@
+---
+layout: pattern
+title: EIP Wire Tap
+folder: eip-wire-tap
+permalink: /patterns/eip-wire-tap/
+categories: Enterprise integration
+tags:
+... | diff --git a/eip-wire-tap/src/test/java/com/iluwatar/eip/wiretap/AppTest.java b/eip-wire-tap/src/test/java/com/iluwatar/eip/wiretap/AppTest.java
new file mode 100644
index 000000000000..25b9d8550f4c
--- /dev/null
+++ b/eip-wire-tap/src/test/java/com/iluwatar/eip/wiretap/AppTest.java
@@ -0,0 +1,15 @@
+package com.iluwat... | train | train | 2017-10-12T16:13:57 | 2015-07-27T17:26:37Z | iluwatar | train | |
iluwatar/java-design-patterns/173_655 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/173 | iluwatar/java-design-patterns/655 | [
"timestamp(timedelta=18.0, similarity=0.861311107588729)"
] | 41710cbe9e3cb1f83e5f8eb9fce8bf2d4323aba0 | 168c9cf3a9054663ca4e17574b6dcdfdd172f5ba | [
"I can work on this one. \r\nSources:\r\n- http://www.enterpriseintegrationpatterns.com/patterns/messaging/Sequencer.html\r\n- http://camel.apache.org/splitter.html",
"Ok @codinghog "
] | [] | 2017-10-17T10:49:34Z | [
"epic: pattern"
] | Splitter (EIP) | [
"pom.xml"
] | [
"eip-splitter/README.md",
"eip-splitter/pom.xml",
"eip-splitter/src/main/java/com/iluwatar/eip/splitter/App.java",
"eip-splitter/src/main/java/com/iluwatar/eip/splitter/routes/SplitterRoute.java",
"eip-splitter/src/main/resources/application.properties",
"eip-splitter/src/test/resources/application-test.p... | [
"eip-splitter/src/test/java/com/iluwatar/eip/splitter/AppTest.java",
"eip-splitter/src/test/java/com/iluwatar/eip/splitter/routes/SplitterRouteTest.java"
] | diff --git a/eip-splitter/README.md b/eip-splitter/README.md
new file mode 100644
index 000000000000..b5914750499e
--- /dev/null
+++ b/eip-splitter/README.md
@@ -0,0 +1,32 @@
+---
+layout: pattern
+title: EIP Splitter
+folder: eip-splitter
+permalink: /patterns/eip-splitter/
+categories: Enterprise integration
+tags:
+... | diff --git a/eip-splitter/src/test/java/com/iluwatar/eip/splitter/AppTest.java b/eip-splitter/src/test/java/com/iluwatar/eip/splitter/AppTest.java
new file mode 100644
index 000000000000..bff2cf0b1c62
--- /dev/null
+++ b/eip-splitter/src/test/java/com/iluwatar/eip/splitter/AppTest.java
@@ -0,0 +1,15 @@
+package com.ilu... | train | train | 2017-10-16T07:24:46 | 2015-07-27T17:25:50Z | iluwatar | train | |
iluwatar/java-design-patterns/114_663 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/114 | iluwatar/java-design-patterns/663 | [
"timestamp(timedelta=29.0, similarity=0.8599817368193922)"
] | 5ed46c2c6481c322673c6eacab918302ca1d5f13 | 6339e26838e60ba83cbc275446c6f542216a1272 | [
"Since I've completed Splitter recently I can work now on this one.",
"Ok @codinghog "
] | [] | 2017-11-04T21:45:39Z | [
"epic: pattern"
] | Aggregator (EIP) | [
"pom.xml"
] | [
"eip-aggregator/README.md",
"eip-aggregator/pom.xml",
"eip-aggregator/src/main/java/com/iluwatar/eip/aggregator/App.java",
"eip-aggregator/src/main/java/com/iluwatar/eip/aggregator/routes/AggregatorRoute.java",
"eip-aggregator/src/main/java/com/iluwatar/eip/aggregator/routes/MessageAggregationStrategy.java"... | [
"eip-aggregator/src/test/java/com/iluwatar/eip/aggregator/AppTest.java",
"eip-aggregator/src/test/java/com/iluwatar/eip/aggregator/routes/AggregatorRouteTest.java",
"eip-aggregator/src/test/java/com/iluwatar/eip/aggregator/routes/MessageAggregationStrategyTest.java"
] | diff --git a/eip-aggregator/README.md b/eip-aggregator/README.md
new file mode 100644
index 000000000000..ec8454f63cef
--- /dev/null
+++ b/eip-aggregator/README.md
@@ -0,0 +1,33 @@
+---
+layout: pattern
+title: EIP Aggregator
+folder: eip-aggregator
+permalink: /patterns/eip-aggregator/
+categories: Enterprise integrat... | diff --git a/eip-aggregator/src/test/java/com/iluwatar/eip/aggregator/AppTest.java b/eip-aggregator/src/test/java/com/iluwatar/eip/aggregator/AppTest.java
new file mode 100644
index 000000000000..5eee0986f02f
--- /dev/null
+++ b/eip-aggregator/src/test/java/com/iluwatar/eip/aggregator/AppTest.java
@@ -0,0 +1,15 @@
+pac... | train | train | 2017-10-22T21:21:54 | 2015-07-27T17:03:24Z | iluwatar | train | |
iluwatar/java-design-patterns/666_668 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/666 | iluwatar/java-design-patterns/668 | [
"keyword_pr_to_issue"
] | 390c33e36e82b558e8cab6028d96e49c0a20da9f | d26f2620ec1714193243deb3ed1dbe843c7d9b46 | [
"@Krandelbord You are correct. It is not thread safe as field is being shared without synchronization. Can you raise a PR with the fix?",
"Perhaps change to atomicInteger?!",
"If I use AtomicInteger then I have to make reading, comparing, incrementing, and setting to zero as one atomic operation.\r\nIt will end... | [] | 2017-11-19T11:06:56Z | [
"type: bug",
"info: help wanted"
] | Is it threadsafe ? | Seems like lastServedId field from LoadBlanacer.class is shared among all instances.
I think this is not threadsafe and will crash when mutiple threads will try to increment it.
https://github.com/iluwatar/java-design-patterns/blob/390c33e36e82b558e8cab6028d96e49c0a20da9f/monostate/src/main/java/com/iluwatar/monost... | [
"monostate/src/main/java/com/iluwatar/monostate/LoadBalancer.java"
] | [
"monostate/src/main/java/com/iluwatar/monostate/LoadBalancer.java"
] | [] | diff --git a/monostate/src/main/java/com/iluwatar/monostate/LoadBalancer.java b/monostate/src/main/java/com/iluwatar/monostate/LoadBalancer.java
index e440dfba22d6..b280de76702d 100644
--- a/monostate/src/main/java/com/iluwatar/monostate/LoadBalancer.java
+++ b/monostate/src/main/java/com/iluwatar/monostate/LoadBalance... | null | train | train | 2017-11-05T08:59:14 | 2017-11-11T09:16:17Z | Krandelbord | train |
iluwatar/java-design-patterns/672_682 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/672 | iluwatar/java-design-patterns/682 | [
"timestamp(timedelta=0.0, similarity=0.8457034043520804)"
] | 6c4de3bcef978bbdec4e7bbb07e6f67d412385c1 | 6b4ae0d0b1d88b344a59bd3098ddb4b79acd0786 | [
"I have no previous experience in the \"CII Best Practices Badge Program\". I see they have some [criteria](https://github.com/coreinfrastructure/best-practices-badge/blob/master/doc/criteria.md) that has to be met for a project to \"self-certify\". I briefly looked at it and it seems that we are already passing al... | [] | 2017-12-25T13:53:59Z | [
"info: help wanted",
"type: enhancement"
] | Consider adding another badge | @iluwatar as this project is open-source, I was thinking why not add https://bestpractices.coreinfrastructure.org
as a badge. It will be like cool both standardization + learning for readers.
You have to create the project there and add the badge.
Others probably also can contribute whenever you create it.
> Just... | [
"README.md"
] | [
"README.md"
] | [] | diff --git a/README.md b/README.md
index 6eed9561b551..d7f2f154c781 100644
--- a/README.md
+++ b/README.md
@@ -8,6 +8,7 @@
[](https://raw.githubusercontent.com/iluwatar/java-design-patterns/master/LICENSE.md)
[![Join the chat at https://gitter.im/iluwat... | null | test | train | 2017-12-25T10:30:24 | 2017-11-25T05:10:21Z | zafarella | train |
iluwatar/java-design-patterns/675_688 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/675 | iluwatar/java-design-patterns/688 | [
"timestamp(timedelta=79.0, similarity=0.9063894209171383)"
] | 082452947186a66d61fe1233264ace92d2722067 | e8496c5d48699e0fce579cc0b1c721240ab65fb8 | [
"Link to the diagram, please?",
"https://github.com/iluwatar/java-design-patterns/blob/master/event-asynchronous/etc/event-asynchronous.png",
"May I take this issue?",
"I am a bit confused. What should the .png look like?",
"I think the method name has changed. `ThreadCompleteListener#notifyOfThreadComplete... | [] | 2017-12-30T07:47:32Z | [
"type: bug",
"info: good first issue"
] | event-asynchronous pattern class diagram is error | The ThreadCompleteListener can't find “notifyOfThreadComplete” method | [
"event-asynchronous/etc/event-asynchronous.ucls"
] | [
"event-asynchronous/etc/event-asynchronous.ucls"
] | [] | diff --git a/event-asynchronous/etc/event-asynchronous.ucls b/event-asynchronous/etc/event-asynchronous.ucls
index df09fc28d955..1327b7104459 100644
--- a/event-asynchronous/etc/event-asynchronous.ucls
+++ b/event-asynchronous/etc/event-asynchronous.ucls
@@ -1,63 +1,62 @@
<?xml version="1.0" encoding="UTF-8"?>
-<class... | null | train | train | 2017-12-30T08:53:28 | 2017-11-27T06:45:44Z | harley-byte | train |
iluwatar/java-design-patterns/681_693 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/681 | iluwatar/java-design-patterns/693 | [
"keyword_pr_to_issue"
] | dea2316f1fb535a7e1038158d54f58939fdd4040 | 09c0891948c221924a9280c19116c4c18611cb71 | [
"@iluwatar if no one help on this I would like to fix this one",
"Ok @jujis008 "
] | [] | 2018-01-02T10:31:52Z | [
"type: bug",
"info: good first issue"
] | AbstractDocument: price or partner? | On the diagram of `AbstractDocument`, `HasPrice.getPartner()` should be `HasPrice.getPrice()`. | [
"abstract-document/README.md",
"abstract-document/etc/abstract-document-base.ucls",
"abstract-document/etc/abstract-document.ucls"
] | [
"abstract-document/README.md",
"abstract-document/etc/abstract-document.ucls"
] | [] | diff --git a/abstract-document/README.md b/abstract-document/README.md
index bf28ff999bf5..2adb3732b822 100644
--- a/abstract-document/README.md
+++ b/abstract-document/README.md
@@ -12,8 +12,6 @@ tags:
## Intent
Achieve flexibility of untyped languages and keep the type-safety
-"
] | f87754917c5c5b8cf079c35de0aa98db039a7a28 | 288f1e8c7e02032dba10525e8f48ae9df1ec9a3e | [
"@iluwatar I'll take this if no one else has",
"@james-a-roland there is a pull request about this, see https://github.com/iluwatar/java-design-patterns/pull/695. But I have a feeling it does not solve all redundant calls to `super()`. Either work with @jonatasemidio by reviewing the PR or create your own PR that... | [] | 2018-01-05T10:40:46Z | [
"type: enhancement",
"info: good first issue"
] | Remove redundant explicit super() constructor calls | The super() calls (taking no arguments) are inserted during compile time, so just make the code more verbose than required.
One example is found in the [HeroStat ](https://github.com/iluwatar/java-design-patterns/blob/master/value-object/src/main/java/com/iluwatar/value/object/HeroStat.java#L40) class. | [
"value-object/src/main/java/com/iluwatar/value/object/HeroStat.java"
] | [
"value-object/src/main/java/com/iluwatar/value/object/HeroStat.java"
] | [] | diff --git a/value-object/src/main/java/com/iluwatar/value/object/HeroStat.java b/value-object/src/main/java/com/iluwatar/value/object/HeroStat.java
index ff85e0e934dc..0274bc47f394 100644
--- a/value-object/src/main/java/com/iluwatar/value/object/HeroStat.java
+++ b/value-object/src/main/java/com/iluwatar/value/object... | null | train | train | 2018-01-02T18:29:14 | 2018-01-05T02:23:51Z | dylanwatsonsoftware | train |
iluwatar/java-design-patterns/677_696 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/677 | iluwatar/java-design-patterns/696 | [
"timestamp(timedelta=82.0, similarity=0.8878464269645263)"
] | 09c0891948c221924a9280c19116c4c18611cb71 | 7fef5e4cd5862338557c1d90fdc6de445ebe631e | [
"Can you please provide links to the pattern?",
"Shure.\r\nWiki - https://en.wikipedia.org/wiki/Trampoline_(computing) (high-level programming)\r\ngood example - https://medium.com/@johnmcclean/trampolining-a-practical-guide-for-awesome-java-developers-4b657d9c3076\r\nstackoverflow - https://stackoverflow.com/que... | [
"Would it be possible to explain the pattern shortly in `Explanation` section? See https://github.com/iluwatar/java-design-patterns/wiki/02.-Pattern-template and some other patterns like http://java-design-patterns.com/patterns/decorator/ for examples.",
"Use `Tutorials` section for examples. Pattern descriptions... | 2018-01-08T11:48:52Z | [
"epic: pattern"
] | Pattern : trampoline. Is it needed? | Hi!
I have not found a pattern Trampoline in the list.
I want to discuss adding this pattern to list.
Will be it right?
I can do it if it is possible. | [
"pom.xml"
] | [
"pom.xml",
"trampoline/.gitignore",
"trampoline/README.md",
"trampoline/pom.xml",
"trampoline/src/main/java/com/iluwatar/trampoline/Trampoline.java",
"trampoline/src/main/java/com/iluwatar/trampoline/TrampolineApp.java"
] | [
"trampoline/src/test/java/com/iluwatar/trampoline/TrampolineAppTest.java"
] | diff --git a/pom.xml b/pom.xml
index 66c5fa850c83..7e669d39669c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -147,13 +147,13 @@
<module>event-sourcing</module>
<module>data-transfer-object</module>
<module>throttling</module>
-
<module>unit-of-work</module>
<module>partial-response... | diff --git a/trampoline/src/test/java/com/iluwatar/trampoline/TrampolineAppTest.java b/trampoline/src/test/java/com/iluwatar/trampoline/TrampolineAppTest.java
new file mode 100644
index 000000000000..553e583e12e9
--- /dev/null
+++ b/trampoline/src/test/java/com/iluwatar/trampoline/TrampolineAppTest.java
@@ -0,0 +1,22 @... | train | train | 2018-01-08T06:55:39 | 2017-12-11T09:29:04Z | besok | train |
iluwatar/java-design-patterns/560_717 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/560 | iluwatar/java-design-patterns/717 | [
"timestamp(timedelta=974.0, similarity=0.934879032923891)"
] | 4ac6f90c96b6d34778c564fae501b4038f106979 | eddfe76a8487d687f7f74d8f7b50a6c005b7f112 | [
"I am working on this.",
"Ok @abhi-agr ",
"@abhi-agr I implemented something similar in my scene graph code without knowing this pattern. If you need collaborator in this pattern please let me know. ",
"@abhi-agr are you still implementing this?",
"Sorry I am not working on this, I got busy with my work. "... | [
"I am not sure if DataFetcher should be returning `null` to indicate no change in data. Any other options for this?",
"Suggestion: Just document a warning that this is not a thread safe way to implement Singleton. Refer to Singleton for more information.",
"Question: I don't understand the intent to keep `World... | 2018-02-19T16:10:42Z | [
"epic: pattern"
] | Dirty Flag pattern | http://gameprogrammingpatterns.com/dirty-flag.html | [
"pom.xml"
] | [
"dirty-flag/README.md",
"dirty-flag/etc/dirty-flag.ucls",
"dirty-flag/pom.xml",
"dirty-flag/src/main/java/com/iluwatar/dirtyflag/App.java",
"dirty-flag/src/main/java/com/iluwatar/dirtyflag/DataFetcher.java",
"dirty-flag/src/main/java/com/iluwatar/dirtyflag/World.java",
"dirty-flag/src/main/resources/wor... | [
"dirty-flag/src/test/java/org/dirty/flag/AppTest.java",
"dirty-flag/src/test/java/org/dirty/flag/DirtyFlagTest.java"
] | diff --git a/dirty-flag/README.md b/dirty-flag/README.md
new file mode 100644
index 000000000000..36c92f0e28b8
--- /dev/null
+++ b/dirty-flag/README.md
@@ -0,0 +1,26 @@
+---
+layout: pattern
+title: Dirty Flag
+folder: dirty-flag
+permalink: /patterns/dirty-flag/
+categories: Other
+tags:
+ - Java
+ - Difficulty-Easy
+... | diff --git a/dirty-flag/src/test/java/org/dirty/flag/AppTest.java b/dirty-flag/src/test/java/org/dirty/flag/AppTest.java
new file mode 100644
index 000000000000..50f107cd58c0
--- /dev/null
+++ b/dirty-flag/src/test/java/org/dirty/flag/AppTest.java
@@ -0,0 +1,40 @@
+/**
+ * The MIT License
+ * Copyright (c) 2014-2016 Il... | val | train | 2018-04-29T09:39:51 | 2017-04-01T08:57:10Z | iluwatar | train |
iluwatar/java-design-patterns/725_726 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/725 | iluwatar/java-design-patterns/726 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.9169838390585222)"
] | c723289bbb7ea841fa15b73006fedbe413691035 | 68799908578ec471239d45460d4aa0af4684ec67 | [
"Hi,\r\n Did they provide you with the new URL pattern? It looks like that even in the SonarSource repo they are still using the old URL (search for quality gate):\r\n\r\n https://raw.githubusercontent.com/SonarSource/sonar-java/master/README.md",
"The new URL's are provided on the sonarcloud.io project pa... | [] | 2018-03-14T17:22:45Z | [
"info: help wanted",
"epic: web site",
"info: good first issue"
] | SonarCloud badge URL changing | Hi,
About a month ago, we deployed new built-in badges on SonarCloud:
News: https://about.sonarcloud.io/news/2018/02/05/new-project-badges.html
Tweet: https://twitter.com/sonarcloud/status/960790516936867840
As explained in the news, the URL for those new badges is different from the old one - which we will remo... | [
"README.md"
] | [
"README.md"
] | [] | diff --git a/README.md b/README.md
index 03aea2bf64e0..4ec0f33bd350 100644
--- a/README.md
+++ b/README.md
@@ -7,7 +7,7 @@
[](https://travis-ci.org/iluwatar/java-design-patterns)
["
] | c7f9266768e566a532280d51b67dc070394233d6 | d915b66e70bf8ba7ad07daf8fcc3d9972b8cf435 | [
"@npathai According to me this pattern is just extended use of proxy pattern. Here at edge service, we are putting our logic for the proxy which hides actual Application and also provides us extendibility to put our circuit breaking and other logic in that.\r\nEg. Hibernate Transaction management uses proxy pattern... | [
"Isn't networking just one example of Ambassador usages? Could the description be more general?",
"This can be written on one line `private RemoteService() {}`. Please check whitespace usage elsewhere too.",
"Use logger for output. Check this elsewhere too.",
"Could be `private final ServiceAmbassador service... | 2018-06-04T21:52:31Z | [
"info: help wanted"
] | Ambassador Pattern | https://docs.microsoft.com/en-us/azure/architecture/patterns/ambassador | [
"pom.xml"
] | [
"ambassador/README.md",
"ambassador/pom.xml",
"ambassador/src/main/java/com/iluwatar/ambassador/App.java",
"ambassador/src/main/java/com/iluwatar/ambassador/Client.java",
"ambassador/src/main/java/com/iluwatar/ambassador/RemoteService.java",
"ambassador/src/main/java/com/iluwatar/ambassador/RemoteServiceI... | [
"ambassador/src/test/java/com/iluwatar/ambassador/AppTest.java",
"ambassador/src/test/java/com/iluwatar/ambassador/ClientTest.java",
"ambassador/src/test/java/com/iluwatar/ambassador/RemoteServiceTest.java",
"ambassador/src/test/java/com/iluwatar/ambassador/ServiceAmbassadorTest.java"
] | diff --git a/ambassador/README.md b/ambassador/README.md
new file mode 100644
index 000000000000..f23d1e13cedb
--- /dev/null
+++ b/ambassador/README.md
@@ -0,0 +1,178 @@
+---
+layout: pattern
+title: Ambassador
+folder: ambassador
+permalink: /patterns/ambassador/
+categories: Structural
+tags:
+ - Java
+ - Difficulty-... | diff --git a/ambassador/src/test/java/com/iluwatar/ambassador/AppTest.java b/ambassador/src/test/java/com/iluwatar/ambassador/AppTest.java
new file mode 100644
index 000000000000..cb072c1eb406
--- /dev/null
+++ b/ambassador/src/test/java/com/iluwatar/ambassador/AppTest.java
@@ -0,0 +1,36 @@
+/**
+ * The MIT License
+ *... | train | train | 2018-06-28T10:25:32 | 2018-02-26T11:52:14Z | npathai | train |
iluwatar/java-design-patterns/784_787 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/784 | iluwatar/java-design-patterns/787 | [
"timestamp(timedelta=53.0, similarity=0.9241091745913026)",
"keyword_issue_to_pr"
] | 16df157181990e8d384f7dfcdc1bac424928d273 | b64262303aa1980ac64ead4bc2e8b7fd7bf1a834 | [
"PR #787 has been merged. Closing this issue now."
] | [] | 2018-08-21T02:38:22Z | [] | Minor Checkstyle issues | com.iluwatar.acyclicvisitor.ZoomVisitor.java and com.iluwatar.retry.Retry.java have Checkstyle warnings. | [
"acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ZoomVisitor.java",
"retry/src/main/java/com/iluwatar/retry/Retry.java"
] | [
"acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ZoomVisitor.java",
"retry/src/main/java/com/iluwatar/retry/Retry.java"
] | [] | diff --git a/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ZoomVisitor.java b/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ZoomVisitor.java
index b4c949ed7b71..6a47867fc81b 100644
--- a/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ZoomVisitor.java
+++ b/acyclic-visitor/src/main/jav... | null | val | train | 2018-08-13T07:13:06 | 2018-08-20T03:54:17Z | bordoisila1 | train |
iluwatar/java-design-patterns/781_794 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/781 | iluwatar/java-design-patterns/794 | [
"keyword_pr_to_issue"
] | 9e56e5cbc1c86980fe61d04bd1e247461611dc99 | b079aec1fdf6e72ffccb4373083b90ce16f562ff | [
"@iluwatar That is not a bug, it is expected to happen. I will change the log level and use `instanceof` instead to resolve the confusion.",
"Well done @npathai Thank you!"
] | [] | 2018-09-11T10:32:38Z | [
"type: bug"
] | ClassCastException was throwed in App.java#52 | The row that has an exception was:
hayes.accept(conUnix); // Hayes modem with Unix configurator
Because of ConfigureForUnixVisitor didn't implements HayesVisitor.
#java-design-patterns/acyclic-visitor | [
"acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/AllModemVisitor.java",
"acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ConfigureForUnixVisitor.java",
"acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/Hayes.java",
"acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/Zoom.ja... | [
"acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/AllModemVisitor.java",
"acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/ConfigureForUnixVisitor.java",
"acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/Hayes.java",
"acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/Zoom.ja... | [] | diff --git a/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/AllModemVisitor.java b/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/AllModemVisitor.java
index e6f5834462d1..749ea00a25fb 100644
--- a/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/AllModemVisitor.java
+++ b/acyclic-visitor/... | null | val | train | 2018-09-08T20:54:42 | 2018-08-10T02:55:01Z | yushouling | train |
iluwatar/java-design-patterns/795_796 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/795 | iluwatar/java-design-patterns/796 | [
"keyword_pr_to_issue"
] | 9e56e5cbc1c86980fe61d04bd1e247461611dc99 | 3cec7a9ec1c5c196969153d802d264f891a5761b | [
"@LyndonArmitage thanks for the improvement suggestion. I think those files could be removed from git and added to `.gitignore`. I would be glad to accept pull request for this.",
"See PR: #796"
] | [] | 2018-09-24T09:14:38Z | [
"info: help wanted",
"info: good first issue"
] | module/output.txt & module/error.txt change on build | First off great project here, thanks for spending time collating all this information! :+1:
Something very minor I noticed when building the project locally with `mvn clean package` is that the files:
`module/output.txt` and `module/error.txt` end up being change to not include the MIT licence.
Perhaps they s... | [
"module/error.txt",
"module/output.txt"
] | [
"module/.gitignore"
] | [] | diff --git a/module/.gitignore b/module/.gitignore
new file mode 100644
index 000000000000..ecfa5dd4617e
--- /dev/null
+++ b/module/.gitignore
@@ -0,0 +1,2 @@
+error.txt
+output.txt
diff --git a/module/error.txt b/module/error.txt
deleted file mode 100644
index ee28c3c1cf7e..000000000000
--- a/module/error.txt
+++ /dev... | null | train | train | 2018-09-08T20:54:42 | 2018-09-19T08:24:24Z | LyndonArmitage | train |
iluwatar/java-design-patterns/699_802 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/699 | iluwatar/java-design-patterns/802 | [
"keyword_pr_to_issue"
] | db33cc533bc1032cb36280653f53a18eb558e48b | f5eaf06c1c6b5f6e33a4315c1421def54c1dcae6 | [
"Ping @Rzeposlaw, care to investigate?",
"Why this is messy when I open the Travis log?",
"@iluwatar I would like to work on it :)",
"Ok @sharmin03 ",
"Flaky test disabled in https://github.com/iluwatar/java-design-patterns/commit/17ea0b17f68e6d20917dfd2937db28de83d9bf27. Still needs to be fixed."
] | [] | 2018-10-15T11:09:17Z | [
"type: bug",
"epic: build issue"
] | Intermittent failure in Balking pattern | See Travis log https://api.travis-ci.org/v3/job/329176022/log.txt | [
"balking/src/main/java/com/iluwatar/balking/WashingMachine.java"
] | [
"balking/src/main/java/com/iluwatar/balking/DelayProvider.java",
"balking/src/main/java/com/iluwatar/balking/WashingMachine.java"
] | [
"balking/src/test/java/com/iluwatar/balking/WashingMachineTest.java"
] | diff --git a/balking/src/main/java/com/iluwatar/balking/DelayProvider.java b/balking/src/main/java/com/iluwatar/balking/DelayProvider.java
new file mode 100644
index 000000000000..26b4f8936127
--- /dev/null
+++ b/balking/src/main/java/com/iluwatar/balking/DelayProvider.java
@@ -0,0 +1,10 @@
+package com.iluwatar.balkin... | diff --git a/balking/src/test/java/com/iluwatar/balking/WashingMachineTest.java b/balking/src/test/java/com/iluwatar/balking/WashingMachineTest.java
index 9a13b8b2dcf4..100bf61a6341 100644
--- a/balking/src/test/java/com/iluwatar/balking/WashingMachineTest.java
+++ b/balking/src/test/java/com/iluwatar/balking/WashingMa... | train | train | 2018-10-13T17:40:10 | 2018-01-16T19:21:59Z | iluwatar | train |
iluwatar/java-design-patterns/562_828 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/562 | iluwatar/java-design-patterns/828 | [
"timestamp(timedelta=75.0, similarity=0.9301966998609539)"
] | 53b673d5b00192fd339e2db7e2fb55a554311a57 | a6749cb63e97cab38f7751ce2d164dfa9b4beb3b | [
"hi @iluwatar \r\nI'm willing to implement this pattern.",
"Ok @szoeke ",
"@szoeke This is pretty interesting pattern, please let me know if you need help in implementing/discussing this pattern.",
"This issue is free for taking again",
"@iluwatar I'll take a stab at this",
"Ok @danielsiwiec ",
"@daniel... | [] | 2018-11-27T01:39:25Z | [
"epic: pattern"
] | Spatial Partition pattern | http://gameprogrammingpatterns.com/spatial-partition.html | [
"pom.xml"
] | [
"pom.xml",
"spatial-partition/README.md",
"spatial-partition/pom.xml",
"spatial-partition/src/main/java/com/iluwatar/spatialpartition/App.java",
"spatial-partition/src/main/java/com/iluwatar/spatialpartition/Bubble.java",
"spatial-partition/src/main/java/com/iluwatar/spatialpartition/Point.java",
"spati... | [
"spatial-partition/src/test/java/com/iluwatar/spatialpartition/BubbleTest.java",
"spatial-partition/src/test/java/com/iluwatar/spatialpartition/QuadTreeTest.java",
"spatial-partition/src/test/java/com/iluwatar/spatialpartition/RectTest.java",
"spatial-partition/src/test/java/com/iluwatar/spatialpartition/Spat... | diff --git a/pom.xml b/pom.xml
index 84cf41535a7a..d5aba817058c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -164,6 +164,7 @@
<module>ambassador</module>
<module>acyclic-visitor</module>
<module>collection-pipeline</module>
+ <module>spatial-partition</module>
</modules>
<repositories>
diff --git a/sp... | diff --git a/spatial-partition/src/test/java/com/iluwatar/spatialpartition/BubbleTest.java b/spatial-partition/src/test/java/com/iluwatar/spatialpartition/BubbleTest.java
new file mode 100644
index 000000000000..ab6b6078fbf0
--- /dev/null
+++ b/spatial-partition/src/test/java/com/iluwatar/spatialpartition/BubbleTest.ja... | val | train | 2018-11-25T18:35:22 | 2017-04-01T08:58:10Z | iluwatar | train |
iluwatar/java-design-patterns/775_829 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/775 | iluwatar/java-design-patterns/829 | [
"timestamp(timedelta=64.0, similarity=0.8490796066626536)"
] | 53b673d5b00192fd339e2db7e2fb55a554311a57 | 10cb191533e4b1c48f8827f481cde4b563ae00d2 | [
"Yes, I agree. Go ahead @awesomefei ",
"Hi, is this done?",
"Created pull request #797 in case it's still needed. I am new to open source, would really appreciate any feedback. I used this source to do it: https://cloud.google.com/storage/docs/exponential-backoff\r\nUpdated: #829 "
] | [] | 2018-12-01T12:24:36Z | [
"type: enhancement"
] | Implement Retry pattern with exponential backoff | In practice, we often retry with exponential backoff to avoid making traffic congestion/server load worse, would be nice to implement this option.
Also, I would like to implement this. | [
"retry/src/main/java/com/iluwatar/retry/App.java"
] | [
"retry/src/main/java/com/iluwatar/retry/App.java",
"retry/src/main/java/com/iluwatar/retry/RetryExponentialBackoff.java"
] | [
"retry/src/test/java/com/iluwatar/retry/RetryExponentialBackoffTest.java"
] | diff --git a/retry/src/main/java/com/iluwatar/retry/App.java b/retry/src/main/java/com/iluwatar/retry/App.java
index 376a64fbff97..20205bdf3973 100644
--- a/retry/src/main/java/com/iluwatar/retry/App.java
+++ b/retry/src/main/java/com/iluwatar/retry/App.java
@@ -71,6 +71,7 @@ public static void main(String[] args) thro... | diff --git a/retry/src/test/java/com/iluwatar/retry/RetryExponentialBackoffTest.java b/retry/src/test/java/com/iluwatar/retry/RetryExponentialBackoffTest.java
new file mode 100644
index 000000000000..d14b1eef68a6
--- /dev/null
+++ b/retry/src/test/java/com/iluwatar/retry/RetryExponentialBackoffTest.java
@@ -0,0 +1,115 ... | train | train | 2018-11-25T18:35:22 | 2018-07-18T18:40:23Z | awesomefei | train |
iluwatar/java-design-patterns/555_848 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/555 | iluwatar/java-design-patterns/848 | [
"timestamp(timedelta=80.0, similarity=0.8931129968109979)"
] | 55c75799831716b6248ceefa1315881e7f90806b | 0c6237c225584a3a28bdd81cb19a40de698ed7f7 | [
"Hello @iluwatar I would like to take this pattern. Thanks!",
"Ok @Imp92 ",
"This issue is free for taking again",
"Hey, @iluwatar I would like to take this pattern. Thanks.",
"@laubera ok",
"@laubera are you still implementing this?",
"PR #848 "
] | [
"does `start` and `end` both needs to current milliseconds?",
"same here. `start` and `end` are essentially the same.",
"It's needed so that we can enter into while loop"
] | 2019-02-09T07:20:53Z | [
"epic: pattern"
] | Type Object pattern | http://gameprogrammingpatterns.com/type-object.html | [
"pom.xml"
] | [
"pom.xml",
"typeobjectpattern/README.md",
"typeobjectpattern/pom.xml",
"typeobjectpattern/src/main/java/com/iluwatar/typeobject/App.java",
"typeobjectpattern/src/main/java/com/iluwatar/typeobject/Candy.java",
"typeobjectpattern/src/main/java/com/iluwatar/typeobject/CandyGame.java",
"typeobjectpattern/sr... | [
"typeobjectpattern/src/test/java/com/iluwatar/typeobject/CandyGameTest.java",
"typeobjectpattern/src/test/java/com/iluwatar/typeobject/CellPoolTest.java",
"typeobjectpattern/src/test/java/com/iluwatar/typeobject/CellTest.java"
] | diff --git a/pom.xml b/pom.xml
index d5aba817058c..990a5a325cff 100644
--- a/pom.xml
+++ b/pom.xml
@@ -165,6 +165,7 @@
<module>acyclic-visitor</module>
<module>collection-pipeline</module>
<module>spatial-partition</module>
+ <module>typeobjectpattern</module>
</modules>
<repositories>
diff --git a/ty... | diff --git a/typeobjectpattern/src/test/java/com/iluwatar/typeobject/CandyGameTest.java b/typeobjectpattern/src/test/java/com/iluwatar/typeobject/CandyGameTest.java
new file mode 100644
index 000000000000..d1b2fd359385
--- /dev/null
+++ b/typeobjectpattern/src/test/java/com/iluwatar/typeobject/CandyGameTest.java
@@ -0,... | train | train | 2019-02-04T07:35:06 | 2017-04-01T08:54:36Z | iluwatar | train |
iluwatar/java-design-patterns/846_853 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/846 | iluwatar/java-design-patterns/853 | [
"keyword_pr_to_issue"
] | 26f1a608ab76178694468c7ce05037e5a1837e6c | 5251ec4a932d8739f201fe19efed2899c429033d | [
"It might be best just to put a comment saying so if needed. It doesn't really matter if it's there or not. It actually might be clearer to have it.\r\n[Java Reference on Enums](https://docs.oracle.com/javase/specs/jls/se7/html/jls-8.html#jls-8.9)",
"Well spotted @lprone. I will gladly accept a pull request that ... | [] | 2019-02-13T21:47:58Z | [
"info: help wanted",
"info: good first issue"
] | static enum | https://github.com/iluwatar/java-design-patterns/blob/55c75799831716b6248ceefa1315881e7f90806b/facade/src/main/java/com/iluwatar/facade/DwarvenMineWorker.java#L89
Enums don't need to be defined as a static. Can change it to :
`
enum Action {
` | [
"facade/src/main/java/com/iluwatar/facade/DwarvenMineWorker.java"
] | [
"facade/src/main/java/com/iluwatar/facade/DwarvenMineWorker.java"
] | [] | diff --git a/facade/src/main/java/com/iluwatar/facade/DwarvenMineWorker.java b/facade/src/main/java/com/iluwatar/facade/DwarvenMineWorker.java
index bb80ae87409d..b313dd9890d9 100644
--- a/facade/src/main/java/com/iluwatar/facade/DwarvenMineWorker.java
+++ b/facade/src/main/java/com/iluwatar/facade/DwarvenMineWorker.ja... | null | test | train | 2019-02-13T22:14:53 | 2019-02-07T01:22:23Z | lprone | train |
iluwatar/java-design-patterns/508_854 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/508 | iluwatar/java-design-patterns/854 | [
"timestamp(timedelta=107.0, similarity=0.8485832572968025)"
] | 26f1a608ab76178694468c7ce05037e5a1837e6c | f7e22a1cf6f7664e8790cc5c76285adbcc6ab19d | [
"I will take care of this.\n",
"Thank you @sangupta you're good to go!\n",
"@sangupta are you still working on this?",
"@iluwatar Am sorry - have been pressed for time lately. Will have sometime in March - when I should be able to lend a helping hand.\r\n",
"@iluwatar I can pick this if no one else is looki... | [] | 2019-02-15T08:17:59Z | [
"type: bug",
"info: good first issue"
] | SonarQube reports code smells | Java Design Patterns is analyzed with SonarQube.com static analysis. The analysis shows some blocker level code smells that should be fixed:
https://sonarqube.com/component_issues/index?id=com.iluwatar%3Ajava-design-patterns#resolved=false|severities=BLOCKER|types=CODE_SMELL
| [
"event-asynchronous/src/main/java/com/iluwatar/event/asynchronous/App.java",
"event-asynchronous/src/main/java/com/iluwatar/event/asynchronous/EventManager.java",
"event-sourcing/src/main/java/com/iluwatar/event/sourcing/domain/Account.java"
] | [
"event-asynchronous/src/main/java/com/iluwatar/event/asynchronous/App.java",
"event-asynchronous/src/main/java/com/iluwatar/event/asynchronous/EventManager.java",
"event-sourcing/src/main/java/com/iluwatar/event/sourcing/domain/Account.java"
] | [] | diff --git a/event-asynchronous/src/main/java/com/iluwatar/event/asynchronous/App.java b/event-asynchronous/src/main/java/com/iluwatar/event/asynchronous/App.java
index 6e9138d3c518..820279bc058a 100644
--- a/event-asynchronous/src/main/java/com/iluwatar/event/asynchronous/App.java
+++ b/event-asynchronous/src/main/jav... | null | val | train | 2019-02-13T22:14:53 | 2016-10-20T14:17:59Z | iluwatar | train |
iluwatar/java-design-patterns/845_856 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/845 | iluwatar/java-design-patterns/856 | [
"timestamp(timedelta=33.0, similarity=0.8746586039099573)"
] | eafe52e17a2e985f269477a633608a64851abcc0 | b6b4602baf5a12d8b76b3f8dd0284bae44230aa9 | [
"I don't really think this is an issue at all. This is a code style suggestion, and in my opinion, both are equally clear.",
"Yes, just create a pull request and we can improve the style.",
"Hi @iluwatar \r\nI can take this up",
"Ok @kanwarpreet25 "
] | [] | 2019-02-15T18:46:41Z | [
"info: good first issue"
] | Unnecesary return | https://github.com/iluwatar/java-design-patterns/blob/55c75799831716b6248ceefa1315881e7f90806b/spatial-partition/src/main/java/com/iluwatar/spatialpartition/QuadTree.java#L58
you can change this block
`
if (!this.boundary.contains(p)) {
return;
} else {
`
to this other most clear:
`
if (t... | [
"spatial-partition/src/main/java/com/iluwatar/spatialpartition/QuadTree.java"
] | [
"spatial-partition/src/main/java/com/iluwatar/spatialpartition/QuadTree.java"
] | [] | diff --git a/spatial-partition/src/main/java/com/iluwatar/spatialpartition/QuadTree.java b/spatial-partition/src/main/java/com/iluwatar/spatialpartition/QuadTree.java
index 072468ce80d4..815bf8acc74c 100644
--- a/spatial-partition/src/main/java/com/iluwatar/spatialpartition/QuadTree.java
+++ b/spatial-partition/src/mai... | null | train | train | 2019-02-15T19:00:21 | 2019-02-07T01:14:46Z | lprone | train |
iluwatar/java-design-patterns/868_872 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/868 | iluwatar/java-design-patterns/872 | [
"keyword_pr_to_issue"
] | fedc2d9e47cb2b44aa4ea23aed9d117bbd4ed069 | aaabc8f517461593d206a009858cefd163e43daa | [
"Code snippet of **_<org.apache.commons.logging.LogFactory: org.apache.commons.logging.LogFactory getFactory()>_** in _**org.slf4j:jcl-over-slf4j:jar:1.7.16:compile**_ (loaded version):\r\n\r\n\r\nCode snippet... | [] | 2019-04-15T10:13:10Z | [
"epic: build issue"
] | Dependency Conflict: duplicate classes "org.apache.commons.logging.LogFactory" in different JARs, have different implementations | Hi, in **java-design-patterns-1.20.0** (**api-gateway\api-gateway-service** module), duplicate classes with the same fully-qualified name _**org.apache.commons.logging.LogFactory**_ are included in two different libraries, i.e., **org.slf4j:jcl-over-slf4j:1.7.16** and **commons-logging:commons-logging:1.2**.
Accordi... | [
"api-gateway/api-gateway-service/pom.xml"
] | [
"api-gateway/api-gateway-service/pom.xml"
] | [] | diff --git a/api-gateway/api-gateway-service/pom.xml b/api-gateway/api-gateway-service/pom.xml
index f947049a757c..13bbddc97d09 100644
--- a/api-gateway/api-gateway-service/pom.xml
+++ b/api-gateway/api-gateway-service/pom.xml
@@ -48,6 +48,10 @@
<groupId>org.springframework</groupId>
<artifactId>spring-we... | null | train | train | 2019-04-07T07:41:35 | 2019-04-07T12:39:23Z | HelloCoCooo | train |
iluwatar/java-design-patterns/875_877 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/875 | iluwatar/java-design-patterns/877 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.9158216094727133)"
] | fedc2d9e47cb2b44aa4ea23aed9d117bbd4ed069 | b497d41f61b43e188f43fa0f3f70b3a2e164bb76 | [] | [] | 2019-05-02T17:28:40Z | [
"info: help wanted",
"type: enhancement",
"epic: web site",
"info: good first issue"
] | Wrong UML in observer | The UML diagram presented in the Observer pattern description is wrong.
The multiplicity between Weather and WeatherType is stated to be 0..1, but that is not the case in the code, since you can't create a Weather object without associating it with a WeatherType (the costructor sets the type to "sunny", timepasses(... | [
"observer/README.md",
"observer/etc/observer.ucls"
] | [
"observer/README.md",
"observer/etc/observer.ucls"
] | [] | diff --git a/observer/README.md b/observer/README.md
index 38a28032f957..afeb0b37d68d 100644
--- a/observer/README.md
+++ b/observer/README.md
@@ -19,7 +19,7 @@ Define a one-to-many dependency between objects so that when one
object changes state, all its dependents are notified and updated
automatically.
-![alt te... | null | val | train | 2019-04-07T07:41:35 | 2019-04-24T18:27:16Z | andreazube | train |
iluwatar/java-design-patterns/883_885 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/883 | iluwatar/java-design-patterns/885 | [
"keyword_pr_to_issue"
] | fedc2d9e47cb2b44aa4ea23aed9d117bbd4ed069 | ccb257d5250f15061499dbb63aeba1057bafc963 | [
"@iluwatar Can i take this. Thanks",
"Ok @ranjeet-floyd ",
"Is this fixed already?",
"Is this issue already resloved?"
] | [] | 2019-06-11T17:23:28Z | [
"info: help wanted",
"type: enhancement",
"info: good first issue"
] | Dirty Flag pattern Issue | https://github.com/iluwatar/java-design-patterns/blob/fedc2d9e47cb2b44aa4ea23aed9d117bbd4ed069/dirty-flag/src/main/java/com/iluwatar/dirtyflag/App.java#L60
Creating object of World class inside Thread's Run method doesn't make sense, as every time it is creating new object and reading the file. It should be outside ... | [
"dirty-flag/src/main/java/com/iluwatar/dirtyflag/App.java"
] | [
"dirty-flag/src/main/java/com/iluwatar/dirtyflag/App.java"
] | [] | diff --git a/dirty-flag/src/main/java/com/iluwatar/dirtyflag/App.java b/dirty-flag/src/main/java/com/iluwatar/dirtyflag/App.java
index 4d72b34da249..827028d09a06 100644
--- a/dirty-flag/src/main/java/com/iluwatar/dirtyflag/App.java
+++ b/dirty-flag/src/main/java/com/iluwatar/dirtyflag/App.java
@@ -55,9 +55,9 @@ public ... | null | train | train | 2019-04-07T07:41:35 | 2019-06-05T19:52:23Z | sajankumarma | train |
iluwatar/java-design-patterns/449_888 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/449 | iluwatar/java-design-patterns/888 | [
"timestamp(timedelta=57.0, similarity=0.9070039905061017)"
] | 11c055055934d1a78e1b98072ea5dd2c4b96da3c | 7f6067f19fe03c41cc25f704dbdab93b5069f0cb | [
"Hi @iluwatar @npathai , I would like to contribute on this issue. \n",
"@harshSE go ahead, it's all yours :)\n",
"Good to see you @harshSE. Looking forward to your long term contribution 😊\n",
"@harshSE are you still working on this?",
"This issue is free for taking again",
"Hi @iluwatar @npathai , I wo... | [
"Make these final",
"Why is maven-compiler-plugin needed here?",
"Explain here more verbosely how the example works and implements the pattern",
"Ok",
"I will check. Thanks",
"i will add better comment. Thanks",
"Removed",
"Added better message",
"Done"
] | 2019-06-15T13:10:02Z | [
"epic: pattern"
] | Priority Queue pattern | https://msdn.microsoft.com/en-us/library/dn589794.aspx
| [
"pom.xml"
] | [
"pom.xml",
"priority-queue/README.md",
"priority-queue/pom.xml",
"priority-queue/src/main/java/com/iluwatar/priority/queue/Application.java",
"priority-queue/src/main/java/com/iluwatar/priority/queue/Message.java",
"priority-queue/src/main/java/com/iluwatar/priority/queue/PriorityMessageQueue.java",
"pr... | [
"priority-queue/src/test/java/com/iluwatar/priority/queue/PriorityMessageQueueTest.java",
"priority-queue/src/test/java/com/iluwatar/priority/queue/QueueManagerTest.java"
] | diff --git a/pom.xml b/pom.xml
index fef21534fa71..f305e97d983e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -17,7 +17,9 @@
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE SOFTWARE.
---><project xmlns="ht... | diff --git a/priority-queue/src/test/java/com/iluwatar/priority/queue/PriorityMessageQueueTest.java b/priority-queue/src/test/java/com/iluwatar/priority/queue/PriorityMessageQueueTest.java
new file mode 100644
index 000000000000..6dc26fcf67e2
--- /dev/null
+++ b/priority-queue/src/test/java/com/iluwatar/priority/queue/... | val | train | 2019-08-21T20:51:27 | 2016-07-02T17:07:38Z | iluwatar | train |
iluwatar/java-design-patterns/553_896 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/553 | iluwatar/java-design-patterns/896 | [
"timestamp(timedelta=116.0, similarity=0.9137941367497018)"
] | 7f6067f19fe03c41cc25f704dbdab93b5069f0cb | 318f811fead95c4a363d776e968b0b1a4a112c86 | [
"Hey @iluwatar, I would love to work on this if no one else has claimed it yet.",
"Ok @abhishek7 ",
"@abhishek7 are you still implementing this?",
"@iluwatar apologies for the delay, did not have a chance to make additional progress on it. Feel free to give it to someone else. If I do have time, I'll open up... | [] | 2019-07-07T18:27:39Z | [
"epic: pattern"
] | Bytecode pattern | http://gameprogrammingpatterns.com/bytecode.html | [
"pom.xml"
] | [
"bytecode/README.md",
"bytecode/etc/bytecode.ucls",
"bytecode/pom.xml",
"bytecode/src/main/java/com/iluwatar/bytecode/App.java",
"bytecode/src/main/java/com/iluwatar/bytecode/Instruction.java",
"bytecode/src/main/java/com/iluwatar/bytecode/VirtualMachine.java",
"bytecode/src/main/java/com/iluwatar/bytec... | [
"bytecode/src/test/java/com/iluwatar/bytecode/AppTest.java",
"bytecode/src/test/java/com/iluwatar/bytecode/VirtualMachineTest.java",
"bytecode/src/test/java/com/iluwatar/bytecode/util/InstructionConverterUtilTest.java"
] | diff --git a/bytecode/README.md b/bytecode/README.md
new file mode 100644
index 000000000000..d2fc45e1e2d1
--- /dev/null
+++ b/bytecode/README.md
@@ -0,0 +1,25 @@
+---
+layout: pattern
+title: Bytecode
+folder: bytecode
+permalink: /patterns/bytecode/
+categories: Behavioral
+tags:
+ - Java
+ - Difficulty-Beginner
+---... | diff --git a/bytecode/src/test/java/com/iluwatar/bytecode/AppTest.java b/bytecode/src/test/java/com/iluwatar/bytecode/AppTest.java
new file mode 100644
index 000000000000..014ec787569c
--- /dev/null
+++ b/bytecode/src/test/java/com/iluwatar/bytecode/AppTest.java
@@ -0,0 +1,37 @@
+/**
+ * The MIT License
+ * Copyright (... | val | train | 2019-08-31T20:10:35 | 2017-04-01T08:53:45Z | iluwatar | train |
iluwatar/java-design-patterns/895_901 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/895 | iluwatar/java-design-patterns/901 | [
"keyword_pr_to_issue"
] | fedc2d9e47cb2b44aa4ea23aed9d117bbd4ed069 | 35dc25d4806f898bfc8f1ee31e4c9479bcc496d8 | [
"I am working on this issue.",
"Ok @saksham93 ",
"Pull Request raised"
] | [] | 2019-07-19T05:41:51Z | [
"type: bug",
"info: good first issue"
] | typo in FYI comment at "java-design-pattern/acyclic-visitor" | From here:
https://github.com/iluwatar/java-design-patterns/blob/fedc2d9e47cb2b44aa4ea23aed9d117bbd4ed069/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/App.java#L50
The comment should be:
```text
// Hayes modem with Dos configurator
``` | [
"acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/App.java"
] | [
"acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/App.java"
] | [] | diff --git a/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/App.java b/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/App.java
index 06e4bd2f255d..2a2f64591b6c 100644
--- a/acyclic-visitor/src/main/java/com/iluwatar/acyclicvisitor/App.java
+++ b/acyclic-visitor/src/main/java/com/iluwatar/acyclicvi... | null | train | train | 2019-04-07T07:41:35 | 2019-07-06T21:34:43Z | ljleb | train |
iluwatar/java-design-patterns/898_906 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/898 | iluwatar/java-design-patterns/906 | [
"timestamp(timedelta=24.0, similarity=0.845261461277026)"
] | 0c6237c225584a3a28bdd81cb19a40de698ed7f7 | 37fb276f28908353edb9a45be9c1e41799c18125 | [
"Describe your idea in this issue."
] | [] | 2019-07-25T08:22:19Z | [
"type: support",
"resolution: won't fix"
] | A new way for Factory Method | I wan to attach a fork with my idea for this project | [] | [
"simple-factory/README.md",
"simple-factory/src/main/java/com/iluwater/simplefactory/Apple.java",
"simple-factory/src/main/java/com/iluwater/simplefactory/Fruit.java",
"simple-factory/src/main/java/com/iluwater/simplefactory/FruitFactory.java",
"simple-factory/src/main/java/com/iluwater/simplefactory/Main.j... | [
"simple-factory/src/test/java/com/iluwater/simplefactory/SimpleFactorytest.java"
] | diff --git a/simple-factory/README.md b/simple-factory/README.md
new file mode 100644
index 000000000000..ec464c63732c
--- /dev/null
+++ b/simple-factory/README.md
@@ -0,0 +1,239 @@
+
+
+
+Simple Factory Pattern
+========================================
+|layout|title|folder|permalink|categories|tags|
+|---|---|---|---... | diff --git a/simple-factory/src/test/java/com/iluwater/simplefactory/SimpleFactorytest.java b/simple-factory/src/test/java/com/iluwater/simplefactory/SimpleFactorytest.java
new file mode 100644
index 000000000000..a79f737d4d3b
--- /dev/null
+++ b/simple-factory/src/test/java/com/iluwater/simplefactory/SimpleFactorytest... | train | train | 2019-07-24T21:08:30 | 2019-07-08T13:40:50Z | ac-ancheon | train |
iluwatar/java-design-patterns/761_920 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/761 | iluwatar/java-design-patterns/920 | [
"keyword_pr_to_issue"
] | 318f811fead95c4a363d776e968b0b1a4a112c86 | f1410337b570c6d444e98713036d13b53bdefe68 | [
"Yes, that is true. But I think that is the way the code is supposed to work. It allows creating one and only one instance, right?",
"Actually you can create another instance via `ThreadSafeDoubleCheckLocking.getInstance()`, or as many instances as possible via reflection.",
"Can someone verify this?",
"@iluw... | [] | 2019-09-05T06:00:01Z | [
"type: bug",
"info: help wanted"
] | ThreadSafeDoubleCheckLocking.java: Instantiating by Reflection call will be successful if you do that firstly | https://github.com/iluwatar/java-design-patterns/blob/987994f0fe5747e5524bc43c3b2000bee478c0c3/singleton/src/main/java/com/iluwatar/singleton/ThreadSafeDoubleCheckLocking.java#L43-L45
Instance will be null, and you can create a singleton object by reflection without an exception. | [
"singleton/pom.xml",
"singleton/src/main/java/com/iluwatar/singleton/ThreadSafeDoubleCheckLocking.java"
] | [
"singleton/pom.xml",
"singleton/src/main/java/com/iluwatar/singleton/ThreadSafeDoubleCheckLocking.java"
] | [
"singleton/src/test/java/com/iluwatar/singleton/ThreadSafeDoubleCheckLockingTest.java"
] | diff --git a/singleton/pom.xml b/singleton/pom.xml
index e3d8f06e2ea5..038d6fdac040 100644
--- a/singleton/pom.xml
+++ b/singleton/pom.xml
@@ -38,5 +38,9 @@
<artifactId>junit-jupiter-engine</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifa... | diff --git a/singleton/src/test/java/com/iluwatar/singleton/ThreadSafeDoubleCheckLockingTest.java b/singleton/src/test/java/com/iluwatar/singleton/ThreadSafeDoubleCheckLockingTest.java
index 1d00d9f8f624..6286b09fb2a4 100644
--- a/singleton/src/test/java/com/iluwatar/singleton/ThreadSafeDoubleCheckLockingTest.java
+++ ... | test | train | 2019-09-03T20:50:48 | 2018-06-24T06:57:35Z | DovahYol | train |
iluwatar/java-design-patterns/915_921 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/915 | iluwatar/java-design-patterns/921 | [
"keyword_pr_to_issue"
] | 318f811fead95c4a363d776e968b0b1a4a112c86 | 88fae070e64dd90c94ed6008a7e15cd549badc17 | [
"@iluwatar , \r\nHi, can I look at this change? ",
"Yes @snehalatapandit ",
"Hi @iluwatar, it seems this is again failing for different link\r\nhttps://travis-ci.org/iluwatar/java-design-patterns/builds/583292258\r\nIn https://github.com/iluwatar/java-design-patterns/tree/master/partial-response credit section ... | [] | 2019-09-05T12:53:40Z | [
"type: bug",
"epic: web site",
"info: good first issue",
"epic: build issue"
] | Fix broken links | The html-proofer that is included in Travis build indicates that we have some broken links.
```shell
Running ["HtmlCheck", "ImageCheck", "ScriptCheck", "LinkCheck"] on ["./_site/"] on *.html...
Checking 391 external links...
Ran on 133 files!
- ./_site/patterns/acyclic-visitor/index.html
* internally linkin... | [
"half-sync-half-async/README.md",
"intercepting-filter/README.md"
] | [
"half-sync-half-async/README.md",
"intercepting-filter/README.md"
] | [] | diff --git a/half-sync-half-async/README.md b/half-sync-half-async/README.md
index 8a091f8133a3..ef463edadc6f 100644
--- a/half-sync-half-async/README.md
+++ b/half-sync-half-async/README.md
@@ -27,11 +27,11 @@ Use Half-Sync/Half-Async pattern when
## Real world examples
-* [BSD Unix networking subsystem](http://w... | null | test | train | 2019-09-03T20:50:48 | 2019-07-30T05:07:14Z | iluwatar | train |
iluwatar/java-design-patterns/929_931 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/929 | iluwatar/java-design-patterns/931 | [
"keyword_pr_to_issue"
] | 5f39f7fbf71fd2799bb48384fc79efc4aba8e1ea | 3d62e02891d269890e86680b06b22033498d6bc6 | [] | [] | 2019-09-29T14:32:26Z | [
"type: bug",
"info: help wanted"
] | half-sync-half-async pattern need to enhance | In the App class of half-sync-half-async pattern, the workers in threadpool is still running when the main thread has finished. This also makes the AppTest less effective (after the test, we expect to see task results, but we get nothing because junit will terminate jvm when the main thread has finished).
To improve... | [
"half-sync-half-async/src/main/java/com/iluwatar/halfsynchalfasync/App.java",
"half-sync-half-async/src/main/java/com/iluwatar/halfsynchalfasync/AsynchronousService.java"
] | [
"half-sync-half-async/src/main/java/com/iluwatar/halfsynchalfasync/App.java",
"half-sync-half-async/src/main/java/com/iluwatar/halfsynchalfasync/AsynchronousService.java"
] | [] | diff --git a/half-sync-half-async/src/main/java/com/iluwatar/halfsynchalfasync/App.java b/half-sync-half-async/src/main/java/com/iluwatar/halfsynchalfasync/App.java
index 90cb5ecbfb0d..b24e29b6a55c 100644
--- a/half-sync-half-async/src/main/java/com/iluwatar/halfsynchalfasync/App.java
+++ b/half-sync-half-async/src/mai... | null | train | train | 2019-09-20T07:08:43 | 2019-09-28T04:05:40Z | npczwh | train |
iluwatar/java-design-patterns/834_940 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/834 | iluwatar/java-design-patterns/940 | [
"keyword_pr_to_issue"
] | 823c58bef2197c30d7f8a40c2701973ee9a04ea2 | 05d0f0babfcb37fc46bc92c384db6e096d78ddca | [
"Hi,\r\n\r\nThis error is coming, because 'spring-boot-dependencies' dependency is redeclared inside dependencyManagement section of image-microservice project without specifying it's version. This dependency has already a version in the top parent pom.xml (https://github.com/iluwatar/java-design-patterns/blob/mas... | [] | 2019-10-03T18:08:17Z | [
"epic: ide issue"
] | Maven build fail - Project "image-microservice" pom.xml lack of version field | Hi. When I run "mvn eclipse:eclipse" in the base path to convert to eclipse project.
An error occur and it's error info as below.
`[ERROR] Failed to execute goal org.apache.maven.plugins:maven-eclipse-plugin:2.10:eclipse (default-cli) on project image-microservice: Execution default-cli of goal org.apache.maven.plu... | [
"aggregator-microservices/aggregator-service/pom.xml",
"aggregator-microservices/information-microservice/pom.xml",
"aggregator-microservices/inventory-microservice/pom.xml",
"api-gateway/api-gateway-service/pom.xml",
"api-gateway/image-microservice/pom.xml",
"api-gateway/price-microservice/pom.xml",
"p... | [
"aggregator-microservices/aggregator-service/pom.xml",
"aggregator-microservices/information-microservice/pom.xml",
"aggregator-microservices/inventory-microservice/pom.xml",
"api-gateway/api-gateway-service/pom.xml",
"api-gateway/image-microservice/pom.xml",
"api-gateway/price-microservice/pom.xml",
"p... | [] | diff --git a/aggregator-microservices/aggregator-service/pom.xml b/aggregator-microservices/aggregator-service/pom.xml
index dbe303809f9b..6ad8c3c8c5a4 100644
--- a/aggregator-microservices/aggregator-service/pom.xml
+++ b/aggregator-microservices/aggregator-service/pom.xml
@@ -32,18 +32,8 @@
<version>1.22.0-S... | null | val | train | 2019-10-02T09:53:57 | 2018-12-18T09:56:22Z | zhangyuejia | train |
iluwatar/java-design-patterns/943_947 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/943 | iluwatar/java-design-patterns/947 | [
"timestamp(timedelta=108225.0, similarity=0.9053963176279485)"
] | 05d0f0babfcb37fc46bc92c384db6e096d78ddca | c24c0cbb9a60a4b3fe83373f92b262bfe096b694 | [
"I'll fix..",
"Thanks @perwramdemark, go ahead"
] | [] | 2019-10-04T04:52:40Z | [
"info: good first issue",
"epic: build issue",
"epic: dependencies"
] | Java 11 support: Maven plugin upgrade | This task is part of the Java 11 transition plan https://github.com/iluwatar/java-design-patterns/wiki/16.-Java-11-Transition
We need to update the Maven plugins used in the build to versions that support Java 11. The plugins include at least
- maven-compiler-plugin
- jacoco-maven-plugin
- maven-checkstyle-plug... | [
"pom.xml",
"trampoline/pom.xml"
] | [
"pom.xml",
"trampoline/pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index 5dfb1fff4376..eb3b68c498fb 100644
--- a/pom.xml
+++ b/pom.xml
@@ -38,7 +38,7 @@
<junit-vintage.version>${junit.version}.2</junit-vintage.version>
<junit-platform.version>1.0.2</junit-platform.version>
<sping-test-junit5.version>1.0.2</sping-test-junit5.ver... | null | train | train | 2019-10-03T20:50:50 | 2019-10-03T19:07:47Z | iluwatar | train |
iluwatar/java-design-patterns/944_947 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/944 | iluwatar/java-design-patterns/947 | [
"timestamp(timedelta=119589.0, similarity=0.8487298047756754)"
] | 05d0f0babfcb37fc46bc92c384db6e096d78ddca | c24c0cbb9a60a4b3fe83373f92b262bfe096b694 | [
"@iluwatar compiling project with java 8 I don't get any other compiler warnings.",
"Yes, I can confirm. We can close this issue."
] | [] | 2019-10-04T04:52:40Z | [
"type: bug",
"info: help wanted",
"info: good first issue",
"epic: build issue"
] | Java 11 support: Get rid of compiler warnings | This task is part of the Java 11 transition plan https://github.com/iluwatar/java-design-patterns/wiki/16.-Java-11-Transition
In this task we run the regular build and inspect the compiler output for warnings. We are especially interested in deprecation warnings, those are going to break things when Java version is ... | [
"pom.xml",
"trampoline/pom.xml"
] | [
"pom.xml",
"trampoline/pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index 5dfb1fff4376..eb3b68c498fb 100644
--- a/pom.xml
+++ b/pom.xml
@@ -38,7 +38,7 @@
<junit-vintage.version>${junit.version}.2</junit-vintage.version>
<junit-platform.version>1.0.2</junit-platform.version>
<sping-test-junit5.version>1.0.2</sping-test-junit5.ver... | null | train | train | 2019-10-03T20:50:50 | 2019-10-03T19:12:41Z | iluwatar | train |
iluwatar/java-design-patterns/941_947 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/941 | iluwatar/java-design-patterns/947 | [
"timestamp(timedelta=51.0, similarity=0.927590914655598)"
] | 05d0f0babfcb37fc46bc92c384db6e096d78ddca | c24c0cbb9a60a4b3fe83373f92b262bfe096b694 | [
"\r\n"
] | [] | 2019-10-04T04:52:40Z | [
"info: help wanted",
"type: support",
"epic: developer wiki",
"info: good first issue",
"epic: build issue"
] | Java 11 support: Maven version | This task is part of the Java 11 transition plan https://github.com/iluwatar/java-design-patterns/wiki/16.-Java-11-Transition
Find out what is the minimum Maven version that supports Java 11. Hopefully this information can be found on the Maven web site somewhere. | [
"pom.xml",
"trampoline/pom.xml"
] | [
"pom.xml",
"trampoline/pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index 5dfb1fff4376..eb3b68c498fb 100644
--- a/pom.xml
+++ b/pom.xml
@@ -38,7 +38,7 @@
<junit-vintage.version>${junit.version}.2</junit-vintage.version>
<junit-platform.version>1.0.2</junit-platform.version>
<sping-test-junit5.version>1.0.2</sping-test-junit5.ver... | null | train | train | 2019-10-03T20:50:50 | 2019-10-03T18:58:37Z | iluwatar | train |
iluwatar/java-design-patterns/591_947 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/591 | iluwatar/java-design-patterns/947 | [
"timestamp(timedelta=124592.0, similarity=0.8593589023804361)"
] | 05d0f0babfcb37fc46bc92c384db6e096d78ddca | c24c0cbb9a60a4b3fe83373f92b262bfe096b694 | [
"There is now branch called `java9` where we aim to make the project work with JDK9. Pull requests helping towards that goal will be gratefully accepted.",
"The Java 9 build fails with the following output: \r\n[build.txt](https://github.com/iluwatar/java-design-patterns/files/1272821/build.txt)\r\n\r\nWith skip ... | [] | 2019-10-04T04:52:40Z | [
"info: needs splitting",
"resolution: won't fix"
] | Java 9 support | Java 9 general availability is just a few months away and we should start migrating the codebase to work on top of that. This is a huge issue and needs more discussion, planning and splitting. | [
"pom.xml",
"trampoline/pom.xml"
] | [
"pom.xml",
"trampoline/pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index 5dfb1fff4376..eb3b68c498fb 100644
--- a/pom.xml
+++ b/pom.xml
@@ -38,7 +38,7 @@
<junit-vintage.version>${junit.version}.2</junit-vintage.version>
<junit-platform.version>1.0.2</junit-platform.version>
<sping-test-junit5.version>1.0.2</sping-test-junit5.ver... | null | train | train | 2019-10-03T20:50:50 | 2017-06-11T15:14:28Z | iluwatar | train |
iluwatar/java-design-patterns/939_952 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/939 | iluwatar/java-design-patterns/952 | [
"keyword_pr_to_issue"
] | 218ba44dbfcaaacc12f11ec4830cf6cd13451388 | 933de30d42271f422a487b0a74d6d7ccf6053709 | [
"I can fix it!",
"Nice @perwramdemark, go ahead!",
"Related to https://github.com/iluwatar/java-design-patterns/issues/944"
] | [] | 2019-10-05T11:52:31Z | [
"type: bug",
"info: good first issue",
"epic: build issue",
"epic: dependencies"
] | WARNING when building project | When building project with mvn install you get below warning. You need to setup the JXR plugin to get ride of this for multi-module projects.
[INFO] --- maven-pmd-plugin:3.6:pmd (pmd) @ abstract-factory ---
[WARNING] Unable to locate Source XRef to link to - DISABLED
Unable to locate Source XRef to link to - DISAB... | [
"pom.xml"
] | [
"pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index d985b6c62fe2..874bf66dddee 100644
--- a/pom.xml
+++ b/pom.xml
@@ -465,6 +465,11 @@
<artifactId>maven-pmd-plugin</artifactId>
<version>${pmd.version}</version>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.pl... | null | train | train | 2019-10-05T13:23:20 | 2019-10-03T17:09:56Z | perwramdemark | train |
iluwatar/java-design-patterns/954_957 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/954 | iluwatar/java-design-patterns/957 | [
"keyword_pr_to_issue"
] | 933de30d42271f422a487b0a74d6d7ccf6053709 | 94ca25462667b15d2d4f7d5120c94a0733f53bf7 | [
"Hi, I have created a pull request for this issue. ",
"https://github.com/iluwatar/java-design-patterns/pull/957",
"A lot of this stuff has just been migrated to community projects...\r\n\r\nShouldn't J-EE move to Jakarta? I didn't think J-EE was truly deprecated.\r\nJavaFX to https://openjfx.io/\r\n",
"@ryan... | [
"Please specify the version numbers in the main `pom.xml` dependencyManagement section",
"I have moved the version numbers to main pom.xml's dependencyManagement section and updated the pull request."
] | 2019-10-05T19:25:49Z | [
"info: help wanted",
"info: good first issue",
"epic: dependencies"
] | Java 11 support: Get rid of JavaEE, Corba and JavaFX | This task is part of the Java 11 transition plan https://github.com/iluwatar/java-design-patterns/wiki/16.-Java-11-Transition
Java EE, Corba and JavaFX have been deprecated in newer JDK versions. Are there any dependencies to those in this project? If there is, we should get rid of them. (see https://blog.codefx.org... | [
"pom.xml",
"repository/pom.xml"
] | [
"pom.xml",
"repository/pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index f1a586eb8b34..acaaef6181c5 100644
--- a/pom.xml
+++ b/pom.xml
@@ -55,6 +55,8 @@
<aws-lambda-java-events.version>2.0.1</aws-lambda-java-events.version>
<jackson.version>2.8.5</jackson.version>
<pmd.version>3.12.0</pmd.version>
+ <jaxb-api.version>2.3... | null | train | train | 2019-10-05T17:01:23 | 2019-10-05T15:08:36Z | iluwatar | train |
iluwatar/java-design-patterns/549_958 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/549 | iluwatar/java-design-patterns/958 | [
"keyword_pr_to_issue"
] | 933de30d42271f422a487b0a74d6d7ccf6053709 | 60171e3c873257b86f66b0a67935321735d2c7d1 | [
"Can't we consider \r\n\r\n` try (CloseableHttpClient httpClient = HttpClients.createDefault()) {\r\n HttpGet httpGet = new HttpGet(\"http://localhost:51515/information\");\r\n try (CloseableHttpResponse httpResponse = httpClient.execute(httpGet)) {\r\n response = EntityUtils.toString(httpRespon... | [] | 2019-10-05T19:57:19Z | [
"type: enhancement",
"info: good first issue",
"epic: code quality"
] | "Aggregator microservices" design pattern doesn't show exception handling | "Aggregator microservices" design pattern doesn't show how exception handling would be done if the one or multiple services used are down and how client calling the aggregator microservice would cope in this situation. | [
"aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/ProductInformationClientImpl.java",
"aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/ProductInventoryClientImpl.java"
] | [
"aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/ProductInformationClientImpl.java",
"aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/ProductInventoryClientImpl.java"
] | [] | diff --git a/aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/ProductInformationClientImpl.java b/aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/ProductInformationClientImpl.java
index 16849d529386..131fbf8695cd 100644
--- a... | null | test | train | 2019-10-05T17:01:23 | 2017-03-26T17:51:56Z | neerajmahajan | train |
Subsets and Splits
Java Code Detection in Problems
Identifies and categorizes entries in the dataset that are likely related to Java programming, providing insights into the prevalence and type of Java content in the problem statements.