type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
334k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
10
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments/141757852","pull_request_review_id":66024181,"id":141757852,"diff_hunk":"@@ -0,0 +1,113 @@\n+## Overview\n+PaddlePaddle represents a neural network as a `Block`. The word block and graph are interchangable in the desgin of PaddlePaddle. A block is like a pair of curly braces in programming languages like C++ and Java, it includes some variables and a sequence of instructions, or, operators. Usually we run a block using a CPU thread. But we want to accelerate the execution of some operators using devices like GPU and FPGA.","path":"doc/design/block_execution.md","position":2,"original_position":2,"commit_id":"9447858aa778bc4fe18419c746c2c6997d822633","original_commit_id":"3989b25057849e24826ef7382708dd8aecd463b7","user":{"login":"helinwang","id":1724178,"avatar_url":"https://avatars3.githubusercontent.com/u/1724178?v=4","gravatar_id":"","url":"https://api.github.com/users/helinwang","html_url":"https://github.com/helinwang","followers_url":"https://api.github.com/users/helinwang/followers","following_url":"https://api.github.com/users/helinwang/following{/other_user}","gists_url":"https://api.github.com/users/helinwang/gists{/gist_id}","starred_url":"https://api.github.com/users/helinwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helinwang/subscriptions","organizations_url":"https://api.github.com/users/helinwang/orgs","repos_url":"https://api.github.com/users/helinwang/repos","events_url":"https://api.github.com/users/helinwang/events{/privacy}","received_events_url":"https://api.github.com/users/helinwang/received_events","type":"User","site_admin":false},"body":"@typhoonzero Sorry, my example is misleading. I mean we need a scheduler to put OP to \"run queue\" only when the dependencies of the OP is done. Because by definition the OP should only run when all of its dependencies is done.","created_at":"2017-09-28T23:11:26Z","updated_at":"2017-09-28T23:11:26Z","html_url":"https://github.com/PaddlePaddle/Paddle/pull/4125#discussion_r141757852","pull_request_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/4125","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments/141757852"},"html":{"href":"https://github.com/PaddlePaddle/Paddle/pull/4125#discussion_r141757852"},"pull_request":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/4125"}},"in_reply_to_id":140932696},"pull_request":{"url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/4125","id":141249916,"html_url":"https://github.com/PaddlePaddle/Paddle/pull/4125","diff_url":"https://github.com/PaddlePaddle/Paddle/pull/4125.diff","patch_url":"https://github.com/PaddlePaddle/Paddle/pull/4125.patch","issue_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/4125","number":4125,"state":"open","locked":false,"title":"add block execution doc","user":{"login":"QiJune","id":22017000,"avatar_url":"https://avatars0.githubusercontent.com/u/22017000?v=4","gravatar_id":"","url":"https://api.github.com/users/QiJune","html_url":"https://github.com/QiJune","followers_url":"https://api.github.com/users/QiJune/followers","following_url":"https://api.github.com/users/QiJune/following{/other_user}","gists_url":"https://api.github.com/users/QiJune/gists{/gist_id}","starred_url":"https://api.github.com/users/QiJune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QiJune/subscriptions","organizations_url":"https://api.github.com/users/QiJune/orgs","repos_url":"https://api.github.com/users/QiJune/repos","events_url":"https://api.github.com/users/QiJune/events{/privacy}","received_events_url":"https://api.github.com/users/QiJune/received_events","type":"User","site_admin":false},"body":"[Here](https://github.com/QiJune/Paddle/blob/9447858aa778bc4fe18419c746c2c6997d822633/doc/design/block_execution.md) is better to review.","created_at":"2017-09-15T07:58:01Z","updated_at":"2017-09-28T23:11:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8703ff15b3c087015f988d9605bd4bdd9e94e749","assignee":null,"assignees":[],"requested_reviewers":[{"login":"reyoung","id":728699,"avatar_url":"https://avatars2.githubusercontent.com/u/728699?v=4","gravatar_id":"","url":"https://api.github.com/users/reyoung","html_url":"https://github.com/reyoung","followers_url":"https://api.github.com/users/reyoung/followers","following_url":"https://api.github.com/users/reyoung/following{/other_user}","gists_url":"https://api.github.com/users/reyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/reyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reyoung/subscriptions","organizations_url":"https://api.github.com/users/reyoung/orgs","repos_url":"https://api.github.com/users/reyoung/repos","events_url":"https://api.github.com/users/reyoung/events{/privacy}","received_events_url":"https://api.github.com/users/reyoung/received_events","type":"User","site_admin":false},{"login":"jacquesqiao","id":3048612,"avatar_url":"https://avatars0.githubusercontent.com/u/3048612?v=4","gravatar_id":"","url":"https://api.github.com/users/jacquesqiao","html_url":"https://github.com/jacquesqiao","followers_url":"https://api.github.com/users/jacquesqiao/followers","following_url":"https://api.github.com/users/jacquesqiao/following{/other_user}","gists_url":"https://api.github.com/users/jacquesqiao/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquesqiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquesqiao/subscriptions","organizations_url":"https://api.github.com/users/jacquesqiao/orgs","repos_url":"https://api.github.com/users/jacquesqiao/repos","events_url":"https://api.github.com/users/jacquesqiao/events{/privacy}","received_events_url":"https://api.github.com/users/jacquesqiao/received_events","type":"User","site_admin":false},{"login":"Canpio","id":8395645,"avatar_url":"https://avatars2.githubusercontent.com/u/8395645?v=4","gravatar_id":"","url":"https://api.github.com/users/Canpio","html_url":"https://github.com/Canpio","followers_url":"https://api.github.com/users/Canpio/followers","following_url":"https://api.github.com/users/Canpio/following{/other_user}","gists_url":"https://api.github.com/users/Canpio/gists{/gist_id}","starred_url":"https://api.github.com/users/Canpio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Canpio/subscriptions","organizations_url":"https://api.github.com/users/Canpio/orgs","repos_url":"https://api.github.com/users/Canpio/repos","events_url":"https://api.github.com/users/Canpio/events{/privacy}","received_events_url":"https://api.github.com/users/Canpio/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/4125/commits","review_comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/4125/comments","review_comment_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/4125/comments","statuses_url":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/9447858aa778bc4fe18419c746c2c6997d822633","head":{"label":"QiJune:block_roadmap","ref":"block_roadmap","sha":"9447858aa778bc4fe18419c746c2c6997d822633","user":{"login":"QiJune","id":22017000,"avatar_url":"https://avatars0.githubusercontent.com/u/22017000?v=4","gravatar_id":"","url":"https://api.github.com/users/QiJune","html_url":"https://github.com/QiJune","followers_url":"https://api.github.com/users/QiJune/followers","following_url":"https://api.github.com/users/QiJune/following{/other_user}","gists_url":"https://api.github.com/users/QiJune/gists{/gist_id}","starred_url":"https://api.github.com/users/QiJune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QiJune/subscriptions","organizations_url":"https://api.github.com/users/QiJune/orgs","repos_url":"https://api.github.com/users/QiJune/repos","events_url":"https://api.github.com/users/QiJune/events{/privacy}","received_events_url":"https://api.github.com/users/QiJune/received_events","type":"User","site_admin":false},"repo":{"id":68076834,"name":"Paddle","full_name":"QiJune/Paddle","owner":{"login":"QiJune","id":22017000,"avatar_url":"https://avatars0.githubusercontent.com/u/22017000?v=4","gravatar_id":"","url":"https://api.github.com/users/QiJune","html_url":"https://github.com/QiJune","followers_url":"https://api.github.com/users/QiJune/followers","following_url":"https://api.github.com/users/QiJune/following{/other_user}","gists_url":"https://api.github.com/users/QiJune/gists{/gist_id}","starred_url":"https://api.github.com/users/QiJune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QiJune/subscriptions","organizations_url":"https://api.github.com/users/QiJune/orgs","repos_url":"https://api.github.com/users/QiJune/repos","events_url":"https://api.github.com/users/QiJune/events{/privacy}","received_events_url":"https://api.github.com/users/QiJune/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/QiJune/Paddle","description":"PArallel Distributed Deep LEarning","fork":true,"url":"https://api.github.com/repos/QiJune/Paddle","forks_url":"https://api.github.com/repos/QiJune/Paddle/forks","keys_url":"https://api.github.com/repos/QiJune/Paddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QiJune/Paddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QiJune/Paddle/teams","hooks_url":"https://api.github.com/repos/QiJune/Paddle/hooks","issue_events_url":"https://api.github.com/repos/QiJune/Paddle/issues/events{/number}","events_url":"https://api.github.com/repos/QiJune/Paddle/events","assignees_url":"https://api.github.com/repos/QiJune/Paddle/assignees{/user}","branches_url":"https://api.github.com/repos/QiJune/Paddle/branches{/branch}","tags_url":"https://api.github.com/repos/QiJune/Paddle/tags","blobs_url":"https://api.github.com/repos/QiJune/Paddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QiJune/Paddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QiJune/Paddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/QiJune/Paddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QiJune/Paddle/statuses/{sha}","languages_url":"https://api.github.com/repos/QiJune/Paddle/languages","stargazers_url":"https://api.github.com/repos/QiJune/Paddle/stargazers","contributors_url":"https://api.github.com/repos/QiJune/Paddle/contributors","subscribers_url":"https://api.github.com/repos/QiJune/Paddle/subscribers","subscription_url":"https://api.github.com/repos/QiJune/Paddle/subscription","commits_url":"https://api.github.com/repos/QiJune/Paddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/QiJune/Paddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/QiJune/Paddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/QiJune/Paddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/QiJune/Paddle/contents/{+path}","compare_url":"https://api.github.com/repos/QiJune/Paddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QiJune/Paddle/merges","archive_url":"https://api.github.com/repos/QiJune/Paddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QiJune/Paddle/downloads","issues_url":"https://api.github.com/repos/QiJune/Paddle/issues{/number}","pulls_url":"https://api.github.com/repos/QiJune/Paddle/pulls{/number}","milestones_url":"https://api.github.com/repos/QiJune/Paddle/milestones{/number}","notifications_url":"https://api.github.com/repos/QiJune/Paddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QiJune/Paddle/labels{/name}","releases_url":"https://api.github.com/repos/QiJune/Paddle/releases{/id}","deployments_url":"https://api.github.com/repos/QiJune/Paddle/deployments","created_at":"2016-09-13T05:21:28Z","updated_at":"2016-09-13T05:21:31Z","pushed_at":"2017-09-28T21:40:04Z","git_url":"git://github.com/QiJune/Paddle.git","ssh_url":"[email protected]:QiJune/Paddle.git","clone_url":"https://github.com/QiJune/Paddle.git","svn_url":"https://github.com/QiJune/Paddle","homepage":"http://www.paddlepaddle.org/","size":30896,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PaddlePaddle:develop","ref":"develop","sha":"5deeefedfbd08354c5efe7cf832268125894b969","user":{"login":"PaddlePaddle","id":23534030,"avatar_url":"https://avatars3.githubusercontent.com/u/23534030?v=4","gravatar_id":"","url":"https://api.github.com/users/PaddlePaddle","html_url":"https://github.com/PaddlePaddle","followers_url":"https://api.github.com/users/PaddlePaddle/followers","following_url":"https://api.github.com/users/PaddlePaddle/following{/other_user}","gists_url":"https://api.github.com/users/PaddlePaddle/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddlePaddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddlePaddle/subscriptions","organizations_url":"https://api.github.com/users/PaddlePaddle/orgs","repos_url":"https://api.github.com/users/PaddlePaddle/repos","events_url":"https://api.github.com/users/PaddlePaddle/events{/privacy}","received_events_url":"https://api.github.com/users/PaddlePaddle/received_events","type":"Organization","site_admin":false},"repo":{"id":65711522,"name":"Paddle","full_name":"PaddlePaddle/Paddle","owner":{"login":"PaddlePaddle","id":23534030,"avatar_url":"https://avatars3.githubusercontent.com/u/23534030?v=4","gravatar_id":"","url":"https://api.github.com/users/PaddlePaddle","html_url":"https://github.com/PaddlePaddle","followers_url":"https://api.github.com/users/PaddlePaddle/followers","following_url":"https://api.github.com/users/PaddlePaddle/following{/other_user}","gists_url":"https://api.github.com/users/PaddlePaddle/gists{/gist_id}","starred_url":"https://api.github.com/users/PaddlePaddle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaddlePaddle/subscriptions","organizations_url":"https://api.github.com/users/PaddlePaddle/orgs","repos_url":"https://api.github.com/users/PaddlePaddle/repos","events_url":"https://api.github.com/users/PaddlePaddle/events{/privacy}","received_events_url":"https://api.github.com/users/PaddlePaddle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PaddlePaddle/Paddle","description":"PArallel Distributed Deep LEarning","fork":false,"url":"https://api.github.com/repos/PaddlePaddle/Paddle","forks_url":"https://api.github.com/repos/PaddlePaddle/Paddle/forks","keys_url":"https://api.github.com/repos/PaddlePaddle/Paddle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PaddlePaddle/Paddle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PaddlePaddle/Paddle/teams","hooks_url":"https://api.github.com/repos/PaddlePaddle/Paddle/hooks","issue_events_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/events{/number}","events_url":"https://api.github.com/repos/PaddlePaddle/Paddle/events","assignees_url":"https://api.github.com/repos/PaddlePaddle/Paddle/assignees{/user}","branches_url":"https://api.github.com/repos/PaddlePaddle/Paddle/branches{/branch}","tags_url":"https://api.github.com/repos/PaddlePaddle/Paddle/tags","blobs_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/refs{/sha}","trees_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/{sha}","languages_url":"https://api.github.com/repos/PaddlePaddle/Paddle/languages","stargazers_url":"https://api.github.com/repos/PaddlePaddle/Paddle/stargazers","contributors_url":"https://api.github.com/repos/PaddlePaddle/Paddle/contributors","subscribers_url":"https://api.github.com/repos/PaddlePaddle/Paddle/subscribers","subscription_url":"https://api.github.com/repos/PaddlePaddle/Paddle/subscription","commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/commits{/sha}","git_commits_url":"https://api.github.com/repos/PaddlePaddle/Paddle/git/commits{/sha}","comments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/comments{/number}","issue_comment_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/comments{/number}","contents_url":"https://api.github.com/repos/PaddlePaddle/Paddle/contents/{+path}","compare_url":"https://api.github.com/repos/PaddlePaddle/Paddle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PaddlePaddle/Paddle/merges","archive_url":"https://api.github.com/repos/PaddlePaddle/Paddle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PaddlePaddle/Paddle/downloads","issues_url":"https://api.github.com/repos/PaddlePaddle/Paddle/issues{/number}","pulls_url":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls{/number}","milestones_url":"https://api.github.com/repos/PaddlePaddle/Paddle/milestones{/number}","notifications_url":"https://api.github.com/repos/PaddlePaddle/Paddle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PaddlePaddle/Paddle/labels{/name}","releases_url":"https://api.github.com/repos/PaddlePaddle/Paddle/releases{/id}","deployments_url":"https://api.github.com/repos/PaddlePaddle/Paddle/deployments","created_at":"2016-08-15T06:59:08Z","updated_at":"2017-09-28T12:14:39Z","pushed_at":"2017-09-28T22:47:43Z","git_url":"git://github.com/PaddlePaddle/Paddle.git","ssh_url":"[email protected]:PaddlePaddle/Paddle.git","clone_url":"https://github.com/PaddlePaddle/Paddle.git","svn_url":"https://github.com/PaddlePaddle/Paddle","homepage":"http://www.paddlepaddle.org/","size":53603,"stargazers_count":5521,"watchers_count":5521,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1477,"mirror_url":null,"open_issues_count":686,"forks":1477,"open_issues":686,"watchers":5521,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/4125"},"html":{"href":"https://github.com/PaddlePaddle/Paddle/pull/4125"},"issue":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/4125"},"comments":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/issues/4125/comments"},"review_comments":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/4125/comments"},"review_comment":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/pulls/4125/commits"},"statuses":{"href":"https://api.github.com/repos/PaddlePaddle/Paddle/statuses/9447858aa778bc4fe18419c746c2c6997d822633"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 65711522,
"name": "PaddlePaddle/Paddle",
"url": "https://api.github.com/repos/PaddlePaddle/Paddle"
}
|
{
"id": 1724178,
"login": "helinwang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1724178?",
"url": "https://api.github.com/users/helinwang"
}
|
{
"id": 23534030,
"login": "PaddlePaddle",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23534030?",
"url": "https://api.github.com/orgs/PaddlePaddle"
}
| 2017-09-28T23:11:26 |
6652129026
|
{"actor":{"display_login":"helinwang"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/comments/100750314","pull_request_review_id":21463629,"id":100750314,"diff_hunk":"@@ -0,0 +1,45 @@\n+/** @file\n+ *\n+ * Class to render a fullscreen 2D quad to the screen.\n+ *\n+ * @copyright 2017 Palm Studios\n+ *\n+ * @date 11-2-2017\n+ *\n+ * @note To render a quad, we need to split the screen into two right-angled triangles, meaning we need 6 vertices for one quad.\n+ *\n+ * @author Jesse Buhagiar\n+ */\n+#ifndef QUAD_HPP_INCLUDED\n+#define QUAD_HPP_INCLUDED\n+\n+#include \"GL/glew.h\"\n+#include \"GL/gl.h\"\n+#include \"glm/glm.hpp\"\n+\n+#include <vector>\n+\n+namespace sh3_graphics\n+{\n+ struct quad final\n+ {\n+ public:\n+ /**\n+ * Class constructor. Takes\n+ */\n+ quad(const std::vector<glm::vec3>& verts);\n+ ~quad(){};\n+\n+ /**\n+ * Draw this quad to the screen\n+ */\n+ void Draw();\n+\n+ private:\n+ GLuint vao; /**< VAO where we will store the four co-ordinates for our 2D quad in slot 1 (\"position\") */\n+ GLuint vbo; /**< The buffer we will */","path":"include/SH3/graphics/quad.hpp","position":40,"original_position":40,"commit_id":"22c7f31180451a47f409a711b6c0c8ee05a12999","original_commit_id":"22c7f31180451a47f409a711b6c0c8ee05a12999","user":{"login":"z33ky","id":289819,"avatar_url":"https://avatars.githubusercontent.com/u/289819?v=3","gravatar_id":"","url":"https://api.github.com/users/z33ky","html_url":"https://github.com/z33ky","followers_url":"https://api.github.com/users/z33ky/followers","following_url":"https://api.github.com/users/z33ky/following{/other_user}","gists_url":"https://api.github.com/users/z33ky/gists{/gist_id}","starred_url":"https://api.github.com/users/z33ky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/z33ky/subscriptions","organizations_url":"https://api.github.com/users/z33ky/orgs","repos_url":"https://api.github.com/users/z33ky/repos","events_url":"https://api.github.com/users/z33ky/events{/privacy}","received_events_url":"https://api.github.com/users/z33ky/received_events","type":"User","site_admin":false},"body":"\"we will\" ..,","created_at":"2017-02-13T09:15:33Z","updated_at":"2017-02-13T09:17:48Z","html_url":"https://github.com/Palm-Studios/sh3redux/pull/83#discussion_r100750314","pull_request_url":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/comments/100750314"},"html":{"href":"https://github.com/Palm-Studios/sh3redux/pull/83#discussion_r100750314"},"pull_request":{"href":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/83","id":105750542,"html_url":"https://github.com/Palm-Studios/sh3redux/pull/83","diff_url":"https://github.com/Palm-Studios/sh3redux/pull/83.diff","patch_url":"https://github.com/Palm-Studios/sh3redux/pull/83.patch","issue_url":"https://api.github.com/repos/Palm-Studios/sh3redux/issues/83","number":83,"state":"open","locked":false,"title":"Created a quad class","user":{"login":"Quaker762","id":4768900,"avatar_url":"https://avatars.githubusercontent.com/u/4768900?v=3","gravatar_id":"","url":"https://api.github.com/users/Quaker762","html_url":"https://github.com/Quaker762","followers_url":"https://api.github.com/users/Quaker762/followers","following_url":"https://api.github.com/users/Quaker762/following{/other_user}","gists_url":"https://api.github.com/users/Quaker762/gists{/gist_id}","starred_url":"https://api.github.com/users/Quaker762/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quaker762/subscriptions","organizations_url":"https://api.github.com/users/Quaker762/orgs","repos_url":"https://api.github.com/users/Quaker762/repos","events_url":"https://api.github.com/users/Quaker762/events{/privacy}","received_events_url":"https://api.github.com/users/Quaker762/received_events","type":"User","site_admin":false},"body":"Created a class that enables us to actually draw a quad to the screen\r\n(and a small GL3.3 test in main.cpp). Currently doesn't pass any data to\r\na shader, so it's just a black quad (no colour data).","created_at":"2017-02-11T11:12:05Z","updated_at":"2017-02-13T09:17:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"946f9a4684d62604971bb7a6154f8fbd803ea2c3","assignee":{"login":"Quaker762","id":4768900,"avatar_url":"https://avatars.githubusercontent.com/u/4768900?v=3","gravatar_id":"","url":"https://api.github.com/users/Quaker762","html_url":"https://github.com/Quaker762","followers_url":"https://api.github.com/users/Quaker762/followers","following_url":"https://api.github.com/users/Quaker762/following{/other_user}","gists_url":"https://api.github.com/users/Quaker762/gists{/gist_id}","starred_url":"https://api.github.com/users/Quaker762/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quaker762/subscriptions","organizations_url":"https://api.github.com/users/Quaker762/orgs","repos_url":"https://api.github.com/users/Quaker762/repos","events_url":"https://api.github.com/users/Quaker762/events{/privacy}","received_events_url":"https://api.github.com/users/Quaker762/received_events","type":"User","site_admin":false},"assignees":[{"login":"Quaker762","id":4768900,"avatar_url":"https://avatars.githubusercontent.com/u/4768900?v=3","gravatar_id":"","url":"https://api.github.com/users/Quaker762","html_url":"https://github.com/Quaker762","followers_url":"https://api.github.com/users/Quaker762/followers","following_url":"https://api.github.com/users/Quaker762/following{/other_user}","gists_url":"https://api.github.com/users/Quaker762/gists{/gist_id}","starred_url":"https://api.github.com/users/Quaker762/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quaker762/subscriptions","organizations_url":"https://api.github.com/users/Quaker762/orgs","repos_url":"https://api.github.com/users/Quaker762/repos","events_url":"https://api.github.com/users/Quaker762/events{/privacy}","received_events_url":"https://api.github.com/users/Quaker762/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/83/commits","review_comments_url":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/83/comments","review_comment_url":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Palm-Studios/sh3redux/issues/83/comments","statuses_url":"https://api.github.com/repos/Palm-Studios/sh3redux/statuses/22c7f31180451a47f409a711b6c0c8ee05a12999","head":{"label":"Quaker762:fsquad","ref":"fsquad","sha":"22c7f31180451a47f409a711b6c0c8ee05a12999","user":{"login":"Quaker762","id":4768900,"avatar_url":"https://avatars.githubusercontent.com/u/4768900?v=3","gravatar_id":"","url":"https://api.github.com/users/Quaker762","html_url":"https://github.com/Quaker762","followers_url":"https://api.github.com/users/Quaker762/followers","following_url":"https://api.github.com/users/Quaker762/following{/other_user}","gists_url":"https://api.github.com/users/Quaker762/gists{/gist_id}","starred_url":"https://api.github.com/users/Quaker762/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quaker762/subscriptions","organizations_url":"https://api.github.com/users/Quaker762/orgs","repos_url":"https://api.github.com/users/Quaker762/repos","events_url":"https://api.github.com/users/Quaker762/events{/privacy}","received_events_url":"https://api.github.com/users/Quaker762/received_events","type":"User","site_admin":false},"repo":{"id":78095188,"name":"sh3redux","full_name":"Quaker762/sh3redux","owner":{"login":"Quaker762","id":4768900,"avatar_url":"https://avatars.githubusercontent.com/u/4768900?v=3","gravatar_id":"","url":"https://api.github.com/users/Quaker762","html_url":"https://github.com/Quaker762","followers_url":"https://api.github.com/users/Quaker762/followers","following_url":"https://api.github.com/users/Quaker762/following{/other_user}","gists_url":"https://api.github.com/users/Quaker762/gists{/gist_id}","starred_url":"https://api.github.com/users/Quaker762/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quaker762/subscriptions","organizations_url":"https://api.github.com/users/Quaker762/orgs","repos_url":"https://api.github.com/users/Quaker762/repos","events_url":"https://api.github.com/users/Quaker762/events{/privacy}","received_events_url":"https://api.github.com/users/Quaker762/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Quaker762/sh3redux","description":"SILENT HILL 3 Engine Remake in OpenGL and C++","fork":true,"url":"https://api.github.com/repos/Quaker762/sh3redux","forks_url":"https://api.github.com/repos/Quaker762/sh3redux/forks","keys_url":"https://api.github.com/repos/Quaker762/sh3redux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Quaker762/sh3redux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Quaker762/sh3redux/teams","hooks_url":"https://api.github.com/repos/Quaker762/sh3redux/hooks","issue_events_url":"https://api.github.com/repos/Quaker762/sh3redux/issues/events{/number}","events_url":"https://api.github.com/repos/Quaker762/sh3redux/events","assignees_url":"https://api.github.com/repos/Quaker762/sh3redux/assignees{/user}","branches_url":"https://api.github.com/repos/Quaker762/sh3redux/branches{/branch}","tags_url":"https://api.github.com/repos/Quaker762/sh3redux/tags","blobs_url":"https://api.github.com/repos/Quaker762/sh3redux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Quaker762/sh3redux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Quaker762/sh3redux/git/refs{/sha}","trees_url":"https://api.github.com/repos/Quaker762/sh3redux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Quaker762/sh3redux/statuses/{sha}","languages_url":"https://api.github.com/repos/Quaker762/sh3redux/languages","stargazers_url":"https://api.github.com/repos/Quaker762/sh3redux/stargazers","contributors_url":"https://api.github.com/repos/Quaker762/sh3redux/contributors","subscribers_url":"https://api.github.com/repos/Quaker762/sh3redux/subscribers","subscription_url":"https://api.github.com/repos/Quaker762/sh3redux/subscription","commits_url":"https://api.github.com/repos/Quaker762/sh3redux/commits{/sha}","git_commits_url":"https://api.github.com/repos/Quaker762/sh3redux/git/commits{/sha}","comments_url":"https://api.github.com/repos/Quaker762/sh3redux/comments{/number}","issue_comment_url":"https://api.github.com/repos/Quaker762/sh3redux/issues/comments{/number}","contents_url":"https://api.github.com/repos/Quaker762/sh3redux/contents/{+path}","compare_url":"https://api.github.com/repos/Quaker762/sh3redux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Quaker762/sh3redux/merges","archive_url":"https://api.github.com/repos/Quaker762/sh3redux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Quaker762/sh3redux/downloads","issues_url":"https://api.github.com/repos/Quaker762/sh3redux/issues{/number}","pulls_url":"https://api.github.com/repos/Quaker762/sh3redux/pulls{/number}","milestones_url":"https://api.github.com/repos/Quaker762/sh3redux/milestones{/number}","notifications_url":"https://api.github.com/repos/Quaker762/sh3redux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Quaker762/sh3redux/labels{/name}","releases_url":"https://api.github.com/repos/Quaker762/sh3redux/releases{/id}","deployments_url":"https://api.github.com/repos/Quaker762/sh3redux/deployments","created_at":"2017-01-05T08:37:57Z","updated_at":"2017-01-05T08:37:59Z","pushed_at":"2017-02-11T11:15:57Z","git_url":"git://github.com/Quaker762/sh3redux.git","ssh_url":"[email protected]:Quaker762/sh3redux.git","clone_url":"https://github.com/Quaker762/sh3redux.git","svn_url":"https://github.com/Quaker762/sh3redux","homepage":null,"size":14849,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Palm-Studios:master","ref":"master","sha":"2e7be3d272060a3f6a9370e19f7cc433a4484df1","user":{"login":"Palm-Studios","id":24369067,"avatar_url":"https://avatars.githubusercontent.com/u/24369067?v=3","gravatar_id":"","url":"https://api.github.com/users/Palm-Studios","html_url":"https://github.com/Palm-Studios","followers_url":"https://api.github.com/users/Palm-Studios/followers","following_url":"https://api.github.com/users/Palm-Studios/following{/other_user}","gists_url":"https://api.github.com/users/Palm-Studios/gists{/gist_id}","starred_url":"https://api.github.com/users/Palm-Studios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Palm-Studios/subscriptions","organizations_url":"https://api.github.com/users/Palm-Studios/orgs","repos_url":"https://api.github.com/users/Palm-Studios/repos","events_url":"https://api.github.com/users/Palm-Studios/events{/privacy}","received_events_url":"https://api.github.com/users/Palm-Studios/received_events","type":"Organization","site_admin":false},"repo":{"id":76116619,"name":"sh3redux","full_name":"Palm-Studios/sh3redux","owner":{"login":"Palm-Studios","id":24369067,"avatar_url":"https://avatars.githubusercontent.com/u/24369067?v=3","gravatar_id":"","url":"https://api.github.com/users/Palm-Studios","html_url":"https://github.com/Palm-Studios","followers_url":"https://api.github.com/users/Palm-Studios/followers","following_url":"https://api.github.com/users/Palm-Studios/following{/other_user}","gists_url":"https://api.github.com/users/Palm-Studios/gists{/gist_id}","starred_url":"https://api.github.com/users/Palm-Studios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Palm-Studios/subscriptions","organizations_url":"https://api.github.com/users/Palm-Studios/orgs","repos_url":"https://api.github.com/users/Palm-Studios/repos","events_url":"https://api.github.com/users/Palm-Studios/events{/privacy}","received_events_url":"https://api.github.com/users/Palm-Studios/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Palm-Studios/sh3redux","description":"SILENT HILL 3 Engine Remake in OpenGL and C++","fork":false,"url":"https://api.github.com/repos/Palm-Studios/sh3redux","forks_url":"https://api.github.com/repos/Palm-Studios/sh3redux/forks","keys_url":"https://api.github.com/repos/Palm-Studios/sh3redux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Palm-Studios/sh3redux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Palm-Studios/sh3redux/teams","hooks_url":"https://api.github.com/repos/Palm-Studios/sh3redux/hooks","issue_events_url":"https://api.github.com/repos/Palm-Studios/sh3redux/issues/events{/number}","events_url":"https://api.github.com/repos/Palm-Studios/sh3redux/events","assignees_url":"https://api.github.com/repos/Palm-Studios/sh3redux/assignees{/user}","branches_url":"https://api.github.com/repos/Palm-Studios/sh3redux/branches{/branch}","tags_url":"https://api.github.com/repos/Palm-Studios/sh3redux/tags","blobs_url":"https://api.github.com/repos/Palm-Studios/sh3redux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Palm-Studios/sh3redux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Palm-Studios/sh3redux/git/refs{/sha}","trees_url":"https://api.github.com/repos/Palm-Studios/sh3redux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Palm-Studios/sh3redux/statuses/{sha}","languages_url":"https://api.github.com/repos/Palm-Studios/sh3redux/languages","stargazers_url":"https://api.github.com/repos/Palm-Studios/sh3redux/stargazers","contributors_url":"https://api.github.com/repos/Palm-Studios/sh3redux/contributors","subscribers_url":"https://api.github.com/repos/Palm-Studios/sh3redux/subscribers","subscription_url":"https://api.github.com/repos/Palm-Studios/sh3redux/subscription","commits_url":"https://api.github.com/repos/Palm-Studios/sh3redux/commits{/sha}","git_commits_url":"https://api.github.com/repos/Palm-Studios/sh3redux/git/commits{/sha}","comments_url":"https://api.github.com/repos/Palm-Studios/sh3redux/comments{/number}","issue_comment_url":"https://api.github.com/repos/Palm-Studios/sh3redux/issues/comments{/number}","contents_url":"https://api.github.com/repos/Palm-Studios/sh3redux/contents/{+path}","compare_url":"https://api.github.com/repos/Palm-Studios/sh3redux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Palm-Studios/sh3redux/merges","archive_url":"https://api.github.com/repos/Palm-Studios/sh3redux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Palm-Studios/sh3redux/downloads","issues_url":"https://api.github.com/repos/Palm-Studios/sh3redux/issues{/number}","pulls_url":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls{/number}","milestones_url":"https://api.github.com/repos/Palm-Studios/sh3redux/milestones{/number}","notifications_url":"https://api.github.com/repos/Palm-Studios/sh3redux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Palm-Studios/sh3redux/labels{/name}","releases_url":"https://api.github.com/repos/Palm-Studios/sh3redux/releases{/id}","deployments_url":"https://api.github.com/repos/Palm-Studios/sh3redux/deployments","created_at":"2016-12-10T14:13:46Z","updated_at":"2017-02-03T15:30:40Z","pushed_at":"2017-02-13T01:05:09Z","git_url":"git://github.com/Palm-Studios/sh3redux.git","ssh_url":"[email protected]:Palm-Studios/sh3redux.git","clone_url":"https://github.com/Palm-Studios/sh3redux.git","svn_url":"https://github.com/Palm-Studios/sh3redux","homepage":null,"size":14839,"stargazers_count":28,"watchers_count":28,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":12,"forks":6,"open_issues":12,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/83"},"html":{"href":"https://github.com/Palm-Studios/sh3redux/pull/83"},"issue":{"href":"https://api.github.com/repos/Palm-Studios/sh3redux/issues/83"},"comments":{"href":"https://api.github.com/repos/Palm-Studios/sh3redux/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Palm-Studios/sh3redux/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/Palm-Studios/sh3redux/statuses/22c7f31180451a47f409a711b6c0c8ee05a12999"}}}}
|
{
"id": 76116619,
"name": "Palm-Studios/sh3redux",
"url": "https://api.github.com/repos/Palm-Studios/sh3redux"
}
|
{
"id": 289819,
"login": "z33ky",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/289819?",
"url": "https://api.github.com/users/z33ky"
}
|
{
"id": 24369067,
"login": "Palm-Studios",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24369067?",
"url": "https://api.github.com/orgs/Palm-Studios"
}
| 2017-02-13T09:15:33 |
5312505879
|
{"actor":{"display_login":"z33ky"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments/145374305","pull_request_review_id":70163204,"id":145374305,"diff_hunk":"@@ -112,6 +76,8 @@ var/ert_request_answered = 0\n \n \t// Respawnable players get first dibs\n \tfor(var/mob/dead/observer/M in ert_candidates)\n+\t\tif(jobban_isbanned(M, ROLE_TRAITOR) || jobban_isbanned(M, \"Security Officer\") || jobban_isbanned(M, \"Captain\") || jobban_isbanned(M, \"Cyborg\"))","path":"code/game/response_team.dm","position":74,"original_position":74,"commit_id":"629acbf36d2a9f0e6f9b6377d8a9a059251ee739","original_commit_id":"9b7def1f8716d5906a95b46c164af3735d1b1fc3","user":{"login":"Birdtalon","id":25027759,"avatar_url":"https://avatars2.githubusercontent.com/u/25027759?v=4","gravatar_id":"","url":"https://api.github.com/users/Birdtalon","html_url":"https://github.com/Birdtalon","followers_url":"https://api.github.com/users/Birdtalon/followers","following_url":"https://api.github.com/users/Birdtalon/following{/other_user}","gists_url":"https://api.github.com/users/Birdtalon/gists{/gist_id}","starred_url":"https://api.github.com/users/Birdtalon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Birdtalon/subscriptions","organizations_url":"https://api.github.com/users/Birdtalon/orgs","repos_url":"https://api.github.com/users/Birdtalon/repos","events_url":"https://api.github.com/users/Birdtalon/events{/privacy}","received_events_url":"https://api.github.com/users/Birdtalon/received_events","type":"User","site_admin":false},"body":"Fair enough 👍 ","created_at":"2017-10-18T10:28:14Z","updated_at":"2017-10-18T10:28:14Z","html_url":"https://github.com/ParadiseSS13/Paradise/pull/8270#discussion_r145374305","pull_request_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/8270","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments/145374305"},"html":{"href":"https://github.com/ParadiseSS13/Paradise/pull/8270#discussion_r145374305"},"pull_request":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/8270"}},"in_reply_to_id":145337254},"pull_request":{"url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/8270","id":147220459,"html_url":"https://github.com/ParadiseSS13/Paradise/pull/8270","diff_url":"https://github.com/ParadiseSS13/Paradise/pull/8270.diff","patch_url":"https://github.com/ParadiseSS13/Paradise/pull/8270.patch","issue_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/8270","number":8270,"state":"open","locked":false,"title":"ERT Configuration","user":{"login":"Kyep","id":16434066,"avatar_url":"https://avatars0.githubusercontent.com/u/16434066?v=4","gravatar_id":"","url":"https://api.github.com/users/Kyep","html_url":"https://github.com/Kyep","followers_url":"https://api.github.com/users/Kyep/followers","following_url":"https://api.github.com/users/Kyep/following{/other_user}","gists_url":"https://api.github.com/users/Kyep/gists{/gist_id}","starred_url":"https://api.github.com/users/Kyep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kyep/subscriptions","organizations_url":"https://api.github.com/users/Kyep/orgs","repos_url":"https://api.github.com/users/Kyep/repos","events_url":"https://api.github.com/users/Kyep/events{/privacy}","received_events_url":"https://api.github.com/users/Kyep/received_events","type":"User","site_admin":false},"body":"🆑 Kyep\r\nadd: ERTs now support janitor, paranormal, and cyborg ERT units, as well as specific slot configurations.\r\n/🆑\r\n\r\nNew features:\r\n- ERT dispatch is now handled via a panel, rather than a series of prompts.\r\n- The dispatch window lets you set how many slots there should be of each class. So you can send an all-sec or all-medical or all-eng ERT if you want. Or mix up the types. You can also give people a mixture of type options.\r\n- The Janitor, Paranormal and Cyborg ERT types are now supported. All are disabled (no slots) by default. Sending Cyborgs in a Gamma ERT makes them into Gamma ERT borgs.\r\n- ERT no longer permits signups from job banned people.\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2017-10-18T06:46:24Z","updated_at":"2017-10-18T10:28:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c49e29327a440c0d114fc863162917a8500d9ec","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/8270/commits","review_comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/8270/comments","review_comment_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/8270/comments","statuses_url":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/629acbf36d2a9f0e6f9b6377d8a9a059251ee739","head":{"label":"Kyep:ert_slots","ref":"ert_slots","sha":"629acbf36d2a9f0e6f9b6377d8a9a059251ee739","user":{"login":"Kyep","id":16434066,"avatar_url":"https://avatars0.githubusercontent.com/u/16434066?v=4","gravatar_id":"","url":"https://api.github.com/users/Kyep","html_url":"https://github.com/Kyep","followers_url":"https://api.github.com/users/Kyep/followers","following_url":"https://api.github.com/users/Kyep/following{/other_user}","gists_url":"https://api.github.com/users/Kyep/gists{/gist_id}","starred_url":"https://api.github.com/users/Kyep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kyep/subscriptions","organizations_url":"https://api.github.com/users/Kyep/orgs","repos_url":"https://api.github.com/users/Kyep/repos","events_url":"https://api.github.com/users/Kyep/events{/privacy}","received_events_url":"https://api.github.com/users/Kyep/received_events","type":"User","site_admin":false},"repo":{"id":49868854,"name":"Paradise","full_name":"Kyep/Paradise","owner":{"login":"Kyep","id":16434066,"avatar_url":"https://avatars0.githubusercontent.com/u/16434066?v=4","gravatar_id":"","url":"https://api.github.com/users/Kyep","html_url":"https://github.com/Kyep","followers_url":"https://api.github.com/users/Kyep/followers","following_url":"https://api.github.com/users/Kyep/following{/other_user}","gists_url":"https://api.github.com/users/Kyep/gists{/gist_id}","starred_url":"https://api.github.com/users/Kyep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kyep/subscriptions","organizations_url":"https://api.github.com/users/Kyep/orgs","repos_url":"https://api.github.com/users/Kyep/repos","events_url":"https://api.github.com/users/Kyep/events{/privacy}","received_events_url":"https://api.github.com/users/Kyep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kyep/Paradise","description":"Paradise fork for submitting PRs","fork":true,"url":"https://api.github.com/repos/Kyep/Paradise","forks_url":"https://api.github.com/repos/Kyep/Paradise/forks","keys_url":"https://api.github.com/repos/Kyep/Paradise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kyep/Paradise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kyep/Paradise/teams","hooks_url":"https://api.github.com/repos/Kyep/Paradise/hooks","issue_events_url":"https://api.github.com/repos/Kyep/Paradise/issues/events{/number}","events_url":"https://api.github.com/repos/Kyep/Paradise/events","assignees_url":"https://api.github.com/repos/Kyep/Paradise/assignees{/user}","branches_url":"https://api.github.com/repos/Kyep/Paradise/branches{/branch}","tags_url":"https://api.github.com/repos/Kyep/Paradise/tags","blobs_url":"https://api.github.com/repos/Kyep/Paradise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kyep/Paradise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kyep/Paradise/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kyep/Paradise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kyep/Paradise/statuses/{sha}","languages_url":"https://api.github.com/repos/Kyep/Paradise/languages","stargazers_url":"https://api.github.com/repos/Kyep/Paradise/stargazers","contributors_url":"https://api.github.com/repos/Kyep/Paradise/contributors","subscribers_url":"https://api.github.com/repos/Kyep/Paradise/subscribers","subscription_url":"https://api.github.com/repos/Kyep/Paradise/subscription","commits_url":"https://api.github.com/repos/Kyep/Paradise/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kyep/Paradise/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kyep/Paradise/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kyep/Paradise/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kyep/Paradise/contents/{+path}","compare_url":"https://api.github.com/repos/Kyep/Paradise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kyep/Paradise/merges","archive_url":"https://api.github.com/repos/Kyep/Paradise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kyep/Paradise/downloads","issues_url":"https://api.github.com/repos/Kyep/Paradise/issues{/number}","pulls_url":"https://api.github.com/repos/Kyep/Paradise/pulls{/number}","milestones_url":"https://api.github.com/repos/Kyep/Paradise/milestones{/number}","notifications_url":"https://api.github.com/repos/Kyep/Paradise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kyep/Paradise/labels{/name}","releases_url":"https://api.github.com/repos/Kyep/Paradise/releases{/id}","deployments_url":"https://api.github.com/repos/Kyep/Paradise/deployments","created_at":"2016-01-18T10:15:30Z","updated_at":"2016-10-22T05:00:39Z","pushed_at":"2017-10-18T10:04:51Z","git_url":"git://github.com/Kyep/Paradise.git","ssh_url":"[email protected]:Kyep/Paradise.git","clone_url":"https://github.com/Kyep/Paradise.git","svn_url":"https://github.com/Kyep/Paradise","homepage":"http://nanotrasen.se/phpBB3/index.php","size":988493,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ParadiseSS13:master","ref":"master","sha":"8dbed0ede461fef777cd3eacee923912fce3f69e","user":{"login":"ParadiseSS13","id":9994901,"avatar_url":"https://avatars2.githubusercontent.com/u/9994901?v=4","gravatar_id":"","url":"https://api.github.com/users/ParadiseSS13","html_url":"https://github.com/ParadiseSS13","followers_url":"https://api.github.com/users/ParadiseSS13/followers","following_url":"https://api.github.com/users/ParadiseSS13/following{/other_user}","gists_url":"https://api.github.com/users/ParadiseSS13/gists{/gist_id}","starred_url":"https://api.github.com/users/ParadiseSS13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParadiseSS13/subscriptions","organizations_url":"https://api.github.com/users/ParadiseSS13/orgs","repos_url":"https://api.github.com/users/ParadiseSS13/repos","events_url":"https://api.github.com/users/ParadiseSS13/events{/privacy}","received_events_url":"https://api.github.com/users/ParadiseSS13/received_events","type":"Organization","site_admin":false},"repo":{"id":27286452,"name":"Paradise","full_name":"ParadiseSS13/Paradise","owner":{"login":"ParadiseSS13","id":9994901,"avatar_url":"https://avatars2.githubusercontent.com/u/9994901?v=4","gravatar_id":"","url":"https://api.github.com/users/ParadiseSS13","html_url":"https://github.com/ParadiseSS13","followers_url":"https://api.github.com/users/ParadiseSS13/followers","following_url":"https://api.github.com/users/ParadiseSS13/following{/other_user}","gists_url":"https://api.github.com/users/ParadiseSS13/gists{/gist_id}","starred_url":"https://api.github.com/users/ParadiseSS13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ParadiseSS13/subscriptions","organizations_url":"https://api.github.com/users/ParadiseSS13/orgs","repos_url":"https://api.github.com/users/ParadiseSS13/repos","events_url":"https://api.github.com/users/ParadiseSS13/events{/privacy}","received_events_url":"https://api.github.com/users/ParadiseSS13/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ParadiseSS13/Paradise","description":"Paradise Station's GitHub main repository.","fork":false,"url":"https://api.github.com/repos/ParadiseSS13/Paradise","forks_url":"https://api.github.com/repos/ParadiseSS13/Paradise/forks","keys_url":"https://api.github.com/repos/ParadiseSS13/Paradise/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ParadiseSS13/Paradise/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ParadiseSS13/Paradise/teams","hooks_url":"https://api.github.com/repos/ParadiseSS13/Paradise/hooks","issue_events_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/events{/number}","events_url":"https://api.github.com/repos/ParadiseSS13/Paradise/events","assignees_url":"https://api.github.com/repos/ParadiseSS13/Paradise/assignees{/user}","branches_url":"https://api.github.com/repos/ParadiseSS13/Paradise/branches{/branch}","tags_url":"https://api.github.com/repos/ParadiseSS13/Paradise/tags","blobs_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/refs{/sha}","trees_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/{sha}","languages_url":"https://api.github.com/repos/ParadiseSS13/Paradise/languages","stargazers_url":"https://api.github.com/repos/ParadiseSS13/Paradise/stargazers","contributors_url":"https://api.github.com/repos/ParadiseSS13/Paradise/contributors","subscribers_url":"https://api.github.com/repos/ParadiseSS13/Paradise/subscribers","subscription_url":"https://api.github.com/repos/ParadiseSS13/Paradise/subscription","commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/commits{/sha}","git_commits_url":"https://api.github.com/repos/ParadiseSS13/Paradise/git/commits{/sha}","comments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/comments{/number}","issue_comment_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/comments{/number}","contents_url":"https://api.github.com/repos/ParadiseSS13/Paradise/contents/{+path}","compare_url":"https://api.github.com/repos/ParadiseSS13/Paradise/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ParadiseSS13/Paradise/merges","archive_url":"https://api.github.com/repos/ParadiseSS13/Paradise/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ParadiseSS13/Paradise/downloads","issues_url":"https://api.github.com/repos/ParadiseSS13/Paradise/issues{/number}","pulls_url":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls{/number}","milestones_url":"https://api.github.com/repos/ParadiseSS13/Paradise/milestones{/number}","notifications_url":"https://api.github.com/repos/ParadiseSS13/Paradise/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ParadiseSS13/Paradise/labels{/name}","releases_url":"https://api.github.com/repos/ParadiseSS13/Paradise/releases{/id}","deployments_url":"https://api.github.com/repos/ParadiseSS13/Paradise/deployments","created_at":"2014-11-29T00:16:54Z","updated_at":"2017-10-15T18:32:29Z","pushed_at":"2017-10-18T10:04:53Z","git_url":"git://github.com/ParadiseSS13/Paradise.git","ssh_url":"[email protected]:ParadiseSS13/Paradise.git","clone_url":"https://github.com/ParadiseSS13/Paradise.git","svn_url":"https://github.com/ParadiseSS13/Paradise","homepage":"https://nanotrasen.se/forum/","size":987283,"stargazers_count":102,"watchers_count":102,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":339,"mirror_url":null,"open_issues_count":511,"forks":339,"open_issues":511,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/8270"},"html":{"href":"https://github.com/ParadiseSS13/Paradise/pull/8270"},"issue":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/8270"},"comments":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/issues/8270/comments"},"review_comments":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/8270/comments"},"review_comment":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/pulls/8270/commits"},"statuses":{"href":"https://api.github.com/repos/ParadiseSS13/Paradise/statuses/629acbf36d2a9f0e6f9b6377d8a9a059251ee739"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 27286452,
"name": "ParadiseSS13/Paradise",
"url": "https://api.github.com/repos/ParadiseSS13/Paradise"
}
|
{
"id": 25027759,
"login": "Birdtalon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25027759?",
"url": "https://api.github.com/users/Birdtalon"
}
|
{
"id": 9994901,
"login": "ParadiseSS13",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9994901?",
"url": "https://api.github.com/orgs/ParadiseSS13"
}
| 2017-10-18T10:28:14 |
6732189967
|
{"actor":{"display_login":"Birdtalon"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/comments/120880717","pull_request_review_id":42881819,"id":120880717,"diff_hunk":"@@ -0,0 +1,786 @@\n+#include \"engine/routing_algorithms/alternative_path.hpp\"\n+#include \"engine/routing_algorithms/routing_base_mld.hpp\"\n+\n+#include \"util/static_assert.hpp\"\n+\n+#include <boost/assert.hpp>\n+\n+#include <algorithm>\n+#include <iterator>\n+#include <memory>\n+#include <type_traits>\n+#include <unordered_set>\n+#include <utility>\n+#include <vector>\n+\n+#include <boost/function_output_iterator.hpp>\n+\n+// TODO: debug, remove\n+#include <iostream>\n+\n+namespace osrm\n+{\n+namespace engine\n+{\n+namespace routing_algorithms\n+{\n+\n+// Unqualified calls below are from the mld namespace.\n+// This alternative implementation works only for mld.\n+using namespace mld;\n+\n+using Heap = SearchEngineData<Algorithm>::QueryHeap;\n+using Partition = partition::MultiLevelPartitionView;\n+using Facade = datafacade::ContiguousInternalMemoryDataFacade<Algorithm>;\n+\n+// Implementation details\n+namespace\n+{\n+\n+// Alternative paths candidate via nodes are taken from overlapping search spaces.\n+// Overlapping by a third guarantees us taking candidate nodes \"from the middle\".\n+const constexpr auto kSearchSpaceOverlapFactor = 1.66;\n+// Maximum number of alternative paths to return.\n+const constexpr auto kMaxAlternatives = 3;","path":"src/engine/routing_algorithms/alternative_path_mld.cpp","position":null,"original_position":44,"commit_id":"ce0c165f338e390fc815db2726544ebc1698d294","original_commit_id":"7044cf937cd5901d1b1d3f8bafe8641a8010b1e5","user":{"login":"daniel-j-h","id":527241,"avatar_url":"https://avatars0.githubusercontent.com/u/527241?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-j-h","html_url":"https://github.com/daniel-j-h","followers_url":"https://api.github.com/users/daniel-j-h/followers","following_url":"https://api.github.com/users/daniel-j-h/following{/other_user}","gists_url":"https://api.github.com/users/daniel-j-h/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-j-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-j-h/subscriptions","organizations_url":"https://api.github.com/users/daniel-j-h/orgs","repos_url":"https://api.github.com/users/daniel-j-h/repos","events_url":"https://api.github.com/users/daniel-j-h/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-j-h/received_events","type":"User","site_admin":false},"body":"Not sure if it should be a query-time parameter but I can definitely see the point in exposing some knobs here in the profiles.","created_at":"2017-06-08T13:00:56Z","updated_at":"2017-06-08T13:00:56Z","html_url":"https://github.com/Project-OSRM/osrm-backend/pull/4047#discussion_r120880717","pull_request_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/4047","_links":{"self":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/comments/120880717"},"html":{"href":"https://github.com/Project-OSRM/osrm-backend/pull/4047#discussion_r120880717"},"pull_request":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/4047"}}},"pull_request":{"url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/4047","id":120649202,"html_url":"https://github.com/Project-OSRM/osrm-backend/pull/4047","diff_url":"https://github.com/Project-OSRM/osrm-backend/pull/4047.diff","patch_url":"https://github.com/Project-OSRM/osrm-backend/pull/4047.patch","issue_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/4047","number":4047,"state":"open","locked":false,"title":"Implements Reasonable Alternative Routes for MLD","user":{"login":"daniel-j-h","id":527241,"avatar_url":"https://avatars0.githubusercontent.com/u/527241?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-j-h","html_url":"https://github.com/daniel-j-h","followers_url":"https://api.github.com/users/daniel-j-h/followers","following_url":"https://api.github.com/users/daniel-j-h/following{/other_user}","gists_url":"https://api.github.com/users/daniel-j-h/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-j-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-j-h/subscriptions","organizations_url":"https://api.github.com/users/daniel-j-h/orgs","repos_url":"https://api.github.com/users/daniel-j-h/repos","events_url":"https://api.github.com/users/daniel-j-h/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-j-h/received_events","type":"User","site_admin":false},"body":"For https://github.com/Project-OSRM/osrm-backend/issues/3905. Implements reasonable alternatives using the via-method. See the ticket for details.\r\n\r\nWork in progress, nothing to see here yet.","created_at":"2017-05-15T17:05:23Z","updated_at":"2017-06-08T13:00:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f071290bb38676ceca212c1222b28493a55d955","assignee":{"login":"daniel-j-h","id":527241,"avatar_url":"https://avatars0.githubusercontent.com/u/527241?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-j-h","html_url":"https://github.com/daniel-j-h","followers_url":"https://api.github.com/users/daniel-j-h/followers","following_url":"https://api.github.com/users/daniel-j-h/following{/other_user}","gists_url":"https://api.github.com/users/daniel-j-h/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-j-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-j-h/subscriptions","organizations_url":"https://api.github.com/users/daniel-j-h/orgs","repos_url":"https://api.github.com/users/daniel-j-h/repos","events_url":"https://api.github.com/users/daniel-j-h/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-j-h/received_events","type":"User","site_admin":false},"assignees":[{"login":"daniel-j-h","id":527241,"avatar_url":"https://avatars0.githubusercontent.com/u/527241?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-j-h","html_url":"https://github.com/daniel-j-h","followers_url":"https://api.github.com/users/daniel-j-h/followers","following_url":"https://api.github.com/users/daniel-j-h/following{/other_user}","gists_url":"https://api.github.com/users/daniel-j-h/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-j-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-j-h/subscriptions","organizations_url":"https://api.github.com/users/daniel-j-h/orgs","repos_url":"https://api.github.com/users/daniel-j-h/repos","events_url":"https://api.github.com/users/daniel-j-h/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-j-h/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/Project-OSRM/osrm-backend/milestones/37","html_url":"https://github.com/Project-OSRM/osrm-backend/milestone/37","labels_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/milestones/37/labels","id":2500787,"number":37,"title":"5.9.0","description":null,"creator":{"login":"TheMarex","id":606968,"avatar_url":"https://avatars3.githubusercontent.com/u/606968?v=3","gravatar_id":"","url":"https://api.github.com/users/TheMarex","html_url":"https://github.com/TheMarex","followers_url":"https://api.github.com/users/TheMarex/followers","following_url":"https://api.github.com/users/TheMarex/following{/other_user}","gists_url":"https://api.github.com/users/TheMarex/gists{/gist_id}","starred_url":"https://api.github.com/users/TheMarex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheMarex/subscriptions","organizations_url":"https://api.github.com/users/TheMarex/orgs","repos_url":"https://api.github.com/users/TheMarex/repos","events_url":"https://api.github.com/users/TheMarex/events{/privacy}","received_events_url":"https://api.github.com/users/TheMarex/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":0,"state":"open","created_at":"2017-05-04T20:05:20Z","updated_at":"2017-05-15T17:05:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/4047/commits","review_comments_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/4047/comments","review_comment_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/4047/comments","statuses_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/statuses/ce0c165f338e390fc815db2726544ebc1698d294","head":{"label":"Project-OSRM:mld/alternatives","ref":"mld/alternatives","sha":"ce0c165f338e390fc815db2726544ebc1698d294","user":{"login":"Project-OSRM","id":8207060,"avatar_url":"https://avatars0.githubusercontent.com/u/8207060?v=3","gravatar_id":"","url":"https://api.github.com/users/Project-OSRM","html_url":"https://github.com/Project-OSRM","followers_url":"https://api.github.com/users/Project-OSRM/followers","following_url":"https://api.github.com/users/Project-OSRM/following{/other_user}","gists_url":"https://api.github.com/users/Project-OSRM/gists{/gist_id}","starred_url":"https://api.github.com/users/Project-OSRM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Project-OSRM/subscriptions","organizations_url":"https://api.github.com/users/Project-OSRM/orgs","repos_url":"https://api.github.com/users/Project-OSRM/repos","events_url":"https://api.github.com/users/Project-OSRM/events{/privacy}","received_events_url":"https://api.github.com/users/Project-OSRM/received_events","type":"Organization","site_admin":false},"repo":{"id":2436255,"name":"osrm-backend","full_name":"Project-OSRM/osrm-backend","owner":{"login":"Project-OSRM","id":8207060,"avatar_url":"https://avatars0.githubusercontent.com/u/8207060?v=3","gravatar_id":"","url":"https://api.github.com/users/Project-OSRM","html_url":"https://github.com/Project-OSRM","followers_url":"https://api.github.com/users/Project-OSRM/followers","following_url":"https://api.github.com/users/Project-OSRM/following{/other_user}","gists_url":"https://api.github.com/users/Project-OSRM/gists{/gist_id}","starred_url":"https://api.github.com/users/Project-OSRM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Project-OSRM/subscriptions","organizations_url":"https://api.github.com/users/Project-OSRM/orgs","repos_url":"https://api.github.com/users/Project-OSRM/repos","events_url":"https://api.github.com/users/Project-OSRM/events{/privacy}","received_events_url":"https://api.github.com/users/Project-OSRM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Project-OSRM/osrm-backend","description":"Open Source Routing Machine - C++ backend","fork":false,"url":"https://api.github.com/repos/Project-OSRM/osrm-backend","forks_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/forks","keys_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/teams","hooks_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/hooks","issue_events_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/events{/number}","events_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/events","assignees_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/assignees{/user}","branches_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/branches{/branch}","tags_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/tags","blobs_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/languages","stargazers_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/stargazers","contributors_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/contributors","subscribers_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/subscribers","subscription_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/subscription","commits_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/contents/{+path}","compare_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/merges","archive_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/downloads","issues_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues{/number}","pulls_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/labels{/name}","releases_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/releases{/id}","deployments_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/deployments","created_at":"2011-09-22T10:05:08Z","updated_at":"2017-06-08T08:21:51Z","pushed_at":"2017-06-08T12:58:25Z","git_url":"git://github.com/Project-OSRM/osrm-backend.git","ssh_url":"[email protected]:Project-OSRM/osrm-backend.git","clone_url":"https://github.com/Project-OSRM/osrm-backend.git","svn_url":"https://github.com/Project-OSRM/osrm-backend","homepage":"http://map.project-osrm.org","size":39267,"stargazers_count":1750,"watchers_count":1750,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":982,"mirror_url":null,"open_issues_count":371,"forks":982,"open_issues":371,"watchers":1750,"default_branch":"master"}},"base":{"label":"Project-OSRM:master","ref":"master","sha":"0d12d2fd285119861e8f8706ba86f2b62a79f882","user":{"login":"Project-OSRM","id":8207060,"avatar_url":"https://avatars0.githubusercontent.com/u/8207060?v=3","gravatar_id":"","url":"https://api.github.com/users/Project-OSRM","html_url":"https://github.com/Project-OSRM","followers_url":"https://api.github.com/users/Project-OSRM/followers","following_url":"https://api.github.com/users/Project-OSRM/following{/other_user}","gists_url":"https://api.github.com/users/Project-OSRM/gists{/gist_id}","starred_url":"https://api.github.com/users/Project-OSRM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Project-OSRM/subscriptions","organizations_url":"https://api.github.com/users/Project-OSRM/orgs","repos_url":"https://api.github.com/users/Project-OSRM/repos","events_url":"https://api.github.com/users/Project-OSRM/events{/privacy}","received_events_url":"https://api.github.com/users/Project-OSRM/received_events","type":"Organization","site_admin":false},"repo":{"id":2436255,"name":"osrm-backend","full_name":"Project-OSRM/osrm-backend","owner":{"login":"Project-OSRM","id":8207060,"avatar_url":"https://avatars0.githubusercontent.com/u/8207060?v=3","gravatar_id":"","url":"https://api.github.com/users/Project-OSRM","html_url":"https://github.com/Project-OSRM","followers_url":"https://api.github.com/users/Project-OSRM/followers","following_url":"https://api.github.com/users/Project-OSRM/following{/other_user}","gists_url":"https://api.github.com/users/Project-OSRM/gists{/gist_id}","starred_url":"https://api.github.com/users/Project-OSRM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Project-OSRM/subscriptions","organizations_url":"https://api.github.com/users/Project-OSRM/orgs","repos_url":"https://api.github.com/users/Project-OSRM/repos","events_url":"https://api.github.com/users/Project-OSRM/events{/privacy}","received_events_url":"https://api.github.com/users/Project-OSRM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Project-OSRM/osrm-backend","description":"Open Source Routing Machine - C++ backend","fork":false,"url":"https://api.github.com/repos/Project-OSRM/osrm-backend","forks_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/forks","keys_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/teams","hooks_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/hooks","issue_events_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/events{/number}","events_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/events","assignees_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/assignees{/user}","branches_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/branches{/branch}","tags_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/tags","blobs_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/statuses/{sha}","languages_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/languages","stargazers_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/stargazers","contributors_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/contributors","subscribers_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/subscribers","subscription_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/subscription","commits_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/contents/{+path}","compare_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/merges","archive_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/downloads","issues_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues{/number}","pulls_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls{/number}","milestones_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/milestones{/number}","notifications_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/labels{/name}","releases_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/releases{/id}","deployments_url":"https://api.github.com/repos/Project-OSRM/osrm-backend/deployments","created_at":"2011-09-22T10:05:08Z","updated_at":"2017-06-08T08:21:51Z","pushed_at":"2017-06-08T12:58:25Z","git_url":"git://github.com/Project-OSRM/osrm-backend.git","ssh_url":"[email protected]:Project-OSRM/osrm-backend.git","clone_url":"https://github.com/Project-OSRM/osrm-backend.git","svn_url":"https://github.com/Project-OSRM/osrm-backend","homepage":"http://map.project-osrm.org","size":39267,"stargazers_count":1750,"watchers_count":1750,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":982,"mirror_url":null,"open_issues_count":371,"forks":982,"open_issues":371,"watchers":1750,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/4047"},"html":{"href":"https://github.com/Project-OSRM/osrm-backend/pull/4047"},"issue":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/4047"},"comments":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/issues/4047/comments"},"review_comments":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/4047/comments"},"review_comment":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/pulls/4047/commits"},"statuses":{"href":"https://api.github.com/repos/Project-OSRM/osrm-backend/statuses/ce0c165f338e390fc815db2726544ebc1698d294"}}}}
|
{
"id": 2436255,
"name": "Project-OSRM/osrm-backend",
"url": "https://api.github.com/repos/Project-OSRM/osrm-backend"
}
|
{
"id": 527241,
"login": "daniel-j-h",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/527241?",
"url": "https://api.github.com/users/daniel-j-h"
}
|
{
"id": 8207060,
"login": "Project-OSRM",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8207060?",
"url": "https://api.github.com/orgs/Project-OSRM"
}
| 2017-06-08T13:00:56 |
6027080381
|
{"actor":{"display_login":"daniel-j-h"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/comments/152378221","pull_request_review_id":78229294,"id":152378221,"diff_hunk":"@@ -0,0 +1,66 @@\n+<?php\n+\n+namespace App\\Http\\Requests;\n+\n+use App\\Http\\Requests\\Request;\n+\n+class UserRequest extends Request\n+{\n+ /**\n+ * Determine if the user is authorized to make this request.\n+ *\n+ * @return bool\n+ */\n+ public function authorize()\n+ {\n+ return true;\n+ }\n+\n+ /**\n+ * Get the validation rules that apply to the request.\n+ *\n+ * @return array\n+ */\n+ public function rules()\n+ {\n+ switch($this->method())\n+ {\n+ case 'GET':\n+ case 'DELETE':\n+ {\n+ return [];\n+ }\n+ case 'POST':\n+ {\n+ return [\n+ 'nombre' => 'required|max:255',\n+ 'apellido' => 'required|max:255',\n+ 'usuario' => 'required|max:255',\n+ 'password' => 'required|max:255',\n+ // por el momento queda asi porque sino no deja cargar. 'admin' => 'required|max:1',","path":"app/Http/Requests/UserRequest.php","position":40,"original_position":40,"commit_id":"1905a0681902e617685bf4c55ccd4430ad0a4f51","original_commit_id":"1905a0681902e617685bf4c55ccd4430ad0a4f51","user":{"login":"ignaciojonas","id":874682,"avatar_url":"https://avatars3.githubusercontent.com/u/874682?v=4","gravatar_id":"","url":"https://api.github.com/users/ignaciojonas","html_url":"https://github.com/ignaciojonas","followers_url":"https://api.github.com/users/ignaciojonas/followers","following_url":"https://api.github.com/users/ignaciojonas/following{/other_user}","gists_url":"https://api.github.com/users/ignaciojonas/gists{/gist_id}","starred_url":"https://api.github.com/users/ignaciojonas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignaciojonas/subscriptions","organizations_url":"https://api.github.com/users/ignaciojonas/orgs","repos_url":"https://api.github.com/users/ignaciojonas/repos","events_url":"https://api.github.com/users/ignaciojonas/events{/privacy}","received_events_url":"https://api.github.com/users/ignaciojonas/received_events","type":"User","site_admin":false},"body":"Deberias agregar admin, quiza no required y por defaul seria false.","created_at":"2017-11-21T19:29:24Z","updated_at":"2017-11-21T19:33:21Z","html_url":"https://github.com/Unicen-Tupar/bomberos/pull/221#discussion_r152378221","pull_request_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/221","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/comments/152378221"},"html":{"href":"https://github.com/Unicen-Tupar/bomberos/pull/221#discussion_r152378221"},"pull_request":{"href":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/221"}}},"pull_request":{"url":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/221","id":153015575,"html_url":"https://github.com/Unicen-Tupar/bomberos/pull/221","diff_url":"https://github.com/Unicen-Tupar/bomberos/pull/221.diff","patch_url":"https://github.com/Unicen-Tupar/bomberos/pull/221.patch","issue_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/issues/221","number":221,"state":"open","locked":false,"title":"issue #176","user":{"login":"gaston0403","id":17991774,"avatar_url":"https://avatars1.githubusercontent.com/u/17991774?v=4","gravatar_id":"","url":"https://api.github.com/users/gaston0403","html_url":"https://github.com/gaston0403","followers_url":"https://api.github.com/users/gaston0403/followers","following_url":"https://api.github.com/users/gaston0403/following{/other_user}","gists_url":"https://api.github.com/users/gaston0403/gists{/gist_id}","starred_url":"https://api.github.com/users/gaston0403/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaston0403/subscriptions","organizations_url":"https://api.github.com/users/gaston0403/orgs","repos_url":"https://api.github.com/users/gaston0403/repos","events_url":"https://api.github.com/users/gaston0403/events{/privacy}","received_events_url":"https://api.github.com/users/gaston0403/received_events","type":"User","site_admin":false},"body":"Esta funcionando. Me queda implementar los test.","created_at":"2017-11-16T11:26:11Z","updated_at":"2017-11-21T19:33:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c193e4cb20048f790aaf60bae50c3948d47022ec","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/221/commits","review_comments_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/221/comments","review_comment_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/issues/221/comments","statuses_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/statuses/1905a0681902e617685bf4c55ccd4430ad0a4f51","head":{"label":"gaston0403:master","ref":"master","sha":"1905a0681902e617685bf4c55ccd4430ad0a4f51","user":{"login":"gaston0403","id":17991774,"avatar_url":"https://avatars1.githubusercontent.com/u/17991774?v=4","gravatar_id":"","url":"https://api.github.com/users/gaston0403","html_url":"https://github.com/gaston0403","followers_url":"https://api.github.com/users/gaston0403/followers","following_url":"https://api.github.com/users/gaston0403/following{/other_user}","gists_url":"https://api.github.com/users/gaston0403/gists{/gist_id}","starred_url":"https://api.github.com/users/gaston0403/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaston0403/subscriptions","organizations_url":"https://api.github.com/users/gaston0403/orgs","repos_url":"https://api.github.com/users/gaston0403/repos","events_url":"https://api.github.com/users/gaston0403/events{/privacy}","received_events_url":"https://api.github.com/users/gaston0403/received_events","type":"User","site_admin":false},"repo":{"id":105078534,"name":"bomberos","full_name":"gaston0403/bomberos","owner":{"login":"gaston0403","id":17991774,"avatar_url":"https://avatars1.githubusercontent.com/u/17991774?v=4","gravatar_id":"","url":"https://api.github.com/users/gaston0403","html_url":"https://github.com/gaston0403","followers_url":"https://api.github.com/users/gaston0403/followers","following_url":"https://api.github.com/users/gaston0403/following{/other_user}","gists_url":"https://api.github.com/users/gaston0403/gists{/gist_id}","starred_url":"https://api.github.com/users/gaston0403/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaston0403/subscriptions","organizations_url":"https://api.github.com/users/gaston0403/orgs","repos_url":"https://api.github.com/users/gaston0403/repos","events_url":"https://api.github.com/users/gaston0403/events{/privacy}","received_events_url":"https://api.github.com/users/gaston0403/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gaston0403/bomberos","description":null,"fork":true,"url":"https://api.github.com/repos/gaston0403/bomberos","forks_url":"https://api.github.com/repos/gaston0403/bomberos/forks","keys_url":"https://api.github.com/repos/gaston0403/bomberos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gaston0403/bomberos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gaston0403/bomberos/teams","hooks_url":"https://api.github.com/repos/gaston0403/bomberos/hooks","issue_events_url":"https://api.github.com/repos/gaston0403/bomberos/issues/events{/number}","events_url":"https://api.github.com/repos/gaston0403/bomberos/events","assignees_url":"https://api.github.com/repos/gaston0403/bomberos/assignees{/user}","branches_url":"https://api.github.com/repos/gaston0403/bomberos/branches{/branch}","tags_url":"https://api.github.com/repos/gaston0403/bomberos/tags","blobs_url":"https://api.github.com/repos/gaston0403/bomberos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gaston0403/bomberos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gaston0403/bomberos/git/refs{/sha}","trees_url":"https://api.github.com/repos/gaston0403/bomberos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gaston0403/bomberos/statuses/{sha}","languages_url":"https://api.github.com/repos/gaston0403/bomberos/languages","stargazers_url":"https://api.github.com/repos/gaston0403/bomberos/stargazers","contributors_url":"https://api.github.com/repos/gaston0403/bomberos/contributors","subscribers_url":"https://api.github.com/repos/gaston0403/bomberos/subscribers","subscription_url":"https://api.github.com/repos/gaston0403/bomberos/subscription","commits_url":"https://api.github.com/repos/gaston0403/bomberos/commits{/sha}","git_commits_url":"https://api.github.com/repos/gaston0403/bomberos/git/commits{/sha}","comments_url":"https://api.github.com/repos/gaston0403/bomberos/comments{/number}","issue_comment_url":"https://api.github.com/repos/gaston0403/bomberos/issues/comments{/number}","contents_url":"https://api.github.com/repos/gaston0403/bomberos/contents/{+path}","compare_url":"https://api.github.com/repos/gaston0403/bomberos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gaston0403/bomberos/merges","archive_url":"https://api.github.com/repos/gaston0403/bomberos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gaston0403/bomberos/downloads","issues_url":"https://api.github.com/repos/gaston0403/bomberos/issues{/number}","pulls_url":"https://api.github.com/repos/gaston0403/bomberos/pulls{/number}","milestones_url":"https://api.github.com/repos/gaston0403/bomberos/milestones{/number}","notifications_url":"https://api.github.com/repos/gaston0403/bomberos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gaston0403/bomberos/labels{/name}","releases_url":"https://api.github.com/repos/gaston0403/bomberos/releases{/id}","deployments_url":"https://api.github.com/repos/gaston0403/bomberos/deployments","created_at":"2017-09-27T23:09:36Z","updated_at":"2017-09-27T23:09:37Z","pushed_at":"2017-11-15T00:04:40Z","git_url":"git://github.com/gaston0403/bomberos.git","ssh_url":"[email protected]:gaston0403/bomberos.git","clone_url":"https://github.com/gaston0403/bomberos.git","svn_url":"https://github.com/gaston0403/bomberos","homepage":null,"size":9213,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Unicen-Tupar:master","ref":"master","sha":"9ee56d47cd15de3554387b2f31031a1fe37a5094","user":{"login":"Unicen-Tupar","id":4358026,"avatar_url":"https://avatars3.githubusercontent.com/u/4358026?v=4","gravatar_id":"","url":"https://api.github.com/users/Unicen-Tupar","html_url":"https://github.com/Unicen-Tupar","followers_url":"https://api.github.com/users/Unicen-Tupar/followers","following_url":"https://api.github.com/users/Unicen-Tupar/following{/other_user}","gists_url":"https://api.github.com/users/Unicen-Tupar/gists{/gist_id}","starred_url":"https://api.github.com/users/Unicen-Tupar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unicen-Tupar/subscriptions","organizations_url":"https://api.github.com/users/Unicen-Tupar/orgs","repos_url":"https://api.github.com/users/Unicen-Tupar/repos","events_url":"https://api.github.com/users/Unicen-Tupar/events{/privacy}","received_events_url":"https://api.github.com/users/Unicen-Tupar/received_events","type":"Organization","site_admin":false},"repo":{"id":59577512,"name":"bomberos","full_name":"Unicen-Tupar/bomberos","owner":{"login":"Unicen-Tupar","id":4358026,"avatar_url":"https://avatars3.githubusercontent.com/u/4358026?v=4","gravatar_id":"","url":"https://api.github.com/users/Unicen-Tupar","html_url":"https://github.com/Unicen-Tupar","followers_url":"https://api.github.com/users/Unicen-Tupar/followers","following_url":"https://api.github.com/users/Unicen-Tupar/following{/other_user}","gists_url":"https://api.github.com/users/Unicen-Tupar/gists{/gist_id}","starred_url":"https://api.github.com/users/Unicen-Tupar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unicen-Tupar/subscriptions","organizations_url":"https://api.github.com/users/Unicen-Tupar/orgs","repos_url":"https://api.github.com/users/Unicen-Tupar/repos","events_url":"https://api.github.com/users/Unicen-Tupar/events{/privacy}","received_events_url":"https://api.github.com/users/Unicen-Tupar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unicen-Tupar/bomberos","description":null,"fork":false,"url":"https://api.github.com/repos/Unicen-Tupar/bomberos","forks_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/forks","keys_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/teams","hooks_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/hooks","issue_events_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/issues/events{/number}","events_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/events","assignees_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/assignees{/user}","branches_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/branches{/branch}","tags_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/tags","blobs_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/statuses/{sha}","languages_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/languages","stargazers_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/stargazers","contributors_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/contributors","subscribers_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/subscribers","subscription_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/subscription","commits_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/contents/{+path}","compare_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/merges","archive_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/downloads","issues_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/issues{/number}","pulls_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls{/number}","milestones_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/milestones{/number}","notifications_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/labels{/name}","releases_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/releases{/id}","deployments_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/deployments","created_at":"2016-05-24T13:53:15Z","updated_at":"2017-09-05T21:15:28Z","pushed_at":"2017-11-21T17:52:23Z","git_url":"git://github.com/Unicen-Tupar/bomberos.git","ssh_url":"[email protected]:Unicen-Tupar/bomberos.git","clone_url":"https://github.com/Unicen-Tupar/bomberos.git","svn_url":"https://github.com/Unicen-Tupar/bomberos","homepage":null,"size":9210,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":35,"forks":8,"open_issues":35,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/221"},"html":{"href":"https://github.com/Unicen-Tupar/bomberos/pull/221"},"issue":{"href":"https://api.github.com/repos/Unicen-Tupar/bomberos/issues/221"},"comments":{"href":"https://api.github.com/repos/Unicen-Tupar/bomberos/issues/221/comments"},"review_comments":{"href":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/221/comments"},"review_comment":{"href":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/221/commits"},"statuses":{"href":"https://api.github.com/repos/Unicen-Tupar/bomberos/statuses/1905a0681902e617685bf4c55ccd4430ad0a4f51"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 59577512,
"name": "Unicen-Tupar/bomberos",
"url": "https://api.github.com/repos/Unicen-Tupar/bomberos"
}
|
{
"id": 874682,
"login": "ignaciojonas",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/874682?",
"url": "https://api.github.com/users/ignaciojonas"
}
|
{
"id": 4358026,
"login": "Unicen-Tupar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4358026?",
"url": "https://api.github.com/orgs/Unicen-Tupar"
}
| 2017-11-21T19:29:24 |
6886458875
|
{"actor":{"display_login":"ignaciojonas"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/api-platform/core/pulls/comments/115928794","pull_request_review_id":37508444,"id":115928794,"diff_hunk":"@@ -0,0 +1,90 @@\n+<?php\n+\n+/*\n+ * This file is part of the API Platform project.\n+ *\n+ * (c) Kévin Dunglas <[email protected]>\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+declare(strict_types=1);\n+\n+namespace ApiPlatform\\Core\\Serializer\\Filter;\n+\n+use Symfony\\Component\\HttpFoundation\\Request;\n+\n+/**\n+ * Group filter.\n+ *\n+ * @author Baptiste Meyer <[email protected]>\n+ */\n+class GroupFilter implements FilterInterface\n+{\n+ protected $overrideDefaultGroups;","path":"src/Serializer/Filter/GroupFilter.php","position":25,"original_position":25,"commit_id":"9694e5807cee10200f3d45f8bf154da16db7f29d","original_commit_id":"9694e5807cee10200f3d45f8bf154da16db7f29d","user":{"login":"dunglas","id":57224,"avatar_url":"https://avatars1.githubusercontent.com/u/57224?v=3","gravatar_id":"","url":"https://api.github.com/users/dunglas","html_url":"https://github.com/dunglas","followers_url":"https://api.github.com/users/dunglas/followers","following_url":"https://api.github.com/users/dunglas/following{/other_user}","gists_url":"https://api.github.com/users/dunglas/gists{/gist_id}","starred_url":"https://api.github.com/users/dunglas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dunglas/subscriptions","organizations_url":"https://api.github.com/users/dunglas/orgs","repos_url":"https://api.github.com/users/dunglas/repos","events_url":"https://api.github.com/users/dunglas/events{/privacy}","received_events_url":"https://api.github.com/users/dunglas/received_events","type":"User","site_admin":false},"body":"`private`","created_at":"2017-05-11T08:13:15Z","updated_at":"2017-05-11T08:17:10Z","html_url":"https://github.com/api-platform/core/pull/1111#discussion_r115928794","pull_request_url":"https://api.github.com/repos/api-platform/core/pulls/1111","_links":{"self":{"href":"https://api.github.com/repos/api-platform/core/pulls/comments/115928794"},"html":{"href":"https://github.com/api-platform/core/pull/1111#discussion_r115928794"},"pull_request":{"href":"https://api.github.com/repos/api-platform/core/pulls/1111"}}},"pull_request":{"url":"https://api.github.com/repos/api-platform/core/pulls/1111","id":119905666,"html_url":"https://github.com/api-platform/core/pull/1111","diff_url":"https://github.com/api-platform/core/pull/1111.diff","patch_url":"https://github.com/api-platform/core/pull/1111.patch","issue_url":"https://api.github.com/repos/api-platform/core/issues/1111","number":1111,"state":"open","locked":false,"title":"Add a filter for serialization groups","user":{"login":"meyerbaptiste","id":4034907,"avatar_url":"https://avatars2.githubusercontent.com/u/4034907?v=3","gravatar_id":"","url":"https://api.github.com/users/meyerbaptiste","html_url":"https://github.com/meyerbaptiste","followers_url":"https://api.github.com/users/meyerbaptiste/followers","following_url":"https://api.github.com/users/meyerbaptiste/following{/other_user}","gists_url":"https://api.github.com/users/meyerbaptiste/gists{/gist_id}","starred_url":"https://api.github.com/users/meyerbaptiste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meyerbaptiste/subscriptions","organizations_url":"https://api.github.com/users/meyerbaptiste/orgs","repos_url":"https://api.github.com/users/meyerbaptiste/repos","events_url":"https://api.github.com/users/meyerbaptiste/events{/privacy}","received_events_url":"https://api.github.com/users/meyerbaptiste/received_events","type":"User","site_admin":false},"body":"| Q | A\r\n| ------------- | ---\r\n| Bug fix? | no\r\n| New feature? | yes\r\n| BC breaks? | no\r\n| Deprecations? | no\r\n| Tests pass? | not yet\r\n| Fixed tickets | #1082 \r\n| License | MIT\r\n| Doc PR | N/A\r\n","created_at":"2017-05-10T15:02:37Z","updated_at":"2017-05-11T08:17:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40eba0706abc0cccbaf94a113dee1145c0c594a4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/api-platform/core/pulls/1111/commits","review_comments_url":"https://api.github.com/repos/api-platform/core/pulls/1111/comments","review_comment_url":"https://api.github.com/repos/api-platform/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/api-platform/core/issues/1111/comments","statuses_url":"https://api.github.com/repos/api-platform/core/statuses/9694e5807cee10200f3d45f8bf154da16db7f29d","head":{"label":"meyerbaptiste:add_group_filter","ref":"add_group_filter","sha":"9694e5807cee10200f3d45f8bf154da16db7f29d","user":{"login":"meyerbaptiste","id":4034907,"avatar_url":"https://avatars2.githubusercontent.com/u/4034907?v=3","gravatar_id":"","url":"https://api.github.com/users/meyerbaptiste","html_url":"https://github.com/meyerbaptiste","followers_url":"https://api.github.com/users/meyerbaptiste/followers","following_url":"https://api.github.com/users/meyerbaptiste/following{/other_user}","gists_url":"https://api.github.com/users/meyerbaptiste/gists{/gist_id}","starred_url":"https://api.github.com/users/meyerbaptiste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meyerbaptiste/subscriptions","organizations_url":"https://api.github.com/users/meyerbaptiste/orgs","repos_url":"https://api.github.com/users/meyerbaptiste/repos","events_url":"https://api.github.com/users/meyerbaptiste/events{/privacy}","received_events_url":"https://api.github.com/users/meyerbaptiste/received_events","type":"User","site_admin":false},"repo":{"id":68818371,"name":"core","full_name":"meyerbaptiste/core","owner":{"login":"meyerbaptiste","id":4034907,"avatar_url":"https://avatars2.githubusercontent.com/u/4034907?v=3","gravatar_id":"","url":"https://api.github.com/users/meyerbaptiste","html_url":"https://github.com/meyerbaptiste","followers_url":"https://api.github.com/users/meyerbaptiste/followers","following_url":"https://api.github.com/users/meyerbaptiste/following{/other_user}","gists_url":"https://api.github.com/users/meyerbaptiste/gists{/gist_id}","starred_url":"https://api.github.com/users/meyerbaptiste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meyerbaptiste/subscriptions","organizations_url":"https://api.github.com/users/meyerbaptiste/orgs","repos_url":"https://api.github.com/users/meyerbaptiste/repos","events_url":"https://api.github.com/users/meyerbaptiste/events{/privacy}","received_events_url":"https://api.github.com/users/meyerbaptiste/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meyerbaptiste/core","description":"The Hypermedia REST API component of API Platform: JSON-LD and Hydra support, works with Symfony too","fork":true,"url":"https://api.github.com/repos/meyerbaptiste/core","forks_url":"https://api.github.com/repos/meyerbaptiste/core/forks","keys_url":"https://api.github.com/repos/meyerbaptiste/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meyerbaptiste/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meyerbaptiste/core/teams","hooks_url":"https://api.github.com/repos/meyerbaptiste/core/hooks","issue_events_url":"https://api.github.com/repos/meyerbaptiste/core/issues/events{/number}","events_url":"https://api.github.com/repos/meyerbaptiste/core/events","assignees_url":"https://api.github.com/repos/meyerbaptiste/core/assignees{/user}","branches_url":"https://api.github.com/repos/meyerbaptiste/core/branches{/branch}","tags_url":"https://api.github.com/repos/meyerbaptiste/core/tags","blobs_url":"https://api.github.com/repos/meyerbaptiste/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meyerbaptiste/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meyerbaptiste/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/meyerbaptiste/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meyerbaptiste/core/statuses/{sha}","languages_url":"https://api.github.com/repos/meyerbaptiste/core/languages","stargazers_url":"https://api.github.com/repos/meyerbaptiste/core/stargazers","contributors_url":"https://api.github.com/repos/meyerbaptiste/core/contributors","subscribers_url":"https://api.github.com/repos/meyerbaptiste/core/subscribers","subscription_url":"https://api.github.com/repos/meyerbaptiste/core/subscription","commits_url":"https://api.github.com/repos/meyerbaptiste/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/meyerbaptiste/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/meyerbaptiste/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/meyerbaptiste/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/meyerbaptiste/core/contents/{+path}","compare_url":"https://api.github.com/repos/meyerbaptiste/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meyerbaptiste/core/merges","archive_url":"https://api.github.com/repos/meyerbaptiste/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meyerbaptiste/core/downloads","issues_url":"https://api.github.com/repos/meyerbaptiste/core/issues{/number}","pulls_url":"https://api.github.com/repos/meyerbaptiste/core/pulls{/number}","milestones_url":"https://api.github.com/repos/meyerbaptiste/core/milestones{/number}","notifications_url":"https://api.github.com/repos/meyerbaptiste/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meyerbaptiste/core/labels{/name}","releases_url":"https://api.github.com/repos/meyerbaptiste/core/releases{/id}","deployments_url":"https://api.github.com/repos/meyerbaptiste/core/deployments","created_at":"2016-09-21T13:14:50Z","updated_at":"2016-09-21T13:14:52Z","pushed_at":"2017-05-10T15:56:57Z","git_url":"git://github.com/meyerbaptiste/core.git","ssh_url":"[email protected]:meyerbaptiste/core.git","clone_url":"https://github.com/meyerbaptiste/core.git","svn_url":"https://github.com/meyerbaptiste/core","homepage":"https://api-platform.com","size":4456,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"api-platform:master","ref":"master","sha":"7dfdcb1715210f12160919d92975e15d8da7e81f","user":{"login":"api-platform","id":13420081,"avatar_url":"https://avatars0.githubusercontent.com/u/13420081?v=3","gravatar_id":"","url":"https://api.github.com/users/api-platform","html_url":"https://github.com/api-platform","followers_url":"https://api.github.com/users/api-platform/followers","following_url":"https://api.github.com/users/api-platform/following{/other_user}","gists_url":"https://api.github.com/users/api-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/api-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/api-platform/subscriptions","organizations_url":"https://api.github.com/users/api-platform/orgs","repos_url":"https://api.github.com/users/api-platform/repos","events_url":"https://api.github.com/users/api-platform/events{/privacy}","received_events_url":"https://api.github.com/users/api-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":29501260,"name":"core","full_name":"api-platform/core","owner":{"login":"api-platform","id":13420081,"avatar_url":"https://avatars0.githubusercontent.com/u/13420081?v=3","gravatar_id":"","url":"https://api.github.com/users/api-platform","html_url":"https://github.com/api-platform","followers_url":"https://api.github.com/users/api-platform/followers","following_url":"https://api.github.com/users/api-platform/following{/other_user}","gists_url":"https://api.github.com/users/api-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/api-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/api-platform/subscriptions","organizations_url":"https://api.github.com/users/api-platform/orgs","repos_url":"https://api.github.com/users/api-platform/repos","events_url":"https://api.github.com/users/api-platform/events{/privacy}","received_events_url":"https://api.github.com/users/api-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/api-platform/core","description":"The Hypermedia REST API component of API Platform: JSON-LD and Hydra support, works with Symfony too","fork":false,"url":"https://api.github.com/repos/api-platform/core","forks_url":"https://api.github.com/repos/api-platform/core/forks","keys_url":"https://api.github.com/repos/api-platform/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/api-platform/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/api-platform/core/teams","hooks_url":"https://api.github.com/repos/api-platform/core/hooks","issue_events_url":"https://api.github.com/repos/api-platform/core/issues/events{/number}","events_url":"https://api.github.com/repos/api-platform/core/events","assignees_url":"https://api.github.com/repos/api-platform/core/assignees{/user}","branches_url":"https://api.github.com/repos/api-platform/core/branches{/branch}","tags_url":"https://api.github.com/repos/api-platform/core/tags","blobs_url":"https://api.github.com/repos/api-platform/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/api-platform/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/api-platform/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/api-platform/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/api-platform/core/statuses/{sha}","languages_url":"https://api.github.com/repos/api-platform/core/languages","stargazers_url":"https://api.github.com/repos/api-platform/core/stargazers","contributors_url":"https://api.github.com/repos/api-platform/core/contributors","subscribers_url":"https://api.github.com/repos/api-platform/core/subscribers","subscription_url":"https://api.github.com/repos/api-platform/core/subscription","commits_url":"https://api.github.com/repos/api-platform/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/api-platform/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/api-platform/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/api-platform/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/api-platform/core/contents/{+path}","compare_url":"https://api.github.com/repos/api-platform/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/api-platform/core/merges","archive_url":"https://api.github.com/repos/api-platform/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/api-platform/core/downloads","issues_url":"https://api.github.com/repos/api-platform/core/issues{/number}","pulls_url":"https://api.github.com/repos/api-platform/core/pulls{/number}","milestones_url":"https://api.github.com/repos/api-platform/core/milestones{/number}","notifications_url":"https://api.github.com/repos/api-platform/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/api-platform/core/labels{/name}","releases_url":"https://api.github.com/repos/api-platform/core/releases{/id}","deployments_url":"https://api.github.com/repos/api-platform/core/deployments","created_at":"2015-01-19T23:05:56Z","updated_at":"2017-05-10T12:14:49Z","pushed_at":"2017-05-11T08:08:07Z","git_url":"git://github.com/api-platform/core.git","ssh_url":"[email protected]:api-platform/core.git","clone_url":"https://github.com/api-platform/core.git","svn_url":"https://github.com/api-platform/core","homepage":"https://api-platform.com","size":4431,"stargazers_count":428,"watchers_count":428,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":129,"mirror_url":null,"open_issues_count":114,"forks":129,"open_issues":114,"watchers":428,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/api-platform/core/pulls/1111"},"html":{"href":"https://github.com/api-platform/core/pull/1111"},"issue":{"href":"https://api.github.com/repos/api-platform/core/issues/1111"},"comments":{"href":"https://api.github.com/repos/api-platform/core/issues/1111/comments"},"review_comments":{"href":"https://api.github.com/repos/api-platform/core/pulls/1111/comments"},"review_comment":{"href":"https://api.github.com/repos/api-platform/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/api-platform/core/pulls/1111/commits"},"statuses":{"href":"https://api.github.com/repos/api-platform/core/statuses/9694e5807cee10200f3d45f8bf154da16db7f29d"}}}}
|
{
"id": 29501260,
"name": "api-platform/core",
"url": "https://api.github.com/repos/api-platform/core"
}
|
{
"id": 57224,
"login": "dunglas",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/57224?",
"url": "https://api.github.com/users/dunglas"
}
|
{
"id": 13420081,
"login": "api-platform",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13420081?",
"url": "https://api.github.com/orgs/api-platform"
}
| 2017-05-11T08:13:15 |
5851305641
|
{"actor":{"display_login":"dunglas"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/appcelerator/amp/pulls/comments/97435319","pull_request_review_id":18045009,"id":97435319,"diff_hunk":"@@ -0,0 +1,37 @@\n+# dind\n+\n+[On Docker Hub](https://hub.docker.com/r/subfuzion/dind/). Cloned from [subfuzion/docker-dind](https://github.com/subfuzion/docker-dind).\n+Convenience image based on latest Docker in Docker with experimental flag set and\n+a few network utilities (like iproute2, dig and drill).\n+\n+Why is this useful? Right now if you want to start dind with the experimental flag\n+you have to explicitly supply it as follows:\n+\n+ $ docker run --detach --privileged --name=dind docker:dind --experimental\n+ $ docker exec -it dind sh\n+ / # docker version\n+ Client:\n+ Version: 1.13.0\n+ API version: 1.25\n+ Go version: go1.7.3\n+ Git commit: 49bf474\n+ Built: Wed Jan 18 16:20:26 2017\n+ OS/Arch: linux/amd64\n+\n+ Server:\n+ Version: 1.13.0\n+ API version: 1.25 (minimum version 1.12)\n+ Go version: go1.7.3\n+ Git commit: 49bf474\n+ Built: Wed Jan 18 16:20:26 2017\n+ OS/Arch: linux/amd64\n+ Experimental: true\n+\n+You can see from the last line that the daemon was started in experimental mode.\n+With this image, however, experimental mode is the default:\n+\n+ $ docker run --detach --privileged --name=dind subfuzion:dind","path":"images/dind/README.md","position":33,"original_position":33,"commit_id":"b32c9d1876e8b128ba03cd271098994c547dd3d4","original_commit_id":"b32c9d1876e8b128ba03cd271098994c547dd3d4","user":{"login":"ndegory","id":11839374,"avatar_url":"https://avatars.githubusercontent.com/u/11839374?v=3","gravatar_id":"","url":"https://api.github.com/users/ndegory","html_url":"https://github.com/ndegory","followers_url":"https://api.github.com/users/ndegory/followers","following_url":"https://api.github.com/users/ndegory/following{/other_user}","gists_url":"https://api.github.com/users/ndegory/gists{/gist_id}","starred_url":"https://api.github.com/users/ndegory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndegory/subscriptions","organizations_url":"https://api.github.com/users/ndegory/orgs","repos_url":"https://api.github.com/users/ndegory/repos","events_url":"https://api.github.com/users/ndegory/events{/privacy}","received_events_url":"https://api.github.com/users/ndegory/received_events","type":"User","site_admin":false},"body":"and change the cmd to use appcelerator/dind instead of subfuzion:dind","created_at":"2017-01-23T22:47:07Z","updated_at":"2017-01-23T22:47:30Z","html_url":"https://github.com/appcelerator/amp/pull/706#discussion_r97435319","pull_request_url":"https://api.github.com/repos/appcelerator/amp/pulls/706","_links":{"self":{"href":"https://api.github.com/repos/appcelerator/amp/pulls/comments/97435319"},"html":{"href":"https://github.com/appcelerator/amp/pull/706#discussion_r97435319"},"pull_request":{"href":"https://api.github.com/repos/appcelerator/amp/pulls/706"}}},"pull_request":{"url":"https://api.github.com/repos/appcelerator/amp/pulls/706","id":102805868,"html_url":"https://github.com/appcelerator/amp/pull/706","diff_url":"https://github.com/appcelerator/amp/pull/706.diff","patch_url":"https://github.com/appcelerator/amp/pull/706.patch","issue_url":"https://api.github.com/repos/appcelerator/amp/issues/706","number":706,"state":"open","locked":false,"title":"docker-dind","user":{"login":"subfuzion","id":159738,"avatar_url":"https://avatars.githubusercontent.com/u/159738?v=3","gravatar_id":"","url":"https://api.github.com/users/subfuzion","html_url":"https://github.com/subfuzion","followers_url":"https://api.github.com/users/subfuzion/followers","following_url":"https://api.github.com/users/subfuzion/following{/other_user}","gists_url":"https://api.github.com/users/subfuzion/gists{/gist_id}","starred_url":"https://api.github.com/users/subfuzion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/subfuzion/subscriptions","organizations_url":"https://api.github.com/users/subfuzion/orgs","repos_url":"https://api.github.com/users/subfuzion/repos","events_url":"https://api.github.com/users/subfuzion/events{/privacy}","received_events_url":"https://api.github.com/users/subfuzion/received_events","type":"User","site_admin":false},"body":"Convenience image based on latest Docker in Docker with experimental flag set and a few network utilities (like iproute2, dig and drill).","created_at":"2017-01-23T21:37:57Z","updated_at":"2017-01-23T22:47:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec697250dae44768411bc133e720d387c380f688","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/appcelerator/amp/pulls/706/commits","review_comments_url":"https://api.github.com/repos/appcelerator/amp/pulls/706/comments","review_comment_url":"https://api.github.com/repos/appcelerator/amp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appcelerator/amp/issues/706/comments","statuses_url":"https://api.github.com/repos/appcelerator/amp/statuses/b32c9d1876e8b128ba03cd271098994c547dd3d4","head":{"label":"appcelerator:dind","ref":"dind","sha":"b32c9d1876e8b128ba03cd271098994c547dd3d4","user":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars.githubusercontent.com/u/82188?v=3","gravatar_id":"","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"repo":{"id":61302197,"name":"amp","full_name":"appcelerator/amp","owner":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars.githubusercontent.com/u/82188?v=3","gravatar_id":"","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appcelerator/amp","description":"AMP - an open source unified CaaS / FaaS platform for Docker","fork":false,"url":"https://api.github.com/repos/appcelerator/amp","forks_url":"https://api.github.com/repos/appcelerator/amp/forks","keys_url":"https://api.github.com/repos/appcelerator/amp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appcelerator/amp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appcelerator/amp/teams","hooks_url":"https://api.github.com/repos/appcelerator/amp/hooks","issue_events_url":"https://api.github.com/repos/appcelerator/amp/issues/events{/number}","events_url":"https://api.github.com/repos/appcelerator/amp/events","assignees_url":"https://api.github.com/repos/appcelerator/amp/assignees{/user}","branches_url":"https://api.github.com/repos/appcelerator/amp/branches{/branch}","tags_url":"https://api.github.com/repos/appcelerator/amp/tags","blobs_url":"https://api.github.com/repos/appcelerator/amp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appcelerator/amp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appcelerator/amp/git/refs{/sha}","trees_url":"https://api.github.com/repos/appcelerator/amp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appcelerator/amp/statuses/{sha}","languages_url":"https://api.github.com/repos/appcelerator/amp/languages","stargazers_url":"https://api.github.com/repos/appcelerator/amp/stargazers","contributors_url":"https://api.github.com/repos/appcelerator/amp/contributors","subscribers_url":"https://api.github.com/repos/appcelerator/amp/subscribers","subscription_url":"https://api.github.com/repos/appcelerator/amp/subscription","commits_url":"https://api.github.com/repos/appcelerator/amp/commits{/sha}","git_commits_url":"https://api.github.com/repos/appcelerator/amp/git/commits{/sha}","comments_url":"https://api.github.com/repos/appcelerator/amp/comments{/number}","issue_comment_url":"https://api.github.com/repos/appcelerator/amp/issues/comments{/number}","contents_url":"https://api.github.com/repos/appcelerator/amp/contents/{+path}","compare_url":"https://api.github.com/repos/appcelerator/amp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appcelerator/amp/merges","archive_url":"https://api.github.com/repos/appcelerator/amp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appcelerator/amp/downloads","issues_url":"https://api.github.com/repos/appcelerator/amp/issues{/number}","pulls_url":"https://api.github.com/repos/appcelerator/amp/pulls{/number}","milestones_url":"https://api.github.com/repos/appcelerator/amp/milestones{/number}","notifications_url":"https://api.github.com/repos/appcelerator/amp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appcelerator/amp/labels{/name}","releases_url":"https://api.github.com/repos/appcelerator/amp/releases{/id}","deployments_url":"https://api.github.com/repos/appcelerator/amp/deployments","created_at":"2016-06-16T14:49:30Z","updated_at":"2017-01-21T01:08:13Z","pushed_at":"2017-01-23T22:41:15Z","git_url":"git://github.com/appcelerator/amp.git","ssh_url":"[email protected]:appcelerator/amp.git","clone_url":"https://github.com/appcelerator/amp.git","svn_url":"https://github.com/appcelerator/amp","homepage":"","size":108006,"stargazers_count":27,"watchers_count":27,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":79,"forks":14,"open_issues":79,"watchers":27,"default_branch":"master"}},"base":{"label":"appcelerator:master","ref":"master","sha":"64a9cf004051a0e57c296117c43ff40b7769bd5d","user":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars.githubusercontent.com/u/82188?v=3","gravatar_id":"","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"repo":{"id":61302197,"name":"amp","full_name":"appcelerator/amp","owner":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars.githubusercontent.com/u/82188?v=3","gravatar_id":"","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appcelerator/amp","description":"AMP - an open source unified CaaS / FaaS platform for Docker","fork":false,"url":"https://api.github.com/repos/appcelerator/amp","forks_url":"https://api.github.com/repos/appcelerator/amp/forks","keys_url":"https://api.github.com/repos/appcelerator/amp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appcelerator/amp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appcelerator/amp/teams","hooks_url":"https://api.github.com/repos/appcelerator/amp/hooks","issue_events_url":"https://api.github.com/repos/appcelerator/amp/issues/events{/number}","events_url":"https://api.github.com/repos/appcelerator/amp/events","assignees_url":"https://api.github.com/repos/appcelerator/amp/assignees{/user}","branches_url":"https://api.github.com/repos/appcelerator/amp/branches{/branch}","tags_url":"https://api.github.com/repos/appcelerator/amp/tags","blobs_url":"https://api.github.com/repos/appcelerator/amp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appcelerator/amp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appcelerator/amp/git/refs{/sha}","trees_url":"https://api.github.com/repos/appcelerator/amp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appcelerator/amp/statuses/{sha}","languages_url":"https://api.github.com/repos/appcelerator/amp/languages","stargazers_url":"https://api.github.com/repos/appcelerator/amp/stargazers","contributors_url":"https://api.github.com/repos/appcelerator/amp/contributors","subscribers_url":"https://api.github.com/repos/appcelerator/amp/subscribers","subscription_url":"https://api.github.com/repos/appcelerator/amp/subscription","commits_url":"https://api.github.com/repos/appcelerator/amp/commits{/sha}","git_commits_url":"https://api.github.com/repos/appcelerator/amp/git/commits{/sha}","comments_url":"https://api.github.com/repos/appcelerator/amp/comments{/number}","issue_comment_url":"https://api.github.com/repos/appcelerator/amp/issues/comments{/number}","contents_url":"https://api.github.com/repos/appcelerator/amp/contents/{+path}","compare_url":"https://api.github.com/repos/appcelerator/amp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appcelerator/amp/merges","archive_url":"https://api.github.com/repos/appcelerator/amp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appcelerator/amp/downloads","issues_url":"https://api.github.com/repos/appcelerator/amp/issues{/number}","pulls_url":"https://api.github.com/repos/appcelerator/amp/pulls{/number}","milestones_url":"https://api.github.com/repos/appcelerator/amp/milestones{/number}","notifications_url":"https://api.github.com/repos/appcelerator/amp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appcelerator/amp/labels{/name}","releases_url":"https://api.github.com/repos/appcelerator/amp/releases{/id}","deployments_url":"https://api.github.com/repos/appcelerator/amp/deployments","created_at":"2016-06-16T14:49:30Z","updated_at":"2017-01-21T01:08:13Z","pushed_at":"2017-01-23T22:41:15Z","git_url":"git://github.com/appcelerator/amp.git","ssh_url":"[email protected]:appcelerator/amp.git","clone_url":"https://github.com/appcelerator/amp.git","svn_url":"https://github.com/appcelerator/amp","homepage":"","size":108006,"stargazers_count":27,"watchers_count":27,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":79,"forks":14,"open_issues":79,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appcelerator/amp/pulls/706"},"html":{"href":"https://github.com/appcelerator/amp/pull/706"},"issue":{"href":"https://api.github.com/repos/appcelerator/amp/issues/706"},"comments":{"href":"https://api.github.com/repos/appcelerator/amp/issues/706/comments"},"review_comments":{"href":"https://api.github.com/repos/appcelerator/amp/pulls/706/comments"},"review_comment":{"href":"https://api.github.com/repos/appcelerator/amp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appcelerator/amp/pulls/706/commits"},"statuses":{"href":"https://api.github.com/repos/appcelerator/amp/statuses/b32c9d1876e8b128ba03cd271098994c547dd3d4"}}}}
|
{
"id": 61302197,
"name": "appcelerator/amp",
"url": "https://api.github.com/repos/appcelerator/amp"
}
|
{
"id": 11839374,
"login": "ndegory",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11839374?",
"url": "https://api.github.com/users/ndegory"
}
|
{
"id": 82188,
"login": "appcelerator",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/82188?",
"url": "https://api.github.com/orgs/appcelerator"
}
| 2017-01-23T22:47:07 |
5200112973
|
{"actor":{"display_login":"ndegory"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/bardsoftware/ace/pulls/comments/111940917","pull_request_review_id":33044039,"id":111940917,"diff_hunk":"@@ -0,0 +1,117 @@\n+foo = null # ACE builder wants some meaningful JS code here to use ace.define instead of just define\n+define((require, exports, module) ->\n+ LatexParsingContext = require(\"ace/ext/papeeria/latex_parsing_context\")\n+ Autocomplete = require('ace/autocomplete')\n+ util = require(\"ace/autocomplete/util\")\n+ lang = require(\"../../lib/lang\")\n+\n+ class BiblioFilesCompleter extends Autocomplete.Autocomplete\n+ constructor: ->\n+ super()\n+ setFiles: (files) => @files = files\n+ _setCompletions: =>\n+ matches = @files.map((file) -> return {","path":"lib/ace/ext/papeeria/biblio_completer.coffee","position":13,"original_position":13,"commit_id":"a8fd310f981f603d4f1a248c1a1f38ea2fc3dba4","original_commit_id":"a8fd310f981f603d4f1a248c1a1f38ea2fc3dba4","user":{"login":"khazhoyan","id":8560130,"avatar_url":"https://avatars1.githubusercontent.com/u/8560130?v=3","gravatar_id":"","url":"https://api.github.com/users/khazhoyan","html_url":"https://github.com/khazhoyan","followers_url":"https://api.github.com/users/khazhoyan/followers","following_url":"https://api.github.com/users/khazhoyan/following{/other_user}","gists_url":"https://api.github.com/users/khazhoyan/gists{/gist_id}","starred_url":"https://api.github.com/users/khazhoyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khazhoyan/subscriptions","organizations_url":"https://api.github.com/users/khazhoyan/orgs","repos_url":"https://api.github.com/users/khazhoyan/repos","events_url":"https://api.github.com/users/khazhoyan/events{/privacy}","received_events_url":"https://api.github.com/users/khazhoyan/received_events","type":"User","site_admin":false},"body":"FYI: `return` isn't necessary in one-statement lambdas","created_at":"2017-04-18T12:32:17Z","updated_at":"2017-04-18T12:57:55Z","html_url":"https://github.com/bardsoftware/ace/pull/120#discussion_r111940917","pull_request_url":"https://api.github.com/repos/bardsoftware/ace/pulls/120","_links":{"self":{"href":"https://api.github.com/repos/bardsoftware/ace/pulls/comments/111940917"},"html":{"href":"https://github.com/bardsoftware/ace/pull/120#discussion_r111940917"},"pull_request":{"href":"https://api.github.com/repos/bardsoftware/ace/pulls/120"}}},"pull_request":{"url":"https://api.github.com/repos/bardsoftware/ace/pulls/120","id":115958082,"html_url":"https://github.com/bardsoftware/ace/pull/120","diff_url":"https://github.com/bardsoftware/ace/pull/120.diff","patch_url":"https://github.com/bardsoftware/ace/pull/120.patch","issue_url":"https://api.github.com/repos/bardsoftware/ace/issues/120","number":120,"state":"open","locked":false,"title":"Biblio search completer","user":{"login":"alinadubatovka","id":6866408,"avatar_url":"https://avatars0.githubusercontent.com/u/6866408?v=3","gravatar_id":"","url":"https://api.github.com/users/alinadubatovka","html_url":"https://github.com/alinadubatovka","followers_url":"https://api.github.com/users/alinadubatovka/followers","following_url":"https://api.github.com/users/alinadubatovka/following{/other_user}","gists_url":"https://api.github.com/users/alinadubatovka/gists{/gist_id}","starred_url":"https://api.github.com/users/alinadubatovka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alinadubatovka/subscriptions","organizations_url":"https://api.github.com/users/alinadubatovka/orgs","repos_url":"https://api.github.com/users/alinadubatovka/repos","events_url":"https://api.github.com/users/alinadubatovka/events{/privacy}","received_events_url":"https://api.github.com/users/alinadubatovka/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-14T16:59:28Z","updated_at":"2017-04-18T12:57:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b51aa3a4520e3913a3994f4593edbb47009163f5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bardsoftware/ace/pulls/120/commits","review_comments_url":"https://api.github.com/repos/bardsoftware/ace/pulls/120/comments","review_comment_url":"https://api.github.com/repos/bardsoftware/ace/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bardsoftware/ace/issues/120/comments","statuses_url":"https://api.github.com/repos/bardsoftware/ace/statuses/a8fd310f981f603d4f1a248c1a1f38ea2fc3dba4","head":{"label":"bardsoftware:biblio_autocompletion","ref":"biblio_autocompletion","sha":"a8fd310f981f603d4f1a248c1a1f38ea2fc3dba4","user":{"login":"bardsoftware","id":2625618,"avatar_url":"https://avatars2.githubusercontent.com/u/2625618?v=3","gravatar_id":"","url":"https://api.github.com/users/bardsoftware","html_url":"https://github.com/bardsoftware","followers_url":"https://api.github.com/users/bardsoftware/followers","following_url":"https://api.github.com/users/bardsoftware/following{/other_user}","gists_url":"https://api.github.com/users/bardsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/bardsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bardsoftware/subscriptions","organizations_url":"https://api.github.com/users/bardsoftware/orgs","repos_url":"https://api.github.com/users/bardsoftware/repos","events_url":"https://api.github.com/users/bardsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/bardsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":13590146,"name":"ace","full_name":"bardsoftware/ace","owner":{"login":"bardsoftware","id":2625618,"avatar_url":"https://avatars2.githubusercontent.com/u/2625618?v=3","gravatar_id":"","url":"https://api.github.com/users/bardsoftware","html_url":"https://github.com/bardsoftware","followers_url":"https://api.github.com/users/bardsoftware/followers","following_url":"https://api.github.com/users/bardsoftware/following{/other_user}","gists_url":"https://api.github.com/users/bardsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/bardsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bardsoftware/subscriptions","organizations_url":"https://api.github.com/users/bardsoftware/orgs","repos_url":"https://api.github.com/users/bardsoftware/repos","events_url":"https://api.github.com/users/bardsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/bardsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bardsoftware/ace","description":"Ace (Ajax.org Cloud9 Editor)","fork":true,"url":"https://api.github.com/repos/bardsoftware/ace","forks_url":"https://api.github.com/repos/bardsoftware/ace/forks","keys_url":"https://api.github.com/repos/bardsoftware/ace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bardsoftware/ace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bardsoftware/ace/teams","hooks_url":"https://api.github.com/repos/bardsoftware/ace/hooks","issue_events_url":"https://api.github.com/repos/bardsoftware/ace/issues/events{/number}","events_url":"https://api.github.com/repos/bardsoftware/ace/events","assignees_url":"https://api.github.com/repos/bardsoftware/ace/assignees{/user}","branches_url":"https://api.github.com/repos/bardsoftware/ace/branches{/branch}","tags_url":"https://api.github.com/repos/bardsoftware/ace/tags","blobs_url":"https://api.github.com/repos/bardsoftware/ace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bardsoftware/ace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bardsoftware/ace/git/refs{/sha}","trees_url":"https://api.github.com/repos/bardsoftware/ace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bardsoftware/ace/statuses/{sha}","languages_url":"https://api.github.com/repos/bardsoftware/ace/languages","stargazers_url":"https://api.github.com/repos/bardsoftware/ace/stargazers","contributors_url":"https://api.github.com/repos/bardsoftware/ace/contributors","subscribers_url":"https://api.github.com/repos/bardsoftware/ace/subscribers","subscription_url":"https://api.github.com/repos/bardsoftware/ace/subscription","commits_url":"https://api.github.com/repos/bardsoftware/ace/commits{/sha}","git_commits_url":"https://api.github.com/repos/bardsoftware/ace/git/commits{/sha}","comments_url":"https://api.github.com/repos/bardsoftware/ace/comments{/number}","issue_comment_url":"https://api.github.com/repos/bardsoftware/ace/issues/comments{/number}","contents_url":"https://api.github.com/repos/bardsoftware/ace/contents/{+path}","compare_url":"https://api.github.com/repos/bardsoftware/ace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bardsoftware/ace/merges","archive_url":"https://api.github.com/repos/bardsoftware/ace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bardsoftware/ace/downloads","issues_url":"https://api.github.com/repos/bardsoftware/ace/issues{/number}","pulls_url":"https://api.github.com/repos/bardsoftware/ace/pulls{/number}","milestones_url":"https://api.github.com/repos/bardsoftware/ace/milestones{/number}","notifications_url":"https://api.github.com/repos/bardsoftware/ace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bardsoftware/ace/labels{/name}","releases_url":"https://api.github.com/repos/bardsoftware/ace/releases{/id}","deployments_url":"https://api.github.com/repos/bardsoftware/ace/deployments","created_at":"2013-10-15T13:03:16Z","updated_at":"2016-10-26T16:51:24Z","pushed_at":"2017-04-17T16:59:34Z","git_url":"git://github.com/bardsoftware/ace.git","ssh_url":"[email protected]:bardsoftware/ace.git","clone_url":"https://github.com/bardsoftware/ace.git","svn_url":"https://github.com/bardsoftware/ace","homepage":"http://ace.c9.io","size":37988,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":5,"default_branch":"internship-2016"}},"base":{"label":"bardsoftware:papeeria_master","ref":"papeeria_master","sha":"9e46e4332bcb039c83a089c8bd5d3ccc746c66fa","user":{"login":"bardsoftware","id":2625618,"avatar_url":"https://avatars2.githubusercontent.com/u/2625618?v=3","gravatar_id":"","url":"https://api.github.com/users/bardsoftware","html_url":"https://github.com/bardsoftware","followers_url":"https://api.github.com/users/bardsoftware/followers","following_url":"https://api.github.com/users/bardsoftware/following{/other_user}","gists_url":"https://api.github.com/users/bardsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/bardsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bardsoftware/subscriptions","organizations_url":"https://api.github.com/users/bardsoftware/orgs","repos_url":"https://api.github.com/users/bardsoftware/repos","events_url":"https://api.github.com/users/bardsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/bardsoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":13590146,"name":"ace","full_name":"bardsoftware/ace","owner":{"login":"bardsoftware","id":2625618,"avatar_url":"https://avatars2.githubusercontent.com/u/2625618?v=3","gravatar_id":"","url":"https://api.github.com/users/bardsoftware","html_url":"https://github.com/bardsoftware","followers_url":"https://api.github.com/users/bardsoftware/followers","following_url":"https://api.github.com/users/bardsoftware/following{/other_user}","gists_url":"https://api.github.com/users/bardsoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/bardsoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bardsoftware/subscriptions","organizations_url":"https://api.github.com/users/bardsoftware/orgs","repos_url":"https://api.github.com/users/bardsoftware/repos","events_url":"https://api.github.com/users/bardsoftware/events{/privacy}","received_events_url":"https://api.github.com/users/bardsoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bardsoftware/ace","description":"Ace (Ajax.org Cloud9 Editor)","fork":true,"url":"https://api.github.com/repos/bardsoftware/ace","forks_url":"https://api.github.com/repos/bardsoftware/ace/forks","keys_url":"https://api.github.com/repos/bardsoftware/ace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bardsoftware/ace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bardsoftware/ace/teams","hooks_url":"https://api.github.com/repos/bardsoftware/ace/hooks","issue_events_url":"https://api.github.com/repos/bardsoftware/ace/issues/events{/number}","events_url":"https://api.github.com/repos/bardsoftware/ace/events","assignees_url":"https://api.github.com/repos/bardsoftware/ace/assignees{/user}","branches_url":"https://api.github.com/repos/bardsoftware/ace/branches{/branch}","tags_url":"https://api.github.com/repos/bardsoftware/ace/tags","blobs_url":"https://api.github.com/repos/bardsoftware/ace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bardsoftware/ace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bardsoftware/ace/git/refs{/sha}","trees_url":"https://api.github.com/repos/bardsoftware/ace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bardsoftware/ace/statuses/{sha}","languages_url":"https://api.github.com/repos/bardsoftware/ace/languages","stargazers_url":"https://api.github.com/repos/bardsoftware/ace/stargazers","contributors_url":"https://api.github.com/repos/bardsoftware/ace/contributors","subscribers_url":"https://api.github.com/repos/bardsoftware/ace/subscribers","subscription_url":"https://api.github.com/repos/bardsoftware/ace/subscription","commits_url":"https://api.github.com/repos/bardsoftware/ace/commits{/sha}","git_commits_url":"https://api.github.com/repos/bardsoftware/ace/git/commits{/sha}","comments_url":"https://api.github.com/repos/bardsoftware/ace/comments{/number}","issue_comment_url":"https://api.github.com/repos/bardsoftware/ace/issues/comments{/number}","contents_url":"https://api.github.com/repos/bardsoftware/ace/contents/{+path}","compare_url":"https://api.github.com/repos/bardsoftware/ace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bardsoftware/ace/merges","archive_url":"https://api.github.com/repos/bardsoftware/ace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bardsoftware/ace/downloads","issues_url":"https://api.github.com/repos/bardsoftware/ace/issues{/number}","pulls_url":"https://api.github.com/repos/bardsoftware/ace/pulls{/number}","milestones_url":"https://api.github.com/repos/bardsoftware/ace/milestones{/number}","notifications_url":"https://api.github.com/repos/bardsoftware/ace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bardsoftware/ace/labels{/name}","releases_url":"https://api.github.com/repos/bardsoftware/ace/releases{/id}","deployments_url":"https://api.github.com/repos/bardsoftware/ace/deployments","created_at":"2013-10-15T13:03:16Z","updated_at":"2016-10-26T16:51:24Z","pushed_at":"2017-04-17T16:59:34Z","git_url":"git://github.com/bardsoftware/ace.git","ssh_url":"[email protected]:bardsoftware/ace.git","clone_url":"https://github.com/bardsoftware/ace.git","svn_url":"https://github.com/bardsoftware/ace","homepage":"http://ace.c9.io","size":37988,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":5,"default_branch":"internship-2016"}},"_links":{"self":{"href":"https://api.github.com/repos/bardsoftware/ace/pulls/120"},"html":{"href":"https://github.com/bardsoftware/ace/pull/120"},"issue":{"href":"https://api.github.com/repos/bardsoftware/ace/issues/120"},"comments":{"href":"https://api.github.com/repos/bardsoftware/ace/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/bardsoftware/ace/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/bardsoftware/ace/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bardsoftware/ace/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/bardsoftware/ace/statuses/a8fd310f981f603d4f1a248c1a1f38ea2fc3dba4"}}}}
|
{
"id": 13590146,
"name": "bardsoftware/ace",
"url": "https://api.github.com/repos/bardsoftware/ace"
}
|
{
"id": 8560130,
"login": "khazhoyan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8560130?",
"url": "https://api.github.com/users/khazhoyan"
}
|
{
"id": 2625618,
"login": "bardsoftware",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2625618?",
"url": "https://api.github.com/orgs/bardsoftware"
}
| 2017-04-18T12:32:17 |
5707030985
|
{"actor":{"display_login":"khazhoyan"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/boundlessgeo/sdk/pulls/comments/139726365","pull_request_review_id":63699736,"id":139726365,"diff_hunk":"@@ -14,13 +14,53 @@ import SdkMap from '@boundlessgeo/sdk/components/map';\n import SdkMapReducer from '@boundlessgeo/sdk/reducers/map';\n import * as mapActions from '@boundlessgeo/sdk/actions/map';\n \n-import LayerList from './components/layerList';\n+import SdkLayerList from '@boundlessgeo/sdk/components/layer-list';\n+import { LayerListItem as SdkLayerListItem } from '@boundlessgeo/sdk/components/layer-list';\n+\n+import { Provider } from 'react-redux';\n \n /* eslint-disable no-underscore-dangle */\n const store = createStore(combineReducers({\n map: SdkMapReducer,\n }), window.__REDUX_DEVTOOLS_EXTENSION__ && window.__REDUX_DEVTOOLS_EXTENSION__());\n \n+class LayerListItem extends SdkLayerListItem {\n+ render() {\n+ const layer = this.props.layer;\n+ const checkbox = this.getVisibilityControl(layer);","path":"examples/layer-list/app.js","position":18,"original_position":18,"commit_id":"2f1affd38afc5fc277b464dc81a2a8870728c286","original_commit_id":"2f1affd38afc5fc277b464dc81a2a8870728c286","user":{"login":"bartvde","id":319678,"avatar_url":"https://avatars3.githubusercontent.com/u/319678?v=4","gravatar_id":"","url":"https://api.github.com/users/bartvde","html_url":"https://github.com/bartvde","followers_url":"https://api.github.com/users/bartvde/followers","following_url":"https://api.github.com/users/bartvde/following{/other_user}","gists_url":"https://api.github.com/users/bartvde/gists{/gist_id}","starred_url":"https://api.github.com/users/bartvde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartvde/subscriptions","organizations_url":"https://api.github.com/users/bartvde/orgs","repos_url":"https://api.github.com/users/bartvde/repos","events_url":"https://api.github.com/users/bartvde/events{/privacy}","received_events_url":"https://api.github.com/users/bartvde/received_events","type":"User","site_admin":false},"body":"ok I was thinking we could handle the visibility with the state of the component instead, but not sure if we would be solving any real performance issue here, haven't benchmarked or anything","created_at":"2017-09-19T15:22:26Z","updated_at":"2017-09-19T15:22:26Z","html_url":"https://github.com/boundlessgeo/sdk/pull/663#discussion_r139726365","pull_request_url":"https://api.github.com/repos/boundlessgeo/sdk/pulls/663","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/boundlessgeo/sdk/pulls/comments/139726365"},"html":{"href":"https://github.com/boundlessgeo/sdk/pull/663#discussion_r139726365"},"pull_request":{"href":"https://api.github.com/repos/boundlessgeo/sdk/pulls/663"}},"in_reply_to_id":139615166},"pull_request":{"url":"https://api.github.com/repos/boundlessgeo/sdk/pulls/663","id":141676838,"html_url":"https://github.com/boundlessgeo/sdk/pull/663","diff_url":"https://github.com/boundlessgeo/sdk/pull/663.diff","patch_url":"https://github.com/boundlessgeo/sdk/pull/663.patch","issue_url":"https://api.github.com/repos/boundlessgeo/sdk/issues/663","number":663,"state":"open","locked":false,"title":"Refactor of layer list to include it in core.","user":{"login":"theduckylittle","id":1282291,"avatar_url":"https://avatars2.githubusercontent.com/u/1282291?v=4","gravatar_id":"","url":"https://api.github.com/users/theduckylittle","html_url":"https://github.com/theduckylittle","followers_url":"https://api.github.com/users/theduckylittle/followers","following_url":"https://api.github.com/users/theduckylittle/following{/other_user}","gists_url":"https://api.github.com/users/theduckylittle/gists{/gist_id}","starred_url":"https://api.github.com/users/theduckylittle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theduckylittle/subscriptions","organizations_url":"https://api.github.com/users/theduckylittle/orgs","repos_url":"https://api.github.com/users/theduckylittle/repos","events_url":"https://api.github.com/users/theduckylittle/events{/privacy}","received_events_url":"https://api.github.com/users/theduckylittle/received_events","type":"User","site_admin":false},"body":"1. Move the layer list component out of the example.\r\n2. Created a very minimal vesion of a layer list for core which\r\n has a very stripped DOM representation and no labels.\r\n3. Rewrote the layer list example with the more complex version\r\n featuring additional controls.\r\n\r\nSome findings:\r\n1. The <Provider/> was necessary to ensure the store was passed\r\n to child elements of the layer list.\r\n2. It was not possible to simply override the `renderLayer` method\r\n of a parent class because `connect()'ed classes wouldn't honour\r\n the override.\r\n3. Less a finding and more question: moving the layer up and down\r\n could probably be moved to the reducer/actions if it is considered\r\n common enough. Having the code in the layer list may also be enough\r\n to make the point moot.","created_at":"2017-09-18T18:52:11Z","updated_at":"2017-09-19T15:22:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"425df2e51cbcb947959e2f7c2852f6786523a08e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/boundlessgeo/sdk/pulls/663/commits","review_comments_url":"https://api.github.com/repos/boundlessgeo/sdk/pulls/663/comments","review_comment_url":"https://api.github.com/repos/boundlessgeo/sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/boundlessgeo/sdk/issues/663/comments","statuses_url":"https://api.github.com/repos/boundlessgeo/sdk/statuses/2f1affd38afc5fc277b464dc81a2a8870728c286","head":{"label":"theduckylittle:feature/layers-list","ref":"feature/layers-list","sha":"2f1affd38afc5fc277b464dc81a2a8870728c286","user":{"login":"theduckylittle","id":1282291,"avatar_url":"https://avatars2.githubusercontent.com/u/1282291?v=4","gravatar_id":"","url":"https://api.github.com/users/theduckylittle","html_url":"https://github.com/theduckylittle","followers_url":"https://api.github.com/users/theduckylittle/followers","following_url":"https://api.github.com/users/theduckylittle/following{/other_user}","gists_url":"https://api.github.com/users/theduckylittle/gists{/gist_id}","starred_url":"https://api.github.com/users/theduckylittle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theduckylittle/subscriptions","organizations_url":"https://api.github.com/users/theduckylittle/orgs","repos_url":"https://api.github.com/users/theduckylittle/repos","events_url":"https://api.github.com/users/theduckylittle/events{/privacy}","received_events_url":"https://api.github.com/users/theduckylittle/received_events","type":"User","site_admin":false},"repo":{"id":86463069,"name":"sdk","full_name":"theduckylittle/sdk","owner":{"login":"theduckylittle","id":1282291,"avatar_url":"https://avatars2.githubusercontent.com/u/1282291?v=4","gravatar_id":"","url":"https://api.github.com/users/theduckylittle","html_url":"https://github.com/theduckylittle","followers_url":"https://api.github.com/users/theduckylittle/followers","following_url":"https://api.github.com/users/theduckylittle/following{/other_user}","gists_url":"https://api.github.com/users/theduckylittle/gists{/gist_id}","starred_url":"https://api.github.com/users/theduckylittle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theduckylittle/subscriptions","organizations_url":"https://api.github.com/users/theduckylittle/orgs","repos_url":"https://api.github.com/users/theduckylittle/repos","events_url":"https://api.github.com/users/theduckylittle/events{/privacy}","received_events_url":"https://api.github.com/users/theduckylittle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/theduckylittle/sdk","description":"New javascript SDK based on React and Flux","fork":true,"url":"https://api.github.com/repos/theduckylittle/sdk","forks_url":"https://api.github.com/repos/theduckylittle/sdk/forks","keys_url":"https://api.github.com/repos/theduckylittle/sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theduckylittle/sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theduckylittle/sdk/teams","hooks_url":"https://api.github.com/repos/theduckylittle/sdk/hooks","issue_events_url":"https://api.github.com/repos/theduckylittle/sdk/issues/events{/number}","events_url":"https://api.github.com/repos/theduckylittle/sdk/events","assignees_url":"https://api.github.com/repos/theduckylittle/sdk/assignees{/user}","branches_url":"https://api.github.com/repos/theduckylittle/sdk/branches{/branch}","tags_url":"https://api.github.com/repos/theduckylittle/sdk/tags","blobs_url":"https://api.github.com/repos/theduckylittle/sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theduckylittle/sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theduckylittle/sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/theduckylittle/sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theduckylittle/sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/theduckylittle/sdk/languages","stargazers_url":"https://api.github.com/repos/theduckylittle/sdk/stargazers","contributors_url":"https://api.github.com/repos/theduckylittle/sdk/contributors","subscribers_url":"https://api.github.com/repos/theduckylittle/sdk/subscribers","subscription_url":"https://api.github.com/repos/theduckylittle/sdk/subscription","commits_url":"https://api.github.com/repos/theduckylittle/sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/theduckylittle/sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/theduckylittle/sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/theduckylittle/sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/theduckylittle/sdk/contents/{+path}","compare_url":"https://api.github.com/repos/theduckylittle/sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theduckylittle/sdk/merges","archive_url":"https://api.github.com/repos/theduckylittle/sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theduckylittle/sdk/downloads","issues_url":"https://api.github.com/repos/theduckylittle/sdk/issues{/number}","pulls_url":"https://api.github.com/repos/theduckylittle/sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/theduckylittle/sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/theduckylittle/sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theduckylittle/sdk/labels{/name}","releases_url":"https://api.github.com/repos/theduckylittle/sdk/releases{/id}","deployments_url":"https://api.github.com/repos/theduckylittle/sdk/deployments","created_at":"2017-03-28T13:25:10Z","updated_at":"2017-03-28T13:25:12Z","pushed_at":"2017-09-18T18:51:49Z","git_url":"git://github.com/theduckylittle/sdk.git","ssh_url":"[email protected]:theduckylittle/sdk.git","clone_url":"https://github.com/theduckylittle/sdk.git","svn_url":"https://github.com/theduckylittle/sdk","homepage":"","size":63662,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"boundlessgeo:master","ref":"master","sha":"e993fe6c852f0c54e0fea8940219e07a30c13e23","user":{"login":"boundlessgeo","id":306022,"avatar_url":"https://avatars0.githubusercontent.com/u/306022?v=4","gravatar_id":"","url":"https://api.github.com/users/boundlessgeo","html_url":"https://github.com/boundlessgeo","followers_url":"https://api.github.com/users/boundlessgeo/followers","following_url":"https://api.github.com/users/boundlessgeo/following{/other_user}","gists_url":"https://api.github.com/users/boundlessgeo/gists{/gist_id}","starred_url":"https://api.github.com/users/boundlessgeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boundlessgeo/subscriptions","organizations_url":"https://api.github.com/users/boundlessgeo/orgs","repos_url":"https://api.github.com/users/boundlessgeo/repos","events_url":"https://api.github.com/users/boundlessgeo/events{/privacy}","received_events_url":"https://api.github.com/users/boundlessgeo/received_events","type":"Organization","site_admin":false},"repo":{"id":36792837,"name":"sdk","full_name":"boundlessgeo/sdk","owner":{"login":"boundlessgeo","id":306022,"avatar_url":"https://avatars0.githubusercontent.com/u/306022?v=4","gravatar_id":"","url":"https://api.github.com/users/boundlessgeo","html_url":"https://github.com/boundlessgeo","followers_url":"https://api.github.com/users/boundlessgeo/followers","following_url":"https://api.github.com/users/boundlessgeo/following{/other_user}","gists_url":"https://api.github.com/users/boundlessgeo/gists{/gist_id}","starred_url":"https://api.github.com/users/boundlessgeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boundlessgeo/subscriptions","organizations_url":"https://api.github.com/users/boundlessgeo/orgs","repos_url":"https://api.github.com/users/boundlessgeo/repos","events_url":"https://api.github.com/users/boundlessgeo/events{/privacy}","received_events_url":"https://api.github.com/users/boundlessgeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boundlessgeo/sdk","description":"Javascript SDK based on React, Redux and OpenLayers","fork":false,"url":"https://api.github.com/repos/boundlessgeo/sdk","forks_url":"https://api.github.com/repos/boundlessgeo/sdk/forks","keys_url":"https://api.github.com/repos/boundlessgeo/sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boundlessgeo/sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boundlessgeo/sdk/teams","hooks_url":"https://api.github.com/repos/boundlessgeo/sdk/hooks","issue_events_url":"https://api.github.com/repos/boundlessgeo/sdk/issues/events{/number}","events_url":"https://api.github.com/repos/boundlessgeo/sdk/events","assignees_url":"https://api.github.com/repos/boundlessgeo/sdk/assignees{/user}","branches_url":"https://api.github.com/repos/boundlessgeo/sdk/branches{/branch}","tags_url":"https://api.github.com/repos/boundlessgeo/sdk/tags","blobs_url":"https://api.github.com/repos/boundlessgeo/sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boundlessgeo/sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boundlessgeo/sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/boundlessgeo/sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boundlessgeo/sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/boundlessgeo/sdk/languages","stargazers_url":"https://api.github.com/repos/boundlessgeo/sdk/stargazers","contributors_url":"https://api.github.com/repos/boundlessgeo/sdk/contributors","subscribers_url":"https://api.github.com/repos/boundlessgeo/sdk/subscribers","subscription_url":"https://api.github.com/repos/boundlessgeo/sdk/subscription","commits_url":"https://api.github.com/repos/boundlessgeo/sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/boundlessgeo/sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/boundlessgeo/sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/boundlessgeo/sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/boundlessgeo/sdk/contents/{+path}","compare_url":"https://api.github.com/repos/boundlessgeo/sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boundlessgeo/sdk/merges","archive_url":"https://api.github.com/repos/boundlessgeo/sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boundlessgeo/sdk/downloads","issues_url":"https://api.github.com/repos/boundlessgeo/sdk/issues{/number}","pulls_url":"https://api.github.com/repos/boundlessgeo/sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/boundlessgeo/sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/boundlessgeo/sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boundlessgeo/sdk/labels{/name}","releases_url":"https://api.github.com/repos/boundlessgeo/sdk/releases{/id}","deployments_url":"https://api.github.com/repos/boundlessgeo/sdk/deployments","created_at":"2015-06-03T09:13:14Z","updated_at":"2017-09-14T18:17:19Z","pushed_at":"2017-09-19T15:21:50Z","git_url":"git://github.com/boundlessgeo/sdk.git","ssh_url":"[email protected]:boundlessgeo/sdk.git","clone_url":"https://github.com/boundlessgeo/sdk.git","svn_url":"https://github.com/boundlessgeo/sdk","homepage":"","size":69868,"stargazers_count":36,"watchers_count":36,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"open_issues_count":13,"forks":21,"open_issues":13,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boundlessgeo/sdk/pulls/663"},"html":{"href":"https://github.com/boundlessgeo/sdk/pull/663"},"issue":{"href":"https://api.github.com/repos/boundlessgeo/sdk/issues/663"},"comments":{"href":"https://api.github.com/repos/boundlessgeo/sdk/issues/663/comments"},"review_comments":{"href":"https://api.github.com/repos/boundlessgeo/sdk/pulls/663/comments"},"review_comment":{"href":"https://api.github.com/repos/boundlessgeo/sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/boundlessgeo/sdk/pulls/663/commits"},"statuses":{"href":"https://api.github.com/repos/boundlessgeo/sdk/statuses/2f1affd38afc5fc277b464dc81a2a8870728c286"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 36792837,
"name": "boundlessgeo/sdk",
"url": "https://api.github.com/repos/boundlessgeo/sdk"
}
|
{
"id": 319678,
"login": "bartvde",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/319678?",
"url": "https://api.github.com/users/bartvde"
}
|
{
"id": 306022,
"login": "boundlessgeo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/306022?",
"url": "https://api.github.com/orgs/boundlessgeo"
}
| 2017-09-19T15:22:26 |
6609725907
|
{"actor":{"display_login":"bartvde"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/calblueprint/ros-student/pulls/comments/112736977","pull_request_review_id":34078616,"id":112736977,"diff_hunk":"@@ -55,13 +55,14 @@ def component_params(component)\n params = component.slice('component_type', 'audio_url', 'title', 'content_url', 'form_key')\n component_type = params.fetch('component_type', 3)\n \n- add_photo(params, 'content_url') if component_type == Component.component_types[:slides]\n+ add_photo(params, 'content_url') if component_type == Component.component_types[:slide]","path":"app/controllers/concerns/import_course.rb","position":5,"original_position":5,"commit_id":"069ef9e5ca794897ae09d8db4c98fc7dd98a6483","original_commit_id":"069ef9e5ca794897ae09d8db4c98fc7dd98a6483","user":{"login":"lbkchen","id":13477279,"avatar_url":"https://avatars3.githubusercontent.com/u/13477279?v=3","gravatar_id":"","url":"https://api.github.com/users/lbkchen","html_url":"https://github.com/lbkchen","followers_url":"https://api.github.com/users/lbkchen/followers","following_url":"https://api.github.com/users/lbkchen/following{/other_user}","gists_url":"https://api.github.com/users/lbkchen/gists{/gist_id}","starred_url":"https://api.github.com/users/lbkchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbkchen/subscriptions","organizations_url":"https://api.github.com/users/lbkchen/orgs","repos_url":"https://api.github.com/users/lbkchen/repos","events_url":"https://api.github.com/users/lbkchen/events{/privacy}","received_events_url":"https://api.github.com/users/lbkchen/received_events","type":"User","site_admin":false},"body":"Is that seriously it o-o","created_at":"2017-04-21T17:19:30Z","updated_at":"2017-04-21T17:20:21Z","html_url":"https://github.com/calblueprint/ros-student/pull/305#discussion_r112736977","pull_request_url":"https://api.github.com/repos/calblueprint/ros-student/pulls/305","_links":{"self":{"href":"https://api.github.com/repos/calblueprint/ros-student/pulls/comments/112736977"},"html":{"href":"https://github.com/calblueprint/ros-student/pull/305#discussion_r112736977"},"pull_request":{"href":"https://api.github.com/repos/calblueprint/ros-student/pulls/305"}}},"pull_request":{"url":"https://api.github.com/repos/calblueprint/ros-student/pulls/305","id":116916196,"html_url":"https://github.com/calblueprint/ros-student/pull/305","diff_url":"https://github.com/calblueprint/ros-student/pull/305.diff","patch_url":"https://github.com/calblueprint/ros-student/pull/305.patch","issue_url":"https://api.github.com/repos/calblueprint/ros-student/issues/305","number":305,"state":"open","locked":false,"title":"Fixing stupid importing bug","user":{"login":"charlesx2013","id":5563367,"avatar_url":"https://avatars3.githubusercontent.com/u/5563367?v=3","gravatar_id":"","url":"https://api.github.com/users/charlesx2013","html_url":"https://github.com/charlesx2013","followers_url":"https://api.github.com/users/charlesx2013/followers","following_url":"https://api.github.com/users/charlesx2013/following{/other_user}","gists_url":"https://api.github.com/users/charlesx2013/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesx2013/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesx2013/subscriptions","organizations_url":"https://api.github.com/users/charlesx2013/orgs","repos_url":"https://api.github.com/users/charlesx2013/repos","events_url":"https://api.github.com/users/charlesx2013/events{/privacy}","received_events_url":"https://api.github.com/users/charlesx2013/received_events","type":"User","site_admin":false},"body":"@lbkchen ","created_at":"2017-04-21T05:50:56Z","updated_at":"2017-04-21T17:20:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1981a366db76c62f5b7cc2d2dfa47fbfcef7f364","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/calblueprint/ros-student/pulls/305/commits","review_comments_url":"https://api.github.com/repos/calblueprint/ros-student/pulls/305/comments","review_comment_url":"https://api.github.com/repos/calblueprint/ros-student/pulls/comments{/number}","comments_url":"https://api.github.com/repos/calblueprint/ros-student/issues/305/comments","statuses_url":"https://api.github.com/repos/calblueprint/ros-student/statuses/069ef9e5ca794897ae09d8db4c98fc7dd98a6483","head":{"label":"calblueprint:charles/fixCourse","ref":"charles/fixCourse","sha":"069ef9e5ca794897ae09d8db4c98fc7dd98a6483","user":{"login":"calblueprint","id":2729578,"avatar_url":"https://avatars3.githubusercontent.com/u/2729578?v=3","gravatar_id":"","url":"https://api.github.com/users/calblueprint","html_url":"https://github.com/calblueprint","followers_url":"https://api.github.com/users/calblueprint/followers","following_url":"https://api.github.com/users/calblueprint/following{/other_user}","gists_url":"https://api.github.com/users/calblueprint/gists{/gist_id}","starred_url":"https://api.github.com/users/calblueprint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calblueprint/subscriptions","organizations_url":"https://api.github.com/users/calblueprint/orgs","repos_url":"https://api.github.com/users/calblueprint/repos","events_url":"https://api.github.com/users/calblueprint/events{/privacy}","received_events_url":"https://api.github.com/users/calblueprint/received_events","type":"Organization","site_admin":false},"repo":{"id":66624689,"name":"ros-student","full_name":"calblueprint/ros-student","owner":{"login":"calblueprint","id":2729578,"avatar_url":"https://avatars3.githubusercontent.com/u/2729578?v=3","gravatar_id":"","url":"https://api.github.com/users/calblueprint","html_url":"https://github.com/calblueprint","followers_url":"https://api.github.com/users/calblueprint/followers","following_url":"https://api.github.com/users/calblueprint/following{/other_user}","gists_url":"https://api.github.com/users/calblueprint/gists{/gist_id}","starred_url":"https://api.github.com/users/calblueprint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calblueprint/subscriptions","organizations_url":"https://api.github.com/users/calblueprint/orgs","repos_url":"https://api.github.com/users/calblueprint/repos","events_url":"https://api.github.com/users/calblueprint/events{/privacy}","received_events_url":"https://api.github.com/users/calblueprint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/calblueprint/ros-student","description":"A student portal for Roots of Success","fork":false,"url":"https://api.github.com/repos/calblueprint/ros-student","forks_url":"https://api.github.com/repos/calblueprint/ros-student/forks","keys_url":"https://api.github.com/repos/calblueprint/ros-student/keys{/key_id}","collaborators_url":"https://api.github.com/repos/calblueprint/ros-student/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/calblueprint/ros-student/teams","hooks_url":"https://api.github.com/repos/calblueprint/ros-student/hooks","issue_events_url":"https://api.github.com/repos/calblueprint/ros-student/issues/events{/number}","events_url":"https://api.github.com/repos/calblueprint/ros-student/events","assignees_url":"https://api.github.com/repos/calblueprint/ros-student/assignees{/user}","branches_url":"https://api.github.com/repos/calblueprint/ros-student/branches{/branch}","tags_url":"https://api.github.com/repos/calblueprint/ros-student/tags","blobs_url":"https://api.github.com/repos/calblueprint/ros-student/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/calblueprint/ros-student/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/calblueprint/ros-student/git/refs{/sha}","trees_url":"https://api.github.com/repos/calblueprint/ros-student/git/trees{/sha}","statuses_url":"https://api.github.com/repos/calblueprint/ros-student/statuses/{sha}","languages_url":"https://api.github.com/repos/calblueprint/ros-student/languages","stargazers_url":"https://api.github.com/repos/calblueprint/ros-student/stargazers","contributors_url":"https://api.github.com/repos/calblueprint/ros-student/contributors","subscribers_url":"https://api.github.com/repos/calblueprint/ros-student/subscribers","subscription_url":"https://api.github.com/repos/calblueprint/ros-student/subscription","commits_url":"https://api.github.com/repos/calblueprint/ros-student/commits{/sha}","git_commits_url":"https://api.github.com/repos/calblueprint/ros-student/git/commits{/sha}","comments_url":"https://api.github.com/repos/calblueprint/ros-student/comments{/number}","issue_comment_url":"https://api.github.com/repos/calblueprint/ros-student/issues/comments{/number}","contents_url":"https://api.github.com/repos/calblueprint/ros-student/contents/{+path}","compare_url":"https://api.github.com/repos/calblueprint/ros-student/compare/{base}...{head}","merges_url":"https://api.github.com/repos/calblueprint/ros-student/merges","archive_url":"https://api.github.com/repos/calblueprint/ros-student/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/calblueprint/ros-student/downloads","issues_url":"https://api.github.com/repos/calblueprint/ros-student/issues{/number}","pulls_url":"https://api.github.com/repos/calblueprint/ros-student/pulls{/number}","milestones_url":"https://api.github.com/repos/calblueprint/ros-student/milestones{/number}","notifications_url":"https://api.github.com/repos/calblueprint/ros-student/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/calblueprint/ros-student/labels{/name}","releases_url":"https://api.github.com/repos/calblueprint/ros-student/releases{/id}","deployments_url":"https://api.github.com/repos/calblueprint/ros-student/deployments","created_at":"2016-08-26T07:01:32Z","updated_at":"2017-04-19T18:30:51Z","pushed_at":"2017-04-21T16:47:04Z","git_url":"git://github.com/calblueprint/ros-student.git","ssh_url":"[email protected]:calblueprint/ros-student.git","clone_url":"https://github.com/calblueprint/ros-student.git","svn_url":"https://github.com/calblueprint/ros-student","homepage":"http://ros-student-staging.herokuapp.com/","size":5032,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":27,"forks":0,"open_issues":27,"watchers":6,"default_branch":"master"}},"base":{"label":"calblueprint:master","ref":"master","sha":"9ac44dbe8531261112b6400bffabeced51b5482b","user":{"login":"calblueprint","id":2729578,"avatar_url":"https://avatars3.githubusercontent.com/u/2729578?v=3","gravatar_id":"","url":"https://api.github.com/users/calblueprint","html_url":"https://github.com/calblueprint","followers_url":"https://api.github.com/users/calblueprint/followers","following_url":"https://api.github.com/users/calblueprint/following{/other_user}","gists_url":"https://api.github.com/users/calblueprint/gists{/gist_id}","starred_url":"https://api.github.com/users/calblueprint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calblueprint/subscriptions","organizations_url":"https://api.github.com/users/calblueprint/orgs","repos_url":"https://api.github.com/users/calblueprint/repos","events_url":"https://api.github.com/users/calblueprint/events{/privacy}","received_events_url":"https://api.github.com/users/calblueprint/received_events","type":"Organization","site_admin":false},"repo":{"id":66624689,"name":"ros-student","full_name":"calblueprint/ros-student","owner":{"login":"calblueprint","id":2729578,"avatar_url":"https://avatars3.githubusercontent.com/u/2729578?v=3","gravatar_id":"","url":"https://api.github.com/users/calblueprint","html_url":"https://github.com/calblueprint","followers_url":"https://api.github.com/users/calblueprint/followers","following_url":"https://api.github.com/users/calblueprint/following{/other_user}","gists_url":"https://api.github.com/users/calblueprint/gists{/gist_id}","starred_url":"https://api.github.com/users/calblueprint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calblueprint/subscriptions","organizations_url":"https://api.github.com/users/calblueprint/orgs","repos_url":"https://api.github.com/users/calblueprint/repos","events_url":"https://api.github.com/users/calblueprint/events{/privacy}","received_events_url":"https://api.github.com/users/calblueprint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/calblueprint/ros-student","description":"A student portal for Roots of Success","fork":false,"url":"https://api.github.com/repos/calblueprint/ros-student","forks_url":"https://api.github.com/repos/calblueprint/ros-student/forks","keys_url":"https://api.github.com/repos/calblueprint/ros-student/keys{/key_id}","collaborators_url":"https://api.github.com/repos/calblueprint/ros-student/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/calblueprint/ros-student/teams","hooks_url":"https://api.github.com/repos/calblueprint/ros-student/hooks","issue_events_url":"https://api.github.com/repos/calblueprint/ros-student/issues/events{/number}","events_url":"https://api.github.com/repos/calblueprint/ros-student/events","assignees_url":"https://api.github.com/repos/calblueprint/ros-student/assignees{/user}","branches_url":"https://api.github.com/repos/calblueprint/ros-student/branches{/branch}","tags_url":"https://api.github.com/repos/calblueprint/ros-student/tags","blobs_url":"https://api.github.com/repos/calblueprint/ros-student/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/calblueprint/ros-student/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/calblueprint/ros-student/git/refs{/sha}","trees_url":"https://api.github.com/repos/calblueprint/ros-student/git/trees{/sha}","statuses_url":"https://api.github.com/repos/calblueprint/ros-student/statuses/{sha}","languages_url":"https://api.github.com/repos/calblueprint/ros-student/languages","stargazers_url":"https://api.github.com/repos/calblueprint/ros-student/stargazers","contributors_url":"https://api.github.com/repos/calblueprint/ros-student/contributors","subscribers_url":"https://api.github.com/repos/calblueprint/ros-student/subscribers","subscription_url":"https://api.github.com/repos/calblueprint/ros-student/subscription","commits_url":"https://api.github.com/repos/calblueprint/ros-student/commits{/sha}","git_commits_url":"https://api.github.com/repos/calblueprint/ros-student/git/commits{/sha}","comments_url":"https://api.github.com/repos/calblueprint/ros-student/comments{/number}","issue_comment_url":"https://api.github.com/repos/calblueprint/ros-student/issues/comments{/number}","contents_url":"https://api.github.com/repos/calblueprint/ros-student/contents/{+path}","compare_url":"https://api.github.com/repos/calblueprint/ros-student/compare/{base}...{head}","merges_url":"https://api.github.com/repos/calblueprint/ros-student/merges","archive_url":"https://api.github.com/repos/calblueprint/ros-student/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/calblueprint/ros-student/downloads","issues_url":"https://api.github.com/repos/calblueprint/ros-student/issues{/number}","pulls_url":"https://api.github.com/repos/calblueprint/ros-student/pulls{/number}","milestones_url":"https://api.github.com/repos/calblueprint/ros-student/milestones{/number}","notifications_url":"https://api.github.com/repos/calblueprint/ros-student/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/calblueprint/ros-student/labels{/name}","releases_url":"https://api.github.com/repos/calblueprint/ros-student/releases{/id}","deployments_url":"https://api.github.com/repos/calblueprint/ros-student/deployments","created_at":"2016-08-26T07:01:32Z","updated_at":"2017-04-19T18:30:51Z","pushed_at":"2017-04-21T16:47:04Z","git_url":"git://github.com/calblueprint/ros-student.git","ssh_url":"[email protected]:calblueprint/ros-student.git","clone_url":"https://github.com/calblueprint/ros-student.git","svn_url":"https://github.com/calblueprint/ros-student","homepage":"http://ros-student-staging.herokuapp.com/","size":5032,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":27,"forks":0,"open_issues":27,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/calblueprint/ros-student/pulls/305"},"html":{"href":"https://github.com/calblueprint/ros-student/pull/305"},"issue":{"href":"https://api.github.com/repos/calblueprint/ros-student/issues/305"},"comments":{"href":"https://api.github.com/repos/calblueprint/ros-student/issues/305/comments"},"review_comments":{"href":"https://api.github.com/repos/calblueprint/ros-student/pulls/305/comments"},"review_comment":{"href":"https://api.github.com/repos/calblueprint/ros-student/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/calblueprint/ros-student/pulls/305/commits"},"statuses":{"href":"https://api.github.com/repos/calblueprint/ros-student/statuses/069ef9e5ca794897ae09d8db4c98fc7dd98a6483"}}}}
|
{
"id": 66624689,
"name": "calblueprint/ros-student",
"url": "https://api.github.com/repos/calblueprint/ros-student"
}
|
{
"id": 13477279,
"login": "lbkchen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13477279?",
"url": "https://api.github.com/users/lbkchen"
}
|
{
"id": 2729578,
"login": "calblueprint",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2729578?",
"url": "https://api.github.com/orgs/calblueprint"
}
| 2017-04-21T17:19:30 |
5733464471
|
{"actor":{"display_login":"lbkchen"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/callstack-io/react-native-paper/pulls/comments/124046480","pull_request_review_id":46302833,"id":124046480,"diff_hunk":"@@ -0,0 +1,101 @@\n+/* @flow */\n+\n+import color from 'color';\n+import React from 'react';\n+import PropTypes from 'prop-types';\n+import { StyleSheet } from 'react-native';\n+import Paper from './Paper';\n+import Icon from './Icon';\n+import TouchableRipple from './TouchableRipple';\n+import { white } from '../styles/colors';\n+import withTheme from '../core/withTheme';\n+import type { Theme } from '../types/Theme';\n+\n+type Props = {\n+ small?: boolean,\n+ dark?: boolean,\n+ icon: string,\n+ color?: string,\n+ onPress?: Function,\n+ theme: Theme,\n+ style?: any,\n+};\n+\n+/**\n+ * A floating action button represents the primary action in an application\n+ */\n+const FAB = (props: Props) => {\n+ const { small, dark, icon, color: iconColor, onPress, theme, style } = props;\n+ const backgroundColor = theme.colors.accent;\n+ const isDark = typeof dark === 'boolean'","path":"src/components/FAB.js","position":30,"original_position":30,"commit_id":"a52ac9e7ea57a9d5d72ca588ad8511da92682667","original_commit_id":"a52ac9e7ea57a9d5d72ca588ad8511da92682667","user":{"login":"ferrannp","id":774577,"avatar_url":"https://avatars1.githubusercontent.com/u/774577?v=3","gravatar_id":"","url":"https://api.github.com/users/ferrannp","html_url":"https://github.com/ferrannp","followers_url":"https://api.github.com/users/ferrannp/followers","following_url":"https://api.github.com/users/ferrannp/following{/other_user}","gists_url":"https://api.github.com/users/ferrannp/gists{/gist_id}","starred_url":"https://api.github.com/users/ferrannp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferrannp/subscriptions","organizations_url":"https://api.github.com/users/ferrannp/orgs","repos_url":"https://api.github.com/users/ferrannp/repos","events_url":"https://api.github.com/users/ferrannp/events{/privacy}","received_events_url":"https://api.github.com/users/ferrannp/received_events","type":"User","site_admin":false},"body":"Doesn't flow type says its a `boolean` always ?","created_at":"2017-06-26T15:48:14Z","updated_at":"2017-06-26T15:49:31Z","html_url":"https://github.com/callstack-io/react-native-paper/pull/109#discussion_r124046480","pull_request_url":"https://api.github.com/repos/callstack-io/react-native-paper/pulls/109","_links":{"self":{"href":"https://api.github.com/repos/callstack-io/react-native-paper/pulls/comments/124046480"},"html":{"href":"https://github.com/callstack-io/react-native-paper/pull/109#discussion_r124046480"},"pull_request":{"href":"https://api.github.com/repos/callstack-io/react-native-paper/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/callstack-io/react-native-paper/pulls/109","id":127472395,"html_url":"https://github.com/callstack-io/react-native-paper/pull/109","diff_url":"https://github.com/callstack-io/react-native-paper/pull/109.diff","patch_url":"https://github.com/callstack-io/react-native-paper/pull/109.patch","issue_url":"https://api.github.com/repos/callstack-io/react-native-paper/issues/109","number":109,"state":"open","locked":false,"title":"feat: add a FAB component","user":{"login":"satya164","id":1174278,"avatar_url":"https://avatars1.githubusercontent.com/u/1174278?v=3","gravatar_id":"","url":"https://api.github.com/users/satya164","html_url":"https://github.com/satya164","followers_url":"https://api.github.com/users/satya164/followers","following_url":"https://api.github.com/users/satya164/following{/other_user}","gists_url":"https://api.github.com/users/satya164/gists{/gist_id}","starred_url":"https://api.github.com/users/satya164/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satya164/subscriptions","organizations_url":"https://api.github.com/users/satya164/orgs","repos_url":"https://api.github.com/users/satya164/repos","events_url":"https://api.github.com/users/satya164/events{/privacy}","received_events_url":"https://api.github.com/users/satya164/received_events","type":"User","site_admin":false},"body":"\r\n","created_at":"2017-06-26T13:38:39Z","updated_at":"2017-06-26T15:49:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e751ba39663c9424a15c4010c5fa76ae41ffdb5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/callstack-io/react-native-paper/pulls/109/commits","review_comments_url":"https://api.github.com/repos/callstack-io/react-native-paper/pulls/109/comments","review_comment_url":"https://api.github.com/repos/callstack-io/react-native-paper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/callstack-io/react-native-paper/issues/109/comments","statuses_url":"https://api.github.com/repos/callstack-io/react-native-paper/statuses/a52ac9e7ea57a9d5d72ca588ad8511da92682667","head":{"label":"callstack-io:@satya164/fab","ref":"@satya164/fab","sha":"a52ac9e7ea57a9d5d72ca588ad8511da92682667","user":{"login":"callstack-io","id":17571969,"avatar_url":"https://avatars3.githubusercontent.com/u/17571969?v=3","gravatar_id":"","url":"https://api.github.com/users/callstack-io","html_url":"https://github.com/callstack-io","followers_url":"https://api.github.com/users/callstack-io/followers","following_url":"https://api.github.com/users/callstack-io/following{/other_user}","gists_url":"https://api.github.com/users/callstack-io/gists{/gist_id}","starred_url":"https://api.github.com/users/callstack-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callstack-io/subscriptions","organizations_url":"https://api.github.com/users/callstack-io/orgs","repos_url":"https://api.github.com/users/callstack-io/repos","events_url":"https://api.github.com/users/callstack-io/events{/privacy}","received_events_url":"https://api.github.com/users/callstack-io/received_events","type":"Organization","site_admin":false},"repo":{"id":71323749,"name":"react-native-paper","full_name":"callstack-io/react-native-paper","owner":{"login":"callstack-io","id":17571969,"avatar_url":"https://avatars3.githubusercontent.com/u/17571969?v=3","gravatar_id":"","url":"https://api.github.com/users/callstack-io","html_url":"https://github.com/callstack-io","followers_url":"https://api.github.com/users/callstack-io/followers","following_url":"https://api.github.com/users/callstack-io/following{/other_user}","gists_url":"https://api.github.com/users/callstack-io/gists{/gist_id}","starred_url":"https://api.github.com/users/callstack-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callstack-io/subscriptions","organizations_url":"https://api.github.com/users/callstack-io/orgs","repos_url":"https://api.github.com/users/callstack-io/repos","events_url":"https://api.github.com/users/callstack-io/events{/privacy}","received_events_url":"https://api.github.com/users/callstack-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callstack-io/react-native-paper","description":"Material Design for React Native","fork":false,"url":"https://api.github.com/repos/callstack-io/react-native-paper","forks_url":"https://api.github.com/repos/callstack-io/react-native-paper/forks","keys_url":"https://api.github.com/repos/callstack-io/react-native-paper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callstack-io/react-native-paper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callstack-io/react-native-paper/teams","hooks_url":"https://api.github.com/repos/callstack-io/react-native-paper/hooks","issue_events_url":"https://api.github.com/repos/callstack-io/react-native-paper/issues/events{/number}","events_url":"https://api.github.com/repos/callstack-io/react-native-paper/events","assignees_url":"https://api.github.com/repos/callstack-io/react-native-paper/assignees{/user}","branches_url":"https://api.github.com/repos/callstack-io/react-native-paper/branches{/branch}","tags_url":"https://api.github.com/repos/callstack-io/react-native-paper/tags","blobs_url":"https://api.github.com/repos/callstack-io/react-native-paper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callstack-io/react-native-paper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callstack-io/react-native-paper/git/refs{/sha}","trees_url":"https://api.github.com/repos/callstack-io/react-native-paper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callstack-io/react-native-paper/statuses/{sha}","languages_url":"https://api.github.com/repos/callstack-io/react-native-paper/languages","stargazers_url":"https://api.github.com/repos/callstack-io/react-native-paper/stargazers","contributors_url":"https://api.github.com/repos/callstack-io/react-native-paper/contributors","subscribers_url":"https://api.github.com/repos/callstack-io/react-native-paper/subscribers","subscription_url":"https://api.github.com/repos/callstack-io/react-native-paper/subscription","commits_url":"https://api.github.com/repos/callstack-io/react-native-paper/commits{/sha}","git_commits_url":"https://api.github.com/repos/callstack-io/react-native-paper/git/commits{/sha}","comments_url":"https://api.github.com/repos/callstack-io/react-native-paper/comments{/number}","issue_comment_url":"https://api.github.com/repos/callstack-io/react-native-paper/issues/comments{/number}","contents_url":"https://api.github.com/repos/callstack-io/react-native-paper/contents/{+path}","compare_url":"https://api.github.com/repos/callstack-io/react-native-paper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callstack-io/react-native-paper/merges","archive_url":"https://api.github.com/repos/callstack-io/react-native-paper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callstack-io/react-native-paper/downloads","issues_url":"https://api.github.com/repos/callstack-io/react-native-paper/issues{/number}","pulls_url":"https://api.github.com/repos/callstack-io/react-native-paper/pulls{/number}","milestones_url":"https://api.github.com/repos/callstack-io/react-native-paper/milestones{/number}","notifications_url":"https://api.github.com/repos/callstack-io/react-native-paper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callstack-io/react-native-paper/labels{/name}","releases_url":"https://api.github.com/repos/callstack-io/react-native-paper/releases{/id}","deployments_url":"https://api.github.com/repos/callstack-io/react-native-paper/deployments","created_at":"2016-10-19T05:56:53Z","updated_at":"2017-06-09T10:24:58Z","pushed_at":"2017-06-26T15:47:09Z","git_url":"git://github.com/callstack-io/react-native-paper.git","ssh_url":"[email protected]:callstack-io/react-native-paper.git","clone_url":"https://github.com/callstack-io/react-native-paper.git","svn_url":"https://github.com/callstack-io/react-native-paper","homepage":"https://react-native-paper.github.io","size":10682,"stargazers_count":44,"watchers_count":44,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":34,"forks":8,"open_issues":34,"watchers":44,"default_branch":"master"}},"base":{"label":"callstack-io:master","ref":"master","sha":"d117bb95c0d0ad3f26e3326b060bc14734084b53","user":{"login":"callstack-io","id":17571969,"avatar_url":"https://avatars3.githubusercontent.com/u/17571969?v=3","gravatar_id":"","url":"https://api.github.com/users/callstack-io","html_url":"https://github.com/callstack-io","followers_url":"https://api.github.com/users/callstack-io/followers","following_url":"https://api.github.com/users/callstack-io/following{/other_user}","gists_url":"https://api.github.com/users/callstack-io/gists{/gist_id}","starred_url":"https://api.github.com/users/callstack-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callstack-io/subscriptions","organizations_url":"https://api.github.com/users/callstack-io/orgs","repos_url":"https://api.github.com/users/callstack-io/repos","events_url":"https://api.github.com/users/callstack-io/events{/privacy}","received_events_url":"https://api.github.com/users/callstack-io/received_events","type":"Organization","site_admin":false},"repo":{"id":71323749,"name":"react-native-paper","full_name":"callstack-io/react-native-paper","owner":{"login":"callstack-io","id":17571969,"avatar_url":"https://avatars3.githubusercontent.com/u/17571969?v=3","gravatar_id":"","url":"https://api.github.com/users/callstack-io","html_url":"https://github.com/callstack-io","followers_url":"https://api.github.com/users/callstack-io/followers","following_url":"https://api.github.com/users/callstack-io/following{/other_user}","gists_url":"https://api.github.com/users/callstack-io/gists{/gist_id}","starred_url":"https://api.github.com/users/callstack-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callstack-io/subscriptions","organizations_url":"https://api.github.com/users/callstack-io/orgs","repos_url":"https://api.github.com/users/callstack-io/repos","events_url":"https://api.github.com/users/callstack-io/events{/privacy}","received_events_url":"https://api.github.com/users/callstack-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callstack-io/react-native-paper","description":"Material Design for React Native","fork":false,"url":"https://api.github.com/repos/callstack-io/react-native-paper","forks_url":"https://api.github.com/repos/callstack-io/react-native-paper/forks","keys_url":"https://api.github.com/repos/callstack-io/react-native-paper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callstack-io/react-native-paper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callstack-io/react-native-paper/teams","hooks_url":"https://api.github.com/repos/callstack-io/react-native-paper/hooks","issue_events_url":"https://api.github.com/repos/callstack-io/react-native-paper/issues/events{/number}","events_url":"https://api.github.com/repos/callstack-io/react-native-paper/events","assignees_url":"https://api.github.com/repos/callstack-io/react-native-paper/assignees{/user}","branches_url":"https://api.github.com/repos/callstack-io/react-native-paper/branches{/branch}","tags_url":"https://api.github.com/repos/callstack-io/react-native-paper/tags","blobs_url":"https://api.github.com/repos/callstack-io/react-native-paper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callstack-io/react-native-paper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callstack-io/react-native-paper/git/refs{/sha}","trees_url":"https://api.github.com/repos/callstack-io/react-native-paper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callstack-io/react-native-paper/statuses/{sha}","languages_url":"https://api.github.com/repos/callstack-io/react-native-paper/languages","stargazers_url":"https://api.github.com/repos/callstack-io/react-native-paper/stargazers","contributors_url":"https://api.github.com/repos/callstack-io/react-native-paper/contributors","subscribers_url":"https://api.github.com/repos/callstack-io/react-native-paper/subscribers","subscription_url":"https://api.github.com/repos/callstack-io/react-native-paper/subscription","commits_url":"https://api.github.com/repos/callstack-io/react-native-paper/commits{/sha}","git_commits_url":"https://api.github.com/repos/callstack-io/react-native-paper/git/commits{/sha}","comments_url":"https://api.github.com/repos/callstack-io/react-native-paper/comments{/number}","issue_comment_url":"https://api.github.com/repos/callstack-io/react-native-paper/issues/comments{/number}","contents_url":"https://api.github.com/repos/callstack-io/react-native-paper/contents/{+path}","compare_url":"https://api.github.com/repos/callstack-io/react-native-paper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callstack-io/react-native-paper/merges","archive_url":"https://api.github.com/repos/callstack-io/react-native-paper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callstack-io/react-native-paper/downloads","issues_url":"https://api.github.com/repos/callstack-io/react-native-paper/issues{/number}","pulls_url":"https://api.github.com/repos/callstack-io/react-native-paper/pulls{/number}","milestones_url":"https://api.github.com/repos/callstack-io/react-native-paper/milestones{/number}","notifications_url":"https://api.github.com/repos/callstack-io/react-native-paper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callstack-io/react-native-paper/labels{/name}","releases_url":"https://api.github.com/repos/callstack-io/react-native-paper/releases{/id}","deployments_url":"https://api.github.com/repos/callstack-io/react-native-paper/deployments","created_at":"2016-10-19T05:56:53Z","updated_at":"2017-06-09T10:24:58Z","pushed_at":"2017-06-26T15:47:09Z","git_url":"git://github.com/callstack-io/react-native-paper.git","ssh_url":"[email protected]:callstack-io/react-native-paper.git","clone_url":"https://github.com/callstack-io/react-native-paper.git","svn_url":"https://github.com/callstack-io/react-native-paper","homepage":"https://react-native-paper.github.io","size":10682,"stargazers_count":44,"watchers_count":44,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":34,"forks":8,"open_issues":34,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/callstack-io/react-native-paper/pulls/109"},"html":{"href":"https://github.com/callstack-io/react-native-paper/pull/109"},"issue":{"href":"https://api.github.com/repos/callstack-io/react-native-paper/issues/109"},"comments":{"href":"https://api.github.com/repos/callstack-io/react-native-paper/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/callstack-io/react-native-paper/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/callstack-io/react-native-paper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/callstack-io/react-native-paper/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/callstack-io/react-native-paper/statuses/a52ac9e7ea57a9d5d72ca588ad8511da92682667"}}}}
|
{
"id": 71323749,
"name": "callstack-io/react-native-paper",
"url": "https://api.github.com/repos/callstack-io/react-native-paper"
}
|
{
"id": 774577,
"login": "ferrannp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/774577?",
"url": "https://api.github.com/users/ferrannp"
}
|
{
"id": 17571969,
"login": "callstack-io",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17571969?",
"url": "https://api.github.com/orgs/callstack-io"
}
| 2017-06-26T15:48:14 |
6139061365
|
{"actor":{"display_login":"ferrannp"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/comments/147833039","pull_request_review_id":72985135,"id":147833039,"diff_hunk":"@@ -0,0 +1,75 @@\n+require_relative '../../test_helper'\n+require_relative '../../../middleware/helpers/storage_id'\n+\n+class StorageIdTest < Minitest::Test\n+ def setup\n+ @user_storage_ids_table = PEGASUS_DB[:user_storage_ids]\n+ @initial_num_entries = @user_storage_ids_table.count\n+ end\n+\n+ def teardown\n+ num_entries = @user_storage_ids_table.count\n+ @user_storage_ids_table.order(:id).last(num_entries - @initial_num_entries).each do |entry|\n+ @user_storage_ids_table.where(id: entry[:id]).delete\n+ end\n+ end","path":"shared/test/middleware/helpers/test_storage_id.rb","position":15,"original_position":15,"commit_id":"ca8e76ebaf8883420eced201257b8fdb3632d057","original_commit_id":"ca8e76ebaf8883420eced201257b8fdb3632d057","user":{"login":"Bjvanminnen","id":1767466,"avatar_url":"https://avatars3.githubusercontent.com/u/1767466?v=4","gravatar_id":"","url":"https://api.github.com/users/Bjvanminnen","html_url":"https://github.com/Bjvanminnen","followers_url":"https://api.github.com/users/Bjvanminnen/followers","following_url":"https://api.github.com/users/Bjvanminnen/following{/other_user}","gists_url":"https://api.github.com/users/Bjvanminnen/gists{/gist_id}","starred_url":"https://api.github.com/users/Bjvanminnen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bjvanminnen/subscriptions","organizations_url":"https://api.github.com/users/Bjvanminnen/orgs","repos_url":"https://api.github.com/users/Bjvanminnen/repos","events_url":"https://api.github.com/users/Bjvanminnen/events{/privacy}","received_events_url":"https://api.github.com/users/Bjvanminnen/received_events","type":"User","site_admin":false},"body":"Not sure if there's a better way to do this. I expected to be able to do `@user_storage_ids_table.order(:id).last(num_entries - @initial_num_entries).delete` but that gave me syntax errors.","created_at":"2017-10-30T20:58:52Z","updated_at":"2017-10-30T20:58:52Z","html_url":"https://github.com/code-dot-org/code-dot-org/pull/18748#discussion_r147833039","pull_request_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/18748","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/comments/147833039"},"html":{"href":"https://github.com/code-dot-org/code-dot-org/pull/18748#discussion_r147833039"},"pull_request":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/18748"}}},"pull_request":{"url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/18748","id":149635759,"html_url":"https://github.com/code-dot-org/code-dot-org/pull/18748","diff_url":"https://github.com/code-dot-org/code-dot-org/pull/18748.diff","patch_url":"https://github.com/code-dot-org/code-dot-org/pull/18748.patch","issue_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/18748","number":18748,"state":"open","locked":false,"title":"Remerge: Check applab-intro progress on account creation","user":{"login":"Bjvanminnen","id":1767466,"avatar_url":"https://avatars3.githubusercontent.com/u/1767466?v=4","gravatar_id":"","url":"https://api.github.com/users/Bjvanminnen","html_url":"https://github.com/Bjvanminnen","followers_url":"https://api.github.com/users/Bjvanminnen/followers","following_url":"https://api.github.com/users/Bjvanminnen/following{/other_user}","gists_url":"https://api.github.com/users/Bjvanminnen/gists{/gist_id}","starred_url":"https://api.github.com/users/Bjvanminnen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bjvanminnen/subscriptions","organizations_url":"https://api.github.com/users/Bjvanminnen/orgs","repos_url":"https://api.github.com/users/Bjvanminnen/repos","events_url":"https://api.github.com/users/Bjvanminnen/events{/privacy}","received_events_url":"https://api.github.com/users/Bjvanminnen/received_events","type":"User","site_admin":false},"body":"Initial PR: https://github.com/code-dot-org/code-dot-org/pull/18624\r\nReverted: https://github.com/code-dot-org/code-dot-org/pull/18743 \r\n\r\nThe initial PR caused a bunch of other shared tests to fail with VCR errors. I believe this was because the creation of new entries in `user_storage_ids` table in this test was causing other tests to make HTTP requests with different user_ids than they used to.\r\n\r\nI believe the reason this hadn't failed in circle was because I only recently fixed shared to run all tests (https://github.com/code-dot-org/code-dot-org/pull/18640) and so that probably wasn't happening in the circle run for the initial PR","created_at":"2017-10-30T20:57:53Z","updated_at":"2017-10-30T20:58:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"785b5146d7998a9ae5d577a838f3ab662493b863","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/18748/commits","review_comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/18748/comments","review_comment_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/18748/comments","statuses_url":"https://api.github.com/repos/code-dot-org/code-dot-org/statuses/ca8e76ebaf8883420eced201257b8fdb3632d057","head":{"label":"code-dot-org:userScriptFromStorageId","ref":"userScriptFromStorageId","sha":"ca8e76ebaf8883420eced201257b8fdb3632d057","user":{"login":"code-dot-org","id":5124627,"avatar_url":"https://avatars2.githubusercontent.com/u/5124627?v=4","gravatar_id":"","url":"https://api.github.com/users/code-dot-org","html_url":"https://github.com/code-dot-org","followers_url":"https://api.github.com/users/code-dot-org/followers","following_url":"https://api.github.com/users/code-dot-org/following{/other_user}","gists_url":"https://api.github.com/users/code-dot-org/gists{/gist_id}","starred_url":"https://api.github.com/users/code-dot-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-dot-org/subscriptions","organizations_url":"https://api.github.com/users/code-dot-org/orgs","repos_url":"https://api.github.com/users/code-dot-org/repos","events_url":"https://api.github.com/users/code-dot-org/events{/privacy}","received_events_url":"https://api.github.com/users/code-dot-org/received_events","type":"Organization","site_admin":false},"repo":{"id":24250009,"name":"code-dot-org","full_name":"code-dot-org/code-dot-org","owner":{"login":"code-dot-org","id":5124627,"avatar_url":"https://avatars2.githubusercontent.com/u/5124627?v=4","gravatar_id":"","url":"https://api.github.com/users/code-dot-org","html_url":"https://github.com/code-dot-org","followers_url":"https://api.github.com/users/code-dot-org/followers","following_url":"https://api.github.com/users/code-dot-org/following{/other_user}","gists_url":"https://api.github.com/users/code-dot-org/gists{/gist_id}","starred_url":"https://api.github.com/users/code-dot-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-dot-org/subscriptions","organizations_url":"https://api.github.com/users/code-dot-org/orgs","repos_url":"https://api.github.com/users/code-dot-org/repos","events_url":"https://api.github.com/users/code-dot-org/events{/privacy}","received_events_url":"https://api.github.com/users/code-dot-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/code-dot-org/code-dot-org","description":"The code powering code.org and studio.code.org","fork":false,"url":"https://api.github.com/repos/code-dot-org/code-dot-org","forks_url":"https://api.github.com/repos/code-dot-org/code-dot-org/forks","keys_url":"https://api.github.com/repos/code-dot-org/code-dot-org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-dot-org/code-dot-org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-dot-org/code-dot-org/teams","hooks_url":"https://api.github.com/repos/code-dot-org/code-dot-org/hooks","issue_events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/events{/number}","events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/events","assignees_url":"https://api.github.com/repos/code-dot-org/code-dot-org/assignees{/user}","branches_url":"https://api.github.com/repos/code-dot-org/code-dot-org/branches{/branch}","tags_url":"https://api.github.com/repos/code-dot-org/code-dot-org/tags","blobs_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-dot-org/code-dot-org/statuses/{sha}","languages_url":"https://api.github.com/repos/code-dot-org/code-dot-org/languages","stargazers_url":"https://api.github.com/repos/code-dot-org/code-dot-org/stargazers","contributors_url":"https://api.github.com/repos/code-dot-org/code-dot-org/contributors","subscribers_url":"https://api.github.com/repos/code-dot-org/code-dot-org/subscribers","subscription_url":"https://api.github.com/repos/code-dot-org/code-dot-org/subscription","commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-dot-org/code-dot-org/contents/{+path}","compare_url":"https://api.github.com/repos/code-dot-org/code-dot-org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-dot-org/code-dot-org/merges","archive_url":"https://api.github.com/repos/code-dot-org/code-dot-org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-dot-org/code-dot-org/downloads","issues_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues{/number}","pulls_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls{/number}","milestones_url":"https://api.github.com/repos/code-dot-org/code-dot-org/milestones{/number}","notifications_url":"https://api.github.com/repos/code-dot-org/code-dot-org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-dot-org/code-dot-org/labels{/name}","releases_url":"https://api.github.com/repos/code-dot-org/code-dot-org/releases{/id}","deployments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/deployments","created_at":"2014-09-20T00:46:11Z","updated_at":"2017-10-26T06:07:24Z","pushed_at":"2017-10-30T20:57:54Z","git_url":"git://github.com/code-dot-org/code-dot-org.git","ssh_url":"[email protected]:code-dot-org/code-dot-org.git","clone_url":"https://github.com/code-dot-org/code-dot-org.git","svn_url":"https://github.com/code-dot-org/code-dot-org","homepage":"http://code.org","size":6023928,"stargazers_count":216,"watchers_count":216,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":137,"mirror_url":null,"archived":false,"open_issues_count":108,"forks":137,"open_issues":108,"watchers":216,"default_branch":"staging"}},"base":{"label":"code-dot-org:staging","ref":"staging","sha":"e31d7708a50b9958495fa91ff169cf33f838883b","user":{"login":"code-dot-org","id":5124627,"avatar_url":"https://avatars2.githubusercontent.com/u/5124627?v=4","gravatar_id":"","url":"https://api.github.com/users/code-dot-org","html_url":"https://github.com/code-dot-org","followers_url":"https://api.github.com/users/code-dot-org/followers","following_url":"https://api.github.com/users/code-dot-org/following{/other_user}","gists_url":"https://api.github.com/users/code-dot-org/gists{/gist_id}","starred_url":"https://api.github.com/users/code-dot-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-dot-org/subscriptions","organizations_url":"https://api.github.com/users/code-dot-org/orgs","repos_url":"https://api.github.com/users/code-dot-org/repos","events_url":"https://api.github.com/users/code-dot-org/events{/privacy}","received_events_url":"https://api.github.com/users/code-dot-org/received_events","type":"Organization","site_admin":false},"repo":{"id":24250009,"name":"code-dot-org","full_name":"code-dot-org/code-dot-org","owner":{"login":"code-dot-org","id":5124627,"avatar_url":"https://avatars2.githubusercontent.com/u/5124627?v=4","gravatar_id":"","url":"https://api.github.com/users/code-dot-org","html_url":"https://github.com/code-dot-org","followers_url":"https://api.github.com/users/code-dot-org/followers","following_url":"https://api.github.com/users/code-dot-org/following{/other_user}","gists_url":"https://api.github.com/users/code-dot-org/gists{/gist_id}","starred_url":"https://api.github.com/users/code-dot-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-dot-org/subscriptions","organizations_url":"https://api.github.com/users/code-dot-org/orgs","repos_url":"https://api.github.com/users/code-dot-org/repos","events_url":"https://api.github.com/users/code-dot-org/events{/privacy}","received_events_url":"https://api.github.com/users/code-dot-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/code-dot-org/code-dot-org","description":"The code powering code.org and studio.code.org","fork":false,"url":"https://api.github.com/repos/code-dot-org/code-dot-org","forks_url":"https://api.github.com/repos/code-dot-org/code-dot-org/forks","keys_url":"https://api.github.com/repos/code-dot-org/code-dot-org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-dot-org/code-dot-org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-dot-org/code-dot-org/teams","hooks_url":"https://api.github.com/repos/code-dot-org/code-dot-org/hooks","issue_events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/events{/number}","events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/events","assignees_url":"https://api.github.com/repos/code-dot-org/code-dot-org/assignees{/user}","branches_url":"https://api.github.com/repos/code-dot-org/code-dot-org/branches{/branch}","tags_url":"https://api.github.com/repos/code-dot-org/code-dot-org/tags","blobs_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-dot-org/code-dot-org/statuses/{sha}","languages_url":"https://api.github.com/repos/code-dot-org/code-dot-org/languages","stargazers_url":"https://api.github.com/repos/code-dot-org/code-dot-org/stargazers","contributors_url":"https://api.github.com/repos/code-dot-org/code-dot-org/contributors","subscribers_url":"https://api.github.com/repos/code-dot-org/code-dot-org/subscribers","subscription_url":"https://api.github.com/repos/code-dot-org/code-dot-org/subscription","commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-dot-org/code-dot-org/contents/{+path}","compare_url":"https://api.github.com/repos/code-dot-org/code-dot-org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-dot-org/code-dot-org/merges","archive_url":"https://api.github.com/repos/code-dot-org/code-dot-org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-dot-org/code-dot-org/downloads","issues_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues{/number}","pulls_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls{/number}","milestones_url":"https://api.github.com/repos/code-dot-org/code-dot-org/milestones{/number}","notifications_url":"https://api.github.com/repos/code-dot-org/code-dot-org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-dot-org/code-dot-org/labels{/name}","releases_url":"https://api.github.com/repos/code-dot-org/code-dot-org/releases{/id}","deployments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/deployments","created_at":"2014-09-20T00:46:11Z","updated_at":"2017-10-26T06:07:24Z","pushed_at":"2017-10-30T20:57:54Z","git_url":"git://github.com/code-dot-org/code-dot-org.git","ssh_url":"[email protected]:code-dot-org/code-dot-org.git","clone_url":"https://github.com/code-dot-org/code-dot-org.git","svn_url":"https://github.com/code-dot-org/code-dot-org","homepage":"http://code.org","size":6023928,"stargazers_count":216,"watchers_count":216,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":137,"mirror_url":null,"archived":false,"open_issues_count":108,"forks":137,"open_issues":108,"watchers":216,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/18748"},"html":{"href":"https://github.com/code-dot-org/code-dot-org/pull/18748"},"issue":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/18748"},"comments":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/18748/comments"},"review_comments":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/18748/comments"},"review_comment":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/18748/commits"},"statuses":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/statuses/ca8e76ebaf8883420eced201257b8fdb3632d057"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 24250009,
"name": "code-dot-org/code-dot-org",
"url": "https://api.github.com/repos/code-dot-org/code-dot-org"
}
|
{
"id": 1767466,
"login": "Bjvanminnen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1767466?",
"url": "https://api.github.com/users/Bjvanminnen"
}
|
{
"id": 5124627,
"login": "code-dot-org",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5124627?",
"url": "https://api.github.com/orgs/code-dot-org"
}
| 2017-10-30T20:58:52 |
6786186352
|
{"actor":{"display_login":"Bjvanminnen"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/comments/115794554","pull_request_review_id":37364912,"id":115794554,"diff_hunk":"@@ -465,23 +465,23 @@ def copy_file(endpoint, encrypted_channel_id, filename, source_filename)\n end\n end\n \n+ #\n+ # NOTE: The files API that we expose is case-insensitive, though AWS s3 is case-sensitive. As a\n+ # result, we normalize s3 filenames to be downcased. That said, we maintain a case-sensitive\n+ # manifest.\n+ #\n def files_put_file(encrypted_channel_id, filename, body)\n- bad_request if filename.downcase == FileBucket::MANIFEST_FILENAME\n+ downcased_filename = filename.downcase\n+ bad_request if downcased_filename == FileBucket::MANIFEST_FILENAME","path":"shared/middleware/files_api.rb","position":12,"original_position":12,"commit_id":"3ac7f02c5855ec86a2ecff8918ac47e4cb151f29","original_commit_id":"3ac7f02c5855ec86a2ecff8918ac47e4cb151f29","user":{"login":"islemaster","id":1615761,"avatar_url":"https://avatars3.githubusercontent.com/u/1615761?v=3","gravatar_id":"","url":"https://api.github.com/users/islemaster","html_url":"https://github.com/islemaster","followers_url":"https://api.github.com/users/islemaster/followers","following_url":"https://api.github.com/users/islemaster/following{/other_user}","gists_url":"https://api.github.com/users/islemaster/gists{/gist_id}","starred_url":"https://api.github.com/users/islemaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/islemaster/subscriptions","organizations_url":"https://api.github.com/users/islemaster/orgs","repos_url":"https://api.github.com/users/islemaster/repos","events_url":"https://api.github.com/users/islemaster/events{/privacy}","received_events_url":"https://api.github.com/users/islemaster/received_events","type":"User","site_admin":false},"body":":( Looks like coverage isn't getting reported correctly for shared tests? Maybe I'll take a look today.","created_at":"2017-05-10T16:54:44Z","updated_at":"2017-05-10T16:54:44Z","html_url":"https://github.com/code-dot-org/code-dot-org/pull/14972#discussion_r115794554","pull_request_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/14972","_links":{"self":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/comments/115794554"},"html":{"href":"https://github.com/code-dot-org/code-dot-org/pull/14972#discussion_r115794554"},"pull_request":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/14972"}}},"pull_request":{"url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/14972","id":119901948,"html_url":"https://github.com/code-dot-org/code-dot-org/pull/14972","diff_url":"https://github.com/code-dot-org/code-dot-org/pull/14972.diff","patch_url":"https://github.com/code-dot-org/code-dot-org/pull/14972.patch","issue_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/14972","number":14972,"state":"open","locked":false,"title":"Create get_manifest helper. Variablize filename.downcase.","user":{"login":"ashercodeorg","id":14206260,"avatar_url":"https://avatars0.githubusercontent.com/u/14206260?v=3","gravatar_id":"","url":"https://api.github.com/users/ashercodeorg","html_url":"https://github.com/ashercodeorg","followers_url":"https://api.github.com/users/ashercodeorg/followers","following_url":"https://api.github.com/users/ashercodeorg/following{/other_user}","gists_url":"https://api.github.com/users/ashercodeorg/gists{/gist_id}","starred_url":"https://api.github.com/users/ashercodeorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashercodeorg/subscriptions","organizations_url":"https://api.github.com/users/ashercodeorg/orgs","repos_url":"https://api.github.com/users/ashercodeorg/repos","events_url":"https://api.github.com/users/ashercodeorg/events{/privacy}","received_events_url":"https://api.github.com/users/ashercodeorg/received_events","type":"User","site_admin":false},"body":"Also adds a few tests for existing functionality.","created_at":"2017-05-10T14:47:56Z","updated_at":"2017-05-10T16:54:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e95b5fe8bc9e7ab2cd5b01a2fe28d55a8a33654","assignee":null,"assignees":[],"requested_reviewers":[{"login":"davidsbailey","id":8001765,"avatar_url":"https://avatars0.githubusercontent.com/u/8001765?v=3","gravatar_id":"","url":"https://api.github.com/users/davidsbailey","html_url":"https://github.com/davidsbailey","followers_url":"https://api.github.com/users/davidsbailey/followers","following_url":"https://api.github.com/users/davidsbailey/following{/other_user}","gists_url":"https://api.github.com/users/davidsbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsbailey/subscriptions","organizations_url":"https://api.github.com/users/davidsbailey/orgs","repos_url":"https://api.github.com/users/davidsbailey/repos","events_url":"https://api.github.com/users/davidsbailey/events{/privacy}","received_events_url":"https://api.github.com/users/davidsbailey/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/14972/commits","review_comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/14972/comments","review_comment_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/14972/comments","statuses_url":"https://api.github.com/repos/code-dot-org/code-dot-org/statuses/3ac7f02c5855ec86a2ecff8918ac47e4cb151f29","head":{"label":"code-dot-org:cleanupFilesPutFile","ref":"cleanupFilesPutFile","sha":"3ac7f02c5855ec86a2ecff8918ac47e4cb151f29","user":{"login":"code-dot-org","id":5124627,"avatar_url":"https://avatars1.githubusercontent.com/u/5124627?v=3","gravatar_id":"","url":"https://api.github.com/users/code-dot-org","html_url":"https://github.com/code-dot-org","followers_url":"https://api.github.com/users/code-dot-org/followers","following_url":"https://api.github.com/users/code-dot-org/following{/other_user}","gists_url":"https://api.github.com/users/code-dot-org/gists{/gist_id}","starred_url":"https://api.github.com/users/code-dot-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-dot-org/subscriptions","organizations_url":"https://api.github.com/users/code-dot-org/orgs","repos_url":"https://api.github.com/users/code-dot-org/repos","events_url":"https://api.github.com/users/code-dot-org/events{/privacy}","received_events_url":"https://api.github.com/users/code-dot-org/received_events","type":"Organization","site_admin":false},"repo":{"id":24250009,"name":"code-dot-org","full_name":"code-dot-org/code-dot-org","owner":{"login":"code-dot-org","id":5124627,"avatar_url":"https://avatars1.githubusercontent.com/u/5124627?v=3","gravatar_id":"","url":"https://api.github.com/users/code-dot-org","html_url":"https://github.com/code-dot-org","followers_url":"https://api.github.com/users/code-dot-org/followers","following_url":"https://api.github.com/users/code-dot-org/following{/other_user}","gists_url":"https://api.github.com/users/code-dot-org/gists{/gist_id}","starred_url":"https://api.github.com/users/code-dot-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-dot-org/subscriptions","organizations_url":"https://api.github.com/users/code-dot-org/orgs","repos_url":"https://api.github.com/users/code-dot-org/repos","events_url":"https://api.github.com/users/code-dot-org/events{/privacy}","received_events_url":"https://api.github.com/users/code-dot-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/code-dot-org/code-dot-org","description":"The code powering code.org and studio.code.org","fork":false,"url":"https://api.github.com/repos/code-dot-org/code-dot-org","forks_url":"https://api.github.com/repos/code-dot-org/code-dot-org/forks","keys_url":"https://api.github.com/repos/code-dot-org/code-dot-org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-dot-org/code-dot-org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-dot-org/code-dot-org/teams","hooks_url":"https://api.github.com/repos/code-dot-org/code-dot-org/hooks","issue_events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/events{/number}","events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/events","assignees_url":"https://api.github.com/repos/code-dot-org/code-dot-org/assignees{/user}","branches_url":"https://api.github.com/repos/code-dot-org/code-dot-org/branches{/branch}","tags_url":"https://api.github.com/repos/code-dot-org/code-dot-org/tags","blobs_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-dot-org/code-dot-org/statuses/{sha}","languages_url":"https://api.github.com/repos/code-dot-org/code-dot-org/languages","stargazers_url":"https://api.github.com/repos/code-dot-org/code-dot-org/stargazers","contributors_url":"https://api.github.com/repos/code-dot-org/code-dot-org/contributors","subscribers_url":"https://api.github.com/repos/code-dot-org/code-dot-org/subscribers","subscription_url":"https://api.github.com/repos/code-dot-org/code-dot-org/subscription","commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-dot-org/code-dot-org/contents/{+path}","compare_url":"https://api.github.com/repos/code-dot-org/code-dot-org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-dot-org/code-dot-org/merges","archive_url":"https://api.github.com/repos/code-dot-org/code-dot-org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-dot-org/code-dot-org/downloads","issues_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues{/number}","pulls_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls{/number}","milestones_url":"https://api.github.com/repos/code-dot-org/code-dot-org/milestones{/number}","notifications_url":"https://api.github.com/repos/code-dot-org/code-dot-org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-dot-org/code-dot-org/labels{/name}","releases_url":"https://api.github.com/repos/code-dot-org/code-dot-org/releases{/id}","deployments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/deployments","created_at":"2014-09-20T00:46:11Z","updated_at":"2017-05-08T19:39:19Z","pushed_at":"2017-05-10T16:53:38Z","git_url":"git://github.com/code-dot-org/code-dot-org.git","ssh_url":"[email protected]:code-dot-org/code-dot-org.git","clone_url":"https://github.com/code-dot-org/code-dot-org.git","svn_url":"https://github.com/code-dot-org/code-dot-org","homepage":"http://code.org","size":5442230,"stargazers_count":185,"watchers_count":185,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":114,"mirror_url":null,"open_issues_count":89,"forks":114,"open_issues":89,"watchers":185,"default_branch":"staging"}},"base":{"label":"code-dot-org:staging","ref":"staging","sha":"d0be95dd8923299ef0fefcf0cff69dc39d7013c3","user":{"login":"code-dot-org","id":5124627,"avatar_url":"https://avatars1.githubusercontent.com/u/5124627?v=3","gravatar_id":"","url":"https://api.github.com/users/code-dot-org","html_url":"https://github.com/code-dot-org","followers_url":"https://api.github.com/users/code-dot-org/followers","following_url":"https://api.github.com/users/code-dot-org/following{/other_user}","gists_url":"https://api.github.com/users/code-dot-org/gists{/gist_id}","starred_url":"https://api.github.com/users/code-dot-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-dot-org/subscriptions","organizations_url":"https://api.github.com/users/code-dot-org/orgs","repos_url":"https://api.github.com/users/code-dot-org/repos","events_url":"https://api.github.com/users/code-dot-org/events{/privacy}","received_events_url":"https://api.github.com/users/code-dot-org/received_events","type":"Organization","site_admin":false},"repo":{"id":24250009,"name":"code-dot-org","full_name":"code-dot-org/code-dot-org","owner":{"login":"code-dot-org","id":5124627,"avatar_url":"https://avatars1.githubusercontent.com/u/5124627?v=3","gravatar_id":"","url":"https://api.github.com/users/code-dot-org","html_url":"https://github.com/code-dot-org","followers_url":"https://api.github.com/users/code-dot-org/followers","following_url":"https://api.github.com/users/code-dot-org/following{/other_user}","gists_url":"https://api.github.com/users/code-dot-org/gists{/gist_id}","starred_url":"https://api.github.com/users/code-dot-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-dot-org/subscriptions","organizations_url":"https://api.github.com/users/code-dot-org/orgs","repos_url":"https://api.github.com/users/code-dot-org/repos","events_url":"https://api.github.com/users/code-dot-org/events{/privacy}","received_events_url":"https://api.github.com/users/code-dot-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/code-dot-org/code-dot-org","description":"The code powering code.org and studio.code.org","fork":false,"url":"https://api.github.com/repos/code-dot-org/code-dot-org","forks_url":"https://api.github.com/repos/code-dot-org/code-dot-org/forks","keys_url":"https://api.github.com/repos/code-dot-org/code-dot-org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-dot-org/code-dot-org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-dot-org/code-dot-org/teams","hooks_url":"https://api.github.com/repos/code-dot-org/code-dot-org/hooks","issue_events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/events{/number}","events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/events","assignees_url":"https://api.github.com/repos/code-dot-org/code-dot-org/assignees{/user}","branches_url":"https://api.github.com/repos/code-dot-org/code-dot-org/branches{/branch}","tags_url":"https://api.github.com/repos/code-dot-org/code-dot-org/tags","blobs_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-dot-org/code-dot-org/statuses/{sha}","languages_url":"https://api.github.com/repos/code-dot-org/code-dot-org/languages","stargazers_url":"https://api.github.com/repos/code-dot-org/code-dot-org/stargazers","contributors_url":"https://api.github.com/repos/code-dot-org/code-dot-org/contributors","subscribers_url":"https://api.github.com/repos/code-dot-org/code-dot-org/subscribers","subscription_url":"https://api.github.com/repos/code-dot-org/code-dot-org/subscription","commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-dot-org/code-dot-org/contents/{+path}","compare_url":"https://api.github.com/repos/code-dot-org/code-dot-org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-dot-org/code-dot-org/merges","archive_url":"https://api.github.com/repos/code-dot-org/code-dot-org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-dot-org/code-dot-org/downloads","issues_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues{/number}","pulls_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls{/number}","milestones_url":"https://api.github.com/repos/code-dot-org/code-dot-org/milestones{/number}","notifications_url":"https://api.github.com/repos/code-dot-org/code-dot-org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-dot-org/code-dot-org/labels{/name}","releases_url":"https://api.github.com/repos/code-dot-org/code-dot-org/releases{/id}","deployments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/deployments","created_at":"2014-09-20T00:46:11Z","updated_at":"2017-05-08T19:39:19Z","pushed_at":"2017-05-10T16:53:38Z","git_url":"git://github.com/code-dot-org/code-dot-org.git","ssh_url":"[email protected]:code-dot-org/code-dot-org.git","clone_url":"https://github.com/code-dot-org/code-dot-org.git","svn_url":"https://github.com/code-dot-org/code-dot-org","homepage":"http://code.org","size":5442230,"stargazers_count":185,"watchers_count":185,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":114,"mirror_url":null,"open_issues_count":89,"forks":114,"open_issues":89,"watchers":185,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/14972"},"html":{"href":"https://github.com/code-dot-org/code-dot-org/pull/14972"},"issue":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/14972"},"comments":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/14972/comments"},"review_comments":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/14972/comments"},"review_comment":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/14972/commits"},"statuses":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/statuses/3ac7f02c5855ec86a2ecff8918ac47e4cb151f29"}}}}
|
{
"id": 24250009,
"name": "code-dot-org/code-dot-org",
"url": "https://api.github.com/repos/code-dot-org/code-dot-org"
}
|
{
"id": 1615761,
"login": "islemaster",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1615761?",
"url": "https://api.github.com/users/islemaster"
}
|
{
"id": 5124627,
"login": "code-dot-org",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5124627?",
"url": "https://api.github.com/orgs/code-dot-org"
}
| 2017-05-10T16:54:44 |
5846767958
|
{"actor":{"display_login":"islemaster"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/comments/108572432","pull_request_review_id":29612038,"id":108572432,"diff_hunk":"@@ -542,21 +542,14 @@ var projects = module.exports = {\n if (typeof arguments[0] === 'function' || !sourceAndHtml) {\n // If no source is provided, shift the arguments and ask for the source\n // ourselves.\n- var args = Array.prototype.slice.apply(arguments);\n+ const args = Array.prototype.slice.apply(arguments);","path":"apps/src/code-studio/initApp/project.js","position":5,"original_position":5,"commit_id":"fa53ae9f09c22a6129123a87f650257807b8248b","original_commit_id":"fa53ae9f09c22a6129123a87f650257807b8248b","user":{"login":"islemaster","id":1615761,"avatar_url":"https://avatars3.githubusercontent.com/u/1615761?v=3","gravatar_id":"","url":"https://api.github.com/users/islemaster","html_url":"https://github.com/islemaster","followers_url":"https://api.github.com/users/islemaster/followers","following_url":"https://api.github.com/users/islemaster/following{/other_user}","gists_url":"https://api.github.com/users/islemaster/gists{/gist_id}","starred_url":"https://api.github.com/users/islemaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/islemaster/subscriptions","organizations_url":"https://api.github.com/users/islemaster/orgs","repos_url":"https://api.github.com/users/islemaster/repos","events_url":"https://api.github.com/users/islemaster/events{/privacy}","received_events_url":"https://api.github.com/users/islemaster/received_events","type":"User","site_admin":false},"body":"I always forget about this, and am pro-es6ifying everything as we go. Thanks for pointing this out.","created_at":"2017-03-29T00:58:19Z","updated_at":"2017-03-29T00:58:19Z","html_url":"https://github.com/code-dot-org/code-dot-org/pull/13958#discussion_r108572432","pull_request_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/13958","_links":{"self":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/comments/108572432"},"html":{"href":"https://github.com/code-dot-org/code-dot-org/pull/13958#discussion_r108572432"},"pull_request":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/13958"}}},"pull_request":{"url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/13958","id":112143535,"html_url":"https://github.com/code-dot-org/code-dot-org/pull/13958","diff_url":"https://github.com/code-dot-org/code-dot-org/pull/13958.diff","patch_url":"https://github.com/code-dot-org/code-dot-org/pull/13958.patch","issue_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/13958","number":13958,"state":"open","locked":false,"title":"Maker: Enable/disable via settings cog","user":{"login":"islemaster","id":1615761,"avatar_url":"https://avatars3.githubusercontent.com/u/1615761?v=3","gravatar_id":"","url":"https://api.github.com/users/islemaster","html_url":"https://github.com/islemaster","followers_url":"https://api.github.com/users/islemaster/followers","following_url":"https://api.github.com/users/islemaster/following{/other_user}","gists_url":"https://api.github.com/users/islemaster/gists{/gist_id}","starred_url":"https://api.github.com/users/islemaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/islemaster/subscriptions","organizations_url":"https://api.github.com/users/islemaster/orgs","repos_url":"https://api.github.com/users/islemaster/repos","events_url":"https://api.github.com/users/islemaster/events{/privacy}","received_events_url":"https://api.github.com/users/islemaster/received_events","type":"User","site_admin":false},"body":"\r\n\r\nProvides a way to enable and disable Maker Toolkit from the App Lab UI. ([Spec](https://docs.google.com/document/d/1QT8As_iDcEJDrzUN5Uc3GnsAix8kBmNt4Ufjd6a7iJ0/edit#heading=h.c0jymslyyefe))\r\n\r\n* Changes the gear in design mode that opens the asset manager so that it opens a menu.\r\n* Adds the gear to the toolbox header in code mode (which also adds it to gamelab).\r\n* Adds an enable/disable maker option to that menu if maker is available.\r\n\r\nNotes: This will affect eyes tests. This is a big diff, and a lot of it is test cleanup and test coverage for the new components.","created_at":"2017-03-23T01:08:22Z","updated_at":"2017-03-29T00:58:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fff7c7e28f53fd50c9ffeb52db4a1a06535c75bf","assignee":{"login":"islemaster","id":1615761,"avatar_url":"https://avatars3.githubusercontent.com/u/1615761?v=3","gravatar_id":"","url":"https://api.github.com/users/islemaster","html_url":"https://github.com/islemaster","followers_url":"https://api.github.com/users/islemaster/followers","following_url":"https://api.github.com/users/islemaster/following{/other_user}","gists_url":"https://api.github.com/users/islemaster/gists{/gist_id}","starred_url":"https://api.github.com/users/islemaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/islemaster/subscriptions","organizations_url":"https://api.github.com/users/islemaster/orgs","repos_url":"https://api.github.com/users/islemaster/repos","events_url":"https://api.github.com/users/islemaster/events{/privacy}","received_events_url":"https://api.github.com/users/islemaster/received_events","type":"User","site_admin":false},"assignees":[{"login":"islemaster","id":1615761,"avatar_url":"https://avatars3.githubusercontent.com/u/1615761?v=3","gravatar_id":"","url":"https://api.github.com/users/islemaster","html_url":"https://github.com/islemaster","followers_url":"https://api.github.com/users/islemaster/followers","following_url":"https://api.github.com/users/islemaster/following{/other_user}","gists_url":"https://api.github.com/users/islemaster/gists{/gist_id}","starred_url":"https://api.github.com/users/islemaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/islemaster/subscriptions","organizations_url":"https://api.github.com/users/islemaster/orgs","repos_url":"https://api.github.com/users/islemaster/repos","events_url":"https://api.github.com/users/islemaster/events{/privacy}","received_events_url":"https://api.github.com/users/islemaster/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/13958/commits","review_comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/13958/comments","review_comment_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/13958/comments","statuses_url":"https://api.github.com/repos/code-dot-org/code-dot-org/statuses/fa53ae9f09c22a6129123a87f650257807b8248b","head":{"label":"code-dot-org:maker-enable-from-menu","ref":"maker-enable-from-menu","sha":"fa53ae9f09c22a6129123a87f650257807b8248b","user":{"login":"code-dot-org","id":5124627,"avatar_url":"https://avatars1.githubusercontent.com/u/5124627?v=3","gravatar_id":"","url":"https://api.github.com/users/code-dot-org","html_url":"https://github.com/code-dot-org","followers_url":"https://api.github.com/users/code-dot-org/followers","following_url":"https://api.github.com/users/code-dot-org/following{/other_user}","gists_url":"https://api.github.com/users/code-dot-org/gists{/gist_id}","starred_url":"https://api.github.com/users/code-dot-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-dot-org/subscriptions","organizations_url":"https://api.github.com/users/code-dot-org/orgs","repos_url":"https://api.github.com/users/code-dot-org/repos","events_url":"https://api.github.com/users/code-dot-org/events{/privacy}","received_events_url":"https://api.github.com/users/code-dot-org/received_events","type":"Organization","site_admin":false},"repo":{"id":24250009,"name":"code-dot-org","full_name":"code-dot-org/code-dot-org","owner":{"login":"code-dot-org","id":5124627,"avatar_url":"https://avatars1.githubusercontent.com/u/5124627?v=3","gravatar_id":"","url":"https://api.github.com/users/code-dot-org","html_url":"https://github.com/code-dot-org","followers_url":"https://api.github.com/users/code-dot-org/followers","following_url":"https://api.github.com/users/code-dot-org/following{/other_user}","gists_url":"https://api.github.com/users/code-dot-org/gists{/gist_id}","starred_url":"https://api.github.com/users/code-dot-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-dot-org/subscriptions","organizations_url":"https://api.github.com/users/code-dot-org/orgs","repos_url":"https://api.github.com/users/code-dot-org/repos","events_url":"https://api.github.com/users/code-dot-org/events{/privacy}","received_events_url":"https://api.github.com/users/code-dot-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/code-dot-org/code-dot-org","description":"The code powering code.org and studio.code.org","fork":false,"url":"https://api.github.com/repos/code-dot-org/code-dot-org","forks_url":"https://api.github.com/repos/code-dot-org/code-dot-org/forks","keys_url":"https://api.github.com/repos/code-dot-org/code-dot-org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-dot-org/code-dot-org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-dot-org/code-dot-org/teams","hooks_url":"https://api.github.com/repos/code-dot-org/code-dot-org/hooks","issue_events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/events{/number}","events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/events","assignees_url":"https://api.github.com/repos/code-dot-org/code-dot-org/assignees{/user}","branches_url":"https://api.github.com/repos/code-dot-org/code-dot-org/branches{/branch}","tags_url":"https://api.github.com/repos/code-dot-org/code-dot-org/tags","blobs_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-dot-org/code-dot-org/statuses/{sha}","languages_url":"https://api.github.com/repos/code-dot-org/code-dot-org/languages","stargazers_url":"https://api.github.com/repos/code-dot-org/code-dot-org/stargazers","contributors_url":"https://api.github.com/repos/code-dot-org/code-dot-org/contributors","subscribers_url":"https://api.github.com/repos/code-dot-org/code-dot-org/subscribers","subscription_url":"https://api.github.com/repos/code-dot-org/code-dot-org/subscription","commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-dot-org/code-dot-org/contents/{+path}","compare_url":"https://api.github.com/repos/code-dot-org/code-dot-org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-dot-org/code-dot-org/merges","archive_url":"https://api.github.com/repos/code-dot-org/code-dot-org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-dot-org/code-dot-org/downloads","issues_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues{/number}","pulls_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls{/number}","milestones_url":"https://api.github.com/repos/code-dot-org/code-dot-org/milestones{/number}","notifications_url":"https://api.github.com/repos/code-dot-org/code-dot-org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-dot-org/code-dot-org/labels{/name}","releases_url":"https://api.github.com/repos/code-dot-org/code-dot-org/releases{/id}","deployments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/deployments","created_at":"2014-09-20T00:46:11Z","updated_at":"2017-03-28T14:59:33Z","pushed_at":"2017-03-29T00:54:57Z","git_url":"git://github.com/code-dot-org/code-dot-org.git","ssh_url":"[email protected]:code-dot-org/code-dot-org.git","clone_url":"https://github.com/code-dot-org/code-dot-org.git","svn_url":"https://github.com/code-dot-org/code-dot-org","homepage":"http://code.org","size":5325793,"stargazers_count":179,"watchers_count":179,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":108,"mirror_url":null,"open_issues_count":77,"forks":108,"open_issues":77,"watchers":179,"default_branch":"staging"}},"base":{"label":"code-dot-org:staging","ref":"staging","sha":"f4371fe580362e60586ae96c386343cb06786e65","user":{"login":"code-dot-org","id":5124627,"avatar_url":"https://avatars1.githubusercontent.com/u/5124627?v=3","gravatar_id":"","url":"https://api.github.com/users/code-dot-org","html_url":"https://github.com/code-dot-org","followers_url":"https://api.github.com/users/code-dot-org/followers","following_url":"https://api.github.com/users/code-dot-org/following{/other_user}","gists_url":"https://api.github.com/users/code-dot-org/gists{/gist_id}","starred_url":"https://api.github.com/users/code-dot-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-dot-org/subscriptions","organizations_url":"https://api.github.com/users/code-dot-org/orgs","repos_url":"https://api.github.com/users/code-dot-org/repos","events_url":"https://api.github.com/users/code-dot-org/events{/privacy}","received_events_url":"https://api.github.com/users/code-dot-org/received_events","type":"Organization","site_admin":false},"repo":{"id":24250009,"name":"code-dot-org","full_name":"code-dot-org/code-dot-org","owner":{"login":"code-dot-org","id":5124627,"avatar_url":"https://avatars1.githubusercontent.com/u/5124627?v=3","gravatar_id":"","url":"https://api.github.com/users/code-dot-org","html_url":"https://github.com/code-dot-org","followers_url":"https://api.github.com/users/code-dot-org/followers","following_url":"https://api.github.com/users/code-dot-org/following{/other_user}","gists_url":"https://api.github.com/users/code-dot-org/gists{/gist_id}","starred_url":"https://api.github.com/users/code-dot-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-dot-org/subscriptions","organizations_url":"https://api.github.com/users/code-dot-org/orgs","repos_url":"https://api.github.com/users/code-dot-org/repos","events_url":"https://api.github.com/users/code-dot-org/events{/privacy}","received_events_url":"https://api.github.com/users/code-dot-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/code-dot-org/code-dot-org","description":"The code powering code.org and studio.code.org","fork":false,"url":"https://api.github.com/repos/code-dot-org/code-dot-org","forks_url":"https://api.github.com/repos/code-dot-org/code-dot-org/forks","keys_url":"https://api.github.com/repos/code-dot-org/code-dot-org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-dot-org/code-dot-org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-dot-org/code-dot-org/teams","hooks_url":"https://api.github.com/repos/code-dot-org/code-dot-org/hooks","issue_events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/events{/number}","events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/events","assignees_url":"https://api.github.com/repos/code-dot-org/code-dot-org/assignees{/user}","branches_url":"https://api.github.com/repos/code-dot-org/code-dot-org/branches{/branch}","tags_url":"https://api.github.com/repos/code-dot-org/code-dot-org/tags","blobs_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-dot-org/code-dot-org/statuses/{sha}","languages_url":"https://api.github.com/repos/code-dot-org/code-dot-org/languages","stargazers_url":"https://api.github.com/repos/code-dot-org/code-dot-org/stargazers","contributors_url":"https://api.github.com/repos/code-dot-org/code-dot-org/contributors","subscribers_url":"https://api.github.com/repos/code-dot-org/code-dot-org/subscribers","subscription_url":"https://api.github.com/repos/code-dot-org/code-dot-org/subscription","commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-dot-org/code-dot-org/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-dot-org/code-dot-org/contents/{+path}","compare_url":"https://api.github.com/repos/code-dot-org/code-dot-org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-dot-org/code-dot-org/merges","archive_url":"https://api.github.com/repos/code-dot-org/code-dot-org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-dot-org/code-dot-org/downloads","issues_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues{/number}","pulls_url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls{/number}","milestones_url":"https://api.github.com/repos/code-dot-org/code-dot-org/milestones{/number}","notifications_url":"https://api.github.com/repos/code-dot-org/code-dot-org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-dot-org/code-dot-org/labels{/name}","releases_url":"https://api.github.com/repos/code-dot-org/code-dot-org/releases{/id}","deployments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/deployments","created_at":"2014-09-20T00:46:11Z","updated_at":"2017-03-28T14:59:33Z","pushed_at":"2017-03-29T00:54:57Z","git_url":"git://github.com/code-dot-org/code-dot-org.git","ssh_url":"[email protected]:code-dot-org/code-dot-org.git","clone_url":"https://github.com/code-dot-org/code-dot-org.git","svn_url":"https://github.com/code-dot-org/code-dot-org","homepage":"http://code.org","size":5325793,"stargazers_count":179,"watchers_count":179,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":108,"mirror_url":null,"open_issues_count":77,"forks":108,"open_issues":77,"watchers":179,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/13958"},"html":{"href":"https://github.com/code-dot-org/code-dot-org/pull/13958"},"issue":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/13958"},"comments":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/13958/comments"},"review_comments":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/13958/comments"},"review_comment":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/13958/commits"},"statuses":{"href":"https://api.github.com/repos/code-dot-org/code-dot-org/statuses/fa53ae9f09c22a6129123a87f650257807b8248b"}}}}
|
{
"id": 24250009,
"name": "code-dot-org/code-dot-org",
"url": "https://api.github.com/repos/code-dot-org/code-dot-org"
}
|
{
"id": 1615761,
"login": "islemaster",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1615761?",
"url": "https://api.github.com/users/islemaster"
}
|
{
"id": 5124627,
"login": "code-dot-org",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5124627?",
"url": "https://api.github.com/orgs/code-dot-org"
}
| 2017-03-29T00:58:19 |
5583578723
|
{"actor":{"display_login":"islemaster"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/pulls/comments/125418617","pull_request_review_id":47804842,"id":125418617,"diff_hunk":"@@ -0,0 +1,3 @@\n+def create_price_buckets(prices, interval_multiplers, min_bucket_count,","path":"price_buckets.py","position":1,"original_position":1,"commit_id":"b511b6547f69ced58f9e8bd78f85b6b38bfbc5bb","original_commit_id":"b511b6547f69ced58f9e8bd78f85b6b38bfbc5bb","user":{"login":"HenrikOssipoff","id":4737224,"avatar_url":"https://avatars1.githubusercontent.com/u/4737224?v=3","gravatar_id":"","url":"https://api.github.com/users/HenrikOssipoff","html_url":"https://github.com/HenrikOssipoff","followers_url":"https://api.github.com/users/HenrikOssipoff/followers","following_url":"https://api.github.com/users/HenrikOssipoff/following{/other_user}","gists_url":"https://api.github.com/users/HenrikOssipoff/gists{/gist_id}","starred_url":"https://api.github.com/users/HenrikOssipoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HenrikOssipoff/subscriptions","organizations_url":"https://api.github.com/users/HenrikOssipoff/orgs","repos_url":"https://api.github.com/users/HenrikOssipoff/repos","events_url":"https://api.github.com/users/HenrikOssipoff/events{/privacy}","received_events_url":"https://api.github.com/users/HenrikOssipoff/received_events","type":"User","site_admin":false},"body":"Should this have been `multipliers` ?","created_at":"2017-07-04T08:40:32Z","updated_at":"2017-07-04T08:43:45Z","html_url":"https://github.com/coolshop-com/coolshop-application-assignment/pull/9#discussion_r125418617","pull_request_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/pulls/comments/125418617"},"html":{"href":"https://github.com/coolshop-com/coolshop-application-assignment/pull/9#discussion_r125418617"},"pull_request":{"href":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/pulls/9","id":128740631,"html_url":"https://github.com/coolshop-com/coolshop-application-assignment/pull/9","diff_url":"https://github.com/coolshop-com/coolshop-application-assignment/pull/9.diff","patch_url":"https://github.com/coolshop-com/coolshop-application-assignment/pull/9.patch","issue_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/issues/9","number":9,"state":"open","locked":false,"title":"Add task to implement get-price-buckets function","user":{"login":"estj92","id":8693155,"avatar_url":"https://avatars1.githubusercontent.com/u/8693155?v=3","gravatar_id":"","url":"https://api.github.com/users/estj92","html_url":"https://github.com/estj92","followers_url":"https://api.github.com/users/estj92/followers","following_url":"https://api.github.com/users/estj92/following{/other_user}","gists_url":"https://api.github.com/users/estj92/gists{/gist_id}","starred_url":"https://api.github.com/users/estj92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estj92/subscriptions","organizations_url":"https://api.github.com/users/estj92/orgs","repos_url":"https://api.github.com/users/estj92/repos","events_url":"https://api.github.com/users/estj92/events{/privacy}","received_events_url":"https://api.github.com/users/estj92/received_events","type":"User","site_admin":false},"body":"ET-355","created_at":"2017-07-04T07:29:20Z","updated_at":"2017-07-04T08:43:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2251404ced9e1215bf8756ca83a90c190b20347","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/pulls/9/commits","review_comments_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/pulls/9/comments","review_comment_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/issues/9/comments","statuses_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/statuses/b511b6547f69ced58f9e8bd78f85b6b38bfbc5bb","head":{"label":"estj92:ET-355","ref":"ET-355","sha":"b511b6547f69ced58f9e8bd78f85b6b38bfbc5bb","user":{"login":"estj92","id":8693155,"avatar_url":"https://avatars1.githubusercontent.com/u/8693155?v=3","gravatar_id":"","url":"https://api.github.com/users/estj92","html_url":"https://github.com/estj92","followers_url":"https://api.github.com/users/estj92/followers","following_url":"https://api.github.com/users/estj92/following{/other_user}","gists_url":"https://api.github.com/users/estj92/gists{/gist_id}","starred_url":"https://api.github.com/users/estj92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estj92/subscriptions","organizations_url":"https://api.github.com/users/estj92/orgs","repos_url":"https://api.github.com/users/estj92/repos","events_url":"https://api.github.com/users/estj92/events{/privacy}","received_events_url":"https://api.github.com/users/estj92/received_events","type":"User","site_admin":false},"repo":{"id":96188516,"name":"coolshop-application-assignment","full_name":"estj92/coolshop-application-assignment","owner":{"login":"estj92","id":8693155,"avatar_url":"https://avatars1.githubusercontent.com/u/8693155?v=3","gravatar_id":"","url":"https://api.github.com/users/estj92","html_url":"https://github.com/estj92","followers_url":"https://api.github.com/users/estj92/followers","following_url":"https://api.github.com/users/estj92/following{/other_user}","gists_url":"https://api.github.com/users/estj92/gists{/gist_id}","starred_url":"https://api.github.com/users/estj92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/estj92/subscriptions","organizations_url":"https://api.github.com/users/estj92/orgs","repos_url":"https://api.github.com/users/estj92/repos","events_url":"https://api.github.com/users/estj92/events{/privacy}","received_events_url":"https://api.github.com/users/estj92/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/estj92/coolshop-application-assignment","description":"Tests/exercises for coolshop developer applicants","fork":true,"url":"https://api.github.com/repos/estj92/coolshop-application-assignment","forks_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/forks","keys_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/teams","hooks_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/hooks","issue_events_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/issues/events{/number}","events_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/events","assignees_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/assignees{/user}","branches_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/branches{/branch}","tags_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/tags","blobs_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/git/refs{/sha}","trees_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/statuses/{sha}","languages_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/languages","stargazers_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/stargazers","contributors_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/contributors","subscribers_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/subscribers","subscription_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/subscription","commits_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/commits{/sha}","git_commits_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/git/commits{/sha}","comments_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/comments{/number}","issue_comment_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/issues/comments{/number}","contents_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/contents/{+path}","compare_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/merges","archive_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/downloads","issues_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/issues{/number}","pulls_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/pulls{/number}","milestones_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/milestones{/number}","notifications_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/labels{/name}","releases_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/releases{/id}","deployments_url":"https://api.github.com/repos/estj92/coolshop-application-assignment/deployments","created_at":"2017-07-04T07:26:08Z","updated_at":"2017-07-04T07:26:10Z","pushed_at":"2017-07-04T07:29:06Z","git_url":"git://github.com/estj92/coolshop-application-assignment.git","ssh_url":"[email protected]:estj92/coolshop-application-assignment.git","clone_url":"https://github.com/estj92/coolshop-application-assignment.git","svn_url":"https://github.com/estj92/coolshop-application-assignment","homepage":null,"size":7,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coolshop-com:master","ref":"master","sha":"3053219149f7dac7ab073fc24488116b1b280b77","user":{"login":"coolshop-com","id":13889177,"avatar_url":"https://avatars2.githubusercontent.com/u/13889177?v=3","gravatar_id":"","url":"https://api.github.com/users/coolshop-com","html_url":"https://github.com/coolshop-com","followers_url":"https://api.github.com/users/coolshop-com/followers","following_url":"https://api.github.com/users/coolshop-com/following{/other_user}","gists_url":"https://api.github.com/users/coolshop-com/gists{/gist_id}","starred_url":"https://api.github.com/users/coolshop-com/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coolshop-com/subscriptions","organizations_url":"https://api.github.com/users/coolshop-com/orgs","repos_url":"https://api.github.com/users/coolshop-com/repos","events_url":"https://api.github.com/users/coolshop-com/events{/privacy}","received_events_url":"https://api.github.com/users/coolshop-com/received_events","type":"Organization","site_admin":false},"repo":{"id":83787109,"name":"coolshop-application-assignment","full_name":"coolshop-com/coolshop-application-assignment","owner":{"login":"coolshop-com","id":13889177,"avatar_url":"https://avatars2.githubusercontent.com/u/13889177?v=3","gravatar_id":"","url":"https://api.github.com/users/coolshop-com","html_url":"https://github.com/coolshop-com","followers_url":"https://api.github.com/users/coolshop-com/followers","following_url":"https://api.github.com/users/coolshop-com/following{/other_user}","gists_url":"https://api.github.com/users/coolshop-com/gists{/gist_id}","starred_url":"https://api.github.com/users/coolshop-com/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coolshop-com/subscriptions","organizations_url":"https://api.github.com/users/coolshop-com/orgs","repos_url":"https://api.github.com/users/coolshop-com/repos","events_url":"https://api.github.com/users/coolshop-com/events{/privacy}","received_events_url":"https://api.github.com/users/coolshop-com/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coolshop-com/coolshop-application-assignment","description":"Tests/exercises for coolshop developer applicants","fork":false,"url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment","forks_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/forks","keys_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/teams","hooks_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/hooks","issue_events_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/issues/events{/number}","events_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/events","assignees_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/assignees{/user}","branches_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/branches{/branch}","tags_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/tags","blobs_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/git/refs{/sha}","trees_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/statuses/{sha}","languages_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/languages","stargazers_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/stargazers","contributors_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/contributors","subscribers_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/subscribers","subscription_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/subscription","commits_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/commits{/sha}","git_commits_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/git/commits{/sha}","comments_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/comments{/number}","issue_comment_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/issues/comments{/number}","contents_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/contents/{+path}","compare_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/merges","archive_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/downloads","issues_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/issues{/number}","pulls_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/pulls{/number}","milestones_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/milestones{/number}","notifications_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/labels{/name}","releases_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/releases{/id}","deployments_url":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/deployments","created_at":"2017-03-03T10:31:37Z","updated_at":"2017-03-07T15:03:14Z","pushed_at":"2017-07-04T07:29:20Z","git_url":"git://github.com/coolshop-com/coolshop-application-assignment.git","ssh_url":"[email protected]:coolshop-com/coolshop-application-assignment.git","clone_url":"https://github.com/coolshop-com/coolshop-application-assignment.git","svn_url":"https://github.com/coolshop-com/coolshop-application-assignment","homepage":null,"size":6,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/pulls/9"},"html":{"href":"https://github.com/coolshop-com/coolshop-application-assignment/pull/9"},"issue":{"href":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/issues/9"},"comments":{"href":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/coolshop-com/coolshop-application-assignment/statuses/b511b6547f69ced58f9e8bd78f85b6b38bfbc5bb"}}}}
|
{
"id": 83787109,
"name": "coolshop-com/coolshop-application-assignment",
"url": "https://api.github.com/repos/coolshop-com/coolshop-application-assignment"
}
|
{
"id": 4737224,
"login": "HenrikOssipoff",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4737224?",
"url": "https://api.github.com/users/HenrikOssipoff"
}
|
{
"id": 13889177,
"login": "coolshop-com",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13889177?",
"url": "https://api.github.com/orgs/coolshop-com"
}
| 2017-07-04T08:40:32 |
6187862277
|
{"actor":{"display_login":"HenrikOssipoff"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments/141332637","pull_request_review_id":65529193,"id":141332637,"diff_hunk":"@@ -53,21 +53,55 @@ require \"crystal/system/time\"\n # span.hours # => 1\n # ```\n struct Time\n- # *Heavily* inspired by Mono's DateTime class:\n- # https://github.com/mono/mono/blob/master/mcs/class/corlib/System/DateTime.cs\n-\n include Comparable(self)\n \n- TicksMask = 0x3fffffffffffffff\n- KindMask = 0xc000000000000000\n- MAX_VALUE_TICKS = 3155378975999999999_i64\n+ # :nodoc:\n+ DAYS_MONTH = [0, 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31]\n \n- DAYS_MONTH = [0, 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31]\n+ # :nodoc:\n DAYS_MONTH_LEAP = [0, 31, 29, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31]\n \n- DP400 = 146097\n- DP100 = 36524\n- DP4 = 1461\n+ # :nodoc:\n+ SECONDS_PER_MINUTE = 60","path":"src/time.cr","position":23,"original_position":23,"commit_id":"5c756e57a75a6014721fcfd746c282796b255936","original_commit_id":"5c756e57a75a6014721fcfd746c282796b255936","user":{"login":"asterite","id":209371,"avatar_url":"https://avatars0.githubusercontent.com/u/209371?v=4","gravatar_id":"","url":"https://api.github.com/users/asterite","html_url":"https://github.com/asterite","followers_url":"https://api.github.com/users/asterite/followers","following_url":"https://api.github.com/users/asterite/following{/other_user}","gists_url":"https://api.github.com/users/asterite/gists{/gist_id}","starred_url":"https://api.github.com/users/asterite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asterite/subscriptions","organizations_url":"https://api.github.com/users/asterite/orgs","repos_url":"https://api.github.com/users/asterite/repos","events_url":"https://api.github.com/users/asterite/events{/privacy}","received_events_url":"https://api.github.com/users/asterite/received_events","type":"User","site_admin":false},"body":"No, they are part of the internal implementation. If the implementation changes I don't want to have to keep this constant. Anyone can compute this by themselves.","created_at":"2017-09-27T12:52:38Z","updated_at":"2017-09-27T12:52:38Z","html_url":"https://github.com/crystal-lang/crystal/pull/5022#discussion_r141332637","pull_request_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/5022","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments/141332637"},"html":{"href":"https://github.com/crystal-lang/crystal/pull/5022#discussion_r141332637"},"pull_request":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/5022"}},"in_reply_to_id":141300387},"pull_request":{"url":"https://api.github.com/repos/crystal-lang/crystal/pulls/5022","id":142659823,"html_url":"https://github.com/crystal-lang/crystal/pull/5022","diff_url":"https://github.com/crystal-lang/crystal/pull/5022.diff","patch_url":"https://github.com/crystal-lang/crystal/pull/5022.patch","issue_url":"https://api.github.com/repos/crystal-lang/crystal/issues/5022","number":5022,"state":"open","locked":false,"title":"Increase the precision of Time and Time::Span to nanoseconds","user":{"login":"asterite","id":209371,"avatar_url":"https://avatars0.githubusercontent.com/u/209371?v=4","gravatar_id":"","url":"https://api.github.com/users/asterite","html_url":"https://github.com/asterite","followers_url":"https://api.github.com/users/asterite/followers","following_url":"https://api.github.com/users/asterite/following{/other_user}","gists_url":"https://api.github.com/users/asterite/gists{/gist_id}","starred_url":"https://api.github.com/users/asterite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asterite/subscriptions","organizations_url":"https://api.github.com/users/asterite/orgs","repos_url":"https://api.github.com/users/asterite/repos","events_url":"https://api.github.com/users/asterite/events{/privacy}","received_events_url":"https://api.github.com/users/asterite/received_events","type":"User","site_admin":false},"body":"This PR fixes the issue that the current `Time` and `Time::Span` types cannot hold nanosecond resolution times.\r\n\r\nInternally, `Time` is now stored as:\r\n\r\n```crystal\r\nstruct Time\r\n @seconds : Int64\r\n @nanoseconds : Int32\r\n @kind : Kind # Int32\r\nend\r\n```\r\n\r\nand `Time::Span` is now:\r\n\r\n```crystal\r\nstruct Time::Span\r\n @seconds : Int64\r\n @nanoseconds : Int32\r\nend\r\n```\r\n\r\nso `Time` occupies 128 bits and `Time::Span` 92 bits (though because of padding it will probably occupy 128 bits too).\r\n\r\nHowever, **I don't intend this to be the final representation**, but I'd like to start sending PRs fixing issues one by one (for example, I can imagine `@kind` ceasing to exist). \r\n\r\nThis also gets rid of the `ticks` property of both `Time` and `Time::Span` which leaks information about the internal representation. I also refactored the code a bit so if later we want to change the internal representation it should be easier to do. The idea is to finish shaping the API and later being able to improve the internals without needing to change the API again.\r\n\r\nNote: on OSX, even though `Time` can now have nanosecond precision, it won't be the case because of the C calls we are making. This should be improved in a separate PR.","created_at":"2017-09-22T20:11:42Z","updated_at":"2017-09-27T12:52:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5d07047baae8d710107f2db0ea8ab8a8a3e24dc","assignee":{"login":"asterite","id":209371,"avatar_url":"https://avatars0.githubusercontent.com/u/209371?v=4","gravatar_id":"","url":"https://api.github.com/users/asterite","html_url":"https://github.com/asterite","followers_url":"https://api.github.com/users/asterite/followers","following_url":"https://api.github.com/users/asterite/following{/other_user}","gists_url":"https://api.github.com/users/asterite/gists{/gist_id}","starred_url":"https://api.github.com/users/asterite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asterite/subscriptions","organizations_url":"https://api.github.com/users/asterite/orgs","repos_url":"https://api.github.com/users/asterite/repos","events_url":"https://api.github.com/users/asterite/events{/privacy}","received_events_url":"https://api.github.com/users/asterite/received_events","type":"User","site_admin":false},"assignees":[{"login":"asterite","id":209371,"avatar_url":"https://avatars0.githubusercontent.com/u/209371?v=4","gravatar_id":"","url":"https://api.github.com/users/asterite","html_url":"https://github.com/asterite","followers_url":"https://api.github.com/users/asterite/followers","following_url":"https://api.github.com/users/asterite/following{/other_user}","gists_url":"https://api.github.com/users/asterite/gists{/gist_id}","starred_url":"https://api.github.com/users/asterite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asterite/subscriptions","organizations_url":"https://api.github.com/users/asterite/orgs","repos_url":"https://api.github.com/users/asterite/repos","events_url":"https://api.github.com/users/asterite/events{/privacy}","received_events_url":"https://api.github.com/users/asterite/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/5022/commits","review_comments_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/5022/comments","review_comment_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crystal-lang/crystal/issues/5022/comments","statuses_url":"https://api.github.com/repos/crystal-lang/crystal/statuses/5c756e57a75a6014721fcfd746c282796b255936","head":{"label":"asterite:feature/time","ref":"feature/time","sha":"5c756e57a75a6014721fcfd746c282796b255936","user":{"login":"asterite","id":209371,"avatar_url":"https://avatars0.githubusercontent.com/u/209371?v=4","gravatar_id":"","url":"https://api.github.com/users/asterite","html_url":"https://github.com/asterite","followers_url":"https://api.github.com/users/asterite/followers","following_url":"https://api.github.com/users/asterite/following{/other_user}","gists_url":"https://api.github.com/users/asterite/gists{/gist_id}","starred_url":"https://api.github.com/users/asterite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asterite/subscriptions","organizations_url":"https://api.github.com/users/asterite/orgs","repos_url":"https://api.github.com/users/asterite/repos","events_url":"https://api.github.com/users/asterite/events{/privacy}","received_events_url":"https://api.github.com/users/asterite/received_events","type":"User","site_admin":false},"repo":{"id":17763014,"name":"crystal-1","full_name":"asterite/crystal-1","owner":{"login":"asterite","id":209371,"avatar_url":"https://avatars0.githubusercontent.com/u/209371?v=4","gravatar_id":"","url":"https://api.github.com/users/asterite","html_url":"https://github.com/asterite","followers_url":"https://api.github.com/users/asterite/followers","following_url":"https://api.github.com/users/asterite/following{/other_user}","gists_url":"https://api.github.com/users/asterite/gists{/gist_id}","starred_url":"https://api.github.com/users/asterite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asterite/subscriptions","organizations_url":"https://api.github.com/users/asterite/orgs","repos_url":"https://api.github.com/users/asterite/repos","events_url":"https://api.github.com/users/asterite/events{/privacy}","received_events_url":"https://api.github.com/users/asterite/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asterite/crystal-1","description":"The Crystal Programming Language","fork":true,"url":"https://api.github.com/repos/asterite/crystal-1","forks_url":"https://api.github.com/repos/asterite/crystal-1/forks","keys_url":"https://api.github.com/repos/asterite/crystal-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asterite/crystal-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asterite/crystal-1/teams","hooks_url":"https://api.github.com/repos/asterite/crystal-1/hooks","issue_events_url":"https://api.github.com/repos/asterite/crystal-1/issues/events{/number}","events_url":"https://api.github.com/repos/asterite/crystal-1/events","assignees_url":"https://api.github.com/repos/asterite/crystal-1/assignees{/user}","branches_url":"https://api.github.com/repos/asterite/crystal-1/branches{/branch}","tags_url":"https://api.github.com/repos/asterite/crystal-1/tags","blobs_url":"https://api.github.com/repos/asterite/crystal-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asterite/crystal-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asterite/crystal-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/asterite/crystal-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asterite/crystal-1/statuses/{sha}","languages_url":"https://api.github.com/repos/asterite/crystal-1/languages","stargazers_url":"https://api.github.com/repos/asterite/crystal-1/stargazers","contributors_url":"https://api.github.com/repos/asterite/crystal-1/contributors","subscribers_url":"https://api.github.com/repos/asterite/crystal-1/subscribers","subscription_url":"https://api.github.com/repos/asterite/crystal-1/subscription","commits_url":"https://api.github.com/repos/asterite/crystal-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/asterite/crystal-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/asterite/crystal-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/asterite/crystal-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/asterite/crystal-1/contents/{+path}","compare_url":"https://api.github.com/repos/asterite/crystal-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asterite/crystal-1/merges","archive_url":"https://api.github.com/repos/asterite/crystal-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asterite/crystal-1/downloads","issues_url":"https://api.github.com/repos/asterite/crystal-1/issues{/number}","pulls_url":"https://api.github.com/repos/asterite/crystal-1/pulls{/number}","milestones_url":"https://api.github.com/repos/asterite/crystal-1/milestones{/number}","notifications_url":"https://api.github.com/repos/asterite/crystal-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asterite/crystal-1/labels{/name}","releases_url":"https://api.github.com/repos/asterite/crystal-1/releases{/id}","deployments_url":"https://api.github.com/repos/asterite/crystal-1/deployments","created_at":"2014-03-14T22:55:01Z","updated_at":"2016-07-25T21:44:08Z","pushed_at":"2017-09-26T20:08:46Z","git_url":"git://github.com/asterite/crystal-1.git","ssh_url":"[email protected]:asterite/crystal-1.git","clone_url":"https://github.com/asterite/crystal-1.git","svn_url":"https://github.com/asterite/crystal-1","homepage":"http://crystal-lang.org","size":35288,"stargazers_count":1,"watchers_count":1,"language":"Crystal","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"crystal-lang:master","ref":"master","sha":"60a33522dea10592d1e67fd0eaf7e237b59a56f3","user":{"login":"crystal-lang","id":6539796,"avatar_url":"https://avatars0.githubusercontent.com/u/6539796?v=4","gravatar_id":"","url":"https://api.github.com/users/crystal-lang","html_url":"https://github.com/crystal-lang","followers_url":"https://api.github.com/users/crystal-lang/followers","following_url":"https://api.github.com/users/crystal-lang/following{/other_user}","gists_url":"https://api.github.com/users/crystal-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/crystal-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crystal-lang/subscriptions","organizations_url":"https://api.github.com/users/crystal-lang/orgs","repos_url":"https://api.github.com/users/crystal-lang/repos","events_url":"https://api.github.com/users/crystal-lang/events{/privacy}","received_events_url":"https://api.github.com/users/crystal-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":6887813,"name":"crystal","full_name":"crystal-lang/crystal","owner":{"login":"crystal-lang","id":6539796,"avatar_url":"https://avatars0.githubusercontent.com/u/6539796?v=4","gravatar_id":"","url":"https://api.github.com/users/crystal-lang","html_url":"https://github.com/crystal-lang","followers_url":"https://api.github.com/users/crystal-lang/followers","following_url":"https://api.github.com/users/crystal-lang/following{/other_user}","gists_url":"https://api.github.com/users/crystal-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/crystal-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crystal-lang/subscriptions","organizations_url":"https://api.github.com/users/crystal-lang/orgs","repos_url":"https://api.github.com/users/crystal-lang/repos","events_url":"https://api.github.com/users/crystal-lang/events{/privacy}","received_events_url":"https://api.github.com/users/crystal-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crystal-lang/crystal","description":"The Crystal Programming Language","fork":false,"url":"https://api.github.com/repos/crystal-lang/crystal","forks_url":"https://api.github.com/repos/crystal-lang/crystal/forks","keys_url":"https://api.github.com/repos/crystal-lang/crystal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crystal-lang/crystal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crystal-lang/crystal/teams","hooks_url":"https://api.github.com/repos/crystal-lang/crystal/hooks","issue_events_url":"https://api.github.com/repos/crystal-lang/crystal/issues/events{/number}","events_url":"https://api.github.com/repos/crystal-lang/crystal/events","assignees_url":"https://api.github.com/repos/crystal-lang/crystal/assignees{/user}","branches_url":"https://api.github.com/repos/crystal-lang/crystal/branches{/branch}","tags_url":"https://api.github.com/repos/crystal-lang/crystal/tags","blobs_url":"https://api.github.com/repos/crystal-lang/crystal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crystal-lang/crystal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crystal-lang/crystal/git/refs{/sha}","trees_url":"https://api.github.com/repos/crystal-lang/crystal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crystal-lang/crystal/statuses/{sha}","languages_url":"https://api.github.com/repos/crystal-lang/crystal/languages","stargazers_url":"https://api.github.com/repos/crystal-lang/crystal/stargazers","contributors_url":"https://api.github.com/repos/crystal-lang/crystal/contributors","subscribers_url":"https://api.github.com/repos/crystal-lang/crystal/subscribers","subscription_url":"https://api.github.com/repos/crystal-lang/crystal/subscription","commits_url":"https://api.github.com/repos/crystal-lang/crystal/commits{/sha}","git_commits_url":"https://api.github.com/repos/crystal-lang/crystal/git/commits{/sha}","comments_url":"https://api.github.com/repos/crystal-lang/crystal/comments{/number}","issue_comment_url":"https://api.github.com/repos/crystal-lang/crystal/issues/comments{/number}","contents_url":"https://api.github.com/repos/crystal-lang/crystal/contents/{+path}","compare_url":"https://api.github.com/repos/crystal-lang/crystal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crystal-lang/crystal/merges","archive_url":"https://api.github.com/repos/crystal-lang/crystal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crystal-lang/crystal/downloads","issues_url":"https://api.github.com/repos/crystal-lang/crystal/issues{/number}","pulls_url":"https://api.github.com/repos/crystal-lang/crystal/pulls{/number}","milestones_url":"https://api.github.com/repos/crystal-lang/crystal/milestones{/number}","notifications_url":"https://api.github.com/repos/crystal-lang/crystal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crystal-lang/crystal/labels{/name}","releases_url":"https://api.github.com/repos/crystal-lang/crystal/releases{/id}","deployments_url":"https://api.github.com/repos/crystal-lang/crystal/deployments","created_at":"2012-11-27T17:32:32Z","updated_at":"2017-09-27T10:34:46Z","pushed_at":"2017-09-27T09:30:32Z","git_url":"git://github.com/crystal-lang/crystal.git","ssh_url":"[email protected]:crystal-lang/crystal.git","clone_url":"https://github.com/crystal-lang/crystal.git","svn_url":"https://github.com/crystal-lang/crystal","homepage":"https://crystal-lang.org","size":34500,"stargazers_count":9152,"watchers_count":9152,"language":"Crystal","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":726,"mirror_url":null,"open_issues_count":496,"forks":726,"open_issues":496,"watchers":9152,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/5022"},"html":{"href":"https://github.com/crystal-lang/crystal/pull/5022"},"issue":{"href":"https://api.github.com/repos/crystal-lang/crystal/issues/5022"},"comments":{"href":"https://api.github.com/repos/crystal-lang/crystal/issues/5022/comments"},"review_comments":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/5022/comments"},"review_comment":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/5022/commits"},"statuses":{"href":"https://api.github.com/repos/crystal-lang/crystal/statuses/5c756e57a75a6014721fcfd746c282796b255936"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 6887813,
"name": "crystal-lang/crystal",
"url": "https://api.github.com/repos/crystal-lang/crystal"
}
|
{
"id": 209371,
"login": "asterite",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/209371?",
"url": "https://api.github.com/users/asterite"
}
|
{
"id": 6539796,
"login": "crystal-lang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6539796?",
"url": "https://api.github.com/orgs/crystal-lang"
}
| 2017-09-27T12:52:38 |
6643825855
|
{"actor":{"display_login":"asterite"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/comments/155634206","pull_request_review_id":81986204,"id":155634206,"diff_hunk":"@@ -0,0 +1,229 @@\n+package units\n+\n+import (\n+\t\"fmt\"\n+\t\"io\"\n+\t\"io/ioutil\"\n+\t\"net/http\"\n+\t\"time\"\n+\n+\t\"github.com/evergreen-ci/evergreen\"\n+\t\"github.com/evergreen-ci/evergreen/db\"\n+\t\"github.com/evergreen-ci/evergreen/model\"\n+\t\"github.com/evergreen-ci/evergreen/model/patch\"\n+\t\"github.com/evergreen-ci/evergreen/model/user\"\n+\t\"github.com/evergreen-ci/evergreen/thirdparty\"\n+\t\"github.com/evergreen-ci/evergreen/validator\"\n+\t\"github.com/mongodb/amboy\"\n+\t\"github.com/mongodb/amboy/job\"\n+\t\"github.com/mongodb/amboy/registry\"\n+\t\"github.com/mongodb/grip\"\n+\t\"github.com/mongodb/grip/logging\"\n+\t\"github.com/pkg/errors\"\n+\t\"gopkg.in/mgo.v2/bson\"\n+\tyaml \"gopkg.in/yaml.v2\"\n+)\n+\n+const patchIntentJobName = \"patch-intent-processor\"\n+\n+func init() {\n+\tregistry.AddJobType(patchIntentJobName,\n+\t\tfunc() amboy.Job { return makePatchIntentProcessor() })\n+}\n+\n+type patchIntentProcessor struct {\n+\tjob.Base `bson:\"job_base\" json:\"job_base\" yaml:\"job_base\"`\n+\tlogger grip.Journaler\n+\tenv evergreen.Environment\n+\n+\tIntent patch.Intent `bson:\"intent\" json:\"intent\"`\n+\tPatchID bson.ObjectId `bson:\"patch_id\" json:\"patch_id\" yaml:\"patch_id\"`\n+\tuser *user.DBUser\n+\tprojectRef *model.ProjectRef\n+}\n+\n+// NewPatchIntentProcessor creates an amboy job to create a patch from the\n+// given patch intent with the given object ID for the patch\n+func NewPatchIntentProcessor(patchID bson.ObjectId, intent patch.Intent) amboy.Job {\n+\tj := makePatchIntentProcessor()\n+\tj.SetID(fmt.Sprintf(\"%s-%s-%s\", patchIntentJobName, intent.GetType(), intent.ID()))\n+\tj.Intent = intent\n+\tj.PatchID = patchID\n+\treturn j\n+}\n+\n+func makePatchIntentProcessor() *patchIntentProcessor {\n+\treturn &patchIntentProcessor{\n+\t\tenv: evergreen.GetEnvironment(),\n+\t\tlogger: logging.MakeGrip(grip.GetSender()),\n+\t\tBase: job.Base{\n+\t\t\tJobType: amboy.JobType{\n+\t\t\t\tName: patchIntentJobName,\n+\t\t\t\tVersion: 0,\n+\t\t\t\tFormat: amboy.BSON,\n+\t\t\t},\n+\t\t},\n+\t}\n+}\n+\n+func (j *patchIntentProcessor) Run() {\n+\tgithubOauthToken := j.env.Settings().Credentials[\"github\"]\n+\n+\tdefer j.MarkComplete()\n+\tif j.Intent == nil {\n+\t\tj.AddError(errors.New(\"nil intent\"))\n+\t\treturn\n+\t}\n+\tdefer j.Intent.SetProcessed()\n+\n+\tpatchDoc := j.Intent.NewPatch()\n+\n+\tswitch j.Intent.GetType() {\n+\tcase patch.CliIntentType:\n+\t\tj.AddError(j.buildCliPatchDoc(patchDoc, githubOauthToken))\n+\n+\tdefault:\n+\t\tj.AddError(errors.Errorf(\"Intent type '%s' is unknown\", j.Intent.GetType()))\n+\t}\n+\tif j.HasErrors() {\n+\t\treturn\n+\t}\n+\n+\tvar err error\n+\tj.user, err = user.FindOne(user.ById(patchDoc.Author))\n+\tif err != nil {\n+\t\tj.AddError(err)\n+\t}\n+\tif j.user == nil {\n+\t\tj.AddError(errors.New(\"Can't find patch author\"))\n+\t}\n+\n+\tif j.HasErrors() {\n+\t\treturn\n+\t}\n+\n+\t// Get and validate patched config and add it to the patch document\n+\tproject, err := validator.GetPatchedProject(patchDoc, githubOauthToken)\n+\tif err != nil {\n+\t\tj.AddError(errors.Wrap(err, \"invalid patched config\"))\n+\t\treturn\n+\t}\n+\n+\tif patchDoc.Patches[0].ModuleName != \"\" {\n+\t\t// is there a module? validate it.\n+\t\tvar module *model.Module\n+\t\tmodule, err = project.GetModuleByName(patchDoc.Patches[0].ModuleName)\n+\t\tif err != nil {\n+\t\t\tj.AddError(errors.Wrapf(err, \"could not find module '%s'\", patchDoc.Patches[0].ModuleName))\n+\t\t}\n+\t\tif module == nil {\n+\t\t\tj.AddError(errors.Errorf(\"no module named '%s'\", patchDoc.Patches[0].ModuleName))\n+\t\t}\n+\t}\n+\n+\t// verify that all variants exists\n+\tfor _, buildVariant := range patchDoc.BuildVariants {\n+\t\tif buildVariant == \"all\" || buildVariant == \"\" {\n+\t\t\tcontinue\n+\t\t}\n+\t\tbv := project.FindBuildVariant(buildVariant)\n+\t\tif bv == nil {\n+\t\t\tj.AddError(errors.Errorf(\"No such buildvariant: '%s'\", buildVariant))\n+\t\t}\n+\t}\n+\n+\tif j.HasErrors() {\n+\t\treturn\n+\t}\n+\n+\t// add the project config\n+\tprojectYamlBytes, err := yaml.Marshal(project)\n+\tif err != nil {\n+\t\tj.AddError(errors.Wrap(err, \"error marshaling patched config\"))\n+\t\treturn\n+\t}\n+\tpatchDoc.PatchedConfig = string(projectYamlBytes)\n+\n+\t// set the patch number based on patch author\n+\tpatchDoc.PatchNumber, err = j.user.IncPatchNumber()\n+\tif err != nil {\n+\t\tj.AddError(errors.Wrap(err, \"error computing patch num\"))\n+\t\treturn\n+\t}\n+\n+\tproject.BuildProjectTVPairs(patchDoc)\n+\n+\tpatchDoc.CreateTime = time.Now()\n+\tpatchDoc.Id = j.PatchID\n+\n+\tif err := patchDoc.Insert(); err != nil {\n+\t\tj.AddError(err)\n+\t\treturn\n+\t}\n+\n+\tif j.Intent.ShouldFinalizePatch() {\n+\t\tif _, err := model.FinalizePatch(patchDoc, githubOauthToken); err != nil {\n+\t\t\tj.AddError(err)\n+\t\t}\n+\t}\n+}\n+\n+func fetchPatchByURL(URL string) (string, error) {\n+\tresp, err := http.Get(URL)","path":"units/patch_intent.go","position":184,"original_position":172,"commit_id":"106a62eb1f2174e7d43f83cc4323b2aecc5dfd84","original_commit_id":"b77f3dea4d6f51151a282d746a035f278d6453fa","user":{"login":"tychoish","id":17534,"avatar_url":"https://avatars1.githubusercontent.com/u/17534?v=4","gravatar_id":"","url":"https://api.github.com/users/tychoish","html_url":"https://github.com/tychoish","followers_url":"https://api.github.com/users/tychoish/followers","following_url":"https://api.github.com/users/tychoish/following{/other_user}","gists_url":"https://api.github.com/users/tychoish/gists{/gist_id}","starred_url":"https://api.github.com/users/tychoish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tychoish/subscriptions","organizations_url":"https://api.github.com/users/tychoish/orgs","repos_url":"https://api.github.com/users/tychoish/repos","events_url":"https://api.github.com/users/tychoish/events{/privacy}","received_events_url":"https://api.github.com/users/tychoish/received_events","type":"User","site_admin":false},"body":"```\r\nclient := util.GetHttpClient()\r\ndefer util.PutHttpClient(client)\r\n\r\nclient.Get(URL)\r\n```\r\nor similar.","created_at":"2017-12-07T20:38:11Z","updated_at":"2017-12-07T20:40:10Z","html_url":"https://github.com/evergreen-ci/evergreen/pull/453#discussion_r155634206","pull_request_url":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/453","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/comments/155634206"},"html":{"href":"https://github.com/evergreen-ci/evergreen/pull/453#discussion_r155634206"},"pull_request":{"href":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/453"}},"in_reply_to_id":155561841},"pull_request":{"url":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/453","id":156856196,"html_url":"https://github.com/evergreen-ci/evergreen/pull/453","diff_url":"https://github.com/evergreen-ci/evergreen/pull/453.diff","patch_url":"https://github.com/evergreen-ci/evergreen/pull/453.patch","issue_url":"https://api.github.com/repos/evergreen-ci/evergreen/issues/453","number":453,"state":"open","locked":false,"title":"EVG-2256 Refactor CLI patch creation to use patch intents","user":{"login":"richardsamuels","id":1666322,"avatar_url":"https://avatars3.githubusercontent.com/u/1666322?v=4","gravatar_id":"","url":"https://api.github.com/users/richardsamuels","html_url":"https://github.com/richardsamuels","followers_url":"https://api.github.com/users/richardsamuels/followers","following_url":"https://api.github.com/users/richardsamuels/following{/other_user}","gists_url":"https://api.github.com/users/richardsamuels/gists{/gist_id}","starred_url":"https://api.github.com/users/richardsamuels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardsamuels/subscriptions","organizations_url":"https://api.github.com/users/richardsamuels/orgs","repos_url":"https://api.github.com/users/richardsamuels/repos","events_url":"https://api.github.com/users/richardsamuels/events{/privacy}","received_events_url":"https://api.github.com/users/richardsamuels/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-06T22:26:13Z","updated_at":"2017-12-07T20:40:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76ce2049190dd31fe53fd92cfccfb28bbc016c2f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bsamek","id":624531,"avatar_url":"https://avatars1.githubusercontent.com/u/624531?v=4","gravatar_id":"","url":"https://api.github.com/users/bsamek","html_url":"https://github.com/bsamek","followers_url":"https://api.github.com/users/bsamek/followers","following_url":"https://api.github.com/users/bsamek/following{/other_user}","gists_url":"https://api.github.com/users/bsamek/gists{/gist_id}","starred_url":"https://api.github.com/users/bsamek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsamek/subscriptions","organizations_url":"https://api.github.com/users/bsamek/orgs","repos_url":"https://api.github.com/users/bsamek/repos","events_url":"https://api.github.com/users/bsamek/events{/privacy}","received_events_url":"https://api.github.com/users/bsamek/received_events","type":"User","site_admin":false},{"login":"john-m-liu","id":29384396,"avatar_url":"https://avatars2.githubusercontent.com/u/29384396?v=4","gravatar_id":"","url":"https://api.github.com/users/john-m-liu","html_url":"https://github.com/john-m-liu","followers_url":"https://api.github.com/users/john-m-liu/followers","following_url":"https://api.github.com/users/john-m-liu/following{/other_user}","gists_url":"https://api.github.com/users/john-m-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/john-m-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-m-liu/subscriptions","organizations_url":"https://api.github.com/users/john-m-liu/orgs","repos_url":"https://api.github.com/users/john-m-liu/repos","events_url":"https://api.github.com/users/john-m-liu/events{/privacy}","received_events_url":"https://api.github.com/users/john-m-liu/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/453/commits","review_comments_url":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/453/comments","review_comment_url":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/evergreen-ci/evergreen/issues/453/comments","statuses_url":"https://api.github.com/repos/evergreen-ci/evergreen/statuses/106a62eb1f2174e7d43f83cc4323b2aecc5dfd84","head":{"label":"richardsamuels:2256","ref":"2256","sha":"106a62eb1f2174e7d43f83cc4323b2aecc5dfd84","user":{"login":"richardsamuels","id":1666322,"avatar_url":"https://avatars3.githubusercontent.com/u/1666322?v=4","gravatar_id":"","url":"https://api.github.com/users/richardsamuels","html_url":"https://github.com/richardsamuels","followers_url":"https://api.github.com/users/richardsamuels/followers","following_url":"https://api.github.com/users/richardsamuels/following{/other_user}","gists_url":"https://api.github.com/users/richardsamuels/gists{/gist_id}","starred_url":"https://api.github.com/users/richardsamuels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardsamuels/subscriptions","organizations_url":"https://api.github.com/users/richardsamuels/orgs","repos_url":"https://api.github.com/users/richardsamuels/repos","events_url":"https://api.github.com/users/richardsamuels/events{/privacy}","received_events_url":"https://api.github.com/users/richardsamuels/received_events","type":"User","site_admin":false},"repo":{"id":105666716,"name":"evergreen","full_name":"richardsamuels/evergreen","owner":{"login":"richardsamuels","id":1666322,"avatar_url":"https://avatars3.githubusercontent.com/u/1666322?v=4","gravatar_id":"","url":"https://api.github.com/users/richardsamuels","html_url":"https://github.com/richardsamuels","followers_url":"https://api.github.com/users/richardsamuels/followers","following_url":"https://api.github.com/users/richardsamuels/following{/other_user}","gists_url":"https://api.github.com/users/richardsamuels/gists{/gist_id}","starred_url":"https://api.github.com/users/richardsamuels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardsamuels/subscriptions","organizations_url":"https://api.github.com/users/richardsamuels/orgs","repos_url":"https://api.github.com/users/richardsamuels/repos","events_url":"https://api.github.com/users/richardsamuels/events{/privacy}","received_events_url":"https://api.github.com/users/richardsamuels/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richardsamuels/evergreen","description":"A Distributed Continuous Integration System from MongoDB","fork":true,"url":"https://api.github.com/repos/richardsamuels/evergreen","forks_url":"https://api.github.com/repos/richardsamuels/evergreen/forks","keys_url":"https://api.github.com/repos/richardsamuels/evergreen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richardsamuels/evergreen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richardsamuels/evergreen/teams","hooks_url":"https://api.github.com/repos/richardsamuels/evergreen/hooks","issue_events_url":"https://api.github.com/repos/richardsamuels/evergreen/issues/events{/number}","events_url":"https://api.github.com/repos/richardsamuels/evergreen/events","assignees_url":"https://api.github.com/repos/richardsamuels/evergreen/assignees{/user}","branches_url":"https://api.github.com/repos/richardsamuels/evergreen/branches{/branch}","tags_url":"https://api.github.com/repos/richardsamuels/evergreen/tags","blobs_url":"https://api.github.com/repos/richardsamuels/evergreen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richardsamuels/evergreen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richardsamuels/evergreen/git/refs{/sha}","trees_url":"https://api.github.com/repos/richardsamuels/evergreen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richardsamuels/evergreen/statuses/{sha}","languages_url":"https://api.github.com/repos/richardsamuels/evergreen/languages","stargazers_url":"https://api.github.com/repos/richardsamuels/evergreen/stargazers","contributors_url":"https://api.github.com/repos/richardsamuels/evergreen/contributors","subscribers_url":"https://api.github.com/repos/richardsamuels/evergreen/subscribers","subscription_url":"https://api.github.com/repos/richardsamuels/evergreen/subscription","commits_url":"https://api.github.com/repos/richardsamuels/evergreen/commits{/sha}","git_commits_url":"https://api.github.com/repos/richardsamuels/evergreen/git/commits{/sha}","comments_url":"https://api.github.com/repos/richardsamuels/evergreen/comments{/number}","issue_comment_url":"https://api.github.com/repos/richardsamuels/evergreen/issues/comments{/number}","contents_url":"https://api.github.com/repos/richardsamuels/evergreen/contents/{+path}","compare_url":"https://api.github.com/repos/richardsamuels/evergreen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richardsamuels/evergreen/merges","archive_url":"https://api.github.com/repos/richardsamuels/evergreen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richardsamuels/evergreen/downloads","issues_url":"https://api.github.com/repos/richardsamuels/evergreen/issues{/number}","pulls_url":"https://api.github.com/repos/richardsamuels/evergreen/pulls{/number}","milestones_url":"https://api.github.com/repos/richardsamuels/evergreen/milestones{/number}","notifications_url":"https://api.github.com/repos/richardsamuels/evergreen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richardsamuels/evergreen/labels{/name}","releases_url":"https://api.github.com/repos/richardsamuels/evergreen/releases{/id}","deployments_url":"https://api.github.com/repos/richardsamuels/evergreen/deployments","created_at":"2017-10-03T15:13:10Z","updated_at":"2017-10-03T15:13:14Z","pushed_at":"2017-12-07T19:54:16Z","git_url":"git://github.com/richardsamuels/evergreen.git","ssh_url":"[email protected]:richardsamuels/evergreen.git","clone_url":"https://github.com/richardsamuels/evergreen.git","svn_url":"https://github.com/richardsamuels/evergreen","homepage":"http://evergreen.mongodb.com","size":39454,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"evergreen-ci:master","ref":"master","sha":"7eb0462e23993f73affa7be602735a53cff51ab8","user":{"login":"evergreen-ci","id":10089490,"avatar_url":"https://avatars3.githubusercontent.com/u/10089490?v=4","gravatar_id":"","url":"https://api.github.com/users/evergreen-ci","html_url":"https://github.com/evergreen-ci","followers_url":"https://api.github.com/users/evergreen-ci/followers","following_url":"https://api.github.com/users/evergreen-ci/following{/other_user}","gists_url":"https://api.github.com/users/evergreen-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/evergreen-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evergreen-ci/subscriptions","organizations_url":"https://api.github.com/users/evergreen-ci/orgs","repos_url":"https://api.github.com/users/evergreen-ci/repos","events_url":"https://api.github.com/users/evergreen-ci/events{/privacy}","received_events_url":"https://api.github.com/users/evergreen-ci/received_events","type":"Organization","site_admin":false},"repo":{"id":36385798,"name":"evergreen","full_name":"evergreen-ci/evergreen","owner":{"login":"evergreen-ci","id":10089490,"avatar_url":"https://avatars3.githubusercontent.com/u/10089490?v=4","gravatar_id":"","url":"https://api.github.com/users/evergreen-ci","html_url":"https://github.com/evergreen-ci","followers_url":"https://api.github.com/users/evergreen-ci/followers","following_url":"https://api.github.com/users/evergreen-ci/following{/other_user}","gists_url":"https://api.github.com/users/evergreen-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/evergreen-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evergreen-ci/subscriptions","organizations_url":"https://api.github.com/users/evergreen-ci/orgs","repos_url":"https://api.github.com/users/evergreen-ci/repos","events_url":"https://api.github.com/users/evergreen-ci/events{/privacy}","received_events_url":"https://api.github.com/users/evergreen-ci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/evergreen-ci/evergreen","description":"A Distributed Continuous Integration System from MongoDB","fork":false,"url":"https://api.github.com/repos/evergreen-ci/evergreen","forks_url":"https://api.github.com/repos/evergreen-ci/evergreen/forks","keys_url":"https://api.github.com/repos/evergreen-ci/evergreen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evergreen-ci/evergreen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evergreen-ci/evergreen/teams","hooks_url":"https://api.github.com/repos/evergreen-ci/evergreen/hooks","issue_events_url":"https://api.github.com/repos/evergreen-ci/evergreen/issues/events{/number}","events_url":"https://api.github.com/repos/evergreen-ci/evergreen/events","assignees_url":"https://api.github.com/repos/evergreen-ci/evergreen/assignees{/user}","branches_url":"https://api.github.com/repos/evergreen-ci/evergreen/branches{/branch}","tags_url":"https://api.github.com/repos/evergreen-ci/evergreen/tags","blobs_url":"https://api.github.com/repos/evergreen-ci/evergreen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evergreen-ci/evergreen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evergreen-ci/evergreen/git/refs{/sha}","trees_url":"https://api.github.com/repos/evergreen-ci/evergreen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evergreen-ci/evergreen/statuses/{sha}","languages_url":"https://api.github.com/repos/evergreen-ci/evergreen/languages","stargazers_url":"https://api.github.com/repos/evergreen-ci/evergreen/stargazers","contributors_url":"https://api.github.com/repos/evergreen-ci/evergreen/contributors","subscribers_url":"https://api.github.com/repos/evergreen-ci/evergreen/subscribers","subscription_url":"https://api.github.com/repos/evergreen-ci/evergreen/subscription","commits_url":"https://api.github.com/repos/evergreen-ci/evergreen/commits{/sha}","git_commits_url":"https://api.github.com/repos/evergreen-ci/evergreen/git/commits{/sha}","comments_url":"https://api.github.com/repos/evergreen-ci/evergreen/comments{/number}","issue_comment_url":"https://api.github.com/repos/evergreen-ci/evergreen/issues/comments{/number}","contents_url":"https://api.github.com/repos/evergreen-ci/evergreen/contents/{+path}","compare_url":"https://api.github.com/repos/evergreen-ci/evergreen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evergreen-ci/evergreen/merges","archive_url":"https://api.github.com/repos/evergreen-ci/evergreen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evergreen-ci/evergreen/downloads","issues_url":"https://api.github.com/repos/evergreen-ci/evergreen/issues{/number}","pulls_url":"https://api.github.com/repos/evergreen-ci/evergreen/pulls{/number}","milestones_url":"https://api.github.com/repos/evergreen-ci/evergreen/milestones{/number}","notifications_url":"https://api.github.com/repos/evergreen-ci/evergreen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evergreen-ci/evergreen/labels{/name}","releases_url":"https://api.github.com/repos/evergreen-ci/evergreen/releases{/id}","deployments_url":"https://api.github.com/repos/evergreen-ci/evergreen/deployments","created_at":"2015-05-27T18:03:09Z","updated_at":"2017-12-07T01:20:54Z","pushed_at":"2017-12-07T20:28:38Z","git_url":"git://github.com/evergreen-ci/evergreen.git","ssh_url":"[email protected]:evergreen-ci/evergreen.git","clone_url":"https://github.com/evergreen-ci/evergreen.git","svn_url":"https://github.com/evergreen-ci/evergreen","homepage":"http://evergreen.mongodb.com","size":39400,"stargazers_count":143,"watchers_count":143,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":38,"open_issues":6,"watchers":143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/453"},"html":{"href":"https://github.com/evergreen-ci/evergreen/pull/453"},"issue":{"href":"https://api.github.com/repos/evergreen-ci/evergreen/issues/453"},"comments":{"href":"https://api.github.com/repos/evergreen-ci/evergreen/issues/453/comments"},"review_comments":{"href":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/453/comments"},"review_comment":{"href":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/evergreen-ci/evergreen/pulls/453/commits"},"statuses":{"href":"https://api.github.com/repos/evergreen-ci/evergreen/statuses/106a62eb1f2174e7d43f83cc4323b2aecc5dfd84"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 36385798,
"name": "evergreen-ci/evergreen",
"url": "https://api.github.com/repos/evergreen-ci/evergreen"
}
|
{
"id": 17534,
"login": "tychoish",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17534?",
"url": "https://api.github.com/users/tychoish"
}
|
{
"id": 10089490,
"login": "evergreen-ci",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10089490?",
"url": "https://api.github.com/orgs/evergreen-ci"
}
| 2017-12-07T20:38:11 |
6959095550
|
{"actor":{"display_login":"tychoish"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/138981170","pull_request_review_id":62852090,"id":138981170,"diff_hunk":"@@ -3604,7 +3618,8 @@ main(int argc, char *argv[])\n \tset_short_version(short_version, NULL);\n \n \t/* Select suitable configuration settings */\n-\tset_null_conf();\n+\tset_null_conf(\"postgresql.conf\");\n+\tset_null_conf(\"gp_replication.conf\");","path":"src/bin/initdb/initdb.c","position":66,"original_position":53,"commit_id":"b47ec2eaad3542e28ce19644204b7612eada4de7","original_commit_id":"aa76a9bd761ab29b768180239850d03e686afdbf","user":{"login":"xinzweb","id":723898,"avatar_url":"https://avatars1.githubusercontent.com/u/723898?v=4","gravatar_id":"","url":"https://api.github.com/users/xinzweb","html_url":"https://github.com/xinzweb","followers_url":"https://api.github.com/users/xinzweb/followers","following_url":"https://api.github.com/users/xinzweb/following{/other_user}","gists_url":"https://api.github.com/users/xinzweb/gists{/gist_id}","starred_url":"https://api.github.com/users/xinzweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinzweb/subscriptions","organizations_url":"https://api.github.com/users/xinzweb/orgs","repos_url":"https://api.github.com/users/xinzweb/repos","events_url":"https://api.github.com/users/xinzweb/events{/privacy}","received_events_url":"https://api.github.com/users/xinzweb/received_events","type":"User","site_admin":false},"body":"Similar situation.","created_at":"2017-09-14T18:52:39Z","updated_at":"2017-09-14T18:52:39Z","html_url":"https://github.com/greenplum-db/gpdb/pull/3279#discussion_r138981170","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/3279","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/138981170"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/3279#discussion_r138981170"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/3279"}},"in_reply_to_id":138770399},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/3279","id":140954719,"html_url":"https://github.com/greenplum-db/gpdb/pull/3279","diff_url":"https://github.com/greenplum-db/gpdb/pull/3279.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/3279.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/3279","number":3279,"state":"open","locked":false,"title":"Add gp_replication.conf","user":{"login":"xinzweb","id":723898,"avatar_url":"https://avatars1.githubusercontent.com/u/723898?v=4","gravatar_id":"","url":"https://api.github.com/users/xinzweb","html_url":"https://github.com/xinzweb","followers_url":"https://api.github.com/users/xinzweb/followers","following_url":"https://api.github.com/users/xinzweb/following{/other_user}","gists_url":"https://api.github.com/users/xinzweb/gists{/gist_id}","starred_url":"https://api.github.com/users/xinzweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinzweb/subscriptions","organizations_url":"https://api.github.com/users/xinzweb/orgs","repos_url":"https://api.github.com/users/xinzweb/repos","events_url":"https://api.github.com/users/xinzweb/events{/privacy}","received_events_url":"https://api.github.com/users/xinzweb/received_events","type":"User","site_admin":false},"body":"This is the new framework created to control the synchronous replication between primary segments and mirrors.\r\n\r\nThis is similar to upstream ALTER SYSTEM, please see commit https://github.com/postgres/postgres/commit/7dfab04a8aad7aa5066d2625a649d407ed6b7a5f.\r\n\r\nThe purpose is to leverage the GUC `synchronous_standby_names` to control the blocking behavior between primaries and mirrors.","created_at":"2017-09-13T23:49:16Z","updated_at":"2017-09-14T18:52:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"255c764eb032ba9b41ff0d77b7f5debc8d6491a1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/3279/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/3279/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/3279/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/b47ec2eaad3542e28ce19644204b7612eada4de7","head":{"label":"xinzweb:squash/replication_conf","ref":"squash/replication_conf","sha":"b47ec2eaad3542e28ce19644204b7612eada4de7","user":{"login":"xinzweb","id":723898,"avatar_url":"https://avatars1.githubusercontent.com/u/723898?v=4","gravatar_id":"","url":"https://api.github.com/users/xinzweb","html_url":"https://github.com/xinzweb","followers_url":"https://api.github.com/users/xinzweb/followers","following_url":"https://api.github.com/users/xinzweb/following{/other_user}","gists_url":"https://api.github.com/users/xinzweb/gists{/gist_id}","starred_url":"https://api.github.com/users/xinzweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinzweb/subscriptions","organizations_url":"https://api.github.com/users/xinzweb/orgs","repos_url":"https://api.github.com/users/xinzweb/repos","events_url":"https://api.github.com/users/xinzweb/events{/privacy}","received_events_url":"https://api.github.com/users/xinzweb/received_events","type":"User","site_admin":false},"repo":{"id":45497539,"name":"gpdb","full_name":"xinzweb/gpdb","owner":{"login":"xinzweb","id":723898,"avatar_url":"https://avatars1.githubusercontent.com/u/723898?v=4","gravatar_id":"","url":"https://api.github.com/users/xinzweb","html_url":"https://github.com/xinzweb","followers_url":"https://api.github.com/users/xinzweb/followers","following_url":"https://api.github.com/users/xinzweb/following{/other_user}","gists_url":"https://api.github.com/users/xinzweb/gists{/gist_id}","starred_url":"https://api.github.com/users/xinzweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xinzweb/subscriptions","organizations_url":"https://api.github.com/users/xinzweb/orgs","repos_url":"https://api.github.com/users/xinzweb/repos","events_url":"https://api.github.com/users/xinzweb/events{/privacy}","received_events_url":"https://api.github.com/users/xinzweb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xinzweb/gpdb","description":"Pivotal Greenplum Database","fork":true,"url":"https://api.github.com/repos/xinzweb/gpdb","forks_url":"https://api.github.com/repos/xinzweb/gpdb/forks","keys_url":"https://api.github.com/repos/xinzweb/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xinzweb/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xinzweb/gpdb/teams","hooks_url":"https://api.github.com/repos/xinzweb/gpdb/hooks","issue_events_url":"https://api.github.com/repos/xinzweb/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/xinzweb/gpdb/events","assignees_url":"https://api.github.com/repos/xinzweb/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/xinzweb/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/xinzweb/gpdb/tags","blobs_url":"https://api.github.com/repos/xinzweb/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xinzweb/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xinzweb/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/xinzweb/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xinzweb/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/xinzweb/gpdb/languages","stargazers_url":"https://api.github.com/repos/xinzweb/gpdb/stargazers","contributors_url":"https://api.github.com/repos/xinzweb/gpdb/contributors","subscribers_url":"https://api.github.com/repos/xinzweb/gpdb/subscribers","subscription_url":"https://api.github.com/repos/xinzweb/gpdb/subscription","commits_url":"https://api.github.com/repos/xinzweb/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/xinzweb/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/xinzweb/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/xinzweb/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/xinzweb/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/xinzweb/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xinzweb/gpdb/merges","archive_url":"https://api.github.com/repos/xinzweb/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xinzweb/gpdb/downloads","issues_url":"https://api.github.com/repos/xinzweb/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/xinzweb/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/xinzweb/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/xinzweb/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xinzweb/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/xinzweb/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/xinzweb/gpdb/deployments","created_at":"2015-11-03T21:41:51Z","updated_at":"2017-01-25T01:33:25Z","pushed_at":"2017-09-13T23:43:49Z","git_url":"git://github.com/xinzweb/gpdb.git","ssh_url":"[email protected]:xinzweb/gpdb.git","clone_url":"https://github.com/xinzweb/gpdb.git","svn_url":"https://github.com/xinzweb/gpdb","homepage":"http://greenplum.org","size":218869,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"8cc820d3cd10f49ed9a943df8c74fe1200da2903","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2017-09-14T10:25:08Z","pushed_at":"2017-09-14T18:34:59Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"[email protected]:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":219912,"stargazers_count":2061,"watchers_count":2061,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":645,"mirror_url":null,"open_issues_count":160,"forks":645,"open_issues":160,"watchers":2061,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/3279"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/3279"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/3279"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/3279/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/3279/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/3279/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/b47ec2eaad3542e28ce19644204b7612eada4de7"}},"author_association":"MEMBER"}}
|
{
"id": 44781140,
"name": "greenplum-db/gpdb",
"url": "https://api.github.com/repos/greenplum-db/gpdb"
}
|
{
"id": 723898,
"login": "xinzweb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/723898?",
"url": "https://api.github.com/users/xinzweb"
}
|
{
"id": 14097842,
"login": "greenplum-db",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14097842?",
"url": "https://api.github.com/orgs/greenplum-db"
}
| 2017-09-14T18:52:39 |
6592195585
|
{"actor":{"display_login":"xinzweb"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/117554495","pull_request_review_id":39270620,"id":117554495,"diff_hunk":"@@ -407,6 +426,32 @@ jobs:\n params:\n file: gpdb_artifacts/greenplum-loaders-*-sles11-x86_64.zip\n \n+- name: compile_gpdb_binary_swap_centos6\n+ plan:\n+ - aggregate:\n+ - get: gpdb_src\n+ - get: gpdb_src_binary_swap\n+ trigger: true\n+ - get: gpaddon_src\n+ - get: centos-gpdb-dev-6\n+ - task: compile_gpdb\n+ file: gpdb_src/concourse/tasks/compile_gpdb_binary_swap.yml\n+ image: centos-gpdb-dev-6\n+ params:\n+ IVYREPO_HOST: {{ivyrepo_host}}\n+ IVYREPO_REALM: {{ivyrepo_realm}}\n+ IVYREPO_USER: {{ivyrepo_user}}\n+ IVYREPO_PASSWD: {{ivyrepo_passwd}}\n+ TARGET_OS: centos\n+ TARGET_OS_VERSION: 6\n+ BLD_TARGETS: \"clients loaders\"\n+ GPDB_SRC_PATH: gpdb_src_binary_swap","path":"concourse/pipelines/pipeline.yml","position":56,"original_position":56,"commit_id":"550c14a087baabdbce93f97ffdb5fa9321d0e95f","original_commit_id":"550c14a087baabdbce93f97ffdb5fa9321d0e95f","user":{"login":"cjcjameson","id":6885889,"avatar_url":"https://avatars0.githubusercontent.com/u/6885889?v=3","gravatar_id":"","url":"https://api.github.com/users/cjcjameson","html_url":"https://github.com/cjcjameson","followers_url":"https://api.github.com/users/cjcjameson/followers","following_url":"https://api.github.com/users/cjcjameson/following{/other_user}","gists_url":"https://api.github.com/users/cjcjameson/gists{/gist_id}","starred_url":"https://api.github.com/users/cjcjameson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjcjameson/subscriptions","organizations_url":"https://api.github.com/users/cjcjameson/orgs","repos_url":"https://api.github.com/users/cjcjameson/repos","events_url":"https://api.github.com/users/cjcjameson/events{/privacy}","received_events_url":"https://api.github.com/users/cjcjameson/received_events","type":"User","site_admin":false},"body":"I see that this is the point at which you're telling concourse to \"jump tracks\" and compile the reference version-tag, rather than latest.\r\n\r\nWould it be easier to just assume that the gpdb_src_binary_swap comes with its own compile_gpdb.yml and use that? We're already assuming that it comes with its own compile_gpdb.bash.\r\n\r\nWhat that would look like is that in the aggregate of `get`s, you don't have two `gpdb_src`s. Just just have one that looks like:\r\n\r\n```\r\n- get: gpdb_src\r\n resource: godb_src_binary_swap\r\n trigger: true\r\n```\r\n\r\nThen the task specification within this job definition stays the same, and you can re-use the `compile_gpdb.yml`, same as with the normal centos 6 compilation. And then I think... I think you can specify the GPDB_BIN_FILENAME here in the pipeline, as you've done, and even if the task.yml doesn't expect that `params:` field, it will still let it through into the shell as an environment variable. Thus, I don't think you need to add `GPDB_BIN_FILENAME:` to `compile_gpdb.yml`.","created_at":"2017-05-19T19:07:09Z","updated_at":"2017-05-19T19:07:28Z","html_url":"https://github.com/greenplum-db/gpdb/pull/2479#discussion_r117554495","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2479","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/117554495"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/2479#discussion_r117554495"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2479"}}},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2479","id":121410845,"html_url":"https://github.com/greenplum-db/gpdb/pull/2479","diff_url":"https://github.com/greenplum-db/gpdb/pull/2479.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/2479.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/2479","number":2479,"state":"open","locked":false,"title":"Binary compatibility tests","user":{"login":"jimmyyih","id":1973115,"avatar_url":"https://avatars1.githubusercontent.com/u/1973115?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmyyih","html_url":"https://github.com/jimmyyih","followers_url":"https://api.github.com/users/jimmyyih/followers","following_url":"https://api.github.com/users/jimmyyih/following{/other_user}","gists_url":"https://api.github.com/users/jimmyyih/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmyyih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmyyih/subscriptions","organizations_url":"https://api.github.com/users/jimmyyih/orgs","repos_url":"https://api.github.com/users/jimmyyih/repos","events_url":"https://api.github.com/users/jimmyyih/events{/privacy}","received_events_url":"https://api.github.com/users/jimmyyih/received_events","type":"User","site_admin":false},"body":"Commit message dump:\r\n```\r\ncommit 0494b842c4f9e49fab4ad6248c211153fd630853\r\n Add binary compatibility testing.\r\n\r\n We need some tests to see if binaries can be swapped around. This\r\n commit provides a simple framework and basic tests to check if\r\n binaries can be upgraded/downgraded by just swapping the Greenplum\r\n binary install paths. Running the tests requires the user to have\r\n another Greenplum compiled which will be provided as an argument to\r\n the test script.\r\n\r\ncommit 550c14a087baabdbce93f97ffdb5fa9321d0e95f\r\n Add binary compatibility tests to Concourse pipeline.\r\n\r\n This is needed to test that Greenplum HEAD is binary compatible with a\r\n previous version of Greenplum. This is controlled by providing a\r\n branch/tag to the gpdb_src_binswap git resource. To start this off,\r\n we'll be testing that HEAD can binary swap over 5.0.0-alpha.4.\r\n```\r\n\r\nThere are plans on incorporating the regression database created during ICW to do better validation but these simple SQLs checking heap, AO, and AOCO should suffice for this initial commit.","created_at":"2017-05-19T01:50:38Z","updated_at":"2017-05-19T19:07:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a8c03fd87d07d660bade907a981e6b8a999af30","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2479/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2479/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/2479/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/550c14a087baabdbce93f97ffdb5fa9321d0e95f","head":{"label":"jimmyyih:binary_swap_test","ref":"binary_swap_test","sha":"550c14a087baabdbce93f97ffdb5fa9321d0e95f","user":{"login":"jimmyyih","id":1973115,"avatar_url":"https://avatars1.githubusercontent.com/u/1973115?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmyyih","html_url":"https://github.com/jimmyyih","followers_url":"https://api.github.com/users/jimmyyih/followers","following_url":"https://api.github.com/users/jimmyyih/following{/other_user}","gists_url":"https://api.github.com/users/jimmyyih/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmyyih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmyyih/subscriptions","organizations_url":"https://api.github.com/users/jimmyyih/orgs","repos_url":"https://api.github.com/users/jimmyyih/repos","events_url":"https://api.github.com/users/jimmyyih/events{/privacy}","received_events_url":"https://api.github.com/users/jimmyyih/received_events","type":"User","site_admin":false},"repo":{"id":45498365,"name":"gpdb","full_name":"jimmyyih/gpdb","owner":{"login":"jimmyyih","id":1973115,"avatar_url":"https://avatars1.githubusercontent.com/u/1973115?v=3","gravatar_id":"","url":"https://api.github.com/users/jimmyyih","html_url":"https://github.com/jimmyyih","followers_url":"https://api.github.com/users/jimmyyih/followers","following_url":"https://api.github.com/users/jimmyyih/following{/other_user}","gists_url":"https://api.github.com/users/jimmyyih/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmyyih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmyyih/subscriptions","organizations_url":"https://api.github.com/users/jimmyyih/orgs","repos_url":"https://api.github.com/users/jimmyyih/repos","events_url":"https://api.github.com/users/jimmyyih/events{/privacy}","received_events_url":"https://api.github.com/users/jimmyyih/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimmyyih/gpdb","description":"Pivotal Greenplum Database","fork":true,"url":"https://api.github.com/repos/jimmyyih/gpdb","forks_url":"https://api.github.com/repos/jimmyyih/gpdb/forks","keys_url":"https://api.github.com/repos/jimmyyih/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimmyyih/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimmyyih/gpdb/teams","hooks_url":"https://api.github.com/repos/jimmyyih/gpdb/hooks","issue_events_url":"https://api.github.com/repos/jimmyyih/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/jimmyyih/gpdb/events","assignees_url":"https://api.github.com/repos/jimmyyih/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/jimmyyih/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/jimmyyih/gpdb/tags","blobs_url":"https://api.github.com/repos/jimmyyih/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimmyyih/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimmyyih/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimmyyih/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimmyyih/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/jimmyyih/gpdb/languages","stargazers_url":"https://api.github.com/repos/jimmyyih/gpdb/stargazers","contributors_url":"https://api.github.com/repos/jimmyyih/gpdb/contributors","subscribers_url":"https://api.github.com/repos/jimmyyih/gpdb/subscribers","subscription_url":"https://api.github.com/repos/jimmyyih/gpdb/subscription","commits_url":"https://api.github.com/repos/jimmyyih/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimmyyih/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimmyyih/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimmyyih/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimmyyih/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/jimmyyih/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimmyyih/gpdb/merges","archive_url":"https://api.github.com/repos/jimmyyih/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimmyyih/gpdb/downloads","issues_url":"https://api.github.com/repos/jimmyyih/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/jimmyyih/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/jimmyyih/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/jimmyyih/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimmyyih/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/jimmyyih/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/jimmyyih/gpdb/deployments","created_at":"2015-11-03T21:58:35Z","updated_at":"2015-11-03T21:59:22Z","pushed_at":"2017-05-19T01:13:48Z","git_url":"git://github.com/jimmyyih/gpdb.git","ssh_url":"[email protected]:jimmyyih/gpdb.git","clone_url":"https://github.com/jimmyyih/gpdb.git","svn_url":"https://github.com/jimmyyih/gpdb","homepage":"http://greenplum.org","size":399018,"stargazers_count":0,"watchers_count":0,"language":"PLpgSQL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"7e774f28d44b7b371071fb486dd9beeb3a20e253","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars1.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars1.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2017-05-19T15:24:11Z","pushed_at":"2017-05-19T19:07:11Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"[email protected]:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":212294,"stargazers_count":1932,"watchers_count":1932,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":588,"mirror_url":null,"open_issues_count":129,"forks":588,"open_issues":129,"watchers":1932,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2479"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/2479"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/2479"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/2479/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2479/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2479/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/550c14a087baabdbce93f97ffdb5fa9321d0e95f"}}}}
|
{
"id": 44781140,
"name": "greenplum-db/gpdb",
"url": "https://api.github.com/repos/greenplum-db/gpdb"
}
|
{
"id": 6885889,
"login": "cjcjameson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6885889?",
"url": "https://api.github.com/users/cjcjameson"
}
|
{
"id": 14097842,
"login": "greenplum-db",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14097842?",
"url": "https://api.github.com/orgs/greenplum-db"
}
| 2017-05-19T19:07:09 |
5907988732
|
{"actor":{"display_login":"cjcjameson"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/115625723","pull_request_review_id":37180670,"id":115625723,"diff_hunk":"@@ -110,13 +111,13 @@ FilePointer FileCache::writeFile(const char* data, File::Metadata&& metadata) {\n return file;\n }\n \n- // write the new file\n- FILE* saveFile = fopen(filepath.c_str(), \"wb\");\n- if (saveFile != nullptr && fwrite(data, metadata.length, 1, saveFile) && fclose(saveFile) == 0) {\n+ QSaveFile saveFile(QString::fromStdString(filepath));\n+ saveFile.open(QIODevice::WriteOnly);\n+ saveFile.write(data, metadata.length);","path":"libraries/networking/src/FileCache.cpp","position":17,"original_position":17,"commit_id":"542001b14f7e6b9ba3ab5dcac329a454c1308b0f","original_commit_id":"542001b14f7e6b9ba3ab5dcac329a454c1308b0f","user":{"login":"huffman","id":167747,"avatar_url":"https://avatars1.githubusercontent.com/u/167747?v=3","gravatar_id":"","url":"https://api.github.com/users/huffman","html_url":"https://github.com/huffman","followers_url":"https://api.github.com/users/huffman/followers","following_url":"https://api.github.com/users/huffman/following{/other_user}","gists_url":"https://api.github.com/users/huffman/gists{/gist_id}","starred_url":"https://api.github.com/users/huffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huffman/subscriptions","organizations_url":"https://api.github.com/users/huffman/orgs","repos_url":"https://api.github.com/users/huffman/repos","events_url":"https://api.github.com/users/huffman/events{/privacy}","received_events_url":"https://api.github.com/users/huffman/received_events","type":"User","site_admin":false},"body":"I ended up omitting the check because commit will fail like you said, but I agree that checking couldn't hurt. I am adding it to the if.","created_at":"2017-05-09T23:28:27Z","updated_at":"2017-05-09T23:28:27Z","html_url":"https://github.com/highfidelity/hifi/pull/10422#discussion_r115625723","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/10422","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/115625723"},"html":{"href":"https://github.com/highfidelity/hifi/pull/10422#discussion_r115625723"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/10422"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/10422","id":119731279,"html_url":"https://github.com/highfidelity/hifi/pull/10422","diff_url":"https://github.com/highfidelity/hifi/pull/10422.diff","patch_url":"https://github.com/highfidelity/hifi/pull/10422.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/10422","number":10422,"state":"open","locked":false,"title":"Fix possible corruption of ktx cache files","user":{"login":"huffman","id":167747,"avatar_url":"https://avatars1.githubusercontent.com/u/167747?v=3","gravatar_id":"","url":"https://api.github.com/users/huffman","html_url":"https://github.com/huffman","followers_url":"https://api.github.com/users/huffman/followers","following_url":"https://api.github.com/users/huffman/following{/other_user}","gists_url":"https://api.github.com/users/huffman/gists{/gist_id}","starred_url":"https://api.github.com/users/huffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huffman/subscriptions","organizations_url":"https://api.github.com/users/huffman/orgs","repos_url":"https://api.github.com/users/huffman/repos","events_url":"https://api.github.com/users/huffman/events{/privacy}","received_events_url":"https://api.github.com/users/huffman/received_events","type":"User","site_admin":false},"body":"When creating a file like this:\r\n\r\n 1. Create file\r\n 2. Write file\r\n 3. Close file\r\n\r\nthere is an opening before the file is written and closed where, if the\r\napplication were to crash (or not finish for any other reason), the file\r\nwould be left in an undefined state. Instead, this change updates it to\r\ndo this:\r\n\r\n 1. Create temp file\r\n 2. Write temp file\r\n 3. Close temp file\r\n 4. Move temp file to final path\r\n\r\nThis ensures that at step 3 we have a valid file, before we rename it.\r\nWe should never end up with a final file in an undefined state, but it is\r\npossible to end up with a temp file that is an undefined state if we,\r\nfor instance, crash during step 2.","created_at":"2017-05-09T19:10:48Z","updated_at":"2017-05-09T23:28:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67f615e201cbfc4e5bf544a50379c4f65909e97c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/10422/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/10422/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/10422/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/542001b14f7e6b9ba3ab5dcac329a454c1308b0f","head":{"label":"huffman:fix/corrupt-ktx","ref":"fix/corrupt-ktx","sha":"542001b14f7e6b9ba3ab5dcac329a454c1308b0f","user":{"login":"huffman","id":167747,"avatar_url":"https://avatars1.githubusercontent.com/u/167747?v=3","gravatar_id":"","url":"https://api.github.com/users/huffman","html_url":"https://github.com/huffman","followers_url":"https://api.github.com/users/huffman/followers","following_url":"https://api.github.com/users/huffman/following{/other_user}","gists_url":"https://api.github.com/users/huffman/gists{/gist_id}","starred_url":"https://api.github.com/users/huffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huffman/subscriptions","organizations_url":"https://api.github.com/users/huffman/orgs","repos_url":"https://api.github.com/users/huffman/repos","events_url":"https://api.github.com/users/huffman/events{/privacy}","received_events_url":"https://api.github.com/users/huffman/received_events","type":"User","site_admin":false},"repo":{"id":16237479,"name":"hifi","full_name":"huffman/hifi","owner":{"login":"huffman","id":167747,"avatar_url":"https://avatars1.githubusercontent.com/u/167747?v=3","gravatar_id":"","url":"https://api.github.com/users/huffman","html_url":"https://github.com/huffman","followers_url":"https://api.github.com/users/huffman/followers","following_url":"https://api.github.com/users/huffman/following{/other_user}","gists_url":"https://api.github.com/users/huffman/gists{/gist_id}","starred_url":"https://api.github.com/users/huffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huffman/subscriptions","organizations_url":"https://api.github.com/users/huffman/orgs","repos_url":"https://api.github.com/users/huffman/repos","events_url":"https://api.github.com/users/huffman/events{/privacy}","received_events_url":"https://api.github.com/users/huffman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huffman/hifi","description":"Open, decentralized virtual world using sensors to control avatars and dynamically assigned devices as servers. San Francisco based startup, we are hiring: http://highfidelity.io/jobs You can also contribute by doing jobs listed at http://worklist.net/worklist.php","fork":true,"url":"https://api.github.com/repos/huffman/hifi","forks_url":"https://api.github.com/repos/huffman/hifi/forks","keys_url":"https://api.github.com/repos/huffman/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huffman/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huffman/hifi/teams","hooks_url":"https://api.github.com/repos/huffman/hifi/hooks","issue_events_url":"https://api.github.com/repos/huffman/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/huffman/hifi/events","assignees_url":"https://api.github.com/repos/huffman/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/huffman/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/huffman/hifi/tags","blobs_url":"https://api.github.com/repos/huffman/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huffman/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huffman/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/huffman/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huffman/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/huffman/hifi/languages","stargazers_url":"https://api.github.com/repos/huffman/hifi/stargazers","contributors_url":"https://api.github.com/repos/huffman/hifi/contributors","subscribers_url":"https://api.github.com/repos/huffman/hifi/subscribers","subscription_url":"https://api.github.com/repos/huffman/hifi/subscription","commits_url":"https://api.github.com/repos/huffman/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/huffman/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/huffman/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/huffman/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/huffman/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/huffman/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huffman/hifi/merges","archive_url":"https://api.github.com/repos/huffman/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huffman/hifi/downloads","issues_url":"https://api.github.com/repos/huffman/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/huffman/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/huffman/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/huffman/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huffman/hifi/labels{/name}","releases_url":"https://api.github.com/repos/huffman/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/huffman/hifi/deployments","created_at":"2014-01-25T18:54:32Z","updated_at":"2015-03-25T17:45:58Z","pushed_at":"2017-05-09T23:01:33Z","git_url":"git://github.com/huffman/hifi.git","ssh_url":"[email protected]:huffman/hifi.git","clone_url":"https://github.com/huffman/hifi.git","svn_url":"https://github.com/huffman/hifi","homepage":"http://highfidelity.io","size":317205,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"713ddd5cefcf3bb73bfb426e0e2e703ec0c5724f","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars3.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars3.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source client/server software for creating shared VR environments. Docs at http://wiki.highfidelity.com We are hiring: http://highfidelity.com/jobs Also, PT work available at http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi/deployments","created_at":"2012-08-10T18:26:22Z","updated_at":"2017-05-08T19:11:15Z","pushed_at":"2017-05-09T23:16:54Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"[email protected]:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":309583,"stargazers_count":504,"watchers_count":504,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":322,"mirror_url":null,"open_issues_count":122,"forks":322,"open_issues":122,"watchers":504,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/10422"},"html":{"href":"https://github.com/highfidelity/hifi/pull/10422"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/10422"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/10422/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/10422/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/10422/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/542001b14f7e6b9ba3ab5dcac329a454c1308b0f"}}}}
|
{
"id": 5372872,
"name": "highfidelity/hifi",
"url": "https://api.github.com/repos/highfidelity/hifi"
}
|
{
"id": 167747,
"login": "huffman",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/167747?",
"url": "https://api.github.com/users/huffman"
}
|
{
"id": 1565370,
"login": "highfidelity",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1565370?",
"url": "https://api.github.com/orgs/highfidelity"
}
| 2017-05-09T23:28:27 |
5841096841
|
{"actor":{"display_login":"huffman"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/108407712","pull_request_review_id":29435135,"id":108407712,"diff_hunk":"@@ -0,0 +1,94 @@\n+/*##############################################################################\n+# HPCC SYSTEMS software Copyright (C) 2012 HPCC Systems®.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+# http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+############################################################################## */\n+define([\n+ \"dojo/_base/declare\",\n+ \"dojo/_base/lang\",\n+ \"dojo/i18n\",\n+ \"dojo/i18n!./nls/hpcc\",\n+ \"dojo/_base/array\",\n+\n+ \"hpcc/GridDetailsWidget\",\n+ \"hpcc/DelayLoadWidget\",\n+ \"hpcc/ESPUtil\",\n+ \"hpcc/WsWorkunits\"\n+\n+], function (declare, lang, i18n, nlsHPCC, arrayUtil,\n+ GridDetailsWidget, DelayLoadWidget, ESPUtil, WsWorkunits) {\n+ return declare(\"GetNumberOfFilesToCopyWidget\", [GridDetailsWidget], {\n+ i18n: nlsHPCC,\n+\n+ gridTitle: nlsHPCC.title_FilesPendingCopy,\n+ idProperty: \"__hpcc_id\",\n+\n+ init: function (params) {\n+ var context = this;\n+ if (this.inherited(arguments))\n+ return;\n+ this.cluster = params.__hpcc_treeItem.Name;\n+\n+ this._refreshActionState();\n+ this.refreshGrid();\n+ },\n+\n+ postCreate: function (args) {\n+ var context = this;\n+ this.inherited(arguments);\n+ },\n+\n+ createGrid: function (domID) {\n+ var context = this;","path":"esp/src/eclwatch/GetNumberOfFilesToCopyWidget.js","position":52,"original_position":52,"commit_id":"bcb929bf6c76b5f2f8f2ccc96d00afdf5a45f10f","original_commit_id":"bcb929bf6c76b5f2f8f2ccc96d00afdf5a45f10f","user":{"login":"GordonSmith","id":966863,"avatar_url":"https://avatars1.githubusercontent.com/u/966863?v=3","gravatar_id":"","url":"https://api.github.com/users/GordonSmith","html_url":"https://github.com/GordonSmith","followers_url":"https://api.github.com/users/GordonSmith/followers","following_url":"https://api.github.com/users/GordonSmith/following{/other_user}","gists_url":"https://api.github.com/users/GordonSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/GordonSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordonSmith/subscriptions","organizations_url":"https://api.github.com/users/GordonSmith/orgs","repos_url":"https://api.github.com/users/GordonSmith/repos","events_url":"https://api.github.com/users/GordonSmith/events{/privacy}","received_events_url":"https://api.github.com/users/GordonSmith/received_events","type":"User","site_admin":false},"body":"Not used.","created_at":"2017-03-28T12:36:09Z","updated_at":"2017-03-28T12:37:37Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/9729#discussion_r108407712","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9729","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/108407712"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/9729#discussion_r108407712"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9729"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9729","id":111852802,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/9729","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/9729.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/9729.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/9729","number":9729,"state":"open","locked":false,"title":"HPCC-16381 Add GetNumFileToCopy","user":{"login":"miguelvazq","id":2362956,"avatar_url":"https://avatars1.githubusercontent.com/u/2362956?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelvazq","html_url":"https://github.com/miguelvazq","followers_url":"https://api.github.com/users/miguelvazq/followers","following_url":"https://api.github.com/users/miguelvazq/following{/other_user}","gists_url":"https://api.github.com/users/miguelvazq/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelvazq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelvazq/subscriptions","organizations_url":"https://api.github.com/users/miguelvazq/orgs","repos_url":"https://api.github.com/users/miguelvazq/repos","events_url":"https://api.github.com/users/miguelvazq/events{/privacy}","received_events_url":"https://api.github.com/users/miguelvazq/received_events","type":"User","site_admin":false},"body":"Add deploy complete notification on the cluster level for Roxie clusters.\r\n\r\nSigned-off-by: Miguel Vazquez <[email protected]>\r\n\r\n<!-- Thank you for submitting a pull request to the HPCC project\r\n\r\n PLEASE READ the following before proceeding.\r\n\r\n This project only accepts pull requests related to open JIRA issues.\r\n If suggesting a new feature or change, please discuss it in a JIRA issue first.\r\n If fixing a bug, there should be an issue describing it with steps to reproduce.\r\n The title line of the pull request (and of each commit within it) should refer to the\r\n associated issue using the format:\r\n\r\n HPCC-nnnnn Short description of issue\r\n\r\n This will allow the Jira ticket to be automatically updated to refer to this pull request,\r\n and will ensure that the automatically-generated changelog is properly formatted.\r\n Where a pull request contains a single commit the pull request title will be set automatically,\r\n assuming that the commit has followed the proper guidelines.\r\n\r\n Please go over all the following points, and put an `x` in all the boxes that apply. You may find\r\n it easier to press the 'Create' button first then click on the checkboxes to edit the comment.\r\n-->\r\n\r\n## Type of change:\r\n- [ ] This change is a bug fix (non-breaking change which fixes an issue).\r\n- [x] This change is a new feature (non-breaking change which adds functionality).\r\n- [ ] This change is a breaking change (fix or feature that will cause existing behavior to change).\r\n- [ ] This change alters the query API (existing queries will have to be recompiled)\r\n\r\n## Checklist:\r\n- [x] My code follows the code style of this project.\r\n - [x] My code does not create any new warnings from compiler, build system, or lint.\r\n- [x] The commit message is properly formatted and free of typos.\r\n - [x] The commit message title makes sense in a changelog, by itself.\r\n - [x] The commit is signed.\r\n- [x] My change requires a change to the documentation.\r\n - [ ] I have updated the documentation accordingly, or...\r\n - [x] I have created a JIRA ticket to update the documentation.\r\n - [ ] Any new interfaces or exported functions are appropriately commented.\r\n- [ ] I have read the CONTRIBUTORS document.\r\n- [ ] The change has been fully tested:\r\n - [ ] I have added tests to cover my changes.\r\n - [ ] All new and existing tests passed.\r\n - [ ] I have checked that this change does not introduce memory leaks.\r\n - [ ] I have used Valgrind or similar tools to check for potential issues.\r\n- [x] I have given due consideration to all of the following potential concerns:\r\n - [x] Scalability\r\n - [ ] Performance\r\n - [ ] Security\r\n - [ ] Thread-safety\r\n - [ ] Premature optimization\r\n - [ ] Existing deployed queries will not be broken\r\n - [ ] This change fixes the problem, not just the symptom\r\n - [ ] The target branch of this pull request is appropriate for such a change.\r\n- [ ] There are no similar instances of the same problem that should be addressed\r\n - [ ] I have addressed them here\r\n - [x] I have raised JIRA issues to address them separately\r\n- [x] This is a user interface / front-end modification\r\n - [x] I have tested my changes in multiple modern browers\r\n - [x] The component(s) render as expected\r\n\r\n## Testing:\r\n<!-- Please describe how this change has been tested.-->\r\n\r\n<!-- Thank you for taking the time to submit this pull request and to answer all of the above-->\r\n","created_at":"2017-03-21T18:48:58Z","updated_at":"2017-03-28T12:37:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2546cf0de6baf14baf239f41617b21024a0abcfd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9729/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9729/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/9729/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/bcb929bf6c76b5f2f8f2ccc96d00afdf5a45f10f","head":{"label":"miguelvazq:GetNumOfFiles","ref":"GetNumOfFiles","sha":"bcb929bf6c76b5f2f8f2ccc96d00afdf5a45f10f","user":{"login":"miguelvazq","id":2362956,"avatar_url":"https://avatars1.githubusercontent.com/u/2362956?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelvazq","html_url":"https://github.com/miguelvazq","followers_url":"https://api.github.com/users/miguelvazq/followers","following_url":"https://api.github.com/users/miguelvazq/following{/other_user}","gists_url":"https://api.github.com/users/miguelvazq/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelvazq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelvazq/subscriptions","organizations_url":"https://api.github.com/users/miguelvazq/orgs","repos_url":"https://api.github.com/users/miguelvazq/repos","events_url":"https://api.github.com/users/miguelvazq/events{/privacy}","received_events_url":"https://api.github.com/users/miguelvazq/received_events","type":"User","site_admin":false},"repo":{"id":5951538,"name":"HPCC-Platform","full_name":"miguelvazq/HPCC-Platform","owner":{"login":"miguelvazq","id":2362956,"avatar_url":"https://avatars1.githubusercontent.com/u/2362956?v=3","gravatar_id":"","url":"https://api.github.com/users/miguelvazq","html_url":"https://github.com/miguelvazq","followers_url":"https://api.github.com/users/miguelvazq/followers","following_url":"https://api.github.com/users/miguelvazq/following{/other_user}","gists_url":"https://api.github.com/users/miguelvazq/gists{/gist_id}","starred_url":"https://api.github.com/users/miguelvazq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguelvazq/subscriptions","organizations_url":"https://api.github.com/users/miguelvazq/orgs","repos_url":"https://api.github.com/users/miguelvazq/repos","events_url":"https://api.github.com/users/miguelvazq/events{/privacy}","received_events_url":"https://api.github.com/users/miguelvazq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miguelvazq/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":true,"url":"https://api.github.com/repos/miguelvazq/HPCC-Platform","forks_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/miguelvazq/HPCC-Platform/deployments","created_at":"2012-09-25T14:49:33Z","updated_at":"2014-09-12T17:18:09Z","pushed_at":"2017-03-27T21:22:51Z","git_url":"git://github.com/miguelvazq/HPCC-Platform.git","ssh_url":"[email protected]:miguelvazq/HPCC-Platform.git","clone_url":"https://github.com/miguelvazq/HPCC-Platform.git","svn_url":"https://github.com/miguelvazq/HPCC-Platform","homepage":"track.hpccsystems.com","size":159209,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"hpcc-systems:candidate-6.4.0","ref":"candidate-6.4.0","sha":"dd2227b6c11b36fd712ff8e8693fe1a061834e41","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars0.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars0.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"HPCC Systems (High Performance Computing Cluster) is an open source, massive parallel-processing computing platform for big data processing and analytics.","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/deployments","created_at":"2011-07-11T14:29:51Z","updated_at":"2017-03-23T06:09:54Z","pushed_at":"2017-03-28T12:24:35Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"[email protected]:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"http://hpccsystems.com","size":159143,"stargazers_count":305,"watchers_count":305,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":160,"mirror_url":null,"open_issues_count":433,"forks":160,"open_issues":433,"watchers":305,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9729"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/9729"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/9729"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/9729/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9729/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/9729/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/bcb929bf6c76b5f2f8f2ccc96d00afdf5a45f10f"}}}}
|
{
"id": 2030681,
"name": "hpcc-systems/HPCC-Platform",
"url": "https://api.github.com/repos/hpcc-systems/HPCC-Platform"
}
|
{
"id": 966863,
"login": "GordonSmith",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/966863?",
"url": "https://api.github.com/users/GordonSmith"
}
|
{
"id": 900867,
"login": "hpcc-systems",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/900867?",
"url": "https://api.github.com/orgs/hpcc-systems"
}
| 2017-03-28T12:36:09 |
5578516256
|
{"actor":{"display_login":"GordonSmith"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/121229177","pull_request_review_id":43266783,"id":121229177,"diff_hunk":"@@ -589,33 +597,211 @@ depending on where they wind up.-->\n </mediaobject>\n </figure></para>\n \n- <para>The package maps page, displays all the package maps loaded on\n+ <para>The package maps page displays all the package maps loaded on\n your cluster. You can Add, Activate, Deactivate, Delete, or Open a\n package map. To examine a package map, select a package map from the\n list.</para>\n \n- <para>You can select the <emphasis role=\"bold\">Validate Package\n- Map</emphasis> tab to validate a package map.</para>\n+ <para>To update the package maps you are using, you would either edit\n+ the package map file or add a new one and then activate it. You could\n+ later delete the old one.</para>\n \n- <para><figure>\n- <title>Validate Package Maps</title>\n+ <sect3>\n+ <title id=\"Packagemap_Actions\">Package Map Actions</title>\n \n- <mediaobject>\n- <imageobject>\n- <imagedata fileref=\"../../images/ECLWaPkMgr.jpg\" />\n- </imageobject>\n- </mediaobject>\n- </figure></para>\n+ <para>You can perform actions on your package maps from the Package\n+ Maps tab in ECL Watch.</para>\n+\n+ <para><emphasis role=\"bold\">Package Map Open</emphasis></para>\n+\n+ <para>To examine a package map, select the package map and press the\n+ <emphasis role=\"bold\">Open</emphasis> action button. This opens a\n+ new tab where you can see the package parts.</para>\n+\n+ <para><emphasis role=\"bold\">Package Map Add </emphasis></para>\n+\n+ <para><figure>\n+ <title>Add Package Maps</title>\n+\n+ <mediaobject>\n+ <imageobject>\n+ <imagedata fileref=\"../../images/ECLWA470A.jpg\"\n+ vendor=\"ECLWatchSS\" />\n+ </imageobject>\n+ </mediaobject>\n+ </figure>To Add a package map to the target cluster:</para>\n+\n+ <orderedlist>\n+ <listitem>\n+ <para>Select the package map to add by checking the box next to\n+ it.</para>\n+ </listitem>\n+\n+ <listitem>\n+ <para>Press the <emphasis role=\"bold\">Add</emphasis> action\n+ button and open the Add Package Map dialog.</para>\n+ </listitem>\n+\n+ <listitem>\n+ <para>Press the <emphasis role=\"bold\">Select Package\n+ File</emphasis> button and select the package files to\n+ add.</para>\n+ </listitem>\n+\n+ <listitem>\n+ <para>Choose the <emphasis role=\"bold\">Target </emphasis>to\n+ associate the package map with.</para>\n+ </listitem>\n+\n+ <listitem>\n+ <para>Select a <emphasis role=\"bold\">Process Filter</emphasis>\n+ from the drop list. The process filter determines which physical\n+ Roxie clusters will actually load the packagemap. </para>\n+ </listitem>\n+\n+ <listitem>\n+ <para>Enter the IP address or hostname of the remote Dali to use\n+ for logical file lookups for the <emphasis role=\"bold\">Remote\n+ Dali IP Address</emphasis> field.</para>\n+ </listitem>\n+\n+ <listitem>\n+ <para>Check the boxes to Activate or Overwrite as\n+ desired.</para>\n+ </listitem>\n+ </orderedlist>\n+\n+ <para><emphasis role=\"bold\">Activate Package Map</emphasis></para>\n+\n+ <para>Press the Activate button to deactivate the currently active\n+ package map and make the selected package map active.</para>\n+\n+ <para><emphasis role=\"bold\">Deactivate Package Map</emphasis></para>\n+\n+ <para>Press the deactivate button to deactivate the currently active\n+ package map.</para>\n+\n+ <para><emphasis role=\"bold\">Package Map Delete </emphasis></para>\n+\n+ <para>To delete a package map:</para>\n+\n+ <orderedlist>\n+ <listitem>\n+ <para>Select the package map to delete by checking the box next\n+ to it.</para>\n+ </listitem>\n+\n+ <listitem>\n+ <para>Press the <emphasis role=\"bold\">Delete</emphasis> action\n+ button.</para>\n+ </listitem>\n+\n+ <listitem>\n+ <para>Press OK when prompted to confirm.</para>\n+ </listitem>\n+ </orderedlist>\n+ </sect3>\n+\n+ <sect3>\n+ <title>Package Map Parts</title>\n+\n+ <para>You can see more information and perform some action on\n+ package map parts. Open the package map to see the package parts\n+ tab.</para>\n+\n+ <para><figure>\n+ <title>Package Parts</title>\n+\n+ <mediaobject>\n+ <imageobject>\n+ <imagedata fileref=\"../../images/ECLWAPkgParts01.jpg\"\n+ vendor=\"ECLWatchSS\" />\n+ </imageobject>\n+ </mediaobject>\n+ </figure></para>\n+\n+ <para>You can examine the individual parts, add parts, or remove\n+ parts through this interface in ECLWatch.</para>\n+\n+ <para><emphasis role=\"bold\">Add Part</emphasis></para>\n+\n+ <para>To add a part to the package map, select the <emphasis\n+ role=\"bold\">Package Parts</emphasis> tab. Then press the <emphasis\n+ role=\"bold\">Add</emphasis> button. Fill in the appropriate\n+ information then press <emphasis\n+ role=\"bold\">Apply</emphasis>.</para>\n+\n+ <para><emphasis role=\"bold\">Remove Part</emphasis></para>\n+\n+ <para>To remove a part from the package map, select the <emphasis\n+ role=\"bold\">Package Parts</emphasis> tab. Then press the <emphasis\n+ role=\"bold\">Remove</emphasis> button and confirm that you really\n+ want to remove the part.</para>\n+\n+ <para><emphasis role=\"bold\">Get Part </emphasis><figure>\n+ <title>Get Part</title>\n+\n+ <mediaobject>\n+ <imageobject>\n+ <imagedata fileref=\"../../images/ECLWaGetPart01.jpg\"\n+ vendor=\"ECLWatchSS\" />\n+ </imageobject>\n+ </mediaobject>\n+ </figure></para>\n+\n+ <para>Press the <emphasis role=\"bold\">Get Part</emphasis> button to\n+ view the contents of the selected part. <figure>\n+ <title>Package Part Contents</title>\n+\n+ <mediaobject>\n+ <imageobject>\n+ <imagedata fileref=\"../../images/ECLWaGetPart02.jpg\"\n+ vendor=\"ECLWatchSS\" />\n+ </imageobject>\n+ </mediaobject>\n+ </figure></para>\n+ </sect3>\n+\n+ <sect3>\n+ <title id=\"Packagemap_Validation\">Package Map Validation</title>\n+\n+ <para>To validate your package map:</para>\n+\n+ <para><figure>\n+ <title>Validate Package Maps</title>\n+\n+ <mediaobject>\n+ <imageobject>\n+ <imagedata fileref=\"../../images/ECLWaPkMgr.jpg\" />\n+ </imageobject>\n+ </mediaobject>\n+ </figure></para>\n \n- <para>Choose the <emphasis role=\"bold\">Target</emphasis> and <emphasis\n- role=\"bold\">Process</emphasis> from the drop lists on the Validate\n- Package Map tab.</para>\n+ <orderedlist>\n+ <listitem>\n+ <para>Select the <emphasis role=\"bold\">Validate Package\n+ Map</emphasis> tab</para>\n+ </listitem>\n \n- <para>Press the <emphasis role=\"bold\">Validate</emphasis> button to\n- validate the package map. The result is shown on the <emphasis\n- role=\"bold\">Validate Active Package Map</emphasis> tab. You can also\n- Validate the package content, on the V<emphasis role=\"bold\">alidate\n- Package Content</emphasis> tab.</para>\n+ <listitem>\n+ <para>Choose the <emphasis role=\"bold\">Target</emphasis> and\n+ <emphasis role=\"bold\">Process</emphasis> from the drop lists on\n+ the <emphasis role=\"bold\">Validate Package Map</emphasis>\n+ tab.</para>\n+ </listitem>\n+\n+ <listitem>\n+ <para>Press the <emphasis role=\"bold\">Validate</emphasis> button\n+ to validate the package map.</para>\n+ </listitem>\n+ </orderedlist>\n+\n+ <para>The result is shown on the <emphasis role=\"bold\">Validate\n+ Active Package Map</emphasis> tab.</para>\n+\n+ <para>You can also Validate the package content on the <emphasis","path":"docs/ECLWatch/ECLWa_mods/ECLWatchQueries.xml","position":258,"original_position":258,"commit_id":"d96242e158fb764c9e2228d1718dad8d4117d752","original_commit_id":"d96242e158fb764c9e2228d1718dad8d4117d752","user":{"login":"afishbeck","id":908017,"avatar_url":"https://avatars2.githubusercontent.com/u/908017?v=3","gravatar_id":"","url":"https://api.github.com/users/afishbeck","html_url":"https://github.com/afishbeck","followers_url":"https://api.github.com/users/afishbeck/followers","following_url":"https://api.github.com/users/afishbeck/following{/other_user}","gists_url":"https://api.github.com/users/afishbeck/gists{/gist_id}","starred_url":"https://api.github.com/users/afishbeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afishbeck/subscriptions","organizations_url":"https://api.github.com/users/afishbeck/orgs","repos_url":"https://api.github.com/users/afishbeck/repos","events_url":"https://api.github.com/users/afishbeck/events{/privacy}","received_events_url":"https://api.github.com/users/afishbeck/received_events","type":"User","site_admin":false},"body":"It's not really \"the\" content. The Validate package content allows you to open any package file, or insert any package content into the form and validate it. It does not first have to be published onto the system.","created_at":"2017-06-09T21:48:23Z","updated_at":"2017-06-09T21:48:46Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/10056#discussion_r121229177","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/10056","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/121229177"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/10056#discussion_r121229177"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/10056"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/10056","id":123364898,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/10056","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/10056.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/10056.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/10056","number":10056,"state":"open","locked":false,"title":"HPCC-17317 DOCS:ECLWatch Add Delete Part","user":{"login":"g-pan","id":910274,"avatar_url":"https://avatars0.githubusercontent.com/u/910274?v=3","gravatar_id":"","url":"https://api.github.com/users/g-pan","html_url":"https://github.com/g-pan","followers_url":"https://api.github.com/users/g-pan/followers","following_url":"https://api.github.com/users/g-pan/following{/other_user}","gists_url":"https://api.github.com/users/g-pan/gists{/gist_id}","starred_url":"https://api.github.com/users/g-pan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-pan/subscriptions","organizations_url":"https://api.github.com/users/g-pan/orgs","repos_url":"https://api.github.com/users/g-pan/repos","events_url":"https://api.github.com/users/g-pan/events{/privacy}","received_events_url":"https://api.github.com/users/g-pan/received_events","type":"User","site_admin":false},"body":"Fix HPCC-17317 DOCS:ECLWatch Add Delete Part\r\nAdd documentation to the ECL Watch doc on\r\nusing the Roxie Package Maps, Add, Delete, Activate Part\r\nNew Pull request, Replacing Pull Request # 10030 & 10050 - due to substantial changes and some technical difficulties with the smoketest. \r\n\r\n@JamesDeFabia please review\r\n@miguelvazq please review\r\n@afishbeck please review\r\n\r\nBuild results and PDF can be reviewed at:\r\nhttp://10.240.32.243/view/Docs/job/DocDev0IV/CE=ubuntu-14.04-amd64-1/lastSuccessfulBuild/artifact/build-docs/Release/docs/The_ECL_Watch_Manual-6.3.0-trunk0.pdf#page=93\r\nNote that chrome users may need to download the file for viewing.\r\n\r\n<!-- Thank you for submitting a pull request to the HPCC project\r\n\r\n PLEASE READ the following before proceeding.\r\n\r\n This project only accepts pull requests related to open JIRA issues.\r\n If suggesting a new feature or change, please discuss it in a JIRA issue first.\r\n If fixing a bug, there should be an issue describing it with steps to reproduce.\r\n The title line of the pull request (and of each commit within it) should refer to the\r\n associated issue using the format:\r\n\r\n HPCC-nnnnn Short description of issue\r\n\r\n This will allow the Jira ticket to be automatically updated to refer to this pull request,\r\n and will ensure that the automatically-generated changelog is properly formatted.\r\n Where a pull request contains a single commit the pull request title will be set automatically,\r\n assuming that the commit has followed the proper guidelines.\r\n\r\n Please go over all the following points, and put an `x` in all the boxes that apply. You may find\r\n it easier to press the 'Create' button first then click on the checkboxes to edit the comment.\r\n-->\r\n\r\n## Type of change:\r\n- [x] This change is a bug fix (non-breaking change which fixes an issue).\r\n- [ ] This change is a new feature (non-breaking change which adds functionality).\r\n- [ ] This change is a breaking change (fix or feature that will cause existing behavior to change).\r\n- [ ] This change alters the query API (existing queries will have to be recompiled)\r\n\r\n## Checklist:\r\n- [x] My code follows the code style of this project.\r\n - [ ] My code does not create any new warnings from compiler, build system, or lint.\r\n- [x] The commit message is properly formatted and free of typos.\r\n - [ ] The commit message title makes sense in a changelog, by itself.\r\n - [ ] The commit is signed.\r\n- [x] My change requires a change to the documentation.\r\n - [x] I have updated the documentation accordingly, or...\r\n - [ ] I have created a JIRA ticket to update the documentation.\r\n - [ ] Any new interfaces or exported functions are appropriately commented.\r\n- [x] I have read the CONTRIBUTORS document.\r\n- [x] The change has been fully tested:\r\n - [x] I have added tests to cover my changes.\r\n - [ ] All new and existing tests passed.\r\n - [ ] I have checked that this change does not introduce memory leaks.\r\n - [ ] I have used Valgrind or similar tools to check for potential issues.\r\n- [x] I have given due consideration to all of the following potential concerns:\r\n - [ ] Scalability\r\n - [ ] Performance\r\n - [ ] Security\r\n - [ ] Thread-safety\r\n - [ ] Premature optimization\r\n - [ ] Existing deployed queries will not be broken\r\n - [ ] This change fixes the problem, not just the symptom\r\n - [ ] The target branch of this pull request is appropriate for such a change.\r\n- [x] There are no similar instances of the same problem that should be addressed\r\n - [ ] I have addressed them here\r\n - [ ] I have raised JIRA issues to address them separately\r\n- [ ] This is a user interface / front-end modification\r\n - [ ] I have tested my changes in multiple modern browers\r\n - [ ] The component(s) render as expected\r\n\r\n## Testing:\r\n<!-- Please describe how this change has been tested.-->\r\n\r\n<!-- Thank you for taking the time to submit this pull request and to answer all of the above-->\r\n","created_at":"2017-05-31T20:46:20Z","updated_at":"2017-06-09T21:48:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5effe4dc4bbddc659db440f3c33172fa263faedd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/10056/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/10056/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/10056/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/d96242e158fb764c9e2228d1718dad8d4117d752","head":{"label":"g-pan:NewH17317-Parts","ref":"NewH17317-Parts","sha":"d96242e158fb764c9e2228d1718dad8d4117d752","user":{"login":"g-pan","id":910274,"avatar_url":"https://avatars0.githubusercontent.com/u/910274?v=3","gravatar_id":"","url":"https://api.github.com/users/g-pan","html_url":"https://github.com/g-pan","followers_url":"https://api.github.com/users/g-pan/followers","following_url":"https://api.github.com/users/g-pan/following{/other_user}","gists_url":"https://api.github.com/users/g-pan/gists{/gist_id}","starred_url":"https://api.github.com/users/g-pan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-pan/subscriptions","organizations_url":"https://api.github.com/users/g-pan/orgs","repos_url":"https://api.github.com/users/g-pan/repos","events_url":"https://api.github.com/users/g-pan/events{/privacy}","received_events_url":"https://api.github.com/users/g-pan/received_events","type":"User","site_admin":false},"repo":{"id":3918391,"name":"HPCC-Platform","full_name":"g-pan/HPCC-Platform","owner":{"login":"g-pan","id":910274,"avatar_url":"https://avatars0.githubusercontent.com/u/910274?v=3","gravatar_id":"","url":"https://api.github.com/users/g-pan","html_url":"https://github.com/g-pan","followers_url":"https://api.github.com/users/g-pan/followers","following_url":"https://api.github.com/users/g-pan/following{/other_user}","gists_url":"https://api.github.com/users/g-pan/gists{/gist_id}","starred_url":"https://api.github.com/users/g-pan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-pan/subscriptions","organizations_url":"https://api.github.com/users/g-pan/orgs","repos_url":"https://api.github.com/users/g-pan/repos","events_url":"https://api.github.com/users/g-pan/events{/privacy}","received_events_url":"https://api.github.com/users/g-pan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/g-pan/HPCC-Platform","description":"HPCC Systems big data solution, community edition","fork":true,"url":"https://api.github.com/repos/g-pan/HPCC-Platform","forks_url":"https://api.github.com/repos/g-pan/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/g-pan/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/g-pan/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/g-pan/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/g-pan/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/g-pan/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/g-pan/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/g-pan/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/g-pan/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/g-pan/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/g-pan/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/g-pan/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/g-pan/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/g-pan/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/g-pan/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/g-pan/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/g-pan/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/g-pan/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/g-pan/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/g-pan/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/g-pan/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/g-pan/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/g-pan/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/g-pan/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/g-pan/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/g-pan/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/g-pan/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/g-pan/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/g-pan/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/g-pan/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/g-pan/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/g-pan/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/g-pan/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/g-pan/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/g-pan/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/g-pan/HPCC-Platform/deployments","created_at":"2012-04-03T13:46:28Z","updated_at":"2017-04-28T15:03:31Z","pushed_at":"2017-06-09T16:06:33Z","git_url":"git://github.com/g-pan/HPCC-Platform.git","ssh_url":"[email protected]:g-pan/HPCC-Platform.git","clone_url":"https://github.com/g-pan/HPCC-Platform.git","svn_url":"https://github.com/g-pan/HPCC-Platform","homepage":"hpccsystems.com","size":170120,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"hpcc-systems:candidate-6.4.0","ref":"candidate-6.4.0","sha":"c5fa17c5bd8aa1abb5849c0e2c4a3b89f62d2cb1","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars0.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars0.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"HPCC Systems (High Performance Computing Cluster) is an open source, massive parallel-processing computing platform for big data processing and analytics.","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/deployments","created_at":"2011-07-11T14:29:51Z","updated_at":"2017-05-26T21:19:12Z","pushed_at":"2017-06-09T19:56:30Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"[email protected]:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"http://hpccsystems.com","size":165330,"stargazers_count":310,"watchers_count":310,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":167,"mirror_url":null,"open_issues_count":430,"forks":167,"open_issues":430,"watchers":310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/10056"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/10056"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/10056"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/10056/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/10056/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/10056/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/d96242e158fb764c9e2228d1718dad8d4117d752"}}}}
|
{
"id": 2030681,
"name": "hpcc-systems/HPCC-Platform",
"url": "https://api.github.com/repos/hpcc-systems/HPCC-Platform"
}
|
{
"id": 908017,
"login": "afishbeck",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/908017?",
"url": "https://api.github.com/users/afishbeck"
}
|
{
"id": 900867,
"login": "hpcc-systems",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/900867?",
"url": "https://api.github.com/orgs/hpcc-systems"
}
| 2017-06-09T21:48:23 |
6038557790
|
{"actor":{"display_login":"afishbeck"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/149982491","pull_request_review_id":75462637,"id":149982491,"diff_hunk":"@@ -85,213 +85,343 @@ static void mkDateCompare(bool dfu,const char *dt,StringBuffer &out,char fill)\n \n void WUiterate(ISashaCommand *cmd, const char *mask)\n {\n- bool dfu = cmd->getDFU();\n- const char *beforedt = cmd->queryBefore();\n- const char *afterdt = cmd->queryAfter();\n- const char *owner = cmd->queryOwner();\n- const char *state = cmd->queryState();\n- const char *cluster = cmd->queryCluster();\n- const char *jobname = cmd->queryJobName();\n- const char *outputformat = cmd->queryOutputFormat();\n- const char *priority = cmd->queryPriority();\n- const char *fileread = cmd->queryFileRead();\n- const char *filewritten = cmd->queryFileWritten();\n- const char *eclcontains = cmd->queryEclContains();\n- const char *cmdname = cmd->queryDfuCmdName();\n- unsigned start = cmd->getStart(); \n- unsigned num = cmd->getLimit();\n- StringBuffer before;\n- StringBuffer after;\n- StringBuffer tmppath;\n- mkDateCompare(dfu,afterdt,after,'0');\n- mkDateCompare(dfu,beforedt,before,'9');\n- bool haswusoutput = cmd->getAction()==SCA_WORKUNIT_SERVICES_GET;\n- bool hasdtoutput = cmd->getAction()==SCA_LISTDT;\n- MemoryBuffer WUSbuf;\n- if (haswusoutput)\n- cmd->setWUSresult(WUSbuf); // swap in/out (in case ever do multiple)\n-\n- StringBuffer baseXPath = dfu ? \"DFU/WorkUnits\" : \"WorkUnits\";\n- Owned<IRemoteConnection> conn;\n- bool isWild = !mask || !*mask || isWildString(mask);\n- bool unfiltered = !mask || !*mask || (0==strcmp(mask,\"*\"));\n- if (cmd->getArchived()) {\n- // used to check not online\n- StringBuffer path;\n- if (dfu)\n- getLdsPath(\"Archive/DFUWorkUnits\",path);\n- else\n- getLdsPath(\"Archive/WorkUnits\",path);\n- Owned<IFile> dir = createIFile(path.str());\n- StringBuffer masktmp;\n- if (unfiltered&&after.length()&&before.length()) {\n- const char *lo = after.str();\n- const char *hi = before.str();\n- while (*lo&&(toupper(*lo)==toupper(*hi))) {\n- masktmp.append((char)toupper(*lo));\n- lo++;\n- hi++;\n+ class CWUData : public CInterface\n+ {\n+ public:\n+ IMPLEMENT_IINTERFACE_USING(CInterface);\n+\n+ CWUData() { };\n+\n+ CDateTime modifiedTime;\n+ Owned<IPropertyTree> wuTree;\n+ };\n+\n+ class CWUReader : public CInterface\n+ {\n+ StringAttr owner, cluster, jobName, state, priority, eclContains, fileRead, fileWritten, cmdName;\n+ StringBuffer mask, fromDT, toDT, fromDir, toDir, afterWU;\n+ bool dfu, hasWUSOutput, outputModifiedTime, outputXML;\n+ MemoryBuffer WUSbuf; //Not sure what this is.\n+\n+ void getMasks(const char *beforeWU, const char *afterWU, StringBuffer &dirMask, StringBuffer &fileMask)\n+ {\n+ //The fromDT and toDT are the filters which defines a search range.\n+ //The afterWU (beforeWU) defines paging within the search range. \n+ //For the first page, a user may define the fromDT and/or toDT without afterWU or beforeWU.\n+ \n+ StringBuffer from, to;\n+ if (!isEmptyString(afterWU) && (fromDT.isEmpty() || (strcmp(afterWU, fromDT.str()) > 0)))\n+ from.set(afterWU);\n+ else if (!fromDT.isEmpty())\n+ from.set(fromDT.str());\n+ if (!isEmptyString(beforeWU) && (toDT.isEmpty() || (strcmp(beforeWU, toDT.str()) < 0)))\n+ to.set(beforeWU);\n+ else if (!toDT.isEmpty())\n+ to.set(toDT.str());\n+\n+ if (!isEmptyString(from))\n+ splitWUID(from, fromDir);\n+ if (!isEmptyString(to))\n+ splitWUID(to, toDir);\n+\n+ bool unfiltered = mask.isEmpty() || streq(mask.str(), \"*\");\n+\n+ //The following code is a clone of the pre-existing code. hmask -> dirMask. tmask -> fileMask.\n+ //The dirMask is used to filter out the directories (ex: W20171010) which store archived WU files.\n+ //The fileMask is used to filter out the WU files (ex: W20171010-101010*.xml).\n+ StringBuffer masktmp;\n+ if (unfiltered && !from.isEmpty() && !to.isEmpty())\n+ {\n+ const char *lo = from.str();\n+ const char *hi = to.str();\n+ while (*lo && (toupper(*lo) == toupper(*hi)))\n+ {\n+ masktmp.append((char)toupper(*lo));\n+ lo++;\n+ hi++;\n+ }\n+ masktmp.append(\"*\");\n+ mask = masktmp.str();\n }\n- masktmp.append(\"*\");\n- mask = masktmp.str();\n+\n+ StringBuffer head;\n+ if (!mask.isEmpty())\n+ {\n+ splitWUID(mask.str(), head);\n+ if (!head.isEmpty())\n+ dirMask = head.str();\n+ fileMask.set(mask.str()).toUpperCase();\n+ }\n+ else\n+ fileMask.append(\"*\");\n+ fileMask.append(\".xml\");\n }\n- StringBuffer head, tmask;\n- const char *hmask = NULL;\n- if (mask&&*mask) {\n- splitWUID(mask,head);\n- if (head.length())\n- hmask = head.str();\n- tmask.clear().append(mask).toUpperCase();\n+ bool checkDirs(const char *dir)\n+ {\n+ if (!fromDir.isEmpty() && (strcmp(dir, fromDir.str()) < 0))\n+ return false;\n+ if (!toDir.isEmpty() && (strcmp(dir, toDir.str()) > 0))\n+ return false;\n+ return true;\n }\n- else\n- tmask.append(\"*\");\n- tmask.append(\".xml\");\n- Owned<IDirectoryIterator> di = dir->directoryFiles(hmask,false,true);\n- StringBuffer name;\n- unsigned index = 0;\n- StringBuffer xb;\n- bool overflowed = false;\n- ForEach(*di) {\n- if (overflowed||(index>start+num))\n- break;\n- if (di->isDir()) {\n- Owned<IDirectoryIterator> di2 = di->query().directoryFiles(tmask.str(),false);\n+ bool parseAndCheckWUID(bool &checkBeforeOrAfterWU, const char *beforeWU,\n+ const char *afterWU, StringBuffer &name)\n+ {\n+ if (name.length() < 5)\n+ return false;\n+\n+ name.setLength(name.length()-4);\n+ name.toUpperCase();\n+ const char *wuid = name.str();\n+ if ((name.length()>6) && strieq(wuid+name.length()-6, \"_HINTS\"))\n+ return false;\n+\n+ if (!mask.isEmpty() && !WildMatch(wuid, mask.str(),true))\n+ return false;\n+\n+ if (checkBeforeOrAfterWU)\n+ {\n+ if (!isEmptyString(afterWU) && (stricmp(wuid, afterWU) <= 0))\n+ return false;\n+ if (!isEmptyString(beforeWU) && (stricmp(wuid, beforeWU) >= 0))\n+ return false;\n+ if (isEmptyString(beforeWU) || isEmptyString(afterWU))\n+ checkBeforeOrAfterWU = false; //Found the starting point. So, do not need to check anymore.\n+ }\n+ return true;\n+ }\n+ bool checkFilters(IPropertyTree *t)\n+ {\n+ //The following code is a clone of the pre-existing code.\n+ StringBuffer path, val;\n+ if (!owner.isEmpty() && (!t->getProp(\"@submitID\", val.clear()) || !WildMatch(val.str(), owner.get(), true)))\n+ return false;\n+ if (!state.isEmpty() && (!t->getProp(dfu?\"Progress/@state\":\"@state\", val.clear()) || !WildMatch(val.str(), state.get(), true)))\n+ return false;\n+ if (!cluster.isEmpty() && (!t->getProp(\"@clusterName\", val.clear()) || !WildMatch(val.str(), cluster.get(), true)))\n+ return false;\n+ if (!jobName.isEmpty() && (!t->getProp(\"@jobName\", val.clear()) || !WildMatch(val.str(), jobName.get(), true)))\n+ return false;\n+ if (!cmdName.isEmpty() && (!t->getProp(\"@command\", val.clear()) || !WildMatch(val.str(), cmdName.get(), true)))\n+ return false;\n+ if (!priority.isEmpty() && (!t->getProp(\"@priorityClass\", val.clear()) || !WildMatch(val.str(), priority.get(), true)))\n+ return false;\n+ if (!fileRead.isEmpty() && !t->hasProp(path.setf(\"FilesRead/File[@name=~?\\\"%s\\\"]\", fileRead.get()).str()))\n+ return false;\n+ if (!fileWritten.isEmpty() && !t->hasProp(path.setf(\"Files/File[@name=~?\\\"%s\\\"]\", fileWritten.get()).str()))\n+ return false;\n+ if (!eclContains.isEmpty() && !t->hasProp(path.setf(\"Query[Text=~?\\\"*%s*\\\"]\", eclContains.get()).str()))\n+ return false;\n+ return true;\n+ }\n+ bool setOutput(ISashaCommand *cmd, StringArray &outputFields, IPropertyTree *wuTree, CDateTime &modifiedTime)\n+ {\n+ if (hasWUSOutput)\n+ { //cmd->getAction()==SCA_WORKUNIT_SERVICES_GET\n+ if (!serializeWUSrow(*wuTree, WUSbuf, false))\n+ return false; //Log overflowed?\n+ }\n+ else if (outputXML)\n+ { //cmd->getAction()==SCA_GET\n+ StringBuffer xml;\n+ toXML(wuTree, xml);\n+ if (!cmd->addResult(xml.str()))\n+ return false; //Log overflowed?\n+ }\n+ else\n+ {\n+ if (outputFields.length() == 0)\n+ cmd->addId(wuTree->queryName());\n+ else\n+ {\n+ StringBuffer output = wuTree->queryName();\n+ setWUDataTree(wuTree, outputFields, output);\n+ cmd->addId(output.str());\n+ }\n+ if (outputModifiedTime)\n+ cmd->addDT(modifiedTime);\n+ }\n+ return true;\n+ }\n+ void setWUDataTree(IPropertyTree *wu, StringArray &outputFields, StringBuffer &output)\n+ {\n+ ForEachItemIn(i, outputFields)\n+ {\n+ const char* outputField = (const char*)outputFields.item(i);\n+\n StringBuffer val;\n- ForEach(*di2) {\n- di2->getName(name.clear());\n- if (!di2->isDir()&&(name.length()>4)) {\n- name.setLength(name.length()-4);\n- name.toUpperCase();\n- const char *wuid = name.str();\n- if ((name.length()>6)&&(stricmp(wuid+name.length()-6,\"_HINTS\")==0))\n+ bool found = true;\n+ if (strieq(outputField, \"owner\"))\n+ wu->getProp(\"@submitID\", val);\n+ else if (strieq(outputField, \"cluster\"))\n+ wu->getProp(\"@clusterName\", val);\n+ else if (strieq(outputField, \"jobname\"))\n+ wu->getProp(\"@jobName\",val);\n+ else if (strieq(outputField,\"state\"))\n+ wu->getProp(\"@state\", val);\n+ else\n+ found = false;\n+ if (found)\n+ output.append(',').append(val);\n+ }\n+ }\n+\n+ public:\n+ IMPLEMENT_IINTERFACE_USING(CInterface);\n+\n+ CWUReader(ISashaCommand *cmd, const char *_mask)\n+ {\n+ mask.set(_mask);\n+ owner.set(cmd->queryOwner());\n+ cluster.set(cmd->queryCluster());\n+ jobName.set(cmd->queryJobName());\n+ state.set(cmd->queryState());\n+ priority.set(cmd->queryPriority());\n+ eclContains.set(cmd->queryEclContains());\n+ fileRead.set(cmd->queryFileRead());\n+ fileWritten.set(cmd->queryFileWritten());\n+ cmdName.set(cmd->queryDfuCmdName());\n+\n+ dfu = cmd->getDFU();\n+ hasWUSOutput = cmd->getAction()==SCA_WORKUNIT_SERVICES_GET;\n+ outputModifiedTime = cmd->getAction()==SCA_LISTDT;\n+ outputXML = cmd->getAction()==SCA_GET;\n+\n+ //In WUiterate(), the queryAfter() is used as fromDT and the queryBefore() is used as toDT.\n+ mkDateCompare(dfu, cmd->queryAfter(), fromDT, '0');\n+ mkDateCompare(dfu, cmd->queryBefore(), toDT, '9');\n+ }\n+ void getWUs(ISashaCommand *cmd, const char *beforeWU, const char *afterWU, unsigned numWUs)\n+ {\n+ StringBuffer path;\n+ if (dfu)\n+ getLdsPath(\"Archive/DFUWorkUnits\", path);\n+ else\n+ getLdsPath(\"Archive/WorkUnits\", path);\n+ Owned<IFile> dir = createIFile(path.str());\n+\n+ StringArray outputFields;\n+ const char *outputFormat = cmd->queryOutputFormat();\n+ outputFields.appendList(outputFormat, \"|,\");\n+\n+ StringBuffer dirMask, fileMask;\n+ getMasks(beforeWU, afterWU, dirMask, fileMask);\n+ bool checkBeforeOrAfterWU = !isEmptyString(beforeWU) || !isEmptyString(afterWU);\n+ bool sortInc = !isEmptyString(beforeWU) && isEmptyString(afterWU);\n+\n+ if (hasWUSOutput)\n+ cmd->setWUSresult(WUSbuf); // swap in/out (in case ever do multiple)\n+\n+ CIArrayOf<CWUData> wus;\n+ unsigned wuCount = 0;\n+ bool overflowed = false;\n+ StringBuffer output;\n+ Owned<IDirectoryIterator> dirIterator = dir->directoryFilesSorted(SD_bynameNC, sortInc, dirMask.isEmpty() ? nullptr : dirMask.str(), false, true);\n+ ForEach(*dirIterator)\n+ {\n+ dirIterator->getName(output.clear());\n+ if (!dirIterator->isDir() || !checkDirs(output.str()))\n+ continue;\n+\n+ Owned<IDirectoryIterator> fileIterator = dirIterator->query().directoryFilesSorted(SD_bynameNC, sortInc, fileMask.str(), false);\n+ ForEach(*fileIterator)\n+ {\n+ fileIterator->getName(output.clear());\n+ if (!parseAndCheckWUID(checkBeforeOrAfterWU, beforeWU, afterWU, output))\n+ continue;\n+ \n+ const char *wuid = output.str();\n+ \n+ Owned<IPropertyTree> wuTree;\n+ if (outputXML || hasWUSOutput || !isEmptyString(outputFormat) || !owner.isEmpty() || !state.isEmpty() || !cluster.isEmpty() ||\n+ !jobName.isEmpty() || !cmdName.isEmpty() || !priority.isEmpty() || !fileRead.isEmpty() ||\n+ !fileWritten.isEmpty() || !eclContains.isEmpty())\n+ {\n+ try\n+ {\n+ wuTree.setown(createPTree(fileIterator->query()));\n+ if (!wuTree || isEmptyString(wuTree->queryName()) || !checkFilters(wuTree))\n+ continue;\n+ }\n+ catch (IException *e)\n+ {\n+ VStringBuffer msg(\"WUiterate: Workunit %s failed to load\", wuid);\n+ EXCLOG(e,msg.str());\n+ e->Release();\n continue;\n- if ((!mask||!*mask||WildMatch(wuid,mask,true)) &&\n- ((before.length()==0)||(stricmp(wuid,before.str())<=0)) &&\n- ((after.length()==0)||(stricmp(wuid,after.str())>=0))) {\n- if (isWild) {\n- if (!conn)\n- conn.setown(querySDS().connect(baseXPath.str(), myProcessSession(), 0, 5*60*1000)); // connection to all\n- }\n- else {\n- VStringBuffer xpath(\"%s/%s\", baseXPath.str(), mask);\n- conn.setown(querySDS().connect(xpath.str(), myProcessSession(), 0, 5*60*1000));\n- }\n- if ((isWild && !conn->queryRoot()->hasProp(wuid)) || (!isWild && !conn)) { // check not online\n- Owned<IPropertyTree> t;\n- bool hasowner = owner&&*owner;\n- bool hascluster = cluster&&*cluster;\n- bool hasstate = state&&*state;\n- bool hasjobname = jobname&&*jobname;\n- bool hasoutput = outputformat&&*outputformat;\n- bool inrange = (index>=start)&&(index<start+num);\n- bool hascommand = cmdname&&*cmdname;\n- bool haspriority = priority&&*priority;\n- bool hasfileread = fileread&&*fileread;\n- bool hasfilewritten = filewritten&&*filewritten;\n- bool haseclcontains = eclcontains&&*eclcontains;\n- if ((cmd->getAction()==SCA_GET)||haswusoutput||hasowner||hasstate||hascluster||hasjobname||hascommand||(hasoutput&&inrange)||haspriority||hasfileread||hasfilewritten||haseclcontains) {\n- try {\n- t.setown(createPTree(di2->query()));\n- if (!t)\n- continue;\n- if (hasowner&&(!t->getProp(\"@submitID\",val.clear())||!WildMatch(val.str(),owner,true)))\n- continue;\n- if (hasstate&&(!t->getProp(dfu?\"Progress/@state\":\"@state\",val.clear())||!WildMatch(val.str(),state,true)))\n- continue;\n- if (hascluster&&(!t->getProp(\"@clusterName\",val.clear())||!WildMatch(val.str(),cluster,true)))\n- continue;\n- if (hasjobname&&(!t->getProp(\"@jobName\",val.clear())||!WildMatch(val.str(),jobname,true)))\n- continue;\n- if (hascommand&&(!t->getProp(\"@command\",val.clear())||!WildMatch(val.str(),cmdname,true)))\n- continue;\n- if (haspriority&&(!t->getProp(\"@priorityClass\",val.clear())||!WildMatch(val.str(),priority,true)))\n- continue;\n- if (hasfileread&&!t->hasProp(tmppath.clear().appendf(\"FilesRead/File[@name=~?\\\"%s\\\"]\",fileread).str()))\n- continue;\n- if (hasfilewritten&&!t->hasProp(tmppath.clear().appendf(\"Files/File[@name=~?\\\"%s\\\"]\",filewritten).str()))\n- continue;\n- if (haseclcontains&&!t->hasProp(tmppath.clear().appendf(\"Query[Text=~?\\\"*%s*\\\"]\",eclcontains).str()))\n- continue;\n- }\n- catch (IException *e) {\n- StringBuffer msg;\n- msg.appendf(\"WUiterate: Workunit %s failed to load\", wuid);\n- EXCLOG(e,msg.str());\n- e->Release();\n- continue;\n- }\n- }\n- index++;\n- if (!inrange)\n- continue;\n- if (hasoutput) {\n- char *saveptr;\n- char *parse = strdup(outputformat);\n- char *tok = strtok_r(parse, \"|,\",&saveptr);\n- while (tok) {\n- val.clear();\n- bool found = true;\n- if (stricmp(tok,\"owner\")==0)\n- t->getProp(\"@submitID\",val);\n- else if (stricmp(tok,\"cluster\")==0)\n- t->getProp(\"@clusterName\",val);\n- else if (stricmp(tok,\"jobname\")==0)\n- t->getProp(\"@jobName\",val);\n- else if (stricmp(tok,\"state\")==0)\n- t->getProp(dfu?\"Progress/@state\":\"@state\",val);\n- else if (stricmp(tok,\"command\")==0)\n- t->getProp(\"@command\",val);\n- else if (stricmp(tok,\"wuid\")==0)\n- t->getName(val);\n- else\n- found = false;\n- if (found) {\n- // remove commas TBD\n- name.append(',').append(val);\n- }\n- tok = strtok_r(NULL, \"|,\",&saveptr);\n- }\n- free(parse);\n- }\n- if (haswusoutput) {\n- if (!serializeWUSrow(*t,WUSbuf,false)) {\n- overflowed = true;\n- break;\n- }\n- }\n- else {\n- cmd->addId(name.str());\n- if (hasdtoutput) {\n- CDateTime dt;\n- di2->getModifiedTime(dt);\n- cmd->addDT(dt);\n- }\n- }\n- if (cmd->getAction()==SCA_GET) {\n- StringBuffer xml;\n- toXML(t,xml);\n- if (!cmd->addResult(xml.str()))\n- break;\n- }\n- }\n }\n }\n- if (index>start+num)\n+\n+ if (sortInc)\n+ {//The output should contain WUs from new to old. So, we need to reverse the order before output.\n+ Owned<CWUData> wu = new CWUData();\n+ if (outputXML || !isEmptyString(outputFormat))\n+ wu->wuTree.setown(wuTree.getClear());\n+ if (outputModifiedTime)\n+ fileIterator->getModifiedTime(wu->modifiedTime);\n+ wus.append(*wu.getClear());\n+ }\n+ else\n+ {\n+ CDateTime dt;\n+ if (outputModifiedTime)\n+ fileIterator->getModifiedTime(dt);\n+\n+ if (!setOutput(cmd, outputFields, wuTree, dt))\n+ {\n+ overflowed = true;\n+ break;\n+ }\n+ }\n+ wuCount++;\n+ if (wuCount == numWUs)\n break;\n }\n+ if (overflowed || (wuCount == numWUs))\n+ break;\n }\n+ if (sortInc)\n+ {\n+ ForEachItemInRev(i, wus)\n+ {\n+ CWUData &wuData = wus.item(i);\n+ if (!setOutput(cmd, outputFields, wuData.wuTree, wuData.modifiedTime)) //Log an error?\n+ break;\n+ }\n+ }\n+\n+ if (hasWUSOutput)\n+ cmd->setWUSresult(WUSbuf);\n }\n- }\n- if (cmd->getOnline()) {\n- if (haswusoutput)\n+ };\n+\n+ Owned<CWUReader> reader = new CWUReader(cmd, mask);\n+ if (!cmd->getOnline())\n+ reader->getWUs(cmd, cmd->queryBeforeWU(), cmd->queryAfterWU(), cmd->getLimit());\n+ else\n+ {//The following code is from the pre-existing code.\n+ bool dfu = cmd->getDFU();\n+ const char *beforedt = cmd->queryBefore();\n+ const char *afterdt = cmd->queryAfter();\n+ const char *owner = cmd->queryOwner();\n+ const char *state = cmd->queryState();\n+ const char *cluster = cmd->queryCluster();\n+ const char *jobname = cmd->queryJobName();\n+ const char *outputformat = cmd->queryOutputFormat();\n+ unsigned start = cmd->getStart(); \n+ unsigned num = cmd->getLimit();\n+ StringBuffer before;\n+ StringBuffer after;\n+ StringBuffer tmppath;\n+ mkDateCompare(dfu,afterdt,after,'0');\n+ mkDateCompare(dfu,beforedt,before,'9');","path":"dali/sasha/saarch.cpp","position":521,"original_position":521,"commit_id":"97745c43e83073f272d6b78d70c36abcdd9bf167","original_commit_id":"97745c43e83073f272d6b78d70c36abcdd9bf167","user":{"login":"wangkx","id":903406,"avatar_url":"https://avatars1.githubusercontent.com/u/903406?v=4","gravatar_id":"","url":"https://api.github.com/users/wangkx","html_url":"https://github.com/wangkx","followers_url":"https://api.github.com/users/wangkx/followers","following_url":"https://api.github.com/users/wangkx/following{/other_user}","gists_url":"https://api.github.com/users/wangkx/gists{/gist_id}","starred_url":"https://api.github.com/users/wangkx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangkx/subscriptions","organizations_url":"https://api.github.com/users/wangkx/orgs","repos_url":"https://api.github.com/users/wangkx/repos","events_url":"https://api.github.com/users/wangkx/events{/privacy}","received_events_url":"https://api.github.com/users/wangkx/received_events","type":"User","site_admin":false},"body":"Sorry for confusing you. My previous comment just tried to explain that why I did not move the getOnlineWus() code into CWUReader and I will move it now.","created_at":"2017-11-09T14:51:50Z","updated_at":"2017-11-09T14:51:50Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/10497#discussion_r149982491","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/10497","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/149982491"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/10497#discussion_r149982491"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/10497"}},"in_reply_to_id":148600649},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/10497","id":146480078,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/10497","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/10497.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/10497.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/10497","number":10497,"state":"open","locked":false,"title":"HPCC-11822 Add new code to access archived workunits with paging","user":{"login":"wangkx","id":903406,"avatar_url":"https://avatars1.githubusercontent.com/u/903406?v=4","gravatar_id":"","url":"https://api.github.com/users/wangkx","html_url":"https://github.com/wangkx","followers_url":"https://api.github.com/users/wangkx/followers","following_url":"https://api.github.com/users/wangkx/following{/other_user}","gists_url":"https://api.github.com/users/wangkx/gists{/gist_id}","starred_url":"https://api.github.com/users/wangkx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangkx/subscriptions","organizations_url":"https://api.github.com/users/wangkx/orgs","repos_url":"https://api.github.com/users/wangkx/repos","events_url":"https://api.github.com/users/wangkx/events{/privacy}","received_events_url":"https://api.github.com/users/wangkx/received_events","type":"User","site_admin":false},"body":"In saarch.cpp, WUiterateSorted() is added to retrieve archived workunits\r\nsorted by WUID. The new code is based on sortDirectory(). The beforeWU/\r\nafterWU and/or StartDate/EndDate are used to skip the directories which\r\nstore WUs not in the date range. The beforeWU/afterWU is also used to\r\nskip the WUs which are not in the time range. The exisitng filters in\r\nthe WUiterate() are supported by WUiterateSorted().\r\n\r\nWUiterateSorted() is used by WsWorkunits.WUQuery to access archived\r\nworkunits with paging. An ESP client may ask for next page by specifing\r\nafterWU or ask for previous page by specifing beforeWU.\r\n\r\nSigned-off-by: wangkx <[email protected]>\r\n\r\n<!-- Thank you for submitting a pull request to the HPCC project\r\n\r\n PLEASE READ the following before proceeding.\r\n\r\n This project only accepts pull requests related to open JIRA issues.\r\n If suggesting a new feature or change, please discuss it in a JIRA issue first.\r\n If fixing a bug, there should be an issue describing it with steps to reproduce.\r\n The title line of the pull request (and of each commit within it) should refer to the\r\n associated issue using the format:\r\n\r\n HPCC-nnnnn Short description of issue\r\n\r\n This will allow the Jira ticket to be automatically updated to refer to this pull request,\r\n and will ensure that the automatically-generated changelog is properly formatted.\r\n Where a pull request contains a single commit the pull request title will be set automatically,\r\n assuming that the commit has followed the proper guidelines.\r\n\r\n Please go over all the following points, and put an `x` in all the boxes that apply. You may find\r\n it easier to press the 'Create' button first then click on the checkboxes to edit the comment.\r\n-->\r\n\r\n## Type of change:\r\n- [ ] This change is a bug fix (non-breaking change which fixes an issue).\r\n- [x] This change is a new feature (non-breaking change which adds functionality).\r\n- [ ] This change improves the code (refactor or other change that does not change the functionality)\r\n- [ ] This change fixes warnings (the fix does not alter the functionality or the generated code)\r\n- [ ] This change is a breaking change (fix or feature that will cause existing behavior to change).\r\n- [ ] This change alters the query API (existing queries will have to be recompiled)\r\n\r\n## Checklist:\r\n- [x] My code follows the code style of this project.\r\n - [x] My code does not create any new warnings from compiler, build system, or lint.\r\n- [x] The commit message is properly formatted and free of typos.\r\n - [ ] The commit message title makes sense in a changelog, by itself.\r\n - [x] The commit is signed.\r\n- [ ] My change requires a change to the documentation.\r\n - [ ] I have updated the documentation accordingly, or...\r\n - [ ] I have created a JIRA ticket to update the documentation.\r\n - [ ] Any new interfaces or exported functions are appropriately commented.\r\n- [x] I have read the CONTRIBUTORS document.\r\n- [x] The change has been fully tested:\r\n - [ ] I have added tests to cover my changes.\r\n - [ ] All new and existing tests passed.\r\n - [ ] I have checked that this change does not introduce memory leaks.\r\n - [ ] I have used Valgrind or similar tools to check for potential issues.\r\n- [x] I have given due consideration to all of the following potential concerns:\r\n - [ ] Scalability\r\n - [ ] Performance\r\n - [ ] Security\r\n - [ ] Thread-safety\r\n - [ ] Premature optimization\r\n - [ ] Existing deployed queries will not be broken\r\n - [ ] This change fixes the problem, not just the symptom\r\n - [ ] The target branch of this pull request is appropriate for such a change.\r\n- [ ] There are no similar instances of the same problem that should be addressed\r\n - [ ] I have addressed them here\r\n - [ ] I have raised JIRA issues to address them separately\r\n- [ ] This is a user interface / front-end modification\r\n - [ ] I have tested my changes in multiple modern browsers\r\n - [ ] The component(s) render as expected\r\n\r\n## Testing:\r\n<!-- Please describe how this change has been tested.-->\r\n\r\n<!-- Thank you for taking the time to submit this pull request and to answer all of the above-->\r\n","created_at":"2017-10-13T15:00:43Z","updated_at":"2017-11-09T14:51:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3330f7202997067eebfd3007e41a486ad38a613e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/10497/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/10497/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/10497/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/97745c43e83073f272d6b78d70c36abcdd9bf167","head":{"label":"wangkx:h11822a","ref":"h11822a","sha":"97745c43e83073f272d6b78d70c36abcdd9bf167","user":{"login":"wangkx","id":903406,"avatar_url":"https://avatars1.githubusercontent.com/u/903406?v=4","gravatar_id":"","url":"https://api.github.com/users/wangkx","html_url":"https://github.com/wangkx","followers_url":"https://api.github.com/users/wangkx/followers","following_url":"https://api.github.com/users/wangkx/following{/other_user}","gists_url":"https://api.github.com/users/wangkx/gists{/gist_id}","starred_url":"https://api.github.com/users/wangkx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangkx/subscriptions","organizations_url":"https://api.github.com/users/wangkx/orgs","repos_url":"https://api.github.com/users/wangkx/repos","events_url":"https://api.github.com/users/wangkx/events{/privacy}","received_events_url":"https://api.github.com/users/wangkx/received_events","type":"User","site_admin":false},"repo":{"id":2199076,"name":"HPCC-Platform","full_name":"wangkx/HPCC-Platform","owner":{"login":"wangkx","id":903406,"avatar_url":"https://avatars1.githubusercontent.com/u/903406?v=4","gravatar_id":"","url":"https://api.github.com/users/wangkx","html_url":"https://github.com/wangkx","followers_url":"https://api.github.com/users/wangkx/followers","following_url":"https://api.github.com/users/wangkx/following{/other_user}","gists_url":"https://api.github.com/users/wangkx/gists{/gist_id}","starred_url":"https://api.github.com/users/wangkx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangkx/subscriptions","organizations_url":"https://api.github.com/users/wangkx/orgs","repos_url":"https://api.github.com/users/wangkx/repos","events_url":"https://api.github.com/users/wangkx/events{/privacy}","received_events_url":"https://api.github.com/users/wangkx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wangkx/HPCC-Platform","description":"HPCC Systems big data solution, community edition","fork":true,"url":"https://api.github.com/repos/wangkx/HPCC-Platform","forks_url":"https://api.github.com/repos/wangkx/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/wangkx/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wangkx/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wangkx/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/wangkx/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/wangkx/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/wangkx/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/wangkx/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/wangkx/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/wangkx/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/wangkx/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wangkx/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wangkx/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/wangkx/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wangkx/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/wangkx/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/wangkx/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/wangkx/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/wangkx/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/wangkx/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/wangkx/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/wangkx/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/wangkx/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/wangkx/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/wangkx/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/wangkx/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wangkx/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/wangkx/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wangkx/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/wangkx/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/wangkx/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/wangkx/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/wangkx/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wangkx/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/wangkx/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/wangkx/HPCC-Platform/deployments","created_at":"2011-08-12T20:36:10Z","updated_at":"2017-07-11T21:02:08Z","pushed_at":"2017-11-08T19:36:08Z","git_url":"git://github.com/wangkx/HPCC-Platform.git","ssh_url":"[email protected]:wangkx/HPCC-Platform.git","clone_url":"https://github.com/wangkx/HPCC-Platform.git","svn_url":"https://github.com/wangkx/HPCC-Platform","homepage":"www.hpccsystems.com","size":178890,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"hpcc-systems:master","ref":"master","sha":"c4f3bc42984997a37723e5d2a957e4bdea5ba24d","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars3.githubusercontent.com/u/900867?v=4","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars3.githubusercontent.com/u/900867?v=4","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"HPCC Systems (High Performance Computing Cluster) is an open source, massive parallel-processing computing platform for big data processing and analytics.","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/deployments","created_at":"2011-07-11T14:29:51Z","updated_at":"2017-11-09T10:00:05Z","pushed_at":"2017-11-09T13:56:35Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"[email protected]:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"http://hpccsystems.com","size":177717,"stargazers_count":320,"watchers_count":320,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":178,"mirror_url":null,"archived":false,"open_issues_count":452,"forks":178,"open_issues":452,"watchers":320,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/10497"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/10497"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/10497"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/10497/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/10497/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/10497/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/97745c43e83073f272d6b78d70c36abcdd9bf167"}},"author_association":"MEMBER"}}
|
{
"id": 2030681,
"name": "hpcc-systems/HPCC-Platform",
"url": "https://api.github.com/repos/hpcc-systems/HPCC-Platform"
}
|
{
"id": 903406,
"login": "wangkx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/903406?",
"url": "https://api.github.com/users/wangkx"
}
|
{
"id": 900867,
"login": "hpcc-systems",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/900867?",
"url": "https://api.github.com/orgs/hpcc-systems"
}
| 2017-11-09T14:51:50 |
6832530691
|
{"actor":{"display_login":"wangkx"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/pulls/comments/142192487","pull_request_review_id":66518170,"id":142192487,"diff_hunk":"@@ -1,22 +1,24 @@\n import React from \"react\";\n import PropTypes from \"prop-types\";\n+import { compose } from \"recompose\";\n+import { translate } from \"react-i18next\";\n+import { connect } from \"react-redux\";\n \n import { password_recovery_tokens } from \"lib/api\";\n import Section from \"components/elements/Section\";\n import ResetPasswordForm from \"components/forms/ResetPasswordForm\";\n import RecoverPasswordForm from \"components/forms/RecoverPasswordForm\";\n \n+import { setJWT, getCurrentUser } from \"actions/session\";\n+import { addToast, TOAST_LEVEL_SUCCESS } from \"actions/toasts\";","path":"app/components/pages/ResetPassword.jsx","position":13,"original_position":13,"commit_id":"ba021166d1a2993efe36fc5cd0749aeb787172cb","original_commit_id":"ba021166d1a2993efe36fc5cd0749aeb787172cb","user":{"login":"jgradim","id":102879,"avatar_url":"https://avatars2.githubusercontent.com/u/102879?v=4","gravatar_id":"","url":"https://api.github.com/users/jgradim","html_url":"https://github.com/jgradim","followers_url":"https://api.github.com/users/jgradim/followers","following_url":"https://api.github.com/users/jgradim/following{/other_user}","gists_url":"https://api.github.com/users/jgradim/gists{/gist_id}","starred_url":"https://api.github.com/users/jgradim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgradim/subscriptions","organizations_url":"https://api.github.com/users/jgradim/orgs","repos_url":"https://api.github.com/users/jgradim/repos","events_url":"https://api.github.com/users/jgradim/events{/privacy}","received_events_url":"https://api.github.com/users/jgradim/received_events","type":"User","site_admin":false},"body":"Add curried `addSuccessToast`, `addFailureToast`","created_at":"2017-10-02T16:45:47Z","updated_at":"2017-10-02T16:45:47Z","html_url":"https://github.com/lifeonmarspt/mentorados-frontend/pull/12#discussion_r142192487","pull_request_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/pulls/12","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/pulls/comments/142192487"},"html":{"href":"https://github.com/lifeonmarspt/mentorados-frontend/pull/12#discussion_r142192487"},"pull_request":{"href":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/pulls/12","id":143645566,"html_url":"https://github.com/lifeonmarspt/mentorados-frontend/pull/12","diff_url":"https://github.com/lifeonmarspt/mentorados-frontend/pull/12.diff","patch_url":"https://github.com/lifeonmarspt/mentorados-frontend/pull/12.patch","issue_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/issues/12","number":12,"state":"open","locked":false,"title":"General fixes","user":{"login":"jgradim","id":102879,"avatar_url":"https://avatars2.githubusercontent.com/u/102879?v=4","gravatar_id":"","url":"https://api.github.com/users/jgradim","html_url":"https://github.com/jgradim","followers_url":"https://api.github.com/users/jgradim/followers","following_url":"https://api.github.com/users/jgradim/following{/other_user}","gists_url":"https://api.github.com/users/jgradim/gists{/gist_id}","starred_url":"https://api.github.com/users/jgradim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgradim/subscriptions","organizations_url":"https://api.github.com/users/jgradim/orgs","repos_url":"https://api.github.com/users/jgradim/repos","events_url":"https://api.github.com/users/jgradim/events{/privacy}","received_events_url":"https://api.github.com/users/jgradim/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-28T13:18:46Z","updated_at":"2017-10-02T16:45:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1852d6e1789715f5ef96d883176b625fa86ffbec","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/pulls/12/commits","review_comments_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/pulls/12/comments","review_comment_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/issues/12/comments","statuses_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/statuses/ba021166d1a2993efe36fc5cd0749aeb787172cb","head":{"label":"lifeonmarspt:general-fixes","ref":"general-fixes","sha":"ba021166d1a2993efe36fc5cd0749aeb787172cb","user":{"login":"lifeonmarspt","id":19327309,"avatar_url":"https://avatars2.githubusercontent.com/u/19327309?v=4","gravatar_id":"","url":"https://api.github.com/users/lifeonmarspt","html_url":"https://github.com/lifeonmarspt","followers_url":"https://api.github.com/users/lifeonmarspt/followers","following_url":"https://api.github.com/users/lifeonmarspt/following{/other_user}","gists_url":"https://api.github.com/users/lifeonmarspt/gists{/gist_id}","starred_url":"https://api.github.com/users/lifeonmarspt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifeonmarspt/subscriptions","organizations_url":"https://api.github.com/users/lifeonmarspt/orgs","repos_url":"https://api.github.com/users/lifeonmarspt/repos","events_url":"https://api.github.com/users/lifeonmarspt/events{/privacy}","received_events_url":"https://api.github.com/users/lifeonmarspt/received_events","type":"Organization","site_admin":false},"repo":{"id":89082390,"name":"mentorados-frontend","full_name":"lifeonmarspt/mentorados-frontend","owner":{"login":"lifeonmarspt","id":19327309,"avatar_url":"https://avatars2.githubusercontent.com/u/19327309?v=4","gravatar_id":"","url":"https://api.github.com/users/lifeonmarspt","html_url":"https://github.com/lifeonmarspt","followers_url":"https://api.github.com/users/lifeonmarspt/followers","following_url":"https://api.github.com/users/lifeonmarspt/following{/other_user}","gists_url":"https://api.github.com/users/lifeonmarspt/gists{/gist_id}","starred_url":"https://api.github.com/users/lifeonmarspt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifeonmarspt/subscriptions","organizations_url":"https://api.github.com/users/lifeonmarspt/orgs","repos_url":"https://api.github.com/users/lifeonmarspt/repos","events_url":"https://api.github.com/users/lifeonmarspt/events{/privacy}","received_events_url":"https://api.github.com/users/lifeonmarspt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lifeonmarspt/mentorados-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend","forks_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/forks","keys_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/teams","hooks_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/hooks","issue_events_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/events","assignees_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/tags","blobs_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/languages","stargazers_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/stargazers","contributors_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/contributors","subscribers_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/subscribers","subscription_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/subscription","commits_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/merges","archive_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/downloads","issues_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/labels{/name}","releases_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/deployments","created_at":"2017-04-22T16:09:38Z","updated_at":"2017-04-22T16:11:11Z","pushed_at":"2017-09-28T13:18:46Z","git_url":"git://github.com/lifeonmarspt/mentorados-frontend.git","ssh_url":"[email protected]:lifeonmarspt/mentorados-frontend.git","clone_url":"https://github.com/lifeonmarspt/mentorados-frontend.git","svn_url":"https://github.com/lifeonmarspt/mentorados-frontend","homepage":null,"size":222,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"lifeonmarspt:develop","ref":"develop","sha":"818db4d2ca6b547ed325ff9a9cc4f48f0c7afc6a","user":{"login":"lifeonmarspt","id":19327309,"avatar_url":"https://avatars2.githubusercontent.com/u/19327309?v=4","gravatar_id":"","url":"https://api.github.com/users/lifeonmarspt","html_url":"https://github.com/lifeonmarspt","followers_url":"https://api.github.com/users/lifeonmarspt/followers","following_url":"https://api.github.com/users/lifeonmarspt/following{/other_user}","gists_url":"https://api.github.com/users/lifeonmarspt/gists{/gist_id}","starred_url":"https://api.github.com/users/lifeonmarspt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifeonmarspt/subscriptions","organizations_url":"https://api.github.com/users/lifeonmarspt/orgs","repos_url":"https://api.github.com/users/lifeonmarspt/repos","events_url":"https://api.github.com/users/lifeonmarspt/events{/privacy}","received_events_url":"https://api.github.com/users/lifeonmarspt/received_events","type":"Organization","site_admin":false},"repo":{"id":89082390,"name":"mentorados-frontend","full_name":"lifeonmarspt/mentorados-frontend","owner":{"login":"lifeonmarspt","id":19327309,"avatar_url":"https://avatars2.githubusercontent.com/u/19327309?v=4","gravatar_id":"","url":"https://api.github.com/users/lifeonmarspt","html_url":"https://github.com/lifeonmarspt","followers_url":"https://api.github.com/users/lifeonmarspt/followers","following_url":"https://api.github.com/users/lifeonmarspt/following{/other_user}","gists_url":"https://api.github.com/users/lifeonmarspt/gists{/gist_id}","starred_url":"https://api.github.com/users/lifeonmarspt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifeonmarspt/subscriptions","organizations_url":"https://api.github.com/users/lifeonmarspt/orgs","repos_url":"https://api.github.com/users/lifeonmarspt/repos","events_url":"https://api.github.com/users/lifeonmarspt/events{/privacy}","received_events_url":"https://api.github.com/users/lifeonmarspt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lifeonmarspt/mentorados-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend","forks_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/forks","keys_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/teams","hooks_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/hooks","issue_events_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/events","assignees_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/tags","blobs_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/languages","stargazers_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/stargazers","contributors_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/contributors","subscribers_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/subscribers","subscription_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/subscription","commits_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/merges","archive_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/downloads","issues_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/labels{/name}","releases_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/deployments","created_at":"2017-04-22T16:09:38Z","updated_at":"2017-04-22T16:11:11Z","pushed_at":"2017-09-28T13:18:46Z","git_url":"git://github.com/lifeonmarspt/mentorados-frontend.git","ssh_url":"[email protected]:lifeonmarspt/mentorados-frontend.git","clone_url":"https://github.com/lifeonmarspt/mentorados-frontend.git","svn_url":"https://github.com/lifeonmarspt/mentorados-frontend","homepage":null,"size":222,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/pulls/12"},"html":{"href":"https://github.com/lifeonmarspt/mentorados-frontend/pull/12"},"issue":{"href":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/issues/12"},"comments":{"href":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/lifeonmarspt/mentorados-frontend/statuses/ba021166d1a2993efe36fc5cd0749aeb787172cb"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 89082390,
"name": "lifeonmarspt/mentorados-frontend",
"url": "https://api.github.com/repos/lifeonmarspt/mentorados-frontend"
}
|
{
"id": 102879,
"login": "jgradim",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/102879?",
"url": "https://api.github.com/users/jgradim"
}
|
{
"id": 19327309,
"login": "lifeonmarspt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19327309?",
"url": "https://api.github.com/orgs/lifeonmarspt"
}
| 2017-10-02T16:45:47 |
6663536429
|
{"actor":{"display_login":"jgradim"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/model-airbnb/Search/pulls/comments/148157846","pull_request_review_id":73357498,"id":148157846,"diff_hunk":"@@ -0,0 +1,55 @@\n+const AWS = require('aws-sdk');\n+const config = require('./aws.config');\n+\n+AWS.config.update({\n+ accessKeyId: process.env.SQS_ACCESS_KEY || config.accessKey,\n+ secretAccessKey: process.env.SQS_SECRET_KEY || config.secretKey,\n+});\n+\n+const sqs = new AWS.SQS({ region: process.env.SQS_REGION || config.region });\n+\n+const MAX_NUMBER_OF_MESSAGES_TO_RECEIVE = 10;\n+const MESSAGE_VISIBILITY_TIMEOUT = 10;\n+const subscribers = [\n+ config.queue,\n+];\n+\n+module.exports.publish = (message) => {\n+ subscribers.forEach((subscriber) => {\n+ const sqsParams = {\n+ QueueUrl: subscriber,\n+ MessageBody: JSON.stringify(message),\n+ };\n+ sqs.sendMessage(sqsParams, (err) => {\n+ if (err) throw err;\n+ });\n+ });\n+};\n+\n+module.exports.poll = () => {\n+ const sqsParams = {\n+ QueueUrl: config.queue,\n+ AttributeNames: ['All'],","path":"messageBus/amazonSQS.js","position":32,"original_position":32,"commit_id":"748705aaed7d275acb704a0e09d95495358dca57","original_commit_id":"748705aaed7d275acb704a0e09d95495358dca57","user":{"login":"tylertruong","id":19479391,"avatar_url":"https://avatars3.githubusercontent.com/u/19479391?v=4","gravatar_id":"","url":"https://api.github.com/users/tylertruong","html_url":"https://github.com/tylertruong","followers_url":"https://api.github.com/users/tylertruong/followers","following_url":"https://api.github.com/users/tylertruong/following{/other_user}","gists_url":"https://api.github.com/users/tylertruong/gists{/gist_id}","starred_url":"https://api.github.com/users/tylertruong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylertruong/subscriptions","organizations_url":"https://api.github.com/users/tylertruong/orgs","repos_url":"https://api.github.com/users/tylertruong/repos","events_url":"https://api.github.com/users/tylertruong/events{/privacy}","received_events_url":"https://api.github.com/users/tylertruong/received_events","type":"User","site_admin":false},"body":"Attribute Names is actually optional if you want all of them. I think you are also using the default visibility time out as well.","created_at":"2017-11-01T00:02:59Z","updated_at":"2017-11-01T00:07:38Z","html_url":"https://github.com/model-airbnb/Search/pull/17#discussion_r148157846","pull_request_url":"https://api.github.com/repos/model-airbnb/Search/pulls/17","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/model-airbnb/Search/pulls/comments/148157846"},"html":{"href":"https://github.com/model-airbnb/Search/pull/17#discussion_r148157846"},"pull_request":{"href":"https://api.github.com/repos/model-airbnb/Search/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/model-airbnb/Search/pulls/17","id":149907746,"html_url":"https://github.com/model-airbnb/Search/pull/17","diff_url":"https://github.com/model-airbnb/Search/pull/17.diff","patch_url":"https://github.com/model-airbnb/Search/pull/17.patch","issue_url":"https://api.github.com/repos/model-airbnb/Search/issues/17","number":17,"state":"open","locked":false,"title":"Add ability to receive search event messages from the search message bus","user":{"login":"christine-w","id":13019368,"avatar_url":"https://avatars3.githubusercontent.com/u/13019368?v=4","gravatar_id":"","url":"https://api.github.com/users/christine-w","html_url":"https://github.com/christine-w","followers_url":"https://api.github.com/users/christine-w/followers","following_url":"https://api.github.com/users/christine-w/following{/other_user}","gists_url":"https://api.github.com/users/christine-w/gists{/gist_id}","starred_url":"https://api.github.com/users/christine-w/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christine-w/subscriptions","organizations_url":"https://api.github.com/users/christine-w/orgs","repos_url":"https://api.github.com/users/christine-w/repos","events_url":"https://api.github.com/users/christine-w/events{/privacy}","received_events_url":"https://api.github.com/users/christine-w/received_events","type":"User","site_admin":false},"body":"This commit includes the following:\r\n- re-organization of message bus functionality into its own folder since it is a different interface from that of the http server\r\n- sqs helper methods to receive and delete messages from the queue\r\n- forward looking features include a subscriber list and topics managed in the message bus interface","created_at":"2017-10-31T21:05:11Z","updated_at":"2017-11-01T00:07:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1069cf826472ddd07ddb40a2401fb22396bfe50e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ryanakiyama","id":24513769,"avatar_url":"https://avatars3.githubusercontent.com/u/24513769?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanakiyama","html_url":"https://github.com/ryanakiyama","followers_url":"https://api.github.com/users/ryanakiyama/followers","following_url":"https://api.github.com/users/ryanakiyama/following{/other_user}","gists_url":"https://api.github.com/users/ryanakiyama/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanakiyama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanakiyama/subscriptions","organizations_url":"https://api.github.com/users/ryanakiyama/orgs","repos_url":"https://api.github.com/users/ryanakiyama/repos","events_url":"https://api.github.com/users/ryanakiyama/events{/privacy}","received_events_url":"https://api.github.com/users/ryanakiyama/received_events","type":"User","site_admin":false},{"login":"tiffaphm","id":25830524,"avatar_url":"https://avatars0.githubusercontent.com/u/25830524?v=4","gravatar_id":"","url":"https://api.github.com/users/tiffaphm","html_url":"https://github.com/tiffaphm","followers_url":"https://api.github.com/users/tiffaphm/followers","following_url":"https://api.github.com/users/tiffaphm/following{/other_user}","gists_url":"https://api.github.com/users/tiffaphm/gists{/gist_id}","starred_url":"https://api.github.com/users/tiffaphm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiffaphm/subscriptions","organizations_url":"https://api.github.com/users/tiffaphm/orgs","repos_url":"https://api.github.com/users/tiffaphm/repos","events_url":"https://api.github.com/users/tiffaphm/events{/privacy}","received_events_url":"https://api.github.com/users/tiffaphm/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/model-airbnb/Search/pulls/17/commits","review_comments_url":"https://api.github.com/repos/model-airbnb/Search/pulls/17/comments","review_comment_url":"https://api.github.com/repos/model-airbnb/Search/pulls/comments{/number}","comments_url":"https://api.github.com/repos/model-airbnb/Search/issues/17/comments","statuses_url":"https://api.github.com/repos/model-airbnb/Search/statuses/748705aaed7d275acb704a0e09d95495358dca57","head":{"label":"model-airbnb:feat/consumeSearchEvents","ref":"feat/consumeSearchEvents","sha":"748705aaed7d275acb704a0e09d95495358dca57","user":{"login":"model-airbnb","id":32991048,"avatar_url":"https://avatars1.githubusercontent.com/u/32991048?v=4","gravatar_id":"","url":"https://api.github.com/users/model-airbnb","html_url":"https://github.com/model-airbnb","followers_url":"https://api.github.com/users/model-airbnb/followers","following_url":"https://api.github.com/users/model-airbnb/following{/other_user}","gists_url":"https://api.github.com/users/model-airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/model-airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/model-airbnb/subscriptions","organizations_url":"https://api.github.com/users/model-airbnb/orgs","repos_url":"https://api.github.com/users/model-airbnb/repos","events_url":"https://api.github.com/users/model-airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/model-airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":107824419,"name":"Search","full_name":"model-airbnb/Search","owner":{"login":"model-airbnb","id":32991048,"avatar_url":"https://avatars1.githubusercontent.com/u/32991048?v=4","gravatar_id":"","url":"https://api.github.com/users/model-airbnb","html_url":"https://github.com/model-airbnb","followers_url":"https://api.github.com/users/model-airbnb/followers","following_url":"https://api.github.com/users/model-airbnb/following{/other_user}","gists_url":"https://api.github.com/users/model-airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/model-airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/model-airbnb/subscriptions","organizations_url":"https://api.github.com/users/model-airbnb/orgs","repos_url":"https://api.github.com/users/model-airbnb/repos","events_url":"https://api.github.com/users/model-airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/model-airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/model-airbnb/Search","description":"Search service for the Airbnb system model","fork":false,"url":"https://api.github.com/repos/model-airbnb/Search","forks_url":"https://api.github.com/repos/model-airbnb/Search/forks","keys_url":"https://api.github.com/repos/model-airbnb/Search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/model-airbnb/Search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/model-airbnb/Search/teams","hooks_url":"https://api.github.com/repos/model-airbnb/Search/hooks","issue_events_url":"https://api.github.com/repos/model-airbnb/Search/issues/events{/number}","events_url":"https://api.github.com/repos/model-airbnb/Search/events","assignees_url":"https://api.github.com/repos/model-airbnb/Search/assignees{/user}","branches_url":"https://api.github.com/repos/model-airbnb/Search/branches{/branch}","tags_url":"https://api.github.com/repos/model-airbnb/Search/tags","blobs_url":"https://api.github.com/repos/model-airbnb/Search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/model-airbnb/Search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/model-airbnb/Search/git/refs{/sha}","trees_url":"https://api.github.com/repos/model-airbnb/Search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/model-airbnb/Search/statuses/{sha}","languages_url":"https://api.github.com/repos/model-airbnb/Search/languages","stargazers_url":"https://api.github.com/repos/model-airbnb/Search/stargazers","contributors_url":"https://api.github.com/repos/model-airbnb/Search/contributors","subscribers_url":"https://api.github.com/repos/model-airbnb/Search/subscribers","subscription_url":"https://api.github.com/repos/model-airbnb/Search/subscription","commits_url":"https://api.github.com/repos/model-airbnb/Search/commits{/sha}","git_commits_url":"https://api.github.com/repos/model-airbnb/Search/git/commits{/sha}","comments_url":"https://api.github.com/repos/model-airbnb/Search/comments{/number}","issue_comment_url":"https://api.github.com/repos/model-airbnb/Search/issues/comments{/number}","contents_url":"https://api.github.com/repos/model-airbnb/Search/contents/{+path}","compare_url":"https://api.github.com/repos/model-airbnb/Search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/model-airbnb/Search/merges","archive_url":"https://api.github.com/repos/model-airbnb/Search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/model-airbnb/Search/downloads","issues_url":"https://api.github.com/repos/model-airbnb/Search/issues{/number}","pulls_url":"https://api.github.com/repos/model-airbnb/Search/pulls{/number}","milestones_url":"https://api.github.com/repos/model-airbnb/Search/milestones{/number}","notifications_url":"https://api.github.com/repos/model-airbnb/Search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/model-airbnb/Search/labels{/name}","releases_url":"https://api.github.com/repos/model-airbnb/Search/releases{/id}","deployments_url":"https://api.github.com/repos/model-airbnb/Search/deployments","created_at":"2017-10-21T23:51:57Z","updated_at":"2017-10-21T23:53:23Z","pushed_at":"2017-10-31T21:05:12Z","git_url":"git://github.com/model-airbnb/Search.git","ssh_url":"[email protected]:model-airbnb/Search.git","clone_url":"https://github.com/model-airbnb/Search.git","svn_url":"https://github.com/model-airbnb/Search","homepage":null,"size":55,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"model-airbnb:master","ref":"master","sha":"3c7f42ce344112c9845da04051f284721d851c4d","user":{"login":"model-airbnb","id":32991048,"avatar_url":"https://avatars1.githubusercontent.com/u/32991048?v=4","gravatar_id":"","url":"https://api.github.com/users/model-airbnb","html_url":"https://github.com/model-airbnb","followers_url":"https://api.github.com/users/model-airbnb/followers","following_url":"https://api.github.com/users/model-airbnb/following{/other_user}","gists_url":"https://api.github.com/users/model-airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/model-airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/model-airbnb/subscriptions","organizations_url":"https://api.github.com/users/model-airbnb/orgs","repos_url":"https://api.github.com/users/model-airbnb/repos","events_url":"https://api.github.com/users/model-airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/model-airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":107824419,"name":"Search","full_name":"model-airbnb/Search","owner":{"login":"model-airbnb","id":32991048,"avatar_url":"https://avatars1.githubusercontent.com/u/32991048?v=4","gravatar_id":"","url":"https://api.github.com/users/model-airbnb","html_url":"https://github.com/model-airbnb","followers_url":"https://api.github.com/users/model-airbnb/followers","following_url":"https://api.github.com/users/model-airbnb/following{/other_user}","gists_url":"https://api.github.com/users/model-airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/model-airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/model-airbnb/subscriptions","organizations_url":"https://api.github.com/users/model-airbnb/orgs","repos_url":"https://api.github.com/users/model-airbnb/repos","events_url":"https://api.github.com/users/model-airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/model-airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/model-airbnb/Search","description":"Search service for the Airbnb system model","fork":false,"url":"https://api.github.com/repos/model-airbnb/Search","forks_url":"https://api.github.com/repos/model-airbnb/Search/forks","keys_url":"https://api.github.com/repos/model-airbnb/Search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/model-airbnb/Search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/model-airbnb/Search/teams","hooks_url":"https://api.github.com/repos/model-airbnb/Search/hooks","issue_events_url":"https://api.github.com/repos/model-airbnb/Search/issues/events{/number}","events_url":"https://api.github.com/repos/model-airbnb/Search/events","assignees_url":"https://api.github.com/repos/model-airbnb/Search/assignees{/user}","branches_url":"https://api.github.com/repos/model-airbnb/Search/branches{/branch}","tags_url":"https://api.github.com/repos/model-airbnb/Search/tags","blobs_url":"https://api.github.com/repos/model-airbnb/Search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/model-airbnb/Search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/model-airbnb/Search/git/refs{/sha}","trees_url":"https://api.github.com/repos/model-airbnb/Search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/model-airbnb/Search/statuses/{sha}","languages_url":"https://api.github.com/repos/model-airbnb/Search/languages","stargazers_url":"https://api.github.com/repos/model-airbnb/Search/stargazers","contributors_url":"https://api.github.com/repos/model-airbnb/Search/contributors","subscribers_url":"https://api.github.com/repos/model-airbnb/Search/subscribers","subscription_url":"https://api.github.com/repos/model-airbnb/Search/subscription","commits_url":"https://api.github.com/repos/model-airbnb/Search/commits{/sha}","git_commits_url":"https://api.github.com/repos/model-airbnb/Search/git/commits{/sha}","comments_url":"https://api.github.com/repos/model-airbnb/Search/comments{/number}","issue_comment_url":"https://api.github.com/repos/model-airbnb/Search/issues/comments{/number}","contents_url":"https://api.github.com/repos/model-airbnb/Search/contents/{+path}","compare_url":"https://api.github.com/repos/model-airbnb/Search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/model-airbnb/Search/merges","archive_url":"https://api.github.com/repos/model-airbnb/Search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/model-airbnb/Search/downloads","issues_url":"https://api.github.com/repos/model-airbnb/Search/issues{/number}","pulls_url":"https://api.github.com/repos/model-airbnb/Search/pulls{/number}","milestones_url":"https://api.github.com/repos/model-airbnb/Search/milestones{/number}","notifications_url":"https://api.github.com/repos/model-airbnb/Search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/model-airbnb/Search/labels{/name}","releases_url":"https://api.github.com/repos/model-airbnb/Search/releases{/id}","deployments_url":"https://api.github.com/repos/model-airbnb/Search/deployments","created_at":"2017-10-21T23:51:57Z","updated_at":"2017-10-21T23:53:23Z","pushed_at":"2017-10-31T21:05:12Z","git_url":"git://github.com/model-airbnb/Search.git","ssh_url":"[email protected]:model-airbnb/Search.git","clone_url":"https://github.com/model-airbnb/Search.git","svn_url":"https://github.com/model-airbnb/Search","homepage":null,"size":55,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/model-airbnb/Search/pulls/17"},"html":{"href":"https://github.com/model-airbnb/Search/pull/17"},"issue":{"href":"https://api.github.com/repos/model-airbnb/Search/issues/17"},"comments":{"href":"https://api.github.com/repos/model-airbnb/Search/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/model-airbnb/Search/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/model-airbnb/Search/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/model-airbnb/Search/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/model-airbnb/Search/statuses/748705aaed7d275acb704a0e09d95495358dca57"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 107824419,
"name": "model-airbnb/Search",
"url": "https://api.github.com/repos/model-airbnb/Search"
}
|
{
"id": 19479391,
"login": "tylertruong",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19479391?",
"url": "https://api.github.com/users/tylertruong"
}
|
{
"id": 32991048,
"login": "model-airbnb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/32991048?",
"url": "https://api.github.com/orgs/model-airbnb"
}
| 2017-11-01T00:02:59 |
6792412228
|
{"actor":{"display_login":"tylertruong"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/pulls/comments/144171316","pull_request_review_id":68791147,"id":144171316,"diff_hunk":"@@ -305,6 +305,140 @@ msgctxt \"preference_about\"\n msgid \"About %1$s\"\n msgstr \"\"\n \n+#. Header for the list of installed search engines\n+msgctxt \"preference_search_installed_search_engines\"\n+msgid \"Installed search engines\"\n+msgstr \"\"\n+\n+#. Action for restoring the default list of search engines\n+msgctxt \"preference_search_restore\"\n+msgid \"Restore default search engines\"\n+msgstr \"\"\n+\n+#. Action for adding an additional search engine to the list\n+msgctxt \"preference_search_add\"\n+msgid \"Add another search engine\"\n+msgstr \"\"\n+\n+msgctxt \"preference_search_remove\"\n+msgid \"Remove\"\n+msgstr \"\"\n+\n+#. Clickable text in tutorial to open a dialog to manually add a search engine\n+msgctxt \"tutorial_search_manually_add\"\n+msgid \"MANUALLY ADD\"\n+msgstr \"\"\n+\n+msgctxt \"tutorial_search_cancel\"\n+msgid \"CANCEL\"","path":"locales/templates/app.pot","position":38,"original_position":38,"commit_id":"31a0eb1fa5b39ba0f20c9d1c74b994ca315f9d03","original_commit_id":"945b2ffe96dad146db5f9c59966ce005a9594648","user":{"login":"Delphine","id":399020,"avatar_url":"https://avatars3.githubusercontent.com/u/399020?v=4","gravatar_id":"","url":"https://api.github.com/users/Delphine","html_url":"https://github.com/Delphine","followers_url":"https://api.github.com/users/Delphine/followers","following_url":"https://api.github.com/users/Delphine/following{/other_user}","gists_url":"https://api.github.com/users/Delphine/gists{/gist_id}","starred_url":"https://api.github.com/users/Delphine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Delphine/subscriptions","organizations_url":"https://api.github.com/users/Delphine/orgs","repos_url":"https://api.github.com/users/Delphine/repos","events_url":"https://api.github.com/users/Delphine/events{/privacy}","received_events_url":"https://api.github.com/users/Delphine/received_events","type":"User","site_admin":false},"body":"Same question here about caplocks","created_at":"2017-10-12T00:40:34Z","updated_at":"2017-10-12T00:52:57Z","html_url":"https://github.com/mozilla-l10n/focus-android-l10n/pull/22#discussion_r144171316","pull_request_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/pulls/22","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/pulls/comments/144171316"},"html":{"href":"https://github.com/mozilla-l10n/focus-android-l10n/pull/22#discussion_r144171316"},"pull_request":{"href":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/pulls/22","id":146089892,"html_url":"https://github.com/mozilla-l10n/focus-android-l10n/pull/22","diff_url":"https://github.com/mozilla-l10n/focus-android-l10n/pull/22.diff","patch_url":"https://github.com/mozilla-l10n/focus-android-l10n/pull/22.patch","issue_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/issues/22","number":22,"state":"open","locked":false,"title":"Export Granite Strings","user":{"login":"liuche","id":1082253,"avatar_url":"https://avatars0.githubusercontent.com/u/1082253?v=4","gravatar_id":"","url":"https://api.github.com/users/liuche","html_url":"https://github.com/liuche","followers_url":"https://api.github.com/users/liuche/followers","following_url":"https://api.github.com/users/liuche/following{/other_user}","gists_url":"https://api.github.com/users/liuche/gists{/gist_id}","starred_url":"https://api.github.com/users/liuche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liuche/subscriptions","organizations_url":"https://api.github.com/users/liuche/orgs","repos_url":"https://api.github.com/users/liuche/repos","events_url":"https://api.github.com/users/liuche/events{/privacy}","received_events_url":"https://api.github.com/users/liuche/received_events","type":"User","site_admin":false},"body":"These are string for the \"Add search engine\" feature.","created_at":"2017-10-12T00:04:39Z","updated_at":"2017-10-12T00:52:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"377747d87e23d1fdb8d215329ec3e1e3c84445e2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/pulls/22/commits","review_comments_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/pulls/22/comments","review_comment_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/issues/22/comments","statuses_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/statuses/31a0eb1fa5b39ba0f20c9d1c74b994ca315f9d03","head":{"label":"liuche:export-2017-10-11","ref":"export-2017-10-11","sha":"31a0eb1fa5b39ba0f20c9d1c74b994ca315f9d03","user":{"login":"liuche","id":1082253,"avatar_url":"https://avatars0.githubusercontent.com/u/1082253?v=4","gravatar_id":"","url":"https://api.github.com/users/liuche","html_url":"https://github.com/liuche","followers_url":"https://api.github.com/users/liuche/followers","following_url":"https://api.github.com/users/liuche/following{/other_user}","gists_url":"https://api.github.com/users/liuche/gists{/gist_id}","starred_url":"https://api.github.com/users/liuche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liuche/subscriptions","organizations_url":"https://api.github.com/users/liuche/orgs","repos_url":"https://api.github.com/users/liuche/repos","events_url":"https://api.github.com/users/liuche/events{/privacy}","received_events_url":"https://api.github.com/users/liuche/received_events","type":"User","site_admin":false},"repo":{"id":105320670,"name":"focus-android-l10n","full_name":"liuche/focus-android-l10n","owner":{"login":"liuche","id":1082253,"avatar_url":"https://avatars0.githubusercontent.com/u/1082253?v=4","gravatar_id":"","url":"https://api.github.com/users/liuche","html_url":"https://github.com/liuche","followers_url":"https://api.github.com/users/liuche/followers","following_url":"https://api.github.com/users/liuche/following{/other_user}","gists_url":"https://api.github.com/users/liuche/gists{/gist_id}","starred_url":"https://api.github.com/users/liuche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liuche/subscriptions","organizations_url":"https://api.github.com/users/liuche/orgs","repos_url":"https://api.github.com/users/liuche/repos","events_url":"https://api.github.com/users/liuche/events{/privacy}","received_events_url":"https://api.github.com/users/liuche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liuche/focus-android-l10n","description":"Strings for the Focus (Android) project","fork":true,"url":"https://api.github.com/repos/liuche/focus-android-l10n","forks_url":"https://api.github.com/repos/liuche/focus-android-l10n/forks","keys_url":"https://api.github.com/repos/liuche/focus-android-l10n/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liuche/focus-android-l10n/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liuche/focus-android-l10n/teams","hooks_url":"https://api.github.com/repos/liuche/focus-android-l10n/hooks","issue_events_url":"https://api.github.com/repos/liuche/focus-android-l10n/issues/events{/number}","events_url":"https://api.github.com/repos/liuche/focus-android-l10n/events","assignees_url":"https://api.github.com/repos/liuche/focus-android-l10n/assignees{/user}","branches_url":"https://api.github.com/repos/liuche/focus-android-l10n/branches{/branch}","tags_url":"https://api.github.com/repos/liuche/focus-android-l10n/tags","blobs_url":"https://api.github.com/repos/liuche/focus-android-l10n/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liuche/focus-android-l10n/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liuche/focus-android-l10n/git/refs{/sha}","trees_url":"https://api.github.com/repos/liuche/focus-android-l10n/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liuche/focus-android-l10n/statuses/{sha}","languages_url":"https://api.github.com/repos/liuche/focus-android-l10n/languages","stargazers_url":"https://api.github.com/repos/liuche/focus-android-l10n/stargazers","contributors_url":"https://api.github.com/repos/liuche/focus-android-l10n/contributors","subscribers_url":"https://api.github.com/repos/liuche/focus-android-l10n/subscribers","subscription_url":"https://api.github.com/repos/liuche/focus-android-l10n/subscription","commits_url":"https://api.github.com/repos/liuche/focus-android-l10n/commits{/sha}","git_commits_url":"https://api.github.com/repos/liuche/focus-android-l10n/git/commits{/sha}","comments_url":"https://api.github.com/repos/liuche/focus-android-l10n/comments{/number}","issue_comment_url":"https://api.github.com/repos/liuche/focus-android-l10n/issues/comments{/number}","contents_url":"https://api.github.com/repos/liuche/focus-android-l10n/contents/{+path}","compare_url":"https://api.github.com/repos/liuche/focus-android-l10n/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liuche/focus-android-l10n/merges","archive_url":"https://api.github.com/repos/liuche/focus-android-l10n/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liuche/focus-android-l10n/downloads","issues_url":"https://api.github.com/repos/liuche/focus-android-l10n/issues{/number}","pulls_url":"https://api.github.com/repos/liuche/focus-android-l10n/pulls{/number}","milestones_url":"https://api.github.com/repos/liuche/focus-android-l10n/milestones{/number}","notifications_url":"https://api.github.com/repos/liuche/focus-android-l10n/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liuche/focus-android-l10n/labels{/name}","releases_url":"https://api.github.com/repos/liuche/focus-android-l10n/releases{/id}","deployments_url":"https://api.github.com/repos/liuche/focus-android-l10n/deployments","created_at":"2017-09-29T22:01:21Z","updated_at":"2017-08-23T21:03:23Z","pushed_at":"2017-10-12T00:02:32Z","git_url":"git://github.com/liuche/focus-android-l10n.git","ssh_url":"[email protected]:liuche/focus-android-l10n.git","clone_url":"https://github.com/liuche/focus-android-l10n.git","svn_url":"https://github.com/liuche/focus-android-l10n","homepage":null,"size":1995,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-l10n:master","ref":"master","sha":"fb8ea9ef55d50fc292de20f5667f849050dcd3a5","user":{"login":"mozilla-l10n","id":8619669,"avatar_url":"https://avatars3.githubusercontent.com/u/8619669?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-l10n","html_url":"https://github.com/mozilla-l10n","followers_url":"https://api.github.com/users/mozilla-l10n/followers","following_url":"https://api.github.com/users/mozilla-l10n/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-l10n/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-l10n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-l10n/subscriptions","organizations_url":"https://api.github.com/users/mozilla-l10n/orgs","repos_url":"https://api.github.com/users/mozilla-l10n/repos","events_url":"https://api.github.com/users/mozilla-l10n/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-l10n/received_events","type":"Organization","site_admin":false},"repo":{"id":82914570,"name":"focus-android-l10n","full_name":"mozilla-l10n/focus-android-l10n","owner":{"login":"mozilla-l10n","id":8619669,"avatar_url":"https://avatars3.githubusercontent.com/u/8619669?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-l10n","html_url":"https://github.com/mozilla-l10n","followers_url":"https://api.github.com/users/mozilla-l10n/followers","following_url":"https://api.github.com/users/mozilla-l10n/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-l10n/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-l10n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-l10n/subscriptions","organizations_url":"https://api.github.com/users/mozilla-l10n/orgs","repos_url":"https://api.github.com/users/mozilla-l10n/repos","events_url":"https://api.github.com/users/mozilla-l10n/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-l10n/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-l10n/focus-android-l10n","description":"Strings for the Focus (Android) project","fork":false,"url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n","forks_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/forks","keys_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/teams","hooks_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/hooks","issue_events_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/events","assignees_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/tags","blobs_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/languages","stargazers_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/stargazers","contributors_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/contributors","subscribers_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/subscribers","subscription_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/subscription","commits_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/merges","archive_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/downloads","issues_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/deployments","created_at":"2017-02-23T10:14:35Z","updated_at":"2017-08-23T21:03:23Z","pushed_at":"2017-10-12T00:04:40Z","git_url":"git://github.com/mozilla-l10n/focus-android-l10n.git","ssh_url":"[email protected]:mozilla-l10n/focus-android-l10n.git","clone_url":"https://github.com/mozilla-l10n/focus-android-l10n.git","svn_url":"https://github.com/mozilla-l10n/focus-android-l10n","homepage":null,"size":2044,"stargazers_count":3,"watchers_count":3,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/pulls/22"},"html":{"href":"https://github.com/mozilla-l10n/focus-android-l10n/pull/22"},"issue":{"href":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/issues/22"},"comments":{"href":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-l10n/focus-android-l10n/statuses/31a0eb1fa5b39ba0f20c9d1c74b994ca315f9d03"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 82914570,
"name": "mozilla-l10n/focus-android-l10n",
"url": "https://api.github.com/repos/mozilla-l10n/focus-android-l10n"
}
|
{
"id": 399020,
"login": "Delphine",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/399020?",
"url": "https://api.github.com/users/Delphine"
}
|
{
"id": 8619669,
"login": "mozilla-l10n",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8619669?",
"url": "https://api.github.com/orgs/mozilla-l10n"
}
| 2017-10-12T00:40:34 |
6705529267
|
{"actor":{"display_login":"Delphine"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/comments/112809900","pull_request_review_id":34157560,"id":112809900,"diff_hunk":"@@ -14,6 +14,16 @@\n <a href=\"http://v4-alpha.getbootstrap.com\" target=\"_blank\">Bootstrap CSS</a> (tested with 4.0.0-alpha.6)\n </li>\n </ul>\n+\n+ <h3>\n+ Supported browsers\n+ </h3>\n+ <p>We strive to support the same browsers and versions as supported by both Bootstrap 4 and Angular, whichever is more restrictive. Check browser support notes for\n+ <a href=\"https://angular.io/docs/ts/latest/guide/browser-support.html\" target=\"_blank\">Angular</a> and","path":"demo/src/app/getting-started/getting-started.component.html","position":9,"original_position":9,"commit_id":"f227a9317dbbaeab44c7b05cf066a901190567fe","original_commit_id":"f227a9317dbbaeab44c7b05cf066a901190567fe","user":{"login":"Foxandxss","id":1087957,"avatar_url":"https://avatars1.githubusercontent.com/u/1087957?v=3","gravatar_id":"","url":"https://api.github.com/users/Foxandxss","html_url":"https://github.com/Foxandxss","followers_url":"https://api.github.com/users/Foxandxss/followers","following_url":"https://api.github.com/users/Foxandxss/following{/other_user}","gists_url":"https://api.github.com/users/Foxandxss/gists{/gist_id}","starred_url":"https://api.github.com/users/Foxandxss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Foxandxss/subscriptions","organizations_url":"https://api.github.com/users/Foxandxss/orgs","repos_url":"https://api.github.com/users/Foxandxss/repos","events_url":"https://api.github.com/users/Foxandxss/events{/privacy}","received_events_url":"https://api.github.com/users/Foxandxss/received_events","type":"User","site_admin":false},"body":"That is going to change within days :P","created_at":"2017-04-22T13:33:25Z","updated_at":"2017-04-22T13:33:25Z","html_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/1511#discussion_r112809900","pull_request_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/1511","_links":{"self":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/comments/112809900"},"html":{"href":"https://github.com/ng-bootstrap/ng-bootstrap/pull/1511#discussion_r112809900"},"pull_request":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/1511"}}},"pull_request":{"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/1511","id":117109981,"html_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/1511","diff_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/1511.diff","patch_url":"https://github.com/ng-bootstrap/ng-bootstrap/pull/1511.patch","issue_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/1511","number":1511,"state":"open","locked":false,"title":"docs: add note about supported browsers","user":{"login":"pkozlowski-opensource","id":973550,"avatar_url":"https://avatars0.githubusercontent.com/u/973550?v=3","gravatar_id":"","url":"https://api.github.com/users/pkozlowski-opensource","html_url":"https://github.com/pkozlowski-opensource","followers_url":"https://api.github.com/users/pkozlowski-opensource/followers","following_url":"https://api.github.com/users/pkozlowski-opensource/following{/other_user}","gists_url":"https://api.github.com/users/pkozlowski-opensource/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozlowski-opensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozlowski-opensource/subscriptions","organizations_url":"https://api.github.com/users/pkozlowski-opensource/orgs","repos_url":"https://api.github.com/users/pkozlowski-opensource/repos","events_url":"https://api.github.com/users/pkozlowski-opensource/events{/privacy}","received_events_url":"https://api.github.com/users/pkozlowski-opensource/received_events","type":"User","site_admin":false},"body":"Closes #1000\r\n","created_at":"2017-04-22T13:29:39Z","updated_at":"2017-04-22T13:33:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"581dc0fe71488d62ae18c8a861c4f501cb4634a4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/1511/commits","review_comments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/1511/comments","review_comment_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/1511/comments","statuses_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/statuses/f227a9317dbbaeab44c7b05cf066a901190567fe","head":{"label":"pkozlowski-opensource:browsers_support_notes","ref":"browsers_support_notes","sha":"f227a9317dbbaeab44c7b05cf066a901190567fe","user":{"login":"pkozlowski-opensource","id":973550,"avatar_url":"https://avatars0.githubusercontent.com/u/973550?v=3","gravatar_id":"","url":"https://api.github.com/users/pkozlowski-opensource","html_url":"https://github.com/pkozlowski-opensource","followers_url":"https://api.github.com/users/pkozlowski-opensource/followers","following_url":"https://api.github.com/users/pkozlowski-opensource/following{/other_user}","gists_url":"https://api.github.com/users/pkozlowski-opensource/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozlowski-opensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozlowski-opensource/subscriptions","organizations_url":"https://api.github.com/users/pkozlowski-opensource/orgs","repos_url":"https://api.github.com/users/pkozlowski-opensource/repos","events_url":"https://api.github.com/users/pkozlowski-opensource/events{/privacy}","received_events_url":"https://api.github.com/users/pkozlowski-opensource/received_events","type":"User","site_admin":false},"repo":{"id":45191264,"name":"core","full_name":"pkozlowski-opensource/core","owner":{"login":"pkozlowski-opensource","id":973550,"avatar_url":"https://avatars0.githubusercontent.com/u/973550?v=3","gravatar_id":"","url":"https://api.github.com/users/pkozlowski-opensource","html_url":"https://github.com/pkozlowski-opensource","followers_url":"https://api.github.com/users/pkozlowski-opensource/followers","following_url":"https://api.github.com/users/pkozlowski-opensource/following{/other_user}","gists_url":"https://api.github.com/users/pkozlowski-opensource/gists{/gist_id}","starred_url":"https://api.github.com/users/pkozlowski-opensource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkozlowski-opensource/subscriptions","organizations_url":"https://api.github.com/users/pkozlowski-opensource/orgs","repos_url":"https://api.github.com/users/pkozlowski-opensource/repos","events_url":"https://api.github.com/users/pkozlowski-opensource/events{/privacy}","received_events_url":"https://api.github.com/users/pkozlowski-opensource/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pkozlowski-opensource/core","description":"Angular 2 powered Bootstrap","fork":true,"url":"https://api.github.com/repos/pkozlowski-opensource/core","forks_url":"https://api.github.com/repos/pkozlowski-opensource/core/forks","keys_url":"https://api.github.com/repos/pkozlowski-opensource/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkozlowski-opensource/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkozlowski-opensource/core/teams","hooks_url":"https://api.github.com/repos/pkozlowski-opensource/core/hooks","issue_events_url":"https://api.github.com/repos/pkozlowski-opensource/core/issues/events{/number}","events_url":"https://api.github.com/repos/pkozlowski-opensource/core/events","assignees_url":"https://api.github.com/repos/pkozlowski-opensource/core/assignees{/user}","branches_url":"https://api.github.com/repos/pkozlowski-opensource/core/branches{/branch}","tags_url":"https://api.github.com/repos/pkozlowski-opensource/core/tags","blobs_url":"https://api.github.com/repos/pkozlowski-opensource/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkozlowski-opensource/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkozlowski-opensource/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkozlowski-opensource/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkozlowski-opensource/core/statuses/{sha}","languages_url":"https://api.github.com/repos/pkozlowski-opensource/core/languages","stargazers_url":"https://api.github.com/repos/pkozlowski-opensource/core/stargazers","contributors_url":"https://api.github.com/repos/pkozlowski-opensource/core/contributors","subscribers_url":"https://api.github.com/repos/pkozlowski-opensource/core/subscribers","subscription_url":"https://api.github.com/repos/pkozlowski-opensource/core/subscription","commits_url":"https://api.github.com/repos/pkozlowski-opensource/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkozlowski-opensource/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkozlowski-opensource/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkozlowski-opensource/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkozlowski-opensource/core/contents/{+path}","compare_url":"https://api.github.com/repos/pkozlowski-opensource/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkozlowski-opensource/core/merges","archive_url":"https://api.github.com/repos/pkozlowski-opensource/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkozlowski-opensource/core/downloads","issues_url":"https://api.github.com/repos/pkozlowski-opensource/core/issues{/number}","pulls_url":"https://api.github.com/repos/pkozlowski-opensource/core/pulls{/number}","milestones_url":"https://api.github.com/repos/pkozlowski-opensource/core/milestones{/number}","notifications_url":"https://api.github.com/repos/pkozlowski-opensource/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkozlowski-opensource/core/labels{/name}","releases_url":"https://api.github.com/repos/pkozlowski-opensource/core/releases{/id}","deployments_url":"https://api.github.com/repos/pkozlowski-opensource/core/deployments","created_at":"2015-10-29T15:13:07Z","updated_at":"2016-11-10T16:27:30Z","pushed_at":"2017-04-22T13:27:50Z","git_url":"git://github.com/pkozlowski-opensource/core.git","ssh_url":"[email protected]:pkozlowski-opensource/core.git","clone_url":"https://github.com/pkozlowski-opensource/core.git","svn_url":"https://github.com/pkozlowski-opensource/core","homepage":null,"size":1669,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"ng-bootstrap:master","ref":"master","sha":"e8a2662bf281dbd9826e1bca722007780b500768","user":{"login":"ng-bootstrap","id":14283866,"avatar_url":"https://avatars2.githubusercontent.com/u/14283866?v=3","gravatar_id":"","url":"https://api.github.com/users/ng-bootstrap","html_url":"https://github.com/ng-bootstrap","followers_url":"https://api.github.com/users/ng-bootstrap/followers","following_url":"https://api.github.com/users/ng-bootstrap/following{/other_user}","gists_url":"https://api.github.com/users/ng-bootstrap/gists{/gist_id}","starred_url":"https://api.github.com/users/ng-bootstrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ng-bootstrap/subscriptions","organizations_url":"https://api.github.com/users/ng-bootstrap/orgs","repos_url":"https://api.github.com/users/ng-bootstrap/repos","events_url":"https://api.github.com/users/ng-bootstrap/events{/privacy}","received_events_url":"https://api.github.com/users/ng-bootstrap/received_events","type":"Organization","site_admin":false},"repo":{"id":42481664,"name":"ng-bootstrap","full_name":"ng-bootstrap/ng-bootstrap","owner":{"login":"ng-bootstrap","id":14283866,"avatar_url":"https://avatars2.githubusercontent.com/u/14283866?v=3","gravatar_id":"","url":"https://api.github.com/users/ng-bootstrap","html_url":"https://github.com/ng-bootstrap","followers_url":"https://api.github.com/users/ng-bootstrap/followers","following_url":"https://api.github.com/users/ng-bootstrap/following{/other_user}","gists_url":"https://api.github.com/users/ng-bootstrap/gists{/gist_id}","starred_url":"https://api.github.com/users/ng-bootstrap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ng-bootstrap/subscriptions","organizations_url":"https://api.github.com/users/ng-bootstrap/orgs","repos_url":"https://api.github.com/users/ng-bootstrap/repos","events_url":"https://api.github.com/users/ng-bootstrap/events{/privacy}","received_events_url":"https://api.github.com/users/ng-bootstrap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ng-bootstrap/ng-bootstrap","description":"Angular powered Bootstrap","fork":false,"url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap","forks_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/forks","keys_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/teams","hooks_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/hooks","issue_events_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/events","assignees_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/tags","blobs_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/languages","stargazers_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/stargazers","contributors_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/contributors","subscribers_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/subscribers","subscription_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/subscription","commits_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/merges","archive_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/downloads","issues_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/releases{/id}","deployments_url":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/deployments","created_at":"2015-09-14T22:55:53Z","updated_at":"2017-04-22T12:07:13Z","pushed_at":"2017-04-22T13:29:40Z","git_url":"git://github.com/ng-bootstrap/ng-bootstrap.git","ssh_url":"[email protected]:ng-bootstrap/ng-bootstrap.git","clone_url":"https://github.com/ng-bootstrap/ng-bootstrap.git","svn_url":"https://github.com/ng-bootstrap/ng-bootstrap","homepage":"https://ng-bootstrap.github.io","size":1482,"stargazers_count":2638,"watchers_count":2638,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":443,"mirror_url":null,"open_issues_count":124,"forks":443,"open_issues":124,"watchers":2638,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/1511"},"html":{"href":"https://github.com/ng-bootstrap/ng-bootstrap/pull/1511"},"issue":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/1511"},"comments":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/issues/1511/comments"},"review_comments":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/1511/comments"},"review_comment":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/pulls/1511/commits"},"statuses":{"href":"https://api.github.com/repos/ng-bootstrap/ng-bootstrap/statuses/f227a9317dbbaeab44c7b05cf066a901190567fe"}}}}
|
{
"id": 42481664,
"name": "ng-bootstrap/ng-bootstrap",
"url": "https://api.github.com/repos/ng-bootstrap/ng-bootstrap"
}
|
{
"id": 1087957,
"login": "Foxandxss",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1087957?",
"url": "https://api.github.com/users/Foxandxss"
}
|
{
"id": 14283866,
"login": "ng-bootstrap",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14283866?",
"url": "https://api.github.com/orgs/ng-bootstrap"
}
| 2017-04-22T13:33:25 |
5736929595
|
{"actor":{"display_login":"Foxandxss"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/opendatateam/udata/pulls/comments/117805941","pull_request_review_id":39543444,"id":117805941,"diff_hunk":"@@ -65,21 +67,39 @@ def load(filename, drop=False):\n zones_filepath = tmp.path('zones.msgpack')\n with open(zones_filepath) as fp:\n unpacker = msgpack.Unpacker(fp, encoding=str('utf-8'))\n- for i, geozone in enumerate(unpacker, start=1):\n- GeoZone.objects.create(\n- id=geozone['_id'],\n- level=geozone['level'],\n- code=geozone['code'],\n- name=geozone['name'],\n- keys=geozone.get('keys'),\n- parents=geozone.get('parents'),\n- population=geozone.get('population'),\n- dbpedia=geozone.get('dbpedia'),\n- logo=geozone.get('flag') or geozone.get('blazon'),\n- wikipedia=geozone.get('wikipedia'),\n- area=geozone.get('area'),\n- geom=geozone['geom']\n- )\n+ unpacker.next()\n+ for i, geozone in enumerate(unpacker):\n+ if ('geom' not in geozone or not geozone['geom'] or (\n+ geozone['geom']['type'] == 'GeometryCollection' and\n+ not geozone['geom']['geometries'])):\n+ geom = None\n+ else:\n+ geom = geozone['geom']\n+ params = {\n+ 'id': geozone['_id'],\n+ 'slug': slugify.slugify(geozone['name'], separator='-'),\n+ 'level': geozone['level'],\n+ 'code': geozone['code'],\n+ 'name': geozone['name'],\n+ 'keys': geozone.get('keys'),\n+ 'parents': geozone.get('parents'),\n+ 'ancestors': geozone.get('ancestors'),\n+ 'successors': geozone.get('successors'),\n+ 'validity': geozone.get('validity'),\n+ 'population': geozone.get('population'),\n+ 'dbpedia': geozone.get('dbpedia'),\n+ 'flag': geozone.get('flag'),\n+ 'blazon': geozone.get('blazon'),\n+ 'wikipedia': geozone.get('wikipedia'),\n+ 'area': geozone.get('area'),\n+ 'geom': geom\n+ }\n+ try:\n+ GeoZone.objects.create(**params)\n+ except errors.ValidationError as e:\n+ log.warning('Validation error (%s) for %s with %s',\n+ e, geozone, params)\n+ continue\n os.remove(zones_filepath)\n log.info('Loaded {total} zones'.format(total=i))","path":"udata/core/spatial/commands.py","position":62,"original_position":62,"commit_id":"4017fb79c0a066d709da89ad0bbea638bb5f0319","original_commit_id":"c7af7a96dbfd68f8ef486d024e47387033b181f8","user":{"login":"davidbgk","id":3556,"avatar_url":"https://avatars1.githubusercontent.com/u/3556?v=3","gravatar_id":"","url":"https://api.github.com/users/davidbgk","html_url":"https://github.com/davidbgk","followers_url":"https://api.github.com/users/davidbgk/followers","following_url":"https://api.github.com/users/davidbgk/following{/other_user}","gists_url":"https://api.github.com/users/davidbgk/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbgk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbgk/subscriptions","organizations_url":"https://api.github.com/users/davidbgk/orgs","repos_url":"https://api.github.com/users/davidbgk/repos","events_url":"https://api.github.com/users/davidbgk/events{/privacy}","received_events_url":"https://api.github.com/users/davidbgk/received_events","type":"User","site_admin":false},"body":"We don't want to skip zones.","created_at":"2017-05-22T17:49:25Z","updated_at":"2017-05-22T17:49:25Z","html_url":"https://github.com/opendatateam/udata/pull/501#discussion_r117805941","pull_request_url":"https://api.github.com/repos/opendatateam/udata/pulls/501","_links":{"self":{"href":"https://api.github.com/repos/opendatateam/udata/pulls/comments/117805941"},"html":{"href":"https://github.com/opendatateam/udata/pull/501#discussion_r117805941"},"pull_request":{"href":"https://api.github.com/repos/opendatateam/udata/pulls/501"}}},"pull_request":{"url":"https://api.github.com/repos/opendatateam/udata/pulls/501","id":75281962,"html_url":"https://github.com/opendatateam/udata/pull/501","diff_url":"https://github.com/opendatateam/udata/pull/501.diff","patch_url":"https://github.com/opendatateam/udata/pull/501.patch","issue_url":"https://api.github.com/repos/opendatateam/udata/issues/501","number":501,"state":"open","locked":false,"title":"HistoTerritories 2.0, fix #499","user":{"login":"davidbgk","id":3556,"avatar_url":"https://avatars1.githubusercontent.com/u/3556?v=3","gravatar_id":"","url":"https://api.github.com/users/davidbgk","html_url":"https://github.com/davidbgk","followers_url":"https://api.github.com/users/davidbgk/followers","following_url":"https://api.github.com/users/davidbgk/following{/other_user}","gists_url":"https://api.github.com/users/davidbgk/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbgk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbgk/subscriptions","organizations_url":"https://api.github.com/users/davidbgk/orgs","repos_url":"https://api.github.com/users/davidbgk/repos","events_url":"https://api.github.com/users/davidbgk/events{/privacy}","received_events_url":"https://api.github.com/users/davidbgk/received_events","type":"User","site_admin":false},"body":"Remaining things to do:\r\n- [x] deal with old/new regions (waiting for Christian’s input on that subject)\r\n- [x] migrate datasets’ zones with new regions\r\n- [x] understand why DROM-COM do not load their geometries anymore (probably an issue on geozones’ side, see below)\r\n- [x] deal with redirections from old to new regions/towns\r\n\r\n```\r\nWARNING: Validation error for {u'code': u'fr/dom', u'name': u'DOM', u'area': 0, u'level': u'country-subset', u'parents': [u'country/fr', u'country-group/ue', u'country-group/world'], u'geom': {u'type': u'GeometryCollection', u'geometries': []}, u'_id': u'country-subset/fr/dom', u'population': 0}\r\nWARNING: Validation error for {u'code': u'fr/domtom', u'name': u'Overseas France', u'area': 2208, u'level': u'country-subset', u'parents': [u'country/fr', u'country-group/ue', u'country-group/world'], u'geom': {u'type': u'GeometryCollection', u'geometries': []}, u'_id': u'country-subset/fr/domtom', u'population': 511242}\r\n```\r\n","created_at":"2016-06-27T09:38:58Z","updated_at":"2017-05-22T17:49:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05230aef328e3bb2de712ac6f56f0c3eae78d724","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/opendatateam/udata/milestones/2","html_url":"https://github.com/opendatateam/udata/milestone/2","labels_url":"https://api.github.com/repos/opendatateam/udata/milestones/2/labels","id":2083649,"number":2,"title":"1.1","description":"","creator":{"login":"noirbizarre","id":15725,"avatar_url":"https://avatars3.githubusercontent.com/u/15725?v=3","gravatar_id":"","url":"https://api.github.com/users/noirbizarre","html_url":"https://github.com/noirbizarre","followers_url":"https://api.github.com/users/noirbizarre/followers","following_url":"https://api.github.com/users/noirbizarre/following{/other_user}","gists_url":"https://api.github.com/users/noirbizarre/gists{/gist_id}","starred_url":"https://api.github.com/users/noirbizarre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noirbizarre/subscriptions","organizations_url":"https://api.github.com/users/noirbizarre/orgs","repos_url":"https://api.github.com/users/noirbizarre/repos","events_url":"https://api.github.com/users/noirbizarre/events{/privacy}","received_events_url":"https://api.github.com/users/noirbizarre/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":34,"state":"open","created_at":"2016-10-20T21:49:23Z","updated_at":"2017-05-17T15:11:08Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/opendatateam/udata/pulls/501/commits","review_comments_url":"https://api.github.com/repos/opendatateam/udata/pulls/501/comments","review_comment_url":"https://api.github.com/repos/opendatateam/udata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opendatateam/udata/issues/501/comments","statuses_url":"https://api.github.com/repos/opendatateam/udata/statuses/4017fb79c0a066d709da89ad0bbea638bb5f0319","head":{"label":"davidbgk:499-rename-territories","ref":"499-rename-territories","sha":"4017fb79c0a066d709da89ad0bbea638bb5f0319","user":{"login":"davidbgk","id":3556,"avatar_url":"https://avatars1.githubusercontent.com/u/3556?v=3","gravatar_id":"","url":"https://api.github.com/users/davidbgk","html_url":"https://github.com/davidbgk","followers_url":"https://api.github.com/users/davidbgk/followers","following_url":"https://api.github.com/users/davidbgk/following{/other_user}","gists_url":"https://api.github.com/users/davidbgk/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbgk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbgk/subscriptions","organizations_url":"https://api.github.com/users/davidbgk/orgs","repos_url":"https://api.github.com/users/davidbgk/repos","events_url":"https://api.github.com/users/davidbgk/events{/privacy}","received_events_url":"https://api.github.com/users/davidbgk/received_events","type":"User","site_admin":false},"repo":{"id":33595552,"name":"udata","full_name":"davidbgk/udata","owner":{"login":"davidbgk","id":3556,"avatar_url":"https://avatars1.githubusercontent.com/u/3556?v=3","gravatar_id":"","url":"https://api.github.com/users/davidbgk","html_url":"https://github.com/davidbgk","followers_url":"https://api.github.com/users/davidbgk/followers","following_url":"https://api.github.com/users/davidbgk/following{/other_user}","gists_url":"https://api.github.com/users/davidbgk/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbgk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbgk/subscriptions","organizations_url":"https://api.github.com/users/davidbgk/orgs","repos_url":"https://api.github.com/users/davidbgk/repos","events_url":"https://api.github.com/users/davidbgk/events{/privacy}","received_events_url":"https://api.github.com/users/davidbgk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidbgk/udata","description":"Social data platform","fork":true,"url":"https://api.github.com/repos/davidbgk/udata","forks_url":"https://api.github.com/repos/davidbgk/udata/forks","keys_url":"https://api.github.com/repos/davidbgk/udata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidbgk/udata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidbgk/udata/teams","hooks_url":"https://api.github.com/repos/davidbgk/udata/hooks","issue_events_url":"https://api.github.com/repos/davidbgk/udata/issues/events{/number}","events_url":"https://api.github.com/repos/davidbgk/udata/events","assignees_url":"https://api.github.com/repos/davidbgk/udata/assignees{/user}","branches_url":"https://api.github.com/repos/davidbgk/udata/branches{/branch}","tags_url":"https://api.github.com/repos/davidbgk/udata/tags","blobs_url":"https://api.github.com/repos/davidbgk/udata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidbgk/udata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidbgk/udata/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidbgk/udata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidbgk/udata/statuses/{sha}","languages_url":"https://api.github.com/repos/davidbgk/udata/languages","stargazers_url":"https://api.github.com/repos/davidbgk/udata/stargazers","contributors_url":"https://api.github.com/repos/davidbgk/udata/contributors","subscribers_url":"https://api.github.com/repos/davidbgk/udata/subscribers","subscription_url":"https://api.github.com/repos/davidbgk/udata/subscription","commits_url":"https://api.github.com/repos/davidbgk/udata/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidbgk/udata/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidbgk/udata/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidbgk/udata/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidbgk/udata/contents/{+path}","compare_url":"https://api.github.com/repos/davidbgk/udata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidbgk/udata/merges","archive_url":"https://api.github.com/repos/davidbgk/udata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidbgk/udata/downloads","issues_url":"https://api.github.com/repos/davidbgk/udata/issues{/number}","pulls_url":"https://api.github.com/repos/davidbgk/udata/pulls{/number}","milestones_url":"https://api.github.com/repos/davidbgk/udata/milestones{/number}","notifications_url":"https://api.github.com/repos/davidbgk/udata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidbgk/udata/labels{/name}","releases_url":"https://api.github.com/repos/davidbgk/udata/releases{/id}","deployments_url":"https://api.github.com/repos/davidbgk/udata/deployments","created_at":"2015-04-08T08:51:08Z","updated_at":"2016-01-21T22:06:38Z","pushed_at":"2017-05-15T13:12:22Z","git_url":"git://github.com/davidbgk/udata.git","ssh_url":"[email protected]:davidbgk/udata.git","clone_url":"https://github.com/davidbgk/udata.git","svn_url":"https://github.com/davidbgk/udata","homepage":null,"size":8253,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opendatateam:dev","ref":"dev","sha":"85cf364c96999f77bd349e595e624e69b2485b71","user":{"login":"opendatateam","id":19330690,"avatar_url":"https://avatars1.githubusercontent.com/u/19330690?v=3","gravatar_id":"","url":"https://api.github.com/users/opendatateam","html_url":"https://github.com/opendatateam","followers_url":"https://api.github.com/users/opendatateam/followers","following_url":"https://api.github.com/users/opendatateam/following{/other_user}","gists_url":"https://api.github.com/users/opendatateam/gists{/gist_id}","starred_url":"https://api.github.com/users/opendatateam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opendatateam/subscriptions","organizations_url":"https://api.github.com/users/opendatateam/orgs","repos_url":"https://api.github.com/users/opendatateam/repos","events_url":"https://api.github.com/users/opendatateam/events{/privacy}","received_events_url":"https://api.github.com/users/opendatateam/received_events","type":"Organization","site_admin":false},"repo":{"id":19141754,"name":"udata","full_name":"opendatateam/udata","owner":{"login":"opendatateam","id":19330690,"avatar_url":"https://avatars1.githubusercontent.com/u/19330690?v=3","gravatar_id":"","url":"https://api.github.com/users/opendatateam","html_url":"https://github.com/opendatateam","followers_url":"https://api.github.com/users/opendatateam/followers","following_url":"https://api.github.com/users/opendatateam/following{/other_user}","gists_url":"https://api.github.com/users/opendatateam/gists{/gist_id}","starred_url":"https://api.github.com/users/opendatateam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opendatateam/subscriptions","organizations_url":"https://api.github.com/users/opendatateam/orgs","repos_url":"https://api.github.com/users/opendatateam/repos","events_url":"https://api.github.com/users/opendatateam/events{/privacy}","received_events_url":"https://api.github.com/users/opendatateam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opendatateam/udata","description":"Customizable and skinnable social platform dedicated to (open)data.","fork":false,"url":"https://api.github.com/repos/opendatateam/udata","forks_url":"https://api.github.com/repos/opendatateam/udata/forks","keys_url":"https://api.github.com/repos/opendatateam/udata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opendatateam/udata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opendatateam/udata/teams","hooks_url":"https://api.github.com/repos/opendatateam/udata/hooks","issue_events_url":"https://api.github.com/repos/opendatateam/udata/issues/events{/number}","events_url":"https://api.github.com/repos/opendatateam/udata/events","assignees_url":"https://api.github.com/repos/opendatateam/udata/assignees{/user}","branches_url":"https://api.github.com/repos/opendatateam/udata/branches{/branch}","tags_url":"https://api.github.com/repos/opendatateam/udata/tags","blobs_url":"https://api.github.com/repos/opendatateam/udata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opendatateam/udata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opendatateam/udata/git/refs{/sha}","trees_url":"https://api.github.com/repos/opendatateam/udata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opendatateam/udata/statuses/{sha}","languages_url":"https://api.github.com/repos/opendatateam/udata/languages","stargazers_url":"https://api.github.com/repos/opendatateam/udata/stargazers","contributors_url":"https://api.github.com/repos/opendatateam/udata/contributors","subscribers_url":"https://api.github.com/repos/opendatateam/udata/subscribers","subscription_url":"https://api.github.com/repos/opendatateam/udata/subscription","commits_url":"https://api.github.com/repos/opendatateam/udata/commits{/sha}","git_commits_url":"https://api.github.com/repos/opendatateam/udata/git/commits{/sha}","comments_url":"https://api.github.com/repos/opendatateam/udata/comments{/number}","issue_comment_url":"https://api.github.com/repos/opendatateam/udata/issues/comments{/number}","contents_url":"https://api.github.com/repos/opendatateam/udata/contents/{+path}","compare_url":"https://api.github.com/repos/opendatateam/udata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opendatateam/udata/merges","archive_url":"https://api.github.com/repos/opendatateam/udata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opendatateam/udata/downloads","issues_url":"https://api.github.com/repos/opendatateam/udata/issues{/number}","pulls_url":"https://api.github.com/repos/opendatateam/udata/pulls{/number}","milestones_url":"https://api.github.com/repos/opendatateam/udata/milestones{/number}","notifications_url":"https://api.github.com/repos/opendatateam/udata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opendatateam/udata/labels{/name}","releases_url":"https://api.github.com/repos/opendatateam/udata/releases{/id}","deployments_url":"https://api.github.com/repos/opendatateam/udata/deployments","created_at":"2014-04-25T09:57:34Z","updated_at":"2017-05-10T14:07:48Z","pushed_at":"2017-05-22T15:18:34Z","git_url":"git://github.com/opendatateam/udata.git","ssh_url":"[email protected]:opendatateam/udata.git","clone_url":"https://github.com/opendatateam/udata.git","svn_url":"https://github.com/opendatateam/udata","homepage":"http://udata.readthedocs.org","size":8159,"stargazers_count":72,"watchers_count":72,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":57,"forks":30,"open_issues":57,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opendatateam/udata/pulls/501"},"html":{"href":"https://github.com/opendatateam/udata/pull/501"},"issue":{"href":"https://api.github.com/repos/opendatateam/udata/issues/501"},"comments":{"href":"https://api.github.com/repos/opendatateam/udata/issues/501/comments"},"review_comments":{"href":"https://api.github.com/repos/opendatateam/udata/pulls/501/comments"},"review_comment":{"href":"https://api.github.com/repos/opendatateam/udata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opendatateam/udata/pulls/501/commits"},"statuses":{"href":"https://api.github.com/repos/opendatateam/udata/statuses/4017fb79c0a066d709da89ad0bbea638bb5f0319"}}}}
|
{
"id": 19141754,
"name": "opendatateam/udata",
"url": "https://api.github.com/repos/opendatateam/udata"
}
|
{
"id": 3556,
"login": "davidbgk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3556?",
"url": "https://api.github.com/users/davidbgk"
}
|
{
"id": 19330690,
"login": "opendatateam",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19330690?",
"url": "https://api.github.com/orgs/opendatateam"
}
| 2017-05-22T17:49:25 |
5919479712
|
{"actor":{"display_login":"davidbgk"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/otavanopisto/muikku/pulls/comments/120051024","pull_request_review_id":41981563,"id":120051024,"diff_hunk":"@@ -208,18 +232,19 @@\n .gt-user-file-action {\n text-transform: uppercase;\n }\n+\n+\n \n .gt-course {\n- border-left: 3px solid $item-border-color-active; \n \n+ margin-bottom: 5px;\n &.open {\n+ background-color: #eee; ","path":"muikku/src/main/webapp/resources/theme-muikku/sass/flex/guider.scss","position":54,"original_position":54,"commit_id":"2cfec99eb5770ac110751a3bdd65d8692021ff04","original_commit_id":"2cfec99eb5770ac110751a3bdd65d8692021ff04","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars3.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Line should be indented 4 spaces, but was indented 5 spaces<br>Color literals like `#eee` should only be used in variable declarations; they should be referred to via variable everywhere else.","created_at":"2017-06-05T06:52:48Z","updated_at":"2017-06-05T06:52:49Z","html_url":"https://github.com/otavanopisto/muikku/pull/3209#discussion_r120051024","pull_request_url":"https://api.github.com/repos/otavanopisto/muikku/pulls/3209","_links":{"self":{"href":"https://api.github.com/repos/otavanopisto/muikku/pulls/comments/120051024"},"html":{"href":"https://github.com/otavanopisto/muikku/pull/3209#discussion_r120051024"},"pull_request":{"href":"https://api.github.com/repos/otavanopisto/muikku/pulls/3209"}}},"pull_request":{"url":"https://api.github.com/repos/otavanopisto/muikku/pulls/3209","id":123453392,"html_url":"https://github.com/otavanopisto/muikku/pull/3209","diff_url":"https://github.com/otavanopisto/muikku/pull/3209.diff","patch_url":"https://github.com/otavanopisto/muikku/pull/3209.patch","issue_url":"https://api.github.com/repos/otavanopisto/muikku/issues/3209","number":3209,"state":"open","locked":false,"title":"Ftr 3183 guider studies ui","user":{"login":"ilmoeuro","id":1074146,"avatar_url":"https://avatars1.githubusercontent.com/u/1074146?v=3","gravatar_id":"","url":"https://api.github.com/users/ilmoeuro","html_url":"https://github.com/ilmoeuro","followers_url":"https://api.github.com/users/ilmoeuro/followers","following_url":"https://api.github.com/users/ilmoeuro/following{/other_user}","gists_url":"https://api.github.com/users/ilmoeuro/gists{/gist_id}","starred_url":"https://api.github.com/users/ilmoeuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilmoeuro/subscriptions","organizations_url":"https://api.github.com/users/ilmoeuro/orgs","repos_url":"https://api.github.com/users/ilmoeuro/repos","events_url":"https://api.github.com/users/ilmoeuro/events{/privacy}","received_events_url":"https://api.github.com/users/ilmoeuro/received_events","type":"User","site_admin":false},"body":"** Fixes #3183\r\n** Fixes #3129 ","created_at":"2017-06-01T09:21:10Z","updated_at":"2017-06-05T06:52:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b794470db93e703932a3f6730b35a991a5be409","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pkukkon","id":3963004,"avatar_url":"https://avatars2.githubusercontent.com/u/3963004?v=3","gravatar_id":"","url":"https://api.github.com/users/pkukkon","html_url":"https://github.com/pkukkon","followers_url":"https://api.github.com/users/pkukkon/followers","following_url":"https://api.github.com/users/pkukkon/following{/other_user}","gists_url":"https://api.github.com/users/pkukkon/gists{/gist_id}","starred_url":"https://api.github.com/users/pkukkon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkukkon/subscriptions","organizations_url":"https://api.github.com/users/pkukkon/orgs","repos_url":"https://api.github.com/users/pkukkon/repos","events_url":"https://api.github.com/users/pkukkon/events{/privacy}","received_events_url":"https://api.github.com/users/pkukkon/received_events","type":"User","site_admin":false},{"login":"onzag","id":10426555,"avatar_url":"https://avatars3.githubusercontent.com/u/10426555?v=3","gravatar_id":"","url":"https://api.github.com/users/onzag","html_url":"https://github.com/onzag","followers_url":"https://api.github.com/users/onzag/followers","following_url":"https://api.github.com/users/onzag/following{/other_user}","gists_url":"https://api.github.com/users/onzag/gists{/gist_id}","starred_url":"https://api.github.com/users/onzag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onzag/subscriptions","organizations_url":"https://api.github.com/users/onzag/orgs","repos_url":"https://api.github.com/users/onzag/repos","events_url":"https://api.github.com/users/onzag/events{/privacy}","received_events_url":"https://api.github.com/users/onzag/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/otavanopisto/muikku/pulls/3209/commits","review_comments_url":"https://api.github.com/repos/otavanopisto/muikku/pulls/3209/comments","review_comment_url":"https://api.github.com/repos/otavanopisto/muikku/pulls/comments{/number}","comments_url":"https://api.github.com/repos/otavanopisto/muikku/issues/3209/comments","statuses_url":"https://api.github.com/repos/otavanopisto/muikku/statuses/2cfec99eb5770ac110751a3bdd65d8692021ff04","head":{"label":"otavanopisto:FTR-3183-Guider-studies-UI","ref":"FTR-3183-Guider-studies-UI","sha":"2cfec99eb5770ac110751a3bdd65d8692021ff04","user":{"login":"otavanopisto","id":3909061,"avatar_url":"https://avatars1.githubusercontent.com/u/3909061?v=3","gravatar_id":"","url":"https://api.github.com/users/otavanopisto","html_url":"https://github.com/otavanopisto","followers_url":"https://api.github.com/users/otavanopisto/followers","following_url":"https://api.github.com/users/otavanopisto/following{/other_user}","gists_url":"https://api.github.com/users/otavanopisto/gists{/gist_id}","starred_url":"https://api.github.com/users/otavanopisto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otavanopisto/subscriptions","organizations_url":"https://api.github.com/users/otavanopisto/orgs","repos_url":"https://api.github.com/users/otavanopisto/repos","events_url":"https://api.github.com/users/otavanopisto/events{/privacy}","received_events_url":"https://api.github.com/users/otavanopisto/received_events","type":"Organization","site_admin":false},"repo":{"id":8877030,"name":"muikku","full_name":"otavanopisto/muikku","owner":{"login":"otavanopisto","id":3909061,"avatar_url":"https://avatars1.githubusercontent.com/u/3909061?v=3","gravatar_id":"","url":"https://api.github.com/users/otavanopisto","html_url":"https://github.com/otavanopisto","followers_url":"https://api.github.com/users/otavanopisto/followers","following_url":"https://api.github.com/users/otavanopisto/following{/other_user}","gists_url":"https://api.github.com/users/otavanopisto/gists{/gist_id}","starred_url":"https://api.github.com/users/otavanopisto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otavanopisto/subscriptions","organizations_url":"https://api.github.com/users/otavanopisto/orgs","repos_url":"https://api.github.com/users/otavanopisto/repos","events_url":"https://api.github.com/users/otavanopisto/events{/privacy}","received_events_url":"https://api.github.com/users/otavanopisto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/otavanopisto/muikku","description":"Muikku Learning Environment","fork":false,"url":"https://api.github.com/repos/otavanopisto/muikku","forks_url":"https://api.github.com/repos/otavanopisto/muikku/forks","keys_url":"https://api.github.com/repos/otavanopisto/muikku/keys{/key_id}","collaborators_url":"https://api.github.com/repos/otavanopisto/muikku/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/otavanopisto/muikku/teams","hooks_url":"https://api.github.com/repos/otavanopisto/muikku/hooks","issue_events_url":"https://api.github.com/repos/otavanopisto/muikku/issues/events{/number}","events_url":"https://api.github.com/repos/otavanopisto/muikku/events","assignees_url":"https://api.github.com/repos/otavanopisto/muikku/assignees{/user}","branches_url":"https://api.github.com/repos/otavanopisto/muikku/branches{/branch}","tags_url":"https://api.github.com/repos/otavanopisto/muikku/tags","blobs_url":"https://api.github.com/repos/otavanopisto/muikku/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/otavanopisto/muikku/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/otavanopisto/muikku/git/refs{/sha}","trees_url":"https://api.github.com/repos/otavanopisto/muikku/git/trees{/sha}","statuses_url":"https://api.github.com/repos/otavanopisto/muikku/statuses/{sha}","languages_url":"https://api.github.com/repos/otavanopisto/muikku/languages","stargazers_url":"https://api.github.com/repos/otavanopisto/muikku/stargazers","contributors_url":"https://api.github.com/repos/otavanopisto/muikku/contributors","subscribers_url":"https://api.github.com/repos/otavanopisto/muikku/subscribers","subscription_url":"https://api.github.com/repos/otavanopisto/muikku/subscription","commits_url":"https://api.github.com/repos/otavanopisto/muikku/commits{/sha}","git_commits_url":"https://api.github.com/repos/otavanopisto/muikku/git/commits{/sha}","comments_url":"https://api.github.com/repos/otavanopisto/muikku/comments{/number}","issue_comment_url":"https://api.github.com/repos/otavanopisto/muikku/issues/comments{/number}","contents_url":"https://api.github.com/repos/otavanopisto/muikku/contents/{+path}","compare_url":"https://api.github.com/repos/otavanopisto/muikku/compare/{base}...{head}","merges_url":"https://api.github.com/repos/otavanopisto/muikku/merges","archive_url":"https://api.github.com/repos/otavanopisto/muikku/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/otavanopisto/muikku/downloads","issues_url":"https://api.github.com/repos/otavanopisto/muikku/issues{/number}","pulls_url":"https://api.github.com/repos/otavanopisto/muikku/pulls{/number}","milestones_url":"https://api.github.com/repos/otavanopisto/muikku/milestones{/number}","notifications_url":"https://api.github.com/repos/otavanopisto/muikku/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/otavanopisto/muikku/labels{/name}","releases_url":"https://api.github.com/repos/otavanopisto/muikku/releases{/id}","deployments_url":"https://api.github.com/repos/otavanopisto/muikku/deployments","created_at":"2013-03-19T11:30:32Z","updated_at":"2017-01-16T06:11:24Z","pushed_at":"2017-06-05T06:52:38Z","git_url":"git://github.com/otavanopisto/muikku.git","ssh_url":"[email protected]:otavanopisto/muikku.git","clone_url":"https://github.com/otavanopisto/muikku.git","svn_url":"https://github.com/otavanopisto/muikku","homepage":null,"size":259872,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":490,"forks":0,"open_issues":490,"watchers":6,"default_branch":"devel"}},"base":{"label":"otavanopisto:devel","ref":"devel","sha":"99f19dafd3f11a62d062dea49488265e100eacce","user":{"login":"otavanopisto","id":3909061,"avatar_url":"https://avatars1.githubusercontent.com/u/3909061?v=3","gravatar_id":"","url":"https://api.github.com/users/otavanopisto","html_url":"https://github.com/otavanopisto","followers_url":"https://api.github.com/users/otavanopisto/followers","following_url":"https://api.github.com/users/otavanopisto/following{/other_user}","gists_url":"https://api.github.com/users/otavanopisto/gists{/gist_id}","starred_url":"https://api.github.com/users/otavanopisto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otavanopisto/subscriptions","organizations_url":"https://api.github.com/users/otavanopisto/orgs","repos_url":"https://api.github.com/users/otavanopisto/repos","events_url":"https://api.github.com/users/otavanopisto/events{/privacy}","received_events_url":"https://api.github.com/users/otavanopisto/received_events","type":"Organization","site_admin":false},"repo":{"id":8877030,"name":"muikku","full_name":"otavanopisto/muikku","owner":{"login":"otavanopisto","id":3909061,"avatar_url":"https://avatars1.githubusercontent.com/u/3909061?v=3","gravatar_id":"","url":"https://api.github.com/users/otavanopisto","html_url":"https://github.com/otavanopisto","followers_url":"https://api.github.com/users/otavanopisto/followers","following_url":"https://api.github.com/users/otavanopisto/following{/other_user}","gists_url":"https://api.github.com/users/otavanopisto/gists{/gist_id}","starred_url":"https://api.github.com/users/otavanopisto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otavanopisto/subscriptions","organizations_url":"https://api.github.com/users/otavanopisto/orgs","repos_url":"https://api.github.com/users/otavanopisto/repos","events_url":"https://api.github.com/users/otavanopisto/events{/privacy}","received_events_url":"https://api.github.com/users/otavanopisto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/otavanopisto/muikku","description":"Muikku Learning Environment","fork":false,"url":"https://api.github.com/repos/otavanopisto/muikku","forks_url":"https://api.github.com/repos/otavanopisto/muikku/forks","keys_url":"https://api.github.com/repos/otavanopisto/muikku/keys{/key_id}","collaborators_url":"https://api.github.com/repos/otavanopisto/muikku/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/otavanopisto/muikku/teams","hooks_url":"https://api.github.com/repos/otavanopisto/muikku/hooks","issue_events_url":"https://api.github.com/repos/otavanopisto/muikku/issues/events{/number}","events_url":"https://api.github.com/repos/otavanopisto/muikku/events","assignees_url":"https://api.github.com/repos/otavanopisto/muikku/assignees{/user}","branches_url":"https://api.github.com/repos/otavanopisto/muikku/branches{/branch}","tags_url":"https://api.github.com/repos/otavanopisto/muikku/tags","blobs_url":"https://api.github.com/repos/otavanopisto/muikku/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/otavanopisto/muikku/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/otavanopisto/muikku/git/refs{/sha}","trees_url":"https://api.github.com/repos/otavanopisto/muikku/git/trees{/sha}","statuses_url":"https://api.github.com/repos/otavanopisto/muikku/statuses/{sha}","languages_url":"https://api.github.com/repos/otavanopisto/muikku/languages","stargazers_url":"https://api.github.com/repos/otavanopisto/muikku/stargazers","contributors_url":"https://api.github.com/repos/otavanopisto/muikku/contributors","subscribers_url":"https://api.github.com/repos/otavanopisto/muikku/subscribers","subscription_url":"https://api.github.com/repos/otavanopisto/muikku/subscription","commits_url":"https://api.github.com/repos/otavanopisto/muikku/commits{/sha}","git_commits_url":"https://api.github.com/repos/otavanopisto/muikku/git/commits{/sha}","comments_url":"https://api.github.com/repos/otavanopisto/muikku/comments{/number}","issue_comment_url":"https://api.github.com/repos/otavanopisto/muikku/issues/comments{/number}","contents_url":"https://api.github.com/repos/otavanopisto/muikku/contents/{+path}","compare_url":"https://api.github.com/repos/otavanopisto/muikku/compare/{base}...{head}","merges_url":"https://api.github.com/repos/otavanopisto/muikku/merges","archive_url":"https://api.github.com/repos/otavanopisto/muikku/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/otavanopisto/muikku/downloads","issues_url":"https://api.github.com/repos/otavanopisto/muikku/issues{/number}","pulls_url":"https://api.github.com/repos/otavanopisto/muikku/pulls{/number}","milestones_url":"https://api.github.com/repos/otavanopisto/muikku/milestones{/number}","notifications_url":"https://api.github.com/repos/otavanopisto/muikku/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/otavanopisto/muikku/labels{/name}","releases_url":"https://api.github.com/repos/otavanopisto/muikku/releases{/id}","deployments_url":"https://api.github.com/repos/otavanopisto/muikku/deployments","created_at":"2013-03-19T11:30:32Z","updated_at":"2017-01-16T06:11:24Z","pushed_at":"2017-06-05T06:52:38Z","git_url":"git://github.com/otavanopisto/muikku.git","ssh_url":"[email protected]:otavanopisto/muikku.git","clone_url":"https://github.com/otavanopisto/muikku.git","svn_url":"https://github.com/otavanopisto/muikku","homepage":null,"size":259872,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":490,"forks":0,"open_issues":490,"watchers":6,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/otavanopisto/muikku/pulls/3209"},"html":{"href":"https://github.com/otavanopisto/muikku/pull/3209"},"issue":{"href":"https://api.github.com/repos/otavanopisto/muikku/issues/3209"},"comments":{"href":"https://api.github.com/repos/otavanopisto/muikku/issues/3209/comments"},"review_comments":{"href":"https://api.github.com/repos/otavanopisto/muikku/pulls/3209/comments"},"review_comment":{"href":"https://api.github.com/repos/otavanopisto/muikku/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/otavanopisto/muikku/pulls/3209/commits"},"statuses":{"href":"https://api.github.com/repos/otavanopisto/muikku/statuses/2cfec99eb5770ac110751a3bdd65d8692021ff04"}}}}
|
{
"id": 8877030,
"name": "otavanopisto/muikku",
"url": "https://api.github.com/repos/otavanopisto/muikku"
}
|
{
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
}
|
{
"id": 3909061,
"login": "otavanopisto",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3909061?",
"url": "https://api.github.com/orgs/otavanopisto"
}
| 2017-06-05T06:52:48 |
6000797660
|
{"actor":{"display_login":"houndci-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/prismskylabs/connect/pulls/comments/131690400","pull_request_review_id":54688845,"id":131690400,"diff_hunk":"@@ -215,14 +215,16 @@ struct ObjectStream\n \n struct Count\n {\n- Count(const timestamp_t& timestamp, int32_t value)\n+ Count(const timestamp_t& timestamp, std::string& label, int32_t value)","path":"include/domain-types.h","position":5,"original_position":5,"commit_id":"5d47563dee3a8683121d4aee68cf4b429110b71f","original_commit_id":"5d47563dee3a8683121d4aee68cf4b429110b71f","user":{"login":"ionyshch-prismsl","id":24312265,"avatar_url":"https://avatars0.githubusercontent.com/u/24312265?v=4","gravatar_id":"","url":"https://api.github.com/users/ionyshch-prismsl","html_url":"https://github.com/ionyshch-prismsl","followers_url":"https://api.github.com/users/ionyshch-prismsl/followers","following_url":"https://api.github.com/users/ionyshch-prismsl/following{/other_user}","gists_url":"https://api.github.com/users/ionyshch-prismsl/gists{/gist_id}","starred_url":"https://api.github.com/users/ionyshch-prismsl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ionyshch-prismsl/subscriptions","organizations_url":"https://api.github.com/users/ionyshch-prismsl/orgs","repos_url":"https://api.github.com/users/ionyshch-prismsl/repos","events_url":"https://api.github.com/users/ionyshch-prismsl/events{/privacy}","received_events_url":"https://api.github.com/users/ionyshch-prismsl/received_events","type":"User","site_admin":false},"body":"Shall be *const* std::string&","created_at":"2017-08-07T15:46:04Z","updated_at":"2017-08-07T15:47:10Z","html_url":"https://github.com/prismskylabs/connect/pull/69#discussion_r131690400","pull_request_url":"https://api.github.com/repos/prismskylabs/connect/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/prismskylabs/connect/pulls/comments/131690400"},"html":{"href":"https://github.com/prismskylabs/connect/pull/69#discussion_r131690400"},"pull_request":{"href":"https://api.github.com/repos/prismskylabs/connect/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/prismskylabs/connect/pulls/69","id":134438962,"html_url":"https://github.com/prismskylabs/connect/pull/69","diff_url":"https://github.com/prismskylabs/connect/pull/69.diff","patch_url":"https://github.com/prismskylabs/connect/pull/69.patch","issue_url":"https://api.github.com/repos/prismskylabs/connect/issues/69","number":69,"state":"open","locked":false,"title":"feature/edge-460","user":{"login":"a-bykov","id":30590571,"avatar_url":"https://avatars0.githubusercontent.com/u/30590571?v=4","gravatar_id":"","url":"https://api.github.com/users/a-bykov","html_url":"https://github.com/a-bykov","followers_url":"https://api.github.com/users/a-bykov/followers","following_url":"https://api.github.com/users/a-bykov/following{/other_user}","gists_url":"https://api.github.com/users/a-bykov/gists{/gist_id}","starred_url":"https://api.github.com/users/a-bykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-bykov/subscriptions","organizations_url":"https://api.github.com/users/a-bykov/orgs","repos_url":"https://api.github.com/users/a-bykov/repos","events_url":"https://api.github.com/users/a-bykov/events{/privacy}","received_events_url":"https://api.github.com/users/a-bykov/received_events","type":"User","site_admin":false},"body":"Added ability to upload both IN and OUT counts to the server. ","created_at":"2017-08-07T13:32:59Z","updated_at":"2017-08-07T15:47:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c369d181ba08538fef0737d6281535861519181","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/prismskylabs/connect/pulls/69/commits","review_comments_url":"https://api.github.com/repos/prismskylabs/connect/pulls/69/comments","review_comment_url":"https://api.github.com/repos/prismskylabs/connect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prismskylabs/connect/issues/69/comments","statuses_url":"https://api.github.com/repos/prismskylabs/connect/statuses/5d47563dee3a8683121d4aee68cf4b429110b71f","head":{"label":"prismskylabs:feature/edge-460","ref":"feature/edge-460","sha":"5d47563dee3a8683121d4aee68cf4b429110b71f","user":{"login":"prismskylabs","id":2381267,"avatar_url":"https://avatars3.githubusercontent.com/u/2381267?v=4","gravatar_id":"","url":"https://api.github.com/users/prismskylabs","html_url":"https://github.com/prismskylabs","followers_url":"https://api.github.com/users/prismskylabs/followers","following_url":"https://api.github.com/users/prismskylabs/following{/other_user}","gists_url":"https://api.github.com/users/prismskylabs/gists{/gist_id}","starred_url":"https://api.github.com/users/prismskylabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prismskylabs/subscriptions","organizations_url":"https://api.github.com/users/prismskylabs/orgs","repos_url":"https://api.github.com/users/prismskylabs/repos","events_url":"https://api.github.com/users/prismskylabs/events{/privacy}","received_events_url":"https://api.github.com/users/prismskylabs/received_events","type":"Organization","site_admin":false},"repo":{"id":65768540,"name":"connect","full_name":"prismskylabs/connect","owner":{"login":"prismskylabs","id":2381267,"avatar_url":"https://avatars3.githubusercontent.com/u/2381267?v=4","gravatar_id":"","url":"https://api.github.com/users/prismskylabs","html_url":"https://github.com/prismskylabs","followers_url":"https://api.github.com/users/prismskylabs/followers","following_url":"https://api.github.com/users/prismskylabs/following{/other_user}","gists_url":"https://api.github.com/users/prismskylabs/gists{/gist_id}","starred_url":"https://api.github.com/users/prismskylabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prismskylabs/subscriptions","organizations_url":"https://api.github.com/users/prismskylabs/orgs","repos_url":"https://api.github.com/users/prismskylabs/repos","events_url":"https://api.github.com/users/prismskylabs/events{/privacy}","received_events_url":"https://api.github.com/users/prismskylabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prismskylabs/connect","description":null,"fork":false,"url":"https://api.github.com/repos/prismskylabs/connect","forks_url":"https://api.github.com/repos/prismskylabs/connect/forks","keys_url":"https://api.github.com/repos/prismskylabs/connect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prismskylabs/connect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prismskylabs/connect/teams","hooks_url":"https://api.github.com/repos/prismskylabs/connect/hooks","issue_events_url":"https://api.github.com/repos/prismskylabs/connect/issues/events{/number}","events_url":"https://api.github.com/repos/prismskylabs/connect/events","assignees_url":"https://api.github.com/repos/prismskylabs/connect/assignees{/user}","branches_url":"https://api.github.com/repos/prismskylabs/connect/branches{/branch}","tags_url":"https://api.github.com/repos/prismskylabs/connect/tags","blobs_url":"https://api.github.com/repos/prismskylabs/connect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prismskylabs/connect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prismskylabs/connect/git/refs{/sha}","trees_url":"https://api.github.com/repos/prismskylabs/connect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prismskylabs/connect/statuses/{sha}","languages_url":"https://api.github.com/repos/prismskylabs/connect/languages","stargazers_url":"https://api.github.com/repos/prismskylabs/connect/stargazers","contributors_url":"https://api.github.com/repos/prismskylabs/connect/contributors","subscribers_url":"https://api.github.com/repos/prismskylabs/connect/subscribers","subscription_url":"https://api.github.com/repos/prismskylabs/connect/subscription","commits_url":"https://api.github.com/repos/prismskylabs/connect/commits{/sha}","git_commits_url":"https://api.github.com/repos/prismskylabs/connect/git/commits{/sha}","comments_url":"https://api.github.com/repos/prismskylabs/connect/comments{/number}","issue_comment_url":"https://api.github.com/repos/prismskylabs/connect/issues/comments{/number}","contents_url":"https://api.github.com/repos/prismskylabs/connect/contents/{+path}","compare_url":"https://api.github.com/repos/prismskylabs/connect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prismskylabs/connect/merges","archive_url":"https://api.github.com/repos/prismskylabs/connect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prismskylabs/connect/downloads","issues_url":"https://api.github.com/repos/prismskylabs/connect/issues{/number}","pulls_url":"https://api.github.com/repos/prismskylabs/connect/pulls{/number}","milestones_url":"https://api.github.com/repos/prismskylabs/connect/milestones{/number}","notifications_url":"https://api.github.com/repos/prismskylabs/connect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prismskylabs/connect/labels{/name}","releases_url":"https://api.github.com/repos/prismskylabs/connect/releases{/id}","deployments_url":"https://api.github.com/repos/prismskylabs/connect/deployments","created_at":"2016-08-15T22:13:37Z","updated_at":"2017-03-30T07:53:53Z","pushed_at":"2017-08-07T13:32:59Z","git_url":"git://github.com/prismskylabs/connect.git","ssh_url":"[email protected]:prismskylabs/connect.git","clone_url":"https://github.com/prismskylabs/connect.git","svn_url":"https://github.com/prismskylabs/connect","homepage":null,"size":616,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"prismskylabs:master","ref":"master","sha":"04ce2c1d79fd48e8e687d34ffd9482b961e24826","user":{"login":"prismskylabs","id":2381267,"avatar_url":"https://avatars3.githubusercontent.com/u/2381267?v=4","gravatar_id":"","url":"https://api.github.com/users/prismskylabs","html_url":"https://github.com/prismskylabs","followers_url":"https://api.github.com/users/prismskylabs/followers","following_url":"https://api.github.com/users/prismskylabs/following{/other_user}","gists_url":"https://api.github.com/users/prismskylabs/gists{/gist_id}","starred_url":"https://api.github.com/users/prismskylabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prismskylabs/subscriptions","organizations_url":"https://api.github.com/users/prismskylabs/orgs","repos_url":"https://api.github.com/users/prismskylabs/repos","events_url":"https://api.github.com/users/prismskylabs/events{/privacy}","received_events_url":"https://api.github.com/users/prismskylabs/received_events","type":"Organization","site_admin":false},"repo":{"id":65768540,"name":"connect","full_name":"prismskylabs/connect","owner":{"login":"prismskylabs","id":2381267,"avatar_url":"https://avatars3.githubusercontent.com/u/2381267?v=4","gravatar_id":"","url":"https://api.github.com/users/prismskylabs","html_url":"https://github.com/prismskylabs","followers_url":"https://api.github.com/users/prismskylabs/followers","following_url":"https://api.github.com/users/prismskylabs/following{/other_user}","gists_url":"https://api.github.com/users/prismskylabs/gists{/gist_id}","starred_url":"https://api.github.com/users/prismskylabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prismskylabs/subscriptions","organizations_url":"https://api.github.com/users/prismskylabs/orgs","repos_url":"https://api.github.com/users/prismskylabs/repos","events_url":"https://api.github.com/users/prismskylabs/events{/privacy}","received_events_url":"https://api.github.com/users/prismskylabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prismskylabs/connect","description":null,"fork":false,"url":"https://api.github.com/repos/prismskylabs/connect","forks_url":"https://api.github.com/repos/prismskylabs/connect/forks","keys_url":"https://api.github.com/repos/prismskylabs/connect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prismskylabs/connect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prismskylabs/connect/teams","hooks_url":"https://api.github.com/repos/prismskylabs/connect/hooks","issue_events_url":"https://api.github.com/repos/prismskylabs/connect/issues/events{/number}","events_url":"https://api.github.com/repos/prismskylabs/connect/events","assignees_url":"https://api.github.com/repos/prismskylabs/connect/assignees{/user}","branches_url":"https://api.github.com/repos/prismskylabs/connect/branches{/branch}","tags_url":"https://api.github.com/repos/prismskylabs/connect/tags","blobs_url":"https://api.github.com/repos/prismskylabs/connect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prismskylabs/connect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prismskylabs/connect/git/refs{/sha}","trees_url":"https://api.github.com/repos/prismskylabs/connect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prismskylabs/connect/statuses/{sha}","languages_url":"https://api.github.com/repos/prismskylabs/connect/languages","stargazers_url":"https://api.github.com/repos/prismskylabs/connect/stargazers","contributors_url":"https://api.github.com/repos/prismskylabs/connect/contributors","subscribers_url":"https://api.github.com/repos/prismskylabs/connect/subscribers","subscription_url":"https://api.github.com/repos/prismskylabs/connect/subscription","commits_url":"https://api.github.com/repos/prismskylabs/connect/commits{/sha}","git_commits_url":"https://api.github.com/repos/prismskylabs/connect/git/commits{/sha}","comments_url":"https://api.github.com/repos/prismskylabs/connect/comments{/number}","issue_comment_url":"https://api.github.com/repos/prismskylabs/connect/issues/comments{/number}","contents_url":"https://api.github.com/repos/prismskylabs/connect/contents/{+path}","compare_url":"https://api.github.com/repos/prismskylabs/connect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prismskylabs/connect/merges","archive_url":"https://api.github.com/repos/prismskylabs/connect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prismskylabs/connect/downloads","issues_url":"https://api.github.com/repos/prismskylabs/connect/issues{/number}","pulls_url":"https://api.github.com/repos/prismskylabs/connect/pulls{/number}","milestones_url":"https://api.github.com/repos/prismskylabs/connect/milestones{/number}","notifications_url":"https://api.github.com/repos/prismskylabs/connect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prismskylabs/connect/labels{/name}","releases_url":"https://api.github.com/repos/prismskylabs/connect/releases{/id}","deployments_url":"https://api.github.com/repos/prismskylabs/connect/deployments","created_at":"2016-08-15T22:13:37Z","updated_at":"2017-03-30T07:53:53Z","pushed_at":"2017-08-07T13:32:59Z","git_url":"git://github.com/prismskylabs/connect.git","ssh_url":"[email protected]:prismskylabs/connect.git","clone_url":"https://github.com/prismskylabs/connect.git","svn_url":"https://github.com/prismskylabs/connect","homepage":null,"size":616,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prismskylabs/connect/pulls/69"},"html":{"href":"https://github.com/prismskylabs/connect/pull/69"},"issue":{"href":"https://api.github.com/repos/prismskylabs/connect/issues/69"},"comments":{"href":"https://api.github.com/repos/prismskylabs/connect/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/prismskylabs/connect/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/prismskylabs/connect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prismskylabs/connect/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/prismskylabs/connect/statuses/5d47563dee3a8683121d4aee68cf4b429110b71f"}}}}
|
{
"id": 65768540,
"name": "prismskylabs/connect",
"url": "https://api.github.com/repos/prismskylabs/connect"
}
|
{
"id": 24312265,
"login": "ionyshch-prismsl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24312265?",
"url": "https://api.github.com/users/ionyshch-prismsl"
}
|
{
"id": 2381267,
"login": "prismskylabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2381267?",
"url": "https://api.github.com/orgs/prismskylabs"
}
| 2017-08-07T15:46:04 |
6408523633
|
{"actor":{"display_login":"ionyshch-prismsl"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/quintilesims/layer0/pulls/comments/140114908","pull_request_review_id":64141734,"id":140114908,"diff_hunk":"@@ -0,0 +1,170 @@\n+package aws\n+\n+import (\n+\t\"strings\"\n+\n+\t\"github.com/aws/aws-sdk-go/aws\"\n+\t\"github.com/aws/aws-sdk-go/service/ecs\"\n+\t\"github.com/quintilesims/layer0/common/models\"\n+)\n+\n+func (s *ServiceProvider) List() ([]models.ServiceSummary, error) {","path":"api/provider/aws/service_list.go","position":11,"original_position":11,"commit_id":"5cafb3f796634db5af411ec71ec16ea25c162d5e","original_commit_id":"5cafb3f796634db5af411ec71ec16ea25c162d5e","user":{"login":"tlake","id":5035800,"avatar_url":"https://avatars3.githubusercontent.com/u/5035800?v=4","gravatar_id":"","url":"https://api.github.com/users/tlake","html_url":"https://github.com/tlake","followers_url":"https://api.github.com/users/tlake/followers","following_url":"https://api.github.com/users/tlake/following{/other_user}","gists_url":"https://api.github.com/users/tlake/gists{/gist_id}","starred_url":"https://api.github.com/users/tlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlake/subscriptions","organizations_url":"https://api.github.com/users/tlake/orgs","repos_url":"https://api.github.com/users/tlake/repos","events_url":"https://api.github.com/users/tlake/events{/privacy}","received_events_url":"https://api.github.com/users/tlake/received_events","type":"User","site_admin":false},"body":"Yeah - our two branches seemed to be a little intertwined, but with Seshi being a new dad, I expect to take responsibility for all of service, so I can continue his work going forward.","created_at":"2017-09-20T23:07:54Z","updated_at":"2017-09-20T23:07:55Z","html_url":"https://github.com/quintilesims/layer0/pull/352#discussion_r140114908","pull_request_url":"https://api.github.com/repos/quintilesims/layer0/pulls/352","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/quintilesims/layer0/pulls/comments/140114908"},"html":{"href":"https://github.com/quintilesims/layer0/pull/352#discussion_r140114908"},"pull_request":{"href":"https://api.github.com/repos/quintilesims/layer0/pulls/352"}},"in_reply_to_id":140108635},"pull_request":{"url":"https://api.github.com/repos/quintilesims/layer0/pulls/352","id":141925450,"html_url":"https://github.com/quintilesims/layer0/pull/352","diff_url":"https://github.com/quintilesims/layer0/pull/352.diff","patch_url":"https://github.com/quintilesims/layer0/pull/352.patch","issue_url":"https://api.github.com/repos/quintilesims/layer0/issues/352","number":352,"state":"open","locked":false,"title":"Service provider: `Update`","user":{"login":"tlake","id":5035800,"avatar_url":"https://avatars3.githubusercontent.com/u/5035800?v=4","gravatar_id":"","url":"https://api.github.com/users/tlake","html_url":"https://github.com/tlake","followers_url":"https://api.github.com/users/tlake/followers","following_url":"https://api.github.com/users/tlake/following{/other_user}","gists_url":"https://api.github.com/users/tlake/gists{/gist_id}","starred_url":"https://api.github.com/users/tlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlake/subscriptions","organizations_url":"https://api.github.com/users/tlake/orgs","repos_url":"https://api.github.com/users/tlake/repos","events_url":"https://api.github.com/users/tlake/events{/privacy}","received_events_url":"https://api.github.com/users/tlake/received_events","type":"User","site_admin":false},"body":"**What does this pull request do?**\r\nAdds `Update` to service provider.","created_at":"2017-09-19T18:42:48Z","updated_at":"2017-09-20T23:07:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e03d3044c5a8f438645ae1982568fd025457a7aa","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/quintilesims/layer0/pulls/352/commits","review_comments_url":"https://api.github.com/repos/quintilesims/layer0/pulls/352/comments","review_comment_url":"https://api.github.com/repos/quintilesims/layer0/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quintilesims/layer0/issues/352/comments","statuses_url":"https://api.github.com/repos/quintilesims/layer0/statuses/5cafb3f796634db5af411ec71ec16ea25c162d5e","head":{"label":"quintilesims:aws-provider-service-tlake","ref":"aws-provider-service-tlake","sha":"5cafb3f796634db5af411ec71ec16ea25c162d5e","user":{"login":"quintilesims","id":23506699,"avatar_url":"https://avatars2.githubusercontent.com/u/23506699?v=4","gravatar_id":"","url":"https://api.github.com/users/quintilesims","html_url":"https://github.com/quintilesims","followers_url":"https://api.github.com/users/quintilesims/followers","following_url":"https://api.github.com/users/quintilesims/following{/other_user}","gists_url":"https://api.github.com/users/quintilesims/gists{/gist_id}","starred_url":"https://api.github.com/users/quintilesims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quintilesims/subscriptions","organizations_url":"https://api.github.com/users/quintilesims/orgs","repos_url":"https://api.github.com/users/quintilesims/repos","events_url":"https://api.github.com/users/quintilesims/events{/privacy}","received_events_url":"https://api.github.com/users/quintilesims/received_events","type":"Organization","site_admin":false},"repo":{"id":74167056,"name":"layer0","full_name":"quintilesims/layer0","owner":{"login":"quintilesims","id":23506699,"avatar_url":"https://avatars2.githubusercontent.com/u/23506699?v=4","gravatar_id":"","url":"https://api.github.com/users/quintilesims","html_url":"https://github.com/quintilesims","followers_url":"https://api.github.com/users/quintilesims/followers","following_url":"https://api.github.com/users/quintilesims/following{/other_user}","gists_url":"https://api.github.com/users/quintilesims/gists{/gist_id}","starred_url":"https://api.github.com/users/quintilesims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quintilesims/subscriptions","organizations_url":"https://api.github.com/users/quintilesims/orgs","repos_url":"https://api.github.com/users/quintilesims/repos","events_url":"https://api.github.com/users/quintilesims/events{/privacy}","received_events_url":"https://api.github.com/users/quintilesims/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quintilesims/layer0","description":"Build, Manage, and Deploy Your Applications","fork":false,"url":"https://api.github.com/repos/quintilesims/layer0","forks_url":"https://api.github.com/repos/quintilesims/layer0/forks","keys_url":"https://api.github.com/repos/quintilesims/layer0/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quintilesims/layer0/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quintilesims/layer0/teams","hooks_url":"https://api.github.com/repos/quintilesims/layer0/hooks","issue_events_url":"https://api.github.com/repos/quintilesims/layer0/issues/events{/number}","events_url":"https://api.github.com/repos/quintilesims/layer0/events","assignees_url":"https://api.github.com/repos/quintilesims/layer0/assignees{/user}","branches_url":"https://api.github.com/repos/quintilesims/layer0/branches{/branch}","tags_url":"https://api.github.com/repos/quintilesims/layer0/tags","blobs_url":"https://api.github.com/repos/quintilesims/layer0/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quintilesims/layer0/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quintilesims/layer0/git/refs{/sha}","trees_url":"https://api.github.com/repos/quintilesims/layer0/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quintilesims/layer0/statuses/{sha}","languages_url":"https://api.github.com/repos/quintilesims/layer0/languages","stargazers_url":"https://api.github.com/repos/quintilesims/layer0/stargazers","contributors_url":"https://api.github.com/repos/quintilesims/layer0/contributors","subscribers_url":"https://api.github.com/repos/quintilesims/layer0/subscribers","subscription_url":"https://api.github.com/repos/quintilesims/layer0/subscription","commits_url":"https://api.github.com/repos/quintilesims/layer0/commits{/sha}","git_commits_url":"https://api.github.com/repos/quintilesims/layer0/git/commits{/sha}","comments_url":"https://api.github.com/repos/quintilesims/layer0/comments{/number}","issue_comment_url":"https://api.github.com/repos/quintilesims/layer0/issues/comments{/number}","contents_url":"https://api.github.com/repos/quintilesims/layer0/contents/{+path}","compare_url":"https://api.github.com/repos/quintilesims/layer0/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quintilesims/layer0/merges","archive_url":"https://api.github.com/repos/quintilesims/layer0/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quintilesims/layer0/downloads","issues_url":"https://api.github.com/repos/quintilesims/layer0/issues{/number}","pulls_url":"https://api.github.com/repos/quintilesims/layer0/pulls{/number}","milestones_url":"https://api.github.com/repos/quintilesims/layer0/milestones{/number}","notifications_url":"https://api.github.com/repos/quintilesims/layer0/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quintilesims/layer0/labels{/name}","releases_url":"https://api.github.com/repos/quintilesims/layer0/releases{/id}","deployments_url":"https://api.github.com/repos/quintilesims/layer0/deployments","created_at":"2016-11-18T21:18:34Z","updated_at":"2017-09-19T16:18:22Z","pushed_at":"2017-09-20T22:46:54Z","git_url":"git://github.com/quintilesims/layer0.git","ssh_url":"[email protected]:quintilesims/layer0.git","clone_url":"https://github.com/quintilesims/layer0.git","svn_url":"https://github.com/quintilesims/layer0","homepage":"","size":51226,"stargazers_count":22,"watchers_count":22,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":31,"forks":2,"open_issues":31,"watchers":22,"default_branch":"develop"}},"base":{"label":"quintilesims:api-refactor","ref":"api-refactor","sha":"b88ab534bd5024a514b92d3ecb674a78ba40d6bc","user":{"login":"quintilesims","id":23506699,"avatar_url":"https://avatars2.githubusercontent.com/u/23506699?v=4","gravatar_id":"","url":"https://api.github.com/users/quintilesims","html_url":"https://github.com/quintilesims","followers_url":"https://api.github.com/users/quintilesims/followers","following_url":"https://api.github.com/users/quintilesims/following{/other_user}","gists_url":"https://api.github.com/users/quintilesims/gists{/gist_id}","starred_url":"https://api.github.com/users/quintilesims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quintilesims/subscriptions","organizations_url":"https://api.github.com/users/quintilesims/orgs","repos_url":"https://api.github.com/users/quintilesims/repos","events_url":"https://api.github.com/users/quintilesims/events{/privacy}","received_events_url":"https://api.github.com/users/quintilesims/received_events","type":"Organization","site_admin":false},"repo":{"id":74167056,"name":"layer0","full_name":"quintilesims/layer0","owner":{"login":"quintilesims","id":23506699,"avatar_url":"https://avatars2.githubusercontent.com/u/23506699?v=4","gravatar_id":"","url":"https://api.github.com/users/quintilesims","html_url":"https://github.com/quintilesims","followers_url":"https://api.github.com/users/quintilesims/followers","following_url":"https://api.github.com/users/quintilesims/following{/other_user}","gists_url":"https://api.github.com/users/quintilesims/gists{/gist_id}","starred_url":"https://api.github.com/users/quintilesims/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quintilesims/subscriptions","organizations_url":"https://api.github.com/users/quintilesims/orgs","repos_url":"https://api.github.com/users/quintilesims/repos","events_url":"https://api.github.com/users/quintilesims/events{/privacy}","received_events_url":"https://api.github.com/users/quintilesims/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quintilesims/layer0","description":"Build, Manage, and Deploy Your Applications","fork":false,"url":"https://api.github.com/repos/quintilesims/layer0","forks_url":"https://api.github.com/repos/quintilesims/layer0/forks","keys_url":"https://api.github.com/repos/quintilesims/layer0/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quintilesims/layer0/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quintilesims/layer0/teams","hooks_url":"https://api.github.com/repos/quintilesims/layer0/hooks","issue_events_url":"https://api.github.com/repos/quintilesims/layer0/issues/events{/number}","events_url":"https://api.github.com/repos/quintilesims/layer0/events","assignees_url":"https://api.github.com/repos/quintilesims/layer0/assignees{/user}","branches_url":"https://api.github.com/repos/quintilesims/layer0/branches{/branch}","tags_url":"https://api.github.com/repos/quintilesims/layer0/tags","blobs_url":"https://api.github.com/repos/quintilesims/layer0/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quintilesims/layer0/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quintilesims/layer0/git/refs{/sha}","trees_url":"https://api.github.com/repos/quintilesims/layer0/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quintilesims/layer0/statuses/{sha}","languages_url":"https://api.github.com/repos/quintilesims/layer0/languages","stargazers_url":"https://api.github.com/repos/quintilesims/layer0/stargazers","contributors_url":"https://api.github.com/repos/quintilesims/layer0/contributors","subscribers_url":"https://api.github.com/repos/quintilesims/layer0/subscribers","subscription_url":"https://api.github.com/repos/quintilesims/layer0/subscription","commits_url":"https://api.github.com/repos/quintilesims/layer0/commits{/sha}","git_commits_url":"https://api.github.com/repos/quintilesims/layer0/git/commits{/sha}","comments_url":"https://api.github.com/repos/quintilesims/layer0/comments{/number}","issue_comment_url":"https://api.github.com/repos/quintilesims/layer0/issues/comments{/number}","contents_url":"https://api.github.com/repos/quintilesims/layer0/contents/{+path}","compare_url":"https://api.github.com/repos/quintilesims/layer0/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quintilesims/layer0/merges","archive_url":"https://api.github.com/repos/quintilesims/layer0/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quintilesims/layer0/downloads","issues_url":"https://api.github.com/repos/quintilesims/layer0/issues{/number}","pulls_url":"https://api.github.com/repos/quintilesims/layer0/pulls{/number}","milestones_url":"https://api.github.com/repos/quintilesims/layer0/milestones{/number}","notifications_url":"https://api.github.com/repos/quintilesims/layer0/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quintilesims/layer0/labels{/name}","releases_url":"https://api.github.com/repos/quintilesims/layer0/releases{/id}","deployments_url":"https://api.github.com/repos/quintilesims/layer0/deployments","created_at":"2016-11-18T21:18:34Z","updated_at":"2017-09-19T16:18:22Z","pushed_at":"2017-09-20T22:46:54Z","git_url":"git://github.com/quintilesims/layer0.git","ssh_url":"[email protected]:quintilesims/layer0.git","clone_url":"https://github.com/quintilesims/layer0.git","svn_url":"https://github.com/quintilesims/layer0","homepage":"","size":51226,"stargazers_count":22,"watchers_count":22,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":31,"forks":2,"open_issues":31,"watchers":22,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/quintilesims/layer0/pulls/352"},"html":{"href":"https://github.com/quintilesims/layer0/pull/352"},"issue":{"href":"https://api.github.com/repos/quintilesims/layer0/issues/352"},"comments":{"href":"https://api.github.com/repos/quintilesims/layer0/issues/352/comments"},"review_comments":{"href":"https://api.github.com/repos/quintilesims/layer0/pulls/352/comments"},"review_comment":{"href":"https://api.github.com/repos/quintilesims/layer0/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quintilesims/layer0/pulls/352/commits"},"statuses":{"href":"https://api.github.com/repos/quintilesims/layer0/statuses/5cafb3f796634db5af411ec71ec16ea25c162d5e"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 74167056,
"name": "quintilesims/layer0",
"url": "https://api.github.com/repos/quintilesims/layer0"
}
|
{
"id": 5035800,
"login": "tlake",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5035800?",
"url": "https://api.github.com/users/tlake"
}
|
{
"id": 23506699,
"login": "quintilesims",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23506699?",
"url": "https://api.github.com/orgs/quintilesims"
}
| 2017-09-20T23:07:54 |
6617079380
|
{"actor":{"display_login":"tlake"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/reportportal/commons-dao/pulls/comments/142776470","pull_request_review_id":67187945,"id":142776470,"diff_hunk":"@@ -0,0 +1,48 @@\n+/*\n+ * Copyright 2017 EPAM Systems\n+ *\n+ *\n+ * This file is part of EPAM Report Portal.\n+ * https://github.com/reportportal/service-api\n+ *\n+ * Report Portal is free software: you can redistribute it and/or modify\n+ * it under the terms of the GNU General Public License as published by\n+ * the Free Software Foundation, either version 3 of the License, or\n+ * (at your option) any later version.\n+ *\n+ * Report Portal is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+ * GNU General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU General Public License\n+ * along with Report Portal. If not, see <http://www.gnu.org/licenses/>.\n+ */\n+package com.epam.ta.reportportal.commons;\n+\n+import java.util.LinkedHashMap;\n+import java.util.Map;\n+import java.util.function.Function;\n+import java.util.stream.Collector;\n+import java.util.stream.Collectors;\n+\n+/**\n+ * Custom collectors for collections streaming.\n+ *\n+ * @author Pavel Bortnik\n+ */\n+public final class MoreCollectors {\n+\n+ private MoreCollectors() {\n+ //static only\n+ }\n+\n+ public static <T, K, U> Collector<T, ?, Map<K, U>> toLinkedMap(Function<? super T, ? extends K> keyMapper,","path":"src/main/java/com/epam/ta/reportportal/commons/MoreCollectors.java","position":40,"original_position":40,"commit_id":"1786c48e1bc213706314957e666bcac6cd169818","original_commit_id":"1786c48e1bc213706314957e666bcac6cd169818","user":{"login":"avarabyeu","id":1565439,"avatar_url":"https://avatars1.githubusercontent.com/u/1565439?v=4","gravatar_id":"","url":"https://api.github.com/users/avarabyeu","html_url":"https://github.com/avarabyeu","followers_url":"https://api.github.com/users/avarabyeu/followers","following_url":"https://api.github.com/users/avarabyeu/following{/other_user}","gists_url":"https://api.github.com/users/avarabyeu/gists{/gist_id}","starred_url":"https://api.github.com/users/avarabyeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avarabyeu/subscriptions","organizations_url":"https://api.github.com/users/avarabyeu/orgs","repos_url":"https://api.github.com/users/avarabyeu/repos","events_url":"https://api.github.com/users/avarabyeu/events{/privacy}","received_events_url":"https://api.github.com/users/avarabyeu/received_events","type":"User","site_admin":false},"body":"any unit tests?","created_at":"2017-10-04T19:58:24Z","updated_at":"2017-10-04T19:58:29Z","html_url":"https://github.com/reportportal/commons-dao/pull/82#discussion_r142776470","pull_request_url":"https://api.github.com/repos/reportportal/commons-dao/pulls/82","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/reportportal/commons-dao/pulls/comments/142776470"},"html":{"href":"https://github.com/reportportal/commons-dao/pull/82#discussion_r142776470"},"pull_request":{"href":"https://api.github.com/repos/reportportal/commons-dao/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/reportportal/commons-dao/pulls/82","id":144639262,"html_url":"https://github.com/reportportal/commons-dao/pull/82","diff_url":"https://github.com/reportportal/commons-dao/pull/82.diff","patch_url":"https://github.com/reportportal/commons-dao/pull/82.patch","issue_url":"https://api.github.com/repos/reportportal/commons-dao/issues/82","number":82,"state":"open","locked":false,"title":"Analyzer imporvements","user":{"login":"pictureb00k","id":8058828,"avatar_url":"https://avatars1.githubusercontent.com/u/8058828?v=4","gravatar_id":"","url":"https://api.github.com/users/pictureb00k","html_url":"https://github.com/pictureb00k","followers_url":"https://api.github.com/users/pictureb00k/followers","following_url":"https://api.github.com/users/pictureb00k/following{/other_user}","gists_url":"https://api.github.com/users/pictureb00k/gists{/gist_id}","starred_url":"https://api.github.com/users/pictureb00k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pictureb00k/subscriptions","organizations_url":"https://api.github.com/users/pictureb00k/orgs","repos_url":"https://api.github.com/users/pictureb00k/repos","events_url":"https://api.github.com/users/pictureb00k/events{/privacy}","received_events_url":"https://api.github.com/users/pictureb00k/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-04T11:01:34Z","updated_at":"2017-10-04T19:58:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd93c1bd1f59961c27b5ddfc7d4170caf21279ef","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/reportportal/commons-dao/pulls/82/commits","review_comments_url":"https://api.github.com/repos/reportportal/commons-dao/pulls/82/comments","review_comment_url":"https://api.github.com/repos/reportportal/commons-dao/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reportportal/commons-dao/issues/82/comments","statuses_url":"https://api.github.com/repos/reportportal/commons-dao/statuses/1786c48e1bc213706314957e666bcac6cd169818","head":{"label":"reportportal:analyzer-imporve","ref":"analyzer-imporve","sha":"1786c48e1bc213706314957e666bcac6cd169818","user":{"login":"reportportal","id":17636279,"avatar_url":"https://avatars1.githubusercontent.com/u/17636279?v=4","gravatar_id":"","url":"https://api.github.com/users/reportportal","html_url":"https://github.com/reportportal","followers_url":"https://api.github.com/users/reportportal/followers","following_url":"https://api.github.com/users/reportportal/following{/other_user}","gists_url":"https://api.github.com/users/reportportal/gists{/gist_id}","starred_url":"https://api.github.com/users/reportportal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reportportal/subscriptions","organizations_url":"https://api.github.com/users/reportportal/orgs","repos_url":"https://api.github.com/users/reportportal/repos","events_url":"https://api.github.com/users/reportportal/events{/privacy}","received_events_url":"https://api.github.com/users/reportportal/received_events","type":"Organization","site_admin":false},"repo":{"id":68365983,"name":"commons-dao","full_name":"reportportal/commons-dao","owner":{"login":"reportportal","id":17636279,"avatar_url":"https://avatars1.githubusercontent.com/u/17636279?v=4","gravatar_id":"","url":"https://api.github.com/users/reportportal","html_url":"https://github.com/reportportal","followers_url":"https://api.github.com/users/reportportal/followers","following_url":"https://api.github.com/users/reportportal/following{/other_user}","gists_url":"https://api.github.com/users/reportportal/gists{/gist_id}","starred_url":"https://api.github.com/users/reportportal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reportportal/subscriptions","organizations_url":"https://api.github.com/users/reportportal/orgs","repos_url":"https://api.github.com/users/reportportal/repos","events_url":"https://api.github.com/users/reportportal/events{/privacy}","received_events_url":"https://api.github.com/users/reportportal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reportportal/commons-dao","description":"EPAM Report portal. Common DAO Layer","fork":false,"url":"https://api.github.com/repos/reportportal/commons-dao","forks_url":"https://api.github.com/repos/reportportal/commons-dao/forks","keys_url":"https://api.github.com/repos/reportportal/commons-dao/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reportportal/commons-dao/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reportportal/commons-dao/teams","hooks_url":"https://api.github.com/repos/reportportal/commons-dao/hooks","issue_events_url":"https://api.github.com/repos/reportportal/commons-dao/issues/events{/number}","events_url":"https://api.github.com/repos/reportportal/commons-dao/events","assignees_url":"https://api.github.com/repos/reportportal/commons-dao/assignees{/user}","branches_url":"https://api.github.com/repos/reportportal/commons-dao/branches{/branch}","tags_url":"https://api.github.com/repos/reportportal/commons-dao/tags","blobs_url":"https://api.github.com/repos/reportportal/commons-dao/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reportportal/commons-dao/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reportportal/commons-dao/git/refs{/sha}","trees_url":"https://api.github.com/repos/reportportal/commons-dao/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reportportal/commons-dao/statuses/{sha}","languages_url":"https://api.github.com/repos/reportportal/commons-dao/languages","stargazers_url":"https://api.github.com/repos/reportportal/commons-dao/stargazers","contributors_url":"https://api.github.com/repos/reportportal/commons-dao/contributors","subscribers_url":"https://api.github.com/repos/reportportal/commons-dao/subscribers","subscription_url":"https://api.github.com/repos/reportportal/commons-dao/subscription","commits_url":"https://api.github.com/repos/reportportal/commons-dao/commits{/sha}","git_commits_url":"https://api.github.com/repos/reportportal/commons-dao/git/commits{/sha}","comments_url":"https://api.github.com/repos/reportportal/commons-dao/comments{/number}","issue_comment_url":"https://api.github.com/repos/reportportal/commons-dao/issues/comments{/number}","contents_url":"https://api.github.com/repos/reportportal/commons-dao/contents/{+path}","compare_url":"https://api.github.com/repos/reportportal/commons-dao/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reportportal/commons-dao/merges","archive_url":"https://api.github.com/repos/reportportal/commons-dao/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reportportal/commons-dao/downloads","issues_url":"https://api.github.com/repos/reportportal/commons-dao/issues{/number}","pulls_url":"https://api.github.com/repos/reportportal/commons-dao/pulls{/number}","milestones_url":"https://api.github.com/repos/reportportal/commons-dao/milestones{/number}","notifications_url":"https://api.github.com/repos/reportportal/commons-dao/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reportportal/commons-dao/labels{/name}","releases_url":"https://api.github.com/repos/reportportal/commons-dao/releases{/id}","deployments_url":"https://api.github.com/repos/reportportal/commons-dao/deployments","created_at":"2016-09-16T09:00:03Z","updated_at":"2017-02-17T07:20:30Z","pushed_at":"2017-10-04T11:01:35Z","git_url":"git://github.com/reportportal/commons-dao.git","ssh_url":"[email protected]:reportportal/commons-dao.git","clone_url":"https://github.com/reportportal/commons-dao.git","svn_url":"https://github.com/reportportal/commons-dao","homepage":"","size":855,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":6,"default_branch":"develop"}},"base":{"label":"reportportal:develop","ref":"develop","sha":"2f64bce5e7bc2915c38242af25c88e017065d7f8","user":{"login":"reportportal","id":17636279,"avatar_url":"https://avatars1.githubusercontent.com/u/17636279?v=4","gravatar_id":"","url":"https://api.github.com/users/reportportal","html_url":"https://github.com/reportportal","followers_url":"https://api.github.com/users/reportportal/followers","following_url":"https://api.github.com/users/reportportal/following{/other_user}","gists_url":"https://api.github.com/users/reportportal/gists{/gist_id}","starred_url":"https://api.github.com/users/reportportal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reportportal/subscriptions","organizations_url":"https://api.github.com/users/reportportal/orgs","repos_url":"https://api.github.com/users/reportportal/repos","events_url":"https://api.github.com/users/reportportal/events{/privacy}","received_events_url":"https://api.github.com/users/reportportal/received_events","type":"Organization","site_admin":false},"repo":{"id":68365983,"name":"commons-dao","full_name":"reportportal/commons-dao","owner":{"login":"reportportal","id":17636279,"avatar_url":"https://avatars1.githubusercontent.com/u/17636279?v=4","gravatar_id":"","url":"https://api.github.com/users/reportportal","html_url":"https://github.com/reportportal","followers_url":"https://api.github.com/users/reportportal/followers","following_url":"https://api.github.com/users/reportportal/following{/other_user}","gists_url":"https://api.github.com/users/reportportal/gists{/gist_id}","starred_url":"https://api.github.com/users/reportportal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reportportal/subscriptions","organizations_url":"https://api.github.com/users/reportportal/orgs","repos_url":"https://api.github.com/users/reportportal/repos","events_url":"https://api.github.com/users/reportportal/events{/privacy}","received_events_url":"https://api.github.com/users/reportportal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reportportal/commons-dao","description":"EPAM Report portal. Common DAO Layer","fork":false,"url":"https://api.github.com/repos/reportportal/commons-dao","forks_url":"https://api.github.com/repos/reportportal/commons-dao/forks","keys_url":"https://api.github.com/repos/reportportal/commons-dao/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reportportal/commons-dao/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reportportal/commons-dao/teams","hooks_url":"https://api.github.com/repos/reportportal/commons-dao/hooks","issue_events_url":"https://api.github.com/repos/reportportal/commons-dao/issues/events{/number}","events_url":"https://api.github.com/repos/reportportal/commons-dao/events","assignees_url":"https://api.github.com/repos/reportportal/commons-dao/assignees{/user}","branches_url":"https://api.github.com/repos/reportportal/commons-dao/branches{/branch}","tags_url":"https://api.github.com/repos/reportportal/commons-dao/tags","blobs_url":"https://api.github.com/repos/reportportal/commons-dao/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reportportal/commons-dao/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reportportal/commons-dao/git/refs{/sha}","trees_url":"https://api.github.com/repos/reportportal/commons-dao/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reportportal/commons-dao/statuses/{sha}","languages_url":"https://api.github.com/repos/reportportal/commons-dao/languages","stargazers_url":"https://api.github.com/repos/reportportal/commons-dao/stargazers","contributors_url":"https://api.github.com/repos/reportportal/commons-dao/contributors","subscribers_url":"https://api.github.com/repos/reportportal/commons-dao/subscribers","subscription_url":"https://api.github.com/repos/reportportal/commons-dao/subscription","commits_url":"https://api.github.com/repos/reportportal/commons-dao/commits{/sha}","git_commits_url":"https://api.github.com/repos/reportportal/commons-dao/git/commits{/sha}","comments_url":"https://api.github.com/repos/reportportal/commons-dao/comments{/number}","issue_comment_url":"https://api.github.com/repos/reportportal/commons-dao/issues/comments{/number}","contents_url":"https://api.github.com/repos/reportportal/commons-dao/contents/{+path}","compare_url":"https://api.github.com/repos/reportportal/commons-dao/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reportportal/commons-dao/merges","archive_url":"https://api.github.com/repos/reportportal/commons-dao/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reportportal/commons-dao/downloads","issues_url":"https://api.github.com/repos/reportportal/commons-dao/issues{/number}","pulls_url":"https://api.github.com/repos/reportportal/commons-dao/pulls{/number}","milestones_url":"https://api.github.com/repos/reportportal/commons-dao/milestones{/number}","notifications_url":"https://api.github.com/repos/reportportal/commons-dao/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reportportal/commons-dao/labels{/name}","releases_url":"https://api.github.com/repos/reportportal/commons-dao/releases{/id}","deployments_url":"https://api.github.com/repos/reportportal/commons-dao/deployments","created_at":"2016-09-16T09:00:03Z","updated_at":"2017-02-17T07:20:30Z","pushed_at":"2017-10-04T11:01:35Z","git_url":"git://github.com/reportportal/commons-dao.git","ssh_url":"[email protected]:reportportal/commons-dao.git","clone_url":"https://github.com/reportportal/commons-dao.git","svn_url":"https://github.com/reportportal/commons-dao","homepage":"","size":855,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":6,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/reportportal/commons-dao/pulls/82"},"html":{"href":"https://github.com/reportportal/commons-dao/pull/82"},"issue":{"href":"https://api.github.com/repos/reportportal/commons-dao/issues/82"},"comments":{"href":"https://api.github.com/repos/reportportal/commons-dao/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/reportportal/commons-dao/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/reportportal/commons-dao/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reportportal/commons-dao/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/reportportal/commons-dao/statuses/1786c48e1bc213706314957e666bcac6cd169818"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 68365983,
"name": "reportportal/commons-dao",
"url": "https://api.github.com/repos/reportportal/commons-dao"
}
|
{
"id": 1565439,
"login": "avarabyeu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1565439?",
"url": "https://api.github.com/users/avarabyeu"
}
|
{
"id": 17636279,
"login": "reportportal",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17636279?",
"url": "https://api.github.com/orgs/reportportal"
}
| 2017-10-04T19:58:24 |
6674824988
|
{"actor":{"display_login":"avarabyeu"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/root-project/root/pulls/comments/150218923","pull_request_review_id":75737693,"id":150218923,"diff_hunk":"@@ -152,6 +153,45 @@ unsigned int GetNSlots()\n return nSlots;\n }\n \n+void GetBranchNamesImpl(TTree *t, std::set<std::string> &bNames, std::set<TTree *> &analysedTrees)\n+{\n+\n+ if (!t)\n+ return;\n+\n+ if (!analysedTrees.insert(t).second) {\n+ return;\n+ }\n+\n+ auto branches = t->GetListOfBranches();\n+ if (branches) {\n+ for (auto branchObj : *branches) {\n+ bNames.insert(branchObj->GetName());\n+ }\n+ }\n+\n+ auto friendTrees = t->GetListOfFriends();\n+\n+ if (!friendTrees)\n+ return;\n+\n+ for (auto friendTreeObj : *friendTrees) {\n+ auto friendTree = ((TFriendElement *)friendTreeObj)->GetTree();\n+ GetBranchNamesImpl(friendTree, bNames, analysedTrees);\n+ }\n+}\n+\n+ColumnNames_t GetBranchNames(TTree *t)","path":"tree/treeplayer/src/TDFUtils.cxx","position":40,"original_position":40,"commit_id":"67ed0714b966ef09094c33a6c142e6ea2f0dc11b","original_commit_id":"67ed0714b966ef09094c33a6c142e6ea2f0dc11b","user":{"login":"bluehood","id":10999034,"avatar_url":"https://avatars3.githubusercontent.com/u/10999034?v=4","gravatar_id":"","url":"https://api.github.com/users/bluehood","html_url":"https://github.com/bluehood","followers_url":"https://api.github.com/users/bluehood/followers","following_url":"https://api.github.com/users/bluehood/following{/other_user}","gists_url":"https://api.github.com/users/bluehood/gists{/gist_id}","starred_url":"https://api.github.com/users/bluehood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluehood/subscriptions","organizations_url":"https://api.github.com/users/bluehood/orgs","repos_url":"https://api.github.com/users/bluehood/repos","events_url":"https://api.github.com/users/bluehood/events{/privacy}","received_events_url":"https://api.github.com/users/bluehood/received_events","type":"User","site_admin":false},"body":"we shouldn't call this function if there is no tree, so the `TTree*` could be changed to a `TTree&`","created_at":"2017-11-10T12:02:46Z","updated_at":"2017-11-10T12:02:53Z","html_url":"https://github.com/root-project/root/pull/1308#discussion_r150218923","pull_request_url":"https://api.github.com/repos/root-project/root/pulls/1308","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/root-project/root/pulls/comments/150218923"},"html":{"href":"https://github.com/root-project/root/pull/1308#discussion_r150218923"},"pull_request":{"href":"https://api.github.com/repos/root-project/root/pulls/1308"}}},"pull_request":{"url":"https://api.github.com/repos/root-project/root/pulls/1308","id":151885057,"html_url":"https://github.com/root-project/root/pull/1308","diff_url":"https://github.com/root-project/root/pull/1308.diff","patch_url":"https://github.com/root-project/root/pull/1308.patch","issue_url":"https://api.github.com/repos/root-project/root/issues/1308","number":1308,"state":"open","locked":false,"title":"[TDF] Support friend columns in jitted Define's and Filter's","user":{"login":"dpiparo","id":7850302,"avatar_url":"https://avatars2.githubusercontent.com/u/7850302?v=4","gravatar_id":"","url":"https://api.github.com/users/dpiparo","html_url":"https://github.com/dpiparo","followers_url":"https://api.github.com/users/dpiparo/followers","following_url":"https://api.github.com/users/dpiparo/following{/other_user}","gists_url":"https://api.github.com/users/dpiparo/gists{/gist_id}","starred_url":"https://api.github.com/users/dpiparo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpiparo/subscriptions","organizations_url":"https://api.github.com/users/dpiparo/orgs","repos_url":"https://api.github.com/users/dpiparo/repos","events_url":"https://api.github.com/users/dpiparo/events{/privacy}","received_events_url":"https://api.github.com/users/dpiparo/received_events","type":"User","site_admin":false},"body":"The tests for this pr are in PR1148 (test driven development!)","created_at":"2017-11-10T11:27:32Z","updated_at":"2017-11-10T12:02:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41e03c33d738a887400a772d14daf75df35b21a0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/root-project/root/pulls/1308/commits","review_comments_url":"https://api.github.com/repos/root-project/root/pulls/1308/comments","review_comment_url":"https://api.github.com/repos/root-project/root/pulls/comments{/number}","comments_url":"https://api.github.com/repos/root-project/root/issues/1308/comments","statuses_url":"https://api.github.com/repos/root-project/root/statuses/67ed0714b966ef09094c33a6c142e6ea2f0dc11b","head":{"label":"dpiparo:friendCollsTDF","ref":"friendCollsTDF","sha":"67ed0714b966ef09094c33a6c142e6ea2f0dc11b","user":{"login":"dpiparo","id":7850302,"avatar_url":"https://avatars2.githubusercontent.com/u/7850302?v=4","gravatar_id":"","url":"https://api.github.com/users/dpiparo","html_url":"https://github.com/dpiparo","followers_url":"https://api.github.com/users/dpiparo/followers","following_url":"https://api.github.com/users/dpiparo/following{/other_user}","gists_url":"https://api.github.com/users/dpiparo/gists{/gist_id}","starred_url":"https://api.github.com/users/dpiparo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpiparo/subscriptions","organizations_url":"https://api.github.com/users/dpiparo/orgs","repos_url":"https://api.github.com/users/dpiparo/repos","events_url":"https://api.github.com/users/dpiparo/events{/privacy}","received_events_url":"https://api.github.com/users/dpiparo/received_events","type":"User","site_admin":false},"repo":{"id":88480268,"name":"root","full_name":"dpiparo/root","owner":{"login":"dpiparo","id":7850302,"avatar_url":"https://avatars2.githubusercontent.com/u/7850302?v=4","gravatar_id":"","url":"https://api.github.com/users/dpiparo","html_url":"https://github.com/dpiparo","followers_url":"https://api.github.com/users/dpiparo/followers","following_url":"https://api.github.com/users/dpiparo/following{/other_user}","gists_url":"https://api.github.com/users/dpiparo/gists{/gist_id}","starred_url":"https://api.github.com/users/dpiparo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpiparo/subscriptions","organizations_url":"https://api.github.com/users/dpiparo/orgs","repos_url":"https://api.github.com/users/dpiparo/repos","events_url":"https://api.github.com/users/dpiparo/events{/privacy}","received_events_url":"https://api.github.com/users/dpiparo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dpiparo/root","description":"The official ROOT repository","fork":true,"url":"https://api.github.com/repos/dpiparo/root","forks_url":"https://api.github.com/repos/dpiparo/root/forks","keys_url":"https://api.github.com/repos/dpiparo/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpiparo/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpiparo/root/teams","hooks_url":"https://api.github.com/repos/dpiparo/root/hooks","issue_events_url":"https://api.github.com/repos/dpiparo/root/issues/events{/number}","events_url":"https://api.github.com/repos/dpiparo/root/events","assignees_url":"https://api.github.com/repos/dpiparo/root/assignees{/user}","branches_url":"https://api.github.com/repos/dpiparo/root/branches{/branch}","tags_url":"https://api.github.com/repos/dpiparo/root/tags","blobs_url":"https://api.github.com/repos/dpiparo/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpiparo/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpiparo/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpiparo/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpiparo/root/statuses/{sha}","languages_url":"https://api.github.com/repos/dpiparo/root/languages","stargazers_url":"https://api.github.com/repos/dpiparo/root/stargazers","contributors_url":"https://api.github.com/repos/dpiparo/root/contributors","subscribers_url":"https://api.github.com/repos/dpiparo/root/subscribers","subscription_url":"https://api.github.com/repos/dpiparo/root/subscription","commits_url":"https://api.github.com/repos/dpiparo/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpiparo/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpiparo/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpiparo/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/dpiparo/root/contents/{+path}","compare_url":"https://api.github.com/repos/dpiparo/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpiparo/root/merges","archive_url":"https://api.github.com/repos/dpiparo/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpiparo/root/downloads","issues_url":"https://api.github.com/repos/dpiparo/root/issues{/number}","pulls_url":"https://api.github.com/repos/dpiparo/root/pulls{/number}","milestones_url":"https://api.github.com/repos/dpiparo/root/milestones{/number}","notifications_url":"https://api.github.com/repos/dpiparo/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpiparo/root/labels{/name}","releases_url":"https://api.github.com/repos/dpiparo/root/releases{/id}","deployments_url":"https://api.github.com/repos/dpiparo/root/deployments","created_at":"2017-04-17T06:48:51Z","updated_at":"2017-04-17T06:49:54Z","pushed_at":"2017-11-10T11:25:59Z","git_url":"git://github.com/dpiparo/root.git","ssh_url":"[email protected]:dpiparo/root.git","clone_url":"https://github.com/dpiparo/root.git","svn_url":"https://github.com/dpiparo/root","homepage":"","size":668803,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"root-project:master","ref":"master","sha":"6173990f9652d3dd5ad0b9063e85f1c09d88ddc3","user":{"login":"root-project","id":6450093,"avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"repo":{"id":10994345,"name":"root","full_name":"root-project/root","owner":{"login":"root-project","id":6450093,"avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/root-project/root","description":"The official ROOT repository","fork":false,"url":"https://api.github.com/repos/root-project/root","forks_url":"https://api.github.com/repos/root-project/root/forks","keys_url":"https://api.github.com/repos/root-project/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/root-project/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/root-project/root/teams","hooks_url":"https://api.github.com/repos/root-project/root/hooks","issue_events_url":"https://api.github.com/repos/root-project/root/issues/events{/number}","events_url":"https://api.github.com/repos/root-project/root/events","assignees_url":"https://api.github.com/repos/root-project/root/assignees{/user}","branches_url":"https://api.github.com/repos/root-project/root/branches{/branch}","tags_url":"https://api.github.com/repos/root-project/root/tags","blobs_url":"https://api.github.com/repos/root-project/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/root-project/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/root-project/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/root-project/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/root-project/root/statuses/{sha}","languages_url":"https://api.github.com/repos/root-project/root/languages","stargazers_url":"https://api.github.com/repos/root-project/root/stargazers","contributors_url":"https://api.github.com/repos/root-project/root/contributors","subscribers_url":"https://api.github.com/repos/root-project/root/subscribers","subscription_url":"https://api.github.com/repos/root-project/root/subscription","commits_url":"https://api.github.com/repos/root-project/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/root-project/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/root-project/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/root-project/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/root-project/root/contents/{+path}","compare_url":"https://api.github.com/repos/root-project/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/root-project/root/merges","archive_url":"https://api.github.com/repos/root-project/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/root-project/root/downloads","issues_url":"https://api.github.com/repos/root-project/root/issues{/number}","pulls_url":"https://api.github.com/repos/root-project/root/pulls{/number}","milestones_url":"https://api.github.com/repos/root-project/root/milestones{/number}","notifications_url":"https://api.github.com/repos/root-project/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/root-project/root/labels{/name}","releases_url":"https://api.github.com/repos/root-project/root/releases{/id}","deployments_url":"https://api.github.com/repos/root-project/root/deployments","created_at":"2013-06-27T10:46:59Z","updated_at":"2017-11-09T14:17:46Z","pushed_at":"2017-11-10T11:27:33Z","git_url":"git://github.com/root-project/root.git","ssh_url":"[email protected]:root-project/root.git","clone_url":"https://github.com/root-project/root.git","svn_url":"https://github.com/root-project/root","homepage":"","size":669318,"stargazers_count":427,"watchers_count":427,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":311,"mirror_url":null,"archived":false,"open_issues_count":44,"forks":311,"open_issues":44,"watchers":427,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/root-project/root/pulls/1308"},"html":{"href":"https://github.com/root-project/root/pull/1308"},"issue":{"href":"https://api.github.com/repos/root-project/root/issues/1308"},"comments":{"href":"https://api.github.com/repos/root-project/root/issues/1308/comments"},"review_comments":{"href":"https://api.github.com/repos/root-project/root/pulls/1308/comments"},"review_comment":{"href":"https://api.github.com/repos/root-project/root/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/root-project/root/pulls/1308/commits"},"statuses":{"href":"https://api.github.com/repos/root-project/root/statuses/67ed0714b966ef09094c33a6c142e6ea2f0dc11b"}},"author_association":"OWNER"}}
|
{
"id": 10994345,
"name": "root-project/root",
"url": "https://api.github.com/repos/root-project/root"
}
|
{
"id": 10999034,
"login": "bluehood",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10999034?",
"url": "https://api.github.com/users/bluehood"
}
|
{
"id": 6450093,
"login": "root-project",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6450093?",
"url": "https://api.github.com/orgs/root-project"
}
| 2017-11-10T12:02:46 |
6837481054
|
{"actor":{"display_login":"bluehood"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/comments/153542165","pull_request_review_id":79562780,"id":153542165,"diff_hunk":"@@ -0,0 +1,619 @@\n+//Variables\n+$primary-color: #59a0d7;\n+$primary-color-hover: #4089c1;\n+$background-color: #2b2d34;\n+$almost-white: #f7f7f8;\n+$lighter-gray: #dfe1e5;\n+$light-gray: #a0a0a0;\n+$medium-gray: #696b6e;\n+$dark-gray: #46484a;\n+$base-font-size: 16px;\n+$main-font: 'Montserrat', 'Helvetica Neue', Helvetica, Arial, sans-serif;\n+$headline-font: 'Montserrat', 'Helvetica Neue', Helvetica, Arial, sans-serif;\n+$serif-font: 'Droid Serif', Times, Georgia, serif;\n+\n+@mixin custom-button {\n+\tfont-size: .75rem;\n+\ttext-transform: uppercase;\n+\tfont-weight: 700;\n+\tborder-radius: .3rem;\n+}\n+\n+@mixin border-radius {\n+\tborder-radius: .3rem;\n+}\n+\n+//Global Styles\n+\n+body {\n+\tfont-family: $main-font;\n+\tfont-size: $base-font-size;\n+\tbackground-color: #ffffff;\n+\tcolor: $dark-gray;\n+}\n+\n+a {\n+\tcolor: $primary-color;\n+}\n+\n+h1 {\n+\tfont-family: $headline-font;\n+\tfont-size: 4rem;\n+\tfont-weight: 600;\n+}\n+\n+h2 {\n+\tfont-family: $headline-font;\n+\tfont-size: 2.8rem;\n+\tfont-weight: 500;\n+}\n+\n+h3 {\n+\tfont-family: $headline-font;\n+\tfont-size: 2rem;\n+\tfont-weight: 500;\n+}\n+\n+h4 {\n+\tfont-family: $headline-font;\n+\tfont-size: 1rem;\n+\tfont-weight: 700;\n+\ttext-transform: uppercase;\n+}\n+\n+p {\n+\tcolor: $medium-gray;\n+\tfont-size: .9rem;\n+}\n+\n+.divider {\n+\tdisplay: block;\n+\twidth: 6rem;\n+\theight: 0.3rem;\n+\tbackground-color: $lighter-gray;\n+\tmargin: 2rem auto;\n+}\n+\n+.form-control-custom {\n+\tborder: .1rem solid $lighter-gray;\n+\twidth: 100%;\n+\tpadding: 1rem;\n+\tfont-size: .9rem;\n+\tcolor: $medium-gray;\n+\t@include border-radius;\n+}\n+\n+.form-control-custom:focus {\n+\tborder: .1rem solid $primary-color;\n+\toutline: none;\n+}\n+\n+.emphasis {\n+\tfont-family: Georgia, Times, 'Times New Roman';\n+\tfont-style: italic;\n+\tcolor: $primary-color;\n+}\n+\n+.constrain-width {\n+\tmax-width: 45rem;\n+\tmargin: 0 auto;\n+}\n+\n+.rounded-corners {\n+\t@include border-radius;\n+}\n+\n+.pill-btn {\n+\tborder-radius: 499rem!important;\n+}\n+\n+.justify-center {\n+\tdisplay: flex; \n+\talign-items: center; \n+\tjustify-content: center;\n+}\n+\n+.alt-background {\n+\tbackground: $almost-white;\n+}\n+\n+.bg-primary {\n+\tbackground-color: $primary-color!important;\n+}\n+\n+.bg-secondary {\n+\tbackground-color: $dark-gray!important;\n+}\n+\n+.social {\n+\tmargin: 0 auto;\n+\tpadding: 0;\n+}\n+\n+.social li {\n+\tdisplay: inline-block;\n+}\n+\n+.social li a {\n+\tdisplay: block;\n+\twidth: 2.2rem;\n+\theight: 2.2rem;\n+\tmargin: .4rem .1rem;\n+\ttext-align: center;\n+\ttext-decoration: none;\n+\tbackground: #fff;\n+\tcolor: $medium-gray;\n+\tborder: .1rem solid $lighter-gray;\n+\tborder-radius: 499rem;\n+\tline-height: 1.5;\n+\tfont-size: 1.4rem;\n+}\n+\n+.social li a:hover {\n+\tcolor: $primary-color;\n+\tborder-color: $primary-color;\n+}\n+\n+//Custom Button Styles\n+\n+.btn-primary, .btn-outline-primary, .btn-secondary, .btn-outline-secondary, .btn-white, .btn-outline-white, .btn-success, .btn-outline-success, .btn-info, .btn-outline-info, .btn-warning, .btn-outline-warning, .btn-danger, .btn-outline-danger {\n+\t@include custom-button;\n+}\n+\n+.btn-outline-primary, .btn-outline-secondary, .btn-outline-white, .btn-outline-success, .btn-outline-info, .btn-outline-warning, .btn-outline-danger {\n+\tborder-width: 0.15rem;\n+}\n+\n+.btn-lg {\n+\tpadding: 1.1rem 2.5rem;\n+\tfont-size: .9rem;\n+}\n+\n+//Primary Button\n+\n+.btn-primary, .btn-primary:hover, .btn-primary:focus, .btn-primary:active {\n+\tbackground-color: $primary-color;\n+\tborder-color: $primary-color;\n+}\n+\n+.btn-primary:hover, .btn-primary:focus, .btn-primary:active {\n+\tbackground-color: $primary-color-hover;\n+\tborder-color: $primary-color-hover;\n+}\n+\n+.btn-outline-primary, .btn-outline-primary:visited {\n+\tcolor: $primary-color;\n+\tborder-color: $primary-color;\n+\tbackground: none;\n+}\n+.btn-outline-primary:hover, .btn-outline-primary:focus, .btn-outline-primary:active {\n+\tbackground-color: $primary-color;\n+\tborder-color: $primary-color;\n+\tcolor: #fff;\n+}\n+\n+//Secondary Button\n+\n+.btn-secondary {\n+ \tborder-color: $medium-gray;\n+ \tbackground-color: $medium-gray;\n+ \tcolor: #fff;\n+ }\n+ \n+.btn-secondary:hover, .btn-secondary:focus, .btn-secondary:active {\n+\t\tborder-color: $dark-gray;\n+\t\tbackground-color: $dark-gray;\n+\t\tcolor: #fff;\n+\t}\n+\n+.btn-outline-secondary, .btn-outline-secondary:visited {\n+\tcolor: $medium-gray;\n+\tborder-color: $medium-gray;\n+\tbackground: none;\n+}\n+.btn-outline-secondary:hover, .btn-outline-secondary:focus, .btn-outline-secondary:active {\n+\tborder-color: $medium-gray;\n+\tbackground: $medium-gray;\n+\tcolor: #fff;\n+}\n+\n+//White Button\n+\n+.btn-white {\n+ \tborder-color: #fff;\n+ \tbackground-color: #fff;\n+ \tcolor: $dark-gray;\n+ }\n+ \n+.btn-white:hover, .btn-white:focus, .btn-white:active {\n+\t\tborder-color: $lighter-gray;\n+\t\tbackground-color: $lighter-gray;\n+\t\tcolor: $dark-gray;\n+\t}\n+\n+.btn-outline-white, .btn-outline-white:visited {\n+\tbackground: none;\n+\tcolor: #fff;\n+\tborder-color: #fff;\n+}\n+.btn-outline-white:hover, .btn-outline-white:focus, .btn-outline-white:active {\n+\tcolor: $dark-gray;\n+\tbackground: #fff;\n+}\n+\n+.link-white, link-white:visited {\n+\t@include custom-button;\n+ \tborder: 0;\n+ \tcolor: #fff;\n+ }\n+ .link-white:hover, .link-white:focus, .link-white:active {\n+ \tcolor: $lighter-gray!important;\n+ }\n+\n+//Headers\n+\n+.navbar-custom {\n+\tbackground: transparent;\n+}\n+\n+a.navbar-brand, a.logo {\n+\tfont-family: $headline-font;\n+\tcolor: #fff!important;\n+\tfont-size: 2rem;\n+\tfont-weight: bold;\n+\tmargin-top: 0;\n+}\n+\n+a.logo:hover, a.logo:active, a.logo:focus {\n+\ttext-decoration: none;\n+}\n+\n+li.nav-item {\n+\t.btn {\n+\t\tmargin-top: .2rem;\n+\t\tmargin-left: .4rem;\n+\t}\n+\t.btn-white {\n+\t\tcolor: $dark-gray;\n+\t}\n+}\n+\n+.cover-1 {\n+\tbackground: $background-color url(../images/cover-bg-1.jpg) center;\n+\tbackground-size: cover;\n+\tmin-height: 50rem;\n+\theight: auto;\n+\tborder-radius: 0;\n+\twidth: 100%;\n+\tcolor: #fff;\n+\tpadding-top: 1rem;\n+\th1 {\n+\t\tfont-weight: 200;\n+\t}\n+\tp.lead {\n+\t\tmargin: 2rem auto;\n+\t\tcolor: rgba(255, 255, 255, .75);\n+\t}\n+\t.cover-container {\n+\t\tdisplay: table;\n+\t\theight: 100%;\n+\t\tmin-height: 44rem;\n+\t\tmargin: 0 auto;\n+\t}\n+}\n+\n+.cover-2 {\n+\tbackground: $background-color url(../images/cover-bg-1.jpg) center;\n+\tbackground: $background-color;\n+\tbackground-size: cover;\n+\tmin-height: 50rem;\n+\theight: auto;\n+\tborder-radius: 0;\n+\twidth: 100%;\n+\tcolor: #fff;\n+\tpadding-top: 1rem;\n+\tp.lead {\n+\t\tmargin: 2rem auto;\n+\t\tcolor: rgba(255, 255, 255, .75);\n+\t}\n+\t.cover-container {\n+\t\tdisplay: table;\n+\t\theight: 100%;\n+\t\tmin-height: 44rem;\n+\t\tmargin: 0 auto;\n+\t}\n+}\n+\n+.cover-5 {\n+\tbackground: $almost-white;\n+\tmin-height: 40rem;\n+\theight: auto;\n+\tborder-radius: 0;\n+\twidth: 100%;\n+\tcolor: #333;\n+\tpadding-top: 1rem;\n+\ta.navbar-brand {\n+\t\tcolor: #000!important;\n+\t}\n+\th1 {\n+\t\tcolor: #000;\n+\t\tfont-weight: 200;\n+\t}\n+\tp.lead {\n+\t\tmargin: 2rem auto;\n+\t\tcolor: $medium-gray;\n+\t\tfont-family: $serif-font;\n+\t\tfont-style: italic;\n+\t}\n+\t.cover-container {\n+\t\tdisplay: table;\n+\t\theight: 100%;\n+\t\tmin-height: 34rem;\n+\t\tmargin: 0 auto;\n+\t}\n+}\n+\n+.cover-inner {\n+\tdisplay: table-cell;\n+\tvertical-align: middle;\n+}\n+\n+//Features\n+\n+.features-1 {\n+\tpadding: 5rem 0;\n+\th2 {\n+\t\tmargin-top: 2rem;\n+\t}\n+\t.col-feature {\n+\t\tpadding-top: 2rem;\n+\t\tpadding-bottom: 2rem;\n+\t\t.rounded-circle {\n+\t\t\tmargin: 0 auto;\n+\t\t\tmargin-bottom: 2rem;\n+\t\t\twidth: 6rem;\n+\t\t\theight: 6rem;\n+\t\t\tbackground: none;\n+\t\t\tborder: .15rem solid $lighter-gray;\n+\t\t}\n+\t}\n+}\n+\n+.features-4 {\n+\tbackground: $background-color;\n+\tpadding: 5rem 0;\n+\th2 {\n+\t\tmargin-top: 2rem;\n+\t\tcolor: #fff;\n+\t}\n+\tp.lead {\n+\t\tcolor: $light-gray;\n+\t}\n+\t.col-feature {\n+\t\tpadding-top: 2rem;\n+\t\tpadding-bottom: 2rem;\n+\t\th4 {\n+\t\t\tcolor: #fff;\n+\t\t}\n+\t\tp {\n+\t\t\tcolor: $light-gray;\n+\t\t}\n+\t\t.rounded-circle {\n+\t\t\tmargin: 0 auto;\n+\t\t\tmargin-bottom: 2rem;\n+\t\t\twidth: 6rem;\n+\t\t\theight: 6rem;\n+\t\t\tbackground: none;\n+\t\t\tborder: .15rem solid $medium-gray;\n+\t\t\tcolor: #fff;\n+\t\t}\n+\t}\n+}\n+\n+//Content Blocks\n+\n+.content-1, .content-2, .content-4 {\n+\tbackground: #fff;\n+\tpadding-bottom: 0.1rem;\n+\t.container {\n+\t\tmargin: 5rem auto;\n+\t}\n+\t.full-width {\n+\t\twidth: 100%;\n+\t}\n+}\n+\n+//Call to Action\n+\n+.cta-2 {\n+\tcolor: $dark-gray;\n+\tpadding: 5rem 0;\n+\tp {\n+\t\tcolor: $medium-gray;\n+\t}\n+\tform.subscribe {\n+\t\tmax-width: 40rem;\n+\t\tmargin: 0 auto;\n+\t}\n+\t.btn {\n+\t\twidth: 100%;\n+\t}\n+}\n+\n+.cta-4 {\n+\tbackground: $background-color url(../images/cover-bg-3.jpg) center;\n+\tbackground: $background-color;\n+\tbackground-size: cover;\n+\tcolor: #fff;\n+\tpadding: 5rem 0;\n+\tmin-height: 50rem;\n+\tp {\n+\t\tcolor: rgba(255, 255, 255, .75);\n+\t}\n+\t.form-control-custom {\n+\t\tborder: none;\n+\t\tbackground: rgba(255, 255, 255, .2);\n+\t\tcolor: #fff;\n+\t}\n+\t.form-control-custom:focus {\n+\t\tborder: none;\n+\t\tbackground: rgba(255, 255, 255, .3);\n+\t\tcolor: #fff;\n+\t}\n+}\n+.cta-5 {\n+\tcolor: $dark-gray;\n+\tpadding: 4rem 0;\n+\tp {\n+\t\tcolor: $medium-gray;\n+\t}\n+\tform.subscribe {\n+\t\tmax-width: 40rem;\n+\t\tmargin: 0 auto;\n+\t}\n+\t.btn {\n+\t\twidth: 100%;\n+\t}\n+}\n+\n+//Contact\n+\n+.contact-1, .contact-2 {\n+\tpadding: 0 0 5rem 0;\n+\t.contact-details {\n+\t\tpadding-top: 5rem;\n+\t\tpadding-bottom: 1rem;\n+\t}\n+\th3 {\n+\t\tmargin-bottom: 0;\n+\t}\n+}\n+\n+#map {\n+\theight: 400px;\n+\twidth: 100%;\n+}\n+\n+\n+//Footers\n+\n+.footer-2 {\n+\tbackground: $background-color;\n+\tmin-height: 5rem;\n+\twidth: 100%;\n+\tcolor: #fff;\n+\tpadding-top: 2rem;\n+\tpadding-bottom: 1.5rem;\n+\ta.navbar-brand {\n+\t\tcolor: #fff!important;\n+\t}\n+\t.nav-footer {\n+\t\t.nav-link {\n+\t\t\tcolor: $lighter-gray;\n+\t\t}\n+\t\t.nav-link:hover {\n+\t\t\tcolor: $primary-color;\n+\t\t}\n+\t}\n+}\n+\n+.footer-3 {\n+\tbackground: $almost-white;\n+\twidth: 100%;\n+\tcolor: $dark-gray;\n+\tpadding-top: 1rem;\n+\tpadding-bottom: .5rem;\n+\t.container-fluid {\n+\t\tpadding: 0;\n+\t}\n+\t.divider {\n+\t\twidth: 100%;\n+\t\theight: .1rem;\n+\t\tmargin: .5rem 0 1.5rem 0;\n+\t}\n+\t.nav-footer {\n+\t\twidth: 100%;\n+\t\tpadding: 0;\n+\t\tdisplay: flex;\n+\t\tjustify-content: center;\n+\t\t.nav-link {\n+\t\t\tcolor: $medium-gray;\n+\t\t}\n+\t\t.nav-link:hover {\n+\t\t\tcolor: $primary-color;\n+\t\t}\n+\t}\n+\t.social li a {\n+\t\tbackground: none;\n+\t\tborder: none;\n+\t}\n+}\n+\n+.footer-4 {\n+\tbackground: $background-color;\n+\twidth: 100%;\n+\tcolor: #fff;\n+\tpadding-top: 4rem;\n+\tpadding-bottom: .5rem;\n+\t.container-fluid {\n+\t\tpadding: 0;\n+\t}\n+\t.divider {\n+\t\tbackground: $dark-gray;\n+\t\twidth: 100%;\n+\t\theight: .1rem;\n+\t\tmargin: 2rem 0 1.5rem 0;\n+\t}\n+\tul.nav-footer {\n+\t\tfloat: left!important;\n+\t\tpadding: 0;\n+\t\twidth: 100%;\n+\t\tli {\n+\t\t\tdisplay: block;\n+\t\t\tfloat: left;\n+\t\t\tmargin-top: .5rem;\n+\t\t\twidth: 100%;\n+\t\t}\n+\t\t.nav-link {\n+\t\t\tcolor: $light-gray;\n+\t\t\tpadding: 0;\n+\t\t}\n+\t\t.nav-link:hover {\n+\t\t\tcolor: $primary-color;\n+\t\t}\n+\t}\n+\t.copyright {\n+\t\tcolor: $light-gray;\n+\t}\n+\t.social li a {\n+\t\tbackground: none;\n+\t\tcolor: $almost-white;\n+\t\tborder: none;\n+\t}\n+\t.social li a:hover {\n+\t\tcolor: $primary-color;\n+\t}\n+\t@media screen and (max-width: 768px) {\n+\t\t.nav-footer {\n+\t\t\twidth: auto;\n+\t\t\tdisplay: inline;\n+\t\t}\n+\t}\n+}\n+\n+.nav-footer {\n+\tlist-style: none;\n+\tfloat: right;\n+\tli {","path":"2017/DmLaziuk/b2b/vendor/startup-ui-kit/sass/style.scss","position":607,"original_position":607,"commit_id":"bbe267d2d6a5617eb31167d7bba4f8917827b080","original_commit_id":"bbe267d2d6a5617eb31167d7bba4f8917827b080","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Rule declaration should be preceded by an empty line<br>Line should be indented with spaces, not tabs","created_at":"2017-11-28T16:16:53Z","updated_at":"2017-11-28T16:16:54Z","html_url":"https://github.com/rubyroidlabs/bsuir-courses/pull/731#discussion_r153542165","pull_request_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/731","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/comments/153542165"},"html":{"href":"https://github.com/rubyroidlabs/bsuir-courses/pull/731#discussion_r153542165"},"pull_request":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/731"}}},"pull_request":{"url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/731","id":155115966,"html_url":"https://github.com/rubyroidlabs/bsuir-courses/pull/731","diff_url":"https://github.com/rubyroidlabs/bsuir-courses/pull/731.diff","patch_url":"https://github.com/rubyroidlabs/bsuir-courses/pull/731.patch","issue_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/issues/731","number":731,"state":"open","locked":false,"title":"dm-homework-4","user":{"login":"dmlaziuk","id":32341162,"avatar_url":"https://avatars1.githubusercontent.com/u/32341162?v=4","gravatar_id":"","url":"https://api.github.com/users/dmlaziuk","html_url":"https://github.com/dmlaziuk","followers_url":"https://api.github.com/users/dmlaziuk/followers","following_url":"https://api.github.com/users/dmlaziuk/following{/other_user}","gists_url":"https://api.github.com/users/dmlaziuk/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlaziuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlaziuk/subscriptions","organizations_url":"https://api.github.com/users/dmlaziuk/orgs","repos_url":"https://api.github.com/users/dmlaziuk/repos","events_url":"https://api.github.com/users/dmlaziuk/events{/privacy}","received_events_url":"https://api.github.com/users/dmlaziuk/received_events","type":"User","site_admin":false},"body":"## Фамилия Имя\r\nЛозюк Дима\r\n\r\n## Email\r\[email protected]\r\n\r\n## Номер домашнего задания\r\n4\r\n\r\n## Ссылка на видео с демо работы\r\nhttp://recordit.co/9ogkqbJSKX\r\n\r\n## Комментарии\r\nнедоделал запуск задания в режиме обновления каждый день.\r\nОбновляется по клику на обменный курс.","created_at":"2017-11-28T16:15:31Z","updated_at":"2017-11-28T16:16:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"edd6f44d2bc6047b91dd993eff1a042ffd86cf71","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/731/commits","review_comments_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/731/comments","review_comment_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/issues/731/comments","statuses_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/statuses/bbe267d2d6a5617eb31167d7bba4f8917827b080","head":{"label":"dmlaziuk:dm-homework-4","ref":"dm-homework-4","sha":"bbe267d2d6a5617eb31167d7bba4f8917827b080","user":{"login":"dmlaziuk","id":32341162,"avatar_url":"https://avatars1.githubusercontent.com/u/32341162?v=4","gravatar_id":"","url":"https://api.github.com/users/dmlaziuk","html_url":"https://github.com/dmlaziuk","followers_url":"https://api.github.com/users/dmlaziuk/followers","following_url":"https://api.github.com/users/dmlaziuk/following{/other_user}","gists_url":"https://api.github.com/users/dmlaziuk/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlaziuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlaziuk/subscriptions","organizations_url":"https://api.github.com/users/dmlaziuk/orgs","repos_url":"https://api.github.com/users/dmlaziuk/repos","events_url":"https://api.github.com/users/dmlaziuk/events{/privacy}","received_events_url":"https://api.github.com/users/dmlaziuk/received_events","type":"User","site_admin":false},"repo":{"id":106292954,"name":"bsuir-courses","full_name":"dmlaziuk/bsuir-courses","owner":{"login":"dmlaziuk","id":32341162,"avatar_url":"https://avatars1.githubusercontent.com/u/32341162?v=4","gravatar_id":"","url":"https://api.github.com/users/dmlaziuk","html_url":"https://github.com/dmlaziuk","followers_url":"https://api.github.com/users/dmlaziuk/followers","following_url":"https://api.github.com/users/dmlaziuk/following{/other_user}","gists_url":"https://api.github.com/users/dmlaziuk/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlaziuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlaziuk/subscriptions","organizations_url":"https://api.github.com/users/dmlaziuk/orgs","repos_url":"https://api.github.com/users/dmlaziuk/repos","events_url":"https://api.github.com/users/dmlaziuk/events{/privacy}","received_events_url":"https://api.github.com/users/dmlaziuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmlaziuk/bsuir-courses","description":"This is common repository for all student to submit all their homeworks","fork":true,"url":"https://api.github.com/repos/dmlaziuk/bsuir-courses","forks_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/forks","keys_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/teams","hooks_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/hooks","issue_events_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/issues/events{/number}","events_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/events","assignees_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/assignees{/user}","branches_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/branches{/branch}","tags_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/tags","blobs_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/statuses/{sha}","languages_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/languages","stargazers_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/stargazers","contributors_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/contributors","subscribers_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/subscribers","subscription_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/subscription","commits_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/contents/{+path}","compare_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/merges","archive_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/downloads","issues_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/issues{/number}","pulls_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/pulls{/number}","milestones_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/milestones{/number}","notifications_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/labels{/name}","releases_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/releases{/id}","deployments_url":"https://api.github.com/repos/dmlaziuk/bsuir-courses/deployments","created_at":"2017-10-09T14:17:25Z","updated_at":"2017-10-09T14:17:29Z","pushed_at":"2017-11-28T16:12:09Z","git_url":"git://github.com/dmlaziuk/bsuir-courses.git","ssh_url":"[email protected]:dmlaziuk/bsuir-courses.git","clone_url":"https://github.com/dmlaziuk/bsuir-courses.git","svn_url":"https://github.com/dmlaziuk/bsuir-courses","homepage":null,"size":15063,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rubyroidlabs:master","ref":"master","sha":"7d038a1df4d3bd62492c89b531441f318c6a5c28","user":{"login":"rubyroidlabs","id":5137565,"avatar_url":"https://avatars1.githubusercontent.com/u/5137565?v=4","gravatar_id":"","url":"https://api.github.com/users/rubyroidlabs","html_url":"https://github.com/rubyroidlabs","followers_url":"https://api.github.com/users/rubyroidlabs/followers","following_url":"https://api.github.com/users/rubyroidlabs/following{/other_user}","gists_url":"https://api.github.com/users/rubyroidlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rubyroidlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubyroidlabs/subscriptions","organizations_url":"https://api.github.com/users/rubyroidlabs/orgs","repos_url":"https://api.github.com/users/rubyroidlabs/repos","events_url":"https://api.github.com/users/rubyroidlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rubyroidlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":14405320,"name":"bsuir-courses","full_name":"rubyroidlabs/bsuir-courses","owner":{"login":"rubyroidlabs","id":5137565,"avatar_url":"https://avatars1.githubusercontent.com/u/5137565?v=4","gravatar_id":"","url":"https://api.github.com/users/rubyroidlabs","html_url":"https://github.com/rubyroidlabs","followers_url":"https://api.github.com/users/rubyroidlabs/followers","following_url":"https://api.github.com/users/rubyroidlabs/following{/other_user}","gists_url":"https://api.github.com/users/rubyroidlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rubyroidlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubyroidlabs/subscriptions","organizations_url":"https://api.github.com/users/rubyroidlabs/orgs","repos_url":"https://api.github.com/users/rubyroidlabs/repos","events_url":"https://api.github.com/users/rubyroidlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rubyroidlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rubyroidlabs/bsuir-courses","description":"This is common repository for all student to submit all their homeworks","fork":false,"url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses","forks_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/forks","keys_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/teams","hooks_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/hooks","issue_events_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/issues/events{/number}","events_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/events","assignees_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/assignees{/user}","branches_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/branches{/branch}","tags_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/tags","blobs_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/statuses/{sha}","languages_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/languages","stargazers_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/stargazers","contributors_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/contributors","subscribers_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/subscribers","subscription_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/subscription","commits_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/contents/{+path}","compare_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/merges","archive_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/downloads","issues_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/issues{/number}","pulls_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls{/number}","milestones_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/milestones{/number}","notifications_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/labels{/name}","releases_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/releases{/id}","deployments_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/deployments","created_at":"2013-11-14T19:55:12Z","updated_at":"2017-10-23T16:01:22Z","pushed_at":"2017-11-28T16:15:32Z","git_url":"git://github.com/rubyroidlabs/bsuir-courses.git","ssh_url":"[email protected]:rubyroidlabs/bsuir-courses.git","clone_url":"https://github.com/rubyroidlabs/bsuir-courses.git","svn_url":"https://github.com/rubyroidlabs/bsuir-courses","homepage":null,"size":14981,"stargazers_count":38,"watchers_count":38,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":216,"mirror_url":null,"archived":false,"open_issues_count":106,"forks":216,"open_issues":106,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/731"},"html":{"href":"https://github.com/rubyroidlabs/bsuir-courses/pull/731"},"issue":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/issues/731"},"comments":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/issues/731/comments"},"review_comments":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/731/comments"},"review_comment":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/731/commits"},"statuses":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/statuses/bbe267d2d6a5617eb31167d7bba4f8917827b080"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 14405320,
"name": "rubyroidlabs/bsuir-courses",
"url": "https://api.github.com/repos/rubyroidlabs/bsuir-courses"
}
|
{
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
}
|
{
"id": 5137565,
"login": "rubyroidlabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5137565?",
"url": "https://api.github.com/orgs/rubyroidlabs"
}
| 2017-11-28T16:16:53 |
6913799336
|
{"actor":{"display_login":"houndci-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/comments/153248529","pull_request_review_id":79227366,"id":153248529,"diff_hunk":"@@ -0,0 +1,18 @@\n+// This is a manifest file that'll be compiled into application.js, which will include all the files\n+// listed below.\n+//\n+// Any JavaScript/Coffee file within this directory, lib/assets/javascripts, or any plugin's\n+// vendor/assets/javascripts directory can be referenced here using a relative path.\n+//\n+// It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the\n+// compiled file. JavaScript code in this file should be added after the last require_* statement.\n+//\n+// Read Sprockets README (https://github.com/rails/sprockets#sprockets-directives) for details","path":"2017/VladKharitonovitch/hm-4/app/assets/javascripts/application.js","position":10,"original_position":10,"commit_id":"c9315595a887ef13160f12d24464fd3ae25f09e4","original_commit_id":"c9315595a887ef13160f12d24464fd3ae25f09e4","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Line is too long.","created_at":"2017-11-27T16:30:21Z","updated_at":"2017-11-27T16:30:22Z","html_url":"https://github.com/rubyroidlabs/bsuir-courses/pull/727#discussion_r153248529","pull_request_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/727","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/comments/153248529"},"html":{"href":"https://github.com/rubyroidlabs/bsuir-courses/pull/727#discussion_r153248529"},"pull_request":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/727"}}},"pull_request":{"url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/727","id":154855597,"html_url":"https://github.com/rubyroidlabs/bsuir-courses/pull/727","diff_url":"https://github.com/rubyroidlabs/bsuir-courses/pull/727.diff","patch_url":"https://github.com/rubyroidlabs/bsuir-courses/pull/727.patch","issue_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/issues/727","number":727,"state":"open","locked":false,"title":"hm4","user":{"login":"MoRain666","id":30127467,"avatar_url":"https://avatars3.githubusercontent.com/u/30127467?v=4","gravatar_id":"","url":"https://api.github.com/users/MoRain666","html_url":"https://github.com/MoRain666","followers_url":"https://api.github.com/users/MoRain666/followers","following_url":"https://api.github.com/users/MoRain666/following{/other_user}","gists_url":"https://api.github.com/users/MoRain666/gists{/gist_id}","starred_url":"https://api.github.com/users/MoRain666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoRain666/subscriptions","organizations_url":"https://api.github.com/users/MoRain666/orgs","repos_url":"https://api.github.com/users/MoRain666/repos","events_url":"https://api.github.com/users/MoRain666/events{/privacy}","received_events_url":"https://api.github.com/users/MoRain666/received_events","type":"User","site_admin":false},"body":"## Фамилия Имя\r\nХаритонович Владислав\r\n\r\n## Email\r\[email protected]\r\n\r\n## Номер домашнего задания\r\n4\r\n\r\n## Ссылка на видео с демо работы\r\nhttps://youtu.be/80OAlZW79D8\r\n\r\n\r\n## Комментарии\r\n2 лвла","created_at":"2017-11-27T16:29:33Z","updated_at":"2017-11-27T16:30:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2344075290edbf2d851ab6de76b93a44eca8abf6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/727/commits","review_comments_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/727/comments","review_comment_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/issues/727/comments","statuses_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/statuses/c9315595a887ef13160f12d24464fd3ae25f09e4","head":{"label":"MoRain666:hm4","ref":"hm4","sha":"c9315595a887ef13160f12d24464fd3ae25f09e4","user":{"login":"MoRain666","id":30127467,"avatar_url":"https://avatars3.githubusercontent.com/u/30127467?v=4","gravatar_id":"","url":"https://api.github.com/users/MoRain666","html_url":"https://github.com/MoRain666","followers_url":"https://api.github.com/users/MoRain666/followers","following_url":"https://api.github.com/users/MoRain666/following{/other_user}","gists_url":"https://api.github.com/users/MoRain666/gists{/gist_id}","starred_url":"https://api.github.com/users/MoRain666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoRain666/subscriptions","organizations_url":"https://api.github.com/users/MoRain666/orgs","repos_url":"https://api.github.com/users/MoRain666/repos","events_url":"https://api.github.com/users/MoRain666/events{/privacy}","received_events_url":"https://api.github.com/users/MoRain666/received_events","type":"User","site_admin":false},"repo":{"id":106037079,"name":"bsuir-courses","full_name":"MoRain666/bsuir-courses","owner":{"login":"MoRain666","id":30127467,"avatar_url":"https://avatars3.githubusercontent.com/u/30127467?v=4","gravatar_id":"","url":"https://api.github.com/users/MoRain666","html_url":"https://github.com/MoRain666","followers_url":"https://api.github.com/users/MoRain666/followers","following_url":"https://api.github.com/users/MoRain666/following{/other_user}","gists_url":"https://api.github.com/users/MoRain666/gists{/gist_id}","starred_url":"https://api.github.com/users/MoRain666/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoRain666/subscriptions","organizations_url":"https://api.github.com/users/MoRain666/orgs","repos_url":"https://api.github.com/users/MoRain666/repos","events_url":"https://api.github.com/users/MoRain666/events{/privacy}","received_events_url":"https://api.github.com/users/MoRain666/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MoRain666/bsuir-courses","description":"This is common repository for all student to submit all their homeworks","fork":true,"url":"https://api.github.com/repos/MoRain666/bsuir-courses","forks_url":"https://api.github.com/repos/MoRain666/bsuir-courses/forks","keys_url":"https://api.github.com/repos/MoRain666/bsuir-courses/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MoRain666/bsuir-courses/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MoRain666/bsuir-courses/teams","hooks_url":"https://api.github.com/repos/MoRain666/bsuir-courses/hooks","issue_events_url":"https://api.github.com/repos/MoRain666/bsuir-courses/issues/events{/number}","events_url":"https://api.github.com/repos/MoRain666/bsuir-courses/events","assignees_url":"https://api.github.com/repos/MoRain666/bsuir-courses/assignees{/user}","branches_url":"https://api.github.com/repos/MoRain666/bsuir-courses/branches{/branch}","tags_url":"https://api.github.com/repos/MoRain666/bsuir-courses/tags","blobs_url":"https://api.github.com/repos/MoRain666/bsuir-courses/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MoRain666/bsuir-courses/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MoRain666/bsuir-courses/git/refs{/sha}","trees_url":"https://api.github.com/repos/MoRain666/bsuir-courses/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MoRain666/bsuir-courses/statuses/{sha}","languages_url":"https://api.github.com/repos/MoRain666/bsuir-courses/languages","stargazers_url":"https://api.github.com/repos/MoRain666/bsuir-courses/stargazers","contributors_url":"https://api.github.com/repos/MoRain666/bsuir-courses/contributors","subscribers_url":"https://api.github.com/repos/MoRain666/bsuir-courses/subscribers","subscription_url":"https://api.github.com/repos/MoRain666/bsuir-courses/subscription","commits_url":"https://api.github.com/repos/MoRain666/bsuir-courses/commits{/sha}","git_commits_url":"https://api.github.com/repos/MoRain666/bsuir-courses/git/commits{/sha}","comments_url":"https://api.github.com/repos/MoRain666/bsuir-courses/comments{/number}","issue_comment_url":"https://api.github.com/repos/MoRain666/bsuir-courses/issues/comments{/number}","contents_url":"https://api.github.com/repos/MoRain666/bsuir-courses/contents/{+path}","compare_url":"https://api.github.com/repos/MoRain666/bsuir-courses/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MoRain666/bsuir-courses/merges","archive_url":"https://api.github.com/repos/MoRain666/bsuir-courses/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MoRain666/bsuir-courses/downloads","issues_url":"https://api.github.com/repos/MoRain666/bsuir-courses/issues{/number}","pulls_url":"https://api.github.com/repos/MoRain666/bsuir-courses/pulls{/number}","milestones_url":"https://api.github.com/repos/MoRain666/bsuir-courses/milestones{/number}","notifications_url":"https://api.github.com/repos/MoRain666/bsuir-courses/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MoRain666/bsuir-courses/labels{/name}","releases_url":"https://api.github.com/repos/MoRain666/bsuir-courses/releases{/id}","deployments_url":"https://api.github.com/repos/MoRain666/bsuir-courses/deployments","created_at":"2017-10-06T18:24:39Z","updated_at":"2017-10-06T18:24:42Z","pushed_at":"2017-11-27T16:27:23Z","git_url":"git://github.com/MoRain666/bsuir-courses.git","ssh_url":"[email protected]:MoRain666/bsuir-courses.git","clone_url":"https://github.com/MoRain666/bsuir-courses.git","svn_url":"https://github.com/MoRain666/bsuir-courses","homepage":null,"size":14483,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rubyroidlabs:master","ref":"master","sha":"7d038a1df4d3bd62492c89b531441f318c6a5c28","user":{"login":"rubyroidlabs","id":5137565,"avatar_url":"https://avatars1.githubusercontent.com/u/5137565?v=4","gravatar_id":"","url":"https://api.github.com/users/rubyroidlabs","html_url":"https://github.com/rubyroidlabs","followers_url":"https://api.github.com/users/rubyroidlabs/followers","following_url":"https://api.github.com/users/rubyroidlabs/following{/other_user}","gists_url":"https://api.github.com/users/rubyroidlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rubyroidlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubyroidlabs/subscriptions","organizations_url":"https://api.github.com/users/rubyroidlabs/orgs","repos_url":"https://api.github.com/users/rubyroidlabs/repos","events_url":"https://api.github.com/users/rubyroidlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rubyroidlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":14405320,"name":"bsuir-courses","full_name":"rubyroidlabs/bsuir-courses","owner":{"login":"rubyroidlabs","id":5137565,"avatar_url":"https://avatars1.githubusercontent.com/u/5137565?v=4","gravatar_id":"","url":"https://api.github.com/users/rubyroidlabs","html_url":"https://github.com/rubyroidlabs","followers_url":"https://api.github.com/users/rubyroidlabs/followers","following_url":"https://api.github.com/users/rubyroidlabs/following{/other_user}","gists_url":"https://api.github.com/users/rubyroidlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rubyroidlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubyroidlabs/subscriptions","organizations_url":"https://api.github.com/users/rubyroidlabs/orgs","repos_url":"https://api.github.com/users/rubyroidlabs/repos","events_url":"https://api.github.com/users/rubyroidlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rubyroidlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rubyroidlabs/bsuir-courses","description":"This is common repository for all student to submit all their homeworks","fork":false,"url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses","forks_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/forks","keys_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/teams","hooks_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/hooks","issue_events_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/issues/events{/number}","events_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/events","assignees_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/assignees{/user}","branches_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/branches{/branch}","tags_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/tags","blobs_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/statuses/{sha}","languages_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/languages","stargazers_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/stargazers","contributors_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/contributors","subscribers_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/subscribers","subscription_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/subscription","commits_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/contents/{+path}","compare_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/merges","archive_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/downloads","issues_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/issues{/number}","pulls_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls{/number}","milestones_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/milestones{/number}","notifications_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/labels{/name}","releases_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/releases{/id}","deployments_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/deployments","created_at":"2013-11-14T19:55:12Z","updated_at":"2017-10-23T16:01:22Z","pushed_at":"2017-11-27T16:29:35Z","git_url":"git://github.com/rubyroidlabs/bsuir-courses.git","ssh_url":"[email protected]:rubyroidlabs/bsuir-courses.git","clone_url":"https://github.com/rubyroidlabs/bsuir-courses.git","svn_url":"https://github.com/rubyroidlabs/bsuir-courses","homepage":null,"size":14981,"stargazers_count":38,"watchers_count":38,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":216,"mirror_url":null,"archived":false,"open_issues_count":102,"forks":216,"open_issues":102,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/727"},"html":{"href":"https://github.com/rubyroidlabs/bsuir-courses/pull/727"},"issue":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/issues/727"},"comments":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/issues/727/comments"},"review_comments":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/727/comments"},"review_comment":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/727/commits"},"statuses":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/statuses/c9315595a887ef13160f12d24464fd3ae25f09e4"}},"author_association":"NONE"}}
|
{
"id": 14405320,
"name": "rubyroidlabs/bsuir-courses",
"url": "https://api.github.com/repos/rubyroidlabs/bsuir-courses"
}
|
{
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
}
|
{
"id": 5137565,
"login": "rubyroidlabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5137565?",
"url": "https://api.github.com/orgs/rubyroidlabs"
}
| 2017-11-27T16:30:21 |
6908010586
|
{"actor":{"display_login":"houndci-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/comments/145401826","pull_request_review_id":70195065,"id":145401826,"diff_hunk":"@@ -0,0 +1,35 @@\n+require 'mechanize'","path":"2017/VladislavStukov/2/SiteParser.rb","position":1,"original_position":1,"commit_id":"4936d17e7edfa32c647adfbe0723319f8cf95672","original_commit_id":"4936d17e7edfa32c647adfbe0723319f8cf95672","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"The name of this source file (SiteParser.rb) should use snake_case.","created_at":"2017-10-18T12:43:40Z","updated_at":"2017-10-18T12:43:41Z","html_url":"https://github.com/rubyroidlabs/bsuir-courses/pull/604#discussion_r145401826","pull_request_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/604","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/comments/145401826"},"html":{"href":"https://github.com/rubyroidlabs/bsuir-courses/pull/604#discussion_r145401826"},"pull_request":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/604"}}},"pull_request":{"url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/604","id":147289910,"html_url":"https://github.com/rubyroidlabs/bsuir-courses/pull/604","diff_url":"https://github.com/rubyroidlabs/bsuir-courses/pull/604.diff","patch_url":"https://github.com/rubyroidlabs/bsuir-courses/pull/604.patch","issue_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/issues/604","number":604,"state":"open","locked":false,"title":"Homework-2","user":{"login":"VladSt90","id":22668070,"avatar_url":"https://avatars2.githubusercontent.com/u/22668070?v=4","gravatar_id":"","url":"https://api.github.com/users/VladSt90","html_url":"https://github.com/VladSt90","followers_url":"https://api.github.com/users/VladSt90/followers","following_url":"https://api.github.com/users/VladSt90/following{/other_user}","gists_url":"https://api.github.com/users/VladSt90/gists{/gist_id}","starred_url":"https://api.github.com/users/VladSt90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladSt90/subscriptions","organizations_url":"https://api.github.com/users/VladSt90/orgs","repos_url":"https://api.github.com/users/VladSt90/repos","events_url":"https://api.github.com/users/VladSt90/events{/privacy}","received_events_url":"https://api.github.com/users/VladSt90/received_events","type":"User","site_admin":false},"body":"## Фамилия Имя\r\nСтуков Владислав\r\n\r\n## Email\r\[email protected]\r\n\r\n## Номер домашнего задания\r\n2\r\n\r\n## Ссылка на видео с демо работы\r\nhttp://recordit.co/ZVPW2zAi6U\r\n\r\n## Комментарии\r\nПрога учитывает всех участников батла\r\n","created_at":"2017-10-18T12:43:31Z","updated_at":"2017-10-18T12:43:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"554f39adef58b36e9883fb4d0a931fb572290591","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/604/commits","review_comments_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/604/comments","review_comment_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/issues/604/comments","statuses_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/statuses/4936d17e7edfa32c647adfbe0723319f8cf95672","head":{"label":"VladSt90:homework-2","ref":"homework-2","sha":"4936d17e7edfa32c647adfbe0723319f8cf95672","user":{"login":"VladSt90","id":22668070,"avatar_url":"https://avatars2.githubusercontent.com/u/22668070?v=4","gravatar_id":"","url":"https://api.github.com/users/VladSt90","html_url":"https://github.com/VladSt90","followers_url":"https://api.github.com/users/VladSt90/followers","following_url":"https://api.github.com/users/VladSt90/following{/other_user}","gists_url":"https://api.github.com/users/VladSt90/gists{/gist_id}","starred_url":"https://api.github.com/users/VladSt90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladSt90/subscriptions","organizations_url":"https://api.github.com/users/VladSt90/orgs","repos_url":"https://api.github.com/users/VladSt90/repos","events_url":"https://api.github.com/users/VladSt90/events{/privacy}","received_events_url":"https://api.github.com/users/VladSt90/received_events","type":"User","site_admin":false},"repo":{"id":106748166,"name":"bsuir-courses","full_name":"VladSt90/bsuir-courses","owner":{"login":"VladSt90","id":22668070,"avatar_url":"https://avatars2.githubusercontent.com/u/22668070?v=4","gravatar_id":"","url":"https://api.github.com/users/VladSt90","html_url":"https://github.com/VladSt90","followers_url":"https://api.github.com/users/VladSt90/followers","following_url":"https://api.github.com/users/VladSt90/following{/other_user}","gists_url":"https://api.github.com/users/VladSt90/gists{/gist_id}","starred_url":"https://api.github.com/users/VladSt90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladSt90/subscriptions","organizations_url":"https://api.github.com/users/VladSt90/orgs","repos_url":"https://api.github.com/users/VladSt90/repos","events_url":"https://api.github.com/users/VladSt90/events{/privacy}","received_events_url":"https://api.github.com/users/VladSt90/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VladSt90/bsuir-courses","description":"This is common repository for all student to submit all their homeworks","fork":true,"url":"https://api.github.com/repos/VladSt90/bsuir-courses","forks_url":"https://api.github.com/repos/VladSt90/bsuir-courses/forks","keys_url":"https://api.github.com/repos/VladSt90/bsuir-courses/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VladSt90/bsuir-courses/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VladSt90/bsuir-courses/teams","hooks_url":"https://api.github.com/repos/VladSt90/bsuir-courses/hooks","issue_events_url":"https://api.github.com/repos/VladSt90/bsuir-courses/issues/events{/number}","events_url":"https://api.github.com/repos/VladSt90/bsuir-courses/events","assignees_url":"https://api.github.com/repos/VladSt90/bsuir-courses/assignees{/user}","branches_url":"https://api.github.com/repos/VladSt90/bsuir-courses/branches{/branch}","tags_url":"https://api.github.com/repos/VladSt90/bsuir-courses/tags","blobs_url":"https://api.github.com/repos/VladSt90/bsuir-courses/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VladSt90/bsuir-courses/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VladSt90/bsuir-courses/git/refs{/sha}","trees_url":"https://api.github.com/repos/VladSt90/bsuir-courses/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VladSt90/bsuir-courses/statuses/{sha}","languages_url":"https://api.github.com/repos/VladSt90/bsuir-courses/languages","stargazers_url":"https://api.github.com/repos/VladSt90/bsuir-courses/stargazers","contributors_url":"https://api.github.com/repos/VladSt90/bsuir-courses/contributors","subscribers_url":"https://api.github.com/repos/VladSt90/bsuir-courses/subscribers","subscription_url":"https://api.github.com/repos/VladSt90/bsuir-courses/subscription","commits_url":"https://api.github.com/repos/VladSt90/bsuir-courses/commits{/sha}","git_commits_url":"https://api.github.com/repos/VladSt90/bsuir-courses/git/commits{/sha}","comments_url":"https://api.github.com/repos/VladSt90/bsuir-courses/comments{/number}","issue_comment_url":"https://api.github.com/repos/VladSt90/bsuir-courses/issues/comments{/number}","contents_url":"https://api.github.com/repos/VladSt90/bsuir-courses/contents/{+path}","compare_url":"https://api.github.com/repos/VladSt90/bsuir-courses/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VladSt90/bsuir-courses/merges","archive_url":"https://api.github.com/repos/VladSt90/bsuir-courses/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VladSt90/bsuir-courses/downloads","issues_url":"https://api.github.com/repos/VladSt90/bsuir-courses/issues{/number}","pulls_url":"https://api.github.com/repos/VladSt90/bsuir-courses/pulls{/number}","milestones_url":"https://api.github.com/repos/VladSt90/bsuir-courses/milestones{/number}","notifications_url":"https://api.github.com/repos/VladSt90/bsuir-courses/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VladSt90/bsuir-courses/labels{/name}","releases_url":"https://api.github.com/repos/VladSt90/bsuir-courses/releases{/id}","deployments_url":"https://api.github.com/repos/VladSt90/bsuir-courses/deployments","created_at":"2017-10-12T21:39:51Z","updated_at":"2017-10-12T21:39:54Z","pushed_at":"2017-10-18T12:36:16Z","git_url":"git://github.com/VladSt90/bsuir-courses.git","ssh_url":"[email protected]:VladSt90/bsuir-courses.git","clone_url":"https://github.com/VladSt90/bsuir-courses.git","svn_url":"https://github.com/VladSt90/bsuir-courses","homepage":null,"size":14487,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rubyroidlabs:master","ref":"master","sha":"80330cc74f36a98bbb5d125225a21bfe1de915c1","user":{"login":"rubyroidlabs","id":5137565,"avatar_url":"https://avatars1.githubusercontent.com/u/5137565?v=4","gravatar_id":"","url":"https://api.github.com/users/rubyroidlabs","html_url":"https://github.com/rubyroidlabs","followers_url":"https://api.github.com/users/rubyroidlabs/followers","following_url":"https://api.github.com/users/rubyroidlabs/following{/other_user}","gists_url":"https://api.github.com/users/rubyroidlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rubyroidlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubyroidlabs/subscriptions","organizations_url":"https://api.github.com/users/rubyroidlabs/orgs","repos_url":"https://api.github.com/users/rubyroidlabs/repos","events_url":"https://api.github.com/users/rubyroidlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rubyroidlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":14405320,"name":"bsuir-courses","full_name":"rubyroidlabs/bsuir-courses","owner":{"login":"rubyroidlabs","id":5137565,"avatar_url":"https://avatars1.githubusercontent.com/u/5137565?v=4","gravatar_id":"","url":"https://api.github.com/users/rubyroidlabs","html_url":"https://github.com/rubyroidlabs","followers_url":"https://api.github.com/users/rubyroidlabs/followers","following_url":"https://api.github.com/users/rubyroidlabs/following{/other_user}","gists_url":"https://api.github.com/users/rubyroidlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rubyroidlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubyroidlabs/subscriptions","organizations_url":"https://api.github.com/users/rubyroidlabs/orgs","repos_url":"https://api.github.com/users/rubyroidlabs/repos","events_url":"https://api.github.com/users/rubyroidlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rubyroidlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rubyroidlabs/bsuir-courses","description":"This is common repository for all student to submit all their homeworks","fork":false,"url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses","forks_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/forks","keys_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/teams","hooks_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/hooks","issue_events_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/issues/events{/number}","events_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/events","assignees_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/assignees{/user}","branches_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/branches{/branch}","tags_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/tags","blobs_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/statuses/{sha}","languages_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/languages","stargazers_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/stargazers","contributors_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/contributors","subscribers_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/subscribers","subscription_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/subscription","commits_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/contents/{+path}","compare_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/merges","archive_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/downloads","issues_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/issues{/number}","pulls_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls{/number}","milestones_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/milestones{/number}","notifications_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/labels{/name}","releases_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/releases{/id}","deployments_url":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/deployments","created_at":"2013-11-14T19:55:12Z","updated_at":"2017-10-15T11:09:28Z","pushed_at":"2017-10-18T12:43:32Z","git_url":"git://github.com/rubyroidlabs/bsuir-courses.git","ssh_url":"[email protected]:rubyroidlabs/bsuir-courses.git","clone_url":"https://github.com/rubyroidlabs/bsuir-courses.git","svn_url":"https://github.com/rubyroidlabs/bsuir-courses","homepage":null,"size":14428,"stargazers_count":37,"watchers_count":37,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":213,"mirror_url":null,"open_issues_count":55,"forks":213,"open_issues":55,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/604"},"html":{"href":"https://github.com/rubyroidlabs/bsuir-courses/pull/604"},"issue":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/issues/604"},"comments":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/issues/604/comments"},"review_comments":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/604/comments"},"review_comment":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/pulls/604/commits"},"statuses":{"href":"https://api.github.com/repos/rubyroidlabs/bsuir-courses/statuses/4936d17e7edfa32c647adfbe0723319f8cf95672"}},"author_association":"NONE"}}
|
{
"id": 14405320,
"name": "rubyroidlabs/bsuir-courses",
"url": "https://api.github.com/repos/rubyroidlabs/bsuir-courses"
}
|
{
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
}
|
{
"id": 5137565,
"login": "rubyroidlabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5137565?",
"url": "https://api.github.com/orgs/rubyroidlabs"
}
| 2017-10-18T12:43:40 |
6732751327
|
{"actor":{"display_login":"houndci-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments/120087245","pull_request_review_id":42021003,"id":120087245,"diff_hunk":"@@ -442,4 +446,92 @@ public function composeBean($request, $mode = self::COMPOSE_BEAN_MODE_UNDEFINED)\n }\n \n }\n+\n+ /**\n+ * @throws SugarControllerException\n+ */\n+ public function action_MarkEmails () {\n+ $request = $_REQUEST;\n+\n+ // validate the request\n+\n+ if(!isset($request['inbound_email_record']) || !$request['inbound_email_record']) {\n+ throw new SugarControllerException('No Inbound Email record in request');\n+ }\n+\n+ if(!isset($request['folder']) || !$request['folder']) {\n+ throw new SugarControllerException('No Inbound Email folder in request');","path":"modules/Emails/controller.php","position":29,"original_position":29,"commit_id":"f8d97bc20d1aed0fd23e70d148bb163d326d2fdd","original_commit_id":"f8d97bc20d1aed0fd23e70d148bb163d326d2fdd","user":{"login":"gymad","id":13831178,"avatar_url":"https://avatars3.githubusercontent.com/u/13831178?v=3","gravatar_id":"","url":"https://api.github.com/users/gymad","html_url":"https://github.com/gymad","followers_url":"https://api.github.com/users/gymad/followers","following_url":"https://api.github.com/users/gymad/following{/other_user}","gists_url":"https://api.github.com/users/gymad/gists{/gist_id}","starred_url":"https://api.github.com/users/gymad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gymad/subscriptions","organizations_url":"https://api.github.com/users/gymad/orgs","repos_url":"https://api.github.com/users/gymad/repos","events_url":"https://api.github.com/users/gymad/events{/privacy}","received_events_url":"https://api.github.com/users/gymad/received_events","type":"User","site_admin":false},"body":"added","created_at":"2017-06-05T11:08:33Z","updated_at":"2017-06-05T11:08:33Z","html_url":"https://github.com/salesagility/SuiteCRM/pull/3648#discussion_r120087245","pull_request_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/3648","_links":{"self":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments/120087245"},"html":{"href":"https://github.com/salesagility/SuiteCRM/pull/3648#discussion_r120087245"},"pull_request":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/3648"}}},"pull_request":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/3648","id":123942852,"html_url":"https://github.com/salesagility/SuiteCRM/pull/3648","diff_url":"https://github.com/salesagility/SuiteCRM/pull/3648.diff","patch_url":"https://github.com/salesagility/SuiteCRM/pull/3648.patch","issue_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/3648","number":3648,"state":"open","locked":false,"title":"Scrm 585 flag btn","user":{"login":"gymad","id":13831178,"avatar_url":"https://avatars3.githubusercontent.com/u/13831178?v=3","gravatar_id":"","url":"https://api.github.com/users/gymad","html_url":"https://github.com/gymad","followers_url":"https://api.github.com/users/gymad/followers","following_url":"https://api.github.com/users/gymad/following{/other_user}","gists_url":"https://api.github.com/users/gymad/gists{/gist_id}","starred_url":"https://api.github.com/users/gymad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gymad/subscriptions","organizations_url":"https://api.github.com/users/gymad/orgs","repos_url":"https://api.github.com/users/gymad/repos","events_url":"https://api.github.com/users/gymad/events{/privacy}","received_events_url":"https://api.github.com/users/gymad/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here unless your commit contains the issue number -->\r\nAdding: \r\n- mark as flag buttons to bulk action onto email list view\r\n- tidy up indicators style\r\n- fix uids at checkboxes\r\n(ref: SCRM-585, #3610 )\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\nMark as Flag/Unflagged/Read/Unread function are missing\r\n\r\n## How To Test This\r\n<!--- Please describe in detail how to test your changes. -->\r\n- rebuild style.css (sass)\r\n- QRR\r\n- check emails list view => bulk action => \"marks as ...\" menuitems\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n### Final checklist\r\n<!--- Go over all the following points and check all the boxes that apply. --->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --->\r\n- [ ] My code follows the code style of this project found [here](https://suitecrm.com/wiki/index.php/Coding_Standards).\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have read the [**How to Contribute**](https://suitecrm.com/wiki/index.php/Contributing_to_SuiteCRM) guidelines.\r\n\r\n<!--- Your pull request will be tested via Travis CI to automatically indicate that your changes do not prevent compilation. --->\r\n\r\n<!--- If it reports back that there are problems, you can log into the Travis system and check the log report for your pull request to see what the problem was. --->","created_at":"2017-06-05T09:28:45Z","updated_at":"2017-06-05T11:08:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24b6167be4d822be06d413722673db6b7d3e2564","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/3648/commits","review_comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/3648/comments","review_comment_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/3648/comments","statuses_url":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/f8d97bc20d1aed0fd23e70d148bb163d326d2fdd","head":{"label":"gymad:scrm-585_flag_btn","ref":"scrm-585_flag_btn","sha":"f8d97bc20d1aed0fd23e70d148bb163d326d2fdd","user":{"login":"gymad","id":13831178,"avatar_url":"https://avatars3.githubusercontent.com/u/13831178?v=3","gravatar_id":"","url":"https://api.github.com/users/gymad","html_url":"https://github.com/gymad","followers_url":"https://api.github.com/users/gymad/followers","following_url":"https://api.github.com/users/gymad/following{/other_user}","gists_url":"https://api.github.com/users/gymad/gists{/gist_id}","starred_url":"https://api.github.com/users/gymad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gymad/subscriptions","organizations_url":"https://api.github.com/users/gymad/orgs","repos_url":"https://api.github.com/users/gymad/repos","events_url":"https://api.github.com/users/gymad/events{/privacy}","received_events_url":"https://api.github.com/users/gymad/received_events","type":"User","site_admin":false},"repo":{"id":41494060,"name":"SuiteCRM","full_name":"gymad/SuiteCRM","owner":{"login":"gymad","id":13831178,"avatar_url":"https://avatars3.githubusercontent.com/u/13831178?v=3","gravatar_id":"","url":"https://api.github.com/users/gymad","html_url":"https://github.com/gymad","followers_url":"https://api.github.com/users/gymad/followers","following_url":"https://api.github.com/users/gymad/following{/other_user}","gists_url":"https://api.github.com/users/gymad/gists{/gist_id}","starred_url":"https://api.github.com/users/gymad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gymad/subscriptions","organizations_url":"https://api.github.com/users/gymad/orgs","repos_url":"https://api.github.com/users/gymad/repos","events_url":"https://api.github.com/users/gymad/events{/privacy}","received_events_url":"https://api.github.com/users/gymad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gymad/SuiteCRM","description":"SuiteCRM is SugarCRM Supercharged. It's the Free Open Source alternative to SugarCRM Professional.","fork":true,"url":"https://api.github.com/repos/gymad/SuiteCRM","forks_url":"https://api.github.com/repos/gymad/SuiteCRM/forks","keys_url":"https://api.github.com/repos/gymad/SuiteCRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gymad/SuiteCRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gymad/SuiteCRM/teams","hooks_url":"https://api.github.com/repos/gymad/SuiteCRM/hooks","issue_events_url":"https://api.github.com/repos/gymad/SuiteCRM/issues/events{/number}","events_url":"https://api.github.com/repos/gymad/SuiteCRM/events","assignees_url":"https://api.github.com/repos/gymad/SuiteCRM/assignees{/user}","branches_url":"https://api.github.com/repos/gymad/SuiteCRM/branches{/branch}","tags_url":"https://api.github.com/repos/gymad/SuiteCRM/tags","blobs_url":"https://api.github.com/repos/gymad/SuiteCRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gymad/SuiteCRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gymad/SuiteCRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/gymad/SuiteCRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gymad/SuiteCRM/statuses/{sha}","languages_url":"https://api.github.com/repos/gymad/SuiteCRM/languages","stargazers_url":"https://api.github.com/repos/gymad/SuiteCRM/stargazers","contributors_url":"https://api.github.com/repos/gymad/SuiteCRM/contributors","subscribers_url":"https://api.github.com/repos/gymad/SuiteCRM/subscribers","subscription_url":"https://api.github.com/repos/gymad/SuiteCRM/subscription","commits_url":"https://api.github.com/repos/gymad/SuiteCRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/gymad/SuiteCRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/gymad/SuiteCRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/gymad/SuiteCRM/issues/comments{/number}","contents_url":"https://api.github.com/repos/gymad/SuiteCRM/contents/{+path}","compare_url":"https://api.github.com/repos/gymad/SuiteCRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gymad/SuiteCRM/merges","archive_url":"https://api.github.com/repos/gymad/SuiteCRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gymad/SuiteCRM/downloads","issues_url":"https://api.github.com/repos/gymad/SuiteCRM/issues{/number}","pulls_url":"https://api.github.com/repos/gymad/SuiteCRM/pulls{/number}","milestones_url":"https://api.github.com/repos/gymad/SuiteCRM/milestones{/number}","notifications_url":"https://api.github.com/repos/gymad/SuiteCRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gymad/SuiteCRM/labels{/name}","releases_url":"https://api.github.com/repos/gymad/SuiteCRM/releases{/id}","deployments_url":"https://api.github.com/repos/gymad/SuiteCRM/deployments","created_at":"2015-08-27T15:11:18Z","updated_at":"2016-06-30T11:24:42Z","pushed_at":"2017-06-05T10:16:28Z","git_url":"git://github.com/gymad/SuiteCRM.git","ssh_url":"[email protected]:gymad/SuiteCRM.git","clone_url":"https://github.com/gymad/SuiteCRM.git","svn_url":"https://github.com/gymad/SuiteCRM","homepage":"http://www.suitecrm.com","size":75208,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":13,"forks":0,"open_issues":13,"watchers":0,"default_branch":"master"}},"base":{"label":"salesagility:hotfix","ref":"hotfix","sha":"002adca2353e253d8fc4473e3c583b710e467804","user":{"login":"salesagility","id":1450870,"avatar_url":"https://avatars2.githubusercontent.com/u/1450870?v=3","gravatar_id":"","url":"https://api.github.com/users/salesagility","html_url":"https://github.com/salesagility","followers_url":"https://api.github.com/users/salesagility/followers","following_url":"https://api.github.com/users/salesagility/following{/other_user}","gists_url":"https://api.github.com/users/salesagility/gists{/gist_id}","starred_url":"https://api.github.com/users/salesagility/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesagility/subscriptions","organizations_url":"https://api.github.com/users/salesagility/orgs","repos_url":"https://api.github.com/users/salesagility/repos","events_url":"https://api.github.com/users/salesagility/events{/privacy}","received_events_url":"https://api.github.com/users/salesagility/received_events","type":"Organization","site_admin":false},"repo":{"id":13044600,"name":"SuiteCRM","full_name":"salesagility/SuiteCRM","owner":{"login":"salesagility","id":1450870,"avatar_url":"https://avatars2.githubusercontent.com/u/1450870?v=3","gravatar_id":"","url":"https://api.github.com/users/salesagility","html_url":"https://github.com/salesagility","followers_url":"https://api.github.com/users/salesagility/followers","following_url":"https://api.github.com/users/salesagility/following{/other_user}","gists_url":"https://api.github.com/users/salesagility/gists{/gist_id}","starred_url":"https://api.github.com/users/salesagility/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesagility/subscriptions","organizations_url":"https://api.github.com/users/salesagility/orgs","repos_url":"https://api.github.com/users/salesagility/repos","events_url":"https://api.github.com/users/salesagility/events{/privacy}","received_events_url":"https://api.github.com/users/salesagility/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/salesagility/SuiteCRM","description":"SuiteCRM - Open source CRM for the world","fork":false,"url":"https://api.github.com/repos/salesagility/SuiteCRM","forks_url":"https://api.github.com/repos/salesagility/SuiteCRM/forks","keys_url":"https://api.github.com/repos/salesagility/SuiteCRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salesagility/SuiteCRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salesagility/SuiteCRM/teams","hooks_url":"https://api.github.com/repos/salesagility/SuiteCRM/hooks","issue_events_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/events{/number}","events_url":"https://api.github.com/repos/salesagility/SuiteCRM/events","assignees_url":"https://api.github.com/repos/salesagility/SuiteCRM/assignees{/user}","branches_url":"https://api.github.com/repos/salesagility/SuiteCRM/branches{/branch}","tags_url":"https://api.github.com/repos/salesagility/SuiteCRM/tags","blobs_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/{sha}","languages_url":"https://api.github.com/repos/salesagility/SuiteCRM/languages","stargazers_url":"https://api.github.com/repos/salesagility/SuiteCRM/stargazers","contributors_url":"https://api.github.com/repos/salesagility/SuiteCRM/contributors","subscribers_url":"https://api.github.com/repos/salesagility/SuiteCRM/subscribers","subscription_url":"https://api.github.com/repos/salesagility/SuiteCRM/subscription","commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/comments{/number}","contents_url":"https://api.github.com/repos/salesagility/SuiteCRM/contents/{+path}","compare_url":"https://api.github.com/repos/salesagility/SuiteCRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salesagility/SuiteCRM/merges","archive_url":"https://api.github.com/repos/salesagility/SuiteCRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salesagility/SuiteCRM/downloads","issues_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues{/number}","pulls_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls{/number}","milestones_url":"https://api.github.com/repos/salesagility/SuiteCRM/milestones{/number}","notifications_url":"https://api.github.com/repos/salesagility/SuiteCRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salesagility/SuiteCRM/labels{/name}","releases_url":"https://api.github.com/repos/salesagility/SuiteCRM/releases{/id}","deployments_url":"https://api.github.com/repos/salesagility/SuiteCRM/deployments","created_at":"2013-09-23T19:10:08Z","updated_at":"2017-06-05T07:49:49Z","pushed_at":"2017-06-05T10:21:48Z","git_url":"git://github.com/salesagility/SuiteCRM.git","ssh_url":"[email protected]:salesagility/SuiteCRM.git","clone_url":"https://github.com/salesagility/SuiteCRM.git","svn_url":"https://github.com/salesagility/SuiteCRM","homepage":"http://www.suitecrm.com","size":74651,"stargazers_count":637,"watchers_count":637,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":522,"mirror_url":null,"open_issues_count":801,"forks":522,"open_issues":801,"watchers":637,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/3648"},"html":{"href":"https://github.com/salesagility/SuiteCRM/pull/3648"},"issue":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/issues/3648"},"comments":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/issues/3648/comments"},"review_comments":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/3648/comments"},"review_comment":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/3648/commits"},"statuses":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/f8d97bc20d1aed0fd23e70d148bb163d326d2fdd"}}}}
|
{
"id": 13044600,
"name": "salesagility/SuiteCRM",
"url": "https://api.github.com/repos/salesagility/SuiteCRM"
}
|
{
"id": 13831178,
"login": "gymad",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13831178?",
"url": "https://api.github.com/users/gymad"
}
|
{
"id": 1450870,
"login": "salesagility",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1450870?",
"url": "https://api.github.com/orgs/salesagility"
}
| 2017-06-05T11:08:33 |
6002012549
|
{"actor":{"display_login":"gymad"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/94283047","pull_request_review_id":14812490,"id":94283047,"diff_hunk":"@@ -133,6 +133,40 @@ def test_dbscan_callable():\n assert_equal(n_clusters_2, n_clusters)\n \n \n+def test_dbscan_metric_params():\n+ # Tests that DBSCAN works with the metrics_params argument.\n+ # Parameters chosen specifically for this task.\n+ # Different eps to other test, because distance is not normalised.\n+ eps = 0.8\n+ min_samples = 10\n+ p = 2\n+ # Compute DBSCAN\n+ # parameters chosen for task\n+ core_samples, labels = dbscan(X, metric='minkowski',\n+ metric_params={'p': p}, eps=eps,\n+ min_samples=min_samples,\n+ algorithm='ball_tree')\n+\n+ # number of clusters, ignoring noise if present\n+ n_clusters_1 = len(set(labels)) - int(-1 in labels)\n+ assert_equal(n_clusters_1, n_clusters)","path":"sklearn/cluster/tests/test_dbscan.py","position":20,"original_position":20,"commit_id":"5cd2357cc591abc9fe65c2658e171d3eff661a51","original_commit_id":"5cd2357cc591abc9fe65c2658e171d3eff661a51","user":{"login":"jnothman","id":78827,"avatar_url":"https://avatars.githubusercontent.com/u/78827?v=3","gravatar_id":"","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following{/other_user}","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User","site_admin":false},"body":"I would've thought that the complete set of labels were identical. Why are we using as weak an assertion as this?","created_at":"2017-01-01T11:58:15Z","updated_at":"2017-01-01T11:58:29Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/8139#discussion_r94283047","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8139","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/94283047"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/8139#discussion_r94283047"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8139"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8139","id":99820727,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/8139","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/8139.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/8139.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/8139","number":8139,"state":"open","locked":false,"title":"[MRG] Add DBSCAN support for additional metric params","user":{"login":"naoyak","id":3279641,"avatar_url":"https://avatars.githubusercontent.com/u/3279641?v=3","gravatar_id":"","url":"https://api.github.com/users/naoyak","html_url":"https://github.com/naoyak","followers_url":"https://api.github.com/users/naoyak/followers","following_url":"https://api.github.com/users/naoyak/following{/other_user}","gists_url":"https://api.github.com/users/naoyak/gists{/gist_id}","starred_url":"https://api.github.com/users/naoyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naoyak/subscriptions","organizations_url":"https://api.github.com/users/naoyak/orgs","repos_url":"https://api.github.com/users/naoyak/repos","events_url":"https://api.github.com/users/naoyak/events{/privacy}","received_events_url":"https://api.github.com/users/naoyak/received_events","type":"User","site_admin":false},"body":"Fixes #4520\r\n\r\n- Added support for the additional `metrics_params` argument in `DBSCAN` (i.e. passing `{'p': p}` when using 'minkowski' for the metric)\r\n- Added a test to confirm that this works\r\n\r\n","created_at":"2017-01-01T10:09:33Z","updated_at":"2017-01-01T11:58:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13527ff3c6686b7236559334b7ffcc7c5333ac67","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8139/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8139/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/8139/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/5cd2357cc591abc9fe65c2658e171d3eff661a51","head":{"label":"naoyak:dbscan-metric-params","ref":"dbscan-metric-params","sha":"5cd2357cc591abc9fe65c2658e171d3eff661a51","user":{"login":"naoyak","id":3279641,"avatar_url":"https://avatars.githubusercontent.com/u/3279641?v=3","gravatar_id":"","url":"https://api.github.com/users/naoyak","html_url":"https://github.com/naoyak","followers_url":"https://api.github.com/users/naoyak/followers","following_url":"https://api.github.com/users/naoyak/following{/other_user}","gists_url":"https://api.github.com/users/naoyak/gists{/gist_id}","starred_url":"https://api.github.com/users/naoyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naoyak/subscriptions","organizations_url":"https://api.github.com/users/naoyak/orgs","repos_url":"https://api.github.com/users/naoyak/repos","events_url":"https://api.github.com/users/naoyak/events{/privacy}","received_events_url":"https://api.github.com/users/naoyak/received_events","type":"User","site_admin":false},"repo":{"id":65031157,"name":"scikit-learn","full_name":"naoyak/scikit-learn","owner":{"login":"naoyak","id":3279641,"avatar_url":"https://avatars.githubusercontent.com/u/3279641?v=3","gravatar_id":"","url":"https://api.github.com/users/naoyak","html_url":"https://github.com/naoyak","followers_url":"https://api.github.com/users/naoyak/followers","following_url":"https://api.github.com/users/naoyak/following{/other_user}","gists_url":"https://api.github.com/users/naoyak/gists{/gist_id}","starred_url":"https://api.github.com/users/naoyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naoyak/subscriptions","organizations_url":"https://api.github.com/users/naoyak/orgs","repos_url":"https://api.github.com/users/naoyak/repos","events_url":"https://api.github.com/users/naoyak/events{/privacy}","received_events_url":"https://api.github.com/users/naoyak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/naoyak/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/naoyak/scikit-learn","forks_url":"https://api.github.com/repos/naoyak/scikit-learn/forks","keys_url":"https://api.github.com/repos/naoyak/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/naoyak/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/naoyak/scikit-learn/teams","hooks_url":"https://api.github.com/repos/naoyak/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/naoyak/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/naoyak/scikit-learn/events","assignees_url":"https://api.github.com/repos/naoyak/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/naoyak/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/naoyak/scikit-learn/tags","blobs_url":"https://api.github.com/repos/naoyak/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/naoyak/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/naoyak/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/naoyak/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/naoyak/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/naoyak/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/naoyak/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/naoyak/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/naoyak/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/naoyak/scikit-learn/subscription","commits_url":"https://api.github.com/repos/naoyak/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/naoyak/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/naoyak/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/naoyak/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/naoyak/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/naoyak/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/naoyak/scikit-learn/merges","archive_url":"https://api.github.com/repos/naoyak/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/naoyak/scikit-learn/downloads","issues_url":"https://api.github.com/repos/naoyak/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/naoyak/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/naoyak/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/naoyak/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/naoyak/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/naoyak/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/naoyak/scikit-learn/deployments","created_at":"2016-08-05T15:56:45Z","updated_at":"2016-08-05T15:56:53Z","pushed_at":"2017-01-01T11:40:50Z","git_url":"git://github.com/naoyak/scikit-learn.git","ssh_url":"[email protected]:naoyak/scikit-learn.git","clone_url":"https://github.com/naoyak/scikit-learn.git","svn_url":"https://github.com/naoyak/scikit-learn","homepage":"http://scikit-learn.org","size":77810,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"e2adbb7e037de74044db002eff5898f5e11a5507","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2017-01-01T10:57:37Z","pushed_at":"2017-01-01T11:40:52Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"[email protected]:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":78703,"stargazers_count":15597,"watchers_count":15597,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8739,"mirror_url":null,"open_issues_count":1169,"forks":8739,"open_issues":1169,"watchers":15597,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8139"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/8139"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/8139"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/8139/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8139/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8139/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/5cd2357cc591abc9fe65c2658e171d3eff661a51"}}}}
|
{
"id": 843222,
"name": "scikit-learn/scikit-learn",
"url": "https://api.github.com/repos/scikit-learn/scikit-learn"
}
|
{
"id": 78827,
"login": "jnothman",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/78827?",
"url": "https://api.github.com/users/jnothman"
}
|
{
"id": 365630,
"login": "scikit-learn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/365630?",
"url": "https://api.github.com/orgs/scikit-learn"
}
| 2017-01-01T11:58:15 |
5089165253
|
{"actor":{"display_login":"jnothman"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments/140289687","pull_request_review_id":64340792,"id":140289687,"diff_hunk":"@@ -40,95 +40,126 @@ class SSViewer_DataPresenter extends SSViewer_Scope\n \n /**\n * Underlay variables. Concede precedence to overlay variables or anything from the current scope\n- * @var array|null\n+ *\n+ * @var array\n */\n protected $underlay;\n \n- public function __construct($item, $overlay = null, $underlay = null, $inheritedScope = null)\n- {\n+ /**\n+ * @var object $item\n+ * @var array $overlay\n+ * @var array $underlay\n+ * @var SSViewer_Scope $inheritedScope\n+ */\n+ public function __construct(\n+ $item,\n+ array $overlay = null,\n+ array $underlay = null,\n+ SSViewer_Scope $inheritedScope = null\n+ ) {\n parent::__construct($item, $inheritedScope);\n \n- // Build up global property providers array only once per request\n- if (self::$globalProperties === null) {\n- self::$globalProperties = array();\n- // Get all the exposed variables from all classes that implement the TemplateGlobalProvider interface\n- $this->createCallableArray(\n- self::$globalProperties,\n- TemplateGlobalProvider::class,\n- \"get_template_global_variables\"\n- );\n+ $this->overlay = $overlay ?: [];\n+ $this->underlay = $underlay ?: [];\n+\n+ $this->cacheGlobalProperties();\n+ $this->cacheIteratorProperties();\n+ }\n+\n+ /**\n+ * Build cache of global properties\n+ */\n+ protected function cacheGlobalProperties()\n+ {\n+ if (self::$globalProperties !== null) {\n+ return;\n }\n \n- // Build up iterator property providers array only once per request\n- if (self::$iteratorProperties === null) {\n- self::$iteratorProperties = array();\n- // Get all the exposed variables from all classes that implement the TemplateIteratorProvider interface\n- // //call non-statically\n- $this->createCallableArray(\n- self::$iteratorProperties,\n- TemplateIteratorProvider::class,\n- \"get_template_iterator_variables\",\n- true\n- );\n+ self::$globalProperties = $this->getPropertiesFromProvider(\n+ TemplateGlobalProvider::class,\n+ 'get_template_global_variables'\n+ );\n+ }\n+\n+ /**\n+ * Build cache of global iterator properties\n+ */\n+ protected function cacheIteratorProperties()\n+ {\n+ if (self::$iteratorProperties !== null) {\n+ return;\n }\n \n- $this->overlay = $overlay ? $overlay : array();\n- $this->underlay = $underlay ? $underlay : array();\n+ self::$iteratorProperties = $this->getPropertiesFromProvider(\n+ TemplateIteratorProvider::class,\n+ 'get_template_iterator_variables',\n+ true // Call non-statically\n+ );\n }\n \n- protected function createCallableArray(&$extraArray, $interfaceToQuery, $variableMethod, $createObject = false)","path":"src/View/SSViewer_DataPresenter.php","position":86,"original_position":86,"commit_id":"1dd0c048918db31d99f64d6e2b8dc4cbb5dbf4ab","original_commit_id":"1dd0c048918db31d99f64d6e2b8dc4cbb5dbf4ab","user":{"login":"kinglozzer","id":1655548,"avatar_url":"https://avatars3.githubusercontent.com/u/1655548?v=4","gravatar_id":"","url":"https://api.github.com/users/kinglozzer","html_url":"https://github.com/kinglozzer","followers_url":"https://api.github.com/users/kinglozzer/followers","following_url":"https://api.github.com/users/kinglozzer/following{/other_user}","gists_url":"https://api.github.com/users/kinglozzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kinglozzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinglozzer/subscriptions","organizations_url":"https://api.github.com/users/kinglozzer/orgs","repos_url":"https://api.github.com/users/kinglozzer/repos","events_url":"https://api.github.com/users/kinglozzer/events{/privacy}","received_events_url":"https://api.github.com/users/kinglozzer/received_events","type":"User","site_admin":false},"body":"Method refactored/renamed, not part of our “public” API but happy to undo this if others disagree","created_at":"2017-09-21T16:15:24Z","updated_at":"2017-09-21T16:15:24Z","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/7393#discussion_r140289687","pull_request_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/7393","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments/140289687"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/7393#discussion_r140289687"},"pull_request":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/7393"}}},"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/7393","id":142386140,"html_url":"https://github.com/silverstripe/silverstripe-framework/pull/7393","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/7393.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/7393.patch","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/7393","number":7393,"state":"open","locked":false,"title":"Tidy up + document SSViewer classes","user":{"login":"kinglozzer","id":1655548,"avatar_url":"https://avatars3.githubusercontent.com/u/1655548?v=4","gravatar_id":"","url":"https://api.github.com/users/kinglozzer","html_url":"https://github.com/kinglozzer","followers_url":"https://api.github.com/users/kinglozzer/followers","following_url":"https://api.github.com/users/kinglozzer/following{/other_user}","gists_url":"https://api.github.com/users/kinglozzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kinglozzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinglozzer/subscriptions","organizations_url":"https://api.github.com/users/kinglozzer/orgs","repos_url":"https://api.github.com/users/kinglozzer/repos","events_url":"https://api.github.com/users/kinglozzer/events{/privacy}","received_events_url":"https://api.github.com/users/kinglozzer/received_events","type":"User","site_admin":false},"body":"There aren’t any functionality changes in here, it’s mostly docs, re-ordering methods/properties and a couple of minor method refactors.","created_at":"2017-09-21T16:13:23Z","updated_at":"2017-09-21T16:15:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0e6660a35fdaabbf8fe75a0945811965bd4b5b6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/7393/commits","review_comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/7393/comments","review_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/7393/comments","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/1dd0c048918db31d99f64d6e2b8dc4cbb5dbf4ab","head":{"label":"kinglozzer:ssviewer-tidy","ref":"ssviewer-tidy","sha":"1dd0c048918db31d99f64d6e2b8dc4cbb5dbf4ab","user":{"login":"kinglozzer","id":1655548,"avatar_url":"https://avatars3.githubusercontent.com/u/1655548?v=4","gravatar_id":"","url":"https://api.github.com/users/kinglozzer","html_url":"https://github.com/kinglozzer","followers_url":"https://api.github.com/users/kinglozzer/followers","following_url":"https://api.github.com/users/kinglozzer/following{/other_user}","gists_url":"https://api.github.com/users/kinglozzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kinglozzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinglozzer/subscriptions","organizations_url":"https://api.github.com/users/kinglozzer/orgs","repos_url":"https://api.github.com/users/kinglozzer/repos","events_url":"https://api.github.com/users/kinglozzer/events{/privacy}","received_events_url":"https://api.github.com/users/kinglozzer/received_events","type":"User","site_admin":false},"repo":{"id":6370354,"name":"sapphire","full_name":"kinglozzer/sapphire","owner":{"login":"kinglozzer","id":1655548,"avatar_url":"https://avatars3.githubusercontent.com/u/1655548?v=4","gravatar_id":"","url":"https://api.github.com/users/kinglozzer","html_url":"https://github.com/kinglozzer","followers_url":"https://api.github.com/users/kinglozzer/followers","following_url":"https://api.github.com/users/kinglozzer/following{/other_user}","gists_url":"https://api.github.com/users/kinglozzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kinglozzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinglozzer/subscriptions","organizations_url":"https://api.github.com/users/kinglozzer/orgs","repos_url":"https://api.github.com/users/kinglozzer/repos","events_url":"https://api.github.com/users/kinglozzer/events{/privacy}","received_events_url":"https://api.github.com/users/kinglozzer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kinglozzer/sapphire","description":"SilverStripe's Sapphire Framework","fork":true,"url":"https://api.github.com/repos/kinglozzer/sapphire","forks_url":"https://api.github.com/repos/kinglozzer/sapphire/forks","keys_url":"https://api.github.com/repos/kinglozzer/sapphire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinglozzer/sapphire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinglozzer/sapphire/teams","hooks_url":"https://api.github.com/repos/kinglozzer/sapphire/hooks","issue_events_url":"https://api.github.com/repos/kinglozzer/sapphire/issues/events{/number}","events_url":"https://api.github.com/repos/kinglozzer/sapphire/events","assignees_url":"https://api.github.com/repos/kinglozzer/sapphire/assignees{/user}","branches_url":"https://api.github.com/repos/kinglozzer/sapphire/branches{/branch}","tags_url":"https://api.github.com/repos/kinglozzer/sapphire/tags","blobs_url":"https://api.github.com/repos/kinglozzer/sapphire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinglozzer/sapphire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinglozzer/sapphire/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinglozzer/sapphire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinglozzer/sapphire/statuses/{sha}","languages_url":"https://api.github.com/repos/kinglozzer/sapphire/languages","stargazers_url":"https://api.github.com/repos/kinglozzer/sapphire/stargazers","contributors_url":"https://api.github.com/repos/kinglozzer/sapphire/contributors","subscribers_url":"https://api.github.com/repos/kinglozzer/sapphire/subscribers","subscription_url":"https://api.github.com/repos/kinglozzer/sapphire/subscription","commits_url":"https://api.github.com/repos/kinglozzer/sapphire/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinglozzer/sapphire/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinglozzer/sapphire/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinglozzer/sapphire/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinglozzer/sapphire/contents/{+path}","compare_url":"https://api.github.com/repos/kinglozzer/sapphire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinglozzer/sapphire/merges","archive_url":"https://api.github.com/repos/kinglozzer/sapphire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinglozzer/sapphire/downloads","issues_url":"https://api.github.com/repos/kinglozzer/sapphire/issues{/number}","pulls_url":"https://api.github.com/repos/kinglozzer/sapphire/pulls{/number}","milestones_url":"https://api.github.com/repos/kinglozzer/sapphire/milestones{/number}","notifications_url":"https://api.github.com/repos/kinglozzer/sapphire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinglozzer/sapphire/labels{/name}","releases_url":"https://api.github.com/repos/kinglozzer/sapphire/releases{/id}","deployments_url":"https://api.github.com/repos/kinglozzer/sapphire/deployments","created_at":"2012-10-24T13:30:44Z","updated_at":"2015-04-15T14:02:09Z","pushed_at":"2017-09-21T16:03:31Z","git_url":"git://github.com/kinglozzer/sapphire.git","ssh_url":"[email protected]:kinglozzer/sapphire.git","clone_url":"https://github.com/kinglozzer/sapphire.git","svn_url":"https://github.com/kinglozzer/sapphire","homepage":"http://silverstripe.org/","size":95401,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"silverstripe:4","ref":"4","sha":"5956e63745382965dd71b08410fdf379cb7dac3d","user":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars0.githubusercontent.com/u/379348?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":1318892,"name":"silverstripe-framework","full_name":"silverstripe/silverstripe-framework","owner":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars0.githubusercontent.com/u/379348?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripe/silverstripe-framework","description":"SilverStripe Framework, the MVC framework that powers SilverStripe CMS","fork":false,"url":"https://api.github.com/repos/silverstripe/silverstripe-framework","forks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/releases{/id}","deployments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/deployments","created_at":"2011-02-02T02:04:13Z","updated_at":"2017-09-09T22:59:38Z","pushed_at":"2017-09-21T16:13:24Z","git_url":"git://github.com/silverstripe/silverstripe-framework.git","ssh_url":"[email protected]:silverstripe/silverstripe-framework.git","clone_url":"https://github.com/silverstripe/silverstripe-framework.git","svn_url":"https://github.com/silverstripe/silverstripe-framework","homepage":"http://silverstripe.org/","size":95801,"stargazers_count":579,"watchers_count":579,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":664,"mirror_url":null,"open_issues_count":531,"forks":664,"open_issues":531,"watchers":579,"default_branch":"4"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/7393"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/7393"},"issue":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/7393"},"comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/7393/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/7393/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/7393/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/1dd0c048918db31d99f64d6e2b8dc4cbb5dbf4ab"}},"author_association":"OWNER"}}
|
{
"id": 1318892,
"name": "silverstripe/silverstripe-framework",
"url": "https://api.github.com/repos/silverstripe/silverstripe-framework"
}
|
{
"id": 1655548,
"login": "kinglozzer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1655548?",
"url": "https://api.github.com/users/kinglozzer"
}
|
{
"id": 379348,
"login": "silverstripe",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/379348?",
"url": "https://api.github.com/orgs/silverstripe"
}
| 2017-09-21T16:15:24 |
6620659765
|
{"actor":{"display_login":"kinglozzer"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/pulls/comments/130077097","pull_request_review_id":52915967,"id":130077097,"diff_hunk":"@@ -25,74 +26,69 @@ object SourcererApi {\n val password\n get() = Configurator.getPassword()\n \n- @Throws(IOException::class, HttpException::class)\n- fun getUserBlocking(): User {\n- val name = \"getUserBlocking\"\n- Logger.debug(\"Request $name initialized\")\n-\n- val (request, response, result) = Fuel.get(\"/user/info\")\n- .authenticate(username, password)\n- .responseString()\n- val body = result.get()\n- Logger.debug(\"Request $name success\")\n- return User().parseFrom(body)\n+ private fun createRequestGetUser(): Request {\n+ return Fuel.get(\"/user/info\").authenticate(username, password)\n }\n \n- @Throws(IOException::class, HttpException::class)\n- fun postCommitBlocking(commit: Commit): String {\n- val name = \"postCommitBlocking\"\n- Logger.debug(\"Request $name initialized\")\n- val (request, response, result) = Fuel.get(\"/commit\")\n- .authenticate(username, password)\n+ private fun createRequestPostCommit(commit: Commit): Request {\n+ return Fuel.post(\"/commit\").authenticate(username, password)\n .body(commit.serialize())\n- .responseString()\n+ }\n+\n+ private fun <T> makeBlockingRequest(request: Request, requestName: String,\n+ parser: (String) -> T): T {","path":"src/main/kotlin/app/SourcererApi.kt","position":47,"original_position":47,"commit_id":"4c8c5721115515bfc04d13b38983499c03dea561","original_commit_id":"8101e7baf472528014463fdb295244997c1b57b0","user":{"login":"anatolykislov","id":29913247,"avatar_url":"https://avatars3.githubusercontent.com/u/29913247?v=4","gravatar_id":"","url":"https://api.github.com/users/anatolykislov","html_url":"https://github.com/anatolykislov","followers_url":"https://api.github.com/users/anatolykislov/followers","following_url":"https://api.github.com/users/anatolykislov/following{/other_user}","gists_url":"https://api.github.com/users/anatolykislov/gists{/gist_id}","starred_url":"https://api.github.com/users/anatolykislov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anatolykislov/subscriptions","organizations_url":"https://api.github.com/users/anatolykislov/orgs","repos_url":"https://api.github.com/users/anatolykislov/repos","events_url":"https://api.github.com/users/anatolykislov/events{/privacy}","received_events_url":"https://api.github.com/users/anatolykislov/received_events","type":"User","site_admin":false},"body":"Ok","created_at":"2017-07-28T12:24:11Z","updated_at":"2017-07-28T12:24:11Z","html_url":"https://github.com/sourcerer-io/sourcerer-app/pull/8#discussion_r130077097","pull_request_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/sourcerer-io/sourcerer-app/pulls/comments/130077097"},"html":{"href":"https://github.com/sourcerer-io/sourcerer-app/pull/8#discussion_r130077097"},"pull_request":{"href":"https://api.github.com/repos/sourcerer-io/sourcerer-app/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/pulls/8","id":132699595,"html_url":"https://github.com/sourcerer-io/sourcerer-app/pull/8","diff_url":"https://github.com/sourcerer-io/sourcerer-app/pull/8.diff","patch_url":"https://github.com/sourcerer-io/sourcerer-app/pull/8.patch","issue_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/issues/8","number":8,"state":"open","locked":false,"title":"feat: add basic repo processing, refactor SourcererApi, refactor AuthState, fix Jackson serialization (APP-4, APP-7)","user":{"login":"anatolykislov","id":29913247,"avatar_url":"https://avatars3.githubusercontent.com/u/29913247?v=4","gravatar_id":"","url":"https://api.github.com/users/anatolykislov","html_url":"https://github.com/anatolykislov","followers_url":"https://api.github.com/users/anatolykislov/followers","following_url":"https://api.github.com/users/anatolykislov/following{/other_user}","gists_url":"https://api.github.com/users/anatolykislov/gists{/gist_id}","starred_url":"https://api.github.com/users/anatolykislov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anatolykislov/subscriptions","organizations_url":"https://api.github.com/users/anatolykislov/orgs","repos_url":"https://api.github.com/users/anatolykislov/repos","events_url":"https://api.github.com/users/anatolykislov/events{/privacy}","received_events_url":"https://api.github.com/users/anatolykislov/received_events","type":"User","site_admin":false},"body":"Fix:\r\n- Getter serialization in Jackson disabled for ProtoWrapper classes (tried to serialize proto because of getProto)\r\n\r\nRepo processing:\r\n- Base implementation of reading commits from local repo and sending commit messages to server\r\n- Add JGit library\r\n- RepoExplorer renamed to RepoHasher\r\n- Add constructor from JGit's commit to Commit class\r\n\r\nNetwork:\r\n- Refactor of SourcererApi\r\n- ProtoWrapper now serializes to bytes\r\n- Add RequestException wrapper for FuelError\r\n- Refactor of AuthState\r\n- Add auth and connection errors processing in AuthState","created_at":"2017-07-27T09:05:32Z","updated_at":"2017-07-28T12:24:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6301336794863d572681a90bbb01bd5d96b151f","assignee":{"login":"anatolykislov","id":29913247,"avatar_url":"https://avatars3.githubusercontent.com/u/29913247?v=4","gravatar_id":"","url":"https://api.github.com/users/anatolykislov","html_url":"https://github.com/anatolykislov","followers_url":"https://api.github.com/users/anatolykislov/followers","following_url":"https://api.github.com/users/anatolykislov/following{/other_user}","gists_url":"https://api.github.com/users/anatolykislov/gists{/gist_id}","starred_url":"https://api.github.com/users/anatolykislov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anatolykislov/subscriptions","organizations_url":"https://api.github.com/users/anatolykislov/orgs","repos_url":"https://api.github.com/users/anatolykislov/repos","events_url":"https://api.github.com/users/anatolykislov/events{/privacy}","received_events_url":"https://api.github.com/users/anatolykislov/received_events","type":"User","site_admin":false},"assignees":[{"login":"anatolykislov","id":29913247,"avatar_url":"https://avatars3.githubusercontent.com/u/29913247?v=4","gravatar_id":"","url":"https://api.github.com/users/anatolykislov","html_url":"https://github.com/anatolykislov","followers_url":"https://api.github.com/users/anatolykislov/followers","following_url":"https://api.github.com/users/anatolykislov/following{/other_user}","gists_url":"https://api.github.com/users/anatolykislov/gists{/gist_id}","starred_url":"https://api.github.com/users/anatolykislov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anatolykislov/subscriptions","organizations_url":"https://api.github.com/users/anatolykislov/orgs","repos_url":"https://api.github.com/users/anatolykislov/repos","events_url":"https://api.github.com/users/anatolykislov/events{/privacy}","received_events_url":"https://api.github.com/users/anatolykislov/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"yaronskaya","id":29913475,"avatar_url":"https://avatars3.githubusercontent.com/u/29913475?v=4","gravatar_id":"","url":"https://api.github.com/users/yaronskaya","html_url":"https://github.com/yaronskaya","followers_url":"https://api.github.com/users/yaronskaya/followers","following_url":"https://api.github.com/users/yaronskaya/following{/other_user}","gists_url":"https://api.github.com/users/yaronskaya/gists{/gist_id}","starred_url":"https://api.github.com/users/yaronskaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaronskaya/subscriptions","organizations_url":"https://api.github.com/users/yaronskaya/orgs","repos_url":"https://api.github.com/users/yaronskaya/repos","events_url":"https://api.github.com/users/yaronskaya/events{/privacy}","received_events_url":"https://api.github.com/users/yaronskaya/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/pulls/8/commits","review_comments_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/pulls/8/comments","review_comment_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/issues/8/comments","statuses_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/statuses/4c8c5721115515bfc04d13b38983499c03dea561","head":{"label":"sourcerer-io:dev","ref":"dev","sha":"4c8c5721115515bfc04d13b38983499c03dea561","user":{"login":"sourcerer-io","id":29913589,"avatar_url":"https://avatars3.githubusercontent.com/u/29913589?v=4","gravatar_id":"","url":"https://api.github.com/users/sourcerer-io","html_url":"https://github.com/sourcerer-io","followers_url":"https://api.github.com/users/sourcerer-io/followers","following_url":"https://api.github.com/users/sourcerer-io/following{/other_user}","gists_url":"https://api.github.com/users/sourcerer-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcerer-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcerer-io/subscriptions","organizations_url":"https://api.github.com/users/sourcerer-io/orgs","repos_url":"https://api.github.com/users/sourcerer-io/repos","events_url":"https://api.github.com/users/sourcerer-io/events{/privacy}","received_events_url":"https://api.github.com/users/sourcerer-io/received_events","type":"Organization","site_admin":false},"repo":{"id":96525128,"name":"sourcerer-app","full_name":"sourcerer-io/sourcerer-app","owner":{"login":"sourcerer-io","id":29913589,"avatar_url":"https://avatars3.githubusercontent.com/u/29913589?v=4","gravatar_id":"","url":"https://api.github.com/users/sourcerer-io","html_url":"https://github.com/sourcerer-io","followers_url":"https://api.github.com/users/sourcerer-io/followers","following_url":"https://api.github.com/users/sourcerer-io/following{/other_user}","gists_url":"https://api.github.com/users/sourcerer-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcerer-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcerer-io/subscriptions","organizations_url":"https://api.github.com/users/sourcerer-io/orgs","repos_url":"https://api.github.com/users/sourcerer-io/repos","events_url":"https://api.github.com/users/sourcerer-io/events{/privacy}","received_events_url":"https://api.github.com/users/sourcerer-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sourcerer-io/sourcerer-app","description":"Sourcerer app makes engineering profiles from their git repositories.","fork":false,"url":"https://api.github.com/repos/sourcerer-io/sourcerer-app","forks_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/forks","keys_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/teams","hooks_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/hooks","issue_events_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/issues/events{/number}","events_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/events","assignees_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/assignees{/user}","branches_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/branches{/branch}","tags_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/tags","blobs_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/statuses/{sha}","languages_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/languages","stargazers_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/stargazers","contributors_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/contributors","subscribers_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/subscribers","subscription_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/subscription","commits_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/contents/{+path}","compare_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/merges","archive_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/downloads","issues_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/issues{/number}","pulls_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/pulls{/number}","milestones_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/milestones{/number}","notifications_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/labels{/name}","releases_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/releases{/id}","deployments_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/deployments","created_at":"2017-07-07T09:53:22Z","updated_at":"2017-07-10T20:52:50Z","pushed_at":"2017-07-28T11:59:00Z","git_url":"git://github.com/sourcerer-io/sourcerer-app.git","ssh_url":"[email protected]:sourcerer-io/sourcerer-app.git","clone_url":"https://github.com/sourcerer-io/sourcerer-app.git","svn_url":"https://github.com/sourcerer-io/sourcerer-app","homepage":null,"size":46,"stargazers_count":1,"watchers_count":1,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"sourcerer-io:master","ref":"master","sha":"bd4d1223e63044813d198ce7728fca913154f3c3","user":{"login":"sourcerer-io","id":29913589,"avatar_url":"https://avatars3.githubusercontent.com/u/29913589?v=4","gravatar_id":"","url":"https://api.github.com/users/sourcerer-io","html_url":"https://github.com/sourcerer-io","followers_url":"https://api.github.com/users/sourcerer-io/followers","following_url":"https://api.github.com/users/sourcerer-io/following{/other_user}","gists_url":"https://api.github.com/users/sourcerer-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcerer-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcerer-io/subscriptions","organizations_url":"https://api.github.com/users/sourcerer-io/orgs","repos_url":"https://api.github.com/users/sourcerer-io/repos","events_url":"https://api.github.com/users/sourcerer-io/events{/privacy}","received_events_url":"https://api.github.com/users/sourcerer-io/received_events","type":"Organization","site_admin":false},"repo":{"id":96525128,"name":"sourcerer-app","full_name":"sourcerer-io/sourcerer-app","owner":{"login":"sourcerer-io","id":29913589,"avatar_url":"https://avatars3.githubusercontent.com/u/29913589?v=4","gravatar_id":"","url":"https://api.github.com/users/sourcerer-io","html_url":"https://github.com/sourcerer-io","followers_url":"https://api.github.com/users/sourcerer-io/followers","following_url":"https://api.github.com/users/sourcerer-io/following{/other_user}","gists_url":"https://api.github.com/users/sourcerer-io/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcerer-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcerer-io/subscriptions","organizations_url":"https://api.github.com/users/sourcerer-io/orgs","repos_url":"https://api.github.com/users/sourcerer-io/repos","events_url":"https://api.github.com/users/sourcerer-io/events{/privacy}","received_events_url":"https://api.github.com/users/sourcerer-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sourcerer-io/sourcerer-app","description":"Sourcerer app makes engineering profiles from their git repositories.","fork":false,"url":"https://api.github.com/repos/sourcerer-io/sourcerer-app","forks_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/forks","keys_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/teams","hooks_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/hooks","issue_events_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/issues/events{/number}","events_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/events","assignees_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/assignees{/user}","branches_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/branches{/branch}","tags_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/tags","blobs_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/statuses/{sha}","languages_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/languages","stargazers_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/stargazers","contributors_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/contributors","subscribers_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/subscribers","subscription_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/subscription","commits_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/contents/{+path}","compare_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/merges","archive_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/downloads","issues_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/issues{/number}","pulls_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/pulls{/number}","milestones_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/milestones{/number}","notifications_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/labels{/name}","releases_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/releases{/id}","deployments_url":"https://api.github.com/repos/sourcerer-io/sourcerer-app/deployments","created_at":"2017-07-07T09:53:22Z","updated_at":"2017-07-10T20:52:50Z","pushed_at":"2017-07-28T11:59:00Z","git_url":"git://github.com/sourcerer-io/sourcerer-app.git","ssh_url":"[email protected]:sourcerer-io/sourcerer-app.git","clone_url":"https://github.com/sourcerer-io/sourcerer-app.git","svn_url":"https://github.com/sourcerer-io/sourcerer-app","homepage":null,"size":46,"stargazers_count":1,"watchers_count":1,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sourcerer-io/sourcerer-app/pulls/8"},"html":{"href":"https://github.com/sourcerer-io/sourcerer-app/pull/8"},"issue":{"href":"https://api.github.com/repos/sourcerer-io/sourcerer-app/issues/8"},"comments":{"href":"https://api.github.com/repos/sourcerer-io/sourcerer-app/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/sourcerer-io/sourcerer-app/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/sourcerer-io/sourcerer-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sourcerer-io/sourcerer-app/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/sourcerer-io/sourcerer-app/statuses/4c8c5721115515bfc04d13b38983499c03dea561"}}}}
|
{
"id": 96525128,
"name": "sourcerer-io/sourcerer-app",
"url": "https://api.github.com/repos/sourcerer-io/sourcerer-app"
}
|
{
"id": 29913247,
"login": "anatolykislov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29913247?",
"url": "https://api.github.com/users/anatolykislov"
}
|
{
"id": 29913589,
"login": "sourcerer-io",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29913589?",
"url": "https://api.github.com/orgs/sourcerer-io"
}
| 2017-07-28T12:24:11 |
6349237332
|
{"actor":{"display_login":"anatolykislov"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/squad-of-war/magic-box-api/pulls/comments/105027603","pull_request_review_id":25888890,"id":105027603,"diff_hunk":"@@ -24,16 +28,31 @@ const show = (req, res) => {\n };\n \n const create = (req, res, next) => {\n- let upload = Object.assign(req.body.upload, {\n- _owner: req.user._id,\n- });\n- Upload.create(upload)\n- .then(upload =>\n- res.status(201)\n- .json({\n- upload: upload.toJSON({ virtuals: true, user: req.user }),\n- }))\n- .catch(next);\n+ console.log('req is ', req);\n+ // let upload = Object.assign(req.body.upload, {\n+ // _owner: req.user._id,\n+ // });\n+ // Upload.create(upload)\n+ // .then(upload =>\n+ // res.status(201)\n+ // .json({\n+ // upload: upload.toJSON({ virtuals: true, user: req.user }),\n+ // }))\n+ // .catch(next);\n+\n+ s3Upload(req.file)","path":"app/controllers/uploads.js","position":42,"original_position":42,"commit_id":"3fdd75df0dbe78a49ef2a8e59adc383b0ffcf5d6","original_commit_id":"3fdd75df0dbe78a49ef2a8e59adc383b0ffcf5d6","user":{"login":"ddobson","id":7988792,"avatar_url":"https://avatars2.githubusercontent.com/u/7988792?v=3","gravatar_id":"","url":"https://api.github.com/users/ddobson","html_url":"https://github.com/ddobson","followers_url":"https://api.github.com/users/ddobson/followers","following_url":"https://api.github.com/users/ddobson/following{/other_user}","gists_url":"https://api.github.com/users/ddobson/gists{/gist_id}","starred_url":"https://api.github.com/users/ddobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddobson/subscriptions","organizations_url":"https://api.github.com/users/ddobson/orgs","repos_url":"https://api.github.com/users/ddobson/repos","events_url":"https://api.github.com/users/ddobson/events{/privacy}","received_events_url":"https://api.github.com/users/ddobson/received_events","type":"User","site_admin":false},"body":"You can't just pass a file here. You need to send options or you need to change the arguments sent to the lib function.","created_at":"2017-03-08T21:30:28Z","updated_at":"2017-03-08T21:30:28Z","html_url":"https://github.com/squad-of-war/magic-box-api/pull/4#discussion_r105027603","pull_request_url":"https://api.github.com/repos/squad-of-war/magic-box-api/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/squad-of-war/magic-box-api/pulls/comments/105027603"},"html":{"href":"https://github.com/squad-of-war/magic-box-api/pull/4#discussion_r105027603"},"pull_request":{"href":"https://api.github.com/repos/squad-of-war/magic-box-api/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/squad-of-war/magic-box-api/pulls/4","id":109787427,"html_url":"https://github.com/squad-of-war/magic-box-api/pull/4","diff_url":"https://github.com/squad-of-war/magic-box-api/pull/4.diff","patch_url":"https://github.com/squad-of-war/magic-box-api/pull/4.patch","issue_url":"https://api.github.com/repos/squad-of-war/magic-box-api/issues/4","number":4,"state":"open","locked":false,"title":"S3 upload","user":{"login":"Sofistication","id":8274930,"avatar_url":"https://avatars2.githubusercontent.com/u/8274930?v=3","gravatar_id":"","url":"https://api.github.com/users/Sofistication","html_url":"https://github.com/Sofistication","followers_url":"https://api.github.com/users/Sofistication/followers","following_url":"https://api.github.com/users/Sofistication/following{/other_user}","gists_url":"https://api.github.com/users/Sofistication/gists{/gist_id}","starred_url":"https://api.github.com/users/Sofistication/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sofistication/subscriptions","organizations_url":"https://api.github.com/users/Sofistication/orgs","repos_url":"https://api.github.com/users/Sofistication/repos","events_url":"https://api.github.com/users/Sofistication/events{/privacy}","received_events_url":"https://api.github.com/users/Sofistication/received_events","type":"User","site_admin":false},"body":"`uploads#create` now recieves a file from the client and uploads it to s3.\r\nMongo documents now actually save the url of the uploaded file.\r\n\r\nAdds `multer` as a dependency\r\n\r\nsolves #3 ","created_at":"2017-03-08T21:23:30Z","updated_at":"2017-03-08T21:30:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ff3762af95a2d04e301a2dde14cae0a70306ef0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/squad-of-war/magic-box-api/pulls/4/commits","review_comments_url":"https://api.github.com/repos/squad-of-war/magic-box-api/pulls/4/comments","review_comment_url":"https://api.github.com/repos/squad-of-war/magic-box-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/squad-of-war/magic-box-api/issues/4/comments","statuses_url":"https://api.github.com/repos/squad-of-war/magic-box-api/statuses/3fdd75df0dbe78a49ef2a8e59adc383b0ffcf5d6","head":{"label":"squad-of-war:s3-upload","ref":"s3-upload","sha":"3fdd75df0dbe78a49ef2a8e59adc383b0ffcf5d6","user":{"login":"squad-of-war","id":26008759,"avatar_url":"https://avatars2.githubusercontent.com/u/26008759?v=3","gravatar_id":"","url":"https://api.github.com/users/squad-of-war","html_url":"https://github.com/squad-of-war","followers_url":"https://api.github.com/users/squad-of-war/followers","following_url":"https://api.github.com/users/squad-of-war/following{/other_user}","gists_url":"https://api.github.com/users/squad-of-war/gists{/gist_id}","starred_url":"https://api.github.com/users/squad-of-war/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squad-of-war/subscriptions","organizations_url":"https://api.github.com/users/squad-of-war/orgs","repos_url":"https://api.github.com/users/squad-of-war/repos","events_url":"https://api.github.com/users/squad-of-war/events{/privacy}","received_events_url":"https://api.github.com/users/squad-of-war/received_events","type":"Organization","site_admin":false},"repo":{"id":84334840,"name":"magic-box-api","full_name":"squad-of-war/magic-box-api","owner":{"login":"squad-of-war","id":26008759,"avatar_url":"https://avatars2.githubusercontent.com/u/26008759?v=3","gravatar_id":"","url":"https://api.github.com/users/squad-of-war","html_url":"https://github.com/squad-of-war","followers_url":"https://api.github.com/users/squad-of-war/followers","following_url":"https://api.github.com/users/squad-of-war/following{/other_user}","gists_url":"https://api.github.com/users/squad-of-war/gists{/gist_id}","starred_url":"https://api.github.com/users/squad-of-war/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squad-of-war/subscriptions","organizations_url":"https://api.github.com/users/squad-of-war/orgs","repos_url":"https://api.github.com/users/squad-of-war/repos","events_url":"https://api.github.com/users/squad-of-war/events{/privacy}","received_events_url":"https://api.github.com/users/squad-of-war/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/squad-of-war/magic-box-api","description":null,"fork":false,"url":"https://api.github.com/repos/squad-of-war/magic-box-api","forks_url":"https://api.github.com/repos/squad-of-war/magic-box-api/forks","keys_url":"https://api.github.com/repos/squad-of-war/magic-box-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squad-of-war/magic-box-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squad-of-war/magic-box-api/teams","hooks_url":"https://api.github.com/repos/squad-of-war/magic-box-api/hooks","issue_events_url":"https://api.github.com/repos/squad-of-war/magic-box-api/issues/events{/number}","events_url":"https://api.github.com/repos/squad-of-war/magic-box-api/events","assignees_url":"https://api.github.com/repos/squad-of-war/magic-box-api/assignees{/user}","branches_url":"https://api.github.com/repos/squad-of-war/magic-box-api/branches{/branch}","tags_url":"https://api.github.com/repos/squad-of-war/magic-box-api/tags","blobs_url":"https://api.github.com/repos/squad-of-war/magic-box-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squad-of-war/magic-box-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squad-of-war/magic-box-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/squad-of-war/magic-box-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squad-of-war/magic-box-api/statuses/{sha}","languages_url":"https://api.github.com/repos/squad-of-war/magic-box-api/languages","stargazers_url":"https://api.github.com/repos/squad-of-war/magic-box-api/stargazers","contributors_url":"https://api.github.com/repos/squad-of-war/magic-box-api/contributors","subscribers_url":"https://api.github.com/repos/squad-of-war/magic-box-api/subscribers","subscription_url":"https://api.github.com/repos/squad-of-war/magic-box-api/subscription","commits_url":"https://api.github.com/repos/squad-of-war/magic-box-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/squad-of-war/magic-box-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/squad-of-war/magic-box-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/squad-of-war/magic-box-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/squad-of-war/magic-box-api/contents/{+path}","compare_url":"https://api.github.com/repos/squad-of-war/magic-box-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squad-of-war/magic-box-api/merges","archive_url":"https://api.github.com/repos/squad-of-war/magic-box-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squad-of-war/magic-box-api/downloads","issues_url":"https://api.github.com/repos/squad-of-war/magic-box-api/issues{/number}","pulls_url":"https://api.github.com/repos/squad-of-war/magic-box-api/pulls{/number}","milestones_url":"https://api.github.com/repos/squad-of-war/magic-box-api/milestones{/number}","notifications_url":"https://api.github.com/repos/squad-of-war/magic-box-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squad-of-war/magic-box-api/labels{/name}","releases_url":"https://api.github.com/repos/squad-of-war/magic-box-api/releases{/id}","deployments_url":"https://api.github.com/repos/squad-of-war/magic-box-api/deployments","created_at":"2017-03-08T15:20:04Z","updated_at":"2017-03-08T17:52:38Z","pushed_at":"2017-03-08T21:23:31Z","git_url":"git://github.com/squad-of-war/magic-box-api.git","ssh_url":"[email protected]:squad-of-war/magic-box-api.git","clone_url":"https://github.com/squad-of-war/magic-box-api.git","svn_url":"https://github.com/squad-of-war/magic-box-api","homepage":null,"size":49,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"develop"}},"base":{"label":"squad-of-war:develop","ref":"develop","sha":"a40148db5e98b27c9fc96da01216440f06c67c81","user":{"login":"squad-of-war","id":26008759,"avatar_url":"https://avatars2.githubusercontent.com/u/26008759?v=3","gravatar_id":"","url":"https://api.github.com/users/squad-of-war","html_url":"https://github.com/squad-of-war","followers_url":"https://api.github.com/users/squad-of-war/followers","following_url":"https://api.github.com/users/squad-of-war/following{/other_user}","gists_url":"https://api.github.com/users/squad-of-war/gists{/gist_id}","starred_url":"https://api.github.com/users/squad-of-war/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squad-of-war/subscriptions","organizations_url":"https://api.github.com/users/squad-of-war/orgs","repos_url":"https://api.github.com/users/squad-of-war/repos","events_url":"https://api.github.com/users/squad-of-war/events{/privacy}","received_events_url":"https://api.github.com/users/squad-of-war/received_events","type":"Organization","site_admin":false},"repo":{"id":84334840,"name":"magic-box-api","full_name":"squad-of-war/magic-box-api","owner":{"login":"squad-of-war","id":26008759,"avatar_url":"https://avatars2.githubusercontent.com/u/26008759?v=3","gravatar_id":"","url":"https://api.github.com/users/squad-of-war","html_url":"https://github.com/squad-of-war","followers_url":"https://api.github.com/users/squad-of-war/followers","following_url":"https://api.github.com/users/squad-of-war/following{/other_user}","gists_url":"https://api.github.com/users/squad-of-war/gists{/gist_id}","starred_url":"https://api.github.com/users/squad-of-war/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squad-of-war/subscriptions","organizations_url":"https://api.github.com/users/squad-of-war/orgs","repos_url":"https://api.github.com/users/squad-of-war/repos","events_url":"https://api.github.com/users/squad-of-war/events{/privacy}","received_events_url":"https://api.github.com/users/squad-of-war/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/squad-of-war/magic-box-api","description":null,"fork":false,"url":"https://api.github.com/repos/squad-of-war/magic-box-api","forks_url":"https://api.github.com/repos/squad-of-war/magic-box-api/forks","keys_url":"https://api.github.com/repos/squad-of-war/magic-box-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squad-of-war/magic-box-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squad-of-war/magic-box-api/teams","hooks_url":"https://api.github.com/repos/squad-of-war/magic-box-api/hooks","issue_events_url":"https://api.github.com/repos/squad-of-war/magic-box-api/issues/events{/number}","events_url":"https://api.github.com/repos/squad-of-war/magic-box-api/events","assignees_url":"https://api.github.com/repos/squad-of-war/magic-box-api/assignees{/user}","branches_url":"https://api.github.com/repos/squad-of-war/magic-box-api/branches{/branch}","tags_url":"https://api.github.com/repos/squad-of-war/magic-box-api/tags","blobs_url":"https://api.github.com/repos/squad-of-war/magic-box-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squad-of-war/magic-box-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squad-of-war/magic-box-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/squad-of-war/magic-box-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squad-of-war/magic-box-api/statuses/{sha}","languages_url":"https://api.github.com/repos/squad-of-war/magic-box-api/languages","stargazers_url":"https://api.github.com/repos/squad-of-war/magic-box-api/stargazers","contributors_url":"https://api.github.com/repos/squad-of-war/magic-box-api/contributors","subscribers_url":"https://api.github.com/repos/squad-of-war/magic-box-api/subscribers","subscription_url":"https://api.github.com/repos/squad-of-war/magic-box-api/subscription","commits_url":"https://api.github.com/repos/squad-of-war/magic-box-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/squad-of-war/magic-box-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/squad-of-war/magic-box-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/squad-of-war/magic-box-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/squad-of-war/magic-box-api/contents/{+path}","compare_url":"https://api.github.com/repos/squad-of-war/magic-box-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squad-of-war/magic-box-api/merges","archive_url":"https://api.github.com/repos/squad-of-war/magic-box-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squad-of-war/magic-box-api/downloads","issues_url":"https://api.github.com/repos/squad-of-war/magic-box-api/issues{/number}","pulls_url":"https://api.github.com/repos/squad-of-war/magic-box-api/pulls{/number}","milestones_url":"https://api.github.com/repos/squad-of-war/magic-box-api/milestones{/number}","notifications_url":"https://api.github.com/repos/squad-of-war/magic-box-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squad-of-war/magic-box-api/labels{/name}","releases_url":"https://api.github.com/repos/squad-of-war/magic-box-api/releases{/id}","deployments_url":"https://api.github.com/repos/squad-of-war/magic-box-api/deployments","created_at":"2017-03-08T15:20:04Z","updated_at":"2017-03-08T17:52:38Z","pushed_at":"2017-03-08T21:23:31Z","git_url":"git://github.com/squad-of-war/magic-box-api.git","ssh_url":"[email protected]:squad-of-war/magic-box-api.git","clone_url":"https://github.com/squad-of-war/magic-box-api.git","svn_url":"https://github.com/squad-of-war/magic-box-api","homepage":null,"size":49,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/squad-of-war/magic-box-api/pulls/4"},"html":{"href":"https://github.com/squad-of-war/magic-box-api/pull/4"},"issue":{"href":"https://api.github.com/repos/squad-of-war/magic-box-api/issues/4"},"comments":{"href":"https://api.github.com/repos/squad-of-war/magic-box-api/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/squad-of-war/magic-box-api/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/squad-of-war/magic-box-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/squad-of-war/magic-box-api/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/squad-of-war/magic-box-api/statuses/3fdd75df0dbe78a49ef2a8e59adc383b0ffcf5d6"}}}}
|
{
"id": 84334840,
"name": "squad-of-war/magic-box-api",
"url": "https://api.github.com/repos/squad-of-war/magic-box-api"
}
|
{
"id": 7988792,
"login": "ddobson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7988792?",
"url": "https://api.github.com/users/ddobson"
}
|
{
"id": 26008759,
"login": "squad-of-war",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26008759?",
"url": "https://api.github.com/orgs/squad-of-war"
}
| 2017-03-08T21:30:28 |
5458404943
|
{"actor":{"display_login":"ddobson"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ubclaunchpad/cumulus/pulls/comments/116367022","pull_request_review_id":37987189,"id":116367022,"diff_hunk":"@@ -0,0 +1,51 @@\n+package blockchain\n+\n+import (\n+\t\"crypto/ecdsa\"\n+\t\"crypto/elliptic\"\n+\t\"crypto/rand\"\n+\t\"fmt\"\n+\t\"math/big\"\n+)\n+\n+// The curve we use for our ECC crypto.\n+var curve = elliptic.P256()\n+\n+// Wallet represents a Cumulus wallet address in the blockchain.\n+type Wallet ecdsa.PublicKey\n+\n+// Signature represents a signature of a transaction.\n+type Signature struct {\n+\tX big.Int\n+\tY big.Int\n+}\n+\n+// Marshal converts a signature to a byte slice\n+func (s *Signature) Marshal() []byte {\n+\treturn append(s.X.Bytes(), s.Y.Bytes()...)\n+}\n+\n+// New creates a new Wallet backed by a ECC key pair. Uses system entropy.\n+func newWallet() (*Wallet, error) {\n+\tk, err := ecdsa.GenerateKey(curve, rand.Reader)\n+\tif err != nil {\n+\t\treturn nil, err\n+\t}\n+\tpk := Wallet(k.PublicKey)\n+\treturn &pk, nil","path":"blockchain/wallet.go","position":35,"original_position":35,"commit_id":"4475112cbd506ac8f1c4841b0cb997dbf209bd7b","original_commit_id":"4475112cbd506ac8f1c4841b0cb997dbf209bd7b","user":{"login":"chadlagore","id":12241977,"avatar_url":"https://avatars1.githubusercontent.com/u/12241977?v=3","gravatar_id":"","url":"https://api.github.com/users/chadlagore","html_url":"https://github.com/chadlagore","followers_url":"https://api.github.com/users/chadlagore/followers","following_url":"https://api.github.com/users/chadlagore/following{/other_user}","gists_url":"https://api.github.com/users/chadlagore/gists{/gist_id}","starred_url":"https://api.github.com/users/chadlagore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadlagore/subscriptions","organizations_url":"https://api.github.com/users/chadlagore/orgs","repos_url":"https://api.github.com/users/chadlagore/repos","events_url":"https://api.github.com/users/chadlagore/events{/privacy}","received_events_url":"https://api.github.com/users/chadlagore/received_events","type":"User","site_admin":false},"body":"👍 perhaps the biggest upgrade from C. The `(return value, error)` idiom.","created_at":"2017-05-13T20:49:24Z","updated_at":"2017-05-13T20:50:38Z","html_url":"https://github.com/ubclaunchpad/cumulus/pull/14#discussion_r116367022","pull_request_url":"https://api.github.com/repos/ubclaunchpad/cumulus/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/ubclaunchpad/cumulus/pulls/comments/116367022"},"html":{"href":"https://github.com/ubclaunchpad/cumulus/pull/14#discussion_r116367022"},"pull_request":{"href":"https://api.github.com/repos/ubclaunchpad/cumulus/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/ubclaunchpad/cumulus/pulls/14","id":120460907,"html_url":"https://github.com/ubclaunchpad/cumulus/pull/14","diff_url":"https://github.com/ubclaunchpad/cumulus/pull/14.diff","patch_url":"https://github.com/ubclaunchpad/cumulus/pull/14.patch","issue_url":"https://api.github.com/repos/ubclaunchpad/cumulus/issues/14","number":14,"state":"open","locked":false,"title":"Simple Blockchain","user":{"login":"jordanschalm","id":10557821,"avatar_url":"https://avatars2.githubusercontent.com/u/10557821?v=3","gravatar_id":"","url":"https://api.github.com/users/jordanschalm","html_url":"https://github.com/jordanschalm","followers_url":"https://api.github.com/users/jordanschalm/followers","following_url":"https://api.github.com/users/jordanschalm/following{/other_user}","gists_url":"https://api.github.com/users/jordanschalm/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanschalm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanschalm/subscriptions","organizations_url":"https://api.github.com/users/jordanschalm/orgs","repos_url":"https://api.github.com/users/jordanschalm/repos","events_url":"https://api.github.com/users/jordanschalm/events{/privacy}","received_events_url":"https://api.github.com/users/jordanschalm/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-13T19:45:14Z","updated_at":"2017-05-13T20:50:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8969bc43aa6003e340a60938ee64fdfdfe31947d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ubclaunchpad/cumulus/pulls/14/commits","review_comments_url":"https://api.github.com/repos/ubclaunchpad/cumulus/pulls/14/comments","review_comment_url":"https://api.github.com/repos/ubclaunchpad/cumulus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ubclaunchpad/cumulus/issues/14/comments","statuses_url":"https://api.github.com/repos/ubclaunchpad/cumulus/statuses/4475112cbd506ac8f1c4841b0cb997dbf209bd7b","head":{"label":"ubclaunchpad:10-simple-blockchain","ref":"10-simple-blockchain","sha":"4475112cbd506ac8f1c4841b0cb997dbf209bd7b","user":{"login":"ubclaunchpad","id":12406312,"avatar_url":"https://avatars0.githubusercontent.com/u/12406312?v=3","gravatar_id":"","url":"https://api.github.com/users/ubclaunchpad","html_url":"https://github.com/ubclaunchpad","followers_url":"https://api.github.com/users/ubclaunchpad/followers","following_url":"https://api.github.com/users/ubclaunchpad/following{/other_user}","gists_url":"https://api.github.com/users/ubclaunchpad/gists{/gist_id}","starred_url":"https://api.github.com/users/ubclaunchpad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubclaunchpad/subscriptions","organizations_url":"https://api.github.com/users/ubclaunchpad/orgs","repos_url":"https://api.github.com/users/ubclaunchpad/repos","events_url":"https://api.github.com/users/ubclaunchpad/events{/privacy}","received_events_url":"https://api.github.com/users/ubclaunchpad/received_events","type":"Organization","site_admin":false},"repo":{"id":87681715,"name":"cumulus","full_name":"ubclaunchpad/cumulus","owner":{"login":"ubclaunchpad","id":12406312,"avatar_url":"https://avatars0.githubusercontent.com/u/12406312?v=3","gravatar_id":"","url":"https://api.github.com/users/ubclaunchpad","html_url":"https://github.com/ubclaunchpad","followers_url":"https://api.github.com/users/ubclaunchpad/followers","following_url":"https://api.github.com/users/ubclaunchpad/following{/other_user}","gists_url":"https://api.github.com/users/ubclaunchpad/gists{/gist_id}","starred_url":"https://api.github.com/users/ubclaunchpad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubclaunchpad/subscriptions","organizations_url":"https://api.github.com/users/ubclaunchpad/orgs","repos_url":"https://api.github.com/users/ubclaunchpad/repos","events_url":"https://api.github.com/users/ubclaunchpad/events{/privacy}","received_events_url":"https://api.github.com/users/ubclaunchpad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubclaunchpad/cumulus","description":"Cloud cash 💸","fork":false,"url":"https://api.github.com/repos/ubclaunchpad/cumulus","forks_url":"https://api.github.com/repos/ubclaunchpad/cumulus/forks","keys_url":"https://api.github.com/repos/ubclaunchpad/cumulus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubclaunchpad/cumulus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubclaunchpad/cumulus/teams","hooks_url":"https://api.github.com/repos/ubclaunchpad/cumulus/hooks","issue_events_url":"https://api.github.com/repos/ubclaunchpad/cumulus/issues/events{/number}","events_url":"https://api.github.com/repos/ubclaunchpad/cumulus/events","assignees_url":"https://api.github.com/repos/ubclaunchpad/cumulus/assignees{/user}","branches_url":"https://api.github.com/repos/ubclaunchpad/cumulus/branches{/branch}","tags_url":"https://api.github.com/repos/ubclaunchpad/cumulus/tags","blobs_url":"https://api.github.com/repos/ubclaunchpad/cumulus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubclaunchpad/cumulus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubclaunchpad/cumulus/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubclaunchpad/cumulus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubclaunchpad/cumulus/statuses/{sha}","languages_url":"https://api.github.com/repos/ubclaunchpad/cumulus/languages","stargazers_url":"https://api.github.com/repos/ubclaunchpad/cumulus/stargazers","contributors_url":"https://api.github.com/repos/ubclaunchpad/cumulus/contributors","subscribers_url":"https://api.github.com/repos/ubclaunchpad/cumulus/subscribers","subscription_url":"https://api.github.com/repos/ubclaunchpad/cumulus/subscription","commits_url":"https://api.github.com/repos/ubclaunchpad/cumulus/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubclaunchpad/cumulus/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubclaunchpad/cumulus/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubclaunchpad/cumulus/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubclaunchpad/cumulus/contents/{+path}","compare_url":"https://api.github.com/repos/ubclaunchpad/cumulus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubclaunchpad/cumulus/merges","archive_url":"https://api.github.com/repos/ubclaunchpad/cumulus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubclaunchpad/cumulus/downloads","issues_url":"https://api.github.com/repos/ubclaunchpad/cumulus/issues{/number}","pulls_url":"https://api.github.com/repos/ubclaunchpad/cumulus/pulls{/number}","milestones_url":"https://api.github.com/repos/ubclaunchpad/cumulus/milestones{/number}","notifications_url":"https://api.github.com/repos/ubclaunchpad/cumulus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubclaunchpad/cumulus/labels{/name}","releases_url":"https://api.github.com/repos/ubclaunchpad/cumulus/releases{/id}","deployments_url":"https://api.github.com/repos/ubclaunchpad/cumulus/deployments","created_at":"2017-04-09T04:05:13Z","updated_at":"2017-04-30T01:55:02Z","pushed_at":"2017-05-13T19:45:15Z","git_url":"git://github.com/ubclaunchpad/cumulus.git","ssh_url":"[email protected]:ubclaunchpad/cumulus.git","clone_url":"https://github.com/ubclaunchpad/cumulus.git","svn_url":"https://github.com/ubclaunchpad/cumulus","homepage":null,"size":22,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":0,"default_branch":"dev"}},"base":{"label":"ubclaunchpad:dev","ref":"dev","sha":"8fb32b048bf3750e382a261513ce557ab7b6a621","user":{"login":"ubclaunchpad","id":12406312,"avatar_url":"https://avatars0.githubusercontent.com/u/12406312?v=3","gravatar_id":"","url":"https://api.github.com/users/ubclaunchpad","html_url":"https://github.com/ubclaunchpad","followers_url":"https://api.github.com/users/ubclaunchpad/followers","following_url":"https://api.github.com/users/ubclaunchpad/following{/other_user}","gists_url":"https://api.github.com/users/ubclaunchpad/gists{/gist_id}","starred_url":"https://api.github.com/users/ubclaunchpad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubclaunchpad/subscriptions","organizations_url":"https://api.github.com/users/ubclaunchpad/orgs","repos_url":"https://api.github.com/users/ubclaunchpad/repos","events_url":"https://api.github.com/users/ubclaunchpad/events{/privacy}","received_events_url":"https://api.github.com/users/ubclaunchpad/received_events","type":"Organization","site_admin":false},"repo":{"id":87681715,"name":"cumulus","full_name":"ubclaunchpad/cumulus","owner":{"login":"ubclaunchpad","id":12406312,"avatar_url":"https://avatars0.githubusercontent.com/u/12406312?v=3","gravatar_id":"","url":"https://api.github.com/users/ubclaunchpad","html_url":"https://github.com/ubclaunchpad","followers_url":"https://api.github.com/users/ubclaunchpad/followers","following_url":"https://api.github.com/users/ubclaunchpad/following{/other_user}","gists_url":"https://api.github.com/users/ubclaunchpad/gists{/gist_id}","starred_url":"https://api.github.com/users/ubclaunchpad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ubclaunchpad/subscriptions","organizations_url":"https://api.github.com/users/ubclaunchpad/orgs","repos_url":"https://api.github.com/users/ubclaunchpad/repos","events_url":"https://api.github.com/users/ubclaunchpad/events{/privacy}","received_events_url":"https://api.github.com/users/ubclaunchpad/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ubclaunchpad/cumulus","description":"Cloud cash 💸","fork":false,"url":"https://api.github.com/repos/ubclaunchpad/cumulus","forks_url":"https://api.github.com/repos/ubclaunchpad/cumulus/forks","keys_url":"https://api.github.com/repos/ubclaunchpad/cumulus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ubclaunchpad/cumulus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ubclaunchpad/cumulus/teams","hooks_url":"https://api.github.com/repos/ubclaunchpad/cumulus/hooks","issue_events_url":"https://api.github.com/repos/ubclaunchpad/cumulus/issues/events{/number}","events_url":"https://api.github.com/repos/ubclaunchpad/cumulus/events","assignees_url":"https://api.github.com/repos/ubclaunchpad/cumulus/assignees{/user}","branches_url":"https://api.github.com/repos/ubclaunchpad/cumulus/branches{/branch}","tags_url":"https://api.github.com/repos/ubclaunchpad/cumulus/tags","blobs_url":"https://api.github.com/repos/ubclaunchpad/cumulus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ubclaunchpad/cumulus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ubclaunchpad/cumulus/git/refs{/sha}","trees_url":"https://api.github.com/repos/ubclaunchpad/cumulus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ubclaunchpad/cumulus/statuses/{sha}","languages_url":"https://api.github.com/repos/ubclaunchpad/cumulus/languages","stargazers_url":"https://api.github.com/repos/ubclaunchpad/cumulus/stargazers","contributors_url":"https://api.github.com/repos/ubclaunchpad/cumulus/contributors","subscribers_url":"https://api.github.com/repos/ubclaunchpad/cumulus/subscribers","subscription_url":"https://api.github.com/repos/ubclaunchpad/cumulus/subscription","commits_url":"https://api.github.com/repos/ubclaunchpad/cumulus/commits{/sha}","git_commits_url":"https://api.github.com/repos/ubclaunchpad/cumulus/git/commits{/sha}","comments_url":"https://api.github.com/repos/ubclaunchpad/cumulus/comments{/number}","issue_comment_url":"https://api.github.com/repos/ubclaunchpad/cumulus/issues/comments{/number}","contents_url":"https://api.github.com/repos/ubclaunchpad/cumulus/contents/{+path}","compare_url":"https://api.github.com/repos/ubclaunchpad/cumulus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ubclaunchpad/cumulus/merges","archive_url":"https://api.github.com/repos/ubclaunchpad/cumulus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ubclaunchpad/cumulus/downloads","issues_url":"https://api.github.com/repos/ubclaunchpad/cumulus/issues{/number}","pulls_url":"https://api.github.com/repos/ubclaunchpad/cumulus/pulls{/number}","milestones_url":"https://api.github.com/repos/ubclaunchpad/cumulus/milestones{/number}","notifications_url":"https://api.github.com/repos/ubclaunchpad/cumulus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ubclaunchpad/cumulus/labels{/name}","releases_url":"https://api.github.com/repos/ubclaunchpad/cumulus/releases{/id}","deployments_url":"https://api.github.com/repos/ubclaunchpad/cumulus/deployments","created_at":"2017-04-09T04:05:13Z","updated_at":"2017-04-30T01:55:02Z","pushed_at":"2017-05-13T19:45:15Z","git_url":"git://github.com/ubclaunchpad/cumulus.git","ssh_url":"[email protected]:ubclaunchpad/cumulus.git","clone_url":"https://github.com/ubclaunchpad/cumulus.git","svn_url":"https://github.com/ubclaunchpad/cumulus","homepage":null,"size":22,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":0,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/ubclaunchpad/cumulus/pulls/14"},"html":{"href":"https://github.com/ubclaunchpad/cumulus/pull/14"},"issue":{"href":"https://api.github.com/repos/ubclaunchpad/cumulus/issues/14"},"comments":{"href":"https://api.github.com/repos/ubclaunchpad/cumulus/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/ubclaunchpad/cumulus/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/ubclaunchpad/cumulus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ubclaunchpad/cumulus/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/ubclaunchpad/cumulus/statuses/4475112cbd506ac8f1c4841b0cb997dbf209bd7b"}}}}
|
{
"id": 87681715,
"name": "ubclaunchpad/cumulus",
"url": "https://api.github.com/repos/ubclaunchpad/cumulus"
}
|
{
"id": 12241977,
"login": "chadlagore",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12241977?",
"url": "https://api.github.com/users/chadlagore"
}
|
{
"id": 12406312,
"login": "ubclaunchpad",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12406312?",
"url": "https://api.github.com/orgs/ubclaunchpad"
}
| 2017-05-13T20:49:24 |
5867099189
|
{"actor":{"display_login":"chadlagore"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/weld-project/weld/pulls/comments/144372006","pull_request_review_id":69019640,"id":144372006,"diff_hunk":"@@ -443,7 +431,35 @@ pub fn merge_expr(builder: Expr<Type>, value: Expr<Type>) -> WeldResult<Expr<Typ\n return err;\n }\n }\n- // TODO other builders...\n+ DictMerger(ref elem_ty1, ref elem_ty2, _) => {\n+ if let Struct(ref v_ty) = value.ty {\n+ if elem_ty1.as_ref() != &v_ty[0] {\n+ return err;\n+ }\n+ if elem_ty2.as_ref() != &v_ty[1] {\n+ return err;\n+ }\n+ } else {\n+ return err;\n+ }\n+ }\n+ GroupMerger(ref elem_ty1, ref elem_ty2) => {\n+ if let Struct(ref v_ty) = value.ty {\n+ if elem_ty1.as_ref() != &v_ty[0] {","path":"weld/exprs.rs","position":76,"original_position":76,"commit_id":"45838eda81e02ddcbfe7fd74a10ecb1ae1403351","original_commit_id":"45838eda81e02ddcbfe7fd74a10ecb1ae1403351","user":{"login":"sppalkia","id":1360483,"avatar_url":"https://avatars0.githubusercontent.com/u/1360483?v=4","gravatar_id":"","url":"https://api.github.com/users/sppalkia","html_url":"https://github.com/sppalkia","followers_url":"https://api.github.com/users/sppalkia/followers","following_url":"https://api.github.com/users/sppalkia/following{/other_user}","gists_url":"https://api.github.com/users/sppalkia/gists{/gist_id}","starred_url":"https://api.github.com/users/sppalkia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sppalkia/subscriptions","organizations_url":"https://api.github.com/users/sppalkia/orgs","repos_url":"https://api.github.com/users/sppalkia/repos","events_url":"https://api.github.com/users/sppalkia/events{/privacy}","received_events_url":"https://api.github.com/users/sppalkia/received_events","type":"User","site_admin":false},"body":"Same as above","created_at":"2017-10-12T18:25:57Z","updated_at":"2017-10-12T18:29:38Z","html_url":"https://github.com/weld-project/weld/pull/234#discussion_r144372006","pull_request_url":"https://api.github.com/repos/weld-project/weld/pulls/234","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/weld-project/weld/pulls/comments/144372006"},"html":{"href":"https://github.com/weld-project/weld/pull/234#discussion_r144372006"},"pull_request":{"href":"https://api.github.com/repos/weld-project/weld/pulls/234"}}},"pull_request":{"url":"https://api.github.com/repos/weld-project/weld/pulls/234","id":142695484,"html_url":"https://github.com/weld-project/weld/pull/234","diff_url":"https://github.com/weld-project/weld/pull/234.diff","patch_url":"https://github.com/weld-project/weld/pull/234.patch","issue_url":"https://api.github.com/repos/weld-project/weld/issues/234","number":234,"state":"open","locked":false,"title":"predication for more mergers","user":{"login":"pratiksha","id":553500,"avatar_url":"https://avatars0.githubusercontent.com/u/553500?v=4","gravatar_id":"","url":"https://api.github.com/users/pratiksha","html_url":"https://github.com/pratiksha","followers_url":"https://api.github.com/users/pratiksha/followers","following_url":"https://api.github.com/users/pratiksha/following{/other_user}","gists_url":"https://api.github.com/users/pratiksha/gists{/gist_id}","starred_url":"https://api.github.com/users/pratiksha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pratiksha/subscriptions","organizations_url":"https://api.github.com/users/pratiksha/orgs","repos_url":"https://api.github.com/users/pratiksha/repos","events_url":"https://api.github.com/users/pratiksha/events{/privacy}","received_events_url":"https://api.github.com/users/pratiksha/received_events","type":"User","site_admin":false},"body":"Add predication to DictMerger and VecMerger (in addition to being useful, we'll eventually need this to implement some cost model experiments in Weld).\r\n\r\nI'm not sure about the correctness of `make_select_for_kv` in particular, so a review of that would help!","created_at":"2017-09-23T01:48:33Z","updated_at":"2017-10-12T18:29:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"addde1df3d9cc075b650f6119ddd3f83616da3ee","assignee":null,"assignees":[],"requested_reviewers":[{"login":"deepakn94","id":2724038,"avatar_url":"https://avatars0.githubusercontent.com/u/2724038?v=4","gravatar_id":"","url":"https://api.github.com/users/deepakn94","html_url":"https://github.com/deepakn94","followers_url":"https://api.github.com/users/deepakn94/followers","following_url":"https://api.github.com/users/deepakn94/following{/other_user}","gists_url":"https://api.github.com/users/deepakn94/gists{/gist_id}","starred_url":"https://api.github.com/users/deepakn94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepakn94/subscriptions","organizations_url":"https://api.github.com/users/deepakn94/orgs","repos_url":"https://api.github.com/users/deepakn94/repos","events_url":"https://api.github.com/users/deepakn94/events{/privacy}","received_events_url":"https://api.github.com/users/deepakn94/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/weld-project/weld/pulls/234/commits","review_comments_url":"https://api.github.com/repos/weld-project/weld/pulls/234/comments","review_comment_url":"https://api.github.com/repos/weld-project/weld/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weld-project/weld/issues/234/comments","statuses_url":"https://api.github.com/repos/weld-project/weld/statuses/45838eda81e02ddcbfe7fd74a10ecb1ae1403351","head":{"label":"pratiksha:complete-merge-expr","ref":"complete-merge-expr","sha":"45838eda81e02ddcbfe7fd74a10ecb1ae1403351","user":{"login":"pratiksha","id":553500,"avatar_url":"https://avatars0.githubusercontent.com/u/553500?v=4","gravatar_id":"","url":"https://api.github.com/users/pratiksha","html_url":"https://github.com/pratiksha","followers_url":"https://api.github.com/users/pratiksha/followers","following_url":"https://api.github.com/users/pratiksha/following{/other_user}","gists_url":"https://api.github.com/users/pratiksha/gists{/gist_id}","starred_url":"https://api.github.com/users/pratiksha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pratiksha/subscriptions","organizations_url":"https://api.github.com/users/pratiksha/orgs","repos_url":"https://api.github.com/users/pratiksha/repos","events_url":"https://api.github.com/users/pratiksha/events{/privacy}","received_events_url":"https://api.github.com/users/pratiksha/received_events","type":"User","site_admin":false},"repo":{"id":102075985,"name":"weld","full_name":"pratiksha/weld","owner":{"login":"pratiksha","id":553500,"avatar_url":"https://avatars0.githubusercontent.com/u/553500?v=4","gravatar_id":"","url":"https://api.github.com/users/pratiksha","html_url":"https://github.com/pratiksha","followers_url":"https://api.github.com/users/pratiksha/followers","following_url":"https://api.github.com/users/pratiksha/following{/other_user}","gists_url":"https://api.github.com/users/pratiksha/gists{/gist_id}","starred_url":"https://api.github.com/users/pratiksha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pratiksha/subscriptions","organizations_url":"https://api.github.com/users/pratiksha/orgs","repos_url":"https://api.github.com/users/pratiksha/repos","events_url":"https://api.github.com/users/pratiksha/events{/privacy}","received_events_url":"https://api.github.com/users/pratiksha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pratiksha/weld","description":"Weld is a runtime and language for accelerating data analytics frameworks","fork":true,"url":"https://api.github.com/repos/pratiksha/weld","forks_url":"https://api.github.com/repos/pratiksha/weld/forks","keys_url":"https://api.github.com/repos/pratiksha/weld/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pratiksha/weld/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pratiksha/weld/teams","hooks_url":"https://api.github.com/repos/pratiksha/weld/hooks","issue_events_url":"https://api.github.com/repos/pratiksha/weld/issues/events{/number}","events_url":"https://api.github.com/repos/pratiksha/weld/events","assignees_url":"https://api.github.com/repos/pratiksha/weld/assignees{/user}","branches_url":"https://api.github.com/repos/pratiksha/weld/branches{/branch}","tags_url":"https://api.github.com/repos/pratiksha/weld/tags","blobs_url":"https://api.github.com/repos/pratiksha/weld/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pratiksha/weld/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pratiksha/weld/git/refs{/sha}","trees_url":"https://api.github.com/repos/pratiksha/weld/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pratiksha/weld/statuses/{sha}","languages_url":"https://api.github.com/repos/pratiksha/weld/languages","stargazers_url":"https://api.github.com/repos/pratiksha/weld/stargazers","contributors_url":"https://api.github.com/repos/pratiksha/weld/contributors","subscribers_url":"https://api.github.com/repos/pratiksha/weld/subscribers","subscription_url":"https://api.github.com/repos/pratiksha/weld/subscription","commits_url":"https://api.github.com/repos/pratiksha/weld/commits{/sha}","git_commits_url":"https://api.github.com/repos/pratiksha/weld/git/commits{/sha}","comments_url":"https://api.github.com/repos/pratiksha/weld/comments{/number}","issue_comment_url":"https://api.github.com/repos/pratiksha/weld/issues/comments{/number}","contents_url":"https://api.github.com/repos/pratiksha/weld/contents/{+path}","compare_url":"https://api.github.com/repos/pratiksha/weld/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pratiksha/weld/merges","archive_url":"https://api.github.com/repos/pratiksha/weld/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pratiksha/weld/downloads","issues_url":"https://api.github.com/repos/pratiksha/weld/issues{/number}","pulls_url":"https://api.github.com/repos/pratiksha/weld/pulls{/number}","milestones_url":"https://api.github.com/repos/pratiksha/weld/milestones{/number}","notifications_url":"https://api.github.com/repos/pratiksha/weld/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pratiksha/weld/labels{/name}","releases_url":"https://api.github.com/repos/pratiksha/weld/releases{/id}","deployments_url":"https://api.github.com/repos/pratiksha/weld/deployments","created_at":"2017-09-01T05:11:27Z","updated_at":"2017-09-01T05:11:29Z","pushed_at":"2017-10-12T07:21:45Z","git_url":"git://github.com/pratiksha/weld.git","ssh_url":"[email protected]:pratiksha/weld.git","clone_url":"https://github.com/pratiksha/weld.git","svn_url":"https://github.com/pratiksha/weld","homepage":"weld.stanford.edu","size":1261,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"weld-project:master","ref":"master","sha":"fd3eb873ac28fe1ebb6760a7147855a5c6032a8d","user":{"login":"weld-project","id":23513568,"avatar_url":"https://avatars1.githubusercontent.com/u/23513568?v=4","gravatar_id":"","url":"https://api.github.com/users/weld-project","html_url":"https://github.com/weld-project","followers_url":"https://api.github.com/users/weld-project/followers","following_url":"https://api.github.com/users/weld-project/following{/other_user}","gists_url":"https://api.github.com/users/weld-project/gists{/gist_id}","starred_url":"https://api.github.com/users/weld-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weld-project/subscriptions","organizations_url":"https://api.github.com/users/weld-project/orgs","repos_url":"https://api.github.com/users/weld-project/repos","events_url":"https://api.github.com/users/weld-project/events{/privacy}","received_events_url":"https://api.github.com/users/weld-project/received_events","type":"Organization","site_admin":false},"repo":{"id":61008232,"name":"weld","full_name":"weld-project/weld","owner":{"login":"weld-project","id":23513568,"avatar_url":"https://avatars1.githubusercontent.com/u/23513568?v=4","gravatar_id":"","url":"https://api.github.com/users/weld-project","html_url":"https://github.com/weld-project","followers_url":"https://api.github.com/users/weld-project/followers","following_url":"https://api.github.com/users/weld-project/following{/other_user}","gists_url":"https://api.github.com/users/weld-project/gists{/gist_id}","starred_url":"https://api.github.com/users/weld-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weld-project/subscriptions","organizations_url":"https://api.github.com/users/weld-project/orgs","repos_url":"https://api.github.com/users/weld-project/repos","events_url":"https://api.github.com/users/weld-project/events{/privacy}","received_events_url":"https://api.github.com/users/weld-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/weld-project/weld","description":"High-performance runtime for data analytics applications","fork":false,"url":"https://api.github.com/repos/weld-project/weld","forks_url":"https://api.github.com/repos/weld-project/weld/forks","keys_url":"https://api.github.com/repos/weld-project/weld/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weld-project/weld/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weld-project/weld/teams","hooks_url":"https://api.github.com/repos/weld-project/weld/hooks","issue_events_url":"https://api.github.com/repos/weld-project/weld/issues/events{/number}","events_url":"https://api.github.com/repos/weld-project/weld/events","assignees_url":"https://api.github.com/repos/weld-project/weld/assignees{/user}","branches_url":"https://api.github.com/repos/weld-project/weld/branches{/branch}","tags_url":"https://api.github.com/repos/weld-project/weld/tags","blobs_url":"https://api.github.com/repos/weld-project/weld/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weld-project/weld/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weld-project/weld/git/refs{/sha}","trees_url":"https://api.github.com/repos/weld-project/weld/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weld-project/weld/statuses/{sha}","languages_url":"https://api.github.com/repos/weld-project/weld/languages","stargazers_url":"https://api.github.com/repos/weld-project/weld/stargazers","contributors_url":"https://api.github.com/repos/weld-project/weld/contributors","subscribers_url":"https://api.github.com/repos/weld-project/weld/subscribers","subscription_url":"https://api.github.com/repos/weld-project/weld/subscription","commits_url":"https://api.github.com/repos/weld-project/weld/commits{/sha}","git_commits_url":"https://api.github.com/repos/weld-project/weld/git/commits{/sha}","comments_url":"https://api.github.com/repos/weld-project/weld/comments{/number}","issue_comment_url":"https://api.github.com/repos/weld-project/weld/issues/comments{/number}","contents_url":"https://api.github.com/repos/weld-project/weld/contents/{+path}","compare_url":"https://api.github.com/repos/weld-project/weld/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weld-project/weld/merges","archive_url":"https://api.github.com/repos/weld-project/weld/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weld-project/weld/downloads","issues_url":"https://api.github.com/repos/weld-project/weld/issues{/number}","pulls_url":"https://api.github.com/repos/weld-project/weld/pulls{/number}","milestones_url":"https://api.github.com/repos/weld-project/weld/milestones{/number}","notifications_url":"https://api.github.com/repos/weld-project/weld/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weld-project/weld/labels{/name}","releases_url":"https://api.github.com/repos/weld-project/weld/releases{/id}","deployments_url":"https://api.github.com/repos/weld-project/weld/deployments","created_at":"2016-06-13T05:00:24Z","updated_at":"2017-10-11T18:48:28Z","pushed_at":"2017-10-12T07:21:46Z","git_url":"git://github.com/weld-project/weld.git","ssh_url":"[email protected]:weld-project/weld.git","clone_url":"https://github.com/weld-project/weld.git","svn_url":"https://github.com/weld-project/weld","homepage":"http://weld.stanford.edu","size":1290,"stargazers_count":639,"watchers_count":639,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":34,"forks":69,"open_issues":34,"watchers":639,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weld-project/weld/pulls/234"},"html":{"href":"https://github.com/weld-project/weld/pull/234"},"issue":{"href":"https://api.github.com/repos/weld-project/weld/issues/234"},"comments":{"href":"https://api.github.com/repos/weld-project/weld/issues/234/comments"},"review_comments":{"href":"https://api.github.com/repos/weld-project/weld/pulls/234/comments"},"review_comment":{"href":"https://api.github.com/repos/weld-project/weld/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weld-project/weld/pulls/234/commits"},"statuses":{"href":"https://api.github.com/repos/weld-project/weld/statuses/45838eda81e02ddcbfe7fd74a10ecb1ae1403351"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 61008232,
"name": "weld-project/weld",
"url": "https://api.github.com/repos/weld-project/weld"
}
|
{
"id": 1360483,
"login": "sppalkia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1360483?",
"url": "https://api.github.com/users/sppalkia"
}
|
{
"id": 23513568,
"login": "weld-project",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23513568?",
"url": "https://api.github.com/orgs/weld-project"
}
| 2017-10-12T18:25:57 |
6709625940
|
{"actor":{"display_login":"sppalkia"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/comments/108035051","pull_request_review_id":29046257,"id":108035051,"diff_hunk":"@@ -0,0 +1,71 @@\n+\n+// The 'if' statement below is added because the asset pipeline (which includes\n+// this file) is loaded *before* the Ckeditor code (which defines the\n+// CKEDITOR var, and which is loaded from CDN in\n+// views/layouts/application.html.haml).\n+\n+if(typeof(CKEDITOR) != 'undefined') {\n+ CKEDITOR.editorConfig = function( config )\n+ {\n+ // Define changes to default configuration here. For example:\n+ // config.language = 'fr';\n+ // config.uiColor = '#AADC6E';\n+\n+ config.language = I18n.locale;\n+ config.height = 250;\n+ config.removePlugins = 'flash';\n+ config.removeDialogTabs = 'image:advanced';\n+ config.filebrowserWindowWidth = '500';\n+ config.filebrowserWindowHeight = '400';\n+ config.linkShowAdvancedTab = false;\n+ config.linkShowTargetTab = false;\n+ config.contentsCss = '/assets/ckeditor/contents.css';\n+\n+ /* Filebrowser routes */\n+ // The location of an external file browser, that should be launched when \"Browse Server\" button is pressed.\n+ config.filebrowserBrowseUrl = \"/ckeditor/attachment_files\";\n+\n+ // The location of an external file browser, that should be launched when \"Browse Server\" button is pressed in the Flash dialog.\n+ config.filebrowserFlashBrowseUrl = \"/ckeditor/attachment_files\";\n+\n+ // The location of a script that handles file uploads in the Flash dialog.\n+ config.filebrowserFlashUploadUrl = \"/ckeditor/attachment_files\";\n+\n+ // The location of an external file browser, that should be launched when \"Browse Server\" button is pressed in the Link tab of Image dialog.\n+ config.filebrowserImageBrowseLinkUrl = \"/ckeditor/pictures\";\n+\n+ // The location of an external file browser, that should be launched when \"Browse Server\" button is pressed in the Image dialog.\n+ config.filebrowserImageBrowseUrl = \"/ckeditor/pictures\";\n+\n+ // The location of a script that handles file uploads in the Image dialog.\n+ config.filebrowserImageUploadUrl = \"/ckeditor/pictures\";\n+\n+ // The location of a script that handles file uploads.\n+ config.filebrowserUploadUrl = \"/ckeditor/attachment_files\";\n+\n+ config.allowedContent = true;\n+\n+ // Toolbar groups configuration.\n+ config.toolbar = [\n+ { name: 'document', groups: [ 'mode', 'document', 'doctools' ], items: [ 'Source'] },\n+ { name: 'clipboard', groups: [ 'clipboard', 'undo' ], items: [ 'Cut', 'Copy', 'Paste', 'PasteText', 'PasteFromWord', '-', 'Undo', 'Redo' ] },\n+ // { name: 'editing', groups: [ 'find', 'selection', 'spellchecker' ], items: [ 'Find', 'Replace', '-', 'SelectAll', '-', 'Scayt' ] },\n+ // { name: 'forms', items: [ 'Form', 'Checkbox', 'Radio', 'TextField', 'Textarea', 'Select', 'Button', 'ImageButton', 'HiddenField' ] },\n+ { name: 'links', items: [ 'Link', 'Unlink', 'Anchor' ] },\n+ { name: 'insert', items: [ 'Image', 'Flash', 'Table', 'HorizontalRule', 'SpecialChar' ] },\n+ { name: 'paragraph', groups: [ 'list', 'indent', 'blocks', 'align', 'bidi' ], items: [ 'NumberedList', 'BulletedList', '-', 'Outdent', 'Indent', '-', 'Blockquote', 'CreateDiv', '-', 'JustifyLeft', 'JustifyCenter', 'JustifyRight', 'JustifyBlock' ] },","path":"app/assets/javascripts/ckeditor/config.js","position":56,"original_position":56,"commit_id":"fe29bdc30068eb603adb347f9c5a1fa59df20f19","original_commit_id":"fe29bdc30068eb603adb347f9c5a1fa59df20f19","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars3.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Line is too long.","created_at":"2017-03-25T12:21:57Z","updated_at":"2017-03-25T12:21:58Z","html_url":"https://github.com/AgileVentures/shf-project/pull/189#discussion_r108035051","pull_request_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/189","_links":{"self":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/comments/108035051"},"html":{"href":"https://github.com/AgileVentures/shf-project/pull/189#discussion_r108035051"},"pull_request":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/189"}}},"pull_request":{"url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/189","id":110511521,"html_url":"https://github.com/AgileVentures/shf-project/pull/189","diff_url":"https://github.com/AgileVentures/shf-project/pull/189.diff","patch_url":"https://github.com/AgileVentures/shf-project/pull/189.patch","issue_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/189","number":189,"state":"open","locked":false,"title":"WIP - Edit company info #136724617","user":{"login":"patmbolger","id":9968213,"avatar_url":"https://avatars0.githubusercontent.com/u/9968213?v=3","gravatar_id":"","url":"https://api.github.com/users/patmbolger","html_url":"https://github.com/patmbolger","followers_url":"https://api.github.com/users/patmbolger/followers","following_url":"https://api.github.com/users/patmbolger/following{/other_user}","gists_url":"https://api.github.com/users/patmbolger/gists{/gist_id}","starred_url":"https://api.github.com/users/patmbolger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patmbolger/subscriptions","organizations_url":"https://api.github.com/users/patmbolger/orgs","repos_url":"https://api.github.com/users/patmbolger/repos","events_url":"https://api.github.com/users/patmbolger/events{/privacy}","received_events_url":"https://api.github.com/users/patmbolger/received_events","type":"User","site_admin":false},"body":"PT Story: https://www.pivotaltracker.com/story/show/136724617\r\n\r\n\r\nChanges proposed in this pull request:\r\n1. Embed ckeditor as in-line editor in company edit form.\r\n2. Add `info` attribute to Company model (used to store company info text in DB (images stored on file system))\r\n3. Add company info to companies#show view\r\n4. Add migrations for ckeditor STI table and for `info` field added to Company\r\n\r\nScreenshots (Optional):\r\n<hr>\r\nCompany info edit:\r\n<img width=\"745\" alt=\"screen shot 2017-03-13 at 6 21 05 pm\" src=\"https://cloud.githubusercontent.com/assets/9968213/23877697/e33047a4-0819-11e7-9a94-aca1878a5d43.png\">\r\n\r\n\r\n<hr>\r\nCompany info show:\r\n<img width=\"760\" alt=\"screen shot 2017-03-13 at 6 21 55 pm\" src=\"https://cloud.githubusercontent.com/assets/9968213/23877713/f7257266-0819-11e7-801c-b5c0ac5aaa41.png\">\r\n\r\n<hr>\r\nckeditor files manager (used to show images on server - for companies `info`):\r\n\r\n<img width=\"866\" alt=\"screen shot 2017-03-13 at 6 20 06 pm\" src=\"https://cloud.githubusercontent.com/assets/9968213/23877742/230dbbd6-081a-11e7-9bb9-102e26c04972.png\">\r\n\r\nReady for review:\r\n@weedySeaDragon \r\n@thesuss \r\n\r\n### Questions / points for consideration:\r\n\r\n1. I am storing the `info` text in the DB (images are store in file system). I think this is reasonable since company info text will not approach a huge size.\r\n\r\n2. I am not limiting the number of characters that could go into the `info` field (I believe there are plug-ins for ckeditor that could do that). The primary reason is that I don't see it as a problem since the user will see a limited window for editing (sized to typical size of `info` text plus image), and 3) `info` that is too large will push down other information in the company show page that the user will not want to get lost.\r\n\r\n3) The images stored on the server are _not_ isolated by company (see screenshot above - all images associated with companies info are seen in the files manager window). Do we need to isolate images shown by company? (I don't see the images as very proprietary - on the other hand, a user could accidentally delete the image used by another company).\r\n\r\n4) In the #show view I have the company `info` at the top, and the address and map (coming soon) below that.","created_at":"2017-03-13T22:28:19Z","updated_at":"2017-03-25T12:21:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7cacbc377443bd8befb41b31e2bb05c6308d88f2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/189/commits","review_comments_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/189/comments","review_comment_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/189/comments","statuses_url":"https://api.github.com/repos/AgileVentures/shf-project/statuses/fe29bdc30068eb603adb347f9c5a1fa59df20f19","head":{"label":"patmbolger:edit-company-info#136724617","ref":"edit-company-info#136724617","sha":"fe29bdc30068eb603adb347f9c5a1fa59df20f19","user":{"login":"patmbolger","id":9968213,"avatar_url":"https://avatars0.githubusercontent.com/u/9968213?v=3","gravatar_id":"","url":"https://api.github.com/users/patmbolger","html_url":"https://github.com/patmbolger","followers_url":"https://api.github.com/users/patmbolger/followers","following_url":"https://api.github.com/users/patmbolger/following{/other_user}","gists_url":"https://api.github.com/users/patmbolger/gists{/gist_id}","starred_url":"https://api.github.com/users/patmbolger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patmbolger/subscriptions","organizations_url":"https://api.github.com/users/patmbolger/orgs","repos_url":"https://api.github.com/users/patmbolger/repos","events_url":"https://api.github.com/users/patmbolger/events{/privacy}","received_events_url":"https://api.github.com/users/patmbolger/received_events","type":"User","site_admin":false},"repo":{"id":74601752,"name":"shf-project","full_name":"patmbolger/shf-project","owner":{"login":"patmbolger","id":9968213,"avatar_url":"https://avatars0.githubusercontent.com/u/9968213?v=3","gravatar_id":"","url":"https://api.github.com/users/patmbolger","html_url":"https://github.com/patmbolger","followers_url":"https://api.github.com/users/patmbolger/followers","following_url":"https://api.github.com/users/patmbolger/following{/other_user}","gists_url":"https://api.github.com/users/patmbolger/gists{/gist_id}","starred_url":"https://api.github.com/users/patmbolger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patmbolger/subscriptions","organizations_url":"https://api.github.com/users/patmbolger/orgs","repos_url":"https://api.github.com/users/patmbolger/repos","events_url":"https://api.github.com/users/patmbolger/events{/privacy}","received_events_url":"https://api.github.com/users/patmbolger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/patmbolger/shf-project","description":null,"fork":true,"url":"https://api.github.com/repos/patmbolger/shf-project","forks_url":"https://api.github.com/repos/patmbolger/shf-project/forks","keys_url":"https://api.github.com/repos/patmbolger/shf-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patmbolger/shf-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patmbolger/shf-project/teams","hooks_url":"https://api.github.com/repos/patmbolger/shf-project/hooks","issue_events_url":"https://api.github.com/repos/patmbolger/shf-project/issues/events{/number}","events_url":"https://api.github.com/repos/patmbolger/shf-project/events","assignees_url":"https://api.github.com/repos/patmbolger/shf-project/assignees{/user}","branches_url":"https://api.github.com/repos/patmbolger/shf-project/branches{/branch}","tags_url":"https://api.github.com/repos/patmbolger/shf-project/tags","blobs_url":"https://api.github.com/repos/patmbolger/shf-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patmbolger/shf-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patmbolger/shf-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/patmbolger/shf-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patmbolger/shf-project/statuses/{sha}","languages_url":"https://api.github.com/repos/patmbolger/shf-project/languages","stargazers_url":"https://api.github.com/repos/patmbolger/shf-project/stargazers","contributors_url":"https://api.github.com/repos/patmbolger/shf-project/contributors","subscribers_url":"https://api.github.com/repos/patmbolger/shf-project/subscribers","subscription_url":"https://api.github.com/repos/patmbolger/shf-project/subscription","commits_url":"https://api.github.com/repos/patmbolger/shf-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/patmbolger/shf-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/patmbolger/shf-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/patmbolger/shf-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/patmbolger/shf-project/contents/{+path}","compare_url":"https://api.github.com/repos/patmbolger/shf-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patmbolger/shf-project/merges","archive_url":"https://api.github.com/repos/patmbolger/shf-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patmbolger/shf-project/downloads","issues_url":"https://api.github.com/repos/patmbolger/shf-project/issues{/number}","pulls_url":"https://api.github.com/repos/patmbolger/shf-project/pulls{/number}","milestones_url":"https://api.github.com/repos/patmbolger/shf-project/milestones{/number}","notifications_url":"https://api.github.com/repos/patmbolger/shf-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patmbolger/shf-project/labels{/name}","releases_url":"https://api.github.com/repos/patmbolger/shf-project/releases{/id}","deployments_url":"https://api.github.com/repos/patmbolger/shf-project/deployments","created_at":"2016-11-23T18:02:48Z","updated_at":"2017-02-12T13:20:15Z","pushed_at":"2017-03-25T12:21:41Z","git_url":"git://github.com/patmbolger/shf-project.git","ssh_url":"[email protected]:patmbolger/shf-project.git","clone_url":"https://github.com/patmbolger/shf-project.git","svn_url":"https://github.com/patmbolger/shf-project","homepage":null,"size":22785,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"AgileVentures:develop","ref":"develop","sha":"1f356d7de69726c658a32e7e9961e957cce66c28","user":{"login":"AgileVentures","id":5116968,"avatar_url":"https://avatars3.githubusercontent.com/u/5116968?v=3","gravatar_id":"","url":"https://api.github.com/users/AgileVentures","html_url":"https://github.com/AgileVentures","followers_url":"https://api.github.com/users/AgileVentures/followers","following_url":"https://api.github.com/users/AgileVentures/following{/other_user}","gists_url":"https://api.github.com/users/AgileVentures/gists{/gist_id}","starred_url":"https://api.github.com/users/AgileVentures/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgileVentures/subscriptions","organizations_url":"https://api.github.com/users/AgileVentures/orgs","repos_url":"https://api.github.com/users/AgileVentures/repos","events_url":"https://api.github.com/users/AgileVentures/events{/privacy}","received_events_url":"https://api.github.com/users/AgileVentures/received_events","type":"Organization","site_admin":false},"repo":{"id":71157737,"name":"shf-project","full_name":"AgileVentures/shf-project","owner":{"login":"AgileVentures","id":5116968,"avatar_url":"https://avatars3.githubusercontent.com/u/5116968?v=3","gravatar_id":"","url":"https://api.github.com/users/AgileVentures","html_url":"https://github.com/AgileVentures","followers_url":"https://api.github.com/users/AgileVentures/followers","following_url":"https://api.github.com/users/AgileVentures/following{/other_user}","gists_url":"https://api.github.com/users/AgileVentures/gists{/gist_id}","starred_url":"https://api.github.com/users/AgileVentures/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AgileVentures/subscriptions","organizations_url":"https://api.github.com/users/AgileVentures/orgs","repos_url":"https://api.github.com/users/AgileVentures/repos","events_url":"https://api.github.com/users/AgileVentures/events{/privacy}","received_events_url":"https://api.github.com/users/AgileVentures/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AgileVentures/shf-project","description":null,"fork":true,"url":"https://api.github.com/repos/AgileVentures/shf-project","forks_url":"https://api.github.com/repos/AgileVentures/shf-project/forks","keys_url":"https://api.github.com/repos/AgileVentures/shf-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AgileVentures/shf-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AgileVentures/shf-project/teams","hooks_url":"https://api.github.com/repos/AgileVentures/shf-project/hooks","issue_events_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/events{/number}","events_url":"https://api.github.com/repos/AgileVentures/shf-project/events","assignees_url":"https://api.github.com/repos/AgileVentures/shf-project/assignees{/user}","branches_url":"https://api.github.com/repos/AgileVentures/shf-project/branches{/branch}","tags_url":"https://api.github.com/repos/AgileVentures/shf-project/tags","blobs_url":"https://api.github.com/repos/AgileVentures/shf-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AgileVentures/shf-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AgileVentures/shf-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/AgileVentures/shf-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AgileVentures/shf-project/statuses/{sha}","languages_url":"https://api.github.com/repos/AgileVentures/shf-project/languages","stargazers_url":"https://api.github.com/repos/AgileVentures/shf-project/stargazers","contributors_url":"https://api.github.com/repos/AgileVentures/shf-project/contributors","subscribers_url":"https://api.github.com/repos/AgileVentures/shf-project/subscribers","subscription_url":"https://api.github.com/repos/AgileVentures/shf-project/subscription","commits_url":"https://api.github.com/repos/AgileVentures/shf-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/AgileVentures/shf-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/AgileVentures/shf-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/AgileVentures/shf-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/AgileVentures/shf-project/contents/{+path}","compare_url":"https://api.github.com/repos/AgileVentures/shf-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AgileVentures/shf-project/merges","archive_url":"https://api.github.com/repos/AgileVentures/shf-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AgileVentures/shf-project/downloads","issues_url":"https://api.github.com/repos/AgileVentures/shf-project/issues{/number}","pulls_url":"https://api.github.com/repos/AgileVentures/shf-project/pulls{/number}","milestones_url":"https://api.github.com/repos/AgileVentures/shf-project/milestones{/number}","notifications_url":"https://api.github.com/repos/AgileVentures/shf-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AgileVentures/shf-project/labels{/name}","releases_url":"https://api.github.com/repos/AgileVentures/shf-project/releases{/id}","deployments_url":"https://api.github.com/repos/AgileVentures/shf-project/deployments","created_at":"2016-10-17T16:18:10Z","updated_at":"2016-12-02T13:34:05Z","pushed_at":"2017-03-25T12:21:43Z","git_url":"git://github.com/AgileVentures/shf-project.git","ssh_url":"[email protected]:AgileVentures/shf-project.git","clone_url":"https://github.com/AgileVentures/shf-project.git","svn_url":"https://github.com/AgileVentures/shf-project","homepage":null,"size":22597,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":4,"forks":10,"open_issues":4,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/189"},"html":{"href":"https://github.com/AgileVentures/shf-project/pull/189"},"issue":{"href":"https://api.github.com/repos/AgileVentures/shf-project/issues/189"},"comments":{"href":"https://api.github.com/repos/AgileVentures/shf-project/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AgileVentures/shf-project/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/AgileVentures/shf-project/statuses/fe29bdc30068eb603adb347f9c5a1fa59df20f19"}}}}
|
{
"id": 71157737,
"name": "AgileVentures/shf-project",
"url": "https://api.github.com/repos/AgileVentures/shf-project"
}
|
{
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
}
|
{
"id": 5116968,
"login": "AgileVentures",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5116968?",
"url": "https://api.github.com/orgs/AgileVentures"
}
| 2017-03-25T12:21:57 |
5562955125
|
{"actor":{"display_login":"houndci-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/comments/159114623","pull_request_review_id":86022376,"id":159114623,"diff_hunk":"@@ -165,6 +177,7 @@\n \t\t\tcheck_anomalies = value\n \n \t\tupdateTurrets()\n+\t\tupdate_icon()\n \t\treturn 1\n \n /obj/machinery/turretid/proc/updateTurrets()","path":"code/game/machinery/turret_control.dm","position":51,"original_position":51,"commit_id":"81ac597c3cf03e2c5290d00ff6abddcf732bca4f","original_commit_id":"81ac597c3cf03e2c5290d00ff6abddcf732bca4f","user":{"login":"skull132","id":6318408,"avatar_url":"https://avatars3.githubusercontent.com/u/6318408?v=4","gravatar_id":"","url":"https://api.github.com/users/skull132","html_url":"https://github.com/skull132","followers_url":"https://api.github.com/users/skull132/followers","following_url":"https://api.github.com/users/skull132/following{/other_user}","gists_url":"https://api.github.com/users/skull132/gists{/gist_id}","starred_url":"https://api.github.com/users/skull132/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skull132/subscriptions","organizations_url":"https://api.github.com/users/skull132/orgs","repos_url":"https://api.github.com/users/skull132/repos","events_url":"https://api.github.com/users/skull132/events{/privacy}","received_events_url":"https://api.github.com/users/skull132/received_events","type":"User","site_admin":false},"body":"Since `getState` is a thing, change line 184 to be `var/datum/turret_checks/TC = getState()`","created_at":"2017-12-30T01:40:44Z","updated_at":"2017-12-30T01:41:28Z","html_url":"https://github.com/Aurorastation/Aurora.3/pull/4012#discussion_r159114623","pull_request_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/4012","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/comments/159114623"},"html":{"href":"https://github.com/Aurorastation/Aurora.3/pull/4012#discussion_r159114623"},"pull_request":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/4012"}}},"pull_request":{"url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/4012","id":159943525,"html_url":"https://github.com/Aurorastation/Aurora.3/pull/4012","diff_url":"https://github.com/Aurorastation/Aurora.3/pull/4012.diff","patch_url":"https://github.com/Aurorastation/Aurora.3/pull/4012.patch","issue_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/4012","number":4012,"state":"open","locked":false,"title":"Turrets fix","user":{"login":"Sindorman","id":25555314,"avatar_url":"https://avatars2.githubusercontent.com/u/25555314?v=4","gravatar_id":"","url":"https://api.github.com/users/Sindorman","html_url":"https://github.com/Sindorman","followers_url":"https://api.github.com/users/Sindorman/followers","following_url":"https://api.github.com/users/Sindorman/following{/other_user}","gists_url":"https://api.github.com/users/Sindorman/gists{/gist_id}","starred_url":"https://api.github.com/users/Sindorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sindorman/subscriptions","organizations_url":"https://api.github.com/users/Sindorman/orgs","repos_url":"https://api.github.com/users/Sindorman/repos","events_url":"https://api.github.com/users/Sindorman/events{/privacy}","received_events_url":"https://api.github.com/users/Sindorman/received_events","type":"User","site_admin":false},"body":"- Issue #3980 \r\n\r\n- Turret controls with lethal only turrets cannot switch between modes.\r\n\r\n- Turret controls that have turrets with mixed modes now will disable lethal only turrets in stun mode.\r\n\r\n- Turrets now have same fire rate as the gun they have inside.\r\n\r\nThis is what I made. https://1drv.ms/v/s!Ak8pUCKohmprn65-UUV7PWb5bqcqkg\r\nLeft Turret is made from carbine(both modes), middle from laser(one mode, lethal), right is made from taser(one mode, stun).","created_at":"2017-12-22T22:54:35Z","updated_at":"2017-12-30T01:41:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef5ab7a698fca64f37d8933091321e56a179e239","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/4012/commits","review_comments_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/4012/comments","review_comment_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/4012/comments","statuses_url":"https://api.github.com/repos/Aurorastation/Aurora.3/statuses/81ac597c3cf03e2c5290d00ff6abddcf732bca4f","head":{"label":"Sindorman:turret-fix","ref":"turret-fix","sha":"81ac597c3cf03e2c5290d00ff6abddcf732bca4f","user":{"login":"Sindorman","id":25555314,"avatar_url":"https://avatars2.githubusercontent.com/u/25555314?v=4","gravatar_id":"","url":"https://api.github.com/users/Sindorman","html_url":"https://github.com/Sindorman","followers_url":"https://api.github.com/users/Sindorman/followers","following_url":"https://api.github.com/users/Sindorman/following{/other_user}","gists_url":"https://api.github.com/users/Sindorman/gists{/gist_id}","starred_url":"https://api.github.com/users/Sindorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sindorman/subscriptions","organizations_url":"https://api.github.com/users/Sindorman/orgs","repos_url":"https://api.github.com/users/Sindorman/repos","events_url":"https://api.github.com/users/Sindorman/events{/privacy}","received_events_url":"https://api.github.com/users/Sindorman/received_events","type":"User","site_admin":false},"repo":{"id":110596760,"name":"Aurora.3","full_name":"Sindorman/Aurora.3","owner":{"login":"Sindorman","id":25555314,"avatar_url":"https://avatars2.githubusercontent.com/u/25555314?v=4","gravatar_id":"","url":"https://api.github.com/users/Sindorman","html_url":"https://github.com/Sindorman","followers_url":"https://api.github.com/users/Sindorman/followers","following_url":"https://api.github.com/users/Sindorman/following{/other_user}","gists_url":"https://api.github.com/users/Sindorman/gists{/gist_id}","starred_url":"https://api.github.com/users/Sindorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sindorman/subscriptions","organizations_url":"https://api.github.com/users/Sindorman/orgs","repos_url":"https://api.github.com/users/Sindorman/repos","events_url":"https://api.github.com/users/Sindorman/events{/privacy}","received_events_url":"https://api.github.com/users/Sindorman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sindorman/Aurora.3","description":"The code for Aurorastation's new base, forked from Baystation12.","fork":true,"url":"https://api.github.com/repos/Sindorman/Aurora.3","forks_url":"https://api.github.com/repos/Sindorman/Aurora.3/forks","keys_url":"https://api.github.com/repos/Sindorman/Aurora.3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sindorman/Aurora.3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sindorman/Aurora.3/teams","hooks_url":"https://api.github.com/repos/Sindorman/Aurora.3/hooks","issue_events_url":"https://api.github.com/repos/Sindorman/Aurora.3/issues/events{/number}","events_url":"https://api.github.com/repos/Sindorman/Aurora.3/events","assignees_url":"https://api.github.com/repos/Sindorman/Aurora.3/assignees{/user}","branches_url":"https://api.github.com/repos/Sindorman/Aurora.3/branches{/branch}","tags_url":"https://api.github.com/repos/Sindorman/Aurora.3/tags","blobs_url":"https://api.github.com/repos/Sindorman/Aurora.3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sindorman/Aurora.3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sindorman/Aurora.3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sindorman/Aurora.3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sindorman/Aurora.3/statuses/{sha}","languages_url":"https://api.github.com/repos/Sindorman/Aurora.3/languages","stargazers_url":"https://api.github.com/repos/Sindorman/Aurora.3/stargazers","contributors_url":"https://api.github.com/repos/Sindorman/Aurora.3/contributors","subscribers_url":"https://api.github.com/repos/Sindorman/Aurora.3/subscribers","subscription_url":"https://api.github.com/repos/Sindorman/Aurora.3/subscription","commits_url":"https://api.github.com/repos/Sindorman/Aurora.3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sindorman/Aurora.3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sindorman/Aurora.3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sindorman/Aurora.3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sindorman/Aurora.3/contents/{+path}","compare_url":"https://api.github.com/repos/Sindorman/Aurora.3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sindorman/Aurora.3/merges","archive_url":"https://api.github.com/repos/Sindorman/Aurora.3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sindorman/Aurora.3/downloads","issues_url":"https://api.github.com/repos/Sindorman/Aurora.3/issues{/number}","pulls_url":"https://api.github.com/repos/Sindorman/Aurora.3/pulls{/number}","milestones_url":"https://api.github.com/repos/Sindorman/Aurora.3/milestones{/number}","notifications_url":"https://api.github.com/repos/Sindorman/Aurora.3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sindorman/Aurora.3/labels{/name}","releases_url":"https://api.github.com/repos/Sindorman/Aurora.3/releases{/id}","deployments_url":"https://api.github.com/repos/Sindorman/Aurora.3/deployments","created_at":"2017-11-13T20:13:02Z","updated_at":"2017-11-13T20:13:15Z","pushed_at":"2017-12-30T01:30:11Z","git_url":"git://github.com/Sindorman/Aurora.3.git","ssh_url":"[email protected]:Sindorman/Aurora.3.git","clone_url":"https://github.com/Sindorman/Aurora.3.git","svn_url":"https://github.com/Sindorman/Aurora.3","homepage":"http://aurorastation.org/","size":672102,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Aurorastation:master","ref":"master","sha":"c7a979398fa9c4115b8dc645db1092b42e79abb4","user":{"login":"Aurorastation","id":6915762,"avatar_url":"https://avatars2.githubusercontent.com/u/6915762?v=4","gravatar_id":"","url":"https://api.github.com/users/Aurorastation","html_url":"https://github.com/Aurorastation","followers_url":"https://api.github.com/users/Aurorastation/followers","following_url":"https://api.github.com/users/Aurorastation/following{/other_user}","gists_url":"https://api.github.com/users/Aurorastation/gists{/gist_id}","starred_url":"https://api.github.com/users/Aurorastation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aurorastation/subscriptions","organizations_url":"https://api.github.com/users/Aurorastation/orgs","repos_url":"https://api.github.com/users/Aurorastation/repos","events_url":"https://api.github.com/users/Aurorastation/events{/privacy}","received_events_url":"https://api.github.com/users/Aurorastation/received_events","type":"Organization","site_admin":false},"repo":{"id":42579199,"name":"Aurora.3","full_name":"Aurorastation/Aurora.3","owner":{"login":"Aurorastation","id":6915762,"avatar_url":"https://avatars2.githubusercontent.com/u/6915762?v=4","gravatar_id":"","url":"https://api.github.com/users/Aurorastation","html_url":"https://github.com/Aurorastation","followers_url":"https://api.github.com/users/Aurorastation/followers","following_url":"https://api.github.com/users/Aurorastation/following{/other_user}","gists_url":"https://api.github.com/users/Aurorastation/gists{/gist_id}","starred_url":"https://api.github.com/users/Aurorastation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aurorastation/subscriptions","organizations_url":"https://api.github.com/users/Aurorastation/orgs","repos_url":"https://api.github.com/users/Aurorastation/repos","events_url":"https://api.github.com/users/Aurorastation/events{/privacy}","received_events_url":"https://api.github.com/users/Aurorastation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Aurorastation/Aurora.3","description":"The code for Aurorastation's new base, forked from Baystation12.","fork":false,"url":"https://api.github.com/repos/Aurorastation/Aurora.3","forks_url":"https://api.github.com/repos/Aurorastation/Aurora.3/forks","keys_url":"https://api.github.com/repos/Aurorastation/Aurora.3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Aurorastation/Aurora.3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Aurorastation/Aurora.3/teams","hooks_url":"https://api.github.com/repos/Aurorastation/Aurora.3/hooks","issue_events_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/events{/number}","events_url":"https://api.github.com/repos/Aurorastation/Aurora.3/events","assignees_url":"https://api.github.com/repos/Aurorastation/Aurora.3/assignees{/user}","branches_url":"https://api.github.com/repos/Aurorastation/Aurora.3/branches{/branch}","tags_url":"https://api.github.com/repos/Aurorastation/Aurora.3/tags","blobs_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Aurorastation/Aurora.3/statuses/{sha}","languages_url":"https://api.github.com/repos/Aurorastation/Aurora.3/languages","stargazers_url":"https://api.github.com/repos/Aurorastation/Aurora.3/stargazers","contributors_url":"https://api.github.com/repos/Aurorastation/Aurora.3/contributors","subscribers_url":"https://api.github.com/repos/Aurorastation/Aurora.3/subscribers","subscription_url":"https://api.github.com/repos/Aurorastation/Aurora.3/subscription","commits_url":"https://api.github.com/repos/Aurorastation/Aurora.3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Aurorastation/Aurora.3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Aurorastation/Aurora.3/contents/{+path}","compare_url":"https://api.github.com/repos/Aurorastation/Aurora.3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Aurorastation/Aurora.3/merges","archive_url":"https://api.github.com/repos/Aurorastation/Aurora.3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Aurorastation/Aurora.3/downloads","issues_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues{/number}","pulls_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls{/number}","milestones_url":"https://api.github.com/repos/Aurorastation/Aurora.3/milestones{/number}","notifications_url":"https://api.github.com/repos/Aurorastation/Aurora.3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Aurorastation/Aurora.3/labels{/name}","releases_url":"https://api.github.com/repos/Aurorastation/Aurora.3/releases{/id}","deployments_url":"https://api.github.com/repos/Aurorastation/Aurora.3/deployments","created_at":"2015-09-16T09:56:37Z","updated_at":"2017-12-13T04:59:22Z","pushed_at":"2017-12-30T01:30:13Z","git_url":"git://github.com/Aurorastation/Aurora.3.git","ssh_url":"[email protected]:Aurorastation/Aurora.3.git","clone_url":"https://github.com/Aurorastation/Aurora.3.git","svn_url":"https://github.com/Aurorastation/Aurora.3","homepage":"http://aurorastation.org/","size":674432,"stargazers_count":25,"watchers_count":25,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":101,"mirror_url":null,"archived":false,"open_issues_count":491,"license":null,"forks":101,"open_issues":491,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/4012"},"html":{"href":"https://github.com/Aurorastation/Aurora.3/pull/4012"},"issue":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/4012"},"comments":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/4012/comments"},"review_comments":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/4012/comments"},"review_comment":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/4012/commits"},"statuses":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/statuses/81ac597c3cf03e2c5290d00ff6abddcf732bca4f"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 42579199,
"name": "Aurorastation/Aurora.3",
"url": "https://api.github.com/repos/Aurorastation/Aurora.3"
}
|
{
"id": 6318408,
"login": "skull132",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6318408?",
"url": "https://api.github.com/users/skull132"
}
|
{
"id": 6915762,
"login": "Aurorastation",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6915762?",
"url": "https://api.github.com/orgs/Aurorastation"
}
| 2017-12-30T01:40:44 |
7041845043
|
{"actor":{"display_login":"skull132"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/comments/135415907","pull_request_review_id":58826867,"id":135415907,"diff_hunk":"@@ -110,3 +111,144 @@\n \n \n \treturn \"You will now heal twice as much, but take twice as much damage. It will probably kill you.\"\n+\n+/spell/targeted/mend\n+\tname = \"Mend Wounds\"\n+\tdesc = \"This spell heals internal wounds and broken bones.\"\n+\tfeedback = \"MW\"\n+\tspell_flags = INCLUDEUSER | SELECTABLE | NEEDSCLOTHES\n+\tinvocation = \"Ges'undh'eit\"","path":"code/modules/spells/targeted/cleric_spells.dm","position":45,"original_position":45,"commit_id":"e922593779e29e55617fd36e49b50db1f741e675","original_commit_id":"e922593779e29e55617fd36e49b50db1f741e675","user":{"login":"Alberyk","id":11579997,"avatar_url":"https://avatars2.githubusercontent.com/u/11579997?v=4","gravatar_id":"","url":"https://api.github.com/users/Alberyk","html_url":"https://github.com/Alberyk","followers_url":"https://api.github.com/users/Alberyk/followers","following_url":"https://api.github.com/users/Alberyk/following{/other_user}","gists_url":"https://api.github.com/users/Alberyk/gists{/gist_id}","starred_url":"https://api.github.com/users/Alberyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alberyk/subscriptions","organizations_url":"https://api.github.com/users/Alberyk/orgs","repos_url":"https://api.github.com/users/Alberyk/repos","events_url":"https://api.github.com/users/Alberyk/events{/privacy}","received_events_url":"https://api.github.com/users/Alberyk/received_events","type":"User","site_admin":false},"body":"That is on puporse, a lot of wizard's invocations are references or 'jokes\".","created_at":"2017-08-27T16:47:58Z","updated_at":"2017-08-27T16:47:58Z","html_url":"https://github.com/Aurorastation/Aurora.3/pull/3348#discussion_r135415907","pull_request_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/3348","_links":{"self":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/comments/135415907"},"html":{"href":"https://github.com/Aurorastation/Aurora.3/pull/3348#discussion_r135415907"},"pull_request":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/3348"}},"in_reply_to_id":135410205},"pull_request":{"url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/3348","id":137709297,"html_url":"https://github.com/Aurorastation/Aurora.3/pull/3348","diff_url":"https://github.com/Aurorastation/Aurora.3/pull/3348.diff","patch_url":"https://github.com/Aurorastation/Aurora.3/pull/3348.patch","issue_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/3348","number":3348,"state":"open","locked":false,"title":"Adds more cleric spells and more","user":{"login":"Alberyk","id":11579997,"avatar_url":"https://avatars2.githubusercontent.com/u/11579997?v=4","gravatar_id":"","url":"https://api.github.com/users/Alberyk","html_url":"https://github.com/Alberyk","followers_url":"https://api.github.com/users/Alberyk/followers","following_url":"https://api.github.com/users/Alberyk/following{/other_user}","gists_url":"https://api.github.com/users/Alberyk/gists{/gist_id}","starred_url":"https://api.github.com/users/Alberyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alberyk/subscriptions","organizations_url":"https://api.github.com/users/Alberyk/orgs","repos_url":"https://api.github.com/users/Alberyk/repos","events_url":"https://api.github.com/users/Alberyk/events{/privacy}","received_events_url":"https://api.github.com/users/Alberyk/received_events","type":"User","site_admin":false},"body":"-adds the mend would spell; a spell that allows the wizard to close bleeding, heal internal bleeding, broken bones and organ damage by selecting the hurt zone\r\n-adds the resurrection spell, that brings a dead target to life, it will not work if he has been dead for too long\r\n-adds mind bend, that allows the wizard to turn his victim into his lobotomized slave, like the vampire thrall power\r\n-buffs some healing spell, summon bats and summon bear\r\n-adds more wizard related sounds\r\n-adds an emote when someone is firing their eye lasers","created_at":"2017-08-25T16:19:24Z","updated_at":"2017-08-27T16:47:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73939fa482e428842f9c720d7dcc2b306f348028","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/3348/commits","review_comments_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/3348/comments","review_comment_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/3348/comments","statuses_url":"https://api.github.com/repos/Aurorastation/Aurora.3/statuses/e922593779e29e55617fd36e49b50db1f741e675","head":{"label":"Alberyk:the_colour_out_of_space","ref":"the_colour_out_of_space","sha":"e922593779e29e55617fd36e49b50db1f741e675","user":{"login":"Alberyk","id":11579997,"avatar_url":"https://avatars2.githubusercontent.com/u/11579997?v=4","gravatar_id":"","url":"https://api.github.com/users/Alberyk","html_url":"https://github.com/Alberyk","followers_url":"https://api.github.com/users/Alberyk/followers","following_url":"https://api.github.com/users/Alberyk/following{/other_user}","gists_url":"https://api.github.com/users/Alberyk/gists{/gist_id}","starred_url":"https://api.github.com/users/Alberyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alberyk/subscriptions","organizations_url":"https://api.github.com/users/Alberyk/orgs","repos_url":"https://api.github.com/users/Alberyk/repos","events_url":"https://api.github.com/users/Alberyk/events{/privacy}","received_events_url":"https://api.github.com/users/Alberyk/received_events","type":"User","site_admin":false},"repo":{"id":98129467,"name":"Aurora.3","full_name":"Alberyk/Aurora.3","owner":{"login":"Alberyk","id":11579997,"avatar_url":"https://avatars2.githubusercontent.com/u/11579997?v=4","gravatar_id":"","url":"https://api.github.com/users/Alberyk","html_url":"https://github.com/Alberyk","followers_url":"https://api.github.com/users/Alberyk/followers","following_url":"https://api.github.com/users/Alberyk/following{/other_user}","gists_url":"https://api.github.com/users/Alberyk/gists{/gist_id}","starred_url":"https://api.github.com/users/Alberyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alberyk/subscriptions","organizations_url":"https://api.github.com/users/Alberyk/orgs","repos_url":"https://api.github.com/users/Alberyk/repos","events_url":"https://api.github.com/users/Alberyk/events{/privacy}","received_events_url":"https://api.github.com/users/Alberyk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Alberyk/Aurora.3","description":"The code for Aurorastation's new base, forked from Baystation12.","fork":true,"url":"https://api.github.com/repos/Alberyk/Aurora.3","forks_url":"https://api.github.com/repos/Alberyk/Aurora.3/forks","keys_url":"https://api.github.com/repos/Alberyk/Aurora.3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alberyk/Aurora.3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alberyk/Aurora.3/teams","hooks_url":"https://api.github.com/repos/Alberyk/Aurora.3/hooks","issue_events_url":"https://api.github.com/repos/Alberyk/Aurora.3/issues/events{/number}","events_url":"https://api.github.com/repos/Alberyk/Aurora.3/events","assignees_url":"https://api.github.com/repos/Alberyk/Aurora.3/assignees{/user}","branches_url":"https://api.github.com/repos/Alberyk/Aurora.3/branches{/branch}","tags_url":"https://api.github.com/repos/Alberyk/Aurora.3/tags","blobs_url":"https://api.github.com/repos/Alberyk/Aurora.3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alberyk/Aurora.3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alberyk/Aurora.3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alberyk/Aurora.3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alberyk/Aurora.3/statuses/{sha}","languages_url":"https://api.github.com/repos/Alberyk/Aurora.3/languages","stargazers_url":"https://api.github.com/repos/Alberyk/Aurora.3/stargazers","contributors_url":"https://api.github.com/repos/Alberyk/Aurora.3/contributors","subscribers_url":"https://api.github.com/repos/Alberyk/Aurora.3/subscribers","subscription_url":"https://api.github.com/repos/Alberyk/Aurora.3/subscription","commits_url":"https://api.github.com/repos/Alberyk/Aurora.3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alberyk/Aurora.3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alberyk/Aurora.3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alberyk/Aurora.3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alberyk/Aurora.3/contents/{+path}","compare_url":"https://api.github.com/repos/Alberyk/Aurora.3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alberyk/Aurora.3/merges","archive_url":"https://api.github.com/repos/Alberyk/Aurora.3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alberyk/Aurora.3/downloads","issues_url":"https://api.github.com/repos/Alberyk/Aurora.3/issues{/number}","pulls_url":"https://api.github.com/repos/Alberyk/Aurora.3/pulls{/number}","milestones_url":"https://api.github.com/repos/Alberyk/Aurora.3/milestones{/number}","notifications_url":"https://api.github.com/repos/Alberyk/Aurora.3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alberyk/Aurora.3/labels{/name}","releases_url":"https://api.github.com/repos/Alberyk/Aurora.3/releases{/id}","deployments_url":"https://api.github.com/repos/Alberyk/Aurora.3/deployments","created_at":"2017-07-23T22:34:14Z","updated_at":"2017-07-23T22:34:27Z","pushed_at":"2017-08-26T20:49:25Z","git_url":"git://github.com/Alberyk/Aurora.3.git","ssh_url":"[email protected]:Alberyk/Aurora.3.git","clone_url":"https://github.com/Alberyk/Aurora.3.git","svn_url":"https://github.com/Alberyk/Aurora.3","homepage":"http://aurorastation.org/","size":650622,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Aurorastation:development","ref":"development","sha":"4204624b6e46951953c1e28b29740d552e5de539","user":{"login":"Aurorastation","id":6915762,"avatar_url":"https://avatars2.githubusercontent.com/u/6915762?v=4","gravatar_id":"","url":"https://api.github.com/users/Aurorastation","html_url":"https://github.com/Aurorastation","followers_url":"https://api.github.com/users/Aurorastation/followers","following_url":"https://api.github.com/users/Aurorastation/following{/other_user}","gists_url":"https://api.github.com/users/Aurorastation/gists{/gist_id}","starred_url":"https://api.github.com/users/Aurorastation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aurorastation/subscriptions","organizations_url":"https://api.github.com/users/Aurorastation/orgs","repos_url":"https://api.github.com/users/Aurorastation/repos","events_url":"https://api.github.com/users/Aurorastation/events{/privacy}","received_events_url":"https://api.github.com/users/Aurorastation/received_events","type":"Organization","site_admin":false},"repo":{"id":42579199,"name":"Aurora.3","full_name":"Aurorastation/Aurora.3","owner":{"login":"Aurorastation","id":6915762,"avatar_url":"https://avatars2.githubusercontent.com/u/6915762?v=4","gravatar_id":"","url":"https://api.github.com/users/Aurorastation","html_url":"https://github.com/Aurorastation","followers_url":"https://api.github.com/users/Aurorastation/followers","following_url":"https://api.github.com/users/Aurorastation/following{/other_user}","gists_url":"https://api.github.com/users/Aurorastation/gists{/gist_id}","starred_url":"https://api.github.com/users/Aurorastation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aurorastation/subscriptions","organizations_url":"https://api.github.com/users/Aurorastation/orgs","repos_url":"https://api.github.com/users/Aurorastation/repos","events_url":"https://api.github.com/users/Aurorastation/events{/privacy}","received_events_url":"https://api.github.com/users/Aurorastation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Aurorastation/Aurora.3","description":"The code for Aurorastation's new base, forked from Baystation12.","fork":false,"url":"https://api.github.com/repos/Aurorastation/Aurora.3","forks_url":"https://api.github.com/repos/Aurorastation/Aurora.3/forks","keys_url":"https://api.github.com/repos/Aurorastation/Aurora.3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Aurorastation/Aurora.3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Aurorastation/Aurora.3/teams","hooks_url":"https://api.github.com/repos/Aurorastation/Aurora.3/hooks","issue_events_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/events{/number}","events_url":"https://api.github.com/repos/Aurorastation/Aurora.3/events","assignees_url":"https://api.github.com/repos/Aurorastation/Aurora.3/assignees{/user}","branches_url":"https://api.github.com/repos/Aurorastation/Aurora.3/branches{/branch}","tags_url":"https://api.github.com/repos/Aurorastation/Aurora.3/tags","blobs_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Aurorastation/Aurora.3/statuses/{sha}","languages_url":"https://api.github.com/repos/Aurorastation/Aurora.3/languages","stargazers_url":"https://api.github.com/repos/Aurorastation/Aurora.3/stargazers","contributors_url":"https://api.github.com/repos/Aurorastation/Aurora.3/contributors","subscribers_url":"https://api.github.com/repos/Aurorastation/Aurora.3/subscribers","subscription_url":"https://api.github.com/repos/Aurorastation/Aurora.3/subscription","commits_url":"https://api.github.com/repos/Aurorastation/Aurora.3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Aurorastation/Aurora.3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Aurorastation/Aurora.3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Aurorastation/Aurora.3/contents/{+path}","compare_url":"https://api.github.com/repos/Aurorastation/Aurora.3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Aurorastation/Aurora.3/merges","archive_url":"https://api.github.com/repos/Aurorastation/Aurora.3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Aurorastation/Aurora.3/downloads","issues_url":"https://api.github.com/repos/Aurorastation/Aurora.3/issues{/number}","pulls_url":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls{/number}","milestones_url":"https://api.github.com/repos/Aurorastation/Aurora.3/milestones{/number}","notifications_url":"https://api.github.com/repos/Aurorastation/Aurora.3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Aurorastation/Aurora.3/labels{/name}","releases_url":"https://api.github.com/repos/Aurorastation/Aurora.3/releases{/id}","deployments_url":"https://api.github.com/repos/Aurorastation/Aurora.3/deployments","created_at":"2015-09-16T09:56:37Z","updated_at":"2017-07-22T10:29:46Z","pushed_at":"2017-08-27T14:50:28Z","git_url":"git://github.com/Aurorastation/Aurora.3.git","ssh_url":"[email protected]:Aurorastation/Aurora.3.git","clone_url":"https://github.com/Aurorastation/Aurora.3.git","svn_url":"https://github.com/Aurorastation/Aurora.3","homepage":"http://aurorastation.org/","size":649742,"stargazers_count":19,"watchers_count":19,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":421,"forks":63,"open_issues":421,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/3348"},"html":{"href":"https://github.com/Aurorastation/Aurora.3/pull/3348"},"issue":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/3348"},"comments":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/issues/3348/comments"},"review_comments":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/3348/comments"},"review_comment":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/pulls/3348/commits"},"statuses":{"href":"https://api.github.com/repos/Aurorastation/Aurora.3/statuses/e922593779e29e55617fd36e49b50db1f741e675"}}}}
|
{
"id": 42579199,
"name": "Aurorastation/Aurora.3",
"url": "https://api.github.com/repos/Aurorastation/Aurora.3"
}
|
{
"id": 11579997,
"login": "Alberyk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11579997?",
"url": "https://api.github.com/users/Alberyk"
}
|
{
"id": 6915762,
"login": "Aurorastation",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6915762?",
"url": "https://api.github.com/orgs/Aurorastation"
}
| 2017-08-27T16:47:58 |
6516969252
|
{"actor":{"display_login":"Alberyk"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/pulls/comments/141384523","pull_request_review_id":65590447,"id":141384523,"diff_hunk":"@@ -379,142 +323,20 @@ <h1 class=\"name\">Start Bootstrap</h1>\n <div class=\"row\">\n <div class=\"col-lg-8 col-lg-offset-2\">\n <div class=\"modal-body\">\n- <h2>Project Title</h2>\n+ <h2>Bank Empatii</h2>\n <hr class=\"star-primary\">\n <img src=\"img/portfolio/circus.png\" class=\"img-responsive img-centered\" alt=\"\">\n- <p>Use this area of the page to describe your project. The icon above is part of a free icon set by <a href=\"https://sellfy.com/p/8Q9P/jV3VZ/\">Flat Icons</a>. On their website, you can download their free set with 16 icons, or you can purchase the entire set with 146 icons for only $12!</p>\n- <ul class=\"list-inline item-details\">\n- <li>Client:\n- <strong><a href=\"http://startbootstrap.com\">Start Bootstrap</a>\n- </strong>\n- </li>\n- <li>Date:\n- <strong><a href=\"http://startbootstrap.com\">April 2014</a>\n- </strong>\n- </li>\n- <li>Service:\n- <strong><a href=\"http://startbootstrap.com\">Web Development</a>\n- </strong>\n- </li>\n- </ul>\n- <button type=\"button\" class=\"btn btn-default\" data-dismiss=\"modal\"><i class=\"fa fa-times\"></i> Close</button>\n- </div>\n- </div>\n- </div>\n- </div>\n- </div>\n- </div>\n- <div class=\"portfolio-modal modal fade\" id=\"portfolioModal4\" tabindex=\"-1\" role=\"dialog\" aria-hidden=\"true\">\n- <div class=\"modal-content\">\n- <div class=\"close-modal\" data-dismiss=\"modal\">\n- <div class=\"lr\">\n- <div class=\"rl\">\n- </div>\n- </div>\n- </div>\n- <div class=\"container\">\n- <div class=\"row\">\n- <div class=\"col-lg-8 col-lg-offset-2\">\n- <div class=\"modal-body\">\n- <h2>Project Title</h2>\n- <hr class=\"star-primary\">\n- <img src=\"img/portfolio/game.png\" class=\"img-responsive img-centered\" alt=\"\">\n- <p>Use this area of the page to describe your project. The icon above is part of a free icon set by <a href=\"https://sellfy.com/p/8Q9P/jV3VZ/\">Flat Icons</a>. On their website, you can download their free set with 16 icons, or you can purchase the entire set with 146 icons for only $12!</p>\n- <ul class=\"list-inline item-details\">\n- <li>Client:\n- <strong><a href=\"http://startbootstrap.com\">Start Bootstrap</a>\n- </strong>\n- </li>\n- <li>Date:\n- <strong><a href=\"http://startbootstrap.com\">April 2014</a>\n- </strong>\n- </li>\n- <li>Service:\n- <strong><a href=\"http://startbootstrap.com\">Web Development</a>\n- </strong>\n- </li>\n- </ul>\n- <button type=\"button\" class=\"btn btn-default\" data-dismiss=\"modal\"><i class=\"fa fa-times\"></i> Close</button>\n- </div>\n- </div>\n- </div>\n- </div>\n- </div>\n- </div>\n- <div class=\"portfolio-modal modal fade\" id=\"portfolioModal5\" tabindex=\"-1\" role=\"dialog\" aria-hidden=\"true\">\n- <div class=\"modal-content\">\n- <div class=\"close-modal\" data-dismiss=\"modal\">\n- <div class=\"lr\">\n- <div class=\"rl\">\n- </div>\n- </div>\n- </div>\n- <div class=\"container\">\n- <div class=\"row\">\n- <div class=\"col-lg-8 col-lg-offset-2\">\n- <div class=\"modal-body\">\n- <h2>Project Title</h2>\n- <hr class=\"star-primary\">\n- <img src=\"img/portfolio/safe.png\" class=\"img-responsive img-centered\" alt=\"\">\n- <p>Use this area of the page to describe your project. The icon above is part of a free icon set by <a href=\"https://sellfy.com/p/8Q9P/jV3VZ/\">Flat Icons</a>. On their website, you can download their free set with 16 icons, or you can purchase the entire set with 146 icons for only $12!</p>\n- <ul class=\"list-inline item-details\">\n- <li>Client:\n- <strong><a href=\"http://startbootstrap.com\">Start Bootstrap</a>\n- </strong>\n- </li>\n- <li>Date:\n- <strong><a href=\"http://startbootstrap.com\">April 2014</a>\n- </strong>\n- </li>\n- <li>Service:\n- <strong><a href=\"http://startbootstrap.com\">Web Development</a>\n- </strong>\n- </li>\n- </ul>\n+ <p>Bank empatii to projekt strony Patrycji Krawczyk, która zmaga się z białaczką limfoblastyczną i chce znaleźć dawcę komórek macierzystach o podobnym do Patrycji kodzie genetycznym. Trzy główne panele \"Historia Patrycji\", \"Jak wygląda badanie?\"\" oraz \"Gdzie się zgłosić?\" kierują użytkowników strony do uzyskania informacji na temat jak zostać dawcą szpiku oraz czym jest Rejestr Dawców. Na stronie znajduje się mapa Polski z umiejscowieniem punktów poboru krwi.</p>\n+ <p>Kliknij <a href=\"http://bankempatii.pl/\">tutaj</a>, aby wejść na stronę.</p>\n <button type=\"button\" class=\"btn btn-default\" data-dismiss=\"modal\"><i class=\"fa fa-times\"></i> Close</button>\n </div>\n </div>\n </div>\n </div>\n </div>\n </div>\n- <div class=\"portfolio-modal modal fade\" id=\"portfolioModal6\" tabindex=\"-1\" role=\"dialog\" aria-hidden=\"true\">\n- <div class=\"modal-content\">\n- <div class=\"close-modal\" data-dismiss=\"modal\">\n- <div class=\"lr\">\n- <div class=\"rl\">\n- </div>\n- </div>\n- </div>\n- <div class=\"container\">\n- <div class=\"row\">\n- <div class=\"col-lg-8 col-lg-offset-2\">\n- <div class=\"modal-body\">\n- <h2>Project Title</h2>\n- <hr class=\"star-primary\">\n- <img src=\"img/portfolio/submarine.png\" class=\"img-responsive img-centered\" alt=\"\">\n- <p>Use this area of the page to describe your project. The icon above is part of a free icon set by <a href=\"https://sellfy.com/p/8Q9P/jV3VZ/\">Flat Icons</a>. On their website, you can download their free set with 16 icons, or you can purchase the entire set with 146 icons for only $12!</p>\n- <ul class=\"list-inline item-details\">\n- <li>Client:\n- <strong><a href=\"http://startbootstrap.com\">Start Bootstrap</a>\n- </strong>\n- </li>\n- <li>Date:\n- <strong><a href=\"http://startbootstrap.com\">April 2014</a>\n- </strong>\n- </li>\n- <li>Service:\n- <strong><a href=\"http://startbootstrap.com\">Web Development</a>\n- </strong>\n- </li>\n- </ul>\n- <button id=\"btnSubmit\" type=\"button\" class=\"btn btn-default\" data-dismiss=\"modal\"><i class=\"fa fa-times\"></i> Close</button>\n- </div>\n- </div>\n- </div>\n- </div>\n- </div>\n- </div>\n+","path":"index.html","position":236,"original_position":236,"commit_id":"70f7b09eafceea805ab8d89eb76591e0d88f89c3","original_commit_id":"70f7b09eafceea805ab8d89eb76591e0d88f89c3","user":{"login":"w1stler","id":17498341,"avatar_url":"https://avatars3.githubusercontent.com/u/17498341?v=4","gravatar_id":"","url":"https://api.github.com/users/w1stler","html_url":"https://github.com/w1stler","followers_url":"https://api.github.com/users/w1stler/followers","following_url":"https://api.github.com/users/w1stler/following{/other_user}","gists_url":"https://api.github.com/users/w1stler/gists{/gist_id}","starred_url":"https://api.github.com/users/w1stler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w1stler/subscriptions","organizations_url":"https://api.github.com/users/w1stler/orgs","repos_url":"https://api.github.com/users/w1stler/repos","events_url":"https://api.github.com/users/w1stler/events{/privacy}","received_events_url":"https://api.github.com/users/w1stler/received_events","type":"User","site_admin":false},"body":"These lines are not necessary. ","created_at":"2017-09-27T15:42:10Z","updated_at":"2017-09-27T15:44:19Z","html_url":"https://github.com/CodeForPoznan/startbootstrap-freelancer/pull/14#discussion_r141384523","pull_request_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/pulls/14","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/pulls/comments/141384523"},"html":{"href":"https://github.com/CodeForPoznan/startbootstrap-freelancer/pull/14#discussion_r141384523"},"pull_request":{"href":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/pulls/14","id":142155759,"html_url":"https://github.com/CodeForPoznan/startbootstrap-freelancer/pull/14","diff_url":"https://github.com/CodeForPoznan/startbootstrap-freelancer/pull/14.diff","patch_url":"https://github.com/CodeForPoznan/startbootstrap-freelancer/pull/14.patch","issue_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/issues/14","number":14,"state":"open","locked":false,"title":"[7] Add project description","user":{"login":"Szymanpaulina","id":29673569,"avatar_url":"https://avatars0.githubusercontent.com/u/29673569?v=4","gravatar_id":"","url":"https://api.github.com/users/Szymanpaulina","html_url":"https://github.com/Szymanpaulina","followers_url":"https://api.github.com/users/Szymanpaulina/followers","following_url":"https://api.github.com/users/Szymanpaulina/following{/other_user}","gists_url":"https://api.github.com/users/Szymanpaulina/gists{/gist_id}","starred_url":"https://api.github.com/users/Szymanpaulina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Szymanpaulina/subscriptions","organizations_url":"https://api.github.com/users/Szymanpaulina/orgs","repos_url":"https://api.github.com/users/Szymanpaulina/repos","events_url":"https://api.github.com/users/Szymanpaulina/events{/privacy}","received_events_url":"https://api.github.com/users/Szymanpaulina/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-20T17:18:54Z","updated_at":"2017-09-27T15:44:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"240ca55fb0ad9032a398b5cbd7541fca326507ed","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/pulls/14/commits","review_comments_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/pulls/14/comments","review_comment_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/issues/14/comments","statuses_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/statuses/70f7b09eafceea805ab8d89eb76591e0d88f89c3","head":{"label":"Szymanpaulina:7_project_description","ref":"7_project_description","sha":"70f7b09eafceea805ab8d89eb76591e0d88f89c3","user":{"login":"Szymanpaulina","id":29673569,"avatar_url":"https://avatars0.githubusercontent.com/u/29673569?v=4","gravatar_id":"","url":"https://api.github.com/users/Szymanpaulina","html_url":"https://github.com/Szymanpaulina","followers_url":"https://api.github.com/users/Szymanpaulina/followers","following_url":"https://api.github.com/users/Szymanpaulina/following{/other_user}","gists_url":"https://api.github.com/users/Szymanpaulina/gists{/gist_id}","starred_url":"https://api.github.com/users/Szymanpaulina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Szymanpaulina/subscriptions","organizations_url":"https://api.github.com/users/Szymanpaulina/orgs","repos_url":"https://api.github.com/users/Szymanpaulina/repos","events_url":"https://api.github.com/users/Szymanpaulina/events{/privacy}","received_events_url":"https://api.github.com/users/Szymanpaulina/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"CodeForPoznan:master","ref":"master","sha":"23daa974bd2128da04304fdb4d04abd8e1c55586","user":{"login":"CodeForPoznan","id":22869943,"avatar_url":"https://avatars2.githubusercontent.com/u/22869943?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeForPoznan","html_url":"https://github.com/CodeForPoznan","followers_url":"https://api.github.com/users/CodeForPoznan/followers","following_url":"https://api.github.com/users/CodeForPoznan/following{/other_user}","gists_url":"https://api.github.com/users/CodeForPoznan/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeForPoznan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeForPoznan/subscriptions","organizations_url":"https://api.github.com/users/CodeForPoznan/orgs","repos_url":"https://api.github.com/users/CodeForPoznan/repos","events_url":"https://api.github.com/users/CodeForPoznan/events{/privacy}","received_events_url":"https://api.github.com/users/CodeForPoznan/received_events","type":"Organization","site_admin":false},"repo":{"id":99115953,"name":"startbootstrap-freelancer","full_name":"CodeForPoznan/startbootstrap-freelancer","owner":{"login":"CodeForPoznan","id":22869943,"avatar_url":"https://avatars2.githubusercontent.com/u/22869943?v=4","gravatar_id":"","url":"https://api.github.com/users/CodeForPoznan","html_url":"https://github.com/CodeForPoznan","followers_url":"https://api.github.com/users/CodeForPoznan/followers","following_url":"https://api.github.com/users/CodeForPoznan/following{/other_user}","gists_url":"https://api.github.com/users/CodeForPoznan/gists{/gist_id}","starred_url":"https://api.github.com/users/CodeForPoznan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodeForPoznan/subscriptions","organizations_url":"https://api.github.com/users/CodeForPoznan/orgs","repos_url":"https://api.github.com/users/CodeForPoznan/repos","events_url":"https://api.github.com/users/CodeForPoznan/events{/privacy}","received_events_url":"https://api.github.com/users/CodeForPoznan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CodeForPoznan/startbootstrap-freelancer","description":"A one page HTML theme for freelancers created by Start Bootstrap","fork":true,"url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer","forks_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/forks","keys_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/teams","hooks_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/hooks","issue_events_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/issues/events{/number}","events_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/events","assignees_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/assignees{/user}","branches_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/branches{/branch}","tags_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/tags","blobs_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/statuses/{sha}","languages_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/languages","stargazers_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/stargazers","contributors_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/contributors","subscribers_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/subscribers","subscription_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/subscription","commits_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/issues/comments{/number}","contents_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/contents/{+path}","compare_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/merges","archive_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/downloads","issues_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/issues{/number}","pulls_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/pulls{/number}","milestones_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/milestones{/number}","notifications_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/labels{/name}","releases_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/releases{/id}","deployments_url":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/deployments","created_at":"2017-08-02T12:50:16Z","updated_at":"2017-08-16T19:17:06Z","pushed_at":"2017-09-20T17:18:55Z","git_url":"git://github.com/CodeForPoznan/startbootstrap-freelancer.git","ssh_url":"[email protected]:CodeForPoznan/startbootstrap-freelancer.git","clone_url":"https://github.com/CodeForPoznan/startbootstrap-freelancer.git","svn_url":"https://github.com/CodeForPoznan/startbootstrap-freelancer","homepage":"http://startbootstrap.com/template-overviews/freelancer/","size":3201,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":12,"forks":4,"open_issues":12,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/pulls/14"},"html":{"href":"https://github.com/CodeForPoznan/startbootstrap-freelancer/pull/14"},"issue":{"href":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/issues/14"},"comments":{"href":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer/statuses/70f7b09eafceea805ab8d89eb76591e0d88f89c3"}},"author_association":"NONE"}}
|
{
"id": 99115953,
"name": "CodeForPoznan/startbootstrap-freelancer",
"url": "https://api.github.com/repos/CodeForPoznan/startbootstrap-freelancer"
}
|
{
"id": 17498341,
"login": "w1stler",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17498341?",
"url": "https://api.github.com/users/w1stler"
}
|
{
"id": 22869943,
"login": "CodeForPoznan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22869943?",
"url": "https://api.github.com/orgs/CodeForPoznan"
}
| 2017-09-27T15:42:10 |
6644784624
|
{"actor":{"display_login":"w1stler"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/pulls/comments/146586071","pull_request_review_id":71545749,"id":146586071,"diff_hunk":"@@ -0,0 +1,58 @@\n+/*************************************************************************\r\n+> File Name: AgentStructure.cpp\r\n+> Project Name: Hearthstone++\r\n+> Author: Young-Joong Kim\r\n+> Purpose: Agent Data Structure for Interact with Interface\r\n+> Created Time: 2017/10/24\r\n+> Copyright (c) 2017, Young-Joong Kim\r\n+*************************************************************************/\r\n+#include <Agents/AgentStructures.h>\r\n+\r\n+namespace Hearthstonepp\r\n+{\r\n+\tUser::User(Player *player, int deckID)\r","path":"Sources/Agents/AgentStructures.cpp","position":13,"original_position":13,"commit_id":"0134f363c1acbfa8c2db1a09b62a7ac1312d7cce","original_commit_id":"0134f363c1acbfa8c2db1a09b62a7ac1312d7cce","user":{"login":"utilForever","id":5622661,"avatar_url":"https://avatars2.githubusercontent.com/u/5622661?v=4","gravatar_id":"","url":"https://api.github.com/users/utilForever","html_url":"https://github.com/utilForever","followers_url":"https://api.github.com/users/utilForever/followers","following_url":"https://api.github.com/users/utilForever/following{/other_user}","gists_url":"https://api.github.com/users/utilForever/gists{/gist_id}","starred_url":"https://api.github.com/users/utilForever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utilForever/subscriptions","organizations_url":"https://api.github.com/users/utilForever/orgs","repos_url":"https://api.github.com/users/utilForever/repos","events_url":"https://api.github.com/users/utilForever/events{/privacy}","received_events_url":"https://api.github.com/users/utilForever/received_events","type":"User","site_admin":false},"body":"멤버 이니셜라이저 가능한 변수는 멤버 이니셜라이저로 초기화.","created_at":"2017-10-24T14:50:27Z","updated_at":"2017-10-24T14:54:29Z","html_url":"https://github.com/Hearthstonepp/Hearthstonepp/pull/27#discussion_r146586071","pull_request_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/pulls/27","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/pulls/comments/146586071"},"html":{"href":"https://github.com/Hearthstonepp/Hearthstonepp/pull/27#discussion_r146586071"},"pull_request":{"href":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/pulls/27","id":148413348,"html_url":"https://github.com/Hearthstonepp/Hearthstonepp/pull/27","diff_url":"https://github.com/Hearthstonepp/Hearthstonepp/pull/27.diff","patch_url":"https://github.com/Hearthstonepp/Hearthstonepp/pull/27.patch","issue_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/issues/27","number":27,"state":"open","locked":false,"title":"Implement Interface System - Create GameInterface, Renew GameAgent for new Deck System","user":{"login":"revsic","id":15906088,"avatar_url":"https://avatars0.githubusercontent.com/u/15906088?v=4","gravatar_id":"","url":"https://api.github.com/users/revsic","html_url":"https://github.com/revsic","followers_url":"https://api.github.com/users/revsic/followers","following_url":"https://api.github.com/users/revsic/following{/other_user}","gists_url":"https://api.github.com/users/revsic/gists{/gist_id}","starred_url":"https://api.github.com/users/revsic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revsic/subscriptions","organizations_url":"https://api.github.com/users/revsic/orgs","repos_url":"https://api.github.com/users/revsic/repos","events_url":"https://api.github.com/users/revsic/events{/privacy}","received_events_url":"https://api.github.com/users/revsic/received_events","type":"User","site_admin":false},"body":"새로운 덱 시스템과 플레이어 시스템에 맞게 게임 에이전트를 개편하였습니다.\r\n콘솔의 SimulateGame과 게임 인터페이스를 분리하기 위해 GameInterface 클래스를 추가로 구현하였습니다.\r\nGameInterface와 GameAgent의 원활한 소통을 위해 AgentStructure에 관련 구조체를 정의하였습니다.\r\n이로써, 메인 에이전트 개발 전 준비 과정을 모두 마친듯 합니다. ","created_at":"2017-10-24T14:26:14Z","updated_at":"2017-10-24T14:54:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2f96bd6c58e1565e7ec7a4bdbeedc33690e7c4a","assignee":{"login":"revsic","id":15906088,"avatar_url":"https://avatars0.githubusercontent.com/u/15906088?v=4","gravatar_id":"","url":"https://api.github.com/users/revsic","html_url":"https://github.com/revsic","followers_url":"https://api.github.com/users/revsic/followers","following_url":"https://api.github.com/users/revsic/following{/other_user}","gists_url":"https://api.github.com/users/revsic/gists{/gist_id}","starred_url":"https://api.github.com/users/revsic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revsic/subscriptions","organizations_url":"https://api.github.com/users/revsic/orgs","repos_url":"https://api.github.com/users/revsic/repos","events_url":"https://api.github.com/users/revsic/events{/privacy}","received_events_url":"https://api.github.com/users/revsic/received_events","type":"User","site_admin":false},"assignees":[{"login":"revsic","id":15906088,"avatar_url":"https://avatars0.githubusercontent.com/u/15906088?v=4","gravatar_id":"","url":"https://api.github.com/users/revsic","html_url":"https://github.com/revsic","followers_url":"https://api.github.com/users/revsic/followers","following_url":"https://api.github.com/users/revsic/following{/other_user}","gists_url":"https://api.github.com/users/revsic/gists{/gist_id}","starred_url":"https://api.github.com/users/revsic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revsic/subscriptions","organizations_url":"https://api.github.com/users/revsic/orgs","repos_url":"https://api.github.com/users/revsic/repos","events_url":"https://api.github.com/users/revsic/events{/privacy}","received_events_url":"https://api.github.com/users/revsic/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/milestones/1","html_url":"https://github.com/Hearthstonepp/Hearthstonepp/milestone/1","labels_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/milestones/1/labels","id":2713017,"number":1,"title":"Ver 0.1","description":"- Read card data from cards.json\r\n- Implement simple console hearthstone simulator\r\n- Implement card core features\r\n - Aura, Enchantment & Trigger\r\n - Hero, Hero Power & Weapon\r\n - Battlecry & Deathrattle\r\n - Choose One & Combo\r\n - Spell Power","creator":{"login":"utilForever","id":5622661,"avatar_url":"https://avatars2.githubusercontent.com/u/5622661?v=4","gravatar_id":"","url":"https://api.github.com/users/utilForever","html_url":"https://github.com/utilForever","followers_url":"https://api.github.com/users/utilForever/followers","following_url":"https://api.github.com/users/utilForever/following{/other_user}","gists_url":"https://api.github.com/users/utilForever/gists{/gist_id}","starred_url":"https://api.github.com/users/utilForever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utilForever/subscriptions","organizations_url":"https://api.github.com/users/utilForever/orgs","repos_url":"https://api.github.com/users/utilForever/repos","events_url":"https://api.github.com/users/utilForever/events{/privacy}","received_events_url":"https://api.github.com/users/utilForever/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":17,"state":"open","created_at":"2017-08-21T11:10:10Z","updated_at":"2017-10-24T14:26:14Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/pulls/27/commits","review_comments_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/pulls/27/comments","review_comment_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/issues/27/comments","statuses_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/statuses/0134f363c1acbfa8c2db1a09b62a7ac1312d7cce","head":{"label":"Hearthstonepp:dev_agent","ref":"dev_agent","sha":"0134f363c1acbfa8c2db1a09b62a7ac1312d7cce","user":{"login":"Hearthstonepp","id":31149860,"avatar_url":"https://avatars3.githubusercontent.com/u/31149860?v=4","gravatar_id":"","url":"https://api.github.com/users/Hearthstonepp","html_url":"https://github.com/Hearthstonepp","followers_url":"https://api.github.com/users/Hearthstonepp/followers","following_url":"https://api.github.com/users/Hearthstonepp/following{/other_user}","gists_url":"https://api.github.com/users/Hearthstonepp/gists{/gist_id}","starred_url":"https://api.github.com/users/Hearthstonepp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hearthstonepp/subscriptions","organizations_url":"https://api.github.com/users/Hearthstonepp/orgs","repos_url":"https://api.github.com/users/Hearthstonepp/repos","events_url":"https://api.github.com/users/Hearthstonepp/events{/privacy}","received_events_url":"https://api.github.com/users/Hearthstonepp/received_events","type":"Organization","site_admin":false},"repo":{"id":91815485,"name":"Hearthstonepp","full_name":"Hearthstonepp/Hearthstonepp","owner":{"login":"Hearthstonepp","id":31149860,"avatar_url":"https://avatars3.githubusercontent.com/u/31149860?v=4","gravatar_id":"","url":"https://api.github.com/users/Hearthstonepp","html_url":"https://github.com/Hearthstonepp","followers_url":"https://api.github.com/users/Hearthstonepp/followers","following_url":"https://api.github.com/users/Hearthstonepp/following{/other_user}","gists_url":"https://api.github.com/users/Hearthstonepp/gists{/gist_id}","starred_url":"https://api.github.com/users/Hearthstonepp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hearthstonepp/subscriptions","organizations_url":"https://api.github.com/users/Hearthstonepp/orgs","repos_url":"https://api.github.com/users/Hearthstonepp/repos","events_url":"https://api.github.com/users/Hearthstonepp/events{/privacy}","received_events_url":"https://api.github.com/users/Hearthstonepp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Hearthstonepp/Hearthstonepp","description":"Hearthstone simulator using C++ with some reinforcement learning","fork":false,"url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp","forks_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/forks","keys_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/teams","hooks_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/hooks","issue_events_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/issues/events{/number}","events_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/events","assignees_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/assignees{/user}","branches_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/branches{/branch}","tags_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/tags","blobs_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/statuses/{sha}","languages_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/languages","stargazers_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/stargazers","contributors_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/contributors","subscribers_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/subscribers","subscription_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/subscription","commits_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/contents/{+path}","compare_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/merges","archive_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/downloads","issues_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/issues{/number}","pulls_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/pulls{/number}","milestones_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/milestones{/number}","notifications_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/labels{/name}","releases_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/releases{/id}","deployments_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/deployments","created_at":"2017-05-19T14:41:26Z","updated_at":"2017-10-24T04:51:34Z","pushed_at":"2017-10-24T14:26:14Z","git_url":"git://github.com/Hearthstonepp/Hearthstonepp.git","ssh_url":"[email protected]:Hearthstonepp/Hearthstonepp.git","clone_url":"https://github.com/Hearthstonepp/Hearthstonepp.git","svn_url":"https://github.com/Hearthstonepp/Hearthstonepp","homepage":"","size":3245,"stargazers_count":31,"watchers_count":31,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":7,"forks":6,"open_issues":7,"watchers":31,"default_branch":"master"}},"base":{"label":"Hearthstonepp:master","ref":"master","sha":"34c1ce7d4a8e0b2011119c385940ae90e3580ea0","user":{"login":"Hearthstonepp","id":31149860,"avatar_url":"https://avatars3.githubusercontent.com/u/31149860?v=4","gravatar_id":"","url":"https://api.github.com/users/Hearthstonepp","html_url":"https://github.com/Hearthstonepp","followers_url":"https://api.github.com/users/Hearthstonepp/followers","following_url":"https://api.github.com/users/Hearthstonepp/following{/other_user}","gists_url":"https://api.github.com/users/Hearthstonepp/gists{/gist_id}","starred_url":"https://api.github.com/users/Hearthstonepp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hearthstonepp/subscriptions","organizations_url":"https://api.github.com/users/Hearthstonepp/orgs","repos_url":"https://api.github.com/users/Hearthstonepp/repos","events_url":"https://api.github.com/users/Hearthstonepp/events{/privacy}","received_events_url":"https://api.github.com/users/Hearthstonepp/received_events","type":"Organization","site_admin":false},"repo":{"id":91815485,"name":"Hearthstonepp","full_name":"Hearthstonepp/Hearthstonepp","owner":{"login":"Hearthstonepp","id":31149860,"avatar_url":"https://avatars3.githubusercontent.com/u/31149860?v=4","gravatar_id":"","url":"https://api.github.com/users/Hearthstonepp","html_url":"https://github.com/Hearthstonepp","followers_url":"https://api.github.com/users/Hearthstonepp/followers","following_url":"https://api.github.com/users/Hearthstonepp/following{/other_user}","gists_url":"https://api.github.com/users/Hearthstonepp/gists{/gist_id}","starred_url":"https://api.github.com/users/Hearthstonepp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hearthstonepp/subscriptions","organizations_url":"https://api.github.com/users/Hearthstonepp/orgs","repos_url":"https://api.github.com/users/Hearthstonepp/repos","events_url":"https://api.github.com/users/Hearthstonepp/events{/privacy}","received_events_url":"https://api.github.com/users/Hearthstonepp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Hearthstonepp/Hearthstonepp","description":"Hearthstone simulator using C++ with some reinforcement learning","fork":false,"url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp","forks_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/forks","keys_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/teams","hooks_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/hooks","issue_events_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/issues/events{/number}","events_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/events","assignees_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/assignees{/user}","branches_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/branches{/branch}","tags_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/tags","blobs_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/statuses/{sha}","languages_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/languages","stargazers_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/stargazers","contributors_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/contributors","subscribers_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/subscribers","subscription_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/subscription","commits_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/contents/{+path}","compare_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/merges","archive_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/downloads","issues_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/issues{/number}","pulls_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/pulls{/number}","milestones_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/milestones{/number}","notifications_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/labels{/name}","releases_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/releases{/id}","deployments_url":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/deployments","created_at":"2017-05-19T14:41:26Z","updated_at":"2017-10-24T04:51:34Z","pushed_at":"2017-10-24T14:26:14Z","git_url":"git://github.com/Hearthstonepp/Hearthstonepp.git","ssh_url":"[email protected]:Hearthstonepp/Hearthstonepp.git","clone_url":"https://github.com/Hearthstonepp/Hearthstonepp.git","svn_url":"https://github.com/Hearthstonepp/Hearthstonepp","homepage":"","size":3245,"stargazers_count":31,"watchers_count":31,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":7,"forks":6,"open_issues":7,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/pulls/27"},"html":{"href":"https://github.com/Hearthstonepp/Hearthstonepp/pull/27"},"issue":{"href":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/issues/27"},"comments":{"href":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/Hearthstonepp/Hearthstonepp/statuses/0134f363c1acbfa8c2db1a09b62a7ac1312d7cce"}},"author_association":"COLLABORATOR"}}
|
{
"id": 91815485,
"name": "Hearthstonepp/Hearthstonepp",
"url": "https://api.github.com/repos/Hearthstonepp/Hearthstonepp"
}
|
{
"id": 5622661,
"login": "utilForever",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5622661?",
"url": "https://api.github.com/users/utilForever"
}
|
{
"id": 31149860,
"login": "Hearthstonepp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31149860?",
"url": "https://api.github.com/orgs/Hearthstonepp"
}
| 2017-10-24T14:50:27 |
6758694759
|
{"actor":{"display_login":"utilForever"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Intel-bigdata/SSM/pulls/comments/116660556","pull_request_review_id":38297129,"id":116660556,"diff_hunk":"@@ -105,4 +111,37 @@ public ListRulesInfoResponseProto listRulesInfo(RpcController controller,\n throw new ServiceException(e);\n }\n }\n+\n+ @Override\n+ public DeleteRuleResponseProto deleteRule(RpcController controller,\n+ DeleteRuleRequestProto req) throws ServiceException {\n+ try {\n+ server.deleteRule(req.getRuleId(),req.getDropPendingCommands());","path":"hadoop-ssm-project/src/main/java/org/apache/hadoop/ssm/protocolPB/ClientSSMProtocolServerSideTranslatorPB.java","position":22,"original_position":22,"commit_id":"ab9634dcad2b44b3ad7162a111a4a06c94846899","original_commit_id":"ab9634dcad2b44b3ad7162a111a4a06c94846899","user":{"login":"littlezhou","id":10972684,"avatar_url":"https://avatars1.githubusercontent.com/u/10972684?v=3","gravatar_id":"","url":"https://api.github.com/users/littlezhou","html_url":"https://github.com/littlezhou","followers_url":"https://api.github.com/users/littlezhou/followers","following_url":"https://api.github.com/users/littlezhou/following{/other_user}","gists_url":"https://api.github.com/users/littlezhou/gists{/gist_id}","starred_url":"https://api.github.com/users/littlezhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/littlezhou/subscriptions","organizations_url":"https://api.github.com/users/littlezhou/orgs","repos_url":"https://api.github.com/users/littlezhou/repos","events_url":"https://api.github.com/users/littlezhou/events{/privacy}","received_events_url":"https://api.github.com/users/littlezhou/received_events","type":"User","site_admin":false},"body":"blank","created_at":"2017-05-16T06:01:40Z","updated_at":"2017-05-16T06:01:40Z","html_url":"https://github.com/Intel-bigdata/SSM/pull/133#discussion_r116660556","pull_request_url":"https://api.github.com/repos/Intel-bigdata/SSM/pulls/133","_links":{"self":{"href":"https://api.github.com/repos/Intel-bigdata/SSM/pulls/comments/116660556"},"html":{"href":"https://github.com/Intel-bigdata/SSM/pull/133#discussion_r116660556"},"pull_request":{"href":"https://api.github.com/repos/Intel-bigdata/SSM/pulls/133"}}},"pull_request":{"url":"https://api.github.com/repos/Intel-bigdata/SSM/pulls/133","id":120736289,"html_url":"https://github.com/Intel-bigdata/SSM/pull/133","diff_url":"https://github.com/Intel-bigdata/SSM/pull/133.diff","patch_url":"https://github.com/Intel-bigdata/SSM/pull/133.patch","issue_url":"https://api.github.com/repos/Intel-bigdata/SSM/issues/133","number":133,"state":"open","locked":false,"title":"#9 add method deleteRule,activateRule,disableRule","user":{"login":"cy122792387","id":25340536,"avatar_url":"https://avatars0.githubusercontent.com/u/25340536?v=3","gravatar_id":"","url":"https://api.github.com/users/cy122792387","html_url":"https://github.com/cy122792387","followers_url":"https://api.github.com/users/cy122792387/followers","following_url":"https://api.github.com/users/cy122792387/following{/other_user}","gists_url":"https://api.github.com/users/cy122792387/gists{/gist_id}","starred_url":"https://api.github.com/users/cy122792387/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cy122792387/subscriptions","organizations_url":"https://api.github.com/users/cy122792387/orgs","repos_url":"https://api.github.com/users/cy122792387/repos","events_url":"https://api.github.com/users/cy122792387/events{/privacy}","received_events_url":"https://api.github.com/users/cy122792387/received_events","type":"User","site_admin":false},"body":"and test","created_at":"2017-05-16T03:11:30Z","updated_at":"2017-05-16T06:01:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d230d59d23cd24345dad3fc9004f0073c786f08","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Intel-bigdata/SSM/pulls/133/commits","review_comments_url":"https://api.github.com/repos/Intel-bigdata/SSM/pulls/133/comments","review_comment_url":"https://api.github.com/repos/Intel-bigdata/SSM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Intel-bigdata/SSM/issues/133/comments","statuses_url":"https://api.github.com/repos/Intel-bigdata/SSM/statuses/ab9634dcad2b44b3ad7162a111a4a06c94846899","head":{"label":"cy122792387:ssm","ref":"ssm","sha":"ab9634dcad2b44b3ad7162a111a4a06c94846899","user":{"login":"cy122792387","id":25340536,"avatar_url":"https://avatars0.githubusercontent.com/u/25340536?v=3","gravatar_id":"","url":"https://api.github.com/users/cy122792387","html_url":"https://github.com/cy122792387","followers_url":"https://api.github.com/users/cy122792387/followers","following_url":"https://api.github.com/users/cy122792387/following{/other_user}","gists_url":"https://api.github.com/users/cy122792387/gists{/gist_id}","starred_url":"https://api.github.com/users/cy122792387/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cy122792387/subscriptions","organizations_url":"https://api.github.com/users/cy122792387/orgs","repos_url":"https://api.github.com/users/cy122792387/repos","events_url":"https://api.github.com/users/cy122792387/events{/privacy}","received_events_url":"https://api.github.com/users/cy122792387/received_events","type":"User","site_admin":false},"repo":{"id":91289638,"name":"SSM","full_name":"cy122792387/SSM","owner":{"login":"cy122792387","id":25340536,"avatar_url":"https://avatars0.githubusercontent.com/u/25340536?v=3","gravatar_id":"","url":"https://api.github.com/users/cy122792387","html_url":"https://github.com/cy122792387","followers_url":"https://api.github.com/users/cy122792387/followers","following_url":"https://api.github.com/users/cy122792387/following{/other_user}","gists_url":"https://api.github.com/users/cy122792387/gists{/gist_id}","starred_url":"https://api.github.com/users/cy122792387/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cy122792387/subscriptions","organizations_url":"https://api.github.com/users/cy122792387/orgs","repos_url":"https://api.github.com/users/cy122792387/repos","events_url":"https://api.github.com/users/cy122792387/events{/privacy}","received_events_url":"https://api.github.com/users/cy122792387/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cy122792387/SSM","description":"HDFS Smart Storage Management ","fork":true,"url":"https://api.github.com/repos/cy122792387/SSM","forks_url":"https://api.github.com/repos/cy122792387/SSM/forks","keys_url":"https://api.github.com/repos/cy122792387/SSM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cy122792387/SSM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cy122792387/SSM/teams","hooks_url":"https://api.github.com/repos/cy122792387/SSM/hooks","issue_events_url":"https://api.github.com/repos/cy122792387/SSM/issues/events{/number}","events_url":"https://api.github.com/repos/cy122792387/SSM/events","assignees_url":"https://api.github.com/repos/cy122792387/SSM/assignees{/user}","branches_url":"https://api.github.com/repos/cy122792387/SSM/branches{/branch}","tags_url":"https://api.github.com/repos/cy122792387/SSM/tags","blobs_url":"https://api.github.com/repos/cy122792387/SSM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cy122792387/SSM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cy122792387/SSM/git/refs{/sha}","trees_url":"https://api.github.com/repos/cy122792387/SSM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cy122792387/SSM/statuses/{sha}","languages_url":"https://api.github.com/repos/cy122792387/SSM/languages","stargazers_url":"https://api.github.com/repos/cy122792387/SSM/stargazers","contributors_url":"https://api.github.com/repos/cy122792387/SSM/contributors","subscribers_url":"https://api.github.com/repos/cy122792387/SSM/subscribers","subscription_url":"https://api.github.com/repos/cy122792387/SSM/subscription","commits_url":"https://api.github.com/repos/cy122792387/SSM/commits{/sha}","git_commits_url":"https://api.github.com/repos/cy122792387/SSM/git/commits{/sha}","comments_url":"https://api.github.com/repos/cy122792387/SSM/comments{/number}","issue_comment_url":"https://api.github.com/repos/cy122792387/SSM/issues/comments{/number}","contents_url":"https://api.github.com/repos/cy122792387/SSM/contents/{+path}","compare_url":"https://api.github.com/repos/cy122792387/SSM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cy122792387/SSM/merges","archive_url":"https://api.github.com/repos/cy122792387/SSM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cy122792387/SSM/downloads","issues_url":"https://api.github.com/repos/cy122792387/SSM/issues{/number}","pulls_url":"https://api.github.com/repos/cy122792387/SSM/pulls{/number}","milestones_url":"https://api.github.com/repos/cy122792387/SSM/milestones{/number}","notifications_url":"https://api.github.com/repos/cy122792387/SSM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cy122792387/SSM/labels{/name}","releases_url":"https://api.github.com/repos/cy122792387/SSM/releases{/id}","deployments_url":"https://api.github.com/repos/cy122792387/SSM/deployments","created_at":"2017-05-15T03:02:58Z","updated_at":"2017-05-15T03:03:35Z","pushed_at":"2017-05-16T05:04:22Z","git_url":"git://github.com/cy122792387/SSM.git","ssh_url":"[email protected]:cy122792387/SSM.git","clone_url":"https://github.com/cy122792387/SSM.git","svn_url":"https://github.com/cy122792387/SSM","homepage":"","size":278713,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"ssm"}},"base":{"label":"Intel-bigdata:ssm","ref":"ssm","sha":"9184a9886127ee94d526ccb1defee4fa2fab85c3","user":{"login":"Intel-bigdata","id":8433081,"avatar_url":"https://avatars0.githubusercontent.com/u/8433081?v=3","gravatar_id":"","url":"https://api.github.com/users/Intel-bigdata","html_url":"https://github.com/Intel-bigdata","followers_url":"https://api.github.com/users/Intel-bigdata/followers","following_url":"https://api.github.com/users/Intel-bigdata/following{/other_user}","gists_url":"https://api.github.com/users/Intel-bigdata/gists{/gist_id}","starred_url":"https://api.github.com/users/Intel-bigdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Intel-bigdata/subscriptions","organizations_url":"https://api.github.com/users/Intel-bigdata/orgs","repos_url":"https://api.github.com/users/Intel-bigdata/repos","events_url":"https://api.github.com/users/Intel-bigdata/events{/privacy}","received_events_url":"https://api.github.com/users/Intel-bigdata/received_events","type":"Organization","site_admin":false},"repo":{"id":78089297,"name":"SSM","full_name":"Intel-bigdata/SSM","owner":{"login":"Intel-bigdata","id":8433081,"avatar_url":"https://avatars0.githubusercontent.com/u/8433081?v=3","gravatar_id":"","url":"https://api.github.com/users/Intel-bigdata","html_url":"https://github.com/Intel-bigdata","followers_url":"https://api.github.com/users/Intel-bigdata/followers","following_url":"https://api.github.com/users/Intel-bigdata/following{/other_user}","gists_url":"https://api.github.com/users/Intel-bigdata/gists{/gist_id}","starred_url":"https://api.github.com/users/Intel-bigdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Intel-bigdata/subscriptions","organizations_url":"https://api.github.com/users/Intel-bigdata/orgs","repos_url":"https://api.github.com/users/Intel-bigdata/repos","events_url":"https://api.github.com/users/Intel-bigdata/events{/privacy}","received_events_url":"https://api.github.com/users/Intel-bigdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Intel-bigdata/SSM","description":"HDFS Smart Storage Management ","fork":false,"url":"https://api.github.com/repos/Intel-bigdata/SSM","forks_url":"https://api.github.com/repos/Intel-bigdata/SSM/forks","keys_url":"https://api.github.com/repos/Intel-bigdata/SSM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Intel-bigdata/SSM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Intel-bigdata/SSM/teams","hooks_url":"https://api.github.com/repos/Intel-bigdata/SSM/hooks","issue_events_url":"https://api.github.com/repos/Intel-bigdata/SSM/issues/events{/number}","events_url":"https://api.github.com/repos/Intel-bigdata/SSM/events","assignees_url":"https://api.github.com/repos/Intel-bigdata/SSM/assignees{/user}","branches_url":"https://api.github.com/repos/Intel-bigdata/SSM/branches{/branch}","tags_url":"https://api.github.com/repos/Intel-bigdata/SSM/tags","blobs_url":"https://api.github.com/repos/Intel-bigdata/SSM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Intel-bigdata/SSM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Intel-bigdata/SSM/git/refs{/sha}","trees_url":"https://api.github.com/repos/Intel-bigdata/SSM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Intel-bigdata/SSM/statuses/{sha}","languages_url":"https://api.github.com/repos/Intel-bigdata/SSM/languages","stargazers_url":"https://api.github.com/repos/Intel-bigdata/SSM/stargazers","contributors_url":"https://api.github.com/repos/Intel-bigdata/SSM/contributors","subscribers_url":"https://api.github.com/repos/Intel-bigdata/SSM/subscribers","subscription_url":"https://api.github.com/repos/Intel-bigdata/SSM/subscription","commits_url":"https://api.github.com/repos/Intel-bigdata/SSM/commits{/sha}","git_commits_url":"https://api.github.com/repos/Intel-bigdata/SSM/git/commits{/sha}","comments_url":"https://api.github.com/repos/Intel-bigdata/SSM/comments{/number}","issue_comment_url":"https://api.github.com/repos/Intel-bigdata/SSM/issues/comments{/number}","contents_url":"https://api.github.com/repos/Intel-bigdata/SSM/contents/{+path}","compare_url":"https://api.github.com/repos/Intel-bigdata/SSM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Intel-bigdata/SSM/merges","archive_url":"https://api.github.com/repos/Intel-bigdata/SSM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Intel-bigdata/SSM/downloads","issues_url":"https://api.github.com/repos/Intel-bigdata/SSM/issues{/number}","pulls_url":"https://api.github.com/repos/Intel-bigdata/SSM/pulls{/number}","milestones_url":"https://api.github.com/repos/Intel-bigdata/SSM/milestones{/number}","notifications_url":"https://api.github.com/repos/Intel-bigdata/SSM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Intel-bigdata/SSM/labels{/name}","releases_url":"https://api.github.com/repos/Intel-bigdata/SSM/releases{/id}","deployments_url":"https://api.github.com/repos/Intel-bigdata/SSM/deployments","created_at":"2017-01-05T07:13:54Z","updated_at":"2017-04-20T09:50:18Z","pushed_at":"2017-05-16T05:06:36Z","git_url":"git://github.com/Intel-bigdata/SSM.git","ssh_url":"[email protected]:Intel-bigdata/SSM.git","clone_url":"https://github.com/Intel-bigdata/SSM.git","svn_url":"https://github.com/Intel-bigdata/SSM","homepage":"","size":278730,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":37,"forks":7,"open_issues":37,"watchers":2,"default_branch":"ssm"}},"_links":{"self":{"href":"https://api.github.com/repos/Intel-bigdata/SSM/pulls/133"},"html":{"href":"https://github.com/Intel-bigdata/SSM/pull/133"},"issue":{"href":"https://api.github.com/repos/Intel-bigdata/SSM/issues/133"},"comments":{"href":"https://api.github.com/repos/Intel-bigdata/SSM/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/Intel-bigdata/SSM/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/Intel-bigdata/SSM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Intel-bigdata/SSM/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/Intel-bigdata/SSM/statuses/ab9634dcad2b44b3ad7162a111a4a06c94846899"}}}}
|
{
"id": 78089297,
"name": "Intel-bigdata/SSM",
"url": "https://api.github.com/repos/Intel-bigdata/SSM"
}
|
{
"id": 10972684,
"login": "littlezhou",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10972684?",
"url": "https://api.github.com/users/littlezhou"
}
|
{
"id": 8433081,
"login": "Intel-bigdata",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8433081?",
"url": "https://api.github.com/orgs/Intel-bigdata"
}
| 2017-05-16T06:01:40 |
5878727252
|
{"actor":{"display_login":"littlezhou"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Lv-219-Python/MoniNag/pulls/comments/103100112","pull_request_review_id":23877384,"id":103100112,"diff_hunk":"@@ -0,0 +1,70 @@\n+import { Component, OnInit, Input } from '@angular/core';\n+import { Location } from '@angular/common';\n+import { Observable } from 'rxjs/Observable';\n+import 'rxjs/add/operator/switchMap';\n+\n+import { Check } from './check';\n+import { CheckListComponent } from './check-list.component';\n+import { ChecksService } from './checks.service';\n+import { Plugin } from './plugin';\n+\n+\n+@Component({\n+ selector: 'checkupdate-app',\n+ template: `\n+ <div *ngIf=\"check\"><div>\n+ <h6>Name:</h6>\n+ <input [(ngModel)]=\"check.name\" placeholder=\"{{check.name}}\" />\n+ <h6>Run frequency:</h6>\n+ <select [(ngModel)]=\"check.run_freq\">\n+ <option value=1>1 min</option>\n+ <option value=5>5 min</option>\n+ <option value=15>15 min</option>\n+ <option value=30>30 min</option>\n+ <option value=1>1 hour</option>\n+ </select>\n+ <h6>Plugin:</h6>\n+ <select [(ngModel)]=\"check.plugin_id\">\n+ <option *ngFor=\"let plugin of plugins\" value= {{plugin.id}}>\n+ {{plugin.name}}\n+ </option>\n+ </select>\n+ <h6>Target port:</h6>\n+ <input [(ngModel)]=\"check.target_port\" placeholder=\"{{check.target_port}}\" />\n+ <h6>Active:</h6>","path":"moninag/static/src/ts/app/checks/check-update.component.ts","position":34,"original_position":34,"commit_id":"d4e7721d18f0f42a4aa95ada9c77f34b5e826ea8","original_commit_id":"d4e7721d18f0f42a4aa95ada9c77f34b5e826ea8","user":{"login":"orestch","id":2446549,"avatar_url":"https://avatars.githubusercontent.com/u/2446549?v=3","gravatar_id":"","url":"https://api.github.com/users/orestch","html_url":"https://github.com/orestch","followers_url":"https://api.github.com/users/orestch/followers","following_url":"https://api.github.com/users/orestch/following{/other_user}","gists_url":"https://api.github.com/users/orestch/gists{/gist_id}","starred_url":"https://api.github.com/users/orestch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orestch/subscriptions","organizations_url":"https://api.github.com/users/orestch/orgs","repos_url":"https://api.github.com/users/orestch/repos","events_url":"https://api.github.com/users/orestch/events{/privacy}","received_events_url":"https://api.github.com/users/orestch/received_events","type":"User","site_admin":false},"body":"use label instead of h6","created_at":"2017-02-26T09:47:35Z","updated_at":"2017-02-26T09:58:34Z","html_url":"https://github.com/Lv-219-Python/MoniNag/pull/35#discussion_r103100112","pull_request_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/Lv-219-Python/MoniNag/pulls/comments/103100112"},"html":{"href":"https://github.com/Lv-219-Python/MoniNag/pull/35#discussion_r103100112"},"pull_request":{"href":"https://api.github.com/repos/Lv-219-Python/MoniNag/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/Lv-219-Python/MoniNag/pulls/35","id":107689865,"html_url":"https://github.com/Lv-219-Python/MoniNag/pull/35","diff_url":"https://github.com/Lv-219-Python/MoniNag/pull/35.diff","patch_url":"https://github.com/Lv-219-Python/MoniNag/pull/35.patch","issue_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/issues/35","number":35,"state":"open","locked":false,"title":"Initial UI for a new website model","user":{"login":"lisovyk","id":24924432,"avatar_url":"https://avatars.githubusercontent.com/u/24924432?v=3","gravatar_id":"","url":"https://api.github.com/users/lisovyk","html_url":"https://github.com/lisovyk","followers_url":"https://api.github.com/users/lisovyk/followers","following_url":"https://api.github.com/users/lisovyk/following{/other_user}","gists_url":"https://api.github.com/users/lisovyk/gists{/gist_id}","starred_url":"https://api.github.com/users/lisovyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lisovyk/subscriptions","organizations_url":"https://api.github.com/users/lisovyk/orgs","repos_url":"https://api.github.com/users/lisovyk/repos","events_url":"https://api.github.com/users/lisovyk/events{/privacy}","received_events_url":"https://api.github.com/users/lisovyk/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-23T19:01:14Z","updated_at":"2017-02-26T09:58:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e65c182677a375b8d6386f9a1f9506a98e3beff","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/pulls/35/commits","review_comments_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/pulls/35/comments","review_comment_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/issues/35/comments","statuses_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/statuses/d4e7721d18f0f42a4aa95ada9c77f34b5e826ea8","head":{"label":"Lv-219-Python:ResponseForUIService","ref":"ResponseForUIService","sha":"d4e7721d18f0f42a4aa95ada9c77f34b5e826ea8","user":{"login":"Lv-219-Python","id":25081754,"avatar_url":"https://avatars.githubusercontent.com/u/25081754?v=3","gravatar_id":"","url":"https://api.github.com/users/Lv-219-Python","html_url":"https://github.com/Lv-219-Python","followers_url":"https://api.github.com/users/Lv-219-Python/followers","following_url":"https://api.github.com/users/Lv-219-Python/following{/other_user}","gists_url":"https://api.github.com/users/Lv-219-Python/gists{/gist_id}","starred_url":"https://api.github.com/users/Lv-219-Python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lv-219-Python/subscriptions","organizations_url":"https://api.github.com/users/Lv-219-Python/orgs","repos_url":"https://api.github.com/users/Lv-219-Python/repos","events_url":"https://api.github.com/users/Lv-219-Python/events{/privacy}","received_events_url":"https://api.github.com/users/Lv-219-Python/received_events","type":"Organization","site_admin":false},"repo":{"id":78860938,"name":"MoniNag","full_name":"Lv-219-Python/MoniNag","owner":{"login":"Lv-219-Python","id":25081754,"avatar_url":"https://avatars.githubusercontent.com/u/25081754?v=3","gravatar_id":"","url":"https://api.github.com/users/Lv-219-Python","html_url":"https://github.com/Lv-219-Python","followers_url":"https://api.github.com/users/Lv-219-Python/followers","following_url":"https://api.github.com/users/Lv-219-Python/following{/other_user}","gists_url":"https://api.github.com/users/Lv-219-Python/gists{/gist_id}","starred_url":"https://api.github.com/users/Lv-219-Python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lv-219-Python/subscriptions","organizations_url":"https://api.github.com/users/Lv-219-Python/orgs","repos_url":"https://api.github.com/users/Lv-219-Python/repos","events_url":"https://api.github.com/users/Lv-219-Python/events{/privacy}","received_events_url":"https://api.github.com/users/Lv-219-Python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Lv-219-Python/MoniNag","description":null,"fork":false,"url":"https://api.github.com/repos/Lv-219-Python/MoniNag","forks_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/forks","keys_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/teams","hooks_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/hooks","issue_events_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/issues/events{/number}","events_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/events","assignees_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/assignees{/user}","branches_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/branches{/branch}","tags_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/tags","blobs_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/statuses/{sha}","languages_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/languages","stargazers_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/stargazers","contributors_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/contributors","subscribers_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/subscribers","subscription_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/subscription","commits_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/contents/{+path}","compare_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/merges","archive_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/downloads","issues_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/issues{/number}","pulls_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/pulls{/number}","milestones_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/milestones{/number}","notifications_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/labels{/name}","releases_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/releases{/id}","deployments_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/deployments","created_at":"2017-01-13T15:24:43Z","updated_at":"2017-01-19T16:04:57Z","pushed_at":"2017-02-25T16:01:23Z","git_url":"git://github.com/Lv-219-Python/MoniNag.git","ssh_url":"[email protected]:Lv-219-Python/MoniNag.git","clone_url":"https://github.com/Lv-219-Python/MoniNag.git","svn_url":"https://github.com/Lv-219-Python/MoniNag","homepage":null,"size":1742,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"dev"}},"base":{"label":"Lv-219-Python:dev","ref":"dev","sha":"47b1f1bb23f34f971b95db03fd0fa83e765ae00b","user":{"login":"Lv-219-Python","id":25081754,"avatar_url":"https://avatars.githubusercontent.com/u/25081754?v=3","gravatar_id":"","url":"https://api.github.com/users/Lv-219-Python","html_url":"https://github.com/Lv-219-Python","followers_url":"https://api.github.com/users/Lv-219-Python/followers","following_url":"https://api.github.com/users/Lv-219-Python/following{/other_user}","gists_url":"https://api.github.com/users/Lv-219-Python/gists{/gist_id}","starred_url":"https://api.github.com/users/Lv-219-Python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lv-219-Python/subscriptions","organizations_url":"https://api.github.com/users/Lv-219-Python/orgs","repos_url":"https://api.github.com/users/Lv-219-Python/repos","events_url":"https://api.github.com/users/Lv-219-Python/events{/privacy}","received_events_url":"https://api.github.com/users/Lv-219-Python/received_events","type":"Organization","site_admin":false},"repo":{"id":78860938,"name":"MoniNag","full_name":"Lv-219-Python/MoniNag","owner":{"login":"Lv-219-Python","id":25081754,"avatar_url":"https://avatars.githubusercontent.com/u/25081754?v=3","gravatar_id":"","url":"https://api.github.com/users/Lv-219-Python","html_url":"https://github.com/Lv-219-Python","followers_url":"https://api.github.com/users/Lv-219-Python/followers","following_url":"https://api.github.com/users/Lv-219-Python/following{/other_user}","gists_url":"https://api.github.com/users/Lv-219-Python/gists{/gist_id}","starred_url":"https://api.github.com/users/Lv-219-Python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lv-219-Python/subscriptions","organizations_url":"https://api.github.com/users/Lv-219-Python/orgs","repos_url":"https://api.github.com/users/Lv-219-Python/repos","events_url":"https://api.github.com/users/Lv-219-Python/events{/privacy}","received_events_url":"https://api.github.com/users/Lv-219-Python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Lv-219-Python/MoniNag","description":null,"fork":false,"url":"https://api.github.com/repos/Lv-219-Python/MoniNag","forks_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/forks","keys_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/teams","hooks_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/hooks","issue_events_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/issues/events{/number}","events_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/events","assignees_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/assignees{/user}","branches_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/branches{/branch}","tags_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/tags","blobs_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/statuses/{sha}","languages_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/languages","stargazers_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/stargazers","contributors_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/contributors","subscribers_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/subscribers","subscription_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/subscription","commits_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/contents/{+path}","compare_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/merges","archive_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/downloads","issues_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/issues{/number}","pulls_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/pulls{/number}","milestones_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/milestones{/number}","notifications_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/labels{/name}","releases_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/releases{/id}","deployments_url":"https://api.github.com/repos/Lv-219-Python/MoniNag/deployments","created_at":"2017-01-13T15:24:43Z","updated_at":"2017-01-19T16:04:57Z","pushed_at":"2017-02-25T16:01:23Z","git_url":"git://github.com/Lv-219-Python/MoniNag.git","ssh_url":"[email protected]:Lv-219-Python/MoniNag.git","clone_url":"https://github.com/Lv-219-Python/MoniNag.git","svn_url":"https://github.com/Lv-219-Python/MoniNag","homepage":null,"size":1742,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Lv-219-Python/MoniNag/pulls/35"},"html":{"href":"https://github.com/Lv-219-Python/MoniNag/pull/35"},"issue":{"href":"https://api.github.com/repos/Lv-219-Python/MoniNag/issues/35"},"comments":{"href":"https://api.github.com/repos/Lv-219-Python/MoniNag/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/Lv-219-Python/MoniNag/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/Lv-219-Python/MoniNag/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Lv-219-Python/MoniNag/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/Lv-219-Python/MoniNag/statuses/d4e7721d18f0f42a4aa95ada9c77f34b5e826ea8"}}}}
|
{
"id": 78860938,
"name": "Lv-219-Python/MoniNag",
"url": "https://api.github.com/repos/Lv-219-Python/MoniNag"
}
|
{
"id": 2446549,
"login": "orestch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2446549?",
"url": "https://api.github.com/users/orestch"
}
|
{
"id": 25081754,
"login": "Lv-219-Python",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25081754?",
"url": "https://api.github.com/orgs/Lv-219-Python"
}
| 2017-02-26T09:47:35 |
5392337409
|
{"actor":{"display_login":"orestch"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/comments/99999084","pull_request_review_id":20690214,"id":99999084,"diff_hunk":"@@ -308,6 +310,33 @@ public void onSetSize(float width, float height, CallbackInfo ci) {\n }\n }\n \n+ @Inject(method = \"setDead\", at = @At(\"HEAD\"))\n+ public void onSetDead(CallbackInfo ci) {\n+ net.minecraft.entity.Entity mcEntity = (net.minecraft.entity.Entity) (Object) this;\n+ if (!this.world.isRemote && (!(mcEntity instanceof EntityLivingBase) || (mcEntity instanceof EntityArmorStand))) {\n+ IMixinWorldServer spongeWorld = (IMixinWorldServer) this.world;\n+ final CauseTracker causeTracker = spongeWorld.getCauseTracker();\n+\n+ PhaseData phaseData = causeTracker.getCurrentPhaseData();\n+\n+ Cause.Builder causeBuilder = Cause.builder();\n+ Optional<Object> sourceOptional = phaseData.context.getSource(Object.class);\n+ sourceOptional.ifPresent(source -> {\n+ causeBuilder.named(NamedCause.source(source));\n+ if (source instanceof Projectile) {\n+ ProjectileSource projectileSource = ((Projectile) source).getShooter();\n+ causeBuilder.named(NamedCause.of(NamedCause.THROWER, projectileSource));\n+ }\n+ });\n+ Optional<ItemStack> usedItemOptional = phaseData.context.firstNamed(\"ItemUsed\", ItemStack.class);\n+ usedItemOptional.ifPresent(item -> causeBuilder.named(NamedCause.of(\"ItemUsed\", item)));","path":"src/main/java/org/spongepowered/common/mixin/core/entity/MixinEntity.java","position":79,"original_position":79,"commit_id":"3ad44db1669ee6ca1a7af0eeba23a37bbe87831b","original_commit_id":"3ad44db1669ee6ca1a7af0eeba23a37bbe87831b","user":{"login":"me4502","id":546754,"avatar_url":"https://avatars.githubusercontent.com/u/546754?v=3","gravatar_id":"","url":"https://api.github.com/users/me4502","html_url":"https://github.com/me4502","followers_url":"https://api.github.com/users/me4502/followers","following_url":"https://api.github.com/users/me4502/following{/other_user}","gists_url":"https://api.github.com/users/me4502/gists{/gist_id}","starred_url":"https://api.github.com/users/me4502/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/me4502/subscriptions","organizations_url":"https://api.github.com/users/me4502/orgs","repos_url":"https://api.github.com/users/me4502/repos","events_url":"https://api.github.com/users/me4502/events{/privacy}","received_events_url":"https://api.github.com/users/me4502/received_events","type":"User","site_admin":false},"body":"Which part of it do you want multiline? Nothing there should really ever throw an exception.","created_at":"2017-02-08T06:26:04Z","updated_at":"2017-02-08T06:26:04Z","html_url":"https://github.com/SpongePowered/SpongeCommon/pull/1157#discussion_r99999084","pull_request_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1157","_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/comments/99999084"},"html":{"href":"https://github.com/SpongePowered/SpongeCommon/pull/1157#discussion_r99999084"},"pull_request":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1157"}}},"pull_request":{"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1157","id":103049985,"html_url":"https://github.com/SpongePowered/SpongeCommon/pull/1157","diff_url":"https://github.com/SpongePowered/SpongeCommon/pull/1157.diff","patch_url":"https://github.com/SpongePowered/SpongeCommon/pull/1157.patch","issue_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/1157","number":1157,"state":"open","locked":false,"title":"Implementing DestructEntityEvent for non-living entities.","user":{"login":"me4502","id":546754,"avatar_url":"https://avatars.githubusercontent.com/u/546754?v=3","gravatar_id":"","url":"https://api.github.com/users/me4502","html_url":"https://github.com/me4502","followers_url":"https://api.github.com/users/me4502/followers","following_url":"https://api.github.com/users/me4502/following{/other_user}","gists_url":"https://api.github.com/users/me4502/gists{/gist_id}","starred_url":"https://api.github.com/users/me4502/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/me4502/subscriptions","organizations_url":"https://api.github.com/users/me4502/orgs","repos_url":"https://api.github.com/users/me4502/repos","events_url":"https://api.github.com/users/me4502/events{/privacy}","received_events_url":"https://api.github.com/users/me4502/received_events","type":"User","site_admin":false},"body":"This PR implements DestructEntityEvent for non-living entities.\r\n\r\nThe following code has been used to test it,\r\n\r\n```\r\n@Listener\r\npublic void onBlockForm(DestructEntityEvent event) {\r\n System.out.println(event.getCause());\r\n}\r\n```","created_at":"2017-01-25T03:37:26Z","updated_at":"2017-02-08T06:26:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00a9ec16a6a0f82cd33cb6e5fbf4147027965280","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1157/commits","review_comments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1157/comments","review_comment_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/1157/comments","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/statuses/3ad44db1669ee6ca1a7af0eeba23a37bbe87831b","head":{"label":"SpongePowered:feature/destruct-nonliving-entity-impl","ref":"feature/destruct-nonliving-entity-impl","sha":"3ad44db1669ee6ca1a7af0eeba23a37bbe87831b","user":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"repo":{"id":33791453,"name":"SpongeCommon","full_name":"SpongePowered/SpongeCommon","owner":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpongePowered/SpongeCommon","description":"Shared code between SpongeForge and SpongeVanilla","fork":false,"url":"https://api.github.com/repos/SpongePowered/SpongeCommon","forks_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/forks","keys_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/teams","hooks_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/hooks","issue_events_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/events{/number}","events_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/events","assignees_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/assignees{/user}","branches_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/branches{/branch}","tags_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/tags","blobs_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/statuses/{sha}","languages_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/languages","stargazers_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/stargazers","contributors_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/contributors","subscribers_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/subscribers","subscription_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/subscription","commits_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/contents/{+path}","compare_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/merges","archive_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/downloads","issues_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues{/number}","pulls_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls{/number}","milestones_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/milestones{/number}","notifications_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/labels{/name}","releases_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/releases{/id}","deployments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/deployments","created_at":"2015-04-11T20:38:48Z","updated_at":"2017-02-05T05:33:15Z","pushed_at":"2017-02-08T02:36:21Z","git_url":"git://github.com/SpongePowered/SpongeCommon.git","ssh_url":"[email protected]:SpongePowered/SpongeCommon.git","clone_url":"https://github.com/SpongePowered/SpongeCommon.git","svn_url":"https://github.com/SpongePowered/SpongeCommon","homepage":"","size":18712,"stargazers_count":111,"watchers_count":111,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":175,"forks":99,"open_issues":175,"watchers":111,"default_branch":"bleeding"}},"base":{"label":"SpongePowered:bleeding","ref":"bleeding","sha":"91c52f4d40aa99d9a331ab9111d1aa1724f61f94","user":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"repo":{"id":33791453,"name":"SpongeCommon","full_name":"SpongePowered/SpongeCommon","owner":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars.githubusercontent.com/u/8683473?v=3","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpongePowered/SpongeCommon","description":"Shared code between SpongeForge and SpongeVanilla","fork":false,"url":"https://api.github.com/repos/SpongePowered/SpongeCommon","forks_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/forks","keys_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/teams","hooks_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/hooks","issue_events_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/events{/number}","events_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/events","assignees_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/assignees{/user}","branches_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/branches{/branch}","tags_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/tags","blobs_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/statuses/{sha}","languages_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/languages","stargazers_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/stargazers","contributors_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/contributors","subscribers_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/subscribers","subscription_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/subscription","commits_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/contents/{+path}","compare_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/merges","archive_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/downloads","issues_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues{/number}","pulls_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls{/number}","milestones_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/milestones{/number}","notifications_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/labels{/name}","releases_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/releases{/id}","deployments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/deployments","created_at":"2015-04-11T20:38:48Z","updated_at":"2017-02-05T05:33:15Z","pushed_at":"2017-02-08T02:36:21Z","git_url":"git://github.com/SpongePowered/SpongeCommon.git","ssh_url":"[email protected]:SpongePowered/SpongeCommon.git","clone_url":"https://github.com/SpongePowered/SpongeCommon.git","svn_url":"https://github.com/SpongePowered/SpongeCommon","homepage":"","size":18712,"stargazers_count":111,"watchers_count":111,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":175,"forks":99,"open_issues":175,"watchers":111,"default_branch":"bleeding"}},"_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1157"},"html":{"href":"https://github.com/SpongePowered/SpongeCommon/pull/1157"},"issue":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/1157"},"comments":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/1157/comments"},"review_comments":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1157/comments"},"review_comment":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1157/commits"},"statuses":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/statuses/3ad44db1669ee6ca1a7af0eeba23a37bbe87831b"}}}}
|
{
"id": 33791453,
"name": "SpongePowered/SpongeCommon",
"url": "https://api.github.com/repos/SpongePowered/SpongeCommon"
}
|
{
"id": 546754,
"login": "me4502",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/546754?",
"url": "https://api.github.com/users/me4502"
}
|
{
"id": 8683473,
"login": "SpongePowered",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8683473?",
"url": "https://api.github.com/orgs/SpongePowered"
}
| 2017-02-08T06:26:04 |
5285714152
|
{"actor":{"display_login":"me4502"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/comments/152474223","pull_request_review_id":78340421,"id":152474223,"diff_hunk":"@@ -0,0 +1,102 @@\n+/*\n+ * This file is part of Sponge, licensed under the MIT License (MIT).\n+ *\n+ * Copyright (c) SpongePowered <https://www.spongepowered.org>\n+ * Copyright (c) contributors\n+ *\n+ * Permission is hereby granted, free of charge, to any person obtaining a copy\n+ * of this software and associated documentation files (the \"Software\"), to deal\n+ * in the Software without restriction, including without limitation the rights\n+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+ * copies of the Software, and to permit persons to whom the Software is\n+ * furnished to do so, subject to the following conditions:\n+ *\n+ * The above copyright notice and this permission notice shall be included in\n+ * all copies or substantial portions of the Software.\n+ *\n+ * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+ * THE SOFTWARE.\n+ */\n+package org.spongepowered.common.item.enchantment;\n+\n+import static com.google.common.base.Preconditions.checkArgument;\n+import static com.google.common.base.Preconditions.checkNotNull;\n+import static com.google.common.base.Preconditions.checkState;\n+\n+import org.spongepowered.api.data.DataView;\n+import org.spongepowered.api.data.Queries;\n+import org.spongepowered.api.item.enchantment.Enchantment;\n+import org.spongepowered.api.data.persistence.AbstractDataBuilder;\n+import org.spongepowered.api.data.persistence.InvalidDataException;\n+import org.spongepowered.api.item.enchantment.EnchantmentType;\n+import org.spongepowered.common.SpongeImpl;\n+import org.spongepowered.common.data.util.DataUtil;\n+\n+import java.util.Optional;\n+\n+import javax.annotation.Nullable;\n+\n+public final class SpongeEnchantmentBuilder extends AbstractDataBuilder<Enchantment> implements Enchantment.Builder {\n+\n+ @Nullable private EnchantmentType enchantmentType;\n+ @Nullable private Integer level;\n+\n+ public SpongeEnchantmentBuilder() {\n+ super(Enchantment.class, 1);\n+ }\n+\n+ @Override\n+ public Enchantment.Builder from(final Enchantment value) {\n+ this.enchantmentType = value.getType();","path":"src/main/java/org/spongepowered/common/item/enchantment/SpongeEnchantmentBuilder.java","position":55,"original_position":55,"commit_id":"ba802cc85b143e7268596b5c8d990d47bf703b80","original_commit_id":"ba802cc85b143e7268596b5c8d990d47bf703b80","user":{"login":"gabizou","id":1203877,"avatar_url":"https://avatars2.githubusercontent.com/u/1203877?v=4","gravatar_id":"","url":"https://api.github.com/users/gabizou","html_url":"https://github.com/gabizou","followers_url":"https://api.github.com/users/gabizou/followers","following_url":"https://api.github.com/users/gabizou/following{/other_user}","gists_url":"https://api.github.com/users/gabizou/gists{/gist_id}","starred_url":"https://api.github.com/users/gabizou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabizou/subscriptions","organizations_url":"https://api.github.com/users/gabizou/orgs","repos_url":"https://api.github.com/users/gabizou/repos","events_url":"https://api.github.com/users/gabizou/events{/privacy}","received_events_url":"https://api.github.com/users/gabizou/received_events","type":"User","site_admin":false},"body":"Needs a null check.","created_at":"2017-11-22T05:47:12Z","updated_at":"2017-11-22T05:50:57Z","html_url":"https://github.com/SpongePowered/SpongeCommon/pull/1593#discussion_r152474223","pull_request_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1593","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/comments/152474223"},"html":{"href":"https://github.com/SpongePowered/SpongeCommon/pull/1593#discussion_r152474223"},"pull_request":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1593"}}},"pull_request":{"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1593","id":152098556,"html_url":"https://github.com/SpongePowered/SpongeCommon/pull/1593","diff_url":"https://github.com/SpongePowered/SpongeCommon/pull/1593.diff","patch_url":"https://github.com/SpongePowered/SpongeCommon/pull/1593.patch","issue_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/1593","number":1593,"state":"open","locked":false,"title":"Cleanup of enchantments","user":{"login":"Meronat","id":18372958,"avatar_url":"https://avatars0.githubusercontent.com/u/18372958?v=4","gravatar_id":"","url":"https://api.github.com/users/Meronat","html_url":"https://github.com/Meronat","followers_url":"https://api.github.com/users/Meronat/followers","following_url":"https://api.github.com/users/Meronat/following{/other_user}","gists_url":"https://api.github.com/users/Meronat/gists{/gist_id}","starred_url":"https://api.github.com/users/Meronat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Meronat/subscriptions","organizations_url":"https://api.github.com/users/Meronat/orgs","repos_url":"https://api.github.com/users/Meronat/repos","events_url":"https://api.github.com/users/Meronat/events{/privacy}","received_events_url":"https://api.github.com/users/Meronat/received_events","type":"User","site_admin":false},"body":"[SpongeAPI](https://github.com/SpongePowered/SpongeAPI/pull/1687) | **SpongeCommon** | [SpongeVanilla](https://github.com/SpongePowered/SpongeVanilla/pull/361) | [SpongeForge](https://github.com/SpongePowered/SpongeForge/pull/1847)\r\n\r\nRead API PR for more information.","created_at":"2017-11-12T10:43:57Z","updated_at":"2017-11-22T05:50:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a062c6eb71191eda97ebf7f952ba488378ed14f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1593/commits","review_comments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1593/comments","review_comment_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/1593/comments","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/statuses/ba802cc85b143e7268596b5c8d990d47bf703b80","head":{"label":"Meronat:feature/enchantment-clean","ref":"feature/enchantment-clean","sha":"ba802cc85b143e7268596b5c8d990d47bf703b80","user":{"login":"Meronat","id":18372958,"avatar_url":"https://avatars0.githubusercontent.com/u/18372958?v=4","gravatar_id":"","url":"https://api.github.com/users/Meronat","html_url":"https://github.com/Meronat","followers_url":"https://api.github.com/users/Meronat/followers","following_url":"https://api.github.com/users/Meronat/following{/other_user}","gists_url":"https://api.github.com/users/Meronat/gists{/gist_id}","starred_url":"https://api.github.com/users/Meronat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Meronat/subscriptions","organizations_url":"https://api.github.com/users/Meronat/orgs","repos_url":"https://api.github.com/users/Meronat/repos","events_url":"https://api.github.com/users/Meronat/events{/privacy}","received_events_url":"https://api.github.com/users/Meronat/received_events","type":"User","site_admin":false},"repo":{"id":87684512,"name":"SpongeCommon","full_name":"Meronat/SpongeCommon","owner":{"login":"Meronat","id":18372958,"avatar_url":"https://avatars0.githubusercontent.com/u/18372958?v=4","gravatar_id":"","url":"https://api.github.com/users/Meronat","html_url":"https://github.com/Meronat","followers_url":"https://api.github.com/users/Meronat/followers","following_url":"https://api.github.com/users/Meronat/following{/other_user}","gists_url":"https://api.github.com/users/Meronat/gists{/gist_id}","starred_url":"https://api.github.com/users/Meronat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Meronat/subscriptions","organizations_url":"https://api.github.com/users/Meronat/orgs","repos_url":"https://api.github.com/users/Meronat/repos","events_url":"https://api.github.com/users/Meronat/events{/privacy}","received_events_url":"https://api.github.com/users/Meronat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Meronat/SpongeCommon","description":"Shared code between SpongeForge and SpongeVanilla","fork":true,"url":"https://api.github.com/repos/Meronat/SpongeCommon","forks_url":"https://api.github.com/repos/Meronat/SpongeCommon/forks","keys_url":"https://api.github.com/repos/Meronat/SpongeCommon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Meronat/SpongeCommon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Meronat/SpongeCommon/teams","hooks_url":"https://api.github.com/repos/Meronat/SpongeCommon/hooks","issue_events_url":"https://api.github.com/repos/Meronat/SpongeCommon/issues/events{/number}","events_url":"https://api.github.com/repos/Meronat/SpongeCommon/events","assignees_url":"https://api.github.com/repos/Meronat/SpongeCommon/assignees{/user}","branches_url":"https://api.github.com/repos/Meronat/SpongeCommon/branches{/branch}","tags_url":"https://api.github.com/repos/Meronat/SpongeCommon/tags","blobs_url":"https://api.github.com/repos/Meronat/SpongeCommon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Meronat/SpongeCommon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Meronat/SpongeCommon/git/refs{/sha}","trees_url":"https://api.github.com/repos/Meronat/SpongeCommon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Meronat/SpongeCommon/statuses/{sha}","languages_url":"https://api.github.com/repos/Meronat/SpongeCommon/languages","stargazers_url":"https://api.github.com/repos/Meronat/SpongeCommon/stargazers","contributors_url":"https://api.github.com/repos/Meronat/SpongeCommon/contributors","subscribers_url":"https://api.github.com/repos/Meronat/SpongeCommon/subscribers","subscription_url":"https://api.github.com/repos/Meronat/SpongeCommon/subscription","commits_url":"https://api.github.com/repos/Meronat/SpongeCommon/commits{/sha}","git_commits_url":"https://api.github.com/repos/Meronat/SpongeCommon/git/commits{/sha}","comments_url":"https://api.github.com/repos/Meronat/SpongeCommon/comments{/number}","issue_comment_url":"https://api.github.com/repos/Meronat/SpongeCommon/issues/comments{/number}","contents_url":"https://api.github.com/repos/Meronat/SpongeCommon/contents/{+path}","compare_url":"https://api.github.com/repos/Meronat/SpongeCommon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Meronat/SpongeCommon/merges","archive_url":"https://api.github.com/repos/Meronat/SpongeCommon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Meronat/SpongeCommon/downloads","issues_url":"https://api.github.com/repos/Meronat/SpongeCommon/issues{/number}","pulls_url":"https://api.github.com/repos/Meronat/SpongeCommon/pulls{/number}","milestones_url":"https://api.github.com/repos/Meronat/SpongeCommon/milestones{/number}","notifications_url":"https://api.github.com/repos/Meronat/SpongeCommon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Meronat/SpongeCommon/labels{/name}","releases_url":"https://api.github.com/repos/Meronat/SpongeCommon/releases{/id}","deployments_url":"https://api.github.com/repos/Meronat/SpongeCommon/deployments","created_at":"2017-04-09T05:11:36Z","updated_at":"2017-04-09T05:11:44Z","pushed_at":"2017-11-22T05:09:19Z","git_url":"git://github.com/Meronat/SpongeCommon.git","ssh_url":"[email protected]:Meronat/SpongeCommon.git","clone_url":"https://github.com/Meronat/SpongeCommon.git","svn_url":"https://github.com/Meronat/SpongeCommon","homepage":"","size":21904,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"bleeding"}},"base":{"label":"SpongePowered:bleeding","ref":"bleeding","sha":"fc30a85cbe060aa33c338933377348841f8f12c5","user":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars1.githubusercontent.com/u/8683473?v=4","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"repo":{"id":33791453,"name":"SpongeCommon","full_name":"SpongePowered/SpongeCommon","owner":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars1.githubusercontent.com/u/8683473?v=4","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpongePowered/SpongeCommon","description":"Shared code between SpongeForge and SpongeVanilla","fork":false,"url":"https://api.github.com/repos/SpongePowered/SpongeCommon","forks_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/forks","keys_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/teams","hooks_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/hooks","issue_events_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/events{/number}","events_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/events","assignees_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/assignees{/user}","branches_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/branches{/branch}","tags_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/tags","blobs_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/statuses/{sha}","languages_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/languages","stargazers_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/stargazers","contributors_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/contributors","subscribers_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/subscribers","subscription_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/subscription","commits_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/contents/{+path}","compare_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/merges","archive_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/downloads","issues_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues{/number}","pulls_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls{/number}","milestones_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/milestones{/number}","notifications_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/labels{/name}","releases_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/releases{/id}","deployments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/deployments","created_at":"2015-04-11T20:38:48Z","updated_at":"2017-11-10T19:39:14Z","pushed_at":"2017-11-22T05:16:40Z","git_url":"git://github.com/SpongePowered/SpongeCommon.git","ssh_url":"[email protected]:SpongePowered/SpongeCommon.git","clone_url":"https://github.com/SpongePowered/SpongeCommon.git","svn_url":"https://github.com/SpongePowered/SpongeCommon","homepage":"","size":21995,"stargazers_count":132,"watchers_count":132,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":115,"mirror_url":null,"archived":false,"open_issues_count":224,"forks":115,"open_issues":224,"watchers":132,"default_branch":"bleeding"}},"_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1593"},"html":{"href":"https://github.com/SpongePowered/SpongeCommon/pull/1593"},"issue":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/1593"},"comments":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/1593/comments"},"review_comments":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1593/comments"},"review_comment":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1593/commits"},"statuses":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/statuses/ba802cc85b143e7268596b5c8d990d47bf703b80"}},"author_association":"MEMBER"}}
|
{
"id": 33791453,
"name": "SpongePowered/SpongeCommon",
"url": "https://api.github.com/repos/SpongePowered/SpongeCommon"
}
|
{
"id": 1203877,
"login": "gabizou",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1203877?",
"url": "https://api.github.com/users/gabizou"
}
|
{
"id": 8683473,
"login": "SpongePowered",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8683473?",
"url": "https://api.github.com/orgs/SpongePowered"
}
| 2017-11-22T05:47:12 |
6888425501
|
{"actor":{"display_login":"gabizou"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/comments/109163419","pull_request_review_id":30249574,"id":109163419,"diff_hunk":"@@ -1,2 +1,99 @@\n <h1>Select Area</h1>\n-<p>Draw tools go here</p>\n+<p id=\"draw-pane-header-description\">\n+ Lorem ipsum dolor sit amet, consectetur adipiscing elit.\n+ Duis ac pharetra nibh. Nullam gravida massa non egestas\n+ pellentesque.\n+</p>\n+<div id=\"draw-pane-buttons\">","path":"src/mmw/js/src/draw/templates/window.html","position":8,"original_position":8,"commit_id":"e6a171379865cfa41d373851f7f11f7aa7d06ca3","original_commit_id":"e6a171379865cfa41d373851f7f11f7aa7d06ca3","user":{"login":"kellyi","id":4165523,"avatar_url":"https://avatars2.githubusercontent.com/u/4165523?v=3","gravatar_id":"","url":"https://api.github.com/users/kellyi","html_url":"https://github.com/kellyi","followers_url":"https://api.github.com/users/kellyi/followers","following_url":"https://api.github.com/users/kellyi/following{/other_user}","gists_url":"https://api.github.com/users/kellyi/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyi/subscriptions","organizations_url":"https://api.github.com/users/kellyi/orgs","repos_url":"https://api.github.com/users/kellyi/repos","events_url":"https://api.github.com/users/kellyi/events{/privacy}","received_events_url":"https://api.github.com/users/kellyi/received_events","type":"User","site_admin":false},"body":"Yeah, that looks much better, so I'll push a fixup with this change!","created_at":"2017-03-31T13:48:49Z","updated_at":"2017-03-31T13:48:49Z","html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1778#discussion_r109163419","pull_request_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1778","_links":{"self":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/comments/109163419"},"html":{"href":"https://github.com/WikiWatershed/model-my-watershed/pull/1778#discussion_r109163419"},"pull_request":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1778"}}},"pull_request":{"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1778","id":113302090,"html_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1778","diff_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1778.diff","patch_url":"https://github.com/WikiWatershed/model-my-watershed/pull/1778.patch","issue_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1778","number":1778,"state":"open","locked":false,"title":"Move draw tools from map to pane","user":{"login":"kellyi","id":4165523,"avatar_url":"https://avatars2.githubusercontent.com/u/4165523?v=3","gravatar_id":"","url":"https://api.github.com/users/kellyi","html_url":"https://github.com/kellyi","followers_url":"https://api.github.com/users/kellyi/followers","following_url":"https://api.github.com/users/kellyi/following{/other_user}","gists_url":"https://api.github.com/users/kellyi/gists{/gist_id}","starred_url":"https://api.github.com/users/kellyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellyi/subscriptions","organizations_url":"https://api.github.com/users/kellyi/orgs","repos_url":"https://api.github.com/users/kellyi/repos","events_url":"https://api.github.com/users/kellyi/events{/privacy}","received_events_url":"https://api.github.com/users/kellyi/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\nThis PR moves the draw tools from the map onto a sidebar as displayed in the wireframes linked from #1735 \r\n\r\nThe styling currently roughly matches what's in the wireframes, and the image below shows the behavior. \r\n\r\nSuccinctly: clicking to toggle a draw tool active de-activates and closes any others which are open, and clicking again on an active draw tool deactivates it. The x/close buttons call the reset action.\r\n\r\nConnects #1735 \r\n\r\n### Demo\r\n\r\n\r\n\r\n### Notes\r\n\r\nThe new DrawWindow view mostly supplants the old ToolbarView; the only reason that view has been kept around now is so that we can keep the shapefile upload button there. #1735 suggested not bothering to change it, but if we'd like I can move it -- and thereby remove the rest of the ToolbarView.\r\n\r\nTagging @jfrankl for answers to the following Qs:\r\n\r\n* should we keep the tooltips for each item in the lists?\r\n* how should these lists be styled?\r\n\r\n## Testing Instructions\r\n\r\n * get this branch, then `./scripts/bundle.sh --vendor` and `./scripts/bundle.sh`\r\n * visit localhost:8000 and hard refresh\r\n * when the draw pane loads verify that all the controls still work (note: the Shapefile upload section's currently not active per note in #1735, and I left the old toolbar version on the map).\r\n * move back and forth between modeling, analyze, and draw, and verify that the tools continue to work\r\n * verify that the x/ reset button resets the drawing state\r\n * verify that the rest of the app still works as expected","created_at":"2017-03-29T21:45:39Z","updated_at":"2017-03-31T13:48:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60e88f6b8f7ade3644e65f91dce5cce289a5ebaf","assignee":{"login":"arottersman","id":7633670,"avatar_url":"https://avatars0.githubusercontent.com/u/7633670?v=3","gravatar_id":"","url":"https://api.github.com/users/arottersman","html_url":"https://github.com/arottersman","followers_url":"https://api.github.com/users/arottersman/followers","following_url":"https://api.github.com/users/arottersman/following{/other_user}","gists_url":"https://api.github.com/users/arottersman/gists{/gist_id}","starred_url":"https://api.github.com/users/arottersman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arottersman/subscriptions","organizations_url":"https://api.github.com/users/arottersman/orgs","repos_url":"https://api.github.com/users/arottersman/repos","events_url":"https://api.github.com/users/arottersman/events{/privacy}","received_events_url":"https://api.github.com/users/arottersman/received_events","type":"User","site_admin":false},"assignees":[{"login":"arottersman","id":7633670,"avatar_url":"https://avatars0.githubusercontent.com/u/7633670?v=3","gravatar_id":"","url":"https://api.github.com/users/arottersman","html_url":"https://github.com/arottersman","followers_url":"https://api.github.com/users/arottersman/followers","following_url":"https://api.github.com/users/arottersman/following{/other_user}","gists_url":"https://api.github.com/users/arottersman/gists{/gist_id}","starred_url":"https://api.github.com/users/arottersman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arottersman/subscriptions","organizations_url":"https://api.github.com/users/arottersman/orgs","repos_url":"https://api.github.com/users/arottersman/repos","events_url":"https://api.github.com/users/arottersman/events{/privacy}","received_events_url":"https://api.github.com/users/arottersman/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1778/commits","review_comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1778/comments","review_comment_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1778/comments","statuses_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/statuses/e6a171379865cfa41d373851f7f11f7aa7d06ca3","head":{"label":"WikiWatershed:ki/move-draw-tools-to-pane","ref":"ki/move-draw-tools-to-pane","sha":"e6a171379865cfa41d373851f7f11f7aa7d06ca3","user":{"login":"WikiWatershed","id":8520008,"avatar_url":"https://avatars2.githubusercontent.com/u/8520008?v=3","gravatar_id":"","url":"https://api.github.com/users/WikiWatershed","html_url":"https://github.com/WikiWatershed","followers_url":"https://api.github.com/users/WikiWatershed/followers","following_url":"https://api.github.com/users/WikiWatershed/following{/other_user}","gists_url":"https://api.github.com/users/WikiWatershed/gists{/gist_id}","starred_url":"https://api.github.com/users/WikiWatershed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WikiWatershed/subscriptions","organizations_url":"https://api.github.com/users/WikiWatershed/orgs","repos_url":"https://api.github.com/users/WikiWatershed/repos","events_url":"https://api.github.com/users/WikiWatershed/events{/privacy}","received_events_url":"https://api.github.com/users/WikiWatershed/received_events","type":"Organization","site_admin":false},"repo":{"id":32742922,"name":"model-my-watershed","full_name":"WikiWatershed/model-my-watershed","owner":{"login":"WikiWatershed","id":8520008,"avatar_url":"https://avatars2.githubusercontent.com/u/8520008?v=3","gravatar_id":"","url":"https://api.github.com/users/WikiWatershed","html_url":"https://github.com/WikiWatershed","followers_url":"https://api.github.com/users/WikiWatershed/followers","following_url":"https://api.github.com/users/WikiWatershed/following{/other_user}","gists_url":"https://api.github.com/users/WikiWatershed/gists{/gist_id}","starred_url":"https://api.github.com/users/WikiWatershed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WikiWatershed/subscriptions","organizations_url":"https://api.github.com/users/WikiWatershed/orgs","repos_url":"https://api.github.com/users/WikiWatershed/repos","events_url":"https://api.github.com/users/WikiWatershed/events{/privacy}","received_events_url":"https://api.github.com/users/WikiWatershed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WikiWatershed/model-my-watershed","description":"The web application front end for Model My Watershed.","fork":false,"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed","forks_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/forks","keys_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/teams","hooks_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/hooks","issue_events_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/events{/number}","events_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/events","assignees_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/assignees{/user}","branches_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/branches{/branch}","tags_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/tags","blobs_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/refs{/sha}","trees_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/statuses/{sha}","languages_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/languages","stargazers_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/stargazers","contributors_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/contributors","subscribers_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/subscribers","subscription_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/subscription","commits_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/commits{/sha}","git_commits_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/commits{/sha}","comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/comments{/number}","issue_comment_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/comments{/number}","contents_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/contents/{+path}","compare_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/merges","archive_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/downloads","issues_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues{/number}","pulls_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls{/number}","milestones_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/milestones{/number}","notifications_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/labels{/name}","releases_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/releases{/id}","deployments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/deployments","created_at":"2015-03-23T16:02:55Z","updated_at":"2017-03-08T08:55:38Z","pushed_at":"2017-03-30T21:11:24Z","git_url":"git://github.com/WikiWatershed/model-my-watershed.git","ssh_url":"[email protected]:WikiWatershed/model-my-watershed.git","clone_url":"https://github.com/WikiWatershed/model-my-watershed.git","svn_url":"https://github.com/WikiWatershed/model-my-watershed","homepage":"https://app.wikiwatershed.org","size":18828,"stargazers_count":9,"watchers_count":9,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":186,"forks":15,"open_issues":186,"watchers":9,"default_branch":"develop"}},"base":{"label":"WikiWatershed:develop","ref":"develop","sha":"f2731ffdfd41081ebcceb739536d49f75e83f616","user":{"login":"WikiWatershed","id":8520008,"avatar_url":"https://avatars2.githubusercontent.com/u/8520008?v=3","gravatar_id":"","url":"https://api.github.com/users/WikiWatershed","html_url":"https://github.com/WikiWatershed","followers_url":"https://api.github.com/users/WikiWatershed/followers","following_url":"https://api.github.com/users/WikiWatershed/following{/other_user}","gists_url":"https://api.github.com/users/WikiWatershed/gists{/gist_id}","starred_url":"https://api.github.com/users/WikiWatershed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WikiWatershed/subscriptions","organizations_url":"https://api.github.com/users/WikiWatershed/orgs","repos_url":"https://api.github.com/users/WikiWatershed/repos","events_url":"https://api.github.com/users/WikiWatershed/events{/privacy}","received_events_url":"https://api.github.com/users/WikiWatershed/received_events","type":"Organization","site_admin":false},"repo":{"id":32742922,"name":"model-my-watershed","full_name":"WikiWatershed/model-my-watershed","owner":{"login":"WikiWatershed","id":8520008,"avatar_url":"https://avatars2.githubusercontent.com/u/8520008?v=3","gravatar_id":"","url":"https://api.github.com/users/WikiWatershed","html_url":"https://github.com/WikiWatershed","followers_url":"https://api.github.com/users/WikiWatershed/followers","following_url":"https://api.github.com/users/WikiWatershed/following{/other_user}","gists_url":"https://api.github.com/users/WikiWatershed/gists{/gist_id}","starred_url":"https://api.github.com/users/WikiWatershed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WikiWatershed/subscriptions","organizations_url":"https://api.github.com/users/WikiWatershed/orgs","repos_url":"https://api.github.com/users/WikiWatershed/repos","events_url":"https://api.github.com/users/WikiWatershed/events{/privacy}","received_events_url":"https://api.github.com/users/WikiWatershed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WikiWatershed/model-my-watershed","description":"The web application front end for Model My Watershed.","fork":false,"url":"https://api.github.com/repos/WikiWatershed/model-my-watershed","forks_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/forks","keys_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/teams","hooks_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/hooks","issue_events_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/events{/number}","events_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/events","assignees_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/assignees{/user}","branches_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/branches{/branch}","tags_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/tags","blobs_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/refs{/sha}","trees_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/statuses/{sha}","languages_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/languages","stargazers_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/stargazers","contributors_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/contributors","subscribers_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/subscribers","subscription_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/subscription","commits_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/commits{/sha}","git_commits_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/git/commits{/sha}","comments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/comments{/number}","issue_comment_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/comments{/number}","contents_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/contents/{+path}","compare_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/merges","archive_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/downloads","issues_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues{/number}","pulls_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls{/number}","milestones_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/milestones{/number}","notifications_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/labels{/name}","releases_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/releases{/id}","deployments_url":"https://api.github.com/repos/WikiWatershed/model-my-watershed/deployments","created_at":"2015-03-23T16:02:55Z","updated_at":"2017-03-08T08:55:38Z","pushed_at":"2017-03-30T21:11:24Z","git_url":"git://github.com/WikiWatershed/model-my-watershed.git","ssh_url":"[email protected]:WikiWatershed/model-my-watershed.git","clone_url":"https://github.com/WikiWatershed/model-my-watershed.git","svn_url":"https://github.com/WikiWatershed/model-my-watershed","homepage":"https://app.wikiwatershed.org","size":18828,"stargazers_count":9,"watchers_count":9,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":186,"forks":15,"open_issues":186,"watchers":9,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1778"},"html":{"href":"https://github.com/WikiWatershed/model-my-watershed/pull/1778"},"issue":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1778"},"comments":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/issues/1778/comments"},"review_comments":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1778/comments"},"review_comment":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/pulls/1778/commits"},"statuses":{"href":"https://api.github.com/repos/WikiWatershed/model-my-watershed/statuses/e6a171379865cfa41d373851f7f11f7aa7d06ca3"}}}}
|
{
"id": 32742922,
"name": "WikiWatershed/model-my-watershed",
"url": "https://api.github.com/repos/WikiWatershed/model-my-watershed"
}
|
{
"id": 4165523,
"login": "kellyi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4165523?",
"url": "https://api.github.com/users/kellyi"
}
|
{
"id": 8520008,
"login": "WikiWatershed",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8520008?",
"url": "https://api.github.com/orgs/WikiWatershed"
}
| 2017-03-31T13:48:49 |
5603231803
|
{"actor":{"display_login":"kellyi"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apollographql/apollo-link/pulls/comments/128443795","pull_request_review_id":51121728,"id":128443795,"diff_hunk":"@@ -26,8 +20,16 @@ execute(link, operation).subscribe({\n error: error => console.log(`received error ${error}`),\n complete: () => console.log(`complete`),\n })\n+\n+//For single execution operations, a Promise can be used\n+new Promise((resolve, reject) => (execute(link, operation)).subscribe(resolve, reject))","path":"docs/summary.md","position":null,"original_position":19,"commit_id":"29cab562489f4067459a40398ae0e8e832d0742e","original_commit_id":"29cab562489f4067459a40398ae0e8e832d0742e","user":{"login":"stubailo","id":448783,"avatar_url":"https://avatars3.githubusercontent.com/u/448783?v=4","gravatar_id":"","url":"https://api.github.com/users/stubailo","html_url":"https://github.com/stubailo","followers_url":"https://api.github.com/users/stubailo/followers","following_url":"https://api.github.com/users/stubailo/following{/other_user}","gists_url":"https://api.github.com/users/stubailo/gists{/gist_id}","starred_url":"https://api.github.com/users/stubailo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stubailo/subscriptions","organizations_url":"https://api.github.com/users/stubailo/orgs","repos_url":"https://api.github.com/users/stubailo/repos","events_url":"https://api.github.com/users/stubailo/events{/privacy}","received_events_url":"https://api.github.com/users/stubailo/received_events","type":"User","site_admin":false},"body":"Hmm, is there no way to get a promise in a first-class way?","created_at":"2017-07-20T07:35:28Z","updated_at":"2017-07-20T07:36:28Z","html_url":"https://github.com/apollographql/apollo-link/pull/6#discussion_r128443795","pull_request_url":"https://api.github.com/repos/apollographql/apollo-link/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/apollographql/apollo-link/pulls/comments/128443795"},"html":{"href":"https://github.com/apollographql/apollo-link/pull/6#discussion_r128443795"},"pull_request":{"href":"https://api.github.com/repos/apollographql/apollo-link/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/apollographql/apollo-link/pulls/6","id":125922675,"html_url":"https://github.com/apollographql/apollo-link/pull/6","diff_url":"https://github.com/apollographql/apollo-link/pull/6.diff","patch_url":"https://github.com/apollographql/apollo-link/pull/6.patch","issue_url":"https://api.github.com/repos/apollographql/apollo-link/issues/6","number":6,"state":"open","locked":false,"title":"Initial Apollo Link Specification","user":{"login":"evanshauser","id":5565407,"avatar_url":"https://avatars0.githubusercontent.com/u/5565407?v=4","gravatar_id":"","url":"https://api.github.com/users/evanshauser","html_url":"https://github.com/evanshauser","followers_url":"https://api.github.com/users/evanshauser/followers","following_url":"https://api.github.com/users/evanshauser/following{/other_user}","gists_url":"https://api.github.com/users/evanshauser/gists{/gist_id}","starred_url":"https://api.github.com/users/evanshauser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanshauser/subscriptions","organizations_url":"https://api.github.com/users/evanshauser/orgs","repos_url":"https://api.github.com/users/evanshauser/repos","events_url":"https://api.github.com/users/evanshauser/events{/privacy}","received_events_url":"https://api.github.com/users/evanshauser/received_events","type":"User","site_admin":false},"body":"This is the draft specification of the Apollo Link architecture as a standard interface for fetching GraphQL operations. The interface is designed for the current Apollo Client network interface and to provide a simple GraphQL client. Please add your feedback and suggestions on this Pull Request.","created_at":"2017-06-15T22:08:39Z","updated_at":"2017-07-20T07:36:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91dea92c6af1700669983f8ea44edb31cba1d30b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apollographql/apollo-link/pulls/6/commits","review_comments_url":"https://api.github.com/repos/apollographql/apollo-link/pulls/6/comments","review_comment_url":"https://api.github.com/repos/apollographql/apollo-link/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apollographql/apollo-link/issues/6/comments","statuses_url":"https://api.github.com/repos/apollographql/apollo-link/statuses/29cab562489f4067459a40398ae0e8e832d0742e","head":{"label":"apollographql:specification","ref":"specification","sha":"29cab562489f4067459a40398ae0e8e832d0742e","user":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"repo":{"id":93657402,"name":"apollo-link","full_name":"apollographql/apollo-link","owner":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollographql/apollo-link","description":null,"fork":false,"url":"https://api.github.com/repos/apollographql/apollo-link","forks_url":"https://api.github.com/repos/apollographql/apollo-link/forks","keys_url":"https://api.github.com/repos/apollographql/apollo-link/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollographql/apollo-link/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollographql/apollo-link/teams","hooks_url":"https://api.github.com/repos/apollographql/apollo-link/hooks","issue_events_url":"https://api.github.com/repos/apollographql/apollo-link/issues/events{/number}","events_url":"https://api.github.com/repos/apollographql/apollo-link/events","assignees_url":"https://api.github.com/repos/apollographql/apollo-link/assignees{/user}","branches_url":"https://api.github.com/repos/apollographql/apollo-link/branches{/branch}","tags_url":"https://api.github.com/repos/apollographql/apollo-link/tags","blobs_url":"https://api.github.com/repos/apollographql/apollo-link/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollographql/apollo-link/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollographql/apollo-link/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollographql/apollo-link/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollographql/apollo-link/statuses/{sha}","languages_url":"https://api.github.com/repos/apollographql/apollo-link/languages","stargazers_url":"https://api.github.com/repos/apollographql/apollo-link/stargazers","contributors_url":"https://api.github.com/repos/apollographql/apollo-link/contributors","subscribers_url":"https://api.github.com/repos/apollographql/apollo-link/subscribers","subscription_url":"https://api.github.com/repos/apollographql/apollo-link/subscription","commits_url":"https://api.github.com/repos/apollographql/apollo-link/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollographql/apollo-link/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollographql/apollo-link/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollographql/apollo-link/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollographql/apollo-link/contents/{+path}","compare_url":"https://api.github.com/repos/apollographql/apollo-link/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollographql/apollo-link/merges","archive_url":"https://api.github.com/repos/apollographql/apollo-link/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollographql/apollo-link/downloads","issues_url":"https://api.github.com/repos/apollographql/apollo-link/issues{/number}","pulls_url":"https://api.github.com/repos/apollographql/apollo-link/pulls{/number}","milestones_url":"https://api.github.com/repos/apollographql/apollo-link/milestones{/number}","notifications_url":"https://api.github.com/repos/apollographql/apollo-link/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollographql/apollo-link/labels{/name}","releases_url":"https://api.github.com/repos/apollographql/apollo-link/releases{/id}","deployments_url":"https://api.github.com/repos/apollographql/apollo-link/deployments","created_at":"2017-06-07T16:39:32Z","updated_at":"2017-07-19T23:19:13Z","pushed_at":"2017-07-20T07:07:04Z","git_url":"git://github.com/apollographql/apollo-link.git","ssh_url":"[email protected]:apollographql/apollo-link.git","clone_url":"https://github.com/apollographql/apollo-link.git","svn_url":"https://github.com/apollographql/apollo-link","homepage":null,"size":500,"stargazers_count":23,"watchers_count":23,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":23,"default_branch":"master"}},"base":{"label":"apollographql:master","ref":"master","sha":"2cd697adff6bea722472face425b293885326cf4","user":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"repo":{"id":93657402,"name":"apollo-link","full_name":"apollographql/apollo-link","owner":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollographql/apollo-link","description":null,"fork":false,"url":"https://api.github.com/repos/apollographql/apollo-link","forks_url":"https://api.github.com/repos/apollographql/apollo-link/forks","keys_url":"https://api.github.com/repos/apollographql/apollo-link/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollographql/apollo-link/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollographql/apollo-link/teams","hooks_url":"https://api.github.com/repos/apollographql/apollo-link/hooks","issue_events_url":"https://api.github.com/repos/apollographql/apollo-link/issues/events{/number}","events_url":"https://api.github.com/repos/apollographql/apollo-link/events","assignees_url":"https://api.github.com/repos/apollographql/apollo-link/assignees{/user}","branches_url":"https://api.github.com/repos/apollographql/apollo-link/branches{/branch}","tags_url":"https://api.github.com/repos/apollographql/apollo-link/tags","blobs_url":"https://api.github.com/repos/apollographql/apollo-link/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollographql/apollo-link/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollographql/apollo-link/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollographql/apollo-link/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollographql/apollo-link/statuses/{sha}","languages_url":"https://api.github.com/repos/apollographql/apollo-link/languages","stargazers_url":"https://api.github.com/repos/apollographql/apollo-link/stargazers","contributors_url":"https://api.github.com/repos/apollographql/apollo-link/contributors","subscribers_url":"https://api.github.com/repos/apollographql/apollo-link/subscribers","subscription_url":"https://api.github.com/repos/apollographql/apollo-link/subscription","commits_url":"https://api.github.com/repos/apollographql/apollo-link/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollographql/apollo-link/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollographql/apollo-link/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollographql/apollo-link/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollographql/apollo-link/contents/{+path}","compare_url":"https://api.github.com/repos/apollographql/apollo-link/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollographql/apollo-link/merges","archive_url":"https://api.github.com/repos/apollographql/apollo-link/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollographql/apollo-link/downloads","issues_url":"https://api.github.com/repos/apollographql/apollo-link/issues{/number}","pulls_url":"https://api.github.com/repos/apollographql/apollo-link/pulls{/number}","milestones_url":"https://api.github.com/repos/apollographql/apollo-link/milestones{/number}","notifications_url":"https://api.github.com/repos/apollographql/apollo-link/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollographql/apollo-link/labels{/name}","releases_url":"https://api.github.com/repos/apollographql/apollo-link/releases{/id}","deployments_url":"https://api.github.com/repos/apollographql/apollo-link/deployments","created_at":"2017-06-07T16:39:32Z","updated_at":"2017-07-19T23:19:13Z","pushed_at":"2017-07-20T07:07:04Z","git_url":"git://github.com/apollographql/apollo-link.git","ssh_url":"[email protected]:apollographql/apollo-link.git","clone_url":"https://github.com/apollographql/apollo-link.git","svn_url":"https://github.com/apollographql/apollo-link","homepage":null,"size":500,"stargazers_count":23,"watchers_count":23,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apollographql/apollo-link/pulls/6"},"html":{"href":"https://github.com/apollographql/apollo-link/pull/6"},"issue":{"href":"https://api.github.com/repos/apollographql/apollo-link/issues/6"},"comments":{"href":"https://api.github.com/repos/apollographql/apollo-link/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/apollographql/apollo-link/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/apollographql/apollo-link/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apollographql/apollo-link/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/apollographql/apollo-link/statuses/29cab562489f4067459a40398ae0e8e832d0742e"}}}}
|
{
"id": 93657402,
"name": "apollographql/apollo-link",
"url": "https://api.github.com/repos/apollographql/apollo-link"
}
|
{
"id": 448783,
"login": "stubailo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/448783?",
"url": "https://api.github.com/users/stubailo"
}
|
{
"id": 17189275,
"login": "apollographql",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17189275?",
"url": "https://api.github.com/orgs/apollographql"
}
| 2017-07-20T07:35:28 |
6292960697
|
{"actor":{"display_login":"stubailo"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apollographql/apollo-android/pulls/comments/105570895","pull_request_review_id":26457192,"id":105570895,"diff_hunk":"@@ -0,0 +1,81 @@\n+package com.apollographql.android.impl;\n+\n+import com.apollographql.android.ApolloCall;\n+import com.apollographql.android.ApolloWatcher;\n+import com.apollographql.android.api.graphql.Operation;\n+import com.apollographql.android.api.graphql.Response;\n+import com.apollographql.android.cache.normalized.Cache;\n+import com.apollographql.android.cache.normalized.CacheControl;\n+import com.apollographql.android.impl.util.Utils;\n+\n+import javax.annotation.Nonnull;\n+import javax.annotation.Nullable;\n+\n+final class RealApolloWatcher<T extends Operation.Data> implements ApolloWatcher<T> {\n+\n+ private RealApolloCall<T> activeCall;\n+ @Nullable private ApolloCall.Callback<T> callback = null;\n+ private CacheControl refetchCacheControl = CacheControl.CACHE_FIRST;\n+ private volatile boolean isActive = true;\n+ private boolean executed = false;\n+ private final Cache cache;\n+ private final Cache.RecordChangeSubscriber recordChangeSubscriber = new Cache.RecordChangeSubscriber() {\n+ @Override public void onDependentKeysChanged() {\n+ refetch();\n+ }\n+ };\n+\n+ RealApolloWatcher(RealApolloCall<T> originalCall, Cache cache) {\n+ activeCall = originalCall;\n+ this.cache = cache;\n+ }\n+\n+ public void enqueueAndWatch(@Nullable final ApolloCall.Callback<T> callback) {","path":"apollo-runtime/src/main/java/com/apollographql/android/impl/RealApolloWatcher.java","position":33,"original_position":33,"commit_id":"9ea49658baa719f23de1a50511486f94623823d3","original_commit_id":"9ea49658baa719f23de1a50511486f94623823d3","user":{"login":"sav007","id":902816,"avatar_url":"https://avatars1.githubusercontent.com/u/902816?v=3","gravatar_id":"","url":"https://api.github.com/users/sav007","html_url":"https://github.com/sav007","followers_url":"https://api.github.com/users/sav007/followers","following_url":"https://api.github.com/users/sav007/following{/other_user}","gists_url":"https://api.github.com/users/sav007/gists{/gist_id}","starred_url":"https://api.github.com/users/sav007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sav007/subscriptions","organizations_url":"https://api.github.com/users/sav007/orgs","repos_url":"https://api.github.com/users/sav007/repos","events_url":"https://api.github.com/users/sav007/events{/privacy}","received_events_url":"https://api.github.com/users/sav007/received_events","type":"User","site_admin":false},"body":"nit: @Override","created_at":"2017-03-12T22:22:55Z","updated_at":"2017-03-12T22:22:56Z","html_url":"https://github.com/apollographql/apollo-android/pull/312#discussion_r105570895","pull_request_url":"https://api.github.com/repos/apollographql/apollo-android/pulls/312","_links":{"self":{"href":"https://api.github.com/repos/apollographql/apollo-android/pulls/comments/105570895"},"html":{"href":"https://github.com/apollographql/apollo-android/pull/312#discussion_r105570895"},"pull_request":{"href":"https://api.github.com/repos/apollographql/apollo-android/pulls/312"}}},"pull_request":{"url":"https://api.github.com/repos/apollographql/apollo-android/pulls/312","id":110058755,"html_url":"https://github.com/apollographql/apollo-android/pull/312","diff_url":"https://github.com/apollographql/apollo-android/pull/312.diff","patch_url":"https://github.com/apollographql/apollo-android/pull/312.patch","issue_url":"https://api.github.com/repos/apollographql/apollo-android/issues/312","number":312,"state":"open","locked":false,"title":"Add Query Watching","user":{"login":"BenSchwab","id":1754153,"avatar_url":"https://avatars3.githubusercontent.com/u/1754153?v=3","gravatar_id":"","url":"https://api.github.com/users/BenSchwab","html_url":"https://github.com/BenSchwab","followers_url":"https://api.github.com/users/BenSchwab/followers","following_url":"https://api.github.com/users/BenSchwab/following{/other_user}","gists_url":"https://api.github.com/users/BenSchwab/gists{/gist_id}","starred_url":"https://api.github.com/users/BenSchwab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenSchwab/subscriptions","organizations_url":"https://api.github.com/users/BenSchwab/orgs","repos_url":"https://api.github.com/users/BenSchwab/repos","events_url":"https://api.github.com/users/BenSchwab/events{/privacy}","received_events_url":"https://api.github.com/users/BenSchwab/received_events","type":"User","site_admin":false},"body":"closes https://github.com/apollographql/apollo-android/issues/304\r\n\r\nThis is a WIP query watching PR. There will be many more tests, naming will be reconsidered, TODOs fixed etc...\r\n\r\nBut wanted to get early thoughts on general design.\r\n\r\n I played around with couple ways, but settled on have an the flow `ApolloCall.toWatcher()` -> `ApolloWatcher`\r\n\r\nThe reason is that in order to watch a query you need to execute the query at least once to generate the `dependentKeys`. So a user would first need to configure the \"root query\" with whatever cache control they want, and then transform it into a watcher.\r\n\r\nThen they call `enqueueAndWatch` which performs the initial fetch. Upon successful fetch, the watcher then subscribes to change keys events on the cache.\r\n\r\nImportantly, `refetch` cachePolicy is separate than the initial fetch policy.\r\n\r\nOne thing to take a look at: whenever a query is refetched, we actually unsubscribe from cache changed keys event, until the query is returned with new `dependentKeys`. This is because when there is an outgoing request, the current dependentKeys are \"stale\". When we move to more sophisticated threading model this will be important.\r\n","created_at":"2017-03-10T04:20:00Z","updated_at":"2017-03-12T22:22:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc0a3159fe3a26e5fabf6a89afdddee0c2bcc3d8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apollographql/apollo-android/pulls/312/commits","review_comments_url":"https://api.github.com/repos/apollographql/apollo-android/pulls/312/comments","review_comment_url":"https://api.github.com/repos/apollographql/apollo-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apollographql/apollo-android/issues/312/comments","statuses_url":"https://api.github.com/repos/apollographql/apollo-android/statuses/9ea49658baa719f23de1a50511486f94623823d3","head":{"label":"apollographql:bschwab/query-watch","ref":"bschwab/query-watch","sha":"9ea49658baa719f23de1a50511486f94623823d3","user":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars3.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"repo":{"id":69469299,"name":"apollo-android","full_name":"apollographql/apollo-android","owner":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars3.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollographql/apollo-android","description":":pager: A GraphQL client for Android (WIP)","fork":false,"url":"https://api.github.com/repos/apollographql/apollo-android","forks_url":"https://api.github.com/repos/apollographql/apollo-android/forks","keys_url":"https://api.github.com/repos/apollographql/apollo-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollographql/apollo-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollographql/apollo-android/teams","hooks_url":"https://api.github.com/repos/apollographql/apollo-android/hooks","issue_events_url":"https://api.github.com/repos/apollographql/apollo-android/issues/events{/number}","events_url":"https://api.github.com/repos/apollographql/apollo-android/events","assignees_url":"https://api.github.com/repos/apollographql/apollo-android/assignees{/user}","branches_url":"https://api.github.com/repos/apollographql/apollo-android/branches{/branch}","tags_url":"https://api.github.com/repos/apollographql/apollo-android/tags","blobs_url":"https://api.github.com/repos/apollographql/apollo-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollographql/apollo-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollographql/apollo-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollographql/apollo-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollographql/apollo-android/statuses/{sha}","languages_url":"https://api.github.com/repos/apollographql/apollo-android/languages","stargazers_url":"https://api.github.com/repos/apollographql/apollo-android/stargazers","contributors_url":"https://api.github.com/repos/apollographql/apollo-android/contributors","subscribers_url":"https://api.github.com/repos/apollographql/apollo-android/subscribers","subscription_url":"https://api.github.com/repos/apollographql/apollo-android/subscription","commits_url":"https://api.github.com/repos/apollographql/apollo-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollographql/apollo-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollographql/apollo-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollographql/apollo-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollographql/apollo-android/contents/{+path}","compare_url":"https://api.github.com/repos/apollographql/apollo-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollographql/apollo-android/merges","archive_url":"https://api.github.com/repos/apollographql/apollo-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollographql/apollo-android/downloads","issues_url":"https://api.github.com/repos/apollographql/apollo-android/issues{/number}","pulls_url":"https://api.github.com/repos/apollographql/apollo-android/pulls{/number}","milestones_url":"https://api.github.com/repos/apollographql/apollo-android/milestones{/number}","notifications_url":"https://api.github.com/repos/apollographql/apollo-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollographql/apollo-android/labels{/name}","releases_url":"https://api.github.com/repos/apollographql/apollo-android/releases{/id}","deployments_url":"https://api.github.com/repos/apollographql/apollo-android/deployments","created_at":"2016-09-28T14:03:30Z","updated_at":"2017-03-12T15:29:25Z","pushed_at":"2017-03-12T19:09:22Z","git_url":"git://github.com/apollographql/apollo-android.git","ssh_url":"[email protected]:apollographql/apollo-android.git","clone_url":"https://github.com/apollographql/apollo-android.git","svn_url":"https://github.com/apollographql/apollo-android","homepage":"","size":135542,"stargazers_count":162,"watchers_count":162,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":39,"forks":17,"open_issues":39,"watchers":162,"default_branch":"master"}},"base":{"label":"apollographql:master","ref":"master","sha":"51bac3087e83055ba5a9b17a430c7c430830bbcb","user":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars3.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"repo":{"id":69469299,"name":"apollo-android","full_name":"apollographql/apollo-android","owner":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars3.githubusercontent.com/u/17189275?v=3","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollographql/apollo-android","description":":pager: A GraphQL client for Android (WIP)","fork":false,"url":"https://api.github.com/repos/apollographql/apollo-android","forks_url":"https://api.github.com/repos/apollographql/apollo-android/forks","keys_url":"https://api.github.com/repos/apollographql/apollo-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollographql/apollo-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollographql/apollo-android/teams","hooks_url":"https://api.github.com/repos/apollographql/apollo-android/hooks","issue_events_url":"https://api.github.com/repos/apollographql/apollo-android/issues/events{/number}","events_url":"https://api.github.com/repos/apollographql/apollo-android/events","assignees_url":"https://api.github.com/repos/apollographql/apollo-android/assignees{/user}","branches_url":"https://api.github.com/repos/apollographql/apollo-android/branches{/branch}","tags_url":"https://api.github.com/repos/apollographql/apollo-android/tags","blobs_url":"https://api.github.com/repos/apollographql/apollo-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollographql/apollo-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollographql/apollo-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollographql/apollo-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollographql/apollo-android/statuses/{sha}","languages_url":"https://api.github.com/repos/apollographql/apollo-android/languages","stargazers_url":"https://api.github.com/repos/apollographql/apollo-android/stargazers","contributors_url":"https://api.github.com/repos/apollographql/apollo-android/contributors","subscribers_url":"https://api.github.com/repos/apollographql/apollo-android/subscribers","subscription_url":"https://api.github.com/repos/apollographql/apollo-android/subscription","commits_url":"https://api.github.com/repos/apollographql/apollo-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollographql/apollo-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollographql/apollo-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollographql/apollo-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollographql/apollo-android/contents/{+path}","compare_url":"https://api.github.com/repos/apollographql/apollo-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollographql/apollo-android/merges","archive_url":"https://api.github.com/repos/apollographql/apollo-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollographql/apollo-android/downloads","issues_url":"https://api.github.com/repos/apollographql/apollo-android/issues{/number}","pulls_url":"https://api.github.com/repos/apollographql/apollo-android/pulls{/number}","milestones_url":"https://api.github.com/repos/apollographql/apollo-android/milestones{/number}","notifications_url":"https://api.github.com/repos/apollographql/apollo-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollographql/apollo-android/labels{/name}","releases_url":"https://api.github.com/repos/apollographql/apollo-android/releases{/id}","deployments_url":"https://api.github.com/repos/apollographql/apollo-android/deployments","created_at":"2016-09-28T14:03:30Z","updated_at":"2017-03-12T15:29:25Z","pushed_at":"2017-03-12T19:09:22Z","git_url":"git://github.com/apollographql/apollo-android.git","ssh_url":"[email protected]:apollographql/apollo-android.git","clone_url":"https://github.com/apollographql/apollo-android.git","svn_url":"https://github.com/apollographql/apollo-android","homepage":"","size":135542,"stargazers_count":162,"watchers_count":162,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":39,"forks":17,"open_issues":39,"watchers":162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apollographql/apollo-android/pulls/312"},"html":{"href":"https://github.com/apollographql/apollo-android/pull/312"},"issue":{"href":"https://api.github.com/repos/apollographql/apollo-android/issues/312"},"comments":{"href":"https://api.github.com/repos/apollographql/apollo-android/issues/312/comments"},"review_comments":{"href":"https://api.github.com/repos/apollographql/apollo-android/pulls/312/comments"},"review_comment":{"href":"https://api.github.com/repos/apollographql/apollo-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apollographql/apollo-android/pulls/312/commits"},"statuses":{"href":"https://api.github.com/repos/apollographql/apollo-android/statuses/9ea49658baa719f23de1a50511486f94623823d3"}}}}
|
{
"id": 69469299,
"name": "apollographql/apollo-android",
"url": "https://api.github.com/repos/apollographql/apollo-android"
}
|
{
"id": 902816,
"login": "sav007",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/902816?",
"url": "https://api.github.com/users/sav007"
}
|
{
"id": 17189275,
"login": "apollographql",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17189275?",
"url": "https://api.github.com/orgs/apollographql"
}
| 2017-03-12T22:22:55 |
5478963842
|
{"actor":{"display_login":"sav007"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/pulls/comments/109482899","pull_request_review_id":30578144,"id":109482899,"diff_hunk":"@@ -0,0 +1,473 @@\n+#include <cstdint>\n+#include <cstdlib>\n+#include <cstdio>\n+#include <thread>\n+#include <algorithm>\n+\n+#include <unistd.h>\n+#include <fcntl.h>\n+#include <sys/socket.h>\n+#include <sys/epoll.h>\n+\n+#include \"server.h\"\n+#include \"servergamestate.h\"\n+#include \"serverwrappers.h\"\n+\n+/**\n+ * Server side static player id generator.\n+ * This id is sent by the server to each new client.\n+ * This counter is created to prevent conflicting ids for clients.\n+ * John Agapeyev March 19\n+ */\n+int32_t getPlayerId() {\n+ static std::atomic<int32_t> counter{-1};\n+ return ++counter;\n+}\n+\n+/**\n+ * Binds a socket to a given ip and port.\n+ * The ip and port are in network byte order.\n+ * It then returns a servaddr struct containing the address the socket was bound to.\n+ * John Agapeyev March 19\n+ */\n+sockaddr_in bindSocket(const int sock, const unsigned long ip, const unsigned short port) {\n+ struct sockaddr_in servaddrudp;\n+ memset(&servaddrudp, 0, sizeof(servaddrudp));\n+ servaddrudp.sin_family = AF_INET;\n+ servaddrudp.sin_addr.s_addr = htonl(ip);\n+ servaddrudp.sin_port = htons(port);\n+\n+ if ((bind(sock, (struct sockaddr *) &servaddrudp, sizeof(servaddrudp))) == -1) {\n+ perror(\"Bind\");\n+ exit(1);\n+ }\n+ return servaddrudp;\n+}\n+\n+/**\n+ * Creates a socket, choosing a TCP or UDP socket, and optionally making it non-blocking.\n+ * John Agapeyev March 19\n+ */\n+int createSocket(const bool useUDP, const bool nonblocking) {\n+ int sock = socket(AF_INET, ((useUDP) ? SOCK_DGRAM : SOCK_STREAM) | (nonblocking * SOCK_NONBLOCK), 0);\n+ if (sock == -1) {\n+ perror(\"Create socket\");\n+ exit(1);\n+ }\n+ int enable = 1;\n+ if (setsockopt(sock, SOL_SOCKET, SO_REUSEADDR, &enable, sizeof(int)) < 0) {\n+ perror(\"setsockopt(SO_REUSEADDR) failed\");\n+ exit(1);\n+ }\n+ return sock;\n+}\n+\n+void fillMulticastAddr(sockaddr_in& addr) {\n+ memset(&addr, 0, sizeof(addr));\n+\n+ if (inet_pton(AF_INET, MULTICAST_ADDR, &(addr.sin_addr)) != 1) {\n+ perror(\"inet_pton\");\n+ exit(3);\n+ }\n+\n+ addr.sin_family = AF_INET;\n+ addr.sin_port = htons(LISTEN_PORT_UDP);\n+}\n+\n+/**\n+ * Method called when the game should start.\n+ * This is called when either a /start command is received over TCP, or all players are ready to play.\n+ * It launches the game logic loop in a throwaway thread.\n+ * When the intial game has loaded, it will disable the spinlock in this method, allowing the\n+ * server to start reading and processing UDP packets.\n+ * This spinlock is done to prevent a situation where a player has \"moved\" before they have been created\n+ * or otherwise defined. This is mostly to prevent any issues, since it should theoretically never happen.\n+ * John Agapeyev March 19\n+ */\n+void transitionToGameStart() {\n+ logv(\"Starting the game\\n\");\n+ std::thread(startGame).detach();\n+ //Spinlock\n+ while (!isGameRunning.load());\n+ listenUDP(listenSocketUDP, INADDR_ANY, listen_port_udp);\n+}\n+\n+/**\n+ * Sends a message to all clients except for the one with the provided id.\n+ * It serializes the id into the buffer and adds the appropriate header bytes before\n+ * sending it off to the clients.\n+ * John Agapeyev March 19\n+ */\n+void sendTCPClientMessage(const int32_t id, const bool isConnectMessage, const char *mesg, const size_t mesgSize) {\n+ char *outBuff;\n+ if ((outBuff = (char *) malloc(mesgSize + TCP_HEADER_SIZE + 1)) == nullptr) {\n+ perror(\"Malloc failure\");\n+ exit(1);\n+ }\n+ memset(outBuff, '\\0', mesgSize + TCP_HEADER_SIZE + 1);\n+ reinterpret_cast<int32_t *>(outBuff)[0] = id;\n+ outBuff[4] = (isConnectMessage) ? 'C' : 'T';\n+ outBuff[5] = '/';\n+\n+ strncpy(outBuff + TCP_HEADER_SIZE + 1, mesg, mesgSize);\n+\n+ for (const auto& clients : clientList) {\n+ if (clients.first != id && clients.second.hasSentUsername) {\n+ rawClientSend(clients.second.entry.sock, outBuff, mesgSize + TCP_HEADER_SIZE + 1);\n+ }\n+ }\n+ free(outBuff);\n+}\n+\n+/*\n+ * Processes a received TCP message according to the following format.\n+ * buff[4] will be either T or C\n+ * T - Text typed by the user, either server commands or text chat\n+ * C - Connection information like lobby contents, people being ready, etc.\n+ * Server ignores messages marked as connection as it is the only one that sends them\n+ * Server sends T & C messages and ignores flag on receive\n+ * Client sends T messages and receives T&C messages\n+ * John Agapeyev March 19\n+ */\n+void processTCPMessage(const int sock, const char *buff, const size_t nbytes) {\n+ //Convert first 4 chars to 32 bit int representing id\n+ const int32_t idReceived = reinterpret_cast<const int32_t *>(buff)[0];\n+\n+ logv(\"Read packet with id: %d\\n\", idReceived);\n+\n+ for (auto& it : clientList) {\n+ if (it.second.entry.sock == sock) {\n+ if (!it.second.hasSentUsername) {\n+ processClientUsername(sock, buff, it);\n+ } else {\n+ if (buff[5] == '/') {\n+ processCommandMessage(idReceived, buff, nbytes);\n+ } else {\n+ //Regular chat message - processing TBD\n+ logv(\"Server received chat message: %s\\n\", buff + 4);\n+ sendTCPClientMessage(idReceived, false, buff + 4, nbytes - 4);\n+ }\n+ }\n+ break;\n+ }\n+ }\n+}\n+\n+/**\n+ * Create the epoll file descriptor for use in the TCP and UDP read loops.\n+ * John Agapeyev March 19\n+ */\n+int createEpollFD() {\n+ int epollfd;\n+ if ((epollfd = epoll_create1(0)) == -1) {\n+ perror(\"Epoll create\");\n+ exit(1);\n+ }\n+ return epollfd;\n+}\n+\n+/**\n+ * Adds a socket to a epoll descriptor.\n+ * The notifications requested are defined in the epoll_event struct that is passed in.\n+ * John Agapeyev March 19\n+ */\n+void addEpollSocket(const int epollfd, const int sock, epoll_event *ev) {\n+ if ((epoll_ctl(epollfd, EPOLL_CTL_ADD, sock, ev)) == -1) {\n+ perror(\"epoll_ctl\");\n+ exit(1);\n+ }\n+}\n+\n+/**\n+ * Sets a given socket to non-blocking.\n+ * This is mainly done for newly connected TCP client sockets as\n+ * the main sockets are created in non-blocking mode already.\n+ * John Agapeyev March 19\n+ */\n+void setSockNonBlock(const int sock) {\n+ if (fcntl(sock, F_SETFL, O_NONBLOCK) == -1) {\n+ perror(\"fcntl\");\n+ close(sock);\n+ exit(1);\n+ }\n+}\n+\n+/**\n+ * Method called when a new TCP client has joined.\n+ * It adds the client to the client list as well as adding it\n+ * to the epoll descriptor for further notifications.\n+ * John Agapeyev March 19\n+ */\n+void handleIncomingTCP(const int epollfd) {\n+ logv(\"Accepting player\\n\");\n+ if (isGameRunning.load()) {\n+ logv(\"Game has already started so a client cannot be added\\n\");\n+ if ((epoll_ctl(epollfd, EPOLL_CTL_DEL, listenSocketTCP, nullptr)) == -1) {\n+ perror(\"epoll_ctl\");\n+ exit(1);\n+ }\n+ close(listenSocketTCP);\n+ return;\n+ }\n+\n+ sockaddr_in addr;\n+ socklen_t addrLen = sizeof(addr);\n+ int clientSock = accept(listenSocketTCP, (sockaddr *) &addr, &addrLen);\n+ if (clientSock == -1) {\n+ if (errno == EAGAIN || errno == EWOULDBLOCK) {\n+ return;\n+ }\n+ perror(\"Accept\");\n+ return;\n+ }\n+\n+ setSockNonBlock(clientSock);\n+\n+ if (getpeername(clientSock, (sockaddr *) &addr, &addrLen) == -1) {\n+ perror(\"GetPeerName\");\n+ close(clientSock);\n+ return;\n+ }\n+\n+ epoll_event clientEv;\n+ memset(&clientEv, 0, sizeof(epoll_event));\n+ clientEv.events = EPOLLIN | EPOLLET | EPOLLEXCLUSIVE;\n+ clientEv.data.fd = clientSock;\n+\n+ PlayerJoin cli{0};\n+ cli.entry.addr = addr;\n+ cli.entry.addr.sin_port = htons(listen_port_udp);\n+ cli.entry.sock = clientSock;\n+ cli.hasSentUsername = false;\n+ cli.isPlayerReady = false;\n+\n+ clientList.insert({getPlayerId(), cli});\n+\n+ logv(\"New client has joined the server\\n\");\n+\n+ addEpollSocket(epollfd, clientSock, &clientEv);\n+}\n+\n+/**\n+ * Method called when a TCP read event has been received.\n+ * It reads from the socket and sends it off for processing.\n+ * This method also performs some error handling for the read.\n+ * John Agapeyev March 19\n+ */\n+void readTCP(const int sock) {\n+ int nbytes;\n+ char buff[IN_PACKET_SIZE];\n+ logv(\"Reading data\\n\");\n+ while ((nbytes = recv(sock, buff, IN_PACKET_SIZE - 1, 0)) > 0) {\n+ //Handle message\n+ if (nbytes < 4) {\n+ logv(\"Packet read was too small\\n\");\n+ continue;\n+ }\n+ buff[nbytes] = '\\0';\n+ processTCPMessage(sock, buff, nbytes);\n+ }\n+ if (nbytes == -1) {\n+ if (errno == EAGAIN || errno == EWOULDBLOCK) {\n+ return;\n+ }\n+ perror(\"Packet read failure\");\n+ } else {\n+ logv(\"Client %d closed connection\\n\", static_cast<int>(sock));\n+ }\n+ close(sock);\n+}\n+\n+/**\n+ * Method called when a UDP read notification was received.\n+ * It reads from the socket and sends it off for processing.\n+ * John Agapeyev March 19\n+ */\n+void readUDP(const int sock, sockaddr *servaddr, socklen_t *servAddrLen) {\n+ int nmesg;\n+ if ((nmesg = recvmmsg(sock, udpMesgs, MAX_UDP_PACKET_COUNT, MSG_DONTWAIT, nullptr)) == -1) {\n+ perror(\"recvmmsg\");\n+ return;\n+ }\n+\n+ logv(\"Received %d messages\\n\", nmesg);\n+\n+#pragma omp parallel for schedule(static) firstprivate(nmesg)\n+ for (int i = 0; i < nmesg; ++i) {\n+ processPacket(readBuffers[i]);\n+ }\n+}\n+\n+/**\n+ * Waits on an epoll descriptor for events to occur.\n+ * It writes the event data to the epoll event buffere that was passed in.\n+ * It then returns the number of events generated.\n+ * John Agapeyev March 19\n+ */\n+int waitForEpollEvent(const int epollfd, epoll_event *events) {\n+ int nevents;\n+ if ((nevents = epoll_wait(epollfd, events, MAXEVENTS, -1)) == -1) {\n+ perror(\"epoll_wait\");\n+ exit(1);\n+ }\n+ return nevents;\n+}\n+\n+/**\n+ * Creates the epoll event buffer for use in the epoll read loops.\n+ * John Agapeyev March 19\n+ */\n+epoll_event *createEpollEventList() {\n+ epoll_event *events;\n+ if (!(events = (epoll_event *) calloc(MAXEVENTS, sizeof(epoll_event)))) {\n+ perror(\"Calloc failure\");\n+ exit(1);\n+ }\n+ return events;\n+}\n+\n+/**\n+ * Processes a received username.\n+ * Due to the nature of TCP, a new client will be conencted, and then send its username seperately.\n+ * This method registers the username and updates its entry in the client list.\n+ * After reading the username, it sends the client back its username with its generated id.\n+ * Once the client has been updated, it then messages all other clients, informing them of a newly connected player.\n+ * John Agapeyev March 19\n+ */\n+void processClientUsername(const int sock, const char *buff, std::pair<const int32_t, PlayerJoin>& client) {\n+ static float yPos = 0;","path":"src/server/serverWrappers.cpp","position":338,"original_position":338,"commit_id":"d9b900db36a776a092a58125a141206b5b4db588","original_commit_id":"49ccbdaad30da5d5dba0dbf6e66eaa3de7385561","user":{"login":"isaacmorneau","id":15988608,"avatar_url":"https://avatars2.githubusercontent.com/u/15988608?v=3","gravatar_id":"","url":"https://api.github.com/users/isaacmorneau","html_url":"https://github.com/isaacmorneau","followers_url":"https://api.github.com/users/isaacmorneau/followers","following_url":"https://api.github.com/users/isaacmorneau/following{/other_user}","gists_url":"https://api.github.com/users/isaacmorneau/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacmorneau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacmorneau/subscriptions","organizations_url":"https://api.github.com/users/isaacmorneau/orgs","repos_url":"https://api.github.com/users/isaacmorneau/repos","events_url":"https://api.github.com/users/isaacmorneau/events{/privacy}","received_events_url":"https://api.github.com/users/isaacmorneau/received_events","type":"User","site_admin":false},"body":"i know why this is static but it should be commented","created_at":"2017-04-03T17:56:15Z","updated_at":"2017-04-03T17:58:42Z","html_url":"https://github.com/bcit-datacomm/4981_Linux_Game/pull/38#discussion_r109482899","pull_request_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/pulls/38","_links":{"self":{"href":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/pulls/comments/109482899"},"html":{"href":"https://github.com/bcit-datacomm/4981_Linux_Game/pull/38#discussion_r109482899"},"pull_request":{"href":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/pulls/38","id":113976211,"html_url":"https://github.com/bcit-datacomm/4981_Linux_Game/pull/38","diff_url":"https://github.com/bcit-datacomm/4981_Linux_Game/pull/38.diff","patch_url":"https://github.com/bcit-datacomm/4981_Linux_Game/pull/38.patch","issue_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/issues/38","number":38,"state":"open","locked":false,"title":"Merge server code into core","user":{"login":"JohnAgapeyev","id":10760994,"avatar_url":"https://avatars0.githubusercontent.com/u/10760994?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnAgapeyev","html_url":"https://github.com/JohnAgapeyev","followers_url":"https://api.github.com/users/JohnAgapeyev/followers","following_url":"https://api.github.com/users/JohnAgapeyev/following{/other_user}","gists_url":"https://api.github.com/users/JohnAgapeyev/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnAgapeyev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnAgapeyev/subscriptions","organizations_url":"https://api.github.com/users/JohnAgapeyev/orgs","repos_url":"https://api.github.com/users/JohnAgapeyev/repos","events_url":"https://api.github.com/users/JohnAgapeyev/events{/privacy}","received_events_url":"https://api.github.com/users/JohnAgapeyev/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-03T16:57:09Z","updated_at":"2017-04-03T17:58:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a12ad8462752c9eb562066952ca3f887521e9a4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/pulls/38/commits","review_comments_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/pulls/38/comments","review_comment_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/issues/38/comments","statuses_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/statuses/d9b900db36a776a092a58125a141206b5b4db588","head":{"label":"JohnAgapeyev:develop","ref":"develop","sha":"d9b900db36a776a092a58125a141206b5b4db588","user":{"login":"JohnAgapeyev","id":10760994,"avatar_url":"https://avatars0.githubusercontent.com/u/10760994?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnAgapeyev","html_url":"https://github.com/JohnAgapeyev","followers_url":"https://api.github.com/users/JohnAgapeyev/followers","following_url":"https://api.github.com/users/JohnAgapeyev/following{/other_user}","gists_url":"https://api.github.com/users/JohnAgapeyev/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnAgapeyev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnAgapeyev/subscriptions","organizations_url":"https://api.github.com/users/JohnAgapeyev/orgs","repos_url":"https://api.github.com/users/JohnAgapeyev/repos","events_url":"https://api.github.com/users/JohnAgapeyev/events{/privacy}","received_events_url":"https://api.github.com/users/JohnAgapeyev/received_events","type":"User","site_admin":false},"repo":{"id":79589651,"name":"4981_Linux_Game","full_name":"JohnAgapeyev/4981_Linux_Game","owner":{"login":"JohnAgapeyev","id":10760994,"avatar_url":"https://avatars0.githubusercontent.com/u/10760994?v=3","gravatar_id":"","url":"https://api.github.com/users/JohnAgapeyev","html_url":"https://github.com/JohnAgapeyev","followers_url":"https://api.github.com/users/JohnAgapeyev/followers","following_url":"https://api.github.com/users/JohnAgapeyev/following{/other_user}","gists_url":"https://api.github.com/users/JohnAgapeyev/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnAgapeyev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnAgapeyev/subscriptions","organizations_url":"https://api.github.com/users/JohnAgapeyev/orgs","repos_url":"https://api.github.com/users/JohnAgapeyev/repos","events_url":"https://api.github.com/users/JohnAgapeyev/events{/privacy}","received_events_url":"https://api.github.com/users/JohnAgapeyev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JohnAgapeyev/4981_Linux_Game","description":null,"fork":true,"url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game","forks_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/forks","keys_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/teams","hooks_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/hooks","issue_events_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/issues/events{/number}","events_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/events","assignees_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/assignees{/user}","branches_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/branches{/branch}","tags_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/tags","blobs_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/git/refs{/sha}","trees_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/statuses/{sha}","languages_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/languages","stargazers_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/stargazers","contributors_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/contributors","subscribers_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/subscribers","subscription_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/subscription","commits_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/commits{/sha}","git_commits_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/git/commits{/sha}","comments_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/comments{/number}","issue_comment_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/issues/comments{/number}","contents_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/contents/{+path}","compare_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/merges","archive_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/downloads","issues_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/issues{/number}","pulls_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/pulls{/number}","milestones_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/milestones{/number}","notifications_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/labels{/name}","releases_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/releases{/id}","deployments_url":"https://api.github.com/repos/JohnAgapeyev/4981_Linux_Game/deployments","created_at":"2017-01-20T19:15:29Z","updated_at":"2017-03-15T04:59:41Z","pushed_at":"2017-04-03T17:30:31Z","git_url":"git://github.com/JohnAgapeyev/4981_Linux_Game.git","ssh_url":"[email protected]:JohnAgapeyev/4981_Linux_Game.git","clone_url":"https://github.com/JohnAgapeyev/4981_Linux_Game.git","svn_url":"https://github.com/JohnAgapeyev/4981_Linux_Game","homepage":null,"size":15517,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"bcit-datacomm:develop","ref":"develop","sha":"5cc88f12a8bebf8640c26b7856e79d96ab67a98f","user":{"login":"bcit-datacomm","id":25111425,"avatar_url":"https://avatars1.githubusercontent.com/u/25111425?v=3","gravatar_id":"","url":"https://api.github.com/users/bcit-datacomm","html_url":"https://github.com/bcit-datacomm","followers_url":"https://api.github.com/users/bcit-datacomm/followers","following_url":"https://api.github.com/users/bcit-datacomm/following{/other_user}","gists_url":"https://api.github.com/users/bcit-datacomm/gists{/gist_id}","starred_url":"https://api.github.com/users/bcit-datacomm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcit-datacomm/subscriptions","organizations_url":"https://api.github.com/users/bcit-datacomm/orgs","repos_url":"https://api.github.com/users/bcit-datacomm/repos","events_url":"https://api.github.com/users/bcit-datacomm/events{/privacy}","received_events_url":"https://api.github.com/users/bcit-datacomm/received_events","type":"Organization","site_admin":false},"repo":{"id":79378386,"name":"4981_Linux_Game","full_name":"bcit-datacomm/4981_Linux_Game","owner":{"login":"bcit-datacomm","id":25111425,"avatar_url":"https://avatars1.githubusercontent.com/u/25111425?v=3","gravatar_id":"","url":"https://api.github.com/users/bcit-datacomm","html_url":"https://github.com/bcit-datacomm","followers_url":"https://api.github.com/users/bcit-datacomm/followers","following_url":"https://api.github.com/users/bcit-datacomm/following{/other_user}","gists_url":"https://api.github.com/users/bcit-datacomm/gists{/gist_id}","starred_url":"https://api.github.com/users/bcit-datacomm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcit-datacomm/subscriptions","organizations_url":"https://api.github.com/users/bcit-datacomm/orgs","repos_url":"https://api.github.com/users/bcit-datacomm/repos","events_url":"https://api.github.com/users/bcit-datacomm/events{/privacy}","received_events_url":"https://api.github.com/users/bcit-datacomm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bcit-datacomm/4981_Linux_Game","description":"Term long CST Game for Data Comm 2017","fork":false,"url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game","forks_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/forks","keys_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/teams","hooks_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/hooks","issue_events_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/issues/events{/number}","events_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/events","assignees_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/assignees{/user}","branches_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/branches{/branch}","tags_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/tags","blobs_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/statuses/{sha}","languages_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/languages","stargazers_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/stargazers","contributors_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/contributors","subscribers_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/subscribers","subscription_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/subscription","commits_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/issues/comments{/number}","contents_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/contents/{+path}","compare_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/merges","archive_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/downloads","issues_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/issues{/number}","pulls_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/pulls{/number}","milestones_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/milestones{/number}","notifications_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/labels{/name}","releases_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/releases{/id}","deployments_url":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/deployments","created_at":"2017-01-18T19:57:33Z","updated_at":"2017-03-22T05:25:12Z","pushed_at":"2017-04-03T17:30:32Z","git_url":"git://github.com/bcit-datacomm/4981_Linux_Game.git","ssh_url":"[email protected]:bcit-datacomm/4981_Linux_Game.git","clone_url":"https://github.com/bcit-datacomm/4981_Linux_Game.git","svn_url":"https://github.com/bcit-datacomm/4981_Linux_Game","homepage":"","size":15225,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":6,"forks":23,"open_issues":6,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/pulls/38"},"html":{"href":"https://github.com/bcit-datacomm/4981_Linux_Game/pull/38"},"issue":{"href":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/issues/38"},"comments":{"href":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/bcit-datacomm/4981_Linux_Game/statuses/d9b900db36a776a092a58125a141206b5b4db588"}}}}
|
{
"id": 79378386,
"name": "bcit-datacomm/4981_Linux_Game",
"url": "https://api.github.com/repos/bcit-datacomm/4981_Linux_Game"
}
|
{
"id": 15988608,
"login": "isaacmorneau",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15988608?",
"url": "https://api.github.com/users/isaacmorneau"
}
|
{
"id": 25111425,
"login": "bcit-datacomm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25111425?",
"url": "https://api.github.com/orgs/bcit-datacomm"
}
| 2017-04-03T17:56:15 |
5616909390
|
{"actor":{"display_login":"isaacmorneau"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/pulls/comments/94595702","pull_request_review_id":15124164,"id":94595702,"diff_hunk":"@@ -310,30 +316,27 @@ export const findSnap = (req, res) => {\n }\n });\n })\n- .catch((error) => responseError(res, error));\n+ .catch((error) => sendError(res, error));\n };\n \n-export const completeSnapAuthorization = async (req, res) => {\n+// Not a route handler, but kept here so that the beginAuthorization and\n+// completeAuthorization calls are close together. Returns a Promise.\n+export const completeSnapAuthorization = (session, repositoryUrl,\n+ dischargeMacaroon) => {\n let snapUrl;\n- checkAdminPermissions(req)\n- .then(() => internalFindSnap(req.body.repository_url))\n+ return checkAdminPermissions(session, repositoryUrl)\n+ .then(() => internalFindSnap(repositoryUrl))\n .then((result) => {\n snapUrl = result;\n return getLaunchpad().named_post(snapUrl, 'completeAuthorization', {\n- parameters: { discharge_macaroon: req.body.discharge_macaroon },\n+ parameters: { discharge_macaroon: dischargeMacaroon },\n });\n })\n- .then(() => {\n- logger.info(`Completed authorization of ${snapUrl}`);\n- return res.status(200).send({\n- status: 'success',\n- payload: {\n- code: 'snap-authorized',\n- message: snapUrl\n- }\n- });\n- })\n- .catch((error) => responseError(res, error));\n+ .then(() => logger.info(`Completed authorization of ${snapUrl}`))\n+ .catch((error) => {\n+ return prepareError(error)","path":"src/server/handlers/launchpad.js","position":123,"original_position":123,"commit_id":"7d5d306a4d9a30acb34600370c622e366815b44e","original_commit_id":"7d5d306a4d9a30acb34600370c622e366815b44e","user":{"login":"cjwatson","id":2429141,"avatar_url":"https://avatars.githubusercontent.com/u/2429141?v=3","gravatar_id":"","url":"https://api.github.com/users/cjwatson","html_url":"https://github.com/cjwatson","followers_url":"https://api.github.com/users/cjwatson/followers","following_url":"https://api.github.com/users/cjwatson/following{/other_user}","gists_url":"https://api.github.com/users/cjwatson/gists{/gist_id}","starred_url":"https://api.github.com/users/cjwatson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjwatson/subscriptions","organizations_url":"https://api.github.com/users/cjwatson/orgs","repos_url":"https://api.github.com/users/cjwatson/repos","events_url":"https://api.github.com/users/cjwatson/events{/privacy}","received_events_url":"https://api.github.com/users/cjwatson/received_events","type":"User","site_admin":false},"body":"Indeed. I imagine we'll come back to this as a target for further refactoring ...","created_at":"2017-01-04T14:51:50Z","updated_at":"2017-01-04T14:51:50Z","html_url":"https://github.com/canonical-ols/build.snapcraft.io/pull/62#discussion_r94595702","pull_request_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/pulls/comments/94595702"},"html":{"href":"https://github.com/canonical-ols/build.snapcraft.io/pull/62#discussion_r94595702"},"pull_request":{"href":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/pulls/62","id":99985827,"html_url":"https://github.com/canonical-ols/build.snapcraft.io/pull/62","diff_url":"https://github.com/canonical-ols/build.snapcraft.io/pull/62.diff","patch_url":"https://github.com/canonical-ols/build.snapcraft.io/pull/62.patch","issue_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/issues/62","number":62,"state":"open","locked":false,"title":"Finish hooking up completeSnapAuthorization","user":{"login":"cjwatson","id":2429141,"avatar_url":"https://avatars.githubusercontent.com/u/2429141?v=3","gravatar_id":"","url":"https://api.github.com/users/cjwatson","html_url":"https://github.com/cjwatson","followers_url":"https://api.github.com/users/cjwatson/followers","following_url":"https://api.github.com/users/cjwatson/following{/other_user}","gists_url":"https://api.github.com/users/cjwatson/gists{/gist_id}","starred_url":"https://api.github.com/users/cjwatson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjwatson/subscriptions","organizations_url":"https://api.github.com/users/cjwatson/orgs","repos_url":"https://api.github.com/users/cjwatson/repos","events_url":"https://api.github.com/users/cjwatson/events{/privacy}","received_events_url":"https://api.github.com/users/cjwatson/received_events","type":"User","site_admin":false},"body":"It appears that I never actually arranged for completeSnapAuthorization\r\nto be called on creating a new snap, so let's fix that. The\r\nauthorization workflow goes through the server-rendered page\r\n/login/verify after returning from SSO, so the simplest way to do things\r\nis just to have that call completeSnapAuthorization directly rather than\r\nvia a route. We need to add the GitHub repository URL to the parameters\r\npassed through the OpenID dance in order for this to work.","created_at":"2017-01-03T16:58:11Z","updated_at":"2017-01-04T14:51:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffb99c4ec1685dae9dd7b5a099fd9c6d1ef02d60","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/pulls/62/commits","review_comments_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/pulls/62/comments","review_comment_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/issues/62/comments","statuses_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/statuses/7d5d306a4d9a30acb34600370c622e366815b44e","head":{"label":"cjwatson:finish-snap-authorization","ref":"finish-snap-authorization","sha":"7d5d306a4d9a30acb34600370c622e366815b44e","user":{"login":"cjwatson","id":2429141,"avatar_url":"https://avatars.githubusercontent.com/u/2429141?v=3","gravatar_id":"","url":"https://api.github.com/users/cjwatson","html_url":"https://github.com/cjwatson","followers_url":"https://api.github.com/users/cjwatson/followers","following_url":"https://api.github.com/users/cjwatson/following{/other_user}","gists_url":"https://api.github.com/users/cjwatson/gists{/gist_id}","starred_url":"https://api.github.com/users/cjwatson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjwatson/subscriptions","organizations_url":"https://api.github.com/users/cjwatson/orgs","repos_url":"https://api.github.com/users/cjwatson/repos","events_url":"https://api.github.com/users/cjwatson/events{/privacy}","received_events_url":"https://api.github.com/users/cjwatson/received_events","type":"User","site_admin":false},"repo":{"id":74580616,"name":"build.snapcraft.io","full_name":"cjwatson/build.snapcraft.io","owner":{"login":"cjwatson","id":2429141,"avatar_url":"https://avatars.githubusercontent.com/u/2429141?v=3","gravatar_id":"","url":"https://api.github.com/users/cjwatson","html_url":"https://github.com/cjwatson","followers_url":"https://api.github.com/users/cjwatson/followers","following_url":"https://api.github.com/users/cjwatson/following{/other_user}","gists_url":"https://api.github.com/users/cjwatson/gists{/gist_id}","starred_url":"https://api.github.com/users/cjwatson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjwatson/subscriptions","organizations_url":"https://api.github.com/users/cjwatson/orgs","repos_url":"https://api.github.com/users/cjwatson/repos","events_url":"https://api.github.com/users/cjwatson/events{/privacy}","received_events_url":"https://api.github.com/users/cjwatson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cjwatson/build.snapcraft.io","description":"The Snapcraft Build site.","fork":true,"url":"https://api.github.com/repos/cjwatson/build.snapcraft.io","forks_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/forks","keys_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/teams","hooks_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/hooks","issue_events_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/issues/events{/number}","events_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/events","assignees_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/assignees{/user}","branches_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/branches{/branch}","tags_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/tags","blobs_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/statuses/{sha}","languages_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/languages","stargazers_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/stargazers","contributors_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/contributors","subscribers_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/subscribers","subscription_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/subscription","commits_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/contents/{+path}","compare_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/merges","archive_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/downloads","issues_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/issues{/number}","pulls_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/pulls{/number}","milestones_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/milestones{/number}","notifications_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/labels{/name}","releases_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/releases{/id}","deployments_url":"https://api.github.com/repos/cjwatson/build.snapcraft.io/deployments","created_at":"2016-11-23T13:44:40Z","updated_at":"2016-11-23T13:44:43Z","pushed_at":"2017-01-04T12:51:17Z","git_url":"git://github.com/cjwatson/build.snapcraft.io.git","ssh_url":"[email protected]:cjwatson/build.snapcraft.io.git","clone_url":"https://github.com/cjwatson/build.snapcraft.io.git","svn_url":"https://github.com/cjwatson/build.snapcraft.io","homepage":"","size":212,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"canonical-ols:master","ref":"master","sha":"7cf8d131533e020fcdabce689e9f2ce638532684","user":{"login":"canonical-ols","id":17836138,"avatar_url":"https://avatars.githubusercontent.com/u/17836138?v=3","gravatar_id":"","url":"https://api.github.com/users/canonical-ols","html_url":"https://github.com/canonical-ols","followers_url":"https://api.github.com/users/canonical-ols/followers","following_url":"https://api.github.com/users/canonical-ols/following{/other_user}","gists_url":"https://api.github.com/users/canonical-ols/gists{/gist_id}","starred_url":"https://api.github.com/users/canonical-ols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canonical-ols/subscriptions","organizations_url":"https://api.github.com/users/canonical-ols/orgs","repos_url":"https://api.github.com/users/canonical-ols/repos","events_url":"https://api.github.com/users/canonical-ols/events{/privacy}","received_events_url":"https://api.github.com/users/canonical-ols/received_events","type":"Organization","site_admin":false},"repo":{"id":74463479,"name":"build.snapcraft.io","full_name":"canonical-ols/build.snapcraft.io","owner":{"login":"canonical-ols","id":17836138,"avatar_url":"https://avatars.githubusercontent.com/u/17836138?v=3","gravatar_id":"","url":"https://api.github.com/users/canonical-ols","html_url":"https://github.com/canonical-ols","followers_url":"https://api.github.com/users/canonical-ols/followers","following_url":"https://api.github.com/users/canonical-ols/following{/other_user}","gists_url":"https://api.github.com/users/canonical-ols/gists{/gist_id}","starred_url":"https://api.github.com/users/canonical-ols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canonical-ols/subscriptions","organizations_url":"https://api.github.com/users/canonical-ols/orgs","repos_url":"https://api.github.com/users/canonical-ols/repos","events_url":"https://api.github.com/users/canonical-ols/events{/privacy}","received_events_url":"https://api.github.com/users/canonical-ols/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/canonical-ols/build.snapcraft.io","description":"The Snapcraft Build site.","fork":false,"url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io","forks_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/forks","keys_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/teams","hooks_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/hooks","issue_events_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/issues/events{/number}","events_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/events","assignees_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/assignees{/user}","branches_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/branches{/branch}","tags_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/tags","blobs_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/statuses/{sha}","languages_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/languages","stargazers_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/stargazers","contributors_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/contributors","subscribers_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/subscribers","subscription_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/subscription","commits_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/contents/{+path}","compare_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/merges","archive_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/downloads","issues_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/issues{/number}","pulls_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/pulls{/number}","milestones_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/milestones{/number}","notifications_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/labels{/name}","releases_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/releases{/id}","deployments_url":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/deployments","created_at":"2016-11-22T10:55:35Z","updated_at":"2016-11-23T09:48:21Z","pushed_at":"2017-01-04T13:59:29Z","git_url":"git://github.com/canonical-ols/build.snapcraft.io.git","ssh_url":"[email protected]:canonical-ols/build.snapcraft.io.git","clone_url":"https://github.com/canonical-ols/build.snapcraft.io.git","svn_url":"https://github.com/canonical-ols/build.snapcraft.io","homepage":"","size":218,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":7,"forks":3,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/pulls/62"},"html":{"href":"https://github.com/canonical-ols/build.snapcraft.io/pull/62"},"issue":{"href":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/issues/62"},"comments":{"href":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/canonical-ols/build.snapcraft.io/statuses/7d5d306a4d9a30acb34600370c622e366815b44e"}}}}
|
{
"id": 74463479,
"name": "canonical-ols/build.snapcraft.io",
"url": "https://api.github.com/repos/canonical-ols/build.snapcraft.io"
}
|
{
"id": 2429141,
"login": "cjwatson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2429141?",
"url": "https://api.github.com/users/cjwatson"
}
|
{
"id": 17836138,
"login": "canonical-ols",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17836138?",
"url": "https://api.github.com/orgs/canonical-ols"
}
| 2017-01-04T14:51:50 |
5101202337
|
{"actor":{"display_login":"cjwatson"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/comments/122060601","pull_request_review_id":44143841,"id":122060601,"diff_hunk":"@@ -0,0 +1,57 @@\n+namespace circonus;\n+\n+table IntValue {\n+ value:int (id: 0);\n+}\n+\n+table UintValue {\n+ value:uint (id: 0);\n+}\n+\n+table LongValue {\n+ value:long (id: 0);\n+}\n+\n+table UlongValue {\n+ value:ulong (id: 0);\n+}\n+\n+table DoubleValue {\n+ value:double (id: 0);\n+}\n+\n+table StringValue {\n+ value:string (id: 0);\n+}\n+\n+// intentionally empty.. Just a Union placeholder\n+table AbsentNumericValue {\n+}\n+\n+// intentionally empty.. Just a Union placeholder\n+table AbsentStringValue {\n+}\n+\n+// intentionally empty.. Just a Union placeholder\n+table AbsentHistogramValue {\n+}\n+\n+table HistogramBucket {\n+ val: byte;\n+ exp: byte;\n+ count: ulong;\n+}\n+\n+table Histogram {\n+ buckets: [HistogramBucket] (id: 0);\n+}\n+\n+union MetricValueUnion { IntValue, UintValue, LongValue, UlongValue, DoubleValue, StringValue, Histogram, AbsentNumericValue, AbsentStringValue, AbsentHistogramValue }\n+\n+table MetricValue {\n+ name: string (id: 0);\n+ timestamp: ulong (id: 1);","path":"src/flatbuffers/metric_common.fbs","position":53,"original_position":53,"commit_id":"e468b76da9e8181ebe6eb2f45bcad9527493a0b3","original_commit_id":"e468b76da9e8181ebe6eb2f45bcad9527493a0b3","user":{"login":"aidancully","id":503301,"avatar_url":"https://avatars2.githubusercontent.com/u/503301?v=3","gravatar_id":"","url":"https://api.github.com/users/aidancully","html_url":"https://github.com/aidancully","followers_url":"https://api.github.com/users/aidancully/followers","following_url":"https://api.github.com/users/aidancully/following{/other_user}","gists_url":"https://api.github.com/users/aidancully/gists{/gist_id}","starred_url":"https://api.github.com/users/aidancully/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidancully/subscriptions","organizations_url":"https://api.github.com/users/aidancully/orgs","repos_url":"https://api.github.com/users/aidancully/repos","events_url":"https://api.github.com/users/aidancully/events{/privacy}","received_events_url":"https://api.github.com/users/aidancully/received_events","type":"User","site_admin":false},"body":"not that familiar with flatbuffers, but it appears that `name` and `timestamp` are repeated in `table MetricValue` (in this file) and `table Metric` (in metric.fbs). I suspect we should delete the fields from `MetricValue`?","created_at":"2017-06-14T20:49:20Z","updated_at":"2017-06-14T20:49:20Z","html_url":"https://github.com/circonus-labs/reconnoiter/pull/371#discussion_r122060601","pull_request_url":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/371","_links":{"self":{"href":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/comments/122060601"},"html":{"href":"https://github.com/circonus-labs/reconnoiter/pull/371#discussion_r122060601"},"pull_request":{"href":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/371"}}},"pull_request":{"url":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/371","id":125434546,"html_url":"https://github.com/circonus-labs/reconnoiter/pull/371","diff_url":"https://github.com/circonus-labs/reconnoiter/pull/371.diff","patch_url":"https://github.com/circonus-labs/reconnoiter/pull/371.patch","issue_url":"https://api.github.com/repos/circonus-labs/reconnoiter/issues/371","number":371,"state":"open","locked":false,"title":"Flatbuffers","user":{"login":"rileyberton","id":2903565,"avatar_url":"https://avatars2.githubusercontent.com/u/2903565?v=3","gravatar_id":"","url":"https://api.github.com/users/rileyberton","html_url":"https://github.com/rileyberton","followers_url":"https://api.github.com/users/rileyberton/followers","following_url":"https://api.github.com/users/rileyberton/following{/other_user}","gists_url":"https://api.github.com/users/rileyberton/gists{/gist_id}","starred_url":"https://api.github.com/users/rileyberton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rileyberton/subscriptions","organizations_url":"https://api.github.com/users/rileyberton/orgs","repos_url":"https://api.github.com/users/rileyberton/repos","events_url":"https://api.github.com/users/rileyberton/events{/privacy}","received_events_url":"https://api.github.com/users/rileyberton/received_events","type":"User","site_admin":false},"body":"This defines flatbuffer format (pay attention to *.fbs files) and provides some serialization functions to create these flatbuffers in the various formats.\r\n\r\nI have also added check serialization into a `BF` record although this code path is currently unused/commented out.\r\n\r\nThe 3 types of flatbuffers are:\r\n\r\nMetric - an individual metric akin to an M record with the added power of also being a histogram\r\nMetricList - a wrapper around unrelated Metric records so we can send unrelated batches from the irondb-relay\r\nMetricBatch - akin to a B2 record.. shared fields live in the parent (timestamp, check_uuid, check_name, account_id) and it contains a list of MetricValues that house the metric_name and the value.","created_at":"2017-06-13T18:47:13Z","updated_at":"2017-06-14T20:49:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32468bde44d4ad4d010ac473503301402c99e8ce","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/371/commits","review_comments_url":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/371/comments","review_comment_url":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/circonus-labs/reconnoiter/issues/371/comments","statuses_url":"https://api.github.com/repos/circonus-labs/reconnoiter/statuses/e468b76da9e8181ebe6eb2f45bcad9527493a0b3","head":{"label":"circonus-labs:flatbuffers","ref":"flatbuffers","sha":"e468b76da9e8181ebe6eb2f45bcad9527493a0b3","user":{"login":"circonus-labs","id":2091329,"avatar_url":"https://avatars3.githubusercontent.com/u/2091329?v=3","gravatar_id":"","url":"https://api.github.com/users/circonus-labs","html_url":"https://github.com/circonus-labs","followers_url":"https://api.github.com/users/circonus-labs/followers","following_url":"https://api.github.com/users/circonus-labs/following{/other_user}","gists_url":"https://api.github.com/users/circonus-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/circonus-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circonus-labs/subscriptions","organizations_url":"https://api.github.com/users/circonus-labs/orgs","repos_url":"https://api.github.com/users/circonus-labs/repos","events_url":"https://api.github.com/users/circonus-labs/events{/privacy}","received_events_url":"https://api.github.com/users/circonus-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":1585344,"name":"reconnoiter","full_name":"circonus-labs/reconnoiter","owner":{"login":"circonus-labs","id":2091329,"avatar_url":"https://avatars3.githubusercontent.com/u/2091329?v=3","gravatar_id":"","url":"https://api.github.com/users/circonus-labs","html_url":"https://github.com/circonus-labs","followers_url":"https://api.github.com/users/circonus-labs/followers","following_url":"https://api.github.com/users/circonus-labs/following{/other_user}","gists_url":"https://api.github.com/users/circonus-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/circonus-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circonus-labs/subscriptions","organizations_url":"https://api.github.com/users/circonus-labs/orgs","repos_url":"https://api.github.com/users/circonus-labs/repos","events_url":"https://api.github.com/users/circonus-labs/events{/privacy}","received_events_url":"https://api.github.com/users/circonus-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/circonus-labs/reconnoiter","description":"Large-scale Monitoring and Trend Analysis System","fork":false,"url":"https://api.github.com/repos/circonus-labs/reconnoiter","forks_url":"https://api.github.com/repos/circonus-labs/reconnoiter/forks","keys_url":"https://api.github.com/repos/circonus-labs/reconnoiter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/circonus-labs/reconnoiter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/circonus-labs/reconnoiter/teams","hooks_url":"https://api.github.com/repos/circonus-labs/reconnoiter/hooks","issue_events_url":"https://api.github.com/repos/circonus-labs/reconnoiter/issues/events{/number}","events_url":"https://api.github.com/repos/circonus-labs/reconnoiter/events","assignees_url":"https://api.github.com/repos/circonus-labs/reconnoiter/assignees{/user}","branches_url":"https://api.github.com/repos/circonus-labs/reconnoiter/branches{/branch}","tags_url":"https://api.github.com/repos/circonus-labs/reconnoiter/tags","blobs_url":"https://api.github.com/repos/circonus-labs/reconnoiter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/circonus-labs/reconnoiter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/circonus-labs/reconnoiter/git/refs{/sha}","trees_url":"https://api.github.com/repos/circonus-labs/reconnoiter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/circonus-labs/reconnoiter/statuses/{sha}","languages_url":"https://api.github.com/repos/circonus-labs/reconnoiter/languages","stargazers_url":"https://api.github.com/repos/circonus-labs/reconnoiter/stargazers","contributors_url":"https://api.github.com/repos/circonus-labs/reconnoiter/contributors","subscribers_url":"https://api.github.com/repos/circonus-labs/reconnoiter/subscribers","subscription_url":"https://api.github.com/repos/circonus-labs/reconnoiter/subscription","commits_url":"https://api.github.com/repos/circonus-labs/reconnoiter/commits{/sha}","git_commits_url":"https://api.github.com/repos/circonus-labs/reconnoiter/git/commits{/sha}","comments_url":"https://api.github.com/repos/circonus-labs/reconnoiter/comments{/number}","issue_comment_url":"https://api.github.com/repos/circonus-labs/reconnoiter/issues/comments{/number}","contents_url":"https://api.github.com/repos/circonus-labs/reconnoiter/contents/{+path}","compare_url":"https://api.github.com/repos/circonus-labs/reconnoiter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/circonus-labs/reconnoiter/merges","archive_url":"https://api.github.com/repos/circonus-labs/reconnoiter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/circonus-labs/reconnoiter/downloads","issues_url":"https://api.github.com/repos/circonus-labs/reconnoiter/issues{/number}","pulls_url":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls{/number}","milestones_url":"https://api.github.com/repos/circonus-labs/reconnoiter/milestones{/number}","notifications_url":"https://api.github.com/repos/circonus-labs/reconnoiter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/circonus-labs/reconnoiter/labels{/name}","releases_url":"https://api.github.com/repos/circonus-labs/reconnoiter/releases{/id}","deployments_url":"https://api.github.com/repos/circonus-labs/reconnoiter/deployments","created_at":"2011-04-08T01:26:26Z","updated_at":"2017-05-22T23:14:37Z","pushed_at":"2017-06-13T20:35:34Z","git_url":"git://github.com/circonus-labs/reconnoiter.git","ssh_url":"[email protected]:circonus-labs/reconnoiter.git","clone_url":"https://github.com/circonus-labs/reconnoiter.git","svn_url":"https://github.com/circonus-labs/reconnoiter","homepage":"https://labs.omniti.com/labs/reconnoiter","size":34388,"stargazers_count":227,"watchers_count":227,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":64,"mirror_url":null,"open_issues_count":2,"forks":64,"open_issues":2,"watchers":227,"default_branch":"master"}},"base":{"label":"circonus-labs:master","ref":"master","sha":"54a856406033fbe880c75f6f84819bb093f334a2","user":{"login":"circonus-labs","id":2091329,"avatar_url":"https://avatars3.githubusercontent.com/u/2091329?v=3","gravatar_id":"","url":"https://api.github.com/users/circonus-labs","html_url":"https://github.com/circonus-labs","followers_url":"https://api.github.com/users/circonus-labs/followers","following_url":"https://api.github.com/users/circonus-labs/following{/other_user}","gists_url":"https://api.github.com/users/circonus-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/circonus-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circonus-labs/subscriptions","organizations_url":"https://api.github.com/users/circonus-labs/orgs","repos_url":"https://api.github.com/users/circonus-labs/repos","events_url":"https://api.github.com/users/circonus-labs/events{/privacy}","received_events_url":"https://api.github.com/users/circonus-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":1585344,"name":"reconnoiter","full_name":"circonus-labs/reconnoiter","owner":{"login":"circonus-labs","id":2091329,"avatar_url":"https://avatars3.githubusercontent.com/u/2091329?v=3","gravatar_id":"","url":"https://api.github.com/users/circonus-labs","html_url":"https://github.com/circonus-labs","followers_url":"https://api.github.com/users/circonus-labs/followers","following_url":"https://api.github.com/users/circonus-labs/following{/other_user}","gists_url":"https://api.github.com/users/circonus-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/circonus-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/circonus-labs/subscriptions","organizations_url":"https://api.github.com/users/circonus-labs/orgs","repos_url":"https://api.github.com/users/circonus-labs/repos","events_url":"https://api.github.com/users/circonus-labs/events{/privacy}","received_events_url":"https://api.github.com/users/circonus-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/circonus-labs/reconnoiter","description":"Large-scale Monitoring and Trend Analysis System","fork":false,"url":"https://api.github.com/repos/circonus-labs/reconnoiter","forks_url":"https://api.github.com/repos/circonus-labs/reconnoiter/forks","keys_url":"https://api.github.com/repos/circonus-labs/reconnoiter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/circonus-labs/reconnoiter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/circonus-labs/reconnoiter/teams","hooks_url":"https://api.github.com/repos/circonus-labs/reconnoiter/hooks","issue_events_url":"https://api.github.com/repos/circonus-labs/reconnoiter/issues/events{/number}","events_url":"https://api.github.com/repos/circonus-labs/reconnoiter/events","assignees_url":"https://api.github.com/repos/circonus-labs/reconnoiter/assignees{/user}","branches_url":"https://api.github.com/repos/circonus-labs/reconnoiter/branches{/branch}","tags_url":"https://api.github.com/repos/circonus-labs/reconnoiter/tags","blobs_url":"https://api.github.com/repos/circonus-labs/reconnoiter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/circonus-labs/reconnoiter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/circonus-labs/reconnoiter/git/refs{/sha}","trees_url":"https://api.github.com/repos/circonus-labs/reconnoiter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/circonus-labs/reconnoiter/statuses/{sha}","languages_url":"https://api.github.com/repos/circonus-labs/reconnoiter/languages","stargazers_url":"https://api.github.com/repos/circonus-labs/reconnoiter/stargazers","contributors_url":"https://api.github.com/repos/circonus-labs/reconnoiter/contributors","subscribers_url":"https://api.github.com/repos/circonus-labs/reconnoiter/subscribers","subscription_url":"https://api.github.com/repos/circonus-labs/reconnoiter/subscription","commits_url":"https://api.github.com/repos/circonus-labs/reconnoiter/commits{/sha}","git_commits_url":"https://api.github.com/repos/circonus-labs/reconnoiter/git/commits{/sha}","comments_url":"https://api.github.com/repos/circonus-labs/reconnoiter/comments{/number}","issue_comment_url":"https://api.github.com/repos/circonus-labs/reconnoiter/issues/comments{/number}","contents_url":"https://api.github.com/repos/circonus-labs/reconnoiter/contents/{+path}","compare_url":"https://api.github.com/repos/circonus-labs/reconnoiter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/circonus-labs/reconnoiter/merges","archive_url":"https://api.github.com/repos/circonus-labs/reconnoiter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/circonus-labs/reconnoiter/downloads","issues_url":"https://api.github.com/repos/circonus-labs/reconnoiter/issues{/number}","pulls_url":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls{/number}","milestones_url":"https://api.github.com/repos/circonus-labs/reconnoiter/milestones{/number}","notifications_url":"https://api.github.com/repos/circonus-labs/reconnoiter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/circonus-labs/reconnoiter/labels{/name}","releases_url":"https://api.github.com/repos/circonus-labs/reconnoiter/releases{/id}","deployments_url":"https://api.github.com/repos/circonus-labs/reconnoiter/deployments","created_at":"2011-04-08T01:26:26Z","updated_at":"2017-05-22T23:14:37Z","pushed_at":"2017-06-13T20:35:34Z","git_url":"git://github.com/circonus-labs/reconnoiter.git","ssh_url":"[email protected]:circonus-labs/reconnoiter.git","clone_url":"https://github.com/circonus-labs/reconnoiter.git","svn_url":"https://github.com/circonus-labs/reconnoiter","homepage":"https://labs.omniti.com/labs/reconnoiter","size":34388,"stargazers_count":227,"watchers_count":227,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":64,"mirror_url":null,"open_issues_count":2,"forks":64,"open_issues":2,"watchers":227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/371"},"html":{"href":"https://github.com/circonus-labs/reconnoiter/pull/371"},"issue":{"href":"https://api.github.com/repos/circonus-labs/reconnoiter/issues/371"},"comments":{"href":"https://api.github.com/repos/circonus-labs/reconnoiter/issues/371/comments"},"review_comments":{"href":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/371/comments"},"review_comment":{"href":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/circonus-labs/reconnoiter/pulls/371/commits"},"statuses":{"href":"https://api.github.com/repos/circonus-labs/reconnoiter/statuses/e468b76da9e8181ebe6eb2f45bcad9527493a0b3"}}}}
|
{
"id": 1585344,
"name": "circonus-labs/reconnoiter",
"url": "https://api.github.com/repos/circonus-labs/reconnoiter"
}
|
{
"id": 503301,
"login": "aidancully",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/503301?",
"url": "https://api.github.com/users/aidancully"
}
|
{
"id": 2091329,
"login": "circonus-labs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2091329?",
"url": "https://api.github.com/orgs/circonus-labs"
}
| 2017-06-14T20:49:20 |
6067421178
|
{"actor":{"display_login":"aidancully"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/cocos-creator/engine/pulls/comments/122901783","pull_request_review_id":45054845,"id":122901783,"diff_hunk":"@@ -26,15 +26,14 @@\n \n var PrefabHelper = require('./utils/prefab-helper');\n var SgHelper = require('./utils/scene-graph-helper');\n+var CallbacksInvoker = require('./platform/callbacks-invoker');\n \n var Flags = cc.Object.Flags;\n var Destroying = Flags.Destroying;\n \n-var POSITION_CHANGED = 'position-changed';\n+var TRANSFORM_CHANGED = 'transform-changed';\n var SIZE_CHANGED = 'size-changed';\n var ANCHOR_CHANGED = 'anchor-changed';\n-var ROTATION_CHANGED = 'rotation-changed';\n-var SCALE_CHANGED = 'scale-changed';","path":"cocos2d/core/CCNode.js","position":14,"original_position":14,"commit_id":"99c1def534cfff23e9ed0041d72ff5b6fda77686","original_commit_id":"99c1def534cfff23e9ed0041d72ff5b6fda77686","user":{"login":"2youyou2","id":1862402,"avatar_url":"https://avatars0.githubusercontent.com/u/1862402?v=3","gravatar_id":"","url":"https://api.github.com/users/2youyou2","html_url":"https://github.com/2youyou2","followers_url":"https://api.github.com/users/2youyou2/followers","following_url":"https://api.github.com/users/2youyou2/following{/other_user}","gists_url":"https://api.github.com/users/2youyou2/gists{/gist_id}","starred_url":"https://api.github.com/users/2youyou2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2youyou2/subscriptions","organizations_url":"https://api.github.com/users/2youyou2/orgs","repos_url":"https://api.github.com/users/2youyou2/repos","events_url":"https://api.github.com/users/2youyou2/events{/privacy}","received_events_url":"https://api.github.com/users/2youyou2/received_events","type":"User","site_admin":false},"body":"是要同步节点的属性到box2d中，box2d 是没有 scale 设置的，所以要监听节点的 scale 变化单独重新创建刚体，不能一直更新这个值的","created_at":"2017-06-20T07:44:21Z","updated_at":"2017-06-20T07:44:21Z","html_url":"https://github.com/cocos-creator/engine/pull/1741#discussion_r122901783","pull_request_url":"https://api.github.com/repos/cocos-creator/engine/pulls/1741","_links":{"self":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/comments/122901783"},"html":{"href":"https://github.com/cocos-creator/engine/pull/1741#discussion_r122901783"},"pull_request":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/1741"}}},"pull_request":{"url":"https://api.github.com/repos/cocos-creator/engine/pulls/1741","id":126462766,"html_url":"https://github.com/cocos-creator/engine/pull/1741","diff_url":"https://github.com/cocos-creator/engine/pull/1741.diff","patch_url":"https://github.com/cocos-creator/engine/pull/1741.patch","issue_url":"https://api.github.com/repos/cocos-creator/engine/issues/1741","number":1741,"state":"open","locked":false,"title":"Try to solve node trs event overhead","user":{"login":"pandamicro","id":632460,"avatar_url":"https://avatars1.githubusercontent.com/u/632460?v=3","gravatar_id":"","url":"https://api.github.com/users/pandamicro","html_url":"https://github.com/pandamicro","followers_url":"https://api.github.com/users/pandamicro/followers","following_url":"https://api.github.com/users/pandamicro/following{/other_user}","gists_url":"https://api.github.com/users/pandamicro/gists{/gist_id}","starred_url":"https://api.github.com/users/pandamicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandamicro/subscriptions","organizations_url":"https://api.github.com/users/pandamicro/orgs","repos_url":"https://api.github.com/users/pandamicro/repos","events_url":"https://api.github.com/users/pandamicro/events{/privacy}","received_events_url":"https://api.github.com/users/pandamicro/received_events","type":"User","site_admin":false},"body":"Re: cocos-creator/fireball#5899\r\n\r\nChanges proposed in this pull request:\r\n * Try to solve node trs event overhead\r\n\r\n> Makes sure these boxes are checked before submitting your PR - thank you!\r\n>\r\n- [x] If your pull request has gone \"stale\", you should **rebase** your work on top of the latest version of the upstream branch.\r\n- [x] If your commit history is full of small, unimportant commits (such as \"fix pep8\" or \"update tests\"), **squash** your commits down to a few, or one, discreet changesets before submitting a pull request.\r\n- To official teams:\r\n - [x] Check that your javascript is following our [style guide](https://github.com/cocos-creator/fireball/blob/dev/.github/CONTRIBUTING.md) and end files with a newline\r\n - [x] Document new code with comments in source code based on [API Docs](https://github.com/cocos-creator/fireball#api-docs)\r\n - [x] Make sure any runtime log information in `cc.log` , `cc.error`, `cc.warn` or `cc.assert` has been moved into `DebugInfos.js` with an ID\r\n\r\n@cocos-creator/engine-admins\r\n","created_at":"2017-06-20T07:19:39Z","updated_at":"2017-06-20T07:44:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51a1d8977cc0f34d9b52ab74eadb027f81f5d339","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zilongshanren","id":785541,"avatar_url":"https://avatars0.githubusercontent.com/u/785541?v=3","gravatar_id":"","url":"https://api.github.com/users/zilongshanren","html_url":"https://github.com/zilongshanren","followers_url":"https://api.github.com/users/zilongshanren/followers","following_url":"https://api.github.com/users/zilongshanren/following{/other_user}","gists_url":"https://api.github.com/users/zilongshanren/gists{/gist_id}","starred_url":"https://api.github.com/users/zilongshanren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zilongshanren/subscriptions","organizations_url":"https://api.github.com/users/zilongshanren/orgs","repos_url":"https://api.github.com/users/zilongshanren/repos","events_url":"https://api.github.com/users/zilongshanren/events{/privacy}","received_events_url":"https://api.github.com/users/zilongshanren/received_events","type":"User","site_admin":false},{"login":"2youyou2","id":1862402,"avatar_url":"https://avatars0.githubusercontent.com/u/1862402?v=3","gravatar_id":"","url":"https://api.github.com/users/2youyou2","html_url":"https://github.com/2youyou2","followers_url":"https://api.github.com/users/2youyou2/followers","following_url":"https://api.github.com/users/2youyou2/following{/other_user}","gists_url":"https://api.github.com/users/2youyou2/gists{/gist_id}","starred_url":"https://api.github.com/users/2youyou2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2youyou2/subscriptions","organizations_url":"https://api.github.com/users/2youyou2/orgs","repos_url":"https://api.github.com/users/2youyou2/repos","events_url":"https://api.github.com/users/2youyou2/events{/privacy}","received_events_url":"https://api.github.com/users/2youyou2/received_events","type":"User","site_admin":false},{"login":"knoxHuang","id":7564028,"avatar_url":"https://avatars1.githubusercontent.com/u/7564028?v=3","gravatar_id":"","url":"https://api.github.com/users/knoxHuang","html_url":"https://github.com/knoxHuang","followers_url":"https://api.github.com/users/knoxHuang/followers","following_url":"https://api.github.com/users/knoxHuang/following{/other_user}","gists_url":"https://api.github.com/users/knoxHuang/gists{/gist_id}","starred_url":"https://api.github.com/users/knoxHuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knoxHuang/subscriptions","organizations_url":"https://api.github.com/users/knoxHuang/orgs","repos_url":"https://api.github.com/users/knoxHuang/repos","events_url":"https://api.github.com/users/knoxHuang/events{/privacy}","received_events_url":"https://api.github.com/users/knoxHuang/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cocos-creator/engine/pulls/1741/commits","review_comments_url":"https://api.github.com/repos/cocos-creator/engine/pulls/1741/comments","review_comment_url":"https://api.github.com/repos/cocos-creator/engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocos-creator/engine/issues/1741/comments","statuses_url":"https://api.github.com/repos/cocos-creator/engine/statuses/99c1def534cfff23e9ed0041d72ff5b6fda77686","head":{"label":"pandamicro:v1.5","ref":"v1.5","sha":"99c1def534cfff23e9ed0041d72ff5b6fda77686","user":{"login":"pandamicro","id":632460,"avatar_url":"https://avatars1.githubusercontent.com/u/632460?v=3","gravatar_id":"","url":"https://api.github.com/users/pandamicro","html_url":"https://github.com/pandamicro","followers_url":"https://api.github.com/users/pandamicro/followers","following_url":"https://api.github.com/users/pandamicro/following{/other_user}","gists_url":"https://api.github.com/users/pandamicro/gists{/gist_id}","starred_url":"https://api.github.com/users/pandamicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandamicro/subscriptions","organizations_url":"https://api.github.com/users/pandamicro/orgs","repos_url":"https://api.github.com/users/pandamicro/repos","events_url":"https://api.github.com/users/pandamicro/events{/privacy}","received_events_url":"https://api.github.com/users/pandamicro/received_events","type":"User","site_admin":false},"repo":{"id":54607274,"name":"fire-engine","full_name":"pandamicro/fire-engine","owner":{"login":"pandamicro","id":632460,"avatar_url":"https://avatars1.githubusercontent.com/u/632460?v=3","gravatar_id":"","url":"https://api.github.com/users/pandamicro","html_url":"https://github.com/pandamicro","followers_url":"https://api.github.com/users/pandamicro/followers","following_url":"https://api.github.com/users/pandamicro/following{/other_user}","gists_url":"https://api.github.com/users/pandamicro/gists{/gist_id}","starred_url":"https://api.github.com/users/pandamicro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandamicro/subscriptions","organizations_url":"https://api.github.com/users/pandamicro/orgs","repos_url":"https://api.github.com/users/pandamicro/repos","events_url":"https://api.github.com/users/pandamicro/events{/privacy}","received_events_url":"https://api.github.com/users/pandamicro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pandamicro/fire-engine","description":"New integrated engine to replace cocos2d-html5","fork":true,"url":"https://api.github.com/repos/pandamicro/fire-engine","forks_url":"https://api.github.com/repos/pandamicro/fire-engine/forks","keys_url":"https://api.github.com/repos/pandamicro/fire-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandamicro/fire-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandamicro/fire-engine/teams","hooks_url":"https://api.github.com/repos/pandamicro/fire-engine/hooks","issue_events_url":"https://api.github.com/repos/pandamicro/fire-engine/issues/events{/number}","events_url":"https://api.github.com/repos/pandamicro/fire-engine/events","assignees_url":"https://api.github.com/repos/pandamicro/fire-engine/assignees{/user}","branches_url":"https://api.github.com/repos/pandamicro/fire-engine/branches{/branch}","tags_url":"https://api.github.com/repos/pandamicro/fire-engine/tags","blobs_url":"https://api.github.com/repos/pandamicro/fire-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandamicro/fire-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandamicro/fire-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandamicro/fire-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandamicro/fire-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/pandamicro/fire-engine/languages","stargazers_url":"https://api.github.com/repos/pandamicro/fire-engine/stargazers","contributors_url":"https://api.github.com/repos/pandamicro/fire-engine/contributors","subscribers_url":"https://api.github.com/repos/pandamicro/fire-engine/subscribers","subscription_url":"https://api.github.com/repos/pandamicro/fire-engine/subscription","commits_url":"https://api.github.com/repos/pandamicro/fire-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandamicro/fire-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandamicro/fire-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandamicro/fire-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandamicro/fire-engine/contents/{+path}","compare_url":"https://api.github.com/repos/pandamicro/fire-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandamicro/fire-engine/merges","archive_url":"https://api.github.com/repos/pandamicro/fire-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandamicro/fire-engine/downloads","issues_url":"https://api.github.com/repos/pandamicro/fire-engine/issues{/number}","pulls_url":"https://api.github.com/repos/pandamicro/fire-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/pandamicro/fire-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/pandamicro/fire-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandamicro/fire-engine/labels{/name}","releases_url":"https://api.github.com/repos/pandamicro/fire-engine/releases{/id}","deployments_url":"https://api.github.com/repos/pandamicro/fire-engine/deployments","created_at":"2016-03-24T02:06:28Z","updated_at":"2017-04-17T13:38:31Z","pushed_at":"2017-06-20T07:18:50Z","git_url":"git://github.com/pandamicro/fire-engine.git","ssh_url":"[email protected]:pandamicro/fire-engine.git","clone_url":"https://github.com/pandamicro/fire-engine.git","svn_url":"https://github.com/pandamicro/fire-engine","homepage":null,"size":27622,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"cocos-creator:v1.5","ref":"v1.5","sha":"4d6470d3d95148fe154a9f3d7de27b6f5ad198cf","user":{"login":"cocos-creator","id":6937061,"avatar_url":"https://avatars0.githubusercontent.com/u/6937061?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos-creator","html_url":"https://github.com/cocos-creator","followers_url":"https://api.github.com/users/cocos-creator/followers","following_url":"https://api.github.com/users/cocos-creator/following{/other_user}","gists_url":"https://api.github.com/users/cocos-creator/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos-creator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos-creator/subscriptions","organizations_url":"https://api.github.com/users/cocos-creator/orgs","repos_url":"https://api.github.com/users/cocos-creator/repos","events_url":"https://api.github.com/users/cocos-creator/events{/privacy}","received_events_url":"https://api.github.com/users/cocos-creator/received_events","type":"Organization","site_admin":false},"repo":{"id":47440536,"name":"engine","full_name":"cocos-creator/engine","owner":{"login":"cocos-creator","id":6937061,"avatar_url":"https://avatars0.githubusercontent.com/u/6937061?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos-creator","html_url":"https://github.com/cocos-creator","followers_url":"https://api.github.com/users/cocos-creator/followers","following_url":"https://api.github.com/users/cocos-creator/following{/other_user}","gists_url":"https://api.github.com/users/cocos-creator/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos-creator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos-creator/subscriptions","organizations_url":"https://api.github.com/users/cocos-creator/orgs","repos_url":"https://api.github.com/users/cocos-creator/repos","events_url":"https://api.github.com/users/cocos-creator/events{/privacy}","received_events_url":"https://api.github.com/users/cocos-creator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos-creator/engine","description":"The engine for Cocos Creator","fork":false,"url":"https://api.github.com/repos/cocos-creator/engine","forks_url":"https://api.github.com/repos/cocos-creator/engine/forks","keys_url":"https://api.github.com/repos/cocos-creator/engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos-creator/engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos-creator/engine/teams","hooks_url":"https://api.github.com/repos/cocos-creator/engine/hooks","issue_events_url":"https://api.github.com/repos/cocos-creator/engine/issues/events{/number}","events_url":"https://api.github.com/repos/cocos-creator/engine/events","assignees_url":"https://api.github.com/repos/cocos-creator/engine/assignees{/user}","branches_url":"https://api.github.com/repos/cocos-creator/engine/branches{/branch}","tags_url":"https://api.github.com/repos/cocos-creator/engine/tags","blobs_url":"https://api.github.com/repos/cocos-creator/engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos-creator/engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos-creator/engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos-creator/engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos-creator/engine/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos-creator/engine/languages","stargazers_url":"https://api.github.com/repos/cocos-creator/engine/stargazers","contributors_url":"https://api.github.com/repos/cocos-creator/engine/contributors","subscribers_url":"https://api.github.com/repos/cocos-creator/engine/subscribers","subscription_url":"https://api.github.com/repos/cocos-creator/engine/subscription","commits_url":"https://api.github.com/repos/cocos-creator/engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos-creator/engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos-creator/engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos-creator/engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocos-creator/engine/contents/{+path}","compare_url":"https://api.github.com/repos/cocos-creator/engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos-creator/engine/merges","archive_url":"https://api.github.com/repos/cocos-creator/engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos-creator/engine/downloads","issues_url":"https://api.github.com/repos/cocos-creator/engine/issues{/number}","pulls_url":"https://api.github.com/repos/cocos-creator/engine/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos-creator/engine/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos-creator/engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos-creator/engine/labels{/name}","releases_url":"https://api.github.com/repos/cocos-creator/engine/releases{/id}","deployments_url":"https://api.github.com/repos/cocos-creator/engine/deployments","created_at":"2015-12-05T03:28:59Z","updated_at":"2017-06-18T07:36:41Z","pushed_at":"2017-06-20T07:19:40Z","git_url":"git://github.com/cocos-creator/engine.git","ssh_url":"[email protected]:cocos-creator/engine.git","clone_url":"https://github.com/cocos-creator/engine.git","svn_url":"https://github.com/cocos-creator/engine","homepage":"http://www.cocos2d-x.org/creator","size":27948,"stargazers_count":245,"watchers_count":245,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":156,"mirror_url":null,"open_issues_count":31,"forks":156,"open_issues":31,"watchers":245,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/1741"},"html":{"href":"https://github.com/cocos-creator/engine/pull/1741"},"issue":{"href":"https://api.github.com/repos/cocos-creator/engine/issues/1741"},"comments":{"href":"https://api.github.com/repos/cocos-creator/engine/issues/1741/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/1741/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocos-creator/engine/pulls/1741/commits"},"statuses":{"href":"https://api.github.com/repos/cocos-creator/engine/statuses/99c1def534cfff23e9ed0041d72ff5b6fda77686"}}}}
|
{
"id": 47440536,
"name": "cocos-creator/engine",
"url": "https://api.github.com/repos/cocos-creator/engine"
}
|
{
"id": 1862402,
"login": "2youyou2",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1862402?",
"url": "https://api.github.com/users/2youyou2"
}
|
{
"id": 6937061,
"login": "cocos-creator",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6937061?",
"url": "https://api.github.com/orgs/cocos-creator"
}
| 2017-06-20T07:44:21 |
6098497205
|
{"actor":{"display_login":"2youyou2"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments/102771758","pull_request_review_id":23539041,"id":102771758,"diff_hunk":"@@ -136,6 +137,13 @@ async function initDebugger(url, ...sources) {\n return dbg;\n }\n \n+function countSources(dbg) {\n+ const sources = dbg.selectors.getSources(dbg.getState());\n+\n+ // the web test runner has one extra source because it injects the debuggee script\n+ return sources.size - 1;","path":"src/test/integration/utils/mocha.js","position":29,"original_position":29,"commit_id":"6c9285496c18348baab9e61fdf6247d090e85000","original_commit_id":"6c9285496c18348baab9e61fdf6247d090e85000","user":{"login":"bomsy","id":792924,"avatar_url":"https://avatars.githubusercontent.com/u/792924?v=3","gravatar_id":"","url":"https://api.github.com/users/bomsy","html_url":"https://github.com/bomsy","followers_url":"https://api.github.com/users/bomsy/followers","following_url":"https://api.github.com/users/bomsy/following{/other_user}","gists_url":"https://api.github.com/users/bomsy/gists{/gist_id}","starred_url":"https://api.github.com/users/bomsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bomsy/subscriptions","organizations_url":"https://api.github.com/users/bomsy/orgs","repos_url":"https://api.github.com/users/bomsy/repos","events_url":"https://api.github.com/users/bomsy/events{/privacy}","received_events_url":"https://api.github.com/users/bomsy/received_events","type":"User","site_admin":false},"body":"This might be just me :) but the navigation tests seem to be failing because this, when there are no sources\r\n","created_at":"2017-02-23T17:39:26Z","updated_at":"2017-02-23T17:39:26Z","html_url":"https://github.com/devtools-html/debugger.html/pull/2089#discussion_r102771758","pull_request_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/2089","_links":{"self":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments/102771758"},"html":{"href":"https://github.com/devtools-html/debugger.html/pull/2089#discussion_r102771758"},"pull_request":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/2089"}}},"pull_request":{"url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/2089","id":107525155,"html_url":"https://github.com/devtools-html/debugger.html/pull/2089","diff_url":"https://github.com/devtools-html/debugger.html/pull/2089.diff","patch_url":"https://github.com/devtools-html/debugger.html/pull/2089.patch","issue_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/2089","number":2089,"state":"open","locked":false,"title":"Additional integration tests","user":{"login":"jasonLaster","id":254562,"avatar_url":"https://avatars.githubusercontent.com/u/254562?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonLaster","html_url":"https://github.com/jasonLaster","followers_url":"https://api.github.com/users/jasonLaster/followers","following_url":"https://api.github.com/users/jasonLaster/following{/other_user}","gists_url":"https://api.github.com/users/jasonLaster/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonLaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonLaster/subscriptions","organizations_url":"https://api.github.com/users/jasonLaster/orgs","repos_url":"https://api.github.com/users/jasonLaster/repos","events_url":"https://api.github.com/users/jasonLaster/events{/privacy}","received_events_url":"https://api.github.com/users/jasonLaster/received_events","type":"User","site_admin":false},"body":"Associated Issue: #1919 \r\n\r\n### Summary of Changes\r\n\r\n* Adds a test for persisting expand state\r\n* Adds support for a lot more web tests\r\n\r\n\r\n### Test Plan\r\n\r\n* mochitests\r\n\r\n### Screenshots/Videos (OPTIONAL)\r\n\r\n\r\n","created_at":"2017-02-22T23:41:37Z","updated_at":"2017-02-23T17:39:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0fd42719863fd15f7f7341e72e8eb630563d1c5d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/2089/commits","review_comments_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/2089/comments","review_comment_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments{/number}","comments_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/2089/comments","statuses_url":"https://api.github.com/repos/devtools-html/debugger.html/statuses/6c9285496c18348baab9e61fdf6247d090e85000","head":{"label":"jasonLaster:test-scopes","ref":"test-scopes","sha":"6c9285496c18348baab9e61fdf6247d090e85000","user":{"login":"jasonLaster","id":254562,"avatar_url":"https://avatars.githubusercontent.com/u/254562?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonLaster","html_url":"https://github.com/jasonLaster","followers_url":"https://api.github.com/users/jasonLaster/followers","following_url":"https://api.github.com/users/jasonLaster/following{/other_user}","gists_url":"https://api.github.com/users/jasonLaster/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonLaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonLaster/subscriptions","organizations_url":"https://api.github.com/users/jasonLaster/orgs","repos_url":"https://api.github.com/users/jasonLaster/repos","events_url":"https://api.github.com/users/jasonLaster/events{/privacy}","received_events_url":"https://api.github.com/users/jasonLaster/received_events","type":"User","site_admin":false},"repo":{"id":55007537,"name":"debugger.html","full_name":"jasonLaster/debugger.html","owner":{"login":"jasonLaster","id":254562,"avatar_url":"https://avatars.githubusercontent.com/u/254562?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonLaster","html_url":"https://github.com/jasonLaster","followers_url":"https://api.github.com/users/jasonLaster/followers","following_url":"https://api.github.com/users/jasonLaster/following{/other_user}","gists_url":"https://api.github.com/users/jasonLaster/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonLaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonLaster/subscriptions","organizations_url":"https://api.github.com/users/jasonLaster/orgs","repos_url":"https://api.github.com/users/jasonLaster/repos","events_url":"https://api.github.com/users/jasonLaster/events{/privacy}","received_events_url":"https://api.github.com/users/jasonLaster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasonLaster/debugger.html","description":"Experimental something something.","fork":true,"url":"https://api.github.com/repos/jasonLaster/debugger.html","forks_url":"https://api.github.com/repos/jasonLaster/debugger.html/forks","keys_url":"https://api.github.com/repos/jasonLaster/debugger.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasonLaster/debugger.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasonLaster/debugger.html/teams","hooks_url":"https://api.github.com/repos/jasonLaster/debugger.html/hooks","issue_events_url":"https://api.github.com/repos/jasonLaster/debugger.html/issues/events{/number}","events_url":"https://api.github.com/repos/jasonLaster/debugger.html/events","assignees_url":"https://api.github.com/repos/jasonLaster/debugger.html/assignees{/user}","branches_url":"https://api.github.com/repos/jasonLaster/debugger.html/branches{/branch}","tags_url":"https://api.github.com/repos/jasonLaster/debugger.html/tags","blobs_url":"https://api.github.com/repos/jasonLaster/debugger.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasonLaster/debugger.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasonLaster/debugger.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasonLaster/debugger.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasonLaster/debugger.html/statuses/{sha}","languages_url":"https://api.github.com/repos/jasonLaster/debugger.html/languages","stargazers_url":"https://api.github.com/repos/jasonLaster/debugger.html/stargazers","contributors_url":"https://api.github.com/repos/jasonLaster/debugger.html/contributors","subscribers_url":"https://api.github.com/repos/jasonLaster/debugger.html/subscribers","subscription_url":"https://api.github.com/repos/jasonLaster/debugger.html/subscription","commits_url":"https://api.github.com/repos/jasonLaster/debugger.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasonLaster/debugger.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasonLaster/debugger.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasonLaster/debugger.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasonLaster/debugger.html/contents/{+path}","compare_url":"https://api.github.com/repos/jasonLaster/debugger.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasonLaster/debugger.html/merges","archive_url":"https://api.github.com/repos/jasonLaster/debugger.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasonLaster/debugger.html/downloads","issues_url":"https://api.github.com/repos/jasonLaster/debugger.html/issues{/number}","pulls_url":"https://api.github.com/repos/jasonLaster/debugger.html/pulls{/number}","milestones_url":"https://api.github.com/repos/jasonLaster/debugger.html/milestones{/number}","notifications_url":"https://api.github.com/repos/jasonLaster/debugger.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasonLaster/debugger.html/labels{/name}","releases_url":"https://api.github.com/repos/jasonLaster/debugger.html/releases{/id}","deployments_url":"https://api.github.com/repos/jasonLaster/debugger.html/deployments","created_at":"2016-03-29T20:14:57Z","updated_at":"2017-02-01T23:24:18Z","pushed_at":"2017-02-23T17:24:14Z","git_url":"git://github.com/jasonLaster/debugger.html.git","ssh_url":"[email protected]:jasonLaster/debugger.html.git","clone_url":"https://github.com/jasonLaster/debugger.html.git","svn_url":"https://github.com/jasonLaster/debugger.html","homepage":null,"size":20693,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"devtools-html:master","ref":"master","sha":"a793001dae783a68523bb9dbe966cd875b8a3340","user":{"login":"devtools-html","id":19979421,"avatar_url":"https://avatars.githubusercontent.com/u/19979421?v=3","gravatar_id":"","url":"https://api.github.com/users/devtools-html","html_url":"https://github.com/devtools-html","followers_url":"https://api.github.com/users/devtools-html/followers","following_url":"https://api.github.com/users/devtools-html/following{/other_user}","gists_url":"https://api.github.com/users/devtools-html/gists{/gist_id}","starred_url":"https://api.github.com/users/devtools-html/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devtools-html/subscriptions","organizations_url":"https://api.github.com/users/devtools-html/orgs","repos_url":"https://api.github.com/users/devtools-html/repos","events_url":"https://api.github.com/users/devtools-html/events{/privacy}","received_events_url":"https://api.github.com/users/devtools-html/received_events","type":"Organization","site_admin":false},"repo":{"id":54585418,"name":"debugger.html","full_name":"devtools-html/debugger.html","owner":{"login":"devtools-html","id":19979421,"avatar_url":"https://avatars.githubusercontent.com/u/19979421?v=3","gravatar_id":"","url":"https://api.github.com/users/devtools-html","html_url":"https://github.com/devtools-html","followers_url":"https://api.github.com/users/devtools-html/followers","following_url":"https://api.github.com/users/devtools-html/following{/other_user}","gists_url":"https://api.github.com/users/devtools-html/gists{/gist_id}","starred_url":"https://api.github.com/users/devtools-html/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devtools-html/subscriptions","organizations_url":"https://api.github.com/users/devtools-html/orgs","repos_url":"https://api.github.com/users/devtools-html/repos","events_url":"https://api.github.com/users/devtools-html/events{/privacy}","received_events_url":"https://api.github.com/users/devtools-html/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/devtools-html/debugger.html","description":"The Firefox debugger that works anywhere :boom:","fork":false,"url":"https://api.github.com/repos/devtools-html/debugger.html","forks_url":"https://api.github.com/repos/devtools-html/debugger.html/forks","keys_url":"https://api.github.com/repos/devtools-html/debugger.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devtools-html/debugger.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devtools-html/debugger.html/teams","hooks_url":"https://api.github.com/repos/devtools-html/debugger.html/hooks","issue_events_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/events{/number}","events_url":"https://api.github.com/repos/devtools-html/debugger.html/events","assignees_url":"https://api.github.com/repos/devtools-html/debugger.html/assignees{/user}","branches_url":"https://api.github.com/repos/devtools-html/debugger.html/branches{/branch}","tags_url":"https://api.github.com/repos/devtools-html/debugger.html/tags","blobs_url":"https://api.github.com/repos/devtools-html/debugger.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devtools-html/debugger.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devtools-html/debugger.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/devtools-html/debugger.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devtools-html/debugger.html/statuses/{sha}","languages_url":"https://api.github.com/repos/devtools-html/debugger.html/languages","stargazers_url":"https://api.github.com/repos/devtools-html/debugger.html/stargazers","contributors_url":"https://api.github.com/repos/devtools-html/debugger.html/contributors","subscribers_url":"https://api.github.com/repos/devtools-html/debugger.html/subscribers","subscription_url":"https://api.github.com/repos/devtools-html/debugger.html/subscription","commits_url":"https://api.github.com/repos/devtools-html/debugger.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/devtools-html/debugger.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/devtools-html/debugger.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/devtools-html/debugger.html/contents/{+path}","compare_url":"https://api.github.com/repos/devtools-html/debugger.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devtools-html/debugger.html/merges","archive_url":"https://api.github.com/repos/devtools-html/debugger.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devtools-html/debugger.html/downloads","issues_url":"https://api.github.com/repos/devtools-html/debugger.html/issues{/number}","pulls_url":"https://api.github.com/repos/devtools-html/debugger.html/pulls{/number}","milestones_url":"https://api.github.com/repos/devtools-html/debugger.html/milestones{/number}","notifications_url":"https://api.github.com/repos/devtools-html/debugger.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devtools-html/debugger.html/labels{/name}","releases_url":"https://api.github.com/repos/devtools-html/debugger.html/releases{/id}","deployments_url":"https://api.github.com/repos/devtools-html/debugger.html/deployments","created_at":"2016-03-23T18:55:36Z","updated_at":"2017-02-23T16:57:34Z","pushed_at":"2017-02-23T17:33:33Z","git_url":"git://github.com/devtools-html/debugger.html.git","ssh_url":"[email protected]:devtools-html/debugger.html.git","clone_url":"https://github.com/devtools-html/debugger.html.git","svn_url":"https://github.com/devtools-html/debugger.html","homepage":"https://devtools-html.github.io/debugger.html/","size":6160,"stargazers_count":2450,"watchers_count":2450,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":239,"mirror_url":null,"open_issues_count":98,"forks":239,"open_issues":98,"watchers":2450,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/2089"},"html":{"href":"https://github.com/devtools-html/debugger.html/pull/2089"},"issue":{"href":"https://api.github.com/repos/devtools-html/debugger.html/issues/2089"},"comments":{"href":"https://api.github.com/repos/devtools-html/debugger.html/issues/2089/comments"},"review_comments":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/2089/comments"},"review_comment":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/devtools-html/debugger.html/pulls/2089/commits"},"statuses":{"href":"https://api.github.com/repos/devtools-html/debugger.html/statuses/6c9285496c18348baab9e61fdf6247d090e85000"}}}}
|
{
"id": 54585418,
"name": "devtools-html/debugger.html",
"url": "https://api.github.com/repos/devtools-html/debugger.html"
}
|
{
"id": 792924,
"login": "bomsy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/792924?",
"url": "https://api.github.com/users/bomsy"
}
|
{
"id": 19979421,
"login": "devtools-html",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19979421?",
"url": "https://api.github.com/orgs/devtools-html"
}
| 2017-02-23T17:39:26 |
5379644285
|
{"actor":{"display_login":"bomsy"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/edx-solutions/api-integration/pulls/comments/139636691","pull_request_review_id":63594662,"id":139636691,"diff_hunk":"@@ -133,44 +138,44 @@ def setUpClass(cls):\n cls.chapter = ItemFactory.create(\n category=\"chapter\",\n parent_location=cls.course.location,\n- data=cls.test_data,\n+ # data=cls.test_data,","path":"edx_solutions_api_integration/courses/tests.py","position":57,"original_position":57,"commit_id":"ab958ab4f22f6d38f5a958a31984bbe97537aff5","original_commit_id":"ab958ab4f22f6d38f5a958a31984bbe97537aff5","user":{"login":"ziafazal","id":434995,"avatar_url":"https://avatars1.githubusercontent.com/u/434995?v=4","gravatar_id":"","url":"https://api.github.com/users/ziafazal","html_url":"https://github.com/ziafazal","followers_url":"https://api.github.com/users/ziafazal/followers","following_url":"https://api.github.com/users/ziafazal/following{/other_user}","gists_url":"https://api.github.com/users/ziafazal/gists{/gist_id}","starred_url":"https://api.github.com/users/ziafazal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ziafazal/subscriptions","organizations_url":"https://api.github.com/users/ziafazal/orgs","repos_url":"https://api.github.com/users/ziafazal/repos","events_url":"https://api.github.com/users/ziafazal/events{/privacy}","received_events_url":"https://api.github.com/users/ziafazal/received_events","type":"User","site_admin":false},"body":"Commented code","created_at":"2017-09-19T09:10:20Z","updated_at":"2017-09-19T09:24:34Z","html_url":"https://github.com/edx-solutions/api-integration/pull/77#discussion_r139636691","pull_request_url":"https://api.github.com/repos/edx-solutions/api-integration/pulls/77","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/edx-solutions/api-integration/pulls/comments/139636691"},"html":{"href":"https://github.com/edx-solutions/api-integration/pull/77#discussion_r139636691"},"pull_request":{"href":"https://api.github.com/repos/edx-solutions/api-integration/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/edx-solutions/api-integration/pulls/77","id":141777211,"html_url":"https://github.com/edx-solutions/api-integration/pull/77","diff_url":"https://github.com/edx-solutions/api-integration/pull/77.diff","patch_url":"https://github.com/edx-solutions/api-integration/pull/77.patch","issue_url":"https://api.github.com/repos/edx-solutions/api-integration/issues/77","number":77,"state":"open","locked":false,"title":"YONK-16: Added split module store for tests","user":{"login":"aamishbaloch","id":11043598,"avatar_url":"https://avatars2.githubusercontent.com/u/11043598?v=4","gravatar_id":"","url":"https://api.github.com/users/aamishbaloch","html_url":"https://github.com/aamishbaloch","followers_url":"https://api.github.com/users/aamishbaloch/followers","following_url":"https://api.github.com/users/aamishbaloch/following{/other_user}","gists_url":"https://api.github.com/users/aamishbaloch/gists{/gist_id}","starred_url":"https://api.github.com/users/aamishbaloch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aamishbaloch/subscriptions","organizations_url":"https://api.github.com/users/aamishbaloch/orgs","repos_url":"https://api.github.com/users/aamishbaloch/repos","events_url":"https://api.github.com/users/aamishbaloch/events{/privacy}","received_events_url":"https://api.github.com/users/aamishbaloch/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-19T07:37:50Z","updated_at":"2017-09-19T09:24:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7174b03d0c98bf49bf073d2b8b170fec60e7547d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx-solutions/api-integration/pulls/77/commits","review_comments_url":"https://api.github.com/repos/edx-solutions/api-integration/pulls/77/comments","review_comment_url":"https://api.github.com/repos/edx-solutions/api-integration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx-solutions/api-integration/issues/77/comments","statuses_url":"https://api.github.com/repos/edx-solutions/api-integration/statuses/ab958ab4f22f6d38f5a958a31984bbe97537aff5","head":{"label":"edx-solutions:aamishbaloch/YONK-16B","ref":"aamishbaloch/YONK-16B","sha":"ab958ab4f22f6d38f5a958a31984bbe97537aff5","user":{"login":"edx-solutions","id":6585054,"avatar_url":"https://avatars3.githubusercontent.com/u/6585054?v=4","gravatar_id":"","url":"https://api.github.com/users/edx-solutions","html_url":"https://github.com/edx-solutions","followers_url":"https://api.github.com/users/edx-solutions/followers","following_url":"https://api.github.com/users/edx-solutions/following{/other_user}","gists_url":"https://api.github.com/users/edx-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/edx-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx-solutions/subscriptions","organizations_url":"https://api.github.com/users/edx-solutions/orgs","repos_url":"https://api.github.com/users/edx-solutions/repos","events_url":"https://api.github.com/users/edx-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/edx-solutions/received_events","type":"Organization","site_admin":false},"repo":{"id":61370435,"name":"api-integration","full_name":"edx-solutions/api-integration","owner":{"login":"edx-solutions","id":6585054,"avatar_url":"https://avatars3.githubusercontent.com/u/6585054?v=4","gravatar_id":"","url":"https://api.github.com/users/edx-solutions","html_url":"https://github.com/edx-solutions","followers_url":"https://api.github.com/users/edx-solutions/followers","following_url":"https://api.github.com/users/edx-solutions/following{/other_user}","gists_url":"https://api.github.com/users/edx-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/edx-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx-solutions/subscriptions","organizations_url":"https://api.github.com/users/edx-solutions/orgs","repos_url":"https://api.github.com/users/edx-solutions/repos","events_url":"https://api.github.com/users/edx-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/edx-solutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx-solutions/api-integration","description":null,"fork":false,"url":"https://api.github.com/repos/edx-solutions/api-integration","forks_url":"https://api.github.com/repos/edx-solutions/api-integration/forks","keys_url":"https://api.github.com/repos/edx-solutions/api-integration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx-solutions/api-integration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx-solutions/api-integration/teams","hooks_url":"https://api.github.com/repos/edx-solutions/api-integration/hooks","issue_events_url":"https://api.github.com/repos/edx-solutions/api-integration/issues/events{/number}","events_url":"https://api.github.com/repos/edx-solutions/api-integration/events","assignees_url":"https://api.github.com/repos/edx-solutions/api-integration/assignees{/user}","branches_url":"https://api.github.com/repos/edx-solutions/api-integration/branches{/branch}","tags_url":"https://api.github.com/repos/edx-solutions/api-integration/tags","blobs_url":"https://api.github.com/repos/edx-solutions/api-integration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx-solutions/api-integration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx-solutions/api-integration/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx-solutions/api-integration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx-solutions/api-integration/statuses/{sha}","languages_url":"https://api.github.com/repos/edx-solutions/api-integration/languages","stargazers_url":"https://api.github.com/repos/edx-solutions/api-integration/stargazers","contributors_url":"https://api.github.com/repos/edx-solutions/api-integration/contributors","subscribers_url":"https://api.github.com/repos/edx-solutions/api-integration/subscribers","subscription_url":"https://api.github.com/repos/edx-solutions/api-integration/subscription","commits_url":"https://api.github.com/repos/edx-solutions/api-integration/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx-solutions/api-integration/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx-solutions/api-integration/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx-solutions/api-integration/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx-solutions/api-integration/contents/{+path}","compare_url":"https://api.github.com/repos/edx-solutions/api-integration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx-solutions/api-integration/merges","archive_url":"https://api.github.com/repos/edx-solutions/api-integration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx-solutions/api-integration/downloads","issues_url":"https://api.github.com/repos/edx-solutions/api-integration/issues{/number}","pulls_url":"https://api.github.com/repos/edx-solutions/api-integration/pulls{/number}","milestones_url":"https://api.github.com/repos/edx-solutions/api-integration/milestones{/number}","notifications_url":"https://api.github.com/repos/edx-solutions/api-integration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx-solutions/api-integration/labels{/name}","releases_url":"https://api.github.com/repos/edx-solutions/api-integration/releases{/id}","deployments_url":"https://api.github.com/repos/edx-solutions/api-integration/deployments","created_at":"2016-06-17T11:57:41Z","updated_at":"2016-06-20T11:01:55Z","pushed_at":"2017-09-19T07:37:51Z","git_url":"git://github.com/edx-solutions/api-integration.git","ssh_url":"[email protected]:edx-solutions/api-integration.git","clone_url":"https://github.com/edx-solutions/api-integration.git","svn_url":"https://github.com/edx-solutions/api-integration","homepage":null,"size":651,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"edx-solutions:master","ref":"master","sha":"5625b7de37bb8ffe032ba3521c0554ab0184e6db","user":{"login":"edx-solutions","id":6585054,"avatar_url":"https://avatars3.githubusercontent.com/u/6585054?v=4","gravatar_id":"","url":"https://api.github.com/users/edx-solutions","html_url":"https://github.com/edx-solutions","followers_url":"https://api.github.com/users/edx-solutions/followers","following_url":"https://api.github.com/users/edx-solutions/following{/other_user}","gists_url":"https://api.github.com/users/edx-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/edx-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx-solutions/subscriptions","organizations_url":"https://api.github.com/users/edx-solutions/orgs","repos_url":"https://api.github.com/users/edx-solutions/repos","events_url":"https://api.github.com/users/edx-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/edx-solutions/received_events","type":"Organization","site_admin":false},"repo":{"id":61370435,"name":"api-integration","full_name":"edx-solutions/api-integration","owner":{"login":"edx-solutions","id":6585054,"avatar_url":"https://avatars3.githubusercontent.com/u/6585054?v=4","gravatar_id":"","url":"https://api.github.com/users/edx-solutions","html_url":"https://github.com/edx-solutions","followers_url":"https://api.github.com/users/edx-solutions/followers","following_url":"https://api.github.com/users/edx-solutions/following{/other_user}","gists_url":"https://api.github.com/users/edx-solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/edx-solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx-solutions/subscriptions","organizations_url":"https://api.github.com/users/edx-solutions/orgs","repos_url":"https://api.github.com/users/edx-solutions/repos","events_url":"https://api.github.com/users/edx-solutions/events{/privacy}","received_events_url":"https://api.github.com/users/edx-solutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx-solutions/api-integration","description":null,"fork":false,"url":"https://api.github.com/repos/edx-solutions/api-integration","forks_url":"https://api.github.com/repos/edx-solutions/api-integration/forks","keys_url":"https://api.github.com/repos/edx-solutions/api-integration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx-solutions/api-integration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx-solutions/api-integration/teams","hooks_url":"https://api.github.com/repos/edx-solutions/api-integration/hooks","issue_events_url":"https://api.github.com/repos/edx-solutions/api-integration/issues/events{/number}","events_url":"https://api.github.com/repos/edx-solutions/api-integration/events","assignees_url":"https://api.github.com/repos/edx-solutions/api-integration/assignees{/user}","branches_url":"https://api.github.com/repos/edx-solutions/api-integration/branches{/branch}","tags_url":"https://api.github.com/repos/edx-solutions/api-integration/tags","blobs_url":"https://api.github.com/repos/edx-solutions/api-integration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx-solutions/api-integration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx-solutions/api-integration/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx-solutions/api-integration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx-solutions/api-integration/statuses/{sha}","languages_url":"https://api.github.com/repos/edx-solutions/api-integration/languages","stargazers_url":"https://api.github.com/repos/edx-solutions/api-integration/stargazers","contributors_url":"https://api.github.com/repos/edx-solutions/api-integration/contributors","subscribers_url":"https://api.github.com/repos/edx-solutions/api-integration/subscribers","subscription_url":"https://api.github.com/repos/edx-solutions/api-integration/subscription","commits_url":"https://api.github.com/repos/edx-solutions/api-integration/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx-solutions/api-integration/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx-solutions/api-integration/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx-solutions/api-integration/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx-solutions/api-integration/contents/{+path}","compare_url":"https://api.github.com/repos/edx-solutions/api-integration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx-solutions/api-integration/merges","archive_url":"https://api.github.com/repos/edx-solutions/api-integration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx-solutions/api-integration/downloads","issues_url":"https://api.github.com/repos/edx-solutions/api-integration/issues{/number}","pulls_url":"https://api.github.com/repos/edx-solutions/api-integration/pulls{/number}","milestones_url":"https://api.github.com/repos/edx-solutions/api-integration/milestones{/number}","notifications_url":"https://api.github.com/repos/edx-solutions/api-integration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx-solutions/api-integration/labels{/name}","releases_url":"https://api.github.com/repos/edx-solutions/api-integration/releases{/id}","deployments_url":"https://api.github.com/repos/edx-solutions/api-integration/deployments","created_at":"2016-06-17T11:57:41Z","updated_at":"2016-06-20T11:01:55Z","pushed_at":"2017-09-19T07:37:51Z","git_url":"git://github.com/edx-solutions/api-integration.git","ssh_url":"[email protected]:edx-solutions/api-integration.git","clone_url":"https://github.com/edx-solutions/api-integration.git","svn_url":"https://github.com/edx-solutions/api-integration","homepage":null,"size":651,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx-solutions/api-integration/pulls/77"},"html":{"href":"https://github.com/edx-solutions/api-integration/pull/77"},"issue":{"href":"https://api.github.com/repos/edx-solutions/api-integration/issues/77"},"comments":{"href":"https://api.github.com/repos/edx-solutions/api-integration/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/edx-solutions/api-integration/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/edx-solutions/api-integration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx-solutions/api-integration/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/edx-solutions/api-integration/statuses/ab958ab4f22f6d38f5a958a31984bbe97537aff5"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 61370435,
"name": "edx-solutions/api-integration",
"url": "https://api.github.com/repos/edx-solutions/api-integration"
}
|
{
"id": 434995,
"login": "ziafazal",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/434995?",
"url": "https://api.github.com/users/ziafazal"
}
|
{
"id": 6585054,
"login": "edx-solutions",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6585054?",
"url": "https://api.github.com/orgs/edx-solutions"
}
| 2017-09-19T09:10:20 |
6608025825
|
{"actor":{"display_login":"ziafazal"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/elifesciences/lax/pulls/comments/102341006","pull_request_review_id":23094757,"id":102341006,"diff_hunk":"@@ -310,30 +316,58 @@ def setUp(self):\n self.assertTrue(fragments.merge_if_valid(self.av))\n \n self.c = Client()\n+ self.ac = Client(**{\n+ mware.CGROUPS: 'admin',\n+ })\n \n def test_add_fragment(self):\n \"a POST request can be sent that adds an article fragment\"\n key = 'test-frag'\n url = reverse('v2:article-fragment', kwargs={'art_id': self.msid, 'fragment_id': key})\n- fragment = {'title': 'pants-party'}","path":"src/publisher/tests/test_api_v2_views.py","position":64,"original_position":64,"commit_id":"bbefcd0510f7b58dff65b32fa797dbd04ec91edf","original_commit_id":"bbefcd0510f7b58dff65b32fa797dbd04ec91edf","user":{"login":"lsh-0","id":2142748,"avatar_url":"https://avatars.githubusercontent.com/u/2142748?v=3","gravatar_id":"","url":"https://api.github.com/users/lsh-0","html_url":"https://github.com/lsh-0","followers_url":"https://api.github.com/users/lsh-0/followers","following_url":"https://api.github.com/users/lsh-0/following{/other_user}","gists_url":"https://api.github.com/users/lsh-0/gists{/gist_id}","starred_url":"https://api.github.com/users/lsh-0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsh-0/subscriptions","organizations_url":"https://api.github.com/users/lsh-0/orgs","repos_url":"https://api.github.com/users/lsh-0/repos","events_url":"https://api.github.com/users/lsh-0/events{/privacy}","received_events_url":"https://api.github.com/users/lsh-0/received_events","type":"User","site_admin":false},"body":"you don't like the `pants-party` ? heh. an old boss used that as his 'foobar'. I have no idea what it means, but it's something that keeps on being funny to me","created_at":"2017-02-21T22:56:20Z","updated_at":"2017-02-21T22:56:21Z","html_url":"https://github.com/elifesciences/lax/pull/78#discussion_r102341006","pull_request_url":"https://api.github.com/repos/elifesciences/lax/pulls/78","_links":{"self":{"href":"https://api.github.com/repos/elifesciences/lax/pulls/comments/102341006"},"html":{"href":"https://github.com/elifesciences/lax/pull/78#discussion_r102341006"},"pull_request":{"href":"https://api.github.com/repos/elifesciences/lax/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/elifesciences/lax/pulls/78","id":105192409,"html_url":"https://github.com/elifesciences/lax/pull/78","diff_url":"https://github.com/elifesciences/lax/pull/78.diff","patch_url":"https://github.com/elifesciences/lax/pull/78.patch","issue_url":"https://api.github.com/repos/elifesciences/lax/issues/78","number":78,"state":"closed","locked":false,"title":"Actually saving the new article JSON when adding a fragment through the API","user":{"login":"giorgiosironi","id":160299,"avatar_url":"https://avatars.githubusercontent.com/u/160299?v=3","gravatar_id":"","url":"https://api.github.com/users/giorgiosironi","html_url":"https://github.com/giorgiosironi","followers_url":"https://api.github.com/users/giorgiosironi/followers","following_url":"https://api.github.com/users/giorgiosironi/following{/other_user}","gists_url":"https://api.github.com/users/giorgiosironi/gists{/gist_id}","starred_url":"https://api.github.com/users/giorgiosironi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giorgiosironi/subscriptions","organizations_url":"https://api.github.com/users/giorgiosironi/orgs","repos_url":"https://api.github.com/users/giorgiosironi/repos","events_url":"https://api.github.com/users/giorgiosironi/events{/privacy}","received_events_url":"https://api.github.com/users/giorgiosironi/received_events","type":"User","site_admin":false},"body":"Updates all versions of an article.","created_at":"2017-02-08T10:54:55Z","updated_at":"2017-02-21T22:56:21Z","closed_at":"2017-02-08T15:31:06Z","merged_at":"2017-02-08T15:31:06Z","merge_commit_sha":"834256102e697a231c47993a01ebd482a1e973a0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elifesciences/lax/pulls/78/commits","review_comments_url":"https://api.github.com/repos/elifesciences/lax/pulls/78/comments","review_comment_url":"https://api.github.com/repos/elifesciences/lax/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elifesciences/lax/issues/78/comments","statuses_url":"https://api.github.com/repos/elifesciences/lax/statuses/bbefcd0510f7b58dff65b32fa797dbd04ec91edf","head":{"label":"elifesciences:striking_image_api","ref":"striking_image_api","sha":"bbefcd0510f7b58dff65b32fa797dbd04ec91edf","user":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars.githubusercontent.com/u/1777367?v=3","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":38447230,"name":"lax","full_name":"elifesciences/lax","owner":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars.githubusercontent.com/u/1777367?v=3","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elifesciences/lax","description":null,"fork":false,"url":"https://api.github.com/repos/elifesciences/lax","forks_url":"https://api.github.com/repos/elifesciences/lax/forks","keys_url":"https://api.github.com/repos/elifesciences/lax/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/lax/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/lax/teams","hooks_url":"https://api.github.com/repos/elifesciences/lax/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/lax/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/lax/events","assignees_url":"https://api.github.com/repos/elifesciences/lax/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/lax/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/lax/tags","blobs_url":"https://api.github.com/repos/elifesciences/lax/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/lax/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/lax/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/lax/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/lax/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/lax/languages","stargazers_url":"https://api.github.com/repos/elifesciences/lax/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/lax/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/lax/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/lax/subscription","commits_url":"https://api.github.com/repos/elifesciences/lax/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/lax/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/lax/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/lax/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/lax/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/lax/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/lax/merges","archive_url":"https://api.github.com/repos/elifesciences/lax/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/lax/downloads","issues_url":"https://api.github.com/repos/elifesciences/lax/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/lax/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/lax/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/lax/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/lax/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/lax/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/lax/deployments","created_at":"2015-07-02T17:35:26Z","updated_at":"2017-01-22T20:00:46Z","pushed_at":"2017-02-21T21:07:51Z","git_url":"git://github.com/elifesciences/lax.git","ssh_url":"[email protected]:elifesciences/lax.git","clone_url":"https://github.com/elifesciences/lax.git","svn_url":"https://github.com/elifesciences/lax","homepage":null,"size":1596,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"elifesciences:develop","ref":"develop","sha":"2107dfcdc472d0fe85cb702788f0bce139906fef","user":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars.githubusercontent.com/u/1777367?v=3","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":38447230,"name":"lax","full_name":"elifesciences/lax","owner":{"login":"elifesciences","id":1777367,"avatar_url":"https://avatars.githubusercontent.com/u/1777367?v=3","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elifesciences/lax","description":null,"fork":false,"url":"https://api.github.com/repos/elifesciences/lax","forks_url":"https://api.github.com/repos/elifesciences/lax/forks","keys_url":"https://api.github.com/repos/elifesciences/lax/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/lax/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/lax/teams","hooks_url":"https://api.github.com/repos/elifesciences/lax/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/lax/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/lax/events","assignees_url":"https://api.github.com/repos/elifesciences/lax/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/lax/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/lax/tags","blobs_url":"https://api.github.com/repos/elifesciences/lax/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/lax/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/lax/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/lax/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/lax/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/lax/languages","stargazers_url":"https://api.github.com/repos/elifesciences/lax/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/lax/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/lax/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/lax/subscription","commits_url":"https://api.github.com/repos/elifesciences/lax/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/lax/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/lax/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/lax/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/lax/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/lax/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/lax/merges","archive_url":"https://api.github.com/repos/elifesciences/lax/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/lax/downloads","issues_url":"https://api.github.com/repos/elifesciences/lax/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/lax/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/lax/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/lax/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/lax/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/lax/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/lax/deployments","created_at":"2015-07-02T17:35:26Z","updated_at":"2017-01-22T20:00:46Z","pushed_at":"2017-02-21T21:07:51Z","git_url":"git://github.com/elifesciences/lax.git","ssh_url":"[email protected]:elifesciences/lax.git","clone_url":"https://github.com/elifesciences/lax.git","svn_url":"https://github.com/elifesciences/lax","homepage":null,"size":1596,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/elifesciences/lax/pulls/78"},"html":{"href":"https://github.com/elifesciences/lax/pull/78"},"issue":{"href":"https://api.github.com/repos/elifesciences/lax/issues/78"},"comments":{"href":"https://api.github.com/repos/elifesciences/lax/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/elifesciences/lax/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/elifesciences/lax/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elifesciences/lax/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/elifesciences/lax/statuses/bbefcd0510f7b58dff65b32fa797dbd04ec91edf"}}}}
|
{
"id": 38447230,
"name": "elifesciences/lax",
"url": "https://api.github.com/repos/elifesciences/lax"
}
|
{
"id": 2142748,
"login": "lsh-0",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2142748?",
"url": "https://api.github.com/users/lsh-0"
}
|
{
"id": 1777367,
"login": "elifesciences",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1777367?",
"url": "https://api.github.com/orgs/elifesciences"
}
| 2017-02-21T22:56:20 |
5366100994
|
{"actor":{"display_login":"lsh-0"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/pulls/comments/95854498","pull_request_review_id":16423111,"id":95854498,"diff_hunk":"@@ -34,5 +46,7 @@ Record your responses inside the fenced code blocks below each question.\n pass it data?\n \n ```html\n- <!-- your response here -->\n+ {{each contact.phone as |phone|}}\n+ {{my-contact phone=phone}}","path":"diagnostic.md","position":50,"original_position":50,"commit_id":"e5b5ef17174d06c4ff89e9ec1f01dc3ba14ad109","original_commit_id":"e5b5ef17174d06c4ff89e9ec1f01dc3ba14ad109","user":{"login":"raq929","id":13922520,"avatar_url":"https://avatars.githubusercontent.com/u/13922520?v=3","gravatar_id":"","url":"https://api.github.com/users/raq929","html_url":"https://github.com/raq929","followers_url":"https://api.github.com/users/raq929/followers","following_url":"https://api.github.com/users/raq929/following{/other_user}","gists_url":"https://api.github.com/users/raq929/gists{/gist_id}","starred_url":"https://api.github.com/users/raq929/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raq929/subscriptions","organizations_url":"https://api.github.com/users/raq929/orgs","repos_url":"https://api.github.com/users/raq929/repos","events_url":"https://api.github.com/users/raq929/events{/privacy}","received_events_url":"https://api.github.com/users/raq929/received_events","type":"User","site_admin":false},"body":"This line should be:\r\n`{{my-phone phone=phone}}`\r\n\r\nIt seems clear that you're understanding the concept, though.\r\n\r\n.5/1","created_at":"2017-01-12T18:32:15Z","updated_at":"2017-01-12T18:32:36Z","html_url":"https://github.com/ga-wdi-boston/ember-components-diagnostic/pull/83#discussion_r95854498","pull_request_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/pulls/comments/95854498"},"html":{"href":"https://github.com/ga-wdi-boston/ember-components-diagnostic/pull/83#discussion_r95854498"},"pull_request":{"href":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/pulls/83","id":101073861,"html_url":"https://github.com/ga-wdi-boston/ember-components-diagnostic/pull/83","diff_url":"https://github.com/ga-wdi-boston/ember-components-diagnostic/pull/83.diff","patch_url":"https://github.com/ga-wdi-boston/ember-components-diagnostic/pull/83.patch","issue_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/issues/83","number":83,"state":"open","locked":false,"title":"Answer questions in diagnostic","user":{"login":"akradin","id":22475825,"avatar_url":"https://avatars.githubusercontent.com/u/22475825?v=3","gravatar_id":"","url":"https://api.github.com/users/akradin","html_url":"https://github.com/akradin","followers_url":"https://api.github.com/users/akradin/followers","following_url":"https://api.github.com/users/akradin/following{/other_user}","gists_url":"https://api.github.com/users/akradin/gists{/gist_id}","starred_url":"https://api.github.com/users/akradin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akradin/subscriptions","organizations_url":"https://api.github.com/users/akradin/orgs","repos_url":"https://api.github.com/users/akradin/repos","events_url":"https://api.github.com/users/akradin/events{/privacy}","received_events_url":"https://api.github.com/users/akradin/received_events","type":"User","site_admin":false},"body":"comfort/clarity: 3/3\r\nUsed class repos","created_at":"2017-01-11T14:15:53Z","updated_at":"2017-01-12T18:32:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01e5671742df1c989d22067466aa9075a6938eba","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/pulls/83/commits","review_comments_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/pulls/83/comments","review_comment_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/issues/83/comments","statuses_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/statuses/e5b5ef17174d06c4ff89e9ec1f01dc3ba14ad109","head":{"label":"akradin:response","ref":"response","sha":"e5b5ef17174d06c4ff89e9ec1f01dc3ba14ad109","user":{"login":"akradin","id":22475825,"avatar_url":"https://avatars.githubusercontent.com/u/22475825?v=3","gravatar_id":"","url":"https://api.github.com/users/akradin","html_url":"https://github.com/akradin","followers_url":"https://api.github.com/users/akradin/followers","following_url":"https://api.github.com/users/akradin/following{/other_user}","gists_url":"https://api.github.com/users/akradin/gists{/gist_id}","starred_url":"https://api.github.com/users/akradin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akradin/subscriptions","organizations_url":"https://api.github.com/users/akradin/orgs","repos_url":"https://api.github.com/users/akradin/repos","events_url":"https://api.github.com/users/akradin/events{/privacy}","received_events_url":"https://api.github.com/users/akradin/received_events","type":"User","site_admin":false},"repo":{"id":78644340,"name":"ember-components-diagnostic","full_name":"akradin/ember-components-diagnostic","owner":{"login":"akradin","id":22475825,"avatar_url":"https://avatars.githubusercontent.com/u/22475825?v=3","gravatar_id":"","url":"https://api.github.com/users/akradin","html_url":"https://github.com/akradin","followers_url":"https://api.github.com/users/akradin/followers","following_url":"https://api.github.com/users/akradin/following{/other_user}","gists_url":"https://api.github.com/users/akradin/gists{/gist_id}","starred_url":"https://api.github.com/users/akradin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akradin/subscriptions","organizations_url":"https://api.github.com/users/akradin/orgs","repos_url":"https://api.github.com/users/akradin/repos","events_url":"https://api.github.com/users/akradin/events{/privacy}","received_events_url":"https://api.github.com/users/akradin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akradin/ember-components-diagnostic","description":null,"fork":true,"url":"https://api.github.com/repos/akradin/ember-components-diagnostic","forks_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/forks","keys_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/teams","hooks_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/hooks","issue_events_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/issues/events{/number}","events_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/events","assignees_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/assignees{/user}","branches_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/branches{/branch}","tags_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/tags","blobs_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/git/refs{/sha}","trees_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/statuses/{sha}","languages_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/languages","stargazers_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/stargazers","contributors_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/contributors","subscribers_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/subscribers","subscription_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/subscription","commits_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/commits{/sha}","git_commits_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/git/commits{/sha}","comments_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/comments{/number}","issue_comment_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/issues/comments{/number}","contents_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/contents/{+path}","compare_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/merges","archive_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/downloads","issues_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/issues{/number}","pulls_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/pulls{/number}","milestones_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/milestones{/number}","notifications_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/labels{/name}","releases_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/releases{/id}","deployments_url":"https://api.github.com/repos/akradin/ember-components-diagnostic/deployments","created_at":"2017-01-11T14:00:59Z","updated_at":"2016-03-20T23:47:46Z","pushed_at":"2017-01-11T14:15:37Z","git_url":"git://github.com/akradin/ember-components-diagnostic.git","ssh_url":"[email protected]:akradin/ember-components-diagnostic.git","clone_url":"https://github.com/akradin/ember-components-diagnostic.git","svn_url":"https://github.com/akradin/ember-components-diagnostic","homepage":null,"size":28,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ga-wdi-boston:master","ref":"master","sha":"275407a1a95f07f62361d3342705cace0848ca27","user":{"login":"ga-wdi-boston","id":6361298,"avatar_url":"https://avatars.githubusercontent.com/u/6361298?v=3","gravatar_id":"","url":"https://api.github.com/users/ga-wdi-boston","html_url":"https://github.com/ga-wdi-boston","followers_url":"https://api.github.com/users/ga-wdi-boston/followers","following_url":"https://api.github.com/users/ga-wdi-boston/following{/other_user}","gists_url":"https://api.github.com/users/ga-wdi-boston/gists{/gist_id}","starred_url":"https://api.github.com/users/ga-wdi-boston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ga-wdi-boston/subscriptions","organizations_url":"https://api.github.com/users/ga-wdi-boston/orgs","repos_url":"https://api.github.com/users/ga-wdi-boston/repos","events_url":"https://api.github.com/users/ga-wdi-boston/events{/privacy}","received_events_url":"https://api.github.com/users/ga-wdi-boston/received_events","type":"Organization","site_admin":false},"repo":{"id":54346716,"name":"ember-components-diagnostic","full_name":"ga-wdi-boston/ember-components-diagnostic","owner":{"login":"ga-wdi-boston","id":6361298,"avatar_url":"https://avatars.githubusercontent.com/u/6361298?v=3","gravatar_id":"","url":"https://api.github.com/users/ga-wdi-boston","html_url":"https://github.com/ga-wdi-boston","followers_url":"https://api.github.com/users/ga-wdi-boston/followers","following_url":"https://api.github.com/users/ga-wdi-boston/following{/other_user}","gists_url":"https://api.github.com/users/ga-wdi-boston/gists{/gist_id}","starred_url":"https://api.github.com/users/ga-wdi-boston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ga-wdi-boston/subscriptions","organizations_url":"https://api.github.com/users/ga-wdi-boston/orgs","repos_url":"https://api.github.com/users/ga-wdi-boston/repos","events_url":"https://api.github.com/users/ga-wdi-boston/events{/privacy}","received_events_url":"https://api.github.com/users/ga-wdi-boston/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ga-wdi-boston/ember-components-diagnostic","description":null,"fork":false,"url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic","forks_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/forks","keys_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/teams","hooks_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/hooks","issue_events_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/issues/events{/number}","events_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/events","assignees_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/assignees{/user}","branches_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/branches{/branch}","tags_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/tags","blobs_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/git/refs{/sha}","trees_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/statuses/{sha}","languages_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/languages","stargazers_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/stargazers","contributors_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/contributors","subscribers_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/subscribers","subscription_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/subscription","commits_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/commits{/sha}","git_commits_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/git/commits{/sha}","comments_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/comments{/number}","issue_comment_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/issues/comments{/number}","contents_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/contents/{+path}","compare_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/merges","archive_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/downloads","issues_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/issues{/number}","pulls_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/pulls{/number}","milestones_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/milestones{/number}","notifications_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/labels{/name}","releases_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/releases{/id}","deployments_url":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/deployments","created_at":"2016-03-20T23:47:46Z","updated_at":"2016-03-20T23:47:46Z","pushed_at":"2017-01-11T14:29:33Z","git_url":"git://github.com/ga-wdi-boston/ember-components-diagnostic.git","ssh_url":"[email protected]:ga-wdi-boston/ember-components-diagnostic.git","clone_url":"https://github.com/ga-wdi-boston/ember-components-diagnostic.git","svn_url":"https://github.com/ga-wdi-boston/ember-components-diagnostic","homepage":null,"size":101,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":91,"mirror_url":null,"open_issues_count":23,"forks":91,"open_issues":23,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/pulls/83"},"html":{"href":"https://github.com/ga-wdi-boston/ember-components-diagnostic/pull/83"},"issue":{"href":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/issues/83"},"comments":{"href":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic/statuses/e5b5ef17174d06c4ff89e9ec1f01dc3ba14ad109"}}}}
|
{
"id": 54346716,
"name": "ga-wdi-boston/ember-components-diagnostic",
"url": "https://api.github.com/repos/ga-wdi-boston/ember-components-diagnostic"
}
|
{
"id": 13922520,
"login": "raq929",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13922520?",
"url": "https://api.github.com/users/raq929"
}
|
{
"id": 6361298,
"login": "ga-wdi-boston",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6361298?",
"url": "https://api.github.com/orgs/ga-wdi-boston"
}
| 2017-01-12T18:32:15 |
5144397701
|
{"actor":{"display_login":"raq929"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/pulls/comments/110455727","pull_request_review_id":31634706,"id":110455727,"diff_hunk":"@@ -58,13 +64,16 @@ Suppose you want to define a mixin named `row` stored in `./row.scss`. Write the\n code to import the mixin definition in the current module.\n \n ```scss\n-// your response here\n+@import 'row';\n ```\n \n Now that the mixin is imported, let's use it. This mixin doesn't take any\n arguments. Write the code to include the mixin inside all elements with a\n class of `content`.\n \n ```scss\n-// your response here\n+.content {\n+ @include row();\n+\n+}","path":"diagnostic.md","position":67,"original_position":67,"commit_id":"ea539c703d048316e27004c00ac1ab62aeab12c8","original_commit_id":"ea539c703d048316e27004c00ac1ab62aeab12c8","user":{"login":"Jcornmanhomonoff","id":17557070,"avatar_url":"https://avatars1.githubusercontent.com/u/17557070?v=3","gravatar_id":"","url":"https://api.github.com/users/Jcornmanhomonoff","html_url":"https://github.com/Jcornmanhomonoff","followers_url":"https://api.github.com/users/Jcornmanhomonoff/followers","following_url":"https://api.github.com/users/Jcornmanhomonoff/following{/other_user}","gists_url":"https://api.github.com/users/Jcornmanhomonoff/gists{/gist_id}","starred_url":"https://api.github.com/users/Jcornmanhomonoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jcornmanhomonoff/subscriptions","organizations_url":"https://api.github.com/users/Jcornmanhomonoff/orgs","repos_url":"https://api.github.com/users/Jcornmanhomonoff/repos","events_url":"https://api.github.com/users/Jcornmanhomonoff/events{/privacy}","received_events_url":"https://api.github.com/users/Jcornmanhomonoff/received_events","type":"User","site_admin":false},"body":"```\r\n.content {\r\n @include row;\r\n}\r\n```","created_at":"2017-04-07T18:40:45Z","updated_at":"2017-04-07T18:40:45Z","html_url":"https://github.com/ga-wdi-boston/html-css-sass-diagnostic/pull/130#discussion_r110455727","pull_request_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/pulls/130","_links":{"self":{"href":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/pulls/comments/110455727"},"html":{"href":"https://github.com/ga-wdi-boston/html-css-sass-diagnostic/pull/130#discussion_r110455727"},"pull_request":{"href":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/pulls/130"}}},"pull_request":{"url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/pulls/130","id":114374736,"html_url":"https://github.com/ga-wdi-boston/html-css-sass-diagnostic/pull/130","diff_url":"https://github.com/ga-wdi-boston/html-css-sass-diagnostic/pull/130.diff","patch_url":"https://github.com/ga-wdi-boston/html-css-sass-diagnostic/pull/130.patch","issue_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/issues/130","number":130,"state":"open","locked":false,"title":"Response to html-css-sass diagnostic","user":{"login":"vanduong28","id":26147830,"avatar_url":"https://avatars1.githubusercontent.com/u/26147830?v=3","gravatar_id":"","url":"https://api.github.com/users/vanduong28","html_url":"https://github.com/vanduong28","followers_url":"https://api.github.com/users/vanduong28/followers","following_url":"https://api.github.com/users/vanduong28/following{/other_user}","gists_url":"https://api.github.com/users/vanduong28/gists{/gist_id}","starred_url":"https://api.github.com/users/vanduong28/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanduong28/subscriptions","organizations_url":"https://api.github.com/users/vanduong28/orgs","repos_url":"https://api.github.com/users/vanduong28/repos","events_url":"https://api.github.com/users/vanduong28/events{/privacy}","received_events_url":"https://api.github.com/users/vanduong28/received_events","type":"User","site_admin":false},"body":"Response to questions related to html-css-sass\r\n\r\nComfort: 4\r\nClarity: 4\r\n\r\nI referenced my code notes from yesterday's lesson as well as Google.","created_at":"2017-04-05T13:21:42Z","updated_at":"2017-04-07T18:40:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75e67da309aff237e0171c0dfbd10882299d3dcd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/pulls/130/commits","review_comments_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/pulls/130/comments","review_comment_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/issues/130/comments","statuses_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/statuses/ea539c703d048316e27004c00ac1ab62aeab12c8","head":{"label":"vanduong28:response","ref":"response","sha":"ea539c703d048316e27004c00ac1ab62aeab12c8","user":{"login":"vanduong28","id":26147830,"avatar_url":"https://avatars1.githubusercontent.com/u/26147830?v=3","gravatar_id":"","url":"https://api.github.com/users/vanduong28","html_url":"https://github.com/vanduong28","followers_url":"https://api.github.com/users/vanduong28/followers","following_url":"https://api.github.com/users/vanduong28/following{/other_user}","gists_url":"https://api.github.com/users/vanduong28/gists{/gist_id}","starred_url":"https://api.github.com/users/vanduong28/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanduong28/subscriptions","organizations_url":"https://api.github.com/users/vanduong28/orgs","repos_url":"https://api.github.com/users/vanduong28/repos","events_url":"https://api.github.com/users/vanduong28/events{/privacy}","received_events_url":"https://api.github.com/users/vanduong28/received_events","type":"User","site_admin":false},"repo":{"id":87309798,"name":"html-css-sass-diagnostic","full_name":"vanduong28/html-css-sass-diagnostic","owner":{"login":"vanduong28","id":26147830,"avatar_url":"https://avatars1.githubusercontent.com/u/26147830?v=3","gravatar_id":"","url":"https://api.github.com/users/vanduong28","html_url":"https://github.com/vanduong28","followers_url":"https://api.github.com/users/vanduong28/followers","following_url":"https://api.github.com/users/vanduong28/following{/other_user}","gists_url":"https://api.github.com/users/vanduong28/gists{/gist_id}","starred_url":"https://api.github.com/users/vanduong28/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanduong28/subscriptions","organizations_url":"https://api.github.com/users/vanduong28/orgs","repos_url":"https://api.github.com/users/vanduong28/repos","events_url":"https://api.github.com/users/vanduong28/events{/privacy}","received_events_url":"https://api.github.com/users/vanduong28/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vanduong28/html-css-sass-diagnostic","description":null,"fork":true,"url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic","forks_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/forks","keys_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/teams","hooks_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/hooks","issue_events_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/issues/events{/number}","events_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/events","assignees_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/assignees{/user}","branches_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/branches{/branch}","tags_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/tags","blobs_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/statuses/{sha}","languages_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/languages","stargazers_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/stargazers","contributors_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/contributors","subscribers_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/subscribers","subscription_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/subscription","commits_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/contents/{+path}","compare_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/merges","archive_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/downloads","issues_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/issues{/number}","pulls_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/pulls{/number}","milestones_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/milestones{/number}","notifications_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/labels{/name}","releases_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/releases{/id}","deployments_url":"https://api.github.com/repos/vanduong28/html-css-sass-diagnostic/deployments","created_at":"2017-04-05T13:00:55Z","updated_at":"2016-01-21T17:10:24Z","pushed_at":"2017-04-05T13:21:06Z","git_url":"git://github.com/vanduong28/html-css-sass-diagnostic.git","ssh_url":"[email protected]:vanduong28/html-css-sass-diagnostic.git","clone_url":"https://github.com/vanduong28/html-css-sass-diagnostic.git","svn_url":"https://github.com/vanduong28/html-css-sass-diagnostic","homepage":null,"size":25,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ga-wdi-boston:master","ref":"master","sha":"6d2e1767a32118bc28dc357719e10faaa691b600","user":{"login":"ga-wdi-boston","id":6361298,"avatar_url":"https://avatars0.githubusercontent.com/u/6361298?v=3","gravatar_id":"","url":"https://api.github.com/users/ga-wdi-boston","html_url":"https://github.com/ga-wdi-boston","followers_url":"https://api.github.com/users/ga-wdi-boston/followers","following_url":"https://api.github.com/users/ga-wdi-boston/following{/other_user}","gists_url":"https://api.github.com/users/ga-wdi-boston/gists{/gist_id}","starred_url":"https://api.github.com/users/ga-wdi-boston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ga-wdi-boston/subscriptions","organizations_url":"https://api.github.com/users/ga-wdi-boston/orgs","repos_url":"https://api.github.com/users/ga-wdi-boston/repos","events_url":"https://api.github.com/users/ga-wdi-boston/events{/privacy}","received_events_url":"https://api.github.com/users/ga-wdi-boston/received_events","type":"Organization","site_admin":false},"repo":{"id":50123038,"name":"html-css-sass-diagnostic","full_name":"ga-wdi-boston/html-css-sass-diagnostic","owner":{"login":"ga-wdi-boston","id":6361298,"avatar_url":"https://avatars0.githubusercontent.com/u/6361298?v=3","gravatar_id":"","url":"https://api.github.com/users/ga-wdi-boston","html_url":"https://github.com/ga-wdi-boston","followers_url":"https://api.github.com/users/ga-wdi-boston/followers","following_url":"https://api.github.com/users/ga-wdi-boston/following{/other_user}","gists_url":"https://api.github.com/users/ga-wdi-boston/gists{/gist_id}","starred_url":"https://api.github.com/users/ga-wdi-boston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ga-wdi-boston/subscriptions","organizations_url":"https://api.github.com/users/ga-wdi-boston/orgs","repos_url":"https://api.github.com/users/ga-wdi-boston/repos","events_url":"https://api.github.com/users/ga-wdi-boston/events{/privacy}","received_events_url":"https://api.github.com/users/ga-wdi-boston/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ga-wdi-boston/html-css-sass-diagnostic","description":null,"fork":false,"url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic","forks_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/forks","keys_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/teams","hooks_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/hooks","issue_events_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/issues/events{/number}","events_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/events","assignees_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/assignees{/user}","branches_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/branches{/branch}","tags_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/tags","blobs_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/git/refs{/sha}","trees_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/statuses/{sha}","languages_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/languages","stargazers_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/stargazers","contributors_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/contributors","subscribers_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/subscribers","subscription_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/subscription","commits_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/commits{/sha}","git_commits_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/git/commits{/sha}","comments_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/comments{/number}","issue_comment_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/issues/comments{/number}","contents_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/contents/{+path}","compare_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/merges","archive_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/downloads","issues_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/issues{/number}","pulls_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/pulls{/number}","milestones_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/milestones{/number}","notifications_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/labels{/name}","releases_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/releases{/id}","deployments_url":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/deployments","created_at":"2016-01-21T17:10:24Z","updated_at":"2016-01-21T17:10:24Z","pushed_at":"2017-04-05T13:43:08Z","git_url":"git://github.com/ga-wdi-boston/html-css-sass-diagnostic.git","ssh_url":"[email protected]:ga-wdi-boston/html-css-sass-diagnostic.git","clone_url":"https://github.com/ga-wdi-boston/html-css-sass-diagnostic.git","svn_url":"https://github.com/ga-wdi-boston/html-css-sass-diagnostic","homepage":null,"size":24,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":135,"mirror_url":null,"open_issues_count":16,"forks":135,"open_issues":16,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/pulls/130"},"html":{"href":"https://github.com/ga-wdi-boston/html-css-sass-diagnostic/pull/130"},"issue":{"href":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/issues/130"},"comments":{"href":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic/statuses/ea539c703d048316e27004c00ac1ab62aeab12c8"}}}}
|
{
"id": 50123038,
"name": "ga-wdi-boston/html-css-sass-diagnostic",
"url": "https://api.github.com/repos/ga-wdi-boston/html-css-sass-diagnostic"
}
|
{
"id": 17557070,
"login": "Jcornmanhomonoff",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17557070?",
"url": "https://api.github.com/users/Jcornmanhomonoff"
}
|
{
"id": 6361298,
"login": "ga-wdi-boston",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6361298?",
"url": "https://api.github.com/orgs/ga-wdi-boston"
}
| 2017-04-07T18:40:45 |
5649127279
|
{"actor":{"display_login":"Jcornmanhomonoff"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/pulls/comments/152115484","pull_request_review_id":77927881,"id":152115484,"diff_hunk":"@@ -1,6 +1,5 @@\n-#Wed Jul 26 22:23:04 PDT 2017\n distributionBase=GRADLE_USER_HOME\n distributionPath=wrapper/dists\n zipStoreBase=GRADLE_USER_HOME\n zipStorePath=wrapper/dists\n-distributionUrl=https\\://services.gradle.org/distributions/gradle-3.3-all.zip\n+distributionUrl=https\\://services.gradle.org/distributions/gradle-4.1-bin.zip","path":"tutorial01_load_vulkan/gradle/wrapper/gradle-wrapper.properties","position":7,"original_position":7,"commit_id":"f3a6f39edec20f6758d5acf2ebf664dcf55bcedd","original_commit_id":"f3a6f39edec20f6758d5acf2ebf664dcf55bcedd","user":{"login":"ggfan","id":10564521,"avatar_url":"https://avatars3.githubusercontent.com/u/10564521?v=4","gravatar_id":"","url":"https://api.github.com/users/ggfan","html_url":"https://github.com/ggfan","followers_url":"https://api.github.com/users/ggfan/followers","following_url":"https://api.github.com/users/ggfan/following{/other_user}","gists_url":"https://api.github.com/users/ggfan/gists{/gist_id}","starred_url":"https://api.github.com/users/ggfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggfan/subscriptions","organizations_url":"https://api.github.com/users/ggfan/orgs","repos_url":"https://api.github.com/users/ggfan/repos","events_url":"https://api.github.com/users/ggfan/events{/privacy}","received_events_url":"https://api.github.com/users/ggfan/received_events","type":"User","site_admin":false},"body":"either way works, I will change it back to all ( bin type is smaller for download )","created_at":"2017-11-20T21:26:07Z","updated_at":"2017-11-20T21:26:07Z","html_url":"https://github.com/googlesamples/android-vulkan-tutorials/pull/41#discussion_r152115484","pull_request_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/pulls/41","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/pulls/comments/152115484"},"html":{"href":"https://github.com/googlesamples/android-vulkan-tutorials/pull/41#discussion_r152115484"},"pull_request":{"href":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/pulls/41"}},"in_reply_to_id":152106088},"pull_request":{"url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/pulls/41","id":153701006,"html_url":"https://github.com/googlesamples/android-vulkan-tutorials/pull/41","diff_url":"https://github.com/googlesamples/android-vulkan-tutorials/pull/41.diff","patch_url":"https://github.com/googlesamples/android-vulkan-tutorials/pull/41.patch","issue_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/issues/41","number":41,"state":"open","locked":false,"title":"Update build script to Android Studio 3.0.0","user":{"login":"ggfan","id":10564521,"avatar_url":"https://avatars3.githubusercontent.com/u/10564521?v=4","gravatar_id":"","url":"https://api.github.com/users/ggfan","html_url":"https://github.com/ggfan","followers_url":"https://api.github.com/users/ggfan/followers","following_url":"https://api.github.com/users/ggfan/following{/other_user}","gists_url":"https://api.github.com/users/ggfan/gists{/gist_id}","starred_url":"https://api.github.com/users/ggfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggfan/subscriptions","organizations_url":"https://api.github.com/users/ggfan/orgs","repos_url":"https://api.github.com/users/ggfan/repos","events_url":"https://api.github.com/users/ggfan/events{/privacy}","received_events_url":"https://api.github.com/users/ggfan/received_events","type":"User","site_admin":false},"body":"Update the android build tool version to 3.0.0 according to:\r\n https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration.html\r\n","created_at":"2017-11-20T18:22:53Z","updated_at":"2017-11-20T21:26:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8edead69965ec2162e06fa12aa9affdd0ccc49e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/pulls/41/commits","review_comments_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/pulls/41/comments","review_comment_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/issues/41/comments","statuses_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/statuses/f3a6f39edec20f6758d5acf2ebf664dcf55bcedd","head":{"label":"googlesamples:update-as-3.0","ref":"update-as-3.0","sha":"f3a6f39edec20f6758d5acf2ebf664dcf55bcedd","user":{"login":"googlesamples","id":7378196,"avatar_url":"https://avatars3.githubusercontent.com/u/7378196?v=4","gravatar_id":"","url":"https://api.github.com/users/googlesamples","html_url":"https://github.com/googlesamples","followers_url":"https://api.github.com/users/googlesamples/followers","following_url":"https://api.github.com/users/googlesamples/following{/other_user}","gists_url":"https://api.github.com/users/googlesamples/gists{/gist_id}","starred_url":"https://api.github.com/users/googlesamples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlesamples/subscriptions","organizations_url":"https://api.github.com/users/googlesamples/orgs","repos_url":"https://api.github.com/users/googlesamples/repos","events_url":"https://api.github.com/users/googlesamples/events{/privacy}","received_events_url":"https://api.github.com/users/googlesamples/received_events","type":"Organization","site_admin":false},"repo":{"id":53032527,"name":"android-vulkan-tutorials","full_name":"googlesamples/android-vulkan-tutorials","owner":{"login":"googlesamples","id":7378196,"avatar_url":"https://avatars3.githubusercontent.com/u/7378196?v=4","gravatar_id":"","url":"https://api.github.com/users/googlesamples","html_url":"https://github.com/googlesamples","followers_url":"https://api.github.com/users/googlesamples/followers","following_url":"https://api.github.com/users/googlesamples/following{/other_user}","gists_url":"https://api.github.com/users/googlesamples/gists{/gist_id}","starred_url":"https://api.github.com/users/googlesamples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlesamples/subscriptions","organizations_url":"https://api.github.com/users/googlesamples/orgs","repos_url":"https://api.github.com/users/googlesamples/repos","events_url":"https://api.github.com/users/googlesamples/events{/privacy}","received_events_url":"https://api.github.com/users/googlesamples/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlesamples/android-vulkan-tutorials","description":"A set of samples to illustrate Vulkan API on Android","fork":false,"url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials","forks_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/forks","keys_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/teams","hooks_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/hooks","issue_events_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/issues/events{/number}","events_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/events","assignees_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/assignees{/user}","branches_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/branches{/branch}","tags_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/tags","blobs_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/statuses/{sha}","languages_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/languages","stargazers_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/stargazers","contributors_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/contributors","subscribers_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/subscribers","subscription_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/subscription","commits_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/contents/{+path}","compare_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/merges","archive_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/downloads","issues_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/issues{/number}","pulls_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/pulls{/number}","milestones_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/milestones{/number}","notifications_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/labels{/name}","releases_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/releases{/id}","deployments_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/deployments","created_at":"2016-03-03T08:05:32Z","updated_at":"2017-11-20T18:52:36Z","pushed_at":"2017-11-20T18:22:53Z","git_url":"git://github.com/googlesamples/android-vulkan-tutorials.git","ssh_url":"[email protected]:googlesamples/android-vulkan-tutorials.git","clone_url":"https://github.com/googlesamples/android-vulkan-tutorials.git","svn_url":"https://github.com/googlesamples/android-vulkan-tutorials","homepage":"","size":403,"stargazers_count":282,"watchers_count":282,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":6,"forks":53,"open_issues":6,"watchers":282,"default_branch":"master"}},"base":{"label":"googlesamples:master","ref":"master","sha":"ad97537049b886ff9b8da8355c0d1d300a659f7b","user":{"login":"googlesamples","id":7378196,"avatar_url":"https://avatars3.githubusercontent.com/u/7378196?v=4","gravatar_id":"","url":"https://api.github.com/users/googlesamples","html_url":"https://github.com/googlesamples","followers_url":"https://api.github.com/users/googlesamples/followers","following_url":"https://api.github.com/users/googlesamples/following{/other_user}","gists_url":"https://api.github.com/users/googlesamples/gists{/gist_id}","starred_url":"https://api.github.com/users/googlesamples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlesamples/subscriptions","organizations_url":"https://api.github.com/users/googlesamples/orgs","repos_url":"https://api.github.com/users/googlesamples/repos","events_url":"https://api.github.com/users/googlesamples/events{/privacy}","received_events_url":"https://api.github.com/users/googlesamples/received_events","type":"Organization","site_admin":false},"repo":{"id":53032527,"name":"android-vulkan-tutorials","full_name":"googlesamples/android-vulkan-tutorials","owner":{"login":"googlesamples","id":7378196,"avatar_url":"https://avatars3.githubusercontent.com/u/7378196?v=4","gravatar_id":"","url":"https://api.github.com/users/googlesamples","html_url":"https://github.com/googlesamples","followers_url":"https://api.github.com/users/googlesamples/followers","following_url":"https://api.github.com/users/googlesamples/following{/other_user}","gists_url":"https://api.github.com/users/googlesamples/gists{/gist_id}","starred_url":"https://api.github.com/users/googlesamples/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlesamples/subscriptions","organizations_url":"https://api.github.com/users/googlesamples/orgs","repos_url":"https://api.github.com/users/googlesamples/repos","events_url":"https://api.github.com/users/googlesamples/events{/privacy}","received_events_url":"https://api.github.com/users/googlesamples/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlesamples/android-vulkan-tutorials","description":"A set of samples to illustrate Vulkan API on Android","fork":false,"url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials","forks_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/forks","keys_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/teams","hooks_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/hooks","issue_events_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/issues/events{/number}","events_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/events","assignees_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/assignees{/user}","branches_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/branches{/branch}","tags_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/tags","blobs_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/statuses/{sha}","languages_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/languages","stargazers_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/stargazers","contributors_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/contributors","subscribers_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/subscribers","subscription_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/subscription","commits_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/contents/{+path}","compare_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/merges","archive_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/downloads","issues_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/issues{/number}","pulls_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/pulls{/number}","milestones_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/milestones{/number}","notifications_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/labels{/name}","releases_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/releases{/id}","deployments_url":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/deployments","created_at":"2016-03-03T08:05:32Z","updated_at":"2017-11-20T18:52:36Z","pushed_at":"2017-11-20T18:22:53Z","git_url":"git://github.com/googlesamples/android-vulkan-tutorials.git","ssh_url":"[email protected]:googlesamples/android-vulkan-tutorials.git","clone_url":"https://github.com/googlesamples/android-vulkan-tutorials.git","svn_url":"https://github.com/googlesamples/android-vulkan-tutorials","homepage":"","size":403,"stargazers_count":282,"watchers_count":282,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"archived":false,"open_issues_count":6,"forks":53,"open_issues":6,"watchers":282,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/pulls/41"},"html":{"href":"https://github.com/googlesamples/android-vulkan-tutorials/pull/41"},"issue":{"href":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/issues/41"},"comments":{"href":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/googlesamples/android-vulkan-tutorials/statuses/f3a6f39edec20f6758d5acf2ebf664dcf55bcedd"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 53032527,
"name": "googlesamples/android-vulkan-tutorials",
"url": "https://api.github.com/repos/googlesamples/android-vulkan-tutorials"
}
|
{
"id": 10564521,
"login": "ggfan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10564521?",
"url": "https://api.github.com/users/ggfan"
}
|
{
"id": 7378196,
"login": "googlesamples",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7378196?",
"url": "https://api.github.com/orgs/googlesamples"
}
| 2017-11-20T21:26:07 |
6881194230
|
{"actor":{"display_login":"ggfan"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/comments/104235882","pull_request_review_id":25063137,"id":104235882,"diff_hunk":"@@ -520,17 +554,56 @@ private fun RsCallExpr.expectedParamsCount(): Int? {\n }\n }\n \n+private fun RsMethodCallExpr.expectedMutableSelfParameter(): Boolean {\n+ val fn = reference.resolve() as? RsFunction ?: return false\n+ val self = fn.selfParameter ?: return false\n+ return self.isMut && self.isRef\n+}\n+\n private fun RsMethodCallExpr.expectedParamsCount(): Int? {\n val fn = reference.resolve() as? RsFunction ?: return null\n if (fn.queryAttributes.hasCfgAttr()) return null\n return if (fn.isInherentImpl) fn.valueParameterList?.valueParameterList?.size else null\n }\n \n+private val RsCallExpr.declaration: RsFunction?\n+ get() = (expr as? RsPathExpr)?.path?.reference?.resolve() as? RsFunction\n+\n+private fun RsExpr.declaration(): RsCompositeElement? = when (this) {\n+ is RsPathExpr -> this.path.reference.resolve()\n+ is RsFieldExpr -> this.expr.declaration()\n+ else -> null\n+}\n+\n private fun RsExpr.isMutable(): Boolean {\n- val path = (this as? RsPathExpr)?.path ?: return true\n- val declaration = path.reference.resolve()\n+ return when (this) {\n+ is RsPathExpr -> {\n+ val declaration = this.path.reference.resolve() ?: return true\n+\n+ if (declaration is RsSelfParameter) {\n+ return declaration.mut != null\n+ }\n+\n+ if (declaration is RsPatBinding && declaration.isMut) {\n+ return true\n+ }\n \n- declaration?.parentOfType<RsLetDecl>()?.eq ?: return true\n+ val type = this.type\n+ if (type is RustReferenceType) {\n+ return type.mutable\n+ }\n \n- return (declaration as? RsPatBinding)?.isMut ?: true\n+ val letExpr = declaration.parentOfType<RsLetDecl>()\n+ if (letExpr != null && letExpr.eq == null) {\n+ return true\n+ }\n+ if (type is RustUnknownType) {\n+ return true\n+ }\n+ false\n+ }\n+ is RsFieldExpr -> (this.expr.type as? RustReferenceType)?.mutable ?: true\n+ is RsUnaryExpr -> mul != null || (expr != null && expr?.isMutable()!!)","path":"src/main/kotlin/org/rust/ide/annotator/RsErrorAnnotator.kt","position":157,"original_position":157,"commit_id":"bdb0623c9d98a18131b094d2eac6728a38af5492","original_commit_id":"bdb0623c9d98a18131b094d2eac6728a38af5492","user":{"login":"mkaput","id":3450050,"avatar_url":"https://avatars3.githubusercontent.com/u/3450050?v=3","gravatar_id":"","url":"https://api.github.com/users/mkaput","html_url":"https://github.com/mkaput","followers_url":"https://api.github.com/users/mkaput/followers","following_url":"https://api.github.com/users/mkaput/following{/other_user}","gists_url":"https://api.github.com/users/mkaput/gists{/gist_id}","starred_url":"https://api.github.com/users/mkaput/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkaput/subscriptions","organizations_url":"https://api.github.com/users/mkaput/orgs","repos_url":"https://api.github.com/users/mkaput/repos","events_url":"https://api.github.com/users/mkaput/events{/privacy}","received_events_url":"https://api.github.com/users/mkaput/received_events","type":"User","site_admin":false},"body":"Are these `!!` necessary to compile? If so, then you can stick with older version `(expr?.isMutable() ?: true)`","created_at":"2017-03-03T20:26:45Z","updated_at":"2017-03-03T20:26:45Z","html_url":"https://github.com/intellij-rust/intellij-rust/pull/1039#discussion_r104235882","pull_request_url":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/1039","_links":{"self":{"href":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/comments/104235882"},"html":{"href":"https://github.com/intellij-rust/intellij-rust/pull/1039#discussion_r104235882"},"pull_request":{"href":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/1039"}}},"pull_request":{"url":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/1039","id":108136416,"html_url":"https://github.com/intellij-rust/intellij-rust/pull/1039","diff_url":"https://github.com/intellij-rust/intellij-rust/pull/1039.diff","patch_url":"https://github.com/intellij-rust/intellij-rust/pull/1039.patch","issue_url":"https://api.github.com/repos/intellij-rust/intellij-rust/issues/1039","number":1039,"state":"open","locked":false,"title":"ANNOT: Extend mutable check annotator and add quick fix","user":{"login":"farodin91","id":1159212,"avatar_url":"https://avatars2.githubusercontent.com/u/1159212?v=3","gravatar_id":"","url":"https://api.github.com/users/farodin91","html_url":"https://github.com/farodin91","followers_url":"https://api.github.com/users/farodin91/followers","following_url":"https://api.github.com/users/farodin91/following{/other_user}","gists_url":"https://api.github.com/users/farodin91/gists{/gist_id}","starred_url":"https://api.github.com/users/farodin91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farodin91/subscriptions","organizations_url":"https://api.github.com/users/farodin91/orgs","repos_url":"https://api.github.com/users/farodin91/repos","events_url":"https://api.github.com/users/farodin91/events{/privacy}","received_events_url":"https://api.github.com/users/farodin91/received_events","type":"User","site_admin":false},"body":"This checks field, functions and assignment and allow quick fix.","created_at":"2017-02-27T15:25:41Z","updated_at":"2017-03-03T20:26:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea30e888b58fef7f7925327dd3fe5d1bd7b86c0b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/1039/commits","review_comments_url":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/1039/comments","review_comment_url":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intellij-rust/intellij-rust/issues/1039/comments","statuses_url":"https://api.github.com/repos/intellij-rust/intellij-rust/statuses/bdb0623c9d98a18131b094d2eac6728a38af5492","head":{"label":"farodin91:annotator-immutable","ref":"annotator-immutable","sha":"bdb0623c9d98a18131b094d2eac6728a38af5492","user":{"login":"farodin91","id":1159212,"avatar_url":"https://avatars2.githubusercontent.com/u/1159212?v=3","gravatar_id":"","url":"https://api.github.com/users/farodin91","html_url":"https://github.com/farodin91","followers_url":"https://api.github.com/users/farodin91/followers","following_url":"https://api.github.com/users/farodin91/following{/other_user}","gists_url":"https://api.github.com/users/farodin91/gists{/gist_id}","starred_url":"https://api.github.com/users/farodin91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farodin91/subscriptions","organizations_url":"https://api.github.com/users/farodin91/orgs","repos_url":"https://api.github.com/users/farodin91/repos","events_url":"https://api.github.com/users/farodin91/events{/privacy}","received_events_url":"https://api.github.com/users/farodin91/received_events","type":"User","site_admin":false},"repo":{"id":73374868,"name":"intellij-rust","full_name":"farodin91/intellij-rust","owner":{"login":"farodin91","id":1159212,"avatar_url":"https://avatars2.githubusercontent.com/u/1159212?v=3","gravatar_id":"","url":"https://api.github.com/users/farodin91","html_url":"https://github.com/farodin91","followers_url":"https://api.github.com/users/farodin91/followers","following_url":"https://api.github.com/users/farodin91/following{/other_user}","gists_url":"https://api.github.com/users/farodin91/gists{/gist_id}","starred_url":"https://api.github.com/users/farodin91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farodin91/subscriptions","organizations_url":"https://api.github.com/users/farodin91/orgs","repos_url":"https://api.github.com/users/farodin91/repos","events_url":"https://api.github.com/users/farodin91/events{/privacy}","received_events_url":"https://api.github.com/users/farodin91/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/farodin91/intellij-rust","description":"Rust IDE built using the IntelliJ Platform: https://intellij-rust.github.io/","fork":true,"url":"https://api.github.com/repos/farodin91/intellij-rust","forks_url":"https://api.github.com/repos/farodin91/intellij-rust/forks","keys_url":"https://api.github.com/repos/farodin91/intellij-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/farodin91/intellij-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/farodin91/intellij-rust/teams","hooks_url":"https://api.github.com/repos/farodin91/intellij-rust/hooks","issue_events_url":"https://api.github.com/repos/farodin91/intellij-rust/issues/events{/number}","events_url":"https://api.github.com/repos/farodin91/intellij-rust/events","assignees_url":"https://api.github.com/repos/farodin91/intellij-rust/assignees{/user}","branches_url":"https://api.github.com/repos/farodin91/intellij-rust/branches{/branch}","tags_url":"https://api.github.com/repos/farodin91/intellij-rust/tags","blobs_url":"https://api.github.com/repos/farodin91/intellij-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/farodin91/intellij-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/farodin91/intellij-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/farodin91/intellij-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/farodin91/intellij-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/farodin91/intellij-rust/languages","stargazers_url":"https://api.github.com/repos/farodin91/intellij-rust/stargazers","contributors_url":"https://api.github.com/repos/farodin91/intellij-rust/contributors","subscribers_url":"https://api.github.com/repos/farodin91/intellij-rust/subscribers","subscription_url":"https://api.github.com/repos/farodin91/intellij-rust/subscription","commits_url":"https://api.github.com/repos/farodin91/intellij-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/farodin91/intellij-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/farodin91/intellij-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/farodin91/intellij-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/farodin91/intellij-rust/contents/{+path}","compare_url":"https://api.github.com/repos/farodin91/intellij-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/farodin91/intellij-rust/merges","archive_url":"https://api.github.com/repos/farodin91/intellij-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/farodin91/intellij-rust/downloads","issues_url":"https://api.github.com/repos/farodin91/intellij-rust/issues{/number}","pulls_url":"https://api.github.com/repos/farodin91/intellij-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/farodin91/intellij-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/farodin91/intellij-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/farodin91/intellij-rust/labels{/name}","releases_url":"https://api.github.com/repos/farodin91/intellij-rust/releases{/id}","deployments_url":"https://api.github.com/repos/farodin91/intellij-rust/deployments","created_at":"2016-11-10T11:15:56Z","updated_at":"2016-11-10T11:15:58Z","pushed_at":"2017-03-03T18:06:59Z","git_url":"git://github.com/farodin91/intellij-rust.git","ssh_url":"[email protected]:farodin91/intellij-rust.git","clone_url":"https://github.com/farodin91/intellij-rust.git","svn_url":"https://github.com/farodin91/intellij-rust","homepage":"","size":13331,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"intellij-rust:master","ref":"master","sha":"2cea5217a2f42a75a13aa6fd2170a18c45a8bd4d","user":{"login":"intellij-rust","id":16057867,"avatar_url":"https://avatars3.githubusercontent.com/u/16057867?v=3","gravatar_id":"","url":"https://api.github.com/users/intellij-rust","html_url":"https://github.com/intellij-rust","followers_url":"https://api.github.com/users/intellij-rust/followers","following_url":"https://api.github.com/users/intellij-rust/following{/other_user}","gists_url":"https://api.github.com/users/intellij-rust/gists{/gist_id}","starred_url":"https://api.github.com/users/intellij-rust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intellij-rust/subscriptions","organizations_url":"https://api.github.com/users/intellij-rust/orgs","repos_url":"https://api.github.com/users/intellij-rust/repos","events_url":"https://api.github.com/users/intellij-rust/events{/privacy}","received_events_url":"https://api.github.com/users/intellij-rust/received_events","type":"Organization","site_admin":false},"repo":{"id":42619487,"name":"intellij-rust","full_name":"intellij-rust/intellij-rust","owner":{"login":"intellij-rust","id":16057867,"avatar_url":"https://avatars3.githubusercontent.com/u/16057867?v=3","gravatar_id":"","url":"https://api.github.com/users/intellij-rust","html_url":"https://github.com/intellij-rust","followers_url":"https://api.github.com/users/intellij-rust/followers","following_url":"https://api.github.com/users/intellij-rust/following{/other_user}","gists_url":"https://api.github.com/users/intellij-rust/gists{/gist_id}","starred_url":"https://api.github.com/users/intellij-rust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intellij-rust/subscriptions","organizations_url":"https://api.github.com/users/intellij-rust/orgs","repos_url":"https://api.github.com/users/intellij-rust/repos","events_url":"https://api.github.com/users/intellij-rust/events{/privacy}","received_events_url":"https://api.github.com/users/intellij-rust/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intellij-rust/intellij-rust","description":"Rust IDE built using the IntelliJ Platform: https://intellij-rust.github.io/","fork":false,"url":"https://api.github.com/repos/intellij-rust/intellij-rust","forks_url":"https://api.github.com/repos/intellij-rust/intellij-rust/forks","keys_url":"https://api.github.com/repos/intellij-rust/intellij-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intellij-rust/intellij-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intellij-rust/intellij-rust/teams","hooks_url":"https://api.github.com/repos/intellij-rust/intellij-rust/hooks","issue_events_url":"https://api.github.com/repos/intellij-rust/intellij-rust/issues/events{/number}","events_url":"https://api.github.com/repos/intellij-rust/intellij-rust/events","assignees_url":"https://api.github.com/repos/intellij-rust/intellij-rust/assignees{/user}","branches_url":"https://api.github.com/repos/intellij-rust/intellij-rust/branches{/branch}","tags_url":"https://api.github.com/repos/intellij-rust/intellij-rust/tags","blobs_url":"https://api.github.com/repos/intellij-rust/intellij-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intellij-rust/intellij-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intellij-rust/intellij-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/intellij-rust/intellij-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intellij-rust/intellij-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/intellij-rust/intellij-rust/languages","stargazers_url":"https://api.github.com/repos/intellij-rust/intellij-rust/stargazers","contributors_url":"https://api.github.com/repos/intellij-rust/intellij-rust/contributors","subscribers_url":"https://api.github.com/repos/intellij-rust/intellij-rust/subscribers","subscription_url":"https://api.github.com/repos/intellij-rust/intellij-rust/subscription","commits_url":"https://api.github.com/repos/intellij-rust/intellij-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/intellij-rust/intellij-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/intellij-rust/intellij-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/intellij-rust/intellij-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/intellij-rust/intellij-rust/contents/{+path}","compare_url":"https://api.github.com/repos/intellij-rust/intellij-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intellij-rust/intellij-rust/merges","archive_url":"https://api.github.com/repos/intellij-rust/intellij-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intellij-rust/intellij-rust/downloads","issues_url":"https://api.github.com/repos/intellij-rust/intellij-rust/issues{/number}","pulls_url":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/intellij-rust/intellij-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/intellij-rust/intellij-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intellij-rust/intellij-rust/labels{/name}","releases_url":"https://api.github.com/repos/intellij-rust/intellij-rust/releases{/id}","deployments_url":"https://api.github.com/repos/intellij-rust/intellij-rust/deployments","created_at":"2015-09-16T23:44:57Z","updated_at":"2017-03-03T02:33:25Z","pushed_at":"2017-03-03T18:07:00Z","git_url":"git://github.com/intellij-rust/intellij-rust.git","ssh_url":"[email protected]:intellij-rust/intellij-rust.git","clone_url":"https://github.com/intellij-rust/intellij-rust.git","svn_url":"https://github.com/intellij-rust/intellij-rust","homepage":"","size":13323,"stargazers_count":1150,"watchers_count":1150,"language":"Kotlin","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":96,"mirror_url":null,"open_issues_count":93,"forks":96,"open_issues":93,"watchers":1150,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/1039"},"html":{"href":"https://github.com/intellij-rust/intellij-rust/pull/1039"},"issue":{"href":"https://api.github.com/repos/intellij-rust/intellij-rust/issues/1039"},"comments":{"href":"https://api.github.com/repos/intellij-rust/intellij-rust/issues/1039/comments"},"review_comments":{"href":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/1039/comments"},"review_comment":{"href":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/1039/commits"},"statuses":{"href":"https://api.github.com/repos/intellij-rust/intellij-rust/statuses/bdb0623c9d98a18131b094d2eac6728a38af5492"}}}}
|
{
"id": 42619487,
"name": "intellij-rust/intellij-rust",
"url": "https://api.github.com/repos/intellij-rust/intellij-rust"
}
|
{
"id": 3450050,
"login": "mkaput",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3450050?",
"url": "https://api.github.com/users/mkaput"
}
|
{
"id": 16057867,
"login": "intellij-rust",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16057867?",
"url": "https://api.github.com/orgs/intellij-rust"
}
| 2017-03-03T20:26:45 |
5430173531
|
{"actor":{"display_login":"mkaput"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/pulls/comments/150012168","pull_request_review_id":75497393,"id":150012168,"diff_hunk":"@@ -1,21 +1,48 @@\n-const express = require('express');\n+const express = require(\"express\");\n \n // require the Drone model here\n-\n+var Drone = require(\"../models/drone\").Drone;\n const router = express.Router();\n \n-\n-router.get('/drones', (req, res, next) => {\n+router.get(\"/\", (req, res, next) => {\n // Iteration #2\n+ Drone.find({}, (err, result) => {\n+ if (err) {\n+ console.log(\"Error Monongo: \", err);\n+ } else {\n+ const data = {\n+ drones: result\n+ };\n+ res.render(\"drones\", data);\n+ }\n+ });\n });\n \n-\n-router.get('/drones/new', (req, res, next) => {\n+router.get(\"/new\", (req, res, next) => {\n // Iteration #3\n+ Drone.find({}, (err, result) => {","path":"starter-code/routes/drones.js","position":29,"original_position":29,"commit_id":"bc93e43265aacf1befb2c5c8dd7e5a6a8e1aa3d6","original_commit_id":"bc93e43265aacf1befb2c5c8dd7e5a6a8e1aa3d6","user":{"login":"tawebbcn","id":26812171,"avatar_url":"https://avatars2.githubusercontent.com/u/26812171?v=4","gravatar_id":"","url":"https://api.github.com/users/tawebbcn","html_url":"https://github.com/tawebbcn","followers_url":"https://api.github.com/users/tawebbcn/followers","following_url":"https://api.github.com/users/tawebbcn/following{/other_user}","gists_url":"https://api.github.com/users/tawebbcn/gists{/gist_id}","starred_url":"https://api.github.com/users/tawebbcn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tawebbcn/subscriptions","organizations_url":"https://api.github.com/users/tawebbcn/orgs","repos_url":"https://api.github.com/users/tawebbcn/repos","events_url":"https://api.github.com/users/tawebbcn/events{/privacy}","received_events_url":"https://api.github.com/users/tawebbcn/received_events","type":"User","site_admin":false},"body":"Why are you searching for all the drones when going to the page to make a new drone?","created_at":"2017-11-09T16:26:09Z","updated_at":"2017-11-09T16:29:39Z","html_url":"https://github.com/ironhack-labs/lab-mongoose-drones/pull/137#discussion_r150012168","pull_request_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/pulls/137","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/pulls/comments/150012168"},"html":{"href":"https://github.com/ironhack-labs/lab-mongoose-drones/pull/137#discussion_r150012168"},"pull_request":{"href":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/pulls/137"}}},"pull_request":{"url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/pulls/137","id":151672816,"html_url":"https://github.com/ironhack-labs/lab-mongoose-drones/pull/137","diff_url":"https://github.com/ironhack-labs/lab-mongoose-drones/pull/137.diff","patch_url":"https://github.com/ironhack-labs/lab-mongoose-drones/pull/137.patch","issue_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/issues/137","number":137,"state":"open","locked":false,"title":"BCN - Juan & Constantino","user":{"login":"jcuadrad","id":31750689,"avatar_url":"https://avatars0.githubusercontent.com/u/31750689?v=4","gravatar_id":"","url":"https://api.github.com/users/jcuadrad","html_url":"https://github.com/jcuadrad","followers_url":"https://api.github.com/users/jcuadrad/followers","following_url":"https://api.github.com/users/jcuadrad/following{/other_user}","gists_url":"https://api.github.com/users/jcuadrad/gists{/gist_id}","starred_url":"https://api.github.com/users/jcuadrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcuadrad/subscriptions","organizations_url":"https://api.github.com/users/jcuadrad/orgs","repos_url":"https://api.github.com/users/jcuadrad/repos","events_url":"https://api.github.com/users/jcuadrad/events{/privacy}","received_events_url":"https://api.github.com/users/jcuadrad/received_events","type":"User","site_admin":false},"body":"@cyenis","created_at":"2017-11-09T14:54:52Z","updated_at":"2017-11-09T16:29:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c618728af4b7cbb44a9c0389b04feff3ea7b425a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/pulls/137/commits","review_comments_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/pulls/137/comments","review_comment_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/issues/137/comments","statuses_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/statuses/bc93e43265aacf1befb2c5c8dd7e5a6a8e1aa3d6","head":{"label":"jcuadrad:master","ref":"master","sha":"bc93e43265aacf1befb2c5c8dd7e5a6a8e1aa3d6","user":{"login":"jcuadrad","id":31750689,"avatar_url":"https://avatars0.githubusercontent.com/u/31750689?v=4","gravatar_id":"","url":"https://api.github.com/users/jcuadrad","html_url":"https://github.com/jcuadrad","followers_url":"https://api.github.com/users/jcuadrad/followers","following_url":"https://api.github.com/users/jcuadrad/following{/other_user}","gists_url":"https://api.github.com/users/jcuadrad/gists{/gist_id}","starred_url":"https://api.github.com/users/jcuadrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcuadrad/subscriptions","organizations_url":"https://api.github.com/users/jcuadrad/orgs","repos_url":"https://api.github.com/users/jcuadrad/repos","events_url":"https://api.github.com/users/jcuadrad/events{/privacy}","received_events_url":"https://api.github.com/users/jcuadrad/received_events","type":"User","site_admin":false},"repo":{"id":110116066,"name":"lab-mongoose-drones","full_name":"jcuadrad/lab-mongoose-drones","owner":{"login":"jcuadrad","id":31750689,"avatar_url":"https://avatars0.githubusercontent.com/u/31750689?v=4","gravatar_id":"","url":"https://api.github.com/users/jcuadrad","html_url":"https://github.com/jcuadrad","followers_url":"https://api.github.com/users/jcuadrad/followers","following_url":"https://api.github.com/users/jcuadrad/following{/other_user}","gists_url":"https://api.github.com/users/jcuadrad/gists{/gist_id}","starred_url":"https://api.github.com/users/jcuadrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcuadrad/subscriptions","organizations_url":"https://api.github.com/users/jcuadrad/orgs","repos_url":"https://api.github.com/users/jcuadrad/repos","events_url":"https://api.github.com/users/jcuadrad/events{/privacy}","received_events_url":"https://api.github.com/users/jcuadrad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcuadrad/lab-mongoose-drones","description":null,"fork":true,"url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones","forks_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/forks","keys_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/teams","hooks_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/hooks","issue_events_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/issues/events{/number}","events_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/events","assignees_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/assignees{/user}","branches_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/branches{/branch}","tags_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/tags","blobs_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/statuses/{sha}","languages_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/languages","stargazers_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/stargazers","contributors_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/contributors","subscribers_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/subscribers","subscription_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/subscription","commits_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/contents/{+path}","compare_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/merges","archive_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/downloads","issues_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/issues{/number}","pulls_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/pulls{/number}","milestones_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/milestones{/number}","notifications_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/labels{/name}","releases_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/releases{/id}","deployments_url":"https://api.github.com/repos/jcuadrad/lab-mongoose-drones/deployments","created_at":"2017-11-09T13:03:16Z","updated_at":"2017-11-09T13:03:17Z","pushed_at":"2017-11-09T14:54:01Z","git_url":"git://github.com/jcuadrad/lab-mongoose-drones.git","ssh_url":"[email protected]:jcuadrad/lab-mongoose-drones.git","clone_url":"https://github.com/jcuadrad/lab-mongoose-drones.git","svn_url":"https://github.com/jcuadrad/lab-mongoose-drones","homepage":null,"size":2060,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ironhack-labs:master","ref":"master","sha":"879bc344176f3409398685cdf22213009aedfb42","user":{"login":"ironhack-labs","id":25032046,"avatar_url":"https://avatars3.githubusercontent.com/u/25032046?v=4","gravatar_id":"","url":"https://api.github.com/users/ironhack-labs","html_url":"https://github.com/ironhack-labs","followers_url":"https://api.github.com/users/ironhack-labs/followers","following_url":"https://api.github.com/users/ironhack-labs/following{/other_user}","gists_url":"https://api.github.com/users/ironhack-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/ironhack-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironhack-labs/subscriptions","organizations_url":"https://api.github.com/users/ironhack-labs/orgs","repos_url":"https://api.github.com/users/ironhack-labs/repos","events_url":"https://api.github.com/users/ironhack-labs/events{/privacy}","received_events_url":"https://api.github.com/users/ironhack-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":79467766,"name":"lab-mongoose-drones","full_name":"ironhack-labs/lab-mongoose-drones","owner":{"login":"ironhack-labs","id":25032046,"avatar_url":"https://avatars3.githubusercontent.com/u/25032046?v=4","gravatar_id":"","url":"https://api.github.com/users/ironhack-labs","html_url":"https://github.com/ironhack-labs","followers_url":"https://api.github.com/users/ironhack-labs/followers","following_url":"https://api.github.com/users/ironhack-labs/following{/other_user}","gists_url":"https://api.github.com/users/ironhack-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/ironhack-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironhack-labs/subscriptions","organizations_url":"https://api.github.com/users/ironhack-labs/orgs","repos_url":"https://api.github.com/users/ironhack-labs/repos","events_url":"https://api.github.com/users/ironhack-labs/events{/privacy}","received_events_url":"https://api.github.com/users/ironhack-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ironhack-labs/lab-mongoose-drones","description":null,"fork":false,"url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones","forks_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/forks","keys_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/teams","hooks_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/hooks","issue_events_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/issues/events{/number}","events_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/events","assignees_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/assignees{/user}","branches_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/branches{/branch}","tags_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/tags","blobs_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/git/refs{/sha}","trees_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/statuses/{sha}","languages_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/languages","stargazers_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/stargazers","contributors_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/contributors","subscribers_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/subscribers","subscription_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/subscription","commits_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/commits{/sha}","git_commits_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/git/commits{/sha}","comments_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/comments{/number}","issue_comment_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/issues/comments{/number}","contents_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/contents/{+path}","compare_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/merges","archive_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/downloads","issues_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/issues{/number}","pulls_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/pulls{/number}","milestones_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/milestones{/number}","notifications_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/labels{/name}","releases_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/releases{/id}","deployments_url":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/deployments","created_at":"2017-01-19T15:39:32Z","updated_at":"2017-11-07T08:20:34Z","pushed_at":"2017-11-09T16:06:22Z","git_url":"git://github.com/ironhack-labs/lab-mongoose-drones.git","ssh_url":"[email protected]:ironhack-labs/lab-mongoose-drones.git","clone_url":"https://github.com/ironhack-labs/lab-mongoose-drones.git","svn_url":"https://github.com/ironhack-labs/lab-mongoose-drones","homepage":null,"size":2051,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":245,"mirror_url":null,"archived":false,"open_issues_count":35,"forks":245,"open_issues":35,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/pulls/137"},"html":{"href":"https://github.com/ironhack-labs/lab-mongoose-drones/pull/137"},"issue":{"href":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/issues/137"},"comments":{"href":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/ironhack-labs/lab-mongoose-drones/statuses/bc93e43265aacf1befb2c5c8dd7e5a6a8e1aa3d6"}},"author_association":"NONE"}}
|
{
"id": 79467766,
"name": "ironhack-labs/lab-mongoose-drones",
"url": "https://api.github.com/repos/ironhack-labs/lab-mongoose-drones"
}
|
{
"id": 26812171,
"login": "tawebbcn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26812171?",
"url": "https://api.github.com/users/tawebbcn"
}
|
{
"id": 25032046,
"login": "ironhack-labs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25032046?",
"url": "https://api.github.com/orgs/ironhack-labs"
}
| 2017-11-09T16:26:09 |
6833101971
|
{"actor":{"display_login":"tawebbcn"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/pulls/comments/150036602","pull_request_review_id":75527118,"id":150036602,"diff_hunk":"@@ -5,3 +5,395 @@ main-titles dark-grey: #2C303F;\n paragraph grey: #5b5e6d;\n nav grey: #5b5e6d;\n */\n+@import url(\"http://fonts.googleapis.com/css?family=Lato\");\n+\n+.container {\n+ display: flex;\n+ flex-direction: column;\n+ justify-content: center;\n+ align-items: center;\n+ font-family: Lato;\n+ height: 100%;\n+}\n+\n+.navbar {\n+ height: 70px;\n+ width: 100%;\n+ display: flex;\n+ flex-direction: row;\n+ justify-content: center;\n+ align-items: center;\n+ color: #5b5e6d;\n+ border-bottom-style: inset;\n+ border-bottom-width: 1px;\n+ border-bottom-color: #F4F3F4;\n+}\n+\n+.slack-logo > img {\n+ height: 70px;\n+}\n+\n+.nav-menu{\n+ height: 70px;\n+ width: 500px;\n+ align-items: center;\n+ margin-left: 600px;\n+}\n+\n+.nav-menu ul {\n+ display: flex;\n+ flex-wrap: wrap;\n+ justify-content: space-between;\n+ align-items: center;\n+ list-style: none;\n+ }\n+\n+.nav-menu li {\n+ margin-left: 15px;\n+}\n+\n+.nav-menu li:last-child {\n+ border-width: 1px;\n+ border-style: solid;\n+ border-color: #5b5e6d;\n+ box-sizing: border-box;\n+ padding: 10px;\n+ border-radius: 5px;\n+}\n+\n+.content {\n+ display: flex;\n+ flex-direction: column;\n+ justify-content: center;\n+ align-items: center;\n+ width: 100%;\n+}\n+\n+header {\n+ display: flex;\n+ justify-content: center;\n+ align-items: flex-start;\n+ margin-top: 60px;\n+}\n+\n+.where-work {\n+ width: 600px;\n+ margin-left: 40px;\n+}\n+\n+.where-work > h1 {\n+ font-size: 4.8rem;\n+ margin-top: -40px;\n+}\n+\n+.where-work > p {\n+ font-size: 1rem;\n+ color: #5b5e6d;\n+}\n+\n+.where-work > button {","path":"starter_code/stylesheets/style.css","position":90,"original_position":90,"commit_id":"9cf70bfeab23251fbc1c202b7abcb781d549f629","original_commit_id":"9cf70bfeab23251fbc1c202b7abcb781d549f629","user":{"login":"tawebbcn","id":26812171,"avatar_url":"https://avatars2.githubusercontent.com/u/26812171?v=4","gravatar_id":"","url":"https://api.github.com/users/tawebbcn","html_url":"https://github.com/tawebbcn","followers_url":"https://api.github.com/users/tawebbcn/followers","following_url":"https://api.github.com/users/tawebbcn/following{/other_user}","gists_url":"https://api.github.com/users/tawebbcn/gists{/gist_id}","starred_url":"https://api.github.com/users/tawebbcn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tawebbcn/subscriptions","organizations_url":"https://api.github.com/users/tawebbcn/orgs","repos_url":"https://api.github.com/users/tawebbcn/repos","events_url":"https://api.github.com/users/tawebbcn/events{/privacy}","received_events_url":"https://api.github.com/users/tawebbcn/received_events","type":"User","site_admin":false},"body":"Ahora mismo tenemos el \"button\" con una forma rectangular, si queremos que sea cómo en el modelo faltaría añadir la siguiente línea para darle un poco de forma a los bordes: \"border-radious: 3px;\" \r\nLo que hace es darle un radio de 3px a los bordes . Pero no te preocupes es muy difícil acordarse siempre de todos los \"Selectors\". \r\nMuy buen Trabajo 👍 !!!","created_at":"2017-11-09T17:48:14Z","updated_at":"2017-11-09T17:48:53Z","html_url":"https://github.com/ironhack-labs/lab-css-flexbox-slack/pull/71#discussion_r150036602","pull_request_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/pulls/71","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/pulls/comments/150036602"},"html":{"href":"https://github.com/ironhack-labs/lab-css-flexbox-slack/pull/71#discussion_r150036602"},"pull_request":{"href":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/pulls/71","id":150853698,"html_url":"https://github.com/ironhack-labs/lab-css-flexbox-slack/pull/71","diff_url":"https://github.com/ironhack-labs/lab-css-flexbox-slack/pull/71.diff","patch_url":"https://github.com/ironhack-labs/lab-css-flexbox-slack/pull/71.patch","issue_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/issues/71","number":71,"state":"open","locked":false,"title":"BCN - Manu Pacheco","user":{"login":"emeeneu","id":26389953,"avatar_url":"https://avatars0.githubusercontent.com/u/26389953?v=4","gravatar_id":"","url":"https://api.github.com/users/emeeneu","html_url":"https://github.com/emeeneu","followers_url":"https://api.github.com/users/emeeneu/followers","following_url":"https://api.github.com/users/emeeneu/following{/other_user}","gists_url":"https://api.github.com/users/emeeneu/gists{/gist_id}","starred_url":"https://api.github.com/users/emeeneu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emeeneu/subscriptions","organizations_url":"https://api.github.com/users/emeeneu/orgs","repos_url":"https://api.github.com/users/emeeneu/repos","events_url":"https://api.github.com/users/emeeneu/events{/privacy}","received_events_url":"https://api.github.com/users/emeeneu/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-06T13:35:50Z","updated_at":"2017-11-09T17:48:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ccc2e0c1867d1bfa6fce74c397e79ab098bfe18","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/pulls/71/commits","review_comments_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/pulls/71/comments","review_comment_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/issues/71/comments","statuses_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/statuses/9cf70bfeab23251fbc1c202b7abcb781d549f629","head":{"label":"emeeneu:master","ref":"master","sha":"9cf70bfeab23251fbc1c202b7abcb781d549f629","user":{"login":"emeeneu","id":26389953,"avatar_url":"https://avatars0.githubusercontent.com/u/26389953?v=4","gravatar_id":"","url":"https://api.github.com/users/emeeneu","html_url":"https://github.com/emeeneu","followers_url":"https://api.github.com/users/emeeneu/followers","following_url":"https://api.github.com/users/emeeneu/following{/other_user}","gists_url":"https://api.github.com/users/emeeneu/gists{/gist_id}","starred_url":"https://api.github.com/users/emeeneu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emeeneu/subscriptions","organizations_url":"https://api.github.com/users/emeeneu/orgs","repos_url":"https://api.github.com/users/emeeneu/repos","events_url":"https://api.github.com/users/emeeneu/events{/privacy}","received_events_url":"https://api.github.com/users/emeeneu/received_events","type":"User","site_admin":false},"repo":{"id":109508378,"name":"lab-css-flexbox-slack","full_name":"emeeneu/lab-css-flexbox-slack","owner":{"login":"emeeneu","id":26389953,"avatar_url":"https://avatars0.githubusercontent.com/u/26389953?v=4","gravatar_id":"","url":"https://api.github.com/users/emeeneu","html_url":"https://github.com/emeeneu","followers_url":"https://api.github.com/users/emeeneu/followers","following_url":"https://api.github.com/users/emeeneu/following{/other_user}","gists_url":"https://api.github.com/users/emeeneu/gists{/gist_id}","starred_url":"https://api.github.com/users/emeeneu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emeeneu/subscriptions","organizations_url":"https://api.github.com/users/emeeneu/orgs","repos_url":"https://api.github.com/users/emeeneu/repos","events_url":"https://api.github.com/users/emeeneu/events{/privacy}","received_events_url":"https://api.github.com/users/emeeneu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emeeneu/lab-css-flexbox-slack","description":null,"fork":true,"url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack","forks_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/forks","keys_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/teams","hooks_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/hooks","issue_events_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/issues/events{/number}","events_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/events","assignees_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/assignees{/user}","branches_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/branches{/branch}","tags_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/tags","blobs_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/git/refs{/sha}","trees_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/statuses/{sha}","languages_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/languages","stargazers_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/stargazers","contributors_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/contributors","subscribers_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/subscribers","subscription_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/subscription","commits_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/commits{/sha}","git_commits_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/git/commits{/sha}","comments_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/comments{/number}","issue_comment_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/issues/comments{/number}","contents_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/contents/{+path}","compare_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/merges","archive_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/downloads","issues_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/issues{/number}","pulls_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/pulls{/number}","milestones_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/milestones{/number}","notifications_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/labels{/name}","releases_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/releases{/id}","deployments_url":"https://api.github.com/repos/emeeneu/lab-css-flexbox-slack/deployments","created_at":"2017-11-04T15:52:54Z","updated_at":"2017-11-06T13:33:46Z","pushed_at":"2017-11-06T13:33:44Z","git_url":"git://github.com/emeeneu/lab-css-flexbox-slack.git","ssh_url":"[email protected]:emeeneu/lab-css-flexbox-slack.git","clone_url":"https://github.com/emeeneu/lab-css-flexbox-slack.git","svn_url":"https://github.com/emeeneu/lab-css-flexbox-slack","homepage":null,"size":505,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ironhack-labs:master","ref":"master","sha":"2a17c5b0b77b9bc259b642d2042f9ad5c8e733ea","user":{"login":"ironhack-labs","id":25032046,"avatar_url":"https://avatars3.githubusercontent.com/u/25032046?v=4","gravatar_id":"","url":"https://api.github.com/users/ironhack-labs","html_url":"https://github.com/ironhack-labs","followers_url":"https://api.github.com/users/ironhack-labs/followers","following_url":"https://api.github.com/users/ironhack-labs/following{/other_user}","gists_url":"https://api.github.com/users/ironhack-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/ironhack-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironhack-labs/subscriptions","organizations_url":"https://api.github.com/users/ironhack-labs/orgs","repos_url":"https://api.github.com/users/ironhack-labs/repos","events_url":"https://api.github.com/users/ironhack-labs/events{/privacy}","received_events_url":"https://api.github.com/users/ironhack-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":105649700,"name":"lab-css-flexbox-slack","full_name":"ironhack-labs/lab-css-flexbox-slack","owner":{"login":"ironhack-labs","id":25032046,"avatar_url":"https://avatars3.githubusercontent.com/u/25032046?v=4","gravatar_id":"","url":"https://api.github.com/users/ironhack-labs","html_url":"https://github.com/ironhack-labs","followers_url":"https://api.github.com/users/ironhack-labs/followers","following_url":"https://api.github.com/users/ironhack-labs/following{/other_user}","gists_url":"https://api.github.com/users/ironhack-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/ironhack-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironhack-labs/subscriptions","organizations_url":"https://api.github.com/users/ironhack-labs/orgs","repos_url":"https://api.github.com/users/ironhack-labs/repos","events_url":"https://api.github.com/users/ironhack-labs/events{/privacy}","received_events_url":"https://api.github.com/users/ironhack-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ironhack-labs/lab-css-flexbox-slack","description":null,"fork":false,"url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack","forks_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/forks","keys_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/teams","hooks_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/hooks","issue_events_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/issues/events{/number}","events_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/events","assignees_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/assignees{/user}","branches_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/branches{/branch}","tags_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/tags","blobs_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/git/refs{/sha}","trees_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/statuses/{sha}","languages_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/languages","stargazers_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/stargazers","contributors_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/contributors","subscribers_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/subscribers","subscription_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/subscription","commits_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/commits{/sha}","git_commits_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/git/commits{/sha}","comments_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/comments{/number}","issue_comment_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/issues/comments{/number}","contents_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/contents/{+path}","compare_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/merges","archive_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/downloads","issues_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/issues{/number}","pulls_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/pulls{/number}","milestones_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/milestones{/number}","notifications_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/labels{/name}","releases_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/releases{/id}","deployments_url":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/deployments","created_at":"2017-10-03T12:35:23Z","updated_at":"2017-11-07T17:11:45Z","pushed_at":"2017-11-09T17:29:31Z","git_url":"git://github.com/ironhack-labs/lab-css-flexbox-slack.git","ssh_url":"[email protected]:ironhack-labs/lab-css-flexbox-slack.git","clone_url":"https://github.com/ironhack-labs/lab-css-flexbox-slack.git","svn_url":"https://github.com/ironhack-labs/lab-css-flexbox-slack","homepage":null,"size":501,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"archived":false,"open_issues_count":12,"forks":103,"open_issues":12,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/pulls/71"},"html":{"href":"https://github.com/ironhack-labs/lab-css-flexbox-slack/pull/71"},"issue":{"href":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/issues/71"},"comments":{"href":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack/statuses/9cf70bfeab23251fbc1c202b7abcb781d549f629"}},"author_association":"NONE"}}
|
{
"id": 105649700,
"name": "ironhack-labs/lab-css-flexbox-slack",
"url": "https://api.github.com/repos/ironhack-labs/lab-css-flexbox-slack"
}
|
{
"id": 26812171,
"login": "tawebbcn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26812171?",
"url": "https://api.github.com/users/tawebbcn"
}
|
{
"id": 25032046,
"login": "ironhack-labs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25032046?",
"url": "https://api.github.com/orgs/ironhack-labs"
}
| 2017-11-09T17:48:14 |
6833545695
|
{"actor":{"display_login":"tawebbcn"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/comments/134954545","pull_request_review_id":58306111,"id":134954545,"diff_hunk":"@@ -1,2 +1,34 @@\n function StackDataStructure () {\n+ var that = this;\n+ this.stackControl = [];\n+ this.MAX_SIZE = 8;\n+ this.isEmpty = function () {\n+ if (that.stackControl.length === 0) {\n+ return true;\n+ } else {\n+ return false;\n+ }\n+ };\n+ this.canPush = function () {\n+ if (that.stackControl.length !== that.MAX_SIZE) {\n+ return true;\n+ } else {\n+ return false;\n+ }\n+ };\n+ this.push = function (x) {\n+ if (that.canPush()) {\n+ that.stackControl.push(x);\n+ } else {\n+ return (\"Stack Overflow\");\n+ }\n+ return that.stackControl;\n+ };\n+ this.pop = function () {\n+ if (that.stackControl.length !== 0) {","path":"starter-code/src/StackDataStructure.js","position":28,"original_position":28,"commit_id":"8119b0c3ec10236466481b5cdc697fdf35667841","original_commit_id":"8119b0c3ec10236466481b5cdc697fdf35667841","user":{"login":"tawebbcn","id":26812171,"avatar_url":"https://avatars2.githubusercontent.com/u/26812171?v=4","gravatar_id":"","url":"https://api.github.com/users/tawebbcn","html_url":"https://github.com/tawebbcn","followers_url":"https://api.github.com/users/tawebbcn/followers","following_url":"https://api.github.com/users/tawebbcn/following{/other_user}","gists_url":"https://api.github.com/users/tawebbcn/gists{/gist_id}","starred_url":"https://api.github.com/users/tawebbcn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tawebbcn/subscriptions","organizations_url":"https://api.github.com/users/tawebbcn/orgs","repos_url":"https://api.github.com/users/tawebbcn/repos","events_url":"https://api.github.com/users/tawebbcn/events{/privacy}","received_events_url":"https://api.github.com/users/tawebbcn/received_events","type":"User","site_admin":false},"body":"Use this.isEmpty().","created_at":"2017-08-24T08:22:10Z","updated_at":"2017-08-24T08:22:19Z","html_url":"https://github.com/ironhack-labs/lab-javascript-advanced-algorithms/pull/73#discussion_r134954545","pull_request_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/73","_links":{"self":{"href":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/comments/134954545"},"html":{"href":"https://github.com/ironhack-labs/lab-javascript-advanced-algorithms/pull/73#discussion_r134954545"},"pull_request":{"href":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/73"}}},"pull_request":{"url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/73","id":137383162,"html_url":"https://github.com/ironhack-labs/lab-javascript-advanced-algorithms/pull/73","diff_url":"https://github.com/ironhack-labs/lab-javascript-advanced-algorithms/pull/73.diff","patch_url":"https://github.com/ironhack-labs/lab-javascript-advanced-algorithms/pull/73.patch","issue_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/issues/73","number":73,"state":"open","locked":false,"title":"BCN will-thorp","user":{"login":"willjthorp","id":30321077,"avatar_url":"https://avatars3.githubusercontent.com/u/30321077?v=4","gravatar_id":"","url":"https://api.github.com/users/willjthorp","html_url":"https://github.com/willjthorp","followers_url":"https://api.github.com/users/willjthorp/followers","following_url":"https://api.github.com/users/willjthorp/following{/other_user}","gists_url":"https://api.github.com/users/willjthorp/gists{/gist_id}","starred_url":"https://api.github.com/users/willjthorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willjthorp/subscriptions","organizations_url":"https://api.github.com/users/willjthorp/orgs","repos_url":"https://api.github.com/users/willjthorp/repos","events_url":"https://api.github.com/users/willjthorp/events{/privacy}","received_events_url":"https://api.github.com/users/willjthorp/received_events","type":"User","site_admin":false},"body":"Done everything apart from queue DOM stuff. For the stack DOM page, I tried to make the 'Stack Underflow\" / \"Stack Underflow\" error messages fadeIn() and fadeOut() but this does not seem to be happening, they just appear instantly, why is this?","created_at":"2017-08-24T07:06:22Z","updated_at":"2017-08-24T08:22:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6f571a8c9ec7d92066c3ec32e30ae81d858c1b7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/73/commits","review_comments_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/73/comments","review_comment_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/issues/73/comments","statuses_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/statuses/8119b0c3ec10236466481b5cdc697fdf35667841","head":{"label":"willjthorp:master","ref":"master","sha":"8119b0c3ec10236466481b5cdc697fdf35667841","user":{"login":"willjthorp","id":30321077,"avatar_url":"https://avatars3.githubusercontent.com/u/30321077?v=4","gravatar_id":"","url":"https://api.github.com/users/willjthorp","html_url":"https://github.com/willjthorp","followers_url":"https://api.github.com/users/willjthorp/followers","following_url":"https://api.github.com/users/willjthorp/following{/other_user}","gists_url":"https://api.github.com/users/willjthorp/gists{/gist_id}","starred_url":"https://api.github.com/users/willjthorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willjthorp/subscriptions","organizations_url":"https://api.github.com/users/willjthorp/orgs","repos_url":"https://api.github.com/users/willjthorp/repos","events_url":"https://api.github.com/users/willjthorp/events{/privacy}","received_events_url":"https://api.github.com/users/willjthorp/received_events","type":"User","site_admin":false},"repo":{"id":101180507,"name":"lab-javascript-advanced-algorithms","full_name":"willjthorp/lab-javascript-advanced-algorithms","owner":{"login":"willjthorp","id":30321077,"avatar_url":"https://avatars3.githubusercontent.com/u/30321077?v=4","gravatar_id":"","url":"https://api.github.com/users/willjthorp","html_url":"https://github.com/willjthorp","followers_url":"https://api.github.com/users/willjthorp/followers","following_url":"https://api.github.com/users/willjthorp/following{/other_user}","gists_url":"https://api.github.com/users/willjthorp/gists{/gist_id}","starred_url":"https://api.github.com/users/willjthorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willjthorp/subscriptions","organizations_url":"https://api.github.com/users/willjthorp/orgs","repos_url":"https://api.github.com/users/willjthorp/repos","events_url":"https://api.github.com/users/willjthorp/events{/privacy}","received_events_url":"https://api.github.com/users/willjthorp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/willjthorp/lab-javascript-advanced-algorithms","description":"An exercise to practice JavaScript and use testing to create a solution","fork":true,"url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms","forks_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/forks","keys_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/teams","hooks_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/hooks","issue_events_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/issues/events{/number}","events_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/events","assignees_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/assignees{/user}","branches_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/branches{/branch}","tags_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/tags","blobs_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/git/refs{/sha}","trees_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/statuses/{sha}","languages_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/languages","stargazers_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/stargazers","contributors_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/contributors","subscribers_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/subscribers","subscription_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/subscription","commits_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/commits{/sha}","git_commits_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/git/commits{/sha}","comments_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/comments{/number}","issue_comment_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/issues/comments{/number}","contents_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/contents/{+path}","compare_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/merges","archive_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/downloads","issues_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/issues{/number}","pulls_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/pulls{/number}","milestones_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/milestones{/number}","notifications_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/labels{/name}","releases_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/releases{/id}","deployments_url":"https://api.github.com/repos/willjthorp/lab-javascript-advanced-algorithms/deployments","created_at":"2017-08-23T13:01:12Z","updated_at":"2017-08-23T13:01:14Z","pushed_at":"2017-08-24T07:01:35Z","git_url":"git://github.com/willjthorp/lab-javascript-advanced-algorithms.git","ssh_url":"[email protected]:willjthorp/lab-javascript-advanced-algorithms.git","clone_url":"https://github.com/willjthorp/lab-javascript-advanced-algorithms.git","svn_url":"https://github.com/willjthorp/lab-javascript-advanced-algorithms","homepage":null,"size":74,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ironhack-labs:master","ref":"master","sha":"549b6f08b212a471d8f3706f90a5734c3f4af2f6","user":{"login":"ironhack-labs","id":25032046,"avatar_url":"https://avatars3.githubusercontent.com/u/25032046?v=4","gravatar_id":"","url":"https://api.github.com/users/ironhack-labs","html_url":"https://github.com/ironhack-labs","followers_url":"https://api.github.com/users/ironhack-labs/followers","following_url":"https://api.github.com/users/ironhack-labs/following{/other_user}","gists_url":"https://api.github.com/users/ironhack-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/ironhack-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironhack-labs/subscriptions","organizations_url":"https://api.github.com/users/ironhack-labs/orgs","repos_url":"https://api.github.com/users/ironhack-labs/repos","events_url":"https://api.github.com/users/ironhack-labs/events{/privacy}","received_events_url":"https://api.github.com/users/ironhack-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":78558169,"name":"lab-javascript-advanced-algorithms","full_name":"ironhack-labs/lab-javascript-advanced-algorithms","owner":{"login":"ironhack-labs","id":25032046,"avatar_url":"https://avatars3.githubusercontent.com/u/25032046?v=4","gravatar_id":"","url":"https://api.github.com/users/ironhack-labs","html_url":"https://github.com/ironhack-labs","followers_url":"https://api.github.com/users/ironhack-labs/followers","following_url":"https://api.github.com/users/ironhack-labs/following{/other_user}","gists_url":"https://api.github.com/users/ironhack-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/ironhack-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironhack-labs/subscriptions","organizations_url":"https://api.github.com/users/ironhack-labs/orgs","repos_url":"https://api.github.com/users/ironhack-labs/repos","events_url":"https://api.github.com/users/ironhack-labs/events{/privacy}","received_events_url":"https://api.github.com/users/ironhack-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ironhack-labs/lab-javascript-advanced-algorithms","description":"An exercise to practice JavaScript and use testing to create a solution","fork":false,"url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms","forks_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/forks","keys_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/teams","hooks_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/hooks","issue_events_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/issues/events{/number}","events_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/events","assignees_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/assignees{/user}","branches_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/branches{/branch}","tags_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/tags","blobs_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/git/refs{/sha}","trees_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/statuses/{sha}","languages_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/languages","stargazers_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/stargazers","contributors_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/contributors","subscribers_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/subscribers","subscription_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/subscription","commits_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/commits{/sha}","git_commits_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/git/commits{/sha}","comments_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/comments{/number}","issue_comment_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/issues/comments{/number}","contents_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/contents/{+path}","compare_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/merges","archive_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/downloads","issues_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/issues{/number}","pulls_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls{/number}","milestones_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/milestones{/number}","notifications_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/labels{/name}","releases_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/releases{/id}","deployments_url":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/deployments","created_at":"2017-01-10T17:44:23Z","updated_at":"2017-01-10T17:45:09Z","pushed_at":"2017-08-24T08:21:32Z","git_url":"git://github.com/ironhack-labs/lab-javascript-advanced-algorithms.git","ssh_url":"[email protected]:ironhack-labs/lab-javascript-advanced-algorithms.git","clone_url":"https://github.com/ironhack-labs/lab-javascript-advanced-algorithms.git","svn_url":"https://github.com/ironhack-labs/lab-javascript-advanced-algorithms","homepage":null,"size":72,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":119,"mirror_url":null,"open_issues_count":23,"forks":119,"open_issues":23,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/73"},"html":{"href":"https://github.com/ironhack-labs/lab-javascript-advanced-algorithms/pull/73"},"issue":{"href":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/issues/73"},"comments":{"href":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/issues/73/comments"},"review_comments":{"href":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/73/comments"},"review_comment":{"href":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/pulls/73/commits"},"statuses":{"href":"https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms/statuses/8119b0c3ec10236466481b5cdc697fdf35667841"}}}}
|
{
"id": 78558169,
"name": "ironhack-labs/lab-javascript-advanced-algorithms",
"url": "https://api.github.com/repos/ironhack-labs/lab-javascript-advanced-algorithms"
}
|
{
"id": 26812171,
"login": "tawebbcn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26812171?",
"url": "https://api.github.com/users/tawebbcn"
}
|
{
"id": 25032046,
"login": "ironhack-labs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25032046?",
"url": "https://api.github.com/orgs/ironhack-labs"
}
| 2017-08-24T08:22:10 |
6506274813
|
{"actor":{"display_login":"tawebbcn"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/pulls/comments/129232682","pull_request_review_id":51982548,"id":129232682,"diff_hunk":"@@ -0,0 +1,113 @@\n+{\n+ \"$schema\": \"http://json-schema.org/draft-04/schema#\",\n+ \"definitions\": {},\n+ \"id\": \"lunatech-core-curriculum-knowledge-graph-schema\",\n+ \"properties\": {","path":"core-curriculum/schema/knowledge-graph.json","position":5,"original_position":5,"commit_id":"23ffd238a50d2b3f3ced8dbedf6b9cf0f02e00aa","original_commit_id":"10cadf7eb74c937e9938cb4faa805af3cc246eb5","user":{"login":"eamelink","id":332784,"avatar_url":"https://avatars3.githubusercontent.com/u/332784?v=4","gravatar_id":"","url":"https://api.github.com/users/eamelink","html_url":"https://github.com/eamelink","followers_url":"https://api.github.com/users/eamelink/followers","following_url":"https://api.github.com/users/eamelink/following{/other_user}","gists_url":"https://api.github.com/users/eamelink/gists{/gist_id}","starred_url":"https://api.github.com/users/eamelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eamelink/subscriptions","organizations_url":"https://api.github.com/users/eamelink/orgs","repos_url":"https://api.github.com/users/eamelink/repos","events_url":"https://api.github.com/users/eamelink/events{/privacy}","received_events_url":"https://api.github.com/users/eamelink/received_events","type":"User","site_admin":false},"body":"Ah yes, I didn't mean to put the SVG in the json, a path would be fine there :)","created_at":"2017-07-25T07:42:16Z","updated_at":"2017-07-25T07:42:16Z","html_url":"https://github.com/lunatech-labs/lunatech-competence-center-online/pull/68#discussion_r129232682","pull_request_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/pulls/comments/129232682"},"html":{"href":"https://github.com/lunatech-labs/lunatech-competence-center-online/pull/68#discussion_r129232682"},"pull_request":{"href":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/pulls/68","id":131903180,"html_url":"https://github.com/lunatech-labs/lunatech-competence-center-online/pull/68","diff_url":"https://github.com/lunatech-labs/lunatech-competence-center-online/pull/68.diff","patch_url":"https://github.com/lunatech-labs/lunatech-competence-center-online/pull/68.patch","issue_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/issues/68","number":68,"state":"open","locked":false,"title":"CC - Initial commit","user":{"login":"nMoncho","id":1565948,"avatar_url":"https://avatars1.githubusercontent.com/u/1565948?v=4","gravatar_id":"","url":"https://api.github.com/users/nMoncho","html_url":"https://github.com/nMoncho","followers_url":"https://api.github.com/users/nMoncho/followers","following_url":"https://api.github.com/users/nMoncho/following{/other_user}","gists_url":"https://api.github.com/users/nMoncho/gists{/gist_id}","starred_url":"https://api.github.com/users/nMoncho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nMoncho/subscriptions","organizations_url":"https://api.github.com/users/nMoncho/orgs","repos_url":"https://api.github.com/users/nMoncho/repos","events_url":"https://api.github.com/users/nMoncho/events{/privacy}","received_events_url":"https://api.github.com/users/nMoncho/received_events","type":"User","site_admin":false},"body":"Still WIP, just wanted to upload the schema, a readme and a short example.\r\nBefore submitting the final PR, will upload the whole Scala Knowledge graph.","created_at":"2017-07-22T15:39:12Z","updated_at":"2017-07-25T07:42:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a65e87a506f187b822d072ee47a4e9f126470471","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/pulls/68/commits","review_comments_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/pulls/68/comments","review_comment_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/issues/68/comments","statuses_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/statuses/23ffd238a50d2b3f3ced8dbedf6b9cf0f02e00aa","head":{"label":"lunatech-labs:cc-initial","ref":"cc-initial","sha":"23ffd238a50d2b3f3ced8dbedf6b9cf0f02e00aa","user":{"login":"lunatech-labs","id":329359,"avatar_url":"https://avatars2.githubusercontent.com/u/329359?v=4","gravatar_id":"","url":"https://api.github.com/users/lunatech-labs","html_url":"https://github.com/lunatech-labs","followers_url":"https://api.github.com/users/lunatech-labs/followers","following_url":"https://api.github.com/users/lunatech-labs/following{/other_user}","gists_url":"https://api.github.com/users/lunatech-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/lunatech-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunatech-labs/subscriptions","organizations_url":"https://api.github.com/users/lunatech-labs/orgs","repos_url":"https://api.github.com/users/lunatech-labs/repos","events_url":"https://api.github.com/users/lunatech-labs/events{/privacy}","received_events_url":"https://api.github.com/users/lunatech-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":89005663,"name":"lunatech-competence-center-online","full_name":"lunatech-labs/lunatech-competence-center-online","owner":{"login":"lunatech-labs","id":329359,"avatar_url":"https://avatars2.githubusercontent.com/u/329359?v=4","gravatar_id":"","url":"https://api.github.com/users/lunatech-labs","html_url":"https://github.com/lunatech-labs","followers_url":"https://api.github.com/users/lunatech-labs/followers","following_url":"https://api.github.com/users/lunatech-labs/following{/other_user}","gists_url":"https://api.github.com/users/lunatech-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/lunatech-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunatech-labs/subscriptions","organizations_url":"https://api.github.com/users/lunatech-labs/orgs","repos_url":"https://api.github.com/users/lunatech-labs/repos","events_url":"https://api.github.com/users/lunatech-labs/events{/privacy}","received_events_url":"https://api.github.com/users/lunatech-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lunatech-labs/lunatech-competence-center-online","description":"CCO is the Competence Center Online.","fork":false,"url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online","forks_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/forks","keys_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/teams","hooks_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/hooks","issue_events_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/issues/events{/number}","events_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/events","assignees_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/assignees{/user}","branches_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/branches{/branch}","tags_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/tags","blobs_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/git/refs{/sha}","trees_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/statuses/{sha}","languages_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/languages","stargazers_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/stargazers","contributors_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/contributors","subscribers_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/subscribers","subscription_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/subscription","commits_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/commits{/sha}","git_commits_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/git/commits{/sha}","comments_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/comments{/number}","issue_comment_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/issues/comments{/number}","contents_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/contents/{+path}","compare_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/merges","archive_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/downloads","issues_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/issues{/number}","pulls_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/pulls{/number}","milestones_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/milestones{/number}","notifications_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/labels{/name}","releases_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/releases{/id}","deployments_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/deployments","created_at":"2017-04-21T16:55:11Z","updated_at":"2017-07-21T11:56:39Z","pushed_at":"2017-07-25T07:30:20Z","git_url":"git://github.com/lunatech-labs/lunatech-competence-center-online.git","ssh_url":"[email protected]:lunatech-labs/lunatech-competence-center-online.git","clone_url":"https://github.com/lunatech-labs/lunatech-competence-center-online.git","svn_url":"https://github.com/lunatech-labs/lunatech-competence-center-online","homepage":null,"size":11542,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":24,"forks":0,"open_issues":24,"watchers":0,"default_branch":"master"}},"base":{"label":"lunatech-labs:master","ref":"master","sha":"a3cd53c289a3392711dca97d04b5259725755815","user":{"login":"lunatech-labs","id":329359,"avatar_url":"https://avatars2.githubusercontent.com/u/329359?v=4","gravatar_id":"","url":"https://api.github.com/users/lunatech-labs","html_url":"https://github.com/lunatech-labs","followers_url":"https://api.github.com/users/lunatech-labs/followers","following_url":"https://api.github.com/users/lunatech-labs/following{/other_user}","gists_url":"https://api.github.com/users/lunatech-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/lunatech-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunatech-labs/subscriptions","organizations_url":"https://api.github.com/users/lunatech-labs/orgs","repos_url":"https://api.github.com/users/lunatech-labs/repos","events_url":"https://api.github.com/users/lunatech-labs/events{/privacy}","received_events_url":"https://api.github.com/users/lunatech-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":89005663,"name":"lunatech-competence-center-online","full_name":"lunatech-labs/lunatech-competence-center-online","owner":{"login":"lunatech-labs","id":329359,"avatar_url":"https://avatars2.githubusercontent.com/u/329359?v=4","gravatar_id":"","url":"https://api.github.com/users/lunatech-labs","html_url":"https://github.com/lunatech-labs","followers_url":"https://api.github.com/users/lunatech-labs/followers","following_url":"https://api.github.com/users/lunatech-labs/following{/other_user}","gists_url":"https://api.github.com/users/lunatech-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/lunatech-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunatech-labs/subscriptions","organizations_url":"https://api.github.com/users/lunatech-labs/orgs","repos_url":"https://api.github.com/users/lunatech-labs/repos","events_url":"https://api.github.com/users/lunatech-labs/events{/privacy}","received_events_url":"https://api.github.com/users/lunatech-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lunatech-labs/lunatech-competence-center-online","description":"CCO is the Competence Center Online.","fork":false,"url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online","forks_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/forks","keys_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/teams","hooks_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/hooks","issue_events_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/issues/events{/number}","events_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/events","assignees_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/assignees{/user}","branches_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/branches{/branch}","tags_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/tags","blobs_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/git/refs{/sha}","trees_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/statuses/{sha}","languages_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/languages","stargazers_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/stargazers","contributors_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/contributors","subscribers_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/subscribers","subscription_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/subscription","commits_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/commits{/sha}","git_commits_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/git/commits{/sha}","comments_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/comments{/number}","issue_comment_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/issues/comments{/number}","contents_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/contents/{+path}","compare_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/merges","archive_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/downloads","issues_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/issues{/number}","pulls_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/pulls{/number}","milestones_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/milestones{/number}","notifications_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/labels{/name}","releases_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/releases{/id}","deployments_url":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/deployments","created_at":"2017-04-21T16:55:11Z","updated_at":"2017-07-21T11:56:39Z","pushed_at":"2017-07-25T07:30:20Z","git_url":"git://github.com/lunatech-labs/lunatech-competence-center-online.git","ssh_url":"[email protected]:lunatech-labs/lunatech-competence-center-online.git","clone_url":"https://github.com/lunatech-labs/lunatech-competence-center-online.git","svn_url":"https://github.com/lunatech-labs/lunatech-competence-center-online","homepage":null,"size":11542,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":24,"forks":0,"open_issues":24,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/pulls/68"},"html":{"href":"https://github.com/lunatech-labs/lunatech-competence-center-online/pull/68"},"issue":{"href":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/issues/68"},"comments":{"href":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online/statuses/23ffd238a50d2b3f3ced8dbedf6b9cf0f02e00aa"}}}}
|
{
"id": 89005663,
"name": "lunatech-labs/lunatech-competence-center-online",
"url": "https://api.github.com/repos/lunatech-labs/lunatech-competence-center-online"
}
|
{
"id": 332784,
"login": "eamelink",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/332784?",
"url": "https://api.github.com/users/eamelink"
}
|
{
"id": 329359,
"login": "lunatech-labs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/329359?",
"url": "https://api.github.com/orgs/lunatech-labs"
}
| 2017-07-25T07:42:16 |
6321825101
|
{"actor":{"display_login":"eamelink"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/comments/131528343","pull_request_review_id":54521342,"id":131528343,"diff_hunk":"@@ -0,0 +1,39 @@\n+require_relative 'computer'\n+require_relative 'player'\n+\n+class Game\n+\n+ attr_reader :player1, :player2, :choices, :player1_weapon, :player2_weapon\n+\n+ WIN_COMBINATION = [[\"Rock\",\"Scissors\"],[\"Scissors\",\"Paper\"],[\"Paper\",\"Rock\"]]\n+\n+\n+ def initialize(player1,player2)\n+ @player1 = player1\n+ @player2 = player2\n+ @choices = []\n+ @player1_weapon = nil\n+ @player2_weapon = nil\n+ end\n+\n+ def self.create(player1,player2)\n+ @game = Game.new(player1,player2)\n+ end\n+\n+ def self.instance\n+ @game||= Game.new\n+ end\n+\n+ def calc_result\n+ @player1_weapon = @player1.weapon\n+ @player2_weapon = @player2.generate_weapon\n+ @choices = [@player1_weapon,@player2_weapon]\n+ if @choices[0] == @choices[1]\n+ \"Draw\"\n+ elsif WIN_COMBINATION.include? @choices\n+ \"#{@player1.name} Wins!\"","path":"lib/game.rb","position":34,"original_position":34,"commit_id":"1bb1c23d182f6d46b1bc4087a6f1000fd43302a9","original_commit_id":"1bb1c23d182f6d46b1bc4087a6f1000fd43302a9","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Use 2 (not 3) spaces for indentation.","created_at":"2017-08-05T19:39:52Z","updated_at":"2017-08-05T19:39:52Z","html_url":"https://github.com/makersacademy/rps-challenge/pull/764#discussion_r131528343","pull_request_url":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/764","_links":{"self":{"href":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/comments/131528343"},"html":{"href":"https://github.com/makersacademy/rps-challenge/pull/764#discussion_r131528343"},"pull_request":{"href":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/764"}}},"pull_request":{"url":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/764","id":134296566,"html_url":"https://github.com/makersacademy/rps-challenge/pull/764","diff_url":"https://github.com/makersacademy/rps-challenge/pull/764.diff","patch_url":"https://github.com/makersacademy/rps-challenge/pull/764.patch","issue_url":"https://api.github.com/repos/makersacademy/rps-challenge/issues/764","number":764,"state":"open","locked":false,"title":"Completed RPS challenge","user":{"login":"Nandhini31","id":10114868,"avatar_url":"https://avatars3.githubusercontent.com/u/10114868?v=4","gravatar_id":"","url":"https://api.github.com/users/Nandhini31","html_url":"https://github.com/Nandhini31","followers_url":"https://api.github.com/users/Nandhini31/followers","following_url":"https://api.github.com/users/Nandhini31/following{/other_user}","gists_url":"https://api.github.com/users/Nandhini31/gists{/gist_id}","starred_url":"https://api.github.com/users/Nandhini31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nandhini31/subscriptions","organizations_url":"https://api.github.com/users/Nandhini31/orgs","repos_url":"https://api.github.com/users/Nandhini31/repos","events_url":"https://api.github.com/users/Nandhini31/events{/privacy}","received_events_url":"https://api.github.com/users/Nandhini31/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-05T16:17:28Z","updated_at":"2017-08-05T19:39:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"789fef5137de1524e67032c7ff3c9a1e97a3b578","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/764/commits","review_comments_url":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/764/comments","review_comment_url":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/makersacademy/rps-challenge/issues/764/comments","statuses_url":"https://api.github.com/repos/makersacademy/rps-challenge/statuses/1bb1c23d182f6d46b1bc4087a6f1000fd43302a9","head":{"label":"Nandhini31:master","ref":"master","sha":"1bb1c23d182f6d46b1bc4087a6f1000fd43302a9","user":{"login":"Nandhini31","id":10114868,"avatar_url":"https://avatars3.githubusercontent.com/u/10114868?v=4","gravatar_id":"","url":"https://api.github.com/users/Nandhini31","html_url":"https://github.com/Nandhini31","followers_url":"https://api.github.com/users/Nandhini31/followers","following_url":"https://api.github.com/users/Nandhini31/following{/other_user}","gists_url":"https://api.github.com/users/Nandhini31/gists{/gist_id}","starred_url":"https://api.github.com/users/Nandhini31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nandhini31/subscriptions","organizations_url":"https://api.github.com/users/Nandhini31/orgs","repos_url":"https://api.github.com/users/Nandhini31/repos","events_url":"https://api.github.com/users/Nandhini31/events{/privacy}","received_events_url":"https://api.github.com/users/Nandhini31/received_events","type":"User","site_admin":false},"repo":{"id":99416309,"name":"rps-challenge","full_name":"Nandhini31/rps-challenge","owner":{"login":"Nandhini31","id":10114868,"avatar_url":"https://avatars3.githubusercontent.com/u/10114868?v=4","gravatar_id":"","url":"https://api.github.com/users/Nandhini31","html_url":"https://github.com/Nandhini31","followers_url":"https://api.github.com/users/Nandhini31/followers","following_url":"https://api.github.com/users/Nandhini31/following{/other_user}","gists_url":"https://api.github.com/users/Nandhini31/gists{/gist_id}","starred_url":"https://api.github.com/users/Nandhini31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nandhini31/subscriptions","organizations_url":"https://api.github.com/users/Nandhini31/orgs","repos_url":"https://api.github.com/users/Nandhini31/repos","events_url":"https://api.github.com/users/Nandhini31/events{/privacy}","received_events_url":"https://api.github.com/users/Nandhini31/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nandhini31/rps-challenge","description":"Create the Rock Paper Scissors Game","fork":true,"url":"https://api.github.com/repos/Nandhini31/rps-challenge","forks_url":"https://api.github.com/repos/Nandhini31/rps-challenge/forks","keys_url":"https://api.github.com/repos/Nandhini31/rps-challenge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nandhini31/rps-challenge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nandhini31/rps-challenge/teams","hooks_url":"https://api.github.com/repos/Nandhini31/rps-challenge/hooks","issue_events_url":"https://api.github.com/repos/Nandhini31/rps-challenge/issues/events{/number}","events_url":"https://api.github.com/repos/Nandhini31/rps-challenge/events","assignees_url":"https://api.github.com/repos/Nandhini31/rps-challenge/assignees{/user}","branches_url":"https://api.github.com/repos/Nandhini31/rps-challenge/branches{/branch}","tags_url":"https://api.github.com/repos/Nandhini31/rps-challenge/tags","blobs_url":"https://api.github.com/repos/Nandhini31/rps-challenge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nandhini31/rps-challenge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nandhini31/rps-challenge/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nandhini31/rps-challenge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nandhini31/rps-challenge/statuses/{sha}","languages_url":"https://api.github.com/repos/Nandhini31/rps-challenge/languages","stargazers_url":"https://api.github.com/repos/Nandhini31/rps-challenge/stargazers","contributors_url":"https://api.github.com/repos/Nandhini31/rps-challenge/contributors","subscribers_url":"https://api.github.com/repos/Nandhini31/rps-challenge/subscribers","subscription_url":"https://api.github.com/repos/Nandhini31/rps-challenge/subscription","commits_url":"https://api.github.com/repos/Nandhini31/rps-challenge/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nandhini31/rps-challenge/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nandhini31/rps-challenge/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nandhini31/rps-challenge/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nandhini31/rps-challenge/contents/{+path}","compare_url":"https://api.github.com/repos/Nandhini31/rps-challenge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nandhini31/rps-challenge/merges","archive_url":"https://api.github.com/repos/Nandhini31/rps-challenge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nandhini31/rps-challenge/downloads","issues_url":"https://api.github.com/repos/Nandhini31/rps-challenge/issues{/number}","pulls_url":"https://api.github.com/repos/Nandhini31/rps-challenge/pulls{/number}","milestones_url":"https://api.github.com/repos/Nandhini31/rps-challenge/milestones{/number}","notifications_url":"https://api.github.com/repos/Nandhini31/rps-challenge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nandhini31/rps-challenge/labels{/name}","releases_url":"https://api.github.com/repos/Nandhini31/rps-challenge/releases{/id}","deployments_url":"https://api.github.com/repos/Nandhini31/rps-challenge/deployments","created_at":"2017-08-05T10:35:16Z","updated_at":"2017-08-05T10:35:18Z","pushed_at":"2017-08-05T19:39:37Z","git_url":"git://github.com/Nandhini31/rps-challenge.git","ssh_url":"[email protected]:Nandhini31/rps-challenge.git","clone_url":"https://github.com/Nandhini31/rps-challenge.git","svn_url":"https://github.com/Nandhini31/rps-challenge","homepage":null,"size":296,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"makersacademy:master","ref":"master","sha":"0592615f331bb63cc43307e4a4c45e0648b478a2","user":{"login":"makersacademy","id":3636186,"avatar_url":"https://avatars2.githubusercontent.com/u/3636186?v=4","gravatar_id":"","url":"https://api.github.com/users/makersacademy","html_url":"https://github.com/makersacademy","followers_url":"https://api.github.com/users/makersacademy/followers","following_url":"https://api.github.com/users/makersacademy/following{/other_user}","gists_url":"https://api.github.com/users/makersacademy/gists{/gist_id}","starred_url":"https://api.github.com/users/makersacademy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makersacademy/subscriptions","organizations_url":"https://api.github.com/users/makersacademy/orgs","repos_url":"https://api.github.com/users/makersacademy/repos","events_url":"https://api.github.com/users/makersacademy/events{/privacy}","received_events_url":"https://api.github.com/users/makersacademy/received_events","type":"Organization","site_admin":false},"repo":{"id":27006066,"name":"rps-challenge","full_name":"makersacademy/rps-challenge","owner":{"login":"makersacademy","id":3636186,"avatar_url":"https://avatars2.githubusercontent.com/u/3636186?v=4","gravatar_id":"","url":"https://api.github.com/users/makersacademy","html_url":"https://github.com/makersacademy","followers_url":"https://api.github.com/users/makersacademy/followers","following_url":"https://api.github.com/users/makersacademy/following{/other_user}","gists_url":"https://api.github.com/users/makersacademy/gists{/gist_id}","starred_url":"https://api.github.com/users/makersacademy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makersacademy/subscriptions","organizations_url":"https://api.github.com/users/makersacademy/orgs","repos_url":"https://api.github.com/users/makersacademy/repos","events_url":"https://api.github.com/users/makersacademy/events{/privacy}","received_events_url":"https://api.github.com/users/makersacademy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/makersacademy/rps-challenge","description":"Create the Rock Paper Scissors Game","fork":false,"url":"https://api.github.com/repos/makersacademy/rps-challenge","forks_url":"https://api.github.com/repos/makersacademy/rps-challenge/forks","keys_url":"https://api.github.com/repos/makersacademy/rps-challenge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/makersacademy/rps-challenge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/makersacademy/rps-challenge/teams","hooks_url":"https://api.github.com/repos/makersacademy/rps-challenge/hooks","issue_events_url":"https://api.github.com/repos/makersacademy/rps-challenge/issues/events{/number}","events_url":"https://api.github.com/repos/makersacademy/rps-challenge/events","assignees_url":"https://api.github.com/repos/makersacademy/rps-challenge/assignees{/user}","branches_url":"https://api.github.com/repos/makersacademy/rps-challenge/branches{/branch}","tags_url":"https://api.github.com/repos/makersacademy/rps-challenge/tags","blobs_url":"https://api.github.com/repos/makersacademy/rps-challenge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/makersacademy/rps-challenge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/makersacademy/rps-challenge/git/refs{/sha}","trees_url":"https://api.github.com/repos/makersacademy/rps-challenge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/makersacademy/rps-challenge/statuses/{sha}","languages_url":"https://api.github.com/repos/makersacademy/rps-challenge/languages","stargazers_url":"https://api.github.com/repos/makersacademy/rps-challenge/stargazers","contributors_url":"https://api.github.com/repos/makersacademy/rps-challenge/contributors","subscribers_url":"https://api.github.com/repos/makersacademy/rps-challenge/subscribers","subscription_url":"https://api.github.com/repos/makersacademy/rps-challenge/subscription","commits_url":"https://api.github.com/repos/makersacademy/rps-challenge/commits{/sha}","git_commits_url":"https://api.github.com/repos/makersacademy/rps-challenge/git/commits{/sha}","comments_url":"https://api.github.com/repos/makersacademy/rps-challenge/comments{/number}","issue_comment_url":"https://api.github.com/repos/makersacademy/rps-challenge/issues/comments{/number}","contents_url":"https://api.github.com/repos/makersacademy/rps-challenge/contents/{+path}","compare_url":"https://api.github.com/repos/makersacademy/rps-challenge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/makersacademy/rps-challenge/merges","archive_url":"https://api.github.com/repos/makersacademy/rps-challenge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/makersacademy/rps-challenge/downloads","issues_url":"https://api.github.com/repos/makersacademy/rps-challenge/issues{/number}","pulls_url":"https://api.github.com/repos/makersacademy/rps-challenge/pulls{/number}","milestones_url":"https://api.github.com/repos/makersacademy/rps-challenge/milestones{/number}","notifications_url":"https://api.github.com/repos/makersacademy/rps-challenge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/makersacademy/rps-challenge/labels{/name}","releases_url":"https://api.github.com/repos/makersacademy/rps-challenge/releases{/id}","deployments_url":"https://api.github.com/repos/makersacademy/rps-challenge/deployments","created_at":"2014-11-22T17:15:17Z","updated_at":"2017-05-10T12:41:15Z","pushed_at":"2017-08-05T19:39:39Z","git_url":"git://github.com/makersacademy/rps-challenge.git","ssh_url":"[email protected]:makersacademy/rps-challenge.git","clone_url":"https://github.com/makersacademy/rps-challenge.git","svn_url":"https://github.com/makersacademy/rps-challenge","homepage":null,"size":66,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":750,"mirror_url":null,"open_issues_count":356,"forks":750,"open_issues":356,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/764"},"html":{"href":"https://github.com/makersacademy/rps-challenge/pull/764"},"issue":{"href":"https://api.github.com/repos/makersacademy/rps-challenge/issues/764"},"comments":{"href":"https://api.github.com/repos/makersacademy/rps-challenge/issues/764/comments"},"review_comments":{"href":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/764/comments"},"review_comment":{"href":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/makersacademy/rps-challenge/pulls/764/commits"},"statuses":{"href":"https://api.github.com/repos/makersacademy/rps-challenge/statuses/1bb1c23d182f6d46b1bc4087a6f1000fd43302a9"}}}}
|
{
"id": 27006066,
"name": "makersacademy/rps-challenge",
"url": "https://api.github.com/repos/makersacademy/rps-challenge"
}
|
{
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
}
|
{
"id": 3636186,
"login": "makersacademy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3636186?",
"url": "https://api.github.com/orgs/makersacademy"
}
| 2017-08-05T19:39:52 |
6401311098
|
{"actor":{"display_login":"houndci-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/139081937","pull_request_review_id":62966416,"id":139081937,"diff_hunk":"@@ -1507,96 +850,13 @@ void LoadEventNexus::loadEvents(API::Progress *const prog,\n static_cast<double>(std::numeric_limits<uint32_t>::max()) * 0.1;\n longest_tof = 0.;\n \n- // Make the thread pool\n- ThreadScheduler *scheduler = new ThreadSchedulerMutexes();\n- ThreadPool pool(scheduler);\n- auto diskIOMutex = boost::make_shared<std::mutex>();\n- size_t bank0 = 0;\n- size_t bankn = bankNames.size();\n-\n- if (chunk !=\n- EMPTY_INT()) // We are loading part - work out the bank number range\n- {\n- eventsPerChunk = total_events / totalChunks;\n- // Sort banks by size\n- size_t tmp;\n- string stmp;\n- for (size_t i = 0; i < bankn; i++)\n- for (size_t j = 0; j < bankn - 1; j++)\n- if (bankNumEvents[j] < bankNumEvents[j + 1]) {\n- tmp = bankNumEvents[j];\n- bankNumEvents[j] = bankNumEvents[j + 1];\n- bankNumEvents[j + 1] = tmp;\n- stmp = bankNames[j];\n- bankNames[j] = bankNames[j + 1];\n- bankNames[j + 1] = stmp;\n- }\n- int bigBanks = 0;\n- for (size_t i = 0; i < bankn; i++)\n- if (bankNumEvents[i] > eventsPerChunk)\n- bigBanks++;\n- // Each chunk is part of bank or multiple whole banks\n- // 0.5 for last chunk of a bank with multiple chunks\n- // 0.1 for multiple whole banks not completely filled\n- eventsPerChunk +=\n- static_cast<size_t>((static_cast<double>(bigBanks) /\n- static_cast<double>(totalChunks) * 0.5 +\n- 0.05) *\n- static_cast<double>(eventsPerChunk));\n- double partialChunk = 0.;\n- firstChunkForBank = 1;\n- for (int chunki = 1; chunki <= chunk; chunki++) {\n- if (partialChunk > 1.) {\n- partialChunk = 0.;\n- firstChunkForBank = chunki;\n- bank0 = bankn;\n- }\n- if (bankNumEvents[bank0] > 1) {\n- partialChunk += static_cast<double>(eventsPerChunk) /\n- static_cast<double>(bankNumEvents[bank0]);\n- }\n- if (chunki < totalChunks)\n- bankn = bank0 + 1;\n- else\n- bankn = bankNames.size();\n- if (chunki == firstChunkForBank && partialChunk > 1.0)\n- bankn += static_cast<size_t>(partialChunk) - 1;\n- if (bankn > bankNames.size())\n- bankn = bankNames.size();\n- }\n- for (size_t i = bank0; i < bankn; i++) {\n- size_t start_event = (chunk - firstChunkForBank) * eventsPerChunk;\n- size_t stop_event = bankNumEvents[i];\n- // Don't change stop_event for the final chunk\n- if (start_event + eventsPerChunk < stop_event)\n- stop_event = start_event + eventsPerChunk;\n- bankNumEvents[i] = stop_event - start_event;\n- }\n- }\n-\n- // split banks up if the number of cores is more than twice the number of\n- // banks\n- splitProcessing =\n- bool(bankNames.size() * 2 < ThreadPool::getNumPhysicalCores());\n-\n- // set up progress bar for the rest of the (multi-threaded) process\n- size_t numProg = bankNames.size() * (1 + 3); // 1 = disktask, 3 = proc task\n- if (splitProcessing)\n- numProg += bankNames.size() * 3; // 3 = second proc task\n- auto prog2 = make_unique<Progress>(this, 0.3, 1.0, numProg);\n-\n- const std::vector<int> periodLogVec = periodLog->valuesAsVector();\n-\n- for (size_t i = bank0; i < bankn; i++) {\n- // We make tasks for loading\n- if (bankNumEvents[i] > 0)\n- pool.schedule(new LoadBankFromDiskTask(\n- this, bankNames[i], classType, bankNumEvents[i], oldNeXusFileNames,\n- prog2.get(), diskIOMutex, scheduler, periodLogVec));\n- }\n- // Start and end all threads\n- pool.joinAll();\n- diskIOMutex.reset();\n+ bool precount = getProperty(\"Precount\");\n+ int chunk = getProperty(\"ChunkNumber\");\n+ int totalChunks = getProperty(\"TotalChunks\");\n+ DefaultEventLoader::load(this, *m_ws, haveWeights, event_id_is_spec,","path":"Framework/DataHandling/src/LoadEventNexus.cpp","position":871,"original_position":871,"commit_id":"7c6f6bd9f0753ca9a949d4dea7466d5144ba2100","original_commit_id":"7c6f6bd9f0753ca9a949d4dea7466d5144ba2100","user":{"login":"OwenArnold","id":1109536,"avatar_url":"https://avatars3.githubusercontent.com/u/1109536?v=4","gravatar_id":"","url":"https://api.github.com/users/OwenArnold","html_url":"https://github.com/OwenArnold","followers_url":"https://api.github.com/users/OwenArnold/followers","following_url":"https://api.github.com/users/OwenArnold/following{/other_user}","gists_url":"https://api.github.com/users/OwenArnold/gists{/gist_id}","starred_url":"https://api.github.com/users/OwenArnold/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OwenArnold/subscriptions","organizations_url":"https://api.github.com/users/OwenArnold/orgs","repos_url":"https://api.github.com/users/OwenArnold/repos","events_url":"https://api.github.com/users/OwenArnold/events{/privacy}","received_events_url":"https://api.github.com/users/OwenArnold/received_events","type":"User","site_admin":false},"body":"Maybe this suggests that some further refactoring is needed later. Leave it as `Default` for now. I don't have a better suggestion.","created_at":"2017-09-15T07:35:39Z","updated_at":"2017-09-15T07:35:39Z","html_url":"https://github.com/mantidproject/mantid/pull/20425#discussion_r139081937","pull_request_url":"https://api.github.com/repos/mantidproject/mantid/pulls/20425","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments/139081937"},"html":{"href":"https://github.com/mantidproject/mantid/pull/20425#discussion_r139081937"},"pull_request":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/20425"}},"in_reply_to_id":138884964},"pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/20425","id":140307717,"html_url":"https://github.com/mantidproject/mantid/pull/20425","diff_url":"https://github.com/mantidproject/mantid/pull/20425.diff","patch_url":"https://github.com/mantidproject/mantid/pull/20425.patch","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/20425","number":20425,"state":"closed","locked":false,"title":"Some cleanup in LoadEventNexus","user":{"login":"SimonHeybrock","id":12912489,"avatar_url":"https://avatars1.githubusercontent.com/u/12912489?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonHeybrock","html_url":"https://github.com/SimonHeybrock","followers_url":"https://api.github.com/users/SimonHeybrock/followers","following_url":"https://api.github.com/users/SimonHeybrock/following{/other_user}","gists_url":"https://api.github.com/users/SimonHeybrock/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonHeybrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonHeybrock/subscriptions","organizations_url":"https://api.github.com/users/SimonHeybrock/orgs","repos_url":"https://api.github.com/users/SimonHeybrock/repos","events_url":"https://api.github.com/users/SimonHeybrock/events{/privacy}","received_events_url":"https://api.github.com/users/SimonHeybrock/received_events","type":"User","site_admin":false},"body":"Extract some code from `LoadEventNexus` and move it to separate files/classes. This is a preparation for having an alternative loader for event data.\r\n\r\nNote that dependency issues have not been cleaned up, such that, e.g., `LoadBankFromDiskTask` is still referencing internal variables in `LoadEventNexus` (and `DefaultEventLoader` to which some of the code has been migrated). I think this is beyond the scope of this PR an can be dealt with later if necessary.\r\n\r\n**To test:**\r\n\r\nCode review might become easier when reviewing each commit individually instead of the full set of changes. Each commit is mostly just moving around code.\r\n\r\nFixes #20419. \r\nInternal change -> no release notes.\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [ ] Is the code of an acceptable quality?\r\n- [ ] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)?\r\n- [ ] Are the unit tests small and test the class in isolation?\r\n- [ ] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [ ] Do changes function as described? Add comments below that describe the tests performed?\r\n- [ ] Do the changes handle unexpected situations, e.g. bad input?\r\n- [ ] Has the relevant (user and developer) documentation been added/updated?\r\n\r\nDoes everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it.\r\n","created_at":"2017-09-11T11:10:36Z","updated_at":"2017-09-15T07:35:39Z","closed_at":"2017-09-14T13:16:26Z","merged_at":"2017-09-14T13:16:26Z","merge_commit_sha":"df5fa3da1102827c4a42a420ddf2489f6f56c52e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/65","html_url":"https://github.com/mantidproject/mantid/milestone/65","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/65/labels","id":2590252,"number":65,"title":"Release 3.12 (4.0?)","description":"","creator":{"login":"NickDraper","id":1017173,"avatar_url":"https://avatars1.githubusercontent.com/u/1017173?v=4","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false},"open_issues":45,"closed_issues":1,"state":"open","created_at":"2017-06-19T08:22:22Z","updated_at":"2017-09-14T15:43:59Z","due_on":"2018-02-05T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mantidproject/mantid/pulls/20425/commits","review_comments_url":"https://api.github.com/repos/mantidproject/mantid/pulls/20425/comments","review_comment_url":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/20425/comments","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/7c6f6bd9f0753ca9a949d4dea7466d5144ba2100","head":{"label":"mantidproject:20419_cleanup_LoadEventNexus","ref":"20419_cleanup_LoadEventNexus","sha":"7c6f6bd9f0753ca9a949d4dea7466d5144ba2100","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2017-09-03T16:10:29Z","pushed_at":"2017-09-15T07:30:51Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"[email protected]:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":442756,"stargazers_count":61,"watchers_count":61,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":1689,"forks":45,"open_issues":1689,"watchers":61,"default_branch":"master"}},"base":{"label":"mantidproject:parallel_event_loader","ref":"parallel_event_loader","sha":"417df931cb7793d04a05508fd50a15ca31771c9e","user":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"repo":{"id":2594116,"name":"mantid","full_name":"mantidproject/mantid","owner":{"login":"mantidproject","id":671496,"avatar_url":"https://avatars0.githubusercontent.com/u/671496?v=4","gravatar_id":"","url":"https://api.github.com/users/mantidproject","html_url":"https://github.com/mantidproject","followers_url":"https://api.github.com/users/mantidproject/followers","following_url":"https://api.github.com/users/mantidproject/following{/other_user}","gists_url":"https://api.github.com/users/mantidproject/gists{/gist_id}","starred_url":"https://api.github.com/users/mantidproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantidproject/subscriptions","organizations_url":"https://api.github.com/users/mantidproject/orgs","repos_url":"https://api.github.com/users/mantidproject/repos","events_url":"https://api.github.com/users/mantidproject/events{/privacy}","received_events_url":"https://api.github.com/users/mantidproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mantidproject/mantid","description":"Main repository for Mantid code","fork":false,"url":"https://api.github.com/repos/mantidproject/mantid","forks_url":"https://api.github.com/repos/mantidproject/mantid/forks","keys_url":"https://api.github.com/repos/mantidproject/mantid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mantidproject/mantid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mantidproject/mantid/teams","hooks_url":"https://api.github.com/repos/mantidproject/mantid/hooks","issue_events_url":"https://api.github.com/repos/mantidproject/mantid/issues/events{/number}","events_url":"https://api.github.com/repos/mantidproject/mantid/events","assignees_url":"https://api.github.com/repos/mantidproject/mantid/assignees{/user}","branches_url":"https://api.github.com/repos/mantidproject/mantid/branches{/branch}","tags_url":"https://api.github.com/repos/mantidproject/mantid/tags","blobs_url":"https://api.github.com/repos/mantidproject/mantid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mantidproject/mantid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mantidproject/mantid/git/refs{/sha}","trees_url":"https://api.github.com/repos/mantidproject/mantid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mantidproject/mantid/statuses/{sha}","languages_url":"https://api.github.com/repos/mantidproject/mantid/languages","stargazers_url":"https://api.github.com/repos/mantidproject/mantid/stargazers","contributors_url":"https://api.github.com/repos/mantidproject/mantid/contributors","subscribers_url":"https://api.github.com/repos/mantidproject/mantid/subscribers","subscription_url":"https://api.github.com/repos/mantidproject/mantid/subscription","commits_url":"https://api.github.com/repos/mantidproject/mantid/commits{/sha}","git_commits_url":"https://api.github.com/repos/mantidproject/mantid/git/commits{/sha}","comments_url":"https://api.github.com/repos/mantidproject/mantid/comments{/number}","issue_comment_url":"https://api.github.com/repos/mantidproject/mantid/issues/comments{/number}","contents_url":"https://api.github.com/repos/mantidproject/mantid/contents/{+path}","compare_url":"https://api.github.com/repos/mantidproject/mantid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mantidproject/mantid/merges","archive_url":"https://api.github.com/repos/mantidproject/mantid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mantidproject/mantid/downloads","issues_url":"https://api.github.com/repos/mantidproject/mantid/issues{/number}","pulls_url":"https://api.github.com/repos/mantidproject/mantid/pulls{/number}","milestones_url":"https://api.github.com/repos/mantidproject/mantid/milestones{/number}","notifications_url":"https://api.github.com/repos/mantidproject/mantid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mantidproject/mantid/labels{/name}","releases_url":"https://api.github.com/repos/mantidproject/mantid/releases{/id}","deployments_url":"https://api.github.com/repos/mantidproject/mantid/deployments","created_at":"2011-10-17T19:07:38Z","updated_at":"2017-09-03T16:10:29Z","pushed_at":"2017-09-15T07:30:51Z","git_url":"git://github.com/mantidproject/mantid.git","ssh_url":"[email protected]:mantidproject/mantid.git","clone_url":"https://github.com/mantidproject/mantid.git","svn_url":"https://github.com/mantidproject/mantid","homepage":"www.mantidproject.org","size":442756,"stargazers_count":61,"watchers_count":61,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":1689,"forks":45,"open_issues":1689,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/20425"},"html":{"href":"https://github.com/mantidproject/mantid/pull/20425"},"issue":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/20425"},"comments":{"href":"https://api.github.com/repos/mantidproject/mantid/issues/20425/comments"},"review_comments":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/20425/comments"},"review_comment":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mantidproject/mantid/pulls/20425/commits"},"statuses":{"href":"https://api.github.com/repos/mantidproject/mantid/statuses/7c6f6bd9f0753ca9a949d4dea7466d5144ba2100"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 2594116,
"name": "mantidproject/mantid",
"url": "https://api.github.com/repos/mantidproject/mantid"
}
|
{
"id": 1109536,
"login": "OwenArnold",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1109536?",
"url": "https://api.github.com/users/OwenArnold"
}
|
{
"id": 671496,
"login": "mantidproject",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/671496?",
"url": "https://api.github.com/orgs/mantidproject"
}
| 2017-09-15T07:35:39 |
6594339419
|
{"actor":{"display_login":"OwenArnold"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/minetest-mods/technic/pulls/comments/114062267","pull_request_review_id":35505063,"id":114062267,"diff_hunk":"@@ -1,32 +1,28 @@\n \n local S = technic.getter\n \n+local function get_light(param1)\n+\tlocal alight = (param1-param1%16)/16\n+\tlocal sunlight = (param1%16 ~= alight and param1%16) or 0\n+\treturn sunlight, alight","path":"technic/machines/register/solar_array.lua","position":7,"original_position":7,"commit_id":"a70604ca5579a1e079913e882b8330c96a66af05","original_commit_id":"a70604ca5579a1e079913e882b8330c96a66af05","user":{"login":"HybridDog","id":3192173,"avatar_url":"https://avatars1.githubusercontent.com/u/3192173?v=3","gravatar_id":"","url":"https://api.github.com/users/HybridDog","html_url":"https://github.com/HybridDog","followers_url":"https://api.github.com/users/HybridDog/followers","following_url":"https://api.github.com/users/HybridDog/following{/other_user}","gists_url":"https://api.github.com/users/HybridDog/gists{/gist_id}","starred_url":"https://api.github.com/users/HybridDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HybridDog/subscriptions","organizations_url":"https://api.github.com/users/HybridDog/orgs","repos_url":"https://api.github.com/users/HybridDog/repos","events_url":"https://api.github.com/users/HybridDog/events{/privacy}","received_events_url":"https://api.github.com/users/HybridDog/received_events","type":"User","site_admin":false},"body":"artificial_light = math.floor(param1 / 16)\r\ndaylight = param1 % 16\r\nsunlight : See https://github.com/HybridDog/technic/blob/hversion/technic/machines/register/solar_array_new.lua#L81","created_at":"2017-04-29T21:40:44Z","updated_at":"2017-04-29T21:40:44Z","html_url":"https://github.com/minetest-mods/technic/pull/358#discussion_r114062267","pull_request_url":"https://api.github.com/repos/minetest-mods/technic/pulls/358","_links":{"self":{"href":"https://api.github.com/repos/minetest-mods/technic/pulls/comments/114062267"},"html":{"href":"https://github.com/minetest-mods/technic/pull/358#discussion_r114062267"},"pull_request":{"href":"https://api.github.com/repos/minetest-mods/technic/pulls/358"}}},"pull_request":{"url":"https://api.github.com/repos/minetest-mods/technic/pulls/358","id":117301335,"html_url":"https://github.com/minetest-mods/technic/pull/358","diff_url":"https://github.com/minetest-mods/technic/pull/358.diff","patch_url":"https://github.com/minetest-mods/technic/pull/358.patch","issue_url":"https://api.github.com/repos/minetest-mods/technic/issues/358","number":358,"state":"open","locked":false,"title":"make solar arrays only work with sunlight","user":{"login":"DS-Minetest","id":7613443,"avatar_url":"https://avatars1.githubusercontent.com/u/7613443?v=3","gravatar_id":"","url":"https://api.github.com/users/DS-Minetest","html_url":"https://github.com/DS-Minetest","followers_url":"https://api.github.com/users/DS-Minetest/followers","following_url":"https://api.github.com/users/DS-Minetest/following{/other_user}","gists_url":"https://api.github.com/users/DS-Minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/DS-Minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DS-Minetest/subscriptions","organizations_url":"https://api.github.com/users/DS-Minetest/orgs","repos_url":"https://api.github.com/users/DS-Minetest/repos","events_url":"https://api.github.com/users/DS-Minetest/events{/privacy}","received_events_url":"https://api.github.com/users/DS-Minetest/received_events","type":"User","site_admin":false},"body":"This uses `param1` instead of `minetest.get_node_light(pos1, nil)`.\r\nAlso this allows to have solar arrays beyond 0, but that's no real problem since they are there very inefficient.\r\nI don't know, why this hasn't been done yet.","created_at":"2017-04-24T16:05:46Z","updated_at":"2017-04-29T21:40:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d36ffa0d1a917bf2a18c582eeb55aa87b5c1f39e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/minetest-mods/technic/pulls/358/commits","review_comments_url":"https://api.github.com/repos/minetest-mods/technic/pulls/358/comments","review_comment_url":"https://api.github.com/repos/minetest-mods/technic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest-mods/technic/issues/358/comments","statuses_url":"https://api.github.com/repos/minetest-mods/technic/statuses/a70604ca5579a1e079913e882b8330c96a66af05","head":{"label":"DS-Minetest:solar_daylight","ref":"solar_daylight","sha":"a70604ca5579a1e079913e882b8330c96a66af05","user":{"login":"DS-Minetest","id":7613443,"avatar_url":"https://avatars1.githubusercontent.com/u/7613443?v=3","gravatar_id":"","url":"https://api.github.com/users/DS-Minetest","html_url":"https://github.com/DS-Minetest","followers_url":"https://api.github.com/users/DS-Minetest/followers","following_url":"https://api.github.com/users/DS-Minetest/following{/other_user}","gists_url":"https://api.github.com/users/DS-Minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/DS-Minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DS-Minetest/subscriptions","organizations_url":"https://api.github.com/users/DS-Minetest/orgs","repos_url":"https://api.github.com/users/DS-Minetest/repos","events_url":"https://api.github.com/users/DS-Minetest/events{/privacy}","received_events_url":"https://api.github.com/users/DS-Minetest/received_events","type":"User","site_admin":false},"repo":{"id":86491113,"name":"technic","full_name":"DS-Minetest/technic","owner":{"login":"DS-Minetest","id":7613443,"avatar_url":"https://avatars1.githubusercontent.com/u/7613443?v=3","gravatar_id":"","url":"https://api.github.com/users/DS-Minetest","html_url":"https://github.com/DS-Minetest","followers_url":"https://api.github.com/users/DS-Minetest/followers","following_url":"https://api.github.com/users/DS-Minetest/following{/other_user}","gists_url":"https://api.github.com/users/DS-Minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/DS-Minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DS-Minetest/subscriptions","organizations_url":"https://api.github.com/users/DS-Minetest/orgs","repos_url":"https://api.github.com/users/DS-Minetest/repos","events_url":"https://api.github.com/users/DS-Minetest/events{/privacy}","received_events_url":"https://api.github.com/users/DS-Minetest/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DS-Minetest/technic","description":"Technic mod for Minetest","fork":true,"url":"https://api.github.com/repos/DS-Minetest/technic","forks_url":"https://api.github.com/repos/DS-Minetest/technic/forks","keys_url":"https://api.github.com/repos/DS-Minetest/technic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DS-Minetest/technic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DS-Minetest/technic/teams","hooks_url":"https://api.github.com/repos/DS-Minetest/technic/hooks","issue_events_url":"https://api.github.com/repos/DS-Minetest/technic/issues/events{/number}","events_url":"https://api.github.com/repos/DS-Minetest/technic/events","assignees_url":"https://api.github.com/repos/DS-Minetest/technic/assignees{/user}","branches_url":"https://api.github.com/repos/DS-Minetest/technic/branches{/branch}","tags_url":"https://api.github.com/repos/DS-Minetest/technic/tags","blobs_url":"https://api.github.com/repos/DS-Minetest/technic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DS-Minetest/technic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DS-Minetest/technic/git/refs{/sha}","trees_url":"https://api.github.com/repos/DS-Minetest/technic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DS-Minetest/technic/statuses/{sha}","languages_url":"https://api.github.com/repos/DS-Minetest/technic/languages","stargazers_url":"https://api.github.com/repos/DS-Minetest/technic/stargazers","contributors_url":"https://api.github.com/repos/DS-Minetest/technic/contributors","subscribers_url":"https://api.github.com/repos/DS-Minetest/technic/subscribers","subscription_url":"https://api.github.com/repos/DS-Minetest/technic/subscription","commits_url":"https://api.github.com/repos/DS-Minetest/technic/commits{/sha}","git_commits_url":"https://api.github.com/repos/DS-Minetest/technic/git/commits{/sha}","comments_url":"https://api.github.com/repos/DS-Minetest/technic/comments{/number}","issue_comment_url":"https://api.github.com/repos/DS-Minetest/technic/issues/comments{/number}","contents_url":"https://api.github.com/repos/DS-Minetest/technic/contents/{+path}","compare_url":"https://api.github.com/repos/DS-Minetest/technic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DS-Minetest/technic/merges","archive_url":"https://api.github.com/repos/DS-Minetest/technic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DS-Minetest/technic/downloads","issues_url":"https://api.github.com/repos/DS-Minetest/technic/issues{/number}","pulls_url":"https://api.github.com/repos/DS-Minetest/technic/pulls{/number}","milestones_url":"https://api.github.com/repos/DS-Minetest/technic/milestones{/number}","notifications_url":"https://api.github.com/repos/DS-Minetest/technic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DS-Minetest/technic/labels{/name}","releases_url":"https://api.github.com/repos/DS-Minetest/technic/releases{/id}","deployments_url":"https://api.github.com/repos/DS-Minetest/technic/deployments","created_at":"2017-03-28T18:00:49Z","updated_at":"2017-03-28T18:00:51Z","pushed_at":"2017-04-29T11:33:36Z","git_url":"git://github.com/DS-Minetest/technic.git","ssh_url":"[email protected]:DS-Minetest/technic.git","clone_url":"https://github.com/DS-Minetest/technic.git","svn_url":"https://github.com/DS-Minetest/technic","homepage":null,"size":16782,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest-mods:master","ref":"master","sha":"42efc7e47c8e89ed5436261786bbfa1740300730","user":{"login":"minetest-mods","id":16545761,"avatar_url":"https://avatars0.githubusercontent.com/u/16545761?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest-mods","html_url":"https://github.com/minetest-mods","followers_url":"https://api.github.com/users/minetest-mods/followers","following_url":"https://api.github.com/users/minetest-mods/following{/other_user}","gists_url":"https://api.github.com/users/minetest-mods/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest-mods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest-mods/subscriptions","organizations_url":"https://api.github.com/users/minetest-mods/orgs","repos_url":"https://api.github.com/users/minetest-mods/repos","events_url":"https://api.github.com/users/minetest-mods/events{/privacy}","received_events_url":"https://api.github.com/users/minetest-mods/received_events","type":"Organization","site_admin":false},"repo":{"id":5490765,"name":"technic","full_name":"minetest-mods/technic","owner":{"login":"minetest-mods","id":16545761,"avatar_url":"https://avatars0.githubusercontent.com/u/16545761?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest-mods","html_url":"https://github.com/minetest-mods","followers_url":"https://api.github.com/users/minetest-mods/followers","following_url":"https://api.github.com/users/minetest-mods/following{/other_user}","gists_url":"https://api.github.com/users/minetest-mods/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest-mods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest-mods/subscriptions","organizations_url":"https://api.github.com/users/minetest-mods/orgs","repos_url":"https://api.github.com/users/minetest-mods/repos","events_url":"https://api.github.com/users/minetest-mods/events{/privacy}","received_events_url":"https://api.github.com/users/minetest-mods/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest-mods/technic","description":"Technic mod for Minetest","fork":false,"url":"https://api.github.com/repos/minetest-mods/technic","forks_url":"https://api.github.com/repos/minetest-mods/technic/forks","keys_url":"https://api.github.com/repos/minetest-mods/technic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest-mods/technic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest-mods/technic/teams","hooks_url":"https://api.github.com/repos/minetest-mods/technic/hooks","issue_events_url":"https://api.github.com/repos/minetest-mods/technic/issues/events{/number}","events_url":"https://api.github.com/repos/minetest-mods/technic/events","assignees_url":"https://api.github.com/repos/minetest-mods/technic/assignees{/user}","branches_url":"https://api.github.com/repos/minetest-mods/technic/branches{/branch}","tags_url":"https://api.github.com/repos/minetest-mods/technic/tags","blobs_url":"https://api.github.com/repos/minetest-mods/technic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest-mods/technic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest-mods/technic/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest-mods/technic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest-mods/technic/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest-mods/technic/languages","stargazers_url":"https://api.github.com/repos/minetest-mods/technic/stargazers","contributors_url":"https://api.github.com/repos/minetest-mods/technic/contributors","subscribers_url":"https://api.github.com/repos/minetest-mods/technic/subscribers","subscription_url":"https://api.github.com/repos/minetest-mods/technic/subscription","commits_url":"https://api.github.com/repos/minetest-mods/technic/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest-mods/technic/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest-mods/technic/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest-mods/technic/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest-mods/technic/contents/{+path}","compare_url":"https://api.github.com/repos/minetest-mods/technic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest-mods/technic/merges","archive_url":"https://api.github.com/repos/minetest-mods/technic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest-mods/technic/downloads","issues_url":"https://api.github.com/repos/minetest-mods/technic/issues{/number}","pulls_url":"https://api.github.com/repos/minetest-mods/technic/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest-mods/technic/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest-mods/technic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest-mods/technic/labels{/name}","releases_url":"https://api.github.com/repos/minetest-mods/technic/releases{/id}","deployments_url":"https://api.github.com/repos/minetest-mods/technic/deployments","created_at":"2012-08-21T05:17:09Z","updated_at":"2017-04-25T20:55:13Z","pushed_at":"2017-04-29T11:33:37Z","git_url":"git://github.com/minetest-mods/technic.git","ssh_url":"[email protected]:minetest-mods/technic.git","clone_url":"https://github.com/minetest-mods/technic.git","svn_url":"https://github.com/minetest-mods/technic","homepage":null,"size":16829,"stargazers_count":63,"watchers_count":63,"language":"Lua","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":79,"mirror_url":null,"open_issues_count":23,"forks":79,"open_issues":23,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest-mods/technic/pulls/358"},"html":{"href":"https://github.com/minetest-mods/technic/pull/358"},"issue":{"href":"https://api.github.com/repos/minetest-mods/technic/issues/358"},"comments":{"href":"https://api.github.com/repos/minetest-mods/technic/issues/358/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest-mods/technic/pulls/358/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest-mods/technic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest-mods/technic/pulls/358/commits"},"statuses":{"href":"https://api.github.com/repos/minetest-mods/technic/statuses/a70604ca5579a1e079913e882b8330c96a66af05"}}}}
|
{
"id": 5490765,
"name": "minetest-mods/technic",
"url": "https://api.github.com/repos/minetest-mods/technic"
}
|
{
"id": 3192173,
"login": "HybridDog",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3192173?",
"url": "https://api.github.com/users/HybridDog"
}
|
{
"id": 16545761,
"login": "minetest-mods",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16545761?",
"url": "https://api.github.com/orgs/minetest-mods"
}
| 2017-04-29T21:40:44 |
5782500954
|
{"actor":{"display_login":"HybridDog"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/comments/159120354","pull_request_review_id":86027988,"id":159120354,"diff_hunk":"@@ -0,0 +1,211 @@\n+---\n+layout: post\n+authors: [kevin_van_houtte]\n+title: 'Securing your cloud-native microservice architecture in Spring: part 2'\n+image: /img/microservices/part2/part2logo.jpg\n+tags: [Microservices, Security, Encryption, Spring, Cloud, Config]\n+category: Microservices\n+comments: true\n+---\n+\n+Since the rise of the digital era, most enterprises keep their data in a digital format.\n+But if their sensitive data lacks security, it can cause the data to be unreliable, unstable and unavailable to their business.\n+We have to be prepared if an attacker breaches in to our network and tries to hack our sensitive data.\n+Whether it is in-motion or at-rest, encrypting our data and using the proper protection mechanism, will make it worthless for the hacker to use. \n+\n+# Overview\n+* [Cryptographic Algorithms](#cryptographic-algorithms)\n+* [Key Mechanics](#key-mechanics)\n+* [Cloud-hosted Key management service](#cloud-hosted-key-management-service)\n+* [Spring Cloud Config Server](#spring-cloud-config-server)\n+\n+# Cryptographic Algorithms\n+When implementing our application, every programming language will provide us with a set of known libraries for cryptographic algorithms. \n+A big flaw is implementing an algorithm by yourself, the known algorithms have been reviewed, patched and been known for their excellent security. \n+These are the most used types that you can use for encryption at rest: \n+\n+## Symmetric Encryption\n+The key used in encrypting data at rest is used for both encrypting and decrypting the data.\n+This key becomes very vulnerable if anyone gets a hold on it. \n+* Well known: [Advanced Encryption Standard encryption](https://en.wikipedia.org/wiki/Advanced_Encryption_Standard){:target=\"_blank\"}\n+\n+\n+## Asymmetric Encryption\n+In asymmetric encryption, a pair of keys are used. One public that is exposed and encrypts your data and one private key that is only known by the owner that decrypts your data.\n+* Wel known: [Rivest–Shamir–Adleman encryption](https://en.wikipedia.org/wiki/RSA_(cryptosystem)){:target=\"_blank\"}\n+\n+# Key Mechanics \n+Encryption keys are another aspect of encryption, handling the keys become just as sensitive as the data itself. ","path":"_posts/2017-12-28-Secure-your-architecture-part2.md","position":38,"original_position":38,"commit_id":"36621320557019d5f65b7bc50297d905c2f0412c","original_commit_id":"36621320557019d5f65b7bc50297d905c2f0412c","user":{"login":"yannickdeturck","id":1644089,"avatar_url":"https://avatars2.githubusercontent.com/u/1644089?v=4","gravatar_id":"","url":"https://api.github.com/users/yannickdeturck","html_url":"https://github.com/yannickdeturck","followers_url":"https://api.github.com/users/yannickdeturck/followers","following_url":"https://api.github.com/users/yannickdeturck/following{/other_user}","gists_url":"https://api.github.com/users/yannickdeturck/gists{/gist_id}","starred_url":"https://api.github.com/users/yannickdeturck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yannickdeturck/subscriptions","organizations_url":"https://api.github.com/users/yannickdeturck/orgs","repos_url":"https://api.github.com/users/yannickdeturck/repos","events_url":"https://api.github.com/users/yannickdeturck/events{/privacy}","received_events_url":"https://api.github.com/users/yannickdeturck/received_events","type":"User","site_admin":false},"body":"becomes","created_at":"2017-12-30T10:10:07Z","updated_at":"2017-12-30T10:42:58Z","html_url":"https://github.com/ordina-jworks/ordina-jworks.github.io/pull/311#discussion_r159120354","pull_request_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/311","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/comments/159120354"},"html":{"href":"https://github.com/ordina-jworks/ordina-jworks.github.io/pull/311#discussion_r159120354"},"pull_request":{"href":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/311"}}},"pull_request":{"url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/311","id":160511025,"html_url":"https://github.com/ordina-jworks/ordina-jworks.github.io/pull/311","diff_url":"https://github.com/ordina-jworks/ordina-jworks.github.io/pull/311.diff","patch_url":"https://github.com/ordina-jworks/ordina-jworks.github.io/pull/311.patch","issue_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/issues/311","number":311,"state":"open","locked":false,"title":"Feature/securing your microservices part2","user":{"login":"KevinVHoutte","id":3090371,"avatar_url":"https://avatars0.githubusercontent.com/u/3090371?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinVHoutte","html_url":"https://github.com/KevinVHoutte","followers_url":"https://api.github.com/users/KevinVHoutte/followers","following_url":"https://api.github.com/users/KevinVHoutte/following{/other_user}","gists_url":"https://api.github.com/users/KevinVHoutte/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinVHoutte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinVHoutte/subscriptions","organizations_url":"https://api.github.com/users/KevinVHoutte/orgs","repos_url":"https://api.github.com/users/KevinVHoutte/repos","events_url":"https://api.github.com/users/KevinVHoutte/events{/privacy}","received_events_url":"https://api.github.com/users/KevinVHoutte/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-29T12:34:05Z","updated_at":"2017-12-30T10:42:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5837bc52a2a3f357589d74739502a1992477aee8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/311/commits","review_comments_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/311/comments","review_comment_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/issues/311/comments","statuses_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/statuses/36621320557019d5f65b7bc50297d905c2f0412c","head":{"label":"ordina-jworks:feature/securing-your-microservices-part2","ref":"feature/securing-your-microservices-part2","sha":"36621320557019d5f65b7bc50297d905c2f0412c","user":{"login":"ordina-jworks","id":15261659,"avatar_url":"https://avatars0.githubusercontent.com/u/15261659?v=4","gravatar_id":"","url":"https://api.github.com/users/ordina-jworks","html_url":"https://github.com/ordina-jworks","followers_url":"https://api.github.com/users/ordina-jworks/followers","following_url":"https://api.github.com/users/ordina-jworks/following{/other_user}","gists_url":"https://api.github.com/users/ordina-jworks/gists{/gist_id}","starred_url":"https://api.github.com/users/ordina-jworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ordina-jworks/subscriptions","organizations_url":"https://api.github.com/users/ordina-jworks/orgs","repos_url":"https://api.github.com/users/ordina-jworks/repos","events_url":"https://api.github.com/users/ordina-jworks/events{/privacy}","received_events_url":"https://api.github.com/users/ordina-jworks/received_events","type":"Organization","site_admin":false},"repo":{"id":44804684,"name":"ordina-jworks.github.io","full_name":"ordina-jworks/ordina-jworks.github.io","owner":{"login":"ordina-jworks","id":15261659,"avatar_url":"https://avatars0.githubusercontent.com/u/15261659?v=4","gravatar_id":"","url":"https://api.github.com/users/ordina-jworks","html_url":"https://github.com/ordina-jworks","followers_url":"https://api.github.com/users/ordina-jworks/followers","following_url":"https://api.github.com/users/ordina-jworks/following{/other_user}","gists_url":"https://api.github.com/users/ordina-jworks/gists{/gist_id}","starred_url":"https://api.github.com/users/ordina-jworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ordina-jworks/subscriptions","organizations_url":"https://api.github.com/users/ordina-jworks/orgs","repos_url":"https://api.github.com/users/ordina-jworks/repos","events_url":"https://api.github.com/users/ordina-jworks/events{/privacy}","received_events_url":"https://api.github.com/users/ordina-jworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ordina-jworks/ordina-jworks.github.io","description":"Ordina JWorks Business Unit Tech Blog","fork":false,"url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io","forks_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/forks","keys_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/teams","hooks_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/hooks","issue_events_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/events","assignees_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/tags","blobs_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/languages","stargazers_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/stargazers","contributors_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/contributors","subscribers_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/subscribers","subscription_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/subscription","commits_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/merges","archive_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/downloads","issues_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/labels{/name}","releases_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/deployments","created_at":"2015-10-23T09:56:09Z","updated_at":"2017-11-01T20:14:56Z","pushed_at":"2017-12-29T21:05:21Z","git_url":"git://github.com/ordina-jworks/ordina-jworks.github.io.git","ssh_url":"[email protected]:ordina-jworks/ordina-jworks.github.io.git","clone_url":"https://github.com/ordina-jworks/ordina-jworks.github.io.git","svn_url":"https://github.com/ordina-jworks/ordina-jworks.github.io","homepage":"https://ordina-jworks.github.io/","size":168395,"stargazers_count":10,"watchers_count":10,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":6,"open_issues":9,"watchers":10,"default_branch":"source"}},"base":{"label":"ordina-jworks:source","ref":"source","sha":"f9e549cfbdffda72bc4a8b0fa31c77523104b3fb","user":{"login":"ordina-jworks","id":15261659,"avatar_url":"https://avatars0.githubusercontent.com/u/15261659?v=4","gravatar_id":"","url":"https://api.github.com/users/ordina-jworks","html_url":"https://github.com/ordina-jworks","followers_url":"https://api.github.com/users/ordina-jworks/followers","following_url":"https://api.github.com/users/ordina-jworks/following{/other_user}","gists_url":"https://api.github.com/users/ordina-jworks/gists{/gist_id}","starred_url":"https://api.github.com/users/ordina-jworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ordina-jworks/subscriptions","organizations_url":"https://api.github.com/users/ordina-jworks/orgs","repos_url":"https://api.github.com/users/ordina-jworks/repos","events_url":"https://api.github.com/users/ordina-jworks/events{/privacy}","received_events_url":"https://api.github.com/users/ordina-jworks/received_events","type":"Organization","site_admin":false},"repo":{"id":44804684,"name":"ordina-jworks.github.io","full_name":"ordina-jworks/ordina-jworks.github.io","owner":{"login":"ordina-jworks","id":15261659,"avatar_url":"https://avatars0.githubusercontent.com/u/15261659?v=4","gravatar_id":"","url":"https://api.github.com/users/ordina-jworks","html_url":"https://github.com/ordina-jworks","followers_url":"https://api.github.com/users/ordina-jworks/followers","following_url":"https://api.github.com/users/ordina-jworks/following{/other_user}","gists_url":"https://api.github.com/users/ordina-jworks/gists{/gist_id}","starred_url":"https://api.github.com/users/ordina-jworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ordina-jworks/subscriptions","organizations_url":"https://api.github.com/users/ordina-jworks/orgs","repos_url":"https://api.github.com/users/ordina-jworks/repos","events_url":"https://api.github.com/users/ordina-jworks/events{/privacy}","received_events_url":"https://api.github.com/users/ordina-jworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ordina-jworks/ordina-jworks.github.io","description":"Ordina JWorks Business Unit Tech Blog","fork":false,"url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io","forks_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/forks","keys_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/teams","hooks_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/hooks","issue_events_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/events","assignees_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/tags","blobs_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/languages","stargazers_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/stargazers","contributors_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/contributors","subscribers_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/subscribers","subscription_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/subscription","commits_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/merges","archive_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/downloads","issues_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/labels{/name}","releases_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/deployments","created_at":"2015-10-23T09:56:09Z","updated_at":"2017-11-01T20:14:56Z","pushed_at":"2017-12-29T21:05:21Z","git_url":"git://github.com/ordina-jworks/ordina-jworks.github.io.git","ssh_url":"[email protected]:ordina-jworks/ordina-jworks.github.io.git","clone_url":"https://github.com/ordina-jworks/ordina-jworks.github.io.git","svn_url":"https://github.com/ordina-jworks/ordina-jworks.github.io","homepage":"https://ordina-jworks.github.io/","size":168395,"stargazers_count":10,"watchers_count":10,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":6,"open_issues":9,"watchers":10,"default_branch":"source"}},"_links":{"self":{"href":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/311"},"html":{"href":"https://github.com/ordina-jworks/ordina-jworks.github.io/pull/311"},"issue":{"href":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/issues/311"},"comments":{"href":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/issues/311/comments"},"review_comments":{"href":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/311/comments"},"review_comment":{"href":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/311/commits"},"statuses":{"href":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/statuses/36621320557019d5f65b7bc50297d905c2f0412c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 44804684,
"name": "ordina-jworks/ordina-jworks.github.io",
"url": "https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io"
}
|
{
"id": 1644089,
"login": "yannickdeturck",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1644089?",
"url": "https://api.github.com/users/yannickdeturck"
}
|
{
"id": 15261659,
"login": "ordina-jworks",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15261659?",
"url": "https://api.github.com/orgs/ordina-jworks"
}
| 2017-12-30T10:10:07 |
7042315736
|
{"actor":{"display_login":"yannickdeturck"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/comments/139264576","pull_request_review_id":63174875,"id":139264576,"diff_hunk":"@@ -0,0 +1,290 @@\n+---\n+layout: post\n+authors: [tim_de_grande]\n+title: \"Browser Security Features\"\n+image: /img/security/padlock_code.jpg\n+tags: [Security]\n+category: Security\n+comments: true\n+permalink: conference/2017/09/05/Browser-security-features.html\n+---\n+# Browser security features\n+Browsers nowadays come with a ton of security features built-in.\n+These features are there to protect the people using your application as well as protecting your application from malicious others.\n+Most of these features are quite easy to implement, however for some of them (such as key-pinning), you have to be careful not to break your site.\n+It's this danger, combined with the lack of knowledge, that prevents people from taking full advantage of them.\n+\n+## Transport Layer Security\n+The first layer of defense is not a new one at all: Transport Layer Security (TLS).\n+TLS is sometimes (incorrectly) referred to as SSL (Secured Socket Layer). \n+In reality SSL is an obsolete technology, with TLS being its successor, but the name stuck.\n+\n+Having said this, why should you use TLS? \n+First of all, most of the features described below *only* work when you're on a secured connection.\n+Besides that it guarantees the end user that the site they're communicating with is actually the site they think it is.\n+It also provides the guarantee that the content they see was not tampered with while travelling over the network.\n+\n+Another things TLS brings to the table is speed: it used to be true that a secure connection was slower than an unsecured one.\n+Modern hardware however is more than up to the task of handling this efficiently for you.\n+Besides that HTTP/2 is *only* available over a secure connection and it allows for faster page loads.\n+Have a look at [http://www.httpvshttps.com/](http://www.httpvshttps.com/){: target=\"_blank\" } for a demo of the difference.\n+\n+Since speed should no longer prevent you from switching to HTTPS, there's only cost.\n+Even that is no longer true: a simple Domain Validation certificate can be obtained for free.\n+But even if you need more protection, an Extended Validation certificate can be had for as little as 300$ per year.\n+\n+### How hard is it?\n+The main issue is that all resources you use on your site should be served over HTTPS.\n+This means that all third parties should use TLS as well.\n+Furthermore, it depends on the complexity of your site.\n+Nick Craver wrote an extensive [blog post](https://nickcraver.com/blog/2017/05/22/https-on-stack-overflow/){: target=\"_blank\"} on their road to switching to HTTPS.\n+\n+### Should you activate this on your site? \n+Absolutely! \n+Modern browsers are shifting from notifying users that a page is secure to warning them that it isn't.\n+On top of that, Google gives a slight ranking boost to HTTPS sites.\n+\n+## HTTP Strict Transport Security\n+Once your server is properly configured to use TLS, your next step is to redirect your users to the secure version.\n+You could do this by simply adding a redirect-rule in your web server for the non-secure pages.\n+This means that users will still first connect to your non-secure site, allowing a potential attacker to intercept the request and do his nefarious deeds.\n+Wouldn't it be nice if you could tell the browser to just go straight to the secure version?\n+That's the thinking behind the HSTS (HTTP Strict Transport Security) header. \n+\n+HSTS simply tells the browser that you're expecting it to use HTTPS for a certain time.\n+As a result, the browser will *automatically* replace http:// with https:// **before** making the call.\n+This means that even following a link that explicitly defines http:// will instead be called using a secure connection.\n+\n+The configuration of HSTS is as easy as can be: you simply add the following header to your response:\n+\n+```Strict-Transport-Security: max-age=31536000; includeSubDomains```\n+\n+This will tell the browser that for the next 365 days, it should connect to your domain using https.\n+The `includesubdomains` directive tells the browser that your subdomains should also be called using https.\n+Setting the max-age to 0 tells the browser that you no longer wish your domain to be HSTS-enabled. \n+\n+### HSTS preload\n+Of course in this scenario, the user's first connection will still take place over an unsecured connection.\n+This would offer an attacker a brief period in which he can still hijack the connection.\n+To prevent this, most major browsers (Chrome, Firefox, Safari, Edge, IE11 and Opera) offer an HSTS preload list.\n+Domains on this list will automatically be loaded over HTTPS from the start, without having to go through the HTTP -> HTTPS redirect.\n+If you want your domain to be included in this list, you should add the `preload` directive to the HSTS header.\n+\n+```Strict-Transport-Security: max-age=31536000; includeSubDomains; preload```\n+\n+Afterwards, you can register your domain at [https://hstspreload.org/](https://hstspreload.org/){: target=\"_blank\" }\n+\n+### Are there any risks?\n+Activating HSTS does offer some risks:\n+* If you include the `includesubdomains` directive, you tell the browser that *all* subdomains need to be retrieved over HTTPS.\n+ If your internal applications are on a subdomain (e.g. internal.example.com), you'll block access to those that haven't enabled TLS yet.\n+* Adding the `preload` directive is even more dangerous: because this tells browser makes to hardcode your HSTS settings.\n+ If you've made a mistake in the setup, it can take a long time be removed from the list. \n+ Since this list is *in* the browser, you'll affect both your existing and your new users.\n+These risks can be mitigated through extensive testing and conservative settings. \n+Start with a short max-age and slowly increase its length, don't include subdomains if you're not 100% sure that *all* subdomains need to be included\n+and perhaps most importantly, **don't** activate preload unless you're 100% sure that everything works as intended.\n+\n+### Should I activate HSTS?\n+For those (subdomains) where TLS is enabled, you should start rolling out HSTS (while keeping in mind the warnings above).\n+\n+## Public key pinning\n+Alright, now you've secured your site with HTTPS, and you've made sure your users can't fall victim to a Man in the Middle attack.\n+Or have you?\n+It's true that HSTS will make sure that the user only connects using a secured connection, but that doesn't mean the HTTPS connection is actually made to **your** server.\n+Over the last couple of years, there were several incidents where malicious actors were able to generate valid certificates for domains they didn't control.\n+When this happens, your users will think they're safe (as their browser shows the green padlock), but the attacker can still manipulate your content.\n+To protect yourself against this, there's a mechanism called \"HTTP Public Key Pinning\" (HPKP).\n+With HPKP you \"pin\" the public key of your TLS certificate to the browser.\n+In the future, that browser will compare the public key that's actually used for the TLS connection with the pinned one and, if they don't match, refuse the connection altogether.\n+{: .image height=\"245px\" }\n+\n+An HPKP header looks like this:\n+\n+{% highlight http %}\n+public-key-pins:pin-sha256=\"YLh1...uihg=\";pin-sha256=\"9dNi...Dwg=\";pin-sha256=\"Vjs...eWys=\";max-age=2592000;includeSubdomains;report-uri=\"report-uri\"\n+{% endhighlight %}{: style=\"scroll: auto\" }\n+\n+The `max-age` directive tells the browser for how long these pins are valid. \n+You can use `report-uri` to get a report when an invalid certificate is used.\n+`includesubdomains` makes sure that the policy also applies to your subdomains.\n+Finally, there are the actual pins.\n+You need to pin at least 2 fingerprints: 1 that should be active at the moment and 1 that isn't.\n+\n+### What to pin?\n+First of all you need to pin at least one of the keys in your certificate chain.\n+While you can pin the key of the actual certificate, that might not be the best idea.\n+Doing this means that you need to update the keys every time your certificate is changed or risk your users being unable to visit your site.\n+Alternatively, you could pin the key for the root certificate of your CA (Certificate Authority).\n+While this is a lot safer, it does mean that if your CA, or any of its intermediates is compromised, they could issue valid certificates for your site.\n+Finally you have the option to pin the key to the intermediate certificate. \n+Doing so limits the attack surface to that intermediate, while it also allows you to roll out new certificates whenever you need to.\n+Of course you can't control when your CA will change their intermediate cert, so that's a danger in its own.\n+\n+Besides that you also need to have a second key pinned that's *not* in your current certificate chain, otherwise your HPKP header will be ignored.\n+Fortunately you don't have to have certificates ready for this.\n+It's enough to pin the public key of a CSR (Certificate Signing Request).\n+Obviously you can't use the CSR of your current certificate (as that would be valid for this chain), so you'll need to create a backup CSR.\n+You'll need to keep this CSR and the associated private key in a secure location, because you don't want these to be compromised together with the original.\n+\n+### report-uri\n+The `report-uri` directive is used to tell the browser where to send reports if it encounters an invalid certificate.\n+The browser will POST a JSON message to the URL you specify here.\n+If you don't want to implement your own processing of these reports, have a look at [report-uri.io](https://report-uri.io/){: target=\"_blank\" }\n+It will process the reports from your site and display the results in a nice format, allowing you to take action when you see something that's wrong.\n+\n+### Report-only\n+Besides the normal CSP header, there's also the Report-only variant: `Public-Key-Pins-Report-Only`.\n+This header has the exact same specifications as the normal HPKP, **but** it won't block access to your site if there's no valid pin.\n+As the name says, it will simply report violations to the report-uri.\n+Obviously, this header isn't meant to increase the security of your site on its own, rather it's a way to help you on your way to a full HPKP implementation.\n+\n+### Dangers\n+HPKP is quite a dangerous header: it's quite easy to commit \"pinning-suicide\".\n+Pin the wrong certificate, have a CA change keys on you or have something else go wrong and your site is inaccessible until your users' max-age expires.\n+Be careful rolling out this one as it's way too easy to shoot yourself in the foot.\n+\n+### Should I use it?\n+This header has some serious dangers associated with it.\n+It's not enough to know that the current configuration is correct, you also need to be sure that you're equipped to deal with certificate updates without breaking the site.\n+And then you need to be sure that you've got a backup in place in case you ever want to switch CA's.\n+Unless you're 100% sure that this won't be an issue, hold off for now as it's too easy to DoS your own site.\n+\n+## Content Security Policy\n+Even though your connection is secured with TLS, that doesn't mean that the content can't be tampered with in other ways (such as cross-site scripting (XSS)).\n+An attacker could use these kinds of attacks to load malicious content.\n+The Content Security Policy (CSP) header is designed to prevent this kind of attacks.\n+It allows you to specify exactly what content your site is allowed to load through a load of directives.\n+\n+### Fetch directives\n+First of all, you can define what source content can be fetched from. \n+There's a specific directive for each resource type and a fallback directive `default-src`.\n+You define the sources where the content can be loaded from as follows:\n+ * `self` only load content from the same origin as the page\n+ * `none` don't load any content of this type\n+ * `unsafe-inline` lets you use inline javascript and CSS (although it's preferable to use a nonce)\n+ * `unsafe-eval` allows the use of `eval()`, `setTimeout(String)`, `setInterval(String)` and `new Function(String)`.\n+ There's a reason it has \"unsafe\" in its name though: these functions are typically used as attack vectors for XSS.\n+ * `https:` allow content loaded from anywhere, as long as it's served over https\n+ * `example.com` allow content loaded from anywhere on example.com, both http and https\n+ * You can also use wildcards to control which origins are allowed. \n+ E.g. `*://*.example.com:*` will allow resources to be loaded from all *subdomains* of example.com, using any scheme and port.\n+ Note that it won't allow you to load resources from example.com itself.\n+ * `nonce-...` Allows you to specify a [nonce](#nonce). Scripts or styles that have this nonce are then allowed to execute.\n+It's also important to note that you can pass multiple values to these directives: `self https://example.com` will allow resources to be loaded both from the domain itself as well as from https://example.com.\n+\n+You can use these to define `default-src`, but CSP gives you more fine-grained control over where each type of resource can be loaded from.\n+For that you need to use the following properties instead:\n+ * `script-src` - Javascript.\n+ * `style-src` - CSS\n+ * `img-src` - images\n+ * `font-src` - fonts\n+ * `object-src` - objects (e.g. `<object>`, `<embed>`, ...)\n+ * `object-src` - media such as `<audio>` and `<video>` elements\n+ * `connect-src` - where the page can connect to using `XmlHttpRequest`, `WebSocket` or `EventSource`.\n+ The browser will immediately return a 400 status code when your page attempts to connect to a non-valid domain.\n+ * `frame-src` - Specify which locations can be embedded in a `<frame>` and `<iframe>`\n+ * `worker-src` - Worker scripts\n+ * `child-src` - Is either deprecated or serves as fallback for `frame-src` and `worker-src`, depending on the browser and the CSP level implemented.\n+ \n+### Navigation directives\n+These directives tell the browser what kind of navigation is allowed:\n+* `form-action` limits to where forms can be submitted\n+* `frame-ancestors` specifies who may embed pages using elements such as `<frame>`, `<iframe>`, `<embed>`, `<object>` and `<applet>` \n+\n+### Other directives\n+Besides these, CSP allows for quite a few other directives:\n+ * `report-uri` works the same way as the `report-uri` directive of HPKP\n+ * `require-sri-for` allows you to force the use or Subresource Integrity ((SRI)[#Subresource-integrity]) for stylesheets, scripts or both. \n+ Allowed values are `script` and `style` (or both).\n+ * `base-uri` defines which URLs you can use in the `<base>` element\n+ * `sandbox` to enable a sandbox for requested resources \n+ (have a look at [Mozilla's documentation](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/sandbox){: target='_blank' } for more information)\n+ \n+### Nonce","path":"_posts/2017-09-05-Browser Security Features.md","position":217,"original_position":204,"commit_id":"dc162fb595c3c5077e73df0cec8a5a9db0ed6e8c","original_commit_id":"160fe24b5ab31343041c2586aee11c26744e60f3","user":{"login":"TYsewyn","id":6283320,"avatar_url":"https://avatars0.githubusercontent.com/u/6283320?v=4","gravatar_id":"","url":"https://api.github.com/users/TYsewyn","html_url":"https://github.com/TYsewyn","followers_url":"https://api.github.com/users/TYsewyn/followers","following_url":"https://api.github.com/users/TYsewyn/following{/other_user}","gists_url":"https://api.github.com/users/TYsewyn/gists{/gist_id}","starred_url":"https://api.github.com/users/TYsewyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TYsewyn/subscriptions","organizations_url":"https://api.github.com/users/TYsewyn/orgs","repos_url":"https://api.github.com/users/TYsewyn/repos","events_url":"https://api.github.com/users/TYsewyn/events{/privacy}","received_events_url":"https://api.github.com/users/TYsewyn/received_events","type":"User","site_admin":false},"body":"Maybe add that it is pronounced \"/nɒns/\" (nance) and stands for \"number (used) once\".","created_at":"2017-09-15T22:48:39Z","updated_at":"2017-09-15T22:59:02Z","html_url":"https://github.com/ordina-jworks/ordina-jworks.github.io/pull/250#discussion_r139264576","pull_request_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/250","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/comments/139264576"},"html":{"href":"https://github.com/ordina-jworks/ordina-jworks.github.io/pull/250#discussion_r139264576"},"pull_request":{"href":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/250"}}},"pull_request":{"url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/250","id":139319684,"html_url":"https://github.com/ordina-jworks/ordina-jworks.github.io/pull/250","diff_url":"https://github.com/ordina-jworks/ordina-jworks.github.io/pull/250.diff","patch_url":"https://github.com/ordina-jworks/ordina-jworks.github.io/pull/250.patch","issue_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/issues/250","number":250,"state":"open","locked":false,"title":"Feature/browser security features","user":{"login":"TimDG","id":1313186,"avatar_url":"https://avatars1.githubusercontent.com/u/1313186?v=4","gravatar_id":"","url":"https://api.github.com/users/TimDG","html_url":"https://github.com/TimDG","followers_url":"https://api.github.com/users/TimDG/followers","following_url":"https://api.github.com/users/TimDG/following{/other_user}","gists_url":"https://api.github.com/users/TimDG/gists{/gist_id}","starred_url":"https://api.github.com/users/TimDG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimDG/subscriptions","organizations_url":"https://api.github.com/users/TimDG/orgs","repos_url":"https://api.github.com/users/TimDG/repos","events_url":"https://api.github.com/users/TimDG/events{/privacy}","received_events_url":"https://api.github.com/users/TimDG/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-05T13:11:09Z","updated_at":"2017-09-15T22:59:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ddf0ff64315cd613492cebb88c3a6a3878b11607","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/250/commits","review_comments_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/250/comments","review_comment_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/issues/250/comments","statuses_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/statuses/dc162fb595c3c5077e73df0cec8a5a9db0ed6e8c","head":{"label":"ordina-jworks:feature/browser_security_features","ref":"feature/browser_security_features","sha":"dc162fb595c3c5077e73df0cec8a5a9db0ed6e8c","user":{"login":"ordina-jworks","id":15261659,"avatar_url":"https://avatars0.githubusercontent.com/u/15261659?v=4","gravatar_id":"","url":"https://api.github.com/users/ordina-jworks","html_url":"https://github.com/ordina-jworks","followers_url":"https://api.github.com/users/ordina-jworks/followers","following_url":"https://api.github.com/users/ordina-jworks/following{/other_user}","gists_url":"https://api.github.com/users/ordina-jworks/gists{/gist_id}","starred_url":"https://api.github.com/users/ordina-jworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ordina-jworks/subscriptions","organizations_url":"https://api.github.com/users/ordina-jworks/orgs","repos_url":"https://api.github.com/users/ordina-jworks/repos","events_url":"https://api.github.com/users/ordina-jworks/events{/privacy}","received_events_url":"https://api.github.com/users/ordina-jworks/received_events","type":"Organization","site_admin":false},"repo":{"id":44804684,"name":"ordina-jworks.github.io","full_name":"ordina-jworks/ordina-jworks.github.io","owner":{"login":"ordina-jworks","id":15261659,"avatar_url":"https://avatars0.githubusercontent.com/u/15261659?v=4","gravatar_id":"","url":"https://api.github.com/users/ordina-jworks","html_url":"https://github.com/ordina-jworks","followers_url":"https://api.github.com/users/ordina-jworks/followers","following_url":"https://api.github.com/users/ordina-jworks/following{/other_user}","gists_url":"https://api.github.com/users/ordina-jworks/gists{/gist_id}","starred_url":"https://api.github.com/users/ordina-jworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ordina-jworks/subscriptions","organizations_url":"https://api.github.com/users/ordina-jworks/orgs","repos_url":"https://api.github.com/users/ordina-jworks/repos","events_url":"https://api.github.com/users/ordina-jworks/events{/privacy}","received_events_url":"https://api.github.com/users/ordina-jworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ordina-jworks/ordina-jworks.github.io","description":"Ordina JWorks Business Unit Tech Blog","fork":false,"url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io","forks_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/forks","keys_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/teams","hooks_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/hooks","issue_events_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/events","assignees_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/tags","blobs_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/languages","stargazers_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/stargazers","contributors_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/contributors","subscribers_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/subscribers","subscription_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/subscription","commits_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/merges","archive_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/downloads","issues_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/labels{/name}","releases_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/deployments","created_at":"2015-10-23T09:56:09Z","updated_at":"2016-10-27T14:34:29Z","pushed_at":"2017-09-15T21:57:14Z","git_url":"git://github.com/ordina-jworks/ordina-jworks.github.io.git","ssh_url":"[email protected]:ordina-jworks/ordina-jworks.github.io.git","clone_url":"https://github.com/ordina-jworks/ordina-jworks.github.io.git","svn_url":"https://github.com/ordina-jworks/ordina-jworks.github.io","homepage":"","size":102602,"stargazers_count":7,"watchers_count":7,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":14,"forks":4,"open_issues":14,"watchers":7,"default_branch":"source"}},"base":{"label":"ordina-jworks:source","ref":"source","sha":"87f50883c920705af28e0970d4821e3ea910733c","user":{"login":"ordina-jworks","id":15261659,"avatar_url":"https://avatars0.githubusercontent.com/u/15261659?v=4","gravatar_id":"","url":"https://api.github.com/users/ordina-jworks","html_url":"https://github.com/ordina-jworks","followers_url":"https://api.github.com/users/ordina-jworks/followers","following_url":"https://api.github.com/users/ordina-jworks/following{/other_user}","gists_url":"https://api.github.com/users/ordina-jworks/gists{/gist_id}","starred_url":"https://api.github.com/users/ordina-jworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ordina-jworks/subscriptions","organizations_url":"https://api.github.com/users/ordina-jworks/orgs","repos_url":"https://api.github.com/users/ordina-jworks/repos","events_url":"https://api.github.com/users/ordina-jworks/events{/privacy}","received_events_url":"https://api.github.com/users/ordina-jworks/received_events","type":"Organization","site_admin":false},"repo":{"id":44804684,"name":"ordina-jworks.github.io","full_name":"ordina-jworks/ordina-jworks.github.io","owner":{"login":"ordina-jworks","id":15261659,"avatar_url":"https://avatars0.githubusercontent.com/u/15261659?v=4","gravatar_id":"","url":"https://api.github.com/users/ordina-jworks","html_url":"https://github.com/ordina-jworks","followers_url":"https://api.github.com/users/ordina-jworks/followers","following_url":"https://api.github.com/users/ordina-jworks/following{/other_user}","gists_url":"https://api.github.com/users/ordina-jworks/gists{/gist_id}","starred_url":"https://api.github.com/users/ordina-jworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ordina-jworks/subscriptions","organizations_url":"https://api.github.com/users/ordina-jworks/orgs","repos_url":"https://api.github.com/users/ordina-jworks/repos","events_url":"https://api.github.com/users/ordina-jworks/events{/privacy}","received_events_url":"https://api.github.com/users/ordina-jworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ordina-jworks/ordina-jworks.github.io","description":"Ordina JWorks Business Unit Tech Blog","fork":false,"url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io","forks_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/forks","keys_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/teams","hooks_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/hooks","issue_events_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/events","assignees_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/tags","blobs_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/languages","stargazers_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/stargazers","contributors_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/contributors","subscribers_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/subscribers","subscription_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/subscription","commits_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/merges","archive_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/downloads","issues_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/labels{/name}","releases_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/deployments","created_at":"2015-10-23T09:56:09Z","updated_at":"2016-10-27T14:34:29Z","pushed_at":"2017-09-15T21:57:14Z","git_url":"git://github.com/ordina-jworks/ordina-jworks.github.io.git","ssh_url":"[email protected]:ordina-jworks/ordina-jworks.github.io.git","clone_url":"https://github.com/ordina-jworks/ordina-jworks.github.io.git","svn_url":"https://github.com/ordina-jworks/ordina-jworks.github.io","homepage":"","size":102602,"stargazers_count":7,"watchers_count":7,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":14,"forks":4,"open_issues":14,"watchers":7,"default_branch":"source"}},"_links":{"self":{"href":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/250"},"html":{"href":"https://github.com/ordina-jworks/ordina-jworks.github.io/pull/250"},"issue":{"href":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/issues/250"},"comments":{"href":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/issues/250/comments"},"review_comments":{"href":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/250/comments"},"review_comment":{"href":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/pulls/250/commits"},"statuses":{"href":"https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io/statuses/dc162fb595c3c5077e73df0cec8a5a9db0ed6e8c"}},"author_association":"NONE"}}
|
{
"id": 44804684,
"name": "ordina-jworks/ordina-jworks.github.io",
"url": "https://api.github.com/repos/ordina-jworks/ordina-jworks.github.io"
}
|
{
"id": 6283320,
"login": "TYsewyn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6283320?",
"url": "https://api.github.com/users/TYsewyn"
}
|
{
"id": 15261659,
"login": "ordina-jworks",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15261659?",
"url": "https://api.github.com/orgs/ordina-jworks"
}
| 2017-09-15T22:48:39 |
6597950493
|
{"actor":{"display_login":"TYsewyn"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/comments/112040694","pull_request_review_id":33325696,"id":112040694,"diff_hunk":"@@ -36,13 +36,17 @@ type WorkloadEndpointMetadata struct {\n \tName string `json:\"name,omitempty\" validate:\"omitempty,namespacedname\"`\n \n \t// The name of the workload.\n-\tWorkload string `json:\"workload,omitempty\" valid:\"omitempty,namespacedname\"`\n+\tWorkload string `json:\"workload,omitempty\" validate:\"omitempty,namespacedname\"`\n+\n+\t// ActiveInstanceID contains an identifier for the container networked for","path":"lib/api/workloadendpoint.go","position":7,"original_position":7,"commit_id":"43a85702e9d22a87fa6a88435fb187c3451a60ad","original_commit_id":"43a85702e9d22a87fa6a88435fb187c3451a60ad","user":{"login":"robbrockbank","id":3227729,"avatar_url":"https://avatars3.githubusercontent.com/u/3227729?v=3","gravatar_id":"","url":"https://api.github.com/users/robbrockbank","html_url":"https://github.com/robbrockbank","followers_url":"https://api.github.com/users/robbrockbank/followers","following_url":"https://api.github.com/users/robbrockbank/following{/other_user}","gists_url":"https://api.github.com/users/robbrockbank/gists{/gist_id}","starred_url":"https://api.github.com/users/robbrockbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbrockbank/subscriptions","organizations_url":"https://api.github.com/users/robbrockbank/orgs","repos_url":"https://api.github.com/users/robbrockbank/repos","events_url":"https://api.github.com/users/robbrockbank/events{/privacy}","received_events_url":"https://api.github.com/users/robbrockbank/received_events","type":"User","site_admin":false},"body":"Since this is optional and not actually a unique identifier, can you move this to be above the Labels field?\r\n\r\nI don't like this wording, and it doesn't actually say what it does with it. It should cover the following:\r\n\r\n- It isn't a unique identifier for the endpoint in that you cannot have multiple endpoints with the same Name, Workload, Orchestrator and Node and different ActiveInstanceIDs.\r\n- When you update/apply/create the endpoint, the endpoint uniquely identified by Node, Orchestrator, Workload and Name is updated to have the specified ActiveInstanceID.\r\n- When an ActiveInstanceID is store for the endpoint it is used to prevent deletion of the endpoint unless the delete request contains the same ActiveInstanceID (+ rules about what happens when it isn't specified).","created_at":"2017-04-18T19:19:41Z","updated_at":"2017-04-18T19:19:41Z","html_url":"https://github.com/projectcalico/libcalico-go/pull/396#discussion_r112040694","pull_request_url":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/396","_links":{"self":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/comments/112040694"},"html":{"href":"https://github.com/projectcalico/libcalico-go/pull/396#discussion_r112040694"},"pull_request":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/396"}}},"pull_request":{"url":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/396","id":116399081,"html_url":"https://github.com/projectcalico/libcalico-go/pull/396","diff_url":"https://github.com/projectcalico/libcalico-go/pull/396.diff","patch_url":"https://github.com/projectcalico/libcalico-go/pull/396.patch","issue_url":"https://api.github.com/repos/projectcalico/libcalico-go/issues/396","number":396,"state":"open","locked":false,"title":"Add ActiveInstanceID field under workloadEndpoint API","user":{"login":"gunjan5","id":5966968,"avatar_url":"https://avatars2.githubusercontent.com/u/5966968?v=3","gravatar_id":"","url":"https://api.github.com/users/gunjan5","html_url":"https://github.com/gunjan5","followers_url":"https://api.github.com/users/gunjan5/followers","following_url":"https://api.github.com/users/gunjan5/following{/other_user}","gists_url":"https://api.github.com/users/gunjan5/gists{/gist_id}","starred_url":"https://api.github.com/users/gunjan5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunjan5/subscriptions","organizations_url":"https://api.github.com/users/gunjan5/orgs","repos_url":"https://api.github.com/users/gunjan5/repos","events_url":"https://api.github.com/users/gunjan5/events{/privacy}","received_events_url":"https://api.github.com/users/gunjan5/received_events","type":"User","site_admin":false},"body":"Part of https://github.com/projectcalico/cni-plugin/issues/310\r\nRequired for https://github.com/projectcalico/cni-plugin/pull/312","created_at":"2017-04-18T19:10:02Z","updated_at":"2017-04-18T19:19:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88c88442f6d37b2ea8d9d8c31d61706e76bd677f","assignee":{"login":"robbrockbank","id":3227729,"avatar_url":"https://avatars3.githubusercontent.com/u/3227729?v=3","gravatar_id":"","url":"https://api.github.com/users/robbrockbank","html_url":"https://github.com/robbrockbank","followers_url":"https://api.github.com/users/robbrockbank/followers","following_url":"https://api.github.com/users/robbrockbank/following{/other_user}","gists_url":"https://api.github.com/users/robbrockbank/gists{/gist_id}","starred_url":"https://api.github.com/users/robbrockbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbrockbank/subscriptions","organizations_url":"https://api.github.com/users/robbrockbank/orgs","repos_url":"https://api.github.com/users/robbrockbank/repos","events_url":"https://api.github.com/users/robbrockbank/events{/privacy}","received_events_url":"https://api.github.com/users/robbrockbank/received_events","type":"User","site_admin":false},"assignees":[{"login":"robbrockbank","id":3227729,"avatar_url":"https://avatars3.githubusercontent.com/u/3227729?v=3","gravatar_id":"","url":"https://api.github.com/users/robbrockbank","html_url":"https://github.com/robbrockbank","followers_url":"https://api.github.com/users/robbrockbank/followers","following_url":"https://api.github.com/users/robbrockbank/following{/other_user}","gists_url":"https://api.github.com/users/robbrockbank/gists{/gist_id}","starred_url":"https://api.github.com/users/robbrockbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbrockbank/subscriptions","organizations_url":"https://api.github.com/users/robbrockbank/orgs","repos_url":"https://api.github.com/users/robbrockbank/repos","events_url":"https://api.github.com/users/robbrockbank/events{/privacy}","received_events_url":"https://api.github.com/users/robbrockbank/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/396/commits","review_comments_url":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/396/comments","review_comment_url":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectcalico/libcalico-go/issues/396/comments","statuses_url":"https://api.github.com/repos/projectcalico/libcalico-go/statuses/43a85702e9d22a87fa6a88435fb187c3451a60ad","head":{"label":"gunjan5:cid","ref":"cid","sha":"43a85702e9d22a87fa6a88435fb187c3451a60ad","user":{"login":"gunjan5","id":5966968,"avatar_url":"https://avatars2.githubusercontent.com/u/5966968?v=3","gravatar_id":"","url":"https://api.github.com/users/gunjan5","html_url":"https://github.com/gunjan5","followers_url":"https://api.github.com/users/gunjan5/followers","following_url":"https://api.github.com/users/gunjan5/following{/other_user}","gists_url":"https://api.github.com/users/gunjan5/gists{/gist_id}","starred_url":"https://api.github.com/users/gunjan5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunjan5/subscriptions","organizations_url":"https://api.github.com/users/gunjan5/orgs","repos_url":"https://api.github.com/users/gunjan5/repos","events_url":"https://api.github.com/users/gunjan5/events{/privacy}","received_events_url":"https://api.github.com/users/gunjan5/received_events","type":"User","site_admin":false},"repo":{"id":71182096,"name":"libcalico-go","full_name":"gunjan5/libcalico-go","owner":{"login":"gunjan5","id":5966968,"avatar_url":"https://avatars2.githubusercontent.com/u/5966968?v=3","gravatar_id":"","url":"https://api.github.com/users/gunjan5","html_url":"https://github.com/gunjan5","followers_url":"https://api.github.com/users/gunjan5/followers","following_url":"https://api.github.com/users/gunjan5/following{/other_user}","gists_url":"https://api.github.com/users/gunjan5/gists{/gist_id}","starred_url":"https://api.github.com/users/gunjan5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunjan5/subscriptions","organizations_url":"https://api.github.com/users/gunjan5/orgs","repos_url":"https://api.github.com/users/gunjan5/repos","events_url":"https://api.github.com/users/gunjan5/events{/privacy}","received_events_url":"https://api.github.com/users/gunjan5/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gunjan5/libcalico-go","description":"Golang Calico library functions: https://www.projectcalico.org","fork":true,"url":"https://api.github.com/repos/gunjan5/libcalico-go","forks_url":"https://api.github.com/repos/gunjan5/libcalico-go/forks","keys_url":"https://api.github.com/repos/gunjan5/libcalico-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gunjan5/libcalico-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gunjan5/libcalico-go/teams","hooks_url":"https://api.github.com/repos/gunjan5/libcalico-go/hooks","issue_events_url":"https://api.github.com/repos/gunjan5/libcalico-go/issues/events{/number}","events_url":"https://api.github.com/repos/gunjan5/libcalico-go/events","assignees_url":"https://api.github.com/repos/gunjan5/libcalico-go/assignees{/user}","branches_url":"https://api.github.com/repos/gunjan5/libcalico-go/branches{/branch}","tags_url":"https://api.github.com/repos/gunjan5/libcalico-go/tags","blobs_url":"https://api.github.com/repos/gunjan5/libcalico-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gunjan5/libcalico-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gunjan5/libcalico-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/gunjan5/libcalico-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gunjan5/libcalico-go/statuses/{sha}","languages_url":"https://api.github.com/repos/gunjan5/libcalico-go/languages","stargazers_url":"https://api.github.com/repos/gunjan5/libcalico-go/stargazers","contributors_url":"https://api.github.com/repos/gunjan5/libcalico-go/contributors","subscribers_url":"https://api.github.com/repos/gunjan5/libcalico-go/subscribers","subscription_url":"https://api.github.com/repos/gunjan5/libcalico-go/subscription","commits_url":"https://api.github.com/repos/gunjan5/libcalico-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/gunjan5/libcalico-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/gunjan5/libcalico-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/gunjan5/libcalico-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/gunjan5/libcalico-go/contents/{+path}","compare_url":"https://api.github.com/repos/gunjan5/libcalico-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gunjan5/libcalico-go/merges","archive_url":"https://api.github.com/repos/gunjan5/libcalico-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gunjan5/libcalico-go/downloads","issues_url":"https://api.github.com/repos/gunjan5/libcalico-go/issues{/number}","pulls_url":"https://api.github.com/repos/gunjan5/libcalico-go/pulls{/number}","milestones_url":"https://api.github.com/repos/gunjan5/libcalico-go/milestones{/number}","notifications_url":"https://api.github.com/repos/gunjan5/libcalico-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gunjan5/libcalico-go/labels{/name}","releases_url":"https://api.github.com/repos/gunjan5/libcalico-go/releases{/id}","deployments_url":"https://api.github.com/repos/gunjan5/libcalico-go/deployments","created_at":"2016-10-17T21:18:27Z","updated_at":"2017-03-09T22:40:34Z","pushed_at":"2017-04-18T19:08:40Z","git_url":"git://github.com/gunjan5/libcalico-go.git","ssh_url":"[email protected]:gunjan5/libcalico-go.git","clone_url":"https://github.com/gunjan5/libcalico-go.git","svn_url":"https://github.com/gunjan5/libcalico-go","homepage":null,"size":1166,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectcalico:master","ref":"master","sha":"915a7231889467277759b0e2382ab41397332c5d","user":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars0.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"repo":{"id":63438319,"name":"libcalico-go","full_name":"projectcalico/libcalico-go","owner":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars0.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectcalico/libcalico-go","description":"Golang Calico library functions: https://www.projectcalico.org","fork":false,"url":"https://api.github.com/repos/projectcalico/libcalico-go","forks_url":"https://api.github.com/repos/projectcalico/libcalico-go/forks","keys_url":"https://api.github.com/repos/projectcalico/libcalico-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectcalico/libcalico-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectcalico/libcalico-go/teams","hooks_url":"https://api.github.com/repos/projectcalico/libcalico-go/hooks","issue_events_url":"https://api.github.com/repos/projectcalico/libcalico-go/issues/events{/number}","events_url":"https://api.github.com/repos/projectcalico/libcalico-go/events","assignees_url":"https://api.github.com/repos/projectcalico/libcalico-go/assignees{/user}","branches_url":"https://api.github.com/repos/projectcalico/libcalico-go/branches{/branch}","tags_url":"https://api.github.com/repos/projectcalico/libcalico-go/tags","blobs_url":"https://api.github.com/repos/projectcalico/libcalico-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectcalico/libcalico-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectcalico/libcalico-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectcalico/libcalico-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectcalico/libcalico-go/statuses/{sha}","languages_url":"https://api.github.com/repos/projectcalico/libcalico-go/languages","stargazers_url":"https://api.github.com/repos/projectcalico/libcalico-go/stargazers","contributors_url":"https://api.github.com/repos/projectcalico/libcalico-go/contributors","subscribers_url":"https://api.github.com/repos/projectcalico/libcalico-go/subscribers","subscription_url":"https://api.github.com/repos/projectcalico/libcalico-go/subscription","commits_url":"https://api.github.com/repos/projectcalico/libcalico-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectcalico/libcalico-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectcalico/libcalico-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectcalico/libcalico-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectcalico/libcalico-go/contents/{+path}","compare_url":"https://api.github.com/repos/projectcalico/libcalico-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectcalico/libcalico-go/merges","archive_url":"https://api.github.com/repos/projectcalico/libcalico-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectcalico/libcalico-go/downloads","issues_url":"https://api.github.com/repos/projectcalico/libcalico-go/issues{/number}","pulls_url":"https://api.github.com/repos/projectcalico/libcalico-go/pulls{/number}","milestones_url":"https://api.github.com/repos/projectcalico/libcalico-go/milestones{/number}","notifications_url":"https://api.github.com/repos/projectcalico/libcalico-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectcalico/libcalico-go/labels{/name}","releases_url":"https://api.github.com/repos/projectcalico/libcalico-go/releases{/id}","deployments_url":"https://api.github.com/repos/projectcalico/libcalico-go/deployments","created_at":"2016-07-15T17:09:40Z","updated_at":"2017-03-28T02:49:28Z","pushed_at":"2017-04-18T19:10:02Z","git_url":"git://github.com/projectcalico/libcalico-go.git","ssh_url":"[email protected]:projectcalico/libcalico-go.git","clone_url":"https://github.com/projectcalico/libcalico-go.git","svn_url":"https://github.com/projectcalico/libcalico-go","homepage":null,"size":1149,"stargazers_count":23,"watchers_count":23,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":35,"forks":35,"open_issues":35,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/396"},"html":{"href":"https://github.com/projectcalico/libcalico-go/pull/396"},"issue":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/issues/396"},"comments":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/issues/396/comments"},"review_comments":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/396/comments"},"review_comment":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/396/commits"},"statuses":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/statuses/43a85702e9d22a87fa6a88435fb187c3451a60ad"}}}}
|
{
"id": 63438319,
"name": "projectcalico/libcalico-go",
"url": "https://api.github.com/repos/projectcalico/libcalico-go"
}
|
{
"id": 3227729,
"login": "robbrockbank",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3227729?",
"url": "https://api.github.com/users/robbrockbank"
}
|
{
"id": 12304728,
"login": "projectcalico",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12304728?",
"url": "https://api.github.com/orgs/projectcalico"
}
| 2017-04-18T19:19:41 |
5709936309
|
{"actor":{"display_login":"robbrockbank"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/stackbuilders/stache/pulls/comments/140626916","pull_request_review_id":64732819,"id":140626916,"diff_hunk":"@@ -1,3 +1,8 @@\n+## Stache 1.1.3\n+\n+* Added `compileMustacheDirCustom` that allows custom file extensions such as `.mush`\n+* Updated to stackage 9.5, and Megaparsec 6.1.1","path":"CHANGELOG.md","position":4,"original_position":4,"commit_id":"d8627d1182f9ebb1d7c9dac97fe5c3dc479e07e1","original_commit_id":"d8627d1182f9ebb1d7c9dac97fe5c3dc479e07e1","user":{"login":"mrkkrp","id":8165792,"avatar_url":"https://avatars0.githubusercontent.com/u/8165792?v=4","gravatar_id":"","url":"https://api.github.com/users/mrkkrp","html_url":"https://github.com/mrkkrp","followers_url":"https://api.github.com/users/mrkkrp/followers","following_url":"https://api.github.com/users/mrkkrp/following{/other_user}","gists_url":"https://api.github.com/users/mrkkrp/gists{/gist_id}","starred_url":"https://api.github.com/users/mrkkrp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrkkrp/subscriptions","organizations_url":"https://api.github.com/users/mrkkrp/orgs","repos_url":"https://api.github.com/users/mrkkrp/repos","events_url":"https://api.github.com/users/mrkkrp/events{/privacy}","received_events_url":"https://api.github.com/users/mrkkrp/received_events","type":"User","site_admin":false},"body":"Please drop \"Updated to stackage 9.5, and Megaparsec 6.1.1\". `stack.yaml` is not a part of the actual package in any way, it's just a file in the repo (for convenience).\r\n\r\n----\r\n\r\nAlso please end the previous point with a full stop (sorry for nitpicking).","created_at":"2017-09-23T05:45:26Z","updated_at":"2017-09-23T06:01:10Z","html_url":"https://github.com/stackbuilders/stache/pull/27#discussion_r140626916","pull_request_url":"https://api.github.com/repos/stackbuilders/stache/pulls/27","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/stackbuilders/stache/pulls/comments/140626916"},"html":{"href":"https://github.com/stackbuilders/stache/pull/27#discussion_r140626916"},"pull_request":{"href":"https://api.github.com/repos/stackbuilders/stache/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/stackbuilders/stache/pulls/27","id":142698372,"html_url":"https://github.com/stackbuilders/stache/pull/27","diff_url":"https://github.com/stackbuilders/stache/pull/27.diff","patch_url":"https://github.com/stackbuilders/stache/pull/27.patch","issue_url":"https://api.github.com/repos/stackbuilders/stache/issues/27","number":27,"state":"open","locked":false,"title":"Add compileMustacheDirCustom","user":{"login":"logankaser","id":7916909,"avatar_url":"https://avatars0.githubusercontent.com/u/7916909?v=4","gravatar_id":"","url":"https://api.github.com/users/logankaser","html_url":"https://github.com/logankaser","followers_url":"https://api.github.com/users/logankaser/followers","following_url":"https://api.github.com/users/logankaser/following{/other_user}","gists_url":"https://api.github.com/users/logankaser/gists{/gist_id}","starred_url":"https://api.github.com/users/logankaser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logankaser/subscriptions","organizations_url":"https://api.github.com/users/logankaser/orgs","repos_url":"https://api.github.com/users/logankaser/repos","events_url":"https://api.github.com/users/logankaser/events{/privacy}","received_events_url":"https://api.github.com/users/logankaser/received_events","type":"User","site_admin":false},"body":"* adds compileMustacheDirCustom which allows arbitrary extension names for those who don't like to type out `.mustache`\r\n\r\n* Bumps Stackage version to 9.5 & MegaParsec to 6.1.1 (Bugfixes only)\r\n","created_at":"2017-09-23T03:26:30Z","updated_at":"2017-09-23T06:01:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"459e190473b0f6cf2eac63995fe05f63987863ed","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/stackbuilders/stache/pulls/27/commits","review_comments_url":"https://api.github.com/repos/stackbuilders/stache/pulls/27/comments","review_comment_url":"https://api.github.com/repos/stackbuilders/stache/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stackbuilders/stache/issues/27/comments","statuses_url":"https://api.github.com/repos/stackbuilders/stache/statuses/d8627d1182f9ebb1d7c9dac97fe5c3dc479e07e1","head":{"label":"logankaser:master","ref":"master","sha":"d8627d1182f9ebb1d7c9dac97fe5c3dc479e07e1","user":{"login":"logankaser","id":7916909,"avatar_url":"https://avatars0.githubusercontent.com/u/7916909?v=4","gravatar_id":"","url":"https://api.github.com/users/logankaser","html_url":"https://github.com/logankaser","followers_url":"https://api.github.com/users/logankaser/followers","following_url":"https://api.github.com/users/logankaser/following{/other_user}","gists_url":"https://api.github.com/users/logankaser/gists{/gist_id}","starred_url":"https://api.github.com/users/logankaser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logankaser/subscriptions","organizations_url":"https://api.github.com/users/logankaser/orgs","repos_url":"https://api.github.com/users/logankaser/repos","events_url":"https://api.github.com/users/logankaser/events{/privacy}","received_events_url":"https://api.github.com/users/logankaser/received_events","type":"User","site_admin":false},"repo":{"id":104535947,"name":"stache","full_name":"logankaser/stache","owner":{"login":"logankaser","id":7916909,"avatar_url":"https://avatars0.githubusercontent.com/u/7916909?v=4","gravatar_id":"","url":"https://api.github.com/users/logankaser","html_url":"https://github.com/logankaser","followers_url":"https://api.github.com/users/logankaser/followers","following_url":"https://api.github.com/users/logankaser/following{/other_user}","gists_url":"https://api.github.com/users/logankaser/gists{/gist_id}","starred_url":"https://api.github.com/users/logankaser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logankaser/subscriptions","organizations_url":"https://api.github.com/users/logankaser/orgs","repos_url":"https://api.github.com/users/logankaser/repos","events_url":"https://api.github.com/users/logankaser/events{/privacy}","received_events_url":"https://api.github.com/users/logankaser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/logankaser/stache","description":"Mustache templates for Haskell","fork":true,"url":"https://api.github.com/repos/logankaser/stache","forks_url":"https://api.github.com/repos/logankaser/stache/forks","keys_url":"https://api.github.com/repos/logankaser/stache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logankaser/stache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logankaser/stache/teams","hooks_url":"https://api.github.com/repos/logankaser/stache/hooks","issue_events_url":"https://api.github.com/repos/logankaser/stache/issues/events{/number}","events_url":"https://api.github.com/repos/logankaser/stache/events","assignees_url":"https://api.github.com/repos/logankaser/stache/assignees{/user}","branches_url":"https://api.github.com/repos/logankaser/stache/branches{/branch}","tags_url":"https://api.github.com/repos/logankaser/stache/tags","blobs_url":"https://api.github.com/repos/logankaser/stache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logankaser/stache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logankaser/stache/git/refs{/sha}","trees_url":"https://api.github.com/repos/logankaser/stache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logankaser/stache/statuses/{sha}","languages_url":"https://api.github.com/repos/logankaser/stache/languages","stargazers_url":"https://api.github.com/repos/logankaser/stache/stargazers","contributors_url":"https://api.github.com/repos/logankaser/stache/contributors","subscribers_url":"https://api.github.com/repos/logankaser/stache/subscribers","subscription_url":"https://api.github.com/repos/logankaser/stache/subscription","commits_url":"https://api.github.com/repos/logankaser/stache/commits{/sha}","git_commits_url":"https://api.github.com/repos/logankaser/stache/git/commits{/sha}","comments_url":"https://api.github.com/repos/logankaser/stache/comments{/number}","issue_comment_url":"https://api.github.com/repos/logankaser/stache/issues/comments{/number}","contents_url":"https://api.github.com/repos/logankaser/stache/contents/{+path}","compare_url":"https://api.github.com/repos/logankaser/stache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logankaser/stache/merges","archive_url":"https://api.github.com/repos/logankaser/stache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logankaser/stache/downloads","issues_url":"https://api.github.com/repos/logankaser/stache/issues{/number}","pulls_url":"https://api.github.com/repos/logankaser/stache/pulls{/number}","milestones_url":"https://api.github.com/repos/logankaser/stache/milestones{/number}","notifications_url":"https://api.github.com/repos/logankaser/stache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logankaser/stache/labels{/name}","releases_url":"https://api.github.com/repos/logankaser/stache/releases{/id}","deployments_url":"https://api.github.com/repos/logankaser/stache/deployments","created_at":"2017-09-23T02:41:23Z","updated_at":"2017-09-23T02:41:25Z","pushed_at":"2017-09-23T05:21:47Z","git_url":"git://github.com/logankaser/stache.git","ssh_url":"[email protected]:logankaser/stache.git","clone_url":"https://github.com/logankaser/stache.git","svn_url":"https://github.com/logankaser/stache","homepage":"","size":109,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stackbuilders:master","ref":"master","sha":"85c1e96aec6964ca571e2805b7760365eba061eb","user":{"login":"stackbuilders","id":526755,"avatar_url":"https://avatars3.githubusercontent.com/u/526755?v=4","gravatar_id":"","url":"https://api.github.com/users/stackbuilders","html_url":"https://github.com/stackbuilders","followers_url":"https://api.github.com/users/stackbuilders/followers","following_url":"https://api.github.com/users/stackbuilders/following{/other_user}","gists_url":"https://api.github.com/users/stackbuilders/gists{/gist_id}","starred_url":"https://api.github.com/users/stackbuilders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stackbuilders/subscriptions","organizations_url":"https://api.github.com/users/stackbuilders/orgs","repos_url":"https://api.github.com/users/stackbuilders/repos","events_url":"https://api.github.com/users/stackbuilders/events{/privacy}","received_events_url":"https://api.github.com/users/stackbuilders/received_events","type":"Organization","site_admin":false},"repo":{"id":61818483,"name":"stache","full_name":"stackbuilders/stache","owner":{"login":"stackbuilders","id":526755,"avatar_url":"https://avatars3.githubusercontent.com/u/526755?v=4","gravatar_id":"","url":"https://api.github.com/users/stackbuilders","html_url":"https://github.com/stackbuilders","followers_url":"https://api.github.com/users/stackbuilders/followers","following_url":"https://api.github.com/users/stackbuilders/following{/other_user}","gists_url":"https://api.github.com/users/stackbuilders/gists{/gist_id}","starred_url":"https://api.github.com/users/stackbuilders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stackbuilders/subscriptions","organizations_url":"https://api.github.com/users/stackbuilders/orgs","repos_url":"https://api.github.com/users/stackbuilders/repos","events_url":"https://api.github.com/users/stackbuilders/events{/privacy}","received_events_url":"https://api.github.com/users/stackbuilders/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stackbuilders/stache","description":"Mustache templates for Haskell","fork":false,"url":"https://api.github.com/repos/stackbuilders/stache","forks_url":"https://api.github.com/repos/stackbuilders/stache/forks","keys_url":"https://api.github.com/repos/stackbuilders/stache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stackbuilders/stache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stackbuilders/stache/teams","hooks_url":"https://api.github.com/repos/stackbuilders/stache/hooks","issue_events_url":"https://api.github.com/repos/stackbuilders/stache/issues/events{/number}","events_url":"https://api.github.com/repos/stackbuilders/stache/events","assignees_url":"https://api.github.com/repos/stackbuilders/stache/assignees{/user}","branches_url":"https://api.github.com/repos/stackbuilders/stache/branches{/branch}","tags_url":"https://api.github.com/repos/stackbuilders/stache/tags","blobs_url":"https://api.github.com/repos/stackbuilders/stache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stackbuilders/stache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stackbuilders/stache/git/refs{/sha}","trees_url":"https://api.github.com/repos/stackbuilders/stache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stackbuilders/stache/statuses/{sha}","languages_url":"https://api.github.com/repos/stackbuilders/stache/languages","stargazers_url":"https://api.github.com/repos/stackbuilders/stache/stargazers","contributors_url":"https://api.github.com/repos/stackbuilders/stache/contributors","subscribers_url":"https://api.github.com/repos/stackbuilders/stache/subscribers","subscription_url":"https://api.github.com/repos/stackbuilders/stache/subscription","commits_url":"https://api.github.com/repos/stackbuilders/stache/commits{/sha}","git_commits_url":"https://api.github.com/repos/stackbuilders/stache/git/commits{/sha}","comments_url":"https://api.github.com/repos/stackbuilders/stache/comments{/number}","issue_comment_url":"https://api.github.com/repos/stackbuilders/stache/issues/comments{/number}","contents_url":"https://api.github.com/repos/stackbuilders/stache/contents/{+path}","compare_url":"https://api.github.com/repos/stackbuilders/stache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stackbuilders/stache/merges","archive_url":"https://api.github.com/repos/stackbuilders/stache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stackbuilders/stache/downloads","issues_url":"https://api.github.com/repos/stackbuilders/stache/issues{/number}","pulls_url":"https://api.github.com/repos/stackbuilders/stache/pulls{/number}","milestones_url":"https://api.github.com/repos/stackbuilders/stache/milestones{/number}","notifications_url":"https://api.github.com/repos/stackbuilders/stache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stackbuilders/stache/labels{/name}","releases_url":"https://api.github.com/repos/stackbuilders/stache/releases{/id}","deployments_url":"https://api.github.com/repos/stackbuilders/stache/deployments","created_at":"2016-06-23T16:03:12Z","updated_at":"2017-09-13T05:21:13Z","pushed_at":"2017-09-23T05:21:48Z","git_url":"git://github.com/stackbuilders/stache.git","ssh_url":"[email protected]:stackbuilders/stache.git","clone_url":"https://github.com/stackbuilders/stache.git","svn_url":"https://github.com/stackbuilders/stache","homepage":"","size":108,"stargazers_count":13,"watchers_count":13,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stackbuilders/stache/pulls/27"},"html":{"href":"https://github.com/stackbuilders/stache/pull/27"},"issue":{"href":"https://api.github.com/repos/stackbuilders/stache/issues/27"},"comments":{"href":"https://api.github.com/repos/stackbuilders/stache/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/stackbuilders/stache/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/stackbuilders/stache/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stackbuilders/stache/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/stackbuilders/stache/statuses/d8627d1182f9ebb1d7c9dac97fe5c3dc479e07e1"}},"author_association":"NONE"}}
|
{
"id": 61818483,
"name": "stackbuilders/stache",
"url": "https://api.github.com/repos/stackbuilders/stache"
}
|
{
"id": 8165792,
"login": "mrkkrp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8165792?",
"url": "https://api.github.com/users/mrkkrp"
}
|
{
"id": 526755,
"login": "stackbuilders",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/526755?",
"url": "https://api.github.com/orgs/stackbuilders"
}
| 2017-09-23T05:45:26 |
6627624778
|
{"actor":{"display_login":"mrkkrp"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/wellcometrust/loris-docker/pulls/comments/124501033","pull_request_review_id":46793264,"id":124501033,"diff_hunk":"@@ -0,0 +1,39 @@\n+#!/usr/bin/env sh\n+# This script installs Loris in Alpine Linux.\n+\n+set -o errexit\n+set -o nounset\n+\n+DOWNLOAD_URL=\"https://github.com/loris-imageserver/loris/archive/v2.1.0-final.zip\"\n+DOWNLOAD_PATH=\"v2.1.0-final.zip\"\n+DOWNLOAD_DIR=\"loris-2.1.0-final\"\n+\n+apk update\n+\n+# Start by downloading Loris. It isn't installable through pip (yet), so\n+# we have to download a ZIP bundle from GitHub and unpack it from there.\n+apk add ca-certificates unzip wget","path":"install_loris.sh","position":15,"original_position":15,"commit_id":"75722cf826e8e5a5b7ccfb3216c1bddc66f3dec5","original_commit_id":"75722cf826e8e5a5b7ccfb3216c1bddc66f3dec5","user":{"login":"alexwlchan","id":301220,"avatar_url":"https://avatars3.githubusercontent.com/u/301220?v=3","gravatar_id":"","url":"https://api.github.com/users/alexwlchan","html_url":"https://github.com/alexwlchan","followers_url":"https://api.github.com/users/alexwlchan/followers","following_url":"https://api.github.com/users/alexwlchan/following{/other_user}","gists_url":"https://api.github.com/users/alexwlchan/gists{/gist_id}","starred_url":"https://api.github.com/users/alexwlchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexwlchan/subscriptions","organizations_url":"https://api.github.com/users/alexwlchan/orgs","repos_url":"https://api.github.com/users/alexwlchan/repos","events_url":"https://api.github.com/users/alexwlchan/events{/privacy}","received_events_url":"https://api.github.com/users/alexwlchan/received_events","type":"User","site_admin":false},"body":"Why do we need ca-certificates?","created_at":"2017-06-28T10:04:18Z","updated_at":"2017-06-28T10:07:53Z","html_url":"https://github.com/wellcometrust/loris-docker/pull/1#discussion_r124501033","pull_request_url":"https://api.github.com/repos/wellcometrust/loris-docker/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/wellcometrust/loris-docker/pulls/comments/124501033"},"html":{"href":"https://github.com/wellcometrust/loris-docker/pull/1#discussion_r124501033"},"pull_request":{"href":"https://api.github.com/repos/wellcometrust/loris-docker/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/wellcometrust/loris-docker/pulls/1","id":127885613,"html_url":"https://github.com/wellcometrust/loris-docker/pull/1","diff_url":"https://github.com/wellcometrust/loris-docker/pull/1.diff","patch_url":"https://github.com/wellcometrust/loris-docker/pull/1.patch","issue_url":"https://api.github.com/repos/wellcometrust/loris-docker/issues/1","number":1,"state":"open","locked":false,"title":"[WIP] Initial Docker container build with Alpine","user":{"login":"alexwlchan","id":301220,"avatar_url":"https://avatars3.githubusercontent.com/u/301220?v=3","gravatar_id":"","url":"https://api.github.com/users/alexwlchan","html_url":"https://github.com/alexwlchan","followers_url":"https://api.github.com/users/alexwlchan/followers","following_url":"https://api.github.com/users/alexwlchan/following{/other_user}","gists_url":"https://api.github.com/users/alexwlchan/gists{/gist_id}","starred_url":"https://api.github.com/users/alexwlchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexwlchan/subscriptions","organizations_url":"https://api.github.com/users/alexwlchan/orgs","repos_url":"https://api.github.com/users/alexwlchan/repos","events_url":"https://api.github.com/users/alexwlchan/events{/privacy}","received_events_url":"https://api.github.com/users/alexwlchan/received_events","type":"User","site_admin":false},"body":"This is copied from https://github.com/wellcometrust/platform-api/pull/450.\r\n\r\nStill to do:\r\n\r\n- [ ] Split into two images, one with nginx and one without\r\n- [ ] Tidy the commit history\r\n- [ ] Scrutinise what I’m actually checking in! A lot of this is copy/pasted from other projects.","created_at":"2017-06-28T10:02:13Z","updated_at":"2017-06-28T10:07:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7407d55bea4a185d06c565c217df1b0c8291324","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/wellcometrust/loris-docker/pulls/1/commits","review_comments_url":"https://api.github.com/repos/wellcometrust/loris-docker/pulls/1/comments","review_comment_url":"https://api.github.com/repos/wellcometrust/loris-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wellcometrust/loris-docker/issues/1/comments","statuses_url":"https://api.github.com/repos/wellcometrust/loris-docker/statuses/75722cf826e8e5a5b7ccfb3216c1bddc66f3dec5","head":{"label":"wellcometrust:initial-alpine","ref":"initial-alpine","sha":"75722cf826e8e5a5b7ccfb3216c1bddc66f3dec5","user":{"login":"wellcometrust","id":2814213,"avatar_url":"https://avatars0.githubusercontent.com/u/2814213?v=3","gravatar_id":"","url":"https://api.github.com/users/wellcometrust","html_url":"https://github.com/wellcometrust","followers_url":"https://api.github.com/users/wellcometrust/followers","following_url":"https://api.github.com/users/wellcometrust/following{/other_user}","gists_url":"https://api.github.com/users/wellcometrust/gists{/gist_id}","starred_url":"https://api.github.com/users/wellcometrust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellcometrust/subscriptions","organizations_url":"https://api.github.com/users/wellcometrust/orgs","repos_url":"https://api.github.com/users/wellcometrust/repos","events_url":"https://api.github.com/users/wellcometrust/events{/privacy}","received_events_url":"https://api.github.com/users/wellcometrust/received_events","type":"Organization","site_admin":false},"repo":{"id":95654499,"name":"loris-docker","full_name":"wellcometrust/loris-docker","owner":{"login":"wellcometrust","id":2814213,"avatar_url":"https://avatars0.githubusercontent.com/u/2814213?v=3","gravatar_id":"","url":"https://api.github.com/users/wellcometrust","html_url":"https://github.com/wellcometrust","followers_url":"https://api.github.com/users/wellcometrust/followers","following_url":"https://api.github.com/users/wellcometrust/following{/other_user}","gists_url":"https://api.github.com/users/wellcometrust/gists{/gist_id}","starred_url":"https://api.github.com/users/wellcometrust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellcometrust/subscriptions","organizations_url":"https://api.github.com/users/wellcometrust/orgs","repos_url":"https://api.github.com/users/wellcometrust/repos","events_url":"https://api.github.com/users/wellcometrust/events{/privacy}","received_events_url":"https://api.github.com/users/wellcometrust/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wellcometrust/loris-docker","description":"A Docker image for the Loris IIIF image server","fork":false,"url":"https://api.github.com/repos/wellcometrust/loris-docker","forks_url":"https://api.github.com/repos/wellcometrust/loris-docker/forks","keys_url":"https://api.github.com/repos/wellcometrust/loris-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wellcometrust/loris-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wellcometrust/loris-docker/teams","hooks_url":"https://api.github.com/repos/wellcometrust/loris-docker/hooks","issue_events_url":"https://api.github.com/repos/wellcometrust/loris-docker/issues/events{/number}","events_url":"https://api.github.com/repos/wellcometrust/loris-docker/events","assignees_url":"https://api.github.com/repos/wellcometrust/loris-docker/assignees{/user}","branches_url":"https://api.github.com/repos/wellcometrust/loris-docker/branches{/branch}","tags_url":"https://api.github.com/repos/wellcometrust/loris-docker/tags","blobs_url":"https://api.github.com/repos/wellcometrust/loris-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wellcometrust/loris-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wellcometrust/loris-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/wellcometrust/loris-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wellcometrust/loris-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/wellcometrust/loris-docker/languages","stargazers_url":"https://api.github.com/repos/wellcometrust/loris-docker/stargazers","contributors_url":"https://api.github.com/repos/wellcometrust/loris-docker/contributors","subscribers_url":"https://api.github.com/repos/wellcometrust/loris-docker/subscribers","subscription_url":"https://api.github.com/repos/wellcometrust/loris-docker/subscription","commits_url":"https://api.github.com/repos/wellcometrust/loris-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/wellcometrust/loris-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/wellcometrust/loris-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/wellcometrust/loris-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/wellcometrust/loris-docker/contents/{+path}","compare_url":"https://api.github.com/repos/wellcometrust/loris-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wellcometrust/loris-docker/merges","archive_url":"https://api.github.com/repos/wellcometrust/loris-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wellcometrust/loris-docker/downloads","issues_url":"https://api.github.com/repos/wellcometrust/loris-docker/issues{/number}","pulls_url":"https://api.github.com/repos/wellcometrust/loris-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/wellcometrust/loris-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/wellcometrust/loris-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wellcometrust/loris-docker/labels{/name}","releases_url":"https://api.github.com/repos/wellcometrust/loris-docker/releases{/id}","deployments_url":"https://api.github.com/repos/wellcometrust/loris-docker/deployments","created_at":"2017-06-28T09:51:46Z","updated_at":"2017-06-28T09:54:47Z","pushed_at":"2017-06-28T10:02:13Z","git_url":"git://github.com/wellcometrust/loris-docker.git","ssh_url":"[email protected]:wellcometrust/loris-docker.git","clone_url":"https://github.com/wellcometrust/loris-docker.git","svn_url":"https://github.com/wellcometrust/loris-docker","homepage":"","size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"wellcometrust:master","ref":"master","sha":"73b502fa66748af60703feff30bc73a4a7c4c894","user":{"login":"wellcometrust","id":2814213,"avatar_url":"https://avatars0.githubusercontent.com/u/2814213?v=3","gravatar_id":"","url":"https://api.github.com/users/wellcometrust","html_url":"https://github.com/wellcometrust","followers_url":"https://api.github.com/users/wellcometrust/followers","following_url":"https://api.github.com/users/wellcometrust/following{/other_user}","gists_url":"https://api.github.com/users/wellcometrust/gists{/gist_id}","starred_url":"https://api.github.com/users/wellcometrust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellcometrust/subscriptions","organizations_url":"https://api.github.com/users/wellcometrust/orgs","repos_url":"https://api.github.com/users/wellcometrust/repos","events_url":"https://api.github.com/users/wellcometrust/events{/privacy}","received_events_url":"https://api.github.com/users/wellcometrust/received_events","type":"Organization","site_admin":false},"repo":{"id":95654499,"name":"loris-docker","full_name":"wellcometrust/loris-docker","owner":{"login":"wellcometrust","id":2814213,"avatar_url":"https://avatars0.githubusercontent.com/u/2814213?v=3","gravatar_id":"","url":"https://api.github.com/users/wellcometrust","html_url":"https://github.com/wellcometrust","followers_url":"https://api.github.com/users/wellcometrust/followers","following_url":"https://api.github.com/users/wellcometrust/following{/other_user}","gists_url":"https://api.github.com/users/wellcometrust/gists{/gist_id}","starred_url":"https://api.github.com/users/wellcometrust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellcometrust/subscriptions","organizations_url":"https://api.github.com/users/wellcometrust/orgs","repos_url":"https://api.github.com/users/wellcometrust/repos","events_url":"https://api.github.com/users/wellcometrust/events{/privacy}","received_events_url":"https://api.github.com/users/wellcometrust/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wellcometrust/loris-docker","description":"A Docker image for the Loris IIIF image server","fork":false,"url":"https://api.github.com/repos/wellcometrust/loris-docker","forks_url":"https://api.github.com/repos/wellcometrust/loris-docker/forks","keys_url":"https://api.github.com/repos/wellcometrust/loris-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wellcometrust/loris-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wellcometrust/loris-docker/teams","hooks_url":"https://api.github.com/repos/wellcometrust/loris-docker/hooks","issue_events_url":"https://api.github.com/repos/wellcometrust/loris-docker/issues/events{/number}","events_url":"https://api.github.com/repos/wellcometrust/loris-docker/events","assignees_url":"https://api.github.com/repos/wellcometrust/loris-docker/assignees{/user}","branches_url":"https://api.github.com/repos/wellcometrust/loris-docker/branches{/branch}","tags_url":"https://api.github.com/repos/wellcometrust/loris-docker/tags","blobs_url":"https://api.github.com/repos/wellcometrust/loris-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wellcometrust/loris-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wellcometrust/loris-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/wellcometrust/loris-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wellcometrust/loris-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/wellcometrust/loris-docker/languages","stargazers_url":"https://api.github.com/repos/wellcometrust/loris-docker/stargazers","contributors_url":"https://api.github.com/repos/wellcometrust/loris-docker/contributors","subscribers_url":"https://api.github.com/repos/wellcometrust/loris-docker/subscribers","subscription_url":"https://api.github.com/repos/wellcometrust/loris-docker/subscription","commits_url":"https://api.github.com/repos/wellcometrust/loris-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/wellcometrust/loris-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/wellcometrust/loris-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/wellcometrust/loris-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/wellcometrust/loris-docker/contents/{+path}","compare_url":"https://api.github.com/repos/wellcometrust/loris-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wellcometrust/loris-docker/merges","archive_url":"https://api.github.com/repos/wellcometrust/loris-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wellcometrust/loris-docker/downloads","issues_url":"https://api.github.com/repos/wellcometrust/loris-docker/issues{/number}","pulls_url":"https://api.github.com/repos/wellcometrust/loris-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/wellcometrust/loris-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/wellcometrust/loris-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wellcometrust/loris-docker/labels{/name}","releases_url":"https://api.github.com/repos/wellcometrust/loris-docker/releases{/id}","deployments_url":"https://api.github.com/repos/wellcometrust/loris-docker/deployments","created_at":"2017-06-28T09:51:46Z","updated_at":"2017-06-28T09:54:47Z","pushed_at":"2017-06-28T10:02:13Z","git_url":"git://github.com/wellcometrust/loris-docker.git","ssh_url":"[email protected]:wellcometrust/loris-docker.git","clone_url":"https://github.com/wellcometrust/loris-docker.git","svn_url":"https://github.com/wellcometrust/loris-docker","homepage":"","size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wellcometrust/loris-docker/pulls/1"},"html":{"href":"https://github.com/wellcometrust/loris-docker/pull/1"},"issue":{"href":"https://api.github.com/repos/wellcometrust/loris-docker/issues/1"},"comments":{"href":"https://api.github.com/repos/wellcometrust/loris-docker/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/wellcometrust/loris-docker/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/wellcometrust/loris-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wellcometrust/loris-docker/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/wellcometrust/loris-docker/statuses/75722cf826e8e5a5b7ccfb3216c1bddc66f3dec5"}}}}
|
{
"id": 95654499,
"name": "wellcometrust/loris-docker",
"url": "https://api.github.com/repos/wellcometrust/loris-docker"
}
|
{
"id": 301220,
"login": "alexwlchan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/301220?",
"url": "https://api.github.com/users/alexwlchan"
}
|
{
"id": 2814213,
"login": "wellcometrust",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2814213?",
"url": "https://api.github.com/orgs/wellcometrust"
}
| 2017-06-28T10:04:18 |
6153507937
|
{"actor":{"display_login":"alexwlchan"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/pulls/comments/112986150","pull_request_review_id":34337473,"id":112986150,"diff_hunk":"@@ -8,49 +8,62 @@\n <artifactId>pavlo</artifactId>\n <version>1.0-SNAPSHOT</version>\n \n+ <properties>\n+ <cucumber.version>1.2.4</cucumber.version>\n+ <spring.version>4.3.7.RELEASE</spring.version>\n+ </properties>\n+\n <dependencies>\n <dependency>\n- <groupId>info.cukes</groupId>\n- <artifactId>cucumber-core</artifactId>\n- <version>1.2.4</version>\n+ <groupId>org.seleniumhq.selenium</groupId>\n+ <artifactId>selenium-java</artifactId>\n+ <version>2.53.1</version>\n <scope>test</scope>\n </dependency>\n <dependency>\n- <groupId>info.cukes</groupId>\n- <artifactId>cucumber-jvm-deps</artifactId>\n- <version>1.0.5</version>\n- <scope>test</scope>\n+ <groupId>junit</groupId>\n+ <artifactId>junit</artifactId>\n+ <version>4.12</version>","path":"pom.xml","position":26,"original_position":26,"commit_id":"bcd1c517f6527d5effc906d1515b941af2a6008d","original_commit_id":"bcd1c517f6527d5effc906d1515b941af2a6008d","user":{"login":"tramstheman","id":6572099,"avatar_url":"https://avatars2.githubusercontent.com/u/6572099?v=3","gravatar_id":"","url":"https://api.github.com/users/tramstheman","html_url":"https://github.com/tramstheman","followers_url":"https://api.github.com/users/tramstheman/followers","following_url":"https://api.github.com/users/tramstheman/following{/other_user}","gists_url":"https://api.github.com/users/tramstheman/gists{/gist_id}","starred_url":"https://api.github.com/users/tramstheman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tramstheman/subscriptions","organizations_url":"https://api.github.com/users/tramstheman/orgs","repos_url":"https://api.github.com/users/tramstheman/repos","events_url":"https://api.github.com/users/tramstheman/events{/privacy}","received_events_url":"https://api.github.com/users/tramstheman/received_events","type":"User","site_admin":false},"body":"store this version in a property ","created_at":"2017-04-24T15:57:52Z","updated_at":"2017-04-24T16:03:21Z","html_url":"https://github.com/BetaBreakersQE/cucumber-test/pull/1#discussion_r112986150","pull_request_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/pulls/comments/112986150"},"html":{"href":"https://github.com/BetaBreakersQE/cucumber-test/pull/1#discussion_r112986150"},"pull_request":{"href":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/pulls/1","id":117296180,"html_url":"https://github.com/BetaBreakersQE/cucumber-test/pull/1","diff_url":"https://github.com/BetaBreakersQE/cucumber-test/pull/1.diff","patch_url":"https://github.com/BetaBreakersQE/cucumber-test/pull/1.patch","issue_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/issues/1","number":1,"state":"open","locked":false,"title":"Pavlo","user":{"login":"PNikolenko","id":15851089,"avatar_url":"https://avatars3.githubusercontent.com/u/15851089?v=3","gravatar_id":"","url":"https://api.github.com/users/PNikolenko","html_url":"https://github.com/PNikolenko","followers_url":"https://api.github.com/users/PNikolenko/followers","following_url":"https://api.github.com/users/PNikolenko/following{/other_user}","gists_url":"https://api.github.com/users/PNikolenko/gists{/gist_id}","starred_url":"https://api.github.com/users/PNikolenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PNikolenko/subscriptions","organizations_url":"https://api.github.com/users/PNikolenko/orgs","repos_url":"https://api.github.com/users/PNikolenko/repos","events_url":"https://api.github.com/users/PNikolenko/events{/privacy}","received_events_url":"https://api.github.com/users/PNikolenko/received_events","type":"User","site_admin":false},"body":"* added dependency injection to handle WebDriver\r\n* added cucumber.version and spring.version properties to pom.xml\r\n* changed package name to separate step definitions and runner classes","created_at":"2017-04-24T15:42:49Z","updated_at":"2017-04-24T16:03:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"926f7e0d2db0306ee1c11aea73a2c9d8848519fa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/pulls/1/commits","review_comments_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/pulls/1/comments","review_comment_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/issues/1/comments","statuses_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/statuses/bcd1c517f6527d5effc906d1515b941af2a6008d","head":{"label":"BetaBreakersQE:pavlo","ref":"pavlo","sha":"bcd1c517f6527d5effc906d1515b941af2a6008d","user":{"login":"BetaBreakersQE","id":23661939,"avatar_url":"https://avatars2.githubusercontent.com/u/23661939?v=3","gravatar_id":"","url":"https://api.github.com/users/BetaBreakersQE","html_url":"https://github.com/BetaBreakersQE","followers_url":"https://api.github.com/users/BetaBreakersQE/followers","following_url":"https://api.github.com/users/BetaBreakersQE/following{/other_user}","gists_url":"https://api.github.com/users/BetaBreakersQE/gists{/gist_id}","starred_url":"https://api.github.com/users/BetaBreakersQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BetaBreakersQE/subscriptions","organizations_url":"https://api.github.com/users/BetaBreakersQE/orgs","repos_url":"https://api.github.com/users/BetaBreakersQE/repos","events_url":"https://api.github.com/users/BetaBreakersQE/events{/privacy}","received_events_url":"https://api.github.com/users/BetaBreakersQE/received_events","type":"Organization","site_admin":false},"repo":{"id":89030838,"name":"cucumber-test","full_name":"BetaBreakersQE/cucumber-test","owner":{"login":"BetaBreakersQE","id":23661939,"avatar_url":"https://avatars2.githubusercontent.com/u/23661939?v=3","gravatar_id":"","url":"https://api.github.com/users/BetaBreakersQE","html_url":"https://github.com/BetaBreakersQE","followers_url":"https://api.github.com/users/BetaBreakersQE/followers","following_url":"https://api.github.com/users/BetaBreakersQE/following{/other_user}","gists_url":"https://api.github.com/users/BetaBreakersQE/gists{/gist_id}","starred_url":"https://api.github.com/users/BetaBreakersQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BetaBreakersQE/subscriptions","organizations_url":"https://api.github.com/users/BetaBreakersQE/orgs","repos_url":"https://api.github.com/users/BetaBreakersQE/repos","events_url":"https://api.github.com/users/BetaBreakersQE/events{/privacy}","received_events_url":"https://api.github.com/users/BetaBreakersQE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BetaBreakersQE/cucumber-test","description":null,"fork":false,"url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test","forks_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/forks","keys_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/teams","hooks_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/hooks","issue_events_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/issues/events{/number}","events_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/events","assignees_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/assignees{/user}","branches_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/branches{/branch}","tags_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/tags","blobs_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/git/refs{/sha}","trees_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/statuses/{sha}","languages_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/languages","stargazers_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/stargazers","contributors_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/contributors","subscribers_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/subscribers","subscription_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/subscription","commits_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/commits{/sha}","git_commits_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/git/commits{/sha}","comments_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/comments{/number}","issue_comment_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/issues/comments{/number}","contents_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/contents/{+path}","compare_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/merges","archive_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/downloads","issues_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/issues{/number}","pulls_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/pulls{/number}","milestones_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/milestones{/number}","notifications_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/labels{/name}","releases_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/releases{/id}","deployments_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/deployments","created_at":"2017-04-21T23:19:50Z","updated_at":"2017-04-21T23:27:29Z","pushed_at":"2017-04-24T15:42:50Z","git_url":"git://github.com/BetaBreakersQE/cucumber-test.git","ssh_url":"[email protected]:BetaBreakersQE/cucumber-test.git","clone_url":"https://github.com/BetaBreakersQE/cucumber-test.git","svn_url":"https://github.com/BetaBreakersQE/cucumber-test","homepage":null,"size":12,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"BetaBreakersQE:master","ref":"master","sha":"27ab9bf2a3fb4a3c74b6f82f0b37c66b53794e90","user":{"login":"BetaBreakersQE","id":23661939,"avatar_url":"https://avatars2.githubusercontent.com/u/23661939?v=3","gravatar_id":"","url":"https://api.github.com/users/BetaBreakersQE","html_url":"https://github.com/BetaBreakersQE","followers_url":"https://api.github.com/users/BetaBreakersQE/followers","following_url":"https://api.github.com/users/BetaBreakersQE/following{/other_user}","gists_url":"https://api.github.com/users/BetaBreakersQE/gists{/gist_id}","starred_url":"https://api.github.com/users/BetaBreakersQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BetaBreakersQE/subscriptions","organizations_url":"https://api.github.com/users/BetaBreakersQE/orgs","repos_url":"https://api.github.com/users/BetaBreakersQE/repos","events_url":"https://api.github.com/users/BetaBreakersQE/events{/privacy}","received_events_url":"https://api.github.com/users/BetaBreakersQE/received_events","type":"Organization","site_admin":false},"repo":{"id":89030838,"name":"cucumber-test","full_name":"BetaBreakersQE/cucumber-test","owner":{"login":"BetaBreakersQE","id":23661939,"avatar_url":"https://avatars2.githubusercontent.com/u/23661939?v=3","gravatar_id":"","url":"https://api.github.com/users/BetaBreakersQE","html_url":"https://github.com/BetaBreakersQE","followers_url":"https://api.github.com/users/BetaBreakersQE/followers","following_url":"https://api.github.com/users/BetaBreakersQE/following{/other_user}","gists_url":"https://api.github.com/users/BetaBreakersQE/gists{/gist_id}","starred_url":"https://api.github.com/users/BetaBreakersQE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BetaBreakersQE/subscriptions","organizations_url":"https://api.github.com/users/BetaBreakersQE/orgs","repos_url":"https://api.github.com/users/BetaBreakersQE/repos","events_url":"https://api.github.com/users/BetaBreakersQE/events{/privacy}","received_events_url":"https://api.github.com/users/BetaBreakersQE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BetaBreakersQE/cucumber-test","description":null,"fork":false,"url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test","forks_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/forks","keys_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/teams","hooks_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/hooks","issue_events_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/issues/events{/number}","events_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/events","assignees_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/assignees{/user}","branches_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/branches{/branch}","tags_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/tags","blobs_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/git/refs{/sha}","trees_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/statuses/{sha}","languages_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/languages","stargazers_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/stargazers","contributors_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/contributors","subscribers_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/subscribers","subscription_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/subscription","commits_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/commits{/sha}","git_commits_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/git/commits{/sha}","comments_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/comments{/number}","issue_comment_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/issues/comments{/number}","contents_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/contents/{+path}","compare_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/merges","archive_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/downloads","issues_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/issues{/number}","pulls_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/pulls{/number}","milestones_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/milestones{/number}","notifications_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/labels{/name}","releases_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/releases{/id}","deployments_url":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/deployments","created_at":"2017-04-21T23:19:50Z","updated_at":"2017-04-21T23:27:29Z","pushed_at":"2017-04-24T15:42:50Z","git_url":"git://github.com/BetaBreakersQE/cucumber-test.git","ssh_url":"[email protected]:BetaBreakersQE/cucumber-test.git","clone_url":"https://github.com/BetaBreakersQE/cucumber-test.git","svn_url":"https://github.com/BetaBreakersQE/cucumber-test","homepage":null,"size":12,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/pulls/1"},"html":{"href":"https://github.com/BetaBreakersQE/cucumber-test/pull/1"},"issue":{"href":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/issues/1"},"comments":{"href":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/BetaBreakersQE/cucumber-test/statuses/bcd1c517f6527d5effc906d1515b941af2a6008d"}}}}
|
{
"id": 89030838,
"name": "BetaBreakersQE/cucumber-test",
"url": "https://api.github.com/repos/BetaBreakersQE/cucumber-test"
}
|
{
"id": 6572099,
"login": "tramstheman",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6572099?",
"url": "https://api.github.com/users/tramstheman"
}
|
{
"id": 23661939,
"login": "BetaBreakersQE",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23661939?",
"url": "https://api.github.com/orgs/BetaBreakersQE"
}
| 2017-04-24T15:57:52 |
5745248113
|
{"actor":{"display_login":"tramstheman"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/pulls/comments/103118485","pull_request_review_id":23895038,"id":103118485,"diff_hunk":"@@ -169,4 +177,15 @@ public void moveNode(MapNode n, Point2D movedTo)\n edge.updateCost();\n }\n }\n+\n+ public void setCurrentKiosk (Kiosk kiosk) {\n+ if (Hospital.kiosks.contains(kiosk)) {\n+ Hospital.currentKiosk = kiosk;\n+ } else {","path":"src/Boundary/AdminMapBoundary.java","position":39,"original_position":39,"commit_id":"b198020c8838b955cec5abc65c895404184132fa","original_commit_id":"b198020c8838b955cec5abc65c895404184132fa","user":{"login":"bhylak","id":19956321,"avatar_url":"https://avatars.githubusercontent.com/u/19956321?v=3","gravatar_id":"","url":"https://api.github.com/users/bhylak","html_url":"https://github.com/bhylak","followers_url":"https://api.github.com/users/bhylak/followers","following_url":"https://api.github.com/users/bhylak/following{/other_user}","gists_url":"https://api.github.com/users/bhylak/gists{/gist_id}","starred_url":"https://api.github.com/users/bhylak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhylak/subscriptions","organizations_url":"https://api.github.com/users/bhylak/orgs","repos_url":"https://api.github.com/users/bhylak/repos","events_url":"https://api.github.com/users/bhylak/events{/privacy}","received_events_url":"https://api.github.com/users/bhylak/received_events","type":"User","site_admin":false},"body":"Is it possible to make kiosks protected and instead have a \"getKiosks()\" function or \"containsKiosk\" function ","created_at":"2017-02-26T22:08:01Z","updated_at":"2017-02-26T22:10:33Z","html_url":"https://github.com/CS3733TeamBeta/Faulkner.Kiosk/pull/79#discussion_r103118485","pull_request_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/pulls/79","_links":{"self":{"href":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/pulls/comments/103118485"},"html":{"href":"https://github.com/CS3733TeamBeta/Faulkner.Kiosk/pull/79#discussion_r103118485"},"pull_request":{"href":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/pulls/79"}}},"pull_request":{"url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/pulls/79","id":108022875,"html_url":"https://github.com/CS3733TeamBeta/Faulkner.Kiosk/pull/79","diff_url":"https://github.com/CS3733TeamBeta/Faulkner.Kiosk/pull/79.diff","patch_url":"https://github.com/CS3733TeamBeta/Faulkner.Kiosk/pull/79.patch","issue_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/issues/79","number":79,"state":"open","locked":false,"title":"feature/new_kiosk_nodes_33","user":{"login":"sjpridotkas","id":25159632,"avatar_url":"https://avatars.githubusercontent.com/u/25159632?v=3","gravatar_id":"","url":"https://api.github.com/users/sjpridotkas","html_url":"https://github.com/sjpridotkas","followers_url":"https://api.github.com/users/sjpridotkas/followers","following_url":"https://api.github.com/users/sjpridotkas/following{/other_user}","gists_url":"https://api.github.com/users/sjpridotkas/gists{/gist_id}","starred_url":"https://api.github.com/users/sjpridotkas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjpridotkas/subscriptions","organizations_url":"https://api.github.com/users/sjpridotkas/orgs","repos_url":"https://api.github.com/users/sjpridotkas/repos","events_url":"https://api.github.com/users/sjpridotkas/events{/privacy}","received_events_url":"https://api.github.com/users/sjpridotkas/received_events","type":"User","site_admin":false},"body":"Adding kiosk class and fuctionality","created_at":"2017-02-26T21:27:50Z","updated_at":"2017-02-26T22:10:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0f8734a4bfca9fdb26236bda235cd2a4dd311c1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/pulls/79/commits","review_comments_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/pulls/79/comments","review_comment_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/issues/79/comments","statuses_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/statuses/b198020c8838b955cec5abc65c895404184132fa","head":{"label":"CS3733TeamBeta:new_kiosk_nodes_33","ref":"new_kiosk_nodes_33","sha":"b198020c8838b955cec5abc65c895404184132fa","user":{"login":"CS3733TeamBeta","id":25153701,"avatar_url":"https://avatars.githubusercontent.com/u/25153701?v=3","gravatar_id":"","url":"https://api.github.com/users/CS3733TeamBeta","html_url":"https://github.com/CS3733TeamBeta","followers_url":"https://api.github.com/users/CS3733TeamBeta/followers","following_url":"https://api.github.com/users/CS3733TeamBeta/following{/other_user}","gists_url":"https://api.github.com/users/CS3733TeamBeta/gists{/gist_id}","starred_url":"https://api.github.com/users/CS3733TeamBeta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CS3733TeamBeta/subscriptions","organizations_url":"https://api.github.com/users/CS3733TeamBeta/orgs","repos_url":"https://api.github.com/users/CS3733TeamBeta/repos","events_url":"https://api.github.com/users/CS3733TeamBeta/events{/privacy}","received_events_url":"https://api.github.com/users/CS3733TeamBeta/received_events","type":"Organization","site_admin":false},"repo":{"id":79485973,"name":"Faulkner.Kiosk","full_name":"CS3733TeamBeta/Faulkner.Kiosk","owner":{"login":"CS3733TeamBeta","id":25153701,"avatar_url":"https://avatars.githubusercontent.com/u/25153701?v=3","gravatar_id":"","url":"https://api.github.com/users/CS3733TeamBeta","html_url":"https://github.com/CS3733TeamBeta","followers_url":"https://api.github.com/users/CS3733TeamBeta/followers","following_url":"https://api.github.com/users/CS3733TeamBeta/following{/other_user}","gists_url":"https://api.github.com/users/CS3733TeamBeta/gists{/gist_id}","starred_url":"https://api.github.com/users/CS3733TeamBeta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CS3733TeamBeta/subscriptions","organizations_url":"https://api.github.com/users/CS3733TeamBeta/orgs","repos_url":"https://api.github.com/users/CS3733TeamBeta/repos","events_url":"https://api.github.com/users/CS3733TeamBeta/events{/privacy}","received_events_url":"https://api.github.com/users/CS3733TeamBeta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CS3733TeamBeta/Faulkner.Kiosk","description":null,"fork":false,"url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk","forks_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/forks","keys_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/teams","hooks_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/hooks","issue_events_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/issues/events{/number}","events_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/events","assignees_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/assignees{/user}","branches_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/branches{/branch}","tags_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/tags","blobs_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/git/refs{/sha}","trees_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/statuses/{sha}","languages_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/languages","stargazers_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/stargazers","contributors_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/contributors","subscribers_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/subscribers","subscription_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/subscription","commits_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/commits{/sha}","git_commits_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/git/commits{/sha}","comments_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/comments{/number}","issue_comment_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/issues/comments{/number}","contents_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/contents/{+path}","compare_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/merges","archive_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/downloads","issues_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/issues{/number}","pulls_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/pulls{/number}","milestones_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/milestones{/number}","notifications_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/labels{/name}","releases_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/releases{/id}","deployments_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/deployments","created_at":"2017-01-19T19:15:45Z","updated_at":"2017-02-05T18:28:20Z","pushed_at":"2017-02-26T22:06:37Z","git_url":"git://github.com/CS3733TeamBeta/Faulkner.Kiosk.git","ssh_url":"[email protected]:CS3733TeamBeta/Faulkner.Kiosk.git","clone_url":"https://github.com/CS3733TeamBeta/Faulkner.Kiosk.git","svn_url":"https://github.com/CS3733TeamBeta/Faulkner.Kiosk","homepage":null,"size":47261,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":0,"default_branch":"master"}},"base":{"label":"CS3733TeamBeta:develop","ref":"develop","sha":"d4aa64ab8a45ddfd79b11cf0b82258e945b7eede","user":{"login":"CS3733TeamBeta","id":25153701,"avatar_url":"https://avatars.githubusercontent.com/u/25153701?v=3","gravatar_id":"","url":"https://api.github.com/users/CS3733TeamBeta","html_url":"https://github.com/CS3733TeamBeta","followers_url":"https://api.github.com/users/CS3733TeamBeta/followers","following_url":"https://api.github.com/users/CS3733TeamBeta/following{/other_user}","gists_url":"https://api.github.com/users/CS3733TeamBeta/gists{/gist_id}","starred_url":"https://api.github.com/users/CS3733TeamBeta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CS3733TeamBeta/subscriptions","organizations_url":"https://api.github.com/users/CS3733TeamBeta/orgs","repos_url":"https://api.github.com/users/CS3733TeamBeta/repos","events_url":"https://api.github.com/users/CS3733TeamBeta/events{/privacy}","received_events_url":"https://api.github.com/users/CS3733TeamBeta/received_events","type":"Organization","site_admin":false},"repo":{"id":79485973,"name":"Faulkner.Kiosk","full_name":"CS3733TeamBeta/Faulkner.Kiosk","owner":{"login":"CS3733TeamBeta","id":25153701,"avatar_url":"https://avatars.githubusercontent.com/u/25153701?v=3","gravatar_id":"","url":"https://api.github.com/users/CS3733TeamBeta","html_url":"https://github.com/CS3733TeamBeta","followers_url":"https://api.github.com/users/CS3733TeamBeta/followers","following_url":"https://api.github.com/users/CS3733TeamBeta/following{/other_user}","gists_url":"https://api.github.com/users/CS3733TeamBeta/gists{/gist_id}","starred_url":"https://api.github.com/users/CS3733TeamBeta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CS3733TeamBeta/subscriptions","organizations_url":"https://api.github.com/users/CS3733TeamBeta/orgs","repos_url":"https://api.github.com/users/CS3733TeamBeta/repos","events_url":"https://api.github.com/users/CS3733TeamBeta/events{/privacy}","received_events_url":"https://api.github.com/users/CS3733TeamBeta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CS3733TeamBeta/Faulkner.Kiosk","description":null,"fork":false,"url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk","forks_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/forks","keys_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/teams","hooks_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/hooks","issue_events_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/issues/events{/number}","events_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/events","assignees_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/assignees{/user}","branches_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/branches{/branch}","tags_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/tags","blobs_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/git/refs{/sha}","trees_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/statuses/{sha}","languages_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/languages","stargazers_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/stargazers","contributors_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/contributors","subscribers_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/subscribers","subscription_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/subscription","commits_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/commits{/sha}","git_commits_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/git/commits{/sha}","comments_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/comments{/number}","issue_comment_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/issues/comments{/number}","contents_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/contents/{+path}","compare_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/merges","archive_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/downloads","issues_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/issues{/number}","pulls_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/pulls{/number}","milestones_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/milestones{/number}","notifications_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/labels{/name}","releases_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/releases{/id}","deployments_url":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/deployments","created_at":"2017-01-19T19:15:45Z","updated_at":"2017-02-05T18:28:20Z","pushed_at":"2017-02-26T22:06:37Z","git_url":"git://github.com/CS3733TeamBeta/Faulkner.Kiosk.git","ssh_url":"[email protected]:CS3733TeamBeta/Faulkner.Kiosk.git","clone_url":"https://github.com/CS3733TeamBeta/Faulkner.Kiosk.git","svn_url":"https://github.com/CS3733TeamBeta/Faulkner.Kiosk","homepage":null,"size":47261,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/pulls/79"},"html":{"href":"https://github.com/CS3733TeamBeta/Faulkner.Kiosk/pull/79"},"issue":{"href":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/issues/79"},"comments":{"href":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk/statuses/b198020c8838b955cec5abc65c895404184132fa"}}}}
|
{
"id": 79485973,
"name": "CS3733TeamBeta/Faulkner.Kiosk",
"url": "https://api.github.com/repos/CS3733TeamBeta/Faulkner.Kiosk"
}
|
{
"id": 19956321,
"login": "bhylak",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19956321?",
"url": "https://api.github.com/users/bhylak"
}
|
{
"id": 25153701,
"login": "CS3733TeamBeta",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25153701?",
"url": "https://api.github.com/orgs/CS3733TeamBeta"
}
| 2017-02-26T22:08:01 |
5393731001
|
{"actor":{"display_login":"bhylak"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/pulls/comments/102352076","pull_request_review_id":23105749,"id":102352076,"diff_hunk":"@@ -0,0 +1,28 @@\n+import socket\n+import time\n+import argparse\n+\"\"\" Check if port is open, avoid docker-compose race condition \"\"\"","path":"docker/web/check_db.py","position":4,"original_position":4,"commit_id":"b23013314d91a5a559d12d03cdd4c5a14510af1a","original_commit_id":"b23013314d91a5a559d12d03cdd4c5a14510af1a","user":{"login":"smaniotto","id":6256337,"avatar_url":"https://avatars.githubusercontent.com/u/6256337?v=3","gravatar_id":"","url":"https://api.github.com/users/smaniotto","html_url":"https://github.com/smaniotto","followers_url":"https://api.github.com/users/smaniotto/followers","following_url":"https://api.github.com/users/smaniotto/following{/other_user}","gists_url":"https://api.github.com/users/smaniotto/gists{/gist_id}","starred_url":"https://api.github.com/users/smaniotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smaniotto/subscriptions","organizations_url":"https://api.github.com/users/smaniotto/orgs","repos_url":"https://api.github.com/users/smaniotto/repos","events_url":"https://api.github.com/users/smaniotto/events{/privacy}","received_events_url":"https://api.github.com/users/smaniotto/received_events","type":"User","site_admin":false},"body":"Module docstring should come first than imports, no?","created_at":"2017-02-22T00:03:47Z","updated_at":"2017-02-22T00:08:29Z","html_url":"https://github.com/CheesecakeLabs/django-drf-boilerplate/pull/14#discussion_r102352076","pull_request_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/pulls/comments/102352076"},"html":{"href":"https://github.com/CheesecakeLabs/django-drf-boilerplate/pull/14#discussion_r102352076"},"pull_request":{"href":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/pulls/14","id":107306443,"html_url":"https://github.com/CheesecakeLabs/django-drf-boilerplate/pull/14","diff_url":"https://github.com/CheesecakeLabs/django-drf-boilerplate/pull/14.diff","patch_url":"https://github.com/CheesecakeLabs/django-drf-boilerplate/pull/14.patch","issue_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/issues/14","number":14,"state":"open","locked":false,"title":"Implement PostgreSQL","user":{"login":"jonatasbaldin","id":8570364,"avatar_url":"https://avatars.githubusercontent.com/u/8570364?v=3","gravatar_id":"","url":"https://api.github.com/users/jonatasbaldin","html_url":"https://github.com/jonatasbaldin","followers_url":"https://api.github.com/users/jonatasbaldin/followers","following_url":"https://api.github.com/users/jonatasbaldin/following{/other_user}","gists_url":"https://api.github.com/users/jonatasbaldin/gists{/gist_id}","starred_url":"https://api.github.com/users/jonatasbaldin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonatasbaldin/subscriptions","organizations_url":"https://api.github.com/users/jonatasbaldin/orgs","repos_url":"https://api.github.com/users/jonatasbaldin/repos","events_url":"https://api.github.com/users/jonatasbaldin/events{/privacy}","received_events_url":"https://api.github.com/users/jonatasbaldin/received_events","type":"User","site_admin":false},"body":"Implement PostgreSQL in Docker Compose using dj-database-url packge.\r\n\r\nRelated to #4.\r\n\r\n@CheesecakeLabs/backend ","created_at":"2017-02-21T23:58:08Z","updated_at":"2017-02-22T00:08:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ab5511716394d9aa7606abaed96e13afac4cce4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/pulls/14/commits","review_comments_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/pulls/14/comments","review_comment_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/issues/14/comments","statuses_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/statuses/b23013314d91a5a559d12d03cdd4c5a14510af1a","head":{"label":"CheesecakeLabs:dleitee-jojo/postgres","ref":"dleitee-jojo/postgres","sha":"b23013314d91a5a559d12d03cdd4c5a14510af1a","user":{"login":"CheesecakeLabs","id":7116469,"avatar_url":"https://avatars.githubusercontent.com/u/7116469?v=3","gravatar_id":"","url":"https://api.github.com/users/CheesecakeLabs","html_url":"https://github.com/CheesecakeLabs","followers_url":"https://api.github.com/users/CheesecakeLabs/followers","following_url":"https://api.github.com/users/CheesecakeLabs/following{/other_user}","gists_url":"https://api.github.com/users/CheesecakeLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/CheesecakeLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CheesecakeLabs/subscriptions","organizations_url":"https://api.github.com/users/CheesecakeLabs/orgs","repos_url":"https://api.github.com/users/CheesecakeLabs/repos","events_url":"https://api.github.com/users/CheesecakeLabs/events{/privacy}","received_events_url":"https://api.github.com/users/CheesecakeLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":71914462,"name":"django-drf-boilerplate","full_name":"CheesecakeLabs/django-drf-boilerplate","owner":{"login":"CheesecakeLabs","id":7116469,"avatar_url":"https://avatars.githubusercontent.com/u/7116469?v=3","gravatar_id":"","url":"https://api.github.com/users/CheesecakeLabs","html_url":"https://github.com/CheesecakeLabs","followers_url":"https://api.github.com/users/CheesecakeLabs/followers","following_url":"https://api.github.com/users/CheesecakeLabs/following{/other_user}","gists_url":"https://api.github.com/users/CheesecakeLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/CheesecakeLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CheesecakeLabs/subscriptions","organizations_url":"https://api.github.com/users/CheesecakeLabs/orgs","repos_url":"https://api.github.com/users/CheesecakeLabs/repos","events_url":"https://api.github.com/users/CheesecakeLabs/events{/privacy}","received_events_url":"https://api.github.com/users/CheesecakeLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CheesecakeLabs/django-drf-boilerplate","description":"Django starter kit for CKL projects","fork":false,"url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate","forks_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/forks","keys_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/teams","hooks_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/hooks","issue_events_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/issues/events{/number}","events_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/events","assignees_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/assignees{/user}","branches_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/branches{/branch}","tags_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/tags","blobs_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/git/refs{/sha}","trees_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/statuses/{sha}","languages_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/languages","stargazers_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/stargazers","contributors_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/contributors","subscribers_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/subscribers","subscription_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/subscription","commits_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/commits{/sha}","git_commits_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/git/commits{/sha}","comments_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/comments{/number}","issue_comment_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/issues/comments{/number}","contents_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/contents/{+path}","compare_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/merges","archive_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/downloads","issues_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/issues{/number}","pulls_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/pulls{/number}","milestones_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/milestones{/number}","notifications_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/labels{/name}","releases_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/releases{/id}","deployments_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/deployments","created_at":"2016-10-25T16:01:48Z","updated_at":"2017-02-14T13:00:55Z","pushed_at":"2017-02-21T23:58:08Z","git_url":"git://github.com/CheesecakeLabs/django-drf-boilerplate.git","ssh_url":"[email protected]:CheesecakeLabs/django-drf-boilerplate.git","clone_url":"https://github.com/CheesecakeLabs/django-drf-boilerplate.git","svn_url":"https://github.com/CheesecakeLabs/django-drf-boilerplate","homepage":null,"size":16,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":3,"default_branch":"master"}},"base":{"label":"CheesecakeLabs:dleitee-jojo/dockercompose","ref":"dleitee-jojo/dockercompose","sha":"079bc419775e456f843b7b5a11e962b640b1c307","user":{"login":"CheesecakeLabs","id":7116469,"avatar_url":"https://avatars.githubusercontent.com/u/7116469?v=3","gravatar_id":"","url":"https://api.github.com/users/CheesecakeLabs","html_url":"https://github.com/CheesecakeLabs","followers_url":"https://api.github.com/users/CheesecakeLabs/followers","following_url":"https://api.github.com/users/CheesecakeLabs/following{/other_user}","gists_url":"https://api.github.com/users/CheesecakeLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/CheesecakeLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CheesecakeLabs/subscriptions","organizations_url":"https://api.github.com/users/CheesecakeLabs/orgs","repos_url":"https://api.github.com/users/CheesecakeLabs/repos","events_url":"https://api.github.com/users/CheesecakeLabs/events{/privacy}","received_events_url":"https://api.github.com/users/CheesecakeLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":71914462,"name":"django-drf-boilerplate","full_name":"CheesecakeLabs/django-drf-boilerplate","owner":{"login":"CheesecakeLabs","id":7116469,"avatar_url":"https://avatars.githubusercontent.com/u/7116469?v=3","gravatar_id":"","url":"https://api.github.com/users/CheesecakeLabs","html_url":"https://github.com/CheesecakeLabs","followers_url":"https://api.github.com/users/CheesecakeLabs/followers","following_url":"https://api.github.com/users/CheesecakeLabs/following{/other_user}","gists_url":"https://api.github.com/users/CheesecakeLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/CheesecakeLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CheesecakeLabs/subscriptions","organizations_url":"https://api.github.com/users/CheesecakeLabs/orgs","repos_url":"https://api.github.com/users/CheesecakeLabs/repos","events_url":"https://api.github.com/users/CheesecakeLabs/events{/privacy}","received_events_url":"https://api.github.com/users/CheesecakeLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CheesecakeLabs/django-drf-boilerplate","description":"Django starter kit for CKL projects","fork":false,"url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate","forks_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/forks","keys_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/teams","hooks_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/hooks","issue_events_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/issues/events{/number}","events_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/events","assignees_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/assignees{/user}","branches_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/branches{/branch}","tags_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/tags","blobs_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/git/refs{/sha}","trees_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/statuses/{sha}","languages_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/languages","stargazers_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/stargazers","contributors_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/contributors","subscribers_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/subscribers","subscription_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/subscription","commits_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/commits{/sha}","git_commits_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/git/commits{/sha}","comments_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/comments{/number}","issue_comment_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/issues/comments{/number}","contents_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/contents/{+path}","compare_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/merges","archive_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/downloads","issues_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/issues{/number}","pulls_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/pulls{/number}","milestones_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/milestones{/number}","notifications_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/labels{/name}","releases_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/releases{/id}","deployments_url":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/deployments","created_at":"2016-10-25T16:01:48Z","updated_at":"2017-02-14T13:00:55Z","pushed_at":"2017-02-21T23:58:08Z","git_url":"git://github.com/CheesecakeLabs/django-drf-boilerplate.git","ssh_url":"[email protected]:CheesecakeLabs/django-drf-boilerplate.git","clone_url":"https://github.com/CheesecakeLabs/django-drf-boilerplate.git","svn_url":"https://github.com/CheesecakeLabs/django-drf-boilerplate","homepage":null,"size":16,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":12,"forks":0,"open_issues":12,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/pulls/14"},"html":{"href":"https://github.com/CheesecakeLabs/django-drf-boilerplate/pull/14"},"issue":{"href":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/issues/14"},"comments":{"href":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate/statuses/b23013314d91a5a559d12d03cdd4c5a14510af1a"}}}}
|
{
"id": 71914462,
"name": "CheesecakeLabs/django-drf-boilerplate",
"url": "https://api.github.com/repos/CheesecakeLabs/django-drf-boilerplate"
}
|
{
"id": 6256337,
"login": "smaniotto",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6256337?",
"url": "https://api.github.com/users/smaniotto"
}
|
{
"id": 7116469,
"login": "CheesecakeLabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7116469?",
"url": "https://api.github.com/orgs/CheesecakeLabs"
}
| 2017-02-22T00:03:47 |
5366468748
|
{"actor":{"display_login":"smaniotto"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/comments/158105979","pull_request_review_id":84862051,"id":158105979,"diff_hunk":"@@ -118,15 +142,101 @@ public Task<IEnumerable<Role>> GetRoles(string grain, string securableItem = nul\n \n if (!string.IsNullOrWhiteSpace(securableItem))\n {\n- roles = roles.Where(p => string.Equals(p.SecurableItem.Name, securableItem));\n+ roles = roles.Where(r => string.Equals(r.SecurableItem.Name, securableItem));\n }\n \n if (!string.IsNullOrWhiteSpace(roleName))\n {\n- roles = roles.Where(p => string.Equals(p.Name, roleName));\n+ roles = roles.Where(r => string.Equals(r.Name, roleName));\n+ }\n+\n+ return roles;\n+ }\n+\n+ public async Task<Role> AddPermissionsToRole(Role role, ICollection<Permission> permissions)\n+ {\n+ var roleEntity = await _authorizationDbContext.Roles\n+ .SingleOrDefaultAsync(r =>\n+ r.RoleId == role.Id\n+ && !r.IsDeleted);\n+\n+ if (role == null)\n+ {\n+ throw new NotFoundException<Role>($\"Could not find {typeof(Role).Name} entity with ID {role.Id}\");\n+ }\n+\n+ var permissionIds = permissions.Select(p => p.Id);\n+ var permissionDictionary = _authorizationDbContext.Permissions","path":"Fabric.Authorization.Persistence.SqlServer/Stores/SqlServerRoleStore.cs","position":113,"original_position":113,"commit_id":"2352cd55ccf3c9a6b808f65f883c50caf6d40424","original_commit_id":"2352cd55ccf3c9a6b808f65f883c50caf6d40424","user":{"login":"bsmithvt","id":6453904,"avatar_url":"https://avatars1.githubusercontent.com/u/6453904?v=4","gravatar_id":"","url":"https://api.github.com/users/bsmithvt","html_url":"https://github.com/bsmithvt","followers_url":"https://api.github.com/users/bsmithvt/followers","following_url":"https://api.github.com/users/bsmithvt/following{/other_user}","gists_url":"https://api.github.com/users/bsmithvt/gists{/gist_id}","starred_url":"https://api.github.com/users/bsmithvt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsmithvt/subscriptions","organizations_url":"https://api.github.com/users/bsmithvt/orgs","repos_url":"https://api.github.com/users/bsmithvt/repos","events_url":"https://api.github.com/users/bsmithvt/events{/privacy}","received_events_url":"https://api.github.com/users/bsmithvt/received_events","type":"User","site_admin":false},"body":"We have the PermissionIds, which is a set of Guids. I need to get the Sql Server `int` ID to create the relationship.","created_at":"2017-12-20T18:52:55Z","updated_at":"2017-12-20T18:52:55Z","html_url":"https://github.com/HealthCatalyst/Fabric.Authorization/pull/108#discussion_r158105979","pull_request_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/108","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/comments/158105979"},"html":{"href":"https://github.com/HealthCatalyst/Fabric.Authorization/pull/108#discussion_r158105979"},"pull_request":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/108"}},"in_reply_to_id":158103809},"pull_request":{"url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/108","id":159481942,"html_url":"https://github.com/HealthCatalyst/Fabric.Authorization/pull/108","diff_url":"https://github.com/HealthCatalyst/Fabric.Authorization/pull/108.diff","patch_url":"https://github.com/HealthCatalyst/Fabric.Authorization/pull/108.patch","issue_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/issues/108","number":108,"state":"open","locked":false,"title":"User/bsmithvt/refactor role service","user":{"login":"bsmithvt","id":6453904,"avatar_url":"https://avatars1.githubusercontent.com/u/6453904?v=4","gravatar_id":"","url":"https://api.github.com/users/bsmithvt","html_url":"https://github.com/bsmithvt","followers_url":"https://api.github.com/users/bsmithvt/followers","following_url":"https://api.github.com/users/bsmithvt/following{/other_user}","gists_url":"https://api.github.com/users/bsmithvt/gists{/gist_id}","starred_url":"https://api.github.com/users/bsmithvt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsmithvt/subscriptions","organizations_url":"https://api.github.com/users/bsmithvt/orgs","repos_url":"https://api.github.com/users/bsmithvt/repos","events_url":"https://api.github.com/users/bsmithvt/events{/privacy}","received_events_url":"https://api.github.com/users/bsmithvt/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-20T18:01:21Z","updated_at":"2017-12-20T18:52:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c16df223fd725f63d53e359f5c2d11134f12de11","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/108/commits","review_comments_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/108/comments","review_comment_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/issues/108/comments","statuses_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/statuses/2352cd55ccf3c9a6b808f65f883c50caf6d40424","head":{"label":"HealthCatalyst:user/bsmithvt/refactor-role-service","ref":"user/bsmithvt/refactor-role-service","sha":"2352cd55ccf3c9a6b808f65f883c50caf6d40424","user":{"login":"HealthCatalyst","id":27259917,"avatar_url":"https://avatars3.githubusercontent.com/u/27259917?v=4","gravatar_id":"","url":"https://api.github.com/users/HealthCatalyst","html_url":"https://github.com/HealthCatalyst","followers_url":"https://api.github.com/users/HealthCatalyst/followers","following_url":"https://api.github.com/users/HealthCatalyst/following{/other_user}","gists_url":"https://api.github.com/users/HealthCatalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/HealthCatalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HealthCatalyst/subscriptions","organizations_url":"https://api.github.com/users/HealthCatalyst/orgs","repos_url":"https://api.github.com/users/HealthCatalyst/repos","events_url":"https://api.github.com/users/HealthCatalyst/events{/privacy}","received_events_url":"https://api.github.com/users/HealthCatalyst/received_events","type":"Organization","site_admin":false},"repo":{"id":90079030,"name":"Fabric.Authorization","full_name":"HealthCatalyst/Fabric.Authorization","owner":{"login":"HealthCatalyst","id":27259917,"avatar_url":"https://avatars3.githubusercontent.com/u/27259917?v=4","gravatar_id":"","url":"https://api.github.com/users/HealthCatalyst","html_url":"https://github.com/HealthCatalyst","followers_url":"https://api.github.com/users/HealthCatalyst/followers","following_url":"https://api.github.com/users/HealthCatalyst/following{/other_user}","gists_url":"https://api.github.com/users/HealthCatalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/HealthCatalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HealthCatalyst/subscriptions","organizations_url":"https://api.github.com/users/HealthCatalyst/orgs","repos_url":"https://api.github.com/users/HealthCatalyst/repos","events_url":"https://api.github.com/users/HealthCatalyst/events{/privacy}","received_events_url":"https://api.github.com/users/HealthCatalyst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HealthCatalyst/Fabric.Authorization","description":"Permissions service for applications","fork":false,"url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization","forks_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/forks","keys_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/teams","hooks_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/hooks","issue_events_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/issues/events{/number}","events_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/events","assignees_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/assignees{/user}","branches_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/branches{/branch}","tags_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/tags","blobs_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/git/refs{/sha}","trees_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/statuses/{sha}","languages_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/languages","stargazers_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/stargazers","contributors_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/contributors","subscribers_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/subscribers","subscription_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/subscription","commits_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/commits{/sha}","git_commits_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/git/commits{/sha}","comments_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/comments{/number}","issue_comment_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/issues/comments{/number}","contents_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/contents/{+path}","compare_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/merges","archive_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/downloads","issues_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/issues{/number}","pulls_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls{/number}","milestones_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/milestones{/number}","notifications_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/labels{/name}","releases_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/releases{/id}","deployments_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/deployments","created_at":"2017-05-02T21:20:07Z","updated_at":"2017-10-16T23:37:14Z","pushed_at":"2017-12-20T18:31:49Z","git_url":"git://github.com/HealthCatalyst/Fabric.Authorization.git","ssh_url":"[email protected]:HealthCatalyst/Fabric.Authorization.git","clone_url":"https://github.com/HealthCatalyst/Fabric.Authorization.git","svn_url":"https://github.com/HealthCatalyst/Fabric.Authorization","homepage":"","size":2431,"stargazers_count":5,"watchers_count":5,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":5,"watchers":5,"default_branch":"master"}},"base":{"label":"HealthCatalyst:master","ref":"master","sha":"c1b1eb617aa9ebceb0bd82db82f2b199c0cf046d","user":{"login":"HealthCatalyst","id":27259917,"avatar_url":"https://avatars3.githubusercontent.com/u/27259917?v=4","gravatar_id":"","url":"https://api.github.com/users/HealthCatalyst","html_url":"https://github.com/HealthCatalyst","followers_url":"https://api.github.com/users/HealthCatalyst/followers","following_url":"https://api.github.com/users/HealthCatalyst/following{/other_user}","gists_url":"https://api.github.com/users/HealthCatalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/HealthCatalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HealthCatalyst/subscriptions","organizations_url":"https://api.github.com/users/HealthCatalyst/orgs","repos_url":"https://api.github.com/users/HealthCatalyst/repos","events_url":"https://api.github.com/users/HealthCatalyst/events{/privacy}","received_events_url":"https://api.github.com/users/HealthCatalyst/received_events","type":"Organization","site_admin":false},"repo":{"id":90079030,"name":"Fabric.Authorization","full_name":"HealthCatalyst/Fabric.Authorization","owner":{"login":"HealthCatalyst","id":27259917,"avatar_url":"https://avatars3.githubusercontent.com/u/27259917?v=4","gravatar_id":"","url":"https://api.github.com/users/HealthCatalyst","html_url":"https://github.com/HealthCatalyst","followers_url":"https://api.github.com/users/HealthCatalyst/followers","following_url":"https://api.github.com/users/HealthCatalyst/following{/other_user}","gists_url":"https://api.github.com/users/HealthCatalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/HealthCatalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HealthCatalyst/subscriptions","organizations_url":"https://api.github.com/users/HealthCatalyst/orgs","repos_url":"https://api.github.com/users/HealthCatalyst/repos","events_url":"https://api.github.com/users/HealthCatalyst/events{/privacy}","received_events_url":"https://api.github.com/users/HealthCatalyst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HealthCatalyst/Fabric.Authorization","description":"Permissions service for applications","fork":false,"url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization","forks_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/forks","keys_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/teams","hooks_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/hooks","issue_events_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/issues/events{/number}","events_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/events","assignees_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/assignees{/user}","branches_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/branches{/branch}","tags_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/tags","blobs_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/git/refs{/sha}","trees_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/statuses/{sha}","languages_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/languages","stargazers_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/stargazers","contributors_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/contributors","subscribers_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/subscribers","subscription_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/subscription","commits_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/commits{/sha}","git_commits_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/git/commits{/sha}","comments_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/comments{/number}","issue_comment_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/issues/comments{/number}","contents_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/contents/{+path}","compare_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/merges","archive_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/downloads","issues_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/issues{/number}","pulls_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls{/number}","milestones_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/milestones{/number}","notifications_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/labels{/name}","releases_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/releases{/id}","deployments_url":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/deployments","created_at":"2017-05-02T21:20:07Z","updated_at":"2017-10-16T23:37:14Z","pushed_at":"2017-12-20T18:31:49Z","git_url":"git://github.com/HealthCatalyst/Fabric.Authorization.git","ssh_url":"[email protected]:HealthCatalyst/Fabric.Authorization.git","clone_url":"https://github.com/HealthCatalyst/Fabric.Authorization.git","svn_url":"https://github.com/HealthCatalyst/Fabric.Authorization","homepage":"","size":2431,"stargazers_count":5,"watchers_count":5,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":5,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/108"},"html":{"href":"https://github.com/HealthCatalyst/Fabric.Authorization/pull/108"},"issue":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/issues/108"},"comments":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/HealthCatalyst/Fabric.Authorization/statuses/2352cd55ccf3c9a6b808f65f883c50caf6d40424"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 90079030,
"name": "HealthCatalyst/Fabric.Authorization",
"url": "https://api.github.com/repos/HealthCatalyst/Fabric.Authorization"
}
|
{
"id": 6453904,
"login": "bsmithvt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6453904?",
"url": "https://api.github.com/users/bsmithvt"
}
|
{
"id": 27259917,
"login": "HealthCatalyst",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/27259917?",
"url": "https://api.github.com/orgs/HealthCatalyst"
}
| 2017-12-20T18:52:55 |
7014728705
|
{"actor":{"display_login":"bsmithvt"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/pulls/comments/137316837","pull_request_review_id":60967059,"id":137316837,"diff_hunk":"@@ -0,0 +1,92 @@\n+<!doctype html>\n+<html lang=\"en\">\n+ <head>\n+ <meta charset=\"utf-8\">\n+ <meta name=\"viewport\" content=\"width=device-width, minimum-scale=1, initial-scale=1, user-scalable=yes\">\n+\n+ <title>kwc-feature-list test</title>\n+\n+ <script src=\"../../webcomponentsjs/webcomponents-lite.js\"></script>\n+ <script src=\"../../web-component-tester/browser.js\"></script>\n+\n+ <link rel=\"import\" href=\"../kwc-feature-list.html\">\n+ </head>\n+ <body>\n+ <test-fixture id=\"basic\">\n+ <template>\n+ <kwc-feature-list></kwc-feature-list>\n+ </template>\n+ </test-fixture>\n+\n+ <script>\n+ suite('kwc-feature-list', function() {\n+ var element;\n+\n+ setup(function () {\n+ element = fixture('basic');\n+ });\n+\n+ test('instantiating the element works', function() {\n+ assert.equal(element.is, 'kwc-feature-list');\n+ });\n+\n+ test('the title is null by default', function() {\n+ assert.equal(element.title, null);\n+ });\n+\n+ test('the title can be set imperatively', function(done) {\n+ var titleText = 'Features';\n+ element.title = titleText;\n+ assert.equal(element.title, titleText);\n+ flush(function() {\n+ var title = Polymer.dom(element.root).querySelector('h2');\n+ assert.equal(title.textContent, titleText);\n+ done();\n+ });\n+ });\n+\n+ test('the features are an empty array by default', function() {\n+ assert.isArray(element.features);\n+ assert.lengthOf(element.features, 0);\n+ });\n+\n+ test('the features can be set imperatively', function(done) {\n+ var imageUrl = 'https://placekitten.com/300/150',\n+ featureArray = [\n+ {\n+ imgSrc: imageUrl,\n+ title: \"Title 1\",\n+ body: \"Body 1\"\n+ }, {\n+ imgSrc: imageUrl,\n+ title: \"Title 2\",\n+ body: \"Body 2\"\n+ }, {\n+ imgSrc: imageUrl,\n+ title: \"Title 3\",\n+ body: \"Body 3\"\n+ }\n+ ];\n+ element.features = featureArray;\n+ assert.lengthOf(element.features, featureArray.length);\n+ assert.isObject(element.features[0]);\n+ assert.equal(element.features[0].imgSrc, imageUrl);\n+ assert.equal(element.features[0].title, 'Title 1');\n+ assert.equal(element.features[0].body, 'Body 1');\n+ flush(function() {\n+ var features = Polymer.dom(element.root).querySelectorAll('.feature'),\n+ feature = Polymer.dom(element.root).querySelector('.feature'),\n+ image = feature.querySelector('iron-image')\n+ title = feature.querySelector('h3'),\n+ body = feature.querySelector('p');\n+ assert.lengthOf(features, featureArray.length);","path":"test/kwc-feature-list_test.html","position":82,"original_position":82,"commit_id":"61643b7932a06a746be1e4c82737070ccf3d646f","original_commit_id":"61643b7932a06a746be1e4c82737070ccf3d646f","user":{"login":"murilopolese","id":954594,"avatar_url":"https://avatars3.githubusercontent.com/u/954594?v=4","gravatar_id":"","url":"https://api.github.com/users/murilopolese","html_url":"https://github.com/murilopolese","followers_url":"https://api.github.com/users/murilopolese/followers","following_url":"https://api.github.com/users/murilopolese/following{/other_user}","gists_url":"https://api.github.com/users/murilopolese/gists{/gist_id}","starred_url":"https://api.github.com/users/murilopolese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murilopolese/subscriptions","organizations_url":"https://api.github.com/users/murilopolese/orgs","repos_url":"https://api.github.com/users/murilopolese/repos","events_url":"https://api.github.com/users/murilopolese/events{/privacy}","received_events_url":"https://api.github.com/users/murilopolese/received_events","type":"User","site_admin":false},"body":"Uh! Nice finding this `lengthOf`!","created_at":"2017-09-06T16:15:56Z","updated_at":"2017-09-06T16:18:27Z","html_url":"https://github.com/KanoComponents/kwc-feature-list/pull/1#discussion_r137316837","pull_request_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/KanoComponents/kwc-feature-list/pulls/comments/137316837"},"html":{"href":"https://github.com/KanoComponents/kwc-feature-list/pull/1#discussion_r137316837"},"pull_request":{"href":"https://api.github.com/repos/KanoComponents/kwc-feature-list/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/pulls/1","id":139585414,"html_url":"https://github.com/KanoComponents/kwc-feature-list/pull/1","diff_url":"https://github.com/KanoComponents/kwc-feature-list/pull/1.diff","patch_url":"https://github.com/KanoComponents/kwc-feature-list/pull/1.patch","issue_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/issues/1","number":1,"state":"open","locked":false,"title":"Initial component setup","user":{"login":"abridger","id":4664049,"avatar_url":"https://avatars1.githubusercontent.com/u/4664049?v=4","gravatar_id":"","url":"https://api.github.com/users/abridger","html_url":"https://github.com/abridger","followers_url":"https://api.github.com/users/abridger/followers","following_url":"https://api.github.com/users/abridger/following{/other_user}","gists_url":"https://api.github.com/users/abridger/gists{/gist_id}","starred_url":"https://api.github.com/users/abridger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abridger/subscriptions","organizations_url":"https://api.github.com/users/abridger/orgs","repos_url":"https://api.github.com/users/abridger/repos","events_url":"https://api.github.com/users/abridger/events{/privacy}","received_events_url":"https://api.github.com/users/abridger/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-06T14:57:13Z","updated_at":"2017-09-06T16:18:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11719639a305f6fa89b63308c766bd28102b9956","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/pulls/1/commits","review_comments_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/pulls/1/comments","review_comment_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/issues/1/comments","statuses_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/statuses/61643b7932a06a746be1e4c82737070ccf3d646f","head":{"label":"abridger:development","ref":"development","sha":"61643b7932a06a746be1e4c82737070ccf3d646f","user":{"login":"abridger","id":4664049,"avatar_url":"https://avatars1.githubusercontent.com/u/4664049?v=4","gravatar_id":"","url":"https://api.github.com/users/abridger","html_url":"https://github.com/abridger","followers_url":"https://api.github.com/users/abridger/followers","following_url":"https://api.github.com/users/abridger/following{/other_user}","gists_url":"https://api.github.com/users/abridger/gists{/gist_id}","starred_url":"https://api.github.com/users/abridger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abridger/subscriptions","organizations_url":"https://api.github.com/users/abridger/orgs","repos_url":"https://api.github.com/users/abridger/repos","events_url":"https://api.github.com/users/abridger/events{/privacy}","received_events_url":"https://api.github.com/users/abridger/received_events","type":"User","site_admin":false},"repo":{"id":102621734,"name":"kwc-feature-list","full_name":"abridger/kwc-feature-list","owner":{"login":"abridger","id":4664049,"avatar_url":"https://avatars1.githubusercontent.com/u/4664049?v=4","gravatar_id":"","url":"https://api.github.com/users/abridger","html_url":"https://github.com/abridger","followers_url":"https://api.github.com/users/abridger/followers","following_url":"https://api.github.com/users/abridger/following{/other_user}","gists_url":"https://api.github.com/users/abridger/gists{/gist_id}","starred_url":"https://api.github.com/users/abridger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abridger/subscriptions","organizations_url":"https://api.github.com/users/abridger/orgs","repos_url":"https://api.github.com/users/abridger/repos","events_url":"https://api.github.com/users/abridger/events{/privacy}","received_events_url":"https://api.github.com/users/abridger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abridger/kwc-feature-list","description":null,"fork":true,"url":"https://api.github.com/repos/abridger/kwc-feature-list","forks_url":"https://api.github.com/repos/abridger/kwc-feature-list/forks","keys_url":"https://api.github.com/repos/abridger/kwc-feature-list/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abridger/kwc-feature-list/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abridger/kwc-feature-list/teams","hooks_url":"https://api.github.com/repos/abridger/kwc-feature-list/hooks","issue_events_url":"https://api.github.com/repos/abridger/kwc-feature-list/issues/events{/number}","events_url":"https://api.github.com/repos/abridger/kwc-feature-list/events","assignees_url":"https://api.github.com/repos/abridger/kwc-feature-list/assignees{/user}","branches_url":"https://api.github.com/repos/abridger/kwc-feature-list/branches{/branch}","tags_url":"https://api.github.com/repos/abridger/kwc-feature-list/tags","blobs_url":"https://api.github.com/repos/abridger/kwc-feature-list/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abridger/kwc-feature-list/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abridger/kwc-feature-list/git/refs{/sha}","trees_url":"https://api.github.com/repos/abridger/kwc-feature-list/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abridger/kwc-feature-list/statuses/{sha}","languages_url":"https://api.github.com/repos/abridger/kwc-feature-list/languages","stargazers_url":"https://api.github.com/repos/abridger/kwc-feature-list/stargazers","contributors_url":"https://api.github.com/repos/abridger/kwc-feature-list/contributors","subscribers_url":"https://api.github.com/repos/abridger/kwc-feature-list/subscribers","subscription_url":"https://api.github.com/repos/abridger/kwc-feature-list/subscription","commits_url":"https://api.github.com/repos/abridger/kwc-feature-list/commits{/sha}","git_commits_url":"https://api.github.com/repos/abridger/kwc-feature-list/git/commits{/sha}","comments_url":"https://api.github.com/repos/abridger/kwc-feature-list/comments{/number}","issue_comment_url":"https://api.github.com/repos/abridger/kwc-feature-list/issues/comments{/number}","contents_url":"https://api.github.com/repos/abridger/kwc-feature-list/contents/{+path}","compare_url":"https://api.github.com/repos/abridger/kwc-feature-list/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abridger/kwc-feature-list/merges","archive_url":"https://api.github.com/repos/abridger/kwc-feature-list/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abridger/kwc-feature-list/downloads","issues_url":"https://api.github.com/repos/abridger/kwc-feature-list/issues{/number}","pulls_url":"https://api.github.com/repos/abridger/kwc-feature-list/pulls{/number}","milestones_url":"https://api.github.com/repos/abridger/kwc-feature-list/milestones{/number}","notifications_url":"https://api.github.com/repos/abridger/kwc-feature-list/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abridger/kwc-feature-list/labels{/name}","releases_url":"https://api.github.com/repos/abridger/kwc-feature-list/releases{/id}","deployments_url":"https://api.github.com/repos/abridger/kwc-feature-list/deployments","created_at":"2017-09-06T14:54:04Z","updated_at":"2017-09-06T12:56:39Z","pushed_at":"2017-09-06T16:01:50Z","git_url":"git://github.com/abridger/kwc-feature-list.git","ssh_url":"[email protected]:abridger/kwc-feature-list.git","clone_url":"https://github.com/abridger/kwc-feature-list.git","svn_url":"https://github.com/abridger/kwc-feature-list","homepage":null,"size":6,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KanoComponents:master","ref":"master","sha":"c0f0f8567684c4ef8fa903926b9b19ba4a001ae6","user":{"login":"KanoComponents","id":31478227,"avatar_url":"https://avatars0.githubusercontent.com/u/31478227?v=4","gravatar_id":"","url":"https://api.github.com/users/KanoComponents","html_url":"https://github.com/KanoComponents","followers_url":"https://api.github.com/users/KanoComponents/followers","following_url":"https://api.github.com/users/KanoComponents/following{/other_user}","gists_url":"https://api.github.com/users/KanoComponents/gists{/gist_id}","starred_url":"https://api.github.com/users/KanoComponents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KanoComponents/subscriptions","organizations_url":"https://api.github.com/users/KanoComponents/orgs","repos_url":"https://api.github.com/users/KanoComponents/repos","events_url":"https://api.github.com/users/KanoComponents/events{/privacy}","received_events_url":"https://api.github.com/users/KanoComponents/received_events","type":"Organization","site_admin":false},"repo":{"id":102608516,"name":"kwc-feature-list","full_name":"KanoComponents/kwc-feature-list","owner":{"login":"KanoComponents","id":31478227,"avatar_url":"https://avatars0.githubusercontent.com/u/31478227?v=4","gravatar_id":"","url":"https://api.github.com/users/KanoComponents","html_url":"https://github.com/KanoComponents","followers_url":"https://api.github.com/users/KanoComponents/followers","following_url":"https://api.github.com/users/KanoComponents/following{/other_user}","gists_url":"https://api.github.com/users/KanoComponents/gists{/gist_id}","starred_url":"https://api.github.com/users/KanoComponents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KanoComponents/subscriptions","organizations_url":"https://api.github.com/users/KanoComponents/orgs","repos_url":"https://api.github.com/users/KanoComponents/repos","events_url":"https://api.github.com/users/KanoComponents/events{/privacy}","received_events_url":"https://api.github.com/users/KanoComponents/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KanoComponents/kwc-feature-list","description":null,"fork":false,"url":"https://api.github.com/repos/KanoComponents/kwc-feature-list","forks_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/forks","keys_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/teams","hooks_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/hooks","issue_events_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/issues/events{/number}","events_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/events","assignees_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/assignees{/user}","branches_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/branches{/branch}","tags_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/tags","blobs_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/git/refs{/sha}","trees_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/statuses/{sha}","languages_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/languages","stargazers_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/stargazers","contributors_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/contributors","subscribers_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/subscribers","subscription_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/subscription","commits_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/commits{/sha}","git_commits_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/git/commits{/sha}","comments_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/comments{/number}","issue_comment_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/issues/comments{/number}","contents_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/contents/{+path}","compare_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/merges","archive_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/downloads","issues_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/issues{/number}","pulls_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/pulls{/number}","milestones_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/milestones{/number}","notifications_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/labels{/name}","releases_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/releases{/id}","deployments_url":"https://api.github.com/repos/KanoComponents/kwc-feature-list/deployments","created_at":"2017-09-06T12:56:39Z","updated_at":"2017-09-06T12:56:39Z","pushed_at":"2017-09-06T16:01:51Z","git_url":"git://github.com/KanoComponents/kwc-feature-list.git","ssh_url":"[email protected]:KanoComponents/kwc-feature-list.git","clone_url":"https://github.com/KanoComponents/kwc-feature-list.git","svn_url":"https://github.com/KanoComponents/kwc-feature-list","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KanoComponents/kwc-feature-list/pulls/1"},"html":{"href":"https://github.com/KanoComponents/kwc-feature-list/pull/1"},"issue":{"href":"https://api.github.com/repos/KanoComponents/kwc-feature-list/issues/1"},"comments":{"href":"https://api.github.com/repos/KanoComponents/kwc-feature-list/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/KanoComponents/kwc-feature-list/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/KanoComponents/kwc-feature-list/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KanoComponents/kwc-feature-list/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/KanoComponents/kwc-feature-list/statuses/61643b7932a06a746be1e4c82737070ccf3d646f"}},"author_association":"MEMBER"}}
|
{
"id": 102608516,
"name": "KanoComponents/kwc-feature-list",
"url": "https://api.github.com/repos/KanoComponents/kwc-feature-list"
}
|
{
"id": 954594,
"login": "murilopolese",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/954594?",
"url": "https://api.github.com/users/murilopolese"
}
|
{
"id": 31478227,
"login": "KanoComponents",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31478227?",
"url": "https://api.github.com/orgs/KanoComponents"
}
| 2017-09-06T16:15:56 |
6557137438
|
{"actor":{"display_login":"murilopolese"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/pulls/comments/114840959","pull_request_review_id":36335482,"id":114840959,"diff_hunk":"@@ -897,9 +944,83 @@ fork_execute (const char *prog, char *const *argv)\n do_wait (prog, pex);\n }\n \n+/* Determine if progname is available in PATH. */\n+static bool\n+program_available (const char *progname)","path":"nvptx-as.c","position":83,"original_position":83,"commit_id":"39511bae362d5746c0bf0a1dcbc76297b4a0155c","original_commit_id":"39511bae362d5746c0bf0a1dcbc76297b4a0155c","user":{"login":"jakubjelinek","id":9370665,"avatar_url":"https://avatars0.githubusercontent.com/u/9370665?v=3","gravatar_id":"","url":"https://api.github.com/users/jakubjelinek","html_url":"https://github.com/jakubjelinek","followers_url":"https://api.github.com/users/jakubjelinek/followers","following_url":"https://api.github.com/users/jakubjelinek/following{/other_user}","gists_url":"https://api.github.com/users/jakubjelinek/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubjelinek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubjelinek/subscriptions","organizations_url":"https://api.github.com/users/jakubjelinek/orgs","repos_url":"https://api.github.com/users/jakubjelinek/repos","events_url":"https://api.github.com/users/jakubjelinek/events{/privacy}","received_events_url":"https://api.github.com/users/jakubjelinek/received_events","type":"User","site_admin":false},"body":"It is copied and modified from libiberty/make-relative-prefix.c. It is sufficiently different that sharing the code would require big changes into libiberty.","created_at":"2017-05-04T17:32:30Z","updated_at":"2017-05-04T17:32:30Z","html_url":"https://github.com/MentorEmbedded/nvptx-tools/pull/18#discussion_r114840959","pull_request_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/pulls/comments/114840959"},"html":{"href":"https://github.com/MentorEmbedded/nvptx-tools/pull/18#discussion_r114840959"},"pull_request":{"href":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/pulls/18","id":118945779,"html_url":"https://github.com/MentorEmbedded/nvptx-tools/pull/18","diff_url":"https://github.com/MentorEmbedded/nvptx-tools/pull/18.diff","patch_url":"https://github.com/MentorEmbedded/nvptx-tools/pull/18.patch","issue_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/issues/18","number":18,"state":"closed","locked":false,"title":"nvptx-none-as: Cope with ptxas not being available","user":{"login":"tschwinge","id":21753,"avatar_url":"https://avatars0.githubusercontent.com/u/21753?v=3","gravatar_id":"","url":"https://api.github.com/users/tschwinge","html_url":"https://github.com/tschwinge","followers_url":"https://api.github.com/users/tschwinge/followers","following_url":"https://api.github.com/users/tschwinge/following{/other_user}","gists_url":"https://api.github.com/users/tschwinge/gists{/gist_id}","starred_url":"https://api.github.com/users/tschwinge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschwinge/subscriptions","organizations_url":"https://api.github.com/users/tschwinge/orgs","repos_url":"https://api.github.com/users/tschwinge/repos","events_url":"https://api.github.com/users/tschwinge/events{/privacy}","received_events_url":"https://api.github.com/users/tschwinge/received_events","type":"User","site_admin":false},"body":"... to allow building GCC with PTX offloading even without CUDA being\r\ninstalled.\r\n\r\nBefore, nvptx-none-as was calling the ptxas program to verify the assembly\r\nis correct, which of course doesn't work very well when the proprietary\r\nptxas is not available. So the patch makes it invoke ptxas always only if\r\na new --verify option is used, if --no-verify is used, then as before it\r\nis not invoked, and without either of these options the behavior is that if\r\nptxas is found in $PATH, then it invokes it, if not, it does only minimal\r\nverification good enough for gcc/configure purposes (it turned out to be\r\nsufficient to error out if .version directive is not the first non-comment\r\ntoken (ptxas errors on that too).","created_at":"2017-05-04T10:53:18Z","updated_at":"2017-05-04T17:32:30Z","closed_at":"2017-05-04T17:05:41Z","merged_at":"2017-05-04T17:05:41Z","merge_commit_sha":"f959110889e0f032cdedea3d4f5d11d99ef0c362","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/pulls/18/commits","review_comments_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/pulls/18/comments","review_comment_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/issues/18/comments","statuses_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/statuses/39511bae362d5746c0bf0a1dcbc76297b4a0155c","head":{"label":"tschwinge:jakub-no-ptxas","ref":"jakub-no-ptxas","sha":"39511bae362d5746c0bf0a1dcbc76297b4a0155c","user":{"login":"tschwinge","id":21753,"avatar_url":"https://avatars0.githubusercontent.com/u/21753?v=3","gravatar_id":"","url":"https://api.github.com/users/tschwinge","html_url":"https://github.com/tschwinge","followers_url":"https://api.github.com/users/tschwinge/followers","following_url":"https://api.github.com/users/tschwinge/following{/other_user}","gists_url":"https://api.github.com/users/tschwinge/gists{/gist_id}","starred_url":"https://api.github.com/users/tschwinge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschwinge/subscriptions","organizations_url":"https://api.github.com/users/tschwinge/orgs","repos_url":"https://api.github.com/users/tschwinge/repos","events_url":"https://api.github.com/users/tschwinge/events{/privacy}","received_events_url":"https://api.github.com/users/tschwinge/received_events","type":"User","site_admin":false},"repo":{"id":31081100,"name":"nvptx-tools","full_name":"tschwinge/nvptx-tools","owner":{"login":"tschwinge","id":21753,"avatar_url":"https://avatars0.githubusercontent.com/u/21753?v=3","gravatar_id":"","url":"https://api.github.com/users/tschwinge","html_url":"https://github.com/tschwinge","followers_url":"https://api.github.com/users/tschwinge/followers","following_url":"https://api.github.com/users/tschwinge/following{/other_user}","gists_url":"https://api.github.com/users/tschwinge/gists{/gist_id}","starred_url":"https://api.github.com/users/tschwinge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschwinge/subscriptions","organizations_url":"https://api.github.com/users/tschwinge/orgs","repos_url":"https://api.github.com/users/tschwinge/repos","events_url":"https://api.github.com/users/tschwinge/events{/privacy}","received_events_url":"https://api.github.com/users/tschwinge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tschwinge/nvptx-tools","description":null,"fork":true,"url":"https://api.github.com/repos/tschwinge/nvptx-tools","forks_url":"https://api.github.com/repos/tschwinge/nvptx-tools/forks","keys_url":"https://api.github.com/repos/tschwinge/nvptx-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tschwinge/nvptx-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tschwinge/nvptx-tools/teams","hooks_url":"https://api.github.com/repos/tschwinge/nvptx-tools/hooks","issue_events_url":"https://api.github.com/repos/tschwinge/nvptx-tools/issues/events{/number}","events_url":"https://api.github.com/repos/tschwinge/nvptx-tools/events","assignees_url":"https://api.github.com/repos/tschwinge/nvptx-tools/assignees{/user}","branches_url":"https://api.github.com/repos/tschwinge/nvptx-tools/branches{/branch}","tags_url":"https://api.github.com/repos/tschwinge/nvptx-tools/tags","blobs_url":"https://api.github.com/repos/tschwinge/nvptx-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tschwinge/nvptx-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tschwinge/nvptx-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/tschwinge/nvptx-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tschwinge/nvptx-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/tschwinge/nvptx-tools/languages","stargazers_url":"https://api.github.com/repos/tschwinge/nvptx-tools/stargazers","contributors_url":"https://api.github.com/repos/tschwinge/nvptx-tools/contributors","subscribers_url":"https://api.github.com/repos/tschwinge/nvptx-tools/subscribers","subscription_url":"https://api.github.com/repos/tschwinge/nvptx-tools/subscription","commits_url":"https://api.github.com/repos/tschwinge/nvptx-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/tschwinge/nvptx-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/tschwinge/nvptx-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/tschwinge/nvptx-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/tschwinge/nvptx-tools/contents/{+path}","compare_url":"https://api.github.com/repos/tschwinge/nvptx-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tschwinge/nvptx-tools/merges","archive_url":"https://api.github.com/repos/tschwinge/nvptx-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tschwinge/nvptx-tools/downloads","issues_url":"https://api.github.com/repos/tschwinge/nvptx-tools/issues{/number}","pulls_url":"https://api.github.com/repos/tschwinge/nvptx-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/tschwinge/nvptx-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/tschwinge/nvptx-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tschwinge/nvptx-tools/labels{/name}","releases_url":"https://api.github.com/repos/tschwinge/nvptx-tools/releases{/id}","deployments_url":"https://api.github.com/repos/tschwinge/nvptx-tools/deployments","created_at":"2015-02-20T19:31:20Z","updated_at":"2015-02-20T19:31:21Z","pushed_at":"2017-05-04T17:16:06Z","git_url":"git://github.com/tschwinge/nvptx-tools.git","ssh_url":"[email protected]:tschwinge/nvptx-tools.git","clone_url":"https://github.com/tschwinge/nvptx-tools.git","svn_url":"https://github.com/tschwinge/nvptx-tools","homepage":null,"size":875,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MentorEmbedded:master","ref":"master","sha":"5006e9e473502fa6fc24059ab221e9095d91b377","user":{"login":"MentorEmbedded","id":1394742,"avatar_url":"https://avatars2.githubusercontent.com/u/1394742?v=3","gravatar_id":"","url":"https://api.github.com/users/MentorEmbedded","html_url":"https://github.com/MentorEmbedded","followers_url":"https://api.github.com/users/MentorEmbedded/followers","following_url":"https://api.github.com/users/MentorEmbedded/following{/other_user}","gists_url":"https://api.github.com/users/MentorEmbedded/gists{/gist_id}","starred_url":"https://api.github.com/users/MentorEmbedded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MentorEmbedded/subscriptions","organizations_url":"https://api.github.com/users/MentorEmbedded/orgs","repos_url":"https://api.github.com/users/MentorEmbedded/repos","events_url":"https://api.github.com/users/MentorEmbedded/events{/privacy}","received_events_url":"https://api.github.com/users/MentorEmbedded/received_events","type":"Organization","site_admin":false},"repo":{"id":26441447,"name":"nvptx-tools","full_name":"MentorEmbedded/nvptx-tools","owner":{"login":"MentorEmbedded","id":1394742,"avatar_url":"https://avatars2.githubusercontent.com/u/1394742?v=3","gravatar_id":"","url":"https://api.github.com/users/MentorEmbedded","html_url":"https://github.com/MentorEmbedded","followers_url":"https://api.github.com/users/MentorEmbedded/followers","following_url":"https://api.github.com/users/MentorEmbedded/following{/other_user}","gists_url":"https://api.github.com/users/MentorEmbedded/gists{/gist_id}","starred_url":"https://api.github.com/users/MentorEmbedded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MentorEmbedded/subscriptions","organizations_url":"https://api.github.com/users/MentorEmbedded/orgs","repos_url":"https://api.github.com/users/MentorEmbedded/repos","events_url":"https://api.github.com/users/MentorEmbedded/events{/privacy}","received_events_url":"https://api.github.com/users/MentorEmbedded/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MentorEmbedded/nvptx-tools","description":null,"fork":false,"url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools","forks_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/forks","keys_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/teams","hooks_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/hooks","issue_events_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/issues/events{/number}","events_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/events","assignees_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/assignees{/user}","branches_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/branches{/branch}","tags_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/tags","blobs_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/languages","stargazers_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/stargazers","contributors_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/contributors","subscribers_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/subscribers","subscription_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/subscription","commits_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/contents/{+path}","compare_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/merges","archive_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/downloads","issues_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/issues{/number}","pulls_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/labels{/name}","releases_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/releases{/id}","deployments_url":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/deployments","created_at":"2014-11-10T15:07:53Z","updated_at":"2017-05-04T10:02:57Z","pushed_at":"2017-05-04T17:15:41Z","git_url":"git://github.com/MentorEmbedded/nvptx-tools.git","ssh_url":"[email protected]:MentorEmbedded/nvptx-tools.git","clone_url":"https://github.com/MentorEmbedded/nvptx-tools.git","svn_url":"https://github.com/MentorEmbedded/nvptx-tools","homepage":null,"size":865,"stargazers_count":5,"watchers_count":5,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":9,"forks":4,"open_issues":9,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/pulls/18"},"html":{"href":"https://github.com/MentorEmbedded/nvptx-tools/pull/18"},"issue":{"href":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/issues/18"},"comments":{"href":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/MentorEmbedded/nvptx-tools/statuses/39511bae362d5746c0bf0a1dcbc76297b4a0155c"}}}}
|
{
"id": 26441447,
"name": "MentorEmbedded/nvptx-tools",
"url": "https://api.github.com/repos/MentorEmbedded/nvptx-tools"
}
|
{
"id": 9370665,
"login": "jakubjelinek",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9370665?",
"url": "https://api.github.com/users/jakubjelinek"
}
|
{
"id": 1394742,
"login": "MentorEmbedded",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1394742?",
"url": "https://api.github.com/orgs/MentorEmbedded"
}
| 2017-05-04T17:32:30 |
5811389260
|
{"actor":{"display_login":"jakubjelinek"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/OpenAngelArena/oaa/pulls/comments/107023268","pull_request_review_id":27973102,"id":107023268,"diff_hunk":"@@ -0,0 +1,28 @@\n+# Testing Open Angel Arena\n+This is the continuation of [Install guide](/docs/install.md)\n+Here is a guide how you can modify and run the OAA\n+\n+## Preparation\n+You first need to open dev tools and load OAA project","path":"docs/testing.md","position":6,"original_position":6,"commit_id":"d06145ffb1a7129ba0f11322941c2225d8788e73","original_commit_id":"d06145ffb1a7129ba0f11322941c2225d8788e73","user":{"login":"warpdragon","id":13878439,"avatar_url":"https://avatars1.githubusercontent.com/u/13878439?v=3","gravatar_id":"","url":"https://api.github.com/users/warpdragon","html_url":"https://github.com/warpdragon","followers_url":"https://api.github.com/users/warpdragon/followers","following_url":"https://api.github.com/users/warpdragon/following{/other_user}","gists_url":"https://api.github.com/users/warpdragon/gists{/gist_id}","starred_url":"https://api.github.com/users/warpdragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warpdragon/subscriptions","organizations_url":"https://api.github.com/users/warpdragon/orgs","repos_url":"https://api.github.com/users/warpdragon/repos","events_url":"https://api.github.com/users/warpdragon/events{/privacy}","received_events_url":"https://api.github.com/users/warpdragon/received_events","type":"User","site_admin":false},"body":"Should read:\r\n\"You first need to open 'Dota 2 Tools' and load OAA project\". There is no such program called \"Dev Tools\", right? It's Dota 2 Tools.","created_at":"2017-03-20T21:36:51Z","updated_at":"2017-03-20T21:36:51Z","html_url":"https://github.com/OpenAngelArena/oaa/pull/218#discussion_r107023268","pull_request_url":"https://api.github.com/repos/OpenAngelArena/oaa/pulls/218","_links":{"self":{"href":"https://api.github.com/repos/OpenAngelArena/oaa/pulls/comments/107023268"},"html":{"href":"https://github.com/OpenAngelArena/oaa/pull/218#discussion_r107023268"},"pull_request":{"href":"https://api.github.com/repos/OpenAngelArena/oaa/pulls/218"}}},"pull_request":{"url":"https://api.github.com/repos/OpenAngelArena/oaa/pulls/218","id":111652561,"html_url":"https://github.com/OpenAngelArena/oaa/pull/218","diff_url":"https://github.com/OpenAngelArena/oaa/pull/218.diff","patch_url":"https://github.com/OpenAngelArena/oaa/pull/218.patch","issue_url":"https://api.github.com/repos/OpenAngelArena/oaa/issues/218","number":218,"state":"open","locked":false,"title":"Nuke gulp and guides","user":{"login":"ProstoSanja","id":26527928,"avatar_url":"https://avatars1.githubusercontent.com/u/26527928?v=3","gravatar_id":"","url":"https://api.github.com/users/ProstoSanja","html_url":"https://github.com/ProstoSanja","followers_url":"https://api.github.com/users/ProstoSanja/followers","following_url":"https://api.github.com/users/ProstoSanja/following{/other_user}","gists_url":"https://api.github.com/users/ProstoSanja/gists{/gist_id}","starred_url":"https://api.github.com/users/ProstoSanja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProstoSanja/subscriptions","organizations_url":"https://api.github.com/users/ProstoSanja/orgs","repos_url":"https://api.github.com/users/ProstoSanja/repos","events_url":"https://api.github.com/users/ProstoSanja/events{/privacy}","received_events_url":"https://api.github.com/users/ProstoSanja/received_events","type":"User","site_admin":false},"body":"title says it all","created_at":"2017-03-20T21:16:02Z","updated_at":"2017-03-20T21:36:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"238e697d1e671a60cd60584785b86a11860119ec","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenAngelArena/oaa/pulls/218/commits","review_comments_url":"https://api.github.com/repos/OpenAngelArena/oaa/pulls/218/comments","review_comment_url":"https://api.github.com/repos/OpenAngelArena/oaa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenAngelArena/oaa/issues/218/comments","statuses_url":"https://api.github.com/repos/OpenAngelArena/oaa/statuses/d06145ffb1a7129ba0f11322941c2225d8788e73","head":{"label":"ProstoSanja:nuke-gulp-and-guides","ref":"nuke-gulp-and-guides","sha":"d06145ffb1a7129ba0f11322941c2225d8788e73","user":{"login":"ProstoSanja","id":26527928,"avatar_url":"https://avatars1.githubusercontent.com/u/26527928?v=3","gravatar_id":"","url":"https://api.github.com/users/ProstoSanja","html_url":"https://github.com/ProstoSanja","followers_url":"https://api.github.com/users/ProstoSanja/followers","following_url":"https://api.github.com/users/ProstoSanja/following{/other_user}","gists_url":"https://api.github.com/users/ProstoSanja/gists{/gist_id}","starred_url":"https://api.github.com/users/ProstoSanja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProstoSanja/subscriptions","organizations_url":"https://api.github.com/users/ProstoSanja/orgs","repos_url":"https://api.github.com/users/ProstoSanja/repos","events_url":"https://api.github.com/users/ProstoSanja/events{/privacy}","received_events_url":"https://api.github.com/users/ProstoSanja/received_events","type":"User","site_admin":false},"repo":{"id":85625564,"name":"oaa","full_name":"ProstoSanja/oaa","owner":{"login":"ProstoSanja","id":26527928,"avatar_url":"https://avatars1.githubusercontent.com/u/26527928?v=3","gravatar_id":"","url":"https://api.github.com/users/ProstoSanja","html_url":"https://github.com/ProstoSanja","followers_url":"https://api.github.com/users/ProstoSanja/followers","following_url":"https://api.github.com/users/ProstoSanja/following{/other_user}","gists_url":"https://api.github.com/users/ProstoSanja/gists{/gist_id}","starred_url":"https://api.github.com/users/ProstoSanja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProstoSanja/subscriptions","organizations_url":"https://api.github.com/users/ProstoSanja/orgs","repos_url":"https://api.github.com/users/ProstoSanja/repos","events_url":"https://api.github.com/users/ProstoSanja/events{/privacy}","received_events_url":"https://api.github.com/users/ProstoSanja/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ProstoSanja/oaa","description":"A really great Dota 2 game mode.","fork":true,"url":"https://api.github.com/repos/ProstoSanja/oaa","forks_url":"https://api.github.com/repos/ProstoSanja/oaa/forks","keys_url":"https://api.github.com/repos/ProstoSanja/oaa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProstoSanja/oaa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProstoSanja/oaa/teams","hooks_url":"https://api.github.com/repos/ProstoSanja/oaa/hooks","issue_events_url":"https://api.github.com/repos/ProstoSanja/oaa/issues/events{/number}","events_url":"https://api.github.com/repos/ProstoSanja/oaa/events","assignees_url":"https://api.github.com/repos/ProstoSanja/oaa/assignees{/user}","branches_url":"https://api.github.com/repos/ProstoSanja/oaa/branches{/branch}","tags_url":"https://api.github.com/repos/ProstoSanja/oaa/tags","blobs_url":"https://api.github.com/repos/ProstoSanja/oaa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProstoSanja/oaa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProstoSanja/oaa/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProstoSanja/oaa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProstoSanja/oaa/statuses/{sha}","languages_url":"https://api.github.com/repos/ProstoSanja/oaa/languages","stargazers_url":"https://api.github.com/repos/ProstoSanja/oaa/stargazers","contributors_url":"https://api.github.com/repos/ProstoSanja/oaa/contributors","subscribers_url":"https://api.github.com/repos/ProstoSanja/oaa/subscribers","subscription_url":"https://api.github.com/repos/ProstoSanja/oaa/subscription","commits_url":"https://api.github.com/repos/ProstoSanja/oaa/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProstoSanja/oaa/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProstoSanja/oaa/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProstoSanja/oaa/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProstoSanja/oaa/contents/{+path}","compare_url":"https://api.github.com/repos/ProstoSanja/oaa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProstoSanja/oaa/merges","archive_url":"https://api.github.com/repos/ProstoSanja/oaa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProstoSanja/oaa/downloads","issues_url":"https://api.github.com/repos/ProstoSanja/oaa/issues{/number}","pulls_url":"https://api.github.com/repos/ProstoSanja/oaa/pulls{/number}","milestones_url":"https://api.github.com/repos/ProstoSanja/oaa/milestones{/number}","notifications_url":"https://api.github.com/repos/ProstoSanja/oaa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProstoSanja/oaa/labels{/name}","releases_url":"https://api.github.com/repos/ProstoSanja/oaa/releases{/id}","deployments_url":"https://api.github.com/repos/ProstoSanja/oaa/deployments","created_at":"2017-03-20T20:47:21Z","updated_at":"2017-03-20T20:47:24Z","pushed_at":"2017-03-20T21:15:24Z","git_url":"git://github.com/ProstoSanja/oaa.git","ssh_url":"[email protected]:ProstoSanja/oaa.git","clone_url":"https://github.com/ProstoSanja/oaa.git","svn_url":"https://github.com/ProstoSanja/oaa","homepage":null,"size":50995,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenAngelArena:master","ref":"master","sha":"9ffd06577e86ec9e0ec57cf21631b6b6819cb828","user":{"login":"OpenAngelArena","id":24740194,"avatar_url":"https://avatars3.githubusercontent.com/u/24740194?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenAngelArena","html_url":"https://github.com/OpenAngelArena","followers_url":"https://api.github.com/users/OpenAngelArena/followers","following_url":"https://api.github.com/users/OpenAngelArena/following{/other_user}","gists_url":"https://api.github.com/users/OpenAngelArena/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenAngelArena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenAngelArena/subscriptions","organizations_url":"https://api.github.com/users/OpenAngelArena/orgs","repos_url":"https://api.github.com/users/OpenAngelArena/repos","events_url":"https://api.github.com/users/OpenAngelArena/events{/privacy}","received_events_url":"https://api.github.com/users/OpenAngelArena/received_events","type":"Organization","site_admin":false},"repo":{"id":77870022,"name":"oaa","full_name":"OpenAngelArena/oaa","owner":{"login":"OpenAngelArena","id":24740194,"avatar_url":"https://avatars3.githubusercontent.com/u/24740194?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenAngelArena","html_url":"https://github.com/OpenAngelArena","followers_url":"https://api.github.com/users/OpenAngelArena/followers","following_url":"https://api.github.com/users/OpenAngelArena/following{/other_user}","gists_url":"https://api.github.com/users/OpenAngelArena/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenAngelArena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenAngelArena/subscriptions","organizations_url":"https://api.github.com/users/OpenAngelArena/orgs","repos_url":"https://api.github.com/users/OpenAngelArena/repos","events_url":"https://api.github.com/users/OpenAngelArena/events{/privacy}","received_events_url":"https://api.github.com/users/OpenAngelArena/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenAngelArena/oaa","description":"A really great Dota 2 game mode.","fork":false,"url":"https://api.github.com/repos/OpenAngelArena/oaa","forks_url":"https://api.github.com/repos/OpenAngelArena/oaa/forks","keys_url":"https://api.github.com/repos/OpenAngelArena/oaa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenAngelArena/oaa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenAngelArena/oaa/teams","hooks_url":"https://api.github.com/repos/OpenAngelArena/oaa/hooks","issue_events_url":"https://api.github.com/repos/OpenAngelArena/oaa/issues/events{/number}","events_url":"https://api.github.com/repos/OpenAngelArena/oaa/events","assignees_url":"https://api.github.com/repos/OpenAngelArena/oaa/assignees{/user}","branches_url":"https://api.github.com/repos/OpenAngelArena/oaa/branches{/branch}","tags_url":"https://api.github.com/repos/OpenAngelArena/oaa/tags","blobs_url":"https://api.github.com/repos/OpenAngelArena/oaa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenAngelArena/oaa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenAngelArena/oaa/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenAngelArena/oaa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenAngelArena/oaa/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenAngelArena/oaa/languages","stargazers_url":"https://api.github.com/repos/OpenAngelArena/oaa/stargazers","contributors_url":"https://api.github.com/repos/OpenAngelArena/oaa/contributors","subscribers_url":"https://api.github.com/repos/OpenAngelArena/oaa/subscribers","subscription_url":"https://api.github.com/repos/OpenAngelArena/oaa/subscription","commits_url":"https://api.github.com/repos/OpenAngelArena/oaa/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenAngelArena/oaa/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenAngelArena/oaa/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenAngelArena/oaa/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenAngelArena/oaa/contents/{+path}","compare_url":"https://api.github.com/repos/OpenAngelArena/oaa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenAngelArena/oaa/merges","archive_url":"https://api.github.com/repos/OpenAngelArena/oaa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenAngelArena/oaa/downloads","issues_url":"https://api.github.com/repos/OpenAngelArena/oaa/issues{/number}","pulls_url":"https://api.github.com/repos/OpenAngelArena/oaa/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenAngelArena/oaa/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenAngelArena/oaa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenAngelArena/oaa/labels{/name}","releases_url":"https://api.github.com/repos/OpenAngelArena/oaa/releases{/id}","deployments_url":"https://api.github.com/repos/OpenAngelArena/oaa/deployments","created_at":"2017-01-03T00:03:14Z","updated_at":"2017-03-20T18:47:47Z","pushed_at":"2017-03-20T21:16:03Z","git_url":"git://github.com/OpenAngelArena/oaa.git","ssh_url":"[email protected]:OpenAngelArena/oaa.git","clone_url":"https://github.com/OpenAngelArena/oaa.git","svn_url":"https://github.com/OpenAngelArena/oaa","homepage":null,"size":50995,"stargazers_count":49,"watchers_count":49,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":53,"forks":48,"open_issues":53,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenAngelArena/oaa/pulls/218"},"html":{"href":"https://github.com/OpenAngelArena/oaa/pull/218"},"issue":{"href":"https://api.github.com/repos/OpenAngelArena/oaa/issues/218"},"comments":{"href":"https://api.github.com/repos/OpenAngelArena/oaa/issues/218/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenAngelArena/oaa/pulls/218/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenAngelArena/oaa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenAngelArena/oaa/pulls/218/commits"},"statuses":{"href":"https://api.github.com/repos/OpenAngelArena/oaa/statuses/d06145ffb1a7129ba0f11322941c2225d8788e73"}}}}
|
{
"id": 77870022,
"name": "OpenAngelArena/oaa",
"url": "https://api.github.com/repos/OpenAngelArena/oaa"
}
|
{
"id": 13878439,
"login": "warpdragon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13878439?",
"url": "https://api.github.com/users/warpdragon"
}
|
{
"id": 24740194,
"login": "OpenAngelArena",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24740194?",
"url": "https://api.github.com/orgs/OpenAngelArena"
}
| 2017-03-20T21:36:51 |
5529083541
|
{"actor":{"display_login":"warpdragon"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/pulls/comments/116396891","pull_request_review_id":38014615,"id":116396891,"diff_hunk":"@@ -237,5 +260,18 @@ public static void PasteToPosition(Models.PowerPointSlide slide, bool clipboardI\n }\n }\n }\n+\n+ private static ShapeRange RemovePlaceholders(PowerPointSlide slide, ShapeRange shapes)","path":"PowerPointLabs/PowerPointLabs/PasteLab/PasteLabMain.cs","position":null,"original_position":207,"commit_id":"558d4b3f824b004ff50bf8833b811ad71a15c61b","original_commit_id":"af69ca747fcead8d152d2337a3fa8c1a17f7ec5a","user":{"login":"kai33","id":3591355,"avatar_url":"https://avatars2.githubusercontent.com/u/3591355?v=3","gravatar_id":"","url":"https://api.github.com/users/kai33","html_url":"https://github.com/kai33","followers_url":"https://api.github.com/users/kai33/followers","following_url":"https://api.github.com/users/kai33/following{/other_user}","gists_url":"https://api.github.com/users/kai33/gists{/gist_id}","starred_url":"https://api.github.com/users/kai33/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kai33/subscriptions","organizations_url":"https://api.github.com/users/kai33/orgs","repos_url":"https://api.github.com/users/kai33/repos","events_url":"https://api.github.com/users/kai33/events{/privacy}","received_events_url":"https://api.github.com/users/kai33/received_events","type":"User","site_admin":false},"body":"quick question, it feels strange the methods are put into Graphics.cs,\r\nshould it be put into shapes' related util, what do you think","created_at":"2017-05-15T01:15:44Z","updated_at":"2017-05-15T01:15:44Z","html_url":"https://github.com/PowerPointLabs/PowerPointLabs/pull/1326#discussion_r116396891","pull_request_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/pulls/1326","_links":{"self":{"href":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/pulls/comments/116396891"},"html":{"href":"https://github.com/PowerPointLabs/PowerPointLabs/pull/1326#discussion_r116396891"},"pull_request":{"href":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/pulls/1326"}}},"pull_request":{"url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/pulls/1326","id":120046827,"html_url":"https://github.com/PowerPointLabs/PowerPointLabs/pull/1326","diff_url":"https://github.com/PowerPointLabs/PowerPointLabs/pull/1326.diff","patch_url":"https://github.com/PowerPointLabs/PowerPointLabs/pull/1326.patch","issue_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/issues/1326","number":1326,"state":"open","locked":false,"title":"Paste To Fill Slide does not maintain aspect ratio and crop to slide #1325 ","user":{"login":"initialshl","id":19281538,"avatar_url":"https://avatars2.githubusercontent.com/u/19281538?v=3","gravatar_id":"","url":"https://api.github.com/users/initialshl","html_url":"https://github.com/initialshl","followers_url":"https://api.github.com/users/initialshl/followers","following_url":"https://api.github.com/users/initialshl/following{/other_user}","gists_url":"https://api.github.com/users/initialshl/gists{/gist_id}","starred_url":"https://api.github.com/users/initialshl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/initialshl/subscriptions","organizations_url":"https://api.github.com/users/initialshl/orgs","repos_url":"https://api.github.com/users/initialshl/repos","events_url":"https://api.github.com/users/initialshl/events{/privacy}","received_events_url":"https://api.github.com/users/initialshl/received_events","type":"User","site_admin":false},"body":"Fixes #1325 , #1306 (similar issues and fixes, dependent helper methods)\r\n\r\nThe crop can be reverted using PowerPoint's crop","created_at":"2017-05-11T08:01:55Z","updated_at":"2017-05-15T01:15:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01a456ec2c183196095e0c6a788212d8417c23dc","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/pulls/1326/commits","review_comments_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/pulls/1326/comments","review_comment_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/issues/1326/comments","statuses_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/statuses/558d4b3f824b004ff50bf8833b811ad71a15c61b","head":{"label":"initialshl:1325-fix-paste-to-fill-slide","ref":"1325-fix-paste-to-fill-slide","sha":"558d4b3f824b004ff50bf8833b811ad71a15c61b","user":{"login":"initialshl","id":19281538,"avatar_url":"https://avatars2.githubusercontent.com/u/19281538?v=3","gravatar_id":"","url":"https://api.github.com/users/initialshl","html_url":"https://github.com/initialshl","followers_url":"https://api.github.com/users/initialshl/followers","following_url":"https://api.github.com/users/initialshl/following{/other_user}","gists_url":"https://api.github.com/users/initialshl/gists{/gist_id}","starred_url":"https://api.github.com/users/initialshl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/initialshl/subscriptions","organizations_url":"https://api.github.com/users/initialshl/orgs","repos_url":"https://api.github.com/users/initialshl/repos","events_url":"https://api.github.com/users/initialshl/events{/privacy}","received_events_url":"https://api.github.com/users/initialshl/received_events","type":"User","site_admin":false},"repo":{"id":78319111,"name":"PowerPointLabs","full_name":"initialshl/PowerPointLabs","owner":{"login":"initialshl","id":19281538,"avatar_url":"https://avatars2.githubusercontent.com/u/19281538?v=3","gravatar_id":"","url":"https://api.github.com/users/initialshl","html_url":"https://github.com/initialshl","followers_url":"https://api.github.com/users/initialshl/followers","following_url":"https://api.github.com/users/initialshl/following{/other_user}","gists_url":"https://api.github.com/users/initialshl/gists{/gist_id}","starred_url":"https://api.github.com/users/initialshl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/initialshl/subscriptions","organizations_url":"https://api.github.com/users/initialshl/orgs","repos_url":"https://api.github.com/users/initialshl/repos","events_url":"https://api.github.com/users/initialshl/events{/privacy}","received_events_url":"https://api.github.com/users/initialshl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/initialshl/PowerPointLabs","description":"This is the project for PowerPointLabs, a productivity add-in for PowerPoint","fork":true,"url":"https://api.github.com/repos/initialshl/PowerPointLabs","forks_url":"https://api.github.com/repos/initialshl/PowerPointLabs/forks","keys_url":"https://api.github.com/repos/initialshl/PowerPointLabs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/initialshl/PowerPointLabs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/initialshl/PowerPointLabs/teams","hooks_url":"https://api.github.com/repos/initialshl/PowerPointLabs/hooks","issue_events_url":"https://api.github.com/repos/initialshl/PowerPointLabs/issues/events{/number}","events_url":"https://api.github.com/repos/initialshl/PowerPointLabs/events","assignees_url":"https://api.github.com/repos/initialshl/PowerPointLabs/assignees{/user}","branches_url":"https://api.github.com/repos/initialshl/PowerPointLabs/branches{/branch}","tags_url":"https://api.github.com/repos/initialshl/PowerPointLabs/tags","blobs_url":"https://api.github.com/repos/initialshl/PowerPointLabs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/initialshl/PowerPointLabs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/initialshl/PowerPointLabs/git/refs{/sha}","trees_url":"https://api.github.com/repos/initialshl/PowerPointLabs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/initialshl/PowerPointLabs/statuses/{sha}","languages_url":"https://api.github.com/repos/initialshl/PowerPointLabs/languages","stargazers_url":"https://api.github.com/repos/initialshl/PowerPointLabs/stargazers","contributors_url":"https://api.github.com/repos/initialshl/PowerPointLabs/contributors","subscribers_url":"https://api.github.com/repos/initialshl/PowerPointLabs/subscribers","subscription_url":"https://api.github.com/repos/initialshl/PowerPointLabs/subscription","commits_url":"https://api.github.com/repos/initialshl/PowerPointLabs/commits{/sha}","git_commits_url":"https://api.github.com/repos/initialshl/PowerPointLabs/git/commits{/sha}","comments_url":"https://api.github.com/repos/initialshl/PowerPointLabs/comments{/number}","issue_comment_url":"https://api.github.com/repos/initialshl/PowerPointLabs/issues/comments{/number}","contents_url":"https://api.github.com/repos/initialshl/PowerPointLabs/contents/{+path}","compare_url":"https://api.github.com/repos/initialshl/PowerPointLabs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/initialshl/PowerPointLabs/merges","archive_url":"https://api.github.com/repos/initialshl/PowerPointLabs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/initialshl/PowerPointLabs/downloads","issues_url":"https://api.github.com/repos/initialshl/PowerPointLabs/issues{/number}","pulls_url":"https://api.github.com/repos/initialshl/PowerPointLabs/pulls{/number}","milestones_url":"https://api.github.com/repos/initialshl/PowerPointLabs/milestones{/number}","notifications_url":"https://api.github.com/repos/initialshl/PowerPointLabs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/initialshl/PowerPointLabs/labels{/name}","releases_url":"https://api.github.com/repos/initialshl/PowerPointLabs/releases{/id}","deployments_url":"https://api.github.com/repos/initialshl/PowerPointLabs/deployments","created_at":"2017-01-08T03:32:16Z","updated_at":"2017-01-08T03:32:20Z","pushed_at":"2017-05-15T01:04:48Z","git_url":"git://github.com/initialshl/PowerPointLabs.git","ssh_url":"[email protected]:initialshl/PowerPointLabs.git","clone_url":"https://github.com/initialshl/PowerPointLabs.git","svn_url":"https://github.com/initialshl/PowerPointLabs","homepage":"http://powerpointlabs.info","size":218301,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PowerPointLabs:dev-release","ref":"dev-release","sha":"b98d1a0e5406e930f5d6609a40f62d6fcd0c4527","user":{"login":"PowerPointLabs","id":7374821,"avatar_url":"https://avatars3.githubusercontent.com/u/7374821?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerPointLabs","html_url":"https://github.com/PowerPointLabs","followers_url":"https://api.github.com/users/PowerPointLabs/followers","following_url":"https://api.github.com/users/PowerPointLabs/following{/other_user}","gists_url":"https://api.github.com/users/PowerPointLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerPointLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerPointLabs/subscriptions","organizations_url":"https://api.github.com/users/PowerPointLabs/orgs","repos_url":"https://api.github.com/users/PowerPointLabs/repos","events_url":"https://api.github.com/users/PowerPointLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PowerPointLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":19517247,"name":"PowerPointLabs","full_name":"PowerPointLabs/PowerPointLabs","owner":{"login":"PowerPointLabs","id":7374821,"avatar_url":"https://avatars3.githubusercontent.com/u/7374821?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerPointLabs","html_url":"https://github.com/PowerPointLabs","followers_url":"https://api.github.com/users/PowerPointLabs/followers","following_url":"https://api.github.com/users/PowerPointLabs/following{/other_user}","gists_url":"https://api.github.com/users/PowerPointLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerPointLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerPointLabs/subscriptions","organizations_url":"https://api.github.com/users/PowerPointLabs/orgs","repos_url":"https://api.github.com/users/PowerPointLabs/repos","events_url":"https://api.github.com/users/PowerPointLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PowerPointLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PowerPointLabs/PowerPointLabs","description":"This is the project for PowerPointLabs, a productivity add-in for PowerPoint","fork":false,"url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs","forks_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/forks","keys_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/teams","hooks_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/hooks","issue_events_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/issues/events{/number}","events_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/events","assignees_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/assignees{/user}","branches_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/branches{/branch}","tags_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/tags","blobs_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/languages","stargazers_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/stargazers","contributors_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/contributors","subscribers_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/subscribers","subscription_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/subscription","commits_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/contents/{+path}","compare_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/merges","archive_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/downloads","issues_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/issues{/number}","pulls_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/labels{/name}","releases_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/releases{/id}","deployments_url":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/deployments","created_at":"2014-05-07T01:46:34Z","updated_at":"2017-05-05T12:08:30Z","pushed_at":"2017-05-15T01:04:49Z","git_url":"git://github.com/PowerPointLabs/PowerPointLabs.git","ssh_url":"[email protected]:PowerPointLabs/PowerPointLabs.git","clone_url":"https://github.com/PowerPointLabs/PowerPointLabs.git","svn_url":"https://github.com/PowerPointLabs/PowerPointLabs","homepage":"http://powerpointlabs.info","size":219634,"stargazers_count":16,"watchers_count":16,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":126,"forks":31,"open_issues":126,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/pulls/1326"},"html":{"href":"https://github.com/PowerPointLabs/PowerPointLabs/pull/1326"},"issue":{"href":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/issues/1326"},"comments":{"href":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/issues/1326/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/pulls/1326/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/pulls/1326/commits"},"statuses":{"href":"https://api.github.com/repos/PowerPointLabs/PowerPointLabs/statuses/558d4b3f824b004ff50bf8833b811ad71a15c61b"}}}}
|
{
"id": 19517247,
"name": "PowerPointLabs/PowerPointLabs",
"url": "https://api.github.com/repos/PowerPointLabs/PowerPointLabs"
}
|
{
"id": 3591355,
"login": "kai33",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3591355?",
"url": "https://api.github.com/users/kai33"
}
|
{
"id": 7374821,
"login": "PowerPointLabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7374821?",
"url": "https://api.github.com/orgs/PowerPointLabs"
}
| 2017-05-15T01:15:44 |
5869892374
|
{"actor":{"display_login":"kai33"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/comments/94350795","pull_request_review_id":14876478,"id":94350795,"diff_hunk":"@@ -0,0 +1,145 @@\n+<?php\n+\n+/**\n+ * Simple Machines Forum (SMF)\n+ *\n+ * @package SMF\n+ * @author Simple Machines http://www.simplemachines.org\n+ * @copyright 2017 Simple Machines and individual contributors\n+ * @license http://www.simplemachines.org/about/smf/license.php BSD\n+ *\n+ * @version 2.1 Beta 3\n+ */\n+\n+if (!defined('SMF'))\n+\tdie('Hacking attempt...');\n+\n+/**\n+ * SQLite Cache API class\n+ * @package cacheAPI\n+ */\n+class sqlite_cache extends cache_api\n+{\n+ /**\n+ * @var string The path to the current $cachedir directory.\n+ */\n+ private $cachedir\t\t= null;\n+ private $cacheDB\t\t= null;\n+ private $cacheTime\t= null;\n+\n+\tpublic function __construct()\n+\t{\n+\t\tglobal $modSettings;\n+\n+\t\tparent::__construct();\n+\n+\t\t// Set our default cachedir.\n+\t\t$this->setCachedir();\n+\n+\t\t$database = $this->cachedir.'/'.'SQLite3Cache.db3';\n+\n+\t\t$this->cacheDB = new SQLite3($database);\n+\t\t$this->cacheDB->busyTimeout(1000);\n+\t\tif (filesize($database) == 0) {\n+\t\t\t$this->cacheDB->exec('CREATE TABLE cache (key text unique, value blob, ttl int);');\n+\t\t\t$this->cacheDB->exec('CREATE INDEX ttls ON cache(ttl);');\n+\t\t}\n+\t\t$this->cacheTime\t= time();\n+\n+\t}\n+\n+\t/**\n+\t * {@inheritDoc}\n+\t */\n+\tpublic function isSupported($test = false)\n+\t{\n+\t\t$supported = class_exists(\"SQLite3\") && is_writable($this->cachedir);\n+\n+\t\tif ($test)\n+\t\t\treturn $supported;\n+\n+\t\treturn parent::isSupported() && $supported;\n+\t}\n+\n+\t/**\n+\t * {@inheritDoc}\n+\t */\n+\tpublic function getData($key, $ttl = null)\n+\t{\n+\t\t$ttl\t\t= time();","path":"Sources/CacheAPI-sqlite.php","position":69,"original_position":69,"commit_id":"6f85aeb5ddd72dfc587f64428b0f1ec42e8163b4","original_commit_id":"6f85aeb5ddd72dfc587f64428b0f1ec42e8163b4","user":{"login":"jdarwood007","id":732116,"avatar_url":"https://avatars.githubusercontent.com/u/732116?v=3","gravatar_id":"","url":"https://api.github.com/users/jdarwood007","html_url":"https://github.com/jdarwood007","followers_url":"https://api.github.com/users/jdarwood007/followers","following_url":"https://api.github.com/users/jdarwood007/following{/other_user}","gists_url":"https://api.github.com/users/jdarwood007/gists{/gist_id}","starred_url":"https://api.github.com/users/jdarwood007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdarwood007/subscriptions","organizations_url":"https://api.github.com/users/jdarwood007/orgs","repos_url":"https://api.github.com/users/jdarwood007/repos","events_url":"https://api.github.com/users/jdarwood007/events{/privacy}","received_events_url":"https://api.github.com/users/jdarwood007/received_events","type":"User","site_admin":false},"body":"Was the TTL here to force the cache to always pull valid entries? How do we handle old entries (automatic cleanup/garbage collection)?","created_at":"2017-01-02T23:37:12Z","updated_at":"2017-01-02T23:38:34Z","html_url":"https://github.com/SimpleMachines/SMF2.1/pull/3778#discussion_r94350795","pull_request_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/3778","_links":{"self":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/comments/94350795"},"html":{"href":"https://github.com/SimpleMachines/SMF2.1/pull/3778#discussion_r94350795"},"pull_request":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/3778"}}},"pull_request":{"url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/3778","id":99883902,"html_url":"https://github.com/SimpleMachines/SMF2.1/pull/3778","diff_url":"https://github.com/SimpleMachines/SMF2.1/pull/3778.diff","patch_url":"https://github.com/SimpleMachines/SMF2.1/pull/3778.patch","issue_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/3778","number":3778,"state":"open","locked":false,"title":"Added SQLite Database Cacheing","user":{"login":"tinoest","id":2171403,"avatar_url":"https://avatars.githubusercontent.com/u/2171403?v=3","gravatar_id":"","url":"https://api.github.com/users/tinoest","html_url":"https://github.com/tinoest","followers_url":"https://api.github.com/users/tinoest/followers","following_url":"https://api.github.com/users/tinoest/following{/other_user}","gists_url":"https://api.github.com/users/tinoest/gists{/gist_id}","starred_url":"https://api.github.com/users/tinoest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinoest/subscriptions","organizations_url":"https://api.github.com/users/tinoest/orgs","repos_url":"https://api.github.com/users/tinoest/repos","events_url":"https://api.github.com/users/tinoest/events{/privacy}","received_events_url":"https://api.github.com/users/tinoest/received_events","type":"User","site_admin":false},"body":"Added SQLite Database Based Cache, in some instances its faster than filebased. Simple Class currently, if its wanted then I'll add additional features/checking to ensure its more stable. ","created_at":"2017-01-02T18:12:21Z","updated_at":"2017-01-02T23:38:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b59dd181836407e24313eb5648190d15d942862c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/3778/commits","review_comments_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/3778/comments","review_comment_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/3778/comments","statuses_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/statuses/6f85aeb5ddd72dfc587f64428b0f1ec42e8163b4","head":{"label":"tinoest:release-2.1","ref":"release-2.1","sha":"6f85aeb5ddd72dfc587f64428b0f1ec42e8163b4","user":{"login":"tinoest","id":2171403,"avatar_url":"https://avatars.githubusercontent.com/u/2171403?v=3","gravatar_id":"","url":"https://api.github.com/users/tinoest","html_url":"https://github.com/tinoest","followers_url":"https://api.github.com/users/tinoest/followers","following_url":"https://api.github.com/users/tinoest/following{/other_user}","gists_url":"https://api.github.com/users/tinoest/gists{/gist_id}","starred_url":"https://api.github.com/users/tinoest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinoest/subscriptions","organizations_url":"https://api.github.com/users/tinoest/orgs","repos_url":"https://api.github.com/users/tinoest/repos","events_url":"https://api.github.com/users/tinoest/events{/privacy}","received_events_url":"https://api.github.com/users/tinoest/received_events","type":"User","site_admin":false},"repo":{"id":40044741,"name":"SMF2.1","full_name":"tinoest/SMF2.1","owner":{"login":"tinoest","id":2171403,"avatar_url":"https://avatars.githubusercontent.com/u/2171403?v=3","gravatar_id":"","url":"https://api.github.com/users/tinoest","html_url":"https://github.com/tinoest","followers_url":"https://api.github.com/users/tinoest/followers","following_url":"https://api.github.com/users/tinoest/following{/other_user}","gists_url":"https://api.github.com/users/tinoest/gists{/gist_id}","starred_url":"https://api.github.com/users/tinoest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinoest/subscriptions","organizations_url":"https://api.github.com/users/tinoest/orgs","repos_url":"https://api.github.com/users/tinoest/repos","events_url":"https://api.github.com/users/tinoest/events{/privacy}","received_events_url":"https://api.github.com/users/tinoest/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tinoest/SMF2.1","description":"Thoughts, Ideas and bits of code for SMF (2.1)","fork":true,"url":"https://api.github.com/repos/tinoest/SMF2.1","forks_url":"https://api.github.com/repos/tinoest/SMF2.1/forks","keys_url":"https://api.github.com/repos/tinoest/SMF2.1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tinoest/SMF2.1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tinoest/SMF2.1/teams","hooks_url":"https://api.github.com/repos/tinoest/SMF2.1/hooks","issue_events_url":"https://api.github.com/repos/tinoest/SMF2.1/issues/events{/number}","events_url":"https://api.github.com/repos/tinoest/SMF2.1/events","assignees_url":"https://api.github.com/repos/tinoest/SMF2.1/assignees{/user}","branches_url":"https://api.github.com/repos/tinoest/SMF2.1/branches{/branch}","tags_url":"https://api.github.com/repos/tinoest/SMF2.1/tags","blobs_url":"https://api.github.com/repos/tinoest/SMF2.1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tinoest/SMF2.1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tinoest/SMF2.1/git/refs{/sha}","trees_url":"https://api.github.com/repos/tinoest/SMF2.1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tinoest/SMF2.1/statuses/{sha}","languages_url":"https://api.github.com/repos/tinoest/SMF2.1/languages","stargazers_url":"https://api.github.com/repos/tinoest/SMF2.1/stargazers","contributors_url":"https://api.github.com/repos/tinoest/SMF2.1/contributors","subscribers_url":"https://api.github.com/repos/tinoest/SMF2.1/subscribers","subscription_url":"https://api.github.com/repos/tinoest/SMF2.1/subscription","commits_url":"https://api.github.com/repos/tinoest/SMF2.1/commits{/sha}","git_commits_url":"https://api.github.com/repos/tinoest/SMF2.1/git/commits{/sha}","comments_url":"https://api.github.com/repos/tinoest/SMF2.1/comments{/number}","issue_comment_url":"https://api.github.com/repos/tinoest/SMF2.1/issues/comments{/number}","contents_url":"https://api.github.com/repos/tinoest/SMF2.1/contents/{+path}","compare_url":"https://api.github.com/repos/tinoest/SMF2.1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tinoest/SMF2.1/merges","archive_url":"https://api.github.com/repos/tinoest/SMF2.1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tinoest/SMF2.1/downloads","issues_url":"https://api.github.com/repos/tinoest/SMF2.1/issues{/number}","pulls_url":"https://api.github.com/repos/tinoest/SMF2.1/pulls{/number}","milestones_url":"https://api.github.com/repos/tinoest/SMF2.1/milestones{/number}","notifications_url":"https://api.github.com/repos/tinoest/SMF2.1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tinoest/SMF2.1/labels{/name}","releases_url":"https://api.github.com/repos/tinoest/SMF2.1/releases{/id}","deployments_url":"https://api.github.com/repos/tinoest/SMF2.1/deployments","created_at":"2015-08-01T11:38:09Z","updated_at":"2016-09-11T13:48:08Z","pushed_at":"2017-01-02T19:33:55Z","git_url":"git://github.com/tinoest/SMF2.1.git","ssh_url":"[email protected]:tinoest/SMF2.1.git","clone_url":"https://github.com/tinoest/SMF2.1.git","svn_url":"https://github.com/tinoest/SMF2.1","homepage":"","size":34906,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"release-2.1"}},"base":{"label":"SimpleMachines:release-2.1","ref":"release-2.1","sha":"250ee8f5c42efafd218582fb0f13c9c4fcd35bd6","user":{"login":"SimpleMachines","id":1085746,"avatar_url":"https://avatars.githubusercontent.com/u/1085746?v=3","gravatar_id":"","url":"https://api.github.com/users/SimpleMachines","html_url":"https://github.com/SimpleMachines","followers_url":"https://api.github.com/users/SimpleMachines/followers","following_url":"https://api.github.com/users/SimpleMachines/following{/other_user}","gists_url":"https://api.github.com/users/SimpleMachines/gists{/gist_id}","starred_url":"https://api.github.com/users/SimpleMachines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimpleMachines/subscriptions","organizations_url":"https://api.github.com/users/SimpleMachines/orgs","repos_url":"https://api.github.com/users/SimpleMachines/repos","events_url":"https://api.github.com/users/SimpleMachines/events{/privacy}","received_events_url":"https://api.github.com/users/SimpleMachines/received_events","type":"Organization","site_admin":false},"repo":{"id":3257475,"name":"SMF2.1","full_name":"SimpleMachines/SMF2.1","owner":{"login":"SimpleMachines","id":1085746,"avatar_url":"https://avatars.githubusercontent.com/u/1085746?v=3","gravatar_id":"","url":"https://api.github.com/users/SimpleMachines","html_url":"https://github.com/SimpleMachines","followers_url":"https://api.github.com/users/SimpleMachines/followers","following_url":"https://api.github.com/users/SimpleMachines/following{/other_user}","gists_url":"https://api.github.com/users/SimpleMachines/gists{/gist_id}","starred_url":"https://api.github.com/users/SimpleMachines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimpleMachines/subscriptions","organizations_url":"https://api.github.com/users/SimpleMachines/orgs","repos_url":"https://api.github.com/users/SimpleMachines/repos","events_url":"https://api.github.com/users/SimpleMachines/events{/privacy}","received_events_url":"https://api.github.com/users/SimpleMachines/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SimpleMachines/SMF2.1","description":"Thoughts, Ideas and bits of code for SMF (2.1)","fork":false,"url":"https://api.github.com/repos/SimpleMachines/SMF2.1","forks_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/forks","keys_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/teams","hooks_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/hooks","issue_events_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/events{/number}","events_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/events","assignees_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/assignees{/user}","branches_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/branches{/branch}","tags_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/tags","blobs_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/git/refs{/sha}","trees_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/statuses/{sha}","languages_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/languages","stargazers_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/stargazers","contributors_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/contributors","subscribers_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/subscribers","subscription_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/subscription","commits_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/commits{/sha}","git_commits_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/git/commits{/sha}","comments_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/comments{/number}","issue_comment_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/comments{/number}","contents_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/contents/{+path}","compare_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/merges","archive_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/downloads","issues_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues{/number}","pulls_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls{/number}","milestones_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/milestones{/number}","notifications_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/labels{/name}","releases_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/releases{/id}","deployments_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/deployments","created_at":"2012-01-24T16:36:19Z","updated_at":"2017-01-02T09:21:56Z","pushed_at":"2017-01-02T20:09:00Z","git_url":"git://github.com/SimpleMachines/SMF2.1.git","ssh_url":"[email protected]:SimpleMachines/SMF2.1.git","clone_url":"https://github.com/SimpleMachines/SMF2.1.git","svn_url":"https://github.com/SimpleMachines/SMF2.1","homepage":"","size":34896,"stargazers_count":221,"watchers_count":221,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":179,"mirror_url":null,"open_issues_count":132,"forks":179,"open_issues":132,"watchers":221,"default_branch":"release-2.1"}},"_links":{"self":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/3778"},"html":{"href":"https://github.com/SimpleMachines/SMF2.1/pull/3778"},"issue":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/3778"},"comments":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/3778/comments"},"review_comments":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/3778/comments"},"review_comment":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/3778/commits"},"statuses":{"href":"https://api.github.com/repos/SimpleMachines/SMF2.1/statuses/6f85aeb5ddd72dfc587f64428b0f1ec42e8163b4"}}}}
|
{
"id": 3257475,
"name": "SimpleMachines/SMF2.1",
"url": "https://api.github.com/repos/SimpleMachines/SMF2.1"
}
|
{
"id": 732116,
"login": "jdarwood007",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/732116?",
"url": "https://api.github.com/users/jdarwood007"
}
|
{
"id": 1085746,
"login": "SimpleMachines",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1085746?",
"url": "https://api.github.com/orgs/SimpleMachines"
}
| 2017-01-02T23:37:12 |
5092792120
|
{"actor":{"display_login":"jdarwood007"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/aceleradora-TW/conecta/pulls/comments/123231997","pull_request_review_id":45414170,"id":123231997,"diff_hunk":"@@ -1,66 +1,177 @@\n-\n @import \"_mixins.scss\";\n @import \"_variables.scss\";\n-@import \"MediaQuery\";\n+@import \"MediaQuery.scss\";\n+\n+\n \n .Navbar{\n \t@include size($width:100%, $height:12vh);\n-\t@include flex($direction: row, $justify: space-between);\n+\t@include flex($align: center, $direction: row, $justify: space-between);\n \tfont-family: $font-style;\n \tfont-weight: lighter;\n \tbackground-color: rgba(0,0,0,0.47);","path":"public/stylesheets/sass/Navbar.scss","position":15,"original_position":15,"commit_id":"2736ff09c4184eb4914372777dd7442cdcd0c99f","original_commit_id":"9981ed13c4dacd5ca4380f4150ab1efcce34b316","user":{"login":"annaleme","id":26899558,"avatar_url":"https://avatars2.githubusercontent.com/u/26899558?v=3","gravatar_id":"","url":"https://api.github.com/users/annaleme","html_url":"https://github.com/annaleme","followers_url":"https://api.github.com/users/annaleme/followers","following_url":"https://api.github.com/users/annaleme/following{/other_user}","gists_url":"https://api.github.com/users/annaleme/gists{/gist_id}","starred_url":"https://api.github.com/users/annaleme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annaleme/subscriptions","organizations_url":"https://api.github.com/users/annaleme/orgs","repos_url":"https://api.github.com/users/annaleme/repos","events_url":"https://api.github.com/users/annaleme/events{/privacy}","received_events_url":"https://api.github.com/users/annaleme/received_events","type":"User","site_admin":false},"body":"Ainda não trocaremos, pois não foi feito o merge :(","created_at":"2017-06-21T12:23:51Z","updated_at":"2017-06-21T12:23:52Z","html_url":"https://github.com/aceleradora-TW/conecta/pull/48#discussion_r123231997","pull_request_url":"https://api.github.com/repos/aceleradora-TW/conecta/pulls/48","_links":{"self":{"href":"https://api.github.com/repos/aceleradora-TW/conecta/pulls/comments/123231997"},"html":{"href":"https://github.com/aceleradora-TW/conecta/pull/48#discussion_r123231997"},"pull_request":{"href":"https://api.github.com/repos/aceleradora-TW/conecta/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/aceleradora-TW/conecta/pulls/48","id":125423221,"html_url":"https://github.com/aceleradora-TW/conecta/pull/48","diff_url":"https://github.com/aceleradora-TW/conecta/pull/48.diff","patch_url":"https://github.com/aceleradora-TW/conecta/pull/48.patch","issue_url":"https://api.github.com/repos/aceleradora-TW/conecta/issues/48","number":48,"state":"open","locked":false,"title":"Improvement 0 refatorar navbar","user":{"login":"annaleme","id":26899558,"avatar_url":"https://avatars2.githubusercontent.com/u/26899558?v=3","gravatar_id":"","url":"https://api.github.com/users/annaleme","html_url":"https://github.com/annaleme","followers_url":"https://api.github.com/users/annaleme/followers","following_url":"https://api.github.com/users/annaleme/following{/other_user}","gists_url":"https://api.github.com/users/annaleme/gists{/gist_id}","starred_url":"https://api.github.com/users/annaleme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annaleme/subscriptions","organizations_url":"https://api.github.com/users/annaleme/orgs","repos_url":"https://api.github.com/users/annaleme/repos","events_url":"https://api.github.com/users/annaleme/events{/privacy}","received_events_url":"https://api.github.com/users/annaleme/received_events","type":"User","site_admin":false},"body":"refatorar o css do navbar","created_at":"2017-06-13T17:49:54Z","updated_at":"2017-06-21T12:23:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d41e835ba5852d4bcf766cc8a462e47a1308e9a4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hsangalli","id":7349960,"avatar_url":"https://avatars1.githubusercontent.com/u/7349960?v=3","gravatar_id":"","url":"https://api.github.com/users/hsangalli","html_url":"https://github.com/hsangalli","followers_url":"https://api.github.com/users/hsangalli/followers","following_url":"https://api.github.com/users/hsangalli/following{/other_user}","gists_url":"https://api.github.com/users/hsangalli/gists{/gist_id}","starred_url":"https://api.github.com/users/hsangalli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsangalli/subscriptions","organizations_url":"https://api.github.com/users/hsangalli/orgs","repos_url":"https://api.github.com/users/hsangalli/repos","events_url":"https://api.github.com/users/hsangalli/events{/privacy}","received_events_url":"https://api.github.com/users/hsangalli/received_events","type":"User","site_admin":false},{"login":"gmeneguz","id":11391388,"avatar_url":"https://avatars3.githubusercontent.com/u/11391388?v=3","gravatar_id":"","url":"https://api.github.com/users/gmeneguz","html_url":"https://github.com/gmeneguz","followers_url":"https://api.github.com/users/gmeneguz/followers","following_url":"https://api.github.com/users/gmeneguz/following{/other_user}","gists_url":"https://api.github.com/users/gmeneguz/gists{/gist_id}","starred_url":"https://api.github.com/users/gmeneguz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmeneguz/subscriptions","organizations_url":"https://api.github.com/users/gmeneguz/orgs","repos_url":"https://api.github.com/users/gmeneguz/repos","events_url":"https://api.github.com/users/gmeneguz/events{/privacy}","received_events_url":"https://api.github.com/users/gmeneguz/received_events","type":"User","site_admin":false},{"login":"tatianeaguirres","id":15195125,"avatar_url":"https://avatars0.githubusercontent.com/u/15195125?v=3","gravatar_id":"","url":"https://api.github.com/users/tatianeaguirres","html_url":"https://github.com/tatianeaguirres","followers_url":"https://api.github.com/users/tatianeaguirres/followers","following_url":"https://api.github.com/users/tatianeaguirres/following{/other_user}","gists_url":"https://api.github.com/users/tatianeaguirres/gists{/gist_id}","starred_url":"https://api.github.com/users/tatianeaguirres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatianeaguirres/subscriptions","organizations_url":"https://api.github.com/users/tatianeaguirres/orgs","repos_url":"https://api.github.com/users/tatianeaguirres/repos","events_url":"https://api.github.com/users/tatianeaguirres/events{/privacy}","received_events_url":"https://api.github.com/users/tatianeaguirres/received_events","type":"User","site_admin":false},{"login":"BernardoFelipetto","id":17886435,"avatar_url":"https://avatars1.githubusercontent.com/u/17886435?v=3","gravatar_id":"","url":"https://api.github.com/users/BernardoFelipetto","html_url":"https://github.com/BernardoFelipetto","followers_url":"https://api.github.com/users/BernardoFelipetto/followers","following_url":"https://api.github.com/users/BernardoFelipetto/following{/other_user}","gists_url":"https://api.github.com/users/BernardoFelipetto/gists{/gist_id}","starred_url":"https://api.github.com/users/BernardoFelipetto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BernardoFelipetto/subscriptions","organizations_url":"https://api.github.com/users/BernardoFelipetto/orgs","repos_url":"https://api.github.com/users/BernardoFelipetto/repos","events_url":"https://api.github.com/users/BernardoFelipetto/events{/privacy}","received_events_url":"https://api.github.com/users/BernardoFelipetto/received_events","type":"User","site_admin":false},{"login":"cschallenberger","id":19154779,"avatar_url":"https://avatars1.githubusercontent.com/u/19154779?v=3","gravatar_id":"","url":"https://api.github.com/users/cschallenberger","html_url":"https://github.com/cschallenberger","followers_url":"https://api.github.com/users/cschallenberger/followers","following_url":"https://api.github.com/users/cschallenberger/following{/other_user}","gists_url":"https://api.github.com/users/cschallenberger/gists{/gist_id}","starred_url":"https://api.github.com/users/cschallenberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cschallenberger/subscriptions","organizations_url":"https://api.github.com/users/cschallenberger/orgs","repos_url":"https://api.github.com/users/cschallenberger/repos","events_url":"https://api.github.com/users/cschallenberger/events{/privacy}","received_events_url":"https://api.github.com/users/cschallenberger/received_events","type":"User","site_admin":false},{"login":"marlonfurtado","id":20863186,"avatar_url":"https://avatars0.githubusercontent.com/u/20863186?v=3","gravatar_id":"","url":"https://api.github.com/users/marlonfurtado","html_url":"https://github.com/marlonfurtado","followers_url":"https://api.github.com/users/marlonfurtado/followers","following_url":"https://api.github.com/users/marlonfurtado/following{/other_user}","gists_url":"https://api.github.com/users/marlonfurtado/gists{/gist_id}","starred_url":"https://api.github.com/users/marlonfurtado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marlonfurtado/subscriptions","organizations_url":"https://api.github.com/users/marlonfurtado/orgs","repos_url":"https://api.github.com/users/marlonfurtado/repos","events_url":"https://api.github.com/users/marlonfurtado/events{/privacy}","received_events_url":"https://api.github.com/users/marlonfurtado/received_events","type":"User","site_admin":false},{"login":"gbrlcardozo","id":26579791,"avatar_url":"https://avatars3.githubusercontent.com/u/26579791?v=3","gravatar_id":"","url":"https://api.github.com/users/gbrlcardozo","html_url":"https://github.com/gbrlcardozo","followers_url":"https://api.github.com/users/gbrlcardozo/followers","following_url":"https://api.github.com/users/gbrlcardozo/following{/other_user}","gists_url":"https://api.github.com/users/gbrlcardozo/gists{/gist_id}","starred_url":"https://api.github.com/users/gbrlcardozo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbrlcardozo/subscriptions","organizations_url":"https://api.github.com/users/gbrlcardozo/orgs","repos_url":"https://api.github.com/users/gbrlcardozo/repos","events_url":"https://api.github.com/users/gbrlcardozo/events{/privacy}","received_events_url":"https://api.github.com/users/gbrlcardozo/received_events","type":"User","site_admin":false},{"login":"mayracalves","id":26582427,"avatar_url":"https://avatars2.githubusercontent.com/u/26582427?v=3","gravatar_id":"","url":"https://api.github.com/users/mayracalves","html_url":"https://github.com/mayracalves","followers_url":"https://api.github.com/users/mayracalves/followers","following_url":"https://api.github.com/users/mayracalves/following{/other_user}","gists_url":"https://api.github.com/users/mayracalves/gists{/gist_id}","starred_url":"https://api.github.com/users/mayracalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayracalves/subscriptions","organizations_url":"https://api.github.com/users/mayracalves/orgs","repos_url":"https://api.github.com/users/mayracalves/repos","events_url":"https://api.github.com/users/mayracalves/events{/privacy}","received_events_url":"https://api.github.com/users/mayracalves/received_events","type":"User","site_admin":false},{"login":"fealmeida","id":26826136,"avatar_url":"https://avatars0.githubusercontent.com/u/26826136?v=3","gravatar_id":"","url":"https://api.github.com/users/fealmeida","html_url":"https://github.com/fealmeida","followers_url":"https://api.github.com/users/fealmeida/followers","following_url":"https://api.github.com/users/fealmeida/following{/other_user}","gists_url":"https://api.github.com/users/fealmeida/gists{/gist_id}","starred_url":"https://api.github.com/users/fealmeida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fealmeida/subscriptions","organizations_url":"https://api.github.com/users/fealmeida/orgs","repos_url":"https://api.github.com/users/fealmeida/repos","events_url":"https://api.github.com/users/fealmeida/events{/privacy}","received_events_url":"https://api.github.com/users/fealmeida/received_events","type":"User","site_admin":false},{"login":"FilipeHassen","id":26899666,"avatar_url":"https://avatars0.githubusercontent.com/u/26899666?v=3","gravatar_id":"","url":"https://api.github.com/users/FilipeHassen","html_url":"https://github.com/FilipeHassen","followers_url":"https://api.github.com/users/FilipeHassen/followers","following_url":"https://api.github.com/users/FilipeHassen/following{/other_user}","gists_url":"https://api.github.com/users/FilipeHassen/gists{/gist_id}","starred_url":"https://api.github.com/users/FilipeHassen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FilipeHassen/subscriptions","organizations_url":"https://api.github.com/users/FilipeHassen/orgs","repos_url":"https://api.github.com/users/FilipeHassen/repos","events_url":"https://api.github.com/users/FilipeHassen/events{/privacy}","received_events_url":"https://api.github.com/users/FilipeHassen/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/aceleradora-TW/conecta/pulls/48/commits","review_comments_url":"https://api.github.com/repos/aceleradora-TW/conecta/pulls/48/comments","review_comment_url":"https://api.github.com/repos/aceleradora-TW/conecta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aceleradora-TW/conecta/issues/48/comments","statuses_url":"https://api.github.com/repos/aceleradora-TW/conecta/statuses/2736ff09c4184eb4914372777dd7442cdcd0c99f","head":{"label":"aceleradora-TW:improvement-0-refatorar-navbar","ref":"improvement-0-refatorar-navbar","sha":"2736ff09c4184eb4914372777dd7442cdcd0c99f","user":{"login":"aceleradora-TW","id":18720656,"avatar_url":"https://avatars3.githubusercontent.com/u/18720656?v=3","gravatar_id":"","url":"https://api.github.com/users/aceleradora-TW","html_url":"https://github.com/aceleradora-TW","followers_url":"https://api.github.com/users/aceleradora-TW/followers","following_url":"https://api.github.com/users/aceleradora-TW/following{/other_user}","gists_url":"https://api.github.com/users/aceleradora-TW/gists{/gist_id}","starred_url":"https://api.github.com/users/aceleradora-TW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aceleradora-TW/subscriptions","organizations_url":"https://api.github.com/users/aceleradora-TW/orgs","repos_url":"https://api.github.com/users/aceleradora-TW/repos","events_url":"https://api.github.com/users/aceleradora-TW/events{/privacy}","received_events_url":"https://api.github.com/users/aceleradora-TW/received_events","type":"Organization","site_admin":false},"repo":{"id":89599892,"name":"conecta","full_name":"aceleradora-TW/conecta","owner":{"login":"aceleradora-TW","id":18720656,"avatar_url":"https://avatars3.githubusercontent.com/u/18720656?v=3","gravatar_id":"","url":"https://api.github.com/users/aceleradora-TW","html_url":"https://github.com/aceleradora-TW","followers_url":"https://api.github.com/users/aceleradora-TW/followers","following_url":"https://api.github.com/users/aceleradora-TW/following{/other_user}","gists_url":"https://api.github.com/users/aceleradora-TW/gists{/gist_id}","starred_url":"https://api.github.com/users/aceleradora-TW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aceleradora-TW/subscriptions","organizations_url":"https://api.github.com/users/aceleradora-TW/orgs","repos_url":"https://api.github.com/users/aceleradora-TW/repos","events_url":"https://api.github.com/users/aceleradora-TW/events{/privacy}","received_events_url":"https://api.github.com/users/aceleradora-TW/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aceleradora-TW/conecta","description":"CONECTA - Plataforma que fomenta parcerias em um ecossistema de inovação","fork":false,"url":"https://api.github.com/repos/aceleradora-TW/conecta","forks_url":"https://api.github.com/repos/aceleradora-TW/conecta/forks","keys_url":"https://api.github.com/repos/aceleradora-TW/conecta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aceleradora-TW/conecta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aceleradora-TW/conecta/teams","hooks_url":"https://api.github.com/repos/aceleradora-TW/conecta/hooks","issue_events_url":"https://api.github.com/repos/aceleradora-TW/conecta/issues/events{/number}","events_url":"https://api.github.com/repos/aceleradora-TW/conecta/events","assignees_url":"https://api.github.com/repos/aceleradora-TW/conecta/assignees{/user}","branches_url":"https://api.github.com/repos/aceleradora-TW/conecta/branches{/branch}","tags_url":"https://api.github.com/repos/aceleradora-TW/conecta/tags","blobs_url":"https://api.github.com/repos/aceleradora-TW/conecta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aceleradora-TW/conecta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aceleradora-TW/conecta/git/refs{/sha}","trees_url":"https://api.github.com/repos/aceleradora-TW/conecta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aceleradora-TW/conecta/statuses/{sha}","languages_url":"https://api.github.com/repos/aceleradora-TW/conecta/languages","stargazers_url":"https://api.github.com/repos/aceleradora-TW/conecta/stargazers","contributors_url":"https://api.github.com/repos/aceleradora-TW/conecta/contributors","subscribers_url":"https://api.github.com/repos/aceleradora-TW/conecta/subscribers","subscription_url":"https://api.github.com/repos/aceleradora-TW/conecta/subscription","commits_url":"https://api.github.com/repos/aceleradora-TW/conecta/commits{/sha}","git_commits_url":"https://api.github.com/repos/aceleradora-TW/conecta/git/commits{/sha}","comments_url":"https://api.github.com/repos/aceleradora-TW/conecta/comments{/number}","issue_comment_url":"https://api.github.com/repos/aceleradora-TW/conecta/issues/comments{/number}","contents_url":"https://api.github.com/repos/aceleradora-TW/conecta/contents/{+path}","compare_url":"https://api.github.com/repos/aceleradora-TW/conecta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aceleradora-TW/conecta/merges","archive_url":"https://api.github.com/repos/aceleradora-TW/conecta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aceleradora-TW/conecta/downloads","issues_url":"https://api.github.com/repos/aceleradora-TW/conecta/issues{/number}","pulls_url":"https://api.github.com/repos/aceleradora-TW/conecta/pulls{/number}","milestones_url":"https://api.github.com/repos/aceleradora-TW/conecta/milestones{/number}","notifications_url":"https://api.github.com/repos/aceleradora-TW/conecta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aceleradora-TW/conecta/labels{/name}","releases_url":"https://api.github.com/repos/aceleradora-TW/conecta/releases{/id}","deployments_url":"https://api.github.com/repos/aceleradora-TW/conecta/deployments","created_at":"2017-04-27T13:21:24Z","updated_at":"2017-06-12T18:34:51Z","pushed_at":"2017-06-20T18:47:40Z","git_url":"git://github.com/aceleradora-TW/conecta.git","ssh_url":"[email protected]:aceleradora-TW/conecta.git","clone_url":"https://github.com/aceleradora-TW/conecta.git","svn_url":"https://github.com/aceleradora-TW/conecta","homepage":"","size":1332,"stargazers_count":6,"watchers_count":6,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":17,"forks":2,"open_issues":17,"watchers":6,"default_branch":"master"}},"base":{"label":"aceleradora-TW:master","ref":"master","sha":"076098bf298145dd6e7c44c47ec2b74df0c40f21","user":{"login":"aceleradora-TW","id":18720656,"avatar_url":"https://avatars3.githubusercontent.com/u/18720656?v=3","gravatar_id":"","url":"https://api.github.com/users/aceleradora-TW","html_url":"https://github.com/aceleradora-TW","followers_url":"https://api.github.com/users/aceleradora-TW/followers","following_url":"https://api.github.com/users/aceleradora-TW/following{/other_user}","gists_url":"https://api.github.com/users/aceleradora-TW/gists{/gist_id}","starred_url":"https://api.github.com/users/aceleradora-TW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aceleradora-TW/subscriptions","organizations_url":"https://api.github.com/users/aceleradora-TW/orgs","repos_url":"https://api.github.com/users/aceleradora-TW/repos","events_url":"https://api.github.com/users/aceleradora-TW/events{/privacy}","received_events_url":"https://api.github.com/users/aceleradora-TW/received_events","type":"Organization","site_admin":false},"repo":{"id":89599892,"name":"conecta","full_name":"aceleradora-TW/conecta","owner":{"login":"aceleradora-TW","id":18720656,"avatar_url":"https://avatars3.githubusercontent.com/u/18720656?v=3","gravatar_id":"","url":"https://api.github.com/users/aceleradora-TW","html_url":"https://github.com/aceleradora-TW","followers_url":"https://api.github.com/users/aceleradora-TW/followers","following_url":"https://api.github.com/users/aceleradora-TW/following{/other_user}","gists_url":"https://api.github.com/users/aceleradora-TW/gists{/gist_id}","starred_url":"https://api.github.com/users/aceleradora-TW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aceleradora-TW/subscriptions","organizations_url":"https://api.github.com/users/aceleradora-TW/orgs","repos_url":"https://api.github.com/users/aceleradora-TW/repos","events_url":"https://api.github.com/users/aceleradora-TW/events{/privacy}","received_events_url":"https://api.github.com/users/aceleradora-TW/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aceleradora-TW/conecta","description":"CONECTA - Plataforma que fomenta parcerias em um ecossistema de inovação","fork":false,"url":"https://api.github.com/repos/aceleradora-TW/conecta","forks_url":"https://api.github.com/repos/aceleradora-TW/conecta/forks","keys_url":"https://api.github.com/repos/aceleradora-TW/conecta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aceleradora-TW/conecta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aceleradora-TW/conecta/teams","hooks_url":"https://api.github.com/repos/aceleradora-TW/conecta/hooks","issue_events_url":"https://api.github.com/repos/aceleradora-TW/conecta/issues/events{/number}","events_url":"https://api.github.com/repos/aceleradora-TW/conecta/events","assignees_url":"https://api.github.com/repos/aceleradora-TW/conecta/assignees{/user}","branches_url":"https://api.github.com/repos/aceleradora-TW/conecta/branches{/branch}","tags_url":"https://api.github.com/repos/aceleradora-TW/conecta/tags","blobs_url":"https://api.github.com/repos/aceleradora-TW/conecta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aceleradora-TW/conecta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aceleradora-TW/conecta/git/refs{/sha}","trees_url":"https://api.github.com/repos/aceleradora-TW/conecta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aceleradora-TW/conecta/statuses/{sha}","languages_url":"https://api.github.com/repos/aceleradora-TW/conecta/languages","stargazers_url":"https://api.github.com/repos/aceleradora-TW/conecta/stargazers","contributors_url":"https://api.github.com/repos/aceleradora-TW/conecta/contributors","subscribers_url":"https://api.github.com/repos/aceleradora-TW/conecta/subscribers","subscription_url":"https://api.github.com/repos/aceleradora-TW/conecta/subscription","commits_url":"https://api.github.com/repos/aceleradora-TW/conecta/commits{/sha}","git_commits_url":"https://api.github.com/repos/aceleradora-TW/conecta/git/commits{/sha}","comments_url":"https://api.github.com/repos/aceleradora-TW/conecta/comments{/number}","issue_comment_url":"https://api.github.com/repos/aceleradora-TW/conecta/issues/comments{/number}","contents_url":"https://api.github.com/repos/aceleradora-TW/conecta/contents/{+path}","compare_url":"https://api.github.com/repos/aceleradora-TW/conecta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aceleradora-TW/conecta/merges","archive_url":"https://api.github.com/repos/aceleradora-TW/conecta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aceleradora-TW/conecta/downloads","issues_url":"https://api.github.com/repos/aceleradora-TW/conecta/issues{/number}","pulls_url":"https://api.github.com/repos/aceleradora-TW/conecta/pulls{/number}","milestones_url":"https://api.github.com/repos/aceleradora-TW/conecta/milestones{/number}","notifications_url":"https://api.github.com/repos/aceleradora-TW/conecta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aceleradora-TW/conecta/labels{/name}","releases_url":"https://api.github.com/repos/aceleradora-TW/conecta/releases{/id}","deployments_url":"https://api.github.com/repos/aceleradora-TW/conecta/deployments","created_at":"2017-04-27T13:21:24Z","updated_at":"2017-06-12T18:34:51Z","pushed_at":"2017-06-20T18:47:40Z","git_url":"git://github.com/aceleradora-TW/conecta.git","ssh_url":"[email protected]:aceleradora-TW/conecta.git","clone_url":"https://github.com/aceleradora-TW/conecta.git","svn_url":"https://github.com/aceleradora-TW/conecta","homepage":"","size":1332,"stargazers_count":6,"watchers_count":6,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":17,"forks":2,"open_issues":17,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aceleradora-TW/conecta/pulls/48"},"html":{"href":"https://github.com/aceleradora-TW/conecta/pull/48"},"issue":{"href":"https://api.github.com/repos/aceleradora-TW/conecta/issues/48"},"comments":{"href":"https://api.github.com/repos/aceleradora-TW/conecta/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/aceleradora-TW/conecta/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/aceleradora-TW/conecta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aceleradora-TW/conecta/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/aceleradora-TW/conecta/statuses/2736ff09c4184eb4914372777dd7442cdcd0c99f"}}}}
|
{
"id": 89599892,
"name": "aceleradora-TW/conecta",
"url": "https://api.github.com/repos/aceleradora-TW/conecta"
}
|
{
"id": 26899558,
"login": "annaleme",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26899558?",
"url": "https://api.github.com/users/annaleme"
}
|
{
"id": 18720656,
"login": "aceleradora-TW",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18720656?",
"url": "https://api.github.com/orgs/aceleradora-TW"
}
| 2017-06-21T12:23:51 |
6109136694
|
{"actor":{"display_login":"annaleme"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/pulls/comments/152832821","pull_request_review_id":78755891,"id":152832821,"diff_hunk":"@@ -14,6 +14,7 @@\n gtag('js', new Date());\n gtag('config', 'UA-109982161-1' );\n </script>\n+ <link rel=\"shortcut icon\" href=\"/images/icone.ico\" >","path":"views/layouts/main.handlebars","position":4,"original_position":4,"commit_id":"a54fecf419d294a5617325c043ddf53075a62519","original_commit_id":"a54fecf419d294a5617325c043ddf53075a62519","user":{"login":"MauricioSalin","id":13355144,"avatar_url":"https://avatars0.githubusercontent.com/u/13355144?v=4","gravatar_id":"","url":"https://api.github.com/users/MauricioSalin","html_url":"https://github.com/MauricioSalin","followers_url":"https://api.github.com/users/MauricioSalin/followers","following_url":"https://api.github.com/users/MauricioSalin/following{/other_user}","gists_url":"https://api.github.com/users/MauricioSalin/gists{/gist_id}","starred_url":"https://api.github.com/users/MauricioSalin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MauricioSalin/subscriptions","organizations_url":"https://api.github.com/users/MauricioSalin/orgs","repos_url":"https://api.github.com/users/MauricioSalin/repos","events_url":"https://api.github.com/users/MauricioSalin/events{/privacy}","received_events_url":"https://api.github.com/users/MauricioSalin/received_events","type":"User","site_admin":false},"body":"O ícone da aba do navegador também deve ser acessivel?","created_at":"2017-11-23T15:51:33Z","updated_at":"2017-11-23T15:51:33Z","html_url":"https://github.com/aceleradora-TW/conhecimento-livre/pull/135#discussion_r152832821","pull_request_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/pulls/135","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/pulls/comments/152832821"},"html":{"href":"https://github.com/aceleradora-TW/conhecimento-livre/pull/135#discussion_r152832821"},"pull_request":{"href":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/pulls/135"}},"in_reply_to_id":152830603},"pull_request":{"url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/pulls/135","id":154369078,"html_url":"https://github.com/aceleradora-TW/conhecimento-livre/pull/135","diff_url":"https://github.com/aceleradora-TW/conhecimento-livre/pull/135.diff","patch_url":"https://github.com/aceleradora-TW/conhecimento-livre/pull/135.patch","issue_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/issues/135","number":135,"state":"open","locked":false,"title":"Adiciona icone no header","user":{"login":"MauricioSalin","id":13355144,"avatar_url":"https://avatars0.githubusercontent.com/u/13355144?v=4","gravatar_id":"","url":"https://api.github.com/users/MauricioSalin","html_url":"https://github.com/MauricioSalin","followers_url":"https://api.github.com/users/MauricioSalin/followers","following_url":"https://api.github.com/users/MauricioSalin/following{/other_user}","gists_url":"https://api.github.com/users/MauricioSalin/gists{/gist_id}","starred_url":"https://api.github.com/users/MauricioSalin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MauricioSalin/subscriptions","organizations_url":"https://api.github.com/users/MauricioSalin/orgs","repos_url":"https://api.github.com/users/MauricioSalin/repos","events_url":"https://api.github.com/users/MauricioSalin/events{/privacy}","received_events_url":"https://api.github.com/users/MauricioSalin/received_events","type":"User","site_admin":false},"body":"Adiciona icone no header do site.","created_at":"2017-11-23T12:50:02Z","updated_at":"2017-11-23T15:51:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea93269ae63f931f741f9f0ec56984ede6779bb0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/pulls/135/commits","review_comments_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/pulls/135/comments","review_comment_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/issues/135/comments","statuses_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/statuses/a54fecf419d294a5617325c043ddf53075a62519","head":{"label":"aceleradora-TW:adiciona-icone","ref":"adiciona-icone","sha":"a54fecf419d294a5617325c043ddf53075a62519","user":{"login":"aceleradora-TW","id":18720656,"avatar_url":"https://avatars0.githubusercontent.com/u/18720656?v=4","gravatar_id":"","url":"https://api.github.com/users/aceleradora-TW","html_url":"https://github.com/aceleradora-TW","followers_url":"https://api.github.com/users/aceleradora-TW/followers","following_url":"https://api.github.com/users/aceleradora-TW/following{/other_user}","gists_url":"https://api.github.com/users/aceleradora-TW/gists{/gist_id}","starred_url":"https://api.github.com/users/aceleradora-TW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aceleradora-TW/subscriptions","organizations_url":"https://api.github.com/users/aceleradora-TW/orgs","repos_url":"https://api.github.com/users/aceleradora-TW/repos","events_url":"https://api.github.com/users/aceleradora-TW/events{/privacy}","received_events_url":"https://api.github.com/users/aceleradora-TW/received_events","type":"Organization","site_admin":false},"repo":{"id":103977877,"name":"conhecimento-livre","full_name":"aceleradora-TW/conhecimento-livre","owner":{"login":"aceleradora-TW","id":18720656,"avatar_url":"https://avatars0.githubusercontent.com/u/18720656?v=4","gravatar_id":"","url":"https://api.github.com/users/aceleradora-TW","html_url":"https://github.com/aceleradora-TW","followers_url":"https://api.github.com/users/aceleradora-TW/followers","following_url":"https://api.github.com/users/aceleradora-TW/following{/other_user}","gists_url":"https://api.github.com/users/aceleradora-TW/gists{/gist_id}","starred_url":"https://api.github.com/users/aceleradora-TW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aceleradora-TW/subscriptions","organizations_url":"https://api.github.com/users/aceleradora-TW/orgs","repos_url":"https://api.github.com/users/aceleradora-TW/repos","events_url":"https://api.github.com/users/aceleradora-TW/events{/privacy}","received_events_url":"https://api.github.com/users/aceleradora-TW/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aceleradora-TW/conhecimento-livre","description":null,"fork":false,"url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre","forks_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/forks","keys_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/teams","hooks_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/hooks","issue_events_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/issues/events{/number}","events_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/events","assignees_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/assignees{/user}","branches_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/branches{/branch}","tags_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/tags","blobs_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/git/refs{/sha}","trees_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/statuses/{sha}","languages_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/languages","stargazers_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/stargazers","contributors_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/contributors","subscribers_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/subscribers","subscription_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/subscription","commits_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/commits{/sha}","git_commits_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/git/commits{/sha}","comments_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/comments{/number}","issue_comment_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/issues/comments{/number}","contents_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/contents/{+path}","compare_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/merges","archive_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/downloads","issues_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/issues{/number}","pulls_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/pulls{/number}","milestones_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/milestones{/number}","notifications_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/labels{/name}","releases_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/releases{/id}","deployments_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/deployments","created_at":"2017-09-18T18:43:45Z","updated_at":"2017-10-24T20:14:59Z","pushed_at":"2017-11-23T12:50:03Z","git_url":"git://github.com/aceleradora-TW/conhecimento-livre.git","ssh_url":"[email protected]:aceleradora-TW/conhecimento-livre.git","clone_url":"https://github.com/aceleradora-TW/conhecimento-livre.git","svn_url":"https://github.com/aceleradora-TW/conhecimento-livre","homepage":null,"size":27867,"stargazers_count":3,"watchers_count":3,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"aceleradora-TW:master","ref":"master","sha":"bede7377c3ed8937b03558c34a6d41072e76fa18","user":{"login":"aceleradora-TW","id":18720656,"avatar_url":"https://avatars0.githubusercontent.com/u/18720656?v=4","gravatar_id":"","url":"https://api.github.com/users/aceleradora-TW","html_url":"https://github.com/aceleradora-TW","followers_url":"https://api.github.com/users/aceleradora-TW/followers","following_url":"https://api.github.com/users/aceleradora-TW/following{/other_user}","gists_url":"https://api.github.com/users/aceleradora-TW/gists{/gist_id}","starred_url":"https://api.github.com/users/aceleradora-TW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aceleradora-TW/subscriptions","organizations_url":"https://api.github.com/users/aceleradora-TW/orgs","repos_url":"https://api.github.com/users/aceleradora-TW/repos","events_url":"https://api.github.com/users/aceleradora-TW/events{/privacy}","received_events_url":"https://api.github.com/users/aceleradora-TW/received_events","type":"Organization","site_admin":false},"repo":{"id":103977877,"name":"conhecimento-livre","full_name":"aceleradora-TW/conhecimento-livre","owner":{"login":"aceleradora-TW","id":18720656,"avatar_url":"https://avatars0.githubusercontent.com/u/18720656?v=4","gravatar_id":"","url":"https://api.github.com/users/aceleradora-TW","html_url":"https://github.com/aceleradora-TW","followers_url":"https://api.github.com/users/aceleradora-TW/followers","following_url":"https://api.github.com/users/aceleradora-TW/following{/other_user}","gists_url":"https://api.github.com/users/aceleradora-TW/gists{/gist_id}","starred_url":"https://api.github.com/users/aceleradora-TW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aceleradora-TW/subscriptions","organizations_url":"https://api.github.com/users/aceleradora-TW/orgs","repos_url":"https://api.github.com/users/aceleradora-TW/repos","events_url":"https://api.github.com/users/aceleradora-TW/events{/privacy}","received_events_url":"https://api.github.com/users/aceleradora-TW/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aceleradora-TW/conhecimento-livre","description":null,"fork":false,"url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre","forks_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/forks","keys_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/teams","hooks_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/hooks","issue_events_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/issues/events{/number}","events_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/events","assignees_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/assignees{/user}","branches_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/branches{/branch}","tags_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/tags","blobs_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/git/refs{/sha}","trees_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/statuses/{sha}","languages_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/languages","stargazers_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/stargazers","contributors_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/contributors","subscribers_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/subscribers","subscription_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/subscription","commits_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/commits{/sha}","git_commits_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/git/commits{/sha}","comments_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/comments{/number}","issue_comment_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/issues/comments{/number}","contents_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/contents/{+path}","compare_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/merges","archive_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/downloads","issues_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/issues{/number}","pulls_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/pulls{/number}","milestones_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/milestones{/number}","notifications_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/labels{/name}","releases_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/releases{/id}","deployments_url":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/deployments","created_at":"2017-09-18T18:43:45Z","updated_at":"2017-10-24T20:14:59Z","pushed_at":"2017-11-23T12:50:03Z","git_url":"git://github.com/aceleradora-TW/conhecimento-livre.git","ssh_url":"[email protected]:aceleradora-TW/conhecimento-livre.git","clone_url":"https://github.com/aceleradora-TW/conhecimento-livre.git","svn_url":"https://github.com/aceleradora-TW/conhecimento-livre","homepage":null,"size":27867,"stargazers_count":3,"watchers_count":3,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/pulls/135"},"html":{"href":"https://github.com/aceleradora-TW/conhecimento-livre/pull/135"},"issue":{"href":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/issues/135"},"comments":{"href":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/aceleradora-TW/conhecimento-livre/statuses/a54fecf419d294a5617325c043ddf53075a62519"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 103977877,
"name": "aceleradora-TW/conhecimento-livre",
"url": "https://api.github.com/repos/aceleradora-TW/conhecimento-livre"
}
|
{
"id": 13355144,
"login": "MauricioSalin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13355144?",
"url": "https://api.github.com/users/MauricioSalin"
}
|
{
"id": 18720656,
"login": "aceleradora-TW",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18720656?",
"url": "https://api.github.com/orgs/aceleradora-TW"
}
| 2017-11-23T15:51:33 |
6895992394
|
{"actor":{"display_login":"MauricioSalin"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/pulls/comments/131928714","pull_request_review_id":54955565,"id":131928714,"diff_hunk":"@@ -565,7 +565,7 @@ def create_user_annotations\n @options = load_cluster_group_options\n @notice = nil\n @alert = 'The following errors prevented the annotation from being saved: ' + @user_annotation.errors.full_messages.join(',')\n- logger.error \"#{Time.now}: Creating user annotation of params: #{user_annotation_params}, unable to save user annotation #{e.message}\"","path":"app/controllers/site_controller.rb","position":13,"original_position":13,"commit_id":"1415f0bcb0231adecb3ab8e51496da65334c9549","original_commit_id":"1415f0bcb0231adecb3ab8e51496da65334c9549","user":{"login":"bistline","id":729968,"avatar_url":"https://avatars0.githubusercontent.com/u/729968?v=4","gravatar_id":"","url":"https://api.github.com/users/bistline","html_url":"https://github.com/bistline","followers_url":"https://api.github.com/users/bistline/followers","following_url":"https://api.github.com/users/bistline/following{/other_user}","gists_url":"https://api.github.com/users/bistline/gists{/gist_id}","starred_url":"https://api.github.com/users/bistline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bistline/subscriptions","organizations_url":"https://api.github.com/users/bistline/orgs","repos_url":"https://api.github.com/users/bistline/repos","events_url":"https://api.github.com/users/bistline/events{/privacy}","received_events_url":"https://api.github.com/users/bistline/received_events","type":"User","site_admin":false},"body":"rather than just calling @user_annotation.errors, we should call @user_annotation.errors.full_messages.join(', ') so that it prints everything to the log (otherwise we just see an object and not the messages)","created_at":"2017-08-08T14:29:35Z","updated_at":"2017-08-08T14:29:35Z","html_url":"https://github.com/broadinstitute/single_cell_portal_core/pull/25#discussion_r131928714","pull_request_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/pulls/comments/131928714"},"html":{"href":"https://github.com/broadinstitute/single_cell_portal_core/pull/25#discussion_r131928714"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/pulls/25","id":134674217,"html_url":"https://github.com/broadinstitute/single_cell_portal_core/pull/25","diff_url":"https://github.com/broadinstitute/single_cell_portal_core/pull/25.diff","patch_url":"https://github.com/broadinstitute/single_cell_portal_core/pull/25.patch","issue_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/issues/25","number":25,"state":"open","locked":false,"title":"Yr last week","user":{"login":"YanayRosen","id":20192176,"avatar_url":"https://avatars3.githubusercontent.com/u/20192176?v=4","gravatar_id":"","url":"https://api.github.com/users/YanayRosen","html_url":"https://github.com/YanayRosen","followers_url":"https://api.github.com/users/YanayRosen/followers","following_url":"https://api.github.com/users/YanayRosen/following{/other_user}","gists_url":"https://api.github.com/users/YanayRosen/gists{/gist_id}","starred_url":"https://api.github.com/users/YanayRosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YanayRosen/subscriptions","organizations_url":"https://api.github.com/users/YanayRosen/orgs","repos_url":"https://api.github.com/users/YanayRosen/repos","events_url":"https://api.github.com/users/YanayRosen/events{/privacy}","received_events_url":"https://api.github.com/users/YanayRosen/received_events","type":"User","site_admin":false},"body":"Labels and errors changes","created_at":"2017-08-08T14:26:16Z","updated_at":"2017-08-08T14:29:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34fa567e26e1614b0a12036ab93da07283327f6f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/pulls/25/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/pulls/25/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/issues/25/comments","statuses_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/statuses/1415f0bcb0231adecb3ab8e51496da65334c9549","head":{"label":"broadinstitute:yr-last_week","ref":"yr-last_week","sha":"1415f0bcb0231adecb3ab8e51496da65334c9549","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":54125413,"name":"single_cell_portal_core","full_name":"broadinstitute/single_cell_portal_core","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/single_cell_portal_core","description":"Rails/Docker application for the Regev lab's single cell RNA-seq data portal","fork":false,"url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core","forks_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/forks","keys_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/teams","hooks_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/events","assignees_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/tags","blobs_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/subscription","commits_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/merges","archive_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/downloads","issues_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/deployments","created_at":"2016-03-17T14:40:51Z","updated_at":"2017-08-02T00:32:19Z","pushed_at":"2017-08-08T14:26:16Z","git_url":"git://github.com/broadinstitute/single_cell_portal_core.git","ssh_url":"[email protected]:broadinstitute/single_cell_portal_core.git","clone_url":"https://github.com/broadinstitute/single_cell_portal_core.git","svn_url":"https://github.com/broadinstitute/single_cell_portal_core","homepage":null,"size":3705,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"broadinstitute:development","ref":"development","sha":"49051f8115bbef5602d6582d593cb8c151445b0f","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":54125413,"name":"single_cell_portal_core","full_name":"broadinstitute/single_cell_portal_core","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/single_cell_portal_core","description":"Rails/Docker application for the Regev lab's single cell RNA-seq data portal","fork":false,"url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core","forks_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/forks","keys_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/teams","hooks_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/events","assignees_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/tags","blobs_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/subscription","commits_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/merges","archive_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/downloads","issues_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/deployments","created_at":"2016-03-17T14:40:51Z","updated_at":"2017-08-02T00:32:19Z","pushed_at":"2017-08-08T14:26:16Z","git_url":"git://github.com/broadinstitute/single_cell_portal_core.git","ssh_url":"[email protected]:broadinstitute/single_cell_portal_core.git","clone_url":"https://github.com/broadinstitute/single_cell_portal_core.git","svn_url":"https://github.com/broadinstitute/single_cell_portal_core","homepage":null,"size":3705,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/pulls/25"},"html":{"href":"https://github.com/broadinstitute/single_cell_portal_core/pull/25"},"issue":{"href":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/issues/25"},"comments":{"href":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/single_cell_portal_core/statuses/1415f0bcb0231adecb3ab8e51496da65334c9549"}}}}
|
{
"id": 54125413,
"name": "broadinstitute/single_cell_portal_core",
"url": "https://api.github.com/repos/broadinstitute/single_cell_portal_core"
}
|
{
"id": 729968,
"login": "bistline",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/729968?",
"url": "https://api.github.com/users/bistline"
}
|
{
"id": 393552,
"login": "broadinstitute",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/393552?",
"url": "https://api.github.com/orgs/broadinstitute"
}
| 2017-08-08T14:29:35 |
6416264050
|
{"actor":{"display_login":"bistline"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/gatk/pulls/comments/141401961","pull_request_review_id":65608034,"id":141401961,"diff_hunk":"@@ -21,7 +21,7 @@\n *\n * Created by tsato on 4/19/17.\n */\n-public class StrandArtifact extends GenotypeAnnotation implements StandardSomaticAnnotation {\n+public class StrandArtifact extends GenotypeAnnotation implements StandardSomaticAnnotation, StandardM2Annotation {","path":"src/main/java/org/broadinstitute/hellbender/tools/walkers/annotator/StrandArtifact.java","position":5,"original_position":5,"commit_id":"b5721e63e465c838c35c2f2b15f266e0ef513977","original_commit_id":"b5721e63e465c838c35c2f2b15f266e0ef513977","user":{"login":"davidbenjamin","id":8438890,"avatar_url":"https://avatars3.githubusercontent.com/u/8438890?v=4","gravatar_id":"","url":"https://api.github.com/users/davidbenjamin","html_url":"https://github.com/davidbenjamin","followers_url":"https://api.github.com/users/davidbenjamin/followers","following_url":"https://api.github.com/users/davidbenjamin/following{/other_user}","gists_url":"https://api.github.com/users/davidbenjamin/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbenjamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbenjamin/subscriptions","organizations_url":"https://api.github.com/users/davidbenjamin/orgs","repos_url":"https://api.github.com/users/davidbenjamin/repos","events_url":"https://api.github.com/users/davidbenjamin/events{/privacy}","received_events_url":"https://api.github.com/users/davidbenjamin/received_events","type":"User","site_admin":false},"body":"You can delete `StandardSomaticAnnotation` entirely and absorb implementing classes into `StandardM2Annotation`.","created_at":"2017-09-27T16:43:47Z","updated_at":"2017-09-27T16:46:03Z","html_url":"https://github.com/broadinstitute/gatk/pull/3621#discussion_r141401961","pull_request_url":"https://api.github.com/repos/broadinstitute/gatk/pulls/3621","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/gatk/pulls/comments/141401961"},"html":{"href":"https://github.com/broadinstitute/gatk/pull/3621#discussion_r141401961"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/gatk/pulls/3621"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/gatk/pulls/3621","id":143431096,"html_url":"https://github.com/broadinstitute/gatk/pull/3621","diff_url":"https://github.com/broadinstitute/gatk/pull/3621.diff","patch_url":"https://github.com/broadinstitute/gatk/pull/3621.patch","issue_url":"https://api.github.com/repos/broadinstitute/gatk/issues/3621","number":3621,"state":"open","locked":false,"title":"Created VariantAnnotationArgumentCollection and StandardM2Annotation classes","user":{"login":"jamesemery","id":16102845,"avatar_url":"https://avatars2.githubusercontent.com/u/16102845?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesemery","html_url":"https://github.com/jamesemery","followers_url":"https://api.github.com/users/jamesemery/followers","following_url":"https://api.github.com/users/jamesemery/following{/other_user}","gists_url":"https://api.github.com/users/jamesemery/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesemery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesemery/subscriptions","organizations_url":"https://api.github.com/users/jamesemery/orgs","repos_url":"https://api.github.com/users/jamesemery/repos","events_url":"https://api.github.com/users/jamesemery/events{/privacy}","received_events_url":"https://api.github.com/users/jamesemery/received_events","type":"User","site_admin":false},"body":"\r\nFixes #3618\r\nFixes #3292","created_at":"2017-09-27T15:49:40Z","updated_at":"2017-09-27T16:46:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1c105e86263def4186aae0f8d87d8eab924bb82","assignee":{"login":"droazen","id":798637,"avatar_url":"https://avatars0.githubusercontent.com/u/798637?v=4","gravatar_id":"","url":"https://api.github.com/users/droazen","html_url":"https://github.com/droazen","followers_url":"https://api.github.com/users/droazen/followers","following_url":"https://api.github.com/users/droazen/following{/other_user}","gists_url":"https://api.github.com/users/droazen/gists{/gist_id}","starred_url":"https://api.github.com/users/droazen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droazen/subscriptions","organizations_url":"https://api.github.com/users/droazen/orgs","repos_url":"https://api.github.com/users/droazen/repos","events_url":"https://api.github.com/users/droazen/events{/privacy}","received_events_url":"https://api.github.com/users/droazen/received_events","type":"User","site_admin":false},"assignees":[{"login":"droazen","id":798637,"avatar_url":"https://avatars0.githubusercontent.com/u/798637?v=4","gravatar_id":"","url":"https://api.github.com/users/droazen","html_url":"https://github.com/droazen","followers_url":"https://api.github.com/users/droazen/followers","following_url":"https://api.github.com/users/droazen/following{/other_user}","gists_url":"https://api.github.com/users/droazen/gists{/gist_id}","starred_url":"https://api.github.com/users/droazen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droazen/subscriptions","organizations_url":"https://api.github.com/users/droazen/orgs","repos_url":"https://api.github.com/users/droazen/repos","events_url":"https://api.github.com/users/droazen/events{/privacy}","received_events_url":"https://api.github.com/users/droazen/received_events","type":"User","site_admin":false},{"login":"davidbenjamin","id":8438890,"avatar_url":"https://avatars3.githubusercontent.com/u/8438890?v=4","gravatar_id":"","url":"https://api.github.com/users/davidbenjamin","html_url":"https://github.com/davidbenjamin","followers_url":"https://api.github.com/users/davidbenjamin/followers","following_url":"https://api.github.com/users/davidbenjamin/following{/other_user}","gists_url":"https://api.github.com/users/davidbenjamin/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbenjamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbenjamin/subscriptions","organizations_url":"https://api.github.com/users/davidbenjamin/orgs","repos_url":"https://api.github.com/users/davidbenjamin/repos","events_url":"https://api.github.com/users/davidbenjamin/events{/privacy}","received_events_url":"https://api.github.com/users/davidbenjamin/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"droazen","id":798637,"avatar_url":"https://avatars0.githubusercontent.com/u/798637?v=4","gravatar_id":"","url":"https://api.github.com/users/droazen","html_url":"https://github.com/droazen","followers_url":"https://api.github.com/users/droazen/followers","following_url":"https://api.github.com/users/droazen/following{/other_user}","gists_url":"https://api.github.com/users/droazen/gists{/gist_id}","starred_url":"https://api.github.com/users/droazen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droazen/subscriptions","organizations_url":"https://api.github.com/users/droazen/orgs","repos_url":"https://api.github.com/users/droazen/repos","events_url":"https://api.github.com/users/droazen/events{/privacy}","received_events_url":"https://api.github.com/users/droazen/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/gatk/pulls/3621/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/gatk/pulls/3621/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/gatk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/gatk/issues/3621/comments","statuses_url":"https://api.github.com/repos/broadinstitute/gatk/statuses/b5721e63e465c838c35c2f2b15f266e0ef513977","head":{"label":"broadinstitute:je_annotationArgumentCollection","ref":"je_annotationArgumentCollection","sha":"b5721e63e465c838c35c2f2b15f266e0ef513977","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":27452807,"name":"gatk","full_name":"broadinstitute/gatk","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/gatk","description":"Official code repository for GATK versions 4 and up","fork":false,"url":"https://api.github.com/repos/broadinstitute/gatk","forks_url":"https://api.github.com/repos/broadinstitute/gatk/forks","keys_url":"https://api.github.com/repos/broadinstitute/gatk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/gatk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/gatk/teams","hooks_url":"https://api.github.com/repos/broadinstitute/gatk/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/gatk/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/gatk/events","assignees_url":"https://api.github.com/repos/broadinstitute/gatk/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/gatk/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/gatk/tags","blobs_url":"https://api.github.com/repos/broadinstitute/gatk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/gatk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/gatk/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/gatk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/gatk/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/gatk/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/gatk/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/gatk/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/gatk/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/gatk/subscription","commits_url":"https://api.github.com/repos/broadinstitute/gatk/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/gatk/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/gatk/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/gatk/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/gatk/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/gatk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/gatk/merges","archive_url":"https://api.github.com/repos/broadinstitute/gatk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/gatk/downloads","issues_url":"https://api.github.com/repos/broadinstitute/gatk/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/gatk/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/gatk/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/gatk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/gatk/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/gatk/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/gatk/deployments","created_at":"2014-12-02T20:50:36Z","updated_at":"2017-09-27T13:33:30Z","pushed_at":"2017-09-27T15:49:41Z","git_url":"git://github.com/broadinstitute/gatk.git","ssh_url":"[email protected]:broadinstitute/gatk.git","clone_url":"https://github.com/broadinstitute/gatk.git","svn_url":"https://github.com/broadinstitute/gatk","homepage":"https://software.broadinstitute.org/gatk","size":143578,"stargazers_count":231,"watchers_count":231,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":789,"forks":86,"open_issues":789,"watchers":231,"default_branch":"master"}},"base":{"label":"broadinstitute:master","ref":"master","sha":"847048db7985db3d5fd2a0fdcd3398246635757b","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":27452807,"name":"gatk","full_name":"broadinstitute/gatk","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/gatk","description":"Official code repository for GATK versions 4 and up","fork":false,"url":"https://api.github.com/repos/broadinstitute/gatk","forks_url":"https://api.github.com/repos/broadinstitute/gatk/forks","keys_url":"https://api.github.com/repos/broadinstitute/gatk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/gatk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/gatk/teams","hooks_url":"https://api.github.com/repos/broadinstitute/gatk/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/gatk/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/gatk/events","assignees_url":"https://api.github.com/repos/broadinstitute/gatk/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/gatk/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/gatk/tags","blobs_url":"https://api.github.com/repos/broadinstitute/gatk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/gatk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/gatk/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/gatk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/gatk/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/gatk/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/gatk/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/gatk/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/gatk/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/gatk/subscription","commits_url":"https://api.github.com/repos/broadinstitute/gatk/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/gatk/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/gatk/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/gatk/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/gatk/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/gatk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/gatk/merges","archive_url":"https://api.github.com/repos/broadinstitute/gatk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/gatk/downloads","issues_url":"https://api.github.com/repos/broadinstitute/gatk/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/gatk/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/gatk/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/gatk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/gatk/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/gatk/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/gatk/deployments","created_at":"2014-12-02T20:50:36Z","updated_at":"2017-09-27T13:33:30Z","pushed_at":"2017-09-27T15:49:41Z","git_url":"git://github.com/broadinstitute/gatk.git","ssh_url":"[email protected]:broadinstitute/gatk.git","clone_url":"https://github.com/broadinstitute/gatk.git","svn_url":"https://github.com/broadinstitute/gatk","homepage":"https://software.broadinstitute.org/gatk","size":143578,"stargazers_count":231,"watchers_count":231,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":789,"forks":86,"open_issues":789,"watchers":231,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/gatk/pulls/3621"},"html":{"href":"https://github.com/broadinstitute/gatk/pull/3621"},"issue":{"href":"https://api.github.com/repos/broadinstitute/gatk/issues/3621"},"comments":{"href":"https://api.github.com/repos/broadinstitute/gatk/issues/3621/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/gatk/pulls/3621/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/gatk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/gatk/pulls/3621/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/gatk/statuses/b5721e63e465c838c35c2f2b15f266e0ef513977"}},"author_association":"COLLABORATOR"}}
|
{
"id": 27452807,
"name": "broadinstitute/gatk",
"url": "https://api.github.com/repos/broadinstitute/gatk"
}
|
{
"id": 8438890,
"login": "davidbenjamin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8438890?",
"url": "https://api.github.com/users/davidbenjamin"
}
|
{
"id": 393552,
"login": "broadinstitute",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/393552?",
"url": "https://api.github.com/orgs/broadinstitute"
}
| 2017-09-27T16:43:47 |
6645099768
|
{"actor":{"display_login":"davidbenjamin"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/picard/pulls/comments/151570144","pull_request_review_id":77302429,"id":151570144,"diff_hunk":"@@ -43,14 +45,16 @@\n import java.io.File;\n import java.util.List;\n \n+@DocumentedFeature\n+@BetaFeature\n @CommandLineProgramProperties(\n summary = CollectWgsMetricsWithNonZeroCoverage.USAGE_SUMMARY + CollectWgsMetricsWithNonZeroCoverage.USAGE_DETAILS,\n oneLineSummary = CollectWgsMetricsWithNonZeroCoverage.USAGE_SUMMARY,\n programGroup = Alpha.class\n )\n public class CollectWgsMetricsWithNonZeroCoverage extends CollectWgsMetrics {\n \n- static final String USAGE_SUMMARY = \"Collect metrics about coverage and performance of whole genome sequencing (WGS) experiments. \";\n+ static final String USAGE_SUMMARY = \"(Experimental) Collect metrics about coverage and performance of whole genome sequencing (WGS) experiments. \";","path":"src/main/java/picard/analysis/CollectWgsMetricsWithNonZeroCoverage.java","position":23,"original_position":23,"commit_id":"4d01d76f70b24b0ee89c019adec0de5ed2cfe6e3","original_commit_id":"4d01d76f70b24b0ee89c019adec0de5ed2cfe6e3","user":{"login":"sooheelee","id":11543866,"avatar_url":"https://avatars2.githubusercontent.com/u/11543866?v=4","gravatar_id":"","url":"https://api.github.com/users/sooheelee","html_url":"https://github.com/sooheelee","followers_url":"https://api.github.com/users/sooheelee/followers","following_url":"https://api.github.com/users/sooheelee/following{/other_user}","gists_url":"https://api.github.com/users/sooheelee/gists{/gist_id}","starred_url":"https://api.github.com/users/sooheelee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sooheelee/subscriptions","organizations_url":"https://api.github.com/users/sooheelee/orgs","repos_url":"https://api.github.com/users/sooheelee/repos","events_url":"https://api.github.com/users/sooheelee/events{/privacy}","received_events_url":"https://api.github.com/users/sooheelee/received_events","type":"User","site_admin":false},"body":"@cmnbroad is the barclay \"Experimental\" annotation going to be done in the next month or after the Jan 9 release?","created_at":"2017-11-16T23:48:57Z","updated_at":"2017-11-16T23:48:57Z","html_url":"https://github.com/broadinstitute/picard/pull/978#discussion_r151570144","pull_request_url":"https://api.github.com/repos/broadinstitute/picard/pulls/978","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/picard/pulls/comments/151570144"},"html":{"href":"https://github.com/broadinstitute/picard/pull/978#discussion_r151570144"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/picard/pulls/978"}},"in_reply_to_id":151549032},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/picard/pulls/978","id":153155245,"html_url":"https://github.com/broadinstitute/picard/pull/978","diff_url":"https://github.com/broadinstitute/picard/pull/978.diff","patch_url":"https://github.com/broadinstitute/picard/pull/978.patch","issue_url":"https://api.github.com/repos/broadinstitute/picard/issues/978","number":978,"state":"open","locked":false,"title":"Tag for 6 tools for documentation and add beta and experimental categorization to 3","user":{"login":"sooheelee","id":11543866,"avatar_url":"https://avatars2.githubusercontent.com/u/11543866?v=4","gravatar_id":"","url":"https://api.github.com/users/sooheelee","html_url":"https://github.com/sooheelee","followers_url":"https://api.github.com/users/sooheelee/followers","following_url":"https://api.github.com/users/sooheelee/following{/other_user}","gists_url":"https://api.github.com/users/sooheelee/gists{/gist_id}","starred_url":"https://api.github.com/users/sooheelee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sooheelee/subscriptions","organizations_url":"https://api.github.com/users/sooheelee/orgs","repos_url":"https://api.github.com/users/sooheelee/repos","events_url":"https://api.github.com/users/sooheelee/events{/privacy}","received_events_url":"https://api.github.com/users/sooheelee/received_events","type":"User","site_admin":false},"body":"### Description\r\nAdded `@DocumentedFeature` and `@BetaFeature` tags appropriately to six tool docs that were not showing up in gatkDocs. \r\n\r\n- Three tools categorized under \"Alpha Tools\" got the BETA and (Experimental) labels, consistent with how we treat GATK tools.\r\n- Two of these are deprecated tools.\r\n- One is a unit testing tool.\r\n\r\nIn https://github.com/broadinstitute/dsde-docs/issues/2639, @vdauwera asks that we tag _all_ tools for documentation.\r\n\r\nRelated issues:\r\nhttps://github.com/broadinstitute/gatk/issues/3847\r\nhttps://github.com/broadinstitute/gatk/pull/3850\r\n\r\n#### Content\r\n- [ ] Added or modified tests to cover changes and any new functionality\r\n- [x] Edited the README / documentation (if applicable)\r\n- [ ] All tests passing on Travis\r\n\r\n#### Review\r\n- [ ] Final thumbs-up from reviewer\r\n- [ ] Rebase, squash and reword as applicable\r\n\r\nFor more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests\r\n\r\n","created_at":"2017-11-16T21:29:51Z","updated_at":"2017-11-16T23:48:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4f0ec778fc01d276e651e9203c30ef51bc2755b","assignee":{"login":"sooheelee","id":11543866,"avatar_url":"https://avatars2.githubusercontent.com/u/11543866?v=4","gravatar_id":"","url":"https://api.github.com/users/sooheelee","html_url":"https://github.com/sooheelee","followers_url":"https://api.github.com/users/sooheelee/followers","following_url":"https://api.github.com/users/sooheelee/following{/other_user}","gists_url":"https://api.github.com/users/sooheelee/gists{/gist_id}","starred_url":"https://api.github.com/users/sooheelee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sooheelee/subscriptions","organizations_url":"https://api.github.com/users/sooheelee/orgs","repos_url":"https://api.github.com/users/sooheelee/repos","events_url":"https://api.github.com/users/sooheelee/events{/privacy}","received_events_url":"https://api.github.com/users/sooheelee/received_events","type":"User","site_admin":false},"assignees":[{"login":"sooheelee","id":11543866,"avatar_url":"https://avatars2.githubusercontent.com/u/11543866?v=4","gravatar_id":"","url":"https://api.github.com/users/sooheelee","html_url":"https://github.com/sooheelee","followers_url":"https://api.github.com/users/sooheelee/followers","following_url":"https://api.github.com/users/sooheelee/following{/other_user}","gists_url":"https://api.github.com/users/sooheelee/gists{/gist_id}","starred_url":"https://api.github.com/users/sooheelee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sooheelee/subscriptions","organizations_url":"https://api.github.com/users/sooheelee/orgs","repos_url":"https://api.github.com/users/sooheelee/repos","events_url":"https://api.github.com/users/sooheelee/events{/privacy}","received_events_url":"https://api.github.com/users/sooheelee/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"vdauwera","id":2748435,"avatar_url":"https://avatars3.githubusercontent.com/u/2748435?v=4","gravatar_id":"","url":"https://api.github.com/users/vdauwera","html_url":"https://github.com/vdauwera","followers_url":"https://api.github.com/users/vdauwera/followers","following_url":"https://api.github.com/users/vdauwera/following{/other_user}","gists_url":"https://api.github.com/users/vdauwera/gists{/gist_id}","starred_url":"https://api.github.com/users/vdauwera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdauwera/subscriptions","organizations_url":"https://api.github.com/users/vdauwera/orgs","repos_url":"https://api.github.com/users/vdauwera/repos","events_url":"https://api.github.com/users/vdauwera/events{/privacy}","received_events_url":"https://api.github.com/users/vdauwera/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/picard/pulls/978/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/picard/pulls/978/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/picard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/picard/issues/978/comments","statuses_url":"https://api.github.com/repos/broadinstitute/picard/statuses/4d01d76f70b24b0ee89c019adec0de5ed2cfe6e3","head":{"label":"broadinstitute:shl_doc_tagtool","ref":"shl_doc_tagtool","sha":"4d01d76f70b24b0ee89c019adec0de5ed2cfe6e3","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":18225913,"name":"picard","full_name":"broadinstitute/picard","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/picard","description":"A set of command line tools (in Java) for manipulating high-throughput sequencing (HTS) data and formats such as SAM/BAM/CRAM and VCF.","fork":false,"url":"https://api.github.com/repos/broadinstitute/picard","forks_url":"https://api.github.com/repos/broadinstitute/picard/forks","keys_url":"https://api.github.com/repos/broadinstitute/picard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/picard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/picard/teams","hooks_url":"https://api.github.com/repos/broadinstitute/picard/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/picard/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/picard/events","assignees_url":"https://api.github.com/repos/broadinstitute/picard/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/picard/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/picard/tags","blobs_url":"https://api.github.com/repos/broadinstitute/picard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/picard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/picard/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/picard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/picard/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/picard/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/picard/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/picard/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/picard/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/picard/subscription","commits_url":"https://api.github.com/repos/broadinstitute/picard/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/picard/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/picard/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/picard/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/picard/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/picard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/picard/merges","archive_url":"https://api.github.com/repos/broadinstitute/picard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/picard/downloads","issues_url":"https://api.github.com/repos/broadinstitute/picard/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/picard/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/picard/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/picard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/picard/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/picard/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/picard/deployments","created_at":"2014-03-28T20:43:35Z","updated_at":"2017-11-15T08:19:46Z","pushed_at":"2017-11-16T21:29:51Z","git_url":"git://github.com/broadinstitute/picard.git","ssh_url":"[email protected]:broadinstitute/picard.git","clone_url":"https://github.com/broadinstitute/picard.git","svn_url":"https://github.com/broadinstitute/picard","homepage":"http://broadinstitute.github.io/picard/","size":117210,"stargazers_count":328,"watchers_count":328,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":217,"mirror_url":null,"archived":false,"open_issues_count":104,"forks":217,"open_issues":104,"watchers":328,"default_branch":"master"}},"base":{"label":"broadinstitute:master","ref":"master","sha":"2a73bd4e082d810d11274f471ae4b89439396690","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":18225913,"name":"picard","full_name":"broadinstitute/picard","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/picard","description":"A set of command line tools (in Java) for manipulating high-throughput sequencing (HTS) data and formats such as SAM/BAM/CRAM and VCF.","fork":false,"url":"https://api.github.com/repos/broadinstitute/picard","forks_url":"https://api.github.com/repos/broadinstitute/picard/forks","keys_url":"https://api.github.com/repos/broadinstitute/picard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/picard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/picard/teams","hooks_url":"https://api.github.com/repos/broadinstitute/picard/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/picard/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/picard/events","assignees_url":"https://api.github.com/repos/broadinstitute/picard/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/picard/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/picard/tags","blobs_url":"https://api.github.com/repos/broadinstitute/picard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/picard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/picard/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/picard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/picard/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/picard/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/picard/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/picard/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/picard/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/picard/subscription","commits_url":"https://api.github.com/repos/broadinstitute/picard/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/picard/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/picard/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/picard/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/picard/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/picard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/picard/merges","archive_url":"https://api.github.com/repos/broadinstitute/picard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/picard/downloads","issues_url":"https://api.github.com/repos/broadinstitute/picard/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/picard/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/picard/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/picard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/picard/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/picard/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/picard/deployments","created_at":"2014-03-28T20:43:35Z","updated_at":"2017-11-15T08:19:46Z","pushed_at":"2017-11-16T21:29:51Z","git_url":"git://github.com/broadinstitute/picard.git","ssh_url":"[email protected]:broadinstitute/picard.git","clone_url":"https://github.com/broadinstitute/picard.git","svn_url":"https://github.com/broadinstitute/picard","homepage":"http://broadinstitute.github.io/picard/","size":117210,"stargazers_count":328,"watchers_count":328,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":217,"mirror_url":null,"archived":false,"open_issues_count":104,"forks":217,"open_issues":104,"watchers":328,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/picard/pulls/978"},"html":{"href":"https://github.com/broadinstitute/picard/pull/978"},"issue":{"href":"https://api.github.com/repos/broadinstitute/picard/issues/978"},"comments":{"href":"https://api.github.com/repos/broadinstitute/picard/issues/978/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/picard/pulls/978/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/picard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/picard/pulls/978/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/picard/statuses/4d01d76f70b24b0ee89c019adec0de5ed2cfe6e3"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 18225913,
"name": "broadinstitute/picard",
"url": "https://api.github.com/repos/broadinstitute/picard"
}
|
{
"id": 11543866,
"login": "sooheelee",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11543866?",
"url": "https://api.github.com/users/sooheelee"
}
|
{
"id": 393552,
"login": "broadinstitute",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/393552?",
"url": "https://api.github.com/orgs/broadinstitute"
}
| 2017-11-16T23:48:57 |
6867316879
|
{"actor":{"display_login":"sooheelee"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/gatk/pulls/comments/134795861","pull_request_review_id":58130556,"id":134795861,"diff_hunk":"@@ -57,31 +56,23 @@ private String getResourceDir(){\n \n @DataProvider(name = \"ReadsPipeline\")\n public Object[][] createReadsPipelineSparkTestData() {\n- final String GRCh37Ref_2021 = b37_reference_20_21;\n final String GRCh37Ref2bit_chr2021 = b37_2bit_reference_20_21;\n final String hiSeqBam_chr20 = getResourceDir() + \"CEUTrio.HiSeq.WGS.b37.ch20.1m-1m1k.NA12878.noMD.noBQSR.bam\";\n- final String hiSeqBam_chr20_queryNameSorted = getResourceDir() + \"CEUTrio.HiSeq.WGS.b37.ch20.1m-1m1k.NA12878.noMD.noBQSR.queryNameSorted.bam\";\n- final String hiSeqCram_chr20 = getResourceDir() + \"CEUTrio.HiSeq.WGS.b37.ch20.1m-1m1k.NA12878.noMD.noBQSR.cram\";\n final String dbSNPb37_20 = getResourceDir() + DBSNP_138_B37_CH20_1M_1M1K_VCF;\n final String more20Sites = getResourceDir() + \"dbsnp_138.b37.20.10m-10m100.vcf\"; //for testing 2 input files\n \n- final String expectedSingleKnownSites = \"expected.CEUTrio.HiSeq.WGS.b37.ch20.1m-1m1k.NA12878.noMD.noBQSR.md.bqsr.bam\";\n- final String expectedMultipleKnownSites = \"expected.MultiSite.reads.pipeline.bam\";\n- final String expectedMultipleKnownSitesCram = \"expected.MultiSite.reads.pipeline.cram\";\n+ final String expectedMultipleKnownSites = \"expected.MultiSite.reads.pipeline.vcf\";\n \n return new Object[][]{\n // input local, computation local.\n- //Note: these output files were created by running Picard 1.130 and GATK3.46","path":"src/test/java/org/broadinstitute/hellbender/tools/spark/pipelines/ReadsPipelineSparkIntegrationTest.java","position":32,"original_position":32,"commit_id":"1ccb9b3ba26282d2246e11448165f9df515cffdb","original_commit_id":"1ccb9b3ba26282d2246e11448165f9df515cffdb","user":{"login":"lbergelson","id":4700332,"avatar_url":"https://avatars3.githubusercontent.com/u/4700332?v=4","gravatar_id":"","url":"https://api.github.com/users/lbergelson","html_url":"https://github.com/lbergelson","followers_url":"https://api.github.com/users/lbergelson/followers","following_url":"https://api.github.com/users/lbergelson/following{/other_user}","gists_url":"https://api.github.com/users/lbergelson/gists{/gist_id}","starred_url":"https://api.github.com/users/lbergelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbergelson/subscriptions","organizations_url":"https://api.github.com/users/lbergelson/orgs","repos_url":"https://api.github.com/users/lbergelson/repos","events_url":"https://api.github.com/users/lbergelson/events{/privacy}","received_events_url":"https://api.github.com/users/lbergelson/received_events","type":"User","site_admin":false},"body":"I think it would be best if we could keep these tests, and just generate expected variant files from them. Ideally we could run them in a mode the produces a bam and variants so we can detect subtler changes that may not be reflected strongly in the variants. Why delete them all?\r\n","created_at":"2017-08-23T16:01:02Z","updated_at":"2017-08-23T16:01:02Z","html_url":"https://github.com/broadinstitute/gatk/pull/3452#discussion_r134795861","pull_request_url":"https://api.github.com/repos/broadinstitute/gatk/pulls/3452","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/gatk/pulls/comments/134795861"},"html":{"href":"https://github.com/broadinstitute/gatk/pull/3452#discussion_r134795861"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/gatk/pulls/3452"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/gatk/pulls/3452","id":136046061,"html_url":"https://github.com/broadinstitute/gatk/pull/3452","diff_url":"https://github.com/broadinstitute/gatk/pull/3452.diff","patch_url":"https://github.com/broadinstitute/gatk/pull/3452.patch","issue_url":"https://api.github.com/repos/broadinstitute/gatk/issues/3452","number":3452,"state":"open","locked":false,"title":"Extend ReadsPipelineSpark to run HaplotypeCallerSpark","user":{"login":"tomwhite","id":85085,"avatar_url":"https://avatars3.githubusercontent.com/u/85085?v=4","gravatar_id":"","url":"https://api.github.com/users/tomwhite","html_url":"https://github.com/tomwhite","followers_url":"https://api.github.com/users/tomwhite/followers","following_url":"https://api.github.com/users/tomwhite/following{/other_user}","gists_url":"https://api.github.com/users/tomwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwhite/subscriptions","organizations_url":"https://api.github.com/users/tomwhite/orgs","repos_url":"https://api.github.com/users/tomwhite/repos","events_url":"https://api.github.com/users/tomwhite/events{/privacy}","received_events_url":"https://api.github.com/users/tomwhite/received_events","type":"User","site_admin":false},"body":"Based on https://github.com/broadinstitute/gatk/pull/3106, so not ready to be merged until after that PR is in.","created_at":"2017-08-16T14:54:11Z","updated_at":"2017-08-23T16:01:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"530abd23ce40a011690fa229f694134294ed8815","assignee":{"login":"lbergelson","id":4700332,"avatar_url":"https://avatars3.githubusercontent.com/u/4700332?v=4","gravatar_id":"","url":"https://api.github.com/users/lbergelson","html_url":"https://github.com/lbergelson","followers_url":"https://api.github.com/users/lbergelson/followers","following_url":"https://api.github.com/users/lbergelson/following{/other_user}","gists_url":"https://api.github.com/users/lbergelson/gists{/gist_id}","starred_url":"https://api.github.com/users/lbergelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbergelson/subscriptions","organizations_url":"https://api.github.com/users/lbergelson/orgs","repos_url":"https://api.github.com/users/lbergelson/repos","events_url":"https://api.github.com/users/lbergelson/events{/privacy}","received_events_url":"https://api.github.com/users/lbergelson/received_events","type":"User","site_admin":false},"assignees":[{"login":"lbergelson","id":4700332,"avatar_url":"https://avatars3.githubusercontent.com/u/4700332?v=4","gravatar_id":"","url":"https://api.github.com/users/lbergelson","html_url":"https://github.com/lbergelson","followers_url":"https://api.github.com/users/lbergelson/followers","following_url":"https://api.github.com/users/lbergelson/following{/other_user}","gists_url":"https://api.github.com/users/lbergelson/gists{/gist_id}","starred_url":"https://api.github.com/users/lbergelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbergelson/subscriptions","organizations_url":"https://api.github.com/users/lbergelson/orgs","repos_url":"https://api.github.com/users/lbergelson/repos","events_url":"https://api.github.com/users/lbergelson/events{/privacy}","received_events_url":"https://api.github.com/users/lbergelson/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/gatk/pulls/3452/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/gatk/pulls/3452/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/gatk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/gatk/issues/3452/comments","statuses_url":"https://api.github.com/repos/broadinstitute/gatk/statuses/1ccb9b3ba26282d2246e11448165f9df515cffdb","head":{"label":"broadinstitute:tw_hc_genome_fixes_with_single_pipeline","ref":"tw_hc_genome_fixes_with_single_pipeline","sha":"1ccb9b3ba26282d2246e11448165f9df515cffdb","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":27452807,"name":"gatk","full_name":"broadinstitute/gatk","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/gatk","description":"Official code repository for GATK versions 4 and up","fork":false,"url":"https://api.github.com/repos/broadinstitute/gatk","forks_url":"https://api.github.com/repos/broadinstitute/gatk/forks","keys_url":"https://api.github.com/repos/broadinstitute/gatk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/gatk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/gatk/teams","hooks_url":"https://api.github.com/repos/broadinstitute/gatk/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/gatk/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/gatk/events","assignees_url":"https://api.github.com/repos/broadinstitute/gatk/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/gatk/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/gatk/tags","blobs_url":"https://api.github.com/repos/broadinstitute/gatk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/gatk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/gatk/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/gatk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/gatk/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/gatk/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/gatk/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/gatk/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/gatk/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/gatk/subscription","commits_url":"https://api.github.com/repos/broadinstitute/gatk/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/gatk/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/gatk/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/gatk/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/gatk/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/gatk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/gatk/merges","archive_url":"https://api.github.com/repos/broadinstitute/gatk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/gatk/downloads","issues_url":"https://api.github.com/repos/broadinstitute/gatk/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/gatk/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/gatk/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/gatk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/gatk/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/gatk/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/gatk/deployments","created_at":"2014-12-02T20:50:36Z","updated_at":"2017-08-23T13:32:55Z","pushed_at":"2017-08-23T15:34:59Z","git_url":"git://github.com/broadinstitute/gatk.git","ssh_url":"[email protected]:broadinstitute/gatk.git","clone_url":"https://github.com/broadinstitute/gatk.git","svn_url":"https://github.com/broadinstitute/gatk","homepage":"https://software.broadinstitute.org/gatk","size":139458,"stargazers_count":209,"watchers_count":209,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":781,"forks":78,"open_issues":781,"watchers":209,"default_branch":"master"}},"base":{"label":"broadinstitute:master","ref":"master","sha":"685913bf483f544f1e9a6ec999652376b522ac38","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":27452807,"name":"gatk","full_name":"broadinstitute/gatk","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/gatk","description":"Official code repository for GATK versions 4 and up","fork":false,"url":"https://api.github.com/repos/broadinstitute/gatk","forks_url":"https://api.github.com/repos/broadinstitute/gatk/forks","keys_url":"https://api.github.com/repos/broadinstitute/gatk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/gatk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/gatk/teams","hooks_url":"https://api.github.com/repos/broadinstitute/gatk/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/gatk/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/gatk/events","assignees_url":"https://api.github.com/repos/broadinstitute/gatk/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/gatk/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/gatk/tags","blobs_url":"https://api.github.com/repos/broadinstitute/gatk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/gatk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/gatk/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/gatk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/gatk/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/gatk/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/gatk/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/gatk/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/gatk/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/gatk/subscription","commits_url":"https://api.github.com/repos/broadinstitute/gatk/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/gatk/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/gatk/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/gatk/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/gatk/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/gatk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/gatk/merges","archive_url":"https://api.github.com/repos/broadinstitute/gatk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/gatk/downloads","issues_url":"https://api.github.com/repos/broadinstitute/gatk/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/gatk/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/gatk/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/gatk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/gatk/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/gatk/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/gatk/deployments","created_at":"2014-12-02T20:50:36Z","updated_at":"2017-08-23T13:32:55Z","pushed_at":"2017-08-23T15:34:59Z","git_url":"git://github.com/broadinstitute/gatk.git","ssh_url":"[email protected]:broadinstitute/gatk.git","clone_url":"https://github.com/broadinstitute/gatk.git","svn_url":"https://github.com/broadinstitute/gatk","homepage":"https://software.broadinstitute.org/gatk","size":139458,"stargazers_count":209,"watchers_count":209,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":781,"forks":78,"open_issues":781,"watchers":209,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/gatk/pulls/3452"},"html":{"href":"https://github.com/broadinstitute/gatk/pull/3452"},"issue":{"href":"https://api.github.com/repos/broadinstitute/gatk/issues/3452"},"comments":{"href":"https://api.github.com/repos/broadinstitute/gatk/issues/3452/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/gatk/pulls/3452/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/gatk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/gatk/pulls/3452/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/gatk/statuses/1ccb9b3ba26282d2246e11448165f9df515cffdb"}}}}
|
{
"id": 27452807,
"name": "broadinstitute/gatk",
"url": "https://api.github.com/repos/broadinstitute/gatk"
}
|
{
"id": 4700332,
"login": "lbergelson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4700332?",
"url": "https://api.github.com/users/lbergelson"
}
|
{
"id": 393552,
"login": "broadinstitute",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/393552?",
"url": "https://api.github.com/orgs/broadinstitute"
}
| 2017-08-23T16:01:02 |
6503202458
|
{"actor":{"display_login":"lbergelson"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/comments/136677789","pull_request_review_id":60256156,"id":136677789,"diff_hunk":"@@ -14,3 +21,12 @@ services:\n - \"3000:3000\"\n depends_on:\n - db","path":"docker-compose.yml","position":17,"original_position":17,"commit_id":"85be104d9a8cb73e64478fe609733a89d3a11497","original_commit_id":"85be104d9a8cb73e64478fe609733a89d3a11497","user":{"login":"ryanking","id":5640,"avatar_url":"https://avatars1.githubusercontent.com/u/5640?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanking","html_url":"https://github.com/ryanking","followers_url":"https://api.github.com/users/ryanking/followers","following_url":"https://api.github.com/users/ryanking/following{/other_user}","gists_url":"https://api.github.com/users/ryanking/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanking/subscriptions","organizations_url":"https://api.github.com/users/ryanking/orgs","repos_url":"https://api.github.com/users/ryanking/repos","events_url":"https://api.github.com/users/ryanking/events{/privacy}","received_events_url":"https://api.github.com/users/ryanking/received_events","type":"User","site_admin":false},"body":"doesn't web need to depend on redis too?","created_at":"2017-09-01T22:48:32Z","updated_at":"2017-09-01T22:49:00Z","html_url":"https://github.com/chanzuckerberg/idseq-web/pull/43#discussion_r136677789","pull_request_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/43","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/comments/136677789"},"html":{"href":"https://github.com/chanzuckerberg/idseq-web/pull/43#discussion_r136677789"},"pull_request":{"href":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/43","id":138985083,"html_url":"https://github.com/chanzuckerberg/idseq-web/pull/43","diff_url":"https://github.com/chanzuckerberg/idseq-web/pull/43.diff","patch_url":"https://github.com/chanzuckerberg/idseq-web/pull/43.patch","issue_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/issues/43","number":43,"state":"open","locked":false,"title":"resque setup","user":{"login":"yunfangjuan","id":1704002,"avatar_url":"https://avatars0.githubusercontent.com/u/1704002?v=4","gravatar_id":"","url":"https://api.github.com/users/yunfangjuan","html_url":"https://github.com/yunfangjuan","followers_url":"https://api.github.com/users/yunfangjuan/followers","following_url":"https://api.github.com/users/yunfangjuan/following{/other_user}","gists_url":"https://api.github.com/users/yunfangjuan/gists{/gist_id}","starred_url":"https://api.github.com/users/yunfangjuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunfangjuan/subscriptions","organizations_url":"https://api.github.com/users/yunfangjuan/orgs","repos_url":"https://api.github.com/users/yunfangjuan/repos","events_url":"https://api.github.com/users/yunfangjuan/events{/privacy}","received_events_url":"https://api.github.com/users/yunfangjuan/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-01T22:46:05Z","updated_at":"2017-09-01T22:49:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5aec7b9f85da61426a357263bdeb47021130ceab","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/43/commits","review_comments_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/43/comments","review_comment_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/issues/43/comments","statuses_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/statuses/85be104d9a8cb73e64478fe609733a89d3a11497","head":{"label":"chanzuckerberg:resque_setup","ref":"resque_setup","sha":"85be104d9a8cb73e64478fe609733a89d3a11497","user":{"login":"chanzuckerberg","id":19917299,"avatar_url":"https://avatars2.githubusercontent.com/u/19917299?v=4","gravatar_id":"","url":"https://api.github.com/users/chanzuckerberg","html_url":"https://github.com/chanzuckerberg","followers_url":"https://api.github.com/users/chanzuckerberg/followers","following_url":"https://api.github.com/users/chanzuckerberg/following{/other_user}","gists_url":"https://api.github.com/users/chanzuckerberg/gists{/gist_id}","starred_url":"https://api.github.com/users/chanzuckerberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chanzuckerberg/subscriptions","organizations_url":"https://api.github.com/users/chanzuckerberg/orgs","repos_url":"https://api.github.com/users/chanzuckerberg/repos","events_url":"https://api.github.com/users/chanzuckerberg/events{/privacy}","received_events_url":"https://api.github.com/users/chanzuckerberg/received_events","type":"Organization","site_admin":false},"repo":{"id":99148438,"name":"idseq-web","full_name":"chanzuckerberg/idseq-web","owner":{"login":"chanzuckerberg","id":19917299,"avatar_url":"https://avatars2.githubusercontent.com/u/19917299?v=4","gravatar_id":"","url":"https://api.github.com/users/chanzuckerberg","html_url":"https://github.com/chanzuckerberg","followers_url":"https://api.github.com/users/chanzuckerberg/followers","following_url":"https://api.github.com/users/chanzuckerberg/following{/other_user}","gists_url":"https://api.github.com/users/chanzuckerberg/gists{/gist_id}","starred_url":"https://api.github.com/users/chanzuckerberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chanzuckerberg/subscriptions","organizations_url":"https://api.github.com/users/chanzuckerberg/orgs","repos_url":"https://api.github.com/users/chanzuckerberg/repos","events_url":"https://api.github.com/users/chanzuckerberg/events{/privacy}","received_events_url":"https://api.github.com/users/chanzuckerberg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chanzuckerberg/idseq-web","description":null,"fork":false,"url":"https://api.github.com/repos/chanzuckerberg/idseq-web","forks_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/forks","keys_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/teams","hooks_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/hooks","issue_events_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/issues/events{/number}","events_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/events","assignees_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/assignees{/user}","branches_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/branches{/branch}","tags_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/tags","blobs_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/statuses/{sha}","languages_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/languages","stargazers_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/stargazers","contributors_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/contributors","subscribers_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/subscribers","subscription_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/subscription","commits_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/contents/{+path}","compare_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/merges","archive_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/downloads","issues_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/issues{/number}","pulls_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls{/number}","milestones_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/milestones{/number}","notifications_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/labels{/name}","releases_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/releases{/id}","deployments_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/deployments","created_at":"2017-08-02T18:24:03Z","updated_at":"2017-08-28T22:26:27Z","pushed_at":"2017-09-01T22:46:06Z","git_url":"git://github.com/chanzuckerberg/idseq-web.git","ssh_url":"[email protected]:chanzuckerberg/idseq-web.git","clone_url":"https://github.com/chanzuckerberg/idseq-web.git","svn_url":"https://github.com/chanzuckerberg/idseq-web","homepage":null,"size":197,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"chanzuckerberg:master","ref":"master","sha":"275fd3fd96d8751f887b17e2fb4c251f097a16d6","user":{"login":"chanzuckerberg","id":19917299,"avatar_url":"https://avatars2.githubusercontent.com/u/19917299?v=4","gravatar_id":"","url":"https://api.github.com/users/chanzuckerberg","html_url":"https://github.com/chanzuckerberg","followers_url":"https://api.github.com/users/chanzuckerberg/followers","following_url":"https://api.github.com/users/chanzuckerberg/following{/other_user}","gists_url":"https://api.github.com/users/chanzuckerberg/gists{/gist_id}","starred_url":"https://api.github.com/users/chanzuckerberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chanzuckerberg/subscriptions","organizations_url":"https://api.github.com/users/chanzuckerberg/orgs","repos_url":"https://api.github.com/users/chanzuckerberg/repos","events_url":"https://api.github.com/users/chanzuckerberg/events{/privacy}","received_events_url":"https://api.github.com/users/chanzuckerberg/received_events","type":"Organization","site_admin":false},"repo":{"id":99148438,"name":"idseq-web","full_name":"chanzuckerberg/idseq-web","owner":{"login":"chanzuckerberg","id":19917299,"avatar_url":"https://avatars2.githubusercontent.com/u/19917299?v=4","gravatar_id":"","url":"https://api.github.com/users/chanzuckerberg","html_url":"https://github.com/chanzuckerberg","followers_url":"https://api.github.com/users/chanzuckerberg/followers","following_url":"https://api.github.com/users/chanzuckerberg/following{/other_user}","gists_url":"https://api.github.com/users/chanzuckerberg/gists{/gist_id}","starred_url":"https://api.github.com/users/chanzuckerberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chanzuckerberg/subscriptions","organizations_url":"https://api.github.com/users/chanzuckerberg/orgs","repos_url":"https://api.github.com/users/chanzuckerberg/repos","events_url":"https://api.github.com/users/chanzuckerberg/events{/privacy}","received_events_url":"https://api.github.com/users/chanzuckerberg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chanzuckerberg/idseq-web","description":null,"fork":false,"url":"https://api.github.com/repos/chanzuckerberg/idseq-web","forks_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/forks","keys_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/teams","hooks_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/hooks","issue_events_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/issues/events{/number}","events_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/events","assignees_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/assignees{/user}","branches_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/branches{/branch}","tags_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/tags","blobs_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/statuses/{sha}","languages_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/languages","stargazers_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/stargazers","contributors_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/contributors","subscribers_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/subscribers","subscription_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/subscription","commits_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/contents/{+path}","compare_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/merges","archive_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/downloads","issues_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/issues{/number}","pulls_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls{/number}","milestones_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/milestones{/number}","notifications_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/labels{/name}","releases_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/releases{/id}","deployments_url":"https://api.github.com/repos/chanzuckerberg/idseq-web/deployments","created_at":"2017-08-02T18:24:03Z","updated_at":"2017-08-28T22:26:27Z","pushed_at":"2017-09-01T22:46:06Z","git_url":"git://github.com/chanzuckerberg/idseq-web.git","ssh_url":"[email protected]:chanzuckerberg/idseq-web.git","clone_url":"https://github.com/chanzuckerberg/idseq-web.git","svn_url":"https://github.com/chanzuckerberg/idseq-web","homepage":null,"size":197,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/43"},"html":{"href":"https://github.com/chanzuckerberg/idseq-web/pull/43"},"issue":{"href":"https://api.github.com/repos/chanzuckerberg/idseq-web/issues/43"},"comments":{"href":"https://api.github.com/repos/chanzuckerberg/idseq-web/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chanzuckerberg/idseq-web/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/chanzuckerberg/idseq-web/statuses/85be104d9a8cb73e64478fe609733a89d3a11497"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 99148438,
"name": "chanzuckerberg/idseq-web",
"url": "https://api.github.com/repos/chanzuckerberg/idseq-web"
}
|
{
"id": 5640,
"login": "ryanking",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5640?",
"url": "https://api.github.com/users/ryanking"
}
|
{
"id": 19917299,
"login": "chanzuckerberg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19917299?",
"url": "https://api.github.com/orgs/chanzuckerberg"
}
| 2017-09-01T22:48:32 |
6541918973
|
{"actor":{"display_login":"ryanking"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/comments/106594742","pull_request_review_id":27523770,"id":106594742,"diff_hunk":"@@ -127,16 +127,34 @@ def assertion():\n break\n else:\n self.fail('could not find expected message')\n- events = [e for e in events if\n- e.get('event_type', '').startswith('task_') or\n- e.get('event_type', '') == 'sending_task']\n- seen_current_retries = set()\n- for event in events:\n- current_retries = event['context']['task_current_retries']\n- seen_current_retries.add(current_retries)\n- total_retries = event['context']['task_total_retries']\n- self.assertEqual(total_retries, 5)\n- self.assertSetEqual(seen_current_retries, {0, 1, 2, 3})\n+\n+ # We're looking only at the events from the create operation\n+ retry_events = [e for e in events if e['context']['operation'] ==\n+ 'cloudify.interfaces.lifecycle.create']\n+ retry_events = sorted(retry_events, key=lambda e: e['timestamp'])\n+ self.assertTrue(len(retry_events), 12)\n+\n+ retries = 0\n+ for i in range(0, 10, 3): # Set the range's step to 3","path":"tests/integration_tests/tests/agentless_tests/test_task_retries.py","position":null,"original_position":22,"commit_id":"b37433b946ed8d22dd5215a6b80d9600c7e5f69e","original_commit_id":"9d52bbd50e8200ce8442f48913dbec756883e09f","user":{"login":"mcouthon","id":844807,"avatar_url":"https://avatars1.githubusercontent.com/u/844807?v=3","gravatar_id":"","url":"https://api.github.com/users/mcouthon","html_url":"https://github.com/mcouthon","followers_url":"https://api.github.com/users/mcouthon/followers","following_url":"https://api.github.com/users/mcouthon/following{/other_user}","gists_url":"https://api.github.com/users/mcouthon/gists{/gist_id}","starred_url":"https://api.github.com/users/mcouthon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcouthon/subscriptions","organizations_url":"https://api.github.com/users/mcouthon/orgs","repos_url":"https://api.github.com/users/mcouthon/repos","events_url":"https://api.github.com/users/mcouthon/events{/privacy}","received_events_url":"https://api.github.com/users/mcouthon/received_events","type":"User","site_admin":false},"body":"@tehasdf where do you find this stuff? :)","created_at":"2017-03-17T07:16:13Z","updated_at":"2017-03-17T07:16:13Z","html_url":"https://github.com/cloudify-cosmo/cloudify-manager/pull/771#discussion_r106594742","pull_request_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/771","_links":{"self":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/comments/106594742"},"html":{"href":"https://github.com/cloudify-cosmo/cloudify-manager/pull/771#discussion_r106594742"},"pull_request":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/771"}}},"pull_request":{"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/771","id":111065359,"html_url":"https://github.com/cloudify-cosmo/cloudify-manager/pull/771","diff_url":"https://github.com/cloudify-cosmo/cloudify-manager/pull/771.diff","patch_url":"https://github.com/cloudify-cosmo/cloudify-manager/pull/771.patch","issue_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/issues/771","number":771,"state":"open","locked":false,"title":"CFY-6572 Fix the operation retries integration test","user":{"login":"mcouthon","id":844807,"avatar_url":"https://avatars1.githubusercontent.com/u/844807?v=3","gravatar_id":"","url":"https://api.github.com/users/mcouthon","html_url":"https://github.com/mcouthon","followers_url":"https://api.github.com/users/mcouthon/followers","following_url":"https://api.github.com/users/mcouthon/following{/other_user}","gists_url":"https://api.github.com/users/mcouthon/gists{/gist_id}","starred_url":"https://api.github.com/users/mcouthon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcouthon/subscriptions","organizations_url":"https://api.github.com/users/mcouthon/orgs","repos_url":"https://api.github.com/users/mcouthon/repos","events_url":"https://api.github.com/users/mcouthon/events{/privacy}","received_events_url":"https://api.github.com/users/mcouthon/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-03-16T13:17:58Z","updated_at":"2017-03-17T07:16:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c44de886700394d81235cc0a74c494989929b3e0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/771/commits","review_comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/771/comments","review_comment_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/issues/771/comments","statuses_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/statuses/b37433b946ed8d22dd5215a6b80d9600c7e5f69e","head":{"label":"cloudify-cosmo:CFY-6572-fix-operation-retries-integration-test","ref":"CFY-6572-fix-operation-retries-integration-test","sha":"b37433b946ed8d22dd5215a6b80d9600c7e5f69e","user":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars0.githubusercontent.com/u/6260555?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"repo":{"id":18326574,"name":"cloudify-manager","full_name":"cloudify-cosmo/cloudify-manager","owner":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars0.githubusercontent.com/u/6260555?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudify-cosmo/cloudify-manager","description":"Cloudify's manager related code","fork":false,"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager","forks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/forks","keys_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/teams","hooks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/hooks","issue_events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/issues/events{/number}","events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/events","assignees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/assignees{/user}","branches_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/branches{/branch}","tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/tags","blobs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/languages","stargazers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/stargazers","contributors_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/contributors","subscribers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/subscribers","subscription_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/subscription","commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/contents/{+path}","compare_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/merges","archive_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/downloads","issues_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/issues{/number}","pulls_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/labels{/name}","releases_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/releases{/id}","deployments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/deployments","created_at":"2014-04-01T11:06:47Z","updated_at":"2017-03-12T13:13:19Z","pushed_at":"2017-03-16T19:12:07Z","git_url":"git://github.com/cloudify-cosmo/cloudify-manager.git","ssh_url":"[email protected]:cloudify-cosmo/cloudify-manager.git","clone_url":"https://github.com/cloudify-cosmo/cloudify-manager.git","svn_url":"https://github.com/cloudify-cosmo/cloudify-manager","homepage":null,"size":14572,"stargazers_count":40,"watchers_count":40,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"open_issues_count":32,"forks":39,"open_issues":32,"watchers":40,"default_branch":"master"}},"base":{"label":"cloudify-cosmo:master","ref":"master","sha":"73da2e1056480194ffdca8c57e01cdb7e2207604","user":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars0.githubusercontent.com/u/6260555?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"repo":{"id":18326574,"name":"cloudify-manager","full_name":"cloudify-cosmo/cloudify-manager","owner":{"login":"cloudify-cosmo","id":6260555,"avatar_url":"https://avatars0.githubusercontent.com/u/6260555?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudify-cosmo","html_url":"https://github.com/cloudify-cosmo","followers_url":"https://api.github.com/users/cloudify-cosmo/followers","following_url":"https://api.github.com/users/cloudify-cosmo/following{/other_user}","gists_url":"https://api.github.com/users/cloudify-cosmo/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudify-cosmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudify-cosmo/subscriptions","organizations_url":"https://api.github.com/users/cloudify-cosmo/orgs","repos_url":"https://api.github.com/users/cloudify-cosmo/repos","events_url":"https://api.github.com/users/cloudify-cosmo/events{/privacy}","received_events_url":"https://api.github.com/users/cloudify-cosmo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudify-cosmo/cloudify-manager","description":"Cloudify's manager related code","fork":false,"url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager","forks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/forks","keys_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/teams","hooks_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/hooks","issue_events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/issues/events{/number}","events_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/events","assignees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/assignees{/user}","branches_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/branches{/branch}","tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/tags","blobs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/languages","stargazers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/stargazers","contributors_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/contributors","subscribers_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/subscribers","subscription_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/subscription","commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/contents/{+path}","compare_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/merges","archive_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/downloads","issues_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/issues{/number}","pulls_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/labels{/name}","releases_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/releases{/id}","deployments_url":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/deployments","created_at":"2014-04-01T11:06:47Z","updated_at":"2017-03-12T13:13:19Z","pushed_at":"2017-03-16T19:12:07Z","git_url":"git://github.com/cloudify-cosmo/cloudify-manager.git","ssh_url":"[email protected]:cloudify-cosmo/cloudify-manager.git","clone_url":"https://github.com/cloudify-cosmo/cloudify-manager.git","svn_url":"https://github.com/cloudify-cosmo/cloudify-manager","homepage":null,"size":14572,"stargazers_count":40,"watchers_count":40,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"open_issues_count":32,"forks":39,"open_issues":32,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/771"},"html":{"href":"https://github.com/cloudify-cosmo/cloudify-manager/pull/771"},"issue":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/issues/771"},"comments":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/issues/771/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/771/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/pulls/771/commits"},"statuses":{"href":"https://api.github.com/repos/cloudify-cosmo/cloudify-manager/statuses/b37433b946ed8d22dd5215a6b80d9600c7e5f69e"}}}}
|
{
"id": 18326574,
"name": "cloudify-cosmo/cloudify-manager",
"url": "https://api.github.com/repos/cloudify-cosmo/cloudify-manager"
}
|
{
"id": 844807,
"login": "mcouthon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/844807?",
"url": "https://api.github.com/users/mcouthon"
}
|
{
"id": 6260555,
"login": "cloudify-cosmo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6260555?",
"url": "https://api.github.com/orgs/cloudify-cosmo"
}
| 2017-03-17T07:16:13 |
5511871413
|
{"actor":{"display_login":"mcouthon"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls/comments/144091724","pull_request_review_id":68700352,"id":144091724,"diff_hunk":"@@ -9,24 +9,28 @@\n \n <div class=\"form-card\">\n <header class=\"form-card__header\">\n- <div class=\"form-card__title\">Before we get started, do you currently reside in Michigan?</div>\n+ <div class=\"form-card__title\">\n+ Before we get started, do you currently reside in Michigan?\n+ </div>\n+\n <p class=\"text--help text--centered\">\n- If not, we'll help point you in the right direction. However, this application for health coverage is specifically for current residents of Michigan.\n+ If not, we'll help point you in the right direction. However, this\n+ application for health coverage is specifically for current residents of\n+ Michigan.\n </p>\n </header>\n \n- <div class=\"form-card__content\">\n- <!-- Replace with partial -->\n- <footer class=\"form-card__buttons\">\n- <a href=\"/pages/medicaid/intro_location_help\" class=\"button button--nav button--full-width\">\n- No\n- </a>\n+ <%= form_for @step,\n+ as: :step,\n+ builder: MbFormBuilder,\n+ url: current_path,\n+ method: :put do |f| %>\n \n- <a href=\"/pages/medicaid/intro_name\" class=\"button button--nav button--cta button--full-width\">\n- Yes\n- </a>\n- </footer>\n- </div>\n-</div>\n+ <div class=\"form-card__content\">\n+ <footer class=\"form-card__buttons\">\n+ <%= f.mb_boolean_buttons :michigan_resident %>","path":"app/views/medicaid/intro_location/edit.html.erb","position":37,"original_position":37,"commit_id":"f943f5fb69241235cef1ef1116e57d58f08a7e94","original_commit_id":"f943f5fb69241235cef1ef1116e57d58f08a7e94","user":{"login":"jessieay","id":601515,"avatar_url":"https://avatars0.githubusercontent.com/u/601515?v=4","gravatar_id":"","url":"https://api.github.com/users/jessieay","html_url":"https://github.com/jessieay","followers_url":"https://api.github.com/users/jessieay/followers","following_url":"https://api.github.com/users/jessieay/following{/other_user}","gists_url":"https://api.github.com/users/jessieay/gists{/gist_id}","starred_url":"https://api.github.com/users/jessieay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessieay/subscriptions","organizations_url":"https://api.github.com/users/jessieay/orgs","repos_url":"https://api.github.com/users/jessieay/repos","events_url":"https://api.github.com/users/jessieay/events{/privacy}","received_events_url":"https://api.github.com/users/jessieay/received_events","type":"User","site_admin":false},"body":"beauty! 🌹 ","created_at":"2017-10-11T18:09:48Z","updated_at":"2017-10-11T18:10:28Z","html_url":"https://github.com/codeforamerica/michigan-benefits/pull/321#discussion_r144091724","pull_request_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls/321","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls/comments/144091724"},"html":{"href":"https://github.com/codeforamerica/michigan-benefits/pull/321#discussion_r144091724"},"pull_request":{"href":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls/321"}}},"pull_request":{"url":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls/321","id":146015267,"html_url":"https://github.com/codeforamerica/michigan-benefits/pull/321","diff_url":"https://github.com/codeforamerica/michigan-benefits/pull/321.diff","patch_url":"https://github.com/codeforamerica/michigan-benefits/pull/321.patch","issue_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/issues/321","number":321,"state":"open","locked":false,"title":"Add medicaid_application model & integrate with the form object","user":{"login":"jayroh","id":28194,"avatar_url":"https://avatars1.githubusercontent.com/u/28194?v=4","gravatar_id":"","url":"https://api.github.com/users/jayroh","html_url":"https://github.com/jayroh","followers_url":"https://api.github.com/users/jayroh/followers","following_url":"https://api.github.com/users/jayroh/following{/other_user}","gists_url":"https://api.github.com/users/jayroh/gists{/gist_id}","starred_url":"https://api.github.com/users/jayroh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayroh/subscriptions","organizations_url":"https://api.github.com/users/jayroh/orgs","repos_url":"https://api.github.com/users/jayroh/repos","events_url":"https://api.github.com/users/jayroh/events{/privacy}","received_events_url":"https://api.github.com/users/jayroh/received_events","type":"User","site_admin":false},"body":" Medicaid information must be stored, of course, so this commit\r\n introduces that first migration and model to get things started.\r\n\r\n In addition, an update to the form builder here allows us to abstract\r\n the common pattern of the \"yes\" and \"no\" buttons on the Medicaid side of\r\n the application. Clicking one or the other will pass the boolean value\r\n to the update action, as well as allowing us to determine which page is\r\n the next page for either option.","created_at":"2017-10-11T17:37:54Z","updated_at":"2017-10-11T18:10:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46317ce25a8c10d14e6e7fda4cc0b8445e89528b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls/321/commits","review_comments_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls/321/comments","review_comment_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/issues/321/comments","statuses_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/statuses/f943f5fb69241235cef1ef1116e57d58f08a7e94","head":{"label":"codeforamerica:jro-medicaid-application","ref":"jro-medicaid-application","sha":"f943f5fb69241235cef1ef1116e57d58f08a7e94","user":{"login":"codeforamerica","id":337792,"avatar_url":"https://avatars2.githubusercontent.com/u/337792?v=4","gravatar_id":"","url":"https://api.github.com/users/codeforamerica","html_url":"https://github.com/codeforamerica","followers_url":"https://api.github.com/users/codeforamerica/followers","following_url":"https://api.github.com/users/codeforamerica/following{/other_user}","gists_url":"https://api.github.com/users/codeforamerica/gists{/gist_id}","starred_url":"https://api.github.com/users/codeforamerica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeforamerica/subscriptions","organizations_url":"https://api.github.com/users/codeforamerica/orgs","repos_url":"https://api.github.com/users/codeforamerica/repos","events_url":"https://api.github.com/users/codeforamerica/events{/privacy}","received_events_url":"https://api.github.com/users/codeforamerica/received_events","type":"Organization","site_admin":false},"repo":{"id":83607937,"name":"michigan-benefits","full_name":"codeforamerica/michigan-benefits","owner":{"login":"codeforamerica","id":337792,"avatar_url":"https://avatars2.githubusercontent.com/u/337792?v=4","gravatar_id":"","url":"https://api.github.com/users/codeforamerica","html_url":"https://github.com/codeforamerica","followers_url":"https://api.github.com/users/codeforamerica/followers","following_url":"https://api.github.com/users/codeforamerica/following{/other_user}","gists_url":"https://api.github.com/users/codeforamerica/gists{/gist_id}","starred_url":"https://api.github.com/users/codeforamerica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeforamerica/subscriptions","organizations_url":"https://api.github.com/users/codeforamerica/orgs","repos_url":"https://api.github.com/users/codeforamerica/repos","events_url":"https://api.github.com/users/codeforamerica/events{/privacy}","received_events_url":"https://api.github.com/users/codeforamerica/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codeforamerica/michigan-benefits","description":"Digital Assister for Michigan","fork":false,"url":"https://api.github.com/repos/codeforamerica/michigan-benefits","forks_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/forks","keys_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/teams","hooks_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/hooks","issue_events_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/issues/events{/number}","events_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/events","assignees_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/assignees{/user}","branches_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/branches{/branch}","tags_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/tags","blobs_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/git/refs{/sha}","trees_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/statuses/{sha}","languages_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/languages","stargazers_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/stargazers","contributors_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/contributors","subscribers_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/subscribers","subscription_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/subscription","commits_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/commits{/sha}","git_commits_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/git/commits{/sha}","comments_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/comments{/number}","issue_comment_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/issues/comments{/number}","contents_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/contents/{+path}","compare_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/merges","archive_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/downloads","issues_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/issues{/number}","pulls_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls{/number}","milestones_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/milestones{/number}","notifications_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/labels{/name}","releases_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/releases{/id}","deployments_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/deployments","created_at":"2017-03-01T22:24:46Z","updated_at":"2017-10-06T23:39:23Z","pushed_at":"2017-10-11T18:06:02Z","git_url":"git://github.com/codeforamerica/michigan-benefits.git","ssh_url":"[email protected]:codeforamerica/michigan-benefits.git","clone_url":"https://github.com/codeforamerica/michigan-benefits.git","svn_url":"https://github.com/codeforamerica/michigan-benefits","homepage":"","size":7858,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":5,"default_branch":"master"}},"base":{"label":"codeforamerica:master","ref":"master","sha":"4b610b5c448f02927231c10293bcf3bf3f22ddd8","user":{"login":"codeforamerica","id":337792,"avatar_url":"https://avatars2.githubusercontent.com/u/337792?v=4","gravatar_id":"","url":"https://api.github.com/users/codeforamerica","html_url":"https://github.com/codeforamerica","followers_url":"https://api.github.com/users/codeforamerica/followers","following_url":"https://api.github.com/users/codeforamerica/following{/other_user}","gists_url":"https://api.github.com/users/codeforamerica/gists{/gist_id}","starred_url":"https://api.github.com/users/codeforamerica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeforamerica/subscriptions","organizations_url":"https://api.github.com/users/codeforamerica/orgs","repos_url":"https://api.github.com/users/codeforamerica/repos","events_url":"https://api.github.com/users/codeforamerica/events{/privacy}","received_events_url":"https://api.github.com/users/codeforamerica/received_events","type":"Organization","site_admin":false},"repo":{"id":83607937,"name":"michigan-benefits","full_name":"codeforamerica/michigan-benefits","owner":{"login":"codeforamerica","id":337792,"avatar_url":"https://avatars2.githubusercontent.com/u/337792?v=4","gravatar_id":"","url":"https://api.github.com/users/codeforamerica","html_url":"https://github.com/codeforamerica","followers_url":"https://api.github.com/users/codeforamerica/followers","following_url":"https://api.github.com/users/codeforamerica/following{/other_user}","gists_url":"https://api.github.com/users/codeforamerica/gists{/gist_id}","starred_url":"https://api.github.com/users/codeforamerica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeforamerica/subscriptions","organizations_url":"https://api.github.com/users/codeforamerica/orgs","repos_url":"https://api.github.com/users/codeforamerica/repos","events_url":"https://api.github.com/users/codeforamerica/events{/privacy}","received_events_url":"https://api.github.com/users/codeforamerica/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codeforamerica/michigan-benefits","description":"Digital Assister for Michigan","fork":false,"url":"https://api.github.com/repos/codeforamerica/michigan-benefits","forks_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/forks","keys_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/teams","hooks_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/hooks","issue_events_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/issues/events{/number}","events_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/events","assignees_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/assignees{/user}","branches_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/branches{/branch}","tags_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/tags","blobs_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/git/refs{/sha}","trees_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/statuses/{sha}","languages_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/languages","stargazers_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/stargazers","contributors_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/contributors","subscribers_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/subscribers","subscription_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/subscription","commits_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/commits{/sha}","git_commits_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/git/commits{/sha}","comments_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/comments{/number}","issue_comment_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/issues/comments{/number}","contents_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/contents/{+path}","compare_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/merges","archive_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/downloads","issues_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/issues{/number}","pulls_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls{/number}","milestones_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/milestones{/number}","notifications_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/labels{/name}","releases_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/releases{/id}","deployments_url":"https://api.github.com/repos/codeforamerica/michigan-benefits/deployments","created_at":"2017-03-01T22:24:46Z","updated_at":"2017-10-06T23:39:23Z","pushed_at":"2017-10-11T18:06:02Z","git_url":"git://github.com/codeforamerica/michigan-benefits.git","ssh_url":"[email protected]:codeforamerica/michigan-benefits.git","clone_url":"https://github.com/codeforamerica/michigan-benefits.git","svn_url":"https://github.com/codeforamerica/michigan-benefits","homepage":"","size":7858,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls/321"},"html":{"href":"https://github.com/codeforamerica/michigan-benefits/pull/321"},"issue":{"href":"https://api.github.com/repos/codeforamerica/michigan-benefits/issues/321"},"comments":{"href":"https://api.github.com/repos/codeforamerica/michigan-benefits/issues/321/comments"},"review_comments":{"href":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls/321/comments"},"review_comment":{"href":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codeforamerica/michigan-benefits/pulls/321/commits"},"statuses":{"href":"https://api.github.com/repos/codeforamerica/michigan-benefits/statuses/f943f5fb69241235cef1ef1116e57d58f08a7e94"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 83607937,
"name": "codeforamerica/michigan-benefits",
"url": "https://api.github.com/repos/codeforamerica/michigan-benefits"
}
|
{
"id": 601515,
"login": "jessieay",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/601515?",
"url": "https://api.github.com/users/jessieay"
}
|
{
"id": 337792,
"login": "codeforamerica",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/337792?",
"url": "https://api.github.com/orgs/codeforamerica"
}
| 2017-10-11T18:09:48 |
6704001795
|
{"actor":{"display_login":"jessieay"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/drupalcommerce/commerce/pulls/comments/103143829","pull_request_review_id":23920376,"id":103143829,"diff_hunk":"@@ -84,6 +91,80 @@ public static function processForm(array $element, FormStateInterface $form_stat\n }\n \n $element['#profile'] = $element['#default_value'];\n+ $pane_id = $element['#name'];\n+ $mode = 'view';\n+\n+ $profile_selection_parents = $element['#parents'];\n+ $profile_selection_parents[] = 'profile_selection';\n+ $profile_id = $form_state->getValue($profile_selection_parents);\n+ $storage = $form_state->getStorage();\n+ $bundle = $element['#profile']->bundle();\n+ // User is adding a new profile.\n+ if ($profile_id && $profile_id == 'new_address') {\n+ $mode = 'new';\n+ unset($storage['pane_' . $pane_id]);\n+ }\n+ // If an AJAX rebuild happened, we might have our data in form state.\n+ elseif (!empty($storage['pane_' . $pane_id])) {\n+ $profile = $storage['pane_' . $pane_id]['profile'];\n+ $mode = $storage['pane_' . $pane_id]['mode'];\n+ $bundle = $profile->bundle();\n+ }\n+\n+ $ajax_wrapper_id = Html::getUniqueId('profile-select-ajax-wrapper');\n+ // Prefix and suffix used for Ajax replacement.\n+ $element['#prefix'] = '<div id=\"' . $ajax_wrapper_id . '\">';\n+ $element['#suffix'] = '</div>';\n+\n+ // Fetch all profiles of the user for an addressbook functionality.\n+ $profile_uid = $element['#profile']->getOwnerId();\n+ // Anonymous users don't get an addressbook.\n+ if ($profile_uid) {\n+ $default_profile_id = '';\n+ $profile_ids = \\Drupal::service('entity.query')\n+ ->get('profile')\n+ ->condition('uid', $profile_uid)\n+ ->condition('type', $bundle)\n+ ->condition('status', TRUE)\n+ ->sort('profile_id', 'DESC')\n+ ->execute();\n+ $profiles = Profile::loadMultiple($profile_ids);\n+ $profile_options = [];\n+ /** @var Profile $profile_option */\n+ foreach ($profiles as $profile_option) {\n+ if (empty($default_profile_id)) {\n+ $default_profile_id = $profile_option->id();\n+ $default_profile = $profile_option;\n+ }\n+ $profile_options[$profile_option->id()] = $profile_option->label();\n+ }\n+ $profile_options['new_address'] = t('+ Enter a new address');","path":"modules/order/src/Element/ProfileSelect.php","position":75,"original_position":75,"commit_id":"49f1c46a4501f571c7b36511de886dbbd4cfcb2c","original_commit_id":"49f1c46a4501f571c7b36511de886dbbd4cfcb2c","user":{"login":"czigor","id":648581,"avatar_url":"https://avatars.githubusercontent.com/u/648581?v=3","gravatar_id":"","url":"https://api.github.com/users/czigor","html_url":"https://github.com/czigor","followers_url":"https://api.github.com/users/czigor/followers","following_url":"https://api.github.com/users/czigor/following{/other_user}","gists_url":"https://api.github.com/users/czigor/gists{/gist_id}","starred_url":"https://api.github.com/users/czigor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czigor/subscriptions","organizations_url":"https://api.github.com/users/czigor/orgs","repos_url":"https://api.github.com/users/czigor/repos","events_url":"https://api.github.com/users/czigor/events{/privacy}","received_events_url":"https://api.github.com/users/czigor/received_events","type":"User","site_admin":false},"body":"Yes, this enables us to include/exclude + in the translation.","created_at":"2017-02-27T06:45:02Z","updated_at":"2017-02-27T06:45:02Z","html_url":"https://github.com/drupalcommerce/commerce/pull/631#discussion_r103143829","pull_request_url":"https://api.github.com/repos/drupalcommerce/commerce/pulls/631","_links":{"self":{"href":"https://api.github.com/repos/drupalcommerce/commerce/pulls/comments/103143829"},"html":{"href":"https://github.com/drupalcommerce/commerce/pull/631#discussion_r103143829"},"pull_request":{"href":"https://api.github.com/repos/drupalcommerce/commerce/pulls/631"}}},"pull_request":{"url":"https://api.github.com/repos/drupalcommerce/commerce/pulls/631","id":105048269,"html_url":"https://github.com/drupalcommerce/commerce/pull/631","diff_url":"https://github.com/drupalcommerce/commerce/pull/631.diff","patch_url":"https://github.com/drupalcommerce/commerce/pull/631.patch","issue_url":"https://api.github.com/repos/drupalcommerce/commerce/issues/631","number":631,"state":"open","locked":false,"title":"Profile selection","user":{"login":"czigor","id":648581,"avatar_url":"https://avatars.githubusercontent.com/u/648581?v=3","gravatar_id":"","url":"https://api.github.com/users/czigor","html_url":"https://github.com/czigor","followers_url":"https://api.github.com/users/czigor/followers","following_url":"https://api.github.com/users/czigor/following{/other_user}","gists_url":"https://api.github.com/users/czigor/gists{/gist_id}","starred_url":"https://api.github.com/users/czigor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czigor/subscriptions","organizations_url":"https://api.github.com/users/czigor/orgs","repos_url":"https://api.github.com/users/czigor/repos","events_url":"https://api.github.com/users/czigor/events{/privacy}","received_events_url":"https://api.github.com/users/czigor/received_events","type":"User","site_admin":false},"body":"Tests are still needed. \r\nhttps://www.drupal.org/node/2844920","created_at":"2017-02-07T16:58:03Z","updated_at":"2017-02-27T06:45:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c018f985684a90e54eaf50cd4e3c2ad956f3dbc3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/drupalcommerce/commerce/pulls/631/commits","review_comments_url":"https://api.github.com/repos/drupalcommerce/commerce/pulls/631/comments","review_comment_url":"https://api.github.com/repos/drupalcommerce/commerce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/drupalcommerce/commerce/issues/631/comments","statuses_url":"https://api.github.com/repos/drupalcommerce/commerce/statuses/49f1c46a4501f571c7b36511de886dbbd4cfcb2c","head":{"label":"czigor:2844920-profile-selection","ref":"2844920-profile-selection","sha":"49f1c46a4501f571c7b36511de886dbbd4cfcb2c","user":{"login":"czigor","id":648581,"avatar_url":"https://avatars.githubusercontent.com/u/648581?v=3","gravatar_id":"","url":"https://api.github.com/users/czigor","html_url":"https://github.com/czigor","followers_url":"https://api.github.com/users/czigor/followers","following_url":"https://api.github.com/users/czigor/following{/other_user}","gists_url":"https://api.github.com/users/czigor/gists{/gist_id}","starred_url":"https://api.github.com/users/czigor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czigor/subscriptions","organizations_url":"https://api.github.com/users/czigor/orgs","repos_url":"https://api.github.com/users/czigor/repos","events_url":"https://api.github.com/users/czigor/events{/privacy}","received_events_url":"https://api.github.com/users/czigor/received_events","type":"User","site_admin":false},"repo":{"id":44681611,"name":"commerce","full_name":"czigor/commerce","owner":{"login":"czigor","id":648581,"avatar_url":"https://avatars.githubusercontent.com/u/648581?v=3","gravatar_id":"","url":"https://api.github.com/users/czigor","html_url":"https://github.com/czigor","followers_url":"https://api.github.com/users/czigor/followers","following_url":"https://api.github.com/users/czigor/following{/other_user}","gists_url":"https://api.github.com/users/czigor/gists{/gist_id}","starred_url":"https://api.github.com/users/czigor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/czigor/subscriptions","organizations_url":"https://api.github.com/users/czigor/orgs","repos_url":"https://api.github.com/users/czigor/repos","events_url":"https://api.github.com/users/czigor/events{/privacy}","received_events_url":"https://api.github.com/users/czigor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/czigor/commerce","description":"Drupal Commerce 8.x-2.x development","fork":true,"url":"https://api.github.com/repos/czigor/commerce","forks_url":"https://api.github.com/repos/czigor/commerce/forks","keys_url":"https://api.github.com/repos/czigor/commerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/czigor/commerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/czigor/commerce/teams","hooks_url":"https://api.github.com/repos/czigor/commerce/hooks","issue_events_url":"https://api.github.com/repos/czigor/commerce/issues/events{/number}","events_url":"https://api.github.com/repos/czigor/commerce/events","assignees_url":"https://api.github.com/repos/czigor/commerce/assignees{/user}","branches_url":"https://api.github.com/repos/czigor/commerce/branches{/branch}","tags_url":"https://api.github.com/repos/czigor/commerce/tags","blobs_url":"https://api.github.com/repos/czigor/commerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/czigor/commerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/czigor/commerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/czigor/commerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/czigor/commerce/statuses/{sha}","languages_url":"https://api.github.com/repos/czigor/commerce/languages","stargazers_url":"https://api.github.com/repos/czigor/commerce/stargazers","contributors_url":"https://api.github.com/repos/czigor/commerce/contributors","subscribers_url":"https://api.github.com/repos/czigor/commerce/subscribers","subscription_url":"https://api.github.com/repos/czigor/commerce/subscription","commits_url":"https://api.github.com/repos/czigor/commerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/czigor/commerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/czigor/commerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/czigor/commerce/issues/comments{/number}","contents_url":"https://api.github.com/repos/czigor/commerce/contents/{+path}","compare_url":"https://api.github.com/repos/czigor/commerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/czigor/commerce/merges","archive_url":"https://api.github.com/repos/czigor/commerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/czigor/commerce/downloads","issues_url":"https://api.github.com/repos/czigor/commerce/issues{/number}","pulls_url":"https://api.github.com/repos/czigor/commerce/pulls{/number}","milestones_url":"https://api.github.com/repos/czigor/commerce/milestones{/number}","notifications_url":"https://api.github.com/repos/czigor/commerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/czigor/commerce/labels{/name}","releases_url":"https://api.github.com/repos/czigor/commerce/releases{/id}","deployments_url":"https://api.github.com/repos/czigor/commerce/deployments","created_at":"2015-10-21T14:23:58Z","updated_at":"2016-07-29T12:43:55Z","pushed_at":"2017-02-20T15:27:30Z","git_url":"git://github.com/czigor/commerce.git","ssh_url":"[email protected]:czigor/commerce.git","clone_url":"https://github.com/czigor/commerce.git","svn_url":"https://github.com/czigor/commerce","homepage":null,"size":2979,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"8.x-2.x"}},"base":{"label":"drupalcommerce:8.x-2.x","ref":"8.x-2.x","sha":"a7d02d792779fd647c21ce02493d20b0c77d0ae7","user":{"login":"drupalcommerce","id":183176,"avatar_url":"https://avatars.githubusercontent.com/u/183176?v=3","gravatar_id":"","url":"https://api.github.com/users/drupalcommerce","html_url":"https://github.com/drupalcommerce","followers_url":"https://api.github.com/users/drupalcommerce/followers","following_url":"https://api.github.com/users/drupalcommerce/following{/other_user}","gists_url":"https://api.github.com/users/drupalcommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/drupalcommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drupalcommerce/subscriptions","organizations_url":"https://api.github.com/users/drupalcommerce/orgs","repos_url":"https://api.github.com/users/drupalcommerce/repos","events_url":"https://api.github.com/users/drupalcommerce/events{/privacy}","received_events_url":"https://api.github.com/users/drupalcommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":21392057,"name":"commerce","full_name":"drupalcommerce/commerce","owner":{"login":"drupalcommerce","id":183176,"avatar_url":"https://avatars.githubusercontent.com/u/183176?v=3","gravatar_id":"","url":"https://api.github.com/users/drupalcommerce","html_url":"https://github.com/drupalcommerce","followers_url":"https://api.github.com/users/drupalcommerce/followers","following_url":"https://api.github.com/users/drupalcommerce/following{/other_user}","gists_url":"https://api.github.com/users/drupalcommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/drupalcommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drupalcommerce/subscriptions","organizations_url":"https://api.github.com/users/drupalcommerce/orgs","repos_url":"https://api.github.com/users/drupalcommerce/repos","events_url":"https://api.github.com/users/drupalcommerce/events{/privacy}","received_events_url":"https://api.github.com/users/drupalcommerce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/drupalcommerce/commerce","description":"Commerce 2.x development","fork":false,"url":"https://api.github.com/repos/drupalcommerce/commerce","forks_url":"https://api.github.com/repos/drupalcommerce/commerce/forks","keys_url":"https://api.github.com/repos/drupalcommerce/commerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drupalcommerce/commerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drupalcommerce/commerce/teams","hooks_url":"https://api.github.com/repos/drupalcommerce/commerce/hooks","issue_events_url":"https://api.github.com/repos/drupalcommerce/commerce/issues/events{/number}","events_url":"https://api.github.com/repos/drupalcommerce/commerce/events","assignees_url":"https://api.github.com/repos/drupalcommerce/commerce/assignees{/user}","branches_url":"https://api.github.com/repos/drupalcommerce/commerce/branches{/branch}","tags_url":"https://api.github.com/repos/drupalcommerce/commerce/tags","blobs_url":"https://api.github.com/repos/drupalcommerce/commerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drupalcommerce/commerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drupalcommerce/commerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/drupalcommerce/commerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drupalcommerce/commerce/statuses/{sha}","languages_url":"https://api.github.com/repos/drupalcommerce/commerce/languages","stargazers_url":"https://api.github.com/repos/drupalcommerce/commerce/stargazers","contributors_url":"https://api.github.com/repos/drupalcommerce/commerce/contributors","subscribers_url":"https://api.github.com/repos/drupalcommerce/commerce/subscribers","subscription_url":"https://api.github.com/repos/drupalcommerce/commerce/subscription","commits_url":"https://api.github.com/repos/drupalcommerce/commerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/drupalcommerce/commerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/drupalcommerce/commerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/drupalcommerce/commerce/issues/comments{/number}","contents_url":"https://api.github.com/repos/drupalcommerce/commerce/contents/{+path}","compare_url":"https://api.github.com/repos/drupalcommerce/commerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drupalcommerce/commerce/merges","archive_url":"https://api.github.com/repos/drupalcommerce/commerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drupalcommerce/commerce/downloads","issues_url":"https://api.github.com/repos/drupalcommerce/commerce/issues{/number}","pulls_url":"https://api.github.com/repos/drupalcommerce/commerce/pulls{/number}","milestones_url":"https://api.github.com/repos/drupalcommerce/commerce/milestones{/number}","notifications_url":"https://api.github.com/repos/drupalcommerce/commerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drupalcommerce/commerce/labels{/name}","releases_url":"https://api.github.com/repos/drupalcommerce/commerce/releases{/id}","deployments_url":"https://api.github.com/repos/drupalcommerce/commerce/deployments","created_at":"2014-07-01T15:05:51Z","updated_at":"2017-02-24T15:31:09Z","pushed_at":"2017-02-26T12:52:39Z","git_url":"git://github.com/drupalcommerce/commerce.git","ssh_url":"[email protected]:drupalcommerce/commerce.git","clone_url":"https://github.com/drupalcommerce/commerce.git","svn_url":"https://github.com/drupalcommerce/commerce","homepage":"https://drupal.org/project/commerce","size":5203,"stargazers_count":238,"watchers_count":238,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":159,"mirror_url":null,"open_issues_count":47,"forks":159,"open_issues":47,"watchers":238,"default_branch":"8.x-2.x"}},"_links":{"self":{"href":"https://api.github.com/repos/drupalcommerce/commerce/pulls/631"},"html":{"href":"https://github.com/drupalcommerce/commerce/pull/631"},"issue":{"href":"https://api.github.com/repos/drupalcommerce/commerce/issues/631"},"comments":{"href":"https://api.github.com/repos/drupalcommerce/commerce/issues/631/comments"},"review_comments":{"href":"https://api.github.com/repos/drupalcommerce/commerce/pulls/631/comments"},"review_comment":{"href":"https://api.github.com/repos/drupalcommerce/commerce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/drupalcommerce/commerce/pulls/631/commits"},"statuses":{"href":"https://api.github.com/repos/drupalcommerce/commerce/statuses/49f1c46a4501f571c7b36511de886dbbd4cfcb2c"}}}}
|
{
"id": 21392057,
"name": "drupalcommerce/commerce",
"url": "https://api.github.com/repos/drupalcommerce/commerce"
}
|
{
"id": 648581,
"login": "czigor",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/648581?",
"url": "https://api.github.com/users/czigor"
}
|
{
"id": 183176,
"login": "drupalcommerce",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/183176?",
"url": "https://api.github.com/orgs/drupalcommerce"
}
| 2017-02-27T06:45:02 |
5395014654
|
{"actor":{"display_login":"czigor"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/foam-framework/foam2/pulls/comments/125745078","pull_request_review_id":48164976,"id":125745078,"diff_hunk":"@@ -0,0 +1,34 @@\n+/**\n+ * @license\n+ * Copyright 2017 The FOAM Authors. All Rights Reserved.\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ */\n+\n+package foam.core;\n+\n+import javax.xml.stream.XMLStreamReader;\n+import java.util.Date;\n+\n+public abstract class AbstractDatePropertyInfo\n+ extends AbstractPropertyInfo","path":"src/foam/core/AbstractDatePropertyInfo.java","position":13,"original_position":13,"commit_id":"04467cc8b0a34b3c587ab26f4e119ba4db95b6ca","original_commit_id":"04467cc8b0a34b3c587ab26f4e119ba4db95b6ca","user":{"login":"kgrgreer","id":7460787,"avatar_url":"https://avatars0.githubusercontent.com/u/7460787?v=3","gravatar_id":"","url":"https://api.github.com/users/kgrgreer","html_url":"https://github.com/kgrgreer","followers_url":"https://api.github.com/users/kgrgreer/followers","following_url":"https://api.github.com/users/kgrgreer/following{/other_user}","gists_url":"https://api.github.com/users/kgrgreer/gists{/gist_id}","starred_url":"https://api.github.com/users/kgrgreer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgrgreer/subscriptions","organizations_url":"https://api.github.com/users/kgrgreer/orgs","repos_url":"https://api.github.com/users/kgrgreer/repos","events_url":"https://api.github.com/users/kgrgreer/events{/privacy}","received_events_url":"https://api.github.com/users/kgrgreer/received_events","type":"User","site_admin":false},"body":"indent 2 spaces","created_at":"2017-07-05T20:12:21Z","updated_at":"2017-07-05T20:12:21Z","html_url":"https://github.com/foam-framework/foam2/pull/454#discussion_r125745078","pull_request_url":"https://api.github.com/repos/foam-framework/foam2/pulls/454","_links":{"self":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/comments/125745078"},"html":{"href":"https://github.com/foam-framework/foam2/pull/454#discussion_r125745078"},"pull_request":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/454"}}},"pull_request":{"url":"https://api.github.com/repos/foam-framework/foam2/pulls/454","id":125671942,"html_url":"https://github.com/foam-framework/foam2/pull/454","diff_url":"https://github.com/foam-framework/foam2/pull/454.diff","patch_url":"https://github.com/foam-framework/foam2/pull/454.patch","issue_url":"https://api.github.com/repos/foam-framework/foam2/issues/454","number":454,"state":"open","locked":false,"title":"Added XMLDAO and XMLSupport with necessary modifications","user":{"login":"pavneetskapoor","id":12050663,"avatar_url":"https://avatars1.githubusercontent.com/u/12050663?v=3","gravatar_id":"","url":"https://api.github.com/users/pavneetskapoor","html_url":"https://github.com/pavneetskapoor","followers_url":"https://api.github.com/users/pavneetskapoor/followers","following_url":"https://api.github.com/users/pavneetskapoor/following{/other_user}","gists_url":"https://api.github.com/users/pavneetskapoor/gists{/gist_id}","starred_url":"https://api.github.com/users/pavneetskapoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavneetskapoor/subscriptions","organizations_url":"https://api.github.com/users/pavneetskapoor/orgs","repos_url":"https://api.github.com/users/pavneetskapoor/repos","events_url":"https://api.github.com/users/pavneetskapoor/events{/privacy}","received_events_url":"https://api.github.com/users/pavneetskapoor/received_events","type":"User","site_admin":false},"body":"- Created XMLDAO and XMLSupport for writing from FObject to XML and vice versa\r\n- Modified foam.core.Date and foam.core.DateTime to incorporate various date formats in the future. \r\n For now, it is set to ISO8601. Property for these types is called `dateFormat`","created_at":"2017-06-14T19:15:08Z","updated_at":"2017-07-05T20:12:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8eaca9e88e7d1801b987377abea56a5c4b598a71","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/foam-framework/foam2/pulls/454/commits","review_comments_url":"https://api.github.com/repos/foam-framework/foam2/pulls/454/comments","review_comment_url":"https://api.github.com/repos/foam-framework/foam2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/foam-framework/foam2/issues/454/comments","statuses_url":"https://api.github.com/repos/foam-framework/foam2/statuses/04467cc8b0a34b3c587ab26f4e119ba4db95b6ca","head":{"label":"pavneetskapoor:master","ref":"master","sha":"04467cc8b0a34b3c587ab26f4e119ba4db95b6ca","user":{"login":"pavneetskapoor","id":12050663,"avatar_url":"https://avatars1.githubusercontent.com/u/12050663?v=3","gravatar_id":"","url":"https://api.github.com/users/pavneetskapoor","html_url":"https://github.com/pavneetskapoor","followers_url":"https://api.github.com/users/pavneetskapoor/followers","following_url":"https://api.github.com/users/pavneetskapoor/following{/other_user}","gists_url":"https://api.github.com/users/pavneetskapoor/gists{/gist_id}","starred_url":"https://api.github.com/users/pavneetskapoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavneetskapoor/subscriptions","organizations_url":"https://api.github.com/users/pavneetskapoor/orgs","repos_url":"https://api.github.com/users/pavneetskapoor/repos","events_url":"https://api.github.com/users/pavneetskapoor/events{/privacy}","received_events_url":"https://api.github.com/users/pavneetskapoor/received_events","type":"User","site_admin":false},"repo":{"id":90903413,"name":"foam2","full_name":"pavneetskapoor/foam2","owner":{"login":"pavneetskapoor","id":12050663,"avatar_url":"https://avatars1.githubusercontent.com/u/12050663?v=3","gravatar_id":"","url":"https://api.github.com/users/pavneetskapoor","html_url":"https://github.com/pavneetskapoor","followers_url":"https://api.github.com/users/pavneetskapoor/followers","following_url":"https://api.github.com/users/pavneetskapoor/following{/other_user}","gists_url":"https://api.github.com/users/pavneetskapoor/gists{/gist_id}","starred_url":"https://api.github.com/users/pavneetskapoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavneetskapoor/subscriptions","organizations_url":"https://api.github.com/users/pavneetskapoor/orgs","repos_url":"https://api.github.com/users/pavneetskapoor/repos","events_url":"https://api.github.com/users/pavneetskapoor/events{/privacy}","received_events_url":"https://api.github.com/users/pavneetskapoor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pavneetskapoor/foam2","description":"FOAM: Feature-Oriented Active Modeller, Version 2","fork":true,"url":"https://api.github.com/repos/pavneetskapoor/foam2","forks_url":"https://api.github.com/repos/pavneetskapoor/foam2/forks","keys_url":"https://api.github.com/repos/pavneetskapoor/foam2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pavneetskapoor/foam2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pavneetskapoor/foam2/teams","hooks_url":"https://api.github.com/repos/pavneetskapoor/foam2/hooks","issue_events_url":"https://api.github.com/repos/pavneetskapoor/foam2/issues/events{/number}","events_url":"https://api.github.com/repos/pavneetskapoor/foam2/events","assignees_url":"https://api.github.com/repos/pavneetskapoor/foam2/assignees{/user}","branches_url":"https://api.github.com/repos/pavneetskapoor/foam2/branches{/branch}","tags_url":"https://api.github.com/repos/pavneetskapoor/foam2/tags","blobs_url":"https://api.github.com/repos/pavneetskapoor/foam2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pavneetskapoor/foam2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pavneetskapoor/foam2/git/refs{/sha}","trees_url":"https://api.github.com/repos/pavneetskapoor/foam2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pavneetskapoor/foam2/statuses/{sha}","languages_url":"https://api.github.com/repos/pavneetskapoor/foam2/languages","stargazers_url":"https://api.github.com/repos/pavneetskapoor/foam2/stargazers","contributors_url":"https://api.github.com/repos/pavneetskapoor/foam2/contributors","subscribers_url":"https://api.github.com/repos/pavneetskapoor/foam2/subscribers","subscription_url":"https://api.github.com/repos/pavneetskapoor/foam2/subscription","commits_url":"https://api.github.com/repos/pavneetskapoor/foam2/commits{/sha}","git_commits_url":"https://api.github.com/repos/pavneetskapoor/foam2/git/commits{/sha}","comments_url":"https://api.github.com/repos/pavneetskapoor/foam2/comments{/number}","issue_comment_url":"https://api.github.com/repos/pavneetskapoor/foam2/issues/comments{/number}","contents_url":"https://api.github.com/repos/pavneetskapoor/foam2/contents/{+path}","compare_url":"https://api.github.com/repos/pavneetskapoor/foam2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pavneetskapoor/foam2/merges","archive_url":"https://api.github.com/repos/pavneetskapoor/foam2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pavneetskapoor/foam2/downloads","issues_url":"https://api.github.com/repos/pavneetskapoor/foam2/issues{/number}","pulls_url":"https://api.github.com/repos/pavneetskapoor/foam2/pulls{/number}","milestones_url":"https://api.github.com/repos/pavneetskapoor/foam2/milestones{/number}","notifications_url":"https://api.github.com/repos/pavneetskapoor/foam2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pavneetskapoor/foam2/labels{/name}","releases_url":"https://api.github.com/repos/pavneetskapoor/foam2/releases{/id}","deployments_url":"https://api.github.com/repos/pavneetskapoor/foam2/deployments","created_at":"2017-05-10T20:01:02Z","updated_at":"2017-05-10T20:01:05Z","pushed_at":"2017-07-05T16:54:31Z","git_url":"git://github.com/pavneetskapoor/foam2.git","ssh_url":"[email protected]:pavneetskapoor/foam2.git","clone_url":"https://github.com/pavneetskapoor/foam2.git","svn_url":"https://github.com/pavneetskapoor/foam2","homepage":"","size":9932,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"foam-framework:master","ref":"master","sha":"ff73798a7aaa4905daf412a6841314b24da84f1a","user":{"login":"foam-framework","id":7460756,"avatar_url":"https://avatars2.githubusercontent.com/u/7460756?v=3","gravatar_id":"","url":"https://api.github.com/users/foam-framework","html_url":"https://github.com/foam-framework","followers_url":"https://api.github.com/users/foam-framework/followers","following_url":"https://api.github.com/users/foam-framework/following{/other_user}","gists_url":"https://api.github.com/users/foam-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/foam-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foam-framework/subscriptions","organizations_url":"https://api.github.com/users/foam-framework/orgs","repos_url":"https://api.github.com/users/foam-framework/repos","events_url":"https://api.github.com/users/foam-framework/events{/privacy}","received_events_url":"https://api.github.com/users/foam-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":50441060,"name":"foam2","full_name":"foam-framework/foam2","owner":{"login":"foam-framework","id":7460756,"avatar_url":"https://avatars2.githubusercontent.com/u/7460756?v=3","gravatar_id":"","url":"https://api.github.com/users/foam-framework","html_url":"https://github.com/foam-framework","followers_url":"https://api.github.com/users/foam-framework/followers","following_url":"https://api.github.com/users/foam-framework/following{/other_user}","gists_url":"https://api.github.com/users/foam-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/foam-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foam-framework/subscriptions","organizations_url":"https://api.github.com/users/foam-framework/orgs","repos_url":"https://api.github.com/users/foam-framework/repos","events_url":"https://api.github.com/users/foam-framework/events{/privacy}","received_events_url":"https://api.github.com/users/foam-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/foam-framework/foam2","description":"FOAM: Feature-Oriented Active Modeller, Version 2","fork":false,"url":"https://api.github.com/repos/foam-framework/foam2","forks_url":"https://api.github.com/repos/foam-framework/foam2/forks","keys_url":"https://api.github.com/repos/foam-framework/foam2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foam-framework/foam2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foam-framework/foam2/teams","hooks_url":"https://api.github.com/repos/foam-framework/foam2/hooks","issue_events_url":"https://api.github.com/repos/foam-framework/foam2/issues/events{/number}","events_url":"https://api.github.com/repos/foam-framework/foam2/events","assignees_url":"https://api.github.com/repos/foam-framework/foam2/assignees{/user}","branches_url":"https://api.github.com/repos/foam-framework/foam2/branches{/branch}","tags_url":"https://api.github.com/repos/foam-framework/foam2/tags","blobs_url":"https://api.github.com/repos/foam-framework/foam2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foam-framework/foam2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foam-framework/foam2/git/refs{/sha}","trees_url":"https://api.github.com/repos/foam-framework/foam2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foam-framework/foam2/statuses/{sha}","languages_url":"https://api.github.com/repos/foam-framework/foam2/languages","stargazers_url":"https://api.github.com/repos/foam-framework/foam2/stargazers","contributors_url":"https://api.github.com/repos/foam-framework/foam2/contributors","subscribers_url":"https://api.github.com/repos/foam-framework/foam2/subscribers","subscription_url":"https://api.github.com/repos/foam-framework/foam2/subscription","commits_url":"https://api.github.com/repos/foam-framework/foam2/commits{/sha}","git_commits_url":"https://api.github.com/repos/foam-framework/foam2/git/commits{/sha}","comments_url":"https://api.github.com/repos/foam-framework/foam2/comments{/number}","issue_comment_url":"https://api.github.com/repos/foam-framework/foam2/issues/comments{/number}","contents_url":"https://api.github.com/repos/foam-framework/foam2/contents/{+path}","compare_url":"https://api.github.com/repos/foam-framework/foam2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foam-framework/foam2/merges","archive_url":"https://api.github.com/repos/foam-framework/foam2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foam-framework/foam2/downloads","issues_url":"https://api.github.com/repos/foam-framework/foam2/issues{/number}","pulls_url":"https://api.github.com/repos/foam-framework/foam2/pulls{/number}","milestones_url":"https://api.github.com/repos/foam-framework/foam2/milestones{/number}","notifications_url":"https://api.github.com/repos/foam-framework/foam2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foam-framework/foam2/labels{/name}","releases_url":"https://api.github.com/repos/foam-framework/foam2/releases{/id}","deployments_url":"https://api.github.com/repos/foam-framework/foam2/deployments","created_at":"2016-01-26T16:13:38Z","updated_at":"2017-06-28T17:13:25Z","pushed_at":"2017-07-05T19:14:15Z","git_url":"git://github.com/foam-framework/foam2.git","ssh_url":"[email protected]:foam-framework/foam2.git","clone_url":"https://github.com/foam-framework/foam2.git","svn_url":"https://github.com/foam-framework/foam2","homepage":"","size":9941,"stargazers_count":16,"watchers_count":16,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":121,"forks":23,"open_issues":121,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/454"},"html":{"href":"https://github.com/foam-framework/foam2/pull/454"},"issue":{"href":"https://api.github.com/repos/foam-framework/foam2/issues/454"},"comments":{"href":"https://api.github.com/repos/foam-framework/foam2/issues/454/comments"},"review_comments":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/454/comments"},"review_comment":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/454/commits"},"statuses":{"href":"https://api.github.com/repos/foam-framework/foam2/statuses/04467cc8b0a34b3c587ab26f4e119ba4db95b6ca"}}}}
|
{
"id": 50441060,
"name": "foam-framework/foam2",
"url": "https://api.github.com/repos/foam-framework/foam2"
}
|
{
"id": 7460787,
"login": "kgrgreer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7460787?",
"url": "https://api.github.com/users/kgrgreer"
}
|
{
"id": 7460756,
"login": "foam-framework",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7460756?",
"url": "https://api.github.com/orgs/foam-framework"
}
| 2017-07-05T20:12:21 |
6198869160
|
{"actor":{"display_login":"kgrgreer"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/helena-project/tock/pulls/comments/100608595","pull_request_review_id":21325507,"id":100608595,"diff_hunk":"@@ -0,0 +1,1424 @@\n+//! Provide capsule driver for accessing an SD Card.\n+//! This allows initialization and block reads or writes on top of SPI\n+\n+// Resources for SD Card API\n+// elm-chan.org/docs/mmc/mmc_e.html\n+// alumni.cs.ucr.edu/~amitra/sdcard/Additional/sdcard_appnote_foust.pdf\n+// luckyresistor.me/cat-protector/software/sdcard-2/\n+// http://users.ece.utexas.edu/~valvano/EE345M/SD_Physical_Layer_Spec.pdf\n+\n+use core::cell::Cell;\n+use core::cmp;\n+use kernel::{AppId, AppSlice, Callback, Driver, ReturnCode, Shared};\n+use kernel::common::take_cell::{MapCell, TakeCell};\n+\n+use kernel::hil;\n+use kernel::hil::time::Frequency;\n+\n+// Buffers used for SD card transactions\n+// Constraints:\n+// * RXBUFFER must be greater than or equal to TXBUFFER in length\n+// * Both RXBUFFER and TXBUFFER must be longer than the SD card's block size\n+pub static mut TXBUFFER: [u8; 515] = [0; 515];\n+pub static mut RXBUFFER: [u8; 515] = [0; 515];\n+\n+// Buffer for SD card driver\n+pub static mut KERNEL_BUFFER: [u8; 512] = [0; 512];\n+\n+#[allow(dead_code)]\n+#[derive(Clone,Copy,Debug,PartialEq)]\n+enum SDCmd {\n+ CMD0 = 0, // Reset\n+ CMD1 = 1, // Generic init\n+ CMD8 = 8, // Check voltage range\n+ CMD9 = 9, // Read chip specific data (CSD) register\n+ CMD12 = 12, // Stop multiple block read\n+ CMD16 = 16, // Set blocksize\n+ CMD17 = 17, // Read single block\n+ CMD18 = 18, // Read multiple blocks\n+ CMD24 = 24, // Write single block\n+ CMD25 = 25, // Write multiple blocks\n+ CMD55 = 55, // Next command will be application specific\n+ CMD58 = 58, // Read operation condition register (OCR)\n+ ACMD41 = 0x80 + 41, // App-specific Init\n+}\n+\n+#[allow(dead_code)]\n+#[derive(Clone,Copy,Debug,PartialEq)]\n+enum SDResponse {\n+ R1,\n+ R2,\n+ R3,\n+ R7,\n+}\n+\n+#[derive(Clone,Copy,Debug,PartialEq)]\n+enum State {\n+ Idle,\n+\n+ SendACmd { acmd: SDCmd, arg: u32 },\n+\n+ InitReset,\n+ InitCheckVersion,\n+ InitRepeatHCSInit,\n+ InitCheckCapacity,\n+ InitAppSpecificInit,\n+ InitRepeatAppSpecificInit,\n+ InitRepeatGenericInit,\n+ InitSetBlocksize,\n+ InitComplete,\n+\n+ StartReadBlocks { count: u32 },\n+ WaitReadBlock,\n+ ReadBlockComplete,\n+ WaitReadBlocks { count: u32 },\n+ ReceivedBlock { count: u32 },\n+ ReadBlocksComplete,\n+\n+ StartWriteBlocks { count: u32 },\n+ WriteBlockResponse,\n+ WriteBlockBusy,\n+ WaitWriteBlockBusy,\n+}\n+\n+#[derive(Clone,Copy,Debug,PartialEq)]\n+enum AlarmState {\n+ Idle,\n+\n+ DetectionChange,\n+\n+ RepeatHCSInit,\n+ RepeatAppSpecificInit,\n+ RepeatGenericInit,\n+\n+ WaitForDataBlock,\n+ WaitForDataBlocks { count: u32 },\n+\n+ WaitForWriteBusy,\n+}\n+\n+#[derive(Clone,Copy,Debug,PartialEq)]\n+enum ErrorCode {\n+ CardStateChanged = -1,\n+ InitializationFailure = -2,\n+ ReadFailure = -3,\n+ WriteFailure = -4,\n+ TimeoutFailure = -5,\n+}\n+\n+// SD Card types\n+const CT_MMC: u8 = 0x01;\n+const CT_SD1: u8 = 0x02;\n+const CT_SD2: u8 = 0x04;\n+const CT_BLOCK: u8 = 0x08;\n+\n+// SD Card capsule, capable of being built on top of by other kernel capsules\n+pub struct SDCard<'a, A: hil::time::Alarm + 'a> {","path":"capsules/src/sdcard.rs","position":116,"original_position":116,"commit_id":"8353a73a6325333d664814f17e8fa5b1dde879e8","original_commit_id":"e0d0a7b35b0fbf1e07c407ce242f578f93cd7547","user":{"login":"brghena","id":235448,"avatar_url":"https://avatars.githubusercontent.com/u/235448?v=3","gravatar_id":"","url":"https://api.github.com/users/brghena","html_url":"https://github.com/brghena","followers_url":"https://api.github.com/users/brghena/followers","following_url":"https://api.github.com/users/brghena/following{/other_user}","gists_url":"https://api.github.com/users/brghena/gists{/gist_id}","starred_url":"https://api.github.com/users/brghena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brghena/subscriptions","organizations_url":"https://api.github.com/users/brghena/orgs","repos_url":"https://api.github.com/users/brghena/repos","events_url":"https://api.github.com/users/brghena/events{/privacy}","received_events_url":"https://api.github.com/users/brghena/received_events","type":"User","site_admin":false},"body":"But you mean just the definition of fields, not the implementation of it, right?","created_at":"2017-02-10T19:38:27Z","updated_at":"2017-02-10T19:38:27Z","html_url":"https://github.com/helena-project/tock/pull/283#discussion_r100608595","pull_request_url":"https://api.github.com/repos/helena-project/tock/pulls/283","_links":{"self":{"href":"https://api.github.com/repos/helena-project/tock/pulls/comments/100608595"},"html":{"href":"https://github.com/helena-project/tock/pull/283#discussion_r100608595"},"pull_request":{"href":"https://api.github.com/repos/helena-project/tock/pulls/283"}}},"pull_request":{"url":"https://api.github.com/repos/helena-project/tock/pulls/283","id":105576871,"html_url":"https://github.com/helena-project/tock/pull/283","diff_url":"https://github.com/helena-project/tock/pull/283.diff","patch_url":"https://github.com/helena-project/tock/pull/283.patch","issue_url":"https://api.github.com/repos/helena-project/tock/issues/283","number":283,"state":"open","locked":false,"title":"SD Card driver","user":{"login":"brghena","id":235448,"avatar_url":"https://avatars.githubusercontent.com/u/235448?v=3","gravatar_id":"","url":"https://api.github.com/users/brghena","html_url":"https://github.com/brghena","followers_url":"https://api.github.com/users/brghena/followers","following_url":"https://api.github.com/users/brghena/following{/other_user}","gists_url":"https://api.github.com/users/brghena/gists{/gist_id}","starred_url":"https://api.github.com/users/brghena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brghena/subscriptions","organizations_url":"https://api.github.com/users/brghena/orgs","repos_url":"https://api.github.com/users/brghena/repos","events_url":"https://api.github.com/users/brghena/events{/privacy}","received_events_url":"https://api.github.com/users/brghena/received_events","type":"User","site_admin":false},"body":"Implementation of a raw SD card interface for Tock. This code has been tested on the [Signpost Control Module](https://github.com/lab11/signpost/tree/master/hardware/controller/rev_b), [Storage Master platform](https://github.com/lab11/signpost/tree/master/software/kernel/boards/storage_master) on multiple 8 GB and 4 GB SDHC cards. The code should also be compatible with older, smaller SD cards, but has not been explicitly tested on them (I don't have any).\r\n\r\nThese commits should probably be squashed when merging.\r\n\r\n## Files\r\n\r\n`capsules/src/sdcard.rs`:\r\n * `SDCard` for interacting with SD cards on a block level\r\n * `SDCardDriver` implements syscalls for the `SDCard` interface\r\n\r\n`userland/libtock/sdcard.c` and `userland/libtock/sdcard.h`:\r\n * Functions for interacting with an SD card including checking if it is installed, initializing it, and reading/writing single blocks\r\n\r\n`userland/examples/sdcard/main.c`:\r\n * Tests the SD card functionality","created_at":"2017-02-10T07:07:58Z","updated_at":"2017-02-10T19:38:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a873d71a6cb671a90f6c70de5cf224e9e24ba743","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/helena-project/tock/pulls/283/commits","review_comments_url":"https://api.github.com/repos/helena-project/tock/pulls/283/comments","review_comment_url":"https://api.github.com/repos/helena-project/tock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helena-project/tock/issues/283/comments","statuses_url":"https://api.github.com/repos/helena-project/tock/statuses/8353a73a6325333d664814f17e8fa5b1dde879e8","head":{"label":"helena-project:sd-card","ref":"sd-card","sha":"8353a73a6325333d664814f17e8fa5b1dde879e8","user":{"login":"helena-project","id":8978731,"avatar_url":"https://avatars.githubusercontent.com/u/8978731?v=3","gravatar_id":"","url":"https://api.github.com/users/helena-project","html_url":"https://github.com/helena-project","followers_url":"https://api.github.com/users/helena-project/followers","following_url":"https://api.github.com/users/helena-project/following{/other_user}","gists_url":"https://api.github.com/users/helena-project/gists{/gist_id}","starred_url":"https://api.github.com/users/helena-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helena-project/subscriptions","organizations_url":"https://api.github.com/users/helena-project/orgs","repos_url":"https://api.github.com/users/helena-project/repos","events_url":"https://api.github.com/users/helena-project/events{/privacy}","received_events_url":"https://api.github.com/users/helena-project/received_events","type":"Organization","site_admin":false},"repo":{"id":36428094,"name":"tock","full_name":"helena-project/tock","owner":{"login":"helena-project","id":8978731,"avatar_url":"https://avatars.githubusercontent.com/u/8978731?v=3","gravatar_id":"","url":"https://api.github.com/users/helena-project","html_url":"https://github.com/helena-project","followers_url":"https://api.github.com/users/helena-project/followers","following_url":"https://api.github.com/users/helena-project/following{/other_user}","gists_url":"https://api.github.com/users/helena-project/gists{/gist_id}","starred_url":"https://api.github.com/users/helena-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helena-project/subscriptions","organizations_url":"https://api.github.com/users/helena-project/orgs","repos_url":"https://api.github.com/users/helena-project/repos","events_url":"https://api.github.com/users/helena-project/events{/privacy}","received_events_url":"https://api.github.com/users/helena-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/helena-project/tock","description":"A secure embedded operating system for Cortex-M based microcontrollers","fork":false,"url":"https://api.github.com/repos/helena-project/tock","forks_url":"https://api.github.com/repos/helena-project/tock/forks","keys_url":"https://api.github.com/repos/helena-project/tock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helena-project/tock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helena-project/tock/teams","hooks_url":"https://api.github.com/repos/helena-project/tock/hooks","issue_events_url":"https://api.github.com/repos/helena-project/tock/issues/events{/number}","events_url":"https://api.github.com/repos/helena-project/tock/events","assignees_url":"https://api.github.com/repos/helena-project/tock/assignees{/user}","branches_url":"https://api.github.com/repos/helena-project/tock/branches{/branch}","tags_url":"https://api.github.com/repos/helena-project/tock/tags","blobs_url":"https://api.github.com/repos/helena-project/tock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helena-project/tock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helena-project/tock/git/refs{/sha}","trees_url":"https://api.github.com/repos/helena-project/tock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helena-project/tock/statuses/{sha}","languages_url":"https://api.github.com/repos/helena-project/tock/languages","stargazers_url":"https://api.github.com/repos/helena-project/tock/stargazers","contributors_url":"https://api.github.com/repos/helena-project/tock/contributors","subscribers_url":"https://api.github.com/repos/helena-project/tock/subscribers","subscription_url":"https://api.github.com/repos/helena-project/tock/subscription","commits_url":"https://api.github.com/repos/helena-project/tock/commits{/sha}","git_commits_url":"https://api.github.com/repos/helena-project/tock/git/commits{/sha}","comments_url":"https://api.github.com/repos/helena-project/tock/comments{/number}","issue_comment_url":"https://api.github.com/repos/helena-project/tock/issues/comments{/number}","contents_url":"https://api.github.com/repos/helena-project/tock/contents/{+path}","compare_url":"https://api.github.com/repos/helena-project/tock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helena-project/tock/merges","archive_url":"https://api.github.com/repos/helena-project/tock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helena-project/tock/downloads","issues_url":"https://api.github.com/repos/helena-project/tock/issues{/number}","pulls_url":"https://api.github.com/repos/helena-project/tock/pulls{/number}","milestones_url":"https://api.github.com/repos/helena-project/tock/milestones{/number}","notifications_url":"https://api.github.com/repos/helena-project/tock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helena-project/tock/labels{/name}","releases_url":"https://api.github.com/repos/helena-project/tock/releases{/id}","deployments_url":"https://api.github.com/repos/helena-project/tock/deployments","created_at":"2015-05-28T09:26:47Z","updated_at":"2017-02-10T12:56:56Z","pushed_at":"2017-02-10T19:30:55Z","git_url":"git://github.com/helena-project/tock.git","ssh_url":"[email protected]:helena-project/tock.git","clone_url":"https://github.com/helena-project/tock.git","svn_url":"https://github.com/helena-project/tock","homepage":"http://www.tockos.org","size":91360,"stargazers_count":354,"watchers_count":354,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":34,"forks":32,"open_issues":34,"watchers":354,"default_branch":"master"}},"base":{"label":"helena-project:master","ref":"master","sha":"26fe6b297964654a095642e56a095d2e67b1b1c3","user":{"login":"helena-project","id":8978731,"avatar_url":"https://avatars.githubusercontent.com/u/8978731?v=3","gravatar_id":"","url":"https://api.github.com/users/helena-project","html_url":"https://github.com/helena-project","followers_url":"https://api.github.com/users/helena-project/followers","following_url":"https://api.github.com/users/helena-project/following{/other_user}","gists_url":"https://api.github.com/users/helena-project/gists{/gist_id}","starred_url":"https://api.github.com/users/helena-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helena-project/subscriptions","organizations_url":"https://api.github.com/users/helena-project/orgs","repos_url":"https://api.github.com/users/helena-project/repos","events_url":"https://api.github.com/users/helena-project/events{/privacy}","received_events_url":"https://api.github.com/users/helena-project/received_events","type":"Organization","site_admin":false},"repo":{"id":36428094,"name":"tock","full_name":"helena-project/tock","owner":{"login":"helena-project","id":8978731,"avatar_url":"https://avatars.githubusercontent.com/u/8978731?v=3","gravatar_id":"","url":"https://api.github.com/users/helena-project","html_url":"https://github.com/helena-project","followers_url":"https://api.github.com/users/helena-project/followers","following_url":"https://api.github.com/users/helena-project/following{/other_user}","gists_url":"https://api.github.com/users/helena-project/gists{/gist_id}","starred_url":"https://api.github.com/users/helena-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helena-project/subscriptions","organizations_url":"https://api.github.com/users/helena-project/orgs","repos_url":"https://api.github.com/users/helena-project/repos","events_url":"https://api.github.com/users/helena-project/events{/privacy}","received_events_url":"https://api.github.com/users/helena-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/helena-project/tock","description":"A secure embedded operating system for Cortex-M based microcontrollers","fork":false,"url":"https://api.github.com/repos/helena-project/tock","forks_url":"https://api.github.com/repos/helena-project/tock/forks","keys_url":"https://api.github.com/repos/helena-project/tock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helena-project/tock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helena-project/tock/teams","hooks_url":"https://api.github.com/repos/helena-project/tock/hooks","issue_events_url":"https://api.github.com/repos/helena-project/tock/issues/events{/number}","events_url":"https://api.github.com/repos/helena-project/tock/events","assignees_url":"https://api.github.com/repos/helena-project/tock/assignees{/user}","branches_url":"https://api.github.com/repos/helena-project/tock/branches{/branch}","tags_url":"https://api.github.com/repos/helena-project/tock/tags","blobs_url":"https://api.github.com/repos/helena-project/tock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helena-project/tock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helena-project/tock/git/refs{/sha}","trees_url":"https://api.github.com/repos/helena-project/tock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helena-project/tock/statuses/{sha}","languages_url":"https://api.github.com/repos/helena-project/tock/languages","stargazers_url":"https://api.github.com/repos/helena-project/tock/stargazers","contributors_url":"https://api.github.com/repos/helena-project/tock/contributors","subscribers_url":"https://api.github.com/repos/helena-project/tock/subscribers","subscription_url":"https://api.github.com/repos/helena-project/tock/subscription","commits_url":"https://api.github.com/repos/helena-project/tock/commits{/sha}","git_commits_url":"https://api.github.com/repos/helena-project/tock/git/commits{/sha}","comments_url":"https://api.github.com/repos/helena-project/tock/comments{/number}","issue_comment_url":"https://api.github.com/repos/helena-project/tock/issues/comments{/number}","contents_url":"https://api.github.com/repos/helena-project/tock/contents/{+path}","compare_url":"https://api.github.com/repos/helena-project/tock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helena-project/tock/merges","archive_url":"https://api.github.com/repos/helena-project/tock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helena-project/tock/downloads","issues_url":"https://api.github.com/repos/helena-project/tock/issues{/number}","pulls_url":"https://api.github.com/repos/helena-project/tock/pulls{/number}","milestones_url":"https://api.github.com/repos/helena-project/tock/milestones{/number}","notifications_url":"https://api.github.com/repos/helena-project/tock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helena-project/tock/labels{/name}","releases_url":"https://api.github.com/repos/helena-project/tock/releases{/id}","deployments_url":"https://api.github.com/repos/helena-project/tock/deployments","created_at":"2015-05-28T09:26:47Z","updated_at":"2017-02-10T12:56:56Z","pushed_at":"2017-02-10T19:30:55Z","git_url":"git://github.com/helena-project/tock.git","ssh_url":"[email protected]:helena-project/tock.git","clone_url":"https://github.com/helena-project/tock.git","svn_url":"https://github.com/helena-project/tock","homepage":"http://www.tockos.org","size":91360,"stargazers_count":354,"watchers_count":354,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"open_issues_count":34,"forks":32,"open_issues":34,"watchers":354,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helena-project/tock/pulls/283"},"html":{"href":"https://github.com/helena-project/tock/pull/283"},"issue":{"href":"https://api.github.com/repos/helena-project/tock/issues/283"},"comments":{"href":"https://api.github.com/repos/helena-project/tock/issues/283/comments"},"review_comments":{"href":"https://api.github.com/repos/helena-project/tock/pulls/283/comments"},"review_comment":{"href":"https://api.github.com/repos/helena-project/tock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helena-project/tock/pulls/283/commits"},"statuses":{"href":"https://api.github.com/repos/helena-project/tock/statuses/8353a73a6325333d664814f17e8fa5b1dde879e8"}}}}
|
{
"id": 36428094,
"name": "helena-project/tock",
"url": "https://api.github.com/repos/helena-project/tock"
}
|
{
"id": 235448,
"login": "brghena",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/235448?",
"url": "https://api.github.com/users/brghena"
}
|
{
"id": 8978731,
"login": "helena-project",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8978731?",
"url": "https://api.github.com/orgs/helena-project"
}
| 2017-02-10T19:38:27 |
5304894909
|
{"actor":{"display_login":"brghena"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/helena-project/tock/pulls/comments/141184697","pull_request_review_id":65362186,"id":141184697,"diff_hunk":"@@ -1,43 +1,148 @@\n+/*\n+ * BLE setup functions\n+ */\n+\n #include \"ble.h\"\n+#include \"tock.h\"\n+#include <stdbool.h>\n+#include <stdint.h>\n #include <stdio.h>\n #include <string.h>\n \n-int ble_adv_set_txpower(BLE_TX_Power_t power) {\n- return command(DRIVER_RADIO, BLE_CFG_TX_POWER, power);\n+#define MAX_SIZE 31\n+\n+\n+/*******************************************************************************\n+ * INTERNAL BLE HELPER FUNCTION Prototypes\n+ *\n+ * s_ - static (file scope)\n+ ******************************************************************************/\n+static int s_ble_cfg_addr (uint8_t *addr, uint8_t addr_len);\n+static int s_ble_cfg_flags (uint8_t flags);\n+static int s_ble_cfg_adv_itv (uint16_t advertising_itv_ms);\n+static int s_ble_cfg_gap_data (GapAdvertisementData_t header, uint8_t *data, uint8_t len);\n+\n+\n+/*******************************************************************************\n+ * USER-SPACE BLE API\n+ ******************************************************************************/\n+\n+int ble_initialize(uint16_t advertising_itv_ms, bool discoverable, uint8_t *addr,","path":"userland/libtock/ble.c","position":32,"original_position":32,"commit_id":"a468d3ba62460c2b086ff8cfd52f7276c6a7a48c","original_commit_id":"a468d3ba62460c2b086ff8cfd52f7276c6a7a48c","user":{"login":"niklasad1","id":14157425,"avatar_url":"https://avatars1.githubusercontent.com/u/14157425?v=4","gravatar_id":"","url":"https://api.github.com/users/niklasad1","html_url":"https://github.com/niklasad1","followers_url":"https://api.github.com/users/niklasad1/followers","following_url":"https://api.github.com/users/niklasad1/following{/other_user}","gists_url":"https://api.github.com/users/niklasad1/gists{/gist_id}","starred_url":"https://api.github.com/users/niklasad1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niklasad1/subscriptions","organizations_url":"https://api.github.com/users/niklasad1/orgs","repos_url":"https://api.github.com/users/niklasad1/repos","events_url":"https://api.github.com/users/niklasad1/events{/privacy}","received_events_url":"https://api.github.com/users/niklasad1/received_events","type":"User","site_admin":false},"body":"Ok, but it sounds like it is best to let kernel decide the address for now then?\r\n\r\nShould be pretty easy to use the TRNG driver to generate 6 random bytes if you want that?\r\n\r\nBut should all functions be completely re-written because it is still possible have interleaving between configuring advertisement_interval, configure different data (device_name, uuids etc) in the packet.\r\n\r\nBut after ```_start``` the busy flag will be set and block the entire thing as it is right now\r\n\r\nI think you @alevy and @brghena has to decide this because I don't know how to approach this.\r\n","created_at":"2017-09-26T21:06:42Z","updated_at":"2017-09-26T21:06:42Z","html_url":"https://github.com/helena-project/tock/pull/623#discussion_r141184697","pull_request_url":"https://api.github.com/repos/helena-project/tock/pulls/623","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/helena-project/tock/pulls/comments/141184697"},"html":{"href":"https://github.com/helena-project/tock/pull/623#discussion_r141184697"},"pull_request":{"href":"https://api.github.com/repos/helena-project/tock/pulls/623"}},"in_reply_to_id":141054091},"pull_request":{"url":"https://api.github.com/repos/helena-project/tock/pulls/623","id":142763904,"html_url":"https://github.com/helena-project/tock/pull/623","diff_url":"https://github.com/helena-project/tock/pull/623.diff","patch_url":"https://github.com/helena-project/tock/pull/623.patch","issue_url":"https://api.github.com/repos/helena-project/tock/issues/623","number":623,"state":"open","locked":false,"title":"simple ble interface","user":{"login":"niklasad1","id":14157425,"avatar_url":"https://avatars1.githubusercontent.com/u/14157425?v=4","gravatar_id":"","url":"https://api.github.com/users/niklasad1","html_url":"https://github.com/niklasad1","followers_url":"https://api.github.com/users/niklasad1/followers","following_url":"https://api.github.com/users/niklasad1/following{/other_user}","gists_url":"https://api.github.com/users/niklasad1/gists{/gist_id}","starred_url":"https://api.github.com/users/niklasad1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niklasad1/subscriptions","organizations_url":"https://api.github.com/users/niklasad1/orgs","repos_url":"https://api.github.com/users/niklasad1/repos","events_url":"https://api.github.com/users/niklasad1/events{/privacy}","received_events_url":"https://api.github.com/users/niklasad1/received_events","type":"User","site_admin":false},"body":"### Pull Request Overview\r\n\r\nThis pull request simplifies the Bluetooth Low Energy API in user-space\r\n\r\n\r\n### Testing Strategy\r\n\r\nThis pull request was tested by running the test application [tutorials/xx_ble_adv](https://github.com/niklasad1/tock/blob/simple_ble_interface/userland/examples/tutorials/xx_ble_adv/main.c)\r\n\r\nA screenshot from Nordic Connect Android App can be found here:\r\n[Screenshot](https://www.dropbox.com/s/8c8jyqsogbbslhz/Screenshot_2017-09-24-19-25-11.png?dl=0)\r\n\r\n### TODO or Help Wanted\r\n\r\nI want feedback on the BLE API and what should be different etc?\r\n@brghena @alevy :smiley: \r\n\r\nAfter feedback I will continue to add wrapper for Eddystone as @brghena suggested and update existing example apps since this will break those.\r\n\r\n### Documentation Updated\r\n\r\n- [ ] Kernel: The relevant files in `/docs` have been updated or no updates are required.\r\n- [ ] Userland: The application README has been added, updated, or no updates are required.\r\n\r\n### Formatting\r\n\r\n- [X] `make formatall` has been run.\r\n","created_at":"2017-09-24T18:01:56Z","updated_at":"2017-09-26T21:06:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e146bf1fb0c42595b439596eebf2e44b17dd3ba8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/helena-project/tock/pulls/623/commits","review_comments_url":"https://api.github.com/repos/helena-project/tock/pulls/623/comments","review_comment_url":"https://api.github.com/repos/helena-project/tock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helena-project/tock/issues/623/comments","statuses_url":"https://api.github.com/repos/helena-project/tock/statuses/a468d3ba62460c2b086ff8cfd52f7276c6a7a48c","head":{"label":"niklasad1:simple_ble_interface","ref":"simple_ble_interface","sha":"a468d3ba62460c2b086ff8cfd52f7276c6a7a48c","user":{"login":"niklasad1","id":14157425,"avatar_url":"https://avatars1.githubusercontent.com/u/14157425?v=4","gravatar_id":"","url":"https://api.github.com/users/niklasad1","html_url":"https://github.com/niklasad1","followers_url":"https://api.github.com/users/niklasad1/followers","following_url":"https://api.github.com/users/niklasad1/following{/other_user}","gists_url":"https://api.github.com/users/niklasad1/gists{/gist_id}","starred_url":"https://api.github.com/users/niklasad1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niklasad1/subscriptions","organizations_url":"https://api.github.com/users/niklasad1/orgs","repos_url":"https://api.github.com/users/niklasad1/repos","events_url":"https://api.github.com/users/niklasad1/events{/privacy}","received_events_url":"https://api.github.com/users/niklasad1/received_events","type":"User","site_admin":false},"repo":{"id":90353656,"name":"tock","full_name":"niklasad1/tock","owner":{"login":"niklasad1","id":14157425,"avatar_url":"https://avatars1.githubusercontent.com/u/14157425?v=4","gravatar_id":"","url":"https://api.github.com/users/niklasad1","html_url":"https://github.com/niklasad1","followers_url":"https://api.github.com/users/niklasad1/followers","following_url":"https://api.github.com/users/niklasad1/following{/other_user}","gists_url":"https://api.github.com/users/niklasad1/gists{/gist_id}","starred_url":"https://api.github.com/users/niklasad1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niklasad1/subscriptions","organizations_url":"https://api.github.com/users/niklasad1/orgs","repos_url":"https://api.github.com/users/niklasad1/repos","events_url":"https://api.github.com/users/niklasad1/events{/privacy}","received_events_url":"https://api.github.com/users/niklasad1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/niklasad1/tock","description":"A secure embedded operating system for Cortex-M based microcontrollers","fork":true,"url":"https://api.github.com/repos/niklasad1/tock","forks_url":"https://api.github.com/repos/niklasad1/tock/forks","keys_url":"https://api.github.com/repos/niklasad1/tock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/niklasad1/tock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/niklasad1/tock/teams","hooks_url":"https://api.github.com/repos/niklasad1/tock/hooks","issue_events_url":"https://api.github.com/repos/niklasad1/tock/issues/events{/number}","events_url":"https://api.github.com/repos/niklasad1/tock/events","assignees_url":"https://api.github.com/repos/niklasad1/tock/assignees{/user}","branches_url":"https://api.github.com/repos/niklasad1/tock/branches{/branch}","tags_url":"https://api.github.com/repos/niklasad1/tock/tags","blobs_url":"https://api.github.com/repos/niklasad1/tock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/niklasad1/tock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/niklasad1/tock/git/refs{/sha}","trees_url":"https://api.github.com/repos/niklasad1/tock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/niklasad1/tock/statuses/{sha}","languages_url":"https://api.github.com/repos/niklasad1/tock/languages","stargazers_url":"https://api.github.com/repos/niklasad1/tock/stargazers","contributors_url":"https://api.github.com/repos/niklasad1/tock/contributors","subscribers_url":"https://api.github.com/repos/niklasad1/tock/subscribers","subscription_url":"https://api.github.com/repos/niklasad1/tock/subscription","commits_url":"https://api.github.com/repos/niklasad1/tock/commits{/sha}","git_commits_url":"https://api.github.com/repos/niklasad1/tock/git/commits{/sha}","comments_url":"https://api.github.com/repos/niklasad1/tock/comments{/number}","issue_comment_url":"https://api.github.com/repos/niklasad1/tock/issues/comments{/number}","contents_url":"https://api.github.com/repos/niklasad1/tock/contents/{+path}","compare_url":"https://api.github.com/repos/niklasad1/tock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/niklasad1/tock/merges","archive_url":"https://api.github.com/repos/niklasad1/tock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/niklasad1/tock/downloads","issues_url":"https://api.github.com/repos/niklasad1/tock/issues{/number}","pulls_url":"https://api.github.com/repos/niklasad1/tock/pulls{/number}","milestones_url":"https://api.github.com/repos/niklasad1/tock/milestones{/number}","notifications_url":"https://api.github.com/repos/niklasad1/tock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/niklasad1/tock/labels{/name}","releases_url":"https://api.github.com/repos/niklasad1/tock/releases{/id}","deployments_url":"https://api.github.com/repos/niklasad1/tock/deployments","created_at":"2017-05-05T08:19:11Z","updated_at":"2017-05-05T08:19:14Z","pushed_at":"2017-09-25T08:21:32Z","git_url":"git://github.com/niklasad1/tock.git","ssh_url":"[email protected]:niklasad1/tock.git","clone_url":"https://github.com/niklasad1/tock.git","svn_url":"https://github.com/niklasad1/tock","homepage":"https://www.tockos.org","size":110659,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"helena-project:master","ref":"master","sha":"0165c4956f49e280ac169d72b7b375403f0ea103","user":{"login":"helena-project","id":8978731,"avatar_url":"https://avatars0.githubusercontent.com/u/8978731?v=4","gravatar_id":"","url":"https://api.github.com/users/helena-project","html_url":"https://github.com/helena-project","followers_url":"https://api.github.com/users/helena-project/followers","following_url":"https://api.github.com/users/helena-project/following{/other_user}","gists_url":"https://api.github.com/users/helena-project/gists{/gist_id}","starred_url":"https://api.github.com/users/helena-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helena-project/subscriptions","organizations_url":"https://api.github.com/users/helena-project/orgs","repos_url":"https://api.github.com/users/helena-project/repos","events_url":"https://api.github.com/users/helena-project/events{/privacy}","received_events_url":"https://api.github.com/users/helena-project/received_events","type":"Organization","site_admin":false},"repo":{"id":36428094,"name":"tock","full_name":"helena-project/tock","owner":{"login":"helena-project","id":8978731,"avatar_url":"https://avatars0.githubusercontent.com/u/8978731?v=4","gravatar_id":"","url":"https://api.github.com/users/helena-project","html_url":"https://github.com/helena-project","followers_url":"https://api.github.com/users/helena-project/followers","following_url":"https://api.github.com/users/helena-project/following{/other_user}","gists_url":"https://api.github.com/users/helena-project/gists{/gist_id}","starred_url":"https://api.github.com/users/helena-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helena-project/subscriptions","organizations_url":"https://api.github.com/users/helena-project/orgs","repos_url":"https://api.github.com/users/helena-project/repos","events_url":"https://api.github.com/users/helena-project/events{/privacy}","received_events_url":"https://api.github.com/users/helena-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/helena-project/tock","description":"A secure embedded operating system for Cortex-M based microcontrollers","fork":false,"url":"https://api.github.com/repos/helena-project/tock","forks_url":"https://api.github.com/repos/helena-project/tock/forks","keys_url":"https://api.github.com/repos/helena-project/tock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helena-project/tock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helena-project/tock/teams","hooks_url":"https://api.github.com/repos/helena-project/tock/hooks","issue_events_url":"https://api.github.com/repos/helena-project/tock/issues/events{/number}","events_url":"https://api.github.com/repos/helena-project/tock/events","assignees_url":"https://api.github.com/repos/helena-project/tock/assignees{/user}","branches_url":"https://api.github.com/repos/helena-project/tock/branches{/branch}","tags_url":"https://api.github.com/repos/helena-project/tock/tags","blobs_url":"https://api.github.com/repos/helena-project/tock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helena-project/tock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helena-project/tock/git/refs{/sha}","trees_url":"https://api.github.com/repos/helena-project/tock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helena-project/tock/statuses/{sha}","languages_url":"https://api.github.com/repos/helena-project/tock/languages","stargazers_url":"https://api.github.com/repos/helena-project/tock/stargazers","contributors_url":"https://api.github.com/repos/helena-project/tock/contributors","subscribers_url":"https://api.github.com/repos/helena-project/tock/subscribers","subscription_url":"https://api.github.com/repos/helena-project/tock/subscription","commits_url":"https://api.github.com/repos/helena-project/tock/commits{/sha}","git_commits_url":"https://api.github.com/repos/helena-project/tock/git/commits{/sha}","comments_url":"https://api.github.com/repos/helena-project/tock/comments{/number}","issue_comment_url":"https://api.github.com/repos/helena-project/tock/issues/comments{/number}","contents_url":"https://api.github.com/repos/helena-project/tock/contents/{+path}","compare_url":"https://api.github.com/repos/helena-project/tock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helena-project/tock/merges","archive_url":"https://api.github.com/repos/helena-project/tock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helena-project/tock/downloads","issues_url":"https://api.github.com/repos/helena-project/tock/issues{/number}","pulls_url":"https://api.github.com/repos/helena-project/tock/pulls{/number}","milestones_url":"https://api.github.com/repos/helena-project/tock/milestones{/number}","notifications_url":"https://api.github.com/repos/helena-project/tock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helena-project/tock/labels{/name}","releases_url":"https://api.github.com/repos/helena-project/tock/releases{/id}","deployments_url":"https://api.github.com/repos/helena-project/tock/deployments","created_at":"2015-05-28T09:26:47Z","updated_at":"2017-09-25T02:17:07Z","pushed_at":"2017-09-26T14:46:22Z","git_url":"git://github.com/helena-project/tock.git","ssh_url":"[email protected]:helena-project/tock.git","clone_url":"https://github.com/helena-project/tock.git","svn_url":"https://github.com/helena-project/tock","homepage":"https://www.tockos.org","size":112060,"stargazers_count":532,"watchers_count":532,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":45,"forks":65,"open_issues":45,"watchers":532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helena-project/tock/pulls/623"},"html":{"href":"https://github.com/helena-project/tock/pull/623"},"issue":{"href":"https://api.github.com/repos/helena-project/tock/issues/623"},"comments":{"href":"https://api.github.com/repos/helena-project/tock/issues/623/comments"},"review_comments":{"href":"https://api.github.com/repos/helena-project/tock/pulls/623/comments"},"review_comment":{"href":"https://api.github.com/repos/helena-project/tock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helena-project/tock/pulls/623/commits"},"statuses":{"href":"https://api.github.com/repos/helena-project/tock/statuses/a468d3ba62460c2b086ff8cfd52f7276c6a7a48c"}},"author_association":"COLLABORATOR"}}
|
{
"id": 36428094,
"name": "helena-project/tock",
"url": "https://api.github.com/repos/helena-project/tock"
}
|
{
"id": 14157425,
"login": "niklasad1",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14157425?",
"url": "https://api.github.com/users/niklasad1"
}
|
{
"id": 8978731,
"login": "helena-project",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8978731?",
"url": "https://api.github.com/orgs/helena-project"
}
| 2017-09-26T21:06:42 |
6640688186
|
{"actor":{"display_login":"niklasad1"}}
|