commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
Handle crashing Pepper plug-ins the same as crashing NPAPI plug-ins.
BUG=151895
Review URL: https://chromiumcodereview.appspot.com/10956065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158364 0039d316-1c4b-4281-b951-d872f2087c98 | ef97ce340c462d5212336f09bf8075d1cb10faa4 | chrome | bigvul | 1 | null | null | null |
OTS roll r94:r95
BUG=chromium:146254
Review URL: https://chromiumcodereview.appspot.com/10925002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154803 0039d316-1c4b-4281-b951-d872f2087c98 | 67f961d089584f227866808cb7428c111a174210 | chrome | bigvul | 1 | null | null | null |
[views] Remove header bar on shell windows created with {frame: none}.
BUG=130182
[email protected]
Review URL: https://chromiumcodereview.appspot.com/10597003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143439 0039d316-1c4b-4281-b951-d872f2087c98 | 7f8cdab6fda192d15e45a3e9682b1eec427870c5 | chrome | bigvul | 1 | null | null | null |
ash: Make UserActivityDetector ignore synthetic mouse events
This may have been preventing us from suspending (e.g.
mouse event is synthesized in response to lock window being
shown so Chrome tells powerd that the user is active).
BUG=133419
TEST=added
Review URL: https://chromiumcodereview.appspot.com/10574044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143437 0039d316-1c4b-4281-b951-d872f2087c98 | 10b688f204a81d8447c83021624220607353552e | chrome | bigvul | 1 | null | null | null |
Disable WebUIBidiCheckerBrowserTestRTL.TestSettingsFramePasswords for being flaky on all platforms.
[email protected].
BUG=95425
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10447119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139814 0039d316-1c4b-4281-b951-d872f2087c98 | ac0a7cb3b0da035c2c2ca21abf2c5f899ec32735 | chrome | bigvul | 1 | null | null | null |
Convert the autofill interactive browser test to a normal browser_test. I added testing methods to fake input events that don't depend on the OS and being at the front.
BUG=121574
Review URL: https://chromiumcodereview.appspot.com/10368010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135432 0039d316-1c4b-4281-b951-d872f2087c98 | 2511466dd15750f2ab0e5cecc30010f0a3f7949c | chrome | bigvul | 1 | null | null | null |
INPUT_MULTIPLE_FIELDS_UI: Inconsistent value of aria-valuetext attribute
https://bugs.webkit.org/show_bug.cgi?id=107897
Reviewed by Kentaro Hara.
Source/WebCore:
aria-valuetext and aria-valuenow attributes had inconsistent values in
a case of initial empty state and a case that a user clears a field.
- aria-valuetext attribute should have "blank" message in the initial
empty state.
- aria-valuenow attribute should be removed in the cleared empty state.
Also, we have a bug that aira-valuenow had a symbolic value such as "AM"
"January". It should always have a numeric value according to the
specification.
http://www.w3.org/TR/wai-aria/states_and_properties#aria-valuenow
No new tests. Updates fast/forms/*-multiple-fields/*-multiple-fields-ax-aria-attributes.html.
* html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::DateTimeFieldElement):
Set "blank" message to aria-valuetext attribute.
(WebCore::DateTimeFieldElement::updateVisibleValue):
aria-valuenow attribute should be a numeric value. Apply String::number
to the return value of valueForARIAValueNow.
Remove aria-valuenow attribute if nothing is selected.
(WebCore::DateTimeFieldElement::valueForARIAValueNow):
Added.
* html/shadow/DateTimeFieldElement.h:
(DateTimeFieldElement): Declare valueForARIAValueNow.
* html/shadow/DateTimeSymbolicFieldElement.cpp:
(WebCore::DateTimeSymbolicFieldElement::valueForARIAValueNow):
Added. Returns 1 + internal selection index.
For example, the function returns 1 for January.
* html/shadow/DateTimeSymbolicFieldElement.h:
(DateTimeSymbolicFieldElement): Declare valueForARIAValueNow.
LayoutTests:
Fix existing tests to show aria-valuenow attribute values.
* fast/forms/resources/multiple-fields-ax-aria-attributes.js: Added.
* fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes-expected.txt:
* fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes.html:
Use multiple-fields-ax-aria-attributes.js.
Add tests for initial empty-value state.
* fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes-expected.txt:
* fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes.html:
Use multiple-fields-ax-aria-attributes.js.
* fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes-expected.txt:
* fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes.html:
Use multiple-fields-ax-aria-attributes.js.
git-svn-id: svn://svn.chromium.org/blink/trunk@140803 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | f7b020b3d36def118881daa4402c44ca72271482 | chrome | bigvul | 1 | null | null | null |
[New Multicolumn] Add a positioned object pagination test.
https://bugs.webkit.org/show_bug.cgi?id=110480.
Reviewed by Antti Koivisto.
* fast/multicol/newmulticol/positioned-split-expected.html: Added.
* fast/multicol/newmulticol/positioned-split.html: Added.
git-svn-id: svn://svn.chromium.org/blink/trunk@143609 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 673d9c0a5e7c1b56f85aec4a9d2c472504cda403 | chrome | bigvul | 1 | null | null | null |
Revert 143656 - Add an IPC channel between the NaCl loader process and the renderer.
BUG=116317
TEST=ppapi, nacl tests, manual testing for experimental IPC proxy.
Review URL: https://chromiumcodereview.appspot.com/10641016
[email protected]
Review URL: https://chromiumcodereview.appspot.com/10625007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143665 0039d316-1c4b-4281-b951-d872f2087c98 | 3b0d77670a0613f409110817455d2137576b485a | chrome | bigvul | 1 | null | null | null |
[cros] Allow media streaming for OOBE WebUI.
BUG=122764
TEST=Manual with --enable-html5-camera
Review URL: https://chromiumcodereview.appspot.com/10693027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144899 0039d316-1c4b-4281-b951-d872f2087c98 | 9dc6161824d61e899c282cfe9aa40a4d3031974d | chrome | bigvul | 1 | null | null | null |
Fix SafeAdd and SafeMultiply
BUG=145648,145544
Review URL: https://chromiumcodereview.appspot.com/10916165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155478 0039d316-1c4b-4281-b951-d872f2087c98 | 3aad1a37affb1ab70d1897f2b03eb8c077264984 | chrome | bigvul | 1 | null | null | null |
Fix a Windows crash bug with javascript alerts from extension popups.
BUG=137707
Review URL: https://chromiumcodereview.appspot.com/10828423
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152716 0039d316-1c4b-4281-b951-d872f2087c98 | 94036902775aa96ea74db583135f4080a125fab9 | chrome | bigvul | 1 | null | null | null |
Assertion Failure in WebCore::RenderLayerCompositor::updateCompositingLayers.
https://bugs.webkit.org/show_bug.cgi?id=106419.
Unreviewed.
Updated Expectations.
* platform/mac/TestExpectations:
git-svn-id: svn://svn.chromium.org/blink/trunk@139168 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 1b01d348e86cb6c3517b7e5b593f2f0ad4b2a57b | chrome | bigvul | 1 | null | null | null |
Add another instance of a problematic DLL (different location) to the about:conflicts blacklist.
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10546096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141651 0039d316-1c4b-4281-b951-d872f2087c98 | 2bc34f038d1eb149e75c932061a475dbdb369564 | chrome | bigvul | 1 | null | null | null |
[protector] Refactoring of --no-protector code.
*) On DSE change, new provider is not pushed to Sync.
*) Simplified code in BrowserInit.
BUG=None
TEST=protector.py
Review URL: http://codereview.chromium.org/10065016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132398 0039d316-1c4b-4281-b951-d872f2087c98 | 76a3314ac3b711e01fae3b76a5d85f0eddeeec0b | chrome | bigvul | 1 | null | null | null |
Mark scheme-data-base-https-other-https.html as timing out
This test is flaky with site-per-process:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=site_per_process_webkit_layout_tests&tests=etch%2Fserviceworker-proxied%2Fthorough%2Fscheme-data-base-https-other-https.html
Most recent failure:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/134955
This patch marks the test as timing out and passing which matches the current
behavior.
[email protected]
No-Try: true
Bug: 834185
Change-Id: I38c12e53b7fe27add8c6d50160426a3da666d1f6
Reviewed-on: https://chromium-review.googlesource.com/1128163
Commit-Queue: Philip Rogers <[email protected]>
Reviewed-by: Philip Rogers <[email protected]>
Cr-Commit-Position: refs/heads/master@{#573013} | 39661c75086cce244dbcb87c8b89e8a305adecfe | chrome | bigvul | 1 | null | null | null |
WebKit roll 135488:135502
BUG=None
TBR=rjkroege
Review URL: https://codereview.chromium.org/11416152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169258 0039d316-1c4b-4281-b951-d872f2087c98 | c1bb74cabe5afcc7e1bb9a8877dfa28fc3909ddc | chrome | bigvul | 1 | null | null | null |
[Qt] Gardening after r137006.
https://bugs.webkit.org/show_bug.cgi?id=104432
Patch by Huang Dongsung <[email protected]> on 2012-12-09
Reviewed by Kentaro Hara.
Update existing tests that are affected by r137006.
* compositing/rtl/rtl-iframe-absolute-expected.txt:
* compositing/rtl/rtl-iframe-fixed-expected.txt:
* compositing/rtl/rtl-iframe-relative-expected.txt:
* platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt:
* platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/resizer-expected.txt:
* platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt:
* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
* platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
* platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
* platform/qt-5.0-wk2/compositing/overflow/content-gains-scrollbars-expected.txt:
* platform/qt-5.0-wk2/compositing/overflow/overflow-scrollbar-layers-expected.txt:
* platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
* platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
* platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
* platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
* platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt:
* platform/qt-5.0-wk2/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
* platform/qt-5.0-wk2/compositing/tiling/huge-layer-add-remove-child-expected.txt:
* platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-expected.txt:
* platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
* platform/qt/compositing/backing/no-backing-for-clip-expected.txt:
* platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt:
* platform/qt/compositing/backing/no-backing-for-perspective-expected.txt:
* platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:
git-svn-id: svn://svn.chromium.org/blink/trunk@137106 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 87942b3a518d34e98f179ef218eaf99295910c87 | chrome | bigvul | 1 | null | null | null |
Adds per-provider information to omnibox UMA logs.
Adds a fairly general structure to omnibox logs that can be used to pass information (that's not per-result information) from providers to the UMA logs. Right now it's only used to pass whether the asynchronous pass of a provider has finished, but it will probably be used for other things in the future.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10380007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137288 0039d316-1c4b-4281-b951-d872f2087c98 | 0e9e87823285d504a210dcce2eabdc847f230f09 | chrome | bigvul | 1 | null | null | null |
WebKit tests for the Qt API should include tests of CMake config files
https://bugs.webkit.org/show_bug.cgi?id=104003
Patch by Stephen Kelly <[email protected]> on 2012-12-11
Reviewed by Simon Hausmann.
The Qt WebKit CI system is not going to run this test, but it can
be run locally and to test packages.
.:
* Source/tests.pri:
Source/WebKit/qt:
* tests/cmake/CMakeLists.txt: Added.
* tests/cmake/cmake.pro: Added.
git-svn-id: svn://svn.chromium.org/blink/trunk@137302 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 01be4511324ff96c1e97f6e39f2485a6fcae6bc9 | chrome | bigvul | 1 | null | null | null |
[WIN] Implement WebCore::fileSystemRepresentation() for !USE(CF)
https://bugs.webkit.org/show_bug.cgi?id=104456
Reviewed by Brent Fulgham.
Convert the UTF-16 path to the system default Windows ANSI code page (usually Windows Latin1).
* platform/win/FileSystemWin.cpp:
(WebCore::fileSystemRepresentation):
git-svn-id: svn://svn.chromium.org/blink/trunk@137547 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | b654d718218ece17c496e74acd250038656f31c3 | chrome | bigvul | 1 | null | null | null |
Introduce XGetImage() for GrabWindowSnapshot() in ChromeOS.
BUG=119492
TEST=manually done
Review URL: https://chromiumcodereview.appspot.com/10386124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137556 0039d316-1c4b-4281-b951-d872f2087c98 | 1266ba494530a267ec8a21442ea1b5cae94da4fb | chrome | bigvul | 1 | null | null | null |
Fix uninitialized member in ctor.
[email protected]
[email protected]
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10377180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137606 0039d316-1c4b-4281-b951-d872f2087c98 | fd4edbad91f65bfab79276390de5db59b079fd3b | chrome | bigvul | 1 | null | null | null |
Crash fix in fileapi::FileSystemOperation::DidGetUsageAndQuotaAndRunTask
https://chromiumcodereview.appspot.com/10008047 introduced delete-with-inflight-tasks in Write sequence but I failed to convert this callback to use WeakPtr().
BUG=128178
TEST=manual test
Review URL: https://chromiumcodereview.appspot.com/10408006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137635 0039d316-1c4b-4281-b951-d872f2087c98 | 3ea4ba8af75eb37860c15d02af94f272e5bbc235 | chrome | bigvul | 1 | null | null | null |
[BlackBerry] Adapt to new BlackBerry::Platform::TouchPoint API
https://bugs.webkit.org/show_bug.cgi?id=105143
RIM PR 171941
Reviewed by Rob Buis.
Internally reviewed by George Staikos.
Source/WebCore:
TouchPoint instances now provide document coordinates for the viewport
and content position of the touch event. The pixel coordinates stored
in the TouchPoint should no longer be needed in WebKit.
Also adapt to new method names and encapsulation of TouchPoint data
members.
No change in behavior, no new tests.
* platform/blackberry/PlatformTouchPointBlackBerry.cpp:
(WebCore::PlatformTouchPoint::PlatformTouchPoint):
Source/WebKit/blackberry:
TouchPoint instances now provide document coordinates for the viewport
and content position of the touch event. The pixel coordinates stored
in the TouchPoint should no longer be needed in WebKit. One exception
is when passing events to a full screen plugin.
Also adapt to new method names and encapsulation of TouchPoint data
members.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::touchEvent):
(BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
(BlackBerry::WebKit::WebPagePrivate::dispatchTouchEventToFullScreenPlugin):
(BlackBerry::WebKit::WebPagePrivate::dispatchTouchPointAsMouseEventToFullScreenPlugin):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
* WebKitSupport/InputHandler.h:
(InputHandler):
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::doFatFingers):
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
* WebKitSupport/TouchEventHandler.h:
(TouchEventHandler):
Tools:
Adapt to new method names and encapsulation of TouchPoint data members.
* DumpRenderTree/blackberry/EventSender.cpp:
(addTouchPointCallback):
(updateTouchPointCallback):
(touchEndCallback):
(releaseTouchPointCallback):
(sendTouchEvent):
git-svn-id: svn://svn.chromium.org/blink/trunk@137880 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | d345af9ed62ee5f431be327967f41c3cc3fe936a | chrome | bigvul | 1 | null | null | null |
gdata: Define the resource ID for the root directory
Per the spec, the resource ID for the root directory is defined
as "folder:root". Add the resource ID to the root directory in our
file system representation so we can look up the root directory by
the resource ID.
BUG=127697
TEST=add unit tests
Review URL: https://chromiumcodereview.appspot.com/10332253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137928 0039d316-1c4b-4281-b951-d872f2087c98 | 40ed2b7ae4f6f5adb1b0ce9acf9c4dece339c2a6 | chrome | bigvul | 1 | null | null | null |
OpenGLShims: fix check for ANGLE GLES2 extensions
https://bugs.webkit.org/show_bug.cgi?id=111656
Patch by Sergio Correia <[email protected]> on 2013-03-07
Reviewed by Simon Hausmann.
The check for ANGLE GLES2 extensions is currently being overriden
with checks for APPLE extensions in lookupOpenGLFunctionAddress().
No new tests. No user visible behavior changed.
* platform/graphics/OpenGLShims.cpp:
(WebCore::lookupOpenGLFunctionAddress):
git-svn-id: svn://svn.chromium.org/blink/trunk@145079 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 9f5ebcc99c8cd3a19be087be38f14c99cfe9e006 | chrome | bigvul | 1 | null | null | null |
[BlackBerry] Prevent text selection inside Colour and Date/Time input fields
https://bugs.webkit.org/show_bug.cgi?id=111733
Reviewed by Rob Buis.
PR 305194.
Prevent selection for popup input fields as they are buttons.
Informally Reviewed Gen Mak.
* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
git-svn-id: svn://svn.chromium.org/blink/trunk@145121 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | f81fcab3b31dfaff3473e8eb94c6531677116242 | chrome | bigvul | 1 | null | null | null |
Remove unintentional raw_input() from policy_prefs_ui.py
Got unintentionally introduced in r144734
[email protected]
BUG= 134560
TEST=
Review URL: https://chromiumcodereview.appspot.com/10701059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145163 0039d316-1c4b-4281-b951-d872f2087c98 | b7edcbc15d68a383255b4224c985bfeef44fd027 | chrome | bigvul | 1 | null | null | null |
Refresh promo notifications as they're fetched
The "guard" existed for notification scheduling was preventing
"turn-off a promo" and "update a promo" scenarios.
Yet I do not believe it was adding any actual safety: if things
on a server backend go wrong, the clients will be affected one
way or the other, and it is better to have an option to shut
the malformed promo down "as quickly as possible" (~in 12-24 hours).
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10696204
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146462 0039d316-1c4b-4281-b951-d872f2087c98 | 7d97e1d327f153cce6137ef8b533d45d083802d9 | chrome | bigvul | 1 | null | null | null |
[Sync] Cleanup all tab sync enabling logic now that its on by default.
BUG=none
TEST=
Review URL: https://chromiumcodereview.appspot.com/10443046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139462 0039d316-1c4b-4281-b951-d872f2087c98 | fcd3a7a671ecf2d5f46ea34787d27507a914d2f5 | chrome | bigvul | 1 | null | null | null |
Removed requirement for ash::Window::transient_parent() presence for system modal dialogs.
BUG=130420
TEST=SystemModalContainerLayoutManagerTest.ModalTransientAndNonTransient
Review URL: https://chromiumcodereview.appspot.com/10514012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140647 0039d316-1c4b-4281-b951-d872f2087c98 | 3fe224d430d863880df0050faaa037b0eb00d3c0 | chrome | bigvul | 1 | null | null | null |
Quota double-delete fix
BUG=142310
Review URL: https://chromiumcodereview.appspot.com/10832407
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152532 0039d316-1c4b-4281-b951-d872f2087c98 | 58feadc64d191d834b68b8218eea4ba12b052b96 | chrome | bigvul | 1 | null | null | null |
Remove UrlFetcher from remoting and use the one in net instead.
BUG=133790
TEST=Stop and restart the Me2Me host. It should still work.
Review URL: https://chromiumcodereview.appspot.com/10637008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143798 0039d316-1c4b-4281-b951-d872f2087c98 | 7cf563aba8f4b3bab68e9bfe43824d952241dcf7 | chrome | bigvul | 1 | null | null | null |
Make chrome.appWindow.create() provide access to the child window at a predictable time.
When you first create a window with chrome.appWindow.create(), it won't have
loaded any resources. So, at create time, you are guaranteed that:
child_window.location.href == 'about:blank'
child_window.document.documentElement.outerHTML ==
'<html><head></head><body></body></html>'
This is in line with the behaviour of window.open().
BUG=131735
TEST=browser_tests:PlatformAppBrowserTest.WindowsApi
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144072
Review URL: https://chromiumcodereview.appspot.com/10644006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144356 0039d316-1c4b-4281-b951-d872f2087c98 | eb4bcacd683a68534bbe2e4d8d6eeafafc7f57ba | chrome | bigvul | 1 | null | null | null |
Unreviewed, rolling out r147402.
http://trac.webkit.org/changeset/147402
https://bugs.webkit.org/show_bug.cgi?id=112903
Source/WebCore:
* dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
LayoutTests:
* http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body.html:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny.html:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag.html:
* http/tests/security/XFrameOptions/x-frame-options-deny.html:
* http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html:
* http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html:
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
git-svn-id: svn://svn.chromium.org/blink/trunk@147450 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | a6f7726de20450074a01493e4e85409ce3f2595a | chrome | bigvul | 1 | null | null | null |
Print preview: Use an ID instead of memory pointer string in WebUI.
BUG=144051
Review URL: https://chromiumcodereview.appspot.com/10870003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153342 0039d316-1c4b-4281-b951-d872f2087c98 | 116d0963cadfbf55ef2ec3d13781987c4d80517a | chrome | bigvul | 1 | null | null | null |
Commit crop on double tap.
BUG=129741
TEST=Manual test.
Review URL: https://chromiumcodereview.appspot.com/10690005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144704 0039d316-1c4b-4281-b951-d872f2087c98 | 3db59050895db1f36314b71893872f0b3bde82c3 | chrome | bigvul | 1 | null | null | null |
Fix dictionary string usage.
BUG=144799
Review URL: https://chromiumcodereview.appspot.com/10919019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154331 0039d316-1c4b-4281-b951-d872f2087c98 | 2de493f4a1d48952e09230a0c32ccbd45db973b2 | chrome | bigvul | 1 | null | null | null |
Revert 144993 - gdata: Remove invalid files in the cache directories
Broke linux_chromeos_valgrind:
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%285%29/builds/8628/steps/memory%20test%3A%20unit/logs/stdio
In theory, we shouldn't have any invalid files left in the
cache directories, but things can go wrong and invalid files
may be left if the device shuts down unexpectedly, for instance.
Besides, it's good to be defensive.
BUG=134862
TEST=added unit tests
Review URL: https://chromiumcodereview.appspot.com/10693020
[email protected]
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145029 0039d316-1c4b-4281-b951-d872f2087c98 | baef1ffd73db183ca50c854e1779ed7f6e5100a8 | chrome | bigvul | 1 | null | null | null |
Refactors to simplify rename pathway in DownloadFileManager.
This is https://chromiumcodereview.appspot.com/10668004 / r144817 (reverted
due to CrOS failure) with the completion logic moved to after the
auto-opening. The tests that test the auto-opening (for web store install)
were waiting for download completion to check install, and hence were
failing when completion was moved earlier.
Doing this right would probably require another state (OPENED).
BUG=123998
BUG-134930
[email protected]
Review URL: https://chromiumcodereview.appspot.com/10701040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145157 0039d316-1c4b-4281-b951-d872f2087c98 | 16dcd30c215801941d9890859fd79a234128fc3e | chrome | bigvul | 1 | null | null | null |
ash: Add launcher overflow bubble.
- Host a LauncherView in bubble to display overflown items;
- Mouse wheel and two-finger scroll to scroll the LauncherView in bubble in case overflow bubble is overflown;
- Fit bubble when items are added/removed;
- Keep launcher bar on screen when the bubble is shown;
BUG=128054
TEST=Verify launcher overflown items are in a bubble instead of menu.
Review URL: https://chromiumcodereview.appspot.com/10659003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146460 0039d316-1c4b-4281-b951-d872f2087c98 | 3475f5e448ddf5e48888f3d0563245cc46e3c98b | chrome | bigvul | 1 | null | null | null |
Add RELEASE_ASSERT (and a few friends)
https://bugs.webkit.org/show_bug.cgi?id=107725
Reviewed by Filip Pizlo.
Adding a few macros to make release mode assertions easier and more readable.
Also makes same assertions more useful in debug builds.
* wtf/Assertions.h:
git-svn-id: svn://svn.chromium.org/blink/trunk@140577 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 60eedbe28e6ad4bded3501fc964baf5f2504b972 | chrome | bigvul | 1 | null | null | null |
browser: Extract AutocompleteProvider from autocomplete.*
This is the first part of splitting autocomplete.* into small pieces, one for
each class.
BUG=94842
[email protected]
[email protected]
Review URL: https://chromiumcodereview.appspot.com/10663015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144107 0039d316-1c4b-4281-b951-d872f2087c98 | 30f5bc981921d9c0221c82f38d80bd2d5c86a022 | chrome | bigvul | 1 | null | null | null |
Fix bug 130606: Panels [WIN]: Alt-Tabbing to a minimized panel no longer restores it
BUG=130606
TEST=Manual test by minimizing panel and alt-tabbing to it
Review URL: https://chromiumcodereview.appspot.com/10509011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140498 0039d316-1c4b-4281-b951-d872f2087c98 | 10c7ed8f076afd290fccf283d8bc416959722ca3 | chrome | bigvul | 1 | null | null | null |
[BlackBerry] Add graphics subdirectory to include path.
https://bugs.webkit.org/show_bug.cgi?id=109437
Patch by Mike Lattanzio <[email protected]> on 2013-02-11
Reviewed by Rob Buis.
Add browser/platform/graphics to include path.
Internal review by Jeff Rogers.
* Scripts/webkitdirs.pm:
(blackberryCMakeArguments):
git-svn-id: svn://svn.chromium.org/blink/trunk@142479 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 9e3f082c1e447f14aae9c0974cd8d61c881b14cc | chrome | bigvul | 1 | null | null | null |
Change VideoDecoder::ReadCB to take const scoped_refptr<VideoFrame>&.
BUG=none
TEST=media_unittests, media layout tests.
Review URL: https://chromiumcodereview.appspot.com/10559074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143192 0039d316-1c4b-4281-b951-d872f2087c98 | 1da0daecc540238cb473f0d6322da51d3a544244 | chrome | bigvul | 1 | null | null | null |
Fix erroneous semicolon causing build failure: if statement has empty body [-Werror,-Wempty-body]
https://bugs.webkit.org/show_bug.cgi?id=108241
Patch by Kiran Muppala <[email protected]> on 2013-01-29
Reviewed by Anders Carlsson.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addExistingWebPage): Remove erroneous
semicolon following the if condition.
git-svn-id: svn://svn.chromium.org/blink/trunk@141180 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 2bfb2b8299e2fb6a432390a93a99a85fed1d29c9 | chrome | bigvul | 1 | null | null | null |
chromeos: Send 'keypress' for the content when composing a character with dead keys
This change leaves characters outside BMP unable to be typed on docs.google.com, but surely fixes the problem for most use cases.
BUG=132668
TEST=Create a document on docs.google.com and try typing a character with dead keys (e.g. type '^'+'a' with keyboard layout "English - US international")
Review URL: https://chromiumcodereview.appspot.com/10565032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142705 0039d316-1c4b-4281-b951-d872f2087c98 | 41a7e42ef575c10375f574145e5d023118fbd149 | chrome | bigvul | 1 | null | null | null |
[BlackBerry] willComposite() and didComposite() are now in InspectorController
https://bugs.webkit.org/show_bug.cgi?id=110343
Patch by Alberto Garcia <[email protected]> on 2013-02-21
Reviewed by Carlos Garcia Campos.
This was changed in r142879.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::willComposite):
(BlackBerry::WebKit::WebPagePrivate::didComposite):
git-svn-id: svn://svn.chromium.org/blink/trunk@143584 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | aa0e1ed74972a619072341b6409dc5cacd2418aa | chrome | bigvul | 1 | null | null | null |
Uber: Don't attempt to set the title of a page that has not been loaded yet.
BUG=none
TEST=none
R=dbeam
Review URL: https://chromiumcodereview.appspot.com/9373045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121347 0039d316-1c4b-4281-b951-d872f2087c98 | e01b90a445d0de6a0b9b802d4acee10c6537d26a | chrome | bigvul | 1 | null | null | null |
[GTK][WTR] Implement AccessibilityUIElement::stringValue
https://bugs.webkit.org/show_bug.cgi?id=102951
Reviewed by Martin Robinson.
Implement AccessibilityUIElement::stringValue in the ATK backend
in the same manner it is implemented in DumpRenderTree.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::replaceCharactersForResults):
(WTR):
(WTR::AccessibilityUIElement::stringValue):
git-svn-id: svn://svn.chromium.org/blink/trunk@135485 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | b7a161633fd7ecb59093c2c56ed908416292d778 | chrome | bigvul | 1 | null | null | null |
DFG profiler should be helpful about gem installation
https://bugs.webkit.org/show_bug.cgi?id=104217
Reviewed by Oliver Hunt.
'json' and 'highline' are not installed by default on the ruby distributions with
which I am familiar, and the default error messages don't make me happy. This makes
display-profiler-output print a helpful message if those gems are not found.
* Scripts/display-profiler-output:
git-svn-id: svn://svn.chromium.org/blink/trunk@136881 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 4c1cad7424351039e56a1dd05cb6f4ab82b2934c | chrome | bigvul | 1 | null | null | null |
Remove possibility of stale user_buffer_ member in PPB_URLLoader_Impl when FinishedLoading() is called.
BUG=137778
Review URL: https://chromiumcodereview.appspot.com/10797037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147914 0039d316-1c4b-4281-b951-d872f2087c98 | 9ce8793d2a8ca2cc0cb3c26fa1ca0eef3d9bc999 | chrome | bigvul | 1 | null | null | null |
Handle a bad XSLT expression better.
BUG=138672
Review URL: https://chromiumcodereview.appspot.com/10830177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150123 0039d316-1c4b-4281-b951-d872f2087c98 | 9939d35f9827ed0929646607cbdb071af627ac38 | chrome | bigvul | 1 | null | null | null |
Fix harmless memory error in generate-id.
BUG=140368
Review URL: https://chromiumcodereview.appspot.com/10823168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149998 0039d316-1c4b-4281-b951-d872f2087c98 | e741149a6b7872a2bf1f2b6cc0a56e836592fb77 | chrome | bigvul | 1 | null | null | null |
Webkit roll 138622:138673
http://trac.webkit.org/log/?rev=138673&stop_rev=138623&verbose=on
[email protected]
BUG=
Review URL: https://chromiumcodereview.appspot.com/11722009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174951 0039d316-1c4b-4281-b951-d872f2087c98 | f82a5f8769d79d316cb0119f35d04d8d2d0bfb8a | chrome | bigvul | 1 | null | null | null |
Properly EscapeForHTML potentially malicious input from X.509 certificates.
BUG=142956
TEST=Create an X.509 certificate with a CN field that contains JavaScript.
When you get the SSL error screen, check that the HTML + JavaScript is
escape instead of being treated as HTML and/or script.
Review URL: https://chromiumcodereview.appspot.com/10827364
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152210 0039d316-1c4b-4281-b951-d872f2087c98 | 68b6502084af7e2021f7321633f5fbb5f997a58b | chrome | bigvul | 1 | null | null | null |
Aura desktop: Fix startup by setting the input method on the root window.
BUG=123160
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10492011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140366 0039d316-1c4b-4281-b951-d872f2087c98 | 00f695aec78100076c4085388ad13eafe6eaa7c1 | chrome | bigvul | 1 | null | null | null |
Don't move the window when resizing
When the GPU ode resizes the window to make it non-0x0 size, it should not move the window.
BUG=137523
Review URL: https://chromiumcodereview.appspot.com/10829206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150176 0039d316-1c4b-4281-b951-d872f2087c98 | a151041807a7e3c702c5f935a742368333aa69d4 | chrome | bigvul | 1 | null | null | null |
Prevent HTMLPreloadScanner from fetching resources inside <template>
https://bugs.webkit.org/show_bug.cgi?id=106687
Reviewed by Adam Barth.
Source/WebCore:
This patch adds a simple counter to the preload scanner which increments on template start
tag and decrements on template element. It only fetchs resources when the counter is at zero
(i.e. for elements not contained by a template element).
Test re-enabled within fast/dom/HTMLTemplateElement/inertContents.html
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):
(WebCore::HTMLPreloadScanner::processToken):
* html/parser/HTMLPreloadScanner.h:
(HTMLPreloadScanner):
LayoutTests:
* fast/dom/HTMLTemplateElement/inertContents-expected.txt:
* fast/dom/HTMLTemplateElement/inertContents.html:
git-svn-id: svn://svn.chromium.org/blink/trunk@139502 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | b82e700d70fd2309708673196eb60e1266721e2f | chrome | bigvul | 1 | null | null | null |
[Print Preview]: Added code to support pdf fit to page functionality.
BUG=85132
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10083060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137498 0039d316-1c4b-4281-b951-d872f2087c98 | 7a3439b3d169047c1c07f28a6f9cda341328980b | chrome | bigvul | 1 | null | null | null |
WebKit roll 138552:138617
WebKit roll 138552:138617
BUG=none
TBR=tdanderson
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11741002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174823 0039d316-1c4b-4281-b951-d872f2087c98 | 5000fa01173a4b4003914653aad4db3ac69680a7 | chrome | bigvul | 1 | null | null | null |
Gracefully deal with clearing content settings for unregistered extensions.
BUG=128652
Review URL: https://chromiumcodereview.appspot.com/10907093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155341 0039d316-1c4b-4281-b951-d872f2087c98 | 1a113d35a19c0ed6500fb5c0acdc35730617fb3f | chrome | bigvul | 1 | null | null | null |
Block Avast! AV DLLs in sandboxed processes.
BUG=140140
Review URL: https://chromiumcodereview.appspot.com/10852008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149909 0039d316-1c4b-4281-b951-d872f2087c98 | 930a732317022195f6ec5674f89fa4de88e2b61e | chrome | bigvul | 1 | null | null | null |
Put browser side mixing back behind a flag.
BUG=140247
TEST=Tried --enable-audio-mixer flag and observed regression.
Review URL: https://chromiumcodereview.appspot.com/10834159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149906 0039d316-1c4b-4281-b951-d872f2087c98 | 87190165c55bcf3eecd8824dd8d083f5e3236552 | chrome | bigvul | 1 | null | null | null |
Do not add 'cloudPrintID' in print preview settings, if the print destination is local.
BUG=135374
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10700074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145341 0039d316-1c4b-4281-b951-d872f2087c98 | 092b4b46923481299e5a32ffbb1edbb5ab01b062 | chrome | bigvul | 1 | null | null | null |
Fix the candidate window position of IME in Retina display.
BUG=139108
TEST=manually done
Review URL: https://chromiumcodereview.appspot.com/10825070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148916 0039d316-1c4b-4281-b951-d872f2087c98 | 8c1affafffcbb7bbc57f7b61181f200508d99e66 | chrome | bigvul | 1 | null | null | null |
Implement delegation to Metro file pickers.
[email protected],[email protected]
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10310103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136624 0039d316-1c4b-4281-b951-d872f2087c98 | eb7971fdb0c3b76bacfb77c1ecc76459ef481f17 | chrome | bigvul | 1 | null | null | null |
Set the default locale for ICU in the PPAPI process.
BUG=140432
Review URL: https://chromiumcodereview.appspot.com/10853007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149937 0039d316-1c4b-4281-b951-d872f2087c98 | 0b74c338bd286e51a004981e746cc212c2d5423c | chrome | bigvul | 1 | null | null | null |
Introduce a method to build the tree from a CompactHTMLToken
https://bugs.webkit.org/show_bug.cgi?id=107082
Reviewed by Adam Barth.
No new tests because covered by existing fast/parser tests.
* html/parser/HTMLDocumentParser.cpp:
(WebCore):
(WebCore::HTMLDocumentParser::constructTreeFromCompactHTMLToken):
* html/parser/HTMLDocumentParser.h:
* html/parser/HTMLToken.h:
(AtomicHTMLToken):
(WebCore::AtomicHTMLToken::create):
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
* xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(AtomicMarkupTokenBase):
git-svn-id: svn://svn.chromium.org/blink/trunk@139953 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | c58d6ae09d0c916b6003238de09e34f14cce758f | chrome | bigvul | 1 | null | null | null |
[Sync] Rework unit tests for ChromeInvalidationClient
In particular, add unit tests that would have caught bug 139424.
Dep-inject InvalidationClient into ChromeInvalidationClient.
Use the function name 'UpdateRegisteredIds' consistently.
Replace some mocks with fakes.
BUG=139424
Review URL: https://chromiumcodereview.appspot.com/10827133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150665 0039d316-1c4b-4281-b951-d872f2087c98 | 8a50f99c25fb70ff43aaa82b6f9569db383f0ca8 | chrome | bigvul | 1 | null | null | null |
Use display_email() for Uber Tray messages.
BUG=124087
TEST=manually
Review URL: https://chromiumcodereview.appspot.com/10388171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137721 0039d316-1c4b-4281-b951-d872f2087c98 | 92afc45a43336c468720a3143e7f2adfa882fa78 | chrome | bigvul | 1 | null | null | null |
accelerators: Remove deprecated Accelerator ctor that takes booleans.
BUG=128242
[email protected]
Review URL: https://chromiumcodereview.appspot.com/10399085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137957 0039d316-1c4b-4281-b951-d872f2087c98 | c4f40933f2cd7f975af63e56ea4cdcdc6c636f73 | chrome | bigvul | 1 | null | null | null |
[Chromium] Enable Intel's Resource Timing tests
https://bugs.webkit.org/show_bug.cgi?id=104330
Reviewed by Tony Gentilcore.
* platform/chromium/TestExpectations: 2 fail because they rely on iframes.
git-svn-id: svn://svn.chromium.org/blink/trunk@136968 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 9163cc2ff14b9489d090feebfbdf91ce89a82e6b | chrome | bigvul | 1 | null | null | null |
Make ScopedGenericObj compile with strict warnings when used with non-pointers.
No intended functionality change. Required for a future clang roll.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10310183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137361 0039d316-1c4b-4281-b951-d872f2087c98 | cec36a7bfa7411a4992820ce8639310b2b426eeb | chrome | bigvul | 1 | null | null | null |
ash: Fix right-alignment of power-status text.
It turns out setting ALING_RIGHT on a Label isn't enough to get proper
right-aligned text. Label has to be explicitly told that it is multi-lined.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9918026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129898 0039d316-1c4b-4281-b951-d872f2087c98 | e3171b346e6919f4162ea128d0f7b342cf878fd4 | chrome | bigvul | 1 | null | null | null |
[EFL] Skip css3/masking tests added in r130592
https://bugs.webkit.org/show_bug.cgi?id=98614
Unreviewed EFL gardening.
Skip the two css3/masking ref tests added in r130592 since
they fail for EFL port and GTK port.
Patch by Christophe Dumez <[email protected]> on 2012-10-07
* platform/efl/TestExpectations:
git-svn-id: svn://svn.chromium.org/blink/trunk@130595 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | fff3191f3a76c8f92bf1f8b20e8757d788308096 | chrome | bigvul | 1 | null | null | null |
[EFL][WK2] Add --window-size command line option to EFL MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=100942
Patch by Mikhail Pozdnyakov <[email protected]> on 2012-11-05
Reviewed by Kenneth Rohde Christiansen.
Added window-size (-s) command line option to EFL MiniBrowser.
* MiniBrowser/efl/main.c:
(window_create):
(parse_window_size):
(elm_main):
git-svn-id: svn://svn.chromium.org/blink/trunk@133450 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 46afbe7f7f55280947e9c06c429a68983ba9d8dd | chrome | bigvul | 1 | null | null | null |
fast/dom/shadow/content-element-in-media.html is wrong.
https://bugs.webkit.org/show_bug.cgi?id=81310
Modifying to check() to dump expected and actual text at the same
absolute position, because DumpRenderTree dumps absolute x,y-position
information for a layer which contains RenderVideo. For example,
backgroundClip at (8,163), clip at (8, 163) and so on.
Patch by Takashi Sakamoto <[email protected]> on 2012-05-27
Reviewed by Hajime Morita.
* fast/dom/resources/shadow-test-driver.js:
(check):
Disabled actual block when dumping expected block as text, and vice
versa.
* platform/chromium/test_expectations.txt:
Removed BUGWK81310.
git-svn-id: svn://svn.chromium.org/blink/trunk@118633 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 13ea6f4f06a97cd781736847795c452c9e17cacc | chrome | bigvul | 1 | null | null | null |
Prevent sandboxed processes from opening each other
TBR=brettw
BUG=117627
BUG=119150
TEST=sbox_validation_tests
Review URL: https://chromiumcodereview.appspot.com/9716027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132477 0039d316-1c4b-4281-b951-d872f2087c98 | 48fae61b8a6c9b741f001d478c595b6c7c0af4d9 | chrome | bigvul | 1 | null | null | null |
Convert plugin and GPU process to brokered handle duplication.
BUG=119250
Review URL: https://chromiumcodereview.appspot.com/9958034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132303 0039d316-1c4b-4281-b951-d872f2087c98 | cd0bd79d6ebdb72183e6f0833673464cc10b3600 | chrome | bigvul | 1 | null | null | null |
Explicitly stopping thread in MediaStreamImpl dtor to avoid any racing issues.
This may solve the below bugs.
BUG=112408,111202
TEST=content_unittests
Review URL: https://chromiumcodereview.appspot.com/9307058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120222 0039d316-1c4b-4281-b951-d872f2087c98 | 9b9a9f33f0a26f40d083be85a539dd7963adfc9b | chrome | bigvul | 1 | null | null | null |
Roll DEPS for third_party/gold updates.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9361004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120944 0039d316-1c4b-4281-b951-d872f2087c98 | 788e55493bded3addc2e501646893d7a26c812f1 | chrome | bigvul | 1 | null | null | null |
Disable crashing OfflineLoadPageTest
[email protected]
BUG=113219
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9358027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120977 0039d316-1c4b-4281-b951-d872f2087c98 | 651bc8d5bc1564e2984f6ac604560de282f4ed77 | chrome | bigvul | 1 | null | null | null |
Removing dead code from NetworkActionPredictor.
BUG=none
Review URL: http://codereview.chromium.org/9358062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121926 0039d316-1c4b-4281-b951-d872f2087c98 | dbcfe72cb16222c9f7e7907fcc5f35b27cc25331 | chrome | bigvul | 1 | null | null | null |
Mark IndexedDBBrowserTest.ClearLocalState and IndexedDBBrowserTest.SaveSessionState as flaky.
BUG=115188
TEST=
[email protected]
Review URL: https://chromiumcodereview.appspot.com/9416079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122925 0039d316-1c4b-4281-b951-d872f2087c98 | 6be59593779ed9954710589f00b0bc107d05c536 | chrome | bigvul | 1 | null | null | null |
Revert 124346 - Add basic threaded compositor test to gpu_feature_browsertest.cc
BUG=113159
Review URL: http://codereview.chromium.org/9509001
[email protected]
Review URL: https://chromiumcodereview.appspot.com/9561011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124356 0039d316-1c4b-4281-b951-d872f2087c98 | 3511b6ec1e955578ddb6e90f0cc99f824e36026e | chrome | bigvul | 1 | null | null | null |
Set the access qualifier of two methods to query frame specific info of BitmapImage to protected.
https://bugs.webkit.org/show_bug.cgi?id=90505
Patch by Huang Dongsung <[email protected]> on 2012-08-12
Reviewed by Eric Seidel.
Following 4 methods are protected.
size_t frameCount();
NativeImagePtr frameAtIndex(size_t);
bool frameIsCompleteAtIndex(size_t);
float frameDurationAtIndex(size_t);
So, 2 methds also should be protected because the frame info is only specific of
BitmapImage.
bool frameHasAlphaAtIndex(size_t);
ImageOrientation frameOrientationAtIndex(size_t);
On the other hand, this patch amended GraphicsContext3DCG.
- static_cast<BitmapImage*>(image)->frameHasAlphaAtIndex(0)
+ image->currentFrameHasAlpha()
This patch does not affect PNG, JPEG, BMP, and WEBP because those images
have only 0 indexed frame.
Thus, GIF, and ICO are affected. However, an above query to get Alpha
is for the image that is created by image->nativeImageForCurrentFrame(), so it
is proper to use image->currentFrameHasAlpha() instead of
image->frameHasAlphaAtIndex(0).
No new tests, because it is hard to test. We need an animated GIF that
one frame has alpha and another frame does not have alpha. However, I
cannot find the animated GIF file that suffices the requirement.
* platform/graphics/BitmapImage.h:
(BitmapImage):
* platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::getImageData):
git-svn-id: svn://svn.chromium.org/blink/trunk@125374 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 7c2785fab1685c8735288dfbbbb617d9c4f5d8b2 | chrome | bigvul | 1 | null | null | null |
always link chrome_shared2.css, never inline
previously we inlined because chrome_shared2.css used grit ifdefs, and there was no recursive flattening. Now there is recursive flattening, and also we don't use grit ifdefs in there any more.
(also link some more shared resources)
BUG=103688
TEST=manual
Review URL: http://codereview.chromium.org/9836049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128688 0039d316-1c4b-4281-b951-d872f2087c98 | e06c774f7cea5d52fda77b89d6536e3eeb039c7e | chrome | bigvul | 1 | null | null | null |
Retain the controller in -[DownloadItemButton rightMouseDown:] before opening the menu that targets it.
BUG=129826
TEST=See comment #18 in bug.
Review URL: https://chromiumcodereview.appspot.com/10543033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140870 0039d316-1c4b-4281-b951-d872f2087c98 | fa590d4d1e88c74356f8d3665571aeff00b681b7 | chrome | bigvul | 1 | null | null | null |
Disable OutOfProcessPPAPITest.VarDeprecated on Mac due to timeouts.
BUG=121107
[email protected],[email protected]
Review URL: https://chromiumcodereview.appspot.com/9950017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129857 0039d316-1c4b-4281-b951-d872f2087c98 | d560c6f5a89c582c9e12000adcebb4d4538a665d | chrome | bigvul | 1 | null | null | null |
Remove installer strings from chrome.dll.
They are only used by the installer (the header installer_util_strings.h
is only included in files in chrome/installer), so they don't
need to be in chrome.dll.
It looks like this was added in r1044, but I don't think it's
needed anymore.
BUG=119947
Review URL: https://chromiumcodereview.appspot.com/9809036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129947 0039d316-1c4b-4281-b951-d872f2087c98 | 7825931bdacb66eb2f41031e48484cd29dc02843 | chrome | bigvul | 1 | null | null | null |
Disable crashing test
BUG=121487
TBR=sky
TEST=
Review URL: https://chromiumcodereview.appspot.com/9950076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130276 0039d316-1c4b-4281-b951-d872f2087c98 | 1ee4f604e68b1e719394df9e8b845aee944d7ef3 | chrome | bigvul | 1 | null | null | null |
OTS roll r83:r87
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/9965099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130356 0039d316-1c4b-4281-b951-d872f2087c98 | 5b533aac9a9469ef6b38699fa89ab1f15cd5e1db | chrome | bigvul | 1 | null | null | null |
html5-full-render.html test uses substring but meant substr
https://bugs.webkit.org/show_bug.cgi?id=99495
Patch by Elliott Sprehn <[email protected]> on 2012-10-16
Reviewed by Adam Barth.
This test intended to chunk up the HTML5 spec into chunks of 500k chars, but used
substring(to,from) instead of substr(from,length) so it actually loaded 5x more
content than was in the HTML5 spec.
* Parser/html5-full-render.html:
git-svn-id: svn://svn.chromium.org/blink/trunk@131553 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 6fbd919a944a34bc9f9a4585d6ec6b6cb538dd91 | chrome | bigvul | 1 | null | null | null |
[V8] ASSERT that removeAllDOMObjects() is called only on worker threads
https://bugs.webkit.org/show_bug.cgi?id=100046
Reviewed by Eric Seidel.
This function is called only on worker threads. We should ASSERT that
fact and remove the dead code that tries to handle the main thread
case.
* bindings/v8/V8DOMMap.cpp:
(WebCore::removeAllDOMObjects):
git-svn-id: svn://svn.chromium.org/blink/trunk@132156 bbb929c8-8fbe-4397-9dbb-9b2b20218538 | 1595f66a8dec04864afd048809cd9d0802049feb | chrome | bigvul | 1 | null | null | null |
Roll FFmpeg to pick up security fixes.
Pulls in the following security fixes:
59c122b matroskadec: add assert on lack of overflow in pkt_size+offset
4b7c523 matroskadec: change size check in matroska_decode_buffer() to unsigned
08169fc matroskadec: move lace_size check up so it catches all code pathes
88a740a matroskadec: change assert to av_assert0()
71529bd Fix incorrect unsigned->signed conversion.
Adds a new test for the issue.
BUG=132779
TEST=ffmpeg_regression_tests, video test matrix.
TBR=scherkus
Review URL: https://chromiumcodereview.appspot.com/10546180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142328 0039d316-1c4b-4281-b951-d872f2087c98 | 00a9b5471ffdd02f36b6c788fab8dcd9fb13d451 | chrome | bigvul | 1 | null | null | null |
Fix crash with unexpected DTD nodes in XSLT.
BUG=127417
Review URL: https://chromiumcodereview.appspot.com/10441148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140041 0039d316-1c4b-4281-b951-d872f2087c98 | bb7bfb81c158268fb242292b7e0fbd2d3b933d09 | chrome | bigvul | 1 | null | null | null |
Attempt to address libxml crash.
BUG=129930
Review URL: https://chromiumcodereview.appspot.com/10458051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142822 0039d316-1c4b-4281-b951-d872f2087c98 | f183580d61c054f7f6bb35cfe29e1b342390fbeb | chrome | bigvul | 1 | null | null | null |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.