commit_msg
stringlengths
1
24.2k
commit_hash
stringlengths
2
84
project
stringlengths
2
40
source
stringclasses
4 values
labels
int64
0
1
repo_url
stringlengths
26
70
commit_url
stringlengths
74
118
commit_date
stringlengths
25
25
Add documentation for the EVP_CIPHER_CTX_cipher_data functions The new pipeline code added a new function EVP_CIPHER_CTX_set_cipher_data(). Add documentation for this and the existing EVP_CIPHER_CTX_cipher_data() function. Reviewed-by: Tim Hudson <[email protected]>
ccd82ef4c2ca0b1e931e8f6e5f3848a2110b8680
openssl
neuralsentry
0
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/ccd82ef4c2ca0b1e931e8f6e5f3848a2110b8680
2016-02-16 14:00:55+00:00
bugfix in cmac calculation example The example never executes code inside of the while loop, as read() returns bigger number than 0. Thus the end result is wrong. CLA: trivial Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from https://github.com/openssl/openssl/pull/11143)
38e6c4907e3b81f05d384d2c938c55762221de63
openssl
neuralsentry
1
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/38e6c4907e3b81f05d384d2c938c55762221de63
2020-02-21 09:41:29+02:00
Add a test for CVE-2017-3737 Test reading/writing to an SSL object after a fatal error has been detected. This CVE only affected 1.0.2, but we should add it to other branches for completeness. Reviewed-by: Viktor Dukhovni <[email protected]>
97652f0b3a557876462ef30373ac5eeeaa88b295
openssl
neuralsentry
0
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/97652f0b3a557876462ef30373ac5eeeaa88b295
2017-11-29 13:56:15+00:00
QUIC QSM: Minor bugfixes Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from https://github.com/openssl/openssl/pull/20765)
8b5278942be94b5764b93c0633ea4162685264ac
openssl
neuralsentry
1
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/8b5278942be94b5764b93c0633ea4162685264ac
2023-04-18 19:30:56+01:00
NGX-2040 - fix wildcard match on punycode/IDNA DNS names - bugfix: should not treat '--' as invalid domain substring. - '-' should not be the first letter of a domain Signed-off-by: Viktor Dukhovni <[email protected]> Reviewed-by: Rich Salz <[email protected]>
9f9a39267f6c752af0905d77062b00671b1b60c6
openssl
neuralsentry
1
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/9f9a39267f6c752af0905d77062b00671b1b60c6
2016-01-15 14:31:11-05:00
Fix ASN1_INTEGER handling. Only treat an ASN1_ANY type as an integer if it has the V_ASN1_INTEGER tag: V_ASN1_NEG_INTEGER is an internal only value which is never used for on the wire encoding. Thanks to David Benjamin <[email protected]> for reporting this bug. This was found using libFuzzer. RT#4364 (part)CVE-2016-2108. Reviewed-by: Emilia Käsper <[email protected]>
d7ab691bc479d3cf2eea07329db6ce0e2589f0b9
openssl
neuralsentry
1
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/d7ab691bc479d3cf2eea07329db6ce0e2589f0b9
2016-04-15 02:37:09+01:00
Extend X509 cert checks and error reporting in v3_{purp,crld}.c and x509_{set,vfy}.c add various checks for malformedness to static check_chain_extensions() in x509_vfc.c improve error reporting of X509v3_cache_extensions() in v3_purp.c add error reporting to x509_init_sig_info() in x509_set.c improve static setup_dp() and related functions in v3_purp.c and v3_crld.c add test case for non-conforming cert from https://tools.ietf.org/html/rfc8410#section-10.2 Reviewed-by: Kurt Roeckx <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from https://github.com/openssl/openssl/pull/12478)
1e41dadfa7b9f792ed0f4714a3d3d36f070cf30e
openssl
neuralsentry
0
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/1e41dadfa7b9f792ed0f4714a3d3d36f070cf30e
2020-06-27 16:16:12+02:00
Add a test for CVE-2022-4450 Call PEM_read_bio_ex() and expect a failure. There should be no dangling ptrs and therefore there should be no double free if we free the ptrs on error. Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]>
dc341a46677fe19f055bd2eea0e3a2af21053903
openssl
neuralsentry
0
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/dc341a46677fe19f055bd2eea0e3a2af21053903
2022-12-13 15:02:26+00:00
Bugfix: Encode the requested length in s_cb.c:hexencode() Reviewed-by: Rich Salz <[email protected]>
b5f40eb279e37c86d0634db5ffcc37517ea97694
openssl
neuralsentry
1
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/b5f40eb279e37c86d0634db5ffcc37517ea97694
2016-03-16 23:58:58-04:00
Fix a few misspellings. Reviewed-by: Rich Salz <[email protected]> Reviewed-by: Matt Caswell <[email protected]> (Merged from https://github.com/openssl/openssl/pull/1618)
48722ff5f0988128c85e3cd3169d6457d6450c11
openssl
neuralsentry
0
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/48722ff5f0988128c85e3cd3169d6457d6450c11
2016-11-17 23:55:43+01:00
OSSL_STORE_expect(): Improve error handling and documentation Reviewed-by: Tomas Mraz <[email protected]> (Merged from https://github.com/openssl/openssl/pull/15029)
6e328484ab17f671134077962ce1aa392e512423
openssl
neuralsentry
0
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/6e328484ab17f671134077962ce1aa392e512423
2021-04-26 14:57:05+02:00
ts: fix memleaks caused by TS_VERIFY_CTX_set_imprint CLA: trivial Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from https://github.com/openssl/openssl/pull/16347)
62bae84d4587ec9a56d0ce830e36e4a5b2fa8a33
openssl
neuralsentry
1
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/62bae84d4587ec9a56d0ce830e36e4a5b2fa8a33
2021-08-18 15:40:22+08:00
Fix the spelling of "implement". Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Rich Salz <[email protected]>
085b3860651e2ff55e28f8a28a1f66b1a3fe538f
openssl
neuralsentry
0
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/085b3860651e2ff55e28f8a28a1f66b1a3fe538f
2016-04-13 23:43:07+03:00
Improve error handling in rand_init function Reviewed-by: Rich Salz <[email protected]> (Merged from https://github.com/openssl/openssl/pull/6124)
0e5c1a66f7911352a4db3bda2293b91858b9f33c
openssl
neuralsentry
0
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/0e5c1a66f7911352a4db3bda2293b91858b9f33c
2018-04-28 20:35:54+02:00
bn/asm/rsaz-avx2.pl: fix digit correction bug in rsaz_1024_mul_avx2. Credit to OSS-Fuzz for finding this. CVE-2017-3738 Reviewed-by: Rich Salz <[email protected]>
5630661aecbea5fe3c4740f5fea744a1f07a6253
openssl
neuralsentry
1
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/5630661aecbea5fe3c4740f5fea744a1f07a6253
2017-11-24 11:35:50+01:00
Fix the RSA_SSLV23_PADDING padding type This also fixes the public function RSA_padding_check_SSLv23. Commit 6555a89 changed the padding check logic in RSA_padding_check_SSLv23 so that padding is rejected if the nul delimiter byte is not immediately preceded by at least 8 bytes containing 0x03. Prior to that commit the padding is rejected if it *is* preceded by at least 8 bytes containing 0x03. Presumably this change was made to be consistent with what it says in appendix E.3 of RFC 5246. Unfortunately that RFC is in error, and the original behaviour was correct. This is fixed in later errata issued for that RFC. This has no impact on libssl for modern versions of OpenSSL because there is no protocol support for SSLv2 in these versions. However applications that call RSA_paddin_check_SSLv23 directly, or use the RSA_SSLV23_PADDING mode may still be impacted. The effect of the original error is that an RSA message encrypted by an SSLv2 only client will fail to be decrypted properly by a TLS capable server, or a message encrypted by a TLS capable client will fail to decrypt on an SSLv2 only server. Most significantly an RSA message encrypted by a TLS capable client will be successfully decrypted by a TLS capable server. This last case should fail due to a rollback being detected. Thanks to D. Katz and Joel Luellwitz (both from Trustwave) for reporting this issue. CVE-2021-23839 Reviewed-by: Paul Dale <[email protected]>
d9461cbe87b91fec98c4ab99a6f47621390e4aa2
openssl
neuralsentry
1
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/d9461cbe87b91fec98c4ab99a6f47621390e4aa2
2021-01-22 16:38:50+00:00
bugfix in ossl_cmp_msg_add_extraCerts(): should include cert chain when using PBM Reviewed-by: Tim Hudson <[email protected]> (Merged from https://github.com/openssl/openssl/pull/12822)
61994781011ba4dde5b546971623ce6590d5d60f
openssl
neuralsentry
1
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/61994781011ba4dde5b546971623ce6590d5d60f
2020-09-04 10:58:26+02:00
Prevent EBCDIC overread for very long strings ASN1 Strings that are over 1024 bytes can cause an overread in applications using the X509_NAME_oneline() function on EBCDIC systems. This could result in arbitrary stack data being returned in the buffer. Issue reported by Guido Vranken. CVE-2016-2176 Reviewed-by: Andy Polyakov <[email protected]>
ea96ad5a206b7b5f25dad230333e8ff032df3219
openssl
neuralsentry
1
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/ea96ad5a206b7b5f25dad230333e8ff032df3219
2016-04-28 10:46:55+01:00
EVP: fix memleak in evp_pkey_downgrade() The EVP_KEYMGMT pointer in the pkey is removed when downgrading, but wasn't necessarily freed when need, thus leaving an incorrect reference count. Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Nicola Tuveri <[email protected]> (Merged from https://github.com/openssl/openssl/pull/11328)
49276c3569656a17c24517ff0781967ced2c9658
openssl
neuralsentry
1
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/49276c3569656a17c24517ff0781967ced2c9658
2020-04-11 13:16:22+02:00
GH601: Various spelling fixes. Signed-off-by: Rich Salz <[email protected]> Reviewed-by: Matt Caswell <[email protected]>
0d4fb8439092ff8253af72ac6bc193e77ebbcf2f
openssl
neuralsentry
0
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/0d4fb8439092ff8253af72ac6bc193e77ebbcf2f
2016-02-05 15:23:54-05:00
Fix a few memleaks in TXT_DB. Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Rich Salz <[email protected]> (Merged from https://github.com/openssl/openssl/pull/2684)
9ad52c562a93c9a57ae3024e54c575430753244c
openssl
neuralsentry
1
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/9ad52c562a93c9a57ae3024e54c575430753244c
2017-02-19 18:12:03+01:00
Don't set choice selector on parse failure. Don't set choice selector on parse failure: this can pass unexpected values to the choice callback. Instead free up partial structure directly. CVE-2016-7053 Thanks to Tyler Nighswander of ForAllSecure for reporting this issue. Reviewed-by: Richard Levitte <[email protected]>
f962541d0be200055e508641ddf3a8ec8819e4df
openssl
neuralsentry
1
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/f962541d0be200055e508641ddf3a8ec8819e4df
2016-10-14 11:51:43+01:00
Put DES into "not default" category. Add CVE to CHANGES Reviewed-by: Emilia Käsper <[email protected]>
ef28891bab7054667f2f6739f6d376c38b3ca1cc
openssl
neuralsentry
1
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/ef28891bab7054667f2f6739f6d376c38b3ca1cc
2016-08-18 08:56:42-04:00
Prevent an overflow if an application supplies a buffer that is too small If an application bug means that a buffer smaller than is necessary is passed to various functions then OpenSSL does not spot that the buffer is too small and fills it anyway. This PR prevents that. Since it requires an application bug to hit this problem, no CVE is allocated. Thanks to David Benjamin for reporting this issue. Reviewed-by: Tomas Mraz <[email protected]> (Merged from https://github.com/openssl/openssl/pull/16789)
43da9a14f0e73f42f28ae34219929b44df5d1a11
openssl
neuralsentry
1
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/43da9a14f0e73f42f28ae34219929b44df5d1a11
2021-10-07 11:33:17+01:00
fix spelling of Camellia in comment Reviewed-by: Andy Polyakov <[email protected]> Reviewed-by: Rich Salz <[email protected]> (Merged from https://github.com/openssl/openssl/pull/2337)
9bb6f82958537b9ab5ec8fe44c762f448d4a59d8
openssl
neuralsentry
0
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/9bb6f82958537b9ab5ec8fe44c762f448d4a59d8
2017-02-02 09:56:47+10:00
Add -new and -subj options to x509 app for direct cert generation Complete and improve error output of parse_name() in apps/apps.c Reviewed-by: Viktor Dukhovni <[email protected]> Reviewed-by: Paul Dale <[email protected]> (Merged from https://github.com/openssl/openssl/pull/8193)
529586085e38487d45974817d4f3ff40f30e19f6
openssl
neuralsentry
0
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/529586085e38487d45974817d4f3ff40f30e19f6
2019-03-19 09:35:03+10:00
Fix an error code spelling. Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Rich Salz <[email protected]>
2b0bcfaf834e2fb7cd52888d7330b247e3878115
openssl
neuralsentry
0
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/2b0bcfaf834e2fb7cd52888d7330b247e3878115
2016-04-04 20:42:27+02:00
Fixed a spelling mistake in ASN1_TIME_set.pod Reviewed-by: Tim Hudson <[email protected]> Reviewed-by: Rich Salz <[email protected]> (Merged from https://github.com/openssl/openssl/pull/5569)
d47eaaf41f67b0c3521a53aed6b4c4458417f791
openssl
neuralsentry
0
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/d47eaaf41f67b0c3521a53aed6b4c4458417f791
2018-03-09 07:11:13-05:00
Avoid overflow in MDC2_Update() Thanks to Shi Lei for reporting this issue. CVE-2016-6303 Reviewed-by: Matt Caswell <[email protected]>
55d83bf7c10c7b205fffa23fa7c3977491e56c07
openssl
neuralsentry
1
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/55d83bf7c10c7b205fffa23fa7c3977491e56c07
2016-08-19 23:28:29+01:00
Revert "various spelling fixes" This reverts commit 620d540bd47a96fb6905fbbdd8ea5167a8841a3e. It wasn't reviewed. Reviewed-by: Rich Salz <[email protected]>
e771eea6d8ca3caa48076367ee86c3b55249dcb3
openssl
neuralsentry
0
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/e771eea6d8ca3caa48076367ee86c3b55249dcb3
2016-04-04 16:11:43-04:00
test/memleaktest.c: Modify for use with address/leak sanitizer Detects if leak sanitizing is on, and directs the exit code accordingly. Note that this program is designed to fail when leaking, as that's expected, so to make it easy for wrapper scripts, we also make it look like it fails when sanitizing isn't on. Reviewed-by: Paul Dale <[email protected]> (Merged from https://github.com/openssl/openssl/pull/9294)
ea7a952c8aab33d0bb0a2bbd210305d722a5702b
openssl
neuralsentry
0
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/ea7a952c8aab33d0bb0a2bbd210305d722a5702b
2019-11-25 17:13:10+01:00
Ensure bn_cmp_words can handle the case where n == 0 Thanks to David Benjamin who reported this, performed the analysis and suggested the patch. I have incorporated some of his analysis in the comments below. This issue can cause an out-of-bounds read. It is believed that this was not reachable until the recent "fixed top" changes. Analysis has so far only identified one code path that can encounter this - although it is possible that others may be found. The one code path only impacts 1.0.2 in certain builds. The fuzzer found a path in RSA where iqmp is too large. If the input is all zeros, the RSA CRT logic will multiply a padded zero by iqmp. Two mitigating factors: - Private keys which trip this are invalid (iqmp is not reduced mod p). Only systems which take untrusted private keys care. - In OpenSSL 1.1.x, there is a check which rejects the oversize iqmp, so the bug is only reproducible in 1.0.2 so far. Fortunately, the bug appears to be relatively harmless. The consequences of bn_cmp_word's misbehavior are: - OpenSSL may crash if the buffers are page-aligned and the previous page is non-existent. - OpenSSL will incorrectly treat two BN_ULONG buffers as not equal when they are equal. - Side channel concerns. The first is indeed a concern and is a DoS bug. The second is fine in this context. bn_cmp_word and bn_cmp_part_words are used to compute abs(a0 - a1) in Karatsuba. If a0 = a1, it does not matter whether we use a0 - a1 or a1 - a0. The third would be worth thinking about, but it is overshadowed by the entire Karatsuba implementation not being constant time. Due to the difficulty of tripping this and the low impact no CVE is felt necessary for this issue. Reviewed-by: Paul Dale <[email protected]> Reviewed-by: Viktor Dukhovni <[email protected]> (Merged from https://github.com/openssl/openssl/pull/8326)
576129cd72ae054d246221f111aabf42b9c6d76d
openssl
neuralsentry
1
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/576129cd72ae054d246221f111aabf42b9c6d76d
2019-02-25 11:28:32+00:00
Bugfix: unsafe return check of EVP_PKEY_fromdata_init Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Richard Levitte <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from https://github.com/openssl/openssl/pull/16783)
5e199c356d09aca3b625b5ea16966b36d24b0201
openssl
neuralsentry
1
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/5e199c356d09aca3b625b5ea16966b36d24b0201
2021-10-08 16:59:00+08:00
Fix spelling Reviewed-by: Rich Salz <[email protected]>
6ba5dd341b9b2304de1478fece9ed25a4b15483c
openssl
neuralsentry
0
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/6ba5dd341b9b2304de1478fece9ed25a4b15483c
2016-02-18 00:11:18+01:00
memleaktest with MSVC's AddressSanitizer Disabling memleaktest under MSVC because leak detection is not a supported feature with MSVC's AddressSanitizer. Leaving ASan enabled in this case causes a test failure because the test suite is expecting the leak to be detected. CLA: trivial Reviewed-by: Shane Lontis <[email protected]> Reviewed-by: Tomas Mraz <[email protected]> (Merged from https://github.com/openssl/openssl/pull/14581)
d97adfda2868aeb9e62df96216203e8120a95d6d
openssl
neuralsentry
0
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/d97adfda2868aeb9e62df96216203e8120a95d6d
2021-03-19 13:54:05-07:00
Fix a memleak in ec_copy_parameters. Reviewed-by: Matt Caswell <[email protected]> Reviewed-by: Rich Salz <[email protected]> (Merged from https://github.com/openssl/openssl/pull/3666)
188a9bd950837c70661aa6849894e4e02d129031
openssl
neuralsentry
1
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/188a9bd950837c70661aa6849894e4e02d129031
2017-06-13 07:22:50+02:00
Fix memleaks in KDF implementations Reviewed-by: Paul Dale <[email protected]> (Merged from https://github.com/openssl/openssl/pull/9662)
df2f8af4cb3e19fe5a1ed41582d1659aa6c4ef50
openssl
neuralsentry
1
https://github.com/openssl/openssl
https://github.com/openssl/openssl/commit/df2f8af4cb3e19fe5a1ed41582d1659aa6c4ef50
2019-08-30 14:35:43+02:00
Accept "+infinity" in date and timestamp[tz] input. The float and numeric types accept this variant spelling of "infinity", so it seems like the datetime types should too. Vik Fearing, some cosmetic mods by me Discussion: https://postgr.es/m/[email protected]
2ceea5adb02603ef52579b568ca2c5aebed87358
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/2ceea5adb02603ef52579b568ca2c5aebed87358
2023-01-01 14:16:07-05:00
Adapt hashfn.c and hashutils.h for frontend use. hash_any() and its various variants are defined to return Datum, which is a backend-only concept, but the underlying functions actually want to return uint32 and uint64, and only return Datum because it's convenient for callers who are using them to implement a hash function for some SQL datatype. However, changing these functions to return uint32 and uint64 seems like it might lead to programming errors or back-patching difficulties, both because they are widely used and because failure to use UInt{32,64}GetDatum() might not provoke a compilation error. Instead, rename the existing functions as well as changing the return type, and add static inline wrappers for those callers that need the previous behavior. Although this commit adapts hashutils.h and hashfn.c so that they can be compiled as frontend code, it does not actually do anything that would cause them to be so compiled. That is left for another commit. Patch by me, reviewed by Suraj Kharage and Mark Dilger. Discussion: http://postgr.es/m/CA+TgmoaRiG4TXND8QuM6JXFRkM_1wL2ZNhzaUKsuec9-4yrkgw@mail.gmail.com
a91e2fa94180f24dd68fb6c99136cda820e02089
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/a91e2fa94180f24dd68fb6c99136cda820e02089
2020-02-24 17:27:15+05:30
Add "Slab" MemoryContext implementation for efficient equal-sized allocations. The default general purpose aset.c style memory context is not a great choice for allocations that are all going to be evenly sized, especially when those objects aren't small, and have varying lifetimes. There tends to be a lot of fragmentation, larger allocations always directly go to libc rather than have their cost amortized over several pallocs. These problems lead to the introduction of ad-hoc slab allocators in reorderbuffer.c. But it turns out that the simplistic implementation leads to problems when a lot of objects are allocated and freed, as aset.c is still the underlying implementation. Especially freeing can easily run into O(n^2) behavior in aset.c. While the O(n^2) behavior in aset.c can, and probably will, be addressed, custom allocators for this behavior are more efficient both in space and time. This allocator is for evenly sized allocations, and supports both cheap allocations and freeing, without fragmenting significantly. It does so by allocating evenly sized blocks via malloc(), and carves them into chunks that can be used for allocations. In order to release blocks to the OS as early as possible, chunks are allocated from the fullest block that still has free objects, increasing the likelihood of a block being entirely unused. A subsequent commit uses this in reorderbuffer.c, but a further allocator is needed to resolve the performance problems triggering this work. There likely are further potentialy uses of this allocator besides reorderbuffer.c. There's potential further optimizations of the new slab.c, in particular the array of freelists could be replaced by a more intelligent structure - but for now this looks more than good enough. Author: Tomas Vondra, editorialized by Andres Freund Reviewed-By: Andres Freund, Petr Jelinek, Robert Haas, Jim Nasby Discussion: https://postgr.es/m/[email protected]
58b25e98106dbe062cec0f3d31d64977bffaa4af
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/58b25e98106dbe062cec0f3d31d64977bffaa4af
2017-02-27 03:41:44-08:00
Add "headerscheck" script to test header-file compilability under C. We already had "cpluspluscheck", which served the dual purposes of verifying that headers compile standalone and that they compile as C++. However, C++ compilers don't have the exact same set of error conditions as C compilers, so this doesn't really prove that a header will compile standalone as C. Hence, add a second script that's largely similar but runs the C compiler not C++. Also add a bit more documentation than the none-at-all we had before. Discussion: https://postgr.es/m/[email protected]
55ea109188474dae22d90f743d7189a8bdf94d49
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/55ea109188474dae22d90f743d7189a8bdf94d49
2019-08-19 14:22:56-04:00
Add "LP_DEAD item?" column to GiST pageinspect functions This brings gist_page_items() and gist_page_items_bytea() in line with nbtree's bt_page_items() function. Minor follow-up to commit 756ab291, which added the GiST functions. Author: Andrey Borodin <[email protected]> Discussion: https://postgr.es/m/[email protected]
9e596b65f430fcb942685b41860b323398a88873
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/9e596b65f430fcb942685b41860b323398a88873
2021-02-14 20:11:11-08:00
Accept that server might not be able to send error in crash recovery test. As it turns out we can't rely that the script's monitoring session is terminated with a proper error by the server, because the session might be terminated while already trying to send data. Also improve robustness and error reporting facilities of the test, developed while debugging this issue. Discussion: https://postgr.es/m/[email protected]
5ada1fcd0c30be1b0b793a802cf6da386a6c1925
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/5ada1fcd0c30be1b0b793a802cf6da386a6c1925
2017-09-19 21:29:51-07:00
Add ALTER .. NO DEPENDS ON Commit f2fcad27d59c (9.6 era) added the ability to mark objects as dependent an extension, but forgot to add a way for such dependencies to be removed. This commit fixes that oversight. Strictly speaking this should be backpatched to 9.6, but due to lack of demand we're not doing so at this time. Discussion: https://postgr.es/m/[email protected] Reviewed-by: ahsan hadi <[email protected]> Reviewed-by: Ibrar Ahmed <[email protected]> Reviewed-by: Tom Lane <[email protected]>
5fc703946bf3b18642ce83b937671d254a8ac5b5
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/5fc703946bf3b18642ce83b937671d254a8ac5b5
2020-04-20 13:42:12-04:00
Prevent buffer overrun in read_tablespace_map(). Robert Foggia of Trustwave reported that read_tablespace_map() fails to prevent an overrun of its on-stack input buffer. Since the tablespace map file is presumed trustworthy, this does not seem like an interesting security vulnerability, but still we should fix it just in the name of robustness. While here, document that pg_basebackup's --tablespace-mapping option doesn't work with tar-format output, because it doesn't. To make it work, we'd have to modify the tablespace_map file within the tarball sent by the server, which might be possible but I'm not volunteering. (Less-painful solutions would require changing the basebackup protocol so that the source server could adjust the map. That's not very appetizing either.)
a50e4fd028a1ece2b1a04df2c9ae6581783e9eef
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/a50e4fd028a1ece2b1a04df2c9ae6581783e9eef
2021-03-17 16:10:37-04:00
Force certain "pljava" custom GUCs to be PGC_SUSET. Future PL/Java versions will close CVE-2016-0766 by making these GUCs PGC_SUSET. This PostgreSQL change independently mitigates that PL/Java vulnerability, helping sites that update PostgreSQL more frequently than PL/Java. Back-patch to 9.1 (all supported versions).
f4aa3a18a20d51575562520754aa376b3b08b2d0
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/f4aa3a18a20d51575562520754aa376b3b08b2d0
2016-02-05 20:22:51-05:00
Accept "B" in all memory-unit GUCs, and improve error messages. Commit 6e7baa3227 added support for "B" unit, for specifying config options in bytes. However, it was only accepted in GUC_UNIT_BYTE settings, wal_segment_size and track_activity_query_size, and not e.g. in work_mem. This patch makes it consistent, so that "B" accepted in all the same contexts where "kB", "MB", and so forth are accepted. Add "B" to the list of accepted units in the error hint, along with "kB", "MB", etc. Add an entry in the conversion table for "TB" to "B" conversion. A terabyte is out of range for any GUC_UNIT_BYTE option, so you always get an "out of range" error with that, but without it, you get a confusing error message that claims that "TB" is not an accepted unit, with a hint that nevertheless lists "TB" as an accepted unit. Reviewed-by: Alexander Korotkov, Andres Freund Discussion: https://www.postgresql.org/message-id/[email protected]
b06d8e58b5ac257c2119312c47c4a0f233c5e0ca
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/b06d8e58b5ac257c2119312c47c4a0f233c5e0ca
2018-05-23 10:02:40+03:00
Add 'missing_ok' argument to build_attrmap_by_name When it's given as true, return a 0 in the position of the missing column rather than raising an error. This is currently unused, but it allows us to reimplement column permission checking in a subsequent commit. It seems worth breaking into a separate commit because it affects unrelated code. Author: Amit Langote <[email protected]> Discussion: https://postgr.es/m/CA+HiwqFfiai=qBxPDTjaio_ZcaqUKh+FC=prESrB8ogZgFNNNQ@mail.gmail.com
ad86d159b6ab90b195b06fb5c7b593900a7f9cd8
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/ad86d159b6ab90b195b06fb5c7b593900a7f9cd8
2022-11-29 09:39:36+01:00
Add Bloom filter implementation. A Bloom filter is a space-efficient, probabilistic data structure that can be used to test set membership. Callers will sometimes incur false positives, but never false negatives. The rate of false positives is a function of the total number of elements and the amount of memory available for the Bloom filter. Two classic applications of Bloom filters are cache filtering, and data synchronization testing. Any user of Bloom filters must accept the possibility of false positives as a cost worth paying for the benefit in space efficiency. This commit adds a test harness extension module, test_bloomfilter. It can be used to get a sense of how the Bloom filter implementation performs under varying conditions. This is infrastructure for the upcoming "heapallindexed" amcheck patch, which verifies the consistency of a heap relation against one of its indexes. Author: Peter Geoghegan Reviewed-By: Andrey Borodin, Michael Paquier, Thomas Munro, Andres Freund Discussion: https://postgr.es/m/CAH2-Wzm5VmG7cu1N-H=nnS57wZThoSDQU+F5dewx3o84M+jY=g@mail.gmail.com
51bc271790eb234a1ba4d14d3e6530f70de92ab5
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/51bc271790eb234a1ba4d14d3e6530f70de92ab5
2018-03-31 17:49:41-07:00
Fix tab completion for ALTER ... TABLESPACE ... OWNED BY. Previously the completion used the wrong word to match 'BY'. This was introduced brokenly, in b2de2a. While at it, also add completion of IN TABLESPACE ... OWNED BY and fix comments referencing nonexistent syntax. Reported-By: Michael Paquier Author: Michael Paquier and Andres Freund Discussion: CAB7nPqSHDdSwsJqX0d2XzjqOHr==HdWiubCi4L=Zs7YFTUne8w@mail.gmail.com Backpatch: 9.4, like the commit introducing the bug
130d94a7b868f5b6df512e5fde94a64e5e71178b
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/130d94a7b868f5b6df512e5fde94a64e5e71178b
2015-12-19 17:37:11+01:00
Eat XIDs more efficiently in recovery TAP test. The point of this loop is to insert 1000 rows into the test table and consume 1000 XIDs. I can't see any good reason why it's useful to launch 1000 psqls and 1000 backend processes to accomplish that. Pushing the looping into a plpgsql DO block shaves about 10 seconds off the runtime of the src/test/recovery TAP tests on my machine; that's over 10% of the runtime of that test suite. It is, in fact, sufficiently more efficient that we now demonstrably need wait_slot_xmins() afterwards, or the slaves' xmins may not have moved yet.
08aed6604de2e6a9f4d499818d7c641cbf5eb9f7
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/08aed6604de2e6a9f4d499818d7c641cbf5eb9f7
2017-06-28 22:11:12-04:00
Fix some documentation about access methods Author: Guillaume Lelarge Discussion: https://postgr.es/m/CAECtzeWPz4JikzUqZdMjqPTe8dAP3nZxPD-58Y-Hhvirg0fF+A@mail.gmail.com
56b78626c7288fad498c0fae7fe4fd1f240ed13f
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/56b78626c7288fad498c0fae7fe4fd1f240ed13f
2019-05-29 11:37:37-04:00
Disable anonymous record hash support except in special cases Commit 01e658fa74 added hash support for row types. This also added support for hashing anonymous record types, using the same approach that the type cache uses for comparison support for record types: It just reports that it works, but it might fail at run time if a component type doesn't actually support the operation. We get away with that for comparison because most types support that. But some types don't support hashing, so the current state can result in failures at run time where the planner chooses hashing over sorting, whereas that previously worked if only sorting was an option. We do, however, want the record hashing support for path tracking in recursive unions, and the SEARCH and CYCLE clauses built on that. In that case, hashing is the only plan option. So enable that, this commit implements the following approach: The type cache does not report that hashing is available for the record type. This undoes that part of 01e658fa74. Instead, callers that require hashing no matter what can override that result themselves. This patch only touches the callers to make the aforementioned recursive query cases work, namely the parse analysis of unions, as well as the hash_array() function. Reported-by: Sait Talha Nisanci <[email protected]> Bug: #17158 Discussion: https://www.postgresql.org/message-id/flat/17158-8a2ba823982537a4%40postgresql.org
a3d2b1bbe904b0ca8d9fdde20f25295ff3e21f79
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/a3d2b1bbe904b0ca8d9fdde20f25295ff3e21f79
2021-09-08 09:25:46+02:00
Fix crash with old libxml2 Certain libxml2 versions (such as the 2.7.6 commonly seen in older distributions, but apparently only on x86_64) contain a bug that causes xmlCopyNode, when called on a XML_DOCUMENT_NODE, to return a node that xmlFreeNode crashes on. Arrange to call xmlFreeDoc instead of xmlFreeNode for those nodes. Per buildfarm members lapwing and grison. Author: Pavel Stehule, light editing by Álvaro. Discussion: https://postgr.es/m/[email protected]
2e616dee9e601d36462dc4cc48eb0b6a1ff20051
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/2e616dee9e601d36462dc4cc48eb0b6a1ff20051
2019-03-08 19:13:25-03:00
Fix severe memory leaks in GSSAPI encryption support. Both the backend and libpq leaked buffers containing encrypted data to be transmitted, so that the process size would grow roughly as the total amount of data sent. There were also far-less-critical leaks of the same sort in GSSAPI session establishment. Oversight in commit b0b39f72b, which I failed to notice while reviewing the code in 2c0cdc818. Per complaint from pmc@citylink. Back-patch to v12 where this code was introduced. Discussion: https://postgr.es/m/[email protected]
46da7bf671c002659d48dad72d325167db8df84b
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/46da7bf671c002659d48dad72d325167db8df84b
2020-05-05 13:10:09-04:00
Doc: Fix some spelling mistakes Author: Daniel Gustafsson Discussion: https://postgr.es/m/[email protected]
8f3c06c5d56fc0fa414bcf548860ac50a8fe5982
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/8f3c06c5d56fc0fa414bcf548860ac50a8fe5982
2021-06-04 23:39:40+12:00
Add new flag to format_type_extended() to get NULL for undefined type If a type scanned is undefined, type format routines have two behaviors depending on if FORMAT_TYPE_ALLOW_INVALID is used by the caller or not: - Issue a cache lookup error - Return an undefined type name "???", "???[]" or "-" The current interface is not really helpful for callers willing to format properly a type name, but still make sure that the type is defined as there could be types matching the strings generated when looking for an undefined type, even if that should not be a problem in practice. In order to counter that, add a new flag called FORMAT_TYPE_INVALID_AS_NULL that returns a NULL result instead of "??? or "-" which does not generate an error. This flag will be used in a follow-up patch improving the set of SQL functions showing information for object addresses when it comes to undefined objects. Author: Michael Paquier Reviewed-by: Aleksander Alekseev, Dmitry Dolgov, Daniel Gustafsson, Álvaro Herrera Discussion: https://postgr.es/m/CAB7nPqSZxrSmdHK-rny7z8mi=EAFXJ5J-0RbzDw6aus=wB5azQ@mail.gmail.com
1185c782943c6d36835db481b199dce8e6f30246
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/1185c782943c6d36835db481b199dce8e6f30246
2020-07-06 12:12:11+09:00
Fix incorrect tlist generation in create_gather_plan(). This function is written as though Gather doesn't project; but it does. Even if it did not project, though, we must use build_path_tlist to ensure that the output columns receive correct sortgroupref labeling. Per report from Amit Kapila.
8776c15c85322612b9bf79daf50f74be71c12e05
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/8776c15c85322612b9bf79daf50f74be71c12e05
2016-03-09 10:56:36-05:00
Add two HyperLogLog functions New functions initHyperLogLogError() and freeHyperLogLog() simplify using this module from elsewhere. Author: Tomáš Vondra Review: Peter Geoghegan
948c97958bf37adb2a9c2d6d92c255abfc7499ba
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/948c97958bf37adb2a9c2d6d92c255abfc7499ba
2016-01-19 17:40:15-03:00
Fix busted logic for parallel lock grouping in TopoSort(). A "break" statement erroneously left behind by commit a1c1af2a1 caused TopoSort to do the wrong thing if a lock's wait list contained multiple members of the same locking group. Because parallel workers don't normally need any locks not already taken by their leader, this is very hard --- maybe impossible --- to hit in production. Still, if it did happen, the queries involved in an otherwise-resolvable deadlock would block until canceled. In addition to removing the bogus "break", add an Assert showing that the conflicting uses of the beforeConstraints[] array (for both counts and flags) don't overlap, and add some commentary explaining why not; because it's not obvious without explanation, IMHO. Original report and patch from Rui Hai Jiang; additional assert and commentary by me. Back-patch to 9.6 where the bug came in. Discussion: https://postgr.es/m/CAEri+mLd3bpHLyW+a9pSe1y=aEkeuJpwBSwvo-+m4n7-ceRmXw@mail.gmail.com
3420851a2c2d2ac49b8ba53ccec5d02aa1e6a272
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/3420851a2c2d2ac49b8ba53ccec5d02aa1e6a272
2019-07-29 18:49:04-04:00
Access pg_dump's options structs through Archive struct, not directly. Rather than passing around DumpOptions and RestoreOptions as separate arguments, add fields to struct Archive to carry pointers to these objects, and access them through those fields when needed. There already was a RestoreOptions pointer in Archive, though for no obvious reason it was part of the "private" struct rather than out where pg_dump.c could see it. Doing this allows reversion of quite a lot of parameter-addition changes made in commit 0eea8047bf, which is a good thing IMO because this will reduce the code delta between 9.4 and 9.5, probably easing a few future back-patch efforts. Moreover, the previous commit only added a DumpOptions argument to functions that had to have it at the time, which means we could anticipate still more code churn (and more back-patch hazard) as the requirement spread further. I'd hit exactly that problem in my upcoming patch to fix extension membership marking, which is what motivated me to do this.
5b5fea2a11741e651f7c25e981dd29b610a08426
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/5b5fea2a11741e651f7c25e981dd29b610a08426
2016-01-13 17:48:33-05:00
Add to pageinspect function to make t_infomask/t_infomask2 human-readable Flags of t_infomask and t_infomask2 for each tuple are already included in the information returned by heap_page_items as integers, and we lacked a way to make that information human-readable. Per discussion, the function includes an option which controls if combined flags should be decomposed or not. The default is false, to not decompose combined flags. The module is bumped to version 1.8. Author: Craig Ringer, Sawada Masahiko Reviewed-by: Peter Geoghegan, Robert Haas, Álvaro Herrera, Moon Insung, Amit Kapila, Michael Paquier, Tomas Vondra Discussion: https://postgr.es/m/CAMsr+YEY7jeaXOb+oX+RhDyOFuTMdmHjGsBxL=igCm03J0go9Q@mail.gmail.com
ddbd5d8731619ad3ab47ce325e8605422297a613
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/ddbd5d8731619ad3ab47ce325e8605422297a613
2019-09-12 15:06:00+09:00
Fix autovacuum for shared relations The table-skipping logic in autovacuum would fail to consider that multiple workers could be processing the same shared catalog in different databases. This normally wouldn't be a problem: firstly because autovacuum workers not for wraparound would simply ignore tables in which they cannot acquire lock, and secondly because most of the time these tables are small enough that even if multiple for-wraparound workers are stuck in the same catalog, they would be over pretty quickly. But in cases where the catalogs are severely bloated it could become a problem. Backpatch all the way back, because the problem has been there since the beginning. Reported by Ondřej Světlík Discussion: https://www.postgresql.org/message-id/572B63B1.3030603%40flexibee.eu https://www.postgresql.org/message-id/572A1072.5080308%40flexibee.eu
15739393e4c3b64b9038d75784e848a415827517
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/15739393e4c3b64b9038d75784e848a415827517
2016-05-10 16:23:54-03:00
Fix typos in comments. Etsuro Fujita Discussion: http://postgr.es/m/[email protected]
0d1e1f0ea45c15170c2d2ae0f0c448bc2d2b72d9
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/0d1e1f0ea45c15170c2d2ae0f0c448bc2d2b72d9
2017-05-02 14:47:46-04:00
doc: Fix typo in ANALYZE documentation Commit 61fa6ca79b3 accidentally wrote constrast instead of contrast. Backpatch-through: 10 Discussion: https://postgr.es/m/[email protected]
4e31c46e1e7b7d3a34909ec872c4446711e86e7d
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/4e31c46e1e7b7d3a34909ec872c4446711e86e7d
2022-03-31 12:03:33+02:00
Fix incorrect copy-pasto in error message of pg_waldump.c The error message used on fclose() failure was incorrect, so fix it. Oversight in d497093, that I have somehow managed to miss.
2259c661dc4ecd88ac22b5358248f47ca5a5d4fc
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/2259c661dc4ecd88ac22b5358248f47ca5a5d4fc
2022-12-27 12:16:24+09:00
Fix build failure on header generation with repetitive builds of MSVC GenerateConfigHeader() in Solution.pm was complaining about unused define symbols even if a newer config header was not generated, causing successive build attempts with MSVC to fail. Oversight in commit 8f4fb4c. Author: Kyotaro Horiguchi Reviewed-by: Juan José Santamaría Flecha Discussion: https://postgr.es/m/[email protected]
59f9cd9dd5e4db8c59c57a17388c17564a3211a3
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/59f9cd9dd5e4db8c59c57a17388c17564a3211a3
2020-02-25 13:57:40+09:00
Fix VPATH builds for src/test/ssl targets Commit b4c4a00ea refactored the gist of the sslfiles target into a separate makefile in order to override settings in Makefile.global. The invocation of this this file didn't however include the absolute path for VPATH builds, resulting in "make clean" failing. Fix by providing the path to the new makefile. Reported-by: Andres Freund <[email protected]> Discussion: https://postgr.es/m/[email protected]
349cd8c582a1e666c9c804850cf5b532b86cd1b4
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/349cd8c582a1e666c9c804850cf5b532b86cd1b4
2021-10-27 21:49:48+02:00
Fix pgbench permute tests. One of the tests for the pgbench permute() function added by 6b258e3d68 fails on some 32-bit platforms, due to variations in the floating point computations in getrand(). The remaining tests give sufficient coverage, so just remove the failing test. Reported by Christoph Berg. Analysis by Thomas Munro and Tom Lane. Based on patch by Fabien Coelho. Discussion: https://postgr.es/m/[email protected]
0f516d039d8023163e82fa51104052306068dd69
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/0f516d039d8023163e82fa51104052306068dd69
2021-05-19 12:50:58+01:00
Fix typo in comment. Daniel Gustafsson
8a2f08fbeaf75f67da122b49f05f96257df3faed
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/8a2f08fbeaf75f67da122b49f05f96257df3faed
2016-10-26 11:10:13+03:00
Fix collection of typos and grammar mistakes in the tree, volume 2 This fixes some comments and documentation new as of Postgres 13, and is a follow-up of the work done in dd0f37e. Author: Justin Pryzby Discussion: https://postgr.es/m/[email protected]
8128b0c152a67917535f50738ac26da4f984ddd9
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/8128b0c152a67917535f50738ac26da4f984ddd9
2020-04-14 14:45:43+09:00
Fix bugs in plpgsql's handling of CALL argument lists. exec_stmt_call() tried to extract information out of a CALL statement's argument list without using expand_function_arguments(), apparently in the hope of saving a few nanoseconds by not processing defaulted arguments. It got that quite wrong though, leading to crashes with named arguments, as well as failure to enforce writability of the argument for a defaulted INOUT parameter. Fix and simplify the logic by using expand_function_arguments() before examining the list. Also, move the argument-examination to just after producing the CALL command's plan, before invoking the called procedure. This ensures that we'll track possible changes in the procedure's argument list correctly, and avoids a hazard of the plan cache being flushed while the procedure executes. Also fix assorted falsehoods and omissions in associated documentation. Per bug #15477 from Alexey Stepanov. Patch by me, with some help from Pavel Stehule. Back-patch to v11. Discussion: https://postgr.es/m/[email protected] Discussion: https://postgr.es/m/CAFj8pRA6UsujpTs9Sdwmk-R6yQykPx46wgjj+YZ7zxm4onrDyw@mail.gmail.com
15c7293477a6de03234f58898da7fb29f3ab5b94
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/15c7293477a6de03234f58898da7fb29f3ab5b94
2018-11-04 13:25:39-05:00
docs: improve pg_upgrade standby instructions This makes it clear that pg_upgrade standby upgrade instructions should only be used in link mode, adds examples, and explains how rsync works with links. Reported-by: Andreas Joseph Krogh Discussion: https://postgr.es/m/VisenaEmail.6c.c0e592c5af4ef0a2.15e785dcb61@tc7-visena Backpatch-through: 9.5
9521ce4a7a1125385fb4de9689f345db594c516a
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/9521ce4a7a1125385fb4de9689f345db594c516a
2017-09-13 09:11:28-04:00
Fix portability issue in pg_audit. "%ld" is not a portable way to print int64's. This may explain the buildfarm crashes we're seeing --- it seems to make dromedary happy, at least.
35a1e1d1593f4355c9d87bbc8208a8736801a607
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/35a1e1d1593f4355c9d87bbc8208a8736801a607
2015-05-14 13:19:26-04:00
Allow DateTimeParseError to handle bad-timezone error messages. Pay down some ancient technical debt (dating to commit 022fd9966): fix a couple of places in datetime parsing that were throwing ereport's immediately instead of returning a DTERR code that could be interpreted by DateTimeParseError. The reason for that was that there was no mechanism for passing any auxiliary data (such as a zone name) to DateTimeParseError, and these errors seemed to really need it. Up to now it didn't matter that much just where the error got thrown, but now we'd like to have a hard policy that datetime parse errors get thrown from just the one place. Hence, invent a "DateTimeErrorExtra" struct that can be used to carry any extra values needed for specific DTERR codes. Perhaps in the future somebody will be motivated to use this to improve the specificity of other DateTimeParseError messages, but for now just deal with the timezone-error cases. This is on the way to making the datetime input functions report parse errors softly; but it's really an independent change, so commit separately. Discussion: https://postgr.es/m/[email protected]
2661469d862239ea8b9e3a1cf5352d833f6f0fec
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/2661469d862239ea8b9e3a1cf5352d833f6f0fec
2022-12-09 13:30:43-05:00
Fix another ancient bug in parsing of BRE-mode regular expressions. While poking at the regex code, I happened to notice that the bug squashed in commit afcc8772e had a sibling: next() failed to return a specific value associated with the '}' token for a "\{m,n\}" quantifier when parsing in basic RE mode. Again, this could result in treating the quantifier as non-greedy, which it never should be in basic mode. For that to happen, the last character before "\}" that sets "nextvalue" would have to set it to zero, or it'd have to have accidentally been zero from the start. The failure can be provoked repeatably with, for example, a bound ending in digit "0". Like the previous patch, back-patch all the way.
b5a66e7353ba65c11c5fc6a79b72213bde8dbe44
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/b5a66e7353ba65c11c5fc6a79b72213bde8dbe44
2021-02-18 22:38:55-05:00
release notes: Add entry for commit 5ea86e6e6. Peter Geoghegan and Robert Haas
c66bc72e8a1318e43ea657ffa3798fa95f491650
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/c66bc72e8a1318e43ea657ffa3798fa95f491650
2015-06-26 14:48:52-04:00
Fix inconsistencies in SRF checks of pg_config() and string_to_table() The execution paths of those functions have been using a set of checks inconsistent with any other SRF function: - string_to_table() missed a check on expectedDesc, the tuple descriptor expected by the caller, that should never be NULL. Introduced in 66f1630. - pg_config() should check for a ReturnSetInfo, and expectedDesc cannot be NULL. Its error messages were also inconsistent. Introduced in a5c43b8. Extracted from a larger patch by the same author, in preparation for a larger patch set aimed at refactoring the way tuplestores are created and checked in SRF functions. Author: Melanie Plageman Reviewed-by: Justin Pryzby Discussion: https://postgr.es/m/CAAKRu_azyd1Z3W_r7Ou4sorTjRCs+PxeHw1CWJeXKofkE6TuZg@mail.gmail.com
07daca53bfcad59618a9c6fad304e380cc9d2bc1
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/07daca53bfcad59618a9c6fad304e380cc9d2bc1
2022-02-19 14:58:51+09:00
Fix crash with pg_partition_root Trying to call the function with the top-most parent of a partition tree was leading to a crash. In this case the correct result is to return the top-most parent itself. Reported-by: Álvaro Herrera Author: Michael Paquier Reviewed-by: Amit Langote Discussion: https://postgr.es/m/[email protected]
2ab6d28d233af17987ea323e3235b2bda89b4f2e
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/2ab6d28d233af17987ea323e3235b2bda89b4f2e
2019-03-22 17:27:38+09:00
Teach configure --with-python to report the Python version number. We already do this for Perl and some other interesting tools, so it seems sensible to do it for Python as well, especially since the sub-release number is never determinable from other configure output and even the major/minor numbers may not be clear without excavation in config.log. While at it, get rid of the code's assumption that both the major and minor numbers contain exactly one digit. That will foreseeably be broken by Python 3.10 in perhaps four or five years. That's far enough out that we probably don't need to back-patch this. Discussion: https://postgr.es/m/[email protected]
beff4bb9c7411cfd973e192df05c0c1f5c796d22
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/beff4bb9c7411cfd973e192df05c0c1f5c796d22
2018-04-02 12:26:09-04:00
Fix parallel index and index-only scans to fall back to serial. Parallel executor nodes can't assume that parallel execution will happen in every case where the plan calls for it, because it might not work out that way. However, parallel index scan and parallel index-only scan failed to do the right thing here. Repair. Amit Kapila, per a report from me. Discussion: http://postgr.es/m/CAA4eK1Kq5qb_u2AOoda5XBB91vVWz90w=LgtRLgsssriS8pVTw@mail.gmail.com
09529a70bb5a77935d086d651c63396767d240d7
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/09529a70bb5a77935d086d651c63396767d240d7
2017-03-08 08:15:24-05:00
Fix incorrect handling of lookahead constraints in pg_regprefix(). pg_regprefix was doing nothing with lookahead constraints, which would be fine if it were the right kind of nothing, but it isn't: we have to terminate our search for a fixed prefix, not just pretend the LACON arc isn't there. Otherwise, if the current state has both a LACON outarc and a single plain-color outarc, we'd falsely conclude that the color represents an addition to the fixed prefix, and generate an extracted index condition that restricts the indexscan too much. (See added regression test case.) Terminating the search is conservative: we could traverse the LACON arc (thus assuming that the constraint can be satisfied at runtime) and then examine the outarcs of the linked-to state. But that would be a lot more work than it seems worth, because writing a LACON followed by a single plain character is a pretty silly thing to do. This makes a difference only in rather contrived cases, but it's a bug, so back-patch to all supported branches.
9f1e642d50b30ec5c9604b6095073012a9a73e93
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/9f1e642d50b30ec5c9604b6095073012a9a73e93
2015-10-19 13:54:53-07:00
Fix handling of empty ranges and NULLs in BRIN BRIN indexes did not properly distinguish between summaries for empty (no rows) and all-NULL ranges, treating them as essentially the same thing. Summaries were initialized with allnulls=true, and opclasses simply reset allnulls to false when processing the first non-NULL value. This however produces incorrect results if the range starts with a NULL value (or a sequence of NULL values), in which case we forget the range contains NULL values when adding the first non-NULL value. This happens because the allnulls flag is used for two separate purposes - to mark empty ranges (not representing any rows yet) and ranges containing only NULL values. Opclasses don't know which of these cases it is, and so don't know whether to set hasnulls=true. Setting the flag in both cases would make it correct, but it would also make BRIN indexes useless for queries with IS NULL clauses. All ranges start empty (and thus allnulls=true), so all ranges would end up with either allnulls=true or hasnulls=true. The severity of the issue is somewhat reduced by the fact that it only happens when adding values to an existing summary with allnulls=true. This can happen e.g. for small tables (because a summary for the first range exists for all BRIN indexes), or for tables with large fraction of NULL values in the indexed columns. Bulk summarization (e.g. during CREATE INDEX or automatic summarization) that processes all values at once is not affected by this issue. In this case the flags were updated in a slightly different way, not forgetting the NULL values. To identify empty ranges we use a new flag, stored in an unused bit in the BRIN tuple header so the on-disk format remains the same. A matching flag is added to BrinMemTuple, into a 3B gap after bt_placeholder. That means there's no risk of ABI breakage, although we don't actually pass the BrinMemTuple to any public API. We could also skip storing index tuples for empty summaries, but then we'd have to always process such ranges - even if there are no rows in large parts of the table (e.g. after a bulk DELETE), it would still require reading the pages etc. So we store them, but ignore them when building the bitmap. Backpatch to 11. The issue exists since BRIN indexes were introduced in 9.5, but older releases are already EOL. Backpatch-through: 11 Reviewed-by: Justin Pryzby, Matthias van de Meent, Alvaro Herrera Discussion: https://postgr.es/m/[email protected]
3581cbdcd64f5aceb445f60df23141d08ed50617
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/3581cbdcd64f5aceb445f60df23141d08ed50617
2023-05-19 00:00:22+02:00
pg_basebackup: Add tests for -X option Reviewed-by: Michael Paquier <[email protected]>
90102bb538831fca734cc9fa1450b97c7d4e1190
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/90102bb538831fca734cc9fa1450b97c7d4e1190
2015-06-30 21:15:29-04:00
doc: Fix typo Author: Julien Rouhaud <[email protected]>
506b565831e6c88666c18a467377c2f98066ccac
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/506b565831e6c88666c18a467377c2f98066ccac
2017-06-13 11:28:52-04:00
Accept relations of any kind in LOCK TABLE The restriction that only tables and views can be locked by LOCK TABLE is quite arbitrary, since the underlying mechanism can lock any relation type. Drop the restriction so that programs such as pg_dump can lock all relations they're interested in, preventing schema changes that could cause a dump to fail after expending much effort. Backpatch to 9.5. Author: Álvaro Herrera <[email protected]> Reviewed-by: Tom Lane <[email protected]> Reported-by: Wells Oliver <[email protected]> Discussion: https://postgr.es/m/[email protected]
59ab4ac32460a6a93b665f4e487d7ff64979ba4d
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/59ab4ac32460a6a93b665f4e487d7ff64979ba4d
2020-10-27 13:49:19-03:00
Add separate error message for procedure does not exist While we probably don't want to split up all error messages into function and procedure variants, this one is a very prominent one, so it's helpful to be more specific here.
0903bbdad24a8f51b18a6a54a41bbb36ad2ceee4
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/0903bbdad24a8f51b18a6a54a41bbb36ad2ceee4
2018-07-07 11:17:04+02:00
Fix bug in Tid scan. Commit 147e3722f7 changed Tid scan so that it calls table_beginscan() and uses the scan option for seq scan. This change caused two issues. (1) The change caused Tid scan to take a predicate lock on the entire relation in serializable transaction even when relation-level lock is not necessary. This could lead to an unexpected serialization error. (2) The change caused Tid scan to increment the number of seq_scan in pg_stat_*_tables views even though it's not seq scan. This could confuse the users. This commit adds the scan option for Tid scan and makes Tid scan use it, to avoid those issues. Back-patch to v12, where the bug was introduced. Author: Tatsuhito Kasahara Reviewed-by: Kyotaro Horiguchi, Masahiko Sawada, Fujii Masao Discussion: https://postgr.es/m/CAP0=ZVKy+gTbFmB6X_UW0pP3WaeJ-fkUWHoD-pExS=at3CY76g@mail.gmail.com
cb5b28613d553b1c750622e91cbc96c83f052a63
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/cb5b28613d553b1c750622e91cbc96c83f052a63
2020-02-07 22:00:21+09:00
Add logging for excessive ProcSignalBarrier waits. To enable diagnosis of systems that are not processing ProcSignalBarrier requests promptly, add a LOG message every 5 seconds if we seem to be wedged. Although you could already see this state as a wait event in pg_stat_activity, the log message also shows the PID of the process that is preventing progress. Also add DEBUG1 logging around the whole wait loop. Reviewed-by: Robert Haas <[email protected]> Discussion: https://postgr.es/m/CA%2BTgmoYJ03r5359gQutRGP9BtigYCg3_UskcmnVjBf-QO3-0pQ%40mail.gmail.com
0d3431497dbe91ba1e428ace4e9537c109eaff07
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/0d3431497dbe91ba1e428ace4e9537c109eaff07
2022-05-11 18:03:03+12:00
Replace remaining uses of "whitelist". Instead describe the action that the list effects, or just use "list" where the meaning is obvious from context. Author: Dagfinn Ilmari Mannsåker <[email protected]> Discussion: https://postgr.es/m/20200615182235.x7lch5n6kcjq4aue%40alap3.anarazel.de
034510c820cd75e0410332d92b4967ef9b844936
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/034510c820cd75e0410332d92b4967ef9b844936
2021-01-05 14:00:16+13:00
Fix typo in header comment Commit 4c04be9b0 accidentally left off the _id portion of the function name in the header comment. Author: Junwang Zhao <[email protected]> Discussion: https://postgr.es/m/CAEG8a3LP+ytnAXSzR=yiEaQrde+iCybMHsuPn9n=UN3puV_1tw@mail.gmail.com
a04761ac77354930aebe7613b40bbdd749af5002
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/a04761ac77354930aebe7613b40bbdd749af5002
2023-03-24 09:03:31+01:00
BRIN: improve documentation on summarization The existing wording wasn't clear enough and some details weren't anywhere, such as the fact that autosummarization is off by default. Improve. Authors: Roberto Mello, Jaime Casanova, Justin Pryzby, Álvaro Herrera Discussion: https://postgr.es/m/CAKz==bK_NoJytRyQfX8K-erCW3Ff7--oGYpiB8+ePVS7dRVW_A@mail.gmail.com Discussion: https://postgr.es/m/[email protected]
5001b44b11381f6e1787403ae81bce1ff1f78a99
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/5001b44b11381f6e1787403ae81bce1ff1f78a99
2022-07-05 13:38:26+02:00
Allow committing inside cursor loop Previously, committing or aborting inside a cursor loop was prohibited because that would close and remove the cursor. To allow that, automatically convert such cursors to holdable cursors so they survive commits or rollbacks. Portals now have a new state "auto-held", which means they have been converted automatically from pinned. An auto-held portal is kept on transaction commit or rollback, but is still removed when returning to the main loop on error. This supports all languages that have cursor loop constructs: PL/pgSQL, PL/Python, PL/Perl. Reviewed-by: Ildus Kurbangaliev <[email protected]>
056a5a3f63f1a29d9266165ee6e25c6a51ddd63c
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/056a5a3f63f1a29d9266165ee6e25c6a51ddd63c
2018-03-28 18:57:10-04:00
Add functions to wait for backend termination This adds a function, pg_wait_for_backend_termination(), and a new timeout argument to pg_terminate_backend(), which will wait for the backend to actually terminate (with or without signaling it to do so depending on which function is called). The default behaviour of pg_terminate_backend() remains being timeout=0 which does not waiting. For pg_wait_for_backend_termination() the default wait is 5 seconds. Author: Bharath Rupireddy Reviewed-By: Fujii Masao, David Johnston, Muhammad Usama, Hou Zhijie, Magnus Hagander Discussion: https://postgr.es/m/CALj2ACUBpunmyhYZw-kXCYs5NM+h6oG_7Df_Tn4mLmmUQifkqA@mail.gmail.com
aaf043257205ec523f1ba09a3856464d17cf2281
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/aaf043257205ec523f1ba09a3856464d17cf2281
2021-04-08 11:32:14+02:00
Offer pnstrdup to frontend code We already had it on the backend. Frontend can also use it now. Discussion: https://postgr.es/m/[email protected]
0b9466fce2cf4f8c32b3a9170ca272829aa11e66
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/0b9466fce2cf4f8c32b3a9170ca272829aa11e66
2019-12-04 19:36:06-03:00
Guard against null arguments in binary_upgrade_create_empty_extension(). The CHECK_IS_BINARY_UPGRADE macro is not sufficient security protection if we're going to dereference pass-by-reference arguments before it. But in any case we really need to explicitly check PG_ARGISNULL for all the arguments of a non-strict function, not only the ones we expect null values for. Oversight in commits 30982be4e5019684e1772dd9170aaa53f5a8e894 and f92fc4c95ddcc25978354a8248d3df22269201bc. Found by Andreas Seltenreich. (The other usages in pg_upgrade_support.c seem safe.)
939d10cd8711fdeb7f0ff62c9c6b08e3eddbba3e
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/939d10cd8711fdeb7f0ff62c9c6b08e3eddbba3e
2016-01-03 16:26:38-05:00
Fix dbtoepub output file name In previous releases, the input file of dbtoepub was postgres.xml, and dbtoepub knows to derive the output file name postgres.epub from that automatically. But now the intput file is postgres.sgml (since postgres.sgml is itself an XML file and we no longer need the intermediate postgres.xml file), but dbtoepub doesn't know how to deal with the .sgml suffix, so the automatically derived output file name becomes postgres.sgml.epub. Fix by adding an explicit -o option.
7aa00d2464b4e14d553e8a64adacfe9741939e14
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/7aa00d2464b4e14d553e8a64adacfe9741939e14
2019-02-21 15:39:37+01:00
autho_explain: Add GUC to log query parameters auto_explain.log_parameter_max_length is a new GUC part of the extension, similar to the corresponding core setting, that controls the inclusion of query parameters in the logged explain output. More tests are added to check the behavior of this new parameter: when parameters logged in full (the default of -1), when disabled (value of 0) and when partially truncated (value different than the two others). Author: Dagfinn Ilmari Mannsåker Discussion: https://postgr.es/m/[email protected]
d4bfe41281705c1bcb7093b3d07ce5ff1114341b
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/d4bfe41281705c1bcb7093b3d07ce5ff1114341b
2022-07-06 09:55:30+09:00
Fix possible crash in ALTER TABLE ... REPLICA IDENTITY USING INDEX. Careless coding added by commit 07cacba983ef79be could result in a crash or a bizarre error message if someone tried to select an index on the OID column as the replica identity index for a table. Back-patch to 9.4 where the feature was introduced. Discussion: CAKJS1f8TQYgTRDyF1_u9PVCKWRWz+DkieH=U7954HeHVPJKaKg@mail.gmail.com David Rowley
8f1911d5e6d5a1e62c860ddb040d664b01c6415c
postgres
neuralsentry
1
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/8f1911d5e6d5a1e62c860ddb040d664b01c6415c
2016-04-15 12:11:27-04:00
Translation updates Source-Git-URL: git://git.postgresql.org/git/pgtranslation/messages.git Source-Git-Hash: 19c72ea8d856d7b1d4f5d759a766c8206bf9ce53
f8948616c9403effb84ed09c244650d9750243a2
postgres
neuralsentry
0
https://github.com/postgres/postgres
https://github.com/postgres/postgres/commit/f8948616c9403effb84ed09c244650d9750243a2
2015-02-01 23:23:40-05:00