Update services/agentic_handlers.py

services/agentic_handlers.py

@@ -40,6 +40,50 @@ class AgenticHandlers:
         self.agentic_modules_really_loaded = AGENTIC_MODULES_LOADED
         logging.info(f"AgenticHandlers initialized. Modules loaded: {self.agentic_modules_really_loaded}")
 
+    def _safe_checkbox_update(self, choices=None, value=None, interactive=None):
+        """
+        Create a safe update for CheckboxGroup that handles version compatibility.
+        """
+        update_dict = {}
+        
+        # Only include parameters that are supported and valid
+        if choices is not None:
+            # Ensure choices is a list of tuples (display_value, return_value)
+            if isinstance(choices, list):
+                formatted_choices = []
+                for choice in choices:
+                    if isinstance(choice, tuple) and len(choice) == 2:
+                        formatted_choices.append(choice)
+                    else:
+                        # Convert single values to (display, value) tuples
+                        formatted_choices.append((str(choice), choice))
+                update_dict['choices'] = formatted_choices
+            else:
+                update_dict['choices'] = []
+        
+        if value is not None:
+            # Ensure value is a list and only contains valid choices
+            if isinstance(value, list):
+                if choices is not None:
+                    # Filter value to only include items that exist in choices
+                    valid_values = [choice[1] if isinstance(choice, tuple) else choice for choice in (choices or [])]
+                    filtered_value = [v for v in value if v in valid_values]
+                    update_dict['value'] = filtered_value
+                else:
+                    update_dict['value'] = []
+            else:
+                update_dict['value'] = []
+        
+        # Try to include interactive parameter, but handle gracefully if not supported
+        if interactive is not None:
+            try:
+                update_dict['interactive'] = interactive
+            except:
+                # If interactive parameter is not supported, continue without it
+                pass
+        
+        return gr.update(**update_dict)
+
     async def run_agentic_pipeline_autonomously_on_update(self, current_token_state_val):
         """
         This function is intended to be triggered by changes in token_state.
@@ -64,7 +108,13 @@ class AgenticHandlers:
         report_status_md_update = gr.update(value=initial_report_status) if self.report_components.get("agentic_pipeline_status_md") else gr.update()
         report_display_md_update = gr.update() 
         
-        okrs_cbg_update = gr.update(choices=initial_okr_cbg_choices, value=initial_okr_cbg_value, interactive=initial_okr_cbg_interactive) if self.okrs_components.get("key_results_cbg") else gr.update()
+        # Use safe checkbox update method
+        okrs_cbg_update = self._safe_checkbox_update(
+            choices=initial_okr_cbg_choices, 
+            value=initial_okr_cbg_value, 
+            interactive=initial_okr_cbg_interactive
+        ) if self.okrs_components.get("key_results_cbg") else gr.update()
+        
         okrs_detail_md_update = gr.update(value=initial_okr_details) if self.okrs_components.get("okr_detail_display_md") else gr.update()
 
         if not current_token_state_val or not current_token_state_val.get("token"):
@@ -104,7 +154,7 @@ class AgenticHandlers:
             
             # Update for key_results_cbg (CheckboxGroup) in error case
             if self.okrs_components.get("key_results_cbg"):
-                 okrs_cbg_update = gr.update(choices=[], value=[], interactive=False) 
+                okrs_cbg_update = self._safe_checkbox_update(choices=[], value=[], interactive=False)
             
             if self.okrs_components.get("okr_detail_display_md"):
                  okrs_detail_md_update = gr.update(value=error_status) 
@@ -147,9 +197,23 @@ class AgenticHandlers:
                 krs_for_selection_update_val = krs_for_ui_selection_list # This is the list of dicts
                 
                 # Prepare choices for key_results_cbg (CheckboxGroup)
-                kr_choices_for_cbg = [(kr['kr_description'], kr['unique_kr_id']) for kr in krs_for_ui_selection_list]
+                kr_choices_for_cbg = []
+                if krs_for_ui_selection_list:
+                    for kr in krs_for_ui_selection_list:
+                        if isinstance(kr, dict) and 'kr_description' in kr and 'unique_kr_id' in kr:
+                            # Ensure kr_description is a string and clean it
+                            kr_desc = str(kr['kr_description']).strip()
+                            # Truncate very long descriptions to avoid UI issues
+                            if len(kr_desc) > 100:
+                                kr_desc = kr_desc[:97] + "..."
+                            kr_choices_for_cbg.append((kr_desc, kr['unique_kr_id']))
+                
                 if self.okrs_components.get("key_results_cbg"):
-                    okrs_cbg_update = gr.update(choices=kr_choices_for_cbg, value=[], interactive=True) 
+                    okrs_cbg_update = self._safe_checkbox_update(
+                        choices=kr_choices_for_cbg, 
+                        value=[], 
+                        interactive=True
+                    )
                 
                 all_okrs_md_parts = []
                 if actionable_okrs and isinstance(actionable_okrs.get("okrs"), list):
@@ -171,7 +235,7 @@ class AgenticHandlers:
                 
                 # Update for key_results_cbg (CheckboxGroup) if no output
                 if self.okrs_components.get("key_results_cbg"):
-                    okrs_cbg_update = gr.update(choices=[], value=[], interactive=False) 
+                    okrs_cbg_update = self._safe_checkbox_update(choices=[], value=[], interactive=False)
                 
                 if self.okrs_components.get("okr_detail_display_md"):
                     okrs_detail_md_update = gr.update(value="Nessun OKR generato o errore nella pipeline AI (Sempre).")
@@ -196,7 +260,7 @@ class AgenticHandlers:
             
             # Update for key_results_cbg (CheckboxGroup) in case of exception
             if self.okrs_components.get("key_results_cbg"):
-                okrs_cbg_update = gr.update(choices=[], value=[], interactive=False) 
+                okrs_cbg_update = self._safe_checkbox_update(choices=[], value=[], interactive=False)
 
             if self.okrs_components.get("okr_detail_display_md"):
                 okrs_detail_md_update = gr.update(value=f"Errore generazione OKR AI (Sempre): {str(e)}")
@@ -217,11 +281,15 @@ class AgenticHandlers:
         if not self.agentic_modules_really_loaded:
             return gr.update(value="Moduli AI non caricati. Impossibile visualizzare i dettagli OKR.")
         
+        # Handle case where selected_kr_unique_ids might be None or not a list
+        if not isinstance(selected_kr_unique_ids, list):
+            selected_kr_unique_ids = []
+        
         parsed_orchestration_results = None
         try:
             if raw_orchestration_results_json: # Check if the string is not empty
                 parsed_orchestration_results = json.loads(raw_orchestration_results_json)
-        except json.JSONDecodeError as e:
+        except (json.JSONDecodeError, TypeError) as e:
             logging.error(f"Failed to parse raw_orchestration_results_json: {raw_orchestration_results_json}. Error: {e}")
             return gr.update(value="Errore: Dati interni corrotti (orchestration results).")
 
@@ -232,7 +300,7 @@ class AgenticHandlers:
         try:
             if all_krs_for_selection_list_json: # Check if the string is not empty
                  parsed_krs_for_selection_list = json.loads(all_krs_for_selection_list_json)
-        except json.JSONDecodeError as e:
+        except (json.JSONDecodeError, TypeError) as e:
             logging.error(f"Failed to parse all_krs_for_selection_list_json: {all_krs_for_selection_list_json}. Error: {e}")
             return gr.update(value="Errore: Dati interni corrotti (krs for selection).")
         
@@ -241,7 +309,6 @@ class AgenticHandlers:
             logging.warning(f"Parsed all_krs_for_selection_list is not a list: {type(parsed_krs_for_selection_list)}. Defaulting to empty list.")
             parsed_krs_for_selection_list = []
 
-
         actionable_okrs_dict = parsed_orchestration_results.get("actionable_okrs_and_tasks") if isinstance(parsed_orchestration_results, dict) else None
         
         if not actionable_okrs_dict or not isinstance(actionable_okrs_dict.get("okrs"), list):
@@ -315,4 +382,4 @@ class AgenticHandlers:
             )
             logging.info("Agentic OKR selection handler setup complete.")
         else:
-            logging.warning("key_results_cbg component not found for agentic OKR handler setup.")
+            logging.warning("key_results_cbg component not found for agentic OKR handler setup.")