Update services/agentic_handlers.py

services/agentic_handlers.py

@@ -2,6 +2,7 @@
 import gradio as gr
 import logging
 from collections import defaultdict
+import json # Added for JSON serialization/deserialization
 
 # Attempt to import agentic pipeline functions and UI formatters
 try:
@@ -34,25 +35,28 @@ class AgenticHandlers:
         self.token_state = token_state_ref
         self.orchestration_raw_results_st = orchestration_raw_results_st_ref
         self.key_results_for_selection_st = key_results_for_selection_st_ref
-        self.selected_key_result_ids_st = selected_key_result_ids_st_ref # Though this is updated by CBG, might be read
+        self.selected_key_result_ids_st = selected_key_result_ids_st_ref
         
-        self.agentic_modules_really_loaded = AGENTIC_MODULES_LOADED # Store the flag
+        self.agentic_modules_really_loaded = AGENTIC_MODULES_LOADED
         logging.info(f"AgenticHandlers initialized. Modules loaded: {self.agentic_modules_really_loaded}")
 
     async def run_agentic_pipeline_autonomously_on_update(self, current_token_state_val):
         """
-        This function is intended to be triggered by changes in token_state
-        (e.g., after initial load or after sync).
+        This function is intended to be triggered by changes in token_state.
         It yields updates for the agentic report and OKR tabs.
-        The 5th, 6th, and 7th yielded values are stringified to prevent errors
-        if misconfigured UI routes them to Markdown components.
+        State values (5th, 6th, 7th) are serialized to JSON strings.
+        Updates for key_results_cbg are now for a CheckboxGroup.
         """
         logging.info(f"Agentic pipeline auto-trigger. Token: {'Set' if current_token_state_val.get('token') else 'Not Set'}")
 
-        # Initial "waiting" status updates
         initial_report_status = "Pipeline AI: In attesa dei dati necessari..."
-        initial_okr_value_for_markdown = "" 
         initial_okr_details = "Pipeline AI: In attesa dei dati necessari..."
+        
+        # Initial state for key_results_cbg (CheckboxGroup)
+        initial_okr_cbg_choices = []
+        initial_okr_cbg_value = []
+        initial_okr_cbg_interactive = False
+        
         initial_orchestration_results = self.orchestration_raw_results_st.value 
         initial_selected_krs = self.selected_key_result_ids_st.value
         initial_krs_for_selection = self.key_results_for_selection_st.value
@@ -60,7 +64,7 @@ class AgenticHandlers:
         report_status_md_update = gr.update(value=initial_report_status) if self.report_components.get("agentic_pipeline_status_md") else gr.update()
         report_display_md_update = gr.update() 
         
-        okrs_cbg_update = gr.update(value=initial_okr_value_for_markdown) if self.okrs_components.get("key_results_cbg") else gr.update()
+        okrs_cbg_update = gr.update(choices=initial_okr_cbg_choices, value=initial_okr_cbg_value, interactive=initial_okr_cbg_interactive) if self.okrs_components.get("key_results_cbg") else gr.update()
         okrs_detail_md_update = gr.update(value=initial_okr_details) if self.okrs_components.get("okr_detail_display_md") else gr.update()
 
         if not current_token_state_val or not current_token_state_val.get("token"):
@@ -70,9 +74,9 @@ class AgenticHandlers:
                 report_display_md_update, 
                 okrs_cbg_update,          
                 okrs_detail_md_update,    
-                str(initial_orchestration_results), # Stringify state value
-                str(initial_selected_krs),          # Stringify state value
-                str(initial_krs_for_selection)      # Stringify state value
+                json.dumps(initial_orchestration_results), # Serialize to JSON
+                json.dumps(initial_selected_krs),          # Serialize to JSON
+                json.dumps(initial_krs_for_selection)      # Serialize to JSON
             )
             return
 
@@ -82,11 +86,12 @@ class AgenticHandlers:
         if self.okrs_components.get("okr_detail_display_md"): 
              okrs_detail_md_update = gr.update(value="Dettagli OKR (Sempre) in corso di generazione...")
         
+        # okrs_cbg_update is already set to initial waiting state for CheckboxGroup
         yield (
             report_status_md_update, report_display_md_update, okrs_cbg_update, okrs_detail_md_update,
-            str(initial_orchestration_results), # Stringify state value
-            str(initial_selected_krs),          # Stringify state value
-            str(initial_krs_for_selection)      # Stringify state value
+            json.dumps(initial_orchestration_results), # Serialize to JSON
+            json.dumps(initial_selected_krs),          # Serialize to JSON
+            json.dumps(initial_krs_for_selection)      # Serialize to JSON
         )
 
         if not self.agentic_modules_really_loaded:
@@ -97,15 +102,16 @@ class AgenticHandlers:
             if self.report_components.get("agentic_report_display_md"):
                 report_display_md_update = gr.update(value=error_status) 
             
+            # Update for key_results_cbg (CheckboxGroup) in error case
             if self.okrs_components.get("key_results_cbg"):
-                 okrs_cbg_update = gr.update(value=error_status) 
+                 okrs_cbg_update = gr.update(choices=[], value=[], interactive=False) 
             
             if self.okrs_components.get("okr_detail_display_md"):
                  okrs_detail_md_update = gr.update(value=error_status) 
 
             yield (
                 report_status_md_update, report_display_md_update, okrs_cbg_update, okrs_detail_md_update,
-                str(None), str([]), str([]) # Stringify state values
+                json.dumps(None), json.dumps([]), json.dumps([]) # Serialize to JSON
             )
             return
 
@@ -126,7 +132,7 @@ class AgenticHandlers:
             logging.info(f"Autonomous agentic pipeline finished. Output keys: {orchestration_output.keys() if orchestration_output else 'None'}")
 
             orchestration_results_update_val = None
-            selected_krs_update_val = []
+            selected_krs_update_val = [] # This will be the value for the CheckboxGroup, initially empty
             krs_for_selection_update_val = []
 
             if orchestration_output:
@@ -138,10 +144,12 @@ class AgenticHandlers:
                 
                 actionable_okrs = orchestration_output.get('actionable_okrs_and_tasks')
                 krs_for_ui_selection_list = extract_key_results_for_selection(actionable_okrs)
-                krs_for_selection_update_val = krs_for_ui_selection_list 
+                krs_for_selection_update_val = krs_for_ui_selection_list # This is the list of dicts
                 
+                # Prepare choices for key_results_cbg (CheckboxGroup)
+                kr_choices_for_cbg = [(kr['kr_description'], kr['unique_kr_id']) for kr in krs_for_ui_selection_list]
                 if self.okrs_components.get("key_results_cbg"):
-                    okrs_cbg_update = gr.update(value="Key Results available for selection (display as Markdown)") 
+                    okrs_cbg_update = gr.update(choices=kr_choices_for_cbg, value=[], interactive=True) 
                 
                 all_okrs_md_parts = []
                 if actionable_okrs and isinstance(actionable_okrs.get("okrs"), list):
@@ -155,14 +163,15 @@ class AgenticHandlers:
                     if self.okrs_components.get("okr_detail_display_md"):
                         okrs_detail_md_update = gr.update(value="\n\n---\n\n".join(all_okrs_md_parts))
                 
-                selected_krs_update_val = [] 
+                selected_krs_update_val = [] # Reset CheckboxGroup selection
             else: 
                 final_status_text = "Pipeline AI (Sempre): Nessun risultato prodotto."
                 if self.report_components.get("agentic_report_display_md"):
                     report_display_md_update = gr.update(value="Nessun report generato dalla pipeline AI (Sempre).")
                 
+                # Update for key_results_cbg (CheckboxGroup) if no output
                 if self.okrs_components.get("key_results_cbg"):
-                    okrs_cbg_update = gr.update(value="Nessun Key Result (Markdown display)") 
+                    okrs_cbg_update = gr.update(choices=[], value=[], interactive=False) 
                 
                 if self.okrs_components.get("okr_detail_display_md"):
                     okrs_detail_md_update = gr.update(value="Nessun OKR generato o errore nella pipeline AI (Sempre).")
@@ -172,9 +181,9 @@ class AgenticHandlers:
 
             yield (
                 report_status_md_update, report_display_md_update, okrs_cbg_update, okrs_detail_md_update,
-                str(orchestration_results_update_val), # Stringify state value
-                str(selected_krs_update_val),          # Stringify state value
-                str(krs_for_selection_update_val)      # Stringify state value
+                json.dumps(orchestration_results_update_val), # Serialize to JSON
+                json.dumps(selected_krs_update_val),          # Serialize to JSON (value for selected_key_result_ids_st)
+                json.dumps(krs_for_selection_update_val)      # Serialize to JSON (value for key_results_for_selection_st)
             )
 
         except Exception as e:
@@ -185,48 +194,55 @@ class AgenticHandlers:
             if self.report_components.get("agentic_report_display_md"):
                  report_display_md_update = gr.update(value=f"Errore generazione report AI (Sempre): {str(e)}")
             
+            # Update for key_results_cbg (CheckboxGroup) in case of exception
             if self.okrs_components.get("key_results_cbg"):
-                okrs_cbg_update = gr.update(value=f"Errore Key Results (Markdown): {str(e)}") 
+                okrs_cbg_update = gr.update(choices=[], value=[], interactive=False) 
 
             if self.okrs_components.get("okr_detail_display_md"):
                 okrs_detail_md_update = gr.update(value=f"Errore generazione OKR AI (Sempre): {str(e)}")
 
             yield (
                 report_status_md_update, report_display_md_update, okrs_cbg_update, okrs_detail_md_update,
-                str(None), str([]), str([]) # Stringify state values
+                json.dumps(None), json.dumps([]), json.dumps([]) # Serialize to JSON
             )
 
     def update_okr_display_on_kr_selection(self, selected_kr_unique_ids: list, 
-                                           raw_orchestration_results: dict, 
-                                           all_krs_for_selection_list: list):
+                                           raw_orchestration_results_json: str, 
+                                           all_krs_for_selection_list_json: str):
         """
         Updates the OKR detail display when Key Results are selected in the CheckboxGroup.
+        raw_orchestration_results_json and all_krs_for_selection_list_json are expected
+        to be JSON strings from state.
         """
-        # raw_orchestration_results, all_krs_for_selection_list now might be strings
-        # if they come from state that was stringified. This needs careful handling
-        # if this function is called with outputs from the stringified state.
-        # For now, assuming they are passed correctly as dict/list if not from stringified state.
-
         if not self.agentic_modules_really_loaded:
             return gr.update(value="Moduli AI non caricati. Impossibile visualizzare i dettagli OKR.")
         
-        # Attempt to parse if stringified, this is a significant assumption about how state is used.
-        # This part is complex because we don't know if these inputs are direct from UI or from stringified state.
-        # A robust solution would involve type checking and conditional parsing (e.g. import json; json.loads if string)
-        # For this focused fix, we'll assume they are passed as dict/list for now.
-        # If they come from the stringified state, this function will likely fail or misbehave.
-        # The problem is, the `inputs` to this handler in `setup_event_handlers` are `gr.State` objects.
-        # If those `gr.State` objects now store strings like "'[]'", then `raw_orchestration_results` here
-        # will be the string "'[]'", not the list [].
+        parsed_orchestration_results = None
+        try:
+            if raw_orchestration_results_json: # Check if the string is not empty
+                parsed_orchestration_results = json.loads(raw_orchestration_results_json)
+        except json.JSONDecodeError as e:
+            logging.error(f"Failed to parse raw_orchestration_results_json: {raw_orchestration_results_json}. Error: {e}")
+            return gr.update(value="Errore: Dati interni corrotti (orchestration results).")
 
-        if not raw_orchestration_results: # This check might be problematic if "None" (string) is passed
-            return gr.update(value="Nessun dato dalla pipeline AI o moduli non caricati.")
+        if not parsed_orchestration_results: # This covers None or empty after parsing
+            return gr.update(value="Nessun dato dalla pipeline AI (orchestration results).")
 
-        # This is a critical point: if raw_orchestration_results is a string representation
-        # of a dict (e.g., "{'key': 'value'}"), .get will fail.
-        # We would need to json.loads() it.
-        # For now, we proceed assuming it's a dict. This might be the next error point.
-        actionable_okrs_dict = raw_orchestration_results.get("actionable_okrs_and_tasks") if isinstance(raw_orchestration_results, dict) else None
+        parsed_krs_for_selection_list = []
+        try:
+            if all_krs_for_selection_list_json: # Check if the string is not empty
+                 parsed_krs_for_selection_list = json.loads(all_krs_for_selection_list_json)
+        except json.JSONDecodeError as e:
+            logging.error(f"Failed to parse all_krs_for_selection_list_json: {all_krs_for_selection_list_json}. Error: {e}")
+            return gr.update(value="Errore: Dati interni corrotti (krs for selection).")
+        
+        # Ensure parsed_krs_for_selection_list is a list, even if JSON was 'null' or other non-list type
+        if not isinstance(parsed_krs_for_selection_list, list):
+            logging.warning(f"Parsed all_krs_for_selection_list is not a list: {type(parsed_krs_for_selection_list)}. Defaulting to empty list.")
+            parsed_krs_for_selection_list = []
+
+
+        actionable_okrs_dict = parsed_orchestration_results.get("actionable_okrs_and_tasks") if isinstance(parsed_orchestration_results, dict) else None
         
         if not actionable_okrs_dict or not isinstance(actionable_okrs_dict.get("okrs"), list):
             return gr.update(value="Nessun OKR trovato nei risultati della pipeline (o dati in formato imprevisto).")
@@ -236,14 +252,16 @@ class AgenticHandlers:
             return gr.update(value="Nessun OKR generato.")
 
         kr_id_to_indices = {}
-        # Similar issue here: all_krs_for_selection_list could be a string representation of a list.
-        if isinstance(all_krs_for_selection_list, list):
-            for kr_info in all_krs_for_selection_list:
-                if isinstance(kr_info, dict): # defensive check
+        if isinstance(parsed_krs_for_selection_list, list): # Ensure it's a list before iterating
+            for kr_info in parsed_krs_for_selection_list:
+                if isinstance(kr_info, dict) and 'unique_kr_id' in kr_info and 'okr_index' in kr_info and 'kr_index' in kr_info:
                     kr_id_to_indices[kr_info['unique_kr_id']] = (kr_info['okr_index'], kr_info['kr_index'])
-        
+                else:
+                    logging.warning(f"Skipping invalid kr_info item: {kr_info}")
+
         selected_krs_by_okr_idx = defaultdict(list)
-        if selected_kr_unique_ids: 
+        # selected_kr_unique_ids comes directly from CheckboxGroup, should be a list of strings/values
+        if isinstance(selected_kr_unique_ids, list): 
             for kr_unique_id in selected_kr_unique_ids:
                 if kr_unique_id in kr_id_to_indices:
                     okr_idx, kr_idx_in_okr = kr_id_to_indices[kr_unique_id]
@@ -293,7 +311,7 @@ class AgenticHandlers:
                     self.key_results_for_selection_st      
                 ],
                 outputs=[self.okrs_components['okr_detail_display_md']],
-                api_name="update_okr_display_on_kr_selection"
+                api_name="update_okr_display_on_kr_selection" # Keep api_name for Gradio
             )
             logging.info("Agentic OKR selection handler setup complete.")
         else: